[00:05:20] (03CR) 10Jforrester: [C: 04-1] "Hmm. We've been very consistent in using "insert " in all our dialogs as a design decision. I think breaking this here feels wrong" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150018 (owner: 10Amire80) [00:07:39] (03CR) 10Jforrester: [C: 032] Remove old message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149855 (owner: 10Esanders) [00:08:46] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] Fix camel-casing of countNonInternalElements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148657 (owner: 10Esanders) [00:09:17] (03Merged) 10jenkins-bot: Remove old message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149855 (owner: 10Esanders) [00:09:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf16]Cannot srcoll up/down a page in mobile when the keyboard is open and cursor active on CE - 10https://bugzilla.wikimedia.org/68828 (10Rummana Yasmeen) [00:09:44] James_F, so I found https://www.mediawiki.org/wiki/Manual:Collapsible_elements [00:10:11] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Fix camel-casing of countNonInternalElements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148657 (owner: 10Esanders) [00:11:25] Krenair: Yeah, that's I think what it should be. [00:11:45] Krenair: Something in ?VPT sends a "hey you, kill yourself" message to gadgets to stop them breaking VE. [00:12:02] James_F, VE doesn't really seem to care that this is shown as collapsible [00:12:15] Krenair: Something else in VPT (or wherever) says "hey you, come back", but maybe it's not working. [00:12:15] no collapse/expand button, expanded always [00:12:24] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf16]Cannot srcoll up/down a page in mobile when the keyboard is open and cursor active on CE - 10https://bugzilla.wikimedia.org/68828#c1 (10Rummana Yasmeen) This is also happening while scrolling down the link suggestions inside link inspector. [00:12:37] Krenair: Yeah, that's intentional. /Maybe/ we could trust a few gadgets to run inside VE's surface, but… [00:13:25] no way to change whether it's collapsible either (can't modify class attribute of
in VE, AFAICT) [00:14:23] And we do have ve.activate and ve.deactivate hooks that are fired which gadgets could listen for [00:15:06] But we also fix sortable and things like that, don't we? [00:16:11] (03PS3) 10Jforrester: Update VE core submodule to master (61dea59) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148659 (owner: 10Esanders) [00:16:27] (03CR) 10Jforrester: [C: 032] Use native style property names instead of jQuery's css map [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150266 (owner: 10Krinkle) [00:17:42] Krenair: James_F: navbox code should use the 'wikipage.content' mw.hook, to have the JS reinstated after the page is saved [00:17:54] (03Merged) 10jenkins-bot: Use native style property names instead of jQuery's css map [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150266 (owner: 10Krinkle) [00:17:59] Thanks MatmaRex. [00:18:13] and that [00:18:17] i believe VE implements its half correctly [00:18:27] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (61dea59) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148659 (owner: 10Esanders) [00:18:28] unless you want the collapsing to work during editing? hmm… [00:18:54] MatmaRex: I'm not sure that'd be /terrible/, but… it might break things oddly? [00:18:59] James_F, re: sortable, I don't think we handle sortable tables either. [00:19:13] Krenair: We certainly disable it on activate, don't we? [00:19:27] James_F: yeah. i don't think it would even work, with the shield/focusables/whatever-the-blue-translucent-thingies-are-called [00:19:52] No reference to 'sortable' directly that I see... [00:20:11] (03Merged) 10jenkins-bot: Update VE core submodule to master (61dea59) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148659 (owner: 10Esanders) [00:20:17] Krenair: sortable tables are handled in core [00:20:28] resources/src/mediawiki.page/mediawiki.page.ready.js [00:20:32] they use the 'wikipage.content' hook [00:21:11] core collapsibility solution (jquery.makeCollapsible) is also handled there, actually [00:21:41] MatmaRex, I mean VE just shows sortable tables as any other table [00:22:05] is there a way to compare two chunks of model ? Not sure ve.compare is suitable [00:22:08] Yeah, we don't really want tables being re-sorted mid-edit accidentally. [00:22:14] You can't make a table sortable with VE, or make it non-sortable. It's not shown in the UI whether it's sortable or not [00:22:23] Krenair: Yet. :-) [00:22:33] mooeypoo: Isn't there a .getComparableObject thing in DM? [00:22:52] I saw it in annotations, didn't see it in the document model itself.. not sure if I missed something [00:23:13] Ah, maybe it's just for annotations. [00:23:17] * James_F is freelancing. :-) [00:23:54] yeah, it seems to be annotation-only [00:23:55] hmmm [00:24:58] RoanKattouw, I'm trying to check if a caption surface data changed at a given moment. I can't really compare just the 'getText()' part becaues then I'm missing things like references or internallist stuff... but comparing the two ve.dm.Document() objects straight up won't work either. Do you know how that might be possible? [00:25:07] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf16] Cannot scroll up/down a page in mobile when the keyboard is open and cursor active on CE - 10https://bugzilla.wikimedia.org/68828 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [00:25:46] RoanKattouw, or maybe I can compare the data itself, that's a "simple" object. [00:25:51] would that work with ve.compare ? [00:25:59] Krenair: hmm, fascinating, https://en.wikipedia.org/wiki/MediaWiki:Common.js seems to have code to do navboxes after VE page is saved (using that mw.hook) [00:26:04] i wonder why it doesn't work [00:26:18] (or maybe it does, but no one updated the bug?…) [00:26:45] bug was filed on the 19th [00:27:02] no changes to that page since the 10th [00:27:42] hm… somebody is going to have fun debugging ten-year-old crappy onwiki JS, then :P [00:28:57] good night [00:29:04] Heh. I don't think I want to be the next WMF person to alter that page. :p [00:30:11] Psh. :-) [00:32:32] mooeypoo: I would recommend just looking at the captionSurface's document's completeHistory.length [00:33:40] RoanKattouw, oh, I went with comparing the data elements [00:33:41] not good? [00:33:50] Ugh [00:34:03] No I think that will explore if there are originalDomElements in there [00:34:24] Like, try putting some s in your caption [00:34:35] (with text in them) [00:34:40] *will explode [00:34:59] Also, we do the same thing in the reference dialog: if the document has history, assume that it changed and is save-able [00:37:16] hmmm [00:37:32] RoanKattouw, the problem I saw in the reference dialog is that it checks if the surface is empty [00:37:36] (03PS3) 10Catrope: Remove redundant setting of title in link nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149524 (owner: 10Esanders) [00:37:44] mooeypoo: Well there's that too [00:37:47] There's two things [00:37:54] It listens for a transact even to un-disable the apply changes button [00:38:03] (03PS2) 10Alex Monk: Don't show PostEdit message if we made a null edit. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150419 (https://bugzilla.wikimedia.org/51243) [00:38:10] (Which, ideally that would be smarter with the undo stack, but whatever) [00:38:20] And it also tries to refuse to let you save an empty reference [00:38:26] But for images, empty captions are allowed, right? [00:38:40] (I guess we still want to detect them for special treatment though?) [00:39:33] (03CR) 10jenkins-bot: [V: 04-1] Remove redundant setting of title in link nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149524 (owner: 10Esanders) [00:39:41] yep [00:39:55] (03CR) 10Jforrester: [C: 032] Don't show PostEdit message if we made a null edit. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150419 (https://bugzilla.wikimedia.org/51243) (owner: 10Alex Monk) [00:40:24] 3VisualEditor / 3MediaWiki integration: VisualEditor: If making a null change, the "Your edit was saved" message appears, even if there were no changes and so it wasn't - 10https://bugzilla.wikimedia.org/51243 (10James Forrester) 5PATC>3RESO/FIX [00:40:35] RoanKattouw, I'm not sure you're going to like what I'm doing, but I think that in general we're going to need some better way to check if an image actually changed (which right now is relatively rudimentary) - I was waiting for the new media dialog to do that fully [00:40:51] but now there's this bug that i'm fixing, so this is going to be a bit of a patchy fix. [00:41:15] James_F, actually it sounds like this bug could be valid for core's collapsible stuff [00:41:22] Krenair: Potentially. [00:41:23] (03CR) 10Catrope: [C: 04-1] Remove redundant setting of title in link nodes (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149524 (owner: 10Esanders) [00:41:28] Needs clarification from creator, language unclear etc. [00:41:32] (03PS3) 10Catrope: Don't show PostEdit message if we made a null edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150419 (https://bugzilla.wikimedia.org/51243) (owner: 10Alex Monk) [00:42:05] TrevorParscal, are you planning to deprecate custom styling of widgets in VE, I'm looking at .ve-ui-fragmentInspector-form rule in particular now, I want to style link inspector in ooui, but this gets in my way [00:42:06] Um. [00:42:11] Argh [00:42:13] f u gerrit [00:42:29] RoanKattouw, I think you took an old PS and changed its commit message [00:42:33] Yes [00:42:42] Because I hadn't reloaded the Gerrit tab after you amended [00:42:49] And gerrit sucks. [00:43:01] custom styling of widgets... I don't think it's bad, but it's usually a sign that the widget needs some sort of additional option [00:43:06] (03PS4) 10Catrope: Don't show PostEdit message if we made a null edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150419 (https://bugzilla.wikimedia.org/51243) (owner: 10Alex Monk) [00:43:12] or the layout does [00:43:28] (03CR) 10Catrope: [C: 032] Don't show PostEdit message if we made a null edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150419 (https://bugzilla.wikimedia.org/51243) (owner: 10Alex Monk) [00:45:10] (03Merged) 10jenkins-bot: Don't show PostEdit message if we made a null edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150419 (https://bugzilla.wikimedia.org/51243) (owner: 10Alex Monk) [00:47:22] 3VisualEditor / 3MediaWiki integration: VisualEditor: The show/hide text a collapsed navbox disappear afted have edited - 10https://bugzilla.wikimedia.org/68279#c2 (10Alex Monk) Gabrasca: Could you clarify what you mean please? Some of the language in this bug is unclear. It sounds as if some of this might b... [00:50:17] RoanKattouw, completeHistory.length gives me 0 [00:50:35] hm... wait. I'm doing it wrong [00:51:27] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16098 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16098&action=e... [00:54:48] mooeypoo: If it's zero then nothing was changed [00:57:19] RoanKattouw, yeah I was accidentally trying to read the node's history instead of the actual surface's history [00:57:30] mooeypoo: You need to read the dm.Document's history [00:57:45] But there's also something called documentNode so maybe that's confusing you? [01:01:41] no, I'm just not having much luck getting the document history from the surface [01:02:17] this.captionSurface.getSurface().getModel() is not quite what I expect; no completeHistory there, and .getHistory() doesn't help, it outputs several arrays with length 1 [01:02:49] this.captionSurface.getModel().getDocument().hasBeenModified() [01:03:05] Sorry, no [01:03:07] and then there is this.captionSurface.getSurface().getModel().documentModel.completeHistory.length [01:03:09] but that's just nasty [01:03:13] this.captionSurface.getModel().hasBeenModified() [01:03:30] oh [01:03:35] Which is slightly different but fundamentally does what you want [01:03:56] no, I'm getting "undefined is not a function" [01:03:57] oh [01:04:02] wait, that's because we're missing "getSurface" in there [01:04:13] Oh [01:04:17] this.captionSurface is a SurfaceWidget, not a Surface [01:04:19] Right [01:04:21] Damn you Trevor [01:04:35] This isn't the first time I've fallen into that trap [01:04:47] this.captionSurface.getSurface().getModel().hasBeenModified() [01:05:02] that works [01:05:03] yeesh [01:05:53] Yeah [01:08:47] RoanKattouw, TrevorParscal is there a way to check the status (enabled/disabled) of an action in a dialog? like this.actions.setAbilities( { 'insert': true, 'apply': true } ); only "get" instead of set? [01:09:07] I don't know, this code landed while I was on vacation [01:09:13] can I check if 'apply' is currently enabled, is what i'm trying to figure out [01:09:17] hasAbilities would be a nice function [01:09:21] hasAbility [01:09:33] well, the ability is there, just disabled [01:09:43] but I guess that means it's no longer there [01:09:54] O.O this is very confusing [01:10:00] disabled means it doesn't have the ability [01:10:10] anywyas, yes, so.. any way to check if the "apply" button is enabled at a given moment, TrevorParscal ? :\ [01:10:11] the point is you are setting the ability or not [01:10:34] ok, so the reason it's not there is that you shouldn't do it that way [01:10:42] I thought ability was the point of having buttons, then stating whether they're available. I see what you mean [01:10:51] you need to use the same logic you used to set the abilities to check them [01:11:02] don't set them, then treat the ActionSet as a model [01:11:16] TrevorParscal, it's going to be one big messymess otherwise in the media dialog :\ [01:11:19] okay, here's the issue: [01:11:31] abstract the "should I be able to apply or not" into a function that can be called whenever you like [01:11:37] The media dialog starts with 'apply' disabled, and waits for the user to make their move [01:11:43] yes [01:11:51] the user changed anything -- the dialog knows "I was changed" and the apply is enabled [01:12:00] (03PS1) 10JGonera: Restyle agora theme for mobile after window refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/150460 [01:12:17] the problem is that I am not keeping track of whether the user changed things *back* to what the image *was before* because the changes can be interconnected and complex [01:12:30] so I did this as sort of "clicked a button --> change" [01:12:37] which is not ideal, but I knew that we're going to have a new dialog soon [01:12:57] so, there should be a this.modified property, which you happen to use setAbilities( { 'apply': this.modified } ) with [01:13:18] *now* we have a small issue with the caption; if a user types into a caption the apply button is on -- but then if the user undos, the caption goes back to being the original but the apply button is still on. So I want to revert it, but I need to know if the apply is on or off first [01:13:26] because if there were *other* changes, he apply should still be on [01:13:27] my point is, don't use ActionSet to store state, store it locally and sync it to ActionSet [01:13:39] hmm [01:13:53] yeah, this.modified is going to be a mess in the dialog [01:14:01] abstract it in a method [01:14:01] I can add it in, but it's not as simple as a boolean [01:14:04] isModified [01:14:05] and touch() [01:14:20] well, it's more about comparing the entire thing backwards to the entire initial state [01:14:21] and within those methods you can check various things [01:14:23] and there are so many details. [01:14:28] i guess i have to. [01:14:32] sounds like method time [01:14:36] * mooeypoo nods [01:14:44] i gotta feed the kids din din, sorry [01:14:55] I will be happy to cont. this convo tomorrow [01:14:59] I was hoping to deal with this properly in the new iteration where we actually can work with something more robust to compare the model to the initial model [01:15:03] * mooeypoo nods [01:15:05] hope you are having a nice evening [01:15:07] have fun and thanks TrevorParscal [01:15:23] TrevorParscal: BTW have a look at https://gerrit.wikimedia.org/r/#/c/150460/ [01:15:24] mooeypoo: what you want is a state hash [01:15:28] * mooeypoo nods [01:15:29] you build a [01:15:38] unique hash string that represents the state [01:15:54] like, a serialization of the caption + title + size + ... etc [01:15:56] then compare it [01:16:03] And I can ask the model for it... yes! [01:16:09] (03PS1) 10JGonera: Make scrolling in PanelLayout smoother on iOS [oojs/ui] - 10https://gerrit.wikimedia.org/r/150461 [01:16:23] TrevorParscal, okay, gotcha. That sounds great. I'll work on that! Thanks! [01:16:25] when the user returns to the previous state, even if they do so in 10000 steps, it will always reliably show it's the same [01:16:28] :) [01:16:30] have fun [01:16:40] awesomesauce, have a great evening [01:16:42] thanks :) [01:52:57] * mooeypoo snorts [01:53:00] you know you love the image model when "getDimensions" starts being auto-typed as "getDimentia" (even though that's a misspelling) [01:58:32] :-) [02:26:55] (03PS1) 10Catrope: Greatly simplify ve.ce.Surface#getSelectionRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150473 [02:31:06] meh [02:31:28] I'm getting a ve.compare( initialHash, currentHash) = false even though there's no difference between them. [02:31:32] whaaaat. [02:34:23] Why are you comparing hashes? [02:34:25] Or are they hash objects? [02:36:29] they're hash objects [02:36:34] OK [02:36:35] and I found out why.. my scalable pieces [02:36:48] i think I am comparing references instead of values. Just added ve.copy() to these [02:36:52] let's see if that solves it [02:37:04] I don't think it will [02:37:17] Look, reference comparison makes things *more* likely to be considered equal, not *less* [02:39:20] Meh. [02:39:40] now I'm getting an oojs error. "Uncaught TypeError: Cannot read property 'clone' of undefined " [02:40:00] for my scalable hash state method [02:40:10] wtf? [02:40:13] { originalDimensions: ve.copy( this.getOriginalDimensions() ) } [02:40:17] Do you have undefineds in there somewhere? [02:40:23] Or is this.getOriginalDimensions() undefined? [02:40:30] it .. shouldn't... be [02:40:34] * mooeypoo verifies [02:40:44] (03CR) 10Jforrester: [C: 031] "Tested in desktop Safari, Firefox and Chrome; seems to work fine." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150473 (owner: 10Catrope) [02:42:29] * mooeypoo mutters [02:44:00] ok, I got it. [02:47:42] RoanKattouw, to your question: yes. Yes it is, until it's fetched from the API. [02:50:02] OK [02:50:12] Well ve.copy() expects an array or object [02:50:17] It does not take kindly to being fed undefined [02:52:19] crap. This is annoying. My hash is different inherently, because in the beginning it won't have originalDimensions and maxDimensions (until they're fetched from the API) but when I check, the *new* hash I test against have them [02:52:46] so either I don't store those and can't check against that change, or I have to check for size changes separately [02:53:18] or I check each value in the object separately. [02:53:23] * mooeypoo blames salable [02:53:27] it all comes down to the scalable. [02:56:13] mooeypoo: What are you trying to *accomplish* ? [02:56:48] RoanKattouw, feats. [02:56:51] More to the point: [02:57:35] I want the media dialog to know whether it was changed or not. If it was changed, activate the 'insert' or 'apply' button. If it wasn't changed, deactivate them. This is somewhat tricky because there are so many conditions and codependent attribues changing one another. [02:57:56] So, trevor suggested I create a hash, and I did that in the image model. Then I realized I need to store the size too, because that can change, so I created one for the scalable. [02:58:03] And I check the caption surface separately. [02:58:13] So, hold on [02:58:18] originalDimensions *can't be changed* [02:58:23] So they need not be in the hash, rihgt? [02:58:34] Now -- every click or change, the method checks first if the cpation surface changed, then if the other attributes changed [02:58:57] Well, I guess not. If that changes, the rest of the attributes change too [02:59:00] That's a good point. [02:59:10] .... actually, that's a really good point. [02:59:17] but then, most other things can't change either [02:59:59] okay, you have a point there. I recreate the hash *anyways* every time we recreate the model (whcih means that if I switch an image, which is what I was mostly worried about, I create a new hash anyways) [03:00:06] and "reset" the check [03:00:09] hm. [03:00:46] okay, no. Not really. I could have this scenario: User starts with image A, does nothing other than changin image to B and leaves the dimensions exactly the same. [03:01:03] Well you should probably record which image is being used? [03:01:06] Like, that's a change [03:01:08] Image changed, but all other attributes are the same. So... I need source. But I guess I can live without originalDimensions [03:01:13] right [03:01:13] Yeah [03:01:26] You should use attributes that are as close to the actual changes as possible, not derived ones [03:01:26] and maxdimensions, too. If those change, the image itself changed. [03:01:34] And then get like a minimal spanning set [03:01:39] * mooeypoo nods [03:01:41] good point [03:01:50] Right yeah [03:02:06] So actual and max are essentially derived, so the user can't edit them directly, so you don't need to check them [03:02:20] so, bsaically, I just need 'currentDimensions' and 'isDefault' from the scalable [03:02:31] Yeah [03:02:35] everything else is derived or taken from the API [03:02:39] Which, really, you probably don't really want to do the scalable hash object thing [03:02:57] true. I thought it would be a full thing, but if it's just those two, i can do without. [03:03:01] Because what you're interested in is a rather arbitrary set of attributes from the scalable's point of view [03:03:06] Yeah that too [03:03:23] So you need those two, and a bunch of other non-scalable stuff? Like, alignment, type, border, source? [03:03:30] caption [03:03:55] caption is separate [03:04:04] caption is tested against the changes in the surface [03:04:08] like what we discussed before [03:04:18] so basically, source, alignment, border, etc. [03:04:21] all the things the user can change [03:04:57] src, altText, type, alignment, sizeType, border, borderable [03:05:14] and then the two scalable objects. I think that should probably do it [03:05:45] Oh yes, altText [03:06:15] let me see if that works now. [03:15:19] \o/ [03:16:26] oh... no. [03:16:27] hm [03:18:01] mooeypoo: Tonight's a night of ups and downs for you, hmm? :-( [03:18:27] James_F, it's all Scalable's fault. [03:18:29] even when it isn't. [03:18:31] :D [03:18:58] mooeypoo: I blame Roan! :-) [03:19:45] hmmm [03:19:47] okay, so here's the problem now [03:19:59] apparently, text input emit "change" event on keystroke [03:20:19] so, I had to update the model with the new alternate text otherwise the new hash isn't representing it [03:21:05] BUT if I update the model *and* check "is there change in the model" for every 'change' event of the altText textbox, it does this + the comparison of the hashes every character I type. [03:21:22] RoanKattouw, ^^ how bad is this? :\ it feels terrible to me, but I may be thinking it's worse than it actually is. [03:21:38] I can, instead, call for the alt text value when I check change and add it to the new hash [03:21:55] that would work too, but then the hash doesn't necessarily represent the model completely at any given moment. [03:22:22] One thing you could do is check the alt text first [03:22:44] If the user is editing the alt text, then there can only be one keystroke out of a rapid succession for which the alt text *won't* be different [03:22:54] So, I shouldn't update it in the model on every change? [03:22:55] For all the others, it will be, and for those you can bypass checking everything else [03:22:59] hmmm [03:23:01] Well, it depends [03:23:09] You need not actually maintain this hash as a variable somewhere [03:23:20] You could instead compute it when you need it [03:23:27] Wasn't the text box widget 'change' event used to be emited only for actual change and not keydown/up [03:23:39] That should be true [03:23:47] It is computed only when I need it, but I call it on changes so it can revalidate [03:23:47] Simply moving arrows should not emit 'change' [03:23:52] But if you type, it changes [03:23:55] hmm. [03:24:16] So even if I don't update the model with each keystroke, the fact I check for changes to the model will STILL call the 'compare' method each time [03:24:19] change is emitted if basically any DOM event is observed on the textbox AND its value was different from last time we checkedl [03:24:52] btw, shouldn't you go home? I don't want to keep you [03:25:13] this isn't urgent, I think I'll continue working on this tomorrow too. I just noticed it's 11:30pm here. hah. [03:26:10] Yeah I should [04:01:14] (03PS1) 10Mooeypoo: Check for changes in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150478 (https://bugzilla.wikimedia.org/68058) [08:24:36] 3VisualEditor / 3MediaWiki integration: VisualEditor: Please add a button for reporting bugs to the Save dialog - 10https://bugzilla.wikimedia.org/68692#c5 (10Elitre) My second solution, then. Since that template doesn't probably exist elsewhere, my guess is we could copy it onto mediawiki and centralize tha... [09:32:56] (03PS28) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [09:32:59] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [09:37:28] (03PS29) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [09:37:31] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [09:40:20] (03PS1) 10Divec: Merge "Use native style property names instead of jQuery's css map" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150502 [09:40:53] (03CR) 10Divec: "Patchset 29: rebase" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [09:41:40] (03CR) 10jenkins-bot: [V: 04-1] Merge "Use native style property names instead of jQuery's css map" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150502 (owner: 10Divec) [09:43:05] (03CR) 10Divec: "Correction: Patchset 29 was not a rebase" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [09:45:06] (03PS30) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [09:45:35] (03CR) 10Divec: "Patchset 30: rebase" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [09:46:29] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [09:53:51] (03CR) 10Amire80: Bidi-isolate the version in the help panel (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) (owner: 10Amire80) [09:54:47] (03CR) 10Amire80: "I replied to the comment." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) (owner: 10Amire80) [09:55:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: version number in the help panel must be bidi-isolated - 10https://bugzilla.wikimedia.org/68688#c3 (10Amir E. Aharoni) 5RESO/FIX>3PATC It's not merged yet. [10:34:20] 3VisualEditor / 3MediaWiki integration: VisualEditor: The show/hide text a collapsed navbox disappear afted have edited - 10https://bugzilla.wikimedia.org/68279#c3 (10Gabrasca) Edit a page with VisualEditor, add a template written with navbox, save, the template added is uncollapsed and in the right corner o... [10:35:06] 3VisualEditor / 3Editing Tools: VisualEditor: Support "substituting" templates in transclusion dialog - 10https://bugzilla.wikimedia.org/49904#c7 (10Sunpriat) Not only in insert dialogue. Template text should be inserted and rerendered page immediately. for example: -[[:en:Template:Accent]] -[[:ru:Шаблон:Уда... [10:56:51] hey [10:56:57] this thing popped out on plwiki [10:57:10] all links in VE have the same css classes? [10:57:33] we'd like to be able to mark redirects with a different color [10:58:14] while reading they have .mw-redirect and there's a gadget for coloring them [11:13:26] Hi everybody! I'm trying to learn the OO JS and OOJ UI Framework/API. Can you tell me the current state of the codebase? Is it stable enough for third party use? Or would you not recommend building extension user interfaces upon it? [11:14:32] (03CR) 10Esanders: Remove redundant setting of title in link nodes (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149524 (owner: 10Esanders) [11:15:24] (03PS4) 10Esanders: Remove redundant setting of title in link nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149524 [11:19:13] (03CR) 10Krinkle: "Eh... I think you did a rebase or cherry-pick and then ran git-commit--amended at the end instead of git-rebase--continue or git-commit. " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150502 (owner: 10Divec) [11:22:43] ah, it's here [11:22:43] https://bugzilla.wikimedia.org/show_bug.cgi?id=61072 [11:22:45] osnard: OOjs is a stable code base that has had a 1.0 release and is following semver. [11:23:36] osnard: OOjs UI is still in flux (pre 1.0). however it is well-documented, and if you take care to follow the release notes /git log we do mark any breaking changes as such. [13:01:43] Krinkle: Thank you. [13:07:50] (03PS3) 10Esanders: Create a WhitespaceTextInputWidget and use in CommentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150276 [13:08:08] (03PS1) 10Esanders: Use whitespace preserving text input in extension inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150543 [13:09:11] (03CR) 10jenkins-bot: [V: 04-1] Use whitespace preserving text input in extension inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150543 (owner: 10Esanders) [13:14:59] (03PS1) 10Esanders: Use extension name in context menu for alien extensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150544 [13:34:48] James_F, good morning! you're up early [13:37:07] 3VisualEditor / 3ContentEditable: VisualEditor: Phantoms are appearing at wrong place while selecting an image after making it fullsize - 10https://bugzilla.wikimedia.org/62284#c7 (10Moriel Schottlender) I can't replicate this. I think this was fixed after the refactor of the phantoms. [14:04:09] (03PS1) 10Vikassy: [BrowserTest] Language screenshots will not have scrollbars [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150553 [14:47:34] (03CR) 10Krinkle: Create a WhitespaceTextInputWidget and use in CommentInspector (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150276 (owner: 10Esanders) [14:52:24] (03PS4) 10Esanders: Create a whitespace preserving TextInputWidget and use in CommentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150276 [15:33:36] 3VisualEditor / 3MediaWiki integration: VisualEditor: The show/hide text a collapsed navbox disappear afted have edited - 10https://bugzilla.wikimedia.org/68279#c4 (10Alex Monk) Hm.. Doesn't seem to happen with MW's built-in collapsible functionality. And obviously enwiki's navbox (and related JS gadgets) is... [15:42:58] (03CR) 10Eranroz: Bidi-isolate the version in the help panel (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) (owner: 10Amire80) [15:47:06] 3VisualEditor / 3ContentEditable: VisualEditor: Cursoring off the page with left/right doesn't scroll the cursor in to view - 10https://bugzilla.wikimedia.org/58038 (10Bartosz Dziewoński) [15:47:12] 3VisualEditor / 3Data Model: VisualEditor: Investigate parsing/rendering/behavior of "{{MW 1.23}}" on mediawiki.org [mini-tracking] - 10https://bugzilla.wikimedia.org/68297#c4 (10Bartosz Dziewoński) Let's turn this into a mini tracking bug, then? I split off the Parsoid issue to bug 68862, together with VE b... [15:47:12] 3VisualEditor / 3ContentEditable: VisualEditor: Remove media or templates, page loses focus - 10https://bugzilla.wikimedia.org/68708 (10Bartosz Dziewoński) [15:47:12] 3VisualEditor / 3ContentEditable: VisualEditor: Character duplication in paragraphs following the {{lang-it}} template (and others?) - 10https://bugzilla.wikimedia.org/68733 (10Bartosz Dziewoński) [15:47:53] 3VisualEditor / 3Data Model: VisualEditor: Investigate parsing/rendering/behavior of "{{MW 1.23}}" on mediawiki.org [mini-tracking] - 10https://bugzilla.wikimedia.org/68297 (10Bartosz Dziewoński) [15:47:53] 3VisualEditor / 3ContentEditable: VisualEditor: Cursoring off gallery into slug scrolls viewport to the top of the document, not the slug - 10https://bugzilla.wikimedia.org/68589 (10Bartosz Dziewoński) [16:16:37] 3VisualEditor: VisualEditor: Set up an IRC bot in #mediawiki-visualeditor to report visualeditor-needcheck edits on WMF wikis - 10https://bugzilla.wikimedia.org/62860#c5 (10Elitre) @Alex, that filter doesn't seem to be catching anything, I have no idea if it's still functional or not, that's why I asked. [16:19:13] ... What? [16:19:26] What filter? [16:20:42] James_F, any idea what Elitre is talking about on that bug? [16:29:18] (03CR) 10Jforrester: [C: 031] Create a whitespace preserving TextInputWidget and use in CommentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150276 (owner: 10Esanders) [16:30:33] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=105824461 [16:30:33] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=39694308 [16:30:33] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=39696565 [16:30:33] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=64516412 [16:30:33] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=64516612 [16:38:36] (03CR) 10Jforrester: [C: 032] Use extension name in context menu for alien extensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150544 (owner: 10Esanders) [16:39:12] (03PS1) 10Krinkle: demos: Add right-aligned menu in toolbar demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/150574 [16:40:19] (03Merged) 10jenkins-bot: Use extension name in context menu for alien extensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150544 (owner: 10Esanders) [16:47:48] (03PS1) 10Krinkle: demos: Limit page width to not include infinite auto margin [oojs/ui] - 10https://gerrit.wikimedia.org/r/150578 [16:49:18] (03PS2) 10Krinkle: demos: Limit page width to not include infinite auto margin [oojs/ui] - 10https://gerrit.wikimedia.org/r/150578 [17:01:06] 3VisualEditor / 3MediaWiki integration: VisualEditor: The show/hide text a collapsed navbox disappear afted have edited - 10https://bugzilla.wikimedia.org/68279#c5 (10Gabrasca) I tried on itwiki, in a personal sandbox with a navbox (example discography of a band).(In reply to Alex Monk from comment #4) > Hm.... [17:11:12] (03Abandoned) 10Krinkle: demos: Limit page width to not include infinite auto margin [oojs/ui] - 10https://gerrit.wikimedia.org/r/150578 (owner: 10Krinkle) [17:12:01] (03CR) 10Krinkle: [C: 032] MWMediaSearchWidget: Use json/jsonp for local/foreign api respectively [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150054 (https://bugzilla.wikimedia.org/64822) (owner: 10Mooeypoo) [17:13:43] (03Merged) 10jenkins-bot: MWMediaSearchWidget: Use json/jsonp for local/foreign api respectively [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150054 (https://bugzilla.wikimedia.org/64822) (owner: 10Mooeypoo) [17:17:22] 3VisualEditor / 3Editing Tools: VisualEditor:Inserting image gives error : Uncaught TypeError: Property 'jQuery18302923649437725544_1386807070459' of object [object Object] is not a function - 10https://bugzilla.wikimedia.org/58364#c5 (10Krinkle) 5RESO/WOR>3RESO/DUP This is actually still happening. It i... [17:17:23] 3VisualEditor / 3Editing Tools: VisualEditor: Console shows "TypeError: jQuery_xxxxx is not a function" when cross-domain ajax request is aborted - 10https://bugzilla.wikimedia.org/59604#c17 (10Krinkle) *** Bug 58364 has been marked as a duplicate of this bug. *** [17:17:51] mooeypoo: https://bugzilla.wikimedia.org/show_bug.cgi?id=67749#c4 [17:17:52] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] TypeError: Cannot read property 'context' of undefined appears when you try to insert another image that appears on the same index as the previous search, right after you inserted one - 10https://bugzilla.wikimedia.org/67749#c4 (10Krinkle) (In... [17:18:23] (03CR) 10Catrope: [C: 032] Create a whitespace preserving TextInputWidget and use in CommentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150276 (owner: 10Esanders) [17:19:48] (03Merged) 10jenkins-bot: Create a whitespace preserving TextInputWidget and use in CommentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150276 (owner: 10Esanders) [17:21:03] (03CR) 10Catrope: [C: 032] Remove redundant setting of title in link nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149524 (owner: 10Esanders) [17:21:24] 3VisualEditor: VisualEditor: Set up an IRC bot in #mediawiki-visualeditor to report visualeditor-needcheck edits on WMF wikis - 10https://bugzilla.wikimedia.org/62860#c6 (10Alex Monk) What filter? [17:21:34] (03PS6) 10Amire80: Bidi-isolate the version in the help panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) [17:22:51] (03Merged) 10jenkins-bot: Remove redundant setting of title in link nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149524 (owner: 10Esanders) [17:24:10] (03CR) 10Amire80: Bidi-isolate the version in the help panel (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) (owner: 10Amire80) [17:35:37] Krinkle: https://gerrit.wikimedia.org/r/#/c/114899/ was the WIP change from Trevor. [17:36:55] (03PS7) 10Jforrester: Bidi-isolate the version in the help panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) (owner: 10Amire80) [17:37:51] (03CR) 10Jforrester: [C: 032] "+2'ing per LE team advice." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) (owner: 10Amire80) [17:38:14] (03PS6) 10Esanders: WIP Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) [17:39:03] (03CR) 10jenkins-bot: [V: 04-1] WIP Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [17:39:31] (03Merged) 10jenkins-bot: Bidi-isolate the version in the help panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) (owner: 10Amire80) [17:44:36] 3VisualEditor / 3MediaWiki integration: VisualEditor: version number in the help panel must be bidi-isolated - 10https://bugzilla.wikimedia.org/68688#c5 (10James Forrester) 5PATC>3RESO/FIX Now it is. :-) [17:55:09] (03PS7) 10Esanders: Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) [17:55:56] (03CR) 10jenkins-bot: [V: 04-1] Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [17:58:50] edsanders: so what's your plan visa vi Paris on Monday/Tuesday? [18:02:48] TrevorParscal, quite probably not going to be there [18:04:03] Krinkle was thinking of going too [18:04:23] assuming we could get things booked at reasonable rates and things could work out [18:04:51] edsanders: is it a scheduling thing, or a cost of last minute tickets/rooms thing? [18:10:39] How long is the train ride? [18:10:45] 2 hours [18:10:47] and change [18:11:08] 3VisualEditor / 3Editing Tools: VisualEditor: Only the first one of the newly added references is appearing in re-use existing reference dialog - 10https://bugzilla.wikimedia.org/68869 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Add a reference (B... [18:18:10] Reasonable rates and booking now don't go together, I'm afraid. [18:19:05] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf15] Only the first one of the newly added references is appearing in re-use existing reference dialog - 10https://bugzilla.wikimedia.org/68869 (10Rummana Yasmeen) [18:19:10] edsanders: Dude, stage slugs is non-WIP now?!! [18:19:21] RoanKattouw: Inorite? :-) [18:20:07] divec: What is https://gerrit.wikimedia.org/r/#/c/150502/ ? Can it be thrown away in favor of PS30 of the unicorn change? [18:21:26] RoanKattouw, it's not perfect but it's better from David's POV [18:22:02] just saw a minor bug in that if you paste in the slug, it stays in staging until you do something else [18:25:21] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000#c4 (10Rummana Yasmeen) 5RESO/FIX>3REOP This is happening again (!) in Betalab... [18:26:43] TrevorParscal: https://gerrit.wikimedia.org/r/149625 https://gerrit.wikimedia.org/r/144505 (read comments for that one) https://gerrit.wikimedia.org/r/150473 https://gerrit.wikimedia.org/r/150461 https://gerrit.wikimedia.org/r/150460 https://gerrit.wikimedia.org/r/150574 [18:30:09] hrm [18:36:36] (03CR) 10Catrope: POC DONTMERGE: Unicorn (035 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [18:43:36] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000#c5 (10Moriel Schottlender) I can't manage to reproduce this in master or in beta... [18:44:22] ryasmeen, you want to go over this bug? I can't reproduce it? ^^ [18:45:28] The behavior can be a little confusing, but as far as I can tell that's the intended behavior, unless I'm missing the bug. [18:50:16] Krinkle|detached: Could you review https://gerrit.wikimedia.org/r/150001 ? [18:52:36] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the toolbar for Mobile VE also scrolls down when you try to scroll down the page having a node selected - 10https://bugzilla.wikimedia.org/67390 (10Roan Kattouw) 5PATC>3RESO/FIX [18:56:22] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot include the same existing reference after adding it once in an article - 10https://bugzilla.wikimedia.org/68582#c1 (10Roan Kattouw) a:3Alex Monk Sounds like an OptionWidget/SelectWidget thing? Clear the selection when reopening the dialog? [19:04:37] 3VisualEditor / 3Editing Tools: VisualEditor: Opening the link inspector and then closing, while selecting an image moves the image to the previous position - 10https://bugzilla.wikimedia.org/68762#c1 (10Roan Kattouw) 5NEW>3ASSI p:5Unprio>3Normal a:3Bartosz Dziewoński This is almost certainly becau... [19:06:53] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf15] Only the first one of the newly added references is appearing in re-use existing reference dialog - 10https://bugzilla.wikimedia.org/68869#c1 (10Roan Kattouw) 5NEW>3ASSI p:5Unprio>3High a:3Alex Monk Could it be that the list of refere... [19:09:06] 3VisualEditor / 3Mobile: VisualEditor Mobile: references context selection is wonky - 10https://bugzilla.wikimedia.org/67433#c1 (10James Forrester) 5ASSI>3RESO/FIX Looks like this is now fixed thanks to Juliusz's new context menu changes. [19:09:21] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the context menu of previously selected link is appearing upon placing the cursor in a different position in the document - 10https://bugzilla.wikimedia.org/67637#c2 (10James Forrester) 5ASSI>3RESO/FIX I think this is now fixed too. [19:10:05] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] The highlights of the nodes are appearing over the toolbar menu - 10https://bugzilla.wikimedia.org/68198#c1 (10James Forrester) 5ASSI>3RESO/FIX To check… [19:12:37] (03CR) 10Trevor Parscal: [C: 032] Reduce bottom margin of reference names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149625 (owner: 10Esanders) [19:13:06] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195#c1 (10James Forrester) 5ASSI>3RESO/FIX Fixed. [19:14:42] (03Merged) 10jenkins-bot: Reduce bottom margin of reference names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149625 (owner: 10Esanders) [19:17:09] (03CR) 10Jforrester: [C: 031] Make scrolling in PanelLayout smoother on iOS [oojs/ui] - 10https://gerrit.wikimedia.org/r/150461 (owner: 10JGonera) [19:17:37] Krenair: why are you using pointer-events: none in https://gerrit.wikimedia.org/r/#/c/144505/7/modules/ve-mw/ui/dialogs/ve.ui.MWWikitextSwitchConfirmDialog.js ?? [19:20:37] 3VisualEditor / 3Mobile: VisualEditor Mobile: Switching tabs in mobile safari often causes page to refresh causing data loss of session changes - 10https://bugzilla.wikimedia.org/68017#c1 (10James Forrester) s:5critic>3major a:3Juliusz Gonera This is "normal" behaviour from Safari, but we need to inves... [19:20:54] (03CR) 10Trevor Parscal: [C: 032] Greatly simplify ve.ce.Surface#getSelectionRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150473 (owner: 10Catrope) [19:21:22] Roan suggested we have a blocking overlay (which would stop interaction with the page). See comments (in gerrit and bugzilla) [19:21:47] RoanKattouw: hmm. want to talk to me about AnnotationInspector? [19:21:50] I found pointer-events:none; would pretty much achieve that [19:22:08] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot type the reference name inside Re-use existing reference dialog unless select a reference from that dialog - 10https://bugzilla.wikimedia.org/68824 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [19:22:17] (03Merged) 10jenkins-bot: Greatly simplify ve.ce.Surface#getSelectionRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150473 (owner: 10Catrope) [19:22:28] (03CR) 10Trevor Parscal: [C: 032] Make scrolling in PanelLayout smoother on iOS [oojs/ui] - 10https://gerrit.wikimedia.org/r/150461 (owner: 10JGonera) [19:23:27] (03Merged) 10jenkins-bot: Make scrolling in PanelLayout smoother on iOS [oojs/ui] - 10https://gerrit.wikimedia.org/r/150461 (owner: 10JGonera) [19:23:28] RoanKattouw: WHY does it apply any annotations at all in #getSetupProcess (which causes it to need to undo stupidity), and WHY does it mess around with the selection restoring so much? [19:23:29] (03CR) 10Trevor Parscal: [C: 032] Restyle agora theme for mobile after window refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/150460 (owner: 10JGonera) [19:23:34] RoanKattouw: can we kill these two things? [19:24:35] (03Merged) 10jenkins-bot: Restyle agora theme for mobile after window refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/150460 (owner: 10JGonera) [19:24:50] (03CR) 10Trevor Parscal: [C: 032] demos: Add right-aligned menu in toolbar demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/150574 (owner: 10Krinkle) [19:25:06] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf16] Cannot scroll up/down a page in mobile when the keyboard is open and cursor active on CE - 10https://bugzilla.wikimedia.org/68828#c2 (10James Forrester) 5ASSI>3RESO/FIX Beta Labs gremlins. [19:25:29] (03Merged) 10jenkins-bot: demos: Add right-aligned menu in toolbar demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/150574 (owner: 10Krinkle) [19:27:23] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High Juliusz's thoughts: Height of tabs not taken into account? Too many things going on at the same t... [19:27:55] Krenair: well, pointer-events: none isn't cross browser compatible, I don't see where you unset it, and a click block is all you need, a div, at the end of the body, absolutely positioned, top, bottom, left, right all 0 [19:30:10] Why would I unset it..? [19:30:26] This is for while we're preparing to move to a different page.... [19:31:21] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696#c3 (10James Forrester) Maybe fixed? [19:31:21] and we've reached the point of no return? [19:32:02] (i think yes) [19:32:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: The Remove button for the link inspector in mobile is not styled as Red - 10https://bugzilla.wikimedia.org/68194 (10James Forrester) 5ASSI>3RESO/FIX a:5Trevor Parscal>3Juliusz Gonera [19:33:44] Krenair: if you add a comment above the pointer-events: none lines, describing what they are meant to do, and that they don't work in IE <= 10 I will +2 [19:34:35] Sounds like I should use your
at the end of the body idea instead [19:34:37] 3VisualEditor / 3Editing Tools: VisualEditor: The reference name for a newly added reference is not appearing in the dialog for "Use existing reference" while opening it for the first time - 10https://bugzilla.wikimedia.org/67342 (10James Forrester) p:5Normal>3High a:3Alex Monk [19:34:54] that is the more dependable way to go [19:37:56] (03CR) 10Trevor Parscal: [C: 04-1] "Please use an absolutely positioned div at the end of the body as a click block instead of pointer-events: none on the body." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [19:38:53] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (3d8475c0b3) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150637 [19:42:30] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (3d8475c0b3) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150637 (owner: 10Jforrester) [19:45:23] (03CR) 10Catrope: [C: 032] "Fine. But we should really make removals across an internal list not fail." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149085 (owner: 10Esanders) [19:46:42] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (3d8475c0b3) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150637 (owner: 10Jforrester) [19:46:56] (03Merged) 10jenkins-bot: Fix expandRange( 'root' ) to not include the internal list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149085 (owner: 10Esanders) [19:47:23] Rooooooan [19:48:08] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot include the same existing reference after adding it once in an article - 10https://bugzilla.wikimedia.org/68582 (10James Forrester) [19:48:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf15] Only the first one of the newly added references is appearing in re-use existing reference dialog - 10https://bugzilla.wikimedia.org/68869 (10James Forrester) [19:48:08] 3VisualEditor / 3Editing Tools: VisualEditor: The reference name for a newly added reference is not appearing in the dialog for "Use existing reference" while opening it for the first time - 10https://bugzilla.wikimedia.org/67342 (10James Forrester) [19:51:35] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn gets added beside the comment, when inserting a whitespace after it. - 10https://bugzilla.wikimedia.org/68539#c6 (10Ritu Swain) (In reply to James Forrester from comment #5) > Sounds like it was fixed in wmf15 then. a bit confused, i can reproduce it in t... [19:52:21] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn gets added beside the comment, when inserting a whitespace after it. - 10https://bugzilla.wikimedia.org/68539#c7 (10James Forrester) Sorry, yes, I meant wmf16. My apologies! [20:02:59] TrevorParscal, I'll check tomorrow on the ticket prices [20:03:21] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696#c4 (10Rummana Yasmeen) 5ASSI>3RESO/FIX Yes, Cannot reproduce it from my end as well.Marking it as... [20:03:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10Rummana Yasmeen) 5RESO/?>3VERI [20:03:54] Have you guys sorted acommodation [20:04:24] edsanders: Yes [20:04:30] Booked a hotel like 3 weeks ago [20:04:54] can you accommodate Timo? We may have friends we can stay with [20:05:06] I can cuddle with Roan and Timo can have the other bed [20:05:21] nothin' wrong with a little snuggling [20:06:18] unfortunately my cousin who lives there has a TINY place, he refers to it as a "shoebox" appartment [20:06:36] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn gets added beside the comment, when inserting a whitespace after it. - 10https://bugzilla.wikimedia.org/68539#c8 (10Ritu Swain) thank you. just for future.. this is not the right forum .. but how can i find the release version of beta? if a bug is not re... [20:07:03] and my other closest family is in Tours, which is not going to be convenient :) [20:07:36] 3VisualEditor: VisualEditor: Set up an IRC bot in #mediawiki-visualeditor to report visualeditor-needcheck edits on WMF wikis - 10https://bugzilla.wikimedia.org/62860#c7 (10Elitre) The tag vepawns, i.e. : https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&tagfilter=vepawns . [20:08:51] 3VisualEditor: VisualEditor: Set up an IRC bot in #mediawiki-visualeditor to report visualeditor-needcheck edits on WMF wikis - 10https://bugzilla.wikimedia.org/62860#c8 (10James Forrester) (In reply to Elitre from comment #7) > The tag vepawns, i.e. : > https://en.wikipedia.org/w/index.php?title=Special: > Re... [20:11:04] It's choux box [20:12:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS, while opening the link inspector for the second time, the inspector gets zoomed making the inspector title overlapped with the browser tab - 10https://bugzilla.wikimedia.org/68197#c3 (10Rummana Yasmeen) 5ASSI>3RESO/FIX Cannot reproduce it anymore, mig... [20:12:57] edsanders: :-) [20:14:51] (03PS1) 10Jforrester: Update VE core submodule to master (5fdb204) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150692 [20:15:58] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (5fdb204) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150692 (owner: 10Jforrester) [20:16:19] (03CR) 10Catrope: [C: 032] ve.ui.AnnotationInspector: Allow content insertion without annotating [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149640 (owner: 10Bartosz Dziewoński) [20:16:26] (03PS2) 10Catrope: ve.ui.AnnotationInspector: Stop truncating fragments to 255 elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149646 (owner: 10Bartosz Dziewoński) [20:16:51] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (5fdb204) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150692 (owner: 10Jforrester) [20:16:53] (03CR) 10Catrope: [C: 032] ve.ui.AnnotationInspector: Stop truncating fragments to 255 elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149646 (owner: 10Bartosz Dziewoński) [20:17:01] Rooooooan [20:17:18] RoanKattouw: about AnnotationInspector. WHY does it apply any annotations at all in #getSetupProcess (which causes it to need to undo stupidity), and WHY does it mess around with the selection restoring so much? can we kill these two things? [20:17:21] 3VisualEditor / 3ContentEditable: VisualEditor: Snowman character gets triggered, when trying to insert a template with Comment edit dialog open. - 10https://bugzilla.wikimedia.org/68740#c16 (10Ritu Swain) Issue fixed in beta and test2 [20:17:35] (03Merged) 10jenkins-bot: ve.ui.AnnotationInspector: Allow content insertion without annotating [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149640 (owner: 10Bartosz Dziewoński) [20:17:40] MatmaRex: Most of it is horrible [20:17:40] Some selection restoration is necessary [20:17:44] But what it's doing is probably excessive [20:17:51] (03PS2) 10Jforrester: Update VE core submodule to master (5fdb204) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150692 [20:17:55] RoanKattouw: why is it necessary? i'd kill it all [20:18:06] RoanKattouw: okay, placing the cursor after the inserted content should probably stay [20:18:12] the rest looks rather useless [20:18:44] (03Merged) 10jenkins-bot: ve.ui.AnnotationInspector: Stop truncating fragments to 255 elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149646 (owner: 10Bartosz Dziewoński) [20:19:05] It should annotate upon opening too, and select the whole link [20:19:47] it should select indeed, but i don't see why it has to restore the original selection later [20:20:10] TrevorParscal, so a
appended to the body, position: absolute; top: 0px; bottom: 0px; left: 0px; right: 0px;, and with .click( function () { return false; } ) should stop any interaction with the body? [20:21:29] MatmaRex: Oh for if you press escape [20:21:55] Apparently the behavior we want is that if you put your cursor in the middle of the link, press Ctrl+K (selects whole link) then Esc, the cursor goes back to where it was originally [20:22:34] but that's weird if you have a selection that overlaps with a link and you don't cancel the dialog [20:23:09] i'm not sure why would we want that behavior, even in the case you describe :/ but okay [20:26:06] Actually I'm not sure we need a blocking overlay if I'm just going to keep the dialog open [20:27:24] (03PS8) 10Alex Monk: Show pending state and keep dialog open when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) [20:33:36] 3VisualEditor / 3ContentEditable: VisualEditor: Phantoms are appearing at wrong place while selecting an image after making it fullsize - 10https://bugzilla.wikimedia.org/62284#c8 (10James Forrester) 5ASSI>3RESO/FIX Yeah, this looks fixed to me. [20:38:52] Krenair: yes [20:40:21] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn gets added beside the comment, when inserting a whitespace after it. - 10https://bugzilla.wikimedia.org/68539#c9 (10James Forrester) (In reply to Ritu Swain from comment #8) > thank you. just for future.. this is not the right forum .. No problem. :-) >... [20:41:51] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf16] Cannot scroll up/down a page in mobile when the keyboard is open and cursor active on CE - 10https://bugzilla.wikimedia.org/68828#c3 (10Rummana Yasmeen) 5RESO/FIX>3REOP Reopening it again,since I just reproduced it. [20:54:21] 3VisualEditor / 3Editing Tools: VisualEditor: OpenSearch results aren't perfect for searching for pages (some don't come up) - 10https://bugzilla.wikimedia.org/54361#c2 (10James Forrester) *** Bug 67150 has been marked as a duplicate of this bug. *** [20:54:22] 3VisualEditor: VisualEditor: In which it is apparently impossible to create a redirect to [[Foo]] because the list of possible links does not scroll - 10https://bugzilla.wikimedia.org/67150#c2 (10James Forrester) 5NEW>3RESO/DUP Yeah, this is bug 54361. *** This bug has been marked as a duplicate of bug 5... [20:56:06] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf16] Cannot scroll up/down a page in mobile when the keyboard is open and cursor active on CE - 10https://bugzilla.wikimedia.org/68828#c4 (10Rummana Yasmeen) This is happening now but following a different steps to reproduce: 1.Open a page with... [20:57:09] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf16] Cannot scroll up/down a page in mobile when the keyboard is open and cursor active on CE - 10https://bugzilla.wikimedia.org/68828 (10Rummana Yasmeen) 5REOP>3ASSI a:3Juliusz Gonera [21:00:52] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] TypeError: Cannot read property 'context' of undefined appears when you try to insert another image that appears on the same index as the previous search, right after you inserted one - 10https://bugzilla.wikimedia.org/67749#c5 (10Moriel Schottl... [21:00:52] 3VisualEditor / 3Data Model: VisualEditor: Deleting new line icon ("↵") between two links has no effect (?) - 10https://bugzilla.wikimedia.org/51336 (10James Forrester) [21:02:21] 3VisualEditor / 3Editing Tools: VisualEditor: Return arrow is getting placed after every element inside Reference Dialog box - 10https://bugzilla.wikimedia.org/61510#c1 (10James Forrester) 5NEW>3RESO/INV I think this is just an artefact of "↵" characters being show for the
s put in by Parsoid… [21:03:22] 3VisualEditor / 3Editing Tools: VisualEditor:Double return arrow getting added after adding Galley just before a hiero - 10https://bugzilla.wikimedia.org/61162#c1 (10James Forrester) 5NEW>3RESO/FIX These don't show now; I think the upstream Parsoid fixes will have helped. [21:04:06] 3VisualEditor / 3Editing Tools: Visualeditor:A Return character gets placed between two galleries placed one after another - 10https://bugzilla.wikimedia.org/60312#c1 (10James Forrester) 5NEW>3RESO/FIX This also looks to have been fixed, probably by Parsoid. [21:04:53] 3VisualEditor / 3ContentEditable: VisualEditor: ↵ is shown when wikicode contains single newline, which is not very WYSIWYG - 10https://bugzilla.wikimedia.org/48290#c9 (10James Forrester) *** Bug 68811 has been marked as a duplicate of this bug. *** [21:04:53] 3VisualEditor / 3ContentEditable: VisualEditor:Categories when added are shown as return character in VE. - 10https://bugzilla.wikimedia.org/68811#c3 (10James Forrester) 5UNCO>3RESO/DUP Yeah, these are bug 48290 issues… *** This bug has been marked as a duplicate of bug 48290 *** [21:09:07] 3VisualEditor / 3Editing Tools: VisualEditor:Link Inspector icon is not appearing, when language is selected, in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68810#c2 (10James Forrester) Yeah, this is not very good. [21:11:22] James_F, any bugs for me to work on 'till Wikimania? [21:11:28] mooeypoo: Sure! [21:11:37] 3VisualEditor / 3ContentEditable: VisualEditor: Weird behavior around a wikilink - 10https://bugzilla.wikimedia.org/68666#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3High s:5normal>3major a:3Roan Kattouw I think this was caused by the pawning/snowmen issue that we fixed and pushed to produ... [21:12:07] mooeypoo: How do you feel about Mobile issues? Do you have a iDevice on which you can test? [21:12:29] no, I have Android and ( ... ) a Windows phone [21:12:39] if those work, then sure [21:12:44] but no iAnything [21:12:44] Dun-dun-dun! [21:12:56] OK, never mind then [21:13:07] (We're only doing tablet stuff for now.) [21:13:38] I have a Windows tablet. With IE11. We love IE 11. Especially RoanKattouw_away. [21:13:50] :D [21:14:13] Is there anything oyu want me to add to the image/media dialog from the pending requests ? [21:14:17] Uh-huh. :-) [21:18:32] mooeypoo: Not really media stuff right now. [21:18:36] Is https://bugzilla.wikimedia.org/show_bug.cgi?id=68582 still valid? [21:18:39] * mooeypoo nods [21:18:58] mooeypoo: https://bugzilla.wikimedia.org/show_bug.cgi?id=66210 looks pretty important – can you debug that at all/ [21:19:03] When I go back to the re-use citation dialog, nothing is selected [21:20:29] Krenair: Think it might be expected behaviour… ^^^ [21:20:36] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot include the same existing reference after adding it once in an article - 10https://bugzilla.wikimedia.org/68582#c2 (10James Forrester) Is this just because the reference is selected? [21:21:04] mooeypoo, sure you do, and I've got a pet unicorn [21:21:39] edsanders: We saw it. It was pink. [21:21:56] James_F, while a reference is selected, if I go Cite -> Re-use, nothing is already selected in the dialog [21:22:21] Krenair: … it is for me. [21:22:30] (03PS3) 10Cmcmahon: [BrowserTest] WIP: create new test for Cite tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150055 [21:22:35] Krenair: Try http://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/Sandbox?veaction=edit [21:22:53] Ah, have a week-old version of VE. hang on [21:23:09] :-) [21:23:36] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn gets added beside the comment, when inserting a whitespace after it. - 10https://bugzilla.wikimedia.org/68539#c10 (10Ritu Swain) (In reply to James Forrester from comment #9) > (In reply to Ritu Swain from comment #8) > > thank you. just for future.. this... [21:23:58] Ah yes, I see it's selected now [21:24:06] The one selected is the most recently re-used [21:24:16] Isn't it the one you've seleected? [21:24:39] no [21:25:49] It's a valid bug [21:25:51] 3VisualEditor / 3Editing Tools: VisualEditor: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - 10https://bugzilla.wikimedia.org/68590 (10James Forrester) [21:26:29] James_F, last I tried I couldn't reproduce, but let me try again. [21:27:37] 3VisualEditor / 3Editing Tools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - 10https://bugzilla.wikimedia.org/68537 (10James Forrester) a:3Ed Sanders [21:30:51] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog should validate template parameter values using TemplateData information - 10https://bugzilla.wikimedia.org/52651 (10James Forrester) s:5normal>3enhanc [21:34:18] jgonera_: I reopened https://bugzilla.wikimedia.org/show_bug.cgi?id=68828 and added the "new" steps to reproduce [21:34:57] let me know if you cant reproduce it [21:35:07] ok, thank you ryasmeen [21:37:05] 3VisualEditor / 3Editing Tools: VisualEditor: Link icon in menu shown as "selected" (but only if link was created this session?) - 10https://bugzilla.wikimedia.org/64979#c1 (10James Forrester) 5ASSI>3RESO/FIX This was fixed a while ago with the new context. [21:37:37] 3VisualEditor / 3Editing Tools: VisualEditor: "Use an Existing Reference" option remains disabled for a reference inside Media Settings while there is a reference available to re-use in the page - 10https://bugzilla.wikimedia.org/60919 (10James Forrester) a:3Moriel Schottlender [21:38:21] 3VisualEditor / 3Editing Tools: VisualEditor: Editing toolbar CSS disappears on hover, then the buttons do nothing - 10https://bugzilla.wikimedia.org/52987#c3 (10James Forrester) 5ASSI>3RESO/WOR Still can't reproduce, unfortunately. :-( [21:39:36] 3VisualEditor / 3Editing Tools: VisualEditor: Inspectors and context menu should close when blurring the document and/or when opening the save dialog - 10https://bugzilla.wikimedia.org/51439 (10James Forrester) [21:42:51] (03PS1) 10Alex Monk: Unselect currently selected item in re-use citation dialog when reopening [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150708 (https://bugzilla.wikimedia.org/68582) [21:50:38] 3VisualEditor: VisualEditor Mobile: scrolling and tapping into CE goes dead after using link inspector - 10https://bugzilla.wikimedia.org/68878 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None This just appeared as of a couple hours ago: 1. Go into VE edit mode on beta labs 2. Select a word and ta... [21:52:10] James_F, I'm going to contact hewiki guys again about these tags. I can't reproduce them at all. I'll try to see if there are more for me to try and make a connection beyond what I couldn't do up until now. [21:52:21] mooeypoo: Cool. [21:52:34] I didn't get any new ones about tags though. I don't know if it was a temporary fluke. [21:53:50] James_F, I need to go for a bit, but I'll work on that and the other bug you just assigned me when i get back [21:54:17] mooeypoo: Great. [21:59:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf15] Re-use existing citation dialog never rebuilds list of references after first opening - 10https://bugzilla.wikimedia.org/68869 (10Alex Monk) [22:02:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] TypeError: Cannot read property 'context' of undefined appears when you try to insert another image that appears on the same index as the previous search, right after you inserted one - 10https://bugzilla.wikimedia.org/67749#c6 (10James Forreste... [22:07:48] (03PS1) 10Alex Monk: Don't refuse to rebuild reference list when reopening re-using existing citation widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150711 (https://bugzilla.wikimedia.org/68869) [22:09:06] 3VisualEditor / 3Mobile: VisualEditor Mobile: Switching tabs in mobile safari often causes page to refresh causing data loss of session changes - 10https://bugzilla.wikimedia.org/68017 (10James Forrester) [22:09:10] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any edit in mobile VE for Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66756 (10James Forrester) [22:09:10] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on Return while cursor is at the end of a text , deletes that text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66758 (10James Forrester) [22:09:10] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Clicking in the document where an inspector was opened doesn't close the inspector - 10https://bugzilla.wikimedia.org/68679 (10James Forrester) [22:09:10] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - 10https://bugzilla.wikimedia.org/66604 (10James Forrester) [22:09:20] 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580 (10James Forrester) [22:09:29] 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - 10https://bugzilla.wikimedia.org/67262 (10James Forrester) [22:09:29] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843 (10James Forrester) [22:09:29] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697 (10James Forrester) [22:09:30] 3VisualEditor / 3Mobile: VisualEditor: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110 (10James Forrester) [22:09:31] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf12] The highlight for centered images is taking 100% width - 10https://bugzilla.wikimedia.org/67507 (10James Forrester) [22:09:32] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Unknown error" on saving on officewiki - 10https://bugzilla.wikimedia.org/68235 (10James Forrester) [22:09:33] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping at the end of each link, does copy-paste of preceding link text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66755 (10James Forrester) [22:09:34] 3VisualEditor / 3ContentEditable: VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - 10https://bugzilla.wikimedia.org/50036 (10James Forrester) [22:16:27] woot [22:16:32] what is this stuff… [22:16:35] this.schedule = ve.debounce( this.processQueue.bind( this ), 0 ); [22:16:38] from LinkCache [22:16:47] why the zero? that doesn't seem to make a lot of sense [22:19:18] It's basically the setTimeout( ..., 0 ) trick [22:19:29] Except setTimeout() makes that second param optional whereas ve.debounce() doesn't [22:19:53] MatmaRex: That's there so that if there are multiple requests to the link cache before the browser yields, we combine them [22:20:18] hm. [22:20:20] Construction of ce.LinkAnnotations cause link cache requests, and we don't want to do a separate API call for each one of them [22:20:34] I'm open to better solutions, I wrote this in an afternoon so I won't claim it's perfect [22:20:48] does that do anything in practice? the method itself should prevent double requests [22:20:52] queue = this.queue; [22:20:53] queueCopy = queue.slice(); [22:20:53] this.queue = []; [22:21:26] well anyway, in the worst case this just does nothing :) and i guess might help [22:21:47] someone from pl.wp just asked me to look at https://bugzilla.wikimedia.org/show_bug.cgi?id=61072 and i'm figuring it out [22:33:06] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000#c6 (10Rummana Yasmeen) 5REOP>3RESO/FIX I cant reproduce it now , the problem... [22:36:34] MatmaRex: It'll prevent two reqs for the same thing, yes [22:36:45] But say you have 5 links on the page [22:37:00] You'd like to have 1 request for the status of 5 links, not 5 requests for the status of 1 link each [22:37:44] oh. right [22:37:52] duh [22:37:58] in my defence, it's late ;) [22:39:05] Excuses. :-) [22:39:49] MatmaRex: What did you want to know about bug 61072? [22:40:21] James_F: uh, nothing much. you might want to know that i intend to fix it tomorrow :) [22:40:37] MatmaRex: "Fix"? There aren't such colours in MW-core yet. [22:40:55] hmm? [22:41:03] the .mw-redirect class is in core [22:41:12] (it just has no styles by default) [22:41:13] Is it used? [22:41:19] Hmm. OK… [22:41:23] used by on-wiki gadgets :) [22:41:32] Hmmph. [22:41:37] What about disambigs? [22:41:46] there's a gadget at pl.wp that colors it green, and .mw-disambig maroon [22:41:55] apparently people like that a lot [22:42:27] should be possible to gather all that information with one request for all the links [22:42:34] i just need to figure out how [22:42:38] Yuck. [22:43:01] i hope you don't mind putting .mw-disambig handling code in VE MW itself, rather than in E:Disambiguator or whatever? :) [22:43:17] James_F: be in london? [22:43:29] MatmaRex: Not for 36 hours, sorry. [22:43:31] Err. [22:43:34] matanya: ^^^. [22:43:36] * James_F sighs. [22:43:46] We have Kr* and Mat*. [22:43:54] It's too much. :-) [22:44:00] in hackaton? [22:44:13] marktraceur also enjoys being pinged instead of me, and vice versa ;) [22:44:22] Thanks MatmaRex. [22:44:24] matanya: Definitely. [22:44:26] Ha. [22:44:46] poke me there, will show you some stuff [22:44:53] James_F: matthewaroth isn't here! (I think that's his nick...) [22:45:00] and you owe me thing, iirc ;) [22:47:03] (03PS1) 10JGonera: Revert "Make scrolling in PanelLayout smoother on iOS" [oojs/ui] - 10https://gerrit.wikimedia.org/r/150719 (https://bugzilla.wikimedia.org/68878) [22:47:34] (03PS2) 10JGonera: Revert "Make scrolling in PanelLayout smoother on iOS" [oojs/ui] - 10https://gerrit.wikimedia.org/r/150719 (https://bugzilla.wikimedia.org/68878) [22:48:15] TrevorParscal, James_F ^ [22:48:27] that smooth scrolling messed up a lot more than it improved [22:56:08] 3VisualEditor / 3Mobile: VisualEditor Mobile:CE is getting zoomed in on rotating the screen orientation in iPad Mini - 10https://bugzilla.wikimedia.org/68883 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with Mobile VE 2.Place the cursor anywhere in CE 3.Chan... [23:04:48] (03CR) 10Catrope: [C: 032] Revert "Make scrolling in PanelLayout smoother on iOS" [oojs/ui] - 10https://gerrit.wikimedia.org/r/150719 (https://bugzilla.wikimedia.org/68878) (owner: 10JGonera) [23:05:27] (03Merged) 10jenkins-bot: Revert "Make scrolling in PanelLayout smoother on iOS" [oojs/ui] - 10https://gerrit.wikimedia.org/r/150719 (https://bugzilla.wikimedia.org/68878) (owner: 10JGonera) [23:09:35] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf16] Cannot scroll up/down a page in mobile when the keyboard is open and cursor active on CE - 10https://bugzilla.wikimedia.org/68828#c5 (10Juliusz Gonera) 5ASSI>3RESO/FIX Should be fixed by https://gerrit.wikimedia.org/r/#/c/150719/ [23:09:44] jgonera: Will do the pull-throughs. [23:09:57] thank you James_F [23:10:09] sorry for the hassle, should have tested it better [23:10:30] jgonera: These things happen. That's why we have Beta Labs. [23:10:35] ;) [23:11:22] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (dd294dc785) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150725 [23:11:57] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (dd294dc785) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150725 (owner: 10Jforrester) [23:13:22] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf16] Scrolling and tapping into CE goes dead after using link inspector - 10https://bugzilla.wikimedia.org/68878 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Highes s:5normal>3major a:3Juliusz Gonera [23:14:12] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (dd294dc785) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150725 (owner: 10Jforrester) [23:20:20] (03PS2) 10Catrope: Use whitespace preserving text input in extension inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150543 (owner: 10Esanders) [23:22:04] (03CR) 10jenkins-bot: [V: 04-1] Use whitespace preserving text input in extension inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150543 (owner: 10Esanders) [23:32:55] (03PS1) 10Krinkle: demos: Refactor tool groups to be re-usable between toolbars [oojs/ui] - 10https://gerrit.wikimedia.org/r/150732 [23:34:36] 3VisualEditor / 3Editing Tools: VisualEditor: Console shows "TypeError: jQuery1xxxxx is not a function" when cross-domain ajax request is aborted - 10https://bugzilla.wikimedia.org/59604 (10Krinkle) [23:37:07] (03PS3) 10Catrope: Update VE core submodule to master (5fdb204) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150692 (owner: 10Jforrester) [23:37:52] jgonera: http://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/Try_this [23:38:22] thanks James_F, I should've come up with this myself ;) [23:38:50] jgonera: No problem, I'm now very experienced at coming up with these. :-) [23:38:51] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10Rummana Yasmeen) 5PATC>3RESO/FIX [23:39:04] jgonera: Also ^^^ yay you fixed it according to ryasmeen. [23:39:07] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832#c4 (10Rummana Yasmeen) Verified the fix on Betalabs [23:39:34] James_F, good, let me know if it's still failing sometimes, we can increase the delay I introduced a little bit more [23:39:37] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10Rummana Yasmeen) a:3Juliusz Gonera [23:39:43] * James_F nods. [23:40:17] Krinkle|detached: How goes your OOUI work on https://bugzilla.wikimedia.org/show_bug.cgi?id=57366 ? [23:41:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Switch to source editor" text overlaps with selection indicator; should expand menu or wrap if needed - 10https://bugzilla.wikimedia.org/57366#c6 (10James Forrester) I believe this blocks bug 67340 (or at least, this being fixed would be useful there). [23:41:07] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10James Forrester) [23:44:52] 3VisualEditor / 3Data Model: VisualEditor: Re-use an existing reference shouldn't require a reference list to be or have been on the page to work - 10https://bugzilla.wikimedia.org/68079 (10James Forrester) a:3Alex Monk [23:44:58] Krenair: I've thrown yet another re-use reference bug at you, sorry! [23:45:38] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10James Forrester) a:3Krinkle [23:49:55] (03PS31) 10Catrope: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [23:49:59] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [23:56:15] (03PS1) 10Alex Monk: Don't clone internal item node element used for references in re-use citation dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150736 (https://bugzilla.wikimedia.org/67342) [23:58:09] (03CR) 10Catrope: [C: 032] Don't clone internal item node element used for references in re-use citation dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150736 (https://bugzilla.wikimedia.org/67342) (owner: 10Alex Monk) [23:58:25] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (5fdb204) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150692 (owner: 10Jforrester) [23:59:54] (03Merged) 10jenkins-bot: Don't clone internal item node element used for references in re-use citation dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150736 (https://bugzilla.wikimedia.org/67342) (owner: 10Alex Monk) [23:59:58] (03Merged) 10jenkins-bot: Update VE core submodule to master (5fdb204) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150692 (owner: 10Jforrester)