[00:00:17] (03PS1) 10Jforrester: Set a default language for ve.dm.Document if we can't guess it otherwise [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150738 (https://bugzilla.wikimedia.org/68808) [00:00:28] James_F, some of this bug sounds familiar [00:01:06] Krenair: I can imagine. :-) [00:01:07] (03PS3) 10Catrope: Use whitespace preserving text input in extension inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150543 (owner: 10Esanders) [00:01:14] Hi, all. [00:01:21] Can anyone help me? [00:01:23] 3VisualEditor / 3Editing Tools: VisualEditor: Language Inspector is not opening in the caption of the Media Settings dialog when in insertion mode (because dm.document's this.lang is null). - 10https://bugzilla.wikimedia.org/68808#c5 (10James Forrester) a:5Ed Sanders>3James Forrester This is… interesting. [00:01:26] James_F, for instance the last paragraph by Rummana sounds like one of the ones I just fixed [00:01:36] Okino, possibly! [00:01:47] Krenair: Yeah, this bug pre-dates the ones you fixed, so… [00:02:13] I was writing quite a long article, but then something happened, the Save the page button did not do anything and trying to switch into the wikitext editing just "greyed" all the text - and finally all the buttons do nothing. [00:02:37] I managed to copy all the text (but not the wikitext) into the text editor - but can I save something more? [00:02:55] (03CR) 10Catrope: [C: 04-1] "Hmm, this seems like it's not functionally equivalent: we move from stripping a newline to stripping any whitespace character. If we were " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150543 (owner: 10Esanders) [00:03:22] 3VisualEditor / 3Technical Debt: VisualEditor: dm.Document seems to not get the right lang and dir settings inside the Media Dialog in insert mode - 10https://bugzilla.wikimedia.org/68888 (10James Forrester) p:5Unprio>3Low [00:03:24] 3VisualEditor / 3Technical Debt: VisualEditor: dm.Document seems to not get the right lang and dir settings inside the Media Dialog in insert mode - 10https://bugzilla.wikimedia.org/68888 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3None … so instead it falls back to the built-in defaults (en and... [00:03:40] James_F, not https://bugzilla.wikimedia.org/show_bug.cgi?id=67342 [00:04:08] 3VisualEditor / 3Editing Tools: VisualEditor: The reference name for a newly added reference is not appearing in the dialog for "Use existing reference" while opening it for the first time - 10https://bugzilla.wikimedia.org/67342#c4 (10Alex Monk) 5PATC>3RESO/FIX Should be solved. [00:04:09] In fact, it had happened to me before, but I somehow naively believed it is already more stable... My mistake, I know... [00:04:17] (03CR) 10Catrope: [C: 032] "Said wider hole filed as https://bugzilla.wikimedia.org/68888" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150738 (https://bugzilla.wikimedia.org/68808) (owner: 10Jforrester) [00:04:30] James_F, what is the lowest version of IE we support? or in other words, can I use Array.filter? [00:04:40] Okino, are you still on the VE page? [00:04:45] jgonera: What's the support level for Array.filter? [00:04:51] 3VisualEditor / 3Editing Tools: VisualEditor: Language Inspector is not opening in the caption of the Media Settings dialog when in insertion mode (because dm.document's this.lang is null). - 10https://bugzilla.wikimedia.org/68808 (10James Forrester) 5PATC>3RESO/FIX [00:04:52] IE9 [00:04:53] jgonera: ∞ [00:04:59] Yes, of course. [00:05:00] jgonera: Oh IE9 is totally fine [00:05:08] +Krenair: Yes, of course. [00:05:09] jgonera: Short-term I'm working on trying to get IE11 to behave [00:05:09] so we don't care about IE8? [00:05:18] In the longer term I want to see if I can get that down to 9 [00:05:21] But IE8 can go die in a fire [00:05:22] ok, cool [00:05:24] ;) [00:05:24] jgonera: We currently don't support any IE; we don't intend to ever support IE8, no. [00:05:32] alright [00:05:33] (03Merged) 10jenkins-bot: Set a default language for ve.dm.Document if we can't guess it otherwise [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150738 (https://bugzilla.wikimedia.org/68808) (owner: 10Jforrester) [00:05:36] Okino, can you open the JS console? Is there anything that looks like an error there? [00:06:49] +Krenair: Yes, there are a few errors... Shall I copy them here? [00:07:11] Okino, do you know pastebin or gist? [00:07:53] +Krenair, well, in fact, no - just heard of them. Nevertheless, I can try. Which one is more intuitive? [00:08:22] I think gist.github.com probably requires a github account. I know pastebin.com allows anonymous pastes [00:09:04] +Krenair: Well, meanwhile I logged in with FB account into Pastebin. What shall I do next? [00:09:49] pastebin.com -> copy errors into the big textarea, leave syntax highlighting, set expiration to whatever, paste name "VE errors" or something, Submit [00:11:23] +Krenair: What do you mean by "leave syntax highlighting"? There is "none" as default - shall I select different? [00:11:53] Just leave it as the default "None" [00:13:03] +Krenair: Ok, I believe I shall now copy here the url...? [00:13:09] yeah [00:13:11] +Krenair: http://pastebin.com/MH6gptcE [00:13:28] +Krenair: Copied probably more than needed... - in fact everything. [00:13:46] Yep, VE definitely broke there. [00:14:28] Hmm [00:14:44] +Krenair: Well, I thought so... ;-) :-( [00:15:23] I thought "offset was inside" was supposed to be fixed by my snowman fix [00:15:35] "offset was inside a handlesOwnChildren node" -> https://bugzilla.wikimedia.org/show_bug.cgi?id=68537 or https://bugzilla.wikimedia.org/show_bug.cgi?id=68588 [00:15:53] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf16] Cannot scroll up/down a page in mobile when the keyboard is open and cursor active on CE - 10https://bugzilla.wikimedia.org/68828 (10Rummana Yasmeen) 5REOP>3ASSI [00:15:53] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf16] Cannot scroll up/down a page in mobile when the keyboard is open and cursor active on CE - 10https://bugzilla.wikimedia.org/68828#c6 (10Rummana Yasmeen) 5RESO/FIX>3REOP This issue did not get resolved with the revert [00:17:55] +Krenair: Hmmmm, and.... well what? [00:18:28] Okino, are you able to consistently reproduce this issue across VE sessions? [00:20:14] +Krenair: I cannot say I am able to reproduce it, but it happens to me now and then... But probably quite long ago - maybe months (or better: maybe tens of usages ago). Nevertheless, it's been a long time since I was making such a long article with many (citation) templates etc. [00:27:29] It will be hard to get this fixed if we don't know how you ran into the issue [00:27:53] Although it may have already been fixed... RoanKattouw, did you see those bugs I linked? Are they still valid? [00:28:51] Ooooh 68588 [00:28:52] That could be it [00:29:05] (03PS1) 10JGonera: Disable tools other than links and references on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150743 [00:29:06] Okino: By any chance did you try to put your cursor immediately after a reference list? Perhaps at the end of the page? [00:29:14] +Krenair: Well, the problem is that I even don't know, **when** the error happened. I had VE opened for maybe two hours, editting on and on - and it could have happen at the beginning, or recently... :-( [00:29:19] Cause right now if you try to do that, VE explodes in your face [00:29:40] You would probably have started noticing things being broken once the error happened [00:29:46] (03CR) 10jenkins-bot: [V: 04-1] Disable tools other than links and references on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150743 (owner: 10JGonera) [00:29:50] Like, typing would still work but tools wouldn't work any more [00:30:20] (03PS32) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [00:31:14] +RoanKattouw: Well, I don't remember doing it. The last thing that I made before I tried to ("better") save the page, was mouse-dragging a part of the bullet-list above another part of it. Both of them were behind the reference list, but still some parts below them as well. [00:31:49] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [00:32:25] +RoanKattouw: No, even typing is broken now, as I wrote before: I tried to switch into the wikitext mode - and all went grey and unable to touch. I only managed to CTRL-A select and CTRL-C copy all the material into Word... [00:32:49] Oh, right [00:32:53] 3VisualEditor / 3Editing Tools: VisualEditor: MWReferenceSearchWidget should only build the index if there isn't one or if it was built against a different version of the internal list - 10https://bugzilla.wikimedia.org/68890 (10James Forrester) 3NEW p:3Unprio s:3normal a:3None Right now we build it... [00:32:58] Yeah that makes sense [00:33:03] Do you still have the tab open? [00:33:16] +RoanKattouw: Yes. [00:33:23] 3VisualEditor / 3Editing Tools: VisualEditor: MWReferenceSearchWidget should only build the index if there isn't one or if it was built against a different version of the internal list - 10https://bugzilla.wikimedia.org/68890 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3enhanc a:3Al... [00:33:24] +RoanKattouw: Waiting for miracle :-) :-( :-) [00:33:35] Ahm [00:33:43] OK, you can *try* running the following code in the console [00:33:55] It may fail and cause more errors because it's similar to what switch to source mode tried [00:34:45] James_F, jshint trying to be too smart, fixing [00:35:00] Okino: d = ve.dm.converter.getDomFromModel( ve.instances[0].model.documentModel ); [00:35:16] If that doesn't throw errors, that would make me pretty happy [00:35:23] "Did you mean to return a conditional instead of an assignment?" No, I didn't [00:35:36] +RoanKattouw: Only that one line? [00:36:31] (03PS2) 10Jforrester: Follow-up I569098: Rebuild reference list when reopening as it can change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150711 (https://bugzilla.wikimedia.org/68869) (owner: 10Alex Monk) [00:36:34] Okino: Yes, let's start with that line [00:36:42] If that fails, you're quite probably screwed [00:36:54] If it succeeds, I can recover your wikitext with some more effort [00:37:12] (03CR) 10Jforrester: "Caused bug 68869; fixed in I0564c7a9." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148070 (owner: 10Esanders) [00:37:32] +RoanKattouw: Well, I am going to be little bit more careful - and more BFU. [00:37:34] (03PS3) 10Jforrester: Follow-up I569098: Rebuild reference list when reopening as it can change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150711 (https://bugzilla.wikimedia.org/68869) (owner: 10Alex Monk) [00:37:53] +RoanKattouw: I have the console open. Shall I simply put the code there and press enter? :-) (Sorry.....) [00:37:55] (03CR) 10Jforrester: [C: 032] Follow-up I569098: Rebuild reference list when reopening as it can change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150711 (https://bugzilla.wikimedia.org/68869) (owner: 10Alex Monk) [00:38:07] Okino: Yes [00:38:36] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf15] Re-use existing citation dialog never rebuilds list of references after first opening - 10https://bugzilla.wikimedia.org/68869 (10James Forrester) 5PATC>3RESO/FIX [00:38:49] +RoanKattouw: Ok. Well...... :-( "Error: Unbalanced data: 2 elements left open. [00:39:02] (03CR) 10Jforrester: [C: 032] Unselect currently selected item in re-use citation dialog when reopening [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150708 (https://bugzilla.wikimedia.org/68582) (owner: 10Alex Monk) [00:39:21] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot include the same existing reference after adding it once in an article - 10https://bugzilla.wikimedia.org/68582 (10James Forrester) 5PATC>3RESO/FIX [00:39:36] Okino: Yeah I was afraid of that [00:39:39] (03PS2) 10JGonera: Disable tools other than links and references on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150743 [00:39:41] (03Merged) 10jenkins-bot: Follow-up I569098: Rebuild reference list when reopening as it can change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150711 (https://bugzilla.wikimedia.org/68869) (owner: 10Alex Monk) [00:40:15] Hmm, there's a trick [00:40:22] This might work [00:40:37] James_F, jenkins shouldn't complain anymore [00:40:40] (03Merged) 10jenkins-bot: Unselect currently selected item in re-use citation dialog when reopening [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150708 (https://bugzilla.wikimedia.org/68582) (owner: 10Alex Monk) [00:41:19] Okino: data = ve.instances[0].model.documentModel.data.data; for ( i = 0; i < data.length; i++ ) { if ( data[i].type === 'internalList' ) { console.log(i); } } [00:41:58] (03CR) 10Jforrester: [C: 031] Disable tools other than links and references on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150743 (owner: 10JGonera) [00:42:05] +RoanKattouw: Copying... setting into console... [00:42:18] pressing enter - all ok? [00:42:43] well. "11244 <- undefined" [00:43:24] OK good [00:43:53] Now do this: data.length = 11244; [00:44:15] Then try this again: [00:44:19] [17:34] RoanKattouw Okino: d = ve.dm.converter.getDomFromModel( ve.instances[0].model.documentModel ); [00:45:14] +RoanKattouw: We are moving -- somewhere -- but where...? "TypeError: Cannot read property 'type' of undefined" [00:45:18] (03CR) 10Catrope: [C: 04-1] Stage slugs (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [00:45:25] wtf [00:47:59] Okino: What do you get when you do JSON.stringify(data[data.length - 1]); [00:48:53] +RoanKattouw: "{"type":"/paragraph"}" [00:48:59] OK that sounds good [00:49:20] (03PS8) 10Jforrester: Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [00:49:37] Hmm, OK let's figure out where that error came from [00:50:02] Okino: try { d = ve.dm.converter.getDomFromModel( ve.instances[0].model.documentModel ); } catch ( e ) { ex = e; } [00:50:08] (03CR) 10Jforrester: "And fixed jscs issue; the two big questions left unanswered." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [00:50:17] If that causes another error, then do ex.stack; and pastebin the result [00:50:33] Actually just do ex.stack; even if you don't see an error [00:51:47] Okino: Also that "try" was part of the code, sorry if that was confusing [00:51:50] +RoanKattouw: Well... is "ex is not defined" ok for you (before I copy the result into pastebin)? To me - poor BFU - it looks strange, is that ok? [00:52:33] Well, maybe this could be the problem. Trying "try" again :-) [00:53:21] This time it looks more proper (but not better, I think). Doing pastebin. [00:54:05] It should be 10-20 lines of stuff [00:54:08] +RoanKattouw: http://pastebin.com/SiJ5dZhS [00:54:27] Again copied [almost] all I have. [00:55:14] Hmm this is weird [00:55:30] OK tell me what this says [00:55:49] [ ve.instances[0].model.documentModel.data.getLength(), ve.instances[0].model.documentModel.metadata.getLength() ] [00:56:22] +RoanKattouw: [11244, 11969] [00:57:23] (03CR) 10Catrope: [C: 032] Disable tools other than links and references on mobile (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150743 (owner: 10JGonera) [00:58:31] Hmm, wait [00:58:39] (03Merged) 10jenkins-bot: Disable tools other than links and references on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150743 (owner: 10JGonera) [00:58:48] I realized that what I'm trying to do probably won't work [00:59:02] Because there are references on the page and we can't interpolate their contents [00:59:30] and it'll cause more errors when we try [00:59:41] Well, if you can save at least something, even without references, it is better than --- oh, I see... :-( [01:00:05] You rescued the plain text, right? [01:00:43] Yes, the plain text, but not the wikitext - that means to add all the formatting and linking and templates....... [01:00:51] Right [01:00:53] Hmm [01:00:59] Are there any references in the region that you edited? [01:01:44] RoanKattouw, thanks, I'll keep that in mind, didn't know you had a function for that [01:02:00] Unless the text you wrote is far away from any references, it's probably not worth our time to try and recover the formatting [01:03:12] Well, I changed all the article. It was a completely different than before, with 18 references at all in some 10 thousands letters of text... [01:03:48] Anyway, RoanKattouw, thanks a lot. I expected something like that, just tried... [01:03:57] But, please, let me another question: [01:04:40] Is there something I shall do to: avoid this kind of mishap again - and to save the text, when the first signs of error occur? [01:05:54] Well really we need to fix our software [01:06:06] For the time being, don't put your cursor immediately after a reference node [01:06:14] *reference LIST [01:06:17] We need to fix that bug [01:06:44] Other than that, you can keep a console open, and if it starts showing errors while you're editing, you could bail to source mode and/or save [01:07:07] (03PS1) 10Jforrester: Update VE core submodule to master (6c2c474) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150747 [01:07:24] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (6c2c474) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150747 (owner: 10Jforrester) [01:07:26] Sorry about this. :-( [01:08:54] 3VisualEditor / 3Data Model: VisualEditor: Make transaction processing exception-safe - 10https://bugzilla.wikimedia.org/68892 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None If an exception occurs while processing a transaction, we should roll it back safely, so the converter will still work and t... [01:08:58] +RoanKattouw: Well, I am afraid seeing errors is just the time when the saving/switching to wikitext is already gone. Maybe I will experiment with it next time a little, to see what really happens. [01:09:02] Okino: I've filed https://bugzilla.wikimedia.org/show_bug.cgi?id=68892 to remind ourselves that VE needs to be more resilient in the face of errors like these [01:09:09] (03Merged) 10jenkins-bot: Update VE core submodule to master (6c2c474) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150747 (owner: 10Jforrester) [01:09:09] +RoanKattouw: Thank you anyway. [01:09:24] We should try harder not to break saving and recovery of wikitext even if the rest of the world is on fire [01:09:59] That sounds brave. Even so a little Don-Quijotte-like ;-) [01:10:55] Well, have a nice - I don't know - morning? I will probably go to sleep off the lost text :-) Thanks, and good night. [01:11:22] 3VisualEditor / 3Data Model: VisualEditor: Make transaction processing exception-safe - 10https://bugzilla.wikimedia.org/68892 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major a:3Ed Sanders [01:11:25] Evening here in SF :) [01:11:34] Okino: Have a good night, and sorry we couldn't recover your work [01:11:55] Bye - off [01:13:54] (03PS33) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [01:15:15] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [01:16:21] 3VisualEditor / 3Data Model: VisualEditor: Re-use an existing reference shouldn't require a reference list to be or have been on the page to work - 10https://bugzilla.wikimedia.org/68079#c3 (10Alex Monk) (In reply to Rummana Yasmeen from comment #2) > However there is one issue here, when you first time add... [01:29:38] (03PS34) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [01:30:49] (03CR) 10Catrope: [C: 032] Use $.when() in MediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150001 (https://bugzilla.wikimedia.org/65321) (owner: 10Mooeypoo) [01:30:53] (03CR) 10jenkins-bot: [V: 04-1] Use $.when() in MediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150001 (https://bugzilla.wikimedia.org/65321) (owner: 10Mooeypoo) [01:30:58] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [01:35:10] (03PS3) 10Catrope: Use $.when() in MediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150001 (https://bugzilla.wikimedia.org/65321) (owner: 10Mooeypoo) [01:39:54] 3VisualEditor / 3Editing Tools: VisualEditor lost the first character when inputing with some IME - 10https://bugzilla.wikimedia.org/68893 (10Swimming Tiger) 3UNCO p:3Unprio s:3normal a:3None There is a strange trouble happen when I edit with Baidu Pinyin (a Chinese IME) on Firefox runing on Windows... [01:42:51] 3VisualEditor / 3Data Model: VisualEditor: Re-use an existing reference shouldn't require a reference list to be or have been on the page to work - 10https://bugzilla.wikimedia.org/68079#c4 (10James Forrester) 5ASSI>3RESO/FIX This looks like it's now fixed. (Note that the "re-use" list can take a few se... [02:31:51] 3VisualEditor / 3MediaWiki integration: Toolbar: Merge 'Save' and 'Cancel' buttons to a one group - 10https://bugzilla.wikimedia.org/64479#c1 (10James Forrester) 5ASSI>3RESO/INV This is now no longer needed as we just junked the Cancel button instead. [02:41:24] 3VisualEditor / 3Mobile: VisualEditor Mobile: Disable the context menu for the Basic reference - 10https://bugzilla.wikimedia.org/68897 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None The context menu for Basic Reference is still appearing, letting user to get stuck inside it after adding dffere... [02:42:22] 3VisualEditor / 3Mobile: VisualEditor Mobile: Disable the context menu for the Basic reference - 10https://bugzilla.wikimedia.org/68897 (10Rummana Yasmeen) a:3Juliusz Gonera [02:42:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: Disable the context menu for the Basic reference - 10https://bugzilla.wikimedia.org/68897 (10Rummana Yasmeen) 5NEW>3ASSI [03:02:46] ... references are completely broken for me. Anyone else has a problem? [03:03:03] I can add references, but then I save the page and reload it, and I get the in full text Something [03:03:05] Not me [03:03:07] Dinnertime [03:03:12] Bon apetit [03:03:14] mooeypoo: Is the Cite extension still installed? [03:03:16] And not brkoen? [03:03:23] I am checking now, but I just installed it [03:03:33] * RoanKattouw_away actually leaves [03:03:39] go, go! :) bon apetit [03:03:59] it works in read mode.. hm. [05:44:23] 3VisualEditor: MediaWiki 1.24wmf6 required when trying to install VisualEditor_REL1.23 - 10https://bugzilla.wikimedia.org/68891 (10ssastry) a:5Parsoid Team>3None [06:05:19] Hello to anyone! I'm trying to dive into OOjs UI to create custom dialogs for an extension. So far I've learned that OOjs UI may still be under development but the basic concepts should be stable enough to build own code upon it. I've examined the implementation of a few simple dialogs, like "ve.ui.MWSaveDialog", "ve.ui.MWBetaWelcomeDialog" and "ve.ui.MWReferenceDialog" and I think I understand the way a dialog shoul [06:06:30] hi osnard. I can't help you with OOjs UI, but I think your message got cut off [06:06:35] "..and I think I understand the way a dialog shoul" [06:12:06] (03CR) 10Catrope: [C: 032] Use $.when() in MediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150001 (https://bugzilla.wikimedia.org/65321) (owner: 10Mooeypoo) [06:13:58] (03Merged) 10jenkins-bot: Use $.when() in MediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150001 (https://bugzilla.wikimedia.org/65321) (owner: 10Mooeypoo) [06:20:53] 3VisualEditor / 3MediaWiki integration: Weird behavior of the Cite extension with VisualEditor - 10https://bugzilla.wikimedia.org/68899 (10Moriel Schottlender) 3NEW p:3Unprio s:3normal a:3None Created attachment 16105 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16105&action=edit References... [06:21:21] 3VisualEditor / 3MediaWiki integration: Weird behavior of the Cite extension with VisualEditor - 10https://bugzilla.wikimedia.org/68899#c1 (10Moriel Schottlender) Created attachment 16106 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16106&action=edit Same page in view mode [06:21:51] 3VisualEditor / 3MediaWiki integration: Weird behavior of the Cite extension with VisualEditor - 10https://bugzilla.wikimedia.org/68899#c2 (10Moriel Schottlender) Created attachment 16107 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16107&action=edit Same page in view mode [06:26:44] legotkm: Thank you. May be my client. I'll re-post. [06:27:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: Put in hacks to scrub plugin garbage (e.g. myEventWatcherDiv) - 10https://bugzilla.wikimedia.org/68900 (10Roan Kattouw) 3ASSI p:3Unprio s:3normal a:3Alex Monk These seem to be the leading cause of edit corruption right now. myEventWatcherDiv: htt... [06:28:06] Hello to anyone! I'm trying to dive into OOjs UI to create custom dialogs for an extension. So far I've learned that OOjs UI may still be under development but the basic concepts should be stable enough to build own code upon it. [06:28:24] I've examined the implementation of a few simple dialogs, like "ve.ui.MWSaveDialog", "ve.ui.MWBetaWelcomeDialog" and "ve.ui.MWReferenceDialog" and I think I understand the way a dialog should be implemented. [06:28:32] But I can't find any code that actually creates a dialog instance, shows it to the user or otherwise interact with it. Can you give me a hint where to look for something like this? [06:31:21] 3VisualEditor: MediaWiki 1.24wmf6 required when trying to install VisualEditor_REL1.23 - 10https://bugzilla.wikimedia.org/68891 (10Alexandre Emsenhuber [IAlex]) 5UNCO>3NEW [06:32:09] osnard: (most developers are probably asleep right now) [06:32:37] osnard, this can help you get started, but I suggest that you come back tomorrow morning if you run into problems -- Trevor will be able to help more :) https://www.mediawiki.org/wiki/OOjs_UI#Complex:_displaying_a_modal_dialog [06:33:16] hi [06:33:21] have you're tried just grepping the code for these names? the mwbetawelcome one should have rather simple usage [06:33:32] have you* [06:33:35] do you know, that you cannot save edits in redirect? [06:34:09] mooeypoo: Thanks a lot. Why did I not find this myself? I thought I've read this page already. But obivously not :) [06:36:01] :) it's okay, the documentation is not completely organized. [06:36:35] osnard, the team will be around tomorrow west-coast office hours time, you'll have a lot more people that can actually help then if you have questions. [06:37:01] MatmaRex_mobile: I've grepped through the VisualEditor repo already, yes. But I did not find anything useful. mooeypoo's hint seems to be very valuable. If I run into any troubles I come back when developers are not asleep anymore :) [06:38:33] many things in VE are referenced using the value of the .name property and various factories [06:38:54] MatmaRex_mobile, mooeypoo: Thanks for the quick responses. [06:38:59] so try slso grepping for 'betaWelcome' in this case [06:39:46] osnard, i think the confusing part is that we're using factories [06:40:00] try to see from the docs how we do that, it will also help you catch it in the VE code and see the exmaples [06:40:11] I have to go, but I'll be around tomorrow if you have more questions! [06:40:17] Great [06:40:36] Juandev: dunno. msybe there's a bug? [06:41:01] MatmaRex_mobile: maybe [06:42:31] MatmaRex_mobile: ok, Ill fill it and we will see [06:42:41] Juandev: what doyoumean by "csnnot save"? [06:43:01] also, on which wiki? [06:43:08] the button to safe edits is gray, doesnt work [06:43:09] cs.wp [06:45:20] hmm. seems to work for me [06:45:26] file a bug :) [06:45:32] umm [06:45:33] ok [06:54:53] 3VisualEditor / 3Editing Tools: Cannot redirec page - 10https://bugzilla.wikimedia.org/68901 (10Juan de Vojníkov) 3NEW p:3Unprio s:3blocke a:3None Created attachment 16108 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16108&action=edit Shows that redirect page Save page (=Uložit stránku) is... [06:55:22] 3VisualEditor / 3Editing Tools: Cannot safe redirect page - 10https://bugzilla.wikimedia.org/68901 (10Juan de Vojníkov) [06:55:22] MatmaRex_mobile: done: https://bugzilla.wikimedia.org/show_bug.cgi?id=68901 [06:58:54] thanks [06:59:23] huh, i can't dismiss the welcome dialog... [07:01:34] Juandev: huh, indeed [07:01:55] but! it works if youclock "apply changes" in the dialog [07:02:04] can you confirm? [07:02:13] you click* [07:07:36] 3VisualEditor / 3Editing Tools: Cannot safe redirect page - 10https://bugzilla.wikimedia.org/68901#c1 (10Bartosz Dziewoński) s:5blocke>3minor Indeed. In step 4), it also suffices to just input any text – the "Save" button doesn't become enabled. However, if in step 3) you click "Apply changes" rather t... [07:10:43] MatmaRex: yup it works [07:11:29] MatmaRex: but its not intuitive as I previously reported, you would skip that dialog box as I dont know, why to "apply it" [07:12:07] yep, this is defnitely a bug [07:15:49] MatmaRex: should I change the previous one, or how to do it? [07:16:31] change what? the bug? no, it's okay :) [07:16:38] i commented on it too [07:17:06] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot save redirect page after dismissing initial option dialog - 10https://bugzilla.wikimedia.org/68901 (10Bartosz Dziewoński) [07:18:04] MatmaRex: ah OK, thx [07:25:15] Juandev: hah, it gets better. that's a fascinating bug you found [07:25:54] Juandev: the state of the 'Save' button stops being updated always when you open the "Options" dialog and cancel it instead of applying [07:28:20] MatmaRex: but I didnt open it, it opened automatically [07:28:34] yes, i know [07:28:39] this also happens if you open manually [07:28:51] 3VisualEditor / 3Editing Tools: VisualEditor: State of 'Save' button stops being updated after opening and cancelling the "Options" dialog - 10https://bugzilla.wikimedia.org/68901#c2 (10Bartosz Dziewoński) s:5minor>3major It gets better: the state of the 'Save' button stops being updated always when you... [07:30:17] (03PS1) 10Bartosz Dziewoński: ve.ui.MWMetaDialog: Really *ALWAYS* return to normal tracking behavior [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150772 (https://bugzilla.wikimedia.org/68901) [07:30:48] Juandev: this patch ^ should fix this :) [07:31:03] ok [07:31:15] thanks for the report :D [07:31:22] and when we can edit tables with Ve?:-) [07:31:30] hah [07:32:07] no idea. you could probably get someone to write a simple gadget for at least inserting tables/rows/columns, though ;) [07:32:22] https://www.mediawiki.org/wiki/VisualEditor_gadgets#Adding_a_table [07:33:38] 3VisualEditor / 3Editing Tools: VisualEditor: State of 'Save' button stops being updated after opening and cancelling the "Options" dialog - 10https://bugzilla.wikimedia.org/68901 (10Bartosz Dziewoński) a:3Bartosz Dziewoński [07:39:56] (03CR) 10Esanders: "We'll we preserve, not strip, but if was an extension that was whitespace hyper-sensitive then it's going to have a bad time in AlienE" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150543 (owner: 10Esanders) [07:41:03] (03CR) 10Esanders: "We could also set it to unlimited trim." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150543 (owner: 10Esanders) [07:49:47] (03CR) 10Catrope: [C: 032] ve.ui.MWMetaDialog: Really *ALWAYS* return to normal tracking behavior [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150772 (https://bugzilla.wikimedia.org/68901) (owner: 10Bartosz Dziewoński) [07:51:27] (03Merged) 10jenkins-bot: ve.ui.MWMetaDialog: Really *ALWAYS* return to normal tracking behavior [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150772 (https://bugzilla.wikimedia.org/68901) (owner: 10Bartosz Dziewoński) [11:46:07] edsanders|away: #wikimania-2014 [11:58:53] 3VisualEditor / 3Editing Tools: VisualEditor: Triggering context on link after defocus throws "TypeError: Cannot read property 'isCollapsed' of null" - 10https://bugzilla.wikimedia.org/68915 (10Krinkle) 3NEW p:3Unprio s:3major a:3None 1. Click on a link to show the context menu. 2. Right click on the... [12:08:23] 3VisualEditor / 3Editing Tools: VisualEditor: Toolbar should update fixed position after resize if MediaWiki layout changed - 10https://bugzilla.wikimedia.org/68916 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None When resizing the window, after a certain point the MediaWiki page layout may change (media... [12:10:20] 3VisualEditor / 3Editing Tools: VisualEditor: Toolbar should update fixed position after resize if MediaWiki layout changed - 10https://bugzilla.wikimedia.org/68916#c1 (10Krinkle) Created attachment 16109 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16109&action=edit Screenshot of bug. [12:27:10] Sup guys? I'm facing this trouble when trying to install parsoid, parsoid : Depends: nodejs (>= 0.8.0) but it is not going to be installed. Could it be caused by my manual installation of nodejs? [12:27:27] node -v returns v0.10.29 [12:29:04] hamcore: if you didn't install node using the package, then dpkg / apt-get won't know about it [12:29:45] gwicke, is there a way to ignore this dependency check? (i know i'm not in the right place to ask it, though) [12:30:17] hamcore: you could dpkg -i --force-all the package [12:30:31] not recommended though [12:30:45] which distro / version are you running? [12:31:50] Ubuntu 13.04 [12:33:03] node 0.8+ should be available there [12:33:18] I know that it's available in precise, which is 12.04 [12:34:58] gwicke, installed it manually, it seems it worked. [12:35:01] can i pm you? [12:35:27] hamcore: I prefer the public channel [12:35:56] just for showing you the url [12:36:58] hamcore: if it works then that's great [12:40:02] wow, [948a092a] 2014-07-31 12:39:55: Fatal exception of type MWException [12:40:11] lemme google it [12:40:45] (03PS2) 10Vikassy: [BrowserTest] Do not zoom on specific scenarios to avoid scrollbars [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150553 [12:42:20] hamcore: enable debugging so you can see the stacktrace below that (fatal exception is not gonna be much use) [12:42:33] Alternatively, if you have logging enabled, grep for 948a092a in your exceptoin log [12:42:36] [7853891a] /kb/ Exception from line 3279 of /var/www/kb/includes/GlobalFunctions.php: MediaWiki 1.24wmf6 required--this is only 1.23.1, wow [12:42:49] perfect [12:43:17] it seems im not the only one, http://www.mediawiki.org/wiki/Thread:Extension_talk:VisualEditor/MediaWiki_1.24wmf6_required_when_trying_to_install_VisualEditor_REL1.23 [12:43:39] Yeah, use 1.23 version of extensions with 1.23 version of MEdaiWiki. Only use alpha of an extensoon if you also use alpha of mediawiki. Which is not recommended in prodution. [12:44:25] https://www.mediawiki.org/wiki/Extension:VisualEditor [12:44:36] Download REL1_23 if you're running MediaWiki 1.23 [12:44:39] git checkout REL1_23 [12:44:42] right, thanks [12:45:05] if you're using git directly, be sure to also account for submodules. [12:45:13] git submodule update --init after each checkout change [12:46:50] great, working as expected, thanks Krinkle gwicke. [12:47:09] now all i need is set server.js to run automatically. [12:49:31] weird, theres no parsoid.conf in /etc/init, since i installed it manually should i copy it from somewhere? [12:53:41] Krinkle, gwicke, correct me if I'm wrong: sudo vi /etc/init/parsoid.conf in http://www.mediawiki.org/wiki/Parsoid/Setup should be sudo vi /etc/init.d/parsoid [12:59:21] hamcore: if you use the package then this should not need any editing [13:31:33] does anyone know if there's an easy way to prevent the browser from auto-filling a oojs TextInputWidget? [13:35:21] 3VisualEditor / 3Editing Tools: VisualEditor: Apply styles for redirects/disambiguation links in suggestions in link inspector - 10https://bugzilla.wikimedia.org/61072#c2 (10Bartosz Dziewoński) We actually don't apply any classes, ve.ui.MWLinkTargetInputWidget.css just has some styles defining a close-enough... [13:47:21] 3VisualEditor / 3Editing Tools: VisualEditor: State of 'Save' button stops being updated after opening and cancelling the "Options" dialog - 10https://bugzilla.wikimedia.org/68901 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3High [13:52:51] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438 (10James Forrester) 5PATC>3RESO/FIX [13:53:06] 3VisualEditor / 3Technical Debt: VisualEditor: Use $.when() rather than sourceCount in MediaSearchWidget - 10https://bugzilla.wikimedia.org/65321 (10James Forrester) 5PATC>3RESO/FIX [13:53:20] 3VisualEditor / 3Technical Debt: VisualEditor: Use $.when() rather than sourceCount in MediaSearchWidget - 10https://bugzilla.wikimedia.org/65321 (10James Forrester) [14:09:24] mvolz: Are you using the widget in a form on the page or in a modal context? [14:33:35] (03PS2) 10Krinkle: MWLinkTargetInputWidget: Add styles for invalid link titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150297 (https://bugzilla.wikimedia.org/62761) (owner: 10Palerdot) [14:34:21] (03PS3) 10Krinkle: MWLinkTargetInputWidget: Add styles for invalid link titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150297 (https://bugzilla.wikimedia.org/62761) (owner: 10Palerdot) [14:36:12] (03CR) 10jenkins-bot: [V: 04-1] MWLinkTargetInputWidget: Add styles for invalid link titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150297 (https://bugzilla.wikimedia.org/62761) (owner: 10Palerdot) [14:39:23] (03CR) 10Krinkle: MWLinkTargetInputWidget: Add styles for invalid link titles (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150297 (https://bugzilla.wikimedia.org/62761) (owner: 10Palerdot) [14:40:21] (03CR) 10Krinkle: "I've updated the commit message. Because the latest patch set is submitted by me, the extended test suite was automatically ran for you. T" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150297 (https://bugzilla.wikimedia.org/62761) (owner: 10Palerdot) [14:40:47] (03PS1) 10Vikassy: [BrowserTest] Browser can now zoom out whenever required [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150833 [14:46:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: Put in hacks to scrub plugin garbage (e.g. myEventWatcherDiv) - 10https://bugzilla.wikimedia.org/68900 (10Alex Monk) [14:46:08] 3VisualEditor / 3MediaWiki integration: VisualEditor: Broken browser plugins cause cruft to be injected into the page (tracker) - 10https://bugzilla.wikimedia.org/52327 (10Alex Monk) [15:06:21] 3VisualEditor: MediaWiki 1.24wmf6 required when trying to install VisualEditor_REL1.23 - 10https://bugzilla.wikimedia.org/68891#c1 (10Krinkle) If they installed VisualEditor master, than that is bound to fail because it requires 1.24alpha (as all extensions do unless otherwise noted). There is a REL1_23 branc... [15:46:06] 3VisualEditor / 3Editing Tools: VisualEditor: Apply styles for redirects/disambiguation links in suggestions in link inspector - 10https://bugzilla.wikimedia.org/61072#c3 (10James Forrester) (In reply to Bartosz Dziewoński from comment #2) > We actually don't apply any classes, ve.ui.MWLinkTargetInputWidget.... [15:48:22] 3VisualEditor / 3Editing Tools: VisualEditor: Triggering context on link after defocus throws "TypeError: Cannot read property 'isCollapsed' of null" - 10https://bugzilla.wikimedia.org/68915 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Krinkle [15:50:21] 3VisualEditor / 3MediaWiki integration: VisualEditor: Toolbar should update fixed position after resize if MediaWiki layout changed (e.g. Vector skin goes below 982px SD/HD boundary) - 10https://bugzilla.wikimedia.org/68916 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3minor [16:30:31] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13295377 [16:30:31] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=105836790 [16:30:31] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=105848615 [16:30:31] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=105851288 [16:30:31] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=64524355 [16:30:32] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=39701785 [16:30:32] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=39701958 [16:31:48] Boo. [16:33:23] 3VisualEditor: VisualEditor: Copy/pasting causes and tags to appear - 10https://bugzilla.wikimedia.org/68928 (10Elitre) 3NEW p:3Unprio s:3normal a:3None See diff at https://de.wikipedia.org/w/index.php?title=Schotts_Sammelsurium&diff=prev&oldid=132639553 . [16:37:07] 3VisualEditor / 3Editing Tools: VisualEditor: Lag when selecting complex templates (especially in big pages) - 10https://bugzilla.wikimedia.org/50084#c4 (10James Forrester) 5ASSI>3RESO/FIX a:3Ed Sanders This is an old report that I think is now closable (but performance is of course an on-going concern... [16:56:02] heya James_F [16:56:34] James_F, I've been trying to debug this half the night :( did you hear anyone else iwth this problem? Cite is all screwed up for me, but *only* inside VE. https://bugzilla.wikimedia.org/show_bug.cgi?id=68899 [16:57:42] (03CR) 10Amire80: "It's not so much for Bug 68571. You may want to consider shortening these labels everywhere, because now that they are all so close to the" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150018 (owner: 10Amire80) [16:58:35] mooeypoo: Did you restart Parsoid? [16:58:46] mooeypoo: Remember that Parsoid's Cite is totally independent of MediaWiki's. [16:59:28] * James_F meetings. [17:36:56] (03CR) 10Catrope: [C: 032] "OK, fine. If it turns out to behave in ways people don't want, we can change it later." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150543 (owner: 10Esanders) [17:38:00] [10:30] mvolz [2014-07-31 06:29:37] does anyone know if there's an easy way to prevent the browser from auto-filling a oojs TextInputWidget? [17:38:38] (03Merged) 10jenkins-bot: Use whitespace preserving text input in extension inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150543 (owner: 10Esanders) [17:39:56] mvolz: There isn't. For now, you can hack it with widget.$element.prop( 'autocomplete', 'off' ); [17:41:06] But really we should build that into OO.ui.TextInputWidget as a method [17:41:42] (Which, if you feel like getting your feet wet with that, patches welcome; otherwise one of us might do it at some later point in time) [17:42:52] (03CR) 10Catrope: [C: 04-1] "-1 per Krinkle's inline comments" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150297 (https://bugzilla.wikimedia.org/62761) (owner: 10Palerdot) [17:43:18] RoanKattouw, you're still helping me with the VE demo of "latest attractions", yes? :) [17:43:22] Yes [17:43:34] After I stuff a bagel into my mouth [17:43:43] I'll do that, then come up [17:44:01] Eloquence: Is there a link to the schedule that allows me to figure out when it's my turn? [17:44:08] https://meta.wikimedia.org/wiki/WMF_Metrics_and_activities_meetings/2014-08 [17:44:14] I will do the demo with marielle, then it's your turn [17:44:20] this will be after mobile updates [17:44:30] don't stuff too quickly :) [17:46:49] OK thanks [17:54:52] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector sets wrong title when clicking suggestion - 10https://bugzilla.wikimedia.org/68934 (10Roan Kattouw) p:5Unprio>3High [17:54:53] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector sets wrong title when clicking suggestion - 10https://bugzilla.wikimedia.org/68934 (10Roan Kattouw) 3ASSI p:3Unprio s:3major a:3Trevor Parscal On enwiki: * Inspect an existing link * Type "N" in the text box * Click "North America" in the... [18:25:23] RoanKattouw, so I did a few quick searches for myEventWatcherDiv, , < and they all refer to Mac OS X browser plugins for safari :/ [18:25:56] RoanKattouw, re my "silly" bug about Cite and VE, I'm closing it with a note that it was solved by updating and restarting parsoid. But should I close it with "FIXED" or with "INVALID" since it wasn't really a bug to begin with? [18:28:39] And I don't have a mac, so... [18:37:10] (03PS4) 10Palerdot: Fixed Bug 62761, added invalid link title style. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150297 (https://bugzilla.wikimedia.org/62761) [18:41:17] Krenair: Yeah and Safari has no DOMParser usupport whatsoever [18:41:22] mooeypoo: INVALID [18:41:28] Riight [18:43:36] 3VisualEditor / 3MediaWiki integration: Weird behavior of the Cite extension with VisualEditor - 10https://bugzilla.wikimedia.org/68899#c3 (10Moriel Schottlender) 5NEW>3RESO/INV Apparently, the solution was to update and restart Parsoid. [18:43:58] RoanKattouw, I wonder if I can get the plugins for Safari on Windows. [18:44:32] RoanKattouw, I'm got a suggestion in hewiki about how VE should have a full "Preview" mode, which seems a little weird, because VE *itself* should be the preview of the article. The editing mode should, ideally, be seamless, right? Am I missing something? Because I'm getting responses that make it sound like I am. [18:45:04] (03PS5) 10Catrope: MWLinkTargetInputWidget: Add styles for invalid link titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150297 (https://bugzilla.wikimedia.org/62761) (owner: 10Palerdot) [18:45:09] Preview like the one you have in the source editor, I mean. It makes sense for the source editor to have it, but not really to VE... [18:47:36] mvolz: Wow the Citoid stuff looks awesome! I had no idea it was that far along already! [18:47:53] mvolz: Is there a wiki page about it somewhere? Where is the code? [18:50:37] (03CR) 10Catrope: [C: 032] MWLinkTargetInputWidget: Add styles for invalid link titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150297 (https://bugzilla.wikimedia.org/62761) (owner: 10Palerdot) [18:52:17] (03Merged) 10jenkins-bot: MWLinkTargetInputWidget: Add styles for invalid link titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150297 (https://bugzilla.wikimedia.org/62761) (owner: 10Palerdot) [19:22:00] RoanKattouw_away: thanks! https://www.mediawiki.org/wiki/Citoid but I assume you've already found it at this point [19:25:24] also Sumana said this in #mediawiki: [19:25:26] WHOOOAAA just saw mvolz's citoid demo. WOW [19:25:26] (in the metrics meeting) [19:25:26] this is frakking awesome [19:28:51] :D [19:42:50] 3VisualEditor / 3Data Model: VisualEditor: tags appear when editing on the Hebrew Wiki - 10https://bugzilla.wikimedia.org/66210#c1 (10Moriel Schottlender) I've gone through articles that had 'nowiki' and VisualEditor tags in hewiki to try and find the common error, and as far as I can see, 90% of th... [20:27:21] 3VisualEditor / 3Data Model: VisualEditor: tags appear when editing on the Hebrew Wiki - 10https://bugzilla.wikimedia.org/66210#c2 (10Moriel Schottlender) This seems to also happen in the English wikipedia with quotes and asterix characters. Examples: https://en.wikipedia.org/w/index.php?title=Sca... [20:31:56] 3VisualEditor / 3Mobile: VisualEditor Mobile:Mobile VE does not load after saving the first time edit in production (en.wiki), shows Error,can't load section - 10https://bugzilla.wikimedia.org/68948 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16111 --> https://bugzilla.w... [20:54:38] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot load Mobile VE in Betalabs in iOS safari - 10https://bugzilla.wikimedia.org/68949 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None I cannot load any page with Mobile VE with iOS safari but it works fine in desktop Safari. [21:02:25] RoanKattouw_away, I wonder if we could just $( 'div#myEventWatcherDiv' ).remove() or something and see if it still happens.. :/ [21:20:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832#c5 (10Rummana Yasmeen) 5RESO/FIX>3REOP This one is not working on test2 for some reason :( test2 is running wmf16 now [21:46:36] jgonera: This is the test page I was using : https://test2.wikipedia.org/wiki/20thjunechrome [21:54:28] thanks ryasmeen [21:55:07] Hm [21:55:30] Do we have a bug filed for "" being changed to have quotes around "votesmart"? [21:55:55] I ran into it with Special:Random - see "Brad_Hawkins_(politician)" on enwiki [22:02:13] Maybe? [22:02:15] I've seen it occasionally [22:02:20] But have never been able to reproduce [22:07:21] 3VisualEditor / 3ContentEditable: VisualEditor: Evernote Web Clipper inserts _clearly_component__css - 10https://bugzilla.wikimedia.org/53252#c3 (10Alex Monk) Derk-Jan, did you hear back from Evernote? [22:14:52] RoanKattouw, I have analysis about recent issues, but I am not sure what to do next with that. What makes something appear "nowiki" ? is it VE or parsoid? I think there may be an issue of escaping characters, if that makes sense [22:16:13] Most of the nowiki issues I've seen on both hewiki and enwiki are right after ", a couple are after * or | [22:16:59] mooeypoo: Parsoid [22:17:02] and then there is a whole other category that seems to add an empty space after references, but that didn't seem to be consistent enough for me to see what might cause it, so I stick with the " | and * [22:17:08] And often they're correct [22:17:31] Like, if * is involved, the user might have typed a literal * and Parsoid may need to take action to prevent it from becoming a bullet list item [22:17:42] Ah. Good point. [22:17:47] https://bugzilla.wikimedia.org/show_bug.cgi?id=66210 <-- most are after " though [22:17:58] Another fun one is [[apple]]s which turns into apples [22:18:10] So if you give Parsoid apples , it produces [[apple]]s [22:18:24] I saw 1 like that [22:18:27] in enwiki [22:18:31] Now in some cases, there may well be Parsoid bugs [22:18:37] And the tags might be unnecessary [22:18:56] But I'd recommend trying to preview the offending wikitext with and without nowiki to see if there's a rendering difference [22:18:58] I'm not sure, honestly. I put up a bunch of examples I saw that looked like they're not correct tags [22:19:42] The apostrophe treatment seems broken [22:19:50] yeh. Also, look at this: https://he.wikipedia.org/w/index.php?title=%D7%A2%D7%95%D7%A4%D7%A8_%D7%A2%D7%99%D7%A0%D7%99&curid=309950&diff=15774877&oldid=15774872 [22:19:56] I understand why ''Foo'''s is ambiguous and nowiki gets inserted, but it seems overzealous there [22:19:58] it happens pretty often in enwiki too [22:20:04] empty [22:20:07] Oh, leading space? [22:20:11] Yep [22:20:15] Yeah that's because the line would be a pre otherwise [22:20:21] I mean ideally that space would just be stripped [22:20:21] Ohh. [22:20:29] And maybe we should do that in VE as an MW-specific hack [22:20:46] People sent those in as complaints, so I'm not sure if they expected it [22:21:16] In my experience there's a vocal "any nowiki tag is automatically a bug" crowd, and they're wrong [22:21:23] hmm [22:21:25] I mean we should reduce nowikis [22:21:28] I think I know what happened here: https://he.wikipedia.org/w/index.php?title=%D7%94%D7%90%D7%A8%D7%99_%D7%A4%D7%95%D7%98%D7%A8_%D7%95%D7%90%D7%95%D7%A6%D7%A8%D7%95%D7%AA_%D7%94%D7%9E%D7%95%D7%95%D7%AA_(%D7%A1%D7%A8%D7%98)&curid=794595&diff=15773383&oldid=15733742 [22:21:33] so, ''bold'' right? [22:21:48] if the user typed ''something'', then it would be surrounded with "nowiki" tag [22:21:50] On the one hand, Parsoid is probably overzealous, and on the other hand, we probably make it too easy to create the kind of content that needs nowiki [22:21:53] right? [22:21:59] Which is why we did, say, link continuation, to reduce that [22:22:11] Hmmm. [22:22:12] mooeypoo: Yes [22:22:22] So, I think some of those cases are editors who forget they're using VE [22:22:26] If you type literal wikitext into VE, it'll get nowikied to prevent it from being interpreteed [22:22:33] That's why we have the warning that pops up when you do that [22:22:38] because now it makes sense. I thought those were " (as in double-quotes) but no, they're 2 single quotes [22:23:16] yep. Same here: two single-quotes https://he.wikipedia.org/w/index.php?title=%D7%90%D7%9C%D7%99_%D7%A4%D7%99%D7%A0%D7%99%D7%A9&curid=144088&diff=15769264&oldid=15724086 [22:23:22] I think people just forgot they're not in source mode. [22:23:26] There's quite a lot of thoes [22:23:45] (and they were sent at first to the hewiki VE feedback page as corruption) [22:23:49] which.. is... interesting. [22:24:46] So.. the problem exists between keyboard and chair? [22:26:54] In the case of apostrophes and asterisks and stuff, almost certainly [22:27:01] I mean, people are welcome to type whatever the hell they waant [22:27:17] But if they typed something that requires nowikis to render truthfully, they shouldn't then turn around and complain about nowikis [22:27:28] this is really weird, people are using two ' instead of " [22:27:45] And yeah double single quotes are almost certainly attempts to type wikitext [22:27:51] Which we warn you explicitly that it won't work [22:28:04] In hebrew, we use it for the short words, like instead of U.S.A we'd write US"A [22:28:16] Really? With 2x' rather than " ? [22:28:21] but it's supposed to be double-quotes, not 2 single-quotes. [22:28:23] Right [22:28:52] A bunch of the apostrophe-related nowiki issues are words where you're supposed to use " [22:29:10] Right [22:29:20] there are a couple that are clearly mistaken use of wikitext (''something'') which seems to suggest someone wanted to make it 'bold' [22:29:32] but then some are these, which are weird: https://he.wikipedia.org/w/index.php?title=%D7%A2%D7%93_%D7%A2%D7%A6%D7%9D_%D7%94%D7%99%D7%95%D7%9D_%D7%94%D7%96%D7%94_(%D7%A1%D7%93%D7%A8%D7%AA_%D7%98%D7%9C%D7%95%D7%95%D7%99%D7%96%D7%99%D7%94)&curid=1016962&diff=15762484&oldid=15762481 [22:29:46] Oh hah [22:30:07] That looks like a bug [22:30:24] Probably what happened is, Parsoid mistakenly rendered the bgcolor thing as text rather than an attribute [22:30:27] Then the editor cleaned it up [22:30:33] And it caused ||| which gets nowikied [22:31:11] hmmm [22:31:42] Okay, I need to consider how to write the explanation in the bug without... well, without writing "the problem is between the keyboard and chair" [22:32:33] Well that's not true in *all* cases [22:32:49] And, I think even where it is, in some cases we have a duty of making it harder for naive users to do the wrong thing [22:32:58] Indeed [22:33:05] Like, that leading space in a paragraph thing? [22:33:11] That happens a lot [22:33:17] We should probably just throw it away, rather than nowiki it to prevent a pre from being created [22:33:33] What I'm mostly concerned with, though, is that I was told there are *a lot* of nowiki corruption from VE [22:33:35] in hewiki [22:33:40] Also last year we implemented continuing of links, because stuff like [[Foo]]bar was happening often [22:34:11] from this test, it seems like most issues are actually users typing something they shouldn't (like double-apostrophe) [22:34:36] RoanKattouw, BUT it did made me think. There are a number of cases of * which is the user starting the line with * to notate a list item [22:34:54] Word does this automatically too, so I can see how people may get used to it. I wonder if we can do it automatically. [22:35:18] Some people really want us to make things like [[ and ]] "work" [22:35:19] * something <-- automatically turns into a list, or if a list exists above, automatically adds a bullet ? [22:35:33] We resisted that because some of those things will confuse the crap out of people who have never used wikitext [22:35:39] I think * might be reasonable though [22:35:41] yeah that's just silly :\ [22:35:51] but the * exists in other apps [22:35:55] That's really a James question though [22:36:10] Aye, I'm more thinking out loud. We can talk about this also in WM [22:36:33] I was trying to go over the Big Bad Horrible Corruption Issues (tm) of hewiki [22:36:41] and it turns out they're not quite corruption. [22:36:58] RoanKattouw, you think maybe the note about nowiki isn't prominent enough? [22:37:09] we need the wizard of Word 2000 with nice icon tells you : "Did you mean [[apple]]s or [[apple]]s :) [22:37:27] eranroz, I've been trying to get James_F to add Clippy to VE for EVER [22:38:00] :) [22:38:06] It would be the best easter egg ever. [22:38:10] Inez was going to help do it as an April Fools joke, using ClippyJS [22:38:13] Maybe next year? :) [22:38:22] :) [22:38:26] mooeypoo: Also diffs like https://en.wikipedia.org/w/index.php?title=Scar_%28The_Lion_King%29&curid=30258014&diff=619292425&oldid=619246147 look like Parsoid bugs tom e [22:39:18] RoanKattouw, yikes: Angels, Sadomasochism, and the Culture of Gothic'''s Mark Edmundson, resembles "a cultivated, word-weary, gay man," [22:39:25] Exactly [22:39:26] ... even the nowikis don't know what's up with themselves [22:39:49] but notice the two apostrophies after "Gothic" [22:40:35] Yes, that's terminating italic [22:40:44] Angels ... and Gothic is a book title [22:40:52] or a TV show or whatever [22:41:02] Yes. [22:41:04] Should be " [22:41:06] not '' [22:41:22] So the sentence is [name of thing]'s Mark Edmundson, resembles "[quote from someone else]" [22:41:46] * mooeypoo nods [22:42:00] So there are legitimately two single quotes after Gothic [22:42:01] The fact there was a nowiki there made me wonder if it's again about the quotes [22:42:08] bit it doesn't seem so now [22:42:19] And you may need a nowiki to protect that from the possessive apostrophe [22:42:32] But it shouldn't be nowiki-ing the next 10 words [22:42:36] 3VisualEditor / 3Data Model: VisualEditor: (Possibly) Yet Another Broken Browser Plugin injecting mess into edits (Google Maps?) - 10https://bugzilla.wikimedia.org/65227#c4 (10Alex Monk) So is this unconfirmed then? [22:42:52] RoanKattouw, or adding an empty tag [22:43:15] Well that empty nowiki tag I kind of understand [22:43:23] ''Foo''' looks weird and may be hard to parse [22:43:33] Although oftentimes (including in this case) it's not necesasry [22:45:18] hmm [23:06:27] (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Merge Window and Frame, make content isolation optional (035 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal) [23:10:24] 3VisualEditor: ResourcesTest::testUnsatisfiableDependencies: The module 'mobile.editor.ve' must not have target 'desktop' - 10https://bugzilla.wikimedia.org/68956 (10Nemo) 3NEW p:3Unprio s:3normal a:3None With attachment 16112: 119) ResourcesTest::testUnsatisfiableDependencies The module 'mobile.edito... [23:10:39] 3VisualEditor: ResourcesTest::testUnsatisfiableDependencies: The module 'mobile.editor.ve' must not have target 'desktop' - 10https://bugzilla.wikimedia.org/68956 (10Nemo) [23:14:37] (03PS1) 10Inez: Fix ve.init.mw.TargetEvents.js to subscribe to events that actually exists and are emitted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150983 [23:23:01] (03PS2) 10Catrope: Fix ve.init.mw.TargetEvents.js to subscribe to events that actually exist and are emitted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150983 (owner: 10Inez) [23:23:51] (03CR) 10Catrope: [C: 032] Fix ve.init.mw.TargetEvents.js to subscribe to events that actually exist and are emitted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150983 (owner: 10Inez) [23:25:27] (03Merged) 10jenkins-bot: Fix ve.init.mw.TargetEvents.js to subscribe to events that actually exist and are emitted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150983 (owner: 10Inez) [23:26:39] 3VisualEditor / 3Editing Tools: VisualEditor: Comment box is not opening , throwing error:TypeError: ve.ui.WhitespaceTextInputWidget is not a constructor - 10https://bugzilla.wikimedia.org/68960 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Happening on Betalabs and test2 Cannot open the new... [23:30:06] 3VisualEditor / 3Editing Tools: VisualEditor: Comment box is not opening in Firefox , throwing error:TypeError: ve.ui.WhitespaceTextInputWi dget is not a constructor - 10https://bugzilla.wikimedia.org/68960 (10Rummana Yasmeen) [23:42:57] (03PS1) 10Catrope: Followup 23a949844: fix typo in class name for WhitespacePreservingInputWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150989 (https://bugzilla.wikimedia.org/68960) [23:46:54] (03CR) 10Mwalker: [C: 032] Followup 23a949844: fix typo in class name for WhitespacePreservingInputWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150989 (https://bugzilla.wikimedia.org/68960) (owner: 10Catrope) [23:48:26] (03Merged) 10jenkins-bot: Followup 23a949844: fix typo in class name for WhitespacePreservingInputWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150989 (https://bugzilla.wikimedia.org/68960) (owner: 10Catrope) [23:50:47] (03PS1) 10Catrope: Followup 23a949844: fix typo in class name for WhitespacePreservingInputWidget [VisualEditor/VisualEditor] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/150990 (https://bugzilla.wikimedia.org/68960) [23:50:54] RoanKattouw, I haven't been able to reproduce any of the issues caused by bad extensions today [23:51:03] (03CR) 10Catrope: [C: 032] Followup 23a949844: fix typo in class name for WhitespacePreservingInputWidget [VisualEditor/VisualEditor] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/150990 (https://bugzilla.wikimedia.org/68960) (owner: 10Catrope) [23:51:05] In Safari on Windows? [23:51:13] (that I've tried so far) [23:51:26] Have tried some different things on different browsers. [23:51:51] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] Each category is getting added twice in Betalabs, throws TypeError: categoryItem is undefined - 10https://bugzilla.wikimedia.org/68484#c3 (10Rummana Yasmeen) 5RESO/FIX>3REOP Reproduced it today following these steps 1.Open a page with... [23:52:35] Although I imagine some of them are less likely to do things on localhost than, say, wikipedia.org [23:52:55] (03Merged) 10jenkins-bot: Followup 23a949844: fix typo in class name for WhitespacePreservingInputWidget [VisualEditor/VisualEditor] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/150990 (https://bugzilla.wikimedia.org/68960) (owner: 10Catrope) [23:52:56] True [23:53:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] Each category is getting added twice in Betalabs, throws TypeError: categoryItem is undefined - 10https://bugzilla.wikimedia.org/68484 (10Rummana Yasmeen) 5REOP>3ASSI a:3Alex Monk [23:53:23] 3VisualEditor / 3Editing Tools: VisualEditor lost the first character when inputing with some IME - 10https://bugzilla.wikimedia.org/68893#c1 (10Swimming Tiger) I made a mistake. The IME I use is Sogou Pinyin, not Baidu Pinyin. [23:54:11] or local network addresses, etc.