[00:09:41] (03PS1) 10Catrope: Update VE core submodule to wmf/1.24wmf16 for cherry-pick [extensions/VisualEditor] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/150994 [00:22:30] (03CR) 10Catrope: [C: 032] Update VE core submodule to wmf/1.24wmf16 for cherry-pick [extensions/VisualEditor] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/150994 (owner: 10Catrope) [00:24:09] (03Merged) 10jenkins-bot: Update VE core submodule to wmf/1.24wmf16 for cherry-pick [extensions/VisualEditor] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/150994 (owner: 10Catrope) [00:53:22] 3VisualEditor / 3Editing Tools: VisualEditor: Comment box is not opening in Firefox , throwing error:TypeError: ve.ui.WhitespaceTextInputWidget is not a constructor - 10https://bugzilla.wikimedia.org/68960#c5 (10Roan Kattouw) 5PATC>3RESO/FIX This was backported and deployed just now. [01:37:14] (03PS1) 10Catrope: Factor out wordbreak detection code and run it for simple insertions too [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151004 [01:37:41] (03PS35) 10Catrope: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [01:38:35] (03CR) 10Catrope: "PS35 is a rebase onto https://gerrit.wikimedia.org/r/#/c/151004/1" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [01:39:38] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [03:25:00] (03CR) 10Catrope: [BREAKING CHANGE] Merge Window and Frame, make content isolation optional (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal) [03:25:56] (03Abandoned) 10Catrope: Merge "Use native style property names instead of jQuery's css map" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150502 (owner: 10Divec) [03:27:19] (03CR) 10Catrope: [C: 031] "Needs rebuilding once the oojs-ui change is merged, but the VE code added here looks good." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150050 (owner: 10Trevor Parscal) [03:27:56] (03CR) 10Catrope: [C: 031] "Needs rebuilding when the VE core change is updated and merged, but the VE-MW code changed here looks good." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150051 (owner: 10Trevor Parscal) [09:30:52] (03PS1) 10Catrope: [WIP] Use a single unicorn instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [09:32:13] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use a single unicorn instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [09:40:55] (03PS2) 10Catrope: [WIP] Use a single unicorn instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [09:42:19] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use a single unicorn instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [10:35:03] (03PS2) 10Vikassy: [BrowserTest] Browser can now zoom out whenever required [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150833 [11:19:24] (03PS9) 10Esanders: Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) [11:20:21] (03CR) 10jenkins-bot: [V: 04-1] Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [14:47:37] (03PS1) 10Alex Monk: Tear down meta dialog pages when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151088 (https://bugzilla.wikimedia.org/68484) [15:27:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf16] Comment box is not opening in Firefox , throwing error:TypeError: ve.ui.WhitespaceTextInputWi dget is not a constructor - 10https://bugzilla.wikimedia.org/68960 (10James Forrester) a:3Roan Kattouw [15:50:09] 3VisualEditor / 3Technical Debt: ResourcesTest::testUnsatisfiableDependencies: The module 'mobile.editor.ve' must not have target 'desktop' - 10https://bugzilla.wikimedia.org/68956#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3enhanc Hmm. mobile.editor.ve is defined in MobileFronten... [15:50:09] 3VisualEditor / 3Technical Debt: VisualEditor: ResourcesTest::testUnsatisf iableDependencies: The module 'mobile.editor.ve' must not have target 'desktop' - 10https://bugzilla.wikimedia.org/68956 (10James Forrester) [16:16:36] (03PS1) 10Esanders: Have LanguageInputWidget return land+dir, not an annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151102 [16:30:33] Corruption alert: visualeditor-needcheck on svwiki: https://sv.wikipedia.org/?diff=26818312 [16:30:33] Corruption alert: visualeditor-needcheck on lawiki: https://la.wikipedia.org/?diff=2774622 [16:30:33] Corruption alert: visualeditor-needcheck on lawiki: https://la.wikipedia.org/?diff=2774625 [16:30:33] Corruption alert: visualeditor-needcheck on lawiki: https://la.wikipedia.org/?diff=2774628 [16:30:33] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=64537538 [16:30:34] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=64551248 [16:30:34] Corruption alert: visualeditor-needcheck on enwiki: https://en.wikipedia.org/?diff=619421237 [16:31:39]
[16:31:42] Is that a new one? [16:32:03] (the first ruwiki entry) [16:48:52] Krenair: Hmm, yeah, don't think I've see one of those before. [16:56:06] (03CR) 10Catrope: [C: 031] Tear down meta dialog pages when cancelling (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151088 (https://bugzilla.wikimedia.org/68484) (owner: 10Alex Monk) [17:01:59] Krenair: Never seen that [17:02:24] 3VisualEditor / 3Editing Tools: VisualEditor:Insert -> Comment not working in Betalabs - 10https://bugzilla.wikimedia.org/69012 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None steps- 1> open a page in VE. 2> Insert -> Comment. Add/Edit Comment dialog does not pop. [17:09:07] 3VisualEditor / 3Editing Tools: VisualEditor:Insert -> Comment not working in Betalabs - 10https://bugzilla.wikimedia.org/69012#c1 (10Roan Kattouw) Any errors in the JS console? [17:14:27] (03PS2) 10Alex Monk: Tear down meta dialog pages when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151088 (https://bugzilla.wikimedia.org/68484) [17:16:04] (03CR) 10jenkins-bot: [V: 04-1] Tear down meta dialog pages when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151088 (https://bugzilla.wikimedia.org/68484) (owner: 10Alex Monk) [17:17:01] (03CR) 10Alex Monk: [C: 04-1] "should test code before uploading" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151088 (https://bugzilla.wikimedia.org/68484) (owner: 10Alex Monk) [17:18:58] (03PS3) 10Alex Monk: Tear down meta dialog pages when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151088 (https://bugzilla.wikimedia.org/68484) [17:22:58] (03PS4) 10Alex Monk: Tear down meta dialog pages when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151088 (https://bugzilla.wikimedia.org/68484) [17:23:30] (03PS10) 10Esanders: Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) [17:33:56] RoanKattouw, so the concept of not having sluggable locations in the model requires us to enforce that in the view [17:34:06] I think that means we have to set the to CE=false [17:34:11] *them [17:35:55] the problem is what you do when someone drags from/to them [17:37:54] edsanders: Uhm... I don't understand what you're talking about? What's that about not having sluggable locations in the model? [17:39:03] so consider ['slug-causing-element', 'F', 'o', 'o', '/sce'] [17:39:20] if you render a CE paragraph at 0,0 [17:39:32] you can select from inside 'Foo' to the paragraph [17:39:45] which get's translated to [3,0] for example [17:40:14] but the point of this is that you can't place your cursor at 0 without staging a

,

pair and moving to 1 [17:40:25] *this commit is ... [17:42:12] So you're saying the problem is, someone selects from the end of "Foo" into the block slug, and now because part of the selection is in a block slug we need to stage its conversion to a paragraph and remap the selection? [17:42:38] yes [17:43:17] another issue with that: view->model sync is not instant with selections [17:43:47] but that's a problem we have in general with selection [17:45:58] So you're saying you're thinking about making block slugs ce=false so that the selection doesn't accidentally end up there unless and until you've converted it to a real paragraph? [17:46:35] yup [17:46:59] it would make them much simpler [17:47:39] the only downside is that you can't verically cursor into them (although we could special case that e.g. did you just jump over one?) [17:48:11] horizontal cursoring into them is already broken, but could be 'fixed' in a similar way [17:48:41] assuming we want them to be keyboard accessible [17:49:14] Right [17:49:19] I see them as more of an 'insert paragraph here' button... [17:49:25] Well arrow key handling is fully programmatic right now so I'm not too worried [17:49:37] When arrow key handling becomes native, maybe we should worry [17:49:52] But that's something that future David can punch our future selves over [17:50:03] * mooeypoo coughs in RTL [17:50:11] hgouc [17:50:20] *hguoc [17:50:57] yltcaxe [17:52:57] James_F|Away, so yeah I was probably a bit unclear earlier. I guess I need to talk to a few users who ran into these browser extension issues, work out exactly what plugins, versions, browsers, etc. were involved, and probably ask some other people to attempt a few of them (e.g. the ones mentioning os x) [17:54:06] ‏ [17:54:45] * edsanders pastes an RlM character [17:55:22] ‏nothing exploded... [17:55:34] but my dots got moved [17:55:38] {{כ}} [17:56:34] (03PS2) 10Catrope: Have LanguageInputWidget return lang+dir, not an annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151102 (owner: 10Esanders) [17:56:40] (03CR) 10Catrope: [C: 032] Have LanguageInputWidget return lang+dir, not an annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151102 (owner: 10Esanders) [17:58:01] (03Merged) 10jenkins-bot: Have LanguageInputWidget return lang+dir, not an annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151102 (owner: 10Esanders) [18:02:23] Alright, time to come into the office [18:03:04] (03PS11) 10Esanders: Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) [18:04:21] (03CR) 10Catrope: Stage slugs (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [18:06:42] (03CR) 10Esanders: Stage slugs (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [18:07:08] 3VisualEditor / 3Editing Tools: VisualEditor:Insert -> Comment not working in Betalabs - 10https://bugzilla.wikimedia.org/69012#c2 (10Rummana Yasmeen) yes, the error appearing in the console is: Uncaught TypeError: undefined is not a function [18:07:22] 3VisualEditor / 3Editing Tools: VisualEditor:Insert -> Comment not working in Betalabs - 10https://bugzilla.wikimedia.org/69012 (10Rummana Yasmeen) 5UNCO>3NEW [18:11:20] I propose that 'xor' be pronounced 'zorr' so it can fluently be used in a sentence [18:12:16] e.g. 'We can relax here and have a nice time xor go and visit James' [18:45:59] edsanders: Are you saying cE=false actually works on IE10? [18:46:18] isn't that we we discovered? [18:47:26] I don't remember [18:47:26] I haven't tested the cE=false issue in IE11 on Windows 7, only on Windows 8 [18:51:09] 3VisualEditor / 3Editing Tools: VisualEditor: Media search is extremely slow, some images are not appearing and the progress bar keeps on moving infinitely - 10https://bugzilla.wikimedia.org/69018 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16119 --> https://bugzilla.wik... [18:51:09] edsanders, I thought that's how you pronounce xor anyways? [18:51:38] 3VisualEditor / 3Editing Tools: VisualEditor: In Betalabs,Media search is extremely slow, some images are not appearing and the progress bar keeps on moving infinitely - 10https://bugzilla.wikimedia.org/69018 (10Rummana Yasmeen) p:5Unprio>3High a:3Roan Kattouw [18:51:48] edsanders, You guys are blowing my mind. First "scalable" and now "xor". What next! [18:51:52] 3VisualEditor / 3Editing Tools: VisualEditor: In Betalabs,Media search is extremely slow, some images are not appearing and the progress bar keeps on moving infinitely - 10https://bugzilla.wikimedia.org/69018 (10Rummana Yasmeen) 5NEW>3ASSI [18:51:53] 3VisualEditor / 3Editing Tools: VisualEditor: In Betalabs,Media search is extremely slow, some images are not appearing and the progress bar keeps on moving infinitely - 10https://bugzilla.wikimedia.org/69018 (10Rummana Yasmeen) 5NEW>3ASSI [18:52:55] (03PS12) 10Catrope: Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [18:56:37] 3VisualEditor / 3ContentEditable: VisualEditor: Snowman character gets triggered, when trying to insert a template with Comment edit dialog open. - 10https://bugzilla.wikimedia.org/68740#c17 (10Ritu Swain) Created attachment 16120 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16120&action=edit scree... [18:58:52] 3VisualEditor / 3ContentEditable: VisualEditor: Snowman character gets triggered, when trying to insert a template with Comment edit dialog open. - 10https://bugzilla.wikimedia.org/68740#c18 (10Ritu Swain) In FF, the highlight seems to mask the comment icon.See screenshot_FF. [18:59:33] (03CR) 10Catrope: [C: 04-1] Tear down meta dialog pages when cancelling (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151088 (https://bugzilla.wikimedia.org/68484) (owner: 10Alex Monk) [19:02:14] Krenair: Re ---^^, I think using staging might actually be pretty easy. All you'd have to do is call pushStaging() on open and either popStaging() or applyStaging() on close [19:08:52] 3VisualEditor / 3Editing Tools: VisualEditor: Language dialog launched from inspector doesn't open in a global overlay - 10https://bugzilla.wikimedia.org/68486#c4 (10Ritu Swain) Issue Resolved. [19:24:39] 3VisualEditor / 3Editing Tools: VisualEditor: Language Inspector is not opening in the caption of the Media Settings dialog when in insertion mode (because dm.document's this.lang is null). - 10https://bugzilla.wikimedia.org/68808#c7 (10Ritu Swain) In Chrome and FF only the Language Inspector appears out of... [19:24:39] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf16] Comment box is not opening in Firefox , throwing error:TypeError: ve.ui.WhitespaceTextInputWidget is not a constructor - 10https://bugzilla.wikimedia.org/68960#c6 (10Rummana Yasmeen) *** Bug 69012 has been marked as a duplicate of this bug. *** [19:24:39] 3VisualEditor / 3Editing Tools: VisualEditor:Insert -> Comment not working in Betalabs - 10https://bugzilla.wikimedia.org/69012#c3 (10Rummana Yasmeen) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 68960 *** [19:25:16] (03PS1) 10Catrope: Update VE core submodule to master (8a5945c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151152 [19:25:22] 3VisualEditor / 3Editing Tools: VisualEditor: Language Inspector is not opening in the caption of the Media Settings dialog when in insertion mode (because dm.document's this.lang is null). - 10https://bugzilla.wikimedia.org/68808#c8 (10Ritu Swain) Created attachment 16121 --> https://bugzilla.wikimedia.or... [19:25:29] TrevorParscal: https://gerrit.wikimedia.org/r/151152 [19:26:20] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (8a5945c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151152 (owner: 10Catrope) [19:26:22] 3VisualEditor / 3Editing Tools: VisualEditor:Insert -> Comment not working in Betalabs - 10https://bugzilla.wikimedia.org/69012#c4 (10Rummana Yasmeen) This is the same bug as https://bugzilla.wikimedia.org/show_bug.cgi?id=68960 Just in Chrome the JS error is different , so initially I thought its a different... [19:29:02] (03CR) 10Catrope: [C: 04-1] Check for changes in media dialog (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150478 (https://bugzilla.wikimedia.org/68058) (owner: 10Mooeypoo) [19:32:24] (03CR) 10Catrope: "This breaks changing the image: if you click Change image and choose a different image, you then can't click Apply changes until you also " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150478 (https://bugzilla.wikimedia.org/68058) (owner: 10Mooeypoo) [19:34:43] (03CR) 10Catrope: "That seems to be because, while the ImageModel hash includes src, this is useless because hasBeenChanged() is defined on the ImageModel it" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150478 (https://bugzilla.wikimedia.org/68058) (owner: 10Mooeypoo) [19:39:18] (03Merged) 10jenkins-bot: Update VE core submodule to master (8a5945c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151152 (owner: 10Catrope) [19:43:22] 3VisualEditor / 3Data Model: VisualEditor: Re-use an existing reference shouldn't require a reference list to be or have been on the page to work - 10https://bugzilla.wikimedia.org/68079#c5 (10Ritu Swain) Issue Resolved in test2. [19:43:25] anyone know if Krinkle's "get oojs to work in IE6" is deployed? [19:43:56] because I'm hearing from MultiMedia that the Object.create shim wasn't present, and it wasn't working below IE9 [19:48:51] RoanKattouw, so that we end up with https://gist.github.com/Krenair/73ef3d3fe3cf1f6aa3da ? [19:50:05] Krenair: Yeah that looks very sensible actually [19:50:16] (sans comments that refer to removed code) [19:50:28] I just hope it actually works [19:51:58] Well you know better than I do about that [19:52:51] 3VisualEditor / 3Editing Tools: VisualEditor: Selecting the Alt Text box in the Media Settings dialog should disable the Caption box's toolbar - 10https://bugzilla.wikimedia.org/68806#c6 (10Ritu Swain) Issue Resolved in test2 and beta. [19:53:21] I think it should work just fine [19:53:36] But it should probably be tested [19:54:08] I'm sorry I'm just shoving my work onto your plate at this point :S I have to get this Wikimania talk prep going [19:54:14] (03PS5) 10Alex Monk: Tear down meta dialog pages when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151088 (https://bugzilla.wikimedia.org/68484) [19:54:18] (03CR) 10jenkins-bot: [V: 04-1] Tear down meta dialog pages when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151088 (https://bugzilla.wikimedia.org/68484) (owner: 10Alex Monk) [19:54:29] (03CR) 10Mooeypoo: "Ah, foo, you're right. The initial change had the dialog run the "hasBeenChanged" and accounted for that, but I thought the method should " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150478 (https://bugzilla.wikimedia.org/68058) (owner: 10Mooeypoo) [19:55:01] TrevorParscal: Yeah, OOjs is fully compatible with ES3 (including buggy ES3 as found in IE6). However the shim it relies on doesn't include Object.create. I'm fixing that today. [19:55:14] awesome [19:56:01] (03PS6) 10Alex Monk: Tear down meta dialog pages when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151088 (https://bugzilla.wikimedia.org/68484) [19:56:49] Krinkle: would you say that OOjs and jQuery 1 have comparable compatible clients? [19:56:59] TrevorParscal: Yes [19:57:06] ok, cool [19:57:15] I'm trying to not tell lies in my presentation [19:57:16] TrevorParscal: OOjs supports more in fact. [19:57:23] really? [19:57:32] But that's not continuously tested for. But happens to be the case. [19:57:39] TrevorParscal: It makes sense, since there's no DOM stuff. [19:57:47] It's pure javascript. [19:58:01] right [19:58:29] We carefully avoid any syntaxtical bugs and limitations (e.g. 'super' and other reserved words), and the rest is fully functional whcih we can polyfil. [20:52:10] RoanKattouw, your comments on the image model made me think I should refactor the bit about changing image, ideally. But I'm going to keep that as a "todo" item so the current commit can be merged to fix the current bugs while we're all going to wikimania -- that makes sense? [20:53:24] Yeah makes sense [20:53:29] So, ideally, instead of reinstantiating a new model when the user switches an image, the model should be able to switch the required parameters. But that will involve recalling scalable object -- not horrible in itself, but a bit more elaborate, which is why I want to first do this bugfix commit. [20:53:42] * mooeypoo nods [20:54:53] (03PS2) 10Mooeypoo: Check for changes in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150478 (https://bugzilla.wikimedia.org/68058) [20:55:10] RoanKattouw, any way to listen to the internal list for when a particular type of item is inserted/modified/deleted? [20:56:05] Closest I found was the 'update' event which doesn't quite seem to be what I'm looking for [20:57:18] ahm [20:57:25] What does ce.ReferenceListNode use/ [20:58:54] 'update' [20:59:12] Right and then does it filter based on event data at all? [21:00:26] hm. [21:01:51] Okay, that seems fine then. [21:02:36] although... [21:03:39] Doesn't appear to be triggered when a modify one [21:04:52] I modify* [21:06:34] I guess that's fine though [21:14:16] TrevorParscal: I'm looking at ve.ce.FocusableNode.prototype.getRelativeOffset , do you think it could/should return bottom and right of boundingRect as well? [21:14:48] InezK: There's getDimensions().... [21:14:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot load Mobile VE in Betalabs in iOS safari - 10https://bugzilla.wikimedia.org/68949#c1 (10Ryan Kaldari) 5NEW>3RESO/FIX This should be fixed now. See https://gerrit.wikimedia.org/r/#/c/150995/ [21:16:12] RoanKattouw: yeah, and that's exactly what I do know.. use both, to calculate bottom and right [21:16:59] Right [21:17:15] Oh hah I just noticed how the dimensions are compued [21:17:19] by subtracting bottom and top! [21:17:25] Yeah then just add bottom and right, for sure [21:26:24] 3VisualEditor / 3Editing Tools: VisualEditor: Can't re-use the same reference twice - 10https://bugzilla.wikimedia.org/69027 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Intention: Re-use an existing reference Steps to Reproduce: 1. Open a page containing a citation. 2. Cite > Re-use. Clic... [21:42:22] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot load Mobile VE in Betalabs in iOS safari - 10https://bugzilla.wikimedia.org/68949#c2 (10Rummana Yasmeen) Verified the fix in Betalabs. [21:43:38] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot load Mobile VE in Betalabs in iOS safari - 10https://bugzilla.wikimedia.org/68949 (10Rummana Yasmeen) p:5Unprio>3Highes s:5normal>3major a:3Ryan Kaldari [21:44:56] Hey jgonera [21:45:38] We still have one context menu to disable: Basic Reference [21:45:49] this is the bug for it :https://bugzilla.wikimedia.org/show_bug.cgi?id=68897 [21:48:22] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot include the same existing reference after adding it once in an article - 10https://bugzilla.wikimedia.org/68582#c5 (10Rummana Yasmeen) *** Bug 69027 has been marked as a duplicate of this bug. *** [21:48:23] 3VisualEditor / 3Editing Tools: VisualEditor: Can't re-use the same reference twice - 10https://bugzilla.wikimedia.org/69027#c1 (10Rummana Yasmeen) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 68582 *** [21:59:03] ryasmeen, I'll dig into this, thanks [21:59:26] okay [22:08:38] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195#c2 (10Rummana Yasmeen) 5RESO/FIX>3REOP This is still happening in Betalabs [22:09:07] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195 (10Rummana Yasmeen) 5REOP>3ASSI [22:13:18] RoanKattouw, so the reference list listens for any list node update [22:15:14] which... seems like it would catch unrelated updates? [22:15:20] but seems to do the job roughly anyway [22:17:24] 3VisualEditor / 3Data Model: VisualEditor: Media Settings dialog does not close, when inserting a media with a link or language "Uncaught TypeError: undefined is not a function" - 10https://bugzilla.wikimedia.org/69031 (10Ritu Swain) 3UNCO p:3Unprio s:3major a:3None Created attachment 16124 --> htt... [22:19:54] Right [22:19:58] So it's just wasteful [22:41:32] (03PS1) 10Alex Monk: Only build reference search index when it's been changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151234 (https://bugzilla.wikimedia.org/68890) [22:58:37] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696#c5 (10Rummana Yasmeen) 5VERI>3REOP I reproduced it again today following these steps: 1.Open any... [22:58:37] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696#c6 (10Rummana Yasmeen) I reproduced it again today following these steps: 1.Open any page with mobile... [22:59:38] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10Rummana Yasmeen) [22:59:39] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10Rummana Yasmeen) 5REOP>3ASSI a:3Roan Kattouw [22:59:51] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195 (10Rummana Yasmeen) [23:08:52] 3VisualEditor / 3ContentEditable: VisualEditor: Chrome 36 and higher throws "Discontiguous selection is not supported" on opening the editor - 10https://bugzilla.wikimedia.org/68493#c2 (10Tim Down) It's coming from a perfectly reasonable feature test in Rangy that is upsetting non-standard behaviour in Chrom... [23:09:36] 3VisualEditor / 3ContentEditable: VisualEditor: Don't use Range.detach (is now a no-op in Chrome per revised DOM spec) - 10https://bugzilla.wikimedia.org/68492#c1 (10Tim Down) Rangy has no reliance on Range.detach now. The latest release does not use it at all. [23:33:22] 3VisualEditor / 3ContentEditable: VisualEditor: Don't use Range.detach (is now a no-op in Chrome per revised DOM spec) - 10https://bugzilla.wikimedia.org/68492#c2 (10Roan Kattouw) (In reply to Tim Down from comment #1) > Rangy has no reliance on Range.detach now. The latest release does not use > it at all.... [23:34:39] 3VisualEditor / 3Mobile: VisualEditor Mobile:[Regression wmf16] Cannot scroll the link suggestions inside link inspector - 10https://bugzilla.wikimedia.org/69038 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2,Select a text 3.Open the link inspector...