[02:12:49] (03PS1) 10Catrope: Don't send API requests to preview empty (or whitespace-only) edit summaries [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151376 [02:17:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: Provide a way for the user to switch between VisualEditor and wikitext source editor modes without saving - 10https://bugzilla.wikimedia.org/47779#c17 (10Alex Monk) So with the resolution of bug 50687, this is effectively "Provide a way for the user to sw... [02:52:37] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Unknown error" on saving on officewiki - 10https://bugzilla.wikimedia.org/68235#c5 (10Roan Kattouw) 5ASSI>3RESO/FIX This was caused by local JS overwriting Function.prototype.bind with a broken polyfill that ignores additional parameters rather than... [02:58:15] Urgh. Broken overriding of functions like that on officewiki, of all places. [02:58:38] private wikis are the most neglected [03:06:19] I wonder if we should check other wikis for issues with bind [03:06:32] That code was an import [03:08:37] mwgrep! [03:10:08] legoktm, you running that? [03:11:05] sure [03:12:45] I went to look for what that is, turns out it's some script in operations/puppet that talks to the search engine (search.svc.eqiad.wmnet:9200) directly, so obviously it needs someone with access to run it [03:13:24] https://dpaste.de/JS7k/raw [03:14:51] Mostly for that same damn gadget. Really wish we'd stop copying around gadget files like that. [09:39:09] 3VisualEditor / 3ContentEditable: "There are no references on this page to include in this list." even that refs exists - 10https://bugzilla.wikimedia.org/69066 (10Raimond Spekking) 3NEW p:3Unprio s:3normal a:3None "There are no references on this page to include in this list." even that refs exists,... [09:53:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Unknown error" on saving on officewiki - 10https://bugzilla.wikimedia.org/68235#c6 (10James Forrester) https://dpaste.de/JS7k/raw courtesy of legoktm is an mwgrep of all of the redefinitions of bind on the cluster. Yay. [10:20:24] 3VisualEditor / 3Data Model: VisualEditor: [Regression] References in templates don't appear in references list - 10https://bugzilla.wikimedia.org/51289 (10James Forrester) [10:20:52] 3VisualEditor / 3ContentEditable: "There are no references on this page to include in this list." even that refs exists - 10https://bugzilla.wikimedia.org/69066#c1 (10James Forrester) 5NEW>3RESO/DUP Unfortunately this is a long-standing issue about references defined inside templates – see bug 51289. :-(... [10:21:06] 3VisualEditor / 3Data Model: VisualEditor: [Regression] References in templates don't appear in references list - 10https://bugzilla.wikimedia.org/51289#c9 (10James Forrester) *** Bug 69066 has been marked as a duplicate of this bug. *** [10:26:23] 3VisualEditor / 3ContentEditable: VisualEditor: Language templates replaced by snowmen at Japanese Wikipedia - 10https://bugzilla.wikimedia.org/51883#c3 (10James Forrester) 5ASSI>3RESO/FIX a:3Roan Kattouw I think that this was finally fixed in Roan's great re-working of snowmen. [10:30:53] 3VisualEditor / 3ContentEditable: VisualEditor: Snowmen being created (no reproduction steps) - 10https://bugzilla.wikimedia.org/57884#c4 (10James Forrester) 5ASSI>3RESO/FIX a:3Roan Kattouw I believe that we fixed the last of the snowmen issues (ha!) with the re-write last week; I've not been able to r... [10:32:46] (03PS1) 10Esanders: Set selection before focusing document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151400 (https://bugzilla.wikimedia.org/68589) [10:51:05] 3VisualEditor / 3ContentEditable: VisualEditor: Cursoring off gallery into slug scrolls viewport to the top of the document, not the slug - 10https://bugzilla.wikimedia.org/68589 (10James Forrester) [10:51:05] 3VisualEditor / 3Editing Tools: VisualEditor: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - 10https://bugzilla.wikimedia.org/68590 (10James Forrester) [10:51:05] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Switch to source editor" text overlaps with selection indicator; should expand menu or wrap if needed - 10https://bugzilla.wikimedia.org/57366 (10James Forrester) [10:51:05] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10James Forrester) [10:51:06] 3VisualEditor / 3ContentEditable: VisualEditor: Remove media or templates, page loses focus - 10https://bugzilla.wikimedia.org/68708 (10James Forrester) [10:51:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: After saving a page reference list gets missing (unless it is refreshed again) and the page gets categorized as "Pages with missing reference list" - 10https://bugzilla.wikimedia.org/68182 (10James Forrester) [10:51:08] 3VisualEditor / 3Data Model: VisualEditor: Typing at the beginning of the document pulls annotations from the right; should instead be null - 10https://bugzilla.wikimedia.org/68597 (10James Forrester) [10:51:09] 3VisualEditor / 3Editing Tools: VisualEditor: Append references list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906 (10James Forrester) [10:51:10] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf16] Cannot scroll up/down a page in mobile when the keyboard is open and cursor active on CE - 10https://bugzilla.wikimedia.org/68828 (10James Forrester) [10:51:11] 3VisualEditor / 3Data Model: VisualEditor: tags appear when editing on the Hebrew Wiki - 10https://bugzilla.wikimedia.org/66210 (10James Forrester) [10:51:12] 3VisualEditor / 3ContentEditable: VisualEditor: Putting cursor after reference list throws "offset was inside a handlesOwnChildren node" error - 10https://bugzilla.wikimedia.org/68588 (10James Forrester) [10:51:13] 3VisualEditor / 3Editing Tools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - 10https://bugzilla.wikimedia.org/68537 (10James Forrester) [10:51:14] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10James Forrester) [10:51:15] 3VisualEditor / 3ContentEditable: VisualEditor: Copying text sometimes makes the page jump/scroll in Firefox - 10https://bugzilla.wikimedia.org/55433 (10James Forrester) [11:21:38] 3VisualEditor / 3Data Model: VisualEditor: Selection after deleting block focusablenode (e.g. image) is weird - 10https://bugzilla.wikimedia.org/62579#c1 (10James Forrester) 5ASSI>3RESO/FIX a:3Ed Sanders This looks OK now… assuming that Ed fixed it. Go Ed. [11:22:08] 3VisualEditor / 3Mobile: VisualEditor: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110#c8 (10James Forrester) *** Bug 67257 has been marked as a duplicate of this bug. *** [11:22:08] 3VisualEditor / 3Mobile: VisualEditor Mobile: Focusable nodes can't be deleted - 10https://bugzilla.wikimedia.org/67257#c1 (10James Forrester) 5ASSI>3RESO/DUP Same problem as on iOS. Merging. *** This bug has been marked as a duplicate of bug 60110 *** [11:22:49] (03PS2) 10Jforrester: Set selection before focusing document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151400 (https://bugzilla.wikimedia.org/68589) (owner: 10Esanders) [11:23:06] (03CR) 10Jforrester: [C: 032] "Works beautifully." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151400 (https://bugzilla.wikimedia.org/68589) (owner: 10Esanders) [11:24:31] (03Merged) 10jenkins-bot: Set selection before focusing document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151400 (https://bugzilla.wikimedia.org/68589) (owner: 10Esanders) [11:25:10] 3VisualEditor / 3ContentEditable: VisualEditor: Cursoring off gallery into slug scrolls viewport to the top of the document, not the slug - 10https://bugzilla.wikimedia.org/68589 (10James Forrester) 5PATC>3RESO/FIX [11:25:10] 3VisualEditor / 3ContentEditable: VisualEditor: Remove media or templates, page loses focus - 10https://bugzilla.wikimedia.org/68708 (10James Forrester) 5PATC>3RESO/FIX [15:41:21] (03PS1) 10Vikassy: Added browser tests for Formula [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151419 [15:42:25] (03PS2) 10Vikassy: [BrowserTest] Added browser tests for Formula [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151419 [16:30:33] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=64580580 [16:30:33] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=67371838 [16:30:33] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=67372267 [16:30:33] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=67372335 [16:30:33] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=67372409 [16:30:34] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=67384147 [16:30:34] Corruption alert: visualeditor-needcheck on dawiki: https://da.wikipedia.org/?diff=7726080 [17:09:37] 3VisualEditor / 3Editing Tools: VisualEditor: ve.ui.MWMediaSearchWidget fails on private wikis due to forced use of JSON-P (logged-out API) - 10https://bugzilla.wikimedia.org/64822 (10James Forrester) 5PATC>3RESO/FIX [20:44:51] (03PS1) 10Catrope: Use .lookup() instead of .create().constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151506 [20:45:34] (03CR) 10Catrope: [C: 032] "I checked and sure enough, we have code that blacklists subclasses of blacklisted annotations. We're cleverer than I thought :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151281 (owner: 10Bartosz Dziewoński) [20:47:28] (03Merged) 10jenkins-bot: Blacklist annotating link node with more links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151281 (owner: 10Bartosz Dziewoński) [20:49:56] (03CR) 10Catrope: "Looks fine, didn't test yet. Suggestion inline" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151234 (https://bugzilla.wikimedia.org/68890) (owner: 10Alex Monk) [20:51:12] (03CR) 10Catrope: [C: 032] tests: Fix some minor issues flagged up by karma and related MW references [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151300 (owner: 10Jforrester) [23:17:56] (03PS1) 10Cscott: WIP: Implement ve.dm.Transaction.transpose() w/ intentions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151545 [23:18:40] (03CR) 10jenkins-bot: [V: 04-1] WIP: Implement ve.dm.Transaction.transpose() w/ intentions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151545 (owner: 10Cscott)