[13:02:01] (03PS3) 10Vikassy: [BrowserTest] Added browser tests for Formula and reference list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151419 [13:05:56] (03PS2) 10Alex Monk: Only build reference search index when it's been changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151234 (https://bugzilla.wikimedia.org/68890) [13:48:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Unknown error" on saving on officewiki - 10https://bugzilla.wikimedia.org/68235#c7 (10Alex Monk) So that last srwikibooks entry appears to be in an unused file... Roan, can you release and upstream the LAPI.js changes to the other wikis? I don't think I... [14:22:07] 3VisualEditor / 3Data Model: VisualEditor: Media Settings dialog does not close, when inserting a media with a link or language "Uncaught TypeError: undefined is not a function" - 10https://bugzilla.wikimedia.org/69031#c1 (10Ritu Swain) I cannot reproduce it anymore in test2 or beta.Please close this issue. [14:35:07] 3VisualEditor / 3Data Model: VisualEditor: Media Settings dialog does not close, when inserting a media with a link or language "Uncaught TypeError: undefined is not a function" - 10https://bugzilla.wikimedia.org/69031 (10Alex Monk) 5UNCO>3RESO/WOR [14:40:22] 3VisualEditor / 3Editing Tools: VisualEditor:Link Inspector icon is not appearing, when language is selected, in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68810#c3 (10Ritu Swain) Cannot reproduce it anymore in test2 or beta. [14:48:01] James_F|Away: when you get a chance, I have been talking to myself in http://etherpad.wikimedia.org/p/citoid-TD-fun [15:32:12] (03PS1) 10Vikassy: Added support for highlighting the page object elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151656 [15:34:21] (03PS2) 10Vikassy: [BrowserTest] Added support for highlighting the page object elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151656 [15:37:23] (03PS2) 10Cscott: Factor out ve.dm.Transaction.pushReplaceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116214 (owner: 10Catrope) [15:39:32] (03CR) 10jenkins-bot: [V: 04-1] Factor out ve.dm.Transaction.pushReplaceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116214 (owner: 10Catrope) [15:42:07] 3VisualEditor / 3Editing Tools: VisualEditor:Link Inspector icon is not appearing, when language is selected, in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68810#c4 (10James Forrester) Possibly fixed in 2014-07-31? [16:30:34] Corruption alert: visualeditor-needcheck on lawiki: https://la.wikipedia.org/?diff=2776159 [16:30:34] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=105986613 [16:30:34] Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=40005078 [16:30:34] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=67404431 [16:30:34] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=67404442 [17:07:08] James_F: ping [17:07:26] mvolz: Hey! [17:08:43] huh, i received a VE t-shirt today… and it's twice my size D: [17:08:46] so I had a rambling discussion with myself in the chat box: http://etherpad.wikimedia.org/p/citoid-TD-fun [17:09:42] major questions are: brackets, do we need them, or can the mappings just be implicit [17:09:52] and, please can I make a list of objects be a thing :) [17:10:07] and also, where do I actually fill out the mappings. [17:10:29] so far I am thinking list mappings get filled out in TD, but leave objects alone? [17:10:45] and then let VE do the object grokking... or ... [17:11:08] MatmaRex: I was a bit surprised about the size you asked for… [17:11:18] MatmaRex: I'll send you a different size if you bring that one back. [17:12:46] mvolz: Looking. [17:14:10] mvolz: Hmm, good question. I don't know what exact format we want to do there. [17:15:19] erm, to which question :) [17:16:12] "major questions are: brackets, do we need them, or can the mappings just be implicit" [17:16:26] A list of objects might work. I worry that it's too messy. [17:17:39] My instinct is just to make it implicit... for the case Authors[].Names[] what's literally going to be fed is a list and "Names" doesn't exist anywhere, unless we require the lists have a key... [17:18:13] which seems senseless [17:18:20] So it's ((.*)\[\]) [17:18:21] + [17:18:24] Bah. [17:19:40] The idea is that the services' outputs map's keys are opaque to TemplateData. [17:19:50] But that doesn't work if we use []s to identify things. [17:20:45] yes. so I say we just used the names, and then it's up to the person to know what structure they should apply to it [17:21:21] Yeah. [17:21:23] But then. [17:22:30] I worry about how flexible it might be. [17:23:35] James_F: huh. i am positive i didn't want an L… stupid google forms [17:23:53] MatmaRex: No worries. :-) [17:24:18] ok. q 3. this question may or may not make any sense [17:24:58] I am hoping it is obvious to you [17:25:03] :-D [17:27:03] but where do I actually expand the mappings i.e. in the case of the lists [17:27:18] do I return it expanded in the blob already? [17:27:26] and then I can't do that with objects [17:27:41] well I guess for objs they don't really have to be expanded. [17:28:06] or would it stay structured in VE. [17:32:37] (sorry, I know td doesn't return anything, just talking about what the blob will look like :)) [17:33:36] I'm concerned about it not being mapped in the blob already mostly because I'm afraid the structure will get messed up [17:45:00] (03CR) 10Jforrester: [C: 032] Tear down meta dialog pages when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151088 (https://bugzilla.wikimedia.org/68484) (owner: 10Alex Monk) [17:45:25] (03PS7) 10Jforrester: Tear down meta dialog pages when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151088 (https://bugzilla.wikimedia.org/68484) (owner: 10Alex Monk) [17:46:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] Each category is getting added twice in Betalabs, throws TypeError: categoryItem is undefined - 10https://bugzilla.wikimedia.org/68484 (10James Forrester) 5PATC>3RESO/FIX [17:49:03] (03CR) 10Jforrester: [C: 032] Don't send API requests to preview empty (or whitespace-only) edit summaries [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151376 (owner: 10Catrope) [17:50:36] (03Merged) 10jenkins-bot: Don't send API requests to preview empty (or whitespace-only) edit summaries [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151376 (owner: 10Catrope) [18:10:54] 3VisualEditor: VisualEditor: "Cancel" button in the Save dialog is confusing. How about "Resume editing"? - 10https://bugzilla.wikimedia.org/69116 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None The new Save dialog has two buttons at the top: "Cancel" and "Save" It's not clear whether Cancel mean... [18:24:52] 3VisualEditor / 3Editing Tools: VisualEditor: When adding a new template, auto-open the "add parameter" section and put the cursor in the search dialog's input when we tab to it - 10https://bugzilla.wikimedia.org/55925#c5 (10WhatamIdoing) Works for me! Thanks. [18:28:24] Hrm, just saw (on enwiki) duplication of the "common edit summaries" drop downs [18:28:38] Only happened after reviewing changes and going back to the save form. [18:28:55] Dunno if that's your domain, but just FYI [18:30:07] 3VisualEditor / 3ContentEditable: VisualEditor: Editing window does not scroll when dragging - 10https://bugzilla.wikimedia.org/51669#c8 (10Juan de Vojníkov) I found this a problem to. When additing using just a touchpad or not having a scroll option on the mouse, you have a difficulties to move and object. [18:34:39] 3VisualEditor: VisualEditor: Placing some templates in bulleted lists causes complex transclusions - 10https://bugzilla.wikimedia.org/69117 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None Steps to Reproduce: 1. Open https://ru.wikipedia.org/w/index.php?oldid=63644335&veaction=edit and look at the sec... [18:37:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: Reference should use system messages to work out their rendering style (e.g. 1.0, 1.1 / a,b,c) - 10https://bugzilla.wikimedia.org/49346#c2 (10WhatamIdoing) I think that this is the same problem: Footnotes created with the ref group 3VisualEditor / 3Data Model: VisualEditor:Applying Use this Group to references, results into tools in VE Toolbar behaving oddly gives error "KeyedNodes is Undefined" - 10https://bugzilla.wikimedia.org/69119 (10Ritu Swain) 3UNCO p:3Unprio s:3major a:3None Created attachment 16136 --> https://bugzil... [19:17:40] 3VisualEditor / 3Data Model: VisualEditor:Applying Use this Group to references, results into tools in VE Toolbar behaving oddly gives error "KeyedNodes is Undefined" - 10https://bugzilla.wikimedia.org/69119 (10Ritu Swain) [19:52:22] 3VisualEditor / 3MediaWiki integration: VisualEditor: Provide a way for the user to switch between VisualEditor and wikitext source editor modes without saving - 10https://bugzilla.wikimedia.org/47779#c18 (10Matthew Flaschen) (In reply to Alex Monk from comment #17) > So with the resolution of bug 50687, thi... [20:20:22] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195#c3 (10Rummana Yasmeen) Double tapping on backspace takes to a blank page [20:31:54] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf16]Opening link inspector/comment box in an empty line opens them at the end of the previous line - 10https://bugzilla.wikimedia.org/69122 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16137 --> https://bugzilla.... [20:32:36] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf16]Opening link inspector/comment box in an empty line, opens them at the end of the previous line - 10https://bugzilla.wikimedia.org/69122 (10Rummana Yasmeen) [21:01:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000#c7 (10Rummana Yasmeen) 5RESO/FIX>3REOP This is again happening in production... [21:10:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000 (10Rummana Yasmeen) [21:10:22] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000 (10Rummana Yasmeen) 5REOP>3ASSI [21:12:22] 3VisualEditor / 3Mobile: VisualEditor Mobile: The "Go back" button in use existing reference dialog in mobile takes to Basic Reference dialog - 10https://bugzilla.wikimedia.org/68201#c6 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:15:26] marktraceur: That's a local wiki gadget. [21:20:10] OK James_F. [21:24:22] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] Save button in save dialog remains active while save is in progress and throws "Uncaught TypeError: Cannot read property '$saveOptions' of null" - 10https://bugzilla.wikimedia.org/68073#c10 (10Rummana Yasmeen) 5RESO/?>3VERI Veri... [21:25:54] (03PS3) 10Cscott: Factor out ve.dm.Transaction.pushReplaceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116214 (owner: 10Catrope) [21:25:56] (03PS1) 10Cscott: Fix `Transaction.isNoOp` test. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151776 [21:25:58] (03PS1) 10Cscott: WIP: Record intention in ve.dm.Transaction object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 [21:26:45] (03CR) 10Cscott: "The issue catrope raised has been fixed in Ie01d917b83e9c8b486ac0539ae1b2c6dea9e18d1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/84439 (owner: 10Cscott) [21:30:25] 3VisualEditor: VisualEditor: Citation number 0 - 10https://bugzilla.wikimedia.org/69125 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None * Add a basic citation * Add another non-basic(?) citation * Go back and set group of basic citation to something, apply changes * Undo changes twice [21:32:51] 3VisualEditor / 3Editing Tools: VisualEditor: "TypeError: Cannot read property 'context' of undefined" on pressing return after a reference node - 10https://bugzilla.wikimedia.org/68462#c4 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:34:40] (03PS1) 10Cscott: Add ve.dm.Transaction.newNoOp() constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 [21:36:37] 3VisualEditor / 3Editing Tools: VisualEditor: Use existing reference dialog gets squished upon resizing the window down and does not retain back its UI upon making window size normal - 10https://bugzilla.wikimedia.org/68232#c10 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:36:51] 3VisualEditor / 3Data Model: VisualEditor:Applying Use this Group to references, results into tools in VE Toolbar behaving oddly gives error "KeyedNodes is Undefined" - 10https://bugzilla.wikimedia.org/69119#c1 (10Alex Monk) (In reply to Ritu Swain from comment #0) > 1> Open a page with at least three differ... [21:38:37] 3VisualEditor: VisualEditor: Citation number 0 - 10https://bugzilla.wikimedia.org/69125#c1 (10Alex Monk) Also if you undo again, you get this: Uncaught TypeError: Cannot read property 'length' of undefined Then this: Uncaught TypeError: Cannot read property 'canHaveChildren' of null Then this: Uncaught Error:... [21:46:07] 3VisualEditor / 3Editing Tools: VisualEditor:While switching to edit source mode without making any edit through the Page Options , the confirmation dialog for saving change appears - 10https://bugzilla.wikimedia.org/68229#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:47:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf15] Pressing return after a link is throwingTypeError: Cannot read property 'getOuterLength' of undefined VM112:521 - 10https://bugzilla.wikimedia.org/68415#c6 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:49:07] 3VisualEditor / 3Editing Tools: VisualEditor: Scroll bar is appearing inside the language inspector - 10https://bugzilla.wikimedia.org/68053#c3 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:52:38] 3VisualEditor / 3Editing Tools: VisualEditor: After changing the size of an image and applying changes, the image size changes but does not get updated in the Media dialog until saving the page - 10https://bugzilla.wikimedia.org/68242#c4 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:53:22] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf12] The Math Inspector loses its focus each time a character is inserted when it tries to parse the new value - 10https://bugzilla.wikimedia.org/67326#c7 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [22:01:55] 3VisualEditor / 3Editing Tools: VisualEditor: The size of References List dialog is appearing a bit small in Firefox making the text field almost overlap with the edge of the dialog - 10https://bugzilla.wikimedia.org/68226#c8 (10Rummana Yasmeen) Verified the fix in production [22:01:56] 3VisualEditor / 3Editing Tools: VisualEditor: The size of References List dialog is appearing a bit small in Firefox making the text field almost overlap with the edge of the dialog - 10https://bugzilla.wikimedia.org/68226#c7 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [22:03:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] Link inspector is not opening up in FF in first attempt, upon trying second time it throws error "TypeError: manager.opening is null" and appears with broken UI - 10https://bugzilla.wikimedia.org/68223#c7 (10Rummana Yasmeen) 5RESO/?>3VERI V... [22:09:53] 3VisualEditor / 3Mobile: VisualEditor Mobile: MobileContext is not in the DOM - 10https://bugzilla.wikimedia.org/68546#c3 (10Rummana Yasmeen) Verified the fix in Betalabs and test2 [22:13:22] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf16] Scrolling and tapping into CE goes dead after using link inspector - 10https://bugzilla.wikimedia.org/68878#c3 (10Rummana Yasmeen) Verified the fix in betalabs and test2 [22:22:22] 3VisualEditor / 3Editing Tools: VisualEditor: Language dialog launched from inspector doesn't open in a global overlay - 10https://bugzilla.wikimedia.org/68486#c5 (10Rummana Yasmeen) Hey Ritu, Can you specify the environment where you checked the fix? [22:32:22] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot include the same existing reference after adding it once in an article - 10https://bugzilla.wikimedia.org/68582#c6 (10Rummana Yasmeen) Verified the fix in test2 [22:51:07] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438#c5 (10Rummana Yasmeen) This is fixed in Betalabs but not on test2, moving it to the next sprint. [22:51:10] 3VisualEditor / 3Editing Tools: VisualEditor: The reference name for a newly added reference is not appearing in the dialog for "Use existing reference" while opening it for the first time - 10https://bugzilla.wikimedia.org/67342#c5 (10Rummana Yasmeen) Verified the fix in test2 [22:51:10] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf15] Re-use existing citation dialog never rebuilds list of references after first opening - 10https://bugzilla.wikimedia.org/68869#c4 (10Rummana Yasmeen) Verified the fix in test2 [23:16:35] (03PS2) 10Cscott: WIP: Record intention in ve.dm.Transaction object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 [23:16:37] (03PS2) 10Cscott: WIP: Implement ve.dm.Transaction.transpose() w/ intentions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151545 [23:16:39] (03PS2) 10Cscott: Add ve.dm.Transaction.newNoOp() constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 [23:16:41] (03PS1) 10Cscott: Add ve.dm.Transaction.newFromIntention() method. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151798 [23:16:43] (03PS1) 10Cscott: WIP: Add ve.dm.Transaction.copy() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151799 [23:17:24] (03CR) 10jenkins-bot: [V: 04-1] WIP: Implement ve.dm.Transaction.transpose() w/ intentions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151545 (owner: 10Cscott) [23:18:39] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add ve.dm.Transaction.copy() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151799 (owner: 10Cscott) [23:23:02] huh, what's this? i thought that's not supposed to happen... https://pl.wikipedia.org/w/index.php?title=Żółwin_(województwo_mazowieckie)&curid=407082&diff=40002128&oldid=39071781 [23:26:16] (03PS2) 10Cscott: Fix `Transaction.isNoOp` test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151776 [23:26:18] (03PS3) 10Cscott: WIP: Record intention in ve.dm.Transaction object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 [23:26:20] (03PS2) 10Cscott: WIP: Add ve.dm.Transaction.copy() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151799 [23:26:22] (03PS3) 10Cscott: WIP: Implement ve.dm.Transaction.transpose() w/ intentions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151545 [23:26:24] (03PS2) 10Cscott: Add ve.dm.Transaction.newFromIntention() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151798 [23:26:26] (03PS3) 10Cscott: Add ve.dm.Transaction.newNoOp() constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 [23:26:28] (03PS4) 10Cscott: Factor out ve.dm.Transaction.pushReplaceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116214 (owner: 10Catrope) [23:27:18] (03CR) 10jenkins-bot: [V: 04-1] WIP: Implement ve.dm.Transaction.transpose() w/ intentions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151545 (owner: 10Cscott) [23:45:22] 3VisualEditor / 3Data Model: VisualEditor:Applying Use this Group to references, results into tools in VE Toolbar behaving oddly gives error "KeyedNodes is Undefined" - 10https://bugzilla.wikimedia.org/69119#c2 (10Ritu Swain) (In reply to Alex Monk from comment #1) > (In reply to Ritu Swain from comment #0)... [23:49:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] TypeError: Cannot read property 'context' of undefined appears when you try to insert another image that appears on the same index as the previous search, right after you inserted one - 10https://bugzilla.wikimedia.org/67749#c7 (10Rummana Yasmee...