[03:14:07] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832#c9 (10Juliusz Gonera) Reverting 71395e1f (https://gerrit.wikimedia.org/r/#/c/139677/) fixes this bug but brings back bug 65928. Need to consult with Ed. [08:37:49] (03Abandoned) 10Vikassy: [BrowserTest] Do not zoom on specific scenarios to avoid scrollbars [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150553 (owner: 10Vikassy) [08:41:55] (03PS3) 10Vikassy: [BrowserTest] Browser can now zoom out whenever required [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150833 [08:54:52] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Browser can now zoom out whenever required [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150833 (owner: 10Vikassy) [08:56:50] (03Merged) 10jenkins-bot: [BrowserTest] Browser can now zoom out whenever required [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150833 (owner: 10Vikassy) [08:58:22] hi, someone here is in the hackathon? [09:23:53] 3VisualEditor / 3MediaWiki integration: VisualEditor: Broken DivX browser plugin causes "myEventWatcherDiv" to be injected into the page - 10https://bugzilla.wikimedia.org/51423#c18 (10Alex Monk) Has anyone here managed to actually get this to happen in their browser yet? James tried the DivX plugin in Safar... [09:31:37] 3VisualEditor / 3Data Model: VisualEditor: (Possibly) Yet Another Broken Browser Plugin injecting mess into edits (Google Maps?) - 10https://bugzilla.wikimedia.org/65227 (10Alex Monk) 5ASSI>3UNCO [09:33:12] 3VisualEditor / 3Data Model: VisualEditor: (Possibly) Yet Another Broken Browser Plugin injecting mess into edits (Google Maps?) - 10https://bugzilla.wikimedia.org/65227#c5 (10Alex Monk) 5UNCO>3RESO/WOR apparently worksforme is the correct resolution for this situation [09:37:23] (03PS5) 10Cscott: WIP: Record intention in ve.dm.Transaction object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 [09:37:25] (03PS4) 10Cscott: WIP: Add ve.dm.Transaction.copy() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151799 [09:37:27] (03PS4) 10Cscott: WIP: Implement ve.dm.Transaction.transpose() w/ intentions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151545 [09:37:29] (03PS4) 10Cscott: Add ve.dm.Transaction.newFromIntention() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151798 [09:37:31] (03PS5) 10Cscott: Add ve.dm.Transaction.newNoOp() constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 [09:37:33] (03CR) 10jenkins-bot: [V: 04-1] WIP: Record intention in ve.dm.Transaction object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 (owner: 10Cscott) [09:37:37] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add ve.dm.Transaction.copy() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151799 (owner: 10Cscott) [09:37:39] (03CR) 10jenkins-bot: [V: 04-1] WIP: Implement ve.dm.Transaction.transpose() w/ intentions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151545 (owner: 10Cscott) [09:37:41] (03CR) 10jenkins-bot: [V: 04-1] Add ve.dm.Transaction.newFromIntention() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151798 (owner: 10Cscott) [09:37:43] (03CR) 10jenkins-bot: [V: 04-1] Add ve.dm.Transaction.newNoOp() constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 (owner: 10Cscott) [10:01:09] (03PS1) 10Eloquence: Change label in dialog: "Change image" -> "Choose a different image" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152235 [10:04:02] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152235 (owner: 10Eloquence) [10:30:11] (03PS7) 10Trevor Parscal: [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 [10:30:19] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal) [11:05:01] (03PS6) 10Mooeypoo: [wip] Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 [11:10:49] (03CR) 10jenkins-bot: [V: 04-1] [wip] Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (owner: 10Mooeypoo) [11:12:15] wat [11:12:37] oh, qunit. [11:14:17] (03PS8) 10Trevor Parscal: [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 [11:14:19] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal) [11:15:37] (03PS7) 10Mooeypoo: Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 [11:26:20] (03PS1) 10Esanders: Show metadata in the debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152261 [11:26:24] (03PS9) 10Trevor Parscal: [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 [11:26:31] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal) [11:26:54] 3VisualEditor: Firefox: Cite/Add more information responds to right-click but should not - 10https://bugzilla.wikimedia.org/69229 (10Chris McMahon) 3NEW p:3Unprio s:3minor a:3None Created attachment 16149 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16149&action=edit Add more information elem... [11:27:52] 3VisualEditor: Firefox: Cite/Add more information responds to right-click but should not - 10https://bugzilla.wikimedia.org/69229 (10Chris McMahon) 5NEW>3RESO/INV [11:28:44] (03PS10) 10Trevor Parscal: [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 [11:29:46] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal) [11:30:11] 3VisualEditor: Firefox: Cite/Add more information responds to right-click but should not - 10https://bugzilla.wikimedia.org/69230 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 16150 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16150&action=edit Add more information ele... [11:30:22] 3VisualEditor: Firefox: Cite/Add more information responds to right-click but should not - 10https://bugzilla.wikimedia.org/69230 (10Chris McMahon) s:5normal>3minor [11:32:36] (03PS22) 10Zfilipin: WIP: [BrowserTest] Adding step definition and page object for external link scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (https://bugzilla.wikimedia.org/63104) (owner: 10Jagori79) [11:38:30] (03CR) 10Zfilipin: [C: 04-1] WIP: [BrowserTest] Adding step definition and page object for external link scenario (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (https://bugzilla.wikimedia.org/63104) (owner: 10Jagori79) [11:47:12] (03PS11) 10Trevor Parscal: [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 [11:48:32] if one of you could take a look at https://www.mediawiki.org/wiki/User_talk:Elitre_(WMF)#VE_translathon , especially where messages are linked, I'd appreciate if you could give me directions so I can tell the user :) [12:08:03] So visualeditor-mediasizewidget-label-scale seems unused - it's the label for a scaling-related thing, but that's not actually added to the page - it's commented with "TODO: when upright is supported by Parsoid" [12:09:50] Krenair: Yeah. [12:11:15] visualeditor-dialog-meta-settings-newsectioneditlink-force is used on the advanced settings page as the left option for "Show a tab on this page to add a new section" [12:11:15] visualeditor-dialog-meta-settings-newsectioneditlink-disable for the right option there [12:11:16] (visualeditor-dialog-meta-settings-newsectioneditlink-default for the middle) [12:12:41] Same thing with the "Let this page be indexed by search engines" stuff [12:12:41] (for the -index- messages) [12:16:33] (03PS2) 10Zfilipin: WIP [BrowserTest] Use rspec-expectations expect syntax instead of should syntax [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146712 (https://bugzilla.wikimedia.org/66369) (owner: 10Jagori79) [12:19:37] (03CR) 10Zfilipin: [C: 031] "Looks good to me. Not merging because the commit is marked WIP." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146712 (https://bugzilla.wikimedia.org/66369) (owner: 10Jagori79) [13:21:27] (03PS19) 10Krinkle: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [13:46:06] (03PS6) 10Cmcmahon: [BrowserTest] WIP: create new test for Cite tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150055 [14:02:12] (03CR) 10Catrope: [C: 04-1] Show metadata in the debug bar (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152261 (owner: 10Esanders) [14:22:26] (03PS20) 10Krinkle: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [14:22:34] (03CR) 10Krinkle: Refactor TemplateData Editor (039 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [14:22:43] (03CR) 10Krinkle: [C: 04-1] "See:" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [14:41:24] 3VisualEditor / 3Editing Tools: VisualEditor: Link icon is broken in Monobook skin - 10https://bugzilla.wikimedia.org/69242 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Created attachment 16151 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16151&action=edit screenshot 1> Open a page in V... [14:41:52] 3VisualEditor / 3Editing Tools: VisualEditor: Link icon is broken in Monobook skin - 10https://bugzilla.wikimedia.org/69242 (10Ritu Swain) [14:48:52] 3VisualEditor / 3Editing Tools: VisualEditor: Link icon is broken in Monobook skin - 10https://bugzilla.wikimedia.org/69242#c1 (10Ritu Swain) Similar behavior found with the other icons as well, like - Comment,Language. [14:57:37] (03PS2) 10Esanders: Show metadata in the debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152261 [15:36:09] 3VisualEditor / 3Editing Tools: VisualEditor: Link icon is broken in Monobook skin - 10https://bugzilla.wikimedia.org/69242#c2 (10Andre Klapper) What does "is broken" or "look broken" mean exactly here? [15:36:51] (03PS1) 10Mooeypoo: Remove deprecated types from templatedata editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/152749 [15:38:04] (03CR) 10jenkins-bot: [V: 04-1] Remove deprecated types from templatedata editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/152749 (owner: 10Mooeypoo) [15:41:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/152749 (owner: 10Mooeypoo) [16:09:49] hi [16:10:16] could the reflist being inserted automatically, when you insert first reference? [16:10:43] I guess newbies might not know, they should also insert reflist [16:13:37] I think it may be problematic since: 1. sometimes there are templates for reflist and not usage of the regular [16:13:59] but more serious problem: in different languages there are different customs where to place the reflist [16:27:15] (03PS1) 10Esanders: Queue up annotation changes to make operations safer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152776 (https://bugzilla.wikimedia.org/68892) [16:28:11] eranroz: really? I thought its always placed somewhere on the bottom [16:30:33] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32179166 [17:03:21] (03Abandoned) 10Mooeypoo: Check for changes in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150478 (https://bugzilla.wikimedia.org/68058) (owner: 10Mooeypoo) [17:04:42] (03PS1) 10Mooeypoo: [wip] Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) [17:06:44] (03CR) 10jenkins-bot: [V: 04-1] [wip] Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) (owner: 10Mooeypoo) [17:08:49] * edsanders joins #oojs [17:26:15] (03PS2) 10Mooeypoo: [wip] Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) [17:27:55] (03CR) 10jenkins-bot: [V: 04-1] [wip] Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) (owner: 10Mooeypoo) [20:12:22] 3VisualEditor / 3Editing Tools: VisualEditor: Link icon is broken in Monobook skin - 10https://bugzilla.wikimedia.org/69242#c3 (10Ritu Swain) (In reply to Andre Klapper from comment #2) > What does "is broken" or "look broken" mean exactly here? As the cursor moves on the link,the tip ("^") of the link icon... [20:50:54] 3VisualEditor / 3Editing Tools: VisualEditor: Edit comment dialog turns blank, when applying a text style. - 10https://bugzilla.wikimedia.org/69262 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Created attachment 16155 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16155&action=edit screen... [20:51:07] 3VisualEditor / 3Editing Tools: VisualEditor: Edit comment dialog turns blank, when applying a text style. - 10https://bugzilla.wikimedia.org/69262 (10Ritu Swain) [21:05:10] 3VisualEditor / 3Editing Tools: VisualEditor:Text style drop-down overridden by edit comment, in Monobook skin. - 10https://bugzilla.wikimedia.org/69263 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Created attachment 16156 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16156&action=edit sc... [21:05:22] 3VisualEditor / 3Editing Tools: VisualEditor:Text style drop-down overridden by edit comment, in Monobook skin. - 10https://bugzilla.wikimedia.org/69263 (10Ritu Swain) [21:24:08] 3VisualEditor / 3Editing Tools: VisualEditor: Edit comment dialog turns blank, when applying a text style, Uncaught TypeError:Cannot Read Property 'getSurface of null'. - 10https://bugzilla.wikimedia.org/69262#c1 (10Ritu Swain) JS Console error- Uncaught TypeError:Cannot Read Property 'getSurface of null'. [21:27:23] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697#c2 (10Juliusz Gonera) Might be related to bug 68832. [21:34:11] 3MediaWiki extensions / 3TemplateData: TemplateData: Please suppress the "Manage template documentation" button when the template doesn't exist - 10https://bugzilla.wikimedia.org/69268 (10WhatamIdoing) 3NEW p:3Unprio s:3enhanc a:3None Steps to reproduce: 1. Click on https://en.wikipedia.org/w/inde... [21:44:07] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832#c10 (10Juliusz Gonera) Digging deeper into the rabbit hole... * Commenting out "this.emit( 'select', this.selection && this.selection.clone() );" in ve.dm...