[00:09:53] (03PS1) 10Jforrester: package: Fix typo pointing to the wrong path for oojs.js [oojs/core] - 10https://gerrit.wikimedia.org/r/153361 [00:10:28] (03CR) 10Esanders: [C: 032] package: Fix typo pointing to the wrong path for oojs.js [oojs/core] - 10https://gerrit.wikimedia.org/r/153361 (owner: 10Jforrester) [00:13:55] (03Merged) 10jenkins-bot: package: Fix typo pointing to the wrong path for oojs.js [oojs/core] - 10https://gerrit.wikimedia.org/r/153361 (owner: 10Jforrester) [01:16:26] 3VisualEditor / 3Data Model: VisualEditor: References created by templates numbered alone, not with the rest of the page, and don't show up as references to insert - 10https://bugzilla.wikimedia.org/50474#c32 (10Bartosz Dziewoński) *** Bug 69373 has been marked as a duplicate of this bug. *** [01:16:26] 3VisualEditor: VisualEditor: s in a section-edit get re-numbered - 10https://bugzilla.wikimedia.org/69373#c1 (10Bartosz Dziewoński) 5NEW>3RESO/DUP This sounds like the same thing as what's described as bug 50474. *** This bug has been marked as a duplicate of bug 50474 *** [01:19:08] 3VisualEditor / 3Editing Tools: VisualEditor: Stop users from deleting parameters in the template dialog if they're marked as "required" in TemplateData - 10https://bugzilla.wikimedia.org/60358 (10Bartosz Dziewoński) [01:19:09] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog should recommend TemplateData-hinted mandatory parameters - 10https://bugzilla.wikimedia.org/50747 (10Bartosz Dziewoński) [10:36:23] 3VisualEditor / 3ContentEditable: VisualEditor: A template with the RLM control character doesn't work when editing in VE - 10https://bugzilla.wikimedia.org/51978#c6 (10Amir E. Aharoni) At Wikimania Moriel, Roan and I found that the bug, as originally reported, appears to be fixed. I don't know when exactly... [10:45:39] 3VisualEditor / 3ContentEditable: VisualEditor: A template with the RLM control character doesn't work when editing in VE - 10https://bugzilla.wikimedia.org/51978#c7 (10James Forrester) 5ASSI>3RESO/FIX a:3Ed Sanders (In reply to Amir E. Aharoni from comment #6) > At Wikimania Moriel, Roan and I found t... [10:48:53] 3VisualEditor / 3ContentEditable: VisualEditor: Hidden templates should display as an icon in-page so they can be interacted with (e.g. a puzzle piece?) - 10https://bugzilla.wikimedia.org/49806#c26 (10James Forrester) As an additional item (from bug 51978 comment 6): > Using the {{כ}} template works correct... [12:09:25] 3VisualEditor: Incremental edit summary needed - 10https://bugzilla.wikimedia.org/69393 (10Spinningspark) 3NEW p:3Unprio s:3enhanc a:3None Intention: It should be possible to fill out the edit summary incrementally while editing is still taking place, not just in one hit at save time. Reproducible:... [12:20:09] 3OOjs UI: OOjs UI: Dialogs should be repositionable/draggable - 10https://bugzilla.wikimedia.org/49969#c17 (10Spinningspark) Why is this languishing at low priority? Fixing something that is preventing the editor from reading the thing he is editing is HIGH priority. [12:40:09] 3VisualEditor / 3MediaWiki integration: VisualEditor: Deal with en.wikipedia.org's edit notice system - 10https://bugzilla.wikimedia.org/43013#c20 (10Spinningspark) 5RESO/FIX>3REOP This is still occuring. Pages with no edit notices pop up with "1 notice" when VE is launched. It is not even useful in pr... [12:56:11] 3VisualEditor / 3Language: "Insert reference list" button partially hides "Reference list" heading in reference list dialog box - 10https://bugzilla.wikimedia.org/69396 (10Vikas) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16165 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16165&ac... [13:42:57] 3VisualEditor / 3ContentEditable: VisualEditor: Links should follow the local CSS rules as if they were rendered in the view mode (e.g. external links shown with the external icon) - 10https://bugzilla.wikimedia.org/38726#c6 (10Spinningspark) 5VERI>3REOP I'm not seeing this as entirely fixed. The redlin... [13:58:51] (03PS5) 10Vikassy: [BrowserTest] Added browser tests for Formula, reference list and save button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151419 [15:15:40] (03PS6) 10Vikassy: [BrowserTest] Added browser tests for Formula, reference list and save button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151419 [15:45:39] 3OOjs UI: OOjs UI: Dialogs should be repositionable/draggable - 10https://bugzilla.wikimedia.org/49969#c18 (10James Forrester) (In reply to Spinningspark from comment #17) > Why is this languishing at low priority? Fixing something that is preventing > the editor from reading the thing he is editing is HIGH pr... [15:54:22] (03CR) 10Zfilipin: [C: 04-1] [BrowserTest] Added browser tests for Formula, reference list and save button (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151419 (owner: 10Vikassy) [16:00:42] 3VisualEditor: VisualEditor: Don't allow a linking action if no text was highlighted before - 10https://bugzilla.wikimedia.org/68101#c7 (10Arthur Rubin) I don't know how to reopen this. As an Admin on en.Wikipedia, I can say that having "Escape" _not_ close the box and take none of the actions indicated in th... [16:25:39] Krenair: https://gerrit.wikimedia.org/r/#/c/153078/ [16:30:36] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=106177589 [16:30:36] Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=40050340 [16:36:55] 3VisualEditor: Visual editor should have a cancel button next to the save button - 10https://bugzilla.wikimedia.org/69406 (10Spinningspark) 3NEW p:3Unprio s:3enhanc a:3None Intention: Sometimes in a complex edit one realises that one has made a mistake but it is not too easy to unpick what has already... [16:38:09] 3VisualEditor: Visual editor should have a cancel button next to the save button - 10https://bugzilla.wikimedia.org/69406#c1 (10James Forrester) 5NEW>3RESO/WON We just removed the Cancel button because user testing showed that it wasn't helpful. Any link out of the editor leaves the editor… [16:48:38] 3VisualEditor: VisualEditor: Don't allow a linking action if no text was highlighted before - 10https://bugzilla.wikimedia.org/68101#c8 (10Andre Klapper) (In reply to Arthur Rubin from comment #7) > I don't know how to reopen this. You were asked to not reopen this, but to file a new and separate enhancement... [16:59:08] 3OOjs UI: OOjs UI: Dialogs should be repositionable/draggable - 10https://bugzilla.wikimedia.org/49969#c19 (10John Broughton) Just to be clear, this is a DESIGN TEAM problem, because it's a problem with the OOjs UI, which VE uses, but which is under the control of the Design team. The issue is that the OOjs UI... [17:02:42] 3VisualEditor: VisualEditor: Don't allow a linking action if no text was highlighted before - 10https://bugzilla.wikimedia.org/68101#c9 (10Arthur Rubin) (In reply to Andre Klapper from comment #8) > (In reply to Arthur Rubin from comment #7) > > I don't know how to reopen this. > > You were asked to not reope... [17:09:55] 3VisualEditor: "Esc" saves data - 10https://bugzilla.wikimedia.org/69407 (10Arthur Rubin) 3UNCO p:3Unprio s:3major a:3None Re bug 68101 > Load VE. Say "Foobar" is the first word on the page. > If you click on the link tool, by mistake or not, without selecting anything before, Foobar will automaticall... [17:12:53] 3OOjs UI: OOjs UI: Dialogs should be repositionable/draggable - 10https://bugzilla.wikimedia.org/49969#c20 (10Spinningspark) (In reply to James Forrester from comment #18) > (In reply to Spinningspark from comment #17) > > Why is this languishing at low priority? Fixing something that is preventing > > the edi... [17:26:53] 3VisualEditor: Visual editor should have a cancel button next to the save button - 10https://bugzilla.wikimedia.org/69406#c2 (10Mike Christie) This is probably my least favourite change to VE. I would really like to see the cancel button come back. I did use it, and find it frustrating to have to scroll to t... [17:40:09] 3VisualEditor: Visual editor should have a cancel button next to the save button - 10https://bugzilla.wikimedia.org/69406#c3 (10Spinningspark) What is this mysterious "user testing". Is this something happening offline out of sight of the community? [17:40:17] Krinkle: http://etherpad.wikimedia.org/p/hi6ZshFUi2 [17:40:29] James_F: https://git.wikimedia.org/summary/?r=unicodejs.git [17:40:53] 3VisualEditor: VisualEditor: Don't allow a linking action if no text was highlighted before - 10https://bugzilla.wikimedia.org/68101#c10 (10Andre Klapper) I hereby distance myself from that guy who wrote "enhancement" in comment 8, as differing interpretations and judgements of that term might trigger "lies".... [17:42:38] 3VisualEditor: VisualEditor: Don't allow a linking action if no text was highlighted before - 10https://bugzilla.wikimedia.org/68101#c11 (10Andre Klapper) Ah. Bug 69407. Alright, thanks. [17:51:49] James_F: http://unicodejs.mit-license.org [17:51:59] https://github.com/remy/mit-license/blob/master/users/unicodejs.json [18:10:12] James_F: I'm comparing it mostly to oojs-core and oojs-ui. Noticed your change adds jQuery 1.8 [18:10:16] looks like ve standalone still has that [18:10:26] Which change? [18:10:30] unicodejs [18:10:40] oojs core ui, and mw have 1.11 [18:10:52] Can we up version updates in a later commit rather than bundling it all together? [18:11:33] I'm still waiting for https://gerrit.wikimedia.org/r/#/c/151299/ and https://gerrit.wikimedia.org/r/#/c/153282/ to land… [18:24:53] 3VisualEditor: Incremental edit summary needed - 10https://bugzilla.wikimedia.org/69393#c1 (10WhatamIdoing) I believe that what SpinningSpark is actually requesting is to have the edit summary visible and editable on the main screen. Right now, you can fill out the edit summary incrementally, but you have to... [18:25:18] (03CR) 10Krinkle: build: Switch from qunit directly to karma for code coverage reports (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151299 (owner: 10Jforrester) [18:25:54] 3OOjs UI: OOjs UI: Menus appearing behind page content in Safari 6.1.x (not 6.0.x or 7.x) - 10https://bugzilla.wikimedia.org/64388#c24 (10Bryce Glover) (In reply to James Forrester from comment #22) > (In reply to Bryce Glover from comment #21) > > I'm still seeing this bug with Safari 6.1.4, guys; maybe it's... [18:26:38] 3OOjs UI: OOjs UI: Menus appearing behind page content in Safari 6.1.x (not 6.0.x or 7.x) - 10https://bugzilla.wikimedia.org/64388 (10Bryce Glover) [18:27:09] 3OOjs UI: OOjs UI: Menus appearing behind page content in Safari 6.1.3 and 7.0.5 - 10https://bugzilla.wikimedia.org/64388 (10Bryce Glover) [18:28:08] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/152122/3 [18:31:08] 3OOjs UI: OOjs UI: Menus appearing behind page content in Safari 6.1.3 and 7.0.5 - 10https://bugzilla.wikimedia.org/64388#c25 (10Bryce Glover) P. S.: I just looked at the duplicate bug, number 67741, and I realized that I *always* zoom in by two levels when I use Wikipedia! I will therefore check to see if V... [18:35:44] (03PS2) 10Jforrester: [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 [18:37:29] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 (owner: 10Jforrester) [18:43:59] (03PS3) 10Jforrester: build: Switch from qunit directly to karma for code coverage reports [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151299 [18:54:31] (03PS2) 10Krinkle: Use hasOwnProperty check in registry and lookup in factory [oojs/core] - 10https://gerrit.wikimedia.org/r/153356 (owner: 10Esanders) [18:56:22] (03PS3) 10Krinkle: Registry: Use hasOwnProperty check lookup() [oojs/core] - 10https://gerrit.wikimedia.org/r/153356 (owner: 10Esanders) [18:56:34] (03CR) 10Krinkle: Registry: Use hasOwnProperty check lookup() (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/153356 (owner: 10Esanders) [18:59:25] (03PS1) 10Krinkle: build: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/153429 [19:09:57] (03CR) 10Jforrester: [C: 032] "Works great, thanks." [oojs/core] - 10https://gerrit.wikimedia.org/r/153429 (owner: 10Krinkle) [19:13:21] jgonera: The fix for disabling the context menu for basic reference does not seem to be working in Betalabs :S [19:13:33] (03Merged) 10jenkins-bot: build: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/153429 (owner: 10Krinkle) [19:13:39] I see the patch merged though :https://gerrit.wikimedia.org/r/#/c/151807/ [19:14:10] ryasmeen, did you clear the browser cache? [19:14:22] I did [19:14:24] ryasmeen, if yes and it still fails, send me the URL you're testing on [19:14:52] jgonera: http://en.m.wikipedia.beta.wmflabs.org/wiki/11thaugustchrome [19:19:45] (03PS4) 10Krinkle: Registry: Guard against Object prototype keys in lookup() [oojs/core] - 10https://gerrit.wikimedia.org/r/153356 (owner: 10Esanders) [19:20:02] ryasmeen, the patch is merged but not deployed, probably nobody updated VE core in VE extension for the past few days [19:20:13] (03CR) 10Krinkle: "Added test to verify the fix, and improved the code to guard against all object prototype keys (including 'hasOwnProperty' itself)." [oojs/core] - 10https://gerrit.wikimedia.org/r/153356 (owner: 10Esanders) [19:20:14] check with somebody from the VE team [19:20:18] (03CR) 10Krinkle: [C: 031] Registry: Guard against Object prototype keys in lookup() [oojs/core] - 10https://gerrit.wikimedia.org/r/153356 (owner: 10Esanders) [19:20:46] jgonera: Ah okay, thanks [19:21:06] (03PS5) 10Krinkle: Registry: Guard against Object prototype keys in lookup() [oojs/core] - 10https://gerrit.wikimedia.org/r/153356 (owner: 10Esanders) [19:21:14] (03CR) 10Krinkle: [C: 031] Registry: Guard against Object prototype keys in lookup() [oojs/core] - 10https://gerrit.wikimedia.org/r/153356 (owner: 10Esanders) [19:22:48] Hey James_F :) [19:35:54] 3VisualEditor: Visual editor should have a cancel button next to the save button - 10https://bugzilla.wikimedia.org/69406#c4 (10Andre Klapper) 5RESO/WON>3RESO/FIX (In reply to Spinningspark from comment #3) > What is this mysterious "user testing". Not sure if https://lists.wikimedia.org/mailman/listinfo/... [19:38:23] 3VisualEditor: Visual editor should have a cancel button next to the save button - 10https://bugzilla.wikimedia.org/69406 (10Andre Klapper) 5RESO/FIX>3RESO/WON [19:46:52] (03PS1) 10Esanders: Add missing messages from MW [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153435 [19:47:22] (03PS1) 10Esanders: Remove messages defined in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153436 [19:49:06] (03CR) 10jenkins-bot: [V: 04-1] Remove messages defined in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153436 (owner: 10Esanders) [19:49:53] 3OOjs UI: OOjs UI: Menus appearing behind page content in Safari 6.1.3 and 7.0.5 - 10https://bugzilla.wikimedia.org/64388#c26 (10Bryce Glover) P. P. S.: It turns out that VisualEditor's menus load properly if you reset Safari's zoom level before clicking on 'Edit [beta]' even if you then zoom in afterwards!... [19:55:38] 3VisualEditor: Incremental edit summary needed - 10https://bugzilla.wikimedia.org/69393#c2 (10Spinningspark) Actually, I didn't realise you could do that which makes this much less of a problem that I thought it was. Still, it's a bit clunky. I can't, for instance, start writing the edit summary first (I have... [20:00:39] 3VisualEditor: Visual editor should have a cancel button next to the save button - 10https://bugzilla.wikimedia.org/69406#c5 (10Spinningspark) (In reply to Andre Klapper from comment #4) > (In reply to Spinningspark from comment #3) > > What is this mysterious "user testing". > > Not sure if https://lists.wik... [20:05:53] 3OOjs UI: OOjs UI: Dialogs should be repositionable/draggable - 10https://bugzilla.wikimedia.org/49969#c21 (10WhatamIdoing) > You can't edit anything, tables, Chinese or galleries, > if there is big immovable box in the way. This isn't really true: you can close the box. With the box open (and movable), yo... [21:29:14] (03CR) 10Jforrester: [C: 032] Registry: Guard against Object prototype keys in lookup() [oojs/core] - 10https://gerrit.wikimedia.org/r/153356 (owner: 10Esanders) [21:33:00] (03Merged) 10jenkins-bot: Registry: Guard against Object prototype keys in lookup() [oojs/core] - 10https://gerrit.wikimedia.org/r/153356 (owner: 10Esanders) [21:39:01] (03CR) 10Jforrester: [C: 032] Add missing messages from MW [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153435 (owner: 10Esanders) [21:40:23] (03Merged) 10jenkins-bot: Add missing messages from MW [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153435 (owner: 10Esanders) [21:53:56] (03PS4) 10Krinkle: build: Switch from qunit directly to karma for code coverage reports [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151299 (owner: 10Jforrester) [21:59:47] (03CR) 10Krinkle: build: Switch from qunit directly to karma for code coverage reports (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151299 (owner: 10Jforrester) [22:02:00] (03PS5) 10Jforrester: build: Switch from qunit directly to karma for code coverage reports [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151299 [22:02:03] (03CR) 10Krinkle: build: Switch from qunit directly to karma for code coverage reports (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151299 (owner: 10Jforrester) [22:02:13] (03CR) 10Jforrester: build: Switch from qunit directly to karma for code coverage reports (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151299 (owner: 10Jforrester) [22:07:32] (03PS3) 10Jforrester: [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 [22:09:00] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 (owner: 10Jforrester) [22:11:33] (03CR) 10Krinkle: [C: 032] Actually check annotations in paste test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153359 (owner: 10Catrope) [22:12:52] (03Merged) 10jenkins-bot: Actually check annotations in paste test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153359 (owner: 10Catrope) [22:14:56] (03PS3) 10Jforrester: Update VE core submodule to master (3b86994) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152111 [22:16:35] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (3b86994) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152111 (owner: 10Jforrester) [22:30:38] 3VisualEditor / 3Editing Tools: VisualEditor: Deleting the parameter of any template or the template itself, scrolls the focus up to the top of the transclusion dialog - 10https://bugzilla.wikimedia.org/62420#c1 (10Alex Monk) So there's a couple of strange things going on here, which me and Trevor looked int... [22:32:23] (03CR) 10Esanders: "The image is PD, and we don't write (TM) after VisualEditor anywhere else in the codebase, so why just because it's an image." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152949 (owner: 10Esanders) [22:32:52] (03CR) 10Jforrester: "The image is not PD. What makes you think that?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152949 (owner: 10Esanders) [22:35:24] (03PS2) 10Esanders: Queue up annotation changes to make operations safer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152776 (https://bugzilla.wikimedia.org/68892) [22:35:26] (03PS3) 10Esanders: Show metadata in the debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152261 [22:37:24] (03CR) 10Esanders: "Slightly worrying that the tests passed" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152776 (https://bugzilla.wikimedia.org/68892) (owner: 10Esanders) [22:37:57] (03PS3) 10Esanders: Queue up annotation changes to make operations safer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152776 (https://bugzilla.wikimedia.org/68892) [22:41:16] (03PS4) 10Jforrester: Queue up annotation changes to make operations safer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152776 (https://bugzilla.wikimedia.org/68892) (owner: 10Esanders) [22:46:55] (03CR) 10Jforrester: [C: 032] Show metadata in the debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152261 (owner: 10Esanders) [22:48:11] (03Merged) 10jenkins-bot: Show metadata in the debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152261 (owner: 10Esanders) [22:55:03] (03PS6) 10Krinkle: build: Switch from qunit directly to karma for code coverage reports [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151299 (owner: 10Jforrester) [23:08:03] (03CR) 10Krinkle: [C: 032] build: Switch from qunit directly to karma for code coverage reports [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151299 (owner: 10Jforrester) [23:08:11] (03PS2) 10Krinkle: tests: Fix some minor issues flagged up by karma and related MW references [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151300 (owner: 10Jforrester) [23:09:57] (03Merged) 10jenkins-bot: build: Switch from qunit directly to karma for code coverage reports [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151299 (owner: 10Jforrester)