[01:07:40] 3VisualEditor: Cannot select and overwrite a formiula - 10https://bugzilla.wikimedia.org/69422 (10Spinningspark) 3NEW p:3Unprio s:3normal a:3None Intention: Attempting to replace a formula with text by selecting the formula does not work. Simply nothing happens. Either typing or pasting has the same... [08:21:36] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151300 (owner: 10Jforrester) [08:23:51] (03CR) 10Jforrester: [C: 032] "Per Roan." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151300 (owner: 10Jforrester) [08:25:36] (03Merged) 10jenkins-bot: tests: Fix some minor issues flagged up by karma and related MW references [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151300 (owner: 10Jforrester) [08:35:53] 3VisualEditor: Cannot select and overwrite a formula - 10https://bugzilla.wikimedia.org/69422 (10Andre Klapper) [08:59:59] (03PS4) 10Jforrester: [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 [09:01:57] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 (owner: 10Jforrester) [09:13:07] (03PS5) 10Jforrester: [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 [09:14:48] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 (owner: 10Jforrester) [09:19:09] (03PS6) 10Jforrester: [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 [10:03:07] I think I've just found an utterly bizarre VE bug. ;-) [10:06:31] * tommorris almost reported the bug to Mozilla's Bugzilla. [10:10:26] 3VisualEditor: Backspace to merge paragraph leads to second paragraph's deletion - 10https://bugzilla.wikimedia.org/69429 (10Tom Morris) 3NEW p:3Unprio s:3major a:3None Intention: Add a new paragraph, then merge it with the previous paragraph. Steps to Reproduce: On the article 'Boris Johnson' on Engl... [10:10:26] https://bugzilla.wikimedia.org/show_bug.cgi?id=69429 ;-) [11:18:08] James_F: What does this statement return? [11:18:13] > /*!foo*//a//*bar*/ [11:18:42] >> /*!foo*//a//*bar*/ [11:18:43] Krinkle: (object) /a/ [11:18:50] James_F: https://gerrit.wikimedia.org/r/#/c/153573/2/tests/phpunit/includes/libs/JavaScriptMinifierTest.php [12:00:40] 3VisualEditor / 3MediaWiki integration: VisualEditor: HTML code is seen while editing the ru.wikipedia page about Bohuslav Tablic - 10https://bugzilla.wikimedia.org/69432 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Article URL: https://ru.wikipedia.org/wiki/%D0%A2%D0%B0%D0%B1%D0%BB%D0%B8%D1%... [12:04:43] (03PS1) 10Esanders: Replace setModulesPath with addMessagePath [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153587 [12:04:50] (03CR) 10jenkins-bot: [V: 04-1] Replace setModulesPath with addMessagePath [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153587 (owner: 10Esanders) [12:09:08] TrevorParscal: https://www.npmjs.org/package/oojs [12:09:11] James_F: https://www.npmjs.org/package/oojs [12:11:45] James_F: like https://git.wikimedia.org/git/oojs/core.git [12:11:57] * James_F nods. [12:12:44] James_F: https://git.wikimedia.org/summary/UnicodeJS.git [12:12:57] https://www.mediawiki.org/w/index.php?title=UnicodeJS&diff=1102980&oldid=1101902 [12:23:49] (03PS2) 10Krinkle: demos: Refactor tool groups to be re-usable between toolbars [oojs/ui] - 10https://gerrit.wikimedia.org/r/150732 [12:42:29] James_F: upraised [12:42:30] apprised [12:42:37] uprised [12:45:40] James_F: https://www.npmjs.org/package/oojs [12:52:29] (03PS7) 10Vikassy: [BrowserTest] Added browser tests for Formula, reference list and save button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151419 [13:05:23] (03CR) 10Zfilipin: [C: 04-1] [BrowserTest] Added browser tests for Formula, reference list and save button (037 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151419 (owner: 10Vikassy) [13:21:29] (03PS8) 10Vikassy: [BrowserTest] Added browser tests for Formula, reference list and save button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151419 [13:22:38] (03PS9) 10Vikassy: [BrowserTest] Added browser tests for formula, reference list and save button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151419 [13:32:55] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Added browser tests for formula, reference list and save button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151419 (owner: 10Vikassy) [13:34:32] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Added browser tests for formula, reference list and save button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151419 (owner: 10Vikassy) [13:37:46] (03PS1) 10Vikassy: [BrowserTest] Language screenshot job should run specific scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153594 [13:38:27] (03PS2) 10Vikassy: [BrowserTest] Language screenshot job should run specific scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153594 [13:42:23] (03PS7) 10Jforrester: [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 [13:42:43] Krinkle: ^^^ Now includes UnicodeJS v. 0.1.1. [13:43:24] (03PS3) 10Vikassy: [BrowserTest] Language screenshot job should run specific scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153594 [13:43:54] (03PS4) 10Vikassy: [BrowserTest] Language screenshot job should run specific scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153594 [13:46:28] (03CR) 10Zfilipin: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151419 (owner: 10Vikassy) [13:56:47] (03PS1) 10Mooeypoo: Fix bad jquery 'append' instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153598 [13:58:32] (03PS1) 10Mooeypoo: Fix bad jquery 'append' instances [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153599 [14:00:03] (03CR) 10jenkins-bot: [V: 04-1] Fix bad jquery 'append' instances [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153599 (owner: 10Mooeypoo) [14:06:52] ... what? [14:06:57] oh.. we still have that problem. [14:08:30] Also, good morning James_F, Krenair and TrevorParscal assuming IRC doesn't lie [14:09:13] (03PS2) 10Esanders: Replace setModulesPath with addMessagePath [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153587 [14:10:45] (03PS1) 10Esanders: Remove unused modules URL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153602 [14:12:16] (03CR) 10jenkins-bot: [V: 04-1] Remove unused modules URL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153602 (owner: 10Esanders) [15:05:04] (03PS5) 10Vikassy: WIP: [BrowserTest] Language screenshot job should run specific scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153594 [15:06:07] (03CR) 10Vikassy: "This should be merged after => https://gerrit.wikimedia.org/r/#/c/151419/ gets merged and some changes are made." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153594 (owner: 10Vikassy) [15:17:57] (03PS10) 10Zfilipin: [BrowserTest] Added browser tests for formula, reference list and save button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151419 (owner: 10Vikassy) [15:19:31] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Added browser tests for formula, reference list and save button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151419 (owner: 10Vikassy) [15:42:11] 3VisualEditor / 3ContentEditable: VisualEditor: Cursor moves to the end of the line, if comment,link and language are present . - 10https://bugzilla.wikimedia.org/69438 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16177 --> https://bugzilla.wikimedia.org/attachment.cgi?id=161... [15:47:53] 3VisualEditor / 3ContentEditable: VisualEditor: Cursor moves to the end of the line, if comment,link and language are present . - 10https://bugzilla.wikimedia.org/69438#c1 (10Ritu Swain) Environment-test2 and beta Found only in chrome and Safari. [16:30:35] Corruption alert: visualeditor-needcheck on idwiki: https://id.wikipedia.org/?diff=8118188 [16:30:35] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=64750892 [16:30:35] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=39798793 [16:30:35] Corruption alert: visualeditor-needcheck on trwiki: https://tr.wikipedia.org/?diff=14613823 [16:30:35] Corruption alert: visualeditor-needcheck on dawiki: https://da.wikipedia.org/?diff=7735654 [16:30:36] Corruption alert: visualeditor-needcheck on dawiki: https://da.wikipedia.org/?diff=7735656 [17:45:02] mooey|away: Re the append thing, did you grep to see if we're doing the same thing with .prepend() anywhere? [17:45:25] (03PS3) 10Catrope: Replace setModulesPath with addMessagePath [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153587 (owner: 10Esanders) [17:49:48] RoanKattouw, I did through sublime (search in all files) [17:49:53] I only found my own stuff and fixed those [17:50:13] oh, I didn't search for prepend [17:50:31] Because I vaguely recall I might have seen prepend code with an array at some point [17:50:33] RoanKattouw, I just searched for it now, I can't find any .prepend() problems [17:50:39] OK cool [17:51:00] I just searched for 'prepend( [' in all VE files (including ve-core) .. that should cover it. [17:51:16] (03CR) 10Catrope: [C: 032] Fix bad jquery 'append' instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153598 (owner: 10Mooeypoo) [17:52:35] And of course now all my media dialog stuff will need to be rebased -- but it's a minor change. I have to run to do some errands, I'll come back in the evening and sort the entire chain out plus any reviews in case any are given. [17:52:50] (03Merged) 10jenkins-bot: Fix bad jquery 'append' instances [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153598 (owner: 10Mooeypoo) [17:53:42] RoanKattouw, also, this fix is ve-core (not dependent on the jenkins problem) and is somewhat simple and semi trivial https://gerrit.wikimedia.org/r/#/c/153069/ [17:54:13] OK I'll look at it in a minute [17:54:22] much obliged. [17:54:27] i'll be back soon [17:58:26] shoot, I just literally ran back to the computer, I realized I have a bug in that "trivial" code [17:59:36] lol [18:01:57] (03CR) 10Catrope: [C: 04-1] "Looks good to merge, but there's an out of date doc comment that should be fixed first" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153587 (owner: 10Esanders) [18:07:17] RoanKattouw, hmm. Shouldn't ve.compare account for objects that don't share the same keys? I am getting problems comparing 'newDimensions' and 'oldDimensions' when 'oldDimensions' is an empty object (so, I'm getting an error that attribute "width" not found) [18:07:49] That should work [18:07:54] I realized I need to verify that before I change dimensions for the scalable (and emit 'change' event) I should check that the new dimensions aren't the same as the old ones. [18:07:56] You'll only get an error for second-level undefined property access [18:08:00] hmm [18:08:03] that might be it [18:08:08] i.e. accessing foo.width is fine and will return undefined, but foo.something.width will error [18:08:19] Still, if ve.compare() is doing that that's probably a bug [18:08:54] I think foo is undefined in my case [18:09:02] which is a bug in scalable (fixing now, initializing it as an object) [18:09:11] Well there is a known issue with passing undefined to ve.compare() [18:09:22] The documentation tells you not to but we may want to protect against it anyway [18:09:24] I'm checking only 2 dimensional object. foo.width <--> baz.width [18:09:37] yeah, I think that might be it [18:09:43] it's not being initialized properly [18:17:32] (03PS3) 10Mooeypoo: [wip] Add an event to updating current values in scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153069 [18:32:53] 3VisualEditor / 3Mobile: VisualEditor Mobile: The keyboard stays in the ReadMode after tapping on the Browser back button/ the cross button on the Mobile VE - 10https://bugzilla.wikimedia.org/65411#c3 (10Rummana Yasmeen) Yes, still happens on taping on browser back button [18:40:49] Aha! [18:40:55] I figured out what's going on with the Jenkins error [18:41:59] PhantomJS wraps pasted content in (but only in VE-MW with the Vector skin absent, for whatever reason), and this is getting stripped out correctly by afterPaste but exposing a bug in newFromDocumentInsertion [18:43:01] afterPaste creates a local dm.Document whose store has 0=span.Apple-style-span and 1=b, but the main document's store has 0=b, so we try to insert data annotated with 1 and this isn't remapped to 0 [18:49:31] Oooooh [18:49:55] It looks like edsanders's recent change to getAnnotationIndexesFromOffset broke store index remapping [18:50:12] That function should really have tests [21:19:13] (03PS1) 10Catrope: Followup 95ee357: make remapStoreIndexes() work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153709 [21:42:43] edsanders: https://gerrit.wikimedia.org/r/153709 fixes the Jenkins problem we've been scratching our heads over since Thursday [21:51:06] (03CR) 10Esanders: [C: 032] Followup 95ee357: make remapStoreIndexes() work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153709 (owner: 10Catrope) [21:52:49] (03Merged) 10jenkins-bot: Followup 95ee357: make remapStoreIndexes() work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153709 (owner: 10Catrope) [21:53:45] Thanks edsanders [21:54:56] (03CR) 10Krinkle: [C: 04-1] [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 (owner: 10Jforrester) [21:55:45] (03PS1) 10Catrope: Update VE core submodule to master (f443f90) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153716 [21:57:23] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (f443f90) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153716 (owner: 10Catrope) [21:58:10] (03PS2) 10Catrope: Update VE core submodule to master (f443f90) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153716 [22:06:49] (03PS4) 10Esanders: Replace setModulesPath with addMessagePath [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153587 [22:35:54] Krinkle: Could you +2 https://gerrit.wikimedia.org/r/#/c/153716/ ? [22:36:10] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/152122/ [22:38:22] (03CR) 10Krinkle: [C: 032] Update VE core submodule to master (f443f90) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153716 (owner: 10Catrope) [22:39:59] (03Merged) 10jenkins-bot: Update VE core submodule to master (f443f90) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153716 (owner: 10Catrope) [22:57:12] (03PS2) 10Krinkle: Fix bad jquery 'append' calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153599 (owner: 10Mooeypoo) [22:57:18] (03CR) 10Krinkle: [C: 032] "Thx" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153599 (owner: 10Mooeypoo) [22:58:55] (03Merged) 10jenkins-bot: Fix bad jquery 'append' calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153599 (owner: 10Mooeypoo) [23:07:05] RoanKattouw, I think there's a problem with ve.compare [23:08:02] OK [23:08:05] I'm getting into a separate issue in my code now (revalidating the dimensions after changing image, which for some reason gives me problems) but I will get into the ve.compare issue right after. It seems to completely die on me for 2d comparisons if the compared object is empty (not even undefined) [23:08:21] I'm trying to run something like ve.compare( newDimensions, oldDimensions ) [23:08:29] but oldDimensions may be unset yet (so, empty object) [23:08:42] and new dimensions are just obj={ width: xx; height: yy } [23:08:52] so it's just 2d. It shouldn't die even if the first object is empty... right? [23:09:55] meh, but when I run it in console it works. [23:11:05] RoanKattouw, okay, I need to run deeper checks here. It *definitely* crashes when one of the variables is undefined. I can fix for that, at least. [23:11:41] * mooeypoo curses Scalable. It shouldn't *be* undefined. Gah. [23:12:12] Yeah the crash on undefined thing is known [23:12:25] The only reason that hasn't already been fixed is because the documentation indicates that only objects are handled [23:12:40] (Passing in numbers will fail similarly I believe) [23:13:04] But if you want to fix that, go ahead, as long as other types besides objects and undefined (e.g. numbers and strings; arrays probably work already) are also supported [23:23:06] RoanKattouw, yeah, but it would really help if it didn't crash on undefined [23:23:18] the object shouldn't be undefined to begin with, granted, but still [23:24:00] Yes [23:24:07] Which is why ideally ve.compare() would just work on all types [23:24:51] All I'm saying is, if you do that, actually make it work for all types. It only working for iterable things (objects and arrays) is somewhat legitimate, but it only working for those things plus undefined is arbitrary. If we add support for undefined we should add support for every type [23:26:09] (And also, you should of course fix whatever is causing undefined to be passed to ve.compare in the first place) [23:31:24] hmm, good point. And yes, I'm trying to track down why my value is undefind. I'm setting it up as {} in the constructor. very weird. [23:52:59] (03CR) 10Catrope: [C: 032] Replace setModulesPath with addMessagePath [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153587 (owner: 10Esanders) [23:53:26] 3VisualEditor / 3Editing Tools: just change image => parameter border is lost - 10https://bugzilla.wikimedia.org/69450 (10Drongou) 3UNCO p:3Unprio s:3normal a:3None When you just change image on a media, the border parameter is lost. https://test2.wikipedia.org/w/index.php?title=BorderLost&diff=9884... [23:54:01] hmm [23:54:20] (03Abandoned) 10Catrope: Update VE core submodule to master (3b86994) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152111 (owner: 10Jforrester) [23:54:28] edsanders|away, here's the reminder I promised earlier: I would like a CSS change that can be applied to individual users' accounts to stop the dialog animation in VisualEditor. The original request is posted at https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Stop_the_animation_please [23:54:31] (03PS2) 10Catrope: Remove unused modules URL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153602 (owner: 10Esanders) [23:54:56] (03Merged) 10jenkins-bot: Replace setModulesPath with addMessagePath [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153587 (owner: 10Esanders) [23:55:14] whatami: Good call on not wanting to make it a user pref [23:55:24] 3VisualEditor / 3Editing Tools: just change image => parameter border is lost - 10https://bugzilla.wikimedia.org/69450 (10Moriel Schottlender) 5UNCO>3ASSI a:3Moriel Schottlender [23:55:25] Ed's probably gone to sleep (it's 1am for him) but I'll take a look [23:55:36] Thank you, RoanKattouw. [23:56:09] If you want, you can e-mail it to me, or just post it on the page—whatever's easier for you. [23:59:37] whatami: Re "Inconsistent sizing of input boxes in Cite dialog (mini-editor)" (sorry I got distracted reading that feedback page), can you check/ask if there are a bunch of blank lines in that large input box?