[00:02:26] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Searching for a page name that starts with http://whatever... is kind of silly - 10https://bugzilla.wikimedia.org/69500#c1 (10Alex Monk) Interesting that MediaWiki allows you to create pages that are URLs, but you can't link to them...
[00:06:58] <wikibugs>	 3VisualEditor: VisualEditor:  Broken browser plug-in adds XML cruft like "gte mso" - 10https://bugzilla.wikimedia.org/69513 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Scan down these to find lots of garbage, including lines like:  </xml><![endif]--><!--[if gte mso 9]><xml>  or   <!--[if gte mso...
[00:09:26] <wikibugs>	 3VisualEditor: VisualEditor:  Broken browser plug-in adds XML cruft like "gte mso" - 10https://bugzilla.wikimedia.org/69513 (10Roan Kattouw)
[00:09:28] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Broken browser plugins cause cruft to be injected into the page (tracker) - 10https://bugzilla.wikimedia.org/52327 (10Roan Kattouw)
[00:10:47] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Searching for a page name that starts with http://whatever... is kind of silly - 10https://bugzilla.wikimedia.org/69500#c2 (10Alex Monk) Bug 44011 sounds slightly related
[00:26:11] <wikibugs>	 3VisualEditor: VisualEditor's suggested edit summary is wrong if you use the local gadget to edit section 0 (zero) - 10https://bugzilla.wikimedia.org/69501#c1 (10Alex Monk) 5NEW>3RESO/INV It looks like the gadget needs to be fixed to deal with VE. In particular, it needs to be able to deal with 've' betwee...
[00:32:28] <wikibugs>	 3VisualEditor / 3Data Model: Cannot copy text when dm.surface.enabled === false - 10https://bugzilla.wikimedia.org/69515 (10Ryan Wold) 3UNCO p:3Unprio s:3normal a:3None When disabling an Editor's .target.surface (by calling .disable()), the text is no longer editable, which is great.  However, the te...
[00:33:28] <wikibugs>	 3VisualEditor / 3Data Model: Cannot copy text when dm.surface.enabled === false - 10https://bugzilla.wikimedia.org/69516 (10Ryan Wold) 3UNCO p:3Unprio s:3normal a:3None When disabling an Editor's .target.surface (by calling .disable()), the text is no longer editable, which is great.  However, the te...
[00:34:29] <wikibugs>	 3VisualEditor / 3Data Model: Cannot copy text when dm.surface.enabled === false - 10https://bugzilla.wikimedia.org/69515#c1 (10Ryan Wold) *** Bug 69516 has been marked as a duplicate of this bug. ***
[00:34:29] <wikibugs>	 3VisualEditor / 3Data Model: Cannot copy text when dm.surface.enabled === false - 10https://bugzilla.wikimedia.org/69516#c1 (10Ryan Wold) 5UNCO>3RESO/DUP   *** This bug has been marked as a duplicate of bug 69515 ***
[00:34:56] <wikibugs>	 3VisualEditor: VisualEditor: If 'summary' parameter is provided in URL, it should be the default edit summary - 10https://bugzilla.wikimedia.org/69501#c2 (10Alex Monk) 5RESO/INV>3REOP Although VE should probably pick up the default summary from the URL.
[01:39:56] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Quickly clicking on "Apply Changes" button multiple times on Media Settings throws console error and cannot make any more changes to any media settings dialog after that - 10https://bugzilla.wikimedia.org/66389#c11 (10Coiby) (In reply to Roan Kattouw from comment...
[01:45:11] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: There should be help links in every context - dialog boxes, inspectors, etc. - 10https://bugzilla.wikimedia.org/51798#c8 (10Alex Monk) It looks like some work was done in Gerrit change 147751 and then reverted
[11:24:30] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Undo resizing of image with explicit dimension in core doesn't render correctly - 10https://bugzilla.wikimedia.org/69531 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3None 1. Create an image in VE standalone with no width/heigh attrs (using the html editor...
[11:24:45] <grrrit-wm>	 (03PS1) 10Esanders: Make sure image attribute is cleared if set to null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154036 (https://bugzilla.wikimedia.org/69531) 
[11:30:05] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Make sure image attribute is cleared if set to null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154036 (https://bugzilla.wikimedia.org/69531) (owner: 10Esanders)
[11:30:14] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Undo resizing of image with explicit dimension in core doesn't render correctly - 10https://bugzilla.wikimedia.org/69531 (10James Forrester) p:5Unprio>3Normal a:3Ed Sanders
[11:30:18] <grrrit-wm>	 (03PS2) 10Esanders: Make sure image attribute is cleared if set to null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154036 (https://bugzilla.wikimedia.org/69531) 
[11:31:48] <grrrit-wm>	 (03PS13) 10Esanders: Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) 
[11:32:39] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] "Yes, gross." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153875 (owner: 10Catrope)
[11:34:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: "Fix" hack in ve.test.utils to prevent immediate surface setup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153875 (owner: 10Catrope)
[11:34:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (8e56dd5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153864 (owner: 10Catrope)
[11:43:31] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Make sure image attribute is cleared if set to null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154036 (https://bugzilla.wikimedia.org/69531) (owner: 10Esanders)
[11:45:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make sure image attribute is cleared if set to null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154036 (https://bugzilla.wikimedia.org/69531) (owner: 10Esanders)
[11:48:19] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (ce51e22) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154039 
[12:03:56] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Undo resizing of image with explicit dimension in core doesn't render correctly - 10https://bugzilla.wikimedia.org/69531 (10James Forrester) 5PATC>3RESO/FIX
[14:09:57] <cscott>	 any oojs fans online?
[14:47:00] <edsanders>	 cscott, give me an 'o'
[14:47:34] <cscott>	 do you have any idea why ve.copy only passes *leaf* nodes to the callback?
[14:48:00] <edsanders>	 that's a good question because I wrote that
[14:48:05] <cscott>	 i can't get it to serialize ve.Range in a reasonable manner, since ve.Range has a 'clone' method, and thus never gets passed to the callback
[14:49:19] <edsanders>	 does it not have a toJSON these days?
[14:49:58] <edsanders>	 and a static newFromJSON
[14:50:09] <edsanders>	 I use that in drag and drop
[14:50:49] <grrrit-wm>	 (03PS1) 10Cscott: Apply the ve.copy callback to all nodes, not just leaves [oojs/core] - 10https://gerrit.wikimedia.org/r/154061 
[14:50:55] <cscott>	 ^ a proposal
[14:51:48] <edsanders>	 I think it not applying to clone is an oversight though...
[14:51:58] <cscott>	 i don't want to stringify the range, it's going to be embedded in a larger message first.  i just want to use a custom callback to convert it to a alternate representation.
[14:52:18] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Apply the ve.copy callback to all nodes, not just leaves [oojs/core] - 10https://gerrit.wikimedia.org/r/154061 (owner: 10Cscott)
[14:52:38] <cscott>	 also the ve.Range#toJSON method doesn't add any sort of tag to indicate that the value is a range, which complicates deserialization.
[14:52:52] <mooeypoo>	 I was actually going to take a look at ve.copy to make it not-crash on 'undefined' and support more types.
[14:52:58] <cscott>	 (jenkins not liking my patch isn't terribly surprising, i'm still trying to make `npm test` work on the oojs repo.  i'll fix it.)
[14:53:03] <mooeypoo>	 But that shoulnd' thave anything to do with this problem
[14:53:34] <edsanders>	 cscott, sure
[14:53:37] <cscott>	 mooeypoo: it's sort of related.  especially the 'support more types' thing should be possible with an appropriate callback.
[14:53:44] <edsanders>	 do we need to run callback on destination?
[14:54:11] <edsanders>	 it's always a plain array or object
[14:54:12] <cscott>	 edsanders: yes. ;)
[14:54:35] <cscott>	 it makes sure the callback is invoked exactly once on every node in the copied object, leaf or internal.
[14:55:35] <cscott>	 that is, ve.copy({ type: 'foo', range: new ve.Range(1,2)}) will invoke callback('foo'), callback(ve.Range(1,2)), then callback({type:'foo', range:ve.Range(1,2)}) etc.
[14:56:15] <cscott>	 hm, i guess it might be better to do it in pre-order instead of post-order, like json serialization does.
[14:57:32] <cscott>	 but that's somewhat problematic when cloning.
[14:58:10] <cscott>	 to mooeypoo's point, the current behavior of callback makes it impossible to "support more types" with the callback method if the types in question are "object-like"
[14:58:28] <cscott>	 since object-like values aren't leaves, and thus the callback is never invoked on them.
[14:58:58] <edsanders>	 ok
[14:59:17] <edsanders>	 wanna write some unit tests :)
[14:59:29] <edsanders>	 (and fix the broken ones...)
[15:05:45] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "Tests need updating and possible adding to." [oojs/core] - 10https://gerrit.wikimedia.org/r/154061 (owner: 10Cscott)
[15:29:44] <wikibugs>	 3VisualEditor: VisualEditor: Provide ability to deal easily with dead links - 10https://bugzilla.wikimedia.org/69547 (10Elitre) 3NEW p:3Unprio s:3enhanc a:3None I met User:Zoony at Wikimania and he said that something which he'd love to see in VE is a way to deal easily with dead (rotten) links. He sug...
[15:32:59] <grrrit-wm>	 (03CR) 10Esanders: "https://commons.wikimedia.org/wiki/File:VisualEditor-logo.svg" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152949 (owner: 10Esanders)
[15:35:12] <grrrit-wm>	 (03CR) 10Esanders: "It's less complex than most of the examples on https://commons.wikimedia.org/wiki/Commons:Threshold_of_originality" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152949 (owner: 10Esanders)
[15:36:02] <grrrit-wm>	 (03PS2) 10Cscott: Add new ve.copy callback for all nodes, not just leaves [oojs/core] - 10https://gerrit.wikimedia.org/r/154061 
[15:36:15] <cscott>	 edsanders, mooey|away: ^^ perhaps that's better?
[15:47:30] <grrrit-wm>	 (03CR) 10Esanders: "Looks good, minor comments." (032 comments) [oojs/core] - 10https://gerrit.wikimedia.org/r/154061 (owner: 10Cscott)
[15:54:07] <grrrit-wm>	 (03PS3) 10Cscott: Add new ve.copy callback for all nodes, not just leaves [oojs/core] - 10https://gerrit.wikimedia.org/r/154061 
[16:11:46] <mvolz>	 I can't seem to get sets through the api. When I go to http://localhost/api.php?action=templatedata&titles=Template:Cite_journal it just gives an empty array "sets":[], but when I print the blob in TemplateDataBlob::newFromDatabase everything looks as it should (i.e. array is filled in). 
[16:15:13] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Add new ve.copy callback for all nodes, not just leaves [oojs/core] - 10https://gerrit.wikimedia.org/r/154061 (owner: 10Cscott)
[16:18:01] <mvolz>	 and the status and everything is okay. So I think this issue isn't in TemplateDataBlob which is validating everything okay and returning things but rather ApiTemplateData.php. But I'm not sure how to debug that.
[16:18:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add new ve.copy callback for all nodes, not just leaves [oojs/core] - 10https://gerrit.wikimedia.org/r/154061 (owner: 10Cscott)
[16:22:15] <grrrit-wm>	 (03Abandoned) 10Esanders: Follow-up d9c3b904: Delete the no-longer-updated tests/index.html [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153827 (owner: 10Jforrester)
[16:26:18] <grrrit-wm>	 (03PS1) 10Esanders: Restore QUnit web UI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154082 
[16:30:21] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=64784517
[16:30:21] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=64793951
[16:30:21] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=64794006
[16:30:21] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=39810336
[16:30:21] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on fiwiki: https://fi.wikipedia.org/?diff=14223557
[16:33:08] <grrrit-wm>	 (03PS2) 10Jforrester: Add local image to demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152949 (owner: 10Esanders)
[16:35:06] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "This runs all of the qunit tests twice (once directly, and one through karma), which seems unnecessary. Building the file without using it" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154082 (owner: 10Esanders)
[16:44:57] <mvolz>	 James_F: ping? :)
[16:45:06] <James_F>	 Hey mvolz!
[16:46:12] <mvolz>	 so sets are not coming through the other side for me :) when I look at what gets fetched by the api I get an empty array.
[16:46:51] <mvolz>	 but if I print the TemplateDataBlob it looks okay, status is okay, everything is getting validated okay.
[16:47:00] <mvolz>	 and filled out.
[16:48:11] <James_F>	 Hmm.
[16:48:17] <James_F>	 We've never used sets in anger.
[16:48:21] <James_F>	 Maybe they don't work?
[16:48:28] <James_F>	 (Sorry!)
[16:48:34] <mvolz>	 "in anger"? :)
[16:48:43] <James_F>	 You know what I mean. :-)
[16:48:49] <mvolz>	 hee
[16:48:53] <mvolz>	 blast.
[16:49:19] <mvolz>	 well my maps (formerly known as services) are not coming through either
[16:49:25] <James_F>	 :-(
[16:49:28] <mvolz>	 empty objects.
[16:49:31] <mvolz>	 grr
[16:49:37] <cscott>	 are you using es6 Map and Set classes?  they are probably not serializing to JSON correctly.
[16:50:04] <mvolz>	 no, that's just the name of them :/
[16:50:04] <cscott>	 that is, Map and Set don't have any properties, according to the ES6 spec, and Map#toString() returns '{}' etc.
[16:50:12] <cscott>	 mvolz: oh.  well you should be! ;)
[16:50:14] <mvolz>	 yeah these aren't literal Maps
[16:50:15] <mvolz>	 :)
[16:50:33] <mvolz>	 (this is in php right now)
[16:50:43] <cscott>	 oh, well then i can't help you at all :)
[16:51:01] <mvolz>	 I can't seem to help me either so you're alright
[16:51:01] <cscott>	 ask me again after i've embedded php inside node.js ;)
[16:51:12] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Allow formatting editing - 10https://bugzilla.wikimedia.org/65586 (10James Forrester) 5NEW>3ASSI p:5Low>3High s:5normal>3enhanc a:3None
[16:52:23] <mvolz>	 James_F: well okay... api debugging tips? "normally" I print things to screen. Which .... yeah, doesn't work for an api pages
[16:52:36] <James_F>	 mvolz: api.php?
[16:52:51] <mvolz>	 yes that one
[16:52:54] <mvolz>	 we need a name for it
[16:52:58] <mvolz>	 unicorn api!
[16:53:13] <MatmaRex>	 "mediawiki api"
[16:53:13] <mvolz>	 td extends it in ApiTemplateData.php
[16:53:32] <James_F>	 mvolz: https://en.wikipedia.org/w/api.php?action=templatedata&titles=Template:Cite%20web&format=jsonfm for example
[16:53:32] <MatmaRex>	 mvolz: there is actually a discussion about the name on wikitech-l, you might want to participate ;)
[16:53:57] <mvolz>	 MatmaRex: yeah I was obliquely referencing it :)
[16:53:59] <James_F>	 MatmaRex: There are bunches of MediaWiki APIs, which is why I agreed with Tim that it should be called the MediaWiki Query API.
[16:54:25] <mvolz>	 James_F: sweet, super helpful
[16:55:01] <James_F>	 mvolz: localhost version will be great
[16:55:20] <grrrit-wm>	 (03CR) 10Esanders: "This just means you can run the tests either in Karma from the command line, or with QUnit in the browser. If you're going to -1 you need " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154082 (owner: 10Esanders)
[16:55:44] <MatmaRex>	 James_F: i'm not going to let you pull me into this discussion. :>
[16:55:58] <James_F>	 :-D
[16:56:16] <grrrit-wm>	 (03Draft2) 10Bartosz Dziewoński: Provide mw-redirect and mw-disambig classes for links on the surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150824 
[16:56:28] <MatmaRex>	 James_F: by the way, while i have your attention. ^ thoughts?
[16:56:57] <mooeypoo>	 How about naming it apiph?
[16:56:59] <MatmaRex>	 mostly about mw-disambig, unfortunately nothing generates that server-side right now :(
[16:57:19] <mooeypoo>	 a-la oojsff
[16:58:21] <James_F>	 mooeypoo: :-)
[16:59:24] <James_F>	 MatmaRex: Why can't the Disambig extension extend the Parser to add mw-disambig to links?
[16:59:44] <James_F>	 MatmaRex: Client-land JS is going to be massively worse performance wise, surely?
[17:01:37] <MatmaRex>	 James_F: it can, but implementing that would take effort
[17:01:57] <MatmaRex>	 James_F: so far there were two stillborn attempts that would use one query per link when rendering the page
[17:02:16] <MatmaRex>	 it can be done better, but it's non-trivial :/
[17:02:18] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Ignore me. Fine." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154082 (owner: 10Esanders)
[17:02:46] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Update VE core submodule to master (ce51e22) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154039 (owner: 10Jforrester)
[17:03:13] <MatmaRex>	 James_F: https://bugzilla.wikimedia.org/show_bug.cgi?id=8339
[17:03:55] <James_F>	 MatmaRex: Could it go into the Parsoid redlink code.
[17:04:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Restore QUnit web UI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154082 (owner: 10Esanders)
[17:04:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (ce51e22) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154039 (owner: 10Jforrester)
[17:04:29] <MatmaRex>	 James_F: yes, and could go into LinkCache/LinkBatch/whatever in MW parser (https://bugzilla.wikimedia.org/show_bug.cgi?id=53945)
[17:04:38] * James_F nods.
[17:04:43] <grrrit-wm>	 (03PS2) 10Alex Monk: Fix pulling of annotations when typing at the beginning of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150378 (https://bugzilla.wikimedia.org/68597) 
[17:05:05] <MatmaRex>	 it's just a matter of effort required to do it well, as far as i can tell
[17:05:34] <MatmaRex>	 (and it is indeed a lot easier to do a performant version of this client-side)
[17:13:43] <wikibugs>	 3VisualEditor: VE messes up formatting of graphs in edit box - 10https://bugzilla.wikimedia.org/69552 (10Mdann52) 3UNCO p:3Unprio s:3normal a:3None When editing fields in VE, instead of keeping the existing formatting, it adds surplus line breaks. Please see https://en.wikipedia.org/w/index.php?title=U...
[17:13:51] <grrrit-wm>	 (03CR) 10Alex Monk: "Should add docs to a function, but really what I need here is someone to check that this is actually what we want to do." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153934 (https://bugzilla.wikimedia.org/49904) (owner: 10Alex Monk)
[17:15:56] <RoanKattouw>	 MatmaRex: What about ve.init.mw.LinkCache
[17:16:56] <MatmaRex>	 what about it? i am using that there :)
[17:17:19] <RoanKattouw>	 Oh OK
[17:17:22] <RoanKattouw>	 Sorry hadn't seen the code yet
[17:18:00] <RoanKattouw>	 Ooh excellent patch
[17:18:09] <RoanKattouw>	 I have been meaning to expand LinkCache and its usage for a while
[17:19:49] <grrrit-wm>	 (03PS10) 10Jforrester: [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 
[17:19:55] <James_F>	 edsanders: ^^^^
[17:20:15] <James_F>	 (Or RoanKattouw if you want to beat him to the +2 punch. ;-))
[17:20:36] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 (owner: 10Jforrester)
[17:20:53] <James_F>	 Eurgh.
[17:24:28] <grrrit-wm>	 (03PS11) 10Jforrester: [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 
[17:24:43] <James_F>	 That should now work. Finally.
[17:40:48] <James_F>	 edsanders: Please? :-)
[17:54:41] <wikibugs>	 3VisualEditor / 3Editing Tools: Create link button is not easily discoverable - 10https://bugzilla.wikimedia.org/69364 (10Sam Reed (reedy)) s:5normal>3enhanc
[18:12:06] <grrrit-wm>	 (03PS2) 10Esanders: Add VE logo to repo and use in image demo and for branding demo page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152950 
[18:13:03] <edsanders>	 James_F, testing
[18:13:08] <James_F>	 edsanders: Ta.
[18:16:45] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 (owner: 10Jforrester)
[18:16:50] <James_F>	 Woo.
[18:17:29] <edsanders>	 Seems like it probably isn't that broken, best just to merge it before it conflicts again
[18:17:38] <James_F>	 Yeah.
[18:17:46] * James_F patiently waits. :-)
[18:18:09] <edsanders>	 Dear everyone, rebase all the things. Kthxbye.
[18:18:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 (owner: 10Jforrester)
[18:19:38] <grrrit-wm>	 (03PS3) 10Jforrester: Add local image to demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152949 (owner: 10Esanders)
[18:19:46] <grrrit-wm>	 (03PS3) 10Jforrester: Add VE logo to repo and use in image demo and for branding demo page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152950 (owner: 10Esanders)
[18:22:06] <grrrit-wm>	 (03PS3) 10Jforrester: Fix pulling of annotations when typing at the beginning of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150378 (https://bugzilla.wikimedia.org/68597) (owner: 10Alex Monk)
[18:22:16] <grrrit-wm>	 (03CR) 10Jforrester: "PS3 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150378 (https://bugzilla.wikimedia.org/68597) (owner: 10Alex Monk)
[18:23:30] <grrrit-wm>	 (03PS14) 10Jforrester: Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders)
[18:23:36] <grrrit-wm>	 (03CR) 10Jforrester: "PS14 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders)
[18:24:38] <grrrit-wm>	 (03PS3) 10Jforrester: dm.NodeFactory: Use .lookup() instead of .create().constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151506 (owner: 10Catrope)
[18:24:56] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "PS3 is a rebase. -1 per Ed (lacks unit tests)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151506 (owner: 10Catrope)
[18:25:57] <grrrit-wm>	 (03PS6) 10Jforrester: Add an event to updating current values in scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153069 (owner: 10Mooeypoo)
[18:26:03] <grrrit-wm>	 (03CR) 10Jforrester: "PS6 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153069 (owner: 10Mooeypoo)
[18:27:09] <grrrit-wm>	 (03PS5) 10Jforrester: Queue up annotation changes to make operations safer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152776 (https://bugzilla.wikimedia.org/68892) (owner: 10Esanders)
[18:27:22] <grrrit-wm>	 (03CR) 10Jforrester: "PS5 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152776 (https://bugzilla.wikimedia.org/68892) (owner: 10Esanders)
[18:31:59] <grrrit-wm>	 (03PS4) 10Jforrester: WIP: Kleptologging and interesting thing detection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 (owner: 10Divec)
[18:32:31] <grrrit-wm>	 (03CR) 10Jforrester: "PS4 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 (owner: 10Divec)
[18:34:28] <grrrit-wm>	 (03PS3) 10Jforrester: Fix `ve.dm.Transaction.newFromReplacement` when `removeMetadata` is true. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152017 (owner: 10Cscott)
[18:34:53] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "PS3 is a rebase. Roan's comments still apply." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152017 (owner: 10Cscott)
[18:36:38] <grrrit-wm>	 (03PS7) 10Jforrester: Factor out ve.dm.Transaction.pushReplaceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116214 (owner: 10Catrope)
[18:37:00] <grrrit-wm>	 (03CR) 10Jforrester: "PS7 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116214 (owner: 10Catrope)
[18:38:47] <grrrit-wm>	 (03PS6) 10Jforrester: WIP: Record intention in ve.dm.Transaction object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 (owner: 10Cscott)
[18:39:03] <grrrit-wm>	 (03CR) 10Jforrester: "PS6 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 (owner: 10Cscott)
[18:40:30] <grrrit-wm>	 (03PS6) 10Jforrester: Add ve.dm.Transaction.newNoOp() constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 (owner: 10Cscott)
[18:40:41] <grrrit-wm>	 (03CR) 10Jforrester: "PS6 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 (owner: 10Cscott)
[18:41:55] <grrrit-wm>	 (03PS5) 10Jforrester: Add ve.dm.Transaction.newFromIntention() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151798 (owner: 10Cscott)
[18:42:10] <grrrit-wm>	 (03CR) 10Jforrester: "PS5 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151798 (owner: 10Cscott)
[18:42:17] <cscott>	 James_F: is rebasing these really necessary? it happens automagically when i do my next 'git review' anyway.
[18:44:03] <cscott>	 James_F: oh, i see, you moved directories and broke the world.
[18:44:19] <James_F>	 cscott: Yeah, I said I'd fix all of them. Sorry for the spam!
[18:44:54] <ryasmeen>	 Hey James_F, we did not backport jgonera's fix on https://bugzilla.wikimedia.org/show_bug.cgi?id=68897, so it is on production now :S
[18:45:20] <James_F>	 cscott: Mostly we need to actually merge your huge stack of doom. :-)
[18:45:38] <cscott>	 i need to finish it, first.  making decent progress on that.
[18:46:18] <grrrit-wm>	 (03CR) 10Cscott: Fix `ve.dm.Transaction.newFromReplacement` when `removeMetadata` is true. (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152017 (owner: 10Cscott)
[18:47:02] * James_F nods.
[18:47:26] <James_F>	 ryasmeen: Not the end of the world.
[18:48:03] <grrrit-wm>	 (03PS5) 10Jforrester: WIP: Add ve.dm.Transaction.copy() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151799 (owner: 10Cscott)
[18:48:14] <grrrit-wm>	 (03CR) 10Jforrester: "PS5 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151799 (owner: 10Cscott)
[18:48:47] <ryasmeen>	 James_F: okay, happy to know that :)
[18:54:35] <grrrit-wm>	 (03PS5) 10Jforrester: WIP: Implement ve.dm.Transaction.transpose() w/ intentions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151545 (owner: 10Cscott)
[18:54:51] <grrrit-wm>	 (03CR) 10Jforrester: "PS5 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151545 (owner: 10Cscott)
[18:55:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Implement ve.dm.Transaction.transpose() w/ intentions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151545 (owner: 10Cscott)
[18:58:26] <grrrit-wm>	 (03PS4) 10Cscott: Fix `ve.dm.Transaction.newFromReplacement` when `removeMetadata` is true. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152017 
[18:58:56] <grrrit-wm>	 (03PS4) 10Jforrester: WIP Fix deletion inside a structural node at start/end of document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/107142 (https://bugzilla.wikimedia.org/50250) (owner: 10Esanders)
[18:59:20] <grrrit-wm>	 (03CR) 10Jforrester: "PS4 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/107142 (https://bugzilla.wikimedia.org/50250) (owner: 10Esanders)
[19:02:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP Fix deletion inside a structural node at start/end of document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/107142 (https://bugzilla.wikimedia.org/50250) (owner: 10Esanders)
[19:07:19] <grrrit-wm>	 (03PS2) 10Jforrester: WIP failing converter tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114355 (owner: 10Esanders)
[19:07:43] <grrrit-wm>	 (03CR) 10Jforrester: "PS2 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114355 (owner: 10Esanders)
[19:09:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP failing converter tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114355 (owner: 10Esanders)
[19:16:46] <grrrit-wm>	 (03PS12) 10Jforrester: [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal)
[19:26:07] <grrrit-wm>	 (03PS2) 10Jforrester: [UNMERGED] Update OOjs UI to v0.1.0-pre (a83bdf7700) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150050 (owner: 10Trevor Parscal)
[19:26:38] <grrrit-wm>	 (03CR) 10Jforrester: "PS2 is a rebase (and rebuild of the pull-through)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150050 (owner: 10Trevor Parscal)
[19:27:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [UNMERGED] Update OOjs UI to v0.1.0-pre (a83bdf7700) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150050 (owner: 10Trevor Parscal)
[19:28:41] <grrrit-wm>	 (03PS2) 10Jforrester: Factor out wordbreak detection code and run it for simple insertions too [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151004 (owner: 10Catrope)
[19:31:00] <grrrit-wm>	 (03CR) 10Jforrester: "PS2 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151004 (owner: 10Catrope)
[19:31:13] <James_F>	 edsanders|away: ^^^ Looks good to go if you have a moment to review.
[19:33:24] <grrrit-wm>	 (03PS2) 10Jforrester: Remove 'remove' button from comment inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150194 (owner: 10Esanders)
[19:33:39] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "PS2 is a rebase. Still unsure about this change." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150194 (owner: 10Esanders)
[19:35:00] <grrrit-wm>	 (03PS4) 10Jforrester: [WIP] Fix removals when starting/ending after inline node at end of block [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148690 (owner: 10Esanders)
[19:35:22] <grrrit-wm>	 (03CR) 10Jforrester: "PS4 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148690 (owner: 10Esanders)
[19:36:24] <grrrit-wm>	 (03PS2) 10Jforrester: Blur contentEditable node while destroying surface. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144089 (owner: 10Inez)
[19:36:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Fix removals when starting/ending after inline node at end of block [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148690 (owner: 10Esanders)
[19:39:02] <grrrit-wm>	 (03PS3) 10Jforrester: Blur contentEditable node while destroying surface. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144089 (owner: 10Inez)
[19:39:23] <grrrit-wm>	 (03CR) 10Jforrester: "PS2 is a rebase." (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144089 (owner: 10Inez)
[19:46:24] <grrrit-wm>	 (03PS6) 10Jforrester: Provide tools to make text bigger or smaller [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://bugzilla.wikimedia.org/51613) 
[19:46:56] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "PS6 is a rebase. Still lacks unit tests – Ed?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://bugzilla.wikimedia.org/51613) (owner: 10Jforrester)
[20:01:41] <wikibugs>	 3VisualEditor: VisualEditor:  Broken browser plug-in adds XML cruft like "gte mso" - 10https://bugzilla.wikimedia.org/69513#c1 (10Alex Monk) People copying in things from MS Word, it seems: http://www.equalserving.com/what-the-heck-is-msonormaltable-and-how-did-it-get-in-my-post/
[20:03:27] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] TypeError: Cannot read property 'context' of undefined appears when you try to insert another image that appears on the same index as the previous search, right after you inserted one - 10https://bugzilla.wikimedia.org/67749#c8 (10Rummana Yasmee...
[20:06:41] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: The reference name for a newly added reference is not appearing in the dialog for "Use existing reference" while opening it for the first time - 10https://bugzilla.wikimedia.org/67342#c6 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production for bot...
[20:07:41] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor: [Regression pre-wmf16] Cannot open any page with Mobile VE in Betalabs - 10https://bugzilla.wikimedia.org/68584 (10Rummana Yasmeen) 5RESO/?>3VERI
[20:08:41] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] The highlights of the nodes are appearing over the toolbar menu - 10https://bugzilla.wikimedia.org/68198#c3 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production
[20:09:11] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: The Remove button for the link inspector in mobile is not styled as Red - 10https://bugzilla.wikimedia.org/68194#c2 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production
[20:10:26] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Cannot include the same existing reference after adding it once in an article - 10https://bugzilla.wikimedia.org/68582#c7 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production
[20:15:13] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the context menu of previously selected link is appearing upon placing the cursor in a different position in the document - 10https://bugzilla.wikimedia.org/67637#c4 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production
[20:20:41] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the toolbar for Mobile VE also scrolls down when you try to scroll down the page having a node selected - 10https://bugzilla.wikimedia.org/67390#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production
[20:20:46] <grrrit-wm>	 (03PS9) 10Cmcmahon: [BrowserTest] WIP: create new test for Cite tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150055 
[20:21:26] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: MobileContext is not in the DOM - 10https://bugzilla.wikimedia.org/68546#c4 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production
[20:26:42] <mooeypoo>	 sup eranroz !
[20:26:46] <mooeypoo>	 how was your flight? :)
[20:27:04] <eranroz>	 hi mooeypoo, fine :)
[20:27:25] <mooeypoo>	 I'm just working on the finishing touches of the TemplateData editor
[20:28:43] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Offer to pre-fill the DEFAULTSORT field - 10https://bugzilla.wikimedia.org/69568 (10WhatamIdoing) 3NEW p:3Unprio s:3enhanc a:3None Usually, DEFAULTSORT contents need only a little re-arranging or capitalization changes.  If the name is long or unfamiliar...
[20:31:11] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS, while opening the link inspector for the second time, the inspector gets zoomed making the inspector title overlapped with the browser tab - 10https://bugzilla.wikimedia.org/68197#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production
[20:34:56] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf15] Re-use existing citation dialog never rebuilds list of references after first opening - 10https://bugzilla.wikimedia.org/68869#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production
[20:35:40] <grrrit-wm>	 (03PS22) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) 
[20:36:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo)
[20:36:14] <mooeypoo>	 RoanKattouw, I'm searching and searching in vain, maybe you know? Is there a way to get jquery's JSON.stringify to output arrays in a single line rather than multiline?
[20:36:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Stop users from deleting parameters in the template dialog if they're marked as "required" in TemplateData - 10https://bugzilla.wikimedia.org/60358 (10Alex Monk) a:3Alex Monk
[20:36:31] <grrrit-wm>	 (03PS1) 10Alex Monk: Don't add delete button to required parameters in template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154133 (https://bugzilla.wikimedia.org/60358) 
[20:37:02] <mooeypoo>	 I have dirty diffs over paramOrder: [ 1,2,3 ] and aliases: [ foo, bar, baz ] being outputted as multiline if you edit anything else in the templatedata
[20:40:05] <grrrit-wm>	 (03PS2) 10Alex Monk: Disable delete button for required parameters in template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154133 (https://bugzilla.wikimedia.org/60358) 
[20:43:39] <RoanKattouw>	 Ahm
[20:43:52] <RoanKattouw>	 JSON.stringify always does single line, doesn't it?
[20:44:13] <mooeypoo>	 uhm apparently not?
[20:44:29] <mooeypoo>	 I keep getting all arrays on multilines
[20:44:48] <RoanKattouw>	 Are you using $.toJSON() or something? What are you actually using to produce JSON?
[20:44:49] <mooeypoo>	 JSON.stringify( outputJson, null, '	' );
[20:45:06] <mooeypoo>	 Should I use .toJSON ?
[20:45:18] <RoanKattouw>	 No you should use JSON.stringify
[20:45:25] <RoanKattouw>	 What are the second and third params?
[20:45:31] <mooeypoo>	 The third is the spacing
[20:45:34] <mooeypoo>	 (so it's a tab)
[20:45:38] <mooeypoo>	 the second I forgot, checking now
[20:46:02] <mooeypoo>	 oh, a 'replacer'
[20:46:05] <mooeypoo>	 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify
[20:46:40] <RoanKattouw>	 Oh right
[20:46:59] <mooeypoo>	 These are the only three parameters, and they seem to not have anything to do with the multilines.
[20:47:35] <RoanKattouw>	 Oh right because your space param does not contain \n
[20:47:47] <mooeypoo>	 no, it's just a tab
[20:47:52] <mooeypoo>	 :\ weird.
[20:48:27] <RoanKattouw>	 WTF, you're right
[20:48:29] <RoanKattouw>	 Look at this
[20:48:34] <RoanKattouw>	 >>> JSON.stringify([1,2,3])
[20:48:35] <ecmabot-wm>	 RoanKattouw: (string) '[1,2,3]'
[20:48:37] <mooeypoo>	 It's not terrible, but if a templatedata string was written by hand and then the user edits *anything* in it (not related to the arrays) the arrays are going multiline, which is a dirty diff really
[20:48:39] <RoanKattouw>	 >>> JSON.stringify([1,2,3], null, '\t')
[20:48:40] <ecmabot-wm>	 RoanKattouw: (string) '[\n\t1,\n\t2,\n\t3\n]'
[20:48:44] <mooeypoo>	 :\
[20:49:18] <RoanKattouw>	 >>> JSON.stringify([1,2,3], null, ' ')
[20:49:19] <ecmabot-wm>	 RoanKattouw: (string) '[\n 1,\n 2,\n 3\n]'
[20:49:24] <RoanKattouw>	 >>> JSON.stringify([1,2,3], null, '\n')
[20:49:25] <ecmabot-wm>	 RoanKattouw: (string) '[\n\n1,\n\n2,\n\n3\n]'
[20:49:33] <RoanKattouw>	 Yeah it just adds \n no matter what the spacing is
[20:49:36] <RoanKattouw>	 >>> JSON.stringify([1,2,3], null, 'MORIEL')
[20:49:37] <ecmabot-wm>	 RoanKattouw: (string) '[\nMORIEL1,\nMORIEL2,\nMORIEL3\n]'
[20:49:38] <mooeypoo>	 It's adding the ]n no mater what
[20:49:43] <mooeypoo>	 ooh I like this spacer
[20:49:50] <mooeypoo>	 :D
[20:50:03] <mooeypoo>	 but yeah. I guess I have no choice. It's weird that it can't be set up though
[20:50:13] <mooeypoo>	 I also don't want to remove it from everything, just the arrays
[20:52:07] <RoanKattouw>	 Super weird
[20:52:14] <RoanKattouw>	 I wonder if \n can legitimately appear in any other case
[20:52:25] <RoanKattouw>	 >>> JSON.stringify("foo\nbar\nbaz")
[20:52:26] <ecmabot-wm>	 RoanKattouw: (string) '"foo\\nbar\\nbaz"'
[20:52:35] <RoanKattouw>	 See it gets escaped in string literals
[20:53:00] <RoanKattouw>	 >>> JSON.stringify({"foo":"bar\nbaz", "quux":"whee\nyay"}, null, "XYZ")
[20:53:00] <ecmabot-wm>	 RoanKattouw: (string) '{\nXYZ"foo": "bar\\nbaz",\nXYZ"quux": "whee\\nyay"\n}'
[20:53:10] <RoanKattouw>	 Oh look and \n appears in object literals too
[20:53:15] <RoanKattouw>	 You could just strip it though
[20:53:19] <RoanKattouw>	 .replace( /\n/g, '' )
[20:54:11] <grrrit-wm>	 (03PS23) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) 
[20:54:32] <mooeypoo>	 hmm
[20:54:48] <mooeypoo>	 RoanKattouw, but I don't want to strip it for the json string, it should have \n
[20:54:53] <mooeypoo>	 I want to only take it out for arrays
[20:55:01] <RoanKattouw>	 Arrays but not objects?
[20:55:10] <mooeypoo>	 yeah, objects should be multiline, it's easier to read
[20:55:25] <mooeypoo>	 they usually have a lot of properties anyways
[20:55:42] <mooeypoo>	 The templatedata should still be human-readable. Just weird with the arrays
[20:58:59] <grrrit-wm>	 (03PS2) 10Catrope: Update VE core submodule to 68c07ec0e39f210bb53a0dc777429d72f454d600 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150051 (owner: 10Trevor Parscal)
[21:01:04] <mooeypoo>	 bah, "verified/fixed" emails from Bugzilla should arrive with a different color or something.
[21:01:12] <mooeypoo>	 I keep seeing "REGRESSION!" and my heart drops
[21:01:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to 68c07ec0e39f210bb53a0dc777429d72f454d600 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150051 (owner: 10Trevor Parscal)
[21:15:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Category input box is too small (sometimes) - 10https://bugzilla.wikimedia.org/69574 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None Steps to reproduce:  1.  Add a short category or three.  (At en.wp, you can add Category:1, Category:2, and Category:3,...
[21:15:32] * RoanKattouw casts nasty looks in James_F|Away's direction
[21:15:57] <RoanKattouw>	 You "broke the world" as cscott_away so eloquently described it, but no pull-through?
[21:17:54] <grrrit-wm>	 (03PS10) 10Cmcmahon: [BrowserTest] WIP: create new test for Cite tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150055 
[21:21:39] <edsanders>	 did we miss the IE AMA: http://www.reddit.com/r/IAmA/comments/2dk60t/we_build_internet_explorer_i_know_right_ask_us/ ?
[21:22:16] <RoanKattouw>	 Yeah it's 5:22pm Eastern now
[21:22:20] <RoanKattouw>	 Dang it
[21:22:26] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Disable the context menu for the Basic reference - 10https://bugzilla.wikimedia.org/68897#c5 (10Rummana Yasmeen) Verified the fix in test2
[21:23:56] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] Each category is getting added twice in Betalabs, throws TypeError: categoryItem is undefined - 10https://bugzilla.wikimedia.org/68484#c13 (10Rummana Yasmeen) Verified the fix in test2
[21:51:58] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: tapping into middle of link inspector text causes lots of issues - 10https://bugzilla.wikimedia.org/69578 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None Steps to repro:  1. In prod/stable on iPad, enter VE edit mode and tap on a 2-word wikilink (e.g...
[21:52:57] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: tapping into middle of link inspector text causes lots of issues - 10https://bugzilla.wikimedia.org/69578#c1 (10Maryana Pinchuk) Sorry, that should be:  3. Tap on the end of the FIRST word (e.g., after "European")
[22:25:20] <grrrit-wm>	 (03PS11) 10Cmcmahon: [BrowserTest] WIP: create new test for Cite tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150055 
[22:36:40] <grrrit-wm>	 (03PS12) 10Cmcmahon: [BrowserTest] WIP: create new test for Cite tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150055