[00:24:26] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Sometimes the edit link for VE does not appear - 10https://bugzilla.wikimedia.org/54706#c4 (10Alex Monk) Have you seen this issue recently? If not, this could probably be closed...
[01:03:38] <grrrit-wm>	 (03PS1) 10Catrope: Update VE core submodule to master (8e2477c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 
[01:04:00] <RoanKattouw>	 OK that should unbreak the world
[01:04:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (8e2477c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 (owner: 10Catrope)
[01:05:13] <RoanKattouw>	 or not?
[01:07:31] <grrrit-wm>	 (03PS2) 10Catrope: Update VE core submodule to master (8e2477c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 
[01:08:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (8e2477c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 (owner: 10Catrope)
[01:12:20] <Svetlana>	 Hi all. Would you please release VE to beta on non-wikipedia wikis? It's absent there in any shape or form atm.
[01:12:33] <Svetlana>	 Specifically I can see it missing on Russian Wikinews.
[01:17:02] <RoanKattouw>	 Svetlana: You should talk to James_F|Away about that
[01:17:26] <RoanKattouw>	 He is in Europe this week, so he's asleep (it's 2am there)
[01:17:43] <RoanKattouw>	 But you should be able to reach him during working hours European time, or during San Francisco hours next week
[01:17:45] <RoanKattouw>	 You can also send him an email if you like
[01:18:06] <RoanKattouw>	 jforrester@
[01:20:00] <RoanKattouw>	 Svetlana: French Wikinews has VE though so you'll probably just get it if you ask
[01:24:56] <Svetlana>	 RoanKattouw: https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/FAQ how to disable VE? "To continue to edit the wikitext directly, simply click the "Edit source" button instead of "Edit". On section edit links, you can open the classic wikitext editor for that section by clicking "edit source" instead of the regular "edit" link. If you would like to remove VisualEditor from the user...
[01:24:58] <Svetlana>	 ...interface, then you can go to the Editing tab of your Preferences page, untick the checkbox "Enable VisualEditor (only in the main and user namespaces)"," -- https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-editing does not have this button. Please help!
[01:25:03] <Svetlana>	 RoanKattouw_away: ^
[01:25:07] <Svetlana>	 Or anyone.
[01:32:52] <MatmaRex>	 Svetlana: it's in the "Beta features" tab
[01:33:14] <MatmaRex>	 the configuration changed back-and-forth a few times
[01:33:49] <MatmaRex>	 Svetlana: the instructions on that page are applicable to wikis where VE is enabled by default
[01:34:18] <MatmaRex>	 actually no, they aren't, there's a checkbox that you need to tick rather than untick there
[01:34:28] <MatmaRex>	 they are just outdated, then
[01:37:36] <Svetlana>	 I just now noticed that https://www.mediawiki.org/wiki/VisualEditor has a release plan which only involves Wikipedias and does not involve any other sister projects. ... It has a note saying that they may be given access to it after Wikipedias.
[01:37:56] <Svetlana>	 I emailed James_F|Away asking to add it to beta features on non-Wikipedias. What a shame.
[01:40:02] <Svetlana>	 Your love for sister projects! Oh, the love for the Wikimedia movement! How cunning.
[01:46:00] <Svetlana>	 I imagine it's hard to implement all the things sister projects need, but they're sisters; the users would like to see some consistency I gather. Right now, they'll see it working on Wikipedia, but not anywhere else (and some who are not Wikipedia users will not even notice)..
[01:58:48] <Svetlana>	 James_F: hi.
[01:58:55] <Svetlana>	 James_F: see the above, please. :-)
[07:21:56] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Opening the drop-down for a category in the page settings > category pane can cause a category entry to be duplicated - 10https://bugzilla.wikimedia.org/55405#c1 (10Alex Monk) Didn't we fix a bug like this recently? Is this still valid?
[07:54:06] <grrrit-wm>	 (03PS4) 10Jforrester: Editable blockquotes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders)
[09:04:00] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "PS4 is a rebase. Product issues remain." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders)
[09:09:35] <grrrit-wm>	 (03PS3) 10Jforrester: [WIP] Cache all the things in SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140244 (owner: 10Catrope)
[09:10:10] <grrrit-wm>	 (03PS4) 10Jforrester: [WIP] Cache all the things in SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140244 (owner: 10Catrope)
[09:10:42] <grrrit-wm>	 (03CR) 10Jforrester: "PS3 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140244 (owner: 10Catrope)
[09:12:27] <grrrit-wm>	 (03PS2) 10Jforrester: Add some sanity checks in newFromReplacement, pushInsertion and pushRemoval [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope)
[09:12:49] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "PS2 is a rebase. David's -1 still applies." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope)
[09:17:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add some sanity checks in newFromReplacement, pushInsertion and pushRemoval [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope)
[09:21:03] <grrrit-wm>	 (03PS2) 10Jforrester: WIP some failing tests in fixUpInsertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114357 (owner: 10Esanders)
[09:22:19] <grrrit-wm>	 (03CR) 10Jforrester: "PS2 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114357 (owner: 10Esanders)
[09:22:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP some failing tests in fixUpInsertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114357 (owner: 10Esanders)
[09:34:13] <wikibugs>	 3VisualEditor: Pasting header inserts ☀ - 10https://bugzilla.wikimedia.org/69595 (10Jan Ainali) 3NEW p:3Unprio s:3normal a:3None I copied part of a header from one page on se.wikimedia and pasted in an already started header on another page. After my paste the symbol ☀ was added:  https://se.wikimedia....
[09:50:14] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Minor UnicodeJS pull-in issue." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 (owner: 10Catrope)
[09:54:26] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Sometimes the edit link for VE does not appear - 10https://bugzilla.wikimedia.org/54706#c5 (10James Forrester) 5ASSI>3RESO/WOR No recent reports.
[09:57:13] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Make defaultsort input field always use "real" text, not a placeholder - 10https://bugzilla.wikimedia.org/50002#c5 (10James Forrester) *** Bug 69568 has been marked as a duplicate of this bug. ***
[09:57:13] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Offer to pre-fill the DEFAULTSORT field - 10https://bugzilla.wikimedia.org/69568#c1 (10James Forrester) 5NEW>3RESO/DUP This is the same as bug 50002 (and needs a huge amount of design thought).  *** This bug has been marked as a duplicate of bug 50002 ***
[09:57:58] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Opening the drop-down for a category in the page settings > category pane can cause a category entry to be duplicated - 10https://bugzilla.wikimedia.org/55405#c2 (10James Forrester) 5ASSI>3RESO/FIX a:3Alex Monk Yeah, I think so.
[10:31:36] <grrrit-wm>	 (03PS5) 10Divec: WIP: Kleptologging and interesting thing detection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 
[10:32:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Kleptologging and interesting thing detection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 (owner: 10Divec)
[10:39:11] <grrrit-wm>	 (03PS6) 10Divec: WIP: Kleptologging and interesting thing detection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 
[13:32:26] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: VE crash mid-edit in IE9 - 10https://bugzilla.wikimedia.org/49464#c1 (10Andre Klapper) and.radiate: Have you seen this problem again with a more recent VE version?
[14:52:14] <grrrit-wm>	 (03CR) 10Esanders: "It at least makes things more consistent. We will need more remove options for touch devices in the future so that can be fixed then." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150194 (owner: 10Esanders)
[14:54:12] <grrrit-wm>	 (03CR) 10Jforrester: "We need remove buttons for touch devices *now*. :-P" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150194 (owner: 10Esanders)
[14:56:57] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Make defaultsort input field always use "real" text, not a placeholder - 10https://bugzilla.wikimedia.org/50002#c6 (10pamdavies7) (In reply to pamdavies7 from comment #3) > Thanks for the explanation! So it remains a bug - and distinctly irritating, > for someone...
[15:04:30] * tommorris wonders when someone is going to look at https://bugzilla.wikimedia.org/show_bug.cgi?id=69429 ;-)
[15:11:32] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "Documentation/naming issues." (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope)
[15:14:25] <grrrit-wm>	 (03CR) 10Esanders: "Is it worth showing a disabled button? That suggests that in some contexts the button might become enabled, but for required parameters th" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154133 (https://bugzilla.wikimedia.org/60358) (owner: 10Alex Monk)
[15:14:37] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] Disable delete button for required parameters in template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154133 (https://bugzilla.wikimedia.org/60358) (owner: 10Alex Monk)
[15:16:43] <grrrit-wm>	 (03CR) 10Esanders: WIP: Kleptologging and interesting thing detection (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 (owner: 10Divec)
[15:27:39] <grrrit-wm>	 (03CR) 10Esanders: WIP: Record intention in ve.dm.Transaction object (0320 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 (owner: 10Cscott)
[15:34:30] <grrrit-wm>	 (03PS3) 10Esanders: [UNMERGED] Update OOjs UI to v0.1.0-pre (a83bdf7700) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150050 (owner: 10Trevor Parscal)
[15:38:57] <cscott>	 woot!  just got the togetherjs+visualeditor demo back roughly to where it was in august of last year. ;)
[15:39:18] <cscott>	 you can type at VE in one browser and it shows up in the other.
[15:39:32] <cscott>	 this time based on "intentions" not the low level transaction operations.
[15:40:05] <cscott>	 however, deploying this to my userscripts requires monkey patching VE.  so maybe i should try to get those patches upstreamed now. ;)
[15:45:58] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "In the dialog demo, which now doesn't use iframes, some of the bottom padding is broken." [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal)
[16:12:11] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Breaking words on diacritics - 10https://bugzilla.wikimedia.org/61955#c1 (10Ed Sanders) I suspect this had nothing to do with diacritics, but was because there was unbalanced wikitext. It looks like Parsoid outputs that particular wikitext differently now anywa...
[16:17:18] <grrrit-wm>	 (03PS7) 10Divec: ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 
[16:19:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 (owner: 10Divec)
[16:24:15] <grrrit-wm>	 (03PS8) 10Divec: ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 
[16:25:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 (owner: 10Divec)
[16:30:24] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on fiwiki: https://fi.wikipedia.org/?diff=14226429
[16:32:03] <grrrit-wm>	 (03PS9) 10Divec: ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 
[16:33:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 (owner: 10Divec)
[16:33:41] <grrrit-wm>	 (03PS10) 10Divec: ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 
[16:36:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 (owner: 10Divec)
[16:39:41] <divec_>	 Anyone know how to add ES6's Set into the list of accepted jsduck types? https://integration.wikimedia.org/ci/job/VisualEditor-jsduck/2033/console
[16:41:47] <MatmaRex>	 divec: try adding it at the end of the .docs/categories.json file?
[16:42:06] <MatmaRex>	 where things like Array, Boolean, Date are listed
[16:43:33] <divec_>	 Yeah, I have it there: https://gerrit.wikimedia.org/r/#/c/152123/10/.docs/categories.json . Is there some magic that checks whether "JavaScript" classes are known types? Or have I just got the syntax wrong? :-)
[16:46:01] <grrrit-wm>	 (03PS1) 10Esanders: Fix teardown of live extension nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154287 
[16:46:07] <MatmaRex>	 ha. no idea then
[16:46:26] <MatmaRex>	 indeed it seems to have some internal list
[17:00:27] <grrrit-wm>	 (03PS11) 10Divec: ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 
[17:02:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 (owner: 10Divec)
[17:03:39] <grrrit-wm>	 (03PS12) 10Divec: ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 
[17:24:41] <edsanders>	 cscott, yes...
[17:28:19] <RoanKattouw>	 tommorris: It sounds really scary and I meant to look at it the day you filed it, but I got caught up in other stuff
[17:29:17] <grrrit-wm>	 (03CR) 10Catrope: "I know what's causing the test failure and I'm working on it. It's a long-standing race condition that seems to have decided to become mor" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 (owner: 10Catrope)
[17:30:22] <grrrit-wm>	 (03CR) 10Catrope: Update VE core submodule to master (8e2477c) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 (owner: 10Catrope)
[17:36:08] <grrrit-wm>	 (03PS3) 10Catrope: Update VE core submodule to master (8e2477c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 
[17:37:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (8e2477c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 (owner: 10Catrope)
[17:45:41] <cscott>	 edsanders, RoanKattouw: what's the preferred way to serialize/de-serialize a ve.dm.Annotation ?
[17:46:24] <cscott>	 ve.dm.example.createAnnotation does a cute thing with annotation factory which looks like to would work to deserialize, i'm just not sure what the right method to create that structure is.
[17:50:51] <RoanKattouw>	 cscott: Probably serialize its linmod element (.element property)
[17:51:10] <RoanKattouw>	 Note though that like any other linmod element it can contain DOM elements which are scary from a serialization perspective
[17:51:23] <RoanKattouw>	 You may have noticed this if you've been trying to serialize alienBlock/alienInline nodes for instance
[17:51:31] <RoanKattouw>	 Or other things with an originalDomElements attribute
[17:51:47] <cscott>	 yes, i can handle DOM elements.  DOM parsing and serialization are a specialty of mine. ;)
[17:51:56] <RoanKattouw>	 In practice though I don't think any of our annotation types do this, so you should be cgood
[17:52:07] <cscott>	 how do I recreate the annotation object from the DOM element though?
[17:52:28] <cscott>	 oh, wait, this.element isn't necessarily a DOM element.
[17:53:04] <RoanKattouw>	 No this.element is a linmod element
[17:53:15] <RoanKattouw>	 e.g. { 'type': 'textStyle/bold', 'attributes': { 'nodeName': 'b' } }
[17:53:44] <RoanKattouw>	 So to serialize you probably just do JSON.stringify( annotation.getElement() )
[17:53:58] <RoanKattouw>	 To unserialize, I think there might be a factory function somewhere
[17:55:17] <RoanKattouw>	 Hmph there isn't
[17:55:48] <RoanKattouw>	 But what you need is something like data = JSON.parse( jsonString ); annotation = ve.dm.annotationFactory.create( data.type, data );
[17:56:25] <RoanKattouw>	 (That's if you know that it's an annotation; if you don't know whether something is an annotation, node or meta item yet, then you have to do something else)
[19:05:12] <RoanKattouw>	 WTF
[19:05:19] <RoanKattouw>	 The qunit index.html thing is totally broken
[19:05:25] <RoanKattouw>	 Looks like there's too many ../s in the paths
[19:07:25] <grrrit-wm>	 (03PS1) 10Catrope: Fix path prefix for tests/index.html so it actually runs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154303 
[19:07:45] <James_F>	 RoanKattouw: I blame edsanders.
[19:07:53] <James_F>	 RoanKattouw: It's not meant to run…
[19:08:13] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix path prefix for tests/index.html so it actually runs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154303 (owner: 10Catrope)
[19:08:14] <RoanKattouw>	 It's not run by grunt, now
[19:08:15] <RoanKattouw>	 *no
[19:08:27] <James_F>	 But it is by VE-MW.
[19:08:27] <RoanKattouw>	 But when I load the file in my browser, I expect more than a pile of 404s is what I mean
[19:08:32] <RoanKattouw>	 No it's not
[19:08:33] <James_F>	 Right?
[19:08:39] <RoanKattouw>	 VE-MW uses its own thing to hook into MW's test runner
[19:08:41] <James_F>	 OK. Ed said it worked for him. Tsk.
[19:08:53] <RoanKattouw>	 It may have if he had VE at his web root or something
[19:08:58] <James_F>	 Ah.
[19:09:25] * James_F heads off.
[19:10:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix path prefix for tests/index.html so it actually runs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154303 (owner: 10Catrope)
[19:15:35] <grrrit-wm>	 (03PS1) 10Catrope: Work around getSystemPlatform() race condition [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154304 
[19:17:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Work around getSystemPlatform() race condition [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154304 (owner: 10Catrope)
[19:50:39] <RoanKattouw_away>	  /back
[19:52:45] <grrrit-wm>	 (03PS2) 10Catrope: Work around getSystemPlatform() race condition [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154304 
[19:55:53] <grrrit-wm>	 (03PS1) 10Catrope: Make getParsedMessage() test actually test getParsedMessage() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154317 
[19:56:34] <RoanKattouw>	 edsanders: Could you merge these two commits --^^ so I can unbreak all the things?
[19:58:04] <RoanKattouw>	 I'm trying to do a pull-through of VE core into VE-MW, but even after cleaning up after the unicodejs move I had to hack around unit test problems
[20:27:35] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix teardown of live extension nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154287 (owner: 10Esanders)
[20:30:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix teardown of live extension nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154287 (owner: 10Esanders)
[20:57:32] <grrrit-wm>	 (03PS13) 10Divec: ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 
[20:57:36] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 (owner: 10Divec)
[20:58:45] <jgonera>	 edsanders, did you have a chance to look at that bug I wrote about? If not, I can try to investigate a bit more on my own today
[21:00:01] <grrrit-wm>	 (03PS14) 10Divec: ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 
[21:01:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 (owner: 10Divec)
[21:02:55] <jgonera>	 edsanders, bug 68832
[21:05:38] <edsanders>	 Not in much detail yet
[21:08:04] <RoanKattouw>	 edsanders: I can haz code review? I'm trying to unbreak VE-MW so I can rebase and merge stuff there
[21:09:13] <edsanders>	 sync repos?
[21:09:18] <edsanders>	 it's v-2
[21:10:19] <RoanKattouw>	 Yeah because I have two commits in VE core that need to land
[21:10:29] <RoanKattouw>	 getParsedMessage and getSystemPlatform
[21:10:31] <RoanKattouw>	 Mostly the latter
[21:12:06] <grrrit-wm>	 (03PS15) 10Divec: ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 
[21:20:07] <jgonera>	 edsanders, so if I work on it today I probably won't duplicate your work?
[21:21:55] <edsanders>	 yes
[21:23:31] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Make getParsedMessage() test actually test getParsedMessage() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154317 (owner: 10Catrope)
[21:25:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make getParsedMessage() test actually test getParsedMessage() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154317 (owner: 10Catrope)
[21:27:19] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Work around getSystemPlatform() race condition [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154304 (owner: 10Catrope)
[21:27:47] <RoanKattouw>	 Thanks edsanders 
[21:28:51] <jgonera>	 edsanders, yes I will or yes I won't? ;)
[21:29:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Work around getSystemPlatform() race condition [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154304 (owner: 10Catrope)
[21:32:32] <grrrit-wm>	 (03PS4) 10Catrope: Update VE core submodule to master (03975f8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 
[21:33:24] <grrrit-wm>	 (03PS5) 10Catrope: Update VE core submodule to master (03975f8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 
[21:34:34] <grrrit-wm>	 (03PS6) 10Catrope: Update VE core submodule to master (03975f8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 
[21:36:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (03975f8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 (owner: 10Catrope)
[21:37:40] <grrrit-wm>	 (03PS7) 10Catrope: Update VE core submodule to master (03975f8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 
[21:40:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (03975f8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 (owner: 10Catrope)
[21:42:43] <grrrit-wm>	 (03PS8) 10Catrope: Update VE core submodule to master (03975f8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 
[21:44:10] <grrrit-wm>	 (03PS16) 10Divec: ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 
[21:46:19] <RoanKattouw>	 edsanders: 
[21:46:28] <RoanKattouw>	 edsanders: Yaaaay I got https://gerrit.wikimedia.org/r/#/c/154224/ to be V+2, could you review that one?
[21:55:11] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Launching isolated windows is completely broken." [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal)
[21:56:21] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Update VE core submodule to master (03975f8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 (owner: 10Catrope)
[21:57:45] <grrrit-wm>	 (03PS13) 10Catrope: [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal)
[21:58:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (03975f8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154224 (owner: 10Catrope)
[21:58:21] <grrrit-wm>	 (03CR) 10Catrope: "Fixed that problem in PS13 by initializing the window before the loading promise is resolved, not after. This was probably broken by the m" [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal)
[22:10:33] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "Both my comments on PS12 stand." [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal)
[22:15:29] <RoanKattouw>	 edsanders: Don't worry, I'm finding and fixing more things that are broken
[22:38:52] <edsanders>	 jgonera, sorry, I'm not working on it, go wild!
[22:41:45] <grrrit-wm>	 (03CR) 10Catrope: Use Config instead of globals (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153762 (owner: 10Legoktm)
[22:50:33] <grrrit-wm>	 (03PS3) 10Legoktm: Use Config instead of globals [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153762 
[22:53:21] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Use Config instead of globals [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153762 (owner: 10Legoktm)
[22:55:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use Config instead of globals [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153762 (owner: 10Legoktm)
[23:48:59] <wikibugs>	 3VisualEditor / 3Mobile: VE Mobile: The word "Editing" floats randomly underneath the back button - 10https://bugzilla.wikimedia.org/69632 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Device: Nexus 7.  The word "Editing" floats kind of randomly underneath the back button.  Now that I've written thi...