[00:18:35] Hah! Krenair & James_F, have you seen this ? https://twitter.com/wikimediauk/statuses/498072240672755712 [00:18:47] (03PS1) 10Jforrester: Drop references to magnify-clip-{ltr,rtl}.png file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155165 [00:19:04] It also appears in Wikimania's best moments compilation https://storify.com/wikimanialondon/wikimania2014-best-moments [00:20:13] (03CR) 10Catrope: [C: 032] Drop references to magnify-clip-{ltr,rtl}.png file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155165 (owner: 10Jforrester) [00:21:46] (03Merged) 10jenkins-bot: Drop references to magnify-clip-{ltr,rtl}.png file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155165 (owner: 10Jforrester) [00:23:21] James_F: thanks! [00:24:58] MatmaRex: Welcome. Turned out to be trivial and RoanKattouw goaded me into fixing it. :-) [00:28:30] (03CR) 10Jforrester: [C: 031] Use a pollNode for every transplanted stylesheet, not just external ones [oojs/ui] - 10https://gerrit.wikimedia.org/r/155156 (owner: 10Catrope) [00:30:25] (03PS9) 10Mooeypoo: Refactoring ImageModel constructor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149191 [00:30:41] (03PS14) 10Mooeypoo: Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) [00:30:48] (03PS8) 10Mooeypoo: [wip] Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) [00:30:51] all hail git stash [00:31:02] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (f59a154680) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155170 [00:44:01] (03PS5) 10Jforrester: Fix `ve.dm.Transaction.newFromReplacement` when `removeMetadata` is true [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152017 (owner: 10Cscott) [00:44:26] (03CR) 10Jforrester: [C: 031] "PS5 removes the '.' from the commit subject, per coding conventions." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152017 (owner: 10Cscott) [00:45:05] (03CR) 10Jforrester: [C: 031] Factor out ve.dm.Transaction.pushReplaceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116214 (owner: 10Catrope) [00:55:17] (03CR) 10Jforrester: [C: 032] "Nice catch." [oojs/ui] - 10https://gerrit.wikimedia.org/r/155011 (owner: 10Esanders) [00:56:19] (03PS3) 10Jforrester: demos: Refactor tool groups to be re-usable between toolbars [oojs/ui] - 10https://gerrit.wikimedia.org/r/150732 (owner: 10Krinkle) [00:56:24] (03Merged) 10jenkins-bot: Adjust for border with box-sizing: border-box [oojs/ui] - 10https://gerrit.wikimedia.org/r/155011 (owner: 10Esanders) [00:58:10] (03CR) 10Jforrester: [C: 032] "Though I'll miss the auto-disabling list." [oojs/ui] - 10https://gerrit.wikimedia.org/r/150732 (owner: 10Krinkle) [00:58:45] (03Merged) 10jenkins-bot: demos: Refactor tool groups to be re-usable between toolbars [oojs/ui] - 10https://gerrit.wikimedia.org/r/150732 (owner: 10Krinkle) [00:59:47] (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (51f513f9d3) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155170 [01:01:13] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832#c11 (10Juliusz Gonera) This is weird. I tried following the call stack deeper to see what exactly causes the problem, but I'm stuck in ve.ce.Surface.protot... [01:04:14] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (51f513f9d3) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155170 (owner: 10Jforrester) [01:06:05] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (51f513f9d3) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155170 (owner: 10Jforrester) [01:06:42] (03PS1) 10Jforrester: Update VE core submodule to master (d515ce6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155175 [01:08:18] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (d515ce6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155175 (owner: 10Jforrester) [01:09:09] mooeypoo: ^^^ Do we need to update some of the test cases for that? [01:19:43] (03CR) 10Catrope: [C: 04-1] ve.Filibuster: Scrupulous state logging (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 (owner: 10Divec) [01:39:28] James_F, for what? [01:39:52] mooeypoo: The failing pull-through. Never mind, I'll explore. [01:40:07] Oh, the new Scalable change? [01:40:32] hm, I don't think so, but I can check. It shouldn't have failed tests. We renamed 2 methods (and I grepped for the old ones before +2'ing) [01:40:37] and the rest is internal, should work [01:40:37] * James_F nods. [01:41:00] I only glanced, but the failing test was in DM deleting code, which was a bit surprising. [01:41:17] But some of those have examples that assume things about length that stop being true. [01:41:23] deleting? Interesting. That shouldn't be from the Scalable, I don't think. [01:41:31] I don't think we did anything with images in core yet [01:41:32] Yeah. [01:41:42] ed has a bunch awaiting but I don't think it's merged yet [01:41:48] tags are sometimes used as example content. [01:42:02] Earlier, with the expectation that they'd be alienated. [01:42:08] Really? Out of all the sane tags, we use *images* for tests? [01:42:12] (Helpful. ;-0) [01:42:16] :D [01:42:26] :-) [01:42:26] Yeah, well. [01:42:54] BTW, James_F, the image model chain should fix most (if not all, here's for hoping) of the image model bugs [01:43:23] I went over the nowiki bug and explained the situation there. Most of the nowiki stuff is user errors (typing wikitext) with 2 exceptions we might want to deal with at some point. [01:43:34] Sooo that means I will soon (say, tomorrow) need a new challenge to work on. [01:45:06] Oh, there's this one: https://bugzilla.wikimedia.org/show_bug.cgi?id=60919 I forgot about that. I was going to take a look. But yeah, most other bugs seem to be on their way to fixed. [01:45:29] James_F, is this something we want to implement now, or wait for the new media dialog design? https://bugzilla.wikimedia.org/show_bug.cgi?id=52219 [01:45:47] 3VisualEditor / 3Editing Tools: Template editor freezes when trying to re-edit a template - 10https://bugzilla.wikimedia.org/69769 (10Shimmy) 3UNCO p:3Unprio s:3blocke a:3None Created attachment 16240 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16240&action=edit The red circle surrounds th... [01:50:09] Nice. [01:50:34] Oh, yeah, 52219 is very trivial. [01:50:46] Also, Katie was going to talk to you about the new design. [01:50:48] Will bug her. [01:53:49] (03PS1) 10Jforrester: Emit an error if VE Target fails to load, so users aren't left entirely stranded [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155177 [01:54:59] (03CR) 10jenkins-bot: [V: 04-1] Emit an error if VE Target fails to load, so users aren't left entirely stranded [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155177 (owner: 10Jforrester) [01:56:13] 3VisualEditor / 3Editing Tools: Template editor freezes when trying to re-edit a template - 10https://bugzilla.wikimedia.org/69769 (10Shimmy) [02:09:13] (03PS2) 10Jforrester: Emit an error if VE Target fails to load, so users aren't left entirely stranded [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155177 [02:11:01] TrevorParscal: Looks like you also made it into the "best moments of Wikimania" thing: http://instagram.com/p/rhTzaZSfJC/ [02:11:16] nice! [02:12:17] TrevorParscal: Also, RoanKattouw's finding lots of things to moan at you about in OOUI and its impact on IE specifically. :-) [02:12:41] I'm writing a bug report saying that we should just non-isolation-proof inspectors [02:13:05] i'm interested in how we can do that [02:13:09] Because something subtle changed in the timing of how things are executed and now IE is blurring the surface at the wrong time and closing inspectors right after they open [02:13:17] Apparently IE doesn't do dual selection (iframe+main doc) at all [02:13:38] maybe we can just do away with isolation and fake the selection while inspecting or something [02:13:58] But before the great and terrible dialog refactor, the focus moved with exactly the right timing so that DesktopContext didn't notice [02:14:00] And in dialogs? [02:14:21] That was an awesome lecture, TrevorParscal. I want the video of that and the other two [02:14:31] But no video ... yet, at least [02:14:47] Yeah, no videos outside the main hall yet. [02:15:08] What's even worse is that trying to observe what happened actually changes the behavior [02:15:54] mooeypoo: BTW fixing https://gerrit.wikimedia.org/r/#/c/152749/ shouldn't be too hard presumably? [02:16:00] Like, even in the case where LinkTargetInputWidget's focusing of the input isn't noticed by onFocusChange, adding in console.log()s that dump what is currently selected in the main document causes more events to occur and so onFocusChange notices and closes the inspector [02:16:06] That's probably a rangy bug [02:16:21] James_F, that's fixed in the new templatedata refactor. [02:16:26] mooeypoo: Ah, OK. Rebase it onto that then? [02:16:28] should I fix that too? it seems a bit backwards, but I can. [02:16:56] I was going to hope krinkle approves the other one fast enough so we don't have to patch up the current (IE, abandon this) but I don't know that this is realistic anymore [02:17:04] :-( [02:17:15] mrr. I'll fix the tests there. [02:17:15] * James_F ponders just +2ing. [02:17:18] I wonder though if I can fix this quickly [02:17:36] TrevorParscal: Let me try doing something like .first( 0 ) at the beginning of getReadyProcess [02:17:39] Well, presumably we need to make sure it's tested. But yeah, I hope Krinkle checks it out quickly. [02:18:18] I think that might make the stars align in such a way that the input box will not yet have been focused when focusout happens [02:19:12] mooeypoo: I don't think Krinkle is going to get a 2000-line patch reviewed before the heat-death of the universe at this rate. :-( [02:19:36] The Universe is likely to have a cold death, actually. Does that help? [02:19:39] :D [02:20:03] "Heat-death of the Universe" means lack of heat, as well you know. :-) [02:20:30] Oh, does it? I always thought it means death by heat [02:20:36] I was all "that's so not the physics" [02:20:42] ... That explains everything. [02:20:46] Ha. Yeah. [02:21:24] Anywyas, timo reviewed it last time and had valid comments that I fixed. I'm a bit weary approving it without him. But yeah, it's pretty big. But it resolves a LOT of bugs [02:21:28] and gives a lot of new functionality [02:21:48] And it *should* be more understandable code-wise. [02:21:51] I think. [02:21:57] It's pretty readable. [02:22:13] I tried to separate model from view as much as possible, and denote them as such [02:22:25] There are some minor changes I'd make to the documentation, but… [02:22:59] HA [02:23:01] THAT WORKED [02:23:11] Comment away! I think I will have enough time to fix before the heat-death of the universe. :D [02:23:20] RoanKattouw, your caps lock? [02:23:21] TrevorParscal: So, yeah, adding a 0ms timeout at the beginning of the readyProcess in FragmentInspector totally "fixes" this bug [02:23:43] (03CR) 10Jforrester: [C: 031] "This works, and the code is OK. I'll +2 if no-one objects in the next 48 hours." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [02:23:47] a 0ms timeout? Isn't that a no-timeout ? [02:23:56] mooeypoo: ^^^ Happy? [02:23:59] \o/ [02:24:01] thanks James_F :D [02:24:03] * James_F grins. [02:24:08] You tested? [02:24:23] it looks and feels okay, I hope? The reordering of the params is what we talked about [02:24:29] Yeah, I like it. [02:24:39] awesome [02:46:02] (03PS1) 10Catrope: [WIP] Make OO.ui.Frame's $content a div again [oojs/ui] - 10https://gerrit.wikimedia.org/r/155181 [02:51:14] (03PS1) 10Catrope: Followup b141a7d2: make inspectors not close immediately in IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155182 [02:51:39] (03CR) 10Catrope: "This only works together with https://gerrit.wikimedia.org/r/155181 in oojs-ui, which is WIP for now" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155182 (owner: 10Catrope) [03:08:38] hm [03:09:48] This is odd. I'm trying to get the media dialog to recognize if the user replaced the image with itself (so, chose the same image). However, the src attribute of my initial image is "//upload.wikimedia.org/wikipedia/commons/0/0f/Main_page_commons.jpg" and the new image (which is the same) is this: "http://upload.wikimedia.org/wikipedia/commons/thumb/0/0f/Main_page_commons.jpg/282px-Main_page_commons.jpg" [03:10:14] I assume this is the thumbnail size, not the original [03:14:11] hm. url vs thumburl [10:22:38] (03CR) 10Esanders: [WIP] Make OO.ui.Frame's $content a div again (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/155181 (owner: 10Catrope) [11:06:16] 3VisualEditor / 3Editing Tools: VisualEditor: If there is a page with the exact name, it should appear first in the link auto-complete list - 10https://bugzilla.wikimedia.org/69780 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Select some text and press Ctrl-K. A link inspector will show, and... [12:20:29] (03CR) 10Divec: ve.Filibuster: Scrupulous state logging (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 (owner: 10Divec) [12:20:58] (03PS20) 10Divec: ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 [13:55:59] (03PS1) 10Esanders: Fix check for left/right annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155260 (https://bugzilla.wikimedia.org/68588) [13:56:00] 3VisualEditor / 3Data Model: VisualEditor: Putting cursor after reference list throws "offset was inside a handlesOwnChildren node" error - 10https://bugzilla.wikimedia.org/68588 (10Ed Sanders) [15:30:27] One of my edits has the following tag "VisualEditor: Check" does anyone know what it means? [15:35:20] One of my edits has the following tag "VisualEditor: Check" does anyone know what it means? [15:44:33] (03PS1) 10Phuedx: Reinstate the ve-ui-toolbar-saveButton class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155280 (https://bugzilla.wikimedia.org/69784) [15:54:26] 3MediaWiki extensions / 3WikiEditor: Load toolbar on element ready instead of content ready - 10https://bugzilla.wikimedia.org/45144#c2 (10Bartosz Dziewoński) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 45145 *** [16:01:53] 3VisualEditor / 3MediaWiki integration: VisualEditor: Suggest templates more proactively in the template adding dialog - 10https://bugzilla.wikimedia.org/69787 (10Amir E. Aharoni) 3NEW p:3Unprio s:3enhanc a:3None Currently, in the template adding dialog there is just one search box and a lot of empty... [16:05:39] ReadError: Hey. "VisualEditor: Check" means that VisualEditor is worried it might have corrupted the article you edited. It's rare to be flagged up, and even then about 90% of the time it's fine, but we check them out to make sure we're not breaking things. [16:06:40] (03CR) 10Jforrester: [C: 04-1] "Put in a comment that this class is here for a reason, or it will just get cleaned up next time around…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155280 (https://bugzilla.wikimedia.org/69784) (owner: 10Phuedx) [16:30:29] Corruption alert: visualeditor-needcheck on dawiki: https://da.wikipedia.org/?diff=7744116 [16:39:56] (03PS2) 10Phuedx: Reinstate the ve-ui-toolbar-saveButton class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155280 (https://bugzilla.wikimedia.org/69784) [16:46:46] (03CR) 10Jforrester: [C: 032] "Sorry for the disruption!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155280 (https://bugzilla.wikimedia.org/69784) (owner: 10Phuedx) [16:46:59] thanks James_F :) [16:47:20] phuedx: Sorry for breaking things! [16:47:33] we move fast and break things, right? [16:48:23] True, but… :-) [16:48:26] (03Merged) 10jenkins-bot: Reinstate the ve-ui-toolbar-saveButton class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155280 (https://bugzilla.wikimedia.org/69784) (owner: 10Phuedx) [16:54:08] 3VisualEditor / 3MediaWiki integration: VisualEditor: Reinstate the semantic class on the "Save page" button - 10https://bugzilla.wikimedia.org/69784 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal a:3Sam Smith [17:52:40] (03PS2) 10Catrope: Fix check for left/right annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155260 (https://bugzilla.wikimedia.org/68588) (owner: 10Esanders) [17:52:58] (03Abandoned) 10Catrope: Fix pulling of annotations when typing at the beginning of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150378 (https://bugzilla.wikimedia.org/68597) (owner: 10Alex Monk) [17:53:23] (03CR) 10Catrope: [C: 032] Fix check for left/right annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155260 (https://bugzilla.wikimedia.org/68588) (owner: 10Esanders) [17:53:51] 3VisualEditor / 3Data Model: VisualEditor: Typing at the beginning of the document pulls annotations from the right; should instead be null - 10https://bugzilla.wikimedia.org/68597 (10James Forrester) 5PATC>3RESO/FIX a:5Alex Monk>3Ed Sanders [17:54:05] 3VisualEditor / 3Data Model: VisualEditor: Putting cursor after reference list throws "offset was inside a handlesOwnChildren node" error - 10https://bugzilla.wikimedia.org/68588 (10James Forrester) 5PATC>3RESO/FIX [17:54:23] 3VisualEditor / 3Editing Tools: VisualEditor: The custom tab does not get enabled after making an image of type "Frame" to full size - 10https://bugzilla.wikimedia.org/69794 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Insert an image 3.Change the... [17:55:30] (03Merged) 10jenkins-bot: Fix check for left/right annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155260 (https://bugzilla.wikimedia.org/68588) (owner: 10Esanders) [18:17:28] (03PS17) 10Trevor Parscal: [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 [18:17:32] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal) [18:19:50] (03CR) 10Trevor Parscal: [C: 032] Support nested style transplantation [oojs/ui] - 10https://gerrit.wikimedia.org/r/155157 (owner: 10Catrope) [18:20:23] (03CR) 10Trevor Parscal: [C: 032] Use a pollNode for every transplanted stylesheet, not just external ones [oojs/ui] - 10https://gerrit.wikimedia.org/r/155156 (owner: 10Catrope) [18:21:24] (03Merged) 10jenkins-bot: Use a pollNode for every transplanted stylesheet, not just external ones [oojs/ui] - 10https://gerrit.wikimedia.org/r/155156 (owner: 10Catrope) [18:22:12] (03Merged) 10jenkins-bot: Support nested style transplantation [oojs/ui] - 10https://gerrit.wikimedia.org/r/155157 (owner: 10Catrope) [18:45:37] 3VisualEditor / 3Mobile: VisualEditor Mobile: Switching tabs in mobile safari often causes page to refresh causing data loss of session changes - 10https://bugzilla.wikimedia.org/68017#c3 (10James Forrester) 5ASSI>3RESO/WON Unfortunately, on investigation, this is something that we can't avoid; it's the... [18:45:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10James Forrester) 5REOP>3ASSI [18:50:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: Switching tabs in mobile safari often causes page to refresh causing data loss of session changes - 10https://bugzilla.wikimedia.org/68017#c4 (10Jared Zimmerman (WMF)) 5RESO/WON>3REOP This might not be able to resolved as the bug is written (stop safari from... [18:55:54] (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Make content isolation optional (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal) [19:09:53] 3VisualEditor / 3Editing Tools: VisualEditor: Editing a transclusion with many templates hangs the browser - 10https://bugzilla.wikimedia.org/69799 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None Go to https://nl.wikipedia.org/wiki/Lijst_van_rijksmonumenten_in_Zaandam?veaction=edit and double-click... [19:13:36] does VE REL1_23 work with MW REL1_23? Does anything need backporting? James_F? [19:18:23] 3VisualEditor / 3Editing Tools: VisualEditor: Categories go at the bottom, so please place the cursor above the categories - 10https://bugzilla.wikimedia.org/69802 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None Especially when there are only categories on the page, it does not appear to be possibl... [19:20:42] jgonera: Btw: Setting focus to an element will not work in iOS safari if the call is the eventual result of code in a timeout [19:21:07] I've dealt with similar problems in getting the WebODF Editor to work with that browser [19:21:08] 3VisualEditor / 3Editing Tools: VisualEditor: Adding text to a category resulted in an extra section heading with span tags - 10https://bugzilla.wikimedia.org/69803 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None I have not been able to reproduce this at en.wikipedia.beta, and I didn't want to edi... [19:21:27] Which might explain why focus propagation is failing [19:21:39] unfortunately I don't have an iPad at the moment to test [19:26:17] legoktm: https://bugzilla.wikimedia.org/show_bug.cgi?id=68891 ? [19:26:54] :o [19:26:59] * legoktm looks [19:27:12] i searched for ':visualed "23"' and it came up [19:27:31] but seems to be related to the release branches being hopelessly broken [19:27:58] well, lets see what's in the ED tarball. [19:28:17] jgonera: So, I'd suggest using something like window.requestAnimationFrame instead of a timeout there. [19:35:35] 3VisualEditor: MediaWiki 1.24wmf6 required when trying to install VisualEditor_REL1.23 - 10https://bugzilla.wikimedia.org/68891#c2 (10Kunal Mehta (Legoktm)) 5NEW>3UNCO I just downloaded the latest tarball from MatmaRex: ^ [19:41:46] https://bugzilla.wikimedia.org/show_bug.cgi?id=66812 apparently [19:58:37] 3VisualEditor: VE: Text flows outside dropdown menu buttons - 10https://bugzilla.wikimedia.org/69808 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Created attachment 16251 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16251&action=edit Text flowing outside dropdown menu See attachment. I thi... [19:59:35] 3VisualEditor: VE: Text flows outside dropdown menu buttons - 10https://bugzilla.wikimedia.org/69808 (10Dan Garry) s:5normal>3minor [20:03:32] Adityab, can you point to a specific part of code? [20:04:08] Adityab, you mean the debouncing that VE currently implements for the focus event? [20:04:44] jgonera: Yeah, the debouncing. That was my guess. Unfortunately I can't really debug having no access to an emulator/device right now [20:05:45] Adityab, I'll check if that changes anything, but the truth is that the bug I'm struggling with does not depend on programatically setting focus [20:06:03] the focus should be set by the user just tapping the contenteditable [20:06:19] but maybe the desktop code that tries to force focus in a timeout messes that up... [20:06:22] I'll check [20:06:43] ah, I see [20:11:21] There is a different bug where that is an issue though [20:11:33] Just a few general quirks I've noticed: 1. You can't set focus to anything within a timeout. So any code path that calls a timeout is 'tainted' 2. You can only set focus to something within the handlers of certain user events (touchstart, touchend, for example). [20:11:43] When you tap a focusablenode (like a reference), the keyboard is dismissed, but we want it to be there so you can press backspace to delete it [20:12:25] Adityab: Hah I was trying to work around #2 by faking events but I suppose I was still in timeout cod so maybe that's why I couldn't get it to work [20:12:35] (03PS1) 10Jforrester: Label 'insert' buttons with just "Insert" instead of varying by content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155350 [20:12:42] RoanKattouw: that's likely [20:13:28] RoanKattouw: ah, the keyboard is dismissed. and you want it there. I can't patch it due to lack of device, but I know what's going wrong there :P [20:13:37] I wrote a workaround for that, 1 sec [20:14:18] https://github.com/kogmbh/WebODF/pull/372 [20:14:21] oops, wrong link [20:18:36] (03PS1) 10Jforrester: Label 'insert' buttons with just "Insert" instead of varying by content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155352 [20:19:10] (03Abandoned) 10Jforrester: Shorten visualeditor-dialog-referencelist-insert-button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150018 (owner: 10Amire80) [20:19:32] (03Abandoned) 10Jforrester: Change 'Insert citation' button to 'Done' per design [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154871 (owner: 10Kaldari) [20:20:27] RoanKattouw: Ok, now I see what your problem is. [20:20:30] legoktm: VE REL1_23 and MW REL1_23 should work fine together, I think. [20:20:57] In WebODF, there are many different elements that you can click and edit. The only solution we found for that was to use an event trap [20:21:17] A sort of overlay that grabs events [20:21:42] So if you click on a reference, the event trap would retain focus like before, thus sustaining the keyboard [20:22:20] 3VisualEditor / 3MediaWiki integration: MediaWiki 1.24wmf6 required when trying to install VisualEditor_REL1.23 - 10https://bugzilla.wikimedia.org/68891#c3 (10James Forrester) 5UNCO>3RESO/WOR This sounds like the creation of the temporary tarball was very broken, but thanks to Kunal's work on ExtensionDi... [20:22:48] Not sure how much work that'd be for VE [20:33:53] 3VisualEditor: White pawn ♙ appears on Alt+Shift+F - 10https://bugzilla.wikimedia.org/69810 (10Eran Roz) 3NEW p:3Unprio s:3normal a:3None Alt+Shift+F is shortcut for search box (very useful to validate a name of article...) Pressing Alt+Shift+F when the cursor is in the begining of article or in the... [20:38:45] (03PS1) 10Catrope: Bring MWTransclusion example data out of the stone age [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155429 [20:40:27] (03CR) 10jenkins-bot: [V: 04-1] Bring MWTransclusion example data out of the stone age [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155429 (owner: 10Catrope) [20:41:41] Adityab: Thanks that link should help us [20:41:49] The event trap idea is neat, maybe we'll do that [20:55:02] (03PS2) 10Catrope: Bring MWTransclusion example data out of the stone age [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155429 [20:55:49] (03PS2) 10Catrope: Update VE core submodule to master (d515ce6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155175 (owner: 10Jforrester) [20:57:32] (03CR) 10Catrope: [C: 032] Label 'insert' buttons with just "Insert" instead of varying by content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155350 (owner: 10Jforrester) [20:59:11] (03Merged) 10jenkins-bot: Label 'insert' buttons with just "Insert" instead of varying by content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155350 (owner: 10Jforrester) [20:59:46] TrevorParscal: Could you review https://gerrit.wikimedia.org/r/#/c/155429/2 for me? [21:04:33] (03PS1) 10Cmcmahon: [BrowserTest] WIP: add News and Journal to Cite test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155434 [21:04:49] (03CR) 10Cmcmahon: [C: 04-2] "WIP" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155434 (owner: 10Cmcmahon) [21:06:46] (03CR) 10Trevor Parscal: [C: 032] Bring MWTransclusion example data out of the stone age [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155429 (owner: 10Catrope) [21:07:08] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (d515ce6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155175 (owner: 10Jforrester) [21:08:23] (03Merged) 10jenkins-bot: Bring MWTransclusion example data out of the stone age [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155429 (owner: 10Catrope) [21:08:38] (03Merged) 10jenkins-bot: Update VE core submodule to master (d515ce6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155175 (owner: 10Jforrester) [21:12:00] (03PS1) 10Catrope: Update VE core submodule to master (c6085d9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155440 [21:14:21] (03PS2) 10Catrope: Label 'insert' buttons with just "Insert" instead of varying by content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155352 (owner: 10Jforrester) [21:17:46] (03PS14) 10Trevor Parscal: Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [21:20:08] (03CR) 10Catrope: [C: 032] Label 'insert' buttons with just "Insert" instead of varying by content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155352 (owner: 10Jforrester) [21:24:06] (03PS3) 10Jforrester: Label 'insert' buttons with just "Insert" instead of varying by content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155352 [21:24:18] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (c6085d9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155440 (owner: 10Catrope) [21:24:47] (03CR) 10Catrope: [C: 032] Label 'insert' buttons with just "Insert" instead of varying by content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155352 (owner: 10Jforrester) [21:26:28] (03Merged) 10jenkins-bot: Update VE core submodule to master (c6085d9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155440 (owner: 10Catrope) [21:28:13] (03Merged) 10jenkins-bot: Label 'insert' buttons with just "Insert" instead of varying by content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155352 (owner: 10Jforrester) [21:30:09] 3VisualEditor / 3MediaWiki integration: VisualEditor: On a redirected page, VE URL retains original searched title instead of redirect title - 10https://bugzilla.wikimedia.org/67330#c7 (10Bartosz Dziewoński) 5ASSI>3RESO/WOR a:3Bartosz Dziewoński That change has been merged and this should therefore be... [21:39:06] 3VisualEditor: VE: Text flows outside dropdown menu buttons - 10https://bugzilla.wikimedia.org/69808#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 57366 *** [21:39:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Switch to source editor" text overlaps with selection indicator; should expand menu or wrap if needed - 10https://bugzilla.wikimedia.org/57366#c7 (10James Forrester) *** Bug 69808 has been marked as a duplicate of this bug. *** [21:39:22] 3MediaWiki / 3Page editing: More edit toolbar buttons - 10https://bugzilla.wikimedia.org/23058 (10Helder) [21:47:42] (03PS2) 10Cmcmahon: [BrowserTest] WIP: add News and Journal to Cite test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155434 [21:49:34] (03PS1) 10Jforrester: Re-label inserting mode of transclusion dialog from "New template" to "Add a template" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155448 (https://bugzilla.wikimedia.org/69692) [21:49:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: "New template" is a confusing window title - 10https://bugzilla.wikimedia.org/69692 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3trivia a:3James Forrester [21:50:08] 3VisualEditor / 3MediaWiki integration: VisualEditor: Suggest templates more proactively in the template adding dialog - 10https://bugzilla.wikimedia.org/69787#c1 (10James Forrester) 5NEW>3RESO/DUP I think this is bug 53590. *** This bug has been marked as a duplicate of bug 53590 *** [21:50:21] 3VisualEditor / 3Editing Tools: VisualEditor: Provide some kind of template suggestion in the transclusion editor - 10https://bugzilla.wikimedia.org/53590#c3 (10James Forrester) *** Bug 69787 has been marked as a duplicate of this bug. *** [21:57:22] (03CR) 10Catrope: [C: 032] ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 (owner: 10Divec) [21:57:50] 3VisualEditor: White pawn ♙ appears on Alt+Shift+F - 10https://bugzilla.wikimedia.org/69810#c1 (10Andre Klapper) With which browser(s) was this tested? [21:58:50] 3VisualEditor: White pawn ♙ appears on Alt+Shift+F - 10https://bugzilla.wikimedia.org/69810 (10Eran Roz) [21:59:39] (03Merged) 10jenkins-bot: ve.Filibuster: Scrupulous state logging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 (owner: 10Divec) [22:01:29] (03PS3) 10Cmcmahon: [BrowserTest] WIP: add News and Journal to Cite test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155434 [22:05:42] (03CR) 10Catrope: [C: 032] Look up callbacks by name at call time [oojs/core] - 10https://gerrit.wikimedia.org/r/155025 (owner: 10Divec) [22:06:22] (03CR) 10Catrope: [C: 032] Use empty object as fallback when comparing to null/undefined [oojs/core] - 10https://gerrit.wikimedia.org/r/155047 (owner: 10Esanders) [22:07:05] (03PS18) 10Catrope: [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal) [22:07:08] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal) [22:07:58] (03PS15) 10Catrope: Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [22:09:34] (03Merged) 10jenkins-bot: Look up callbacks by name at call time [oojs/core] - 10https://gerrit.wikimedia.org/r/155025 (owner: 10Divec) [22:10:08] (03Merged) 10jenkins-bot: Use empty object as fallback when comparing to null/undefined [oojs/core] - 10https://gerrit.wikimedia.org/r/155047 (owner: 10Esanders) [22:21:21] (03PS1) 10Jforrester: Tag v1.0.12 [oojs/core] - 10https://gerrit.wikimedia.org/r/155454 [22:21:28] RoanKattouw: ^^^ Please merge. [22:28:41] (03CR) 10Catrope: [C: 032] Tag v1.0.12 [oojs/core] - 10https://gerrit.wikimedia.org/r/155454 (owner: 10Jforrester) [22:31:09] (03PS1) 10Trevor Parscal: [BREAKING CHANGE] Set active and pressed on the buttoned element, not the button [oojs/ui] - 10https://gerrit.wikimedia.org/r/155456 [22:31:11] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Set active and pressed on the buttoned element, not the button [oojs/ui] - 10https://gerrit.wikimedia.org/r/155456 (owner: 10Trevor Parscal) [22:31:21] (03PS1) 10Trevor Parscal: Standardize less imports and image rule generation [oojs/ui] - 10https://gerrit.wikimedia.org/r/155457 [22:31:23] (03CR) 10jenkins-bot: [V: 04-1] Standardize less imports and image rule generation [oojs/ui] - 10https://gerrit.wikimedia.org/r/155457 (owner: 10Trevor Parscal) [22:33:11] (03Merged) 10jenkins-bot: Tag v1.0.12 [oojs/core] - 10https://gerrit.wikimedia.org/r/155454 (owner: 10Jforrester) [22:38:11] (03PS19) 10Trevor Parscal: [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 [22:38:13] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal) [22:38:35] TrevorParscal: https://gerrit.wikimedia.org/r/155459 [22:46:27] (03PS1) 10Jforrester: Re-sync bin/update-oojs.sh with equivalent script in MediaWiki core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155460 [22:47:34] TrevorParscal: ^^^ too please. [22:48:05] (03CR) 10Trevor Parscal: [C: 032] Re-sync bin/update-oojs.sh with equivalent script in MediaWiki core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155460 (owner: 10Jforrester) [22:48:17] (03CR) 10Catrope: [C: 04-1] Create a combo box widget (035 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [22:49:38] (03Merged) 10jenkins-bot: Re-sync bin/update-oojs.sh with equivalent script in MediaWiki core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155460 (owner: 10Jforrester) [22:55:53] 3VisualEditor: VisualEditor Mobile: [iOS] abandoning edit takes me to unscrollable page - 10https://bugzilla.wikimedia.org/69630#c3 (10Juliusz Gonera) a:3None This actually seems to be a VE/OOUI bug. The problem lies in WindowManager not cleaning up after itself. I thought it could be easily fixed by adding... [22:58:35] 3VisualEditor: VisualEditor Mobile: [iOS] abandoning edit takes me to unscrollable page - 10https://bugzilla.wikimedia.org/69630#c4 (10Roan Kattouw) (In reply to Juliusz Gonera from comment #3) > I thought it could be easily fixed by adding this.inspectors.clearWindows() I haven't reported this in Bugzilla yet... [23:04:21] (03PS16) 10Trevor Parscal: Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [23:04:36] 3VisualEditor / 3ContentEditable: VisualEditor: Copying from Microsoft Word adds XML cruft like "gte mso" (mso = Microsoft Outlook) - 10https://bugzilla.wikimedia.org/69513 (10WhatamIdoing) [23:09:39] 3VisualEditor / 3ContentEditable: VisualEditor: Copying from Microsoft Word adds XML cruft like "gte mso" (mso = Microsoft Outlook) - 10https://bugzilla.wikimedia.org/69513 (10WhatamIdoing) [23:09:39] 3VisualEditor / 3ContentEditable: VisualEditor: Pasting lists from Microsoft Word (MS Office) injects hidden HTML cruft like - - 10https://bugzilla.wikimedia.org/69821 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Look at https://fr.wikipedia.org/w/index.php?curid=126510... [23:09:39] 3VisualEditor / 3ContentEditable: VisualEditor: Pasting lists from Microsoft Word (MS Office) injects hidden HTML cruft like - - 10https://bugzilla.wikimedia.org/69821 (10WhatamIdoing) [23:10:24] (03PS2) 10Trevor Parscal: [BREAKING CHANGE] Set active and pressed on the buttoned element, not the button [oojs/ui] - 10https://gerrit.wikimedia.org/r/155456 [23:10:26] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Set active and pressed on the buttoned element, not the button [oojs/ui] - 10https://gerrit.wikimedia.org/r/155456 (owner: 10Trevor Parscal) [23:10:31] (03PS2) 10Trevor Parscal: Standardize less imports and image rule generation [oojs/ui] - 10https://gerrit.wikimedia.org/r/155457 [23:10:33] (03CR) 10jenkins-bot: [V: 04-1] Standardize less imports and image rule generation [oojs/ui] - 10https://gerrit.wikimedia.org/r/155457 (owner: 10Trevor Parscal) [23:15:53] 3VisualEditor: VisualEditor: Make interlanguage links visible (e.g., so that you can avoid typing on the same line) - 10https://bugzilla.wikimedia.org/69822 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Intention: Add some text to the end of a page. Steps to reproduce: 1. Open a page that hap... [23:21:19] (03PS1) 10Catrope: Don't blank .static in ve.dm.Document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155464 [23:22:20] (03CR) 10Catrope: [C: 032] Re-label inserting mode of transclusion dialog from "New template" to "Add a template" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155448 (https://bugzilla.wikimedia.org/69692) (owner: 10Jforrester) [23:23:50] (03CR) 10jenkins-bot: [V: 04-1] Re-label inserting mode of transclusion dialog from "New template" to "Add a template" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155448 (https://bugzilla.wikimedia.org/69692) (owner: 10Jforrester) [23:28:14] (03PS20) 10Catrope: [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal) [23:29:43] (03CR) 10Catrope: [C: 04-1] "Vertical scroll bars are now visible in every dialog" [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal) [23:30:05] (03PS3) 10Catrope: [BREAKING CHANGE] Set active and pressed on the buttoned element, not the button [oojs/ui] - 10https://gerrit.wikimedia.org/r/155456 (owner: 10Trevor Parscal) [23:30:07] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Set active and pressed on the buttoned element, not the button [oojs/ui] - 10https://gerrit.wikimedia.org/r/155456 (owner: 10Trevor Parscal) [23:31:23] (03PS4) 10Catrope: [BREAKING CHANGE] Set active and pressed on the buttoned element, not the button [oojs/ui] - 10https://gerrit.wikimedia.org/r/155456 (owner: 10Trevor Parscal) [23:31:30] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Set active and pressed on the buttoned element, not the button [oojs/ui] - 10https://gerrit.wikimedia.org/r/155456 (owner: 10Trevor Parscal) [23:31:34] (03PS3) 10Catrope: Standardize less imports and image rule generation [oojs/ui] - 10https://gerrit.wikimedia.org/r/155457 (owner: 10Trevor Parscal) [23:44:55] (03CR) 10Catrope: [C: 04-1] Standardize less imports and image rule generation (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/155457 (owner: 10Trevor Parscal) [23:50:33] (03PS21) 10Trevor Parscal: [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761