[00:01:20] (03CR) 10Jforrester: [C: 032] Don't blank .static in ve.dm.Document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155464 (owner: 10Catrope) [00:07:10] (03PS2) 10Jforrester: Don't blank .static in ve.dm.Document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155464 (owner: 10Catrope) [00:07:19] (03CR) 10Jforrester: [C: 032] Don't blank .static in ve.dm.Document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155464 (owner: 10Catrope) [00:08:51] (03Merged) 10jenkins-bot: Don't blank .static in ve.dm.Document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155464 (owner: 10Catrope) [00:13:31] (03CR) 10Catrope: [C: 032] Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [00:14:06] (03Merged) 10jenkins-bot: Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [00:14:53] 3OOjs UI: OOjs UI: Create a "ComboBox" (write-in-able drop-down) widget - 10https://bugzilla.wikimedia.org/61573 (10James Forrester) 5PATC>3RESO/FIX [00:17:03] (03PS1) 10Jforrester: Update OOjs to v1.0.12 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155476 [00:18:09] (03CR) 10Catrope: [C: 032] Update OOjs to v1.0.12 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155476 (owner: 10Jforrester) [00:19:35] (03Merged) 10jenkins-bot: Update OOjs to v1.0.12 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155476 (owner: 10Jforrester) [00:20:13] (03CR) 10Catrope: [C: 04-1] Refactoring ImageModel constructor (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149191 (owner: 10Mooeypoo) [00:21:11] (03PS1) 10Jforrester: Update oojs to v1.0.12 [oojs/ui] - 10https://gerrit.wikimedia.org/r/155477 [00:21:42] (03CR) 10Catrope: [C: 032] Update oojs to v1.0.12 [oojs/ui] - 10https://gerrit.wikimedia.org/r/155477 (owner: 10Jforrester) [00:22:17] (03Merged) 10jenkins-bot: Update oojs to v1.0.12 [oojs/ui] - 10https://gerrit.wikimedia.org/r/155477 (owner: 10Jforrester) [00:23:41] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (944c47c5fe) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155478 [00:24:33] (03PS5) 10Jforrester: [BREAKING CHANGE] Set active and pressed on the buttoned element, not the button [oojs/ui] - 10https://gerrit.wikimedia.org/r/155456 (owner: 10Trevor Parscal) [00:24:50] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (944c47c5fe) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155478 (owner: 10Jforrester) [00:25:24] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal) [00:26:47] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal) [00:26:48] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Set active and pressed on the buttoned element, not the button [oojs/ui] - 10https://gerrit.wikimedia.org/r/155456 (owner: 10Trevor Parscal) [00:27:01] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (944c47c5fe) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155478 (owner: 10Jforrester) [00:32:33] (03PS1) 10Jforrester: Update VE core submodule to master (59a25cb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155480 [00:32:43] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (59a25cb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155480 (owner: 10Jforrester) [00:34:09] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (59a25cb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155480 (owner: 10Jforrester) [00:35:17] (03PS2) 10Jforrester: Update VE core submodule to master (59a25cb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155480 [00:36:56] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (59a25cb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155480 (owner: 10Jforrester) [00:42:56] (03PS3) 10Jforrester: Update VE core submodule to master (59a25cb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155480 [00:43:25] (03PS6) 10Catrope: Update OOjs UI to v0.1.0-pre (466a8762ac) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150050 (owner: 10Trevor Parscal) [00:45:01] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (59a25cb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155480 (owner: 10Jforrester) [00:45:17] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (466a8762ac) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150050 (owner: 10Trevor Parscal) [00:46:42] (03Merged) 10jenkins-bot: Update VE core submodule to master (59a25cb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155480 (owner: 10Jforrester) [00:46:54] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (466a8762ac) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150050 (owner: 10Trevor Parscal) [00:53:19] (03CR) 10Catrope: [C: 04-1] Rename "reference list" to "references list" internally (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155091 (https://bugzilla.wikimedia.org/49923) (owner: 10Jforrester) [00:55:14] (03PS5) 10Jforrester: Update VE core submodule to master (c4ce5ee) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150051 (owner: 10Trevor Parscal) [00:59:20] (03CR) 10Jforrester: [C: 032] Followup b141a7d2: make inspectors not close immediately in IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155182 (owner: 10Catrope) [00:59:44] (03CR) 10Jforrester: [C: 04-1] "Per TODOs in commit message." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [01:01:29] (03Merged) 10jenkins-bot: Followup b141a7d2: make inspectors not close immediately in IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155182 (owner: 10Catrope) [01:13:20] (03PS10) 10Jforrester: Refactoring ImageModel constructor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149191 (owner: 10Mooeypoo) [01:13:24] (03CR) 10Jforrester: Refactoring ImageModel constructor (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149191 (owner: 10Mooeypoo) [01:16:21] (03PS1) 10Jforrester: Correct MWImage* resource regex to find literal .s rather than characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155484 [01:16:33] (03PS2) 10Catrope: Rename "reference list" to "references list" internally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155091 (https://bugzilla.wikimedia.org/49923) (owner: 10Jforrester) [01:16:38] (03CR) 10jenkins-bot: [V: 04-1] Rename "reference list" to "references list" internally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155091 (https://bugzilla.wikimedia.org/49923) (owner: 10Jforrester) [01:24:38] (03PS3) 10Catrope: Rename "reference list" to "references list" internally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155091 (https://bugzilla.wikimedia.org/49923) (owner: 10Jforrester) [01:25:54] (03CR) 10jenkins-bot: [V: 04-1] Rename "reference list" to "references list" internally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155091 (https://bugzilla.wikimedia.org/49923) (owner: 10Jforrester) [01:27:02] (03PS4) 10Catrope: Rename "reference list" to "references list" internally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155091 (https://bugzilla.wikimedia.org/49923) (owner: 10Jforrester) [01:28:57] (03CR) 10Catrope: [C: 032] Rename "reference list" to "references list" internally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155091 (https://bugzilla.wikimedia.org/49923) (owner: 10Jforrester) [01:30:37] (03Merged) 10jenkins-bot: Rename "reference list" to "references list" internally [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155091 (https://bugzilla.wikimedia.org/49923) (owner: 10Jforrester) [01:35:36] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (c4ce5ee) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150051 (owner: 10Trevor Parscal) [01:35:40] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (c4ce5ee) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150051 (owner: 10Trevor Parscal) [01:41:32] (03PS1) 10Jforrester: build: Switch from grunt-recess to grunt-contrib-less [oojs/ui] - 10https://gerrit.wikimedia.org/r/155486 [01:45:03] (03PS6) 10Catrope: Update VE core submodule to master (c4ce5ee) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150051 (owner: 10Trevor Parscal) [01:45:15] James_F, ah, thanks for the fix! [01:45:26] mooeypoo: Happy to help. :-) [01:46:00] and.. wow.. I can't believe about that regex. You know, it's a remnant from the past. I wonder how we didn't get any images fatally explode before... ouch [01:46:10] Yeah exactly [01:46:16] I'm guessing / is an unpopular character in image names [01:46:26] We did have a problem with ? before [01:46:47] remember? I thought it was an unknown character, but it was a literal ?... but I think that was in a different segment of the code. In the API search, I believe. [01:46:56] (03CR) 10Catrope: [C: 032] build: Switch from grunt-recess to grunt-contrib-less [oojs/ui] - 10https://gerrit.wikimedia.org/r/155486 (owner: 10Jforrester) [01:47:12] Oh yeah we did have that before but I think that's because Parsoid was escaping it as %3F [01:47:38] (03Merged) 10jenkins-bot: build: Switch from grunt-recess to grunt-contrib-less [oojs/ui] - 10https://gerrit.wikimedia.org/r/155486 (owner: 10Jforrester) [01:50:18] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (c4ce5ee) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150051 (owner: 10Trevor Parscal) [01:51:58] (03Merged) 10jenkins-bot: Update VE core submodule to master (c4ce5ee) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150051 (owner: 10Trevor Parscal) [01:52:24] (03PS2) 10Catrope: Re-label inserting mode of transclusion dialog from "New template" to "Add a template" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155448 (https://bugzilla.wikimedia.org/69692) (owner: 10Jforrester) [01:53:07] (03CR) 10Catrope: [C: 032] Refactoring ImageModel constructor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149191 (owner: 10Mooeypoo) [01:54:33] It might have been. But I've been copying that regex code as if there's no s/tomorrow// [01:54:38] (03CR) 10Catrope: [C: 032] Only build reference search index when it's been changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151234 (https://bugzilla.wikimedia.org/68890) (owner: 10Alex Monk) [01:54:48] (03Merged) 10jenkins-bot: Refactoring ImageModel constructor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149191 (owner: 10Mooeypoo) [01:56:04] (03CR) 10Catrope: [C: 032] Queue up annotation changes to make operations safer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152776 (https://bugzilla.wikimedia.org/68892) (owner: 10Esanders) [01:56:07] (03Merged) 10jenkins-bot: Only build reference search index when it's been changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/151234 (https://bugzilla.wikimedia.org/68890) (owner: 10Alex Monk) [01:58:20] (03Merged) 10jenkins-bot: Queue up annotation changes to make operations safer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152776 (https://bugzilla.wikimedia.org/68892) (owner: 10Esanders) [02:04:15] (03CR) 10Jforrester: [C: 04-1] "This would be a lot simpler if s are ImageNodes and
s are FigureNodes — as then
s are FigcaptionNodes not ImageCa" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154439 (owner: 10Esanders) [02:05:40] (03CR) 10Jforrester: [C: 032] "'Cos Roan said so…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155448 (https://bugzilla.wikimedia.org/69692) (owner: 10Jforrester) [02:06:07] 3VisualEditor / 3Data Model: VisualEditor: Incorrectly displaying nested references - 10https://bugzilla.wikimedia.org/50749#c3 (10ssastry) 5REOP>3RESO/FIX Filed a bug against Parsoid: see bug 69827 [02:06:19] (03CR) 10Catrope: [C: 032] Correct MWImage* resource regex to find literal .s rather than characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155484 (owner: 10Jforrester) [02:07:22] (03Merged) 10jenkins-bot: Re-label inserting mode of transclusion dialog from "New template" to "Add a template" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155448 (https://bugzilla.wikimedia.org/69692) (owner: 10Jforrester) [02:07:31] (03CR) 10Jforrester: [C: 04-1] "Product issues as discussed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153737 (https://bugzilla.wikimedia.org/69451) (owner: 10Catrope) [02:07:51] (03Merged) 10jenkins-bot: Correct MWImage* resource regex to find literal .s rather than characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155484 (owner: 10Jforrester) [02:10:43] (03CR) 10Jforrester: [C: 04-1] "Needs rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) (owner: 10Mooeypoo) [02:11:53] 3VisualEditor / 3Data Model: VisualEditor: Make transaction processing exception-safe - 10https://bugzilla.wikimedia.org/68892#c3 (10James Forrester) 5PATC>3ASSI Operations are now queued but exceptions aren't caught yet. [02:11:54] 3VisualEditor / 3Technical Debt: VisualEditor: Rename internal use of "Reference list" to "References list" - 10https://bugzilla.wikimedia.org/49923 (10James Forrester) 5PATC>3RESO/FIX [02:11:54] 3VisualEditor / 3Data Model: VisualEditor: Make transaction processing exception-safe - 10https://bugzilla.wikimedia.org/68892 (10James Forrester) [02:12:05] 3VisualEditor / 3MediaWiki integration: VisualEditor: "New template" is a confusing window title - 10https://bugzilla.wikimedia.org/69692 (10James Forrester) 5PATC>3RESO/FIX [02:12:20] 3VisualEditor / 3Editing Tools: VisualEditor: MWReferenceSearchWidget should only build the index if there isn't one or if it was built against a different version of the internal list - 10https://bugzilla.wikimedia.org/68890 (10James Forrester) 5PATC>3RESO/FIX [02:12:35] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any edit in mobile VE for Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66756 (10James Forrester) [02:12:43] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf16]Opening link inspector/comment box in an empty line, opens them at the end of the previous line - 10https://bugzilla.wikimedia.org/69122 (10James Forrester) [02:12:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000 (10James Forrester) [02:12:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: After saving a page reference list gets missing (unless it is refreshed again) and the page gets categorized as "Pages with missing reference list" - 10https://bugzilla.wikimedia.org/68182 (10James Forrester) [02:12:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Clicking in the document where an inspector was opened doesn't close the inspector - 10https://bugzilla.wikimedia.org/68679 (10James Forrester) [02:12:45] 3VisualEditor / 3Editing Tools: VisualEditor: Triggering context on link after defocus throws "TypeError: Cannot read property 'isCollapsed' of null" - 10https://bugzilla.wikimedia.org/68915 (10James Forrester) [02:12:50] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on Return while cursor is at the end of a text , deletes that text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66758 (10James Forrester) [02:12:55] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - 10https://bugzilla.wikimedia.org/66604 (10James Forrester) [02:12:55] 3VisualEditor / 3Editing Tools: VisualEditor: Support "substituting" templates in transclusion dialog - 10https://bugzilla.wikimedia.org/49904 (10James Forrester) [02:12:55] 3VisualEditor / 3Editing Tools: VisualEditor:Link Inspector icon is not appearing, when language is selected, in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68810 (10James Forrester) [02:13:35] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10James Forrester) [02:13:50] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf12] The highlight for centered images is taking 100% width - 10https://bugzilla.wikimedia.org/67507 (10James Forrester) [02:13:51] 3VisualEditor / 3ContentEditable: VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - 10https://bugzilla.wikimedia.org/50036 (10James Forrester) [02:14:13] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10James Forrester) [02:14:13] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping at the end of each link, does copy-paste of preceding link text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66755 (10James Forrester) [02:14:13] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697 (10James Forrester) [02:14:14] 3VisualEditor / 3ContentEditable: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - 10https://bugzilla.wikimedia.org/69474 (10James Forrester) [02:14:15] 3VisualEditor / 3Editing Tools: VisualEditor: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - 10https://bugzilla.wikimedia.org/68590 (10James Forrester) [02:14:16] 3VisualEditor / 3Editing Tools: VisualEditor: Template dialog search widget wrongly uses suffix ellipsis until input is refocused - 10https://bugzilla.wikimedia.org/67385 (10James Forrester) [02:14:20] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195 (10James Forrester) [02:14:25] 3VisualEditor / 3Editing Tools: VisualEditor: Inspectors and context menu should close when blurring the document and/or when opening the save dialog - 10https://bugzilla.wikimedia.org/51439 (10James Forrester) [02:14:25] 3VisualEditor / 3Data Model: VisualEditor: tags appear when editing on the Hebrew Wiki - 10https://bugzilla.wikimedia.org/66210 (10James Forrester) [02:14:25] 3VisualEditor / 3Editing Tools: VisualEditor: Append references list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906 (10James Forrester) [02:14:38] 3VisualEditor / 3Editing Tools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - 10https://bugzilla.wikimedia.org/68537 (10James Forrester) [02:14:38] 3VisualEditor / 3Editing Tools: VisualEditor: Deleting the parameter of any template or the template itself, scrolls the focus up to the top of the transclusion dialog - 10https://bugzilla.wikimedia.org/62420 (10James Forrester) [02:14:39] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Switch to source editor" text overlaps with selection indicator; should expand menu or wrap if needed - 10https://bugzilla.wikimedia.org/57366 (10James Forrester) [02:14:50] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf16] Cannot scroll up/down a page in mobile when the keyboard is open and cursor active on CE - 10https://bugzilla.wikimedia.org/68828 (10James Forrester) [02:15:29] 3VisualEditor / 3Data Model: VisualEditor: Investigate parsing/rendering/behavior of "{{MW 1.23}}" on mediawiki.org [mini-tracking] - 10https://bugzilla.wikimedia.org/68297 (10James Forrester) [02:15:29] 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580 (10James Forrester) [02:15:29] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843 (10James Forrester) [02:15:29] 3VisualEditor / 3MediaWiki integration: VisualEditor: Keyboard shortcut dialog style differs between standalone and MW, ugly line wraps in MW - 10https://bugzilla.wikimedia.org/69643 (10James Forrester) [02:15:30] 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - 10https://bugzilla.wikimedia.org/67262 (10James Forrester) [02:15:31] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10James Forrester) [02:15:39] 3VisualEditor / 3Mobile: VisualEditor Mobile: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110 (10James Forrester) [02:15:39] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438 (10James Forrester) [02:15:39] 3VisualEditor / 3ContentEditable: VisualEditor: Copying text sometimes makes the page jump/scroll in Firefox - 10https://bugzilla.wikimedia.org/55433 (10James Forrester) [02:24:05] 3MediaWiki extensions / 3WikiEditor: [Regression] ext.wikiEditor.toolbar.hideSig.js stopped working - 10https://bugzilla.wikimedia.org/40972#c2 (10George Orwell III) Two months already and still not "fixed"? Look, all we need to do is add... 'filters': [ 'body.ns-talk' ], ... to the 'signature' bu... [02:55:21] 3MediaWiki extensions / 3WikiEditor: Load toolbar on element ready instead of content ready - 10https://bugzilla.wikimedia.org/45144#c3 (10Isarra) Does this use the same code as the core toolbar now? [04:11:06] 3MediaWiki extensions / 3WikiEditor: [Regression] ext.wikiEditor.toolbar.hideSig.js stopped working - 10https://bugzilla.wikimedia.org/40972#c3 (10This, that and the other (TTO)) As I tried to explain to you at the other bug, your approach just introduces new problems: 1. It is inflexible and cannot be confi... [05:31:51] 3MediaWiki extensions / 3WikiEditor: [Regression] ext.wikiEditor.toolbar.hideSig.js stopped working - 10https://bugzilla.wikimedia.org/40972#c4 (10George Orwell III) Yes I fully understand all that. Yet we're months past the 1st report and you have usurped and/or blocked several pseudo-related buzillas in th... [09:03:06] 3MediaWiki extensions / 3WikiEditor: [Regression] ext.wikiEditor.toolbar.hideSig.js stopped working - 10https://bugzilla.wikimedia.org/40972#c5 (10This, that and the other (TTO)) (In reply to George Orwell III from comment #4) > making any attempt to resolve this by any other means than yours > impossible to... [09:30:35] 3VisualEditor: VisualEditor: Cutting text undoes previous typing - 10https://bugzilla.wikimedia.org/57217#c1 (10Mc128k) I have a similar issue that makes Safari reopen a closed tab, same with cmd-x. It doesn't happen immediately and in all cases though. [10:16:26] 3VisualEditor: VisualEditor: REL1_23 branch not compatible with MediaWiki 1.23 - 10https://bugzilla.wikimedia.org/66519#c6 (10Tony Mach) I have a similar (same?) problem: VisualEditor does not load when clicking on the "edit" tab. This is the setup I use: - Windows 7 - XAMPP win32-1.8.3-4-VC11 - MediaWiki (t... [10:23:05] 3VisualEditor: VisualEditor: REL1_23 branch not compatible with MediaWiki 1.23 - 10https://bugzilla.wikimedia.org/66519#c7 (10Tony Mach) Oh, one more thing I just found, when I manually do the GET /mediawiki/load.php?debug=false&lang=en&modules=ext.visualEditor.base%2Ccore%2Cmediawiki%2CviewPageTarget%7Cext.vi... [10:29:51] 3VisualEditor: VisualEditor: REL1_23 branch not compatible with MediaWiki 1.23 - 10https://bugzilla.wikimedia.org/66519#c8 (10Tony Mach) D:\xampp\apps\mediawiki\htdocs\extensions\VisualEditor/lib/ve/ is missing on my system!!! There is only jquery.uls ... Where do I get the ve lib? Why don't I have the ve lib? [11:29:50] 3VisualEditor: VisualEditor: REL1_23 branch not compatible with MediaWiki 1.23 - 10https://bugzilla.wikimedia.org/66519#c9 (10Andre Klapper) Please explain how you installed VE and its dependencies and which exact guide you followed; might be better to ask/discuss on IRC in #mediawiki-visualeditor or https://w... [11:49:56] 3VisualEditor: VisualEditor: REL1_23 branch not compatible with MediaWiki 1.23 - 10https://bugzilla.wikimedia.org/66519#c10 (10Tony Mach) Ok, VisualEditor is now running on my system! And I found the problem: If you download the VisualEditor via the web-interface at http://git.wikimedia.org/branches/mediawik... [12:20:50] 3VisualEditor / 3MediaWiki integration: VisualEditor: Support editing of sections inside a page - 10https://bugzilla.wikimedia.org/48429#c56 (10Amir E. Aharoni) (In reply to Tim Starling from comment #49) > > * Editing by section blocks users from editing other areas at the same time > > that the notice flaw... [13:35:00] (03PS1) 10Esanders: New ve.*.ImageNode classes in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155538 [13:36:05] (03CR) 10jenkins-bot: [V: 04-1] New ve.*.ImageNode classes in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155538 (owner: 10Esanders) [13:42:23] (03PS1) 10Esanders: Define kbd font-family explicity in case environment overrides [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155539 (https://bugzilla.wikimedia.org/69643) [13:48:20] 3VisualEditor / 3Editing Tools: VisualEditor: Too much tabbing in the Template dialog - 10https://bugzilla.wikimedia.org/69512#c1 (10Derk-Jan Hartman) Also shift tab behaves differently (this is due to presence of icon only in focus state. WAI-ARIA has some further thoughts on how bot build fields like this... [14:35:20] (03PS1) 10Esanders: Update oo#compare usages [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155545 [14:48:16] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153934 (https://bugzilla.wikimedia.org/49904) (owner: 10Alex Monk) [15:37:39] (03CR) 10Esanders: "TODOs are non-blocking tech debt items." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [15:45:05] (03CR) 10Jforrester: ""* Fix or kill animations as this breaks them" is not a technical debt issue, it's a regression in user experience." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [15:47:27] (03CR) 10Jforrester: [C: 032] Define kbd font-family explicity in case environment overrides [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155539 (https://bugzilla.wikimedia.org/69643) (owner: 10Esanders) [15:49:01] (03Merged) 10jenkins-bot: Define kbd font-family explicity in case environment overrides [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155539 (https://bugzilla.wikimedia.org/69643) (owner: 10Esanders) [15:55:26] 3VisualEditor: VisualEditor: REL1_23 branch not compatible with MediaWiki 1.23 - 10https://bugzilla.wikimedia.org/66519#c11 (10James Forrester) (In reply to Tony Mach from comment #10) > Ok, VisualEditor is now running on my system! > > And I found the problem: > > If you download the VisualEditor via the we... [15:56:53] edsanders: Thoughts on calling things Image* and Figure* rather than InlineImage* and BlockImage* in VE-core? [15:58:05] 3VisualEditor / 3MediaWiki integration: VisualEditor: Keyboard shortcut dialog style differs between standalone and MW, ugly line wraps in MW - 10https://bugzilla.wikimedia.org/69643 (10James Forrester) 5PATC>3RESO/FIX [16:04:55] James_F: apropos of https://bugzilla.wikimedia.org/show_bug.cgi?id=66519 on a few occasions I have wailed about the lack of standard error reporting in mediawiki. We're working on so many other whole-system things, I'd like to see that become a project also. [16:05:37] chrismcmahon: That's specifically a ResourceLoader issue, FWIW. There /is/ a standard error reporting system in MediaWiki, it's just that RL doesn't use it. [16:07:18] James_F: well, yeah... error reporting remains a hodgepodge in different areas [16:07:36] 3VisualEditor / 3Data Model: VisualEditor: Cutting text undoes previous typing - 10https://bugzilla.wikimedia.org/57217#c2 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major (In reply to Mc128k from comment #1) > I have a similar issue that makes Safari reopen a closed tab, same wit... [16:07:40] * James_F nods. [16:27:08] 3VisualEditor / 3Editing Tools: beta labs: Cite dropdown elements do not bring up inspector - 10https://bugzilla.wikimedia.org/69856 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None On any page in beta labs e.g. http://en.wikipedia.beta.wmflabs.org/wiki/Cite_VisualEditor_Test?veaction=edit click C... [16:30:28] Corruption alert: visualeditor-needcheck on mediawikiwiki: https://www.mediawiki.org/?diff=1114221 [16:30:29] Corruption alert: visualeditor-needcheck on mediawikiwiki: https://www.mediawiki.org/?diff=1114225 [16:30:29] Corruption alert: visualeditor-needcheck on mediawikiwiki: https://www.mediawiki.org/?diff=1114226 [16:30:35] 3VisualEditor / 3Editing Tools: beta labs: Cite, Insert, format dropdown elements do not bring up inspector - 10https://bugzilla.wikimedia.org/69856#c1 (10Chris McMahon) Also true of Insert, etc, anything with a selection list [16:31:53] 3VisualEditor / 3MediaWiki integration: VisualEditor shows double page title after edit when 'edittop' gaget (or similar) is enabled - 10https://bugzilla.wikimedia.org/69857 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Created attachment 16257 --> https://bugzilla.wikimedia.org/attachmen... [16:36:39] (03PS1) 10Bartosz Dziewoński: mw.ViewPageTarget: Be more careful when updating page title [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155577 (https://bugzilla.wikimedia.org/69857) [16:37:07] 3VisualEditor / 3MediaWiki integration: VisualEditor shows double page title after edit when 'edittop' gaget (or similar) is enabled - 10https://bugzilla.wikimedia.org/69857 (10Bartosz Dziewoński) p:5Unprio>3Normal s:5normal>3trivia a:3Bartosz Dziewoński [16:45:06] 3VisualEditor / 3Data Model: VisualEditor: Cutting text undoes previous typing - 10https://bugzilla.wikimedia.org/57217#c3 (10WhatamIdoing) Whether it's impossible or not, it happens every time I use Command-X in Safari after closing a tab. It only happens if "Undo closed tab" is listed in Safari's Edit me... [16:45:52] 3VisualEditor: VisualEditor: Command-x (cut) triggers browser's Undo (Command-z) in Safari - 10https://bugzilla.wikimedia.org/58724 (10WhatamIdoing) [16:45:52] 3VisualEditor / 3Data Model: VisualEditor: Cutting text undoes previous typing - 10https://bugzilla.wikimedia.org/57217 (10WhatamIdoing) [16:48:47] James_F: I reported this and then realized it is release day. do you want to make it a blocker? https://bugzilla.wikimedia.org/show_bug.cgi?id=69856 [16:54:11] chrismcmahon: Yeah, will work out what's broken and fix. [16:56:57] James_F: cool. I was all "test maintenance, test maintenance, phooey" and then I realized it was a real bug. :-) [16:57:07] * James_F grins. [16:57:39] hey James_F, isn't https://bugzilla.wikimedia.org/show_bug.cgi?id=67709 a dupe of https://bugzilla.wikimedia.org/show_bug.cgi?id=49357 ? [16:57:41] chrismcmahon: Roan's looking now; probably us screwing something up in one of our breaking changes to OOUI last night. Oh well! [16:57:46] James_F: it was marked as such and then unmarked [16:58:29] MatmaRex: Don't ask me. I'm just a simple coder. ;-) [16:58:42] MatmaRex: (Yeah, I think so, but I don't really care one way or the other.) [16:58:49] you filed one of them, so i asked you :) [16:58:57] alright. so let's dupe them again [16:59:05] MatmaRex: Arguably 49357 is about it getting bigger long-term, but 67709 is about making it a specific size. [16:59:12] MatmaRex: So 49357 is the tracker? [16:59:16] hmm [16:59:23] okay, that makes sense too [17:00:57] James_F, maybe [17:09:54] 3VisualEditor: Help:Installing Japanese character sets with span tags appeared mysteriously in a reference - 10https://bugzilla.wikimedia.org/69861 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None This mess: [[Help:Installing Japanese character sets| Well, yes [17:39:01] But arrays aren't objects [17:39:19] Also, really what it is is {0:undefined, 1:undefined, length:2} vs {length:0} then isn't it? [17:39:28] (Although I guess length isn't an enumerable property) [17:40:30] divec: Is there any particular reason you made validateMethod a static method? [17:40:36] I think I may want to make it private [17:47:52] hey guys [17:48:18] Is editing-team@wikimedia.org the right email list for VE? [17:49:06] James_F: ^ [17:49:26] kaity: It's the right list for Editing Team, yes. [17:49:58] (03PS1) 10Catrope: Make OO.EventEmitter.static.validateMethod private [oojs/core] - 10https://gerrit.wikimedia.org/r/155589 [17:50:03] James_F: ok cool. I keep forgetting to use the new name :) [17:50:09] * James_F grins. [17:53:22] hey. does anyone remember bug with TemplateDialog, that info icon and delete icon didn't appear after focusing particular field textarea? [18:01:18] InezK: No? [18:04:01] James_F, I don't think Figure vs Image accurately describes their features [18:04:22] I can see how a figure may have a caption, but 'image' doesn't suggest it's not block or captioned [18:04:26] edsanders: Complain to WHATWG? [18:04:39] you could use 'figure' and 'inlineImage', but that feels messy [18:04:45] Native HTML doesn't have block images. [18:04:57] You have to modify them to make them into block elements. [18:05:09] VisualEditor-core is a (mostly) native HTML editor. [18:05:11] Yes/ [18:05:13] ? [18:05:26] it is, but we abstract away from HTML to document components [18:06:03] we shouldn't constrain ourselves to HTML's shortcomings [18:06:45] Eh. [18:06:56] This would force MW's view of images on other platforms, though. [18:07:07] (Or the integrations would have to over-ride core nodes.) [18:07:13] Which seems sub-optimal. [18:09:31] What do you think? [18:10:21] What do RoanKattouw and TrevorParscal think as well? [18:10:35] 3VisualEditor / 3Data Model: VisualEditor: Cutting text undoes previous typing - 10https://bugzilla.wikimedia.org/57217#c4 (10Mc128k) My computer is brand new, no custom shortcuts. Maybe VE is using a keyboard shortcut hack to make undo possible. [18:11:45] edsanders: They think that they're busy in a meeting. :-) [18:14:10] I'm off to the skip, back in 30 [18:19:23] 3VisualEditor / 3Editing Tools: regression: Save Page no longer brings up dialog with Review your changes - 10https://bugzilla.wikimedia.org/69864 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 16258 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16258&action=edit Save... [18:19:51] 3VisualEditor / 3Editing Tools: regression: Save Page no longer brings up dialog with Review your changes - 10https://bugzilla.wikimedia.org/69864 (10Chris McMahon) s:5normal>3major [18:20:01] James_F: another regression blocker: https://bugzilla.wikimedia.org/show_bug.cgi?id=69864 [18:22:08] 3VisualEditor / 3ContentEditable: Unclosed template adds nowiki on |, but not on the opening {{ - 10https://bugzilla.wikimedia.org/69865 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None https://fr.wikipedia.org/w/index.php?title=Eliaquim_Mangala&diff=106681571&oldid=106681205 One, can this be i... [18:24:38] 3VisualEditor / 3Editing Tools: Generate frequency metrics on incomplete template data - 10https://bugzilla.wikimedia.org/69866 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3enhanc a:3None would also be nice if the system were to gather (queryable) data for which templates have been seen (and with what freq... [18:25:27] 3VisualEditor / 3Editing Tools: regression: Save Page no longer completes save actions - 10https://bugzilla.wikimedia.org/69864 (10Chris McMahon) [18:35:57] Hey Krinkle. [18:39:10] (03PS2) 10Jforrester: [BREAKING CHANGE] Make OO.EventEmitter.static.validateMethod private [oojs/core] - 10https://gerrit.wikimedia.org/r/155589 (owner: 10Catrope) [18:39:36] (03CR) 10Jforrester: [C: 031] [BREAKING CHANGE] Make OO.EventEmitter.static.validateMethod private [oojs/core] - 10https://gerrit.wikimedia.org/r/155589 (owner: 10Catrope) [18:44:20] RoanKattouw: I added you to https://bugzilla.wikimedia.org/show_bug.cgi?id=69864 if that's OK [18:50:34] chrismcmahon: JS errors in the console? [18:50:42] I think this might be the same bug as the citation dialog being broken? [18:53:22] RoanKattouw: no, the Cite dialog is working, this is after creating the Cite [18:54:20] RoanKattouw: no JS errors in the console [18:54:20] 3VisualEditor / 3Editing Tools: regression: Save Page no longer completes save actions - 10https://bugzilla.wikimedia.org/69864#c1 (10Rummana Yasmeen) This happens while trying to save a page after adding anything in the page, not just citations.The error that appears in the console is: Uncaught TypeError: C... [18:54:47] Hi all [18:54:48] well, ryasmeen has an error... [18:55:09] Ouch [18:55:16] Does any edit to the text require registering/doing it through a 'transaction'? [18:55:23] * RoanKattouw justreproduced locally [18:55:29] ah, there it is TypeError: this.manager is null [18:55:37] Adityab_: Why are you asking that question? What are you trying to do? [18:55:40] Or is it fine to modify the text programmatically in other ways? [18:56:10] chrismcmahon: Oooooh I see someone's using the old style of opening a window for the save dialog [18:56:15] I'll go and fix that [18:56:27] Adityab_: By programmatically you mean reaching into the DOM and changing the text there? [18:56:29] RoanKattouw: I was having a look at the 'cut' handler. Which undoes the browser-assisted text removal and then does it through such a mechanism [18:56:33] RoanKattouw: yes [18:56:46] RoanKattouw: yeah, there are two mechanisms for that. Links uses it also. [18:57:50] 3VisualEditor / 3Editing Tools: Dropdown menu shows scrollbars - 10https://bugzilla.wikimedia.org/69707 (10Bartosz Dziewoński) [18:58:05] 3VisualEditor / 3Editing Tools: VisualEditor: Dropdown clipping is a bit too aggressive - 10https://bugzilla.wikimedia.org/54705 (10Bartosz Dziewoński) [18:58:20] 3VisualEditor / 3Editing Tools: VisualEditor: Dropdown menu shows scrollbars - 10https://bugzilla.wikimedia.org/69707 (10Bartosz Dziewoński) [18:58:48] James_F: hmm, wasn't https://bugzilla.wikimedia.org/show_bug.cgi?id=69707 supposed to be fixed? also, isn't id a dupe of something? [18:58:53] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf18] Save Page no longer completes save actions - 10https://bugzilla.wikimedia.org/69864 (10Rummana Yasmeen) a:3Roan Kattouw [18:58:53] 3MediaWiki / 3ResourceLoader: mw.loader.store should not occupy all of localStorage - 10https://bugzilla.wikimedia.org/64721#c6 (10Ryan Kaldari) Ori: Any thoughts on this? It's still a significant problem, especially for Firefox users. [18:58:59] Adityab_: Yeah so you should not be touching the DOM directly, you should go through the transaction system [18:59:25] Adityab_: What kind of feature are you working on if you don't mind me asking? [18:59:46] RoanKattouw: Ok [18:59:56] RoanKattouw: I'm trying to fix https://bugzilla.wikimedia.org/show_bug.cgi?id=57217 [19:01:13] (03PS1) 10Catrope: Followup 67f304a: use .openWindow(), not .open(), to open save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155600 [19:01:20] Adityab_: That one or https://bugzilla.wikimedia.org/show_bug.cgi?id=58724 ? [19:01:21] I'm not working on any feature, just getting acquainted with the editor as it looks interesting, technically speaking [19:01:22] Oh God that bug [19:01:45] (03CR) 10Jforrester: [C: 032] Followup 67f304a: use .openWindow(), not .open(), to open save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155600 (owner: 10Catrope) [19:01:52] James_F: They seem to be the same [19:01:54] (03PS1) 10Jforrester: Followup 67f304a: use .openWindow(), not .open(), to open save dialog [extensions/VisualEditor] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/155601 [19:02:05] I'm on linux + chromium, Ctrl + X undoes. [19:02:06] Yeah that seems to be because we're calling execCommand( 'undo' ) and Safari is broken [19:02:19] Oh right and Chrome has this bug too [19:02:23] yep [19:02:54] Why are we using execCommand? [19:06:17] (03Merged) 10jenkins-bot: Followup 67f304a: use .openWindow(), not .open(), to open save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155600 (owner: 10Catrope) [19:11:05] 3VisualEditor / 3Editing Tools: VisualEditor: Dropdown menu shows scrollbars - 10https://bugzilla.wikimedia.org/69707#c2 (10Ed Sanders) The clipping is correct, but we aren't repositioning for the edge of the screen, like we do with link inspectors (context popups). [19:14:37] RoanKattouw ryasmeen when this hits beta I want to make sure saving Links works, because that is also broken right now in the same way as saving a Citation [19:15:01] ? [19:15:09] The link inspector WFM [19:15:28] RoanKattouw: try hitting Save after adding a Link [19:16:09] WFM: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=7thfeb&diff=122583&oldid=79976 [19:16:42] RoanKattouw: OK good :-) [19:17:37] (03PS2) 10Jforrester: Followup 67f304a: use .openWindow(), not .open(), to open save dialog [extensions/VisualEditor] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/155601 (https://bugzilla.wikimedia.org/69864) [19:18:23] RoanKattouw: so it seems we have only a single style of opening a window for the save dialog now. good news! [19:19:05] Yeah we do [19:19:13] It was just using the wrong style until my patch :) [19:19:36] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf18] Save Page no longer completes save actions - 10https://bugzilla.wikimedia.org/69864 (10James Forrester) p:5Unprio>3Normal [19:21:05] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf18] Cite, Insert, format dropdown elements do not bring up dialog - 10https://bugzilla.wikimedia.org/69856 (10James Forrester) p:5Unprio>3Highes s:5normal>3critic [19:35:07] 3VisualEditor / 3Editing Tools: VisualEditor: Add support for editing templates' parameters as DOM elements, including supporting nested templates - 10https://bugzilla.wikimedia.org/50355#c2 (10James Forrester) 5RESO/DUP>3REOP p:5Unprio>3High s:5normal>3enhanc a:5Rob Moen>3None Re-wording; th... [19:35:10] James_F: moouipoo: TemplateData 'sets' is something Trevor and I devised and agreed to satisfy various different use cases for grouping and soft-dependency suggestions, but VisualEditor has yet to adopt it. [19:36:16] Krinkle: … yes, I know. [19:38:03] Krinkle: howdy! [19:38:37] 3VisualEditor / 3Editing Tools: VisualEditor: Add support for editing templates' parameters as DOM elements, including supporting nested templates - 10https://bugzilla.wikimedia.org/50355 (10James Forrester) [19:39:50] (03PS4) 10Jforrester: Standardize less imports and image rule generation [oojs/ui] - 10https://gerrit.wikimedia.org/r/155457 (owner: 10Trevor Parscal) [19:40:58] (03CR) 10jenkins-bot: [V: 04-1] Standardize less imports and image rule generation [oojs/ui] - 10https://gerrit.wikimedia.org/r/155457 (owner: 10Trevor Parscal) [19:41:59] Krinkle: BTW https://gerrit.wikimedia.org/r/#/c/155486/ may be of interest (I switched OOUI from grunt-recess to grunt-contrib-less which means we now support a modern version of LESS, for Trevor to do things using LESS 1.5.x features.). [19:42:18] James_F: btw, I'm re-reviewing the tempalte data refactor. [19:42:29] Krinkle: OK, awesome. [19:43:16] Krinkle: After that, it'd be great to hear how you're getting on with https://bugzilla.wikimedia.org/show_bug.cgi?id=57366 [19:44:20] 3VisualEditor / 3ContentEditable: VisualEditor: Create relocatable markers for complex shapes, e.g. block templates - 10https://bugzilla.wikimedia.org/62006#c6 (10James Forrester) 5ASSI>3RESO/FIX I'm declaring that it was. [19:45:05] 3VisualEditor / 3Editing Tools: VisualEditor: Add support for editing templates' parameters as DOM elements, including supporting nested templates - 10https://bugzilla.wikimedia.org/50355 (10James Forrester) 5REOP>3ASSI [19:50:13] (03CR) 10Krinkle: [C: 04-1] "Code looks good and various issues were addressed, though not all. I've repeated the ones not replied-to/addressed from patch set 19, and " (0312 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [19:50:22] bbiab [19:50:37] 3OOjs UI: OOjs UI: Auto-shortening of dialog titles when there's insufficient space isn't working - 10https://bugzilla.wikimedia.org/68571 (10James Forrester) a:5Trevor Parscal>3Bartosz Dziewoński [19:50:38] Cool. [19:50:50] 3VisualEditor: Help:Installing Japanese character sets with span tags appeared mysteriously in a reference - 10https://bugzilla.wikimedia.org/69861#c1 (10Roan Kattouw) Ugh, I found the cause, it's another whitespace bunny-hop bug. This whole mess is made because we have something like )[category] and i... [19:51:20] 3OOjs UI / 3Technical Debt: OOjs UI: Use MutationObserver to detect when an OO.ui.Element is attached to a document - 10https://bugzilla.wikimedia.org/62174 (10James Forrester) s:5normal>3enhanc [19:54:51] TrevorParscal, so nobody's noticed that you broke embeddable contexts 2 months ago... [19:54:52] 3OOjs UI: OOjs UI: Dialogs in Agora (mobile) have 1em margin at top instead of being full height - 10https://bugzilla.wikimedia.org/69710 (10James Forrester) 5PATC>3RESO/FIX a:3Ryan Kaldari [19:55:14] "if ( node instanceof ve.ce.FocusableNode )" [19:55:19] MatmaRex: I'm slinging a few bugs at you, if you hadn't noticed. :-) [19:55:35] so much pinging [19:55:42] Sorry! [19:56:09] :) [19:57:55] edsanders: Oh yeah come to think of it that is broken [19:58:37] OK I have a failing test case for what we're doing to that Japanese olympics article [19:58:44] Although Parsoid is also doing scary things to it [20:04:42] You also deleted my "containsInspector" code which un-embeds contexts if they can be used as inspectors (so they don't get in the way once opened) [20:05:00] (03PS5) 10Trevor Parscal: Standardize less imports and image rule generation [oojs/ui] - 10https://gerrit.wikimedia.org/r/155457 [20:05:48] Is there a patch to fix MW to work with new dialog code? [20:06:13] (03PS1) 10Esanders: Fix embeddable desktop context popups [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155617 [20:06:15] (03PS1) 10Esanders: Rename getRelativeOffset to getBoundingRect and use in getSelectionRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155618 [20:06:17] (03PS1) 10Esanders: Fallback to node position when getting selection rectangle [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155619 (https://bugzilla.wikimedia.org/69122) [20:16:44] edsanders: It should already work with the patch that pulled that stuff in [20:16:49] (except for the save dialog which I fixed later) [20:17:16] I get an exception opening any inspector or window [20:17:16] (03PS4) 10Cmcmahon: [BrowserTest] add News and Journal to Cite test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155434 [20:17:38] (03CR) 10Cmcmahon: [C: 032] [BrowserTest] add News and Journal to Cite test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155434 (owner: 10Cmcmahon) [20:19:20] (03Merged) 10jenkins-bot: [BrowserTest] add News and Journal to Cite test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155434 (owner: 10Cmcmahon) [20:21:17] (03CR) 10Trevor Parscal: [C: 032] Fix embeddable desktop context popups [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155617 (owner: 10Esanders) [20:21:28] edsanders: Have you updated VE to master, and updated MW core? [20:21:43] update mw then submodule updated [20:22:37] says this.$content is undefined [20:22:52] (03Merged) 10jenkins-bot: Fix embeddable desktop context popups [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155617 (owner: 10Esanders) [20:22:59] this.frame.$content still exists... [20:22:59] hmm [20:23:01] (03CR) 10Trevor Parscal: [C: 032] Fallback to node position when getting selection rectangle [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155619 (https://bugzilla.wikimedia.org/69122) (owner: 10Esanders) [20:24:16] oh [20:24:23] mw core, of course [20:24:24] (03CR) 10Trevor Parscal: [C: 032] Rename getRelativeOffset to getBoundingRect and use in getSelectionRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155618 (owner: 10Esanders) [20:24:31] fscking oojs [20:26:12] (03Merged) 10jenkins-bot: Rename getRelativeOffset to getBoundingRect and use in getSelectionRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155618 (owner: 10Esanders) [20:26:13] (03Merged) 10jenkins-bot: Fallback to node position when getting selection rectangle [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155619 (https://bugzilla.wikimedia.org/69122) (owner: 10Esanders) [20:28:11] (03CR) 10Trevor Parscal: [C: 032] Remove div-wrapping of block images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155012 (owner: 10Esanders) [20:29:32] (03CR) 10Trevor Parscal: [C: 032] Remove span-wrapping of link='' images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154415 (owner: 10Esanders) [20:31:25] (03Merged) 10jenkins-bot: Remove span-wrapping of link='' images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154415 (owner: 10Esanders) [20:31:27] (03Merged) 10jenkins-bot: Remove div-wrapping of block images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155012 (owner: 10Esanders) [20:36:01] (03PS1) 10Jforrester: build: Check for files' existence before building using grunt-file-exists [oojs/ui] - 10https://gerrit.wikimedia.org/r/155630 (https://bugzilla.wikimedia.org/63743) [20:36:37] 3OOjs UI: OOjs UI: CI – Grunt doesn't complain when a file listed in build/tasks/modules.json is missing - 10https://bugzilla.wikimedia.org/63743 (10James Forrester) a:5Krinkle>3James Forrester [20:40:21] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] Each category is getting added twice in Betalabs, throws TypeError: categoryItem is undefined - 10https://bugzilla.wikimedia.org/68484#c14 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [20:44:35] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot load Mobile VE in Betalabs in iOS safari - 10https://bugzilla.wikimedia.org/68949 (10Rummana Yasmeen) 5RESO/?>3VERI [20:45:50] 3VisualEditor / 3Mobile: VisualEditor Mobile: Disable the context menu for the Basic reference - 10https://bugzilla.wikimedia.org/68897#c6 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production. [20:50:05] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf16]Opening link inspector/comment box in an empty line, opens them at the end of the previous line - 10https://bugzilla.wikimedia.org/69122 (10James Forrester) 5PATC>3RESO/FIX [20:50:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf16] Comment box is not opening in Firefox , throwing error:TypeError: ve.ui.WhitespaceTextInputWidget is not a constructor - 10https://bugzilla.wikimedia.org/68960#c8 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [20:53:21] err I'm having troubles rebasing [20:53:28] mooeypoo: Rebasing what? [20:53:41] this https://gerrit.wikimedia.org/r/#/c/149217/ [20:53:51] it's really weird [20:54:28] very straight forward rebase. I pull it for review, go "git rebase master", follow the conflicts (apply all the updates, really) and then 'git add ...MWImageModel.js' and 'git rebase --continue' [20:54:42] but then I get [20:54:44] Applying: Refactoring ImageModel constructor [20:54:44] No changes - did you forget to use 'git add'? [20:54:51] ... and it doesn't let me continue the rebase [20:54:57] Oooh. You may need to rebase --skip? [20:55:08] Did we do some of the changes to MWImageModel early? [20:55:09] But wouldn't that mean not applying the commit [20:55:14] Hmm. [20:55:16] * James_F has a go. [20:55:20] Yeah but I don't think we did them all [20:55:21] hm [20:55:23] (If that's OK?) [20:55:30] go for it [20:55:46] I'm trying to figure out what is going on :\ [20:56:02] It may be that you need to use rebase --onto [20:56:16] Or that you're doing something else weird where you're rebasing onto something that kind of already has your code but not really [20:56:27] Oh, yes [20:56:42] That one has an outdated dependency, you need to either use rebase --onto, or you need to run rebase --skip for the first one [20:56:51] No, hold on, it's a MERGED outdated dependency [20:56:53] wtf [20:58:27] OK James and I talked it through, you do need onto [20:58:38] mooeypoo: Congratulations, you managed to create a rebase scenario that I had never though about before [20:58:45] haha [20:58:58] okay, onto what? [20:59:00] (03PS1) 10Catrope: Change comment to meta in whitespace test case to actually test whitespace handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155633 [20:59:02] (03PS1) 10Catrope: Fix the newline bunny-hop bug harder [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155634 (https://bugzilla.wikimedia.org/69861) [20:59:48] I thought the point of rebasing 'git rebase master' is that it rebases it "onto" the top of master [20:59:59] Well, so here's what happened [21:00:09] The thing you are rebasing on is B [21:00:12] Sorry [21:00:16] The thing you are rebasing is B [21:00:21] B depends on A1 [21:00:28] master contains A2, which is a newer version of A1 [21:00:54] 'git rebase master' is dumb, and will go "oh master has neither A1 nor B, so I need to apply A1 on top of master, then B" [21:01:08] Which explodes in a hellacious ball of fire because master already has A2 which is kind of like A1 but not exactly [21:01:19] I pulled master, so I have A2, theoretically. Then I pulled B, and did 'git rebase master' which theoretically SHOULD rebase onto A2. [21:01:24] Yes [21:01:34] ahha [21:01:36] yeah that's not very intuitive. [21:01:37] But it also needs to automatically detect which commits it's going to rebase onto master [21:01:54] hmmm [21:01:58] And the algorithm for that is "find common ancestor, take all commits between common ancestor and B" [21:02:08] okay, so if I rebase it onto something, do I rebase it 'onto A2' ? [21:02:23] No, --onto is terribly named [21:02:32] mooeypoo: `git rebase --onto origin/master HEAD^` is what you wanted. [21:02:33] (03PS15) 10Jforrester: Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) (owner: 10Mooeypoo) [21:02:37] Yes exactly [21:02:38] (Done.) [21:02:45] oh you did that? awesomesauce [21:02:53] The syntax is git rebase --onto [thing to rebase onto] [cutoff point] [21:02:58] and... geez, git rebase is weird. [21:03:09] If you omit --onto, then [cutoff point] defaults to "the common ancestor of HEAD and [thing to rebase onto]" [21:03:23] right, but usually the 'thing to rebase onto' is a patchset ID [21:03:23] Which is usually correct, but in some cases it's wrong [21:03:36] right [21:03:53] And in those cases we say [cutoff point] = HEAD^ which means "cut off at the commit right before HEAD" which translates to "only rebase HEAD and nothing below it" [21:04:03] Cause by default it tries to lift up an entire tree of stuff and move it somewhere else [21:05:01] ahha [21:05:20] wow, it kinda makes sense, even though it's so weird it really shouldn't [21:08:29] (03CR) 10Jforrester: [C: 032] Change comment to meta in whitespace test case to actually test whitespace handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155633 (owner: 10Catrope) [21:09:03] edsanders: https://gerrit.wikimedia.org/r/#/c/155634/ fun times. :-) [21:09:37] 3VisualEditor / 3Data Model: VisualEditor: Return of the whitespace bunny-hopping bug - 10https://bugzilla.wikimedia.org/69861 (10James Forrester) p:5Unprio>3High a:3Roan Kattouw [21:10:13] (03Merged) 10jenkins-bot: Change comment to meta in whitespace test case to actually test whitespace handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155633 (owner: 10Catrope) [21:14:39] 3VisualEditor / 3Data Model: VisualEditor: Return of the whitespace bunny-hopping bug - 10https://bugzilla.wikimedia.org/69861#c3 (10Roan Kattouw) (In reply to Gerrit Notification Bot from comment #2) > Change 155634 had a related patch set uploaded by Catrope: > Fix the newline bunny-hop bug harder > > htt... [21:17:53] TrevorP|Away, RoanKattouw_away will you have some time at 3pm? [21:20:08] jgonera: I will [21:20:11] (I should get lunch soon) [21:20:17] Trevor is off in a meeting somewhere [21:20:36] ok, cool, I just need one of you at a time I guess ;) [21:20:54] JS is driving me crazy today [21:21:01] I think he'll probably be back by 3 though [21:30:07] 3VisualEditor / 3Data Model: VisualEditor: Return of the whitespace bunny-hopping bug - 10https://bugzilla.wikimedia.org/69861 (10Roan Kattouw) [21:35:25] 3VisualEditor: Media: bogus "no results found" message when searching media returns results - 10https://bugzilla.wikimedia.org/69877 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 16262 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16262&action=edit bogus "no results" fo... [21:37:20] 3VisualEditor: Media: bogus "no results found" message when searching media returns results - 10https://bugzilla.wikimedia.org/69877#c1 (10Chris McMahon) Also note that search results for Media in Firefox are different than in Chrome, and Firefox seems to be less correct. [21:37:50] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438#c7 (10James Forrester) *** Bug 69877 has been marked as a duplicate of this bug. *** [21:37:52] 3VisualEditor: Media: bogus "no results found" message when searching media returns results - 10https://bugzilla.wikimedia.org/69877#c2 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 67438 *** [21:38:05] 3VisualEditor: Media: bogus "no results found" message when searching media returns results - 10https://bugzilla.wikimedia.org/69877#c3 (10James Forrester) (In reply to Chris McMahon from comment #1) > Also note that search results for Media in Firefox are different than in > Chrome, and Firefox seems to be le... [21:43:16] 3VisualEditor / 3Mobile: VisualEditor Mobile: Switching tabs in mobile safari often causes page to refresh causing data loss of session changes - 10https://bugzilla.wikimedia.org/68017#c5 (10James Forrester) 5REOP>3ASSI p:5High>3Low a:5Juliusz Gonera>3None (In reply to Jared Zimmerman (WMF) from... [21:55:13] (03CR) 10Trevor Parscal: [C: 032] Make help icon have an RTL variant [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (owner: 10Jforrester) [21:55:15] (03CR) 10jenkins-bot: [V: 04-1] Make help icon have an RTL variant [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (owner: 10Jforrester) [21:55:34] (03CR) 10Trevor Parscal: [C: 032] build: Check for files' existence before building using grunt-file-exists [oojs/ui] - 10https://gerrit.wikimedia.org/r/155630 (https://bugzilla.wikimedia.org/63743) (owner: 10Jforrester) [21:56:07] (03PS1) 10Cmcmahon: [BrowserTest] UI has new text in buttons and headers [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155645 [21:56:41] (03Merged) 10jenkins-bot: build: Check for files' existence before building using grunt-file-exists [oojs/ui] - 10https://gerrit.wikimedia.org/r/155630 (https://bugzilla.wikimedia.org/63743) (owner: 10Jforrester) [21:58:33] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155645 (owner: 10Cmcmahon) [21:58:59] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf18] Cite, Insert, format dropdown elements do not bring up dialog - 10https://bugzilla.wikimedia.org/69856#c3 (10Rummana Yasmeen) Verified the fix in Betalabs but this is happening in test2 right now [22:00:13] (03Merged) 10jenkins-bot: [BrowserTest] UI has new text in buttons and headers [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155645 (owner: 10Cmcmahon) [22:12:44] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438#c8 (10Moriel Schottlender) I can't replicate this. If you're still seeing this, can you give me the page this is still ha... [22:19:14] 3VisualEditor / 3Mobile: VisualEditor Mobile: Switching tabs in mobile safari often causes page to refresh causing data loss of session changes - 10https://bugzilla.wikimedia.org/68017#c6 (10Jared Zimmerman (WMF)) "don't close me bro" [22:20:29] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438#c9 (10Chris McMahon) As in the duplicate bug, page is http://en.wikipedia.beta.wmflabs.org/wiki/Media_Interface_VisualEdi... [22:23:30] edsanders, how can I find the index of the internal list in the document [22:23:58] dm.internallist has a getnode function [22:24:02] I want to make sure I copy the document's internal list to the new caption document I create in the media dialog Caption [22:24:22] ve.dm.InternalList.prototype.getListNode [22:24:36] But the nodes aren't linmod are they? They're the node objects [22:24:39] mooeypoo: Don't do that manually, there's a thing for that [22:24:48] you should speak to RoanKattouw about document insertion stuff [22:24:57] oh [22:25:01] hi RoanKattouw :P [22:25:21] ve.dm.Document#cloneFromRange [22:25:25] So, there's this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=60919 and it seems to be fairly straight forward if I can only copy over the internalList [22:25:34] from the main document to the caption document [22:26:10] ve.dm.MWReferenceModel does this correctly when editing an existing reference [22:26:14] 3MediaWiki extensions / 3WikiEditor: [Regression] ext.wikiEditor.toolbar.hideSig.js stopped working - 10https://bugzilla.wikimedia.org/40972#c6 (10George Orwell III) Your words, not mine ( https://gerrit.wikimedia.org/r/87649 ) > Most wikis only use user signatures on pages set aside from discussion, > (Tal... [22:26:16] I think it might be broken when inserting a new reference though [22:26:32] Although right now that's not a noticeable problem because only references use the internal list and you can't nest references [22:26:59] Ugh. We should do the subdocument thing already [22:27:51] hm [22:28:10] If I add a reference in the media dialog caption, it appears in the main reference list, so the operation happens one-way at least [22:28:13] now it need to go the other [22:28:46] Yes that works, kind of by accident [22:28:51] It has to work because of copy-paste support [22:30:00] Ha [22:30:07] Can we copy/paste the other way? [22:30:08] :D [22:30:16] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438#c10 (10Moriel Schottlender) And I still can't see the issue there. I load "Insert media" and I see the search image page... [22:31:41] RoanKattouw, so, does this need the subdocuments to be fixed? no good for me to try and copy the internal lists? [22:34:44] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438#c11 (10Chris McMahon) As I mentioned in the dup bug, it's seen in Firefox. In Chrome I see the 'no results' found flicker... [22:38:54] James_F, did you see this bug ? I can't manage to reproduce in beta and in local. O.o https://bugzilla.wikimedia.org/show_bug.cgi?id=67438#c11 [22:39:54] mooeypoo: Sorry I was eating [22:40:25] It doesn't /need/ subdocuments, they would just make it nicer I think [22:40:43] But yeah you should copy the internallist. cloneFromRange() already does that for you, for the case where you have an existing caption [22:41:38] When you don't have an existing caption... I need to write a utility method for that [22:42:05] Hm. But it doesn't seem to work even when I have a caption [22:42:29] RoanKattouw, I added a caption with a reference insde the caption and I saved the image. Caption added and the reference was added to the document's list [22:42:52] Yeah when writing it does work [22:43:14] then i edit the image again -- now, the caption already exists. I try to add a 're-use' reference, and all I see in the options is the reference i added directly into the image caption -- I don't see any of the references outside it in the main document [22:43:20] even though the caption already existed. [22:43:22] Yes, exactly [22:43:26] it seems the internal lists aren't copied [22:43:30] So, let me explain what happens here [22:43:41] If you edit an EXISTING REFERENCE: [22:43:56] doc.cloneFromRange() is called, it copies the main document's internal list [22:44:17] so when editing you have access to existing references (although the UI for this isn't exposed (nested references aren't allowed), so you don't notice) [22:44:18] Existing reference or existing caption? [22:44:55] and when saving, newFromDocumentInsertion() knows that the subdocument's internal list started as a copy of the main document's, so it can safely replace the main document's internal list with the subdocument's [22:45:05] this means that if you added references or changed them, those changes get copied over [22:45:08] So that was for an existing reference [22:45:24] If you create a NEW REFERENCE or a NEW CAPTION (both of these cases are currently broken): [22:45:42] okay [22:45:45] the subdocument is created from scratch, has no relation to the main document, and has an empty internal list [22:45:55] if you try to reuse references, you won't see any, for that reason [22:46:09] you can add a new reference and it'll sit there in the subdocument's internal list, by itself [22:46:33] but the first part may work for existing references, but doesn't seem to work for existing captions. That's known? [22:46:54] then when saving, newFromDocumentInsertion() knows that the subdocument's internal list did NOT start as a copy of the main document's, so it performs a merge, and your new reference gets inserted into the main document's internal list at a different position, and index remapping is performed to make that not break [22:46:56] (03PS1) 10Cmcmahon: [BrowserTest] language screenshot update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155652 [22:47:08] Yes, that's known, because if you EDIT AN EXISTING CAPTION (also broken): [22:47:28] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155652 (owner: 10Cmcmahon) [22:47:35] hmm [22:47:36] the subdocument is not currently created with cloneFromRange(), and so it behaves exactly like the insertion case except it happens to have stuff in it [22:47:55] ...I do have cloneFromRange on the doc for the caption though [22:48:02] It's easy to make that behave like the edit existing reference case, by using cloneFromRange [22:48:05] Oh you do? [22:48:10] this.imageModel.setCaptionDocument( [22:48:10] this.selectedNode.getDocument().cloneFromRange( this.captionNode.getRange() ) [22:48:11] ); [22:48:27] That's what I am trying to figure out - I seem to copy but not copy *enough*... or... something [22:48:34] OK that seems like it should work [22:48:46] But reusing references when editing an existing caption doesn't work? [22:48:53] nope [22:49:25] (03Merged) 10jenkins-bot: [BrowserTest] language screenshot update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155652 (owner: 10Cmcmahon) [22:49:37] (03CR) 10Jforrester: [C: 04-2] Make help icon have an RTL variant [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (owner: 10Jforrester) [22:49:40] Oh, argh [22:49:43] This is a DIFFERENT bug [22:49:54] :\ [22:50:16] It's not this one? https://bugzilla.wikimedia.org/show_bug.cgi?id=60919 [22:50:26] oh, I just realized what you meant with a different bug [22:50:27] ha [22:50:29] hm. [22:50:30] OK so is it clear why insertion is definitely broken and editing existing is only kind of broken? [22:50:43] I am doing some refactoring right now so we can make insertion less broken [22:50:55] Like, it's obvious why insertion cannot possibly work currently, but editing is less obvious [22:50:57] Editing is mostly broken; I can see the references that I used in the *current* document (so, whatever's inside the caption) not the ones that are in the main document [22:51:01] So my patch will get insertion to where editing's at [22:51:04] no matter if it's an insertion or an edit of a new or existing caption [22:51:09] Yeah, so [22:51:15] The internal list is actually copied over correctly [22:51:29] It is? Hm So it's about reading it? [22:51:39] But, for whatever reason, the internal list's registry of which item is used where isn't built [22:51:43] Is there any other 'subdocument' other than images we can test? [22:52:02] IE, test if it's something with the way the caption's copied or something with the bigger process [22:52:17] I just realized I probably should stop using "IE" for "as in" with you [22:52:24] haha [22:52:26] It's i.e. [22:52:40] Indeed. I'll try to remember to dot my I's and E's [22:54:12] OK so the internal list is getting copied right, but internalList.nodes isn't populated [22:54:19] Let me see why [22:57:45] 3OOjs UI: OOjs UI: CI – Grunt doesn't complain when a file listed in build/tasks/modules.json is missing - 10https://bugzilla.wikimedia.org/63743 (10James Forrester) 5PATC>3RESO/FIX [22:58:43] (03PS1) 10Catrope: [WIP] Add cloneWithData() utility [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155655 [22:59:02] OK so that's my messing around with trying to create a utility function to address the new insertion case [22:59:26] It's not done, it needs to be tested and actually used places, but I wanted to just put that somewhere [22:59:39] Now I'll look at why the internalList's this.nodes isn't populated [23:02:39] I need to leave the coffee shop, but I'm adding myself to that patchset to follow it and i'll get back a bit later. [23:03:05] RoanKattouw, so I assume this isn't going to be as straight forward bug-fix as I initially assumed...? :p [23:03:12] No, it's not [23:03:16] It's deep DM stuff [23:03:23] But I'm working on it [23:03:24] Boo DM. [23:03:35] hm. [23:03:37] You know what tihs means. [23:03:43] (03PS1) 10JGonera: Remove global overlay classes when destroying MobileSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155657 (https://bugzilla.wikimedia.org/69630) [23:03:45] I already did https://gerrit.wikimedia.org/r/#/c/155634/ today (see also associated bug, there's a Parsoid bug in play too) [23:03:58] So I'm in a DM mood [23:04:02] James_F, I need bugs. Bugs bugs bugs. [23:04:41] RoanKattouw, hm. It sounds like subdocuments are really going to fix this best, actually. [23:04:44] mooeypoo: :-) [23:04:51] 3VisualEditor / 3Mobile: VisualEditor Mobile: [iOS] abandoning edit takes me to unscrollable page - 10https://bugzilla.wikimedia.org/69630 (10James Forrester) p:5Unprio>3High a:3Juliusz Gonera [23:05:02] mooeypoo: Yes they really are [23:05:26] (03CR) 10jenkins-bot: [V: 04-1] Remove global overlay classes when destroying MobileSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155657 (https://bugzilla.wikimedia.org/69630) (owner: 10JGonera) [23:05:29] Are? Not would? [23:05:32] That seems optimistic. [23:06:35] But I do need to leave the coffee shop in a couple of minutes. [23:06:57] (03PS2) 10JGonera: Remove global overlay classes when destroying MobileSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155657 (https://bugzilla.wikimedia.org/69630) [23:07:00] I'll get back on later. See you guys soon [23:09:44] 3VisualEditor / 3Technical Debt: VisualEditor: Image CE HTML should match Parsoid - 10https://bugzilla.wikimedia.org/66610 (10James Forrester) [23:09:59] 3VisualEditor / 3Technical Debt: VisualEditor: Image CE HTML should match Parsoid - 10https://bugzilla.wikimedia.org/66610#c2 (10James Forrester) What's left to do here? [23:10:16] 3VisualEditor / 3Editing Tools: VisualEditor: In the media selector show name in a tooltip on mouseover - 10https://bugzilla.wikimedia.org/52459 (10James Forrester) a:3Moriel Schottlender [23:10:16] 3VisualEditor / 3Editing Tools: VisualEditor: In the media insertion dialog, give a tooltip on each item saying what will happen when you click it (i.e., "Click to insert as a thumbnail" or whatever) - 10https://bugzilla.wikimedia.org/52219 (10James Forrester) [23:10:27] Oh, I found out what the issue is [23:10:28] It's nasty [23:10:47] The reason no refs get registered with the inner internalList is because there are no refs in the inner document, only internalList items [23:10:51] Which makes sense but is unhelpful [23:11:12] I think maybe we just need to move to subdocuments for this, it can probably be worked around without that but it'd be a pain [23:11:26] I have to go help Juliusz now, just dumping my thoughts into IRC so I don't forget [23:11:31] (03CR) 10Jforrester: "Shouldn't be merged until either (a) OOUI has language-specific LTR/RTL over-rides for icons, or (b) the main downstream users (VE, MV, Mo" [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (owner: 10Jforrester) [23:33:45] (03PS1) 10Trevor Parscal: Make window managers destroyable [oojs/ui] - 10https://gerrit.wikimedia.org/r/155664 [23:36:53] (03PS2) 10Catrope: Make window managers destroyable [oojs/ui] - 10https://gerrit.wikimedia.org/r/155664 (owner: 10Trevor Parscal) [23:39:26] (03CR) 10Catrope: [C: 04-1] Make window managers destroyable (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/155664 (owner: 10Trevor Parscal) [23:41:02] (03PS3) 10Catrope: Make window managers destroyable [oojs/ui] - 10https://gerrit.wikimedia.org/r/155664 (owner: 10Trevor Parscal) [23:41:11] (03CR) 10Catrope: [C: 032] Make window managers destroyable [oojs/ui] - 10https://gerrit.wikimedia.org/r/155664 (owner: 10Trevor Parscal) [23:42:03] (03CR) 10Catrope: [C: 032] Remove global overlay classes when destroying MobileSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155657 (https://bugzilla.wikimedia.org/69630) (owner: 10JGonera) [23:42:22] (03CR) 10Ori.livneh: [C: 032] Followup 67f304a: use .openWindow(), not .open(), to open save dialog [extensions/VisualEditor] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/155601 (https://bugzilla.wikimedia.org/69864) (owner: 10Jforrester) [23:44:16] (03Merged) 10jenkins-bot: Make window managers destroyable [oojs/ui] - 10https://gerrit.wikimedia.org/r/155664 (owner: 10Trevor Parscal) [23:44:56] (03Merged) 10jenkins-bot: Remove global overlay classes when destroying MobileSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155657 (https://bugzilla.wikimedia.org/69630) (owner: 10JGonera) [23:46:01] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (d6008381aa) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155665 [23:46:19] RoanKattouw: and https://gerrit.wikimedia.org/r/155666 [23:46:50] (03Abandoned) 10Catrope: Update OOjs UI to v0.1.0-pre (55b861b167) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155586 (owner: 10Jforrester) [23:47:27] (03Merged) 10jenkins-bot: Followup 67f304a: use .openWindow(), not .open(), to open save dialog [extensions/VisualEditor] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/155601 (https://bugzilla.wikimedia.org/69864) (owner: 10Jforrester) [23:47:42] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (d6008381aa) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155665 (owner: 10Jforrester) [23:49:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf18] Save Page no longer completes save actions - 10https://bugzilla.wikimedia.org/69864 (10James Forrester) 5PATC>3RESO/FIX [23:50:54] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (d6008381aa) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155665 (owner: 10Jforrester) [23:52:03] (03PS1) 10Catrope: Destroy WindowManagers in Context and Surface destructors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155668 [23:52:13] TrevorParscal: https://gerrit.wikimedia.org/r/155668 [23:53:21] (03PS2) 10Catrope: Destroy WindowManagers in Context and Surface destructors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155668 (https://bugzilla.wikimedia.org/69630) [23:53:34] (03CR) 10JGonera: [C: 032] Destroy WindowManagers in Context and Surface destructors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155668 (https://bugzilla.wikimedia.org/69630) (owner: 10Catrope) [23:55:15] (03Merged) 10jenkins-bot: Destroy WindowManagers in Context and Surface destructors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155668 (https://bugzilla.wikimedia.org/69630) (owner: 10Catrope)