[00:07:02] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector ignores selected value - 10https://bugzilla.wikimedia.org/65343#c4 (10Roan Kattouw) *** Bug 68934 has been marked as a duplicate of this bug. ***
[00:07:02] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector sets wrong title when clicking suggestion - 10https://bugzilla.wikimedia.org/68934#c1 (10Roan Kattouw) 5ASSI>3RESO/DUP   *** This bug has been marked as a duplicate of bug 65343 ***
[00:08:29] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Inspectors close immediately in IE - 10https://bugzilla.wikimedia.org/69503#c1 (10Roan Kattouw) 5NEW>3RESO/FIX Fixed in https://gerrit.wikimedia.org/r/#/c/155182/
[00:09:17] <grrrit-wm1>	 (03PS1) 10Trevor Parscal: Select the correct annotation in MWLinkTargetInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155673 (https://bugzilla.wikimedia.org/68934) 
[00:09:54] <grrrit-wm1>	 (03PS2) 10Catrope: Select the correct annotation in MWLinkTargetInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155673 (https://bugzilla.wikimedia.org/65343) (owner: 10Trevor Parscal)
[00:11:06] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: If there is a page with the exact name, it should appear first in the link auto-complete list - 10https://bugzilla.wikimedia.org/69780#c1 (10Roan Kattouw) This is partly a bug in our search backend, but it can also happen because we choose to deprioritize redirec...
[00:13:52] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Select the correct annotation in MWLinkTargetInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155673 (https://bugzilla.wikimedia.org/65343) (owner: 10Trevor Parscal)
[00:15:33] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Select the correct annotation in MWLinkTargetInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155673 (https://bugzilla.wikimedia.org/65343) (owner: 10Trevor Parscal)
[00:22:34] <wikibugs>	 3MediaWiki / 3ResourceLoader: Remove 'apiScript' from $wgResourceLoaderSources - 10https://bugzilla.wikimedia.org/69878 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None When $wgResourceLoaderSources was introduced, it required two keys, one for the load.php location, and another for the api...
[00:22:54] <legoktm>	 :O RL bugs go in here now?
[00:36:14] <wikibugs>	 3MediaWiki extensions / 3WikiEditor: [Regression] ext.wikiEditor.toolbar.hideSig.js stopped working - 10https://bugzilla.wikimedia.org/40972#c7 (10This, that and the other (TTO)) (In reply to George Orwell III from comment #6) > So are we in agreement or not that regardless of the wiki in question - be > it...
[00:40:33] <grrrit-wm1>	 (03PS1) 10JGonera: [WIP] Do not focus CE on mobile when editor opens [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155678 (https://bugzilla.wikimedia.org/68832) 
[00:42:29] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector sets wrong title when clicking suggestion - 10https://bugzilla.wikimedia.org/68934#c3 (10James Forrester) 5PATC>3RESO/DUP Still a dupe of bug 65343 :-)  *** This bug has been marked as a duplicate of bug 65343 ***
[00:42:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector ignores selected value - 10https://bugzilla.wikimedia.org/65343#c7 (10James Forrester) *** Bug 68934 has been marked as a duplicate of this bug. ***
[00:43:01] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector ignores selected value - 10https://bugzilla.wikimedia.org/65343 (10James Forrester) 5PATC>3RESO/FIX s:5normal>3major
[00:44:01] <wikibugs>	 3VisualEditor / 3Initialisation: VisualEditor: Internet Explorer compatibility (tracking) - 10https://bugzilla.wikimedia.org/50085 (10James Forrester)
[00:44:02] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Inspectors close immediately in IE - 10https://bugzilla.wikimedia.org/69503 (10James Forrester) p:5Unprio>3Normal a:3Roan Kattouw
[00:45:15] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [iOS] abandoning edit takes me to unscrollable page - 10https://bugzilla.wikimedia.org/69630 (10James Forrester) 5PATC>3ASSI
[01:13:56] <grrrit-wm1>	 (03PS2) 10Catrope: Fix the newline bunny-hop bug harder [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155634 (https://bugzilla.wikimedia.org/69861) 
[01:15:21] <grrrit-wm1>	 (03PS3) 10Catrope: Fix the newline bunny-hop bug harder [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155634 (https://bugzilla.wikimedia.org/69861) 
[01:15:31] <grrrit-wm1>	 (03PS4) 10Catrope: Fix the newline bunny-hop bug harder [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155634 (https://bugzilla.wikimedia.org/69861) 
[01:20:44] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Standardize less imports and image rule generation [oojs/ui] - 10https://gerrit.wikimedia.org/r/155457 (owner: 10Trevor Parscal)
[01:20:47] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Standardize less imports and image rule generation [oojs/ui] - 10https://gerrit.wikimedia.org/r/155457 (owner: 10Trevor Parscal)
[01:23:29] <grrrit-wm1>	 (03PS6) 10Catrope: Standardize less imports and image rule generation [oojs/ui] - 10https://gerrit.wikimedia.org/r/155457 (owner: 10Trevor Parscal)
[01:23:43] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Standardize less imports and image rule generation [oojs/ui] - 10https://gerrit.wikimedia.org/r/155457 (owner: 10Trevor Parscal)
[01:26:01] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Standardize less imports and image rule generation [oojs/ui] - 10https://gerrit.wikimedia.org/r/155457 (owner: 10Trevor Parscal)
[01:29:44] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: "sets" don't come through in api when td is in a transcluded page - 10https://bugzilla.wikimedia.org/69647#c3 (10Krinkle) 5ASSI>3UNCO Can't reproduce this on latest master.  Edited Unsigned/doc on my local wiki and added a sets section:      "sets": [...
[01:39:59] <wikibugs>	 3MediaWiki extensions / 3WikiEditor: [Regression] ext.wikiEditor.toolbar.hideSig.js stopped working - 10https://bugzilla.wikimedia.org/40972#c8 (10George Orwell III) (In reply to This, that and the other (TTO) from comment #7) > (In reply to George Orwell III from comment #6)  OK. We're not so far apart afte...
[06:02:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Inspectors and context menu should close when blurring the document and/or when opening the save dialog - 10https://bugzilla.wikimedia.org/51439#c3 (10Roan Kattouw) Is this fixed now? I can't reproduce this any more. Clicking Save page closes the link inspector f...
[06:24:32] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Populate LinkCache from MWLinkTargetInputWidget etc - 10https://bugzilla.wikimedia.org/69886 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None In MWLinkTargetInputWidget and other places, we perform API requests that give us exactly the kind of in...
[06:39:01] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: "sets" don't come through in api when td is in a transcluded page - 10https://bugzilla.wikimedia.org/69647#c4 (10marielle.volz) 5UNCO>3RESO/DUP Thanks for looking into this all.  I just realized this is actually a duplicate bug:  https://bugzilla.wikim...
[06:58:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843#c7 (10Roan Kattouw) I think this is fixed now? I can't reproduce it any more...
[08:32:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Too much tabbing in the Template dialog - 10https://bugzilla.wikimedia.org/69512#c3 (10Derk-Jan Hartman) (In reply to James Forrester from comment #2) > Using a <button> rather than a <div> in OOUI for buttoned elements takes us > into really horrible issues mor...
[09:57:55] <grrrit-wm1>	 (03CR) 10Esanders: "We don't need to map every VE node to an HTML element. Given that images will be convertible to figures it makes sense to give them simila" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154439 (owner: 10Esanders)
[10:11:45] <wikibugs>	 3MediaWiki / 3ResourceLoader: Remove 'apiScript' from $wgResourceLoaderSources - 10https://bugzilla.wikimedia.org/69878 (10Andre Klapper) p:5Unprio>3Normal
[10:28:17] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Language selector should be able to use div - 10https://bugzilla.wikimedia.org/69892 (10Eran Roz) 3NEW p:3Unprio s:3normal a:3None Currently language selector adds <span lang=".." dir="..."> which is good for multiple words. However, sometimes longer text...
[10:34:44] <wikibugs>	 3MediaWiki / 3ResourceLoader: ResourceLoader: mw.loader.using() promise is indefinitely "pending" if load request is aborted - 10https://bugzilla.wikimedia.org/66598 (10Krinkle)
[12:36:17] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Inspector of FocusNodes with embedded menu should not be embedded in some cases - 10https://bugzilla.wikimedia.org/66542#c8 (10Ed Sanders) *** Bug 67306 has been marked as a duplicate of this bug. ***
[12:36:17] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Embedded context menu gets in the way of content when live-editing a tall extension node - 10https://bugzilla.wikimedia.org/67306#c5 (10Ed Sanders) 5RESO/FIX>3RESO/DUP   *** This bug has been marked as a duplicate of bug 66542 ***
[12:36:29] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Inspector of FocusNodes with embedded menu should not be embedded in some cases - 10https://bugzilla.wikimedia.org/66542#c9 (10Ed Sanders) Regressed.
[12:36:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Inspector of FocusNodes with embedded menu should not be embedded in some cases - 10https://bugzilla.wikimedia.org/66542 (10Ed Sanders) 5RESO/FIX>3REOP
[12:37:36] <grrrit-wm1>	 (03PS1) 10Esanders: Never embed the context when an inspector is present [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155704 (https://bugzilla.wikimedia.org/66542) 
[13:09:26] <grrrit-wm1>	 (03PS2) 10Esanders: Never embed the context when an inspector is present [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155704 (https://bugzilla.wikimedia.org/66542) 
[13:12:58] <grrrit-wm1>	 (03PS1) 10Esanders: Make focusables behave correctly when $element != $focusable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155706 
[13:43:06] <grrrit-wm1>	 (03PS2) 10Esanders: Update oo#compare usages [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155545 
[14:41:47] <grrrit-wm1>	 (03PS36) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 
[14:42:27] <grrrit-wm1>	 (03PS37) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 
[16:30:24] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=106714416
[16:30:24] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32355016
[16:30:24] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32355068
[16:30:24] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32357666
[16:31:19] <grrrit-wm1>	 (03CR) 10Esanders: "Also this should be non-blocking. If we come up with a different naming scheme in the future that feels better, we can rename quite easily" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154439 (owner: 10Esanders)
[16:39:47] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] "Fine." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154439 (owner: 10Esanders)
[16:42:01] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 04-1] "Minor issue, otherwise good to go." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154421 (owner: 10Esanders)
[16:43:36] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] Remove span-wrapping of images [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154417 (owner: 10Esanders)
[16:44:32] <grrrit-wm1>	 (03PS10) 10Jforrester: [BREAKING CHANGE] Rename 'image' to 'inlineImage' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154421 (owner: 10Esanders)
[16:45:03] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] "PS10 fixes the naming of the internal function. Otherwise good." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154421 (owner: 10Esanders)
[16:46:01] <grrrit-wm1>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Remove span-wrapping of images [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154417 (owner: 10Esanders)
[16:46:39] <grrrit-wm1>	 (03PS38) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 
[16:46:49] <grrrit-wm1>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Rename 'image' to 'inlineImage' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154421 (owner: 10Esanders)
[16:52:59] <grrrit-wm1>	 (03PS7) 10Jforrester: Basic block image (figure/figcaption) support [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154439 (owner: 10Esanders)
[16:53:08] <grrrit-wm1>	 (03PS4) 10Jforrester: Create ImageNode mixin to share logic between Block & Inline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155023 (owner: 10Esanders)
[16:54:03] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 031] Create ImageNode mixin to share logic between Block & Inline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155023 (owner: 10Esanders)
[16:55:30] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf18] Cite, Insert, format dropdown elements do not bring up dialog - 10https://bugzilla.wikimedia.org/69856#c4 (10James Forrester) Believe that this is now fixed in phase 0 (test2 etc.)
[17:02:01] <wikibugs>	 3OOjs UI: OOjs UI: images/ should not contain *.less files - 10https://bugzilla.wikimedia.org/69910 (10Krinkle)
[17:02:01] <wikibugs>	 3OOjs UI: OOjs UI: images/ should not contain *.less files - 10https://bugzilla.wikimedia.org/69910 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Both in src/ and in dist/ there are less files among the images. These should be moved out so that they're not mixed in the source (cleaner repository hierarc...
[17:13:38] <grrrit-wm1>	 (03PS9) 10Mooeypoo: [wip] Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) 
[17:16:08] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Never embed the context when an inspector is present [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155704 (https://bugzilla.wikimedia.org/66542) (owner: 10Esanders)
[17:17:12] <grrrit-wm1>	 (03PS2) 10Catrope: Make focusables behave correctly when $element != $focusable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155706 (owner: 10Esanders)
[17:17:17] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Make focusables behave correctly when $element != $focusable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155706 (owner: 10Esanders)
[17:17:55] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Never embed the context when an inspector is present [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155704 (https://bugzilla.wikimedia.org/66542) (owner: 10Esanders)
[17:19:45] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Make focusables behave correctly when $element != $focusable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155706 (owner: 10Esanders)
[17:49:56] <grrrit-wm1>	 (03CR) 10Mooeypoo: "Answered a couple of the comments and will fix the rest. As for the sortable logic -- yes, it should be tested further. I've made sure tha" (035 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo)
[17:50:31] <mooeypoo>	 Krinkle, some of the comments you put in only had "?" in them, so I wasn't entirely sure what you meant the problem was
[17:52:30] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf18] Cite, Insert, format dropdown elements do not bring up dialog - 10https://bugzilla.wikimedia.org/69856#c5 (10Rummana Yasmeen) Verified the fix in test2 for all dialogs in Chrome and Firefox
[18:12:31] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Inspector of FocusNodes with embedded menu should not be embedded in some cases - 10https://bugzilla.wikimedia.org/66542 (10James Forrester) 5PATC>3RESO/FIX
[18:12:51] <grrrit-wm1>	 (03PS24) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) 
[18:18:27] <RoanKattouw>	 James_F: https://gerrit.wikimedia.org/r/#/c/154439
[18:22:07] <grrrit-wm1>	 (03CR) 10Catrope: [C: 04-1] "Looks fine, one comment inline" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155023 (owner: 10Esanders)
[18:27:28] <grrrit-wm1>	 (03PS8) 10Jforrester: Basic block image (figure/figcaption) support [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154439 (owner: 10Esanders)
[18:29:27] <grrrit-wm1>	 (03PS2) 10Catrope: [WIP] Make OO.ui.Window's $content a div again [oojs/ui] - 10https://gerrit.wikimedia.org/r/155181 
[18:38:03] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843#c8 (10James Forrester) 5ASSI>3RESO/FIX a:5Ed Sanders>3Roan Kattouw Confirmed fixed in master bu...
[18:38:56] <grrrit-wm1>	 (03PS1) 10Catrope: Update VE core submodule to master (fdac16d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155773 
[18:40:03] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (fdac16d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155773 (owner: 10Catrope)
[18:40:45] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843#c9 (10Roan Kattouw) 5RESO/FIX>3REOP Never mind, I'm an idiot. It's still broken if you try to inspe...
[18:43:20] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Basic block image (figure/figcaption) support [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154439 (owner: 10Esanders)
[18:45:30] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Basic block image (figure/figcaption) support [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/154439 (owner: 10Esanders)
[18:48:22] <grrrit-wm1>	 (03PS1) 10Catrope: Update VE core submodule to master (f1fd9a8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155776 
[18:49:21] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (f1fd9a8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155776 (owner: 10Catrope)
[18:52:14] <grrrit-wm1>	 (03PS2) 10Catrope: Update VE core submodule to master (f1fd9a8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155776 
[18:56:47] <James_F>	 edsanders: You there? Could you advise about the pasteRules not listing 'figure's? Do we need to worry or is it fixed somewhere else?
[18:56:56] <James_F>	 edsanders: https://gerrit.wikimedia.org/r/#/c/155776/2/modules/ve-mw/init/ve.init.mw.Target.js looks pretty obviously missing something…
[19:02:13] <grrrit-wm1>	 (03Abandoned) 10Jforrester: Update VE core submodule to master (fdac16d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155773 (owner: 10Catrope)
[19:02:40] <grrrit-wm1>	 (03Abandoned) 10Jforrester: New ve.*.ImageNode classes in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155538 (owner: 10Esanders)
[19:03:01] <grrrit-wm1>	 (03Abandoned) 10Jforrester: Remove unused image css file from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155013 (owner: 10Esanders)
[19:03:18] <grrrit-wm1>	 (03Abandoned) 10Jforrester: Image renamed to InlineImage in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155014 (owner: 10Esanders)
[19:04:05] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 04-1] "Needs rebasing onto Ide31b474." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155018 (owner: 10Esanders)
[19:04:15] <grrrit-wm1>	 (03Abandoned) 10Jforrester: Block image and caption added in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155015 (owner: 10Esanders)
[19:10:45] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Inspectors and context menu should close when blurring the document and/or when opening the save dialog - 10https://bugzilla.wikimedia.org/51439#c4 (10James Forrester) 5ASSI>3RESO/FIX Confirmed, the link and language inspectors close on triggering the save di...
[19:13:02] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Language selector should be able to use div - 10https://bugzilla.wikimedia.org/69892#c1 (10James Forrester) 5NEW>3RESO/DUP Merging with bug 60187; this will require a major amount of work to provide a block-level editing concept more widely, of which this is...
[19:13:02] <wikibugs>	 3VisualEditor / 3Language: VisualEditor: Provide a language inspector to handle <div lang='xx' dir='yyy'> blocks and similar - 10https://bugzilla.wikimedia.org/60187#c1 (10James Forrester) *** Bug 69892 has been marked as a duplicate of this bug. ***
[19:13:14] <RoanKattouw>	 TrevorParscal: So one thing Internet Explorer is good for, apparently, is finding bugs in the window refactor: https://bugzilla.wikimedia.org/show_bug.cgi?id=69918
[19:13:17] <wikibugs>	 3OOjs UI: OOjs UI: Trying to close a window before it's ready causes a JS error - 10https://bugzilla.wikimedia.org/69918 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None An easy way to reproduce this is to add this.manager.closeWindow( this ); to the setup process (or ready process, probably) of any w...
[19:31:17] <wikibugs>	 3MediaWiki / 3Page editing: new section not added on edit conflict - 10https://bugzilla.wikimedia.org/69920 (10Umherirrender) 3NEW p:3Unprio s:3normal a:3None Have seen this[1] edit on the german village pump: The summary indicates a new section, but actually the last edit was removed and no new text...
[19:38:50] <grrrit-wm1>	 (03PS2) 10JGonera: Do not focus CE on mobile when editor opens [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155678 (https://bugzilla.wikimedia.org/68832) 
[19:45:47] <kaity>	 James_F: Have you noticed problems with beta labs today?
[19:47:12] <mooeypoo>	 kaity, I've been having issues with it off and on today
[19:55:06] <TrevorParscal>	 James_F|Away: by the way, our icon system does allow i18n
[19:55:25] <TrevorParscal>	 which I think we can use to override the ltr/rtl help
[19:55:45] <TrevorParscal>	 we should look at that again to get that thing merged
[20:03:00] <James_F>	 TrevorParscal: Oh, OK. How so?
[20:03:02] <James_F>	 kaity: Hey. I've not been using it enough to notice, sorry.
[20:07:58] <grrrit-wm1>	 (03PS1) 10Catrope: Remove broken ve.isMsie() function [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155797 
[20:11:52] <mooeypoo>	 RoanKattouw, if you add a 'v' at the end of that method name, it's a palindrome.
[20:17:38] <James_F>	 mooeypoo: Clearly we need a ve.isMsieV command for IE v. 5?
[20:18:01] <mooeypoo>	 :D
[20:18:40] <eranroz>	 is IE v.5 is IE?
[20:19:07] <James_F>	 Certainly, we don't support IE5. :-)
[20:20:48] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (f1fd9a8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155776 (owner: 10Catrope)
[20:22:29] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (f1fd9a8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155776 (owner: 10Catrope)
[20:23:10] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] Remove broken ve.isMsie() function [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155797 (owner: 10Catrope)
[20:24:23] <RoanKattouw>	 mooeypoo: lol
[20:25:05] <edsanders>	 James_F, um - probably
[20:25:17] <James_F>	 edsanders: Probably we should blacklist it?
[20:25:22] <James_F>	 edsanders: Or probably it's already OK?
[20:25:35] * edsanders ponders
[20:25:41] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Remove broken ve.isMsie() function [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155797 (owner: 10Catrope)
[20:26:21] <edsanders>	 this is the MW blacklist
[20:26:26] <James_F>	 Yeah.
[20:26:34] <grrrit-wm1>	 (03PS3) 10Jforrester: Re-order methods in MWImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155018 (owner: 10Esanders)
[20:26:38] <James_F>	 So we want <figure typeof=…Parsoid…>
[20:26:49] <edsanders>	 any valid image that is pasted will resolve as MW*Image
[20:26:50] <James_F>	 But none of the other <figure>s from the Internet
[20:26:57] <edsanders>	 right
[20:28:15] <edsanders>	 and the blacklist operates on strict equality, not inheritance
[20:28:46] <James_F>	 Does blacklist happen before whitelist?
[20:28:56] <James_F>	 s/whitelist/matching/ or whatever.
[20:29:14] <grrrit-wm1>	 (03CR) 10Jforrester: "PS3 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155018 (owner: 10Esanders)
[20:32:25] <grrrit-wm1>	 (03PS1) 10Catrope: Remove lies about event objects being passed through [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155807 
[20:32:27] <edsanders>	 paste blacklisting happens after conversion
[20:32:43] <grrrit-wm1>	 (03PS1) 10Esanders: Blacklist plain block images from MW paste [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155808 
[20:33:14] <mooeypoo>	 eh can we please do this first before we reorder/touch the MWImageNode code ? :( https://gerrit.wikimedia.org/r/#/c/149217/
[20:33:26] <grrrit-wm1>	 (03PS4) 10Jforrester: Re-order methods in MWImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155018 (owner: 10Esanders)
[20:33:58] <James_F>	 mooeypoo: I can rebase that onto Ed's change; his is trivial (especially now I've corrected it).
[20:34:22] <mooeypoo>	 Eh, okay
[20:34:43] <mooeypoo>	 I think my code just adds two static methods anyways, actually
[20:34:43] <grrrit-wm1>	 (03CR) 10Jforrester: "PS4 changes the order to static methods then non-static methods." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155018 (owner: 10Esanders)
[20:34:48] * James_F nods.
[20:34:50] <mooeypoo>	 so it's a matter --- right
[20:34:52] <mooeypoo>	 :D
[20:34:55] <James_F>	 edsanders: ^^ Could you +1?
[20:34:59] <James_F>	 (Or mooeypoo.)
[20:35:54] <mooeypoo>	 James_F, you mean +2? any reason to just +1 ?
[20:36:02] <grrrit-wm1>	 (03PS1) 10Catrope: Don't apply a background to language annotations in IE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155810 
[20:36:56] <grrrit-wm1>	 (03CR) 10Esanders: [C: 031] Re-order methods in MWImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155018 (owner: 10Esanders)
[20:37:03] <mooeypoo>	 The other bit will be rebased on that one, but this doesn't seem to have dependencies and it's trivial as you said?
[20:37:13] <James_F>	 Eh.
[20:37:30] <James_F>	 Yeah, I just meant that I'd rather not +2 myself given I'd changed Ed's code without someone else OKing it.
[20:37:34] <James_F>	 Feel free to +2. :-)
[20:38:46] <edsanders>	 Are we supposed to be switching over to unquoted key names?
[20:38:49] <grrrit-wm1>	 (03CR) 10Mooeypoo: [C: 032] Re-order methods in MWImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155018 (owner: 10Esanders)
[20:38:56] <James_F>	 edsanders: Yeah, I was going to work on that next.
[20:39:12] <James_F>	 edsanders: It's a boring search-and-replace-and-then-fix-dozens-of-issues change, though.
[20:39:23] <James_F>	 edsanders: (We've done it in all repos except VE-MW at this point.)
[20:39:38] <eranroz>	 Catrope: I met this bug of background causing thing to disappear in IE in some other place. I think there was other option to workaround it, maybe playing with the display
[20:39:49] <RoanKattouw>	 eranroz: Yes, display: inline-block;
[20:39:56] <eranroz>	 ahh yea :)
[20:40:01] <RoanKattouw>	 Unfortunately, if you use that inside contentEditable, it makes the element resizable
[20:40:17] <grrrit-wm1>	 (03PS16) 10Mooeypoo: Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) 
[20:40:30] <mooeypoo>	 omg that worked
[20:40:41] <eranroz>	 ok thanks
[20:40:52] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Re-order methods in MWImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155018 (owner: 10Esanders)
[20:40:55] <James_F>	 mooeypoo: … it did?
[20:41:02] <RoanKattouw>	 I do do this for fixing the position measurement of <sup> tags (if they're not display:inline-block, trying to measure their coordinates will be wrong, it'll tell you it's at the baseline rather than higher up where it really is), but there I can get away with it because I use the measurement to position a click block already, and so the resize handles aren't a problem
[20:41:03] <mooeypoo>	 yea I am looking now
[20:41:06] <mooeypoo>	 and... I think gerrit lies
[20:41:26] <grrrit-wm1>	 (03PS17) 10Mooeypoo: Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) 
[20:41:37] <RoanKattouw>	 (As you can see at the top of that same file, actually)
[20:41:41] <mooeypoo>	 ... now it seemed to work
[20:42:28] <eranroz>	 RoanKattouw: thanks ;)
[20:43:28] <RoanKattouw>	 eranroz: My Microsoft contact tells me both of these bugs will be fixed in the next version of IE though, so that's good :)
[20:47:19] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697#c3 (10Juliusz Gonera) Trying to figure this one out now.  If you set hasFocus to false in ve.ce.Surface#...
[20:50:44] <grrrit-wm1>	 (03CR) 10Esanders: [C: 04-1] "Mostly doc issues." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) (owner: 10Mooeypoo)
[20:51:03] <grrrit-wm1>	 (03CR) 10Esanders: "Mostly doc issues." (0311 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) (owner: 10Mooeypoo)
[20:52:12] <grrrit-wm1>	 (03PS1) 10Jforrester: Switch 'disallowQuotedKeysInObjects' jscs rule on and fix up [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155815 
[20:52:16] <James_F>	 edsanders: ^^^ There you go.
[20:52:30] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697#c4 (10Juliusz Gonera) It's because we call      this.getModel().selectFirstContentOffset();  in ve.ce.Su...
[20:52:40] <James_F>	 edsanders: Just +2851 -2854 ;-)
[20:54:08] <James_F>	 edsanders: If you could review https://gerrit.wikimedia.org/r/#/c/155634/ Roan'd be very grateful.
[20:54:39] <edsanders>	 that's going to be horrible for any patchsets in MW
[20:54:54] <James_F>	 edsanders: I'll rebase, it's trivial to fix.
[20:55:41] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] Don't apply a background to language annotations in IE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155810 (owner: 10Catrope)
[20:57:22] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Don't apply a background to language annotations in IE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155810 (owner: 10Catrope)
[20:57:23] <mooeypoo>	 edsanders, a reference to a string is a string? i.e, if my hash returns the references to variables that hold strings (for instance, "this.alignment" and "this.altText" etc -- if I then change this.alignment = 'something_else' would the hash not change too? (that's why I used 'copy' there)
[20:57:34] <mooeypoo>	 but I seem to remember a string might behave differently
[20:57:40] <edsanders>	 yes
[20:58:16] <mooeypoo>	 I don't need ve.copy there because they're all references to strings? they will change later, that's my worry.
[20:58:24] <edsanders>	 strings are primitive
[20:58:33] <edsanders>	 >>>
[20:58:36] <edsanders>	 >>
[20:58:41] <edsanders>	 ecmabot?
[20:59:24] <edsanders>	 var x = "abc", y = x; x = "def"; y;
[20:59:24] <edsanders>	 "abc"
[20:59:51] <mooeypoo>	 Right, right, okay, that makes sense.
[21:00:00] <RoanKattouw>	 mooeypoo: Only arrays and objects are by reference, strings and numbers and such are always by value
[21:00:26] <RoanKattouw>	 It's actually impossible to pass a string/number by reference in JavaScript <_<
[21:00:45] <mooeypoo>	 Hm, I remembered something, but wasn't sure about strings
[21:01:03] <mooeypoo>	 integers and booleans make more sense
[21:01:19] <mooeypoo>	 for some reason strings don't fit into that in my mind. It seems like they shouldn't.
[21:01:45] <RoanKattouw>	 There are languages where strings are non-primitive, yes
[21:05:41] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] Blacklist plain block images from MW paste [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155808 (owner: 10Esanders)
[21:06:36] <James_F>	 Java, for instance.
[21:06:38] <James_F>	 I think.
[21:06:41] * James_F now isn't sure.
[21:06:47] <edsanders>	 RoanKattouw, 1) ve-ce-LanguageAnnotation should be ve-ce-languageAnnotation
[21:07:01] <edsanders>	 2) why are these IE hacks in MW, they look core?
[21:07:18] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Blacklist plain block images from MW paste [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155808 (owner: 10Esanders)
[21:07:19] <mooeypoo>	 wow, this doesn't even work in javscript with string objects.
[21:07:25] <RoanKattouw>	 edsanders: Sure, but I'm just matching what's already there
[21:07:26] <RoanKattouw>	 (re 1)
[21:07:26] <James_F>	 edsanders: Hysterical Raisins.
[21:07:36] <RoanKattouw>	 Re 2, I guess the latter two are VE core, the former 2 are VE-MW
[21:07:36] <RoanKattouw>	 I could split this up
[21:07:52] <edsanders>	 yup
[21:08:25] <RoanKattouw>	 Right now the way we load IE hacks is through an RL module, which is MW-specific, so that needs to be cleaned up anyway
[21:09:05] <RoanKattouw>	 Both are pre-existing issues though: the class name that was getting a background-color was already cased wrong, and IEHacks.css already contained VE core rules. Would be happy to clean that up in a follow-up commit :)
[21:09:09] <grrrit-wm1>	 (03PS1) 10Esanders: Fix case on language annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155818 
[21:09:18] <RoanKattouw>	 Or you can do it, evidently :P
[21:09:32] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] Fix case on language annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155818 (owner: 10Esanders)
[21:09:38] <grrrit-wm1>	 (03PS2) 10Catrope: Fix case on language annotation CSS class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155818 (owner: 10Esanders)
[21:09:45] <grrrit-wm1>	 (03PS1) 10Esanders: Fix case on language annotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155819 
[21:10:09] <grrrit-wm1>	 (03PS2) 10Catrope: Fix case on language annotation CSS class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155819 (owner: 10Esanders)
[21:10:31] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Fix case on language annotation CSS class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155818 (owner: 10Esanders)
[21:10:36] <edsanders>	 oh wait, all the annotations are broken like this *sigh&
[21:10:40] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Fix case on language annotation CSS class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155819 (owner: 10Esanders)
[21:10:51] <James_F>	 edsanders: Yeah, it's how we've done things before…
[21:11:04] <RoanKattouw>	 I agree with you though edsanders , it should be lowerCamelCase
[21:11:11] <RoanKattouw>	 oo-ui-fooWidget does the same
[21:11:42] <edsanders>	 I don't think it was deliberate, we've not had annotation classes for that long
[21:12:17] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Fix case on language annotation CSS class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155818 (owner: 10Esanders)
[21:17:01] <grrrit-wm1>	 (03PS1) 10Esanders: Fix case in all annotation classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155821 
[21:17:54] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] Fix case in all annotation classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155821 (owner: 10Esanders)
[21:20:01] <grrrit-wm1>	 (03PS1) 10Esanders: Fix case in all annotation classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155822 
[21:20:24] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Fix case in all annotation classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155821 (owner: 10Esanders)
[21:20:32] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697#c5 (10Juliusz Gonera) this.dragging is false because onFocusChange is called after onDocumentMouseUp.  T...
[21:20:35] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Fix case in all annotation classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155822 (owner: 10Esanders)
[21:20:39] <jgonera>	 RoanKattouw_away, see my comments at https://bugzilla.wikimedia.org/show_bug.cgi?id=66697 and let me know if you have any idea what's going on
[21:20:50] <jgonera>	 edsanders too ^
[21:23:07] <grrrit-wm1>	 (03PS2) 10Esanders: Fix case in all annotation classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155822 
[21:23:46] <grrrit-wm1>	 (03Abandoned) 10Esanders: Fix case on language annotation CSS class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155819 (owner: 10Esanders)
[21:24:43] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Fix case in all annotation classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155822 (owner: 10Esanders)
[21:28:14] <grrrit-wm1>	 (03PS3) 10Jforrester: Update VE core submodule to master (c231b71) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155822 (owner: 10Esanders)
[21:29:07] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (c231b71) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155822 (owner: 10Esanders)
[21:29:43] <grrrit-wm1>	 (03PS5) 10Esanders: Create ImageNode mixin to share logic between Block & Inline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155023 
[21:30:48] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (c231b71) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155822 (owner: 10Esanders)
[21:34:26] <RoanKattouw>	 jgonera: Yeah focus is debounced that's why
[21:34:42] <RoanKattouw>	 So if something is checking for this.dragging in focus that's probably wrong?
[21:35:25] <RoanKattouw>	 Also I think selectFirstContentOffset() is only called when the surface is focused but there's no "real" selection. Focusing the surface with your finger in iOS should not satisfy that
[21:35:41] <RoanKattouw>	 But if it does then maybe that's abug
[21:37:21] <grrrit-wm1>	 (03PS6) 10Esanders: Create ImageNode mixin to share logic between Block & Inline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155023 
[21:37:59] <grrrit-wm1>	 (03CR) 10Esanders: Create ImageNode mixin to share logic between Block & Inline (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155023 (owner: 10Esanders)
[21:38:16] <grrrit-wm1>	 (03PS18) 10Mooeypoo: Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) 
[21:39:04] <grrrit-wm1>	 (03PS19) 10Mooeypoo: Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) 
[21:39:06] <grrrit-wm1>	 (03PS10) 10Mooeypoo: [wip] Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) 
[21:39:32] <mooeypoo>	 .... crap
[21:39:46] * mooeypoo sighs
[21:40:09] <mooeypoo>	 okay, so it appears that rebasing the commit on the chain *reverted* my changes in the underlying commit
[21:40:13] <mooeypoo>	 any ideas on how to fix that?
[21:40:47] <mooeypoo>	 https://gerrit.wikimedia.org/r/#/c/149217/18..19/modules/ve-mw/dm/models/ve.dm.MWImageModel.js <-- I need to undo patchset 19
[21:41:23] <mooeypoo>	 RoanKattouw, help
[21:43:06] <RoanKattouw>	 mooeypoo: Looking
[21:43:18] <RoanKattouw>	 You want PS18 back?
[21:43:21] <mooeypoo>	 yes
[21:43:34] <mooeypoo>	 That's the fixes I made as per edsanders' comments
[21:43:46] <mooeypoo>	 then I wanted to rebase the dependent commit, but that reverted those changes :(
[21:43:46] <RoanKattouw>	 PS19 was a rebase?
[21:44:14] <mooeypoo>	 well.. a rebase of that https://gerrit.wikimedia.org/r/#/c/152790/
[21:44:18] <jgonera>	 RoanKattouw, it only checks for focusedNode apart from dragging
[21:44:21] <mooeypoo>	 which also touched the underlying commit, apparently
[21:44:22] <edsanders>	 mooeypoo, is this.boundingbox in MWMediaDialog ever used?
[21:44:35] <jgonera>	 so maybe it's actually a matter of luck that it works on desktop
[21:44:44] <RoanKattouw>	 jgonera: Yeah it might well be
[21:44:52] <RoanKattouw>	 jgonera: What does it to when dragging? Ignore the event?
[21:45:01] <mooeypoo>	 edsanders, not anymore. Did I leave it in the constructor? I did. I'll take it off after we fix the patchset issues
[21:45:09] <grrrit-wm1>	 (03PS20) 10Catrope: Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) (owner: 10Mooeypoo)
[21:45:11] <jgonera>	 no, it simply doesn't call 		this.getModel().selectFirstContentOffset();
[21:45:26] <grrrit-wm1>	 (03CR) 10Catrope: "PS20 restores PS18" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) (owner: 10Mooeypoo)
[21:45:29] <jgonera>	 ve.ce.Surface.js L429 RoanKattouw 
[21:45:58] <RoanKattouw>	 OK yeah that clearly isn't safe to be debounced
[21:46:04] <mooeypoo>	 RoanKattouw, much obliged, but now I don't know how to refactor https://gerrit.wikimedia.org/r/#/c/152790/ properly? what did I do wrong in the previous refactor?
[21:46:07] <mooeypoo>	 errr
[21:46:09] <mooeypoo>	 REBASE.
[21:46:13] <RoanKattouw>	 s/refactor/rebase
[21:46:14] <RoanKattouw>	 Looking
[21:46:36] <grrrit-wm1>	 (03PS21) 10Catrope: Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) (owner: 10Mooeypoo)
[21:46:41] <RoanKattouw>	 mooeypoo: With the rebase button ---^^
[21:46:46] <mooeypoo>	 ... that didn't work before
[21:46:52] <RoanKattouw>	 Weird
[21:46:56] <mooeypoo>	 It's afraid of you.
[21:47:05] <RoanKattouw>	 You can look at the 18..20 diff though, and you'll see that it's empty (apart from Committer changing from you to me)
[21:47:14] * mooeypoo nods
[21:47:16] <mooeypoo>	 just did, yeah
[21:47:20] <mooeypoo>	 that was weird.
[21:47:53] <RoanKattouw>	 Hey edsanders I think you wrote this code that jgonera and I are looking at
[21:48:11] <edsanders>	 'wrote' is a strong word
[21:48:22] <RoanKattouw>	 ve.ce.Surface#onDocumentFocus checks for !this.dragging before calling selectFirstContentOffset()
[21:48:31] <RoanKattouw>	 But onDocumentFocus is called from onFocusChange which is debounced
[21:48:44] <mooeypoo>	 RoanKattouw, err, this isn't rebased, though? still outdated dependency...  https://gerrit.wikimedia.org/r/#/c/152790/
[21:48:44] <RoanKattouw>	 So this.dragging is often not true when it should be
[21:49:03] <RoanKattouw>	 e.g. if you have mousedown, focus, mouseup, then this.dragging is true at the time 'focus' is fired but is false again by the time that code runs
[21:49:13] <jgonera>	 often = (almost?) never on desktop and always on mobile ;)
[21:49:20] <mooeypoo>	 and the button still doesn't work. And 'git rebase master' is what made the underlying commit change last time, so I'm a bit weary of trying that again.
[21:49:29] <RoanKattouw>	 mooeypoo: Right. Download that one and run git rebase --onto 2d61467758001e6569242039b9cd48e4ce8eeddd HEAD^
[21:49:40] <mooeypoo>	 gotcha
[21:49:51] <jgonera>	 yeah, seems like debouncing is more aggressive on mobile
[21:50:00] <RoanKattouw>	 Where 2d6146775 is the hash of the latest patchset of that change
[21:50:24] <edsanders>	 RoanKattouw, hm
[21:50:25] <jgonera>	 RoanKattouw, edsanders why do we debounce the focus handler?
[21:50:28] <RoanKattouw>	 mooeypoo: Most likely you didn't use --onto or used it wrong, and it rebased the older version of 149217 onto master
[21:50:52] <mooeypoo>	 hmmm. Yeah, that makes sense. Usually the button works in these cases.
[21:50:57] <edsanders>	 1. change focus triggers blur & focus at the same time
[21:51:10] <edsanders>	 2. we trigger it on document click as well
[21:51:36] <RoanKattouw>	 document click? or mousedown?
[21:51:46] <jgonera>	 would it break anything if that handler just run more often?
[21:51:48] <RoanKattouw>	 Juliusz is seeing mousedown-focus-mouseup but no click apparently?
[21:52:33] <RoanKattouw>	 mooeypoo: Remember, when there's an outdated dependency involved, you always need --onto
[21:53:18] <mooeypoo>	 what tha heeeelll. Reviewing 152790. Doing 'git rebase --onto 2d61467758001e6569242039b9cd48e4ce8eeddd HEAD^' (I verified that that was patch set 21), and I get "fatal: Needed a single revision
[21:53:18] <mooeypoo>	 Does not point to a valid commit: 2d61467758001e6569242039b9cd48e4ce8eeddd"
[21:53:21] <jgonera>	 RoanKattouw, oh I didn't check for click
[21:53:32] <RoanKattouw>	 mooeypoo: You need to fetch my PS21 first
[21:53:37] <jgonera>	 RoanKattouw, since this.dragging is changed only onMouseDown and onMouseUp
[21:53:54] <mooeypoo>	 oh, I fetched before 21. Ha.
[21:54:03] <RoanKattouw>	 git review -d 149217 , then git review -d 152790 , then try the rebase again
[21:54:08] <RoanKattouw>	 Oh OK
[21:54:27] <RoanKattouw>	 I see no click event being bound though
[21:54:34] <RoanKattouw>	 But edsanders said something about document click
[21:55:01] <RoanKattouw>	 Oh I see
[21:55:13] <RoanKattouw>	 He says we fire focus on document mousedown, and that's true but it's also debounced
[21:55:19] <jgonera>	 anyway, RoanKattouw, removing debouncing for the focus event handler fixes it on mobile
[21:55:34] <RoanKattouw>	 I think that may break other things though?
[21:55:39] <RoanKattouw>	 There was a reason it was made debounced
[21:55:51] <jgonera>	 that's why I'm asking ;)
[21:56:08] <grrrit-wm1>	 (03PS22) 10Mooeypoo: Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) 
[21:56:23] <mooeypoo>	 edsanders, boundingBox gone from MWMediaDialog on that one
[21:57:27] <edsanders>	 RoanKattouw, mousedown yes
[21:57:56] <edsanders>	 so if the handler runs for both blur/focus
[21:57:59] <jgonera>	 interesting, RoanKattouw, edsanders, removing debouncing seems to fix the bug on mobile but introduces it on desktop
[21:58:29] <edsanders>	 there are potential problems with and instant blur-focus happening inside VE
[21:58:41] <edsanders>	 I think before that was causing context menus to close
[21:59:08] <RoanKattouw>	 Right
[21:59:12] <grrrit-wm1>	 (03PS11) 10Mooeypoo: [wip] Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) 
[21:59:18] <mooeypoo>	 There we go.
[21:59:22] <RoanKattouw>	 Yeah and presumably there's a problem when moving the focus from the documentNode to the pasteTarget, too?
[21:59:35] <RoanKattouw>	 Because that'll cause a blur+focus but we shouldn't detect a change at all there
[21:59:45] <jgonera>	 ok, so that's not an option then
[22:00:22] <jgonera>	 is there any other place we can move this 		this.getModel().selectFirstContentOffset(); firefox workaround to?
[22:00:32] <jgonera>	 other than onDocumentFocus
[22:00:53] <RoanKattouw>	 Well the other problem is, it checks for isFocused() first
[22:00:57] <RoanKattouw>	 Somehow that doesn't return true on mobile?
[22:01:37] <RoanKattouw>	 jgonera: Also, hold on, that code is inside ve.ce.Surface.prototype.focus
[22:01:45] <RoanKattouw>	 That means something is trying to programmatically focus the surface?
[22:01:49] <RoanKattouw>	 But that won't work well in iOS
[22:01:50] <jgonera>	 RoanKattouw, it doesn't check isFocused
[22:02:02] <RoanKattouw>	 Oh, sorry, the other one, yes
[22:02:04] <RoanKattouw>	 you're right
[22:02:36] <RoanKattouw>	 The one in onDocumentFocus looks pretty broken
[22:02:42] <RoanKattouw>	 this.dragging will approximately never be true
[22:02:46] <edsanders>	 RoanKattouw, I think pasteTarget was the main problem
[22:03:35] <RoanKattouw>	 So we need a better way of detecting whether the focus came from the mouse/touch or not
[22:04:37] <RoanKattouw>	 Unrelatedly: edsanders, your hasInspector change is causing JS errors
[22:04:41] <RoanKattouw>	 this.availableTools doesn't exist any more
[22:04:53] <RoanKattouw>	 I suppose I should have tested it before merging it
[22:05:54] <RoanKattouw>	 oh hah the property was just made lazy, easy fix
[22:06:34] <edsanders>	 I thought I used the getter...
[22:06:38] <grrrit-wm1>	 (03PS1) 10Catrope: Followup 8c71904: use getter for availableTools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155831 
[22:06:52] <edsanders>	 oops
[22:07:25] <edsanders>	 that's why I wrote a local cache...
[22:07:40] <RoanKattouw>	 oh lol
[22:07:58] <grrrit-wm1>	 (03CR) 10Esanders: [C: 032] "Oops, this is what I meant to write." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155831 (owner: 10Catrope)
[22:09:45] <grrrit-wm1>	 (03CR) 10Catrope: [C: 04-1] Do not focus CE on mobile when editor opens (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155678 (https://bugzilla.wikimedia.org/68832) (owner: 10JGonera)
[22:10:12] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Followup 8c71904: use getter for availableTools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155831 (owner: 10Catrope)
[22:21:32] <wikibugs>	 3MediaWiki / 3ResourceLoader: Gerrit 152122 breaks scripts on Firefox - 10https://bugzilla.wikimedia.org/69924 (10Fomafix) 3NEW p:3Unprio s:3major a:3None https://gerrit.wikimedia.org/r/152122 adds an additional   if(window.mw){...}  around of user scripts. This breaks some scripts in Firefox. Some s...
[22:33:20] <grrrit-wm1>	 (03PS1) 10JGonera: Check for selection in ve.ce.Surface#onDocumentFocus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155839 (https://bugzilla.wikimedia.org/66697) 
[22:33:45] <jgonera>	 RoanKattouw, edsanders|away this seems to work ^ but I'm not entirely sure what I'm doing ;)
[22:43:32] <grrrit-wm1>	 (03CR) 10JGonera: Do not focus CE on mobile when editor opens (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155678 (https://bugzilla.wikimedia.org/68832) (owner: 10JGonera)
[22:43:42] <jgonera>	 RoanKattouw, replied in https://gerrit.wikimedia.org/r/#/c/155678/
[22:48:49] <grrrit-wm1>	 (03PS1) 10Catrope: [WIP] Greylist IE11 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155841 
[22:49:15] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Do not focus CE on mobile when editor opens (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155678 (https://bugzilla.wikimedia.org/68832) (owner: 10JGonera)
[22:51:00] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Do not focus CE on mobile when editor opens [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155678 (https://bugzilla.wikimedia.org/68832) (owner: 10JGonera)
[22:52:45] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10James Forrester) 5PATC>3RESO/FIX
[23:15:33] <wikibugs>	 3VisualEditor: Category suggestions include non-existent and implausible suggestions - 10https://bugzilla.wikimedia.org/69927 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to reporoduce:  1.  Open a page to add a new category.  2.  Type in the beginning of the name:   "1895 es"  3.  Look at t...
[23:39:39] <grrrit-wm1>	 (03PS1) 10JGonera: Add myself to AUTHORS.txt [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155851 
[23:40:27] <grrrit-wm1>	 (03PS1) 10JGonera: Add myself to AUTHORS.txt [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155852 
[23:53:15] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832#c14 (10Rummana Yasmeen) 5RESO/FIX>3REOP Still not working for me.I tried on this page: http://en.m.wikipedia.beta.wmflabs.org/wiki/21staugustchrome  Bu...
[23:53:30] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10Rummana Yasmeen) 5REOP>3ASSI