[00:36:08] (03PS1) 10Rillke: Fix label text in RTL demo listing containing parentheses [oojs/ui] - 10https://gerrit.wikimedia.org/r/156065 [07:38:46] 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c6 (10Michael M.) Why do user scripts have to be enveloped in that if-clause anyway? 1. In most browsers the global mw will be defined before the user script is execu... [07:41:40] hi [07:42:06] why the editu button of a template moved to the button? in the case of long templates it is invisible than [08:18:23] Juandev: please file a bugzilla bug about this [08:19:10] Svetlana: I am afraid, this was changed after someones bug:-( [08:19:27] darn damn christ. wifi. can it please work. [08:22:44] ah. [08:22:54] that is fine, you can file a new bug anyway. [08:59:00] 3MediaWiki / 3ResourceLoader: Remove 'apiScript' from $wgResourceLoaderSources - 10https://bugzilla.wikimedia.org/69878#c1 (10Kunal Mehta (Legoktm)) (In reply to Kunal Mehta (Legoktm) from comment #0) > When $wgResourceLoaderSources was introduced, it required two keys, one for > the load.php location, and a... [09:09:00] Svetlana: done [09:09:55] thanks, I hope it gets through. They're moving all issue tracking over to phabricator at some point and it'll be even easier. [09:10:03] 3VisualEditor / 3ContentEditable: Template edit link to low - 10https://bugzilla.wikimedia.org/69968 (10Juan de Vojníkov) 3NEW p:3Unprio s:3enhanc a:3None Created attachment 16271 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16271&action=edit Edit button/icon to edit the template is not vis... [09:37:01] 3VisualEditor / 3Language: VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking) - 10https://bugzilla.wikimedia.org/33126 (10Amir E. Aharoni) [09:37:06] 3VisualEditor / 3MediaWiki integration: VisualEditor: In the media adding dialog ltr direction is forced on the description field even in rtl wikis - 10https://bugzilla.wikimedia.org/69969 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None To reproduce: 1. Add an image in the Hebrew Wikipedia. 2. T... [12:08:42] mooeypoo: I usually do "?" when I've mentioned something like it before or when I think it's obvious once given an extra look. [12:19:00] 3VisualEditor / 3Editing Tools: VisualEditor: Template dialog search widget wrongly uses suffix ellipsis until input is refocused - 10https://bugzilla.wikimedia.org/67385#c3 (10Krinkle) (In reply to Alex Monk from comment #2) > Timo, could you clarify what's going on here? It sounds as if you're getting > su... [12:19:44] 3VisualEditor / 3Editing Tools: VisualEditor: Template dialog search widget wrongly uses suffix ellipsis until input is refocused - 10https://bugzilla.wikimedia.org/67385#c4 (10Krinkle) Created attachment 16272 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16272&action=edit Screen r [14:45:39] Krinkle, oh, I missed the comment before, then? I am not sure I understood the two last "?"s in there [14:45:50] mooeypoo: link? [14:47:33] https://gerrit.wikimedia.org/r/#/c/134928/23/modules/ext.templateDataGenerator.core.js [14:47:40] #742 and #796 [14:55:49] mooeypoo: hasOwnProperty isn't a safe measure. Either you don't care about hasOwnProperty (why actually? it's a plain object, there's no inheritance), or you use a safe method, via Object.prototype.hasOwnProperty, for hasOwnProperty itself is just as unsafe as any other property. [14:56:38] Krinkle, oh, I wanted to test if the map has the value. I guess I could also do it with map[val] but I actually thought checking 'hasOwnProperty' is safer [14:56:39] (03CR) 10Krinkle: Refactor TemplateData Editor (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [14:56:52] yeah, obj[key] (!|=)== undefined [14:57:00] or Object.proto.hasOwnProperty.call( obj, key) [14:57:06] the current code is confusing. [14:57:08] * mooeypoo nods [14:59:18] * James_F waves. [15:00:40] Krinkle, i'm fixing -- but I want to make sure all's good first. What about line #796 ? [15:01:40] brb [15:21:17] 3MediaWiki / 3Page editing: new section not added on edit conflict - 10https://bugzilla.wikimedia.org/69920#c2 (10Brad Jorsch) The situation of getting an edit conflict when adding a new section is very hard to test, since it generally cannot conflict. But if it does, the user will be given the usual full-pa... [16:23:49] (03CR) 10Esanders: [C: 031] Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) (owner: 10Mooeypoo) [16:25:31] 3VisualEditor / 3ContentEditable: VisualEditor: Breaking words on diacritics - 10https://bugzilla.wikimedia.org/61955 (10Ed Sanders) 5ASSI>3RESO/FIX [16:30:27] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32434741 [16:30:27] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32434803 [16:30:27] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32434827 [16:56:30] 3VisualEditor / 3ContentEditable: VisualEditor: Draw highlights using SVG polygons - 10https://bugzilla.wikimedia.org/51202#c2 (10Ed Sanders) We are now using getBoundingClientRect and getClientRects. The only part missing from this bug is to use SVG. We should investigate the performance benefits/losses of... [16:59:22] (03PS1) 10Catrope: Fix JS error in ce.LanguageAnnotation when dir is set but lang isn't [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156143 (https://bugzilla.wikimedia.org/69955) [17:01:59] mooeypoo: i came to complain :) [17:02:08] aw! [17:02:13] wha about, matanya ? [17:02:22] 57 seconds to save an edit [17:02:31] just fixing a typo [17:02:39] yikes. What article? [17:02:46] הסטוריה של אירופה [17:02:54] היסטוריה [17:03:44] https://he.wikipedia.org/wiki/%D7%94%D7%99%D7%A1%D7%98%D7%95%D7%A8%D7%99%D7%94_%D7%A9%D7%9C_%D7%90%D7%99%D7%A8%D7%95%D7%A4%D7%94 [17:03:44] ? [17:04:32] yes mooeypoo [17:06:59] matanya, hang on one sec, we're in a meeting, we'll check into this. [17:07:11] the article is pretty long. Still, 57 seconds is too long even for a long article. [17:07:14] i'm here, sorry to bother [17:07:22] no bother! [17:07:33] just might be a bit slow in reacting. [17:10:51] 3VisualEditor / 3ContentEditable: VisualEditor: Using browser native interactive spell-check tool adds the missing letters to the DM, but at the top of the page in Chrome - 10https://bugzilla.wikimedia.org/63395#c5 (10Ed Sanders) Can't reproduce in FF or Chrome... [17:16:25] What's the mobile team's irc channel? [17:17:03] mooeypoo: #wikimedia-mobile [17:17:10] awesomesauce, thanks [17:17:17] I tried 'mediawiki-mobile'. bah [17:18:01] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832#c15 (10Juliusz Gonera) We might need to wait unitl https://gerrit.wikimedia.org/r/#/c/155671/ is merged. [17:19:34] matanya, what browser are you using? [17:19:54] (03CR) 10Jforrester: [C: 032] Fix JS error in ce.LanguageAnnotation when dir is set but lang isn't [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156143 (https://bugzilla.wikimedia.org/69955) (owner: 10Catrope) [17:20:34] 3VisualEditor / 3Language: VisualEditor: The article Sindhi language cannot be edited in VE if the Language tool is enabled - 10https://bugzilla.wikimedia.org/69955 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal a:3Roan Kattouw [17:21:32] (03Merged) 10jenkins-bot: Fix JS error in ce.LanguageAnnotation when dir is set but lang isn't [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156143 (https://bugzilla.wikimedia.org/69955) (owner: 10Catrope) [17:23:19] RoanKattouw, hey, so as I just mentioned in the hangout, I'm working on https://bugzilla.wikimedia.org/show_bug.cgi?id=61574 and I made https://gist.github.com/Krenair/3ad594c96d24e87995fc to populate the menu with existing groups [17:23:32] 3VisualEditor / 3ContentEditable: VisualEditor: Using browser native interactive spell-check tool adds the missing letters to the DM, but at the top of the page in Chrome - 10https://bugzilla.wikimedia.org/63395#c6 (10James Forrester) Might this be caused by ancient versions of Firefox/Chrome caused in part... [17:23:54] Is there a better way to do this? [17:24:17] (03CR) 10Jforrester: [C: 032] Fix typo in documentation: "nodes" (pl.) goes wo. article [oojs/ui] - 10https://gerrit.wikimedia.org/r/156063 (owner: 10Rillke) [17:25:07] (03CR) 10Jforrester: [C: 032] Fix label text in RTL demo listing containing parentheses [oojs/ui] - 10https://gerrit.wikimedia.org/r/156065 (owner: 10Rillke) [17:25:11] (03Merged) 10jenkins-bot: Fix typo in documentation: "nodes" (pl.) goes wo. article [oojs/ui] - 10https://gerrit.wikimedia.org/r/156063 (owner: 10Rillke) [17:26:16] (03Merged) 10jenkins-bot: Fix label text in RTL demo listing containing parentheses [oojs/ui] - 10https://gerrit.wikimedia.org/r/156065 (owner: 10Rillke) [17:29:29] edsanders: firefox [17:32:29] Krenair: I feel like there must be some sort of list of groups somewhere in the InternalList object [17:37:01] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832#c18 (10James Forrester) 5PATC>3RESO/FIX Maybe now? [17:39:39] Krenair: Actually Object.keys( this.getFragment().getDocument().getInternalList().getNodeGroups() ) should do it [17:54:08] what the heckity heck heck. [17:54:51] this is so weird. I have a method: 'getNormalizedImageSource()' and all my hashes go through it. And yet, the output comes out as if it didn't. [17:55:59] RoanKattouw, that's just what I was looking for, thanks [17:57:48] (03PS12) 10Mooeypoo: [wip] Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) [17:58:24] (03CR) 10Catrope: [C: 032] Switch 'disallowQuotedKeysInObjects' jscs rule on and fix up [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155815 (owner: 10Jforrester) [18:00:09] (03Merged) 10jenkins-bot: Switch 'disallowQuotedKeysInObjects' jscs rule on and fix up [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155815 (owner: 10Jforrester) [18:02:00] 3VisualEditor / 3ContentEditable: VisualEditor: Using browser native interactive spell-check tool adds the missing letters to the DM, but at the top of the page in Chrome - 10https://bugzilla.wikimedia.org/63395#c7 (10Jared Zimmerman (WMF)) This was happening in new versions of chrome as recently as a month... [18:03:11] RoanKattouw, I guess now I just need to find a way to avoid duplicating this code between ReferenceDialog and ReferencesListDialog [18:11:25] Krenair: Maybe make it a ve.ui.MWReferencesGroupWidget or something/ [18:11:27] ? [18:14:22] RoanKattouw, that contains this ComboBox menu population code and is subclassed by ReferenceDialog and ReferencesListDialog? [18:16:04] I guess it makes sense, the widget appears the same on both dialogs [18:16:06] Well I was thinking a subclass of ComboBox that populates itself from an internallist [18:16:21] oh, right [18:17:44] I'll try that [18:18:58] (03PS7) 10Jforrester: Add a clean-up script for use as a pre-commit hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 [18:19:25] (03Abandoned) 10Jforrester: Don't steal core's 'edit', 'create', 'editsection' by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147737 (https://bugzilla.wikimedia.org/67274) (owner: 10Nemo bis) [18:27:30] (03PS9) 10Jforrester: Show pending state and keep dialog open when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [18:27:47] (03CR) 10Jforrester: "PS9 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [18:29:00] (03PS14) 10Jforrester: Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 [18:29:06] (03CR) 10Jforrester: "PS14 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [18:33:10] (03PS3) 10Jforrester: Move the wrapping checkbox under the alignment buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152054 (https://bugzilla.wikimedia.org/69164) (owner: 10Amire80) [18:33:27] (03CR) 10Jforrester: [C: 04-1] "PS3 is a rebase. Still have reservations." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152054 (https://bugzilla.wikimedia.org/69164) (owner: 10Amire80) [18:33:34] (03PS9) 10Jforrester: Make it possible to create autonumbered external links from link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) (owner: 10Bartosz Dziewoński) [18:35:07] (03PS10) 10Jforrester: Make it possible to create autonumbered external links from link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) (owner: 10Bartosz Dziewoński) [18:35:15] (03CR) 10Jforrester: "PS10 updates to new coding style." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) (owner: 10Bartosz Dziewoński) [18:35:27] (03PS3) 10Jforrester: Emit an error if VE Target fails to load, so users aren't left entirely stranded [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155177 [18:36:09] hmm, i need to finish up that patch. [18:37:54] (03PS2) 10Jforrester: Remove "Options" tool from hamburger menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153737 (https://bugzilla.wikimedia.org/69451) (owner: 10Catrope) [18:38:10] (03CR) 10Jforrester: [C: 04-1] "PS2 is a rebase. Still needs discussion." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153737 (https://bugzilla.wikimedia.org/69451) (owner: 10Catrope) [18:38:19] (03PS1) 10Alex Monk: Use combo box widget to suggest existing values for reference group [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156160 (https://bugzilla.wikimedia.org/61574) [18:38:25] (03CR) 10jenkins-bot: [V: 04-1] Use combo box widget to suggest existing values for reference group [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156160 (https://bugzilla.wikimedia.org/61574) (owner: 10Alex Monk) [18:40:10] (03PS3) 10Jforrester: Provide a checkbox on template page of transclusion dialog to substitute when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153934 (https://bugzilla.wikimedia.org/49904) (owner: 10Alex Monk) [18:40:44] (03CR) 10Jforrester: [C: 04-2] "PS3 is a rebase. Still blocked on Parsoid support / resolution of direction of travel." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153934 (https://bugzilla.wikimedia.org/49904) (owner: 10Alex Monk) [18:41:11] (03PS2) 10Alex Monk: Use combo box widget to suggest existing values for reference group [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156160 (https://bugzilla.wikimedia.org/61574) [18:41:17] (03PS5) 10Jforrester: Remove delete button from required parameters in template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154133 (https://bugzilla.wikimedia.org/60358) (owner: 10Alex Monk) [18:41:56] (03CR) 10jenkins-bot: [V: 04-1] Provide a checkbox on template page of transclusion dialog to substitute when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153934 (https://bugzilla.wikimedia.org/49904) (owner: 10Alex Monk) [18:42:28] (03PS3) 10Alex Monk: Use combo box widget to suggest existing values for reference group [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156160 (https://bugzilla.wikimedia.org/61574) [18:47:21] (03PS4) 10Alex Monk: Provide a checkbox on template page of transclusion dialog to substitute when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153934 (https://bugzilla.wikimedia.org/49904) [18:47:43] (03PS23) 10Jforrester: Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) (owner: 10Mooeypoo) [18:47:52] (03CR) 10Jforrester: "PS23 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) (owner: 10Mooeypoo) [18:50:23] (03PS1) 10Divec: Check IMEs actually fail as expected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156161 [18:53:27] (03CR) 10Trevor Parscal: [C: 032] Tweak behaviour to match description in demos [oojs/ui] - 10https://gerrit.wikimedia.org/r/156062 (owner: 10Rillke) [18:54:27] (03Merged) 10jenkins-bot: Tweak behaviour to match description in demos [oojs/ui] - 10https://gerrit.wikimedia.org/r/156062 (owner: 10Rillke) [18:56:27] (03PS2) 10Divec: Check IME simulations actually fail as expected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156161 [19:14:24] (03CR) 10Catrope: [C: 04-1] Blur contentEditable node while destroying surface. (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144089 (owner: 10Inez) [19:16:23] (03CR) 10Catrope: [C: 032] Update oo#compare usages [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155545 (owner: 10Esanders) [19:17:24] (03CR) 10Catrope: "This may also need to check if there is a selection but it's at a non-content offset? Ed?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155839 (https://bugzilla.wikimedia.org/66697) (owner: 10JGonera) [19:18:14] (03Merged) 10jenkins-bot: Update oo#compare usages [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155545 (owner: 10Esanders) [19:31:49] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832#c19 (10Rummana Yasmeen) 5RESO/FIX>3REOP The issue got resolved for the aforementioned steps , but still it is occurring for the following case 1.Open... [19:32:04] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10Rummana Yasmeen) 5REOP>3ASSI [19:51:04] Why ve.dm.MWTransclusionModel is entirely within a closure? [19:51:52] Oh, I think I know why: do have specCache [20:16:52] 3VisualEditor / 3Editing Tools: VisualEditor: Getting stuck in the Media Settings dialog after changing the image position as it is throwing TypeError: Cannot read property 'length' of null - 10https://bugzilla.wikimedia.org/69988 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduc... [20:30:37] 3VisualEditor / 3ContentEditable: VisualEditor: Using browser native interactive spell-check tool adds the missing letters to the DM, but at the top of the page in Chrome - 10https://bugzilla.wikimedia.org/63395#c8 (10NicoV) According to a post on frwiki VE feedback page: If you look at abuse filter 216, pr... [20:44:42] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot open Math inspector ,TypeError: Cannot read property 'length' of null appears in the console - 10https://bugzilla.wikimedia.org/69991 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16276 --> https://bugzilla.wikimedia.org... [20:46:41] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19]Cannot open Math inspector ,TypeError: Cannot read property 'length' of null appears in the console - 10https://bugzilla.wikimedia.org/69991 (10Rummana Yasmeen) [20:51:45] Sigh, I ran into this again: TypeError: undefined is not a function↵ at Object. (http://localhost/MediaWiki/Git/extensions/VisualEditor/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js:34:19) [20:52:37] wtf, but that code is run from the done() callback of a promise that's resolved when ext.visualEditor.viewPageTarget has loaded [20:53:48] yep. [20:53:56] Only happens with debug=true [20:54:52] Ooh [20:54:56] I hope that we don't still have THAT bug [20:55:25] I might be running something old [20:55:35] But I did update MW core, VE and ran git submodule update [20:58:42] I mean, I wonder if ResourceLoader still has the bug where things are resolved too early in debug mode [20:59:42] I ran into this once before, I think on my laptop [20:59:51] I did... something, and it was fixed. [21:00:03] I think it was just updating repositories like I just tried :/ [21:08:21] * mooeypoo mutters incoherently [21:10:00] Why you be so difficult, Javascript? [21:11:14] James_F, edsanders|away any reason this is +1'ed and not +2'ed? https://gerrit.wikimedia.org/r/#/c/149217/22 [21:11:21] what's it waiting for? am I missing something? [21:12:16] mooeypoo: I didn't want to +2 if edsanders|away had +1'ed for a reason. [21:12:28] * mooeypoo nods [21:12:42] I'm trying to see what the reason was. I'll wait 'till he wakes up. [21:13:01] My sister managed to score cheap broadway show tickets for tonight \o/ [21:13:08] so I'll see if he's up when we get back [21:16:46] (03PS13) 10Mooeypoo: [wip] Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) [21:16:46] * James_F grins. [21:17:27] We're going to try and score more cheap tickets with the raffle tomorrow. I realized I need to be a tourist in NYC for a little bit and get everything I didn't do for a while done before I move! [21:19:31] ... did we change anything in context lately? [21:19:38] * James_F grins. [21:19:43] Erm. Don't think so? [21:20:11] Oh, wait, yes. [21:20:26] Ed re-introduced the concept of embedded context that Trevor broke in the re-write. [21:20:49] The bug rummana reported earlier (https://bugzilla.wikimedia.org/show_bug.cgi?id=69988) throws an error specifically for 'thumb' with center -- on the context. WTF. And everything else seems to work (including setting left/right to frameless/basic images) [21:21:22] it breaks on counting "availableTools" in "context.prototype.hasInspector" [21:22:08] oh, happened now again with 'basic/center' too. That's pretty evil. [21:22:29] Fun. [21:27:58] (03PS1) 10Mooeypoo: Validate availableTools before loop in Context's 'hasInspector' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156192 (https://bugzilla.wikimedia.org/69988) [21:28:05] James_F, ^^ that fixes it. [21:35:10] mooeypoo: WTF I fixed that exact same thing somewhere else too [21:35:47] Ha. [21:36:04] Direct access considered harmful. [21:36:30] (03CR) 10Jforrester: [C: 031] Validate availableTools before loop in Context's 'hasInspector' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156192 (https://bugzilla.wikimedia.org/69988) (owner: 10Mooeypoo) [21:37:57] RoanKattouw, hm. If only we could grepped for that.. [21:38:00] (can we?!) [21:38:11] (03PS2) 10Catrope: Followup bbff57b, 8c71904: use getter for availableTools, again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156192 (https://bugzilla.wikimedia.org/69988) (owner: 10Mooeypoo) [21:38:16] I fear regex now. [21:38:40] oh you mean only availableTools specifically [21:38:59] (03CR) 10Jforrester: Check IME simulations actually fail as expected (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156161 (owner: 10Divec) [21:39:15] (03CR) 10Catrope: [C: 032] Followup bbff57b, 8c71904: use getter for availableTools, again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156192 (https://bugzilla.wikimedia.org/69988) (owner: 10Mooeypoo) [21:39:30] I grepped and only found that one direct use of availableTools [21:40:26] Yeah, I thought you mean getters instead of this.variables in general [21:40:32] which would've been awesome if we could grep for [21:40:51] Oh yeah no that's pretty hard [21:40:54] (03Merged) 10jenkins-bot: Followup bbff57b, 8c71904: use getter for availableTools, again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156192 (https://bugzilla.wikimedia.org/69988) (owner: 10Mooeypoo) [21:40:54] but would require some creative regex. All "this.* without () at the end" [21:41:26] Well and direct property access on this. is usually OK [21:41:33] Except this particular property is lazy-computed [21:41:52] Direct property access on other objects is generally frowned upon, but is sometimes OK, especially if the property name starts with $ [21:42:20] Yeah [21:42:27] Well, we can add that to the regex. [21:42:33] We all know how awesome regex is. [21:42:39] ... [21:43:19] speaking of regexps, when/if you have a moment, I could use another pair of eyes on a REALLY weird bug i have where my method runs but is not being applied (whaaat?) [21:45:22] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/152790/13/modules/ve-mw/dm/models/ve.dm.MWImageModel.js <-- "normalizedSource" in the hash (line 202) always sends the source through normalization. You would think that this would mean every time I do "getHashObject" I get a normalized source. And yet, I get the long non-replaced non-regexp'ed source in the initial hash case, and I don't get why. it makes no sense. [21:46:30] mooeypoo: LOLOL at /img as your regex modifiers [21:47:03] I know, right? [21:47:04] :D [21:47:08] mooeypoo: What's up with the >1 there? If matches.length === 1 do you not want to strip the extension? [21:47:12] no [21:47:18] I just want to strip it in cases where it appears twice [21:47:43] hang on, I'll give you an example of how I get it from the api [21:47:50] the search select sends a resize version [21:48:17] Oh because of the thumb url thing [21:48:18] ? [21:48:23] Also your URL prefix thing seems scary [21:48:39] It should be anchored [21:48:51] Like /^.*?:\/\// [21:49:03] And then you also don't need to apply /g because it won't match more than once [21:49:33] Also note that you may receive protocol-relative URLs like "//upload.wikimedia.org" where there is no colon [21:49:59] Aye, I normalize all URLS to that [21:50:07] so anything:// will be // [21:50:22] Also also, I think that this thing with trying to normalize the thumb url in the way that you're doing it shouldn't be necessary, you should be able to get the real image URL from the API [21:50:42] RoanKattouw, but I am getting this type of URL from the api: http://upload.wikimedia.org/wikipedia/commons/thumb/0/0f/Main_page_commons.jpg/282px-Main_page_commons.jpg [21:50:48] which means I want to check if .jpg appears twice [21:51:03] if it does, then strip it from the first occurence, so you get this: http://upload.wikimedia.org/wikipedia/commons/thumb/0/0f/Main_page_commons.jpg [21:51:11] Well, what I'm saying is, that's the thumburl, and I think you should be able to get both URLs from the API at the same time [21:51:21] and then take off the protocol, and get //upload.wikimedia.org/wikipedia/commons/thumb/0/0f/Main_page_commons.jpg [21:51:28] hm [21:51:58] I changed that, though, from thumburl to url [21:52:05] Yeah, see [21:52:07] I still got multi parts... [21:52:12] You're using .thumburl and you could grab .url instead [21:52:23] I thought I did. I swear I changed that... wtf. [21:52:27] For display you want to use .thumburl [21:52:38] But for any real purposes you probably want .url [21:53:01] I don't really need display for now at all (until we'll have preview, at least) [21:53:08] so I changed that.. it must've reverted in one of the refactors [21:53:22] This is actually pretty funny. [21:53:33] I've created this whole normalizing method because I changed the .url [21:53:38] and apparently didn't. [21:54:32] Yes. Well. That fixed everything. [21:56:39] hm, I still need to 'normalize' for the protocol [21:57:48] RoanKattouw, I'll still have to have a 'normalizeSource' method; since by using "url" instead of "thumburl" I will *probably* not need to strip that second piece again, should I leave the whole erase-double-image routine for the cases where resized images pop up or just leave the piece about taking off the protocol [21:58:00] IE, be defensive, or trust the system? [21:58:06] (sorry, "i.e") [21:58:32] (03CR) 10Catrope: [C: 04-1] "Some visual / interaction problems:" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156160 (https://bugzilla.wikimedia.org/61574) (owner: 10Alex Monk) [21:58:53] I recommend keeping it out [21:58:59] Because it doesn't seem very robust anyway [21:59:16] removing /img ? [21:59:16] Also if at this point all you're doing is protocol-normalization, we have utils for that [21:59:18] aww. [21:59:21] aww :) [21:59:28] Oh, do we? [21:59:40] That seems to be all I need now (removing the protocol) [21:59:55] But you want to normalize towards protocol-relative? [21:59:59] since sometimes the image appears //commons... and from the search widget it has http://commons... [22:00:05] Or do you just want to normalize to something and you don't really care what it is? [22:00:12] I don't care what it is [22:00:17] I want to see if the rest of the url is the same [22:00:26] could be https:// or http:// or just // [22:00:35] that's why I just stripped it [22:00:41] OK, in that case, use ve.resolveUrl() with the base parameter set to the dm.Document's .getHtmlDocument() [22:00:51] That's what we do for link hrefs too [22:01:40] getHtmlDocument() ? [22:01:55] why? I don't need to get the document, it's an image. [22:02:20] It's not yet attached to the document [22:06:12] RoanKattouw, the imageModel is not attached to a document [22:06:13] which document do I use? [22:06:17] (03CR) 10Catrope: Check IME simulations actually fail as expected (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156161 (owner: 10Divec) [22:06:21] I could just use a base string, but I'm not sure I understand ve.resolveUrl documentation. What does it mean "base url" ? [22:06:27] http://something.com --> so we can evaluate /blah as "http://something.com/blah" ? if that's the case, shouldn't I use base url as an empty string, since all the URLs from the API are external ? [22:08:56] mooeypoo: If you specify a string for the base URL, that's expensive. We prefer passing an HTMLDocument [22:09:13] That means it uses that document's base URL, which will typically be something like http://en.wikipedia.org/wiki/Foo or whatever [22:09:26] RoanKattouw, so, if I need to send a document, and that code seems to create a doc and all that -- shouldn't I just stick to my "strip everything before the ://" method? [22:09:29] it's so much simpler? [22:09:46] So yes /blah gets resolved to "http://en.wikipedia.org/wiki/blah", but protocol-relative URLs also get resolved to HTTP [22:10:05] mooeypoo: Well we already have an HTMLDocument lying around in DM, you can use that one, then ve.resolveUrl won't have to expensively create a one-off one [22:10:18] And also, it would mean I have to pass a document since the image model is independent [22:11:02] RoanKattouw, I don't have a way to get a document for the moment unless I actively tell the dialog to attach a document ot the model [22:11:19] which, if done solely for this purpose, sounds a bit backwards, no? [22:11:19] Oh, ugh [22:11:28] Right, you don't have a document [22:11:40] Can I just stick to stripping the protocol? [22:11:47] or is that dangerous? [22:11:48] Yes, let's just do that then [22:12:01] With something like .replace( /^https?:\/\//, '//' ) [22:12:37] .replace( /.*?:\/\//g, '//' ); <-- this hsould replace all protocols [22:12:46] but I can stick to https? if you want [22:12:58] That would worry me less, yeah [22:13:16] If you're gonna strip all protocols, at least anchor the regex with ^ and make it non-/g [22:13:16] .replace( /.https?:\/\//g, '//' ); ? [22:13:22] oh [22:13:45] Hence my .replace( /^https?:\/\//, '//' ) [22:14:17] yup [22:14:20] ^ asserts the start of the string, at which point /g is unnecessary because that tells it to try to apply it multiple times, which since it's anchored cannot happen [22:14:41] I didn't think about that. Also, the above still has the dot (not good!) so yes. I replaced with yours. [22:15:28] (03PS14) 10Mooeypoo: [wip] Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) [22:15:31] woot [22:15:47] oh, I forgot to take off the [wip] on that one. [22:15:58] (03PS15) 10Mooeypoo: Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) [22:17:03] w00t. [22:17:06] thanks RoanKattouw ! [22:17:43] (03CR) 10jenkins-bot: [V: 04-1] Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) (owner: 10Mooeypoo) [22:17:51] ... seriously, jenkins? [22:17:55] party pooper. [22:18:18] ... I GRUNTED! [22:18:28] damnit. [22:19:24] (03PS16) 10Mooeypoo: Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) [22:20:19] (03PS25) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) [22:33:22] (03CR) 10Catrope: [C: 032] Check IME simulations actually fail as expected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156161 (owner: 10Divec) [22:35:01] (03Merged) 10jenkins-bot: Check IME simulations actually fail as expected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156161 (owner: 10Divec) [22:36:07] (03CR) 10Catrope: [C: 04-1] Show pending state and keep dialog open when switching to source mode (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [22:37:45] (03CR) 10Catrope: [C: 04-1] Remove delete button from required parameters in template dialog (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154133 (https://bugzilla.wikimedia.org/60358) (owner: 10Alex Monk) [22:57:09] 3VisualEditor: VisualEditor: Selection overlaps menu, so you can't click on the covered items - 10https://bugzilla.wikimedia.org/69949#c1 (10WhatamIdoing) This appears to only happen if you are at the top of the page. If you scroll down at all, then it works correctly. [23:01:17] 3VisualEditor: VisualEditor: Hung while trying to save - 10https://bugzilla.wikimedia.org/70010 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None This edit was actually saved, but it seemed like it wouldn't be at the time: https://en.wikipedia.org/w/index.php?title=Integrated_circuit&diff=622517186&o... [23:01:54] 3VisualEditor: VisualEditor: Hung while trying to save - 10https://bugzilla.wikimedia.org/70010 (10WhatamIdoing) 5NEW>3UNCO [23:18:26] 3VisualEditor: VisualEdior: {{#tag:ref}} is not processed by VisualEditor, so the references list claims that there are no refs in that group - 10https://bugzilla.wikimedia.org/70011 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None This may be related to bug 51289 and bug 61777. Steps to reproduce:... [23:30:56] 3VisualEditor / 3Editing Tools: VisualEditor: Category names are taking long time (~6-7 secs)to appear in the Category section - 10https://bugzilla.wikimedia.org/70012 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Add some categories to the page 3.... [23:32:31] (03PS1) 10Trevor Parscal: Divide CSS properties between base styles and themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/156211 [23:32:47] (03PS2) 10Trevor Parscal: Divide CSS properties between base styles and themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/156211 [23:34:34] ryasmeen: beta labs has a big performance problem right now because of HHVM. I noticed a lot of recent bugs are about slowness. [23:35:15] chrismcmahon: Oh! yeah thats what I thought. [23:36:14] ryasmeen: it was fixed for a little while mid-day today, but we triggered the problem again a few hours later. Ori is looking into the root cause right now. [23:37:01] chrismcmahon:Alright. Thanks for letting me know of it. [23:52:07] ryasmeen: beta should be normal now [23:55:17] okay chrismcmahon, yeah the bug about categories not appearing was due to that issue, now it seems alright [23:55:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] Getting stuck in the Media Settings dialog after changing the image position as it is throwing TypeError: Cannot read property 'length' of null - 10https://bugzilla.wikimedia.org/69988 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3H... [23:56:55] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] Cannot open Math inspector ,TypeError: Cannot read property 'length' of null appears in the console - 10https://bugzilla.wikimedia.org/69991#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3High s:5normal>3major a:3Ed Sanders... [23:57:09] 3VisualEditor / 3Editing Tools: VisualEditor: Category names are taking long time (~6-7 secs)to appear in the Category section - 10https://bugzilla.wikimedia.org/70012#c1 (10Rummana Yasmeen) 5NEW>3RESO/FIX This was happening because of HHVM issue. Now it is working fine. [23:58:54] 3VisualEditor / 3ContentEditable: VisualEditor: Using browser native interactive spell-check tool adds the missing letters to the DM, but at the top of the page in Chrome - 10https://bugzilla.wikimedia.org/63395#c9 (10James Forrester) 5ASSI>3RESO/FIX In that case, marking as FIXED in that release. Unsati...