[00:07:30] TrevorParscal: You want to add "cleancss: true," to Gruntfile.js's options section for less. [00:07:50] TrevorParscal: This will also minify the CSS, which is a little sucky, but it's not really meant for humans anyway by this point. [00:07:51] awesome [00:07:59] Told you there was an option. ;-) [00:08:00] it's part of dist [00:08:21] Yeah, but we use it vanilla in VE… [00:08:23] * James_F shrugs. [00:08:27] I'll live. :-) [00:08:35] Timo might not, though. :-D [00:09:54] 3VisualEditor / 3ContentEditable: VisualEditor: Open button in link inspector should be disabled when the link target field is empty - 10https://bugzilla.wikimedia.org/70015#c1 (10Rummana Yasmeen) Right now, when you open link inspector and keep the link target field empty, you will still be able to click on... [00:14:56] 3VisualEditor / 3Editing Tools: VisualEditor:Shrink back the Basic Reference dialog size - 10https://bugzilla.wikimedia.org/70016 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16278 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16278&action=edit Reference dialog in... [00:15:09] 3VisualEditor / 3Editing Tools: VisualEditor:Shrink back the Basic Reference dialog size - 10https://bugzilla.wikimedia.org/70016#c1 (10Rummana Yasmeen) Created attachment 16279 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16279&action=edit Reference dialog in production [00:23:56] 3VisualEditor / 3Editing Tools: VisualEditor: Open button in link inspector should be disabled when the link target field is empty - 10https://bugzilla.wikimedia.org/70015 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3minor a:3Alex Monk [00:31:04] (03PS4) 10Alex Monk: Use combo box widget to suggest existing values for reference group [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156160 (https://bugzilla.wikimedia.org/61574) [00:32:09] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] Cannot open Math inspector , TypeError: Cannot read property 'length' of null appears in the console - 10https://bugzilla.wikimedia.org/69991#c2 (10Rummana Yasmeen) 5RESO/FIX>3REOP This is still occurring in Betalabs while trying to ope... [00:32:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] Cannot open Math inspector , TypeError: Cannot read property 'length' of null appears in the console - 10https://bugzilla.wikimedia.org/69991 (10Rummana Yasmeen) 5REOP>3ASSI [00:32:50] (03CR) 10jenkins-bot: [V: 04-1] Use combo box widget to suggest existing values for reference group [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156160 (https://bugzilla.wikimedia.org/61574) (owner: 10Alex Monk) [00:32:54] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] Cannot open Math inspector on a slug – TypeError: Cannot read property 'length' of null appears in the console - 10https://bugzilla.wikimedia.org/69991 (10James Forrester) [00:33:03] (03CR) 10Alex Monk: "#3 looks like something that should be considered in OO.ui.ComboBoxWidget. I'm not sure what the point in having the indicator arrow would" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156160 (https://bugzilla.wikimedia.org/61574) (owner: 10Alex Monk) [00:33:34] (03PS5) 10Alex Monk: Use combo box widget to suggest existing values for reference group [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156160 (https://bugzilla.wikimedia.org/61574) [00:35:55] 3VisualEditor / 3Editing Tools: VisualEditor: Category names are taking long time (~6-7 secs)to appear in the Category section - 10https://bugzilla.wikimedia.org/70012 (10James Forrester) p:5Unprio>3Normal [00:37:56] 3VisualEditor / 3Editing Tools: VisualEditor:Shrink back the Basic Reference dialog size - 10https://bugzilla.wikimedia.org/70016 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3trivia a:3Alex Monk [00:40:01] (03PS6) 10Alex Monk: Remove delete button from required parameters in template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154133 (https://bugzilla.wikimedia.org/60358) [03:04:39] 3MediaWiki extensions / 3WikiEditor: "Show edit toolbar" preference is confusing - 10https://bugzilla.wikimedia.org/30795 (10Helder) [03:07:24] 3MediaWiki / 3ResourceLoader: Sporadic and unpredictable updating of (classic) toolbar via JS - 10https://bugzilla.wikimedia.org/31511 (10Helder) [03:16:54] 3MediaWiki / 3Page editing: [Regression] Dynamically added textarea within the editform no longer work in the classic edit toolbar - 10https://bugzilla.wikimedia.org/39268 (10Helder) [03:28:09] 3MediaWiki / 3Page editing: [Regression] Dynamically added textarea within the editform no longer work in the classic edit toolbar - 10https://bugzilla.wikimedia.org/39268#c26 (10Helder) I believe this was fixed by change Id9469f9dfcbb92854780c63252cd9c5069e94487. See also LQT bug 41220. [03:40:53] 3MediaWiki extensions / 3WikiEditor: There's no easy way to configure the buttons in the enhanced toolbar - 10https://bugzilla.wikimedia.org/23624 (10Helder) [03:44:23] 3MediaWiki extensions / 3WikiEditor: There's no easy way to configure the buttons in the enhanced toolbar - 10https://bugzilla.wikimedia.org/23624 (10Helder) [07:50:39] 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c7 (10Erik Moeller) Michael, if common.js is non-blank, this will lead to site-wide errors in IE6 (and other disabled browsers). That was one of the motivations for Ti... [08:06:48] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153934 (https://bugzilla.wikimedia.org/49904) (owner: 10Alex Monk) [08:26:09] 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c8 (10Andre Klapper) Another example: https://de.wikipedia.org/w/index.php?title=Wikipedia:Technik/Werkstatt&oldid=133432119#.C3.84nderung_im_Javascript.3F [08:29:54] 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c9 (10Michael M.) (In reply to Erik Moeller from comment #7) > Michael, if common.js is non-blank, this will lead to site-wide errors in > IE6 (and other disabled brow... [09:07:41] 3VisualEditor / 3Editing Tools: Category suggestion lists no longer existing categories - 10https://bugzilla.wikimedia.org/70025 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None Take this query from the suggester: https://en.wikipedia.org/w/api.php?format=jsonfm&uselang=en&action=query&list=all... [09:25:57] (03PS1) 10TheDJ: Categories: Don't suggest empty or old categories [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156250 (https://bugzilla.wikimedia.org/70025) [09:35:39] 3VisualEditor: VisualEditor: {{#tag:ref}} is not processed by VisualEditor, so the references list claims that there are no refs in that group - 10https://bugzilla.wikimedia.org/70011 (10Andre Klapper) [10:17:24] 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c10 (10Michael M.) As actually nobody explicitly quoted the relevant standards yet: * ECMAScript defines FunctionDecleration and FunctionExpression. (http://ecma-inte... [12:59:19] (03CR) 10Esanders: "It's a transition from 10px to 15px height, it's not as important as the issues this fixes." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [13:26:15] Hi guys need some help with fresh installation . [13:26:37] I just installed mediawiki 1.23.2 and downloaded VE from the REL1_23 branch . [13:26:49] I wonder from where i should download parsoid to have the correct version for this setup ? [13:35:00] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [13:39:27] Anyone? i need help how to get branch of REL1_23 of parsoid . [14:35:45] (03PS26) 10Krinkle: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [14:37:17] (03CR) 10Krinkle: "A few more comments. All except for the default/case-default were fixed by me in the next patch set." (038 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [14:38:55] (03CR) 10Krinkle: "I've updated jshintrc to fix the broken es3 setting. It was setting es5:false but in recent versions, JSHint removed es5:false and instead" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [14:39:26] agepox: What have you tried so far? [14:39:50] Both the download snapshot link on https://www.mediawiki.org/wiki/Extension:Parsoid as well as the Git repositories have a 23 branch. [14:39:58] https://www.mediawiki.org/wiki/Special:ExtensionDistributor/Parsoid [14:40:12] https://github.com/wikimedia/mediawiki-extensions-Parsoid/tree/REL1_23 [14:44:59] Thanks Krinkle. [14:47:15] Hi Krinkle, this is the extension, i'm talking about hte parsoid node js service itself. [14:48:31] agepox: can you use git? [14:49:35] https://www.mediawiki.org/wiki/Extension:Parsoid links to https://www.mediawiki.org/wiki/Parsoid where you can download the nodejs service [14:49:49] https://github.com/wikimedia/mediawiki-extensions-Parsoid/tree/REL1_23#readme also contains git clone urls [14:50:38] I don't think the nodejs service is branches by MW version [14:50:43] That is, it isn't. [14:51:04] agepox: Have you tried using the latest version of the parsoid nodejs service? [14:51:29] I don't work on it myself, but I imagine there aren't any incompatibilities between Parsoid's nodejs service and MEdiaWiki core 1.23/1.24 [14:51:40] git clone https://gerrit.wikimedia.org/r/p/mediawiki/services/parsoid [15:05:59] Thanks Krinkle, I'll try to work with that. [15:12:23] (03CR) 10Krinkle: [C: 04-1] "OK. So done with the code (except for that question about the default switch case). Reviewing import and param order now." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [15:15:42] Krinkle|detached, agepox: the Parsoid service has a stable REST API, so is pretty much independent of the MediaWiki version [15:29:52] (03CR) 10Mooeypoo: "One quick comment regarding default case and case 'default'" (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [15:33:14] (03CR) 10Jforrester: Refactor TemplateData Editor (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [15:35:49] parsoid q: Can't get the app to start with "node parsoid/api/server.js" [15:36:38] hexmode: more details pelase [15:36:42] please [15:37:46] hexmode, cd parsoid; node api/server.js ? [15:38:17] 1s [15:38:22] oh, no it should apparently work from outside parsoid as well. never mind [15:38:40] hexmode, do you get some error? [15:38:48] http://pastebin.com/6GDv5KQ6 [15:39:08] did you run npm install? and it finished without errors? [15:39:19] 4.8.5 of node-express [15:39:40] trying to create RPMs for installation [15:39:51] but now I'll try npm install to check [15:39:55] 1m [15:42:03] gah ... "you are sitting in a directory with infinitely many node_modules subdirectories" [15:43:18] so npm install works, but this is not what I want(TM) [15:43:28] hrm... [15:44:02] (03CR) 10Jforrester: "Slugs are the number one UX complaint right now. Breaking their behaviour (which we've barely managed to convince people is special even n" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [15:45:19] looks like I need to downgrade nodejs express [15:47:10] 3VisualEditor / 3Editing Tools: VisualEditor: Category suggestion lists no longer existing categories - 10https://bugzilla.wikimedia.org/70025 (10James Forrester) p:5Unprio>3Normal s:5normal>3minor a:3Derk-Jan Hartman [15:47:56] (03CR) 10Jforrester: "It feels like we're worried about categories that aren't used any more, but are also throwing out categories that aren't used /yet/ – mayb" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156250 (https://bugzilla.wikimedia.org/70025) (owner: 10TheDJ) [15:52:32] hexmode: the parsoid package is built from the deploy repository [15:52:45] which already includes a tested checkout of all dependencies for amd64 [15:53:15] it might make sense to build the rpm from the same repo [15:54:26] Yeah, this is going to require multiple rpms -- working on making this upstreamable [15:54:58] and upstream has later version of express packaged [15:55:13] afaik that won't be compatible [15:55:24] it isn't [15:55:27] :/ [15:55:47] so I'm packaging up the compatible express package\ [15:55:56] and naming it nodejs-express2 [15:56:18] we just package our exact depencies within the parsoid package [15:56:35] *dependencies [15:56:51] I understand, but that isn't how upstream wants it [15:57:06] upstream -> Fedora people [15:57:23] of course, I'm just looking at what they've done and their docs [15:57:32] well, do they have a sane way to support multiple versions of a npm package installed in parallel? [15:57:42] no clue [15:57:58] our code still does a require('express') [15:58:07] But I am going to give myself less pain for now [15:58:20] so unless you want to rewrite the code you might have to play tricks with NODE_PATH or something [15:58:23] and package up the result of "npm install" [15:58:40] * hexmode is changing tactics [15:58:47] incrementalism! [15:58:54] in that case you can just use the deploy repo [15:59:08] I keep trying to boil the ocean... need to stop doing that. [15:59:50] yeah, we also went for the easy route for now [16:00:19] the html5 dependency was also just updated, and afaik doesn't require jsdom any more [16:00:26] which means that our package is now arch-independent [16:01:05] What would make it arch-dependent? [16:01:33] no more binary modules -- jsdom was the only one & wasn't exercised by us anyway [16:01:57] all remaining npm modules are pure js, which means that they'll work as-is on any architecture [16:23:23] 3VisualEditor / 3ContentEditable: VisualEditor: Copy/pasting blanks page, prevents saving - 10https://bugzilla.wikimedia.org/61552#c2 (10Ed Sanders) Can't reproduce. [16:28:25] James_F, around? [16:28:34] Yeah. In a meeting though. [16:30:19] Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=11774396 [16:30:19] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=106874566 [16:30:19] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32441805 [16:30:19] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65061497 [16:30:19] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65086042 [16:30:20] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=67805978 [16:30:53] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Clicking in the document where an inspector was opened doesn't close the inspector - 10https://bugzilla.wikimedia.org/68679#c3 (10Ed Sanders) p:5High>3Low s:5major>3normal This is the edgiest of edge cases. You need to open the link inspector... [16:32:07] James_F, what about Trevor? [16:32:30] Krenair: He WFHs on Tuesdays starting at ~ 10:00… so no, sorry, not yet. [16:32:39] Can it wait for the KIT? [16:32:44] yeah [16:33:24] 3VisualEditor / 3ContentEditable: VisualEditor: Copying text sometimes makes the page jump/scroll in Firefox - 10https://bugzilla.wikimedia.org/55433#c8 (10Ed Sanders) Can't reproduce any of the issues described in this bug. [16:33:25] OK. [16:33:38] ew, another one: https://it.wikipedia.org/?diff=67805978 [16:35:18] Fun. :-( [16:36:26] (03PS10) 10Alex Monk: Show pending state and keep dialog open when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) [16:38:19] (03CR) 10jenkins-bot: [V: 04-1] Show pending state and keep dialog open when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [16:38:36] urgh [16:40:21] (03CR) 10Alex Monk: [V: 04-1] "This is broken, probably as of PS9 - although we successfully pushPending and the DOM reflects this, nothing is showing. The header has no" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [16:47:09] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] Cannot open Math inspector on a slug – TypeError: Cannot read property 'length' of null appears in the console - 10https://bugzilla.wikimedia.org/69991#c3 (10Ed Sanders) 5ASSI>3RESO/FIX This was fixed by https://gerrit.wikimedia.org/r/#... [16:48:56] (03PS1) 10Bartosz Dziewoński: README: Fix typos [oojs/core] - 10https://gerrit.wikimedia.org/r/156312 [16:53:11] (03CR) 10Krinkle: [C: 04-1] README: Fix typos (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/156312 (owner: 10Bartosz Dziewoński) [16:53:46] (03PS2) 10Krinkle: reamde: Fix "compatibility" and "appropriate" typo [oojs/core] - 10https://gerrit.wikimedia.org/r/156312 (owner: 10Bartosz Dziewoński) [16:54:13] (03CR) 10Krinkle: [C: 032] reamde: Fix "compatibility" and "appropriate" typo [oojs/core] - 10https://gerrit.wikimedia.org/r/156312 (owner: 10Bartosz Dziewoński) [16:54:39] (03PS3) 10Bartosz Dziewoński: readme: Fix "compatibility" and "appropriate" typo [oojs/core] - 10https://gerrit.wikimedia.org/r/156312 [16:54:40] "reamde" [16:54:46] can't tell if intentional… :D [16:55:13] (03CR) 10Krinkle: [C: 032] readme: Fix "compatibility" and "appropriate" typo [oojs/core] - 10https://gerrit.wikimedia.org/r/156312 (owner: 10Bartosz Dziewoński) [16:58:17] (03PS4) 10Esanders: dm.NodeFactory: Use .lookup() instead of .create().constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151506 (owner: 10Catrope) [16:58:28] MatmaRex: :-) [16:59:24] 3VisualEditor / 3MediaWiki integration: VisualEditor: Toolbar utilities menu items should not be cut off against browser edge - 10https://bugzilla.wikimedia.org/57366 (10Krinkle) [16:59:25] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] Cannot open Math inspector on a slug – TypeError: Cannot read property 'length' of null appears in the console - 10https://bugzilla.wikimedia.org/69991 (10James Forrester) a:5Ed Sanders>3Roan Kattouw [16:59:45] (03Merged) 10jenkins-bot: readme: Fix "compatibility" and "appropriate" typo [oojs/core] - 10https://gerrit.wikimedia.org/r/156312 (owner: 10Bartosz Dziewoński) [16:59:58] (03PS1) 10Jforrester: Update VE core submodule to master (a96cb00) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156316 [17:00:32] edsanders: ^^^ Merge please. [17:00:55] 3VisualEditor / 3MediaWiki integration: VisualEditor: Toolbar utilities menu items should not be cut off against browser edge - 10https://bugzilla.wikimedia.org/57366#c8 (10Krinkle) Created attachment 16280 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16280&action=edit Screenshot of problem on mast... [17:03:17] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (a96cb00) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156316 (owner: 10Jforrester) [17:05:03] (03Merged) 10jenkins-bot: Update VE core submodule to master (a96cb00) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156316 (owner: 10Jforrester) [17:12:59] (03PS5) 10Esanders: dm.NodeFactory: Use .lookup() instead of .create().constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151506 (owner: 10Catrope) [17:17:28] (03CR) 10Esanders: [C: 031] "+1 for the code, Roan can +1 the tests for +2" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151506 (owner: 10Catrope) [17:21:02] edsanders, you +1'ed this, any reason why it shouldn't be +2'ed? https://gerrit.wikimedia.org/r/#/c/149217/ [17:21:24] RoanKattouw_away, previously reviewed it so I thought he might want to review again [17:25:09] 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c11 (10Krinkle) This is not a new problem. Users using older browsers have always had fatal errors because jquery/mediawiki are not loaded in blacklisted browsers not... [17:27:15] awesome, I'll bug RoanKattouw_away to review it again, then. :D [17:29:54] 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c12 (10Krinkle) > > function bar() { return 1; } > > bar(); > >> 1 > > > if (true) { > > function bar() { return 1; } > > } else { > > function bar() { return 2;... [17:30:24] 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c13 (10Krinkle) > quux(); if (true) { function quux() { return 1; } } else { function quux() { return 2; } } V8> 2 SpiderMonkey> quux is undefined [17:30:24] James_F: Hm.. why is this core bug reported here? [17:30:41] Krinkle: Editing team areas of interest come here. [17:31:02] So all of the ResourceLoader component comes here? :/ [17:31:17] Krinkle: Right now it's VE, OOjs, OOUI, MW-core ResourceLoader, MW-core Page editing, WikiEditor, TemplateData, and Cite. [17:31:35] Krinkle: "All"? It's a small fraction of the VE/etc. notices. [17:31:45] Krinkle: The MW-core ones also go to -dev. [17:32:43] Krinkle: Also, Roan (and I!) want you to review a breaking change in OOjs – as it's our first. [17:32:58] Krinkle: https://gerrit.wikimedia.org/r/#/c/155589/ [17:33:23] dinner, brb [17:34:10] (03PS3) 10Krinkle: [BREAKING CHANGE] Make OO.EventEmitter#validateMethod private [oojs/core] - 10https://gerrit.wikimedia.org/r/155589 (owner: 10Catrope) [17:35:43] (03CR) 10Krinkle: "Strictly speaking, we should throw this on the tech debt stack for v2.x as a low priority cleanup. But if we want to do this now, we could" [oojs/core] - 10https://gerrit.wikimedia.org/r/155589 (owner: 10Catrope) [17:36:28] (03CR) 10Jforrester: "Yeah, I was going to bump to v. 1.1.0 for this." [oojs/core] - 10https://gerrit.wikimedia.org/r/155589 (owner: 10Catrope) [17:40:54] where is trevor? [17:51:54] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] Getting stuck in the Media Settings dialog after changing the image position as it is throwing TypeError: Cannot read property 'length' of null - 10https://bugzilla.wikimedia.org/69988#c3 (10Rummana Yasmeen) Verified the fix in Betalabs [17:52:27] edsanders, when you have a moment, can you answer Roan's concern in https://gerrit.wikimedia.org/r/#/c/155839/ ? [17:56:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] Cannot open Math inspector on a slug – TypeError: Cannot read property 'length' of null appears in the console - 10https://bugzilla.wikimedia.org/69991#c4 (10Rummana Yasmeen) Verified the fix in Betalabs [18:04:49] Krenair: He works from home on Tuesdays [18:04:57] I'll ping him saying that he needs to be on IRC when WFH [18:08:43] ok, sorry [18:08:44] I'm here [18:08:51] Krenair: howdy [18:09:12] Hey [18:09:16] So the issue I ran into was with https://gerrit.wikimedia.org/r/#/c/144505/ [18:09:34] that dialog appears to have no visible header which can show the pending status anymore [18:09:51] So I thought maybe we could make the button the user pressed be pending, and disable the others [18:10:36] yes [18:10:37] so [18:10:42] there's already a call for this [18:11:06] Would likely need OOUI changes, as OOUI currently only allows Dialogs and TextInputWidgets to be pending [18:11:55] It's technically an "indeterminate progress indicator", and our buttons need to have a pending state to indicate progress indeterminately [18:12:41] would also be cool, later, to have a determinate progress indicator built into the dialogs and buttons, but let's not get bogged down in the theoretical use cases [18:12:41] (03CR) 10Catrope: [C: 032] dm.NodeFactory: Use .lookup() instead of .create().constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151506 (owner: 10Catrope) [18:12:43] teams that want to use OOjs UI already want this feature [18:12:52] so [18:13:20] you can copy the (push|pop)Pending methods from one of the other things that have them [18:14:20] (03Merged) 10jenkins-bot: dm.NodeFactory: Use .lookup() instead of .create().constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151506 (owner: 10Catrope) [18:15:49] or, if you want to get fancy, you can make an OO.ui.PendingElement mixin [18:16:19] which does the basic mechanism of pushing/popping the pending integer [18:16:27] and provides isPending [18:16:41] and toggles a class [18:16:53] on an element passed in as a parameter [18:17:05] make sense? [18:17:41] then, where we mix it it, we can override, call the parent method, check isPending, and toggle other things (like the oo-ui-texture) accordingly [18:18:12] (note to self, consider adding OO.ui.TexturedElement and generalizing Iconed and Indicated element) [18:18:32] That sounds like it would be useful for this. [18:19:06] Ta-dah. [18:19:11] 3OOjs UI / 3Technical Debt: OOjs UI: Consider adding OO.ui.TexturedElement and generalizing Iconed and Indicated element - 10https://bugzilla.wikimedia.org/70056 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3None Per Trevor. [18:19:23] 3OOjs UI / 3Technical Debt: OOjs UI: Consider adding OO.ui.TexturedElement and generalizing Iconed and Indicated element - 10https://bugzilla.wikimedia.org/70056 (10James Forrester) p:5Unprio>3Normal [18:30:14] (03PS1) 10Trevor Parscal: Build with clean CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/156330 [18:30:24] (03PS1) 10Trevor Parscal: Whitespace fix [oojs/ui] - 10https://gerrit.wikimedia.org/r/156331 [18:31:49] James_F, pinged on gchat [18:32:09] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf16]Opening link inspector/comment box in an empty line, opens them at the end of the previous line - 10https://bugzilla.wikimedia.org/69122#c7 (10Rummana Yasmeen) Created attachment 16282 --> https://bugzilla.wikimedia.org/attachment.cgi?id=162... [18:32:09] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf16]Opening link inspector/comment box in an empty line, opens them at the end of the previous line - 10https://bugzilla.wikimedia.org/69122 (10Rummana Yasmeen) 5RESO/FIX>3REOP [18:32:24] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf16]Opening link inspector/comment box in an empty line, opens them at the end of the previous line - 10https://bugzilla.wikimedia.org/69122 (10Rummana Yasmeen) 5REOP>3ASSI [18:33:17] (03CR) 10Jforrester: [C: 032] Build with clean CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/156330 (owner: 10Trevor Parscal) [19:07:52] (03CR) 10Esanders: "I've lost track of the various edge cases we were fixing with this, but I can't trigger any bugs with this version of the code, so maybe w" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155839 (https://bugzilla.wikimedia.org/66697) (owner: 10JGonera) [19:19:45] (03CR) 10Bartosz Dziewoński: "Thanks James. I just re-tested, this still works and I still think it's a good idea, and the dependency has been merged." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) (owner: 10Bartosz Dziewoński) [19:47:26] 3OOjs UI: OOjs UI: [Regression wmf18] In VE, on the first attempt to invoke , the confirmation dialogs for switching to Read mode and Edit Source mode are appearing with a scroll bar and button placements are also not next to each other - 10https://bugzilla.wikimedia.org/70061 (10Rummana Yasmeen) 3NEW p:3Un... [19:49:40] (03CR) 10TheDJ: "I have some worry here due to large amount of profanity that is included in this set of categories that is indeed the same. Not used yet, " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156250 (https://bugzilla.wikimedia.org/70025) (owner: 10TheDJ) [19:54:36] (03CR) 10TheDJ: "HotCat queries allpages instead of allcategories. Basically treating every category without it's own page as simply non-existing." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156250 (https://bugzilla.wikimedia.org/70025) (owner: 10TheDJ) [19:56:54] 3VisualEditor / 3Editing Tools: VisualEditor: Category suggestion lists no longer existing categories - 10https://bugzilla.wikimedia.org/70025#c2 (10Derk-Jan Hartman) Alternative is to use the HotCat methodology: Here only categories that have their own page are considered to exist: https://en.wikipedia.org... [19:57:48] (03CR) 10Jforrester: [C: 032] "I'd cite WP:OTHERCRAPEXISTS but it'd be unkind. :-)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156250 (https://bugzilla.wikimedia.org/70025) (owner: 10TheDJ) [19:58:09] 3VisualEditor / 3Editing Tools: VisualEditor: Category suggestion lists no longer existing categories - 10https://bugzilla.wikimedia.org/70025 (10James Forrester) 5PATC>3RESO/FIX [20:00:43] (03Merged) 10jenkins-bot: Categories: Don't suggest empty or old categories [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156250 (https://bugzilla.wikimedia.org/70025) (owner: 10TheDJ) [20:01:24] 3VisualEditor / 3Editing Tools: VisualEditor: Category suggestion lists no longer existing categories - 10https://bugzilla.wikimedia.org/70025#c4 (10Derk-Jan Hartman) Actually, i forgot, HotCat now actually runs 2 queries on both of these tables, and then combines them into a result.. Perhaps we should fix... [20:03:07] (03CR) 10Krinkle: "Sure, but that's not relevant imho. 1.1.0 isn't a major version bump. Whether we do 1.x.0 or 1.0.x doesn't really matter. Quite a few of o" [oojs/core] - 10https://gerrit.wikimedia.org/r/155589 (owner: 10Catrope) [20:07:31] (03PS1) 10Catrope: Polyfill Node.prototype.normalize in IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156444 [20:08:51] TrevorParscal: I have question about this: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js#L322-L324 [20:09:04] Currently it modifies this.originalData, but I have doubts if it really should? [20:09:05] InezK: i'm in a meeting, talk later [20:09:11] like 1hr [20:09:16] (03CR) 10Jforrester: "This isn't a proper breaking change, as you identify; this patch was written 24 hours after validateMethod was introduced. It's now been n" [oojs/core] - 10https://gerrit.wikimedia.org/r/155589 (owner: 10Catrope) [20:09:33] InezK: Ouch, yeah that looks bad, it probably shouldn't be doing that [20:12:41] I guess it could be solved in two ways at least [20:12:50] use oo.copy, or just pass null as a first parameter [20:13:36] (03PS1) 10Catrope: Try a bit harder not to create empty text nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156447 [20:13:51] You could pass {} as the first param [20:13:56] That's what we usually do [20:14:46] So I made OO.ui.PendingElement [20:15:25] Unfortunately because we want Dialog to use this as a mixin, it seems I have to put PendingElement before Dialog in build/modules.json [20:15:58] Ugh [20:15:59] Right [20:16:09] I wonder why the elements set doesn't appear earlier in general, though [20:17:27] Also, Dialog and TextInputWidget set up their own pending classes [20:18:03] So they have to override pushPending and popPending, do the check for this.pending and add their class still [20:18:18] (or remove) [20:22:25] Unless you just rename those classes and update the CSS [20:50:28] 3VisualEditor / 3Editing Tools: VisualEditor: Incorrect highlight while trying to add reference in a slug - 10https://bugzilla.wikimedia.org/70065 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16285 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16285&action=edit Scr... [20:50:55] RoanKattouw, And then update a bunch of callers so I no longer need to override to set which element to use for Dialog and TextInputWidget :/ [21:03:11] (03CR) 10JGonera: "Inline comment." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155839 (https://bugzilla.wikimedia.org/66697) (owner: 10JGonera) [21:03:29] edsanders, see my inline comment in https://gerrit.wikimedia.org/r/#/c/155839/ [21:27:58] (03PS1) 10Alex Monk: Split out isPending, pushPending, popPending, etc. into PendingElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/156459 [21:28:09] 3MediaWiki / 3ResourceLoader: ResourceLoader cache not properly fixable after moving MediaWiki - 10https://bugzilla.wikimedia.org/35472#c4 (10Daniel Robbins) Bump on this. This is a pretty ugly bug when dealing with wiki migrations. See my comment above on an easy fix. [21:29:04] (03CR) 10jenkins-bot: [V: 04-1] Split out isPending, pushPending, popPending, etc. into PendingElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/156459 (owner: 10Alex Monk) [21:29:25] (03CR) 10Alex Monk: "See Ib2c8f336 in OOUI. The Jenkins failure is due to a missing linebreak at the end of the file" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [21:32:44] RoanKattouw, TrevorParscal it doesn't like my use of @inheritdoc to get the docs from the mixin PendingElement [21:33:11] where are you using it? [21:33:14] on a method? [21:33:37] did you specify @mixins {OO.ui.PendingElement} in the constructor docs? [21:34:04] Dammit, that's what I missed, of course [21:35:48] glad I could help :) [21:35:57] sometimes JSDuck errors aren't very helpful [21:36:02] they invoke thrashing [21:36:08] (03PS2) 10Alex Monk: Split out isPending, pushPending, popPending, etc. into PendingElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/156459 [21:37:03] I think this was probably just me screwing up [21:38:06] TrevorParscal: Sooo, $content [21:38:28] ( https://gerrit.wikimedia.org/r/155181 ) [21:40:34] TrevorParscal: It used to be that that change made the background grey in windows, now it just messes with the font size. I suppose there are some CSS rules that would need to be adjusted for me splitting the and oo-ui-content back out? [22:00:11] RoanKattouw, not sure if edsanders|away wants to oversee rewording of that comment himself in https://gerrit.wikimedia.org/r/#/c/155839/. if not, let me know if what I suggested works [22:06:29] RoanKattouw: sorry, I was in this meeting of doom [22:06:36] and now I'm trying to finish up a commit [22:06:46] and I haven't eaten lunch yet [22:20:36] hey TrevorParscal [22:21:43] TrevorParscal: the link inspector opens search automatically in Firefox but not in Chrome or Safari, is that right? [22:23:09] 3MediaWiki / 3ResourceLoader: ResourceLoader cache not properly fixable after moving MediaWiki - 10https://bugzilla.wikimedia.org/35472#c5 (10Andre Klapper) Krinkle: Does the approach in comment 3 sound feasible? Daniel: If the approach gets an OK and if you feel like cooking up a patch, see https://www.med... [22:23:21] TrevorParscal: No worries, I'm chasing another IE bug right now [22:24:43] (03PS1) 10Trevor Parscal: Reorganize theme system [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 [22:24:47] boom [22:25:06] (plz review my stuff at some point, I promise I will help you with the $content thing) [22:25:08] (03CR) 10jenkins-bot: [V: 04-1] Reorganize theme system [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 (owner: 10Trevor Parscal) [22:25:10] I gotta go eat something [22:26:18] (03PS2) 10Trevor Parscal: Reorganize theme system [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 [22:27:06] (03CR) 10jenkins-bot: [V: 04-1] Reorganize theme system [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 (owner: 10Trevor Parscal) [22:28:41] arg! [22:28:52] git isn't recognizing file renames that only change case [22:28:54] I HATE YOU [22:29:02] work arounds? [22:29:07] * Krinkle is eating, but can't help giggling Scooby Doo style seeing live 1:1 arm-wrestling with jenkins-bot here on IRC. Spectacle of the day ladies and gentleman! [22:29:22] Sorry Trevor ;-) [22:29:36] TrevorParscal: It supports it but discourages it [22:29:45] git mv foo bar; git mv bar Foo [22:29:50] riight [22:29:56] manual oeprations! nnnoooooooo [22:29:58] one sec [22:30:00] I usually do git mv foo foo.2 then git mv foo.2 Foo [22:30:03] or something like that [22:30:17] can be in the same commit, no worries, just needs to do it twice. [22:31:47] um... fatal: destination exists [22:32:56] oh [22:32:56] yeah, that trick [22:32:57] ARG [22:35:29] (03PS3) 10Trevor Parscal: Reorganize theme system [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 [22:37:26] ok, I'm actually going to get lunch now [22:37:30] omg, nearly 4pm [22:37:30] crap [22:37:30] cyall in a bit [23:18:09] 3VisualEditor / 3Editing Tools: VisualEditor: Category suggestion lists no longer existing categories - 10https://bugzilla.wikimedia.org/70025#c5 (10WhatamIdoing) *** Bug 69927 has been marked as a duplicate of this bug. *** [23:18:10] 3VisualEditor: Category suggestions include non-existent and implausible suggestions - 10https://bugzilla.wikimedia.org/69927#c1 (10WhatamIdoing) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 70025 *** [23:18:11] 3MediaWiki / 3ResourceLoader: ResourceLoader cache not properly fixable after moving MediaWiki - 10https://bugzilla.wikimedia.org/35472#c6 (10Krinkle) Yes. If update.php already cleans other tables the same way, let's just add this one to it. [23:23:41] (03CR) 10Catrope: [C: 04-1] "WTF? Aren't you "fixing" this the wrong way around?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/156331 (owner: 10Trevor Parscal) [23:23:57] (03CR) 10Catrope: [C: 032] Build with clean CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/156330 (owner: 10Trevor Parscal) [23:24:24] (03CR) 10Krinkle: "Oi, space police! All hands on deck." [oojs/ui] - 10https://gerrit.wikimedia.org/r/156331 (owner: 10Trevor Parscal) [23:25:02] Krinkle: Are you feeling quite all right? [23:26:13] Just a bit on edge, and juggling a lot of variables in my situation at the moment [23:27:28] * James_F grins. [23:28:01] Hey edsanders. [23:28:11] hello [23:28:22] Did you say yes to Travel? [23:28:32] yes [23:28:39] all sorted [23:28:43] Yay. [23:28:57] Feel like a quick piece of code review? [23:29:05] https://gerrit.wikimedia.org/r/#/c/155634/ is calling out for you. [23:29:19] (03PS9) 10Jforrester: Factor out ve.dm.Transaction.pushReplaceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116214 (owner: 10Catrope) [23:29:22] (03CR) 10jenkins-bot: [V: 04-1] Factor out ve.dm.Transaction.pushReplaceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116214 (owner: 10Catrope) [23:32:04] (03PS1) 10Catrope: Followup 355be3ed: fix getOffset() behavior inside block aliens [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156477 [23:39:14] (03PS6) 10Jforrester: Fix `ve.dm.Transaction.newFromReplacement` when `removeMetadata` is true. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152017 (owner: 10Cscott) [23:39:14] (03PS7) 10Jforrester: WIP: Record intention in ve.dm.Transaction object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 (owner: 10Cscott) [23:39:15] (03PS6) 10Jforrester: WIP: Add ve.dm.Transaction.copy() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151799 (owner: 10Cscott) [23:39:17] (03PS6) 10Jforrester: WIP: Implement ve.dm.Transaction.transpose() w/ intentions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151545 (owner: 10Cscott) [23:39:19] (03PS6) 10Jforrester: Add ve.dm.Transaction.newFromIntention() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151798 (owner: 10Cscott) [23:39:21] (03PS7) 10Jforrester: Add ve.dm.Transaction.newNoOp() constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 (owner: 10Cscott) [23:39:23] (03PS10) 10Jforrester: Factor out ve.dm.Transaction.pushReplaceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116214 (owner: 10Catrope) [23:40:28] (03PS7) 10Jforrester: Fix `ve.dm.Transaction.newFromReplacement` when `removeMetadata` is true [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152017 (owner: 10Cscott) [23:40:56] (03CR) 10Jforrester: [C: 031] "LGTM – Roan?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152017 (owner: 10Cscott) [23:43:17] (03CR) 10Esanders: Check for selection in ve.ce.Surface#onDocumentFocus (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155839 (https://bugzilla.wikimedia.org/66697) (owner: 10JGonera) [23:43:58] (03CR) 10jenkins-bot: [V: 04-1] WIP: Implement ve.dm.Transaction.transpose() w/ intentions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151545 (owner: 10Cscott) [23:45:29] (03PS8) 10Jforrester: Fix `ve.dm.Transaction.newFromReplacement` when `removeMetadata` is true [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152017 (owner: 10Cscott) [23:45:50] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/152017/5..8/src/dm/ve.dm.Transaction.js [23:48:09] (03CR) 10Catrope: Fix `ve.dm.Transaction.newFromReplacement` when `removeMetadata` is true (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152017 (owner: 10Cscott)