[00:05:17] <grrrit-wm1>	 (03PS2) 10JGonera: Check for selection in ve.ce.Surface#onDocumentFocus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155839 (https://bugzilla.wikimedia.org/66697) 
[00:05:47] <grrrit-wm1>	 (03Abandoned) 10Trevor Parscal: Whitespace fix [oojs/ui] - 10https://gerrit.wikimedia.org/r/156331 (owner: 10Trevor Parscal)
[00:06:11] <James_F>	 :-)
[00:06:38] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/155839/2 should be good to +2 now.
[00:07:56] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Check for selection in ve.ce.Surface#onDocumentFocus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155839 (https://bugzilla.wikimedia.org/66697) (owner: 10JGonera)
[00:10:08] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Check for selection in ve.ce.Surface#onDocumentFocus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155839 (https://bugzilla.wikimedia.org/66697) (owner: 10JGonera)
[00:13:40] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697 (10James Forrester) 5PATC>3RESO/FIX
[00:14:29] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] Split out isPending, pushPending, popPending, etc. into PendingElement (0310 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/156459 (owner: 10Alex Monk)
[00:16:52] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Polyfill Node.prototype.normalize in IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156444 (owner: 10Catrope)
[00:19:27] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Followup 355be3ed: fix getOffset() behavior inside block aliens [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156477 (owner: 10Catrope)
[00:21:40] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Fix the newline bunny-hop bug harder [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155634 (https://bugzilla.wikimedia.org/69861) (owner: 10Catrope)
[00:22:09] <wikibugs>	 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c14 (10Krinkle) Hm.. so yeah, that's annoying. The condition-wrap is supposed to hide an issue in old browsers, not introduce issues in modern browsers.  So far I've o...
[00:22:40] <wikibugs>	 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c15 (10Krinkle) Open to other ideas. Of neither #1 or #2 is acceptable, we may have to remove the if-wrap for the time being since modern Firefox triumps priority over...
[00:24:18] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Try a bit harder not to create empty text nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156447 (owner: 10Catrope)
[00:24:58] <James_F>	 TrevorParscal: What are your thoughts on https://gerrit.wikimedia.org/r/#/c/155181/ for Roan?
[00:27:44] <TrevorParscal>	 lookin
[00:28:08] <TrevorParscal>	 oh, well is it urgent? Can i work with him in person on it tomorrow?
[00:28:31] <TrevorParscal>	 i think it will be simple, we just need to be sitting next to each other and it will get sorted in like 2 minutes
[00:28:38] <TrevorParscal>	 Roan can use his phone as the timer
[00:28:53] <TrevorParscal>	 I will use my phone to browse the internet while helping him
[00:28:58] <TrevorParscal>	 and we will still do it in 1:30
[00:29:05] <TrevorParscal>	 :)
[00:29:57] <James_F>	 OK.
[00:30:02] <James_F>	 Excuses. :-P
[00:32:18] <RoanKattouw>	 We can do it in person tomorrow
[00:32:27] <RoanKattouw>	 James won't be here to time us though
[00:32:33] <James_F>	 (Sad face.)
[00:32:35] <RoanKattouw>	 He has an all-day strategy offside
[00:32:39] <RoanKattouw>	 *offsiTe
[00:32:44] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: isMsie doesn't catch MSIE 11+ - 10https://bugzilla.wikimedia.org/66096#c1 (10James Forrester) 5ASSI>3RESO/FIX Fixed by Roan by the simple expediency of deleting this function.
[00:32:45] <James_F>	 Offside!
[00:32:54] <RoanKattouw>	 He did not violate soccer rules
[00:33:02] <James_F>	 You were clearly making strategy behind the enemy's rear-gunners.
[00:34:59] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Can't create new paragraph by hitting return in IE - 10https://bugzilla.wikimedia.org/63038#c2 (10James Forrester) Fixed in IE11, at least.
[00:36:54] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Test whether paste binding needs "beforepaste" for MSIE compatibility - 10https://bugzilla.wikimedia.org/65714#c1 (10James Forrester) Not needed in IE11, at least.
[00:36:57] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Out-of-skin templates are taking editors to linked pages, rather than letting them edit the template - 10https://bugzilla.wikimedia.org/70074 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce:  1.  Open page containing the {{good artic...
[00:36:59] <wikibugs>	 3VisualEditor / 3Initialisation: VisualEditor: Broken appearance when window is too small in Internet Explorer - 10https://bugzilla.wikimedia.org/63778#c1 (10James Forrester) Fixed in IE11, at least.
[00:37:03] <grrrit-wm>	 (03PS2) 10Jforrester: [WIP] Greylist IE11 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155841 (https://bugzilla.wikimedia.org/50085) (owner: 10Catrope)
[00:52:39] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor:  Out-of-skin templates are taking editors to linked pages, rather than letting them edit the template - 10https://bugzilla.wikimedia.org/70074 (10Roan Kattouw)
[00:52:55] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor:  Out-of-skin templates are taking editors to linked pages, rather than letting them edit the template - 10https://bugzilla.wikimedia.org/70074 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Ed Sanders
[00:53:40] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Minor comments inline" (034 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/156211 (owner: 10Trevor Parscal)
[01:05:08] <grrrit-wm>	 (03PS1) 10Catrope: Make the Resolve conflict button actually appear [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156491 
[01:06:55] <grrrit-wm>	 (03PS2) 10Jforrester: Make the Resolve conflict button actually appear [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156491 (https://bugzilla.wikimedia.org/69150) (owner: 10Catrope)
[01:07:13] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Make the Resolve conflict button actually appear [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156491 (https://bugzilla.wikimedia.org/69150) (owner: 10Catrope)
[01:07:58] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Edit conflict message provides no button to actually resolve the conflict - 10https://bugzilla.wikimedia.org/69150 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3High s:5normal>3major a:3Roan Kattouw
[01:08:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make the Resolve conflict button actually appear [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156491 (https://bugzilla.wikimedia.org/69150) (owner: 10Catrope)
[01:10:58] <grrrit-wm>	 (03PS1) 10Catrope: Make the Resolve conflict button actually appear [extensions/VisualEditor] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156493 (https://bugzilla.wikimedia.org/69150) 
[01:12:38] <grrrit-wm>	 (03PS1) 10Catrope: Make the Resolve conflict button actually appear [extensions/VisualEditor] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/156494 (https://bugzilla.wikimedia.org/69150) 
[01:12:46] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Make the Resolve conflict button actually appear [extensions/VisualEditor] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156493 (https://bugzilla.wikimedia.org/69150) (owner: 10Catrope)
[01:12:53] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Make the Resolve conflict button actually appear [extensions/VisualEditor] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/156494 (https://bugzilla.wikimedia.org/69150) (owner: 10Catrope)
[01:14:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make the Resolve conflict button actually appear [extensions/VisualEditor] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/156494 (https://bugzilla.wikimedia.org/69150) (owner: 10Catrope)
[01:14:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make the Resolve conflict button actually appear [extensions/VisualEditor] (wmf/1.24wmf18) - 10https://gerrit.wikimedia.org/r/156493 (https://bugzilla.wikimedia.org/69150) (owner: 10Catrope)
[01:16:29] <grrrit-wm>	 (03CR) 10Catrope: [V: 032] Make the Resolve conflict button actually appear [extensions/VisualEditor] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/156494 (https://bugzilla.wikimedia.org/69150) (owner: 10Catrope)
[01:26:54] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Edit conflict message provides no button to actually resolve the conflict - 10https://bugzilla.wikimedia.org/69150 (10James Forrester) 5PATC>3RESO/FIX
[01:36:57] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Minor stuff inline" (035 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 (owner: 10Trevor Parscal)
[01:47:39] <grrrit-wm>	 (03CR) 10Catrope: "Breaks the "Message dialog (generic)" demo. The text "It may be risky" is supposed to appear on the next line, and does so in master, but " [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 (owner: 10Trevor Parscal)
[01:57:10] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "This should also warn (but not prevent) the user from inserting / applying changes to the template if any of the required parameters are b" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154133 (https://bugzilla.wikimedia.org/60358) (owner: 10Alex Monk)
[02:00:11] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Template dialog search widget wrongly uses suffix ellipsis until input is refocused - 10https://bugzilla.wikimedia.org/67385#c5 (10Alex Monk) The ellipsis in the middle is done by the call to this.$label.autoEllipsis in OO.ui.LabelledElement#fitLabel - where it s...
[02:36:03] <grrrit-wm>	 (03PS4) 10Trevor Parscal: Reorganize theme system [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 
[02:36:33] <grrrit-wm>	 (03CR) 10Trevor Parscal: Reorganize theme system (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 (owner: 10Trevor Parscal)
[02:37:01] <grrrit-wm>	 (03PS5) 10Trevor Parscal: Reorganize theme system [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 
[02:47:15] <Krenair>	 TrevorParscal, I'm confused about https://gerrit.wikimedia.org/r/#/c/156459/2/src/Dialog.js - "The parent method needs to be called first, because this.pending is always 0 the first time pushPending is called, and the parent method is where that changes."
[02:47:35] <Krenair>	 We want to add a class the first it is called. . .
[02:48:27] <Krenair>	 If we called the parent first in pushPending, we'd then need to check for this.pending being 1 instead of 0, because the parent method will increment it.
[02:50:21] <Krenair>	 oh, he went away as I was typing
[02:51:51] <grrrit-wm>	 (03CR) 10Alex Monk: Split out isPending, pushPending, popPending, etc. into PendingElement (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/156459 (owner: 10Alex Monk)
[02:59:54] <grrrit-wm>	 (03CR) 10Alex Monk: "Sounds like we should merge this, resolving bug 60358, then do that as part of the blocked bug (bug 50747)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154133 (https://bugzilla.wikimedia.org/60358) (owner: 10Alex Monk)
[03:04:09] <grrrit-wm>	 (03PS27) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) 
[03:10:24] <grrrit-wm>	 (03PS28) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) 
[06:56:09] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - 10https://bugzilla.wikimedia.org/54947#c3 (10Amir E. Aharoni) I am a bit of a VE ambassador in the Hebrew Wikipedia and an experienced user...
[09:26:09] <wikibugs>	 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c16 (10Michael M.) What about only wrapping the  mw.loader.state({"user":"ready"}); at the bottom in an if-clause (or prefixing it with window.mw && ) and leaving the...
[09:38:29] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor:  Out-of-skin templates are taking editors to linked pages, rather than letting them edit the template - 10https://bugzilla.wikimedia.org/70074#c1 (10Derk-Jan Hartman) Which browsers are you using ?
[09:57:31] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Fix the newline bunny-hop bug harder [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155634 (https://bugzilla.wikimedia.org/69861) (owner: 10Catrope)
[09:58:39] <grrrit-wm>	 (03CR) 10Esanders: [C: 031] Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) (owner: 10Mooeypoo)
[09:59:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix the newline bunny-hop bug harder [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155634 (https://bugzilla.wikimedia.org/69861) (owner: 10Catrope)
[10:02:44] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Remove delete button from required parameters in template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154133 (https://bugzilla.wikimedia.org/60358) (owner: 10Alex Monk)
[10:04:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove delete button from required parameters in template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/154133 (https://bugzilla.wikimedia.org/60358) (owner: 10Alex Monk)
[10:52:41] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Stop users from deleting parameters in the template dialog if they're marked as "required" in TemplateData - 10https://bugzilla.wikimedia.org/60358 (10Alex Monk) 5PATC>3RESO/FIX
[11:38:28] <wikibugs>	 3MediaWiki / 3ResourceLoader: ResourceLoader cache not properly fixable after moving MediaWiki - 10https://bugzilla.wikimedia.org/35472 (10Andre Klapper)
[11:46:54] <wikibugs>	 3MediaWiki / 3ResourceLoader: ResourceLoader didn't invalidate cached CSS correctly for Extension:CategoryTree change - 10https://bugzilla.wikimedia.org/55334 (10Andre Klapper) p:5High>3Normal
[11:51:40] <wikibugs>	 3MediaWiki / 3ResourceLoader: add timestamp near cache key (JS/CSS minify) - 10https://bugzilla.wikimedia.org/34779 (10Andre Klapper)
[13:14:39] <wikibugs>	 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c17 (10Krinkle) Alternatively, we might be able to do the condition outside the script. Perhaps something like replace this:  <script src="./load.php?modules=user&only...
[13:18:54] <wikibugs>	 3OOjs UI: OOjs UI: onDomEvent('focus') does not work after jQuery upgrade - 10https://bugzilla.wikimedia.org/65608#c4 (10Krinkle) 5ASSI>3RESO/INV OO.ui.Element#onDomEvent is deprecated because it's just a legacy alias for jQuery#on. I don't think this is an OOjs UI bug.  It may or may not have worked befor...
[13:28:09] <wikibugs>	 3VisualEditor / 3Language: VisualEditor: In WebKit, moving the cursor (caret) with the arrow keys breaks connected Arabic letters - 10https://bugzilla.wikimedia.org/66339#c1 (10Amir E. Aharoni) I am not sure what fixed it, but it works for me now in Chrome 36.0.1985.143 on Fedora 20.  Can this be tested auto...
[13:43:09] <wikibugs>	 3VisualEditor / 3Language: VisualEditor: In WebKit, moving the cursor (caret) with the arrow keys breaks connected Arabic letters - 10https://bugzilla.wikimedia.org/66339#c2 (10Krinkle) Be sure to also test in a recent version of Safari (which runs on WebKit).  Chrome hasn't been based on WebKit for almost 2...
[13:45:15] <wikibugs>	 3VisualEditor / 3Language: VisualEditor: In WebKit, moving the cursor (caret) with the arrow keys breaks connected Arabic letters - 10https://bugzilla.wikimedia.org/66339#c3 (10Amir E. Aharoni) Well, I reported it, and I only have Chrome on Linux, so I guess I meant "Chrome" or "Blink" and not "WebKit".
[13:45:53] <wikibugs>	 3MediaWiki / 3ResourceLoader: add timestamp near cache key (JS/CSS minify) - 10https://bugzilla.wikimedia.org/34779 (10Krinkle)
[13:50:27] <wikibugs>	 3VisualEditor / 3Language: VisualEditor: In WebKit, moving the cursor (caret) with the arrow keys breaks connected Arabic letters - 10https://bugzilla.wikimedia.org/66339#c4 (10Krinkle) (In reply to Amir E. Aharoni from comment #3) > Well, I reported it, and I only have Chrome on Linux, so I guess I meant >...
[14:42:29] <mooeypoo>	 Krinkle, are you around?
[14:42:34] <Krinkle>	 Yes
[14:43:29] <mooeypoo>	 hi :) I fixed two things you wrote in the TD editor -- I added the arrow icons and I fixed the bug where the custom parameter got erased when you import. 
[14:44:02] <mooeypoo>	 Krinkle, *but* I think you also wrote that the import didn't import everything for you -- I couldn't replicate that. I used the exact same template wikitext as you put up there, and I got the params correctly.
[14:44:05] <mooeypoo>	 Can you verify?
[14:44:57] <Krinkle>	 No, I don't think I said it didn't import everything.
[14:45:05] <mooeypoo>	 Krinkle, also, about "marking the existing params pink" -- there was a bug report/request to do that. People in hewiki asked that if the templatedata editor displays a list of parameters, then the params that *don't* appear in the template code itself will be marked as such, which is why I added that in. They have a different background color, just to denote that they are "extra"
[14:45:27] <Krinkle>	 Ill read back, but I think I meant that we shouldn't assume it can detect everything (e.g. if there's a parameter present already in the docuemtnation, assume that's it's there on purpose)
[14:45:50] <Krinkle>	 How do I trigger that pink color?
[14:46:00] <Krinkle>	 I still don't understand the scenario in which that's supposed to come up.
[14:46:01] <mooeypoo>	 oh, I thought you wrote something "Edit Template:Unsigned/doc, currently has "date", "timestamp", and "user" in the template data. Template wikitext contains:" <-- but the code itself doesn't have "date" parameter itself, so I got "1", "user", and "timestamp" I believe.
[14:46:44] <agepox>	 Hi guys, i've installed VE and Parsoid and i can see them in the extensions under Version . 
[14:46:49] <Krinkle>	 Yes, the /doc page contains <templatedata> with { params: { date, timestamp, user }. 
[14:46:53] <agepox>	 the problem is that when i'm creating a new page i don't have the "Create" option only "Create source"
[14:46:55] <Krinkle>	 My example page that is
[14:47:43] <mooeypoo>	 Krinkle, but the code doesn't find "date" from the template you put up for me. It find 1, 2, user, timestamp
[14:47:51] <mooeypoo>	 it is a regex that looks for {{{foo
[14:48:22] <mooeypoo>	 I can make it better, but I'm not sure if I know how advanced templates work. So, for instance, it won't see conditional parameters
[14:48:33] <mooeypoo>	 or not always, as far as I saw
[14:49:31] <mooeypoo>	 agepox, you've installed VE into /extensions and added it to the LocalSettings.php page with all the followup settings, and also installed Parsoid ?
[14:49:56] <agepox>	 Yes sir
[14:50:09] <mooeypoo>	 Krinkle, okay, so the pink background: If you have an existing templatedata that has params that exist in the template + params that were added just to the templatedata, then those that were added will be marked pink.
[14:50:15] <agepox>	 I can also see them in the exntesions in the Version page.
[14:50:19] <Krinkle>	 mooeypoo: It's ok that it doesn't find date.
[14:50:43] <mooeypoo>	 Krinkle, and if you add a parameter yourself to the editor and then you hit "import" and get 3 more params (but 'foo' that you added is not in the code) then all params will be normal bg except for 'foo' that will be pink
[14:50:46] <mooeypoo>	 or.. purple
[14:51:02] <mooeypoo>	 It's just meant to mark the parameters as "I didn't find this one in the code"
[14:51:27] <mooeypoo>	 agepox, hmm. This is a local wiki?
[14:52:10] <agepox>	 this is private wiki, yes. 
[14:52:26] <mooeypoo>	 Did you download the extension or are you using git?
[14:52:29] <agepox>	 oh, you can access it from the internet if this is what you asking.
[14:52:46] <agepox>	 I've download the tarball of the REL1_23 branch
[14:53:04] <mooeypoo>	 Hm, so it shouldn't be anything with the submodule. Hmm. And you see them in Special:Version
[14:53:10] <mooeypoo>	 I thought it might be settings
[14:53:41] <agepox>	 This is my 3rd try to install this extension, last 2 times i had the "Create" and "Edit" buttons but they was not working.
[14:53:57] <agepox>	 now i'm facing this issue, frustrating.
[14:54:24] <mooeypoo>	 hang on let's see
[14:54:35] <mooeypoo>	 agepox, do you have all the settings in LocalSettings.php? Liek $wgDefaultUserOptions['visualeditor-enable'] = 1;
[14:54:39] <mooeypoo>	 Like*
[14:54:59] <mooeypoo>	 These: http://www.mediawiki.org/wiki/Extension:VisualEditor#Basic_configuration_for_MediaWiki-VisualEditor
[14:55:00] <agepox>	 I'll paste all my settings file to pastebin in 1 minute for you.
[14:55:10] <mooeypoo>	 (Don't paste passwords)
[14:55:13] <mooeypoo>	 :)
[14:55:40] <agepox>	 thanks :)
[14:55:40] <agepox>	 http://pastebin.com/ZhCCDmxu
[14:56:00] <agepox>	 i did fake password there don't be worry :)
[14:57:19] <mooeypoo>	 agepox, happened to me once when I was frustrated, just making sure :)
[14:57:23] <mooeypoo>	 ok, let's see.
[14:58:41] <mooeypoo>	 Krinkle, https://docs.google.com/a/wikimedia.org/file/d/0B1mkYNt_QfGTemlmNVZ3R1d1Ylk/edit?usp=drivesdk can you see this? "Foo" is not in the code. I added it first, then I hit "import"
[14:58:50] <mooeypoo>	 Krinkle, and you'll see the same if you save that templatedata and then reload the editor. 
[15:00:00] <mooeypoo>	 hm. agepox are you using Parsoid service?
[15:00:06] <grrrit-wm>	 (03PS29) 10Krinkle: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo)
[15:00:27] <agepox>	 Yes
[15:00:30] <agepox>	 i've installed from the deb 
[15:00:36] <agepox>	 it's working on 8142 
[15:00:45] <agepox>	 look : http://internalwiki.cloudapp.net::8142
[15:00:50] <mooeypoo>	 okay, so the Parsoid service and the extension are working. hm.
[15:01:38] <mooeypoo>	 But still, you'll probably see the 'edit' button and not be able to get in if it was a Parsoid issue. This sounds like a VE thing. Can you tell me if you have errors?
[15:01:41] <mooeypoo>	 in the error log?
[15:02:01] <Krinkle>	 mooeypoo: are you saying in my local example of Unsigned, 'date' is supposed to be pink?
[15:02:16] <agepox>	 Sorry i just checked again
[15:02:19] <agepox>	 the create is not presented
[15:02:23] <agepox>	 the edit is present and not working.
[15:02:37] <mooeypoo>	 Krinkle, yes, since it's not in the code
[15:02:38] <mooeypoo>	 but only if you import
[15:02:38] <mooeypoo>	 Oh
[15:02:42] <Krinkle>	 mooeypoo: is it maybe blue/purple instead of pink?
[15:02:43] <mooeypoo>	 Ahha
[15:02:59] <Krinkle>	 They're all purple
[15:03:03] <Krinkle>	 except for '1' which import added
[15:03:37] <mooeypoo>	 Krinkle, yes, purple, sorry. Look: https://docs.google.com/a/wikimedia.org/file/d/0B1mkYNt_QfGTemlmNVZ3R1d1Ylk/edit
[15:04:14] <mooeypoo>	 agepox, okay, now it sounds like a parsoid linking issue.
[15:04:19] <Krinkle>	 mooeypoo: https://gist.github.com/Krinkle/e97fc923762bc3e989fe
[15:04:21] <mooeypoo>	 VE <-> Parsoid
[15:04:57] <Krinkle>	 mooeypoo: http://i.imgur.com/BKKLr9Q.png
[15:05:27] <Krinkle>	 up until now all rows I've ever seen in templatedata dialogs were purple, I thought that's just the way rows look
[15:05:28] <mooeypoo>	 Krinkle, I copy pasted into my page and loaded the editor and I see 3 params: user, timestamp and date -- and 'date' is purple for me
[15:05:28] <Krinkle>	 then I noticed imported row being white
[15:05:36] <mooeypoo>	 .... what tha...
[15:05:50] <James_F>	 Krinkle: Purple?
[15:05:55] <James_F>	 How odd.
[15:06:22] <agepox>	 mooeypoo: so how can i investigate this issue?
[15:06:38] <Krinkle>	 mooeypoo: but that means the wikitext-parsing/parent-page fetching happens by default on load now, not just when the user clicks import?
[15:06:38] <Krinkle>	 The import button only does the addition of rows?
[15:06:42] <mooeypoo>	 ... what the hell. Krinkle I copy/pasted your gist, and immediately opened the editor: https://docs.google.com/a/wikimedia.org/file/d/0B1mkYNt_QfGTaDA0eTJuR011dDQ/edit?usp=drivesdk
[15:07:15] <Krinkle>	 Template:Unsigned and Template:Unsigned/doc ?
[15:07:38] <mooeypoo>	 agepox, hm, can you check if you have any errors in the logs?
[15:08:05] <agepox>	 mooeypoo: sorry for the noobness, where are the logs that i should check ?
[15:08:36] <mooeypoo>	 Krinkle, yes, but it's async.
[15:08:37] <mooeypoo>	 Krinkle, that was the way to solve the bug requesting these fields to be marked.
[15:11:04] <agepox>	 mooeypoo: /var/log/parsoid is empty
[15:14:58] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: GUI editor (tracking) - 10https://bugzilla.wikimedia.org/65544 (10WhatamIdoing)
[15:14:58] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData GUI:  Support "suggested" parameter property, not just "required" - 10https://bugzilla.wikimedia.org/70095 (10WhatamIdoing)
[15:15:00] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData GUI:  Support "suggested" parameter property, not just "required" - 10https://bugzilla.wikimedia.org/70095 (10WhatamIdoing) 3NEW p:3Unprio s:3enhanc a:3None It should be possible to set a parameter's property to "suggested" in the GUI.
[15:15:18] <agepox>	 mooeypoo: acutaly i didn't have permissions to see it so i changed to root, now i can see the log of parsoid. it looks good - 4 workers are running. and : "[info][enwiki/Main_Page] completed parsing in 1456 ms"
[15:17:28] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor:  Out-of-skin templates are taking editors to linked pages, rather than letting them edit the template - 10https://bugzilla.wikimedia.org/70074#c2 (10WhatamIdoing) It was reported on Firefox 31 on Windows 7, using Monobook.  There's a screenshot at https://commo...
[15:17:31] <mooeypoo>	 Krinkle, if oyu want to see it in the code, it's line #200 inside "modelLoadTemplateDataJson"
[15:18:05] <mooeypoo>	 agepox, oh. Uhm... that's a good question... the web server should have error logs
[15:18:06] <Krinkle>	 mooeypoo: plain open without pressing the import button or changing data: http://imgur.com/ThmN14n
[15:18:06] <Krinkle>	 http://i.imgur.com/ThmN14n.png
[15:18:08] <mooeypoo>	 ... that's not what I have. What the hell.
[15:18:09] <mooeypoo>	 oh, got it
[15:18:09] <mooeypoo>	 ... bah, what is going on. That shouldn't happen.
[15:18:21] <mooeypoo>	 agepox, when you click "edit" do you get a popup message or is it just not loading?
[15:18:30] <Krinkle>	 mooeypoo: When I click Import it says:
[15:18:30] <Krinkle>	 > Some parameters were not imported, because they already exist in the editor: 1, 1, 1 
[15:19:07] <mooeypoo>	 Krinkle, oh. ha. I only copied the documentation without the template code. That explains my purples, but not yours. I'm debugging it now, that shouldn't happen.
[15:19:08] <mooeypoo>	 Krinkle, okay, I seem to be having issues importing from within the subpage when the template code is in the parent page. Working on that now.
[15:20:48] <Krinkle>	 that looks off as well
[15:21:36] <agepox>	 mooeypoo: nothing happens
[15:21:39] <agepox>	 mooeypoo: it took few seconds but i got a popup! 
[15:21:40] <agepox>	 mooeypoo: Error loading data from server: parsoidserver-http-bad-status: 500. Would you like to retry?
[15:21:58] <mooeypoo>	 Krinkle, yeah, I'm debugging it now. Something's up when the code tries to fetch template source params from a page that's not the current page. If you put the full code inside the current page, you'll see it does work. So th eimport itself is wonky. I'm working on it.
[15:21:59] <mooeypoo>	 agepox, so it looks like Parsoid is connected to VE properly... whaaat.
[15:22:22] <agepox>	 i got new log entries 
[15:22:29] <agepox>	 i think that i found the problem
[15:22:45] <agepox>	 it's looking for /w/api.php
[15:23:27] <agepox>	 I've changed it on the localsettings.js now, how i reset the parsoid service?
[15:24:02] <agepox>	 Okay i've restarted it, sorry for spamming, only after crying on things they are working XD
[15:24:13] <mooeypoo>	 James_F, any ideas? agepox is trying to install VE; he has ve/parsoid extensions and the parsoid service working, and "Edit" and "Edit source" appear, but "Edit" doesn't work. And "Create" doesn't appear at all, only "Create source"
[15:24:43] <James_F>	 Hmm.
[15:24:53] <James_F>	 JS init race condition, maybe?
[15:25:35] <James_F>	 agepox: Do you have any odd local extensions or scripts?
[15:25:49] <agepox>	 James_F and mooeypoo i have some progress since this condition.
[15:25:59] <agepox>	 the advice of mooeypoo  about looking on the logs of parsoid helped.
[15:26:04] <James_F>	 Aha.
[15:26:08] <agepox>	 parsoid is looking for /w/api.php and not findiing so i get error 500 .
[15:28:45] <agepox>	 in the Version page i see that my api path is correct. not /w/api.php 
[15:28:53] <agepox>	 where parsoid take this path from ?
[15:30:06] <mooeypoo>	 agepox, you need to edit localsettings.js in parsoid service, then?
[15:30:47] <agepox>	 I've already edited it
[15:30:55] <agepox>	       parsoidConfig.setInterwiki( 'localhost', 'http://localhost/mediawiki-1.23.2/api.php' );
[15:30:59] <agepox>	 this is the correct path. 
[15:31:30] <James_F>	 agepox: Have you restarted the Parsoid server?
[15:31:49] <agepox>	 Yes, and because i'm coming from windows background i've also restarted the server itself :)
[15:31:53] <agepox>	 still same error in the log.
[15:31:59] <James_F>	 Ha.:-)
[15:36:12] <agepox>	 Thanks for help guys, i'll try to handle it by myself tomorrrow, i must go now,
[15:36:50] <James_F>	 agepox: Good luck!
[15:45:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog should recommend TemplateData-hinted mandatory parameters - 10https://bugzilla.wikimedia.org/50747#c17 (10Alex Monk) We're also going to require the user to confirm when they try to insert a template with required parameters missing.
[15:46:08] * James_F meetings.
[15:46:24] <grrrit-wm>	 (03PS1) 10Alex Monk: Get confirmation when trying to insert template with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) 
[15:50:30] <grrrit-wm>	 (03PS2) 10Alex Monk: Get confirmation when trying to insert template with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) 
[15:50:50] <Krenair>	 James_F, so https://gerrit.wikimedia.org/r/156559 only checks when inserting a template. I'm not sure about making it apply when editing an existing one...
[15:50:53] <Krenair>	 Some editor inserts a template (probably manually through the wikitext editor) with a required parameter missing, then another one comes along and might be confused that VE is complaining about this
[15:50:54] <Krenair>	 although as it's required parameters, supposedly the template will appear broken. so I guess...
[15:50:57] <grrrit-wm>	 (03PS3) 10Alex Monk: Get confirmation when trying to insert/edit template with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) 
[15:51:31] <Krinkle>	 mooeypoo: did you get my last few messages an hour ago before the net split?
[15:51:53] <Krinkle>	 mooeypoo: Perhaps disable the colouring by default and only do it when clicking Import?
[15:52:29] <Krinkle>	 I think we should also improve the UX on that and have it explain that somewhere. The blue background shade didn't seem meaningful at first. 
[15:52:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Get confirmation when trying to insert/edit template with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk)
[15:52:52] <Krinkle>	 But that's for later.
[15:53:16] <grrrit-wm>	 (03PS4) 10Alex Monk: Get confirmation when trying to insert template with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) 
[15:54:15] <mooeypoo>	 Krinkle, this is frustratingly baffling, but I see what's going on (and I need your help) it's seems to be something with the API. When the code fetches the template from the page above, it asks the API for the template code, but it seems to be getting what we *see* rather than the code itself. 
[15:54:34] <mooeypoo>	 more to the point, I have this in Template:Unsigned when I look in code view: [[User:{{{user|{{{1}}}}}}|{{{user|{{{1}}}}}}]] ([[User talk:{{{user|{{{1}}}}}}|talk]] � [[Special:Contributions/{{{user|{{{1}}}}}}|contribs]]) {{{timestamp|{{{2|}}}}}}
[15:54:54] <Krenair>	 PS2 removed an if statement, PS3 added '/edit' to the change title, PS4 removed unused variables. PS5 will re-add '/edit' to the title because I accidentally undid that in PS4.
[15:54:57] <Krinkle>	 brb in 1h, sorry.
[15:55:06] <Krenair>	 I am way too quick to submit these
[15:55:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Get confirmation when trying to insert template with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk)
[15:55:07] <mooeypoo>	 Krinkle, but in "View" I see this: [[User:{{{1}}}|{{{1}}}]] ([[User talk:{{{1}}}|talk]] � [[Special:Contributions/{{{1}}}|contribs]]) and that's also what the templatedata edito is getting from the API, which means it only thnks it has "{{{1}}}" as a parameter
[15:55:52] <mooeypoo>	 anyone has any idea about this? View and source are different in the template, and the API is bringing up the wrong one... :\
[15:56:58] <mooeypoo>	 and I'm using action=expandtemplates in the API
[15:57:07] <mooeypoo>	 eh.
[15:57:21] <grrrit-wm>	 (03PS5) 10Alex Monk: Get confirmation when trying to insert/edit template with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) 
[15:57:26] <mooeypoo>	 Krenair, you deal with the API a lot, no? Any ideas, perhaps?
[15:59:09] <Krenair>	 This is not really about "the API" itself, but let's see
[15:59:26] <mooeypoo>	 it's an api reply, and it's shotty. Meh.
[15:59:54] <mooeypoo>	 It's not showing me the full parameters, as if it's eating them up. Only showing the internal param {{{1}}} in the API response. How annoying
[15:59:59] <Krenair>	 What request are you sending?
[16:01:43] <mooeypoo>	 Krenair, https://gerrit.wikimedia.org/r/#/c/134928/29/modules/ext.templateDataGenerator.core.js <-- line #525
[16:01:46] <tommorris>	 One does not simply use VisualEditor in Opera. https://imgflip.com/i/bjw2y ;-)
[16:01:55] * tommorris attempts to use VisualEditor in Opera.
[16:02:50] <Krenair>	 Ew, $.ajax
[16:02:51] <Krenair>	 You know about the mediawiki.api module mooeypoo?
[16:02:55] <mooeypoo>	 Krenair, it's outside of VE, so I didn't have much choice--- or.. maybe.. I do
[16:02:56] <mooeypoo>	 no?
[16:04:39] <Krenair>	 mooeypoo, Okay so looking at the request you're making, you give it no parameters
[16:04:39] <Krenair>	 So it does not substitute anything.
[16:04:39] <mooeypoo>	 why? action=parsetemplate&prop=wikitext ...
[16:04:39] <mooeypoo>	 I need the raw code
[16:04:39] <mooeypoo>	 oh... wiat, maybe I should ask for the wikitext without expandtemplate
[16:06:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Get confirmation when trying to insert/edit template with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk)
[16:09:28] <mooeypoo>	 s/parsetemplate/expandtemplate
[16:09:28] <mooeypoo>	 the other way around
[16:09:28] <Krenair>	 what?
[16:09:28] <mooeypoo>	 okay, sorry, I got confused.
[16:09:28] <mooeypoo>	 I'm doing a request to the API with action=expandtemplate
[16:09:29] <Krenair>	 Yes
[16:09:29] <mooeypoo>	 I need the raw wikitext of the template back
[16:09:29] <mooeypoo>	 do I need to instead just request for the wikitext in that page?
[16:09:29] <Krenair>	 Don't you get the raw wikitext back?
[16:09:29] <mooeypoo>	 no
[16:09:30] <Krenair>	 What do you get back and what are you expecting to get back, exactly?
[16:09:30] <mooeypoo>	 This is the raw code in my local template: 
[16:09:30] <mooeypoo>	 [[User:{{{user|{{{1}}}}}}|{{{user|{{{1}}}}}}]] ([[User talk:{{{user|{{{1}}}}}}|talk]] � [[Special:Contributions/{{{user|{{{1}}}}}}|contribs]]) {{{timestamp|{{{2|}}}}}}
[16:09:30] <mooeypoo>	 what I get from the api is this:
[16:09:30] <mooeypoo>	 [[User:{{{1}}}|{{{1}}}]] ([[User talk:{{{1}}}|talk]] � [[Special:Contributions/{{{1}}}|contribs]])
[16:09:31] <mooeypoo>	 See? it "eats up" the {{{user and {{{timestamp
[16:09:31] <Krenair>	 Yeah
[16:09:31] <Krenair>	 You don't provide it with a user parameter
[16:09:31] <mooeypoo>	 Those are important for the templatedata editor, because they're parameters I want to display/import
[16:09:31] <Krenair>	 So it gives you {{{1}}}
[16:09:31] <Krenair>	 That's how templates work
[16:09:31] <mooeypoo>	 hmm. 
[16:09:31] <mooeypoo>	 okay, how can I get just the raw contents, then? ask for the page content (as if it's an article) without consideration of template?
[16:09:32] <Krenair>	 Well then you would end up with <noinclude>/<includeonly> stuff
[16:09:33] <Krenair>	 on most templates on production sites
[16:10:01] <mooeypoo>	 i'm fine with that, I have a code that checks for {{{stuff to pick up the parameter names
[16:12:31] <Krinkle>	 mooeypoo: Hm.. you're having it parse the wikitext instead of returning the wikitext?
[16:12:35] <Krinkle>	 That's odd.
[16:12:49] <Krinkle>	 I guess you just want to action=raw it, or action=query&list=revisions prop=content (or something)
[16:13:02] <Krinkle>	 raw wikitext, right?
[16:13:28] <mooeypoo>	 I just need the raw code
[16:13:28] <Krenair>	 If you really want just the contents of the page, you don't even need the API, you can just use action=raw instead of the default action=view to index.php
[16:14:13] <Krenair>	 But you can use the API too: https://en.wikipedia.org/w/api.php?action=query&prop=revisions&rvprop=content&format=jsonfm&titles=Main%20Page
[16:15:45] <mooeypoo>	 Krenair, I need the API because it might be a parent page. So, I request the template code that exists in Template:Blah while I am inside Template:Blah/doc
[16:15:46] <Krenair>	 What feature are you trying to make with this exactly?
[16:15:46] <mooeypoo>	 The TemplateData Editor is importing parameter names from the template code
[16:15:46] <mooeypoo>	 for documentation. So, in the example above, you want the editor to show "user", "1" and "timestamp" as the parameter names available in the code for the user to document for the templatedata
[16:15:46] <mooeypoo>	 It's a fairly basic importer; it only cares to look for {{{paramname stuff
[16:15:46] <mooeypoo>	 but it helps users document templates.
[16:15:46] <Krenair>	 And you want to parse those out of the wikitext?
[16:15:46] <mooeypoo>	 Yes, that seems like the best way?
[16:15:46] <Krenair>	 Well that will completely fail when it hits a Scibunto invocation, like Template:Cite_web
[16:15:46] <mooeypoo>	 It's actually based off of a similar fnction gadget that was done in hewiki.
[16:15:47] <Krenair>	 But you can't do much about that
[16:15:50] <Krenair>	 Scribunto*
[16:15:57] <mooeypoo>	 It won't be perfect.. it also won't recognize conditional parameters too well
[16:16:04] <wikibugs>	 3MediaWiki / 3ResourceLoader: Make ResourceLoader a standalone library - 10https://bugzilla.wikimedia.org/30956#c4 (10Krinkle) p:5Low>3Lowest Both in the design and implementation we've done pretty well in keeping ResourceLoader independent from MediaWiki, but it has been integrated a little bit here and...
[16:16:07] <mooeypoo>	 but for the basic stuff, it can help
[16:16:25] <mooeypoo>	 But for that, I need the raw content of the page, I think.
[16:17:24] <Krenair>	 Hmm. I wonder if Parsoid can be helpful for this
[16:17:28] <mooeypoo>	 Krinkle, I do want that, but for some reason I misunderstood the docs and thought that was how you get templates
[16:17:28] <mooeypoo>	 I thought it meant it *expands* the template for you, but apparently that wasn't the meaning
[16:18:05] <mooeypoo>	 Docs are really confusing.
[16:20:25] <Krenair>	 view-source:parsoid-lb.eqiad.wikimedia.org/enwiki/Template%3AUnsigned
[16:21:05] <Krenair>	 I wonder if you can do something with those <span typeof="mw:Param">s ?
[16:23:12] <grrrit-wm>	 (03PS6) 10Alex Monk: Get confirmation when trying to insert/edit template with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) 
[16:23:47] <mooeypoo>	 action=query&prop=revisions&rvprop=content&format=jsonfm&titles=Template:Unsigned seems to work
[16:27:56] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: update to fix deprecated API token call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156574 
[16:29:03] <Krenair>	 mooeypoo, https://www.mediawiki.org/wiki/ResourceLoader/Default_modules#mediawiki.api
[16:30:23] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=106906955
[16:30:23] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on cawiki: https://ca.wikipedia.org/?diff=13974927
[16:31:12] <mooeypoo>	 Krenair, yea, I started reading that
[16:31:15] <mooeypoo>	 thanks
[17:09:05] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] "Ah, even better. Let's not change our versioning for this then. Just a regular release." [oojs/core] - 10https://gerrit.wikimedia.org/r/155589 (owner: 10Catrope)
[17:14:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Make OO.EventEmitter#validateMethod private [oojs/core] - 10https://gerrit.wikimedia.org/r/155589 (owner: 10Catrope)
[17:30:00] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Command-x (cut) triggers browser's Undo (Command-z) in Safari - 10https://bugzilla.wikimedia.org/58724#c2 (10Aditya Bhatt) Created attachment 16293   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16293&action=edit Patch to prevent undo on cut  Here's a pa...
[17:30:31] <grrrit-wm>	 (03CR) 10Dduvall: [C: 032] QA: update to fix deprecated API token call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156574 (owner: 10Cmcmahon)
[17:32:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: update to fix deprecated API token call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156574 (owner: 10Cmcmahon)
[17:36:18] <grrrit-wm>	 (03PS1) 10Alex Monk: Link target input widget: Make '' an invalid link target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156582 (https://bugzilla.wikimedia.org/70015) 
[17:41:19] <grrrit-wm>	 (03PS30) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) 
[17:41:29] <grrrit-wm>	 (03PS31) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) 
[17:41:43] <mooeypoo>	 ha. That works now.
[17:42:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo)
[17:43:24] <mooeypoo>	 .... damn you, jenkins.
[17:46:15] <grrrit-wm>	 (03PS32) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) 
[17:56:14] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo)
[18:00:14] <mooeypoo>	 edsanders, any reason for the -1? I am not seeing the comments, I feel like I'm missing something
[18:00:32] <grrrit-wm>	 (03CR) 10Esanders: Refactor TemplateData Editor (0326 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo)
[18:00:41] <mooeypoo>	 There they are! :D
[18:09:27] <mooeypoo>	 edsanders, just curious, is there a preference to use if/then vs 'switch'? I rmeember reading about it and finding no clear advantage for either (or I may be remembering wrong) -- is this just a matter of code style?
[18:09:58] <edsanders>	 I think when you are doing what a switch was designed to do it makes sense and is more readable
[18:10:17] <edsanders>	 otherwise I'm scanning each 'else if' to see if it's the same variable being tested
[18:10:30] * mooeypoo nods
[18:10:52] <mooeypoo>	 makes sense. I thought it might have speed advantages, but I think the internet is arguing about that point.
[18:16:30] <RoanKattouw>	 jgonera: Hey shouldn't https://bugzilla.wikimedia.org/show_bug.cgi?id=69630 be closed? I thought it was fixed? Or did I miss something?
[18:18:22] <jgonera>	 RoanKattouw, yep, done
[18:18:28] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [iOS] abandoning edit takes me to unscrollable page - 10https://bugzilla.wikimedia.org/69630#c9 (10Juliusz Gonera) 5ASSI>3RESO/FIX All patches merged, marking as fixed.
[18:18:31] <RoanKattouw>	 OK I'll close it as fixed then
[18:18:40] <RoanKattouw>	 Oh you beat me to it :P
[18:18:52] <RoanKattouw>	 Did you see https://bugzilla.wikimedia.org/show_bug.cgi?id=68832 got reopened BTW?
[18:19:06] <RoanKattouw>	 It works when you first load the editor, but breaks after you open and close the link inspector
[18:21:53] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf16] Cannot scroll up/down a page in mobile when the keyboard is open and cursor active on CE - 10https://bugzilla.wikimedia.org/68828#c7 (10Roan Kattouw) 5ASSI>3RESO/FIX This seems to still be broken-ish due to bug 68832, which means you ca...
[18:35:28] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Return of the whitespace bunny-hopping bug - 10https://bugzilla.wikimedia.org/69861 (10Roan Kattouw) 5PATC>3RESO/FIX
[18:36:51] <grrrit-wm>	 (03PS1) 10Adityab: Avoid undo when processing a cut event. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156593 (https://bugzilla.wikimedia.org/58724) 
[18:40:45] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Command-x (cut) triggers browser's Undo (Command-z) in Safari - 10https://bugzilla.wikimedia.org/58724#c3 (10Aditya Bhatt) Pushed a patch to gerrit.   https://gerrit.wikimedia.org/r/#/c/156593/
[18:41:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Incorrect highlight while trying to add reference in a slug - 10https://bugzilla.wikimedia.org/70065#c1 (10Roan Kattouw) It seems that if you insert a reference into a slug, the selection ends up as |<p>, <ref>, </ref>, </p>| rather than <p>, |<ref>, </ref>|, </p...
[18:42:41] <grrrit-wm>	 (03PS1) 10Catrope: Update VE core submodule to master (9e92194) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156595 
[18:43:39] <RoanKattouw>	 edsanders: I can haz +2? ---^^
[18:46:59] <grrrit-wm>	 (03PS3) 10Trevor Parscal: Divide CSS properties between base styles and themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/156211 
[18:48:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Divide CSS properties between base styles and themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/156211 (owner: 10Trevor Parscal)
[18:48:30] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Build with clean CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/156330 
[18:49:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Build with clean CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/156330 (owner: 10Trevor Parscal)
[18:53:34] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Command-x (cut) triggers browser's Undo (Command-z) in Safari - 10https://bugzilla.wikimedia.org/58724 (10Andre Klapper) 5ASSI>3PATC
[18:53:59] <grrrit-wm>	 (03PS2) 10Catrope: Avoid undo when processing a cut event. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156593 (https://bugzilla.wikimedia.org/58724) (owner: 10Adityab)
[18:55:26] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] "Looks fine to me, but Ed should look at this too since he's the master of copy/paste" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156593 (https://bugzilla.wikimedia.org/58724) (owner: 10Adityab)
[18:55:54] <RoanKattouw>	 Adityab: Awesome! Thanks for that patch
[18:56:19] <Adityab>	 :)
[18:56:20] <grrrit-wm>	 (03PS4) 10Trevor Parscal: Divide CSS properties between base styles and themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/156211 
[18:57:08] <Krinkle>	 mooeypoo: Well, 'expand' means invoke. It does expand the template. Template being the template itself, not the name
[18:57:27] <Krinkle>	 mooeypoo: you were looking to resolve the template name, to fetch the template entity.
[18:58:16] <Krinkle>	 e.g. the difference between reading: data.get('foo') and expanding/invoking: data.foo()
[18:58:35] <Krinkle>	 It's interesting that it worked at all though
[18:59:52] <Krinkle>	 well, sort of.
[19:00:28] <grrrit-wm>	 (03PS6) 10Trevor Parscal: Reorganize theme system [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 
[19:01:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Reorganize theme system [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 (owner: 10Trevor Parscal)
[19:02:37] <mooeypoo>	 Krinkle, yeah, I get that now. It works well now, though. I also fixed an issue with one of my promises. I'll go over Ed's comments when I get back tonight, I have to run soon.
[19:14:37] <grrrit-wm>	 (03PS7) 10Trevor Parscal: Reorganize theme system [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 
[19:15:59] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Stop users from deleting parameters in the template dialog if they're marked as "required" in TemplateData - 10https://bugzilla.wikimedia.org/60358#c3 (10Rummana Yasmeen) Verified the fix in Betalabs
[19:24:01] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Update VE core submodule to master (9e92194) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156595 (owner: 10Catrope)
[19:25:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (9e92194) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156595 (owner: 10Catrope)
[19:28:10] <grrrit-wm>	 (03PS8) 10Trevor Parscal: Reorganize theme system [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 
[19:33:01] <grrrit-wm>	 (03PS9) 10Trevor Parscal: Reorganize theme system [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 
[19:33:51] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Reorganize theme system [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 (owner: 10Trevor Parscal)
[19:34:06] <grrrit-wm>	 (03PS5) 10Catrope: Divide CSS properties between base styles and themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/156211 (owner: 10Trevor Parscal)
[19:34:12] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Divide CSS properties between base styles and themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/156211 (owner: 10Trevor Parscal)
[19:34:19] <grrrit-wm>	 (03PS10) 10Catrope: Reorganize theme system [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 (owner: 10Trevor Parscal)
[19:35:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Divide CSS properties between base styles and themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/156211 (owner: 10Trevor Parscal)
[19:38:37] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Reorganize theme system [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 (owner: 10Trevor Parscal)
[19:38:48] <grrrit-wm>	 (03PS3) 10Catrope: Build with clean CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/156330 (owner: 10Trevor Parscal)
[19:38:55] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Build with clean CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/156330 (owner: 10Trevor Parscal)
[19:39:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reorganize theme system [oojs/ui] - 10https://gerrit.wikimedia.org/r/156464 (owner: 10Trevor Parscal)
[19:39:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Build with clean CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/156330 (owner: 10Trevor Parscal)
[19:47:01] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] The trash icon for deleting other templates/parameters/content gets missing from the left panel of transclusion dialog after selecting a required parameter - 10https://bugzilla.wikimedia.org/70101 (10Rummana Yasmeen) 3NEW p:3Unprio s:3...
[19:49:58] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] The trash icon for deleting other templates/parameters/content gets missing from the left panel of transclusion dialog after selecting a required parameter - 10https://bugzilla.wikimedia.org/70101#c1 (10Rummana Yasmeen) Created attachment 1...
[19:49:59] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] The trash icon for deleting other templates/parameters/content gets missing from the left panel of transclusion dialog after selecting a required parameter - 10https://bugzilla.wikimedia.org/70101 (10Rummana Yasmeen) 5NEW>3ASSI a:3Alex...
[20:00:43] <grrrit-wm>	 (03PS1) 10Alex Monk: Toggle trash button (on transclusion dialog) visibility when changing to non-parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156671 (https://bugzilla.wikimedia.org/70101) 
[20:02:15] <grrrit-wm>	 (03PS3) 10Trevor Parscal: Make OO.ui.Window's $content a div again [oojs/ui] - 10https://gerrit.wikimedia.org/r/155181 (owner: 10Catrope)
[20:02:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make OO.ui.Window's $content a div again [oojs/ui] - 10https://gerrit.wikimedia.org/r/155181 (owner: 10Catrope)
[20:05:13] <grrrit-wm>	 (03PS4) 10Trevor Parscal: Make OO.ui.Window's $content a div again [oojs/ui] - 10https://gerrit.wikimedia.org/r/155181 (owner: 10Catrope)
[20:19:00] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: All kind of search is extremely slow in Betalabs which includes searching for matching link target names,images, category names, templates etc - 10https://bugzilla.wikimedia.org/70103 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None I am observing deg...
[20:22:28] <grrrit-wm>	 (03PS5) 10Trevor Parscal: Make OO.ui.Window's $content a div again [oojs/ui] - 10https://gerrit.wikimedia.org/r/155181 (owner: 10Catrope)
[20:24:23] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] Make OO.ui.Window's $content a div again [oojs/ui] - 10https://gerrit.wikimedia.org/r/155181 (owner: 10Catrope)
[20:24:43] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Make OO.ui.Window's $content a div again [oojs/ui] - 10https://gerrit.wikimedia.org/r/155181 (owner: 10Catrope)
[20:25:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make OO.ui.Window's $content a div again [oojs/ui] - 10https://gerrit.wikimedia.org/r/155181 (owner: 10Catrope)
[21:26:49] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Toggle trash button (on transclusion dialog) visibility when changing to non-parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156671 (https://bugzilla.wikimedia.org/70101) (owner: 10Alex Monk)
[21:28:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Toggle trash button (on transclusion dialog) visibility when changing to non-parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156671 (https://bugzilla.wikimedia.org/70101) (owner: 10Alex Monk)
[21:31:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] The trash icon for deleting other templates/parameters/content gets missing from the left panel of transclusion dialog after selecting a required parameter - 10https://bugzilla.wikimedia.org/70101 (10Alex Monk) 5PATC>3RESO/FIX
[21:34:37] <grrrit-wm>	 (03CR) 10Trevor Parscal: Split out isPending, pushPending, popPending, etc. into PendingElement (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/156459 (owner: 10Alex Monk)
[21:38:24] <grrrit-wm>	 (03CR) 10Esanders: "I didn't write the execCommand thing, so will do some browser testing to check, but it looks sensible." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156593 (https://bugzilla.wikimedia.org/58724) (owner: 10Adityab)
[21:39:00] <grrrit-wm>	 (03PS3) 10Alex Monk: Split out isPending, pushPending, popPending, etc. into PendingElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/156459 
[21:39:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Split out isPending, pushPending, popPending, etc. into PendingElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/156459 (owner: 10Alex Monk)
[21:42:01] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Apologies for the extreme review delay :(" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) (owner: 10Bartosz Dziewoński)
[21:43:28] <RoanKattouw>	 Krenair: Oh crap yeah you're going to have an interesting experience rebasing that patch there. Would you like help with that?
[21:43:41] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "Cutting in Firefox causes the cursor to reset to the start of the paragraph." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156593 (https://bugzilla.wikimedia.org/58724) (owner: 10Adityab)
[21:43:51] <RoanKattouw>	 (I merged Trevor's theme reorganization commit so any change to OOUI styles now causes non-obvious conflicts)
[21:46:11] <Krenair>	 RoanKattouw, I just have to reapply the src/themes/apex/widgets/TextInputWidget.less change in src/themes/apex/widgets.less don't I?
[21:46:20] <RoanKattouw>	 Yes
[21:46:34] <Krenair>	 I did it before seeing your message :p
[21:48:39] <Krenair>	 Although... I do have a weird issue building it now
[21:49:39] <Krenair>	 Nope, just me.
[21:49:53] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 04-1] Split out isPending, pushPending, popPending, etc. into PendingElement (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/156459 (owner: 10Alex Monk)
[21:56:57] <Krenair>	 TrevorParscal, so I made PendingElement take $pending
[21:57:29] <Krenair>	 But Dialog doesn't have that element we'll want to use set until the Window is initialised
[21:59:13] <TrevorParscal>	 ah
[21:59:19] <TrevorParscal>	 that is indeed an interesting problem
[21:59:29] <TrevorParscal>	 let me ponder on that for a moment
[22:00:45] <TrevorParscal>	 so, technically, as long as push/pop pending aren't called before the window is initialized, if you did this.$pending = this.$head (or whatever) in the initialize method
[22:00:45] <TrevorParscal>	 you should be fine
[22:00:55] <TrevorParscal>	 there's nothing specifically wrong with that
[22:01:06] <TrevorParscal>	 however, what do you then pass into PendingElement
[22:01:37] <TrevorParscal>	 i hate properties
[22:02:13] * TrevorParscal continues thinking
[22:05:17] <TrevorParscal>	 running crazy idea off roan before publicly logging it :)
[22:05:28] <wikibugs>	 3VisualEditor: VisualEditor:  Selection overlaps menu in Monobook, so you can't click on the covered items - 10https://bugzilla.wikimedia.org/69949#c2 (10Roan Kattouw) I couldn't reproduce this bug, and realized it was specific to Monobook. There are other minor display issues with the toolbar in Monobook as w...
[22:06:25] <Krenair>	 :)
[22:13:56] <TrevorParscal>	 ok, so you know how I told you to take $pending?
[22:15:00] <TrevorParscal>	 we want to move away from that, actually (cough) and instead either generate an element inside the mixin constructor (like in the case of icon, indicator and label) or always use $element (like in flaggable)
[22:17:03] <TrevorParscal>	 so... I think you should still drop the whole thing where you take $element as an argument of push/pop pending
[22:17:28] <TrevorParscal>	 but, you should not take $pending in the constructor, isntead always operate on this.$element
[22:17:32] <TrevorParscal>	 and, int he case of dialog
[22:18:56] <TrevorParscal>	 just override the push/pop (as you already do) and add/remove the pending class to this.$content as well so it can be selected against even in the case of isolated windows
[22:19:06] <TrevorParscal>	 where the iframe would otherwise prevent the CSS from cascading
[22:21:13] <TrevorParscal>	 so... I'm going to write a patch that cleans this up
[22:21:21] <TrevorParscal>	 and then you can base your work on that
[22:21:22] <RoanKattouw>	 s/in the case of dialog/in the case of OO.ui.Window/
[22:21:32] <TrevorParscal>	 sorry for this architecture mistake
[22:22:02] <RoanKattouw>	 Dude but thanks for making us run into this, now we're rearchitecting most of our commonly used mixins and making them nicer
[22:30:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] The trash icon for deleting other templates/parameters/content gets missing from the left panel of transclusion dialog after selecting a required parameter - 10https://bugzilla.wikimedia.org/70101#c4 (10Rummana Yasmeen) Verified the fix in...
[23:18:44] <grrrit-wm>	 (03PS1) 10Catrope: Fix various bugs in our Monobook stylesheet [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156723 (https://bugzilla.wikimedia.org/69949) 
[23:19:48] <legoktm>	 RoanKattouw: MonoBook*
[23:20:26] <grrrit-wm>	 (03PS1) 10Catrope: Followup 6ede2d8: fix popup font size [oojs/ui] - 10https://gerrit.wikimedia.org/r/156726 
[23:20:26] <RoanKattouw>	 Urgh
[23:20:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix various bugs in our Monobook stylesheet [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156723 (https://bugzilla.wikimedia.org/69949) (owner: 10Catrope)
[23:21:00] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor Mobile: The page focus always bumps up to the top irrespective of cursor position - 10https://bugzilla.wikimedia.org/70111 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce:  1.Open a page with mobile VE 2.Tap somewhere in the middle...
[23:21:13] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: The page focus always bumps up to the top irrespective of cursor position - 10https://bugzilla.wikimedia.org/70111 (10Rummana Yasmeen)
[23:21:43] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697#c8 (10Rummana Yasmeen) The original issue that cursor jumps to the beginning of the article is resolved,...
[23:28:21] <grrrit-wm>	 (03PS2) 10Catrope: Fix various bugs in our Monobook stylesheet [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156723 (https://bugzilla.wikimedia.org/69949) 
[23:37:25] <ryasmeen>	 jgonera: I am throwing this one to your bucket :https://bugzilla.wikimedia.org/show_bug.cgi?id=66697
[23:38:49] <ryasmeen>	 jgonera: sorry not that one, that issue got resolved but there is still something wrong with the page focus , which is reported in this one instead:https://bugzilla.wikimedia.org/show_bug.cgi?id=70111
[23:39:16] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: The page focus always bumps up to the top irrespective of cursor position - 10https://bugzilla.wikimedia.org/70111 (10Rummana Yasmeen) 5NEW>3ASSI a:3Juliusz Gonera
[23:40:25] <jgonera>	 ryasmeen, commented on it
[23:40:28] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: The page focus always bumps up to the top irrespective of cursor position - 10https://bugzilla.wikimedia.org/70111#c1 (10Juliusz Gonera) "The page focus bumps up to the top of the page" - you mean the page is scrolled to the top or the cursor moves to the top?
[23:42:58] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: The page focus always bumps up to the top irrespective of cursor position - 10https://bugzilla.wikimedia.org/70111#c2 (10Rummana Yasmeen) The page scrolls up, the cursor is correctly positioned with the fix of https://bugzilla.wikimedia.org/show_bug.cgi?id=66697
[23:43:12] <ryasmeen>	 jgonera: commented back :)
[23:54:56] <grrrit-wm>	 (03PS1) 10Adityab: Avoid undo when processing a cut event. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156733 (https://bugzilla.wikimedia.org/58724) 
[23:55:42] <RoanKattouw>	 Adityab: Hmm I think you did something wonky there, you created a new Gerrit change
[23:55:43] <Adityab>	 duh, sorry, I'm not yet used to the gerrit workflow
[23:55:44] * RoanKattouw fixes
[23:55:47] <RoanKattouw>	 No worries
[23:56:00] <grrrit-wm>	 (03PS2) 10Catrope: Avoid undo when processing a cut event. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156733 (https://bugzilla.wikimedia.org/58724) (owner: 10Adityab)
[23:56:19] <RoanKattouw>	 OK that didn't work, let me try something else
[23:56:43] <wikibugs>	 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c18 (10Krinkle) Another solution would be to return early instead of wrap the whole thing.  While a return statement is not allowed in the global scope, a throw works...
[23:57:28] <wikibugs>	 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c19 (10Krinkle) Another solution would be to return early instead of wrap the whole thing.  While a return statement is not allowed in the global scope, a throw works...
[23:57:28] <grrrit-wm>	 (03PS3) 10Catrope: Avoid undo when processing a cut event. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156593 (https://bugzilla.wikimedia.org/58724) (owner: 10Adityab)
[23:57:40] <grrrit-wm>	 (03Abandoned) 10Catrope: Avoid undo when processing a cut event. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156593 (https://bugzilla.wikimedia.org/58724) (owner: 10Adityab)
[23:57:42] <Adityab>	 I've updated the patch with a fix for the firefox regression. How do I make add that to the same gerrit thread?
[23:57:47] <RoanKattouw>	 Ahm wohops
[23:57:57] <grrrit-wm>	 (03Restored) 10Catrope: Avoid undo when processing a cut event. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156593 (https://bugzilla.wikimedia.org/58724) (owner: 10Adityab)
[23:58:03] <grrrit-wm>	 (03Abandoned) 10Catrope: Avoid undo when processing a cut event. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156733 (https://bugzilla.wikimedia.org/58724) (owner: 10Adityab)
[23:58:15] <RoanKattouw>	 OK ignore my thrashing
[23:58:19] <Adityab>	 hehe np
[23:58:20] <RoanKattouw>	 I have now folded your change into https://gerrit.wikimedia.org/r/#/c/156593/
[23:58:26] <RoanKattouw>	 The canonical way that you do that is:
[23:58:31] <RoanKattouw>	 make changes, git commit --amend, git review
[23:58:58] <RoanKattouw>	 Adityab: https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change