[00:00:22] (03CR) 10Catrope: Avoid undo when processing a cut event. (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156593 (https://bugzilla.wikimedia.org/58724) (owner: 10Adityab) [00:00:36] ok, thanks [00:00:48] Adityab: In case you want to try that out, here's a nitpick for you ---^^ [00:02:52] (03CR) 10Catrope: [C: 032] Link target input widget: Make '' an invalid link target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156582 (https://bugzilla.wikimedia.org/70015) (owner: 10Alex Monk) [00:04:30] RoanKattouw: ! [remote rejected] HEAD -> refs/publish/master/bug/58724 (change 156733 closed) [00:04:46] (03Merged) 10jenkins-bot: Link target input widget: Make '' an invalid link target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156582 (https://bugzilla.wikimedia.org/70015) (owner: 10Alex Monk) [00:04:47] Ugh right [00:04:53] That's because of the weird stuff that we did with the two changes [00:05:01] So it points to that closed review, hmm, not sure how that even happened in the first place [00:05:03] When you run git commit --amend it gives you an opportunity to edit the commit message [00:05:11] When you get that opportunity, change the Change-Id to: [00:05:22] I8f3f608e3f0c1bbfd2cda9543bcf7eeea6fa7c37 [00:05:31] the one in the original review? [00:05:38] ack [00:05:41] Also, an easier way to do this is to just fetch my version of the change [00:05:47] Using git review -d 156593 [00:06:16] In that one I also removed the blank line between Bug: 58724 and the Change-Id: line (unfortunately that blank line breaks the Bugzilla bot) [00:06:31] (03PS4) 10Adityab: Avoid undo when processing a cut event. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156593 (https://bugzilla.wikimedia.org/58724) [00:06:35] Then when you've fetched my version of the change, you can edit the file, amend, and git review [00:06:55] OK cool that one came through [00:07:06] RoanKattouw: thanks, I'll keep that in mind the next time :) [00:07:14] 3VisualEditor / 3Editing Tools: VisualEditor: Open button in link inspector should be disabled when the link target field is empty - 10https://bugzilla.wikimedia.org/70015 (10Alex Monk) 5PATC>3RESO/FIX [00:07:43] Adityab: Fetching the latest version is encouraged in general, because other people might make changes to the code as well (I just changed the commit message there) [00:07:56] or they might rebase your change, or whatever [00:10:00] RoanKattouw: ah ok [00:10:29] RoanKattouw: Is it a good practice to rebase on master before uploading a new version of the patch? [00:10:54] For the gerrit workflow, that is [00:11:35] It's good practice to not rebase and make real changes in the same version [00:11:46] Because that makes diffs between patchsets impossible to interpret [00:11:58] 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c20 (10Krinkle) (In reply to Krinkle from comment #19) > Another solution would be to return early instead of wrap the whole thing. > > While a return statement is no... [00:12:02] okay [00:12:08] So we do not want people to do: git rebase master; make changes; git commit --amend -a; git review [00:12:20] We do want people to do: git rebase master; git review; make changes; git commit --amend -a; git review [00:12:45] makes sense [00:13:15] 3OOjs UI: OOjs UI: MenuWidget does not resize correctly when being clipped - 10https://bugzilla.wikimedia.org/70115 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None 1. Open the link inspector 2. Type something that will get a lot of suggestions (e.g. "M") 3. Resize the window so that the suggestions m... [00:25:51] (03CR) 10Adityab: "Sorry about that hiccup." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156593 (https://bugzilla.wikimedia.org/58724) (owner: 10Adityab) [01:15:42] (03CR) 10Catrope: [C: 04-1] Make the image model persistent (037 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) (owner: 10Mooeypoo) [01:57:05] (03PS1) 10Alex Monk: Pick up 'summary' parameter from URL to use as initial edit summary [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156744 (https://bugzilla.wikimedia.org/69501) [11:41:13] 3VisualEditor: VisualEditor: Duplicating categories (and possibly also something else) - 10https://bugzilla.wikimedia.org/54169 (10Elitre) [11:41:13] 3VisualEditor / 3Data Model: VisualEditor: categories being duplicated - 10https://bugzilla.wikimedia.org/52238 (10Elitre) [11:59:28] (03CR) 10Esanders: [C: 04-2] "This approach has a major flaw. While in Chrome onCopy writes straight to the clipboard with the clipboardData API, we can't do that in FF" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156593 (https://bugzilla.wikimedia.org/58724) (owner: 10Adityab) [12:11:21] (03PS1) 10Esanders: Remove unnecessary execCommand('undo') from onCut [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156776 (https://bugzilla.wikimedia.org/58724) [12:14:35] (03CR) 10Esanders: "I believe the solution is actually quite trivial, see I2269e0ec" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156593 (https://bugzilla.wikimedia.org/58724) (owner: 10Adityab) [12:29:10] Hi guys, finally i got my VE up and running. [12:29:38] now i'm trying to use it, how do i use the insert media? i've uploaded a picture and i cant see it in the insert media, should i need to do something else? [12:32:28] I see in the ve help that i can drag and drop a picture into the dialog, but it is not working form e. [12:35:39] edsanders: Wow, that's fantastic. Safari actually reopens a closed window with a mere undo command, and js can actually trigger that [12:35:47] that's amazingly horrible [12:35:59] pretty bad [12:36:26] ...and if you put it in a while(true) ? [12:36:41] Yeah [12:37:36] I mean, considering js can do window.open or location.href or create iframes, it's not completely of interest to be able to reload some url. And there is history.go(-1) as well to go back to a url that is not just going to make an http request but use past user data we don't ahve access too. [12:38:06] but doing it on undo is creepy [12:39:12] (03PS1) 10Esanders: Trigger handleDelete inside onCut [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156781 [12:39:36] ^^ this commit is very nice [12:40:03] Anyone can try help with my problem ? [12:40:23] edsanders: Does exec command 'undo' not do anything then (aside from weird stuff in Safari). One would think that no longer happening will affect how the CE ends up. [12:40:50] or is the native behaviour good enough where it prevously wasn't? [12:40:50] we don't touch the CE anymore since we rewrote onCopy last year [12:40:56] (03CR) 10jenkins-bot: [V: 04-1] Trigger handleDelete inside onCut [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156781 (owner: 10Esanders) [12:41:00] but cut should still remove it from view, where copy doesn't. [12:41:04] no [12:41:09] cut call oncopy [12:41:16] which moves the selection to the pastetarget [12:41:40] regular copy copies it to the pastetarget, in cut we move it? [12:41:55] (03CR) 10Hashar: "The JSduck is my fault. I am fixing up the job sorry." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156781 (owner: 10Esanders) [12:41:55] that'd solve it, yeah, itd already be removed in taht case [12:42:13] onCopy moves the it to the pasteTarget [12:42:28] see the second commit [12:42:42] onCut is just two commands: this.onCopy();this.handleDelete(); [12:43:20] yeah, but I'm looking at the state before that second commit after that first commit. [12:43:22] OK, I see now. [12:43:24] the native deletion from oncut will just happen in the pasteTarget [12:43:30] edsanders: removing the execCommand ('undo'...) block would mean that the browser would actually go ahead and delete the selected text, and then we would delete it again with a transaction, right? [12:43:30] onCopy itself is what makes the copy to the paste target [12:43:38] but we don't give a crap about that [12:43:44] s/block/line/ [12:44:01] Adityab, no, the selection is in the hidden $pasteTarget by this point [12:44:14] we don't actually copy/cut from the view anymore [12:44:30] haven't done for over a year [12:44:32] and in regular copy when then restore selection (CE and original data model were unchanged, the paste target got a copy of some DOM, not moved). and in cut we then do a delete transaction, which auto-updates the rendering. [12:44:36] ah! [12:44:43] So the execCommand had really no effect [12:44:45] right? [12:44:45] we generate DM html and put it in a hidden DIV [12:45:06] ok [12:45:06] it was just undoing the removal of text from that hidden DIV, but we don't care what's in the hidden DIV [12:45:12] got it [12:46:04] also the deletion code in onCut was just a massively simplified version of handleDelete, which handles a bunch of edge cases much better, so the second commit fixes that [12:46:35] yeah, I figured that if onCopy is used there, why not use handleDelete, but decided it was best to not touch that till I knew better :P [12:47:32] (03CR) 10Krinkle: Trigger handleDelete inside onCut (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156781 (owner: 10Esanders) [12:47:55] (03CR) 10Krinkle: [C: 032] Remove unnecessary execCommand('undo') from onCut [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156776 (https://bugzilla.wikimedia.org/58724) (owner: 10Esanders) [12:48:10] (03CR) 10Hashar: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156781 (owner: 10Esanders) [12:48:50] Is there a jenkins product of VE generated from a patch that I can try out directly in the browser? [12:49:31] (03Merged) 10jenkins-bot: Remove unnecessary execCommand('undo') from onCut [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156776 (https://bugzilla.wikimedia.org/58724) (owner: 10Esanders) [12:54:40] (03Abandoned) 10Esanders: Avoid undo when processing a cut event. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156593 (https://bugzilla.wikimedia.org/58724) (owner: 10Adityab) [12:54:45] Adityab: If you have MediaWiki/Parsoid/VisualEditor installed on a server somewhere you can check out VisualEditor from Git (e.g. git clone to create that directory instead of downloading a zip and extracing that into your VE directory) [12:55:09] then you can checkout latest 'master' (or a specific patch) to run that version of VE. [12:56:24] Krinkle: No, I mean - if I publish a patch on gerrit, does jenkins generate a build of VE from it that I can just click on and test? [12:56:33] No [12:56:51] It does create a temporary install to run tests on but those are trashed after each run [12:56:56] (03PS2) 10Esanders: Trigger handleDelete inside onCut [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156781 [12:57:02] (03CR) 10Esanders: Trigger handleDelete inside onCut (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156781 (owner: 10Esanders) [12:57:04] and even during the run, they're on a private IP to avoid security hazards [12:57:11] ok [12:57:24] If you're needing to try it out to see how it works, you should have your own local install to play with. [12:57:35] Note that you don't need MediaWiki or Parsoid to test out Visualeditor locally. [12:57:40] We have a plain html/js/css demo [12:57:58] all you need is git, a web server and node/npm to build the demo. [12:58:10] yes, that's what I'm using :) [12:59:40] The idea of having a environment where you can test unmerged patches has come up before, and I support it, as do our testers. [13:00:18] It's way way down the list of priorities though. And will likely never happen if we don't hire more CI engineers (or at least 1 full time) [13:01:03] Having selenium tests in a more maintainable way, and actually run quick enough and (subset?) of them on each unmerged commit, an cross-browser unit testing, that'll happen first likely. [13:01:29] edsanders: what would be more feasible is a temporary downloadable artifact on Jenkins with just the html demo [13:01:39] which you can fetch and use over file:// locally [13:01:45] guys...... I see in the ve help that i can drag and drop a picture into the insert media dialog, but it is not working form me, someone can give me a lead ? [13:02:32] agepox, drag and drop? where does it say that? [13:03:20] it might be on our roadmap but AFAIK we've not implemented it yet [13:07:02] edsanders: http://community.wikia.com/wiki/Help:VisualEditor [13:08:17] Wikia have written their own extensions to VisualEditor which aren't available on Wikimedia projects [13:11:48] Oh, thanks for the information :) [13:12:12] edsanders: So maybe you can tell me why i can find in the insert media the pictures that i'm uploading throught the upload page? [14:05:02] 3VisualEditor / 3MediaWiki integration: Links to existing pages in the Education Program namespaces are marked as red links - 10https://bugzilla.wikimedia.org/70123 (10Helder) 3NEW p:3Unprio s:3normal a:3None On page https://pt.wikipedia.org/wiki/User:Alpha_Centaurus?veaction=edit&oldid=39924153&usel... [14:46:28] 3VisualEditor / 3ContentEditable: VisualEditor: Copy/pasting blanks page, prevents saving - 10https://bugzilla.wikimedia.org/61552 (10Ed Sanders) 5ASSI>3RESO/WOR [14:47:13] 3VisualEditor / 3ContentEditable: VisualEditor: Copying text sometimes makes the page jump/scroll in Firefox - 10https://bugzilla.wikimedia.org/55433 (10Ed Sanders) 5ASSI>3RESO/WOR [15:24:28] (03CR) 10Mooeypoo: "Answering comments (and 'done' for followup) -- new patchset will reflect changes." (0325 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [15:25:10] (03PS33) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) [15:25:19] edsanders, thanks for the review! [15:34:37] (03PS1) 10Jforrester: Update VE core submodule to master (c9304ac) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156806 [15:36:09] edsanders: ^^^ Want to merge that to get it in for wmf19? [15:36:53] (03CR) 10Jforrester: [C: 031] Trigger handleDelete inside onCut [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156781 (owner: 10Esanders) [15:39:31] Or Krenair or Krinkle? We have only a few minutes to merge this in… [15:40:14] 3VisualEditor / 3Editing Tools: VisualEditor: Command-x (cut) triggers browser's Undo (Command-z) in Safari - 10https://bugzilla.wikimedia.org/58724 (10James Forrester) 5PATC>3RESO/FIX a:3Ed Sanders [15:40:28] 3VisualEditor / 3ContentEditable: VisualEditor: Copying text sometimes makes the page jump/scroll in Firefox - 10https://bugzilla.wikimedia.org/55433 (10James Forrester) [15:44:53] (03CR) 10Krinkle: [C: 032] Update VE core submodule to master (c9304ac) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156806 (owner: 10Jforrester) [15:46:17] Thanks Krinkle. [15:47:05] (03Merged) 10jenkins-bot: Update VE core submodule to master (c9304ac) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156806 (owner: 10Jforrester) [15:51:39] mooeypoo: You in the midst of making the last tweaks to 149217 ("Make the image model persistent")? [15:51:43] agepox, if the image is recently uploaded I think it doesn't get into the search index for a while [15:52:00] which is a bug [15:53:31] James_F, uh, no? it's ready for review? [15:53:49] mooeypoo: It's -1'ed from Roan. [15:53:55] oh, i missed that [15:53:59] mooeypoo: I was going to +2 but… [15:54:36] James_F, got it, I'll work on it now. I need to run for a little to get my glasses, and work on it more when I get back [15:54:46] (though I think I can just finish up in a couple of minutes) [15:54:54] Sure. [15:57:14] James_F, is there a bug for recent images not showing up in the API? [15:57:39] if search has some heavy caching that we can't work around then we should use a different API call to get them [15:57:48] edsanders: It's been INVALID'ed. [15:57:53] as currently it's impossible to add a new image in VE [15:58:13] so we need a 'my recent uploads' section [15:58:20] edsanders: On the basis that the new search system shows new images immediately, and we're not fixing problems with the old search system, [15:58:30] and ETA? [15:58:34] edsanders: On most wikis VE uses the new search system. [15:58:44] Ha. Good question. Original deadline was early 2013. [15:58:50] "Soon." [15:58:57] so none use it yet? [15:59:22] No, about 895 of our 900 sites use it. [15:59:27] en? [16:00:05] No. [16:00:06] https://www.mediawiki.org/wiki/Search#Wikis [16:00:20] right, so an impressive but misleading statistic [16:00:49] that page says 61 [16:01:51] No, that's the "remaining". [16:02:03] I believe we switched the other 800 months ago. [16:02:17] You can ask Chad though. He'll know for sure. [16:02:53] James_F: I'm getting a not-logged-in notice when accessing http://commons.wikimedia.org/w/api.php?action=visualeditor&page=File:Foobar.jpg&format=json&paction=parse - known issue? [16:03:11] marktraceur: I works fine for me. Are you logged in? [16:03:46] ok [16:03:52] Yeah [16:03:55] edsanders: But yeah, old search sucks. [16:03:57] marktraceur: Hmm. [16:04:09] It works, it gives me the content, but there's a notice [16:04:23] Oh, hmm, no, you're right. [16:05:20] (03PS24) 10Mooeypoo: Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) [16:06:20] (03CR) 10Jforrester: [C: 032] Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) (owner: 10Mooeypoo) [16:07:03] woot [16:08:05] (03Merged) 10jenkins-bot: Make the image model persistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (https://bugzilla.wikimedia.org/69450) (owner: 10Mooeypoo) [16:08:12] \o/ [16:08:30] (03PS17) 10Jforrester: Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) (owner: 10Mooeypoo) [16:08:44] (Rebase onto master.) [16:09:20] awesomesauce. It should be ready for merge, if no reviews come [16:09:24] which remind me, I forgot to add people to review [16:09:50] There. [16:10:31] James_F: In a similar vein, is there documentation somewhere about how to handle the content API response on the client side? I remember you talking about frames or something, I think. [16:11:00] marktraceur: action=visualeditor is not a public API and should never be used except by VE itself. [16:11:43] Oh! Maybe you should take it out of the API docs? [16:11:43] marktraceur: The actual content API is being built by gwicke, and when that's done we'll switch to that. [16:11:44] 3VisualEditor / 3Editing Tools: VisualEditor: If you just change an image, the border parameter setting is lost - 10https://bugzilla.wikimedia.org/69450 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal [16:11:54] marktraceur: There's a bug asking for the API to be fixed so we can. [16:11:58] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000 (10James Forrester) 5PATC>3RESO/FIX [16:12:01] Cool. [16:12:16] marktraceur: Unfortunately certain people have threatened to WONTFIX. [16:12:43] marktraceur: Because clearly we should have built a parallel API system for private APIs rather than expecting more useful things from the system we have. [16:12:44] * James_F sighs. [16:12:56] Heh. [16:13:11] For the time, it's the most useful API resource I have for the job I want to do. [16:20:01] Sorry about that. :-( [16:20:09] (03CR) 10Krinkle: "Little extra info on deferred. The way you had it was quite good, better even. But maybe not for this specific case, but don't forget abou" (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [16:22:33] Ah well. [16:22:53] Do we know when gwicke will have the new API ready? [16:23:13] I don't, but your pinging him will probably get you an answer soon enough. :-) [16:23:24] Hopefully. [16:24:07] I may be able to do this with the existing API...not sure though. It will definitely be more painful :) [16:27:06] (03CR) 10Krinkle: [C: 04-1] "Done with CR (see comments for minor issues there). Doing another visual test now." (034 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [16:30:25] Corruption alert: visualeditor-needcheck on rowiki: https://ro.wikipedia.org/?diff=8806799 [16:30:25] Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=11791248 [16:30:25] Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=11791260 [16:30:25] Corruption alert: visualeditor-needcheck on svwiki: https://sv.wikipedia.org/?diff=27215101 [16:30:25] Corruption alert: visualeditor-needcheck on svwiki: https://sv.wikipedia.org/?diff=27215119 [16:30:26] Corruption alert: visualeditor-needcheck on svwiki: https://sv.wikipedia.org/?diff=27215139 [16:30:26] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=106920436 [16:30:27] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=106938995 [16:30:27] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32463870 [16:30:28] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65107413 [16:30:28] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65114224 [16:30:29] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65124027 [16:30:34] Oh dear. [16:30:38] That's… not good. [16:32:27] James_F, those all look okay except the svwiki guy [16:32:53] All the same user. [16:32:55] Hmmm. [16:33:21] Have you had any further thoughts about blocking that kind of stuff? [16:33:42] Given that we can't replicate locally I think we're going to have to attempt something and see if it helps. [16:35:21] (03CR) 10Jforrester: [C: 032] Followup 6ede2d8: fix popup font size [oojs/ui] - 10https://gerrit.wikimedia.org/r/156726 (owner: 10Catrope) [16:36:10] (03Merged) 10jenkins-bot: Followup 6ede2d8: fix popup font size [oojs/ui] - 10https://gerrit.wikimedia.org/r/156726 (owner: 10Catrope) [16:38:04] (03CR) 10Krinkle: "Using:" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [16:39:12] (03CR) 10Krinkle: "Also document it in the spec, and should presumably also be parsed/validated, consistently added to outpout, and tested." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/146395 (owner: 10Mooeypoo) [16:39:32] (03CR) 10Krinkle: [C: 031] Sort i18n files alphabetically for better diffs in future [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/145622 (owner: 10Jforrester) [16:39:49] James_F, I really want to see how it appears in the DOM and how VE handles it :/ [16:40:02] Someone on the team probably already knows, though [16:40:16] Krenair: I don't think they do… [16:44:43] 3OOjs UI: OOjs UI: [Regression wmf18] In VE, on the first attempt to invoke , the confirmation dialogs for switching to Read mode and Edit Source mode are appearing with a scroll bar and button placements are also not next to each other - 10https://bugzilla.wikimedia.org/70061 (10James Forrester) p:5Unprio>... [16:44:58] 3OOjs UI: OOjs UI: MenuWidget does not resize correctly when being clipped - 10https://bugzilla.wikimedia.org/70115 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [16:44:58] 3OOjs UI: OOjs UI: [Regression wmf18] In VE, on the first attempt to invoke , the confirmation dialogs for switching to Read mode and Edit Source mode are appearing with a scroll bar and button placements are also not next to each other - 10https://bugzilla.wikimedia.org/70061 (10James Forrester) 5NEW>3ASSI [16:45:13] 3OOjs UI: OOjs UI: images/ should not contain *.less files - 10https://bugzilla.wikimedia.org/69910 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Lowest s:5normal>3trivia [16:45:43] 3OOjs UI: OOjs UI: Trying to close a window before it's ready causes a JS error - 10https://bugzilla.wikimedia.org/69918 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [16:58:36] (03PS1) 10Jforrester: Fix remaining references to 'agora' not 'minerva' [oojs/ui] - 10https://gerrit.wikimedia.org/r/156818 [17:03:51] (03CR) 10Catrope: [C: 032] Fix remaining references to 'agora' not 'minerva' [oojs/ui] - 10https://gerrit.wikimedia.org/r/156818 (owner: 10Jforrester) [17:04:47] (03Merged) 10jenkins-bot: Fix remaining references to 'agora' not 'minerva' [oojs/ui] - 10https://gerrit.wikimedia.org/r/156818 (owner: 10Jforrester) [17:12:29] 3VisualEditor / 3Editing Tools: VisualEditor:Shrink back the Basic Reference dialog size - 10https://bugzilla.wikimedia.org/70016 (10Roan Kattouw) a:5Alex Monk>3Trevor Parscal [17:24:43] (03CR) 10Krinkle: Trigger handleDelete inside onCut (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156781 (owner: 10Esanders) [17:26:53] (03CR) 10Esanders: Trigger handleDelete inside onCut (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156781 (owner: 10Esanders) [17:35:40] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (d72addbeae) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156820 [17:37:16] (03CR) 10Krinkle: Trigger handleDelete inside onCut (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156781 (owner: 10Esanders) [17:39:58] 3VisualEditor / 3MediaWiki integration: VisualEditor: Edit summary box should be a text input box and not textarea - 10https://bugzilla.wikimedia.org/52133#c9 (10Amir E. Aharoni) Is it possible to meet in the middle: To show it as a textarea, but to allow saving using Enter/Return? And maybe provide autocomp... [17:41:49] (03CR) 10Jforrester: [C: 032] "Appears to make things notably better." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156723 (https://bugzilla.wikimedia.org/69949) (owner: 10Catrope) [17:43:41] (03Merged) 10jenkins-bot: Fix various bugs in our Monobook stylesheet [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156723 (https://bugzilla.wikimedia.org/69949) (owner: 10Catrope) [17:44:30] 3VisualEditor / 3MediaWiki integration: VisualEditor: Selection overlaps menu in Monobook, so you can't click on the covered items - 10https://bugzilla.wikimedia.org/69949 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal a:3Roan Kattouw [17:45:17] 3VisualEditor / 3MediaWiki integration: VisualEditor:Text style drop-down overridden by edit comment, in Monobook skin. - 10https://bugzilla.wikimedia.org/69263#c1 (10James Forrester) 5UNCO>3RESO/FIX p:5Unprio>3Low a:3Roan Kattouw Think that this may have been fixed by gerrit 156723. [17:46:00] 3VisualEditor / 3MediaWiki integration: VisualEditor: Caret looks disconnected from link box in Monobook skin when going to first letter of line - 10https://bugzilla.wikimedia.org/69242#c5 (10James Forrester) 5UNCO>3RESO/FIX p:5Unprio>3Low a:3Roan Kattouw Think that this may have been fixed by gerr... [17:51:19] (03CR) 10Krinkle: [C: 031] Trigger handleDelete inside onCut [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156781 (owner: 10Esanders) [18:11:59] 3VisualEditor / 3MediaWiki integration: VisualEditor: If 'summary' parameter is provided in URL, it should be the default edit summary - 10https://bugzilla.wikimedia.org/69501 (10James Forrester) p:5Unprio>3Normal a:3Alex Monk [18:20:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] The trash icon for deleting other templates/parameters/content gets missing from the left panel of transclusion dialog after selecting a required parameter - 10https://bugzilla.wikimedia.org/70101 (10James Forrester) p:5Unprio>3Normal [18:20:39] (03CR) 10Catrope: [C: 04-1] Update OOjs UI to v0.1.0-pre (d72addbeae) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156820 (owner: 10Jforrester) [18:27:50] (03CR) 10Catrope: [C: 032] Trigger handleDelete inside onCut [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156781 (owner: 10Esanders) [18:30:09] (03Merged) 10jenkins-bot: Trigger handleDelete inside onCut [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156781 (owner: 10Esanders) [18:32:36] (03PS1) 10Jforrester: build: Don't copy anything other than SVG and PNG files to /dist [oojs/ui] - 10https://gerrit.wikimedia.org/r/156835 [18:33:25] (03PS2) 10Jforrester: build: Don't copy anything other than SVG and PNG files to /dist [oojs/ui] - 10https://gerrit.wikimedia.org/r/156835 (https://bugzilla.wikimedia.org/69910) [18:39:56] (03CR) 10Catrope: [C: 032] build: Don't copy anything other than SVG and PNG files to /dist [oojs/ui] - 10https://gerrit.wikimedia.org/r/156835 (https://bugzilla.wikimedia.org/69910) (owner: 10Jforrester) [18:40:30] (03CR) 10Esanders: [C: 04-1] "unit tests? perhaps including one where you pass in a node with a sabotaged normalize method?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156444 (owner: 10Catrope) [18:40:50] (03Merged) 10jenkins-bot: build: Don't copy anything other than SVG and PNG files to /dist [oojs/ui] - 10https://gerrit.wikimedia.org/r/156835 (https://bugzilla.wikimedia.org/69910) (owner: 10Jforrester) [18:41:51] (03CR) 10Esanders: [C: 032] Try a bit harder not to create empty text nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156447 (owner: 10Catrope) [18:43:44] (03Merged) 10jenkins-bot: Try a bit harder not to create empty text nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156447 (owner: 10Catrope) [18:47:00] 3VisualEditor / 3MediaWiki integration: $wgVisualEditorParsoidForwardCookies should be unconditional - 10https://bugzilla.wikimedia.org/70131 (10Marc A. Pelletier) 3NEW p:3Unprio s:3normal a:3None There are use cases where the edit permission is allowed to '*' yet a cookie is necessary for editing ce... [18:47:13] edsanders: Is it possible to put contenteditable=false on a
directly rather than on a wrapping
? [18:47:27] edsanders: AFAICT that's the only way in which VE and Parsoid HTML differ right now… [18:50:14] 3VisualEditor / 3MediaWiki integration: $wgVisualEditorParsoidForwardCookies should be unconditional - 10https://bugzilla.wikimedia.org/70131#c1 (10Marc A. Pelletier) s/true/false/ obviously. [18:51:46] edsanders: Oh, ignore me, we already changed this, it's just not hit production yet. [19:06:48] (03PS1) 10Esanders: Only block language change if dir hasn't changed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156874 [19:09:09] (03CR) 10Catrope: [C: 032] Only block language change if dir hasn't changed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156874 (owner: 10Esanders) [19:10:57] (03Merged) 10jenkins-bot: Only block language change if dir hasn't changed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156874 (owner: 10Esanders) [19:11:36] (03CR) 10Esanders: [C: 032] Followup 355be3ed: fix getOffset() behavior inside block aliens [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156477 (owner: 10Catrope) [19:14:19] (03Merged) 10jenkins-bot: Followup 355be3ed: fix getOffset() behavior inside block aliens [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156477 (owner: 10Catrope) [19:34:35] so... If I want to checkout a copy of Parsoid that matches VE's REL1_23 branch, would my best bet be to go with the date of the VE branch? [19:35:11] Maybe? I don't think Parsoid made breaking changes since then though [19:35:17] You could ask over in #mediawiki-parsoid [19:35:28] ah... so many channels [19:35:35] ty RoanKattouw :) [19:35:54] Sorry :( but this is something the Parsoid folks will be able to answer better than em [19:35:56] *me [19:39:04] (03CR) 10Esanders: Refactor TemplateData Editor (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [19:39:46] 3VisualEditor / 3Technical Debt: VisualEditor: Image CE HTML should match Parsoid - 10https://bugzilla.wikimedia.org/66610#c3 (10James Forrester) 5ASSI>3RESO/FIX a:5Moriel Schottlender>3James Forrester Current Parsoid HTML:
... [19:39:58] 3VisualEditor / 3Editing Tools: VisualEditor:Shrink back the Basic Reference dialog size - 10https://bugzilla.wikimedia.org/70016 (10James Forrester) [19:39:58] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf16]Opening link inspector/comment box in an empty line, opens them at the end of the previous line - 10https://bugzilla.wikimedia.org/69122 (10James Forrester) [19:40:15] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any edit in mobile VE for Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66756 (10James Forrester) [19:40:15] 3VisualEditor / 3MediaWiki integration: VisualEditor: After saving a page reference list gets missing (unless it is refreshed again) and the page gets categorized as "Pages with missing reference list" - 10https://bugzilla.wikimedia.org/68182 (10James Forrester) [19:40:15] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Clicking in the document where an inspector was opened doesn't close the inspector - 10https://bugzilla.wikimedia.org/68679 (10James Forrester) [19:40:15] 3VisualEditor / 3Editing Tools: VisualEditor: Triggering context on link after defocus throws "TypeError: Cannot read property 'isCollapsed' of null" - 10https://bugzilla.wikimedia.org/68915 (10James Forrester) [19:40:27] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on Return while cursor is at the end of a text , deletes that text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66758 (10James Forrester) [19:40:28] 3VisualEditor / 3Editing Tools: VisualEditor:Link Inspector icon is not appearing, when language is selected, in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68810 (10James Forrester) [19:40:28] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - 10https://bugzilla.wikimedia.org/66604 (10James Forrester) [19:40:45] 3VisualEditor / 3Editing Tools: VisualEditor: In the media insertion dialog, give a tooltip on each item saying what will happen when you click it (i.e., "Click to insert as a thumbnail" or whatever) - 10https://bugzilla.wikimedia.org/52219 (10James Forrester) [19:40:45] 3VisualEditor / 3Editing Tools: VisualEditor: Support "substituting" templates in transclusion dialog - 10https://bugzilla.wikimedia.org/49904 (10James Forrester) [19:40:45] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10James Forrester) [19:40:45] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf12] The highlight for centered images is taking 100% width - 10https://bugzilla.wikimedia.org/67507 (10James Forrester) [19:40:58] 3VisualEditor / 3Data Model: VisualEditor: Cutting text undoes previous typing - 10https://bugzilla.wikimedia.org/57217 (10James Forrester) [19:40:58] 3VisualEditor / 3Editing Tools: VisualEditor: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - 10https://bugzilla.wikimedia.org/68590 (10James Forrester) [19:40:58] 3VisualEditor / 3Editing Tools: VisualEditor: In the media selector show name in a tooltip on mouseover - 10https://bugzilla.wikimedia.org/52459 (10James Forrester) [19:40:58] 3VisualEditor / 3ContentEditable: VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - 10https://bugzilla.wikimedia.org/50036 (10James Forrester) [19:40:59] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10James Forrester) [19:41:15] 3VisualEditor / 3Data Model: VisualEditor: Make transaction processing exception-safe - 10https://bugzilla.wikimedia.org/68892 (10James Forrester) [19:41:15] 3VisualEditor / 3ContentEditable: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - 10https://bugzilla.wikimedia.org/69474 (10James Forrester) [19:41:15] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping at the end of each link, does copy-paste of preceding link text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66755 (10James Forrester) [19:41:15] 3VisualEditor / 3Editing Tools: VisualEditor: Template dialog search widget wrongly uses suffix ellipsis until input is refocused - 10https://bugzilla.wikimedia.org/67385 (10James Forrester) [19:41:16] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195 (10James Forrester) [19:41:27] 3VisualEditor / 3ContentEditable: VisualEditor: Out-of-skin templates are taking editors to linked pages, rather than letting them edit the template - 10https://bugzilla.wikimedia.org/70074 (10James Forrester) [19:41:28] 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - 10https://bugzilla.wikimedia.org/67262 (10James Forrester) [19:41:28] 3VisualEditor / 3Editing Tools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - 10https://bugzilla.wikimedia.org/68537 (10James Forrester) [19:41:28] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10James Forrester) [19:41:29] 3VisualEditor / 3Editing Tools: VisualEditor: Append references list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906 (10James Forrester) [19:41:30] 3VisualEditor / 3Data Model: VisualEditor: Investigate parsing/rendering/behavior of "{{MW 1.23}}" on mediawiki.org [mini-tracking] - 10https://bugzilla.wikimedia.org/68297 (10James Forrester) [19:41:31] 3VisualEditor / 3MediaWiki integration: VisualEditor: Toolbar utilities menu items should not be cut off against browser edge - 10https://bugzilla.wikimedia.org/57366 (10James Forrester) [19:41:32] 3VisualEditor / 3Editing Tools: VisualEditor: Deleting the parameter of any template or the template itself, scrolls the focus up to the top of the transclusion dialog - 10https://bugzilla.wikimedia.org/62420 (10James Forrester) [19:41:33] 3VisualEditor / 3Data Model: VisualEditor: tags appear when editing on the Hebrew Wiki - 10https://bugzilla.wikimedia.org/66210 (10James Forrester) [19:41:44] 3VisualEditor / 3Mobile: VisualEditor Mobile: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110 (10James Forrester) [19:41:45] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843 (10James Forrester) [19:41:45] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438 (10James Forrester) [19:41:45] 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580 (10James Forrester) [19:42:53] mooeypoo: This one does not seem as fixed to me : https://bugzilla.wikimedia.org/show_bug.cgi?id=68000 [19:43:57] (03PS2) 10Catrope: Polyfill Node.prototype.normalize in IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156444 [19:44:19] mooeypoo: I tried with this image on Betalabs:http://en.wikipedia.beta.wmflabs.org/wiki/File:Black_sandbox.JPG [19:44:38] (03CR) 10Catrope: "PS2 adds tests. Not sure how much you and/or Timo like my method of sabotage, but I thought it was better than doing ve.isNormalizeBroken " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156444 (owner: 10Catrope) [19:45:17] (03CR) 10jenkins-bot: [V: 04-1] Polyfill Node.prototype.normalize in IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156444 (owner: 10Catrope) [19:46:22] (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (f6468b84e5) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156820 [19:47:11] (03PS3) 10Catrope: Polyfill Node.prototype.normalize in IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156444 [19:47:20] (03CR) 10Jforrester: Update OOjs UI to v0.1.0-pre (f6468b84e5) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156820 (owner: 10Jforrester) [19:51:38] (03PS1) 10Jforrester: build: Also white-list GIF files [oojs/ui] - 10https://gerrit.wikimedia.org/r/156889 [19:53:19] (03CR) 10Krinkle: [C: 04-1] "isNormalizeBroken is cached, so re-creating the broken environment (break native normalize) instead of setting isNormalizeBroken wouldn't " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156444 (owner: 10Catrope) [19:54:55] (03CR) 10Krinkle: [C: 04-1] "Use one pattern: "images/**/*.{svg,png}" to avoid repeating the whole thing and having it traverse the directories multiple times." [oojs/ui] - 10https://gerrit.wikimedia.org/r/156889 (owner: 10Jforrester) [19:55:23] (03PS2) 10Krinkle: build: Whitelist GIF files in the copy task [oojs/ui] - 10https://gerrit.wikimedia.org/r/156889 (owner: 10Jforrester) [19:55:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000#c10 (10Rummana Yasmeen) 5RESO/FIX>3REOP Still reproducible... [19:55:58] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000 (10Rummana Yasmeen) 5REOP>3ASSI [19:56:25] (03PS3) 10Jforrester: build: Also white-list GIF files [oojs/ui] - 10https://gerrit.wikimedia.org/r/156889 [19:56:45] Krinkle: Better/ [19:57:42] James_F: OED approves of whitelist being a verb. [19:57:56] I also added a bit of extra info to it. [19:58:21] Krinkle: You did? [19:58:23] Oh. [19:58:25] * James_F sighs. [19:58:36] And I over-wrote it because you did it too slowly. [19:58:39] yay for forced overwriting being the default [19:58:54] I even fetched the current version before making my changes. [19:59:09] Unfortunately, I clearly fetched a few seconds before you changed. [19:59:42] (03PS4) 10Jforrester: build: Also whitelist GIF files in the copy task [oojs/ui] - 10https://gerrit.wikimedia.org/r/156889 [19:59:49] over-wrote? un-fortunately, you fetched be-fore I changed it on gerr-it [20:05:04] (03CR) 10Krinkle: [C: 032] build: Also whitelist GIF files in the copy task [oojs/ui] - 10https://gerrit.wikimedia.org/r/156889 (owner: 10Jforrester) [20:05:20] James_F: Was there an update since the gif file got added? [20:05:26] Or is it still on time [20:05:44] pending.gif's been there for a year [20:05:49] ok, so we missed it. [20:05:55] (03Merged) 10jenkins-bot: build: Also whitelist GIF files in the copy task [oojs/ui] - 10https://gerrit.wikimedia.org/r/156889 (owner: 10Jforrester) [20:06:09] ah, no because the other one only got merged today [20:06:10] cool [20:06:11] Krinkle: Yeah, hence "also". [20:06:19] It's a follow-up. [20:06:29] Yes, which I added, but I see you didn't want to add that? [20:06:40] I had it in PS2 [20:06:46] No, you removed "also", I added it back in. [20:06:53] look again [20:07:12] Oh, the second line? [20:07:18] That's not our standard form. [20:08:19] (03CR) 10Catrope: "OK yeah that's a very good point. If anything calls normalizeNode before this test does (like, I don't know, the converter tests), the fea" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156444 (owner: 10Catrope) [20:09:15] (03PS4) 10Catrope: Polyfill Node.prototype.normalize in IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156444 [20:09:21] Oh well, next time hopefully I'll spot it. :-) [20:09:38] Krinkle: Thanks for knowing how my own code that I wrote this week works better than I do :) [20:10:17] (03PS3) 10Jforrester: Update OOjs UI to v0.1.0-pre (43f379c884) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156820 [20:11:43] 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c21 (10Bartosz Dziewoński) I quite like the document.write one, seems it will have the least impact on users with non-broken user JS and should be easy to implement? [20:15:14] 3OOjs UI: OOjs UI: images/ should not contain *.less files - 10https://bugzilla.wikimedia.org/69910 (10James Forrester) 5PATC>3RESO/FIX a:3James Forrester [20:16:30] 3MediaWiki / 3ResourceLoader: [Regression] Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924 (10Krinkle) [20:25:03] 3MediaWiki / 3ResourceLoader: sorting of style modules leading to arbitrary loading of files - 10https://bugzilla.wikimedia.org/69159#c3 (10Bartosz Dziewoński) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 45229 *** [20:45:08] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (43f379c884) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156820 (owner: 10Jforrester) [20:45:41] (03PS1) 10Jforrester: Update VE core submodule to master (15cce1d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156948 [20:46:03] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (15cce1d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156948 (owner: 10Jforrester) [20:47:53] Hey guys [20:47:56] (03Merged) 10jenkins-bot: Update VE core submodule to master (15cce1d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156948 (owner: 10Jforrester) [20:48:14] in ve.ce.Surface I'm interested to know when any GeneratedContent node finishes rerendering [20:48:15] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (43f379c884) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156820 (owner: 10Jforrester) [20:48:43] InezK: What do you need that for? [20:48:53] what solution would you suggest? one is to call some method on the surface from inside of GeneratedContentNode... the other solution is to emit some even, and re-emit it all the way up [20:49:22] RoanKattouw: We have something called FocusMode - that have to adjust everytime there is possible change to the size of the Surface [20:49:38] and that FocusMode is managed from inside ve.ce.Surface [20:49:46] What is this FocusMode thing? [20:50:10] (Hmm right the only ways the size of the surface will change is transactions and GCN rerenders) [20:51:37] (03PS1) 10Jforrester: Update VE core submodule to master (be42edf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156952 [20:51:44] Whooooaa wtf [20:51:49] There's a rerender event but nothing is using it right now [20:51:54] And the documentation is lying about it [20:51:54] yup :) [20:51:58] RoanKattouw: http://muppet.inez.wikia-dev.com/wiki/InezsTest?veaction=edit&debug=true&rebuildmessages=true [20:52:08] Oh, nope, my mistake [20:52:16] you see how page, except surface, is covered with this "thing" [20:52:17] grepped for 'rerender' with the quotes [20:52:24] it's a FocusMode [20:53:00] Oh the click block overlay thing? [20:53:18] I already see another bug there too BTW: the animation on slugs doesn't cause an update either [20:59:14] 3VisualEditor / 3Editing Tools: VisualEditor: Open button in link inspector should be disabled when the link target field is empty - 10https://bugzilla.wikimedia.org/70015#c4 (10Rummana Yasmeen) 5RESO/FIX>3REOP The "Open" button is now getting disabled when you clear the link target name , but if you jus... [20:59:20] RoanKattouw: oh yeah, that's true [20:59:23] OK so the way you're currently doing this FocusMode thing is by having 4 pieces of it and sizing them around the editor [20:59:29] yes [20:59:36] Why don't you make a fully covering FocusMode, then z-index the editor on top of it? [20:59:43] 3VisualEditor / 3Editing Tools: VisualEditor: Open button in link inspector should be disabled when the link target field is empty - 10https://bugzilla.wikimedia.org/70015 (10Rummana Yasmeen) 5REOP>3ASSI [21:00:09] yeah, we had bunch of problems with that... Wikia have very messed up usage of zIndexes, and Christian could't get it to work [21:00:22] we might revisit it in the future... I don't like this current approach too much either [21:03:15] Hmm so it looks like you currently don't have a single container that contains what you want to be white as opposed to grey. WikiaMainContentContainer is too big because it contains some other stuff [21:03:23] So maybe if you change the DOM structure, then use z-indexes [21:03:24] * RoanKattouw plays around [21:04:08] but what about re-emitting rerender, what do you think about that approach? [21:04:15] so I can listen to in in surface, on documentview for instance [21:06:26] z-index: 5000100; [21:06:31] lol [21:06:43] Yeah that does constitute messed-up use of z-indexes [21:09:48] Yeah, maybe, I don't know [21:10:13] (03PS1) 10Alex Monk: In LinkTargetInputWidget, put existence status into LinkCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156955 (https://bugzilla.wikimedia.org/69886) [21:10:16] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] The trash icon for deleting other templates/parameters/content gets missing from the left panel of transclusion dialog after selecting a required parameter - 10https://bugzilla.wikimedia.org/70101#c5 (10Rummana Yasmeen) Verified the fix in... [21:10:20] I think it's probably easier to call the surface directly, rather than letting things bubble up through the tree [21:12:45] yeah, definitely easier [21:14:45] 3VisualEditor / 3Mobile: VisualEditor Mobile: The page focus always bumps up to the top irrespective of cursor position - 10https://bugzilla.wikimedia.org/70111#c3 (10Juliusz Gonera) Correction: the page doesn't scroll up. It should scroll up when the keyboard opens and covers up the cursor. Instead, the pag... [21:15:28] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697#c9 (10Rummana Yasmeen) Verified the fix in test2 [21:16:15] but also sort of dirtier [21:16:40] Yes [21:17:46] 3VisualEditor / 3Editing Tools: VisualEditor: Stop users from deleting parameters in the template dialog if they're marked as "required" in TemplateData - 10https://bugzilla.wikimedia.org/60358#c4 (10Rummana Yasmeen) Verified the fix in test2 [21:24:47] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (be42edf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156952 (owner: 10Jforrester) [21:25:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] Cannot open Math inspector on a slug – TypeError: Cannot read property 'length' of null appears in the console - 10https://bugzilla.wikimedia.org/69991#c5 (10Rummana Yasmeen) Verified the fix in test2 [21:26:29] (03Merged) 10jenkins-bot: Update VE core submodule to master (be42edf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156952 (owner: 10Jforrester) [21:27:21] (03CR) 10Catrope: [C: 032] Pick up 'summary' parameter from URL to use as initial edit summary [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156744 (https://bugzilla.wikimedia.org/69501) (owner: 10Alex Monk) [21:28:45] RoanKattouw, how do I go about getting the gadget part of that bug done without violating the User account policy? [21:29:04] Oh you mean the ?summary= thing? [21:29:08] (03Merged) 10jenkins-bot: Pick up 'summary' parameter from URL to use as initial edit summary [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156744 (https://bugzilla.wikimedia.org/69501) (owner: 10Alex Monk) [21:29:14] Yeah [21:29:24] Well the §ion= bit of it actually. See the bug [21:29:47] Right [21:29:55] That's an excellent question [21:30:28] ...and I think maybe I'll ask Whatamidoing [21:30:28] 3MediaWiki / 3ResourceLoader: ResourceLoader preloads blob metadata, then does another query for blob contents - 10https://bugzilla.wikimedia.org/26398 (10Krinkle) p:5Normal>3Low [21:31:01] or ask James when he comes back [21:31:14] RoanKattouw, I have access to do it as a volunteer. [21:31:28] Yeah but only one account, right? [21:31:28] But global interface editor is probably administrative access as far as the policy is concerned >_> [21:31:44] Wait, hold on [21:31:51] Yes, I have it as a volunteer. [21:31:55] Are you saying you have access to do this for two separate reasons? [21:32:11] (community-elected sysop AND global interfaceeditor as staff?) [21:32:15] no [21:32:16] I'm not a sysop [21:32:26] global interface editor as volunteer [21:32:33] hah [21:32:44] I didn't realize that role existed, but I suppose it makes sense [21:34:04] Technically I didn't clarify what role I was having it under when requesting the permission. . . [21:34:07] Krenair, is this gadget similar to https://es.wikipedia.org/wiki/MediaWiki:Gadget-edittop.js? [21:34:32] But staff rights are supposed to be granted by LCA usually, I think [21:34:56] I think you should probably ask James A [21:35:09] He doesn't appear to be on IRC but you could message him on his work gchat account [21:35:10] ugh [21:35:19] why is that even a problem D: [21:35:22] Or get another non-staff global editinterface user to do it :P [21:35:28] i am a volunteer global interfaceeditor [21:35:37] not staff (yet :P) [21:36:12] or just ask for an edit with {{editprotected}}? [21:36:31] eranroz, looks something like that [21:36:33] (03CR) 10Mooeypoo: "Fixed according to CR comments, and also added 'errorbox' class to the notice box at the top." (036 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [21:36:50] so I can fix it in he and es [21:37:45] (03PS34) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) [21:39:24] (it seems ok in this version - it gets to VE and sets summary in URL) [21:39:24] (03PS1) 10Catrope: Return undefined, not null from onbeforeunload [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156965 [21:39:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf19] Getting stuck in the Media Settings dialog after changing the image position as it is throwing TypeError: Cannot read property 'length' of null - 10https://bugzilla.wikimedia.org/69988#c4 (10Rummana Yasmeen) Verified the fix in test2 [21:41:16] MatmaRex, you could do it. [21:44:12] (03CR) 10Catrope: [C: 04-1] In LinkTargetInputWidget, put existence status into LinkCache (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156955 (https://bugzilla.wikimedia.org/69886) (owner: 10Alex Monk) [21:47:57] (03PS2) 10Alex Monk: In LinkTargetInputWidget, put existence status into LinkCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156955 (https://bugzilla.wikimedia.org/69886) [21:49:03] When adding file using file dialog it adds keywords (left, right, file) in English instead of localized keywords names. I already introduced some (ugly) variable called wgWikiEditorMagicWords to wikieditor for localized keywords, is it possible to do the same for VE? (or is it in parsoid side?) [21:49:50] (03PS3) 10Alex Monk: In LinkTargetInputWidget, put existence, redirect and disambig status into LinkCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156955 (https://bugzilla.wikimedia.org/69886) [21:50:30] eranroz: That's a Parsoid thing [21:50:42] And I *think* it's supposed to use localized keywords already? But I'm not sure [21:51:19] (03PS3) 10Catrope: Greylist IE11 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155841 (https://bugzilla.wikimedia.org/50085) [21:51:49] (03CR) 10jenkins-bot: [V: 04-1] In LinkTargetInputWidget, put existence, redirect and disambig status into LinkCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156955 (https://bugzilla.wikimedia.org/69886) (owner: 10Alex Monk) [21:53:28] 3VisualEditor / 3Editing Tools: VisualEditor: Stop users from deleting parameters in the template dialog if they're marked as "required" in TemplateData - 10https://bugzilla.wikimedia.org/60358 (10Helder) 5RESO/?>3VERI [21:53:48] (03CR) 10Catrope: [C: 04-1] In LinkTargetInputWidget, put existence, redirect and disambig status into LinkCache (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156955 (https://bugzilla.wikimedia.org/69886) (owner: 10Alex Monk) [21:56:48] (03CR) 10Jforrester: [C: 032] Greylist IE11 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155841 (https://bugzilla.wikimedia.org/50085) (owner: 10Catrope) [21:58:37] (03Merged) 10jenkins-bot: Greylist IE11 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155841 (https://bugzilla.wikimedia.org/50085) (owner: 10Catrope) [21:58:58] 3VisualEditor / 3Editing Tools: VisualEditor: Stop users from deleting parameters in the template dialog if they're marked as "required" in TemplateData - 10https://bugzilla.wikimedia.org/60358 (10Rummana Yasmeen) 5VERI>3RESO/? [22:00:43] 3VisualEditor / 3Initialisation: VisualEditor: Internet Explorer compatibility (tracking) - 10https://bugzilla.wikimedia.org/50085 (10James Forrester) 5PATC>3ASSI [22:02:43] 3VisualEditor / 3MediaWiki integration: VisualEditor: If 'summary' parameter is provided in URL, it should be the default edit summary - 10https://bugzilla.wikimedia.org/69501 (10James Forrester) 5PATC>3RESO/FIX [22:03:28] 3VisualEditor / 3Mobile: VisualEditor Mobile: The page focus always bumps up to the top irrespective of cursor position - 10https://bugzilla.wikimedia.org/70111 (10James Forrester) p:5Unprio>3Normal [22:05:13] (03CR) 10Jforrester: [C: 031] Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [22:08:18] RoanKattouw, do you know why qunit didn't like it? [22:08:24] (it = https://gerrit.wikimedia.org/r/#/c/156955/ ) [22:10:11] (03PS4) 10Alex Monk: In LinkTargetInputWidget, put existence status into LinkCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156955 (https://bugzilla.wikimedia.org/69886) [22:12:30] Krenair: There's an intermittent thing where sometimes the mediawiki.cookie test fails [22:12:40] I'm not sure why, it seems to happen when there are multiple qunit jobs running [22:13:14] (03CR) 10Catrope: [C: 032] In LinkTargetInputWidget, put existence status into LinkCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156955 (https://bugzilla.wikimedia.org/69886) (owner: 10Alex Monk) [22:13:58] 3VisualEditor / 3MediaWiki integration: VisualEditor: Populate LinkCache from MWLinkTargetInputWidget etc - 10https://bugzilla.wikimedia.org/69886 (10Alex Monk) 5PATC>3RESO/FIX [22:17:04] (03Merged) 10jenkins-bot: In LinkTargetInputWidget, put existence status into LinkCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156955 (https://bugzilla.wikimedia.org/69886) (owner: 10Alex Monk) [22:18:47] (03CR) 10Eranroz: "Suggestion:" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) (owner: 10Mooeypoo) [22:23:58] 3VisualEditor / 3Mobile: VisualEditor Mobile: The page focus always bumps up to the top irrespective of cursor position - 10https://bugzilla.wikimedia.org/70111#c4 (10Juliusz Gonera) 5ASSI>3NEW Maryana said that she doesn't consider that very high priority so I might not get to it before I leave. Unassig... [22:24:15] 3VisualEditor / 3Mobile: VisualEditor Mobile: The page focus always bumps up to the top irrespective of cursor position - 10https://bugzilla.wikimedia.org/70111 (10Juliusz Gonera) a:5Juliusz Gonera>3None [22:26:13] 3MediaWiki / 3ResourceLoader: ResourceLoader: Implement per module configuration - 10https://bugzilla.wikimedia.org/26901 (10Krinkle) p:5Normal>3Lowest [22:30:14] 3MediaWiki / 3ResourceLoader: Add configuration option to enable loading modules based on url parameter - 10https://bugzilla.wikimedia.org/27766#c3 (10Krinkle) withModule has been implemented in a snippet and used by a few wikis: https://www.mediawiki.org/wiki/Snippets/Load_JS_and_CSS_by_URL [22:40:55] (03CR) 10Esanders: [C: 032] Polyfill Node.prototype.normalize in IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156444 (owner: 10Catrope) [22:46:58] (03Merged) 10jenkins-bot: Polyfill Node.prototype.normalize in IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/156444 (owner: 10Catrope) [22:56:56] grumble [22:57:13] y'all have connections with IE developers, don't you? [22:57:43] its history API is broken :D [22:58:39] https://gerrit.wikimedia.org/r/#/c/143852/ caused https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Redirects_to_sections on IE 10 and 11 (and maybe earlier) :/ [23:00:06] MatmaRex: Yeah I'm in touch with an IE person [23:00:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: Populate LinkCache from MWLinkTargetInputWidget etc - 10https://bugzilla.wikimedia.org/69886#c3 (10James Forrester) Do we want to do this from MWTitleInputWidget and MWCategoryInputWidget? [23:00:50] Could you write a jsfiddle that exhibits the bug, then add a section to https://www.mediawiki.org/wiki/User:Catrope/IE_bugs#Bugs_that_are_new_or_that_I_haven.27t_heard_back_about_yet ? [23:00:52] and ping me when done [23:01:04] i'll file a proper bug and try some workarounds for that tomorrow [23:01:05] okay [23:01:35] wow, that's a lot of bugs [23:01:47] 3VisualEditor: Can't copy template or media with Safari - 10https://bugzilla.wikimedia.org/70143 (10Drongou) 3UNCO p:3Unprio s:3normal a:3None I can't copy template or media with Safari on MAC OS X : Cmd C Text copy is OK You can copy template or media with Chrome on MAC OS X (in VE edit mode) and the... [23:02:14] 3VisualEditor / 3Mobile: VisualEditor Mobile: The page focus always bumps up to the top irrespective of cursor position - 10https://bugzilla.wikimedia.org/70111 (10James Forrester) 5NEW>3ASSI [23:07:10] MatmaRex: Yeah. [23:09:32] (03CR) 10Jforrester: [C: 032] Return undefined, not null from onbeforeunload [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156965 (owner: 10Catrope) [23:11:32] (03Merged) 10jenkins-bot: Return undefined, not null from onbeforeunload [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156965 (owner: 10Catrope) [23:19:35] RoanKattouw, can you send me a link to the specs that say that setTimeout doesn't require second argument again? [23:20:40] jgonera: http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#timers [23:21:46] thanks [23:27:53] RoanKattouw: Hope https://www.mediawiki.org/w/index.php?title=User:Catrope/IE_bugs&diff=1124784&oldid=1121742 is OK. [23:28:17] "Clicking beside a protected node" turns out to not be quite dead yet [23:28:27] Because if you click a second time the cursor still gets there [23:29:04] Other than that, awesome, thanks for doing that [23:30:59] Oh, I thought the second time the node went active? [23:31:01] * James_F sighs. [23:31:03] Dratted IE. [23:34:01] 3MediaWiki / 3ResourceLoader: ResourceLoader: JsMinPlus is too memory hungry (memory leaks?) - 10https://bugzilla.wikimedia.org/29784#c13 (10Krinkle) p:5Low>3Normal s:5minor>3normal Bumping priority (since this is still affecting production if you have a large gadget or user script). Mentioning JsMi... [23:34:43] James_F: Well the first time it corrects itself from dropping the cursor into the node to selecting the node. The second time, that selection correction gets dropped because it's a no-op selection change [23:34:55] I've just written some code that deals with this, about to test it [23:35:11] Ah. Helpful. [23:35:27] Also moving the correction to a more sensible place [23:36:38] It used to be that if you had a focusable node at [1,3] , dropping the cursor in the middle would set the selection to [2,2] , which would then cause the focusablenode to be kind of selected but not really (because the selection renderer special-cases this but the rest of the code doesn't) [23:37:02] Now I'm making it so that if we read [2,2] from CE, we set the model selection to [1,3] [23:37:15] 3MediaWiki / 3ResourceLoader: ResourceLoader: Fail more gracefully when a module name is registrated multiple times - 10https://bugzilla.wikimedia.org/31626#c3 (10Krinkle) 5NEW>3RESO/INV This is the functional equivalent of two pieces of php code in MediaWiki (e.g. core and an extension, or two extension... [23:37:15] 3MediaWiki / 3ResourceLoader: ResourceLoader: Fail more gracefully when a module name is registrated multiple times - 10https://bugzilla.wikimedia.org/31626 (10Krinkle) 5RESO/INV>3RESO/WON [23:37:31] plus force the renderer to rerender it even if it was already [1,3] [23:37:53] * James_F nods. [23:39:07] OK well that didn't work [23:39:12] We must be missing an event somewhere or something [23:39:50] Oh I think I know why [23:40:10] RoanKattouw: Your expertise would be appreciated on this code review thread: https://gerrit.wikimedia.org/r/#/c/156490/1/javascripts/common/Overlay.js [23:40:15] 3MediaWiki / 3ResourceLoader: ResourceLoader: Handle bad file paths more elegantly - 10https://bugzilla.wikimedia.org/25572#c8 (10Krinkle) A regular non-load.php request no longer cascades into module contents as far as I know. I don't think it ever did, but perhaps it did (based on reading this bug). Eithe... [23:40:28] 3MediaWiki / 3ResourceLoader: ResourceLoader: Handle bad file paths more elegantly - 10https://bugzilla.wikimedia.org/25572 (10Krinkle) 5NEW>3RESO/WOR [23:44:46] kaldari: Replied on Gerrit [23:53:55] James_F: Never mind. Back to the drawing board. I hate everything [23:54:09] * RoanKattouw casts his hate towards Internet Explorer, SurfaceObserver and Rangy