[06:30:17] 3VisualEditor / 3ContentEditable: Add unknown field automatically - 10https://bugzilla.wikimedia.org/70228 (10Juan de Vojníkov) 3NEW p:3Unprio s:3enhanc a:3None Created attachment 16328 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16328&action=edit Screenshot of VE when call editor to add i... [07:09:31] Hi. What is the editing team email address? I tried one, but my message was rejected. [07:26:28] 3VisualEditor / 3Editing Tools: VisualEditor: Please show the file name in the media dialog, and make it easy to copy it - 10https://bugzilla.wikimedia.org/69726#c1 (10Elitre) Being able to copy it from the tooltip would work for me, for example. [08:19:20] (03PS1) 10Trevor Parscal: Fix click-block focus-loss prevention [oojs/ui] - 10https://gerrit.wikimedia.org/r/157493 [08:20:55] (03PS2) 10Catrope: Fix click-block focus-loss prevention [oojs/ui] - 10https://gerrit.wikimedia.org/r/157493 (owner: 10Trevor Parscal) [08:27:26] (03PS3) 10Catrope: Fix click-block focus-loss prevention [oojs/ui] - 10https://gerrit.wikimedia.org/r/157493 (owner: 10Trevor Parscal) [08:27:31] (03CR) 10Catrope: [C: 032] Fix click-block focus-loss prevention [oojs/ui] - 10https://gerrit.wikimedia.org/r/157493 (owner: 10Trevor Parscal) [08:28:52] (03Merged) 10jenkins-bot: Fix click-block focus-loss prevention [oojs/ui] - 10https://gerrit.wikimedia.org/r/157493 (owner: 10Trevor Parscal) [08:53:59] 3MediaWiki extensions / 3TemplateData: TemplateData: Localise names of types in the HTML rendering (string, wiki-page-name, ...) - 10https://bugzilla.wikimedia.org/59745#c3 (10Ltrlg) I don’t think the original report was about the Editor. For me “HTML rendering” refers to the table displayed by TD where 3MediaWiki extensions / 3TemplateData: TemplateData: Localise names of types in the HTML rendering (string, wiki-page-name, ...) - 10https://bugzilla.wikimedia.org/59745#c4 (10NicoV) 5RESO/FIX>3REOP As Ltrlg, my initial report was about the rendering of the tag inside the template page, no... [12:01:45] (03CR) 10Krinkle: "Uh? This seems a bit random. What's this for?" [oojs/core] - 10https://gerrit.wikimedia.org/r/155047 (owner: 10Esanders) [12:25:12] [13oojs.github.io] 15Krinkle merged 061.0.12 into 06master: 02https://github.com/oojs/oojs.github.io/compare/72eed36dd2c2...6d1bc93b5adf [13:42:14] 3VisualEditor / 3MediaWiki integration: Three editing labels - 10https://bugzilla.wikimedia.org/70230 (10Bartosz Dziewoński) a:3None [14:02:29] 3VisualEditor / 3MediaWiki integration: Three editing labels - 10https://bugzilla.wikimedia.org/70230#c2 (10Lorenzo Marconi) (In reply to Andre Klapper from comment #1) > Hi, > what would "Edit Beta" do if you already have the two other buttons? > Which problem do you try to solve? What's the URL to the dis... [14:24:37] (03CR) 10Esanders: "Any 'weird' case involving number or boolean can be ignored, as the documentation states it's only for comparing objects. As null is typeo" [oojs/core] - 10https://gerrit.wikimedia.org/r/155047 (owner: 10Esanders) [16:02:46] (03CR) 10Esanders: "Ok, a bit late but I've found the case this breaks. If the surface is blurred (null selection) and you click somewhere, this functions fir" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155839 (https://bugzilla.wikimedia.org/66697) (owner: 10JGonera) [16:24:11] Svetlana, what did you try sending to? [18:09:40] (03PS1) 10Krinkle: core: Improve documentation and test coverage for compare() [oojs/core] - 10https://gerrit.wikimedia.org/r/157509 [18:17:58] (03PS2) 10Krinkle: Tag v1.1.0 [oojs/core] - 10https://gerrit.wikimedia.org/r/157323 (owner: 10Jforrester) [18:18:31] (03CR) 10Krinkle: "Removed unnotable entry about change in readme." [oojs/core] - 10https://gerrit.wikimedia.org/r/157323 (owner: 10Jforrester) [18:19:41] (03CR) 10Krinkle: "Thanks. [] comparing to [undefined] is much more relevant indeed, and also lacking from the tests. Added a test for it and some doc fixes " [oojs/core] - 10https://gerrit.wikimedia.org/r/155047 (owner: 10Esanders) [18:58:03] (03CR) 10Jforrester: [C: 031] Tag v1.1.0 [oojs/core] - 10https://gerrit.wikimedia.org/r/157323 (owner: 10Jforrester) [20:51:13] James_F: Maybe merge https://gerrit.wikimedia.org/r/157509 to make it i 1.1.0? [20:51:27] Krinkle: Looking. [20:52:30] (03CR) 10Jforrester: [C: 032] core: Improve documentation and test coverage for compare() [oojs/core] - 10https://gerrit.wikimedia.org/r/157509 (owner: 10Krinkle) [20:52:58] Krinkle: Do you think that needs documenting in the 1.1.0 release notes? It's just documentation changes… [20:53:12] yeah, I'd keep it out [20:53:39] OK, want to merge 1.1.0 then? :-) [20:55:43] (03Merged) 10jenkins-bot: core: Improve documentation and test coverage for compare() [oojs/core] - 10https://gerrit.wikimedia.org/r/157509 (owner: 10Krinkle) [20:55:52] (03PS3) 10Krinkle: Tag v1.1.0 [oojs/core] - 10https://gerrit.wikimedia.org/r/157323 (owner: 10Jforrester) [20:57:04] (03PS4) 10Krinkle: Tag v1.1.0 [oojs/core] - 10https://gerrit.wikimedia.org/r/157323 (owner: 10Jforrester) [20:57:19] LG? [20:57:25] Yeah. [20:57:31] (03CR) 10Jforrester: [C: 031] Tag v1.1.0 [oojs/core] - 10https://gerrit.wikimedia.org/r/157323 (owner: 10Jforrester) [20:57:34] (03CR) 10Krinkle: [C: 032] Tag v1.1.0 [oojs/core] - 10https://gerrit.wikimedia.org/r/157323 (owner: 10Jforrester) [21:01:26] (03PS1) 10Krinkle: EventEmitter: Make documentation of #once consistent with other methods [oojs/core] - 10https://gerrit.wikimedia.org/r/157621 [21:01:35] Now they're all consistent :) [21:01:55] (03CR) 10Jforrester: [C: 032] EventEmitter: Make documentation of #once consistent with other methods [oojs/core] - 10https://gerrit.wikimedia.org/r/157621 (owner: 10Krinkle) [21:01:58] Bah. [21:02:04] Oh well, 1.1.1 will get that. [21:02:17] Oh, you cancelled the +2. [21:02:19] OK. [21:02:25] Future me [21:02:47] Future you? [21:03:11] Jenkins is so slow that time travel is possible. [21:03:21] Ha. [21:03:34] – Albert Einstein [21:05:10] It'd be faster if we upgraded to node 0.10.0 [21:05:20] Maybe. Probably not, actually. But we should do that anyway. :-0 [21:05:25] Meh, I doubt it. [21:05:38] http://reluctantbaltimoron.files.wordpress.com/2013/06/abraham-lincoln-selfie-the-trouble-with-quotes-on-the-internet.jpg [21:05:52] Indee.d [21:05:54] (03Merged) 10jenkins-bot: EventEmitter: Make documentation of #once consistent with other methods [oojs/core] - 10https://gerrit.wikimedia.org/r/157621 (owner: 10Krinkle) [21:05:58] (03CR) 10Esanders: core: Improve documentation and test coverage for compare() (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/157509 (owner: 10Krinkle) [21:11:18] (03PS5) 10Jforrester: Tag v1.1.0 [oojs/core] - 10https://gerrit.wikimedia.org/r/157323 [21:11:27] Krinkle: ^^^ +2 please? [21:11:27] (03CR) 10Krinkle: core: Improve documentation and test coverage for compare() (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/157509 (owner: 10Krinkle) [21:11:35] (03CR) 10Krinkle: [C: 032] Tag v1.1.0 [oojs/core] - 10https://gerrit.wikimedia.org/r/157323 (owner: 10Jforrester) [21:11:50] Ta. [21:13:36] Krinkle: Whilst I've got your attention could you merge this PR: https://github.com/jdforrester/grunt-banana-checker/pull/6 [21:13:45] yeah, read your pm just now [21:14:02] There's another patch we could merge in for 0.2.0. [21:14:35] https://github.com/jdforrester/grunt-banana-checker/tree/no-blank-documentation-please-we-are-British [21:15:03] (03Merged) 10jenkins-bot: Tag v1.1.0 [oojs/core] - 10https://gerrit.wikimedia.org/r/157323 (owner: 10Jforrester) [21:15:08] Whee. [21:15:33] James_F: github released a new inline comment design a few days back [21:15:33] https://github.com/es-shims/es5-shim/pull/246/files [21:15:39] however diff lines and see the [+] pop up [21:15:46] click it and it'll grow slightly and a comment field appears [21:15:51] no selection disability [21:16:14] (like gerrit) [21:17:54] [13oojs.github.io] 15jdforrester created 06release-1.1.0 (+1 new commit): 02https://github.com/oojs/oojs.github.io/commit/88cbe7c23b62 [21:17:54] 13oojs.github.io/06release-1.1.0 1488cbe7c 15James D. Forrester: Publish v1.1.0 release from npm [21:17:58] 3MediaWiki / 3ResourceLoader: mw.loader.store should not occupy all of localStorage - 10https://bugzilla.wikimedia.org/64721#c7 (10Andre Klapper) Ori: Could you reply to comment 6 please if you have some ideas? [21:18:24] [13oojs.github.io] 15jdforrester opened pull request #4: Publish v1.1.0 release from npm (06master...06release-1.1.0) 02https://github.com/oojs/oojs.github.io/pull/4 [21:18:48] James_F: Want me to 1) squash that into the 0.2 commit, 2) amend the 0.2 commit to not bump version, then merge that, and then bump version, 3) merge it underneat and then 0.2.0 commit on top [21:19:25] Krinkle: I was mostly asking which you thought best. Maybe 3. [21:19:31] Krinkle: Wait, no, 1. [21:19:52] (Also, neat new inline commenting, yeah.) [21:24:50] (03PS1) 10Jforrester: Update oojs to v1.1.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/157623 [21:25:59] (03PS1) 10Jforrester: Update oojs to v1.1.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157624 [21:34:26] James_F: https://github.com/jdforrester/grunt-banana-checker/pull/8 [21:34:36] (Don't use github merge, just let me know, and I'll push) [21:34:48] * James_F nods. [21:34:52] No +1s in GitHub… [21:35:27] yeah, and while it's nice in some way, it's annoying that if you want to amend it, you'd have to fork my fork and submit a PR against my branch. [21:35:35] Yeah. [21:35:36] which I'd then merge, and then fold back into that, and then fold back into... [21:35:42] PRs for everyone! :-) [21:36:36] Missing full stop on line 5 of history, fixed. [21:36:53] Yeah, go for it. [21:37:30] Oh, wait. [21:37:37] "Initial release (James D. Forreser)". [21:37:43] That's not exactly how my name is spelt. :-) [21:37:55] Right. [21:37:59] You wrote that though [21:38:06] I did? Oops. [21:38:12] unless I changed it somehow. Let me check [21:38:31] yeah, was already there :S [21:38:37] Also, you've dumped the blame-apportionment from the history file? [21:38:42] Or did I do that too? [21:39:03] Also, Travis doesn't like it. [21:39:20] hm.. strange [21:39:33] package.json issue? [21:39:47] (Maybe we should have mastered this in gerrit…) [21:40:06] Oh, yeah. [21:40:13] https://github.com/jdforrester/grunt-banana-checker/pull/8/files [21:40:17] Look at package.json. [21:40:36] "dependencies": {}, [21:40:37] "grunt": "0.4.5", [21:40:43] Spot the obvious error. :-) [21:43:12] also fixed warning: grunt-jscs-checker was renamed [21:44:19] Seems not to be doing well even so. [21:44:33] i'm going to wait for my nodejs biuld to complete so that I can test locally [21:44:46] brew install nodejs is taking a while.. (minor update) [21:44:54] Ah. [21:47:17] (Should we move grunt-banana-checker to the Wikimedia organisation?) [21:47:58] Sure. [21:48:07] Is that lots of work? [21:48:11] Nope [21:48:40] I can do it if you transfer it to @Krinkle first (or grant me admin access to banana) [21:48:50] Don't you have admin access? [21:48:54] nope, only write access [21:49:01] https://github.com/jdforrester/grunt-banana-checker/settings is 404 for me [21:49:35] You're both listed as "full access". [21:50:22] yeah, that's read/write [21:50:39] I don't think repos under a personal account can be given co-owners [21:50:48] Ah, helpful. [21:50:52] under oojs or wikimedia I can grant admin access to other users but not in a personal repo [21:51:00] So I should transfer it to @Krinkle? [21:51:04] from /settings transfer ownership to @wikimedia [21:51:11] might as well directly, I can receive it there [21:51:57] It's not letting me do so, for some reason. [21:52:01] k [21:52:04] Try @Krinkle then [21:52:24] The "I understand, transfer this repo" button is inactive. [21:52:32] Not clear at all how I make it active. [21:52:39] "Transfer this repo to another user or to an organization where you have admin rights." [21:52:41] Ah, right. [21:52:45] Hm.. [21:52:53] You need to give me admin on @Wikimedia first? [21:52:57] I can't [21:53:00] but.. here's a hack [21:53:05] transfer it to oojs [21:53:13] I'll move it from there [21:53:53] Still won't work. [21:54:00] try again [21:54:02] How about we do this in a couple of weeks when you're here? :-) [21:54:31] (Still nothing.) [21:55:04] Aha. [21:55:12] It shoudl work.. [21:55:17] username=oojs [21:55:32] Yeah, now works. [21:55:35] Finally. [21:56:03] done [21:58:13] James_F: I've enabled irc notifications for the repo as well (commits, issues and pull requests) [21:58:26] Here? Or -i18n [21:58:28] ? [21:58:36] Did a "test service' just now, showing the last 3 events playback [21:58:41] -i18n [21:58:43] Is that ok? [21:58:49] Aha. There. Maybe we should point it here. [22:00:31] Travis hook isn't working. Need to re-auth (it's cached your oath token still) [22:00:32] Given that it's mostly us. [22:01:17] James_F: Wanna do a commit updating urls? [22:01:23] Krinkle: I did [22:01:31] Krinkle: https://github.com/wikimedia/grunt-banana-checker/pulls [22:01:53] OK. updated irc hook to point here [22:02:14] [13grunt-banana-checker] 15none pushed 3 new commits to 06master: 02https://github.com/wikimedia/grunt-banana-checker/compare/457cc02771d4...c258579f31d9 [22:02:14] 13grunt-banana-checker/06master 1451b5485 15James D. Forrester: task: Fail if a documentation message is blank or whitespace-only [22:02:14] 13grunt-banana-checker/06master 14678e4e0 15James D. Forrester: Improve Readme and add History file [22:02:14] 13grunt-banana-checker/06master 14c258579 15Timo Tijhof: Tag v0.2.0 [22:03:00] James_F: IRC hook is managed on /settings on github, but travis irc channel is in the yaml file. [22:03:05] Maybe in the same commit? [22:03:09] Yeah. [22:03:22] Not sure how I do that in the GitHub interface. [22:03:36] I've updated the irc hook already [22:03:51] I only set it up a minute ago for -i18n, updated now to -visualeditor [22:03:56] the yaml file is in the repo [22:04:03] maybe amend that new pr commit [22:04:38] update travis-ci badge in readme as well (404 right now) [22:04:49] Yeah. [22:06:22] Krinkle: https://github.com/wikimedia/grunt-banana-checker/pull/9 [22:10:18] [13grunt-banana-checker] 15Krinkle pushed 2 new commits to 06master: 02https://github.com/wikimedia/grunt-banana-checker/compare/c258579f31d9...1e0a13549359 [22:10:18] 13grunt-banana-checker/06master 14b468211 15James Forrester: Owner has moved from me to Wikimedia [22:10:18] 13grunt-banana-checker/06master 141e0a135 15James Forrester: Change Travis-CI output channel [22:10:46] Krinkle: Why the duplicate PR? [22:10:57] for 0.2.0? [22:10:58] [travis-ci] wikimedia/grunt-banana-checker#39 (master - 1e0a135 : James Forrester): The build passed. [22:10:58] [travis-ci] Change view : https://github.com/wikimedia/grunt-banana-checker/compare/c258579f31d9...1e0a13549359 [22:10:58] [travis-ci] Build details : http://travis-ci.org/wikimedia/grunt-banana-checker/builds/34057992 [22:12:08] Krinkle: No, the thing github spammed in the channel from you. [22:12:16] That's not a PR [22:12:18] I merged yours [22:12:30] Oh. But only two of the three file changes? [22:12:43] No, I squashed the badge url fix into owner change [22:12:48] Ah, right. [22:12:50] Confusing. :-) [22:12:51] since its jdf->wm [22:12:55] too [22:13:00] Sure. [22:13:18] wanted to reduce number of commits with a 404 [22:13:25] Have I now lost merge rights on my "own" repo? ;-) [22:13:28] Hm.. github didnt autoclose the PR this time [22:13:38] Yeah, hence my confusion. [22:13:38] wait, that shouldn't be the case [22:13:57] if you click edit on a file via the github interface (e.g. on Readme) [22:14:08] does it go to your fork or wm branch? [22:14:11] Fork. [22:19:05] [13grunt-banana-checker] 15Krinkle closed pull request #9: Fixes related to changing repo owner to Wikimedia (06master...06patch-1) 02https://github.com/wikimedia/grunt-banana-checker/pull/9 [22:20:10] James_F: I can't add you as owner, but I aded you to staff group and granted wmf/Staff write access to banana [22:20:14] Krinkle: BTW, https://gerrit.wikimedia.org/r/157631 – MW-core had a qqq that was blank, so 0.2.0 upgrade actually does something. [22:20:18] Krinkle: Ah, OK. Thanks. [22:20:44] Krinkle: Still says it'll fork, FWIW… [22:21:30] James_F: accept the invitation [22:22:10] Invitation? [22:24:19] to the organisation [22:24:37] You know, coming along for the ride, showing the department's new employee the ropes. [22:24:43] :P [22:25:00] If you mean the oojs-owners invite, I accepted it. [22:25:16] No, I know you accepted that or the transfer wouldn't have worked. [22:25:18] to wikimedia [22:26:46] Why can't you add him as owner? [22:26:58] Aha. [22:27:04] E-mail just arrived inviting me to join WMF. [22:27:12] GitHub slow. [22:27:41] (Hey Krenair.) [22:27:44] Hi. [22:28:59] because I'm not an über owner [22:29:12] staff group is viral (yay) [22:29:51] Krenair: But you're an owner, it seems? [22:30:01] I am. But so is Krinkle. [22:30:08] Oh, but not an über-owner. [22:30:14] Whatever that is. [22:30:58] Apparently I can add you as owner. [22:31:08] * James_F shrugs. [22:31:27] Thanks. [22:41:25] Eurgh. [22:42:02] I spotted that a user on translatewiki had translated six languages' message for the VE tag into Urdu (and not Urdu). [22:42:15] Isn't it /so/ great that we have that bot self-+2? :-( [22:42:23] Good thing I manually check them. [22:49:03] James_F, they get auto-+2'd before any other translator reviews? [22:49:16] Krenair: Yes. It's a nightmare of a system. [22:49:22] Krenair: No checking. [22:49:38] Wow. Imagine what a vandal with translator access could do [22:49:48] Krenair: And when I murmur slightly about improving it, people get very upset with me [23:33:10] (03CR) 10Krinkle: [C: 032] Update oojs to v1.1.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/157623 (owner: 10Jforrester) [23:33:18] (03PS2) 10Krinkle: Fix process dialog title text position [oojs/ui] - 10https://gerrit.wikimedia.org/r/157354 (owner: 10Esanders) [23:33:45] (03PS3) 10Krinkle: Automatically align popup toolgroups [oojs/ui] - 10https://gerrit.wikimedia.org/r/157295 (owner: 10Trevor Parscal) [23:33:54] (03Merged) 10jenkins-bot: Update oojs to v1.1.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/157623 (owner: 10Jforrester) [23:34:33] (03PS3) 10Krinkle: Fix process dialog title text position [oojs/ui] - 10https://gerrit.wikimedia.org/r/157354 (owner: 10Esanders) [23:47:52] (03CR) 10Krinkle: [C: 032] Fix process dialog title text position [oojs/ui] - 10https://gerrit.wikimedia.org/r/157354 (owner: 10Esanders) [23:48:30] (03Merged) 10jenkins-bot: Fix process dialog title text position [oojs/ui] - 10https://gerrit.wikimedia.org/r/157354 (owner: 10Esanders) [23:48:51] (03PS2) 10Krinkle: Update OOjs to v1.1.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157624 (owner: 10Jforrester) [23:48:56] (03CR) 10Krinkle: [C: 032] Update OOjs to v1.1.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157624 (owner: 10Jforrester) [23:51:19] (03Merged) 10jenkins-bot: Update OOjs to v1.1.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157624 (owner: 10Jforrester) [23:59:55] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (adfcf92c6a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157634