[00:12:14] 3VisualEditor / 3Editing Tools: VisualEditor: Stop users from deleting parameters in the template dialog if they're marked as "required" in TemplateData - 10https://bugzilla.wikimedia.org/60358#c5 (10Ricordisamoa) VisualEditor should only make edits easier, not restrict the users' capabilities. As long as th... [00:14:14] 3MediaWiki / 3Page editing: Classic toolbar should not be enabled on .js and .css pages - 10https://bugzilla.wikimedia.org/29908#c13 (10George Orwell III) (In reply to Bartosz Dziewoński from comment #11) > The patch has been reverted, back to drawing board. > > We need a way to let extensions decide whethe... [00:30:28] 3MediaWiki extensions / 3WikiEditor: "Show edit toolbar" preference is confusing - 10https://bugzilla.wikimedia.org/30795#c5 (10George Orwell III) (In reply to Helder from comment #2) > >>SNIP<< > > I like the idea of having something like > > [x] Show edit toolbar: > (x) Classic > ( ) Modern >... [01:23:48] 3VisualEditor / 3Editing Tools: VisualEditor: When image search results are returned very slowly, remove the "No results found" error message - 10https://bugzilla.wikimedia.org/70273 (10WhatamIdoing) 3NEW p:3Unprio s:3trivia a:3None Created attachment 16338 --> https://bugzilla.wikimedia.org/attac... [01:24:01] 3VisualEditor / 3Editing Tools: VisualEditor: Support media (tracking) - 10https://bugzilla.wikimedia.org/37870 (10WhatamIdoing) [01:24:01] 3VisualEditor / 3Editing Tools: VisualEditor: When image search results are returned very slowly, remove the "No results found" error message - 10https://bugzilla.wikimedia.org/70273 (10WhatamIdoing) [02:55:22] (03PS1) 10MarkAHershberger: Add debugging help to VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157775 [03:05:49] (03PS1) 10MarkAHershberger: Merge commit '433b95a' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157778 [03:07:03] (03Abandoned) 10MarkAHershberger: Merge commit '433b95a' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157778 (owner: 10MarkAHershberger) [04:45:31] Hello! [08:00:04] 3VisualEditor / 3MediaWiki integration: VisualEditor: There should be a link to the template page even if template description is available - 10https://bugzilla.wikimedia.org/70279 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None When a template doesn't have a description in TemplateData, a link... [08:17:35] 3VisualEditor / 3Editing Tools: VisualEditor: Documentation for the message Visualeditor-dialog-action-done is misleading - 10https://bugzilla.wikimedia.org/70281 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None The qqq documentation for the message Visualeditor-dialog-action-done is either misle... [09:53:20] 3VisualEditor / 3ContentEditable: Distinguish better videos and pictures - 10https://bugzilla.wikimedia.org/70284 (10Juan de Vojníkov) 3NEW p:3Unprio s:3enhanc a:3None Created attachment 16340 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16340&action=edit Screenshot of embeded video I thin... [10:02:20] 3VisualEditor / 3Editing Tools: Automatic edit summary - 10https://bugzilla.wikimedia.org/70285 (10Juan de Vojníkov) 3NEW p:3Unprio s:3enhanc a:3None I think it would be great that VE or other tool would detect, what the person were doing and offer edit summary as a gray text. [10:02:55] hi [10:03:30] I can see VE remove the step of adding category into the value of category when addin commonscat template [10:03:46] could this behaviour be caused by VE itself? [10:25:48] 3MediaWiki extensions / 3TemplateData: TemplateData: Add a tracking category to all templates that don't have a TemplateData block - 10https://bugzilla.wikimedia.org/70242#c1 (10Kunal Mehta (Legoktm)) Maybe a Special:PagesWithoutProps would be more useful...? Definitely more efficient than a tracking category. [10:53:00] Juandev: didn't get that. rephrase please? [10:53:36] Svetlana: I see the change in functionality and I am wondering if it could be caused by Ve [10:54:19] before: 1) add template, 2) choose, 3) add field, 4) add value [10:54:38] now it automatically adds template without point 4 [10:55:59] Sounds like a bug to me - the behaviour you describe forces it to insert a template which is not filled in. [10:56:54] well, its not necessary a bug [10:57:19] ir you add this template without value for the parametr, it uses the value from wikidata [10:59:57] basically I wanted to propose wikipedia community to ad the first parameter as important, that VE loads it automatically, which woul be easier for the users [11:00:45] but if this change happened it would not be necessary. I dont know, how correct are the values for wikidata, or if there is a bot, which would create new properties on wikidata upon comparing some values [11:07:43] What is the use in using a default parameter value? Should it be a parameter at all? [11:09:23] ok, let me see,w hat Ve entered there [11:09:57] VE skipped it [11:11:50] default parametr is when the category name at Commons is equal to property name on Wikidata (probably same to title of the wp article), parametr we add, when we suppose the category on commons is differnt [11:11:53] Svetlana: [11:13:07] but I would wait [11:13:12] I'm sorry, I lack context. We were talking about templates, and now we're talking about categories. [11:13:18] community is now changing this template also [11:13:34] never mind, if you dont midn [11:43:20] 3VisualEditor / 3Editing Tools: Automatic edit summary - 10https://bugzilla.wikimedia.org/70285#c1 (10Andre Klapper) 5NEW>3UNCO Doesn't that happen already (bug 50872)? Or do you mean bug 63142? [11:46:48] 3VisualEditor / 3Editing Tools: VisualEditor: Link input widget should have separate inputs for target and display text - 10https://bugzilla.wikimedia.org/53973#c3 (10Elitre) Copy Google Docs solution? [11:48:47] 3VisualEditor / 3ContentEditable: Distinguish better videos and pictures - 10https://bugzilla.wikimedia.org/70284#c1 (10Andre Klapper) Created attachment 16341 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16341&action=edit Screenshot from Firefox 31, no problems Which browser and version is that (... [11:49:17] 3VisualEditor / 3ContentEditable: Some browser does not show the "Play" button overlay for videos - 10https://bugzilla.wikimedia.org/70284#c2 (10Andre Klapper) [Rephrasing bug summary; please insert browser & version there] [11:51:47] 3VisualEditor / 3ContentEditable: Distinguish better between videos and pictures - 10https://bugzilla.wikimedia.org/70284#c3 (10Andre Klapper) Sigh. VE! Confirming. I should get more coffee. Sorry for all the noise. Ignore my last two comments please. Still, what's the usecase of knowing in VisualEditor if... [12:28:05] 3VisualEditor: VisualEditor: Adding a link right before a wikilinked word leads to unexpected results, including a nowiki - 10https://bugzilla.wikimedia.org/70286 (10Elitre) 3NEW p:3Unprio s:3normal a:3None This can be seen by placing the cursor right at the beginning of any existing wikilinked word, t... [12:48:47] 3VisualEditor / 3Editing Tools: Link target choice box scroll bar does not work - 10https://bugzilla.wikimedia.org/70218#c1 (10Elitre) I don't have examples for the link tool, but can confirm in the categories' one. [12:53:45] looks like US crew woke up:-) [12:55:03] 3VisualEditor / 3Editing Tools: Automatic edit summary - 10https://bugzilla.wikimedia.org/70285#c2 (10Juan de Vojníkov) Yep, I mean the second one. [12:56:03] 3VisualEditor / 3Editing Tools: Link target choice box scroll bar does not work - 10https://bugzilla.wikimedia.org/70218#c2 (10Elitre) (Notice that using the mouse wheel works as intended, at least in the categories' case, so assuming it's the same bug we'll need to edit its title.) [12:57:18] 3VisualEditor / 3ContentEditable: Distinguish better between videos and pictures - 10https://bugzilla.wikimedia.org/70284#c4 (10Juan de Vojníkov) (In reply to Andre Klapper from comment #1) > Created attachment 16341 [details] > Screenshot from Firefox 31, no problems > > Which browser and version is that (... [13:42:03] 3VisualEditor / 3Editing Tools: Automatic edit summary - 10https://bugzilla.wikimedia.org/70285#c3 (10Andre Klapper) 5UNCO>3RESO/DUP Alright then. Marking as duplicate. :) *** This bug has been marked as a duplicate of bug 63142 *** [13:42:03] 3VisualEditor / 3MediaWiki integration: VisualEditor: Automatically generate an edit summary for the user - 10https://bugzilla.wikimedia.org/63142#c1 (10Andre Klapper) *** Bug 70285 has been marked as a duplicate of this bug. *** [14:24:18] 3VisualEditor / 3Editing Tools: VisualEditor:Link Inspector icon is not appearing, when language is selected, in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68810#c6 (10Ritu Swain) Issue fixed in test2. [14:33:47] 3VisualEditor / 3MediaWiki integration: VisualEditor:Text style drop-down overridden by edit comment, in Monobook skin. - 10https://bugzilla.wikimedia.org/69263#c2 (10Ritu Swain) Issue Resolved on test2. [14:37:17] 3VisualEditor / 3MediaWiki integration: VisualEditor: Caret looks disconnected from link box in Monobook skin when going to first letter of line - 10https://bugzilla.wikimedia.org/69242#c6 (10Ritu Swain) Issue not fixed on test2. [14:44:03] 3VisualEditor / 3MediaWiki integration: VisualEditor: Caret looks disconnected from link box in Monobook skin when going to first letter of line - 10https://bugzilla.wikimedia.org/69242#c7 (10James Forrester) (In reply to Ritu Swain from comment #6) > Issue not fixed on test2. Yes, this code will be deploye... [14:49:33] 3MediaWiki extensions / 3TemplateData: TemplateData: Add a tracking category to all templates that don't have a TemplateData block - 10https://bugzilla.wikimedia.org/70242#c2 (10James Forrester) (In reply to Kunal Mehta (Legoktm) from comment #1) > Maybe a Special:PagesWithoutProps would be more useful...? D... [14:56:18] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438#c12 (10James Forrester) *** Bug 70273 has been marked as a duplicate of this bug. *** [14:56:19] 3VisualEditor / 3Editing Tools: VisualEditor: When image search results are returned very slowly, remove the "No results found" error message - 10https://bugzilla.wikimedia.org/70273#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 67438 *** [14:57:07] (03PS2) 10Jforrester: Add debugging help to VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157775 (https://bugzilla.wikimedia.org/39057) (owner: 10MarkAHershberger) [14:58:33] 3VisualEditor / 3Mobile: VisualEditor Mobile:Mobile VE does not load after saving the first time edit in production (en.wiki), shows Error, can't load section - 10https://bugzilla.wikimedia.org/68948#c1 (10James Forrester) 5NEW>3RESO/WOR Think this was solved long ago? [14:58:34] 3VisualEditor / 3MediaWiki integration: VisualEditor: after dismissing the little pink saving error window, the Save page button remains disabled - 10https://bugzilla.wikimedia.org/68460#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Alex Monk I think we only show the error message for unre... [15:02:47] 3VisualEditor / 3Editing Tools: VisualEditor: Consider whether exiting the link dialog in create mode should remove the link - 10https://bugzilla.wikimedia.org/69407#c1 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Low s:5major>3enhanc This is a mistaken understanding of what the button does, and wh... [15:05:03] 3VisualEditor / 3Editing Tools: VisualEditor: Support non-image media (tracking) - 10https://bugzilla.wikimedia.org/67690 (10James Forrester) [15:05:03] 3VisualEditor / 3Editing Tools: VisualEditor: Distinguish better between media types in the search interface and in the editing surface - 10https://bugzilla.wikimedia.org/70284#c5 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low This is really two bugs, and should be split, but leaving for now… [15:05:33] 3VisualEditor / 3Editing Tools: VisualEditor: Support non-image media (tracking) - 10https://bugzilla.wikimedia.org/67690 (10James Forrester) [15:05:47] 3VisualEditor / 3ContentEditable: VisualEditor: resizing audio file causes it to resize 0px dialogs do not report size. - 10https://bugzilla.wikimedia.org/67265 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [15:10:25] heya James_F [15:11:29] James_F, I've had a lot of trouble rebasing the https://gerrit.wikimedia.org/r/#/c/146395/ and since it's a really small change, I think it's best if I abandon this and redo the new one. Is that ok? or should I submit a new patchset (from scratch) on top of the existing one? [15:12:00] rebasing was crazy, I ended up with nothing to submit, eating up all the changes. [15:19:48] 3VisualEditor / 3Editing Tools: Link target choice box scroll bar does not work - 10https://bugzilla.wikimedia.org/70218#c3 (10Axel Boldt) Just noticed that the (non-functional) scroll bar is only shown if the target list is displayed too far down on the screen. Otherwise, the list just contains 10 items and... [15:22:45] mooeypoo: If you want. [15:26:32] Krinkle, \o/ I'm trying to add 'autovalue' to the TemplateData validation, but it's not a string, it's wikitext (so validating on 'string' fails if I put in something like '{{CURRENTMONTHNAME}}') -- there's not yet a wikitext validation is there? am I missing something? [15:30:46] (03Abandoned) 10Mooeypoo: [wip] Add autovalue to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/146395 (owner: 10Mooeypoo) [15:31:04] (03PS1) 10Mooeypoo: Add autovalue to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 [15:31:38] (03CR) 10jenkins-bot: [V: 04-1] Add autovalue to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (owner: 10Mooeypoo) [15:35:01] meh. [15:35:19] Forgot the php unit tests. [16:21:00] hm, how do I run local php unit tests? [16:24:31] mooeypoo, "php tests/phpunit/phpunit.php" from your core directory? [16:25:13] you may need to run tests/phpunit/install-phpunit.sh first [16:26:37] you may also need to disable centralauth as well, if you have that enabled [16:30:29] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32525080 [16:30:29] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32525869 [16:30:29] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32530555 [16:33:36] Krenair, ooh thanks. This is th way to test extensions php unit tests too, or just core? [16:33:53] yep, extensions as well [16:35:26] mooeypoo, you can give it the path to the file(s) you want it to run [17:21:42] MatmaRex: I do love four-digit bug patches. :-) [17:22:08] :D [17:22:42] is it just me, or is Gerrit really slow today? [17:24:03] TrevorParscal: Seems about normal to me. [17:25:04] all internet seems slow today actually... [17:25:18] * TrevorParscal thinks to restart his modeml [17:25:21] *modem [17:25:26] :-) [17:25:42] mawhdelm. [17:25:57] From Noo-Joy-zi. [17:28:26] James_F: when is it OK for me to rope MatmaRex into things? [17:33:42] :o [17:34:27] MatmaRex: how's it going man? [17:34:34] ;-) [17:34:59] not bad. :D [18:01:44] 3VisualEditor / 3Editing Tools: VisualEditor:Shrink back the Basic Reference dialog size - 10https://bugzilla.wikimedia.org/70016#c2 (10Roan Kattouw) Many other dialogs have this problem too, including referenceList. It looks like getBodyHeight() is returning a value that's way too high. [18:13:50] (03CR) 10Catrope: [C: 032] Add debugging help to VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157775 (https://bugzilla.wikimedia.org/39057) (owner: 10MarkAHershberger) [18:16:41] (03Merged) 10jenkins-bot: Add debugging help to VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157775 (https://bugzilla.wikimedia.org/39057) (owner: 10MarkAHershberger) [18:16:49] Hey TrevorParscal. [18:17:00] hey [18:17:08] (in a fight with less, currently losing) [18:17:08] :-( [18:24:57] finding that LESS errors are very misleading [18:38:05] RoanKattouw:http://en.wikipedia.beta.wmflabs.org/wiki/2ndseptember [18:51:15] James_F, MatmaRex: Are you guys going to update VE for https://gerrit.wikimedia.org/r/#/c/83662/ ? [18:53:09] Because it currently shows like this to all anonymous users: [18:53:11] "Warning: You are not logged in. Your IP address will be publicly visible if you make any edits. If you [$1 log in] or [$2 create an account], your edits will be attributed to your username, along with other benefits." [18:53:28] which should probably be fixed before thursday [18:56:40] oh. heh. [18:56:49] well [18:57:11] if you ask me, the message shouldn't take any parameters, these links should be in the message itself [18:57:44] but wait. doesn't VE get the edit notices already parsed from EditPage or whatever? [18:58:53] MatmaRex, it starts with those and then adds more [18:59:04] MatmaRex, I'm uploading a patch [18:59:31] (03PS1) 10Alex Monk: Update anoneditwarning message per core change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157858 [18:59:41] 3VisualEditor / 3MediaWiki integration: VisualEditor: Error message texts when the Parsoid service is not around aren't very clear, should be improved - 10https://bugzilla.wikimedia.org/39057#c5 (10James Forrester) 5PATC>3ASSI With the above patch, the former message: Error loading data from server:... [19:00:13] 3VisualEditor / 3MediaWiki integration: VisualEditor: Parsoid diff failure errors are not very descriptive - 10https://bugzilla.wikimedia.org/43147#c3 (10James Forrester) 5PATC>3RESO/FIX a:3Mark A. Hershberger With the above patch, the former message: Error loading data from server: parsoidserver-... [19:00:42] 3VisualEditor / 3MediaWiki integration: VisualEditor: When API returns HTTP 500, present a more useful error message to the user - 10https://bugzilla.wikimedia.org/63149#c4 (10James Forrester) 5PATC>3RESO/FIX a:3Mark A. Hershberger With the above patch, the former message: Error loading data from... [19:00:56] MatmaRex: I also thought that it should be in the message and not as a parameter, but i18n team disagreed. :-( [19:02:08] well, what i'm saying is, they're not infallible either [19:02:24] See the patch history. [19:02:31] i know, seen it [19:02:49] we probably shouldn't add parameters to existing messages that might be used by extensions [19:03:21] (03CR) 10Jforrester: [C: 032] Update anoneditwarning message per core change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157858 (owner: 10Alex Monk) [19:05:04] (03Merged) 10jenkins-bot: Update anoneditwarning message per core change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157858 (owner: 10Alex Monk) [19:20:27] 3VisualEditor / 3MediaWiki integration: VisualEditor: after dismissing the little pink saving error window, the Save page button remains disabled - 10https://bugzilla.wikimedia.org/68460#c2 (10Alex Monk) ViewPageTarget#showSaveError allows errors to be recoverable or unrecoverable (defaulting to recoverable)... [19:21:57] 3VisualEditor / 3MediaWiki integration: VisualEditor: after dismissing the little pink saving error window, the Save page button remains disabled - 10https://bugzilla.wikimedia.org/68460#c3 (10Amir E. Aharoni) Hmmmm, don't remember what it could be. Possibly badtoken. [19:30:07] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/157845/ [19:42:40] (03PS4) 10Trevor Parscal: Automatically align popup toolgroups [oojs/ui] - 10https://gerrit.wikimedia.org/r/157295 [19:42:42] (03PS4) 10Trevor Parscal: [BREAKING CHANGE] Element mixin refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/157274 [19:42:44] (03PS1) 10Trevor Parscal: [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 [19:43:15] ok, about 1/3 through I think [19:43:20] getting some lunch now [19:43:35] will finally have a MediaWiki theme by the end of the day [19:43:44] the buttons are the most fussy part [19:43:48] cyall in a bit [19:43:58] Woo. [19:43:59] (03CR) 10jenkins-bot: [V: 04-1] Automatically align popup toolgroups [oojs/ui] - 10https://gerrit.wikimedia.org/r/157295 (owner: 10Trevor Parscal) [19:49:15] (03PS1) 10Catrope: Don't use three different coordinate systems in getSelectionRect() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157868 (https://bugzilla.wikimedia.org/69122) [20:06:51] (03PS1) 10Catrope: Position the paste target just below the top of the screen [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157876 [20:09:57] (03PS1) 10Catrope: Reorder CSS rules in ve.ce.Surface.css to make sense [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157880 [20:10:58] (03CR) 10Jforrester: [C: 032] Reorder CSS rules in ve.ce.Surface.css to make sense [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157880 (owner: 10Catrope) [20:11:16] (03CR) 10Jforrester: [C: 031] Position the paste target just below the top of the screen [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157876 (owner: 10Catrope) [20:14:15] (03CR) 10Catrope: [C: 032] Fix `ve.dm.Transaction.newFromReplacement` when `removeMetadata` is true [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152017 (owner: 10Cscott) [20:15:51] (03PS11) 10Jforrester: Factor out ve.dm.Transaction.pushReplaceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116214 (owner: 10Catrope) [20:16:19] (03Merged) 10jenkins-bot: Fix `ve.dm.Transaction.newFromReplacement` when `removeMetadata` is true [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152017 (owner: 10Cscott) [20:17:29] (03CR) 10Catrope: [C: 031] Get confirmation when trying to insert/edit template with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk) [20:19:44] (03CR) 10Catrope: [C: 032] Use combo box widget to suggest existing values for reference group [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156160 (https://bugzilla.wikimedia.org/61574) (owner: 10Alex Monk) [20:21:34] (03Merged) 10jenkins-bot: Use combo box widget to suggest existing values for reference group [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156160 (https://bugzilla.wikimedia.org/61574) (owner: 10Alex Monk) [20:22:41] 3VisualEditor / 3Editing Tools: VisualEditor: Reference group input should be a "ComboBox" suggesting possible values - 10https://bugzilla.wikimedia.org/61574 (10Alex Monk) 5PATC>3RESO/FIX [20:23:00] (03CR) 10Catrope: [C: 04-1] "Code looks fine, but:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk) [20:23:10] (03CR) 10Catrope: [C: 032] Shrink height of summary box in save dialog from 80px to 4em [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157707 (owner: 10Jforrester) [20:25:01] (03Merged) 10jenkins-bot: Shrink height of summary box in save dialog from 80px to 4em [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157707 (owner: 10Jforrester) [20:31:35] James_F: mooey|away : A prilific Hebrew Wikipedia user called me on the phone today. He was pissed off at VE. He selected some text and clicked the Heading menu so it would become a heading. It did become a heading, but so did the next paragraph. He probably included the paragraph character in the end (whatever that thing is called in HTML). [20:32:40] I asked him how does he create headings in Microsoft Word. He said: "I select the whole text, I make its font 14px, I center it and I add an underline." [20:33:51] "== Heading ==" is actually more semantic to him. (And he's really not a developer geek type.) [20:40:30] And then I realized that in high school the computer teacher actually gave me a little advanced private lesson about the difference between character formatting and paragraph formatting. (It was not in Microsoft Word but in Dagesh - a wonderful Israeli development that supported Hebrew and a bunch of other languages exceptionally well, and had a very easy to understand styling system, but... [20:40:32] ...was pushed from the market violently by Microsoft.) [20:45:25] aharoni: We separate "formatting" from "styling" for that reason. [20:45:59] It didn't help him :) [20:47:18] It helps me, but back in 1997 I read the Microsoft Word user manual cover to cover (God knows why). [20:50:56] :-) [20:55:28] RoanKattouw_away: https://github.com/oojs/oojs.github.io/pull/4 [20:56:07] [13oojs.github.io] 15catrope pushed 1 new commit to 06master: 02https://github.com/oojs/oojs.github.io/commit/f2efa7801db3d6d25ddc6a12c2a733cc86100eab [20:56:07] 13oojs.github.io/06master 14f2efa78 15Roan Kattouw: Merge pull request #4 from oojs/release-1.1.0... [20:57:35] (03CR) 10Catrope: [C: 032] Allow override of window manager in language input widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157692 (owner: 10Esanders) [20:59:30] (03Merged) 10jenkins-bot: Allow override of window manager in language input widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157692 (owner: 10Esanders) [21:01:11] TrevorParscal: Hey, so did you know your MediaWiki theme commit is based on your "automatically align popup toolgroups" commit which is in turn based on your "Element mixin refactor" which is -1ed with EIGHTEEN comments? :D [21:03:43] (03CR) 10Catrope: [C: 032] Create ImageNode mixin to share logic between Block & Inline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155023 (owner: 10Esanders) [21:04:23] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/144089/ [21:05:29] (03CR) 10Jforrester: "Should this be abandoned?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121284 (owner: 10Divec) [21:05:50] (03Merged) 10jenkins-bot: Create ImageNode mixin to share logic between Block & Inline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155023 (owner: 10Esanders) [21:09:50] RoanKattouw: yeah, so what? [21:10:00] Just sayin'... [21:10:07] what sortta comments? [21:10:21] I'm trying to forge ahead, are they major or just typos and crap? [21:10:46] They are mostly minor, but some of your code is broken in minor ways [21:11:00] Feel free to forge ahead for now [21:11:26] But eventually you're gonna have to come back and clean this up, because all of your other commits depend on it [21:11:43] TrevorParscal: I offered to fix them, but RoanKattouw said you needed to look at some of them. [21:12:29] yeah, well feel free to fix the minor bits - I'm just trying to play catch up here, since I got derailed last week a bit [21:12:29] To be fair, some of them are comments like "I didn't know that flagging elements involved hair treatment" [21:12:37] But others are more serious, like "I don't think this works if you're switching from one icon to another" [21:12:38] lol [21:12:53] not that I don't love those kinds of comments.. just trying to keep momentum [21:13:37] I had to procure the Sketch app just to get going [21:13:40] James can fix the hair treatment comments, but there were a few places where I wanted you to defend what you're doing [21:13:50] ok [21:14:13] it's probably just a few oversights, the behavior should be very strightforward [21:14:15] No rush as far as I'm concerned, tomorrow would work just as well [21:14:34] James_F: so... about MatmaRex helping with thigns? [21:15:02] Any idea when would be a good time for me to be looping him in and all that? [21:15:10] TrevorParscal: Ask him. [21:15:21] Well, is he being paid? [21:15:25] No. [21:15:34] i'm generally available, nevertheless [21:15:34] Will he be soon? [21:15:38] lol [21:15:44] that's very kind of you [21:15:58] I basically need to get started on a few different things [21:16:08] the email I sent mentioned this [21:16:11] 3VisualEditor / 3MediaWiki integration: VisualEditor: after dismissing the little pink saving error window, the Save page button remains disabled - 10https://bugzilla.wikimedia.org/68460#c4 (10James Forrester) Badtoken errors are automatically recovered from, though… [21:16:12] I realize you already know [21:16:44] James_F: any progress on your SVG transformation tinkering? [21:17:02] TrevorParscal: Oh, I dumped that work. I said on Friday but you might have missed it. [21:17:26] dumped, as in the trash? [21:17:26] TrevorParscal: It didn't seem to work out for our needs, and I moved onto other things. [21:17:26] TrevorParscal: Sorry. [21:17:54] yeah [21:18:17] TrevorParscal: Dumped as in `git reset --hard`, but yes. [21:18:36] MatmaRex: how would you feel about working on grunt task that takes a JSON file and bunch of SVG files and generates different (specified) colored versions of the graphics in SVG and PNG (rendering!) formats? [21:19:02] and generates a LESS file to boot [21:19:30] our initial idea is to use existing libs for all we can, but the color transform seems to be something we will need to do ourselves [21:19:37] that's not exactly my forte, but i guess it's nothing i can't figure out [21:20:09] basically, read the SVG into an XML parser, transform fill and stroke attributes [21:20:22] it's not anyone's forte that I know of [21:20:25] 'round here [21:21:06] it landed with me, because I am championing SVG/PNG over icon fonts for a variety of reasons, and the blocker was "I want icons in other colors though!" [21:21:09] so, this was my idea [21:21:35] :D [21:21:55] i can definitely do that then, i also prefer SVGs to icon fonts [21:22:03] I figure we can list the icons in a JSON file, and specify which colors all should be in (like black/white) and also on a per-icon basis specify which alternate colors they should be in [21:22:28] we can just draw the icons in grayscale and do some color blending or something [21:22:35] we want to specify the actual colors separately, by symbolic name (this is a theme-dependent thing) [21:22:41] (assuming we want more than one color shade) [21:22:42] like in CSS? [21:22:46] not in all browsers [21:23:10] yeah, i know, i meant as soome compile/preprocess step, like you're saying [21:23:33] we will do all icons in black (currently OOjs UI uses black, with 80% transparency or some crap, but they should just be opaque black and we can do the transparency in HTML/CSS [21:23:39] ah [21:23:45] if we want to just achieve the same functionality as icon fonts coloring, then we can just apply the new color to everything [21:23:50] well, right now all icons anyone is using are mono [21:23:55] so, we don't need to do anything fancy [21:24:04] just override existing fill and stroke attributes [21:24:25] minding that they may not be present if the SVG default is being used [21:25:06] opacity and color can be independent, the 80% is not a problem, is it? [21:26:11] [13oojs.github.io] 15Krinkle 04deleted 06release-1.1.0 at 1488cbe7c: 02https://github.com/oojs/oojs.github.io/commit/88cbe7c [21:26:14] no, it's not a problem [21:26:19] so, assuming i need to write that colorifier from scratch, what do i need to write it in? [21:26:19] you don't need to solve that [21:26:31] SVG defaults to black fill and no stroke, FYI [21:26:39] node.js [21:26:41] [13oojs.github.io] 15Krinkle created 06release-1.1.0 at 1488cbe7c (+0 new commits): 02https://github.com/oojs/oojs.github.io/commits/release-1.1.0 [21:26:42] yeah, i know [21:26:43] as a grunt task [21:27:01] [13oojs.github.io] 15Krinkle 04deleted 06release-1.1.0 at 1488cbe7c: 02https://github.com/oojs/oojs.github.io/commit/88cbe7c [21:27:08] oh, i assumed the grunt task thingy would just shell out to whatever [21:27:24] well, we need it to be something we can publish with NPM [21:27:30] (in my opinion) [21:27:38] s/need/want [21:27:52] but, barring that, I would prefer if it were written in JS [21:28:11] because it will avoid introducing more dependencies to the build process, which is in JS [21:28:39] hm, including the SVG to PNG rendering? [21:28:54] yeah, there are lots of libs out there to do great thigns like that [21:29:47] you could even generate a PNG of arbitrary HTML man, https://www.npmjs.org/package/webshot [21:31:02] see this: https://www.npmjs.org/package/grunt-iconizr [21:31:06] that does like half the job [21:31:08] or more [21:31:36] no doubt, but surely these things call out to things outside JS [21:31:45] okay [21:31:58] yeah [21:32:21] well, that is true, but I just want to stick to things we can do with grunt/npm [21:32:53] as in, don't write it in PHP (maybe we will need to write something in PHP to get it into MediaWiki core, and integrate with RL to do this on the fly or something, but we don't need to do that now) [21:33:25] brb [21:33:44] TrevorParscal: you know, my favorite language is Ruby ;) [21:34:14] (03CR) 10Catrope: [C: 032] Factor out ve.dm.Transaction.pushReplaceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116214 (owner: 10Catrope) [21:34:54] MatmaRex: i forgive you :) [21:35:00] heh [21:35:43] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/157773/ [21:36:05] (03Merged) 10jenkins-bot: Factor out ve.dm.Transaction.pushReplaceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116214 (owner: 10Catrope) [21:36:48] (03CR) 10Jforrester: [C: 031] "Seems… sane?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157868 (https://bugzilla.wikimedia.org/69122) (owner: 10Catrope) [21:36:57] Krinkle: Uhm, did you see the unit test diff for that change? Nested if(window.mw){ if(window.mw) { ?? [21:37:18] RoanKattouw: Yes, did you see my comment above it and in the commit message? [21:37:34] Oh, I see [21:37:35] This is exactly why I removed it originally, but that was a mistake. [21:37:44] It's triggering wrapping for 2 separate reasons and so it's getting wrapped twice [21:37:57] yeah, but we never embed only=scripts [21:38:12] right [21:38:29] +2ed [21:39:06] Krinkle: You wanted https://gerrit.wikimedia.org/r/#/c/157773/ cherry-picked, right? [21:41:08] (03PS1) 10Jforrester: Update VE core submodule to master (9512223) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157986 [21:41:33] (03PS2) 10Jforrester: Update VE core submodule to master (9512223) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157986 [21:41:45] Whee, another all-numbers one. [21:41:46] 9512223 [21:42:33] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (9512223) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157986 (owner: 10Jforrester) [21:42:52] James_F, what to do about https://bugzilla.wikimedia.org/show_bug.cgi?id=68460 ? [21:42:55] James_F: yep, to any deployed wmf branches cut after 9272bc6c47, 03c503da22. [21:44:12] Krenair: Not sure. [21:46:00] Krinkle: 03c503da22 only went out in wmf19; 9272bc6c47 went out in wmf17. [21:46:08] Krinkle: So… just wmf19? [21:46:19] (03PS1) 10Krinkle: jsduck: Rename config file to jsduck.json (per standard) [oojs/core] - 10https://gerrit.wikimedia.org/r/157989 [21:46:27] James_F: Yep [21:46:35] OK. [21:46:36] (03CR) 10Krinkle: [C: 04-1] "Not until Jenkins is updated." [oojs/core] - 10https://gerrit.wikimedia.org/r/157989 (owner: 10Krinkle) [21:47:07] RoanKattouw_away: you may want to publish your comments, I only see 1 comment on each -1'd patch [21:47:50] (03CR) 10jenkins-bot: [V: 04-1] jsduck: Rename config file to jsduck.json (per standard) [oojs/core] - 10https://gerrit.wikimedia.org/r/157989 (owner: 10Krinkle) [21:52:42] 3VisualEditor / 3ContentEditable: Add unknown field automatically - 10https://bugzilla.wikimedia.org/70228#c1 (10James Forrester) 5NEW>3RESO/DUP I think this is a duplicate of bug 52135. *** This bug has been marked as a duplicate of bug 52135 *** [21:52:42] 3VisualEditor / 3Editing Tools: VisualEditor: VE should detect template parameters automatically instead of using hand-written TemplateData - 10https://bugzilla.wikimedia.org/52135#c9 (10James Forrester) *** Bug 70228 has been marked as a duplicate of this bug. *** [21:53:51] James_F, also, to clarify about badtoken - I was talking about saveErrorNewUser [21:54:23] for invalid session [21:56:17] it appears VE gets a new token to check whether the user ID has changed, when a badtoken error is encountered [21:57:21] (03CR) 10Krinkle: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/157989 (owner: 10Krinkle) [21:57:37] Krenair: Yeah. [21:58:27] Yeah we don't expose a badtoken error to the error handling code unless the API gave us a badtoken error twice [21:58:35] In which case the server's session storage is probably broken [21:58:58] TrevorParscal: The element refactor has comments on an older patchset [21:59:20] (PS3) [21:59:54] (03CR) 10Krinkle: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/157989 (owner: 10Krinkle) [22:01:56] (03PS1) 10Krinkle: jsduck: Rename config file to jsduck.json (per standard) [oojs/ui] - 10https://gerrit.wikimedia.org/r/157999 [22:02:18] (03CR) 10Jforrester: [C: 032] jsduck: Rename config file to jsduck.json (per standard) [oojs/core] - 10https://gerrit.wikimedia.org/r/157989 (owner: 10Krinkle) [22:03:04] (03CR) 10jenkins-bot: [V: 04-1] jsduck: Rename config file to jsduck.json (per standard) [oojs/ui] - 10https://gerrit.wikimedia.org/r/157999 (owner: 10Krinkle) [22:06:12] (03Merged) 10jenkins-bot: jsduck: Rename config file to jsduck.json (per standard) [oojs/core] - 10https://gerrit.wikimedia.org/r/157989 (owner: 10Krinkle) [22:09:11] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340#c3 (10Roan Kattouw) (In reply to Roan Kattouw from comment #2) > Hmm, this sounds like a bug related to Clipp... [22:16:38] (03CR) 10Krinkle: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/157999 (owner: 10Krinkle) [22:17:43] (03CR) 10Jforrester: [C: 032] jsduck: Rename config file to jsduck.json (per standard) [oojs/ui] - 10https://gerrit.wikimedia.org/r/157999 (owner: 10Krinkle) [22:18:35] (03Merged) 10jenkins-bot: jsduck: Rename config file to jsduck.json (per standard) [oojs/ui] - 10https://gerrit.wikimedia.org/r/157999 (owner: 10Krinkle) [22:24:26] 3VisualEditor / 3Editing Tools: VisualEditor: Stop users from deleting parameters in the template dialog if they're marked as "required" in TemplateData - 10https://bugzilla.wikimedia.org/60358#c6 (10James Forrester) (In reply to Ricordisamoa from comment #5) > VisualEditor should only make edits easier, I... [22:25:17] RoanKattouw: i see that now [22:25:27] should it be -1'd? [22:25:37] Isn't it? [22:25:49] no, I guess it got wiped when PS4 came in [22:25:56] Oh, right. Tsk. [22:26:22] (03CR) 10Jforrester: [C: 04-1] "Per Roan's comments on PS3." [oojs/ui] - 10https://gerrit.wikimedia.org/r/157274 (owner: 10Trevor Parscal) [22:26:24] Happy? [22:27:22] lol [22:27:41] so... I'm planning on leaving it to Ed and Thalia, but Ed and I were talking about hanging at mine after I pick him up - consider traffic at 4:45pm into SF for one, and I already have everything for burgers (including veggie burgers) [22:27:44] Sorry for claiming that commit was -1ed while it was the only one that wasn't -1e [22:27:54] so, when I pick them up, I'm going to let them choose [22:28:08] but, I'm offering to BBQ at mine [22:28:18] if we do that, you and/or Roan are welcome [22:28:31] and I will give everyone rides back to "the neighborhood" in the evening [22:28:40] *"the hood" [22:28:48] Come on Trevor, you've lived in Antioch, you know better [22:28:59] 3VisualEditor: VisualEditor: Adding a template to a redirect did not let me save the page - 10https://bugzilla.wikimedia.org/70305 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps taken: 1. Open a redirect to edit. 2. Add a template: {{R from other languages}} 3. Discover that I can't sa... [22:29:02] otherwise, we should have a specific restaurant (or maybe a couple of options) already planned out [22:29:11] 3VisualEditor: VisualEditor: Adding a template to a redirect did not let me save the page - 10https://bugzilla.wikimedia.org/70305 (10WhatamIdoing) 5NEW>3UNCO [22:29:22] But yeah, traffic into SF (from SFO!) around 5 won't be great [22:29:33] yeah, it will not be 5pm by the time we are all in SF (as your event suggested) [22:29:38] more like 6 [22:29:40] seriously [22:30:05] 280 is open again, but you'd still have to get there from SFO, which means 101 (or a ridiculous jump via 380) [22:30:57] Anyway, again, it's really up to them - but between traffic and my own preference to have a low-key welcome back to SF party at mi casa, I'm hoping they will choose BBW [22:30:59] *BBQ [22:31:11] so, Roan, perhaps you should come up with a travel plan for you guys [22:31:12] 3VisualEditor: VisualEditor: Adding a template to a redirect did not let me save the page - 10https://bugzilla.wikimedia.org/70305#c1 (10WhatamIdoing) Created attachment 16345 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16345&action=edit Screenshot showing the template that I just added (highlighte... [22:31:37] BART + SamTrans 118 or BART + Trevor Taxi [22:32:12] also, Asher.getStatus(); [22:32:43] TrevorParscal: I think SFO->SF->Food makes most sense. [22:32:52] TrevorParscal: I'm already looking [22:32:52] My memory has not betrayed me [22:32:52] We need to take BART at 4:19 or 5:19 or 6:19 to catch the 118 [22:33:21] James_F: well, I'm not telling you where to be tonight [22:33:28] just where you are welcome :) [22:33:36] TrevorParscal: :-) [22:33:44] TrevorParscal: If you're sure Ed&Thal will be OK… [22:34:21] Well, they seemed keen to BBQ last we spoke [22:34:42] I will know in 30min [22:34:47] Kk. [22:34:47] when they land and he starts texting [22:34:56] You're not collecting them? [22:35:01] I am [22:35:17] I'm saying he's gonna be texting on Hangouts when they land [22:35:18] His plane is flying south over the peninsula right now [22:35:26] It looks like it's about to turn over San Jose and land [22:35:53] they're 1 min ahead looks like [22:36:01] Hangouts !== texting. [22:36:03] Oh, hah, it's turning over Stanford actually. He should be on the ground in 10 minutes I think [22:36:13] RoanKattouw: Plane spotter. :-P [22:36:18] James_F: you're not wrong James [22:36:28] TrevorParscal: I'm just wonderful. [22:36:33] James_F: I know that approach route quite well, I went to school under it :) [22:36:36] RoanKattouw: isn't that like 5 min lag or something? [22:36:50] TrevorParscal: Yeah, so Ed's probably wheels-down in ~4 minutes. [22:36:53] RoanKattouw: let's be honest, that's not the only reason you know that route well [22:36:57] nice [22:36:58] TrevorParscal: FAA data is but I believe this is crowd-sourced live data [22:37:39] ok, so Roan, I'm guessing the 5:19 is ideal? [22:37:48] if we end up with the BBQ plan [22:38:15] Probably, that gets us there at 6 [22:38:27] seems pretty reasonable to me [22:38:30] The 4:19 gets us there at 5 [22:38:34] I prefer Trevor-taxi, TBF. [22:38:46] James_F: that can be arranged [22:38:53] TrevorParscal: :-) [22:41:07] so, according to the designs, which I'm following (and ignoring all 1.5M other versions of MediaWiki/Agora/Pegusus/Zeus/Promethius UI) [22:41:42] 3VisualEditor / 3MediaWiki integration: VisualEditor: after dismissing the little pink saving error window, the Save page button remains disabled - 10https://bugzilla.wikimedia.org/68460#c5 (10Alex Monk) James_F, also, to clarify about badtoken - I was talking about saveErrorNewUser for i... [22:41:46] the down indicator we use, which is on a 12x12 viewbox... They use a 28px wide chevron-like symbol (like our expand icon) [22:41:56] aharoni, James_F: Shall we make that unconfirmed then? :/ [22:42:06] Krenair: aharoni's call. [22:42:25] so, even if I bring their down indicator to 24 (probably an unnoticeable change) [22:42:30] it's still 2x to big [22:42:39] however, the 12px rule for indicators isn't set in stone [22:42:41] Krenair: But I trust aharoni to have found an actual bug. [22:42:53] in fact, we litterally render them in equal size boxes as icons [22:43:14] James_F: Krenair: Sorry - I'm really not sure what caused that error, only that it was pink :) [22:44:36] so, perhaps the 12px rule doesn't matter at all, it's just something we've done because indicators tend to be minor graphics in comparison to the larger icons - but... yeah. [22:45:32] the other thing is I need to replace the up/down/ltr/rtl indicators with these open angle style arrows for MediaWiki [22:45:34] aharoni, when you see an error and report a bug based on it, the developers usually need to see the error as well :p [22:45:40] (I don't really know who I'm talking to) [22:46:12] (I guess I'm just hoping I don't sound too crazy, thus my decisions won't later be thought insane) [22:46:15] Krenair: Of course... that was the problem with it, that I noticed the bug after closing that window. [22:51:33] TrevorParscal: Hmm why are their indicators so big? [22:51:46] I do agree that if we're going to do big indicators, let's do 24px not 28 [22:52:35] dude, this theme is so poorly designed [22:54:00] OK well I know you're trying to execute it as closely to their design as possible so you can wash your hands in innocence later, but I would like it if we could at least tweak the sizes of things to be less numerically offensive (so 28 --> 24) [22:54:07] it was made in a vaccum, not a single real-world use-case considered, everything is arbitrary, tons of small (and some big) overzealous simplifications that cause controls to fail to communicate their state or behavior [22:54:22] I will be using 24px [22:54:29] but yes, I'm not changing anything [22:55:18] the good news is, so far OOjs UI has been easy to write a new theme for [22:55:42] to be fair, it may only be easy for me since I invented it [22:56:04] but so far, no upstream changes (though I think some will be coming, esp. when we get to dialogs) [22:58:09] in the design, which is just a giant vector drawing, the example for a "text combo" is a download button - it seems like a really poorly designed control, but even it it weren't they use green in the example - and I'm just trying to figure out why downloading a file is "contructive" [22:58:16] I guess it creates a file on your computer [22:58:21] * TrevorParscal is getting grumpy [22:58:41] Oh no that's a combo button I think [22:58:47] It has a fairly narrow use case [22:58:54] There is a default action and several alternate actions [22:59:33] Clicking on the main body of the button executes the default action (Download original, say) whereas clicking the dropdown arrow exposes alternate actions you can click (Download 200px thumbnail, download 500px thumbnail, etc.) [22:59:44] Replace thumbnails with video formats for a better use case, I guess [23:00:26] Meanwhile, Ed's plane allegedly arrived at the gate 11 minutes ago [23:00:46] yeah [23:00:48] saw that [23:00:50] leaving now [23:00:56] will be in touch shortly [23:01:03] Bye TrevorParscal. [23:01:04] He may be a while longer though [23:01:08] Immigration and stuff [23:01:29] But, if he got in 11 mins ago... yeah leave in the next 5-10 mins [23:12:27] 3VisualEditor / 3ContentEditable: VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - 10https://bugzilla.wikimedia.org/50036 (10Alex Monk) [23:34:23] Any word from Ed yet? Nearly to terminal a arrival area [23:40:26] 3VisualEditor / 3Editing Tools: VisualEditor: Stop users from deleting parameters in the template dialog if they're marked as "required" in TemplateData - 10https://bugzilla.wikimedia.org/60358#c7 (10Ricordisamoa) (In reply to James Forrester from comment #6) > The wikitext editor lets you do lots of things... [23:42:13] (03PS1) 10Catrope: Ignore focusin/focusout events on iframes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158027 [23:42:19] TrevorParscal: I haven't heard anything [23:43:07] (03PS2) 10Catrope: Ignore focusin/focusout events on iframes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158027 [23:53:31] (03PS10) 10Alex Monk: Get confirmation when trying to insert/edit template/citation with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) [23:53:57] (03CR) 10Alex Monk: [C: 04-1] "Deals with citation dialog now, but still uses confirm()" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk) [23:57:11] 3VisualEditor / 3MediaWiki integration: $wgVisualEditorParsoidForwardCookies should be unconditional - 10https://bugzilla.wikimedia.org/70131#c6 (10Marc A. Pelletier) 5NEW>3RESO/WON As designed, then.