[00:00:09] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] "This sucks." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157868 (https://bugzilla.wikimedia.org/69122) (owner: 10Catrope)
[00:01:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't use /** in CSS or LESS, use /* instead [oojs/ui] - 10https://gerrit.wikimedia.org/r/158292 (owner: 10Catrope)
[00:03:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only focus the paste target if focusedNode has changed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158269 (https://bugzilla.wikimedia.org/70356) (owner: 10Esanders)
[00:03:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't use three different coordinate systems in getSelectionRect() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157868 (https://bugzilla.wikimedia.org/69122) (owner: 10Catrope)
[00:04:44] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf16] Opening link inspector/comment box in an empty line, opens them at the end of the previous line - 10https://bugzilla.wikimedia.org/69122 (10James Forrester) 5PATC>3RESO/FIX
[00:05:13] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf20] Link target names are not appearing pressing command+K just applying the link text as link target straight off - 10https://bugzilla.wikimedia.org/70356 (10James Forrester) 5PATC>3RESO/FIX
[00:05:44] <MatmaRex>	 TrevorParscal: so, i'm looking into the SVG icons thing
[00:05:51] <TrevorParscal>	 right on
[00:06:08] <MatmaRex>	 TrevorParscal: iconizr which you linked seems to insist on creating sprites for everything, but this looks very neat: https://www.npmjs.org/package/grunt-grunticon
[00:06:17] <MatmaRex>	 can colorize them already, too
[00:06:30] <grrrit-wm>	 (03PS1) 10Catrope: Refactor getSelectionRect()-related insanity [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158293 
[00:06:58] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Category suggestion lists no longer existing categories - 10https://bugzilla.wikimedia.org/70025 (10James Forrester)
[00:06:58] <wikibugs>	 3VisualEditor: Category suggestions include non-existent and implausible suggestions - 10https://bugzilla.wikimedia.org/69927 (10James Forrester)
[00:07:04] <RoanKattouw>	 edsanders: https://gerrit.wikimedia.org/r/158293
[00:07:04] <James_F>	 MatmaRex: I tried playing with it.
[00:07:08] <James_F>	 MatmaRex: I got a bit lots.
[00:07:12] <James_F>	 Err. Lost.
[00:07:18] <MatmaRex>	 it doesn't insist on minifying everything, too, which is another annoying thing iconizr insists on
[00:07:39] <MatmaRex>	 (and svgo was too buggy for unsupervised use last time i checked)
[00:07:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor getSelectionRect()-related insanity [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158293 (owner: 10Catrope)
[00:08:18] <MatmaRex>	 James_F: hmm. well, i'll try playing with it, too, and report back ;)
[00:08:35] <James_F>	 MatmaRex: Awesome.
[00:08:41] <MatmaRex>	 i looked into how the css for ooui icons is generated today and wept once :/
[00:08:51] <James_F>	 MatmaRex: Blame TrevorParscal. :-)
[00:08:54] <grrrit-wm>	 (03PS2) 10Catrope: This British Man Pointed Out Inconsistent Coordinate Systems. You'll Never Believe What Happened Next! [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158293 
[00:09:18] <MatmaRex>	 (at first i couldn't even figure out where the code is, heh. it's as if you deliberately made it ungreppable :P)
[00:09:28] <TrevorParscal>	 MatmaRex: looks awesome!
[00:09:39] <James_F>	 MatmaRex: ;-)
[00:10:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] This British Man Pointed Out Inconsistent Coordinate Systems. You'll Never Believe What Happened Next! [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158293 (owner: 10Catrope)
[00:11:32] <MatmaRex>	 i'll probably have something worth looking at tomorrow evening
[00:11:48] <MatmaRex>	 (or some angry rambling to share if grunticon is as bad as james says)
[00:11:48] <grrrit-wm>	 (03CR) 10Catrope: "@Krinkle: It's position: fixed so the scroll position is irrelevant. The fact that the browser did try to scroll is what caused it to scro" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157876 (owner: 10Catrope)
[00:12:03] <grrrit-wm>	 (03CR) 10Catrope: Position the paste target just below the top of the screen (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157876 (owner: 10Catrope)
[00:13:12] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Support Android - 10https://bugzilla.wikimedia.org/70372 (10James Forrester) p:5Unprio>3Normal
[00:13:14] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Support Android - 10https://bugzilla.wikimedia.org/70372 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3None We should even if it's a minuscule part of the market for tablets, because we're going to eventually support phones (and for decency's sake).
[00:13:44] <grrrit-wm>	 (03PS5) 10Catrope: Update OOjs UI to v0.1.0-pre (4cef83f702) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157286 (owner: 10Trevor Parscal)
[00:14:43] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - 10https://bugzilla.wikimedia.org/67262 (10James Forrester)
[00:14:43] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on Return while cursor is at the end of a text , deletes that text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66758 (10James Forrester)
[00:14:43] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any edit in mobile VE for Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66756 (10James Forrester)
[00:14:57] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Support Android - 10https://bugzilla.wikimedia.org/70372 (10James Forrester)
[00:15:00] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping at the end of each link, does copy-paste of preceding link text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66755 (10James Forrester)
[00:15:00] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any edit in mobile VE for Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66756 (10James Forrester)
[00:15:00] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping at the end of each link, does copy-paste of preceding link text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66755 (10James Forrester)
[00:15:01] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on Return while cursor is at the end of a text , deletes that text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66758 (10James Forrester)
[00:15:02] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - 10https://bugzilla.wikimedia.org/67262 (10James Forrester)
[00:15:29] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (4cef83f702) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157286 (owner: 10Trevor Parscal)
[00:15:55] <James_F>	 edsanders: https://gerrit.wikimedia.org/r/#/c/158027/
[00:16:12] <James_F>	 edsanders: https://gerrit.wikimedia.org/r/#/c/155807/
[00:17:14] <wikibugs>	 3VisualEditor: VisualEditor:  Categories incorrectly moved up, possibly due to improperly closed table - 10https://bugzilla.wikimedia.org/70373 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None https://fr.wikipedia.org/w/index.php?title=Jorge_Salinas&diff=107045495&oldid=107045412  It's possible that s...
[00:17:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (4cef83f702) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157286 (owner: 10Trevor Parscal)
[00:17:55] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] This British Man Pointed Out Inconsistent Coordinate Systems. You'll Never Believe What Happened Next! [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158293 (owner: 10Catrope)
[00:18:02] <grrrit-wm>	 (03PS2) 10Mooeypoo: Add autovalue to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 
[00:18:09] <grrrit-wm>	 (03PS2) 10Jforrester: Position the paste target just below the top of the screen [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157876 (owner: 10Catrope)
[00:19:04] <grrrit-wm>	 (03CR) 10Esanders: This British Man Pointed Out Inconsistent Coordinate Systems. You'll Never Believe What Happened Next! (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158293 (owner: 10Catrope)
[00:19:28] <Juandev>	 ummm Ozyes wake up
[00:19:42] <Juandev>	 or Ozies
[00:20:07] <Krenair>	 ... What?
[00:20:12] <wikibugs>	 3VisualEditor: VisualEditor: Duplicating categories (and possibly also something else) - 10https://bugzilla.wikimedia.org/54169 (10WhatamIdoing)
[00:20:15] <wikibugs>	 3VisualEditor / 3Data Model: Categories/default sort sometimes duplicated to random position in DOM after edit - 10https://bugzilla.wikimedia.org/50120 (10WhatamIdoing)
[00:20:20] <Juandev>	 !time
[00:20:46] <grrrit-wm>	 (03PS5) 10Jforrester: Update VE core submodule to master (1f82a47) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157285 (owner: 10Trevor Parscal)
[00:21:21] <Juandev>	 Krenair: australians
[00:21:29] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Position the paste target just below the top of the screen [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157876 (owner: 10Catrope)
[00:22:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (1f82a47) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157285 (owner: 10Trevor Parscal)
[00:23:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Position the paste target just below the top of the screen [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157876 (owner: 10Catrope)
[00:25:18] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Ignore focusin/focusout events on iframes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158027 (owner: 10Catrope)
[00:27:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Ignore focusin/focusout events on iframes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158027 (owner: 10Catrope)
[00:29:21] <grrrit-wm>	 (03PS3) 10Catrope: Absolutely eradicate absolute selection coordinates [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158293 
[00:30:37] <MatmaRex>	 night
[00:31:23] <Juandev>	 MatmaRex: night, Dobrou
[00:33:39] <RoanKattouw>	 TrevorParscal: https://gerrit.wikimedia.org/r/157202
[00:36:31] <grrrit-wm>	 (03PS5) 10Trevor Parscal: [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 
[00:37:44] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Make menus reevaluate their clipping when they change [oojs/ui] - 10https://gerrit.wikimedia.org/r/157202 (https://bugzilla.wikimedia.org/70115) (owner: 10Catrope)
[00:38:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make menus reevaluate their clipping when they change [oojs/ui] - 10https://gerrit.wikimedia.org/r/157202 (https://bugzilla.wikimedia.org/70115) (owner: 10Catrope)
[00:39:03] <grrrit-wm>	 (03PS2) 10Jforrester: Reorder CSS rules in ve.ce.Surface.css to make sense [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157880 (owner: 10Catrope)
[00:39:08] <grrrit-wm>	 (03CR) 10Jforrester: "PS2 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157880 (owner: 10Catrope)
[00:39:20] <grrrit-wm>	 (03PS3) 10Catrope: Reorder CSS rules in ve.ce.Surface.css to make sense [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157880 
[00:40:00] <grrrit-wm>	 (03PS4) 10Catrope: Reorder CSS rules in ve.ce.Surface.css to make sense [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157880 
[00:40:28] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Reorder CSS rules in ve.ce.Surface.css to make sense [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157880 (owner: 10Catrope)
[00:41:05] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (36d0c7dc3b) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158301 
[00:41:23] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/158300
[00:41:37] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (36d0c7dc3b) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158301 (owner: 10Jforrester)
[00:43:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reorder CSS rules in ve.ce.Surface.css to make sense [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/157880 (owner: 10Catrope)
[00:43:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (36d0c7dc3b) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158301 (owner: 10Jforrester)
[00:43:42] <James_F>	 edsanders: https://gerrit.wikimedia.org/r/#/c/158293/
[00:44:16] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Remove lies about event objects being passed through [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155807 (owner: 10Catrope)
[00:44:19] <grrrit-wm>	 (03CR) 10Esanders: Absolutely eradicate absolute selection coordinates (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158293 (owner: 10Catrope)
[00:44:43] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor:  Cells in tables are styled like regular paragraphs, and they shouldn't be - 10https://bugzilla.wikimedia.org/65416 (10WhatamIdoing)
[00:44:43] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Support tables (tracking) - 10https://bugzilla.wikimedia.org/39596 (10WhatamIdoing)
[00:44:57] <wikibugs>	 3VisualEditor / 3ContentEditable: Deleting a block with a table, leaves the table in place upon save - 10https://bugzilla.wikimedia.org/69706 (10WhatamIdoing)
[00:44:57] <wikibugs>	 3VisualEditor: VisualEditor:  Categories incorrectly moved up, possibly due to improperly closed table - 10https://bugzilla.wikimedia.org/70373 (10WhatamIdoing)
[00:46:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove lies about event objects being passed through [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155807 (owner: 10Catrope)
[00:47:32] <Krenair>	 James_F, went to update the parsoid part of this patch
[00:47:42] <James_F>	 Krenair: Fun?
[00:47:44] <Krenair>	  /var/www/MediaWiki/extensions/VisualEditor/parsoid/lib/mediawiki.HTML5TreeBuilder.node.js:58
[00:47:44] <Krenair>	 		this.parser = new HTML5.DOMParser( domino );
[00:47:51] <Krenair>	 TypeError: undefined is not a function
[00:48:04] <James_F>	 Have you done `npm install` recently?
[00:48:07] <Krenair>	 no
[00:48:08] <grrrit-wm>	 (03PS4) 10Catrope: Absolutely eradicate absolute selection coordinates [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158293 
[00:48:18] <Krenair>	 James_F, it does nothing
[00:48:24] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (1f82a47) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157285 (owner: 10Trevor Parscal)
[00:48:42] <Krenair>	 James_F, from the wrong directory. Oops.
[00:48:47] <James_F>	 :-)
[00:49:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (1f82a47) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157285 (owner: 10Trevor Parscal)
[00:49:29] <wikibugs>	 3VisualEditor: VisualEditor:  Cutting and pasting a table (to move it to a new place on the same page) causes loss of row height formatting, inability to save - 10https://bugzilla.wikimedia.org/70375 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None See https://en.wikipedia.org/wiki/File:VisualEditorTa...
[00:49:42] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Support tables (tracking) - 10https://bugzilla.wikimedia.org/39596 (10WhatamIdoing)
[00:49:42] <wikibugs>	 3VisualEditor: VisualEditor:  Cutting and pasting a table (to move it to a new place on the same page) causes loss of row height formatting,  inability to save - 10https://bugzilla.wikimedia.org/70375 (10WhatamIdoing)
[00:49:58] <wikibugs>	 3MediaWiki extensions / 3Cite: Cite: Support multi-column and alternative list-style for <references /> tag (like enwiki {{reflist}}) - 10https://bugzilla.wikimedia.org/51260#c35 (10Alex Monk) a:5Gabriel Wicke>3Alex Monk I picked up the Cite & VE parts of this again.
[00:50:21] <Krenair>	 gyp WARN EACCES user "root" does not have permission to access the dev dir "/home/alex/.node-gyp/0.10.25"
[00:50:37] <RoanKattouw>	 Krenair: Are you running npm install as root? Don't
[00:51:02] <RoanKattouw>	 Also 'user "root" does not have permission to do X' ---> WTF how can that *ever* happen
[00:51:17] <Krenair>	 indeed.
[00:51:43] <RoanKattouw>	 So, 1) run npm install as alex, not root or whatever, and 2) chown -R alex ~/.node*
[00:52:02] <RoanKattouw>	 You've probably run npm install as another user at some point in the past and that always screws up permissions
[00:53:05] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (1f82a47) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157285 (owner: 10Trevor Parscal)
[00:54:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (1f82a47) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/157285 (owner: 10Trevor Parscal)
[00:55:25] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (8eb47c7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158305 
[00:56:44] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (8eb47c7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158305 (owner: 10Jforrester)
[00:58:15] <grrrit-wm>	 (03PS6) 10Alex Monk: WIP Support new column-width & mode attributes to Cite's <references> [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123093 (https://bugzilla.wikimedia.org/51260) 
[00:58:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (8eb47c7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158305 (owner: 10Jforrester)
[00:58:46] <James_F>	 edsanders: https://gerrit.wikimedia.org/r/#/c/158293/4,publish
[01:00:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP Support new column-width & mode attributes to Cite's <references> [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123093 (https://bugzilla.wikimedia.org/51260) (owner: 10Alex Monk)
[01:02:43] <wikibugs>	 3OOjs UI: OOjs UI: MenuWidget does not resize correctly when being clipped - 10https://bugzilla.wikimedia.org/70115 (10James Forrester) 5PATC>3RESO/FIX
[01:04:12] <grrrit-wm>	 (03PS5) 10Catrope: Absolutely eradicate absolute selection coordinates [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158293 
[01:04:48] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Absolutely eradicate absolute selection coordinates [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158293 (owner: 10Catrope)
[01:07:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Absolutely eradicate absolute selection coordinates [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158293 (owner: 10Catrope)
[01:08:25] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (65991da) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158307 
[01:10:17] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (65991da) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158307 (owner: 10Jforrester)
[01:12:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (65991da) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158307 (owner: 10Jforrester)
[01:14:53] <grrrit-wm>	 (03PS7) 10Alex Monk: WIP Support new column-width & mode attributes to Cite's <references> [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123093 (https://bugzilla.wikimedia.org/51260) 
[01:16:35] <grrrit-wm>	 (03PS18) 10Mooeypoo: Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) 
[01:16:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) (owner: 10Mooeypoo)
[01:19:06] <grrrit-wm>	 (03PS19) 10Mooeypoo: Check for changes in the model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152790 (https://bugzilla.wikimedia.org/68058) 
[01:38:15] <SlaveMaster>	 Alex Monk? interesting name
[01:38:36] <Krenair>	 Hi Juandev.
[01:38:52] <SlaveMaster>	 hi Juandev:-)
[01:39:54] <SlaveMaster>	 who is S_etlana?
[01:41:24] <SlaveMaster>	 well, this nickname is not cool
[02:00:15] <Juandev>	 well, time to sleep
[03:41:47] <grrrit-wm>	 (03PS4) 10Alex Monk: Split out isPending, pushPending, popPending, etc. into PendingElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/156459 
[03:46:44] <grrrit-wm>	 (03CR) 10Alex Monk: Split out isPending, pushPending, popPending, etc. into PendingElement (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/156459 (owner: 10Alex Monk)
[05:24:57] <wikibugs>	 3VisualEditor / 3Language: VisualEditor:  Cannot type in Korean using Mozilla on Windows 7 with dual-script keyboard - 10https://bugzilla.wikimedia.org/70353#c3 (10Ellif d.a) Exactly same problem of bug 50631. This should be merge into 50631.
[09:03:59] <Juandev>	 moorning
[09:18:42] <wikibugs>	 3VisualEditor / 3Editing Tools: Give exact match when looking for a specific file - 10https://bugzilla.wikimedia.org/62917#c2 (10Juan de Vojníkov) (In reply to Elitre from comment #1) > I believe that this request is a duplicate, in that it depends on the > results from the search not being perfect. > If you...
[11:16:42] <wikibugs>	 3VisualEditor / 3Editing Tools: Give exact match when looking for a specific file - 10https://bugzilla.wikimedia.org/62917#c3 (10Andre Klapper) [Please avoid full-quotes of previous comments.]
[12:55:44] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor bugs: wikilinks, tables, nowiki and other - 10https://bugzilla.wikimedia.org/70396 (10Dan) 3UNCO p:3Unprio s:3major a:3None VisualEditor editor is full of bugs. Since his implementation i have disabled it for me, because, as experimented user i just like...
[12:58:29] <wikibugs>	 3VisualEditor: Header line does not expand to full width - 10https://bugzilla.wikimedia.org/70397 (10Jan Ainali) 3NEW p:3Unprio s:3trivia a:3None Created attachment 16368   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16368&action=edit Screen cast of the sequence  When editing a page with an in...
[13:15:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Dropdown menu shows scrollbars - 10https://bugzilla.wikimedia.org/69707#c3 (10Jan Ainali) I guess this became a problem when the cancel button was removed.
[14:00:27] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor bugs: wikilinks, tables, nowiki and other - 10https://bugzilla.wikimedia.org/70396#c1 (10Andre Klapper) Please file only one specific problem per report and stick to the topic (general complaints about perceived quality of software can go to wikis, mailing lists...
[14:01:27] <wikibugs>	 3MediaWiki extensions / 3WikiEditor: "Show edit toolbar" preference is confusing - 10https://bugzilla.wikimedia.org/30795 (10Helder)
[14:38:21] <grrrit-wm>	 (03CR) 10Krinkle: "Ugh, there's still no trace anywhere in Gerrit why this was added, nor why it was removed again." [oojs/ui] - 10https://gerrit.wikimedia.org/r/158271 (owner: 10Jforrester)
[15:01:28] <mooeypoo>	 Krinkle, heya, I've re-added the "adding autovalue to the templatedata editor" fix and just added you as a reviewer. https://gerrit.wikimedia.org/r/#/c/157820/
[15:02:20] <mooeypoo>	 tried my best with the tests, and also added another test at the end to make sure the parameter/attribute values remain. Not sure it's trictly necessary, but I thought it was worth having as a test since nothing else tested it completely? 
[15:05:13] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Use grunt-grunticon to convert SVG icons to PNG for distribution [oojs/ui] - 10https://gerrit.wikimedia.org/r/158386 
[15:07:58] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I was planning to add a PNG optimization step, but then I compared the new and old distributions, and new is already smaller. The build st" [oojs/ui] - 10https://gerrit.wikimedia.org/r/158386 (owner: 10Bartosz Dziewoński)
[15:08:43] <MatmaRex>	 James_F|Away: you were right, grunticon is indeed a pita, and i haven't dug into the whole colorizing part yet
[15:09:04] <MatmaRex>	 but seems worth it
[15:31:23] <grrrit-wm>	 (03PS1) 10Mooeypoo: Set default dimensions based on original dimensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158395 (https://bugzilla.wikimedia.org/68000) 
[15:40:07] <James_F>	 MatmaRex: Well, if you get it working, kudos. :-)
[15:41:13] * James_F reviews.
[15:44:20] <James_F>	 MatmaRex: The SVG->PNG step looks good.
[15:45:12] <MatmaRex>	 James_F: but the black SVG -> colored SVGs look pretty stupid, actually
[15:45:22] <James_F>	 The step or the output?
[15:45:41] <MatmaRex>	 uhh, probably both
[15:46:06] <MatmaRex>	 it seems that the colors to generate are passed by adding them to file names of every SVG file
[15:46:33] <James_F>	 Yeah.
[15:46:40] <James_F>	 When I worked on this my steps were:
[15:46:51] <James_F>	 * Have a JSON file that specifies file -> colour maps.
[15:47:12] <James_F>	 * Read file, then cp each file to file.{colour}.svg in the action directory
[15:47:25] <James_F>	 * Then cry about ghastliness.
[15:47:28] <MatmaRex>	 yeah, i was just thinking that out
[15:47:31] <MatmaRex>	 hah
[15:47:41] <James_F>	 This is why I gave up. :-)
[15:48:09] <MatmaRex>	 and we need to do all that twice, once for PNG and once for SVG files
[15:48:11] <MatmaRex>	 okaaay
[15:48:14] <MatmaRex>	 can't be that bad
[15:48:20] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Minor issue, otherwise good." (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/158386 (owner: 10Bartosz Dziewoński)
[15:48:26] <James_F>	 MatmaRex: Well, no.
[15:48:32] <MatmaRex>	 alternatively, we could fork the underlying library to be less stupid
[15:48:36] <MatmaRex>	 https://github.com/filamentgroup/directory-colorfy/blob/master/lib/colorfy.js
[15:48:37] <James_F>	 MatmaRex: We can do the SVG->PNG conversion afterwards.
[15:48:56] <James_F>	 Yeah, that's also plausible.
[15:49:31] <James_F>	 A grunt-svg-colourfy task that just does s/<base colour>/<new colour>/g could work.
[15:50:19] <James_F>	 Alternatively, we could have in the SVG files multiple definitions of the path, one in each colour, and it'd iterate through and activate only one.
[15:50:27] <MatmaRex>	 ew
[15:50:32] <James_F>	 That way the files define their target colours directly.
[15:50:37] <James_F>	 Rather than a JSON file.
[15:50:40] * James_F shrugs.
[15:50:52] <MatmaRex>	 don't we want to keep the color definitions centralized?
[15:51:21] <James_F>	 There's two sets of definition.
[15:51:45] <James_F>	 The 'progressive' -> '#33dd66' mapping.
[15:52:12] <James_F>	 And the 'accept' -> [ 'progressive', 'destructive', 'neutral'] mapping.
[15:52:29] <James_F>	 The second could be in the files but the first should definitely be centralised.
[15:52:35] <James_F>	 It's a matter of taste.
[15:52:47] <MatmaRex>	 i assumed that we just want to generate all color variants for all icons
[15:53:05] <MatmaRex>	 hmm.
[15:53:06] <James_F>	 Themes will vary the colours.
[15:53:16] <James_F>	 No, we don't want to make most icons available in most colours.
[15:53:33] <James_F>	 E.g. 'delete' shouldn't ever be a progressive action.
[15:53:34] <James_F>	 Etc.
[15:54:27] <James_F>	 Forking directory-colorfy to something sane seems reasonable.
[15:57:43] <MatmaRex>	 hmmmm.
[15:58:04] <MatmaRex>	 at this point, i'm not sure if we actually want to use grunticon itself
[15:58:30] <grrrit-wm>	 (03PS8) 10Jforrester: WIP: Record intention in ve.dm.Transaction object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 (owner: 10Cscott)
[15:59:39] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Per Ed's comment on PS6." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 (owner: 10Cscott)
[16:00:00] <cscott>	 James_F: i've got a much-improved version of that patch, that i'm just working on fixing up the tests for
[16:00:27] <cscott>	 i addressed ed's comments, too.  i assume PS8 is just a rebase?
[16:03:19] <James_F>	 cscott: Yeah.
[16:03:26] <James_F>	 cscott: Sounds good. :-)
[16:03:45] <James_F>	 MatmaRex: Well, the SVG->PNG conversion is useful, but it does create a lot of dross.
[16:04:06] <James_F>	 MatmaRex: Also, spamming the logs with "A grunticon appears!" isn't cute, it's stupid.
[16:04:33] <MatmaRex>	 indeed
[16:04:40] <MatmaRex>	 send a pull request? :P
[16:04:48] <MatmaRex>	 okay, so
[16:05:26] <James_F>	 MatmaRex: If we're forking them (or writing our own from scratch), no real need.
[16:05:40] <James_F>	 MatmaRex: Also, a dist version of the CSS files with the images embedded isn't a stupid idea…
[16:06:51] <MatmaRex>	 okay, but we currently don't need that, and i'd have to figure out how to fit it within the existing system
[16:07:03] <James_F>	 We'd need two dist folders.
[16:07:15] <James_F>	 dist/vanilla and dist/embedded
[16:07:40] <MatmaRex>	 not really. we could ditch vanilla
[16:07:40] <Krinkle>	 RoanKattouw_away: jsduck runs on css because it allows documenting variables, functions and mixins in SASS (and Less too, I suppose, though they optimise for Sass)
[16:08:08] <James_F>	 MatmaRex: We could; is bypassing RL and embedding images considered good?
[16:08:10] <Krinkle>	 RoanKattouw_away: James_F: And yeah, use /* for comments in CSS. /*! is for headers, /** documention blocks, and // or /* is inline comments in js and css respectively.
[16:08:20] <MatmaRex>	 James_F: MW can deal with pre-embedded versions just as well, especially since we don't use the pure-CSS fallbacks
[16:08:24] <James_F>	 Krinkle: It's Trevor who used /**
[16:08:36] <James_F>	 MatmaRex: Kk. Maybe just go with embedded, then?
[16:08:47] <Adityab>	 cscott: Will https://gerrit.wikimedia.org/r/151777  work with your latest togetherjs integration on github?
[16:08:52] <MatmaRex>	 maybe
[16:08:59] <MatmaRex>	 okay, back to grunticon
[16:09:02] <James_F>	 MatmaRex: Oh, but we'd need to preserve /* @noflips */?
[16:09:02] <Adityab>	 cscott: I'm very interested in how you tackle undo with OT
[16:09:29] <MatmaRex>	 we can use it, but we'd need to conform to its conventions – append acceptable color variant names to each file name
[16:09:31] <cscott>	 Adityab: the ve code is already in the togetherjs extension, look for ext.togetherjs.ve.js
[16:09:43] <Adityab>	 ah
[16:09:48] <James_F>	 MatmaRex: Yeah, which… sucks.
[16:09:52] <MatmaRex>	 if that's okay, then it's probably easier to do than reimplementing
[16:09:58] <cscott>	 Adityab: the transaction support in VE is a stack of a number of patches, just implementing the basic operation transpose operation.
[16:09:59] <MatmaRex>	 but yeah, i'm not a huge fan either
[16:10:18] <cscott>	 Adityab: 151777 is a refactoring of a couple of previous approaches.
[16:10:20] <MatmaRex>	 James_F: what about @noflips? MW has no way to flip a embedded data: URI anyway
[16:10:35] <MatmaRex>	 wait, do we depend on MW css flipping?
[16:10:39] <James_F>	 MatmaRex: Ah, really?
[16:10:53] <James_F>	 MatmaRex: No, we use cssjanus in OOUI itself.
[16:11:04] <MatmaRex>	 James_F: MW file flipping is just based on filenames. s/-ltr/-rtl/ and the other way round
[16:11:17] <James_F>	 MatmaRex: But we need to make sure we're not breaking that.
[16:12:25] <Adityab>	 cscott: okay
[16:14:14] <MatmaRex>	 James_F: hmm
[16:14:29] <MatmaRex>	 James_F: we *are* actually relying on MW flipping, as far as i can tell.
[16:14:43] <MatmaRex>	 James_F: we generate RTL CSS files in the build script, but we don't use them
[16:14:56] <James_F>	 MatmaRex: They're used in stand-alone VE.
[16:15:03] <MatmaRex>	 D:
[16:15:20] <James_F>	 MatmaRex: Which is stand-alone, so can't rely on the local environment doing magic things.
[16:15:21] <MatmaRex>	 okay… so we're supporting every possible way
[16:16:35] <MatmaRex>	 so we can't switch from not-embedding to embedding right now
[16:16:56] <James_F>	 Well, we'd just have to embed the right files in the RTL vs. LTR sheets.
[16:17:04] <James_F>	 Fiddly but do-able.
[16:17:21] <MatmaRex>	 let's not do embedding, then; we can consider it when ooui starts being used by anything that isn't MW and VE :)
[16:17:41] <James_F>	 It is used by non-MW stuff already.
[16:17:58] <Krinkle>	 Minifying, embedding and that stuff is something imho best left to the end consumer.
[16:17:59] <MatmaRex>	 i'm not aware of any, enlighten me?
[16:18:24] <James_F>	 MatmaRex: Amongst other things, personal projects of the Editing team. :-)
[16:18:33] <MatmaRex>	 haha
[16:18:44] <MatmaRex>	 i wonder if grunticon even can generate stylesheets that don't embed SVGs
[16:18:58] <James_F>	 Ha.
[16:19:27] <MatmaRex>	 it generates embedded SVG, embedded PNG and fallback PNG, and i don't think that's very configurable
[16:20:05] <MatmaRex>	 so, if we can't do that, and we can't use its colorizing behavior, then it looks like a waste of effort
[16:20:18] <MatmaRex>	 ugh
[16:20:21] <James_F>	 Can we re-use the SVG->PNG conversion?
[16:20:50] <grrrit-wm>	 (03CR) 10Jforrester: "Needs rebase, fixing." [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 (owner: 10Krinkle)
[16:21:00] <MatmaRex>	 we can just use the grunticon's dependency which does that directly: https://www.npmjs.org/package/grunt-svg2png
[16:21:41] <James_F>	 Oh, that's separate? Nice.
[16:21:54] <James_F>	 Yeah, let's do that instead.
[16:21:55] <MatmaRex>	 hmm, that claims to be able to support direcotry structures, too
[16:22:00] <James_F>	 Ha.
[16:22:17] <MatmaRex>	 but i used the exact same syntax in grunticon and it didn't work
[16:22:18] <MatmaRex>	 let's see
[16:22:20] * MatmaRex rewrites
[16:29:41] <MatmaRex>	 huh.
[16:29:45] <MatmaRex>	 this was too easy.
[16:30:21] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on etwiki: https://et.wikipedia.org/?diff=3984381
[16:30:21] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32552212
[16:30:21] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65263691
[16:30:21] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=67967396
[16:34:04] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] WIP: updates for Cite test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158408 
[16:34:58] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Use grunt-svg2png to convert SVG icons to PNG for distribution [oojs/ui] - 10https://gerrit.wikimedia.org/r/158386 
[16:44:54] <James_F>	 MatmaRex: Should we build the SVG files from /dist rather /src ?
[16:45:07] <James_F>	 Err. Build the PNG files from the SVG files in /dist, even.
[16:45:19] <MatmaRex>	 why?
[16:46:01] <MatmaRex>	 we can, but i don't see what difference this makes right now
[16:46:21] <James_F>	 MatmaRex: "src/themes/minerva/images"
[16:46:43] <James_F>	 MatmaRex: Simpler to not have exceptions for what to copy, but instead once that decision's already been made.
[16:47:26] <MatmaRex>	 James_F: there are not SVGs to convert in that directory
[16:47:43] <MatmaRex>	 the only one didn't have a PNG version, and currently renders all broken in the deom
[16:48:03] <James_F>	 MatmaRex: src/themes/minerva/images/icons/check.svg
[16:48:19] <MatmaRex>	 yes.
[16:48:26] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "You need to convert the non-core images from the themes too (src/themes/minerva/images/icons/check.svg etc.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/158386 (owner: 10Bartosz Dziewoński)
[16:48:33] * James_F fiddles.
[16:48:36] <MatmaRex>	 we're also not converting /ui/src/styles/images/anchor.svg to PNG.
[16:48:46] <James_F>	 We aren't?
[16:48:48] <MatmaRex>	 i just preserved that behavior
[16:48:50] <MatmaRex>	 yep
[16:48:56] <James_F>	 That's probably a mistake.
[16:49:50] <MatmaRex>	 hmph.
[16:51:00] <James_F>	 MatmaRex: Also, want to come to the Editing stand-up meeting in 10 minutes?
[16:51:32] <grrrit-wm>	 (03PS3) 10Jforrester: Use grunt-svg2png to convert SVG icons to PNG for distribution [oojs/ui] - 10https://gerrit.wikimedia.org/r/158386 (owner: 10Bartosz Dziewoński)
[16:52:36] <grrrit-wm>	 (03PS2) 10Cmcmahon: [BrowserTest] WIP: updates for Cite test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158408 
[16:53:07] <grrrit-wm>	 (03PS4) 10Jforrester: Use grunt-svg2png to convert SVG icons to PNG for distribution [oojs/ui] - 10https://gerrit.wikimedia.org/r/158386 (owner: 10Bartosz Dziewoński)
[16:53:18] <James_F>	 (Spot the obvious mistake. :-))
[16:53:28] <grrrit-wm>	 (03PS5) 10Bartosz Dziewoński: Use grunt-svg2png to convert SVG icons to PNG for distribution [oojs/ui] - 10https://gerrit.wikimedia.org/r/158386 
[16:53:55] <MatmaRex>	 oh, you were doing this too.
[16:53:56] <James_F>	 Ha. Whoops.
[16:54:11] <James_F>	 We conventionally list the steps in the Gruntfile.js in the order they're executed.
[16:54:13] <MatmaRex>	 well, we arrived at the same result
[16:54:15] <MatmaRex>	 yep
[16:54:16] <MatmaRex>	 fixing
[16:54:17] <James_F>	 Hence https://gerrit.wikimedia.org/r/#/c/158386/4..5/Gruntfile.js
[16:54:21] <James_F>	 Cool.
[16:54:29] <James_F>	 In that case, +2 once you move it.
[16:55:16] <grrrit-wm>	 (03PS6) 10Bartosz Dziewoński: Use grunt-svg2png to convert SVG icons to PNG for distribution [oojs/ui] - 10https://gerrit.wikimedia.org/r/158386 
[16:55:35] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Use grunt-svg2png to convert SVG icons to PNG for distribution [oojs/ui] - 10https://gerrit.wikimedia.org/r/158386 (owner: 10Bartosz Dziewoński)
[16:55:51] <MatmaRex>	 James_F: i can come if you need me
[16:56:40] <James_F>	 MatmaRex: It might be nice…
[16:57:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use grunt-svg2png to convert SVG icons to PNG for distribution [oojs/ui] - 10https://gerrit.wikimedia.org/r/158386 (owner: 10Bartosz Dziewoński)
[17:01:01] <MatmaRex>	 (one minute)
[17:03:46] <grrrit-wm>	 (03PS3) 10Cmcmahon: [BrowserTest] WIP: updates for Cite test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158408 
[17:07:44] <grrrit-wm>	 (03PS4) 10Cmcmahon: [BrowserTest] updates for Cite test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158408 
[17:08:08] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158408 (owner: 10Cmcmahon)
[17:09:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] updates for Cite test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158408 (owner: 10Cmcmahon)
[17:13:57] <wikibugs>	 3VisualEditor / 3Language: VisualEditor:  Cannot type in Korean using Mozilla on Windows 7 with dual-script keyboard - 10https://bugzilla.wikimedia.org/70353#c4 (10WhatamIdoing) Are we sure?  Bug 50631 can get something.  I believe that this user can't get anything.