[08:16:40] Is there a way to specify an option list in TemplateData? I have a template where one parameter could be one of 6~8 values. A selection from a list would eliminate user typing errors when using the template. [08:49:42] 3MediaWiki extensions / 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - 10https://bugzilla.wikimedia.org/35342#c35 (10paladox2015) Hi I have fixed the problem I also removed the shadow from the rest of the svg icons. [13:22:14] 3VisualEditor: VisualEditor/WikiEditor: Consistent terminology - 10https://bugzilla.wikimedia.org/70439 (10Eran Roz) 3NEW p:3Unprio s:3normal a:3None The terminology between WikiEditor (aka "Advanced toolbar") and VisualEditor MUST be consistent so people will not get confused. For example in VisualEd... [13:31:14] 3VisualEditor / 3Editing Tools: VisualEditor: comment feature should be removed by default - 10https://bugzilla.wikimedia.org/70440 (10Eran Roz) 3NEW p:3Unprio s:3major a:3None Comments aren't recommended for new editors (and for 99% of... [16:30:21] Corruption alert: visualeditor-needcheck on sqwiki: https://sq.wikipedia.org/?diff=1457525 [16:30:21] Corruption alert: visualeditor-needcheck on ukwiki: https://uk.wikipedia.org/?diff=14762271 [16:30:21] Corruption alert: visualeditor-needcheck on dewiki: https://de.wikipedia.org/?diff=133744627 [16:30:21] Corruption alert: visualeditor-needcheck on dewiki: https://de.wikipedia.org/?diff=133744746 [16:30:21] Corruption alert: visualeditor-needcheck on dewiki: https://de.wikipedia.org/?diff=133744797 [16:30:22] Corruption alert: visualeditor-needcheck on dewiki: https://de.wikipedia.org/?diff=133744863 [16:30:22] Corruption alert: visualeditor-needcheck on dewiki: https://de.wikipedia.org/?diff=133744928 [17:05:46] (03PS2) 10Mooeypoo: Abort promises before sending new ones in MediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158584 (https://bugzilla.wikimedia.org/67438) [17:08:23] (03PS3) 10Krinkle: Add autovalue to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (owner: 10Mooeypoo) [17:09:31] (03PS4) 10Krinkle: Add autovalue to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (owner: 10Mooeypoo) [17:09:42] 3VisualEditor: VisualEditor: Cutting and pasting a table (to move it to a new place on the same page) causes loss of row height formatting, inability to save - 10https://bugzilla.wikimedia.org/70375#c2 (10WhatamIdoing) The problem appears after the cutting, not after the pasting. Also, it's usually possible... [17:11:37] (03PS5) 10Krinkle: Implement new 'autovalue' parameter property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (owner: 10Mooeypoo) [17:12:51] (03CR) 10Krinkle: [C: 04-1] "I see lots of code that matches surrounding boilerplate, but I still have no idea what this is for. There's no bug report detailing a use " [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (owner: 10Mooeypoo) [17:15:07] Krinkle, I forgot to add the bug # to the commit message, and taking the bug over, but for reference: https://bugzilla.wikimedia.org/show_bug.cgi?id=51428 [17:16:15] 3MediaWiki extensions / 3TemplateData: TempateData: Add an "autofill" attribute for parameters which clients would automatically insert if none specified - 10https://bugzilla.wikimedia.org/51428 (10Moriel Schottlender) a:3Moriel Schottlender [17:47:36] (03PS6) 10Jforrester: Implement new 'autovalue' parameter property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [17:48:00] (03CR) 10Jforrester: "@Krinkle: Search is your friend. :-)" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [17:51:14] James_F: Hm.. I'm slightly confused why this is being implemented now. [17:51:42] Krinkle: For things like {{cn}} and other clean-up templates. [17:51:48] https://bugzilla.wikimedia.org/show_bug.cgi?id=51428#c5 [17:51:51] Krinkle: Or references. [17:51:54] Krinkle: Or other things. [17:52:24] Krinkle: "Generally worked around" isn't true; most templates that want a "today" value have bots that clean up after them on wikis. [17:52:49] Oh, I see you de-prioritised it wrongly. Fixed. [17:52:56] 3MediaWiki extensions / 3TemplateData: TempateData: Add an "autofill" attribute for parameters which clients would automatically insert if none specified - 10https://bugzilla.wikimedia.org/51428 (10James Forrester) p:5Lowest>3Normal [17:53:05] What I mean is, there's a reply from half a year ago, and then a silence, and then it gets implemented with no documentation. [17:53:26] I'm not disagreeing with you haven't said yet. [17:53:39] I didn't see your comment. [17:53:42] But it be helpful for wherever you said that to have it be visible. [17:53:53] Bugmail isn't reliable, as well you know. [17:54:01] I don't read bug mail [17:54:05] Exactly [17:54:06] I review code and look at related bugs [17:54:11] And yet you're complaining that I didn't. :-) [17:54:32] you didn't state anywhere why or how this would be implemented or what it's use or justification would be from product. [17:54:51] I thought I made it pretty clear in the bug. [17:55:08] Comments 0 and 4 in particular. [17:55:09] You mean the reply that says it might be nice but worried about client expecation a year ago? [17:55:20] Not all justification comes from me personally. Other humans have ideas too. [17:55:35] (03CR) 10Catrope: [C: 04-1] Abort promises before sending new ones in MediaSearchWidget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158584 (https://bugzilla.wikimedia.org/67438) (owner: 10Mooeypoo) [17:55:59] I like bug 65550 too, though. [17:56:14] 3MediaWiki extensions / 3TemplateData: TemplateData: Add property to indicate a template must be substituted - 10https://bugzilla.wikimedia.org/65550 (10James Forrester) a:3Moriel Schottlender [17:56:35] James_F: In my reply I deconstruct half the usecaes provided by stating that autofill's imho only and only useful usecase is explicit wikitext provided that clients will substitute. ANything that isn't subtitution of logic elsewhere is pointless and should be a default value instead. [17:58:05] (03CR) 10Mooeypoo: Abort promises before sending new ones in MediaSearchWidget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158584 (https://bugzilla.wikimedia.org/67438) (owner: 10Mooeypoo) [17:58:26] Krinkle: Saying "template authors should do better" on Bugzilla doesn't get things improved, though. [17:58:44] I am not saying that, nor am I opposing the feature. [17:59:02] {{subst:cn-today}} templates are horrible [17:59:12] * James_F nods. [17:59:54] I was documentating that as the current work around besides bots fixing things up (I've seen the -today pattern on quite a few wikis, lots of gadget and power user scripts have toolbar insertion buttons for those, or they put them in CharInsert) [18:00:18] anyway, useful feature, but easily misused so it needs proper documentation. [18:00:40] (03CR) 10Catrope: Abort promises before sending new ones in MediaSearchWidget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158584 (https://bugzilla.wikimedia.org/67438) (owner: 10Mooeypoo) [18:01:13] I agree. [18:02:37] (03CR) 10Krinkle: "Issues atm:" (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [18:03:53] (03CR) 10Catrope: Abort promises before sending new ones in MediaSearchWidget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158584 (https://bugzilla.wikimedia.org/67438) (owner: 10Mooeypoo) [18:03:58] (03CR) 10Krinkle: Implement new 'autovalue' parameter property (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [18:04:16] 3VisualEditor: VisualEditor: Cutting and pasting a table (to move it to a new place on the same page) causes loss of row height formatting, inability to save - 10https://bugzilla.wikimedia.org/70375 (10Ed Sanders) a:3Ed Sanders [18:06:57] 3VisualEditor / 3ContentEditable: VisualEditor: Cutting a table (to move it to a new place on the same page) causes loss of row height formatting, inability to save (editor crash?) - 10https://bugzilla.wikimedia.org/70375 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [18:10:44] for https://gerrit.wikimedia.org/r/#/c/156459/ in the textinputwidget I need to change some LESS so that when the child input element has .oo-ui-pendingElement-pending we apply .oo-ui-texture-pending to it's parent.. [18:20:15] (03CR) 10Alex Monk: "Well in the case of TextInputWidget we want to apply the texture to the parent element of the .oo-ui-pendingElement-pending element... Can" [oojs/ui] - 10https://gerrit.wikimedia.org/r/156459 (owner: 10Alex Monk) [18:20:17] mooeypoo: I replied to your comment at https://gerrit.wikimedia.org/r/#/c/158584/2/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js [18:35:12] 3VisualEditor / 3ContentEditable: VisualEditor: Cutting a table (to move it to a new place on the same page) causes loss of row height formatting, inability to save (editor crash?) - 10https://bugzilla.wikimedia.org/70375#c3 (10Ed Sanders) Minimal failure case in core to trigger the unbalanced delete which i... [18:35:27] 3VisualEditor / 3ContentEditable: VisualEditor: Deleting from an empty paragraph to the end of an inline node throws an exception - 10https://bugzilla.wikimedia.org/70375 (10Ed Sanders) [18:52:26] MatmaRex: Could you review https://gerrit.wikimedia.org/r/158659 for me? [18:53:15] RoanKattouw: was looking at it, looks good [18:53:28] i was going to nitpick the commit message :> [18:53:33] Go for it :) [18:53:59] Once merged I'd like to put it in Monday's SWAT, because https://gerrit.wikimedia.org/r/#/c/157278/ caused a regression where the top half of the save button is now unclickable again [18:54:59] (03PS1) 10Esanders: WIP Failing test case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158662 (https://bugzilla.wikimedia.org/70375) [18:55:15] 3VisualEditor / 3Editing Tools: VisualEditor:Adding a text as an image caption duplicates the text in the field with a following pawn - 10https://bugzilla.wikimedia.org/70450 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16386 --> https://bugzilla.wikimedia.org/attachment.... [18:55:30] done [18:55:43] 3VisualEditor / 3Editing Tools: VisualEditor:Adding a text as an image caption duplicates the text in the field with a following pawn - 10https://bugzilla.wikimedia.org/70450 (10Rummana Yasmeen) 5NEW>3ASSI p:5Unprio>3High a:3Moriel Schottlender [18:57:30] (03CR) 10jenkins-bot: [V: 04-1] WIP Failing test case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158662 (https://bugzilla.wikimedia.org/70375) (owner: 10Esanders) [18:57:42] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] Adding a text as an image caption duplicates the text in the field with a following pawn - 10https://bugzilla.wikimedia.org/70450 (10Rummana Yasmeen) [19:03:14] 3VisualEditor / 3Editing Tools: VisualEditor: Style texts when selected with Language inspector open, turns the drop-down selection blank. - 10https://bugzilla.wikimedia.org/70451 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16387 --> https://bugzilla.wikimedia.org/attachment... [19:03:57] 3VisualEditor / 3Editing Tools: VisualEditor: Style texts when selected with Language inspector open, turns the drop-down selection blank. - 10https://bugzilla.wikimedia.org/70451#c1 (10Ritu Swain) Created attachment 16388 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16388&action=edit screenshot2 [19:04:26] 3VisualEditor / 3Editing Tools: VisualEditor: Style texts when selected with Language inspector open, turns the drop-down selection blank. - 10https://bugzilla.wikimedia.org/70451#c2 (10Ritu Swain) Environment-test2 [19:10:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] Adding a text as an image caption duplicates the text in the field with a following pawn - 10https://bugzilla.wikimedia.org/70450 (10Rummana Yasmeen) [19:10:27] 3VisualEditor / 3Editing Tools: VisualEditor: Style texts when selected with Language inspector open, turns the drop-down selection blank. - 10https://bugzilla.wikimedia.org/70451#c3 (10Ritu Swain) After deleting the text and pawn characters as mentioned in the steps above when i repeat the steps #1 and #2,... [19:13:08] (03PS1) 10Catrope: Make CSS transplantation work in IE10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/158666 [19:13:10] (03PS1) 10Catrope: Make the background reset for dialogs in Apex work in IE10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/158667 [19:13:56] 3VisualEditor / 3Editing Tools: VisualEditor [Regression wmf20] Template dialog no longer displays added template fields' names - 10https://bugzilla.wikimedia.org/70406#c9 (10Rummana Yasmeen) Yes, working properly in Betalabs and test2 [19:35:27] (03PS3) 10Esanders: Split getSelectionRect into bounding and inline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158523 [19:38:42] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000#c13 (10Rummana Yasmeen) Verified the fix in Betalabs [19:43:21] Thanks MatmaRex [19:45:57] (03CR) 10Trevor Parscal: [C: 04-1] Make the background reset for dialogs in Apex work in IE10 (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/158667 (owner: 10Catrope) [19:50:27] (03PS2) 10Catrope: Make the background reset for dialogs in Apex work in IE10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/158667 [19:50:29] (03PS2) 10Catrope: Make CSS transplantation work in IE10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/158666 [19:52:44] 3VisualEditor / 3Editing Tools: VisualEditor: TypeError: boundingRect is undefined and TypeError: surfaceRect is undefined appears when opening Media Settings dialog - 10https://bugzilla.wikimedia.org/70455 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16389 --> https://bu... [19:53:44] (03PS3) 10Catrope: Make the background reset for dialogs in Apex work in IE10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/158667 [19:54:12] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21]TypeError: boundingRect is undefined and TypeError: surfaceRect is undefined appears when opening Media Settings dialog - 10https://bugzilla.wikimedia.org/70455 (10Rummana Yasmeen) [19:54:58] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21]TypeError: boundingRect is undefined and TypeError: surfaceRect is undefined appears when opening Media Settings dialog - 10https://bugzilla.wikimedia.org/70455 (10Rummana Yasmeen) 5NEW>3ASSI a:3Roan Kattouw [20:11:12] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843 (10Rummana Yasmeen) 5REOP>3ASSI [21:21:36] (03PS1) 10Catrope: Update VE core submodule to master (50be82b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158780 [21:21:47] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (50be82b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158780 (owner: 10Catrope) [21:22:34] (03CR) 10Jforrester: [C: 032] Make the background reset for dialogs in Apex work in IE10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/158667 (owner: 10Catrope) [21:22:48] (03CR) 10Jforrester: [C: 032] Make CSS transplantation work in IE10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/158666 (owner: 10Catrope) [21:23:45] (03Merged) 10jenkins-bot: Update VE core submodule to master (50be82b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158780 (owner: 10Catrope) [21:23:57] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21]TypeError: boundingRect is undefined and TypeError: surfaceRect is undefined appears when opening Media Settings dialog - 10https://bugzilla.wikimedia.org/70455#c1 (10Roan Kattouw) 5ASSI>3RESO/FIX This was fixed by https://gerrit.wikimed... [21:24:34] (03Merged) 10jenkins-bot: Make CSS transplantation work in IE10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/158666 (owner: 10Catrope) [21:24:36] (03Merged) 10jenkins-bot: Make the background reset for dialogs in Apex work in IE10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/158667 (owner: 10Catrope) [21:24:42] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21]TypeError: boundingRect is undefined and TypeError: surfaceRect is undefined appears when opening Media Settings dialog - 10https://bugzilla.wikimedia.org/70455 (10James Forrester) 5RESO/FIX>3RESO/INV [21:25:57] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (8ad150e4e7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158783 [21:27:43] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (8ad150e4e7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158783 (owner: 10Jforrester) [21:29:47] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (8ad150e4e7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158783 (owner: 10Jforrester) [21:31:29] RoanKattouw: https://gerrit.wikimedia.org/r/158789 is the same for MW-core. [21:33:06] (03CR) 10Catrope: Update OOjs UI to v0.1.0-pre (8ad150e4e7) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158783 (owner: 10Jforrester) [21:38:42] 3VisualEditor / 3MediaWiki integration: VisualEditor: If 'summary' parameter is provided in URL, it should be the default edit summary - 10https://bugzilla.wikimedia.org/69501#c5 (10Alex Monk) I went back and fixed up that gadget so it should handle VE links correctly. This change to pick up 'summary' from... [21:49:00] TrevorParscal, around? [21:51:22] (03PS1) 10Catrope: Followup cb86c4f: fix call to renamed setChanged() function [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158797 (https://bugzilla.wikimedia.org/70450) [21:59:28] mooeypoo: ---^^ [22:02:00] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is not opening up on the first attempt of an edit session when clicked the icon from the toolbar - 10https://bugzilla.wikimedia.org/70467 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Clic... [22:04:27] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is taking a long time on opening up on the first attempt of an edit session - 10https://bugzilla.wikimedia.org/70467#c1 (10Rummana Yasmeen) It also happens when you try to inspect an existing link [22:19:51] RoanKattouw, wow, oops [22:20:47] (03CR) 10Mooeypoo: [C: 032] "Whoops, good catch." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158797 (https://bugzilla.wikimedia.org/70450) (owner: 10Catrope) [22:21:01] RoanKattouw, how did this not completely crash the dialog? [22:22:54] (03Merged) 10jenkins-bot: Followup cb86c4f: fix call to renamed setChanged() function [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158797 (https://bugzilla.wikimedia.org/70450) (owner: 10Catrope) [22:26:49] mooeypoo: It kind of did [22:27:04] Well, probably because it happened in response to an event [22:27:11] That's a separate execution contect [22:27:12] *context [22:27:16] Is that the duplicate-caption bug? I'd have expected it to have completely crashed with unidentified method [22:27:19] It did crash DM's ability to deal with the key press, hence the pawn [22:27:28] It did crash with that error [22:27:45] But there also happened to be a pawn visible at the time of the crash, so the pawn never got removed, so it got reported as a pawn bug [22:27:48] mh... I tested a couple of images. Weird. [22:28:23] Oh it only happens when you type I think [22:28:25] hm. Is there a way to test UI stuff in VE? [22:28:30] oh [22:28:34] You mean unit tests? [22:28:39] oh that makes sense, the method checks if the cpation changed. Ha. [22:28:42] yeah [22:28:53] We should have unit tests for certain things I think, like the window system [22:29:07] But for user-facing UI code like MWMediaDialog, we should probably have browser tests instead of unit tests [22:29:09] We only do unit tests to DM and CE stuff I think [22:29:47] Even just a basic load->change all attributes->apply->check output thing [22:29:54] ah, yeah, I guess browser test is the way to go [22:36:30] Things like MWImageModel could probably benefit from unit tests though [22:36:41] At least of the load -> change -> apply -> verify kind [22:38:34] yeah that's what I am thinking [22:38:38] but I'm not sure how to do that [22:38:56] the unit tests aren't supposed to load the dialog [22:39:13] the only UI unit tests I see are for actions [22:39:28] and those are more abstract, they don't quite load a full window with widgets and all [22:39:30] Well I said MWImageModel [22:39:33] Which doesn't need a dialog [22:39:34] oh the model [22:39:36] the model has that [22:39:38] Yeah [22:39:49] the model has tests, but in this case, the error was in the dialog [22:39:53] Loading dialogs or windows in unit tests is evil, it's an excellent indication that what you want is a browser test [22:40:01] I should improve the tests, though. [22:40:22] hmm, yeah. [22:40:26] (03PS1) 10Catrope: Followup 67f83f1: fall back to empty string to avoid 'undefined' [oojs/ui] - 10https://gerrit.wikimedia.org/r/158807 (https://bugzilla.wikimedia.org/70467) [22:40:48] I'm also thinking about tweaking the search widget inside OOUI [22:41:26] something like "no results found" should be in the widget, not appended from outside it, I think. It should have some method to call it to be visible from the original widget, then the ve widget calls it on when promises are done [22:42:53] Right [22:43:09] Yeah that sounds sensible [22:43:21] Actually you could just use PendingElement (Alex's future mixin) for that [22:43:33] Make the results widget pending while the requests go, then make it not pending [22:43:44] Then if the widget becomes not pending and has zero results in it, it shows the message [22:44:06] it already has that for the input I think [22:44:23] and yes, that's what I do now in the VE widget [22:44:30] it should probably move to the ooui logic [22:44:34] some of it, at least [22:45:01] (03PS11) 10Bartosz Dziewoński: Make it possible to create autonumbered external links from link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) [22:45:12] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Right, let's do this properly." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) (owner: 10Bartosz Dziewoński) [22:51:48] (03CR) 10Mooeypoo: Abort promises before sending new ones in MediaSearchWidget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158584 (https://bugzilla.wikimedia.org/67438) (owner: 10Mooeypoo) [22:51:53] (03PS3) 10Mooeypoo: Abort promises before sending new ones in MediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158584 (https://bugzilla.wikimedia.org/67438) [22:54:43] (03CR) 10Catrope: [C: 032] Abort promises before sending new ones in MediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158584 (https://bugzilla.wikimedia.org/67438) (owner: 10Mooeypoo) [22:56:20] (03Merged) 10jenkins-bot: Abort promises before sending new ones in MediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158584 (https://bugzilla.wikimedia.org/67438) (owner: 10Mooeypoo) [22:58:06] (03PS4) 10Krinkle: Emit an error if VE Target fails to load, so users aren't left entirely stranded [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155177 (owner: 10Jforrester) [22:58:54] (03CR) 10Krinkle: [C: 04-1] "I don't think the Error constructor takes a second parameter." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155177 (owner: 10Jforrester) [22:59:11] 3VisualEditor / 3Initialisation: VisualEditor: Broken appearance when window is too small in Internet Explorer - 10https://bugzilla.wikimedia.org/63778#c2 (10Roan Kattouw) 5ASSI>3RESO/WOR This doesn't happen for me in IE10. The cursor does go under the toolbar, but that is a general issue (there's a lot... [23:00:15] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion editor broken in IE10 (stack overflow) - 10https://bugzilla.wikimedia.org/50044#c1 (10Roan Kattouw) 5ASSI>3RESO/FIX This doesn't happen in IE10 with master. [23:01:08] (03PS12) 10Bartosz Dziewoński: Make it possible to create autonumbered external links from link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) [23:02:11] (03PS1) 10Bartosz Dziewoński: ve.ui.AnnotationInspector: Explicitly permit inserting non-text data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158811 [23:02:43] MatmaRex: so, icons [23:02:45] (03CR) 10jenkins-bot: [V: 04-1] Make it possible to create autonumbered external links from link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) (owner: 10Bartosz Dziewoński) [23:02:51] (03CR) 10Bartosz Dziewoński: "All done, with new core dependency in I40cd4d5a." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) (owner: 10Bartosz Dziewoński) [23:03:23] TrevorParscal: right? [23:03:41] (03CR) 10Catrope: [C: 032] ve.ui.AnnotationInspector: Explicitly permit inserting non-text data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158811 (owner: 10Bartosz Dziewoński) [23:04:13] I'm introducing OO.ui.Theme [23:04:28] which will be instantiated as OO.ui.theme on load [23:04:36] RoanKattouw: woah, i did not test that, y'know. [23:04:51] and widgets/layouts/dialogs/etc. will have access to it for various theme-specific functionality [23:04:59] the base implementation will work fine [23:05:08] so, you can subclass and do nothing and be good [23:05:40] in MediaWiki we will override getButtonElementClasses, which produces a list of classes to be set on a button in it's current state [23:05:41] MatmaRex: lol, sorry. I'll test it in a minute [23:06:04] and ButtonElement will use that to toggle additional classes whenever the state changes [23:06:18] (03Merged) 10jenkins-bot: ve.ui.AnnotationInspector: Explicitly permit inserting non-text data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158811 (owner: 10Bartosz Dziewoński) [23:06:33] this will allow us to define the icons in a very simple way [23:07:06] sounds neat [23:07:42] 3VisualEditor / 3MediaWiki integration: VisualEditor: IE9/10 incompatibilities with saving process - 10https://bugzilla.wikimedia.org/49187#c9 (10Roan Kattouw) This is working for me now: I saved https://www.mediawiki.org/w/index.php?title=User:Catrope%2FSandbox&diff=1137641&oldid=740030 in IE10. [23:07:43] such as .oo-ui-flaggedElement-destructive .oo-ui-icon-trash, oo-ui-icon-trash-destructive { background-image: url(trash-destructive.svg) } [23:07:52] or, something like that [23:08:11] 3VisualEditor / 3ContentEditable: VisualEditor: Right-click in IE10 causes deletion of the selected content - 10https://bugzilla.wikimedia.org/50045#c4 (10Roan Kattouw) I can't reproduce this in IE10. [23:08:13] so, let me work this out a bit more, and then we can proceed further on the icon CSS generation [23:08:32] TrevorParscal: No I thought we'd said we'd do .oo-ui-icon-trash.oo-ui-destructive instead or something [23:08:42] Rather than have one class name per icon per state [23:08:46] yeah, that's fine [23:08:56] I'm just saying we will do it with classes and keep it simple [23:09:00] Because that makes implementing your variant system much easier [23:09:02] OK yeah cool [23:09:15] i'm just doing a bad job at making examples [23:10:19] TrevorParscal: alright. so, nothing for me to do with this right now? [23:12:07] not at this precise moment [23:12:08] sorry [23:12:57] TrevorParscal: https://gerrit.wikimedia.org/r/158807 [23:12:59] I will very soon [23:13:08] hopefully [23:14:01] (03CR) 10Trevor Parscal: [C: 032] Followup 67f83f1: fall back to empty string to avoid 'undefined' [oojs/ui] - 10https://gerrit.wikimedia.org/r/158807 (https://bugzilla.wikimedia.org/70467) (owner: 10Catrope) [23:15:06] (03Merged) 10jenkins-bot: Followup 67f83f1: fall back to empty string to avoid 'undefined' [oojs/ui] - 10https://gerrit.wikimedia.org/r/158807 (https://bugzilla.wikimedia.org/70467) (owner: 10Catrope) [23:17:12] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21]TypeError: boundingRect is undefined and TypeError: surfaceRect is undefined appears when opening Media Settings dialog - 10https://bugzilla.wikimedia.org/70455#c2 (10Rummana Yasmeen) Yes, working fine now [23:30:13] 3VisualEditor / 3ContentEditable: VisualEditor: Right-click in IE10 causes deletion of the selected content - 10https://bugzilla.wikimedia.org/50045#c5 (10James Forrester) 5ASSI>3RESO/WOR Totally conceivable that we fixed this in the past 15 months with the thousands of other changes (3683 since this poi... [23:34:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: IE9/10 incompatibilities with saving process - 10https://bugzilla.wikimedia.org/49187 (10James Forrester) 5ASSI>3RESO/FIX [23:36:45] Krinkle: Re. 155177, other than that, is it OK? RoanKattouw wanted your thoughts… [23:38:49] James_F: Not sure.. Uncaught exceptions aren't pretty. They through alerts in IE for one. [23:38:54] throw [23:39:10] Maybe we can ve.log it? [23:39:54] ve.error, even. [23:40:19] meh, too early on, no ve.js [23:40:24] mw.log.warn is perfect [23:40:35] doesn't depend on debug mode either [23:41:00] Krinkle: This is a "your sysadmin didn't set the system up right". [23:41:11] Krinkle: Throwing alerts in IE is acceptable. [23:41:16] and since it's an async callback, the exception doesn't realy abort from anything [23:41:18] Krinkle: I /almost/ threw Alert manually. [23:41:36] Krinkle: This is mostly for people who checkout out VE-MW but not the submodule. [23:41:41] so a log warning is functionally equiv [23:42:11] even has a trace [23:42:31] But yes, it's fine. I'll let you / RoanKattouw pick between throw and mw.log.war [23:42:34] o/ [23:42:47] mw.log.warning WFM. [23:42:50] * James_F fixes for you. [23:44:24] (03PS5) 10Jforrester: Log an error if VE Target fails to load, so users aren't left entirely stranded [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155177 [23:44:42] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438 (10Rummana Yasmeen) 5PATC>3RESO/FIX [23:45:49] (03CR) 10Krinkle: "Uncaught exceptions aren't pretty. Since these are from an async call stack, it doesn't abort any logic or code execution, so using a logg" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155177 (owner: 10Jforrester) [23:46:27] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438#c18 (10Rummana Yasmeen) Verified the fix in Betalabs [23:49:07] (03PS13) 10Jforrester: Make it possible to create autonumbered external links from link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) (owner: 10Bartosz Dziewoński) [23:49:09] (03PS1) 10Jforrester: Update VE core submodule to master (bc9ae1f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/158823 [23:49:43] 3VisualEditor / 3Editing Tools: VisualEditor: Icons render weirdly in IE10 - 10https://bugzilla.wikimedia.org/63749#c1 (10Roan Kattouw) 5ASSI>3RESO/WOR Works fine for me in IE10. [23:50:27] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] Adding a text as an image caption duplicates the text in the field with a following pawn - 10https://bugzilla.wikimedia.org/70450 (10James Forrester) 5PATC>3RESO/FIX [23:50:57] 3VisualEditor / 3Editing Tools: VisualEditor: Icons render weirdly in IE10 - 10https://bugzilla.wikimedia.org/63749#c2 (10Roan Kattouw) I have, however, seen a number of interesting rendering problems in IE11. It seems like their hardware acceleration sometimes chokes on gradients or transitions or whatever... [23:51:12] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] Adding a text as an image caption duplicates the text in the field with a following pawn - 10https://bugzilla.wikimedia.org/70450#c3 (10Rummana Yasmeen) Verified the fix in Betalabs [23:52:27] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] Link inspector is taking a long time on opening up on the first attempt of an edit session - 10https://bugzilla.wikimedia.org/70467 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal [23:53:27] 3VisualEditor / 3ContentEditable: VisualEditor: IE9 skips header line in table - 10https://bugzilla.wikimedia.org/63046#c1 (10Roan Kattouw) 5ASSI>3RESO/WOR This is working as expected now. Pressing down once puts the cursor at the beginning of "Header" on my Windows 7 machine in IE10. [23:53:41] 3VisualEditor / 3Editing Tools: VisualEditor: Undoing the edit from toolbar does not disable the "Apply Changes" button inside Media Settings dialog - 10https://bugzilla.wikimedia.org/68058#c5 (10Rummana Yasmeen) Verified the fix in Betalabs [23:55:28] 3VisualEditor / 3ContentEditable: VisualEditor: IE9 skips header line in table - 10https://bugzilla.wikimedia.org/63046#c2 (10Roan Kattouw) 5RESO/WOR>3REOP (In reply to Roan Kattouw from comment #1) > This is working as expected now. Pressing down once puts the cursor at the > beginning of "Header" on my... [23:56:43] 3VisualEditor / 3Initialisation: VisualEditor: Console shows "Permission denied" on IE9 when VE is first initiated - 10https://bugzilla.wikimedia.org/63039#c6 (10Roan Kattouw) For the record, I haven't experienced this problem in weeks of messing around with VE in IE in either IE10 or IE11. [23:56:57] 3VisualEditor / 3ContentEditable: VisualEditor: IE9 skips header line in table - 10https://bugzilla.wikimedia.org/63046 (10James Forrester) 5REOP>3ASSI [23:57:12] 3VisualEditor / 3ContentEditable: VisualEditor: Can't create new paragraph by hitting return in IE - 10https://bugzilla.wikimedia.org/63038#c3 (10Roan Kattouw) Works in IE10 too. Which version of IE did you observe this in? [23:57:27] RoanKattouw: https://bugzilla.wikimedia.org/show_bug.cgi?id=41233 and https://bugzilla.wikimedia.org/show_bug.cgi?id=50088