[01:44:26] 3VisualEditor: period ends up inside wiki link - 10https://bugzilla.wikimedia.org/70542 (10Aude) 3NEW p:3Unprio s:3normal a:3None I was cutting & pasting sentences and it worked nearly flawlessly, including the references! :) Though, somehow during cut & paste of a reference to the end of a sentence,... [01:50:39] 3VisualEditor: cmd+x takes me to top of the page - 10https://bugzilla.wikimedia.org/70543 (10Aude) 3NEW p:3Unprio s:3normal a:3None (on osx) I click edit[beta] on a section of a page. I am trying to cut & paste a reference. I highlight the reference [58] with click on the page + shift and arrow left t... [01:51:23] 3VisualEditor: period ends up inside wiki link - 10https://bugzilla.wikimedia.org/70542#c1 (10Aude) it's possible there is some user error involved, although see if this can be reproduced... [02:11:45] (03PS1) 10Alex Monk: Look through document to find all references/reference lists to get groups from in the input widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159006 (https://bugzilla.wikimedia.org/70365) [03:53:03] (03CR) 10Alex Monk: Automatically align popup toolgroups (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/157295 (owner: 10Trevor Parscal) [03:53:09] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf20] The notification dialog is appearing little bigger in test2 and there is a big empty space in it - 10https://bugzilla.wikimedia.org/70423#c2 (10Alex Monk) a:3Alex Monk Seems to have been caused by Gerrit change 157295 In particular,... [04:22:55] 3VisualEditor / 3Editing Tools: VisualEditor: Insert > References list is very large in Firefox - 10https://bugzilla.wikimedia.org/70545 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None This may be the opposite of bug 68226: The References List dialog in Firefox 31 on my Mac is the expected width... [05:56:25] 3VisualEditor: VisualEditor: Please add a 'close' box to the wikitext warning - 10https://bugzilla.wikimedia.org/70548 (10WhatamIdoing) 3NEW p:3Unprio s:3enhanc a:3None It's not obvious to everyone that you can click the wikitext warning to make it go away. Please add an 'X' or something that makes i... [06:57:24] (03PS1) 10Legoktm: Make message loading for 'ext.visualEditor.viewPageTarget.init' module less hacky [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159021 [06:59:06] (03CR) 10jenkins-bot: [V: 04-1] Make message loading for 'ext.visualEditor.viewPageTarget.init' module less hacky [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159021 (owner: 10Legoktm) [06:59:33] (03PS2) 10Legoktm: Make message loading for 'ext.visualEditor.viewPageTarget.init' module less hacky [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159021 [07:01:34] (03CR) 10Legoktm: "I haven't tested this." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159021 (owner: 10Legoktm) [09:24:08] 3VisualEditor / 3Editing Tools: VisualEditor: Consider whether exiting the link dialog in create mode should remove the link - 10https://bugzilla.wikimedia.org/69407#c2 (10Liam Wyatt) Unfortunately I agree with BOTH of you. I am often confused by the behaviour of the link dialogue and am often looking for t... [09:56:39] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn ♙ appears after deleting the text preceding and following a link by "undo" action - 10https://bugzilla.wikimedia.org/61521#c3 (10Elitre) 5RESO/FIX>3REOP I might be reopening the wrong bug, but this doesn't seem to be fixed. 1) VEdit any article on the... [13:15:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: Caret looks disconnected from link box in Monobook skin when going to first letter of line - 10https://bugzilla.wikimedia.org/69242#c8 (10Ritu Swain) Issue not fixed on test2. [14:55:55] 3VisualEditor / 3Editing Tools: VisualEditor: Sub-heading 4 font, does not match with the other heading style fonts, in Monobook - 10https://bugzilla.wikimedia.org/70559 (10Ritu Swain) 3UNCO p:3Unprio s:3trivia a:3None Created attachment 16403 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16... [14:56:22] 3VisualEditor / 3Editing Tools: VisualEditor: Sub-heading 4 font, does not match with the other heading style fonts, in Monobook - 10https://bugzilla.wikimedia.org/70559 (10Ritu Swain) [15:11:42] (03PS1) 10Alex Monk: PopupWidget: Toggle clipping -after- updating dimensions [oojs/ui] - 10https://gerrit.wikimedia.org/r/159062 (https://bugzilla.wikimedia.org/70423) [15:21:37] 3MediaWiki / 3ResourceLoader: [Regression] Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c23 (10Andre Klapper) Krinkle: So is there some conclusion what should be done here, and by who? [15:23:38] hi [15:23:48] hi [15:25:05] I have a silly question, since I dealt with this stuff too long ago [15:25:58] If I need to add templatedata to a template, can I just create a subpage for it, or do I need the code to be transcluded on the template page as well? [15:26:17] must be transcluded in [15:26:36] otherwise TemplateData would have to search all subpages for it [15:28:25] ok. thank you. [15:29:09] Which could all be templates of their own [15:30:26] 3MediaWiki / 3ResourceLoader: [Regression] Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c24 (10Krinkle) 5NEW>3ASSI a:3Krinkle I've proposed various solutions. None of which are field-tested, best practice and known to work cross-browser... [15:30:52] is there any way to "hide" the table generated by TD, so that it still works but the reader does not see it? [15:36:58] Elitre: If you wrap it in a that works. [15:37:30] Elitre: Readers of Template:Foo will still see it, but not readers of pages with {{Foo}} transclusions. [15:39:52] that's the thing, it wouldn't solve the issue. thanks though. [15:42:29] no idea if I was thrown out or what :) [15:42:41] you left [15:49:05] and I only noticed because I was already missing you. [15:54:36] Elitre: What wouldn't solve the issue? [15:55:05] James_F: having templatedata in plain sight on the Template page. [15:55:17] Elitre: Rather than on the /doc page? [15:55:21] (that's the issue) [15:55:24] Hmm. [15:56:14] James_F: obviously not my issue. you can see our agenda if you wanna dig further :) [15:56:25] Elitre: I'm fine. :-) [15:57:47] you'll need to do that anyway :p [15:58:36] Elitre: I'm not coming to the meeting tomorrow, if that's what you mean. [16:00:57] (03PS1) 10Jforrester: build: Use csscomb to prettify the CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/159076 [16:01:29] it's ok. I can still send emails, or on-wiki pings, or... [16:01:37] Krinkle: csscomb done in https://gerrit.wikimedia.org/r/159076 (though it's not working fully, and its syntax is a pain…) [16:04:40] 3VisualEditor / 3Editing Tools: VisualEditor: Link icon stays selected but is not inserted, with language style text. - 10https://bugzilla.wikimedia.org/70562 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Created attachment 16404 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16404&action=e... [16:04:52] 3VisualEditor / 3Editing Tools: VisualEditor: Link icon stays selected but is not inserted, with language style text. - 10https://bugzilla.wikimedia.org/70562 (10Ritu Swain) [16:30:33] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32587348 [16:30:33] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65370095 [17:26:21] (03CR) 10Esanders: "I went with window because that's where the documentation had it listed, so assumed that was the 'correct' place to call it from. Don't mi" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158893 (owner: 10Esanders) [17:27:40] 3VisualEditor / 3MediaWiki integration: VisualEditor only uses half the space available for the copyright notice and displays a scroll bar - 10https://bugzilla.wikimedia.org/70565 (10Helder) 3NEW p:3Unprio s:3normal a:3None Created attachment 16405 --> https://bugzilla.wikimedia.org/attachment.cgi?... [17:39:54] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf20] Edit notice displays at half-width - 10https://bugzilla.wikimedia.org/70565#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High Probably related to similar link inspector behaviour? [17:39:54] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] Link inspector is taking a long time on opening up on the first attempt of an edit session - 10https://bugzilla.wikimedia.org/70467#c4 (10Rummana Yasmeen) a:3Roan Kattouw Verified the fix in Betalabs [17:41:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf20] Edit notice displays at half-width - 10https://bugzilla.wikimedia.org/70565#c2 (10Alex Monk) Isn't this bug 70423? [17:43:08] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf20] Edit notice displays at half-width - 10https://bugzilla.wikimedia.org/70565#c3 (10James Forrester) 5ASSI>3RESO/DUP Yes. *** This bug has been marked as a duplicate of bug 70423 *** [17:43:08] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf20] The notification dialog is appearing little bigger in test2 and there is a big empty space in it - 10https://bugzilla.wikimedia.org/70423#c4 (10James Forrester) *** Bug 70565 has been marked as a duplicate of this bug. *** [17:43:53] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf20] The notification dialog is appearing little bigger in test2 and there is a big empty space in it - 10https://bugzilla.wikimedia.org/70423 (10James Forrester) p:5Low>3High [17:45:54] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] Adding a text as an image caption duplicates the text in the field with a following pawn - 10https://bugzilla.wikimedia.org/70450 (10Rummana Yasmeen) a:5Moriel Schottlender>3Roan Kattouw [17:49:23] 3VisualEditor / 3Editing Tools: VisualEditor: comment feature should be removed by default - 10https://bugzilla.wikimedia.org/70440#c1 (10James Forrester) 5NEW>3RESO/WON (In reply to Eran Roz from comment #0) > > > Comments aren't recommend... [17:52:07] (03PS1) 10Jforrester: Update VE core submodule to master (8f66045) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159093 [17:52:27] James_F, so https://gerrit.wikimedia.org/r/#/c/139550/ probably broke the frame thing on FieldLayout help buttons [17:53:00] renamed config.frameless to config.framed (and obviously reversed it) [17:53:22] but https://gerrit.wikimedia.org/r/#/c/142468/ still used frameless, which worked when I uploaded the change but not when it was merged [17:53:37] Krenair: Ah, right. [17:53:43] Krenair: Simple fix, then? [17:53:53] should be. checking [17:56:54] (03PS1) 10Alex Monk: Make help button for FieldLayout frameless again [oojs/ui] - 10https://gerrit.wikimedia.org/r/159095 (https://bugzilla.wikimedia.org/51798) [17:56:57] looks like it, uploaded fix. [17:57:02] going to have dinner now, back later [17:57:46] Nice. [17:58:15] (03CR) 10Jforrester: [C: 032] Make help button for FieldLayout frameless again [oojs/ui] - 10https://gerrit.wikimedia.org/r/159095 (https://bugzilla.wikimedia.org/51798) (owner: 10Alex Monk) [17:59:11] (03Merged) 10jenkins-bot: Make help button for FieldLayout frameless again [oojs/ui] - 10https://gerrit.wikimedia.org/r/159095 (https://bugzilla.wikimedia.org/51798) (owner: 10Alex Monk) [18:01:38] James_F: hm, https://bugzilla.wikimedia.org/show_bug.cgi?id=70440 seems to be only about the toolbar button, not about comments in general [18:02:06] James_F: that is, it's a request to display comments, but not provide a tool to insert them [18:02:14] MatmaRex: That just removes the ability to add them from people who don't know how to copy-and-paste… [18:02:35] true, but your comment doesn't acknowledge that [18:02:54] (03CR) 10Krinkle: "Yeah, either is fine. Looking at the spec, neither is deprecated or for backwards compatibility. Historically it was on Document with brow" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158893 (owner: 10Esanders) [18:03:16] (and i'm not sure if it's a bad idea, really. the toolbar is too crowded, and inserting comments is generally not very useful) [18:03:34] (unlike reading them, which generally *is* useful) [18:07:01] (03CR) 10Krinkle: "It was never specified in a Candidate Recommendation version. It used to be in an early HTML5 draft and got kicked out into its own spec w" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158893 (owner: 10Esanders) [18:08:52] MatmaRex: We're waiting for a spare moment to code up collapsible menus which only show the first few items by default. [18:09:00] MatmaRex: I should make a bug for that. :-) [18:13:10] 3OOjs UI: OOjs UI: Toolbar menus should be collapsible - 10https://bugzilla.wikimedia.org/70568 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3None It should be possible to have a "…" button at the bottom of a menu that expands it from an initial state showing only a few entries to showing the rest o... [18:13:12] MatmaRex: https://bugzilla.wikimedia.org/show_bug.cgi?id=70568 [18:13:23] 3OOjs UI: OOjs UI: Toolbar menus should be collapsible - 10https://bugzilla.wikimedia.org/70568 (10James Forrester) p:5Unprio>3High [18:13:51] James_F: have we already considered a global "enable advanced options" checkbox? [18:16:25] 3VisualEditor / 3Editing Tools: VisualEditor: When CE gets re-enabled, the cursor always jumps to the beginning index of the first line irrespective of where user wanted to position it - 10https://bugzilla.wikimedia.org/70569 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce:... [18:20:59] James_F, okay so the missing messages were because you tried to use these keys: [18:21:04] visualeditor-dialiog-meta-settings-toc-help [18:21:08] visualeditor-dialiog-meta-settings-redirect-help [18:21:13] visualeditor-dialiog-meta-settings-redirect-statichelp [18:21:21] visualeditor-dialiog-meta-settings-nogallery-help [18:23:36] (03PS1) 10Alex Monk: Provide contextual help for the page settings dialog's controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159104 (https://bugzilla.wikimedia.org/51798) [18:24:04] Krenair: Yeah, there was a typo in my search & replace which I thought I'd fixed. Oh well. [18:24:38] (03CR) 10Alex Monk: "Differences from I5c24d7f4:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159104 (https://bugzilla.wikimedia.org/51798) (owner: 10Alex Monk) [18:25:08] Krenair: So… I'm going to have to go make those changes again? [18:25:22] (03CR) 10Alex Monk: "Fixed in Ief3c52e5" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148937 (owner: 10Jforrester) [18:25:52] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (cc3c62607c) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159105 [18:26:15] you were reordering unrelated messages [18:26:29] I was fixing broken ordering, yes. [18:27:23] They frequently drift out of alphabetic order and I fix them from time to time. [18:27:25] * James_F shrugs. [18:34:36] (03PS1) 10Jforrester: VisualEditor.php: Re-sort i18n message keys for clarity; add a comment about TOC [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159110 [18:34:42] (03CR) 10jenkins-bot: [V: 04-1] VisualEditor.php: Re-sort i18n message keys for clarity; add a comment about TOC [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159110 (owner: 10Jforrester) [18:34:51] Oh. Bah. [18:34:55] Based off the wrong one. [18:34:56] * James_F sighs. [18:35:03] (03Abandoned) 10Jforrester: VisualEditor.php: Re-sort i18n message keys for clarity; add a comment about TOC [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159110 (owner: 10Jforrester) [18:48:19] (03PS1) 10Jforrester: Re-sort i18n message keys for clarity; add a comment about TOC in VisualEditor.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159114 [18:55:09] 3MediaWiki / 3ResourceLoader: mw.loader.store should not occupy all of localStorage - 10https://bugzilla.wikimedia.org/64721#c9 (10Ryan Kaldari) Michael M.: That sounds like a good idea, but doesn't solve the underlying issue of this bug (that mw.loader.store takes up too much of localStorage). [18:57:24] 3VisualEditor / 3Editing Tools: VisualEditor: Link tool is too small when adding captions to new images - 10https://bugzilla.wikimedia.org/69511#c2 (10James Forrester) 5NEW>3RESO/FIX This appears to now be fixed? (Tested: Vector & Monobook on wmf19, wmf20, and pre-wmf21 with Firefox and Chrome.) [18:57:24] 3VisualEditor / 3Editing Tools: VisualEditor: Link tool is too small when adding captions to new images - 10https://bugzilla.wikimedia.org/69511 (10James Forrester) p:5Unprio>3Normal [18:58:38] 3VisualEditor / 3Editing Tools: VisualEditor: Links added to captions for new images not quite working - 10https://bugzilla.wikimedia.org/69510#c1 (10James Forrester) 5NEW>3RESO/WOR I don't see a bug here? This seems to be working as expected. Have I missed something? [18:59:43] (03CR) 10Jforrester: [C: 031] Add a secondary label (Edit) to ContextItemWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158539 (owner: 10JGonera) [19:02:23] 3VisualEditor / 3Editing Tools: VisualEditor: Insert > References list is very large in Firefox - 10https://bugzilla.wikimedia.org/70545#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal Is this another OOUI breakage? [19:06:41] 3VisualEditor / 3Editing Tools: VisualEditor: After removing the Template:Top,trying to place cursor on content throws TypeError: Cannot read property 'Left'/'right'/'start' of null - 10https://bugzilla.wikimedia.org/70571 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16406... [19:09:38] 3VisualEditor / 3ContentEditable: VisualEditor: Consider aborting link annotation extension on paste of rich content with terminal word-seperator(s) - 10https://bugzilla.wikimedia.org/70542#c2 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc If you're typing at the end of a link... [19:11:08] James_F, got any example pages that demonstrate https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 ? [19:13:23] (03CR) 10Krinkle: [C: 032] mw.ViewPageTarget.init: Log an error if target fails to load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155177 (owner: 10Jforrester) [19:14:05] Krenair: Every page without an edit notice if you're +sysop. [19:15:35] Krenair: They might also show if you're +templateeditor or whatever. [19:15:45] https://en.wikipedia.org/w/index.php?title=4-Methylaminobutanoate_oxidase_(methylamine-forming)&veaction=edit for example. [19:16:06] Krenair: Or add Hi to MediaWIki:Editnotice-0 [19:16:21] Locally! :-) [19:16:53] 3MediaWiki / 3ResourceLoader: mw.loader.store should not occupy all of localStorage - 10https://bugzilla.wikimedia.org/64721#c10 (10Ryan Kaldari) Filed an upstream bug against Firefox at https://bugzilla.mozilla.org/show_bug.cgi?id=1064466 [19:16:56] Hm.. no that's for the visiblity bug, I fixed that >1y ago [19:17:01] Krenair: Without the display: none; :) [19:17:58] Basically the problem is that enwiki created a global editnotice for sysops with a link to "create" a local edit notice. [19:18:12] The red link "[edit notice]" [19:18:30] Hidden by default for non-syops, but .sysop { display: block; } [19:19:10] Easily fixed on-wiki though, it's their system. And until and unless that concept exists in MediaWiki, there's nothing we can do in VE. [19:19:57] (other than provide the ability to hide things, and support hidden content as being "not a real notice", which I did last year with the visibleText plugin) [19:31:46] Krinkle, right, but why does it not actually hide the notice? [19:41:54] 3VisualEditor: VisualEditor: After you create or edit a reference and close the ref dialog, please de-select the newly created citation - 10https://bugzilla.wikimedia.org/70573 (10WhatamIdoing) 3NEW p:3Unprio s:3enhanc a:3None This is similar to Bug 69711. Steps to reproduce: 1. Type some text: "Fo... [19:50:59] So it's not hidden when we run $.getVisibleText. [19:56:55] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf21] Checking "Border" in media settings dialog in not enabling "Apply changes" button - 10https://bugzilla.wikimedia.org/70575 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Open Media S... [19:57:08] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf21] Checking "Border" in media settings dialog is not enabling "Apply changes" button - 10https://bugzilla.wikimedia.org/70575 (10Rummana Yasmeen) [20:01:18] Although... [20:01:31] It looks like the text is inside something properly marked as display:none; [20:01:42] yet $.getVisibleText returns the text anyway? [20:03:35] Though Chrome shows the "display: none;" style as struck through, and it's not !important [20:04:57] (03PS1) 10Esanders: Kill rangy: Vol. 2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159160 [20:06:10] edsanders: Vol. 3 will actually delete? [20:07:09] Ah, right, backwards selection. [20:07:24] And "display:block !important;" is the display: line that takes priority at the moment it seems [20:08:24] Right, so enwiki is hiding ".ve-ui-mwNoticesPopupTool-item .editnotice-redlink", but when it's doing getVisibleText that doesn't match [20:09:53] 3VisualEditor: VisualEditor: After you create or edit a reference and close the ref dialog, please de-select the newly created citation - 10https://bugzilla.wikimedia.org/70573#c1 (10James Forrester) In VE, new stuff always gets selected after you insert it – images, references, templates, comments, …. Do you... [20:10:24] 3VisualEditor / 3ContentEditable: VisualEditor: When CE gets re-enabled, the cursor always jumps to the beginning index of the first line irrespective of where user wanted to position it - 10https://bugzilla.wikimedia.org/70569 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [20:12:38] Krenair: Could you merge https://gerrit.wikimedia.org/r/#/q/Ic6fecd07b680a544e165e2813fc92360d18ad2bf,n,z please? [20:13:17] James_F, could you check bug 43013 again please? I think I just fixed the CSS [20:13:37] Krenair: Checking. [20:13:49] Krenair: Nope, still came up. [20:13:58] James_F, did you clear cache etc.? [20:14:17] Yes, but Chrome might have ignored it… [20:14:21] * James_F trues again. [20:14:52] Krenair: Aha, yes, working. [20:14:56] Krenair: Yay. [20:15:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: Deal with en.wikipedia.org's edit notice system - 10https://bugzilla.wikimedia.org/43013#c21 (10Alex Monk) 5REOP>3RESO/FIX I just fixed it with https://en.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=624714120&oldid=624708988 [20:15:56] (Chrome couldn't decide for me either, in the end I used incognito mode to check) [20:15:57] Brilliant, thanks. [20:16:10] Incognito mode == not sysop == no notice anyway, though? [20:16:21] Oh, I guess you logged in. :-) [20:16:25] I logged in [20:16:29] * James_F nods. [20:16:33] To the account on which I could reproduce it [20:17:08] (non-wmf account, which has templateeditor. global editinterface seems not to affect it) [20:17:18] Yeah. Quality coding, eh? [20:17:34] Heh. [20:18:39] Our version will be better. :-) [20:20:51] Krenair: Merge the OOUI pull-throughs and I'll merge 159104. :-) [20:21:20] James_F, yeah I was just wondering if we really want that yet.. [20:22:24] James_F, the help popups close to the sides of the dialog are kind of broken [20:22:36] Yeah, but that's an underlying issue. [20:23:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: Please add a 'close' box to the wikitext warning - 10https://bugzilla.wikimedia.org/70548#c1 (10James Forrester) 5NEW>3RESO/DUP p:5Unprio>3Low Adding close buttons / etc. to MediaWiki's notice system is bug 40307. Merging this into that rather th... [20:24:42] James_F, well the "Show the Table of Contents" one is half hidden [20:25:38] 3VisualEditor: VisualEditor: After you create or edit a reference and close the ref dialog, please de-select the newly created citation - 10https://bugzilla.wikimedia.org/70573#c2 (10Mike Christie) I wouldn't want to make a blanket statement, and I can recall situations where the fact that an object remains se... [20:27:52] Krenair: Yeah, but we'll fix that (or revert Trevor's change). [20:28:26] I'd prefer to fix it before exposing it as broken in VE. . . [20:28:28] What change? [20:28:56] The OOUI change to popuppable/clippable that seems to have caused a few issues. [20:29:10] Things using OOUI are already rather broken by it. [20:30:23] 3VisualEditor / 3Editing Tools: VisualEditor: Style texts when selected with Language inspector open, turns the drop-down selection blank. - 10https://bugzilla.wikimedia.org/70451#c4 (10Ritu Swain) Apologies.. here are the steps- 1> open a blank page in VE, open the Language inspector and select a text styl... [20:30:41] 3VisualEditor / 3Editing Tools: VisualEditor: In Safari, Cannot enter a search string to search images in the Media Settings dialog - 10https://bugzilla.wikimedia.org/70578 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None In Safari, Go to Insert>Media, try to enter something in the search box. yo... [20:32:08] 3VisualEditor / 3Editing Tools: VisualEditor: In Safari, Cannot enter a search string to search images in the Media Settings dialog and VE gets unresponsive afterwards - 10https://bugzilla.wikimedia.org/70578 (10Rummana Yasmeen) [20:32:56] (03CR) 10Alex Monk: [C: 032] Update OOjs UI to v0.1.0-pre (cc3c62607c) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159105 (owner: 10Jforrester) [20:33:20] Thanks. [20:33:24] 3VisualEditor / 3Editing Tools: VisualEditor: After you insert a new node, don't select it but drop the cursor immediately after it instead - 10https://bugzilla.wikimedia.org/70573#c3 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal (In reply to Mike Christie from comment #2) > I wouldn't want to mak... [20:34:18] Krenair: Is there a MW standard css class for applying "this is an error" to some text content? [20:35:20] .error? [20:35:40] part of mediawiki.legacy.shared [20:35:51] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (cc3c62607c) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159105 (owner: 10Jforrester) [20:36:39] Hmm. [20:37:26] also .errorbox [20:37:45] Krenair: That's great, thanks. :_) [20:40:01] (03CR) 10Jforrester: [C: 032] Provide contextual help for the page settings dialog's controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159104 (https://bugzilla.wikimedia.org/51798) (owner: 10Alex Monk) [20:40:54] 3VisualEditor / 3Editing Tools: VisualEditor: There should be help links in every context - dialog boxes, inspectors, etc. - 10https://bugzilla.wikimedia.org/51798#c12 (10James Forrester) 5PATC>3ASSI a:5Alex Monk>3James Forrester First one done. We'll seek feedback on this approach and then roll out... [20:41:47] (03Merged) 10jenkins-bot: Provide contextual help for the page settings dialog's controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159104 (https://bugzilla.wikimedia.org/51798) (owner: 10Alex Monk) [20:42:59] James_F, https://gerrit.wikimedia.org/r/#/c/159114/1/VisualEditor.php - what happened with 'visualeditor-languageannotation-description' and 'visualeditor-languageannotation-description-with-dir'? [20:43:23] 3VisualEditor / 3Editing Tools: VisualEditor: After you insert a new node, don't select it but drop the cursor immediately after it instead - 10https://bugzilla.wikimedia.org/70573#c4 (10Mike Christie) On reflection I agree; "Save and add another" isn't a common case. I'll see if I run into situations where... [20:43:33] Krenair: " -> ' [20:43:57] Krenair: Oh, but I didn't re-re-sort. [20:43:59] * James_F grumbles. [20:44:04] One mo. [20:44:25] 3VisualEditor / 3Editing Tools: VisualEditor: The link inspector and comment box are appearing with no UI while opening them after an idle time - 10https://bugzilla.wikimedia.org/70580 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16407 --> https://bugzilla.wikimedia.org/a... [20:45:03] (03PS2) 10Jforrester: Re-sort i18n message keys for clarity; add a comment about TOC in VisualEditor.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159114 [20:48:09] 3VisualEditor / 3Editing Tools: VisualEditor: Plugin editors to be created (tracking) - 10https://bugzilla.wikimedia.org/46803 (10James Forrester) [20:52:24] 3VisualEditor / 3Editing Tools: VisualEditor: comment feature should be removed by default - 10https://bugzilla.wikimedia.org/70440#c2 (10Eran Roz) James, comments are great to VIEW & EDIT, but there is no reason to ADD comments in VE. Please consider removing the button, as new editors don't understand what... [20:55:57] James_F, what about just clarifying what that button does in the comment inspector? Or maybe renaming it to "Editor comment" or something? [20:56:35] re: that latest bug comment wikibugs just posted ^ [20:58:50] (03CR) 10Alex Monk: [C: 032] Re-sort i18n message keys for clarity; add a comment about TOC in VisualEditor.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159114 (owner: 10Jforrester) [21:00:26] (03Merged) 10jenkins-bot: Re-sort i18n message keys for clarity; add a comment about TOC in VisualEditor.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159114 (owner: 10Jforrester) [21:19:21] (03PS1) 10Jforrester: [WIP] Show LST
elements and let them be edited [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159182 (https://bugzilla.wikimedia.org/70581) [21:19:45] Urgh, MWCategoryInputWidget#getLookupMenuItemsFromData [21:27:25] 3VisualEditor / 3Editing Tools: VisualEditor: Inserted link annotations don't take pre-annotations (but inserted language annotations do) - 10https://bugzilla.wikimedia.org/70534 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal a:3Bartosz Dziewoński [21:28:07] TrevorP|Away, RoanKattouw_away, edsanders is there a chance for a +2 of https://gerrit.wikimedia.org/r/#/c/158539/ today? If it doesn't happen today I probably won't look at it for the next few days [21:28:38] jgonera: TrevorP|Away and RoanKattouw_away are out 'til Wednesday, but I'll ask edsanders to look at it. [21:28:44] Krenair: Eh. Maybe. [21:28:54] ok, thanks [21:33:38] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf21] In Safari, Cannot enter any input in any dialog and VE gets unresponsive after trying to do that - 10https://bugzilla.wikimedia.org/70578#c1 (10Rummana Yasmeen) This is happening for all citation dialogs, basic reference dialog, transclusion... [21:36:40] MatmaRex: Well, if it's known log noise then something else broke VE for me on Chrome (private wiki, master) [21:37:03] Attempting a veaction=edit just... does nothing. [21:37:17] Coren: That's not good. :-( [21:37:21] Coren: It was working before? [21:37:28] That error on the js console was my only hint. [21:37:33] James_F: As of last Thursday it was. [21:37:44] Hmm. Did you re-sync? [21:37:58] * Coren nods. "Just did too, just to make sure." [21:38:35] Did you do that for MW-core too? [21:38:51] We use wfUseMW quite aggressively to avoid breakage between VE and MW dependencies. [21:38:55] Yep. In fact, I had to because I'm tracking some bugfixes in Flow. [21:39:17] Ah, fun. [21:39:26] Did you re-sync the submodule too? [21:39:37] (Shouldn't be needed, but…) [21:39:38] Had to update Flow -> Had to update core -> VE broke. Resynced VE and Parsoid (and submodule too) [21:39:46] Bah. [21:39:50] In that case, no idea. :-( [21:40:14] James_F: Anything I can help by looking at to make a proper diagnostic beyond "it no worky!"? [21:40:58] (That wiki is an amusing testing ground because I'm running master VE, Flow, Thanks, and FR. :-) [21:41:15] FR? Really? Masochist! :-) [21:41:24] Is there really nothing in the MW logs? [21:42:56] The site is live, so I was a little hesitant to turn on too much instrumentation. Lemme turn wgDebugLogFile back on and try. [21:44:17] ... dafu? [21:44:32] * Coren turns it back off because now VE worked? [21:46:13] James_F: Ah, and a locally-patched FR to boot because of special requirements. :-) [21:46:33] :-) [21:46:35] Magic computers. [21:46:48] (Possibly a caching issue?) [21:46:58] James_F: But... now VE works again. I have *NO* idea what might have possibly happened besides turning logfile on then off again. Is caching affected by the LocalSettings.php timestamp? [21:47:18] memcached is … magic. [21:47:20] So, maybe? [21:47:32] * Coren boggles a littlle. [21:47:47] Oh, well. Fun of the bleeding edge. [21:53:58] Or maybe that was the dev equivalent of sysadmin eyes. You know, an issue never actually happens when you're trying to show the sysadmin. [21:54:22] Absolutely. :-) [21:54:54] * Coren would love it /so/ much if it was possible to turn on wgDebugToolbar per-session. [21:55:30] Coren: Have you seen VE's debugging toolbar? [21:55:54] Coren: Not quite the same (for things inside VE), but ?debug=true gets you a fun toolbar at the bottom of the content div. :-) [21:56:06] Ooo. No, I never did. [21:56:47] * Coren raises an eyebrow at "Start Filibuster" [21:56:53] 3VisualEditor / 3Editing Tools: VisualEditor: After you insert a new node, don't select it but drop the cursor immediately after it instead - 10https://bugzilla.wikimedia.org/70573#c5 (10James Forrester) (In reply to Mike Christie from comment #4) > On reflection I agree; "Save and add another" isn't a commo... [21:57:04] Ha. Yeah, that's a bit insane if you don't know what it is. [21:57:17] It prints out every single function call in the stack. Continuously. [21:57:21] Thousands of them. [21:57:32] Sigh. [21:57:47] David invented it for IME issues, where it's essentially the only way to get inside what's going on. [21:57:51] Krenair: ? [21:57:55] yes [21:58:01] don't use it unless you are David [21:58:10] I've been trying to debug some weird issue I'm running into with category redirects. [21:58:13] Even if you are David, don't use it unless you have lots of coffee. :-) [21:58:21] Krenair: Ah, my sympathies. [21:58:33] With a name like that I hoestly did not intend to click it. It's omnious. :-) [21:58:43] Good, the name worked, then. :-) [21:58:53] But it looks like... you can't actually use action=query&redirects= without using a generator? or something. [21:59:07] Meh. [22:00:33] James_F: FYI, VE does a good job of the horrible layout-by-style things the wiki's users came up with. Bravo. [22:00:34] Or specifying titles= [22:00:52] Coren: Thanks, though the browsers help a bunch. [22:00:58] I wonder if anomie is around [22:01:10] Krenair: He was a few hours ago… [22:02:39] anomie|meeting at the moment. I'll wait till later. [22:03:34] https://gerrit.wikimedia.org/r/#/c/135782/1 probably broke our handling of category redirecting [22:10:55] (03CR) 10Esanders: [C: 032] "Don't forget to add the message to VisualEditor.php in the pull-through" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158539 (owner: 10JGonera) [22:11:47] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (8f66045) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159093 (owner: 10Jforrester) [22:13:15] (03Merged) 10jenkins-bot: Add a secondary label (Edit) to ContextItemWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158539 (owner: 10JGonera) [22:13:26] (03Merged) 10jenkins-bot: Update VE core submodule to master (8f66045) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159093 (owner: 10Jforrester) [22:21:59] (03PS1) 10Jforrester: Update VE core submodule to master (85a059e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159205 [22:45:24] 3VisualEditor / 3Technical Debt: VisualEditor: Nicer removal of Cite.php's class=error - 10https://bugzilla.wikimedia.org/51141#c3 (10James Forrester) Sorry! This refers to the hacky fix for bug 50423 which added (eventually): /* HACK: Hide Ref errors in templates */ .mw-ext-cite-error { display: n... [22:52:39] James_F: hey! VE/mobile meeting today? [22:52:58] kaity: Sure, though I've not got much to say. [22:58:23] 3VisualEditor / 3Editing Tools: VisualEditor: After you insert a new node, don't select it but drop the cursor immediately after it instead - 10https://bugzilla.wikimedia.org/70573#c6 (10WhatamIdoing) > Do you think that design decision should be reversed Yes. Unless I'm likely to need that thing to be sel... [23:00:56] kaity: Cancelling as neither did Maryana or Juliusz. [23:01:10] James_F: ok cool! [23:03:23] 3MediaWiki extensions / 3WikiEditor: CSS Conflict of textareas with mediawiki ui left-side blue bar - 10https://bugzilla.wikimedia.org/70194#c1 (10Matthew Flaschen) How is this connected to the font bug ("Bug 70028 - Should Mediawiki UI change font-family for textareas?")? [23:05:24] 3VisualEditor / 3Editing Tools: VisualEditor: Link tool is too small when adding captions to new images - 10https://bugzilla.wikimedia.org/69511#c3 (10WhatamIdoing) Works for me in Firefox 31 and Safari 6. [23:05:38] James_F, for https://bugzilla.wikimedia.org/show_bug.cgi?id=67156 maybe we just need to prevent any focus events outside the currently open dialog [23:05:57] Krenair: Is that something we should do for accessibility reasons? [23:06:28] well the bug is tagged accessibility [23:07:19] Yeah, but tagged is not necessarily "you should do this for better accessibility"? :-) [23:07:49] Ask TheDJ for his opinion? [23:11:08] 3VisualEditor / 3Editing Tools: VisualEditor: Links added to captions for new images not quite working - 10https://bugzilla.wikimedia.org/69510#c2 (10WhatamIdoing) Experience in Safari: 1. Open VisualEditor and Insert > Media. 2. Pick and image and add a caption. 3. Select a word and press Command-K t... [23:15:20] James_F, http://www.w3.org/WAI/GL/wiki/Using_ARIA_role%3Ddialog_to_implement_a_modal_dialog_box#Note_on_focus_management [23:20:16] http://accessibility.oit.ncsu.edu/blog/2013/09/13/the-incredible-accessible-modal-dialog/ also has a section about this [23:20:24] (03PS2) 10Krinkle: [WIP] build: Make headers atop dist files suitable for distribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 [23:21:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP] build: Make headers atop dist files suitable for distribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 (owner: 10Krinkle) [23:23:53] Krinkle: Bit by the node 0.10.0 CI issue, I see. [23:24:16] Yeah, I've been working with Antoine to get Trusty set up [23:24:44] Yeah. [23:24:49] Would be great to get that done. [23:26:37] (03CR) 10Jforrester: [WIP] build: Make headers atop dist files suitable for distribution (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 (owner: 10Krinkle) [23:27:55] Krinkle: Interested in getting UploadWizard running npm for tests? https://gerrit.wikimedia.org/r/#/c/155833/ is pretty close. [23:30:08] (03CR) 10Esanders: Add a secondary label (Edit) to ContextItemWidget (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158539 (owner: 10JGonera) [23:37:04] Krenair: Hmm, OK then. [23:54:14] 3MediaWiki extensions / 3WikiEditor: CSS Conflict of textareas with mediawiki ui left-side blue bar - 10https://bugzilla.wikimedia.org/70194#c2 (10Bartosz Dziewoński) They're both caused by adding .mw-ui-input to the article textarea. But this bug indeed doesn't depend on that bug – my mistake.