[00:03:29] 3VisualEditor / 3Editing Tools: VisualEditor: Links added to captions for new images not quite working - 10https://bugzilla.wikimedia.org/69510#c3 (10Rummana Yasmeen) I think it is the firefox which is different from Chrome and Safari, not sure which one is correct though!And not just for a link inside imag... [00:20:31] (03CR) 10Krinkle: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 (owner: 10Krinkle) [00:21:40] Krinkle: Whee. Nice to see. :-) [00:21:50] https://integration.wikimedia.org/ci/job/VisualEditor-npm/2845/console [00:22:06] Yep, I cheated. [00:22:10] Oh? [00:22:21] 2840,1,2,3,4 is where I experimented [00:22:25] I knew this one would pass [00:24:34] Ah, right. [00:24:43] And for comparison, the commit doesn't make it work, an old build also passes on trusty [00:24:50] e.g. https://integration.wikimedia.org/ci/job/VisualEditor-npm/2839/consoleFull is rebuilt as https://integration.wikimedia.org/ci/job/VisualEditor-npm/2846/consoleFull [00:25:18] * James_F nods. [00:25:29] speed about the same [00:25:41] But no: [00:25:42] 22:10:59 npm WARN engine grunt-jscs@0.6.1: wanted: {"node":">= 0.10.0"} (current: {"node":"v0.8.2","npm":"1.4.16"}) [00:25:43] Etc. [00:25:51] Could you enable for OOUI and OOjs? [00:25:54] *old build* [00:26:06] One that doesn't have my unmerged changes regarding ve dist headers [00:26:08] Yeah, now we don't get those. [00:26:15] Right [00:26:18] no as in without [00:26:23] Yeah. [00:26:28] Sorry. [00:26:34] this one happened to be a few seconds faster (2m15s > 1m51s) [00:26:49] For https://gerrit.wikimedia.org/r/#/c/158883/ I think https://gerrit.wikimedia.org/r/#/c/158883/2/src/ve.Document.js is the way to go with file headers. What do you think? [00:26:53] but if you look at the build trend, it's variable enough that it may not be a real win [00:27:04] I only proposed options I like [00:27:33] I'll leave it running only for VisualEditor now to see how it performs and whether there's any issues with caching on that new labs instance [00:27:47] in the past we often had cache corruption or where /tmp would fill up [00:28:00] Boo. [00:28:00] code wise it works, but I'm not sold yet. [00:28:21] builds elsewhere arne't failing right now, right? [00:28:27] https://gerrit.wikimedia.org/r/#/c/157315/ is. [00:28:34] In OOUI. [00:28:53] Though of course we're not doing cssmin right now. [00:29:48] Yeah. Well, this day ended 2 hours ago. I'll enable it for oojs-ui tomorrow, then. [00:29:56] Krinkle: Sure. Sleep well! [00:30:01] o/ [00:48:23] (03PS1) 10Esanders: Make tools wrapper display inline so tools wrap around actions [oojs/ui] - 10https://gerrit.wikimedia.org/r/159232 [00:48:25] (03PS1) 10Esanders: Add backgrounds and borders to dropdowns in Minerva [oojs/ui] - 10https://gerrit.wikimedia.org/r/159233 [01:16:12] (03CR) 10Jforrester: [C: 032] Add backgrounds and borders to dropdowns in Minerva [oojs/ui] - 10https://gerrit.wikimedia.org/r/159233 (owner: 10Esanders) [01:16:27] (03CR) 10Jforrester: [C: 032] Make tools wrapper display inline so tools wrap around actions [oojs/ui] - 10https://gerrit.wikimedia.org/r/159232 (owner: 10Esanders) [01:17:42] (03Merged) 10jenkins-bot: Make tools wrapper display inline so tools wrap around actions [oojs/ui] - 10https://gerrit.wikimedia.org/r/159232 (owner: 10Esanders) [01:17:44] (03Merged) 10jenkins-bot: Add backgrounds and borders to dropdowns in Minerva [oojs/ui] - 10https://gerrit.wikimedia.org/r/159233 (owner: 10Esanders) [01:20:33] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (1c5e409ab1) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159239 [01:21:31] (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.1.0-pre (1c5e409ab1) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159239 (owner: 10Jforrester) [01:23:10] edsanders: And https://gerrit.wikimedia.org/r/#/c/159205/ [01:23:51] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (1c5e409ab1) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159239 (owner: 10Jforrester) [01:24:56] (03CR) 10Jforrester: [C: 032] "Clean." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159002 (owner: 10Krinkle) [01:26:46] (03Merged) 10jenkins-bot: mw.ViewPageTarget.init: Reduce Deferred clutter in getTarget() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159002 (owner: 10Krinkle) [01:26:48] (03Merged) 10jenkins-bot: mw.ViewPageTarget.init: Log an error if target fails to load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/155177 (owner: 10Jforrester) [01:33:25] (03PS4) 10Jforrester: Make help icon have an RTL variant [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 [01:34:56] (03CR) 10Jforrester: "PS4 is a rebase." [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (owner: 10Jforrester) [02:04:07] edsanders: https://gerrit.wikimedia.org/r/#/c/159205/ [02:04:23] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (85a059e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159205 (owner: 10Jforrester) [02:05:59] (03Merged) 10jenkins-bot: Update VE core submodule to master (85a059e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159205 (owner: 10Jforrester) [02:11:48] James_F, https://gerrit.wikimedia.org/r/#/c/159243/ [02:12:16] ta [04:08:00] 3VisualEditor / 3Editing Tools: VisualEditor: Support creation of auto-numbered external links and to convert them to labeled ones - 10https://bugzilla.wikimedia.org/51309#c9 (10Matthew Flaschen) Is it possible to convert an auto-numbered link to one with arbitrary text (that's what the second part of the bu... [04:54:00] 3VisualEditor / 3Editing Tools: VisualEditor: Support creation of auto-numbered external links and to convert them to labeled ones - 10https://bugzilla.wikimedia.org/51309#c10 (10James Forrester) (In reply to Matthew Flaschen from comment #9) > Is it possible to convert an auto-numbered link to one with arbi... [07:51:26] (03PS1) 10Jagori79: New commit message removing any special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159259 [08:10:33] (03Abandoned) 10Jagori79: New commit message removing any special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159259 (owner: 10Jagori79) [08:18:32] (03PS23) 10Jagori79: Reworked on step definition and page object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 [08:24:07] (03PS24) 10Jagori79: WIP: [Browser test] Reworked step definition and links file basis input [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 [08:29:18] (03CR) 10Jagori79: "Hi Zeljko," (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [08:31:58] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf20] The notification dialog is appearing little bigger in test2 and there is a big empty space in it - 10https://bugzilla.wikimedia.org/70423#c5 (10Elitre) Adding my screenshot taken in IE. [08:32:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf20] The notification dialog is appearing little bigger in test2 and there is a big empty space in it - 10https://bugzilla.wikimedia.org/70423#c6 (10Elitre) Created attachment 16411 --> https://bugzilla.wikimedia.org/attachment.cgi?id=1641... [09:04:31] 3VisualEditor: VisualEditor: The References List dialog looks too big, much unnecessary empty space - 10https://bugzilla.wikimedia.org/70601 (10Elitre) [09:04:31] 3VisualEditor / 3Editing Tools: VisualEditor: The size of References List dialog is appearing a bit small in Firefox making the text field almost overlap with the edge of the dialog - 10https://bugzilla.wikimedia.org/68226 (10Elitre) [09:04:33] 3VisualEditor: VisualEditor: The References List dialog looks too big, much unnecessary empty space - 10https://bugzilla.wikimedia.org/70601 (10Elitre) 3NEW p:3Unprio s:3normal a:3None Created attachment 16412 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16412&action=edit References list tryi... [09:04:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf20] The notification dialog is appearing little bigger in test2 and there is a big empty space in it - 10https://bugzilla.wikimedia.org/70423 (10Elitre) [09:04:45] 3VisualEditor: VisualEditor: The References List dialog looks too big, much unnecessary empty space - 10https://bugzilla.wikimedia.org/70601 (10Elitre) [09:25:46] 3VisualEditor: VisualEditor: Save page button is not fully clickable - 10https://bugzilla.wikimedia.org/70602 (10Elitre) 3NEW p:3Unprio s:3normal a:3None In Chrome and Internet Explorer it is perfectly possible to click repeatedly on the Save button and achieve nothing. On large portions of it (especia... [09:37:59] 3VisualEditor: VisualEditor: Save page button is not fully clickable - 10https://bugzilla.wikimedia.org/70602#c1 (10Elitre) Actually, Safari is probably the only browser where this doesn't happen. You can reproduce on all the 3 buttons near the Save one, but not on the dialogs' ones. [09:56:17] 3VisualEditor: VisualEditor: Please warn if user adds caption for a pic but then chooses an image type that won't display it? - 10https://bugzilla.wikimedia.org/70603 (10Elitre) 3NEW p:3Unprio s:3normal a:3None Just happened to me, I added some text as a caption for my image, then entered the Advanced... [10:22:31] 3VisualEditor: VisualEditor: The Field description popup looks weird on mediawiki.org - 10https://bugzilla.wikimedia.org/70604 (10Elitre) 3NEW p:3Unprio s:3normal a:3None Created attachment 16413 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16413&action=edit Field description popup for templa... [10:45:42] Should the version number link to git in VE lead somewhere? [10:48:59] 3VisualEditor: VisualEditor: The Field description popup looks weird on mediawiki.org - 10https://bugzilla.wikimedia.org/70604#c1 (10Elitre) Same for the Special Characters dialog. [10:54:06] Elitre1: probably [10:54:47] Elitre1: the link where? on special:version? [11:16:33] MatmaRex: yup. [11:16:59] MatmaRex: nothing happens if I click on it, the page keeps spinnin'. [11:17:34] yeah… looks as if git.wikimedia.org is down [11:18:00] it's fine if it's not the rule :) [11:18:03] (brb) [12:56:14] 3VisualEditor: VisualEditor: Save page button is not fully clickable - 10https://bugzilla.wikimedia.org/70602#c2 (10Bartosz Dziewoński) 5NEW>3UNCO This is probably the bug fixed by 2aebe8054eed2516ac06c62101f2793f29c416aa. [13:15:30] (03PS25) 10Jagori79: WIP: [Browser Test] Reworked step definition and links file basis input [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 [15:09:51] (03PS1) 10Oliverb: Added helper for document pre-order traversal. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159309 [15:09:53] (03PS1) 10Oliverb: Data model implementation for tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 [15:09:55] (03PS1) 10Oliverb: ContentEditable implementation for tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 [15:09:57] (03PS1) 10Oliverb: Actions for manipulating tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 [15:09:59] (03PS1) 10Oliverb: Icons and tools for table manipulations. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159313 [15:10:01] (03PS1) 10Oliverb: I18n for table tools. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159314 [15:10:03] (03PS1) 10Oliverb: Add table example and include necessary source files in demo. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159315 [15:10:05] (03PS1) 10Oliverb: Custom sub-toolbar for table tools. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159316 [15:10:07] (03PS1) 10Oliverb: Provisional fix to prevent structural changes to a table via delete+merge. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 [15:15:46] 3VisualEditor / 3Data Model: VisualEditor: Blank field is shown as “show one more field”, with Templates having at least 4 parameters in Template data. - 10https://bugzilla.wikimedia.org/70609 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Created attachment 16414 --> https://bugzilla.wikimedia... [15:16:14] 3VisualEditor / 3Data Model: VisualEditor: Blank field is shown as “show one more field”, with Templates having at least 4 parameters in Template data. - 10https://bugzilla.wikimedia.org/70609#c1 (10Ritu Swain) Created attachment 16415 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16415&action=ed... [15:16:15] (03CR) 10Jforrester: "Colourful icons are a bit of a departure from the existing monochrome icon set; maybe we could consider using others, possibly later rathe" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159313 (owner: 10Oliverb) [15:16:16] (03CR) 10Oliverb: "Ooops... I don't really use this code anymore..." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159309 (owner: 10Oliverb) [15:18:59] (03PS2) 10Jforrester: Data model implementation for tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [15:19:01] (03PS2) 10Jforrester: ContentEditable implementation for tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [15:19:03] (03PS2) 10Jforrester: Provisional fix to prevent structural changes to a table via delete+merge. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [15:19:05] (03PS2) 10Jforrester: Custom sub-toolbar for table tools. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159316 (owner: 10Oliverb) [15:19:07] (03PS2) 10Jforrester: Icons and tools for table manipulations. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159313 (owner: 10Oliverb) [15:19:09] (03PS2) 10Jforrester: Actions for manipulating tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [15:19:11] (03PS2) 10Jforrester: Add table example and include necessary source files in demo. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159315 (owner: 10Oliverb) [15:19:13] (03PS2) 10Jforrester: I18n for table tools. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159314 (owner: 10Oliverb) [15:19:32] (03CR) 10Jforrester: "Have rebased the rest of the stack off this; is it worth keeping for other users, or should we abandon?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159309 (owner: 10Oliverb) [15:21:06] (03CR) 10jenkins-bot: [V: 04-1] Data model implementation for tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [15:21:25] (03CR) 10jenkins-bot: [V: 04-1] ContentEditable implementation for tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [15:21:29] (03CR) 10jenkins-bot: [V: 04-1] Icons and tools for table manipulations. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159313 (owner: 10Oliverb) [15:21:40] (03CR) 10jenkins-bot: [V: 04-1] Custom sub-toolbar for table tools. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159316 (owner: 10Oliverb) [15:21:57] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [15:22:01] (03CR) 10Oliverb: "For table it turned out, that everything could be solved using up-tree traversal." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159309 (owner: 10Oliverb) [15:23:38] (03CR) 10jenkins-bot: [V: 04-1] Actions for manipulating tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [15:23:42] (03CR) 10jenkins-bot: [V: 04-1] Add table example and include necessary source files in demo. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159315 (owner: 10Oliverb) [15:23:44] (03CR) 10jenkins-bot: [V: 04-1] I18n for table tools. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159314 (owner: 10Oliverb) [15:26:54] (03Abandoned) 10Jforrester: Added helper for document pre-order traversal. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159309 (owner: 10Oliverb) [15:32:49] (03CR) 10Jforrester: "Sorry — the code tests don't run unless you're a whitelisted user, so they were invisible until I rebased. Adding you to the whitelist in " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [15:33:52] (03CR) 10Oliverb: "Generally, the icons are definitely not perfect yet..." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159313 (owner: 10Oliverb) [16:07:01] 3VisualEditor / 3Editing Tools: VisualEditor:”Use an Existing Reference “ button stays active even when there are no references to add. - 10https://bugzilla.wikimedia.org/70611 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16416 --> https://bugzilla.wikimedia.org/attachment.cg... [16:07:14] 3VisualEditor / 3Editing Tools: VisualEditor:”Use an Existing Reference “ button stays active even when there are no references to add. - 10https://bugzilla.wikimedia.org/70611 (10Ritu Swain) [16:29:47] (03CR) 10Alex Monk: [C: 04-1] "This should be squashed into the appropriate commit. I18n should not be separate." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159314 (owner: 10Oliverb) [16:30:25] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107266784 [16:30:25] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32599272 [16:30:25] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32603530 [16:30:25] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32605007 [16:30:25] Corruption alert: visualeditor-needcheck on ukwiki: https://uk.wikipedia.org/?diff=14792176 [16:30:26] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65398705 [16:30:26] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65401429 [16:30:30] Oh dear. [16:30:34] That's… not great. [16:31:58] frwiki entry is the usual myEventWatcherDiv nonsense [16:32:24] second ruwiki entry... looks concerning. might just be the user though. [16:32:47] ukwiki entry blanked the page. [16:33:34] As in, user vandalism or bug? [16:34:13] Well that's the thing. I don't know whether those two are vandalism or an actual bug. [16:34:33] * James_F nods. [17:00:59] 3VisualEditor / 3Data Model: VisualEditor: “show one more field” adds nothing to existing Template data, with Templates having at least 4 parameters. - 10https://bugzilla.wikimedia.org/70609 (10Ritu Swain) [18:23:14] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf20] The notification dialog is appearing little bigger in test2 and there is a big empty space in it - 10https://bugzilla.wikimedia.org/70423#c7 (10Rummana Yasmeen) Created attachment 16417 --> https://bugzilla.wikimedia.org/attachment.cg... [18:58:31] 3VisualEditor / 3Editing Tools: VisualEditor: Media search not working in Betalabs - 10https://bugzilla.wikimedia.org/70621 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16419 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16419&action=edit Screenshot Steps to repro... [20:36:15] 3VisualEditor / 3Editing Tools: VisualEditor: ”Use an Existing Reference“ button should be inactive if there are no references to add (the internal list is empty) - 10https://bugzilla.wikimedia.org/70611 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3High a:3Alex Monk [21:52:30] 3VisualEditor / 3Editing Tools: VisualEditor: Media search not working in Betalabs - 10https://bugzilla.wikimedia.org/70621#c1 (10James Forrester) Works for me… Search blip? [22:35:20] James_F: since you are around, i'll convey my performance concerns about VE [22:35:54] i had timed the time to load a page for me in 40 pages. (i know it is a small amount) [22:36:18] it vary from 23s to 1m 12s [22:36:29] this is slow [22:36:50] saving is usually faster [22:41:38] (03PS1) 10Alex Monk: Update LinkCache in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159418 (https://bugzilla.wikimedia.org/69886) [22:45:16] 3VisualEditor / 3Editing Tools: VisualEditor: Media search not working in Betalabs - 10https://bugzilla.wikimedia.org/70621#c2 (10Rummana Yasmeen) 5NEW>3RESO/FIX Yeah may be..Working for me now as well [22:48:25] matanya: it would be nice to have a bugzilla issue for that. I've seen similar issues [22:48:39] chrismcmahon: will do [22:49:07] matanya: it would also be interesting to know if HHVM affects that. VE for logged in users on beta labs should be using HHVM, and it should be much faster [22:49:22] for some value of "much" [22:49:25] i'll test that too [22:51:17] matanya: beta is a virtual environment, so any performance data from there is suspect, but it would be a useful comparison I think [22:51:38] i see what you mean, but doing it now anyway [22:52:35] matanya: yeah, performance on beta labs is tied to load/stress on the rest of labs, but it's still interesting to know [22:57:59] 3MediaWiki / 3Page editing: Editing help link goes to [[mw:Help:Editing_pages]] instead of the wiki's own [[Help:Editing]] page - 10https://bugzilla.wikimedia.org/70521#c4 (10Rob Kam) The Help link in the sidebar also links off-site to https://www.mediawiki.org/wiki/Help:Contents even though the local wiki's... [23:00:44] 3MediaWiki / 3Page editing: Editing help link goes to [[mw:Help:Editing_pages]] instead of the wiki's own [[Help:Editing]] page - 10https://bugzilla.wikimedia.org/70521#c5 (10Rob Kam) Edit MediaWiki:Helppage to fix it. [23:14:22] (03PS1) 10Alex Monk: Properly mark reference search index as empty when setting internal list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159423 (https://bugzilla.wikimedia.org/70611) [23:14:55] (03CR) 10Alex Monk: "Caused bug 70611, fixed in I81bca8f4" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148070 (owner: 10Esanders) [23:24:57] chrismcmahon: https://bugzilla.wikimedia.org/show_bug.cgi?id=50616 [23:24:59] 3VisualEditor / 3Initialisation: VisualEditor: Significant slowness in loading in Firefox - 10https://bugzilla.wikimedia.org/50616#c1 (10matanya) I'm using firefox 32 and did some tests on this on en,wikipedia, and beta en, which runs HHVM, but is on a virt cluster. Article name:Barack Obama beta en: 41.7s... [23:25:08] (03CR) 10Jforrester: [C: 032] Properly mark reference search index as empty when setting internal list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159423 (https://bugzilla.wikimedia.org/70611) (owner: 10Alex Monk) [23:25:29] 3VisualEditor / 3Editing Tools: VisualEditor: ”Use an Existing Reference“ button should be inactive if there are no references to add (the internal list is empty) - 10https://bugzilla.wikimedia.org/70611#c2 (10James Forrester) 5PATC>3RESO/FIX Nice. [23:26:47] (03Merged) 10jenkins-bot: Properly mark reference search index as empty when setting internal list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159423 (https://bugzilla.wikimedia.org/70611) (owner: 10Alex Monk) [23:27:17] thanks matanya [23:27:22] sure [23:27:29] 3VisualEditor / 3Initialisation: VisualEditor: Significant slowness in loading in Firefox - 10https://bugzilla.wikimedia.org/50616#c2 (10Chris McMahon) adding Ori for possible HHVM implications [23:38:33] matanya: Hmm. Did you do a second load for bug 50616? [23:38:50] matanya: Possibly HHVM's cache needs warming up the first time you load it? [23:39:00] James_F: i'm doing now chrome for comparison [23:39:14] and then well do second phase [23:39:25] matanya: Cool. [23:40:06] matanya: I think it's most likely that it's just "Beta Labs is slow", which isn't bug 50616. [23:40:43] i thought to agree, but prepare to be surprised. [23:40:47] * James_F nods. [23:41:04] Also, can't you still force non-HHVM on the Beta Labs boxen? [23:41:09] For a direct baseline. [23:41:16] I'm not an expert. :-) [23:42:14] I think i can technically can [23:42:26] but bot sure, that is a question for ori [23:42:32] *not [23:42:50] * James_F nods. [23:42:53] James_F: can you see if he can donate 2 minutes to this? [23:44:32] I wonder if https://bugzilla.wikimedia.org/show_bug.cgi?id=70016 is related to https://bugzilla.wikimedia.org/show_bug.cgi?id=70601 [23:45:39] In fact I'm be tempted to mark them as dupes after seeing Roan's comment on 70016... Although the IE one is more extreme [23:45:49] I'm tempted* [23:46:10] meh, see also [23:46:27] (03PS1) 10Esanders: Table demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159433 [23:46:29] 3VisualEditor / 3Editing Tools: VisualEditor:Shrink back the Basic Reference dialog size - 10https://bugzilla.wikimedia.org/70016 (10Alex Monk) [23:46:29] 3VisualEditor: VisualEditor: The References List dialog looks too big, much unnecessary empty space - 10https://bugzilla.wikimedia.org/70601 (10Alex Monk) [23:46:41] (03PS3) 10Esanders: Data model implementation for tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [23:46:56] (03PS3) 10Esanders: ContentEditable implementation for tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [23:47:23] (03PS3) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [23:47:25] (03PS3) 10Esanders: Custom sub-toolbar for table tools. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159316 (owner: 10Oliverb) [23:47:27] (03PS3) 10Esanders: Icons and tools for table manipulations. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159313 (owner: 10Oliverb) [23:47:29] (03PS3) 10Esanders: Actions for manipulating tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [23:47:31] (03PS3) 10Esanders: I18n for table tools. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159314 (owner: 10Oliverb) [23:48:00] oh my god, every time I read an email 7 more appear in it's place [23:48:59] (03Abandoned) 10Esanders: Add table example and include necessary source files in demo. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159315 (owner: 10Oliverb) [23:49:16] Krenair: Welcome to the world of work. ;-) [23:49:32] (03CR) 10jenkins-bot: [V: 04-1] ContentEditable implementation for tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [23:49:36] (03CR) 10jenkins-bot: [V: 04-1] Data model implementation for tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [23:51:44] 3VisualEditor / 3Initialisation: VisualEditor: Significant slowness in loading in Firefox - 10https://bugzilla.wikimedia.org/50616#c3 (10matanya) Adding timings in chromium 37 for comparison: Article name:Barack Obama beta en: 8.1s en : 17.2s Article name: Cat beta en: 7.7s en: 16.0s Article name:Beyoncé... [23:52:25] matanya: Hmmmmmmm. That sounds totally like a slow cache. [23:52:39] (03CR) 10jenkins-bot: [V: 04-1] Icons and tools for table manipulations. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159313 (owner: 10Oliverb) [23:52:49] (03CR) 10jenkins-bot: [V: 04-1] I18n for table tools. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159314 (owner: 10Oliverb) [23:52:51] (03CR) 10jenkins-bot: [V: 04-1] Actions for manipulating tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [23:52:59] James_F: on what end ? [23:53:03] (03CR) 10jenkins-bot: [V: 04-1] Custom sub-toolbar for table tools. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159316 (owner: 10Oliverb) [23:53:12] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [23:53:29] 3VisualEditor / 3Initialisation: VisualEditor: Significant slowness in loading in Firefox - 10https://bugzilla.wikimedia.org/50616#c4 (10Bryan Davis) (In reply to matanya from comment #1) > I'm using firefox 32 and did some tests on this on en,wikipedia, and beta > en, which runs HHVM, but is on a virt clust... [23:54:16] matanya: FF vs. Chrome is ~ 5% slower on enwiki for the first two, but magically the first time you did it on an HHVM box it was 5x slower? [23:55:17] I see what you mean [23:55:47] But then the next three have a very different pattern. [23:56:30] 3VisualEditor / 3Editing Tools: VisualEditor: ”Use an Existing Reference“ button should be inactive if there are no references to add (the internal list is empty) - 10https://bugzilla.wikimedia.org/70611#c4 (10Rummana Yasmeen) 5RESO/FIX>3REOP The Re-Use option in the Cite menu from the toolbar still rema... [23:56:44] 3VisualEditor / 3Editing Tools: VisualEditor: ”Use an Existing Reference“ button should be inactive if there are no references to add (the internal list is empty) - 10https://bugzilla.wikimedia.org/70611 (10Rummana Yasmeen) 5REOP>3ASSI [23:57:13] (03CR) 10Jforrester: [C: 032] Table demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159433 (owner: 10Esanders) [23:58:50] (03Merged) 10jenkins-bot: Table demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159433 (owner: 10Esanders)