[00:00:51] James_F, hmm... do we really want to do what Rummana proposes there? [00:01:11] Krenair: We do it for other tools that aren't appropriate. [00:01:16] Krenair: E.g. clear styling. [00:01:23] Okay. [00:01:40] Also this is kind of unrelated to the issue reported :p [00:02:11] James_F: I think the main thing we learned is your team is using chrome, please change this behavior :) [00:02:13] Eh. It's the same logic and the same conceptual button. [00:02:35] Yeah but this bug was for very specific steps to break the existing restriction on a different button. [00:03:06] matanya: As soon as Firefox ships with a good JS engine. Right now it's terribly slow, which makes the experience bad for some users. [00:03:25] matanya: Also, no, I think two of the team use Firefox as their principle browser. [00:04:20] ok, noted. I'll stick to wikitext for the foreseeable future. Thanks for all your work! [00:04:37] matanya: :-( [00:08:21] i'm still testing, don't worry in that front, just my day-by-day is done wikitext [00:08:44] 3VisualEditor / 3Editing Tools: VisualEditor: ”Use an Existing Reference“ button should be inactive if there are no references to add (the internal list is empty) - 10https://bugzilla.wikimedia.org/70611#c5 (10Alex Monk) 5ASSI>3RESO/FIX This bug is about a very specific way to break the existing disablin... [00:12:12] James_F, do we have any existing examples of widget/dialog code reaching out to disable associated tools? [00:23:00] 3VisualEditor / 3Editing Tools: VisualEditor: ”Use an Existing Reference“ button should be inactive if there are no references to add (the internal list is empty) - 10https://bugzilla.wikimedia.org/70611#c6 (10Alex Monk) (Opened bug 70640 for that) [00:23:03] 3VisualEditor / 3Editing Tools: Disable "Re-use" button under Cite tools when there's nothing to re-use - 10https://bugzilla.wikimedia.org/70640 (10Alex Monk) 3ASSI p:3Unprio s:3normal a:3None The same as we do for the "Use an existing reference" button in the reference dialog, per Rummana in bug 706... [00:31:08] (03PS4) 10Esanders: Data model implementation for tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [00:34:39] (03PS4) 10Esanders: ContentEditable implementation for tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [00:34:41] (03PS4) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [00:34:43] (03PS4) 10Esanders: Custom sub-toolbar for table tools. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159316 (owner: 10Oliverb) [00:34:45] (03PS4) 10Esanders: Icons and tools for table manipulations. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159313 (owner: 10Oliverb) [00:34:47] (03PS4) 10Esanders: Actions for manipulating tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [00:34:49] (03PS4) 10Esanders: I18n for table tools. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159314 (owner: 10Oliverb) [00:37:02] (03CR) 10jenkins-bot: [V: 04-1] Icons and tools for table manipulations. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159313 (owner: 10Oliverb) [00:37:10] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [00:37:12] (03CR) 10jenkins-bot: [V: 04-1] ContentEditable implementation for tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [00:37:35] (03CR) 10jenkins-bot: [V: 04-1] Custom sub-toolbar for table tools. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159316 (owner: 10Oliverb) [00:37:41] (03CR) 10jenkins-bot: [V: 04-1] Actions for manipulating tables. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [00:38:58] (03CR) 10jenkins-bot: [V: 04-1] I18n for table tools. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159314 (owner: 10Oliverb) [00:39:17] 3VisualEditor / 3Editing Tools: Disable "Re-use" button under Cite tools when there's nothing to re-use - 10https://bugzilla.wikimedia.org/70640 (10James Forrester) p:5Unprio>3High a:3Alex Monk [03:58:56] (03PS5) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [03:58:58] (03PS5) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [03:59:00] (03PS5) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [03:59:02] (03PS5) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [04:01:39] (03Abandoned) 10Esanders: I18n for table tools. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159314 (owner: 10Oliverb) [04:02:05] (03Abandoned) 10Esanders: Custom sub-toolbar for table tools. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159316 (owner: 10Oliverb) [04:02:09] (03CR) 10jenkins-bot: [V: 04-1] ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [04:02:11] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [04:02:21] (03Abandoned) 10Esanders: Icons and tools for table manipulations. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159313 (owner: 10Oliverb) [04:02:29] (03CR) 10jenkins-bot: [V: 04-1] Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [04:52:32] (03PS6) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [04:52:34] (03PS6) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [04:52:36] (03PS6) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [04:52:37] (03PS6) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [04:54:47] (03CR) 10jenkins-bot: [V: 04-1] Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [04:54:55] (03CR) 10jenkins-bot: [V: 04-1] ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [04:55:19] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [05:18:46] 3MediaWiki extensions / 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - 10https://bugzilla.wikimedia.org/35342 (10Nemo) [05:19:31] (03PS7) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [05:19:33] (03PS7) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [05:21:46] (03CR) 10jenkins-bot: [V: 04-1] Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [05:21:53] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [05:40:59] (03PS7) 10Mooeypoo: Implement new 'autovalue' parameter property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) [05:43:06] (03PS7) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [05:43:08] (03PS7) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [05:43:10] (03PS8) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [05:43:12] (03PS8) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [05:43:14] (03PS1) 10Esanders: Add containsRange method to ve.Range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159453 [05:46:22] (03CR) 10jenkins-bot: [V: 04-1] Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [05:46:28] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [06:29:44] 3VisualEditor / 3ContentEditable: VisualEditor: Alt + any key in a slug introduces a pawn in Firefox on Windows - 10https://bugzilla.wikimedia.org/58675 (10Amir E. Aharoni) [08:59:15] (03CR) 10Oliverb: "We should not apply this patch, but rather take is as a start for discussion how to prevent implicit structural table changes:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [09:19:41] I have a question concerning Visual Editor gadgets [09:54:01] yes? [10:03:52] hello [10:12:56] Krenair: do you happen to be around? [10:33:35] (03CR) 10Alex Monk: Add containsRange method to ve.Range (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159453 (owner: 10Esanders) [10:49:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf20] The notification dialog is appearing little bigger in test2 and there is a big empty space in it - 10https://bugzilla.wikimedia.org/70423 (10Elitre) [10:49:44] 3VisualEditor: VisualEditor: The Field description popup looks weird on mediawiki.org - 10https://bugzilla.wikimedia.org/70604 (10Elitre) [13:37:00] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf20] The notification dialog is appearing little bigger in test2 and there is a big empty space in it - 10https://bugzilla.wikimedia.org/70423#c8 (10Alex Monk) *** Bug 70604 has been marked as a duplicate of this bug. *** [13:37:00] 3VisualEditor: VisualEditor: The Field description popup looks weird on mediawiki.org - 10https://bugzilla.wikimedia.org/70604#c2 (10Alex Monk) 5NEW>3RESO/DUP My patch for bug 70423 seems to fix this. *** This bug has been marked as a duplicate of bug 70423 *** [13:37:31] thanks for patching that :) [13:41:29] 3OOjs UI: VisualEditor: [Regression wmf20] Popups sizing broken - 10https://bugzilla.wikimedia.org/70423 (10Alex Monk) [13:42:41] Elitre, you're welcome. I just tested the patch on MediaWiki.org (via editing the source in dev tools), it definitely seems to fix the issue [13:42:57] Krenair: if the product has changed (OOjs UI) do we still need to keep the VisualEditor: prefix in the bug title? [13:43:04] I was just wondering that. [13:43:57] Heh. Looking at https://bugzilla.wikimedia.org/buglist.cgi?component=General&list_id=343170&product=OOjs%20UI&query_format=advanced, it's only stuff that I moved in which have the 'VisualEditor:' prefix there [13:44:29] 3OOjs UI: OOjs UI: [Regression wmf20] Popups sizing broken - 10https://bugzilla.wikimedia.org/70423 (10Alex Monk) [13:44:36] Krenair: do you happen to have data about MSIE 11 usage on our sites? I couldn't find anything. [13:45:43] 3OOjs UI: OOjs UI: MenuWidget does not defer label fitting long enough for TextInputMenuWidget when it first opens - 10https://bugzilla.wikimedia.org/67385 (10Alex Monk) [13:45:46] Not sure about whether I should keep the [regression wmf20] bit either, but I'll leave it for now [13:45:52] Elitre, nope, sorry. [13:45:57] I'd need to mention that and don't want to rely on anecdotes :/ [13:47:29] 3OOjs UI: OOjs UI: In certain situations involving StackLayouts, removing items scrolls the focus up to the top - 10https://bugzilla.wikimedia.org/62420 (10Alex Monk) [13:47:56] Elitre, let's see what I can find though [13:48:55] Krenair: thanks! [13:52:19] Elitre, hm. https://stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm says nothing about it :/ [13:54:21] I wonder if Ironholds knows where to find that info [13:54:24] Krenair: it looks like IE 11 is not being detected [13:54:30] Krenair: but you can look for Trident 7 instead [13:54:42] yeah, that's my problem. with all this user agent spoofing going on... [13:54:45] (IE 11's user agent string is something like "Mozilla/5.0 (Windows NT 6.3; Trident/7.0; rv 11.0) like Gecko") [13:54:57] (which doesn't even mention IE, only "Trident") [13:55:03] Trident 7.0 11,757 M [13:56:14] so, this many requests with IE 11. for comparison, "Chrome 57,548 M" and "MSIE 14,888 M" (all other IE versions) [13:56:26] Elitre: ^ [13:57:08] which would mean less than 0,02% of all requests? [13:57:47] noooo, more like ~5% [13:58:37] IE 11 is probably counted towards the total of some other browser, and i don't know which one [13:59:00] might be mozilla, but who knows [13:59:22] Heh, looks like the IE11 user agent was bypassing VE detection as well - https://gerrit.wikimedia.org/r/#/c/155797/ [13:59:58] Krenair: yes, and also jquery.client. i know because i fixed that ;) [14:02:46] i bet opera 15+ is also miscounted as chrome [14:02:51] someone should file bugs about this [14:03:05] "Agent string contains any of the following terms (last upd: March 2012 ):" [14:03:25] let's hope that's not accurate :) [14:07:34] oh, it's already filed. https://bugzilla.wikimedia.org/show_bug.cgi?id=64125 [14:08:10] MatmaRex: I'm not sure we can make the comparison you made above. If all Trident are IE, we get to 27,385M, which is way more than 14,888M? Probably we're not really comparing all requests here? [14:08:23] https://en.wikipedia.org/wiki/Usage_share_of_web_browsers#Wikimedia_.28April_2009_to_present.29 [14:08:28] "Note�: Wikimedia has recently had a large percentage of unrecognised browsers, previously counted as Firefox, that are now assumed to be Internet Explorer 11 fixed ONLY for February 2014 numbers. And February 2014 numbers include mobile for Internet Explorer and Firefox (not included in Android). Chrome does not include mobile numbers (Android does)." [14:10:04] I... never expect to find similar answers on Wikipedia. [14:10:35] Elitre: the "MSIE 14,888 M" doesn't include IE 11 due to this bug [14:10:48] "27,385 M" for Trident does [14:11:19] Elitre: 14,888 (MSIE) + 11,757 (Trident 7.0) just about adds up to 27,385 (total Trident) [14:13:30] (i can't explain the missing 0,74; might be caused by browsers poorly pretending to be IE, or internet pixies) [14:14:08] yup, thanks. [16:34:37] Elitre, MatmaRex, Krenair: Yes, we've been going ahead with 5.6% for IE11 (in comparison, it's 5.5% for all tablet users). [16:35:10] (Hey.) [16:35:19] Hi. [16:35:26] Looks like no needcheck errors today... [16:35:31] Amazing. [16:35:45] Eh. It happens sometimes. [16:43:52] James_F, Roan and Trevor are back today, right? [16:44:03] Krenair: Hopefully. [16:44:08] Heh. [16:44:51] I'd quite like https://gerrit.wikimedia.org/r/#/c/159062/ to be reviewed and put into wmf20 before the deployment tomorrow [16:46:44] (03PS9) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [16:46:46] (03PS9) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [16:47:09] Assuming it's sane. And I think it is. [16:47:18] Otherwise we can just revert the breaking patch :p [16:48:31] <_ob> edsanders: hey... how is it going? [16:48:40] _ob, Hi! [16:48:44] good [16:48:57] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [16:49:03] Krenair: Yeah, I'm waiting for Roan to get in to review it. :-) [16:50:13] Been fixing up your code, mostly code style and a few obvious issues [16:50:33] <_ob> ok... let me know if I can be helpful... [16:50:40] for example I had to move the table overaly out of the CE (otherwise it interferes with our getOffset functions) [16:50:54] feel free to check it out and see if there's anything you think I've broken [16:51:07] <_ob> ok.. will do [16:51:39] I'm also trying to keep styling minimal and as close to the view mode as possible, so I removed the table centring for example [16:52:27] <_ob> of course, all styling is eventually up to you [16:52:38] will give it a second pass with RoanKattouw_away later - might move some of the Matrix stuff around and refactor a bit more [16:52:52] <_ob> ok... [16:52:55] also TrevorP|Away probably has some ideas on the toolbar [16:53:21] might move the controls inline instead of using a toolbar [16:53:54] <_ob> maybe... but consider the nested table situation... inline might be tight [16:53:56] and would like to sort out what happens when you press delete/cut/copy [16:54:22] <_ob> it is actually in ce.Surface... deleting directly on data... [16:54:23] well - around the table [16:54:39] like where the rulers are [16:56:10] I also want to refactor the overlay code, because we're now duplicating a lot of the logic from FocusableNode [16:56:26] might make a base class called OverlayNode or something [16:56:36] <_ob> sonds promising [17:12:18] (03CR) 10Catrope: [C: 032] PopupWidget: Toggle clipping -after- updating dimensions [oojs/ui] - 10https://gerrit.wikimedia.org/r/159062 (https://bugzilla.wikimedia.org/70423) (owner: 10Alex Monk) [17:13:28] (03Merged) 10jenkins-bot: PopupWidget: Toggle clipping -after- updating dimensions [oojs/ui] - 10https://gerrit.wikimedia.org/r/159062 (https://bugzilla.wikimedia.org/70423) (owner: 10Alex Monk) [17:16:44] 3OOjs UI: OOjs UI: [Regression wmf20] Popups sizing broken - 10https://bugzilla.wikimedia.org/70423 (10Alex Monk) 5PATC>3RESO/FIX [17:20:41] <_ob> edsanders: Just saw ... the overlay needs to be updated when a slug is in a cell and gets expanded/collapsed... [17:21:15] <_ob> ...see in the nested table example, delete a nested table... [17:23:01] yes [17:23:25] we emit position events after the slug expands but its not working for some reason [17:25:18] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (f9c217dfa4) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159501 [17:25:49] hm, the problem is we only reposition after that event, not resize [17:35:49] _ob, ah, we were only emitting a 'position' event after blurring a slug, because previously it was not possible to focus a slug and have an overlay visible [17:35:51] edsanders: Won't that be expensive? [17:36:25] We're already doing getClientRects, which gets you the size and position [17:37:27] (03PS8) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [17:37:29] (03PS10) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [17:37:31] (03PS10) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [17:38:42] <_ob> ok, understand [17:39:45] edsanders: https://gerrit.wikimedia.org/r/#/q/I77f667b1eadc49096f2312a55157c070376be61e,n,z [17:40:23] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [17:42:08] (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.1.0-pre (f9c217dfa4) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159501 (owner: 10Jforrester) [17:43:14] <_ob> edsanders: sometimes timing problem... the last overlay update not after the animation is finished [17:44:08] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (f9c217dfa4) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159501 (owner: 10Jforrester) [17:44:17] <_ob> noob alert: is it possible to retrigger the event after animation is finished? [17:44:20] _ob, yes we have that problem with focusable nodes too. [17:45:11] the only real solution is to go back to having overlays inline in the CE [17:45:16] but that has so many problems [17:46:22] for example if you're trying to draw a highlight over an image, you can't append to the image, because image is a leaf node [17:46:35] so you end up having to wrap the image, which causes other horrible rendering issues [17:46:40] <_ob> hmpf... overlays are evil ;) [17:47:00] yes, we used to do it like that so we've learnt the hard way [17:47:18] we emit the event 200ms after it starts, which matches the CSS transition [17:47:55] we've talked about better ways of sharing that '200' value because we use the same technique in other places, e.g. event after a dialog as finished animating open [17:48:32] either using computed CSS (which is slow), or declaring it in a skin JS file, from which we compile the CSS [17:49:49] <_ob> found that: $("#someSelector").bind("transitionend webkitTransitionEnd oTransitionEnd MSTransitionEnd", function(){ ... }); [17:57:47] 3VisualEditor / 3ContentEditable: VisualEditor: Tab/Shift-Tab behaviour in other contexts (and tables) - 10https://bugzilla.wikimedia.org/70665 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3None Current (Shift+)Tab (De-)indents a list item, but in any other context it falls back to native behaviour and... [18:03:29] 3VisualEditor / 3ContentEditable: VisualEditor: Tab/Shift-Tab behaviour in other contexts (and tables) - 10https://bugzilla.wikimedia.org/70665#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High (In reply to Ed Sanders from comment #0) > Current (Shift+)Tab (De-)indents a list item, but in any other c... [18:06:53] (03PS1) 10Catrope: PopupWidget: Toggle clipping -after- updating dimensions [oojs/ui] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159508 (https://bugzilla.wikimedia.org/70423) [18:07:08] (03CR) 10Catrope: [C: 032] PopupWidget: Toggle clipping -after- updating dimensions [oojs/ui] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159508 (https://bugzilla.wikimedia.org/70423) (owner: 10Catrope) [18:08:59] (03CR) 10Catrope: [V: 032] PopupWidget: Toggle clipping -after- updating dimensions [oojs/ui] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159508 (https://bugzilla.wikimedia.org/70423) (owner: 10Catrope) [18:09:15] 3OOjs UI: OOjs UI: [Regression wmf20] Popups sizing broken - 10https://bugzilla.wikimedia.org/70423 (10James Forrester) 5PATC>3RESO/FIX [18:15:05] Hey Krenair [18:16:01] Hi ryasmeen [18:16:42] So I was checking all the notification dialog sizing issue and I see that the help tooltips in the Page Options dialog are still kind of un-styled [18:17:02] un-styled? [18:17:08] yeah [18:17:13] like they are too wrapped around the text [18:17:26] There are issues when they are near the edge of the dialog [18:17:43] I though that your fix is going to resolve that too, so I did not open any separate bug. [18:17:48] Do you think I should? [18:18:13] I think my fix is going to resolve one issue with those [18:18:34] yeah, also for the field show the table of contents it is wrongly aligned and getting cut off at the left edge [18:28:26] Hi James_F, thanks for the info about IE. [18:35:15] (03CR) 10Esanders: "Mobile uses a different context, so this doesn't even improve functionality there, it just adds a useless feature to desktop and makes it " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150194 (owner: 10Esanders) [18:38:34] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf20] Toolbar in mobile got squished in Betalabs and test2 both in desktop and iOS Safari - 10https://bugzilla.wikimedia.org/70430#c1 (10Roan Kattouw) 5ASSI>3RESO/FIX Fixed in https://gerrit.wikimedia.org/r/#/c/159243/ [18:52:56] (03PS1) 10Esanders: Rangy's dead honey, rangy's dead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159521 [18:55:30] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf21] Checking "Border" in media settings dialog is not enabling "Apply changes" button - 10https://bugzilla.wikimedia.org/70575 (10Roan Kattouw) 5NEW>3ASSI a:3Roan Kattouw [18:55:45] 3VisualEditor / 3Editing Tools: VisualEditor: After removing the Template:Top,trying to place cursor on content throws TypeError: Cannot read property 'Left'/'right'/'start' of null - 10https://bugzilla.wikimedia.org/70571 (10Roan Kattouw) 5NEW>3ASSI a:3Roan Kattouw [18:59:25] (03CR) 10Jforrester: [C: 04-1] "git rm lib/rangy" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159521 (owner: 10Esanders) [19:00:58] (03PS2) 10Esanders: Rangy's dead honey, rangy's dead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159521 [19:01:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] Checking "Border" in media settings dialog is not enabling "Apply changes" button - 10https://bugzilla.wikimedia.org/70575 (10James Forrester) p:5Unprio>3Normal s:5normal>3minor [19:01:29] 3VisualEditor / 3Data Model: VisualEditor: After removing the Template:Top,trying to place cursor on content throws TypeError: Cannot read property 'Left'/'right'/'start' of null - 10https://bugzilla.wikimedia.org/70571 (10James Forrester) p:5Unprio>3Low [19:02:56] (03CR) 10Catrope: [C: 032] "Thanks for cleaning this up!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159021 (owner: 10Legoktm) [19:04:40] (03Merged) 10jenkins-bot: Make message loading for 'ext.visualEditor.viewPageTarget.init' module less hacky [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159021 (owner: 10Legoktm) [19:07:23] (03CR) 10Catrope: [C: 032] Update LinkCache in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159418 (https://bugzilla.wikimedia.org/69886) (owner: 10Alex Monk) [19:08:12] (03PS1) 10Jforrester: Fix copyright notice in VisualEditorViewPageTargetInitModule.php header [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159530 [19:09:06] (03Merged) 10jenkins-bot: Update LinkCache in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159418 (https://bugzilla.wikimedia.org/69886) (owner: 10Alex Monk) [19:11:45] 3OOjs UI: OOjs UI: [Regression wmf20] Popups sizing broken - 10https://bugzilla.wikimedia.org/70423#c12 (10Rummana Yasmeen) verified the fix in Betalabs,separate bug has been filed for the help tooltips for Page Settings menu. [19:12:30] 3VisualEditor / 3MediaWiki integration: VisualEditor: LinkCache should also cache mw-redirect and mw-disambig statuses - 10https://bugzilla.wikimedia.org/70674 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3Alex Monk … and use them. [19:12:39] (03CR) 10Catrope: [C: 04-1] "Yeah there should be a better way of doing this. Let's discuss this with Ed" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159006 (https://bugzilla.wikimedia.org/70365) (owner: 10Alex Monk) [19:12:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: LinkCache should also cache mw-redirect and mw-disambig statuses - 10https://bugzilla.wikimedia.org/70674 (10James Forrester) p:5Unprio>3Normal [19:12:59] 3VisualEditor / 3MediaWiki integration: VisualEditor: Populate LinkCache from MWLinkTargetInputWidget etc - 10https://bugzilla.wikimedia.org/69886#c7 (10James Forrester) 5PATC>3ASSI Now just waiting for category existence checking, I believe? [19:13:45] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf20] Toolbar in mobile got squished in Betalabs and test2 both in desktop and iOS Safari - 10https://bugzilla.wikimedia.org/70430 (10James Forrester) a:3Ed Sanders [19:16:02] 3MediaWiki / 3Page editing: AbuseFilter is overridden when creating a blank page - 10https://bugzilla.wikimedia.org/70675 (10Sorawee Porncharoenwase) 3NEW p:3Unprio s:3normal a:3None In Thai Wikipedia, we have a filter[1] preventing creating pages which are too short. It works fine in all cases excep... [19:21:47] 3OOjs UI: OOjs UI: The help texts in the tooltips of Page Settings menu looks crunched inside the pop-up - 10https://bugzilla.wikimedia.org/70677 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16429 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16429&action=edit Screen... [19:22:15] 3OOjs UI: OOjs UI: The help texts in the tooltips of Page Settings menu looks crunched inside the pop-up - 10https://bugzilla.wikimedia.org/70677 (10Rummana Yasmeen) 5NEW>3ASSI a:3Roan Kattouw [19:22:41] (03PS3) 10Esanders: Rangy's dead honey, rangy's dead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159521 [19:30:42] (03CR) 10Catrope: [C: 04-1] Split getSelectionRect into bounding and inline (037 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158523 (owner: 10Esanders) [19:34:29] RoanKattouw: thanks! [19:34:58] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf20] Toolbar in mobile got squished in Betalabs and test2 both in desktop and iOS Safari - 10https://bugzilla.wikimedia.org/70430#c2 (10Rummana Yasmeen) Verified the fix in Betalabs [19:38:02] 3MediaWiki extensions / 3WikiEditor: If the browser set to 90% (zoom), the icons for 'bold', 'italics' etc. becomes... weirdly placed - 10https://bugzilla.wikimedia.org/70679 (10Jonatan Svensson Glad (Josve05a)) 3NEW p:3Unprio s:3normal a:3None Created attachment 16430 --> https://bugzilla.wikimedi... [19:41:29] 3MediaWiki extensions / 3WikiEditor: If the browser set to 90% (zoom), the icons for 'bold', 'italics' etc. becomes... weirdly placed - 10https://bugzilla.wikimedia.org/70679 (10Jonatan Svensson Glad (Josve05a)) [19:46:14] (03CR) 10Catrope: [C: 031] "Code looks good, but I should test this in IE" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158893 (owner: 10Esanders) [19:52:39] (03CR) 10Catrope: [C: 04-1] "Minor comment inline. Code looks good otherwise, but I need to test this in IE." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159160 (owner: 10Esanders) [20:01:43] (03CR) 10Catrope: [C: 031] "Looks good, but needs IE testing" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159521 (owner: 10Esanders) [20:06:01] 3VisualEditor / 3Mobile: VisualEditor Mobile: The link target suggestion drop down is appearing cut off to a very small size upon first time opening the link inspector - 10https://bugzilla.wikimedia.org/70683 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16432 --> https://... [20:07:15] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf20]The link target suggestion drop down is appearing cut off to a very small size upon first time opening the link inspector - 10https://bugzilla.wikimedia.org/70683 (10Rummana Yasmeen) [21:36:55] (03CR) 10Catrope: [C: 032] Fix copyright notice in VisualEditorViewPageTargetInitModule.php header [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159530 (owner: 10Jforrester) [21:38:36] (03Merged) 10jenkins-bot: Fix copyright notice in VisualEditorViewPageTargetInitModule.php header [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159530 (owner: 10Jforrester) [21:41:00] (03CR) 10Legoktm: Fix copyright notice in VisualEditorViewPageTargetInitModule.php header (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159530 (owner: 10Jforrester) [21:42:02] (03CR) 10Jforrester: Fix copyright notice in VisualEditorViewPageTargetInitModule.php header (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159530 (owner: 10Jforrester) [21:46:55] (03CR) 10Esanders: Split getSelectionRect into bounding and inline (036 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158523 (owner: 10Esanders) [21:48:41] (03CR) 10Esanders: Split getSelectionRect into bounding and inline (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158523 (owner: 10Esanders) [21:49:20] (03PS4) 10Esanders: Rangy's dead honey, rangy's dead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159521 [21:49:22] (03PS3) 10Esanders: Kill rangy (almost) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158893 [21:49:24] (03PS6) 10Esanders: Split getSelectionRect into bounding and inline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158523 [21:49:26] (03PS2) 10Esanders: Kill rangy: Vol. 2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159160 [21:51:30] (03CR) 10jenkins-bot: [V: 04-1] Rangy's dead honey, rangy's dead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159521 (owner: 10Esanders) [21:54:29] (03CR) 10Esanders: Kill rangy: Vol. 2 (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159160 (owner: 10Esanders) [21:58:35] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159521 (owner: 10Esanders) [21:59:52] (03CR) 10Jforrester: [C: 031] "All Roan's issues addressed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158523 (owner: 10Esanders) [22:02:15] 3VisualEditor / 3Editing Tools: VisualEditor: Search results (for links, redirects, categories…) should select the exact match by default - 10https://bugzilla.wikimedia.org/69716 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [22:11:32] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf20] The link target suggestion drop down is appearing cut off to a very small size upon first time opening the link inspector - 10https://bugzilla.wikimedia.org/70683 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Ed Sanders [22:17:28] (03PS1) 10Alex Monk: Refactor a bunch of CategoryInputWidget code, tear out dead/broken redirect handling that should be rewritten [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159623 (https://bugzilla.wikimedia.org/69886) [22:18:06] James_F, is Roan around? [22:19:16] (03CR) 10jenkins-bot: [V: 04-1] Refactor a bunch of CategoryInputWidget code, tear out dead/broken redirect handling that should be rewritten [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159623 (https://bugzilla.wikimedia.org/69886) (owner: 10Alex Monk) [22:21:02] Extra space in front of a comment, bah. Ty jenkins [22:21:26] (03PS2) 10Alex Monk: Refactor a bunch of CategoryInputWidget code, tear out dead/broken redirect handling that should be rewritten [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159623 (https://bugzilla.wikimedia.org/69886) [22:22:41] Krenair: Hey sorry I'm here now [22:22:52] I dropped my phone at Disneyland so I had to go to a phone store to get the screen replaced [22:23:00] :) [22:23:43] So I mentioned https://bugzilla.wikimedia.org/show_bug.cgi?id=70640 earlier [22:23:57] Yeah [22:24:02] I made the bug mainly because I've never touched the Tool stuff before and wasn't sure we could easily fit that into the current system. [22:24:09] Then it got assigned to me. Yay. [22:25:05] Right [22:25:15] So, what I was trying to say in the standup is this [22:25:19] We already have a bunch of code around the reference dialog and reference search widget to determine this stuff for the button in the ref dialog [22:25:48] Right now we don't have individual tools listen for events and updating themselves, instead tools have onUpdateState() which gets called by the toolbar in response to certain events [22:26:01] I think this is probably something that should be reconsidered in the long term [22:26:41] But in any case, it should mean that making the tool disable itself should be a simple matter of checking whether it should be enabled or disabled in onUpdateState(), and relying on the toolbar to call that method frequently enough (which I think it already does) [22:27:11] (In fact I've seen traces suggesting we call onUpdateState() on every tool like 3 times per transaction, which I should investigate at some point) [22:27:54] Ahh okay. When you said that earlier I assumed you were talking about the ref search index. :) [22:29:02] Oh sorry [22:29:05] Yeah that one has similar problems [22:29:14] But not quite on an institutional scale like the toolbar does :) [22:29:19] right [22:29:25] I'm guessing we can't simply call into the reference dialog or widgets from the Tool [22:29:57] No let's not do that [22:30:47] Hmm so yeah I guess we'd need a place in DM land (as opposed to UI widgets/dialogs/tools) where this stuff is computed and cached so we can access it from all those places [22:32:10] (03CR) 10Catrope: [C: 031] Split getSelectionRect into bounding and inline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158523 (owner: 10Esanders) [22:33:18] (03CR) 10Catrope: [C: 031] Kill rangy: Vol. 2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159160 (owner: 10Esanders) [22:33:31] (03CR) 10Catrope: Kill rangy: Vol. 2 (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159160 (owner: 10Esanders) [22:52:37] RoanKattouw, I'm wondering how best to do that... [22:54:14] Krenair: How much of this stuff is already in dm.InternalList? [22:55:13] hmm [22:56:31] it looks like we just need part of MWReferenceSearchWidget#setInternalList that just looks through the result of internalList.getNodeGroups() [22:58:16] 3VisualEditor / 3ContentEditable: VisualEditor: ContextItemWidget's "edit" label should be a sibling of the description - 10https://bugzilla.wikimedia.org/70691 (10James Forrester) 3ASSI p:3Unprio s:3normal a:3None Per Ed: | FIXME: This should be a sibling of the description label, with enough space... [22:58:44] 3VisualEditor / 3ContentEditable: VisualEditor: ContextItemWidget's "edit" label should be a sibling of the description - 10https://bugzilla.wikimedia.org/70691 (10James Forrester) p:5Unprio>3Normal [23:00:11] * Krenair tries it [23:07:05] (03PS5) 10Esanders: Rangy's dead honey, rangy's dead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159521 [23:07:07] (03PS4) 10Esanders: Kill rangy (almost) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158893 [23:07:09] (03PS7) 10Esanders: Split getSelectionRect into bounding and inline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158523 [23:07:11] (03PS3) 10Esanders: Kill rangy: Vol. 2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159160 [23:07:16] RoanKattouw, heh, okay. [23:07:18] It works. [23:07:24] I have no idea if it's quick enough, but it works. [23:08:16] (03PS1) 10Alex Monk: Disable re-use citation tool if there are no references in the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159628 (https://bugzilla.wikimedia.org/70640) [23:09:59] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] In Safari, Cannot enter any input in any dialog and VE gets unresponsive after trying to do that - 10https://bugzilla.wikimedia.org/70578 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [23:12:12] Krenair: Looks fine, just put a blank line between the static properties and your new method please [23:16:24] (03PS2) 10Alex Monk: Disable re-use citation tool if there are no references in the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159628 (https://bugzilla.wikimedia.org/70640) [23:17:03] (03PS6) 10Esanders: Rangy's dead honey, rangy's dead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159521 [23:17:05] (03PS5) 10Esanders: Kill rangy (almost) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158893 [23:17:07] (03PS8) 10Esanders: Split getSelectionRect into bounding and inline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158523 [23:17:09] (03PS4) 10Esanders: Kill rangy: Vol. 2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159160 [23:25:59] RoanKattouw, XOOXXXOOOXXXOOOXXXOOOXXXOOXXXOOOXXXOOOXXXOOOXXXOOOXXXOOXXXOOOXXXOOOXXXOOXOOXXXOOOXXXOOOXXXOOOXXXOOXXX [23:27:45] edsanders: Dude on the way back from LA there was a car that passed us like three times and its license plate was XOXO 4♡ [23:27:59] maybe it's a message [23:29:12] Well I passed them on the right when they were camping in the left lane, so I guess I didn't return the sentiment [23:40:16] For fun times, cursor through this CE in Chrome, and observe when you get a meaningful client rectangle, and when you get garbage (0,0,0,0): http://jsfiddle.net/48hu6psf/5/ [23:41:04] edsanders: That's going in my browser bugs tlak