[00:06:59] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] Checking "Border" in media settings dialog is not enabling "Apply changes" button - 10https://bugzilla.wikimedia.org/70575#c1 (10Roan Kattouw) This is due to an OOjs bug. >>> OO.compare( { foo: 3 }, { foo: 4 } ) false >>> OO.compare( { fo... [00:24:41] (03PS1) 10Jforrester: oo.compare: Cover boolean as well as number and string primitives [oojs/core] - 10https://gerrit.wikimedia.org/r/159639 [00:27:20] (03CR) 10Catrope: [C: 032] oo.compare: Cover boolean as well as number and string primitives [oojs/core] - 10https://gerrit.wikimedia.org/r/159639 (owner: 10Jforrester) [00:27:47] James_F, I don't think I've ever actually clicked on 'Included in' before. [00:27:52] That's really useful. [00:27:56] Krenair: It is, yeah. [00:27:59] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] Checking "Border" in media settings dialog is not enabling "Apply changes" button - 10https://bugzilla.wikimedia.org/70575#c2 (10Roan Kattouw) Should be fixed by https://gerrit.wikimedia.org/r/#/c/159639/ [00:30:13] (03Merged) 10jenkins-bot: oo.compare: Cover boolean as well as number and string primitives [oojs/core] - 10https://gerrit.wikimedia.org/r/159639 (owner: 10Jforrester) [00:30:41] (03PS1) 10Esanders: [BREAKING CHANGE] Create ve.dm.Focusable and store focusable flag there [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159640 [00:31:54] (03PS1) 10Jforrester: Tag v1.1.1 [oojs/core] - 10https://gerrit.wikimedia.org/r/159641 [00:31:58] RoanKattouw: ^^^ [00:32:19] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Create ve.dm.Focusable and store focusable flag there [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159640 (owner: 10Esanders) [00:32:33] (03PS1) 10Esanders: Add bew ve.dm.FocusableNode mixin where required [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159642 [00:33:31] (03CR) 10jenkins-bot: [V: 04-1] Add bew ve.dm.FocusableNode mixin where required [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159642 (owner: 10Esanders) [00:33:36] (03PS2) 10Esanders: Add new ve.dm.FocusableNode mixin where required [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159642 [00:34:33] (03CR) 10jenkins-bot: [V: 04-1] Add new ve.dm.FocusableNode mixin where required [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159642 (owner: 10Esanders) [00:36:19] (03CR) 10Catrope: [C: 032] Tag v1.1.1 [oojs/core] - 10https://gerrit.wikimedia.org/r/159641 (owner: 10Jforrester) [00:39:26] (03Merged) 10jenkins-bot: Tag v1.1.1 [oojs/core] - 10https://gerrit.wikimedia.org/r/159641 (owner: 10Jforrester) [00:42:23] [13oojs.github.io] 15jdforrester created 06release-1.1.1 (+1 new commit): 02https://github.com/oojs/oojs.github.io/commit/46303eaf426f [00:42:24] 13oojs.github.io/06release-1.1.1 1446303ea 15James D. Forrester: Publish v1.1.1 release from npm [00:44:59] (03PS1) 10Jforrester: Update OOjs to v1.1.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159647 [00:47:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] Checking "Border" in media settings dialog is not enabling "Apply changes" button - 10https://bugzilla.wikimedia.org/70575#c3 (10James Forrester) 5ASSI>3RESO/FIX a:5Roan Kattouw>3James Forrester Released in OOjs 1.1.1, now in MW-cor... [00:48:25] (03PS7) 10Esanders: Rangy's dead honey, rangy's dead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159521 [00:49:41] edsanders: https://gerrit.wikimedia.org/r/159647 and https://gerrit.wikimedia.org/r/159646 please. [00:56:23] (03PS1) 10Jforrester: Update OOjs to v1.1.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/159648 [00:58:40] (03CR) 10Esanders: [C: 032] Update OOjs to v1.1.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159647 (owner: 10Jforrester) [00:59:09] (03CR) 10Esanders: [C: 032] Update OOjs to v1.1.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/159648 (owner: 10Jforrester) [01:00:10] (03Merged) 10jenkins-bot: Update OOjs to v1.1.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159647 (owner: 10Jforrester) [01:00:12] (03Merged) 10jenkins-bot: Update OOjs to v1.1.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/159648 (owner: 10Jforrester) [01:41:54] James_F, RoanKattouw http://masonry.desandro.com/ <-- Masonry fit library. Seems to work. I've ran some tests, the examples work cross-browser, mobile, and rtl. Also has tons of features to choose from. [01:42:16] code's in github under MIT license https://github.com/desandro/masonry [01:42:53] Nice [01:43:06] Let's run it by Trevor tomorrow too, but if it does what we need it's probably worth it [01:43:48] In general with 3rd party libraries I just want to make sure that we're not trying to use a jet engine to power a golf cart [01:44:00] or [01:49:07] RoanKattouw, yeah. This one seems to be fairly cool so far. It also rearranges its boxes on resize, and you can choose types of order. [01:49:32] Just worth considering, it also seems to be maintained (last commit was 21 days ago) [02:07:49] (03PS1) 10Jforrester: Update VE core submodule to master (216941c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159657 [02:08:01] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (216941c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159657 (owner: 10Jforrester) [02:08:06] (03CR) 10Catrope: [C: 032] Split getSelectionRect into bounding and inline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158523 (owner: 10Esanders) [02:08:17] (03CR) 10Catrope: [C: 032] Kill rangy (almost) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158893 (owner: 10Esanders) [02:08:24] (03CR) 10Catrope: [C: 032] Kill rangy: Vol. 2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159160 (owner: 10Esanders) [02:08:43] (03CR) 10Catrope: [C: 032] Rangy's dead honey, rangy's dead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159521 (owner: 10Esanders) [02:09:43] (03Merged) 10jenkins-bot: Update VE core submodule to master (216941c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159657 (owner: 10Jforrester) [02:10:12] (03Merged) 10jenkins-bot: Split getSelectionRect into bounding and inline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158523 (owner: 10Esanders) [02:10:18] (03Merged) 10jenkins-bot: Kill rangy (almost) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158893 (owner: 10Esanders) [02:10:26] (03Merged) 10jenkins-bot: Kill rangy: Vol. 2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159160 (owner: 10Esanders) [02:11:10] (03Merged) 10jenkins-bot: Rangy's dead honey, rangy's dead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159521 (owner: 10Esanders) [02:13:29] (03PS1) 10Jforrester: Update VE core submodule to master (1fd23db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159660 [02:15:45] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (1fd23db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159660 (owner: 10Jforrester) [02:17:20] (03Merged) 10jenkins-bot: Update VE core submodule to master (1fd23db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159660 (owner: 10Jforrester) [02:59:15] 3VisualEditor / 3ContentEditable: VisualEditor: Don't use Range.detach (is now a no-op in Chrome per revised DOM spec) - 10https://bugzilla.wikimedia.org/68492#c3 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Low a:3Ed Sanders As we've now dumped Rangy, this is now FIXED. [04:29:58] 3OOjs UI: OOjs UI: [Regression wmf20] Popups sizing broken - 10https://bugzilla.wikimedia.org/70423#c13 (10Rummana Yasmeen) Backport did not work in test2 , the notification dialog and the context dialogs for template fields are still broken there. [10:00:59] 3MediaWiki extensions / 3WikiEditor: If the browser set to 90% (zoom), the icons for 'bold', 'italics' etc. becomes... weirdly placed - 10https://bugzilla.wikimedia.org/70679#c1 (10Andre Klapper) Where can this be seen? URL welcome :) [10:01:14] 3MediaWiki extensions / 3WikiEditor: If browser zoom set to 90%, icons for 'bold', 'italics' etc. become too high or too low - 10https://bugzilla.wikimedia.org/70679 (10Andre Klapper) 5NEW>3UNCO [10:05:15] 3MediaWiki extensions / 3WikiEditor: If Chrome browser zoom set to 90% or less, icon positions too high/low in toolbar - 10https://bugzilla.wikimedia.org/70679#c2 (10Andre Klapper) 5UNCO>3NEW Whoops, I can reproduce with Google Chrome 37 on any page on English Wikipedia. [11:40:26] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [11:41:35] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [12:06:14] 3OOjs UI: OOjs UI: [Regression wmf20] Popups sizing broken - 10https://bugzilla.wikimedia.org/70423#c14 (10Alex Monk) It's working for me... Can you try it without any caching, etc.? Maybe in incognito mode? [12:19:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: LinkCache should also cache mw-redirect and mw-disambig statuses - 10https://bugzilla.wikimedia.org/70674#c1 (10Alex Monk) ... Doesn't it do this already? [13:31:44] 3VisualEditor / 3ContentEditable: ; not recognized as wikitext - 10https://bugzilla.wikimedia.org/69689 (10Deryck Chan) [13:31:44] 3VisualEditor / 3Editing Tools: VisualEditor: Support for definition-lists - 10https://bugzilla.wikimedia.org/37938 (10Deryck Chan) [13:32:59] 3VisualEditor / 3Editing Tools: VisualEditor: Support for definition-lists - 10https://bugzilla.wikimedia.org/37938 (10Deryck Chan) [13:33:00] 3VisualEditor / 3ContentEditable: ; not recognized as wikitext - 10https://bugzilla.wikimedia.org/69689 (10Deryck Chan) [15:09:25] (03PS1) 10Cmcmahon: [BrowserTest] Add @safari and @internet_explorer tags for Jenkins build [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159736 [15:11:21] (03PS2) 10Cmcmahon: [BrowserTest] Add @safari and @internet_explorer tags for Jenkins build [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159736 [15:11:57] (03PS3) 10Cmcmahon: [BrowserTest] Add @safari and @internet_explorer tags for Jenkins build [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159736 [15:18:13] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Add @safari and @internet_explorer tags for Jenkins build [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159736 (owner: 10Cmcmahon) [15:19:56] (03Merged) 10jenkins-bot: [BrowserTest] Add @safari and @internet_explorer tags for Jenkins build [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159736 (owner: 10Cmcmahon) [16:28:27] Jaaaaaames_F, it's brooookennnnnnnn, https://integration.wikimedia.org/ci/job/mwext-UploadWizard-npm/14/console [16:28:49] Oh, because Krinkle|detached merged the jenkins change without the UW change. [16:28:52] Derp [16:30:17] James_F|Away: I guess let's get this merged so I can work on patches again [16:35:26] I guess the file input gets an insane amount of width for some reason [16:40:09] That should do it [17:15:16] 3MediaWiki extensions / 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - 10https://bugzilla.wikimedia.org/35342 (10Bartosz Dziewoński) [17:15:16] 3MediaWiki extensions / 3WikiEditor: If Chrome browser zoom set to 90% or less, icon positions too high/low in toolbar - 10https://bugzilla.wikimedia.org/70679#c3 (10Bartosz Dziewoński) Thanks for the report. This issue also appears to be mentioned on the (very confusingly titled) bug 35342, see bug 35342 c... [17:17:44] 3MediaWiki extensions / 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - 10https://bugzilla.wikimedia.org/35342#c36 (10Bartosz Dziewoński) This bug seems to be tracking at least two or maybe three completely distinct issues, one of which has just been reported as bug 70679. Can anybody s... [17:22:57] (03PS2) 10Esanders: [BREAKING CHANGE] Create ve.dm.Focusable and store focusable flag there [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159640 [17:29:47] 3VisualEditor / 3ContentEditable: VisualEditor: Up/down arrow in Firefox broken after using left/right - 10https://bugzilla.wikimedia.org/70724 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3None 1. place cursor in large body of text in FF 2. Cursor up then down, everything is fine 3. Cursor right a doze... [17:32:14] 3VisualEditor / 3ContentEditable: VisualEditor: Up/down arrow in Firefox broken after using left/right - 10https://bugzilla.wikimedia.org/70724 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [17:40:40] (03CR) 10Catrope: [C: 032] Disable re-use citation tool if there are no references in the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159628 (https://bugzilla.wikimedia.org/70640) (owner: 10Alex Monk) [17:42:27] (03Merged) 10jenkins-bot: Disable re-use citation tool if there are no references in the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159628 (https://bugzilla.wikimedia.org/70640) (owner: 10Alex Monk) [17:44:00] 3VisualEditor / 3Editing Tools: Disable "Re-use" button under Cite tools when there's nothing to re-use - 10https://bugzilla.wikimedia.org/70640 (10James Forrester) 5PATC>3RESO/FIX [17:44:10] (03CR) 10Catrope: [C: 04-1] "Code looks fine, but Alex pointed out a typo in the tests" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159453 (owner: 10Esanders) [17:44:57] (03PS2) 10Jforrester: Add containsRange method to ve.Range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159453 (owner: 10Esanders) [17:45:08] (03CR) 10Jforrester: Add containsRange method to ve.Range (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159453 (owner: 10Esanders) [17:45:17] (03CR) 10Catrope: [C: 032] Add containsRange method to ve.Range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159453 (owner: 10Esanders) [17:47:02] (03Merged) 10jenkins-bot: Add containsRange method to ve.Range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159453 (owner: 10Esanders) [17:48:29] (03PS1) 10Esanders: Convert all instances of assert.equal to assert.strictEqual [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159779 [17:48:31] (03CR) 10jenkins-bot: [V: 04-1] Convert all instances of assert.equal to assert.strictEqual [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159779 (owner: 10Esanders) [17:50:17] 3VisualEditor: VisualEditor: Saving produced a "Something went wrong" generic error message, but it silently and successfully saved the page - 10https://bugzilla.wikimedia.org/70726 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None User:Mike Christie made ten small (often single-character) edits to [[... [17:51:27] (03PS1) 10Esanders: Convert all instances of assert.equal to assert.strictEqual [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159781 [17:51:59] 3VisualEditor / 3MediaWiki integration: VisualEditor: For very large pages on slow connections (when a timeout happens?), users get an "Error: Unknown error" on saving changes (but change is indeed saved) - 10https://bugzilla.wikimedia.org/53093 (10WhatamIdoing) [17:52:13] 3VisualEditor: VisualEditor: Saving produced a "Something went wrong" generic error message, but it silently and successfully saved the page - 10https://bugzilla.wikimedia.org/70726 (10WhatamIdoing) [17:52:14] 3VisualEditor / 3MediaWiki integration: VisualEditor: Saving fails silently when the database is locked - 10https://bugzilla.wikimedia.org/51636 (10WhatamIdoing) [18:00:35] (03PS2) 10Esanders: Convert all instances of assert.equal to assert.strictEqual [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159779 [18:03:00] James_F, edsanders, RoanKattouw: I'm still confused about https://gerrit.wikimedia.org/r/#/c/159453/2/tests/ve.Range.test.js [18:03:12] go in [18:03:14] *on [18:03:18] asserting that it doesn't contain 99, comment is 'doesn\'t contain 50' [18:03:28] checks for 100, comment says 150 [18:03:31] agh [18:03:38] checks for 199, comment says 100. etc. [18:03:55] I fixed that but my commit got wiped by a merge [18:06:06] (03PS3) 10Esanders: Convert all instances of assert.equal to assert.strictEqual [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159779 [18:06:08] fixed in ^^ [18:09:07] (03CR) 10Jforrester: [C: 032] Convert all instances of assert.equal to assert.strictEqual [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159779 (owner: 10Esanders) [18:10:37] (03Merged) 10jenkins-bot: Convert all instances of assert.equal to assert.strictEqual [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159779 (owner: 10Esanders) [18:12:32] (03PS1) 10Esanders: Convert all instances of assert.equal to assert.strictEqual [oojs/core] - 10https://gerrit.wikimedia.org/r/159791 [18:14:52] (03PS2) 10Jforrester: test: Convert all instances of assert.equal to assert.strictEqual [oojs/core] - 10https://gerrit.wikimedia.org/r/159791 (owner: 10Esanders) [18:15:04] (03CR) 10Jforrester: [C: 032] test: Convert all instances of assert.equal to assert.strictEqual [oojs/core] - 10https://gerrit.wikimedia.org/r/159791 (owner: 10Esanders) [18:19:31] (03Merged) 10jenkins-bot: test: Convert all instances of assert.equal to assert.strictEqual [oojs/core] - 10https://gerrit.wikimedia.org/r/159791 (owner: 10Esanders) [18:20:00] * Elitre doesn't see a new magical tab in her IE. /me refreshes. /me refreshes. /me gets a huuuge donation banner instead. /me not amused. [18:21:13] Elitre, what site? [18:25:17] Elitre: Yeah, it's not deployed yet. [18:26:13] Elitre: Issues in the deployment script. :-( [18:27:13] (03PS8) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [18:27:15] (03PS9) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [18:27:17] (03PS11) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [18:27:19] (03PS11) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [18:28:39] James_F: I'll cook some dinner then. [18:30:26] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [18:45:46] 3VisualEditor / 3Language: VisualEditor: The language dialog will not close - 10https://bugzilla.wikimedia.org/70731 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None I haven't tried to reproduce this. I copied a page title from Meta and pasted it into VisualEditor on another wiki. The text was... [18:47:14] 3VisualEditor / 3Editing Tools: VisualEditor: Opening and closing the gallery inspector without making any change causes a transaction - 10https://bugzilla.wikimedia.org/60311 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3minor [18:50:16] 3VisualEditor / 3Language: VisualEditor: Language dialog box didn't draw correctly - 10https://bugzilla.wikimedia.org/70733 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Created attachment 16443 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16443&action=edit Language dialog box, as it's... [18:52:53] (03PS1) 10Jforrester: Relabel the cancel button in the save dialog to "Resume editing" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159806 (https://bugzilla.wikimedia.org/69116) [18:53:16] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Cancel" button in the Save dialog is confusing. How about "Resume editing"? - 10https://bugzilla.wikimedia.org/69116 (10James Forrester) p:5Unprio>3Normal s:5normal>3minor a:3James Forrester [18:53:24] (03PS1) 10Esanders: Bound onDocumentMouseUp to the entire document on mousedown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159807 (https://bugzilla.wikimedia.org/59822) [18:53:29] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Cancel" button in the Save dialog is confusing. How about "Resume editing"? - 10https://bugzilla.wikimedia.org/69116 (10James Forrester) [18:54:47] 3VisualEditor / 3MediaWiki integration: VisualEditor: Save page button is not fully clickable - 10https://bugzilla.wikimedia.org/70602#c3 (10James Forrester) 5UNCO>3RESO/FIX p:5Unprio>3Normal a:3Roan Kattouw Yes. [18:56:16] 3VisualEditor / 3ContentEditable: VisualEditor: Pressing "undo" deletes the content of an article making the "save page" button disable for that session - 10https://bugzilla.wikimedia.org/57784#c2 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal a:3Ed Sanders Fixed by Ed as part of bug 57217. [18:57:44] 3VisualEditor / 3Editing Tools: VisualEditor: The language dialog will not close - 10https://bugzilla.wikimedia.org/70731 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [18:58:06] (03PS1) 10Esanders: Rename frequency to pollInterval in SurfaceObserver [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159808 [18:58:34] (03CR) 10Jforrester: [C: 032] Rename frequency to pollInterval in SurfaceObserver [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159808 (owner: 10Esanders) [19:00:37] (03Merged) 10jenkins-bot: Rename frequency to pollInterval in SurfaceObserver [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159808 (owner: 10Esanders) [19:25:16] 3VisualEditor: VisualEditor: Links to disambiguation pages should be highlighted in a different color - 10https://bugzilla.wikimedia.org/70738 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None This is related to bug 61072 and bug 50240. Please consider marking all links to disambiguation pages in a d... [19:26:45] 3VisualEditor: VisualEditor: Links to disambiguation pages should be highlighted in a different color - 10https://bugzilla.wikimedia.org/70738 (10WhatamIdoing) s:5normal>3enhanc [19:36:29] 3VisualEditor / 3Editing Tools: VisualEditor: The language dialog will not close - 10https://bugzilla.wikimedia.org/70731#c1 (10Roan Kattouw) It looks like page titles (at least on meta, possibly elsewhere) are wrapped in , which is recognized as a language annotation (because it has a dir... [19:44:16] 3VisualEditor / 3Editing Tools: VisualEditor: "Clear styling" is confusing. If it's going to clear links, too, then it should say, "Clear styling and links" - 10https://bugzilla.wikimedia.org/70739 (10WhatamIdoing) 3NEW p:3Unprio s:3enhanc a:3None If "clear styling" is going to clear links, too, th... [19:44:29] 3VisualEditor: VisualEditor: Links to disambiguation pages should be highlighted in a different color - 10https://bugzilla.wikimedia.org/70738#c1 (10Bartosz Dziewoński) They already are! (Or rather can be.) I implemented a way to color them in 066283dde745fcc372ffab8d753962858813d032 (the links on the editing... [19:48:09] (03PS1) 10Catrope: Make popups position themselves correctly when dimensions change [oojs/ui] - 10https://gerrit.wikimedia.org/r/159815 [20:42:59] 3VisualEditor: VisualEditor: Links to disambiguation pages should be highlighted in a different color - 10https://bugzilla.wikimedia.org/70738#c2 (10WhatamIdoing) BD2412 has specifically requested that this be available to everyone, not just for himself/people using a script. [21:02:58] TrevorP|Away: i got a notification that you were chatting me, but i can't find the window in which you were doing so [21:04:44] 3VisualEditor: VisualEditor: span tags get added to references - 10https://bugzilla.wikimedia.org/61371#c4 (10Drongou) It's a copy/paste from Microsoft Office => Word mso + wysiwyg on google => general trouble [21:15:44] TrevorP|Away: are you on IRC? [21:16:19] 3MediaWiki / 3ResourceLoader: ResourceLoader doesn't flip embedded images - 10https://bugzilla.wikimedia.org/70742 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None (I thought there might be an existing bug for this, but I couldn't find anything.) If you use: background-image: url('images/back-ltr.p... [21:20:44] 3MediaWiki / 3ResourceLoader: ResourceLoader doesn't flip embedded images - 10https://bugzilla.wikimedia.org/70742#c1 (10Bartosz Dziewoński) 5NEW>3RESO/DUP This only affects embed() in LESS, not /*@embed*/ (in LESS or CSS). *** This bug has been marked as a duplicate of bug 66091 *** [21:20:59] 3MediaWiki / 3ResourceLoader: mediawiki-mixins: .background-image-svg() should support RTL flipping - 10https://bugzilla.wikimedia.org/66091#c5 (10Bartosz Dziewoński) *** Bug 70742 has been marked as a duplicate of this bug. *** [21:21:20] TrevorP|Away: https://gerrit.wikimedia.org/r/159815 [21:22:16] cscott: hey [21:22:25] TrevorParscal: oh there you are ;) [21:22:25] sorry, was texting you while I was afk [21:22:28] here now [21:22:42] TrevorParscal: yeah, i figured. [21:22:42] so, we were talking and kept saying "we need to ask C Scott" [21:22:45] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions ::embed does not support CSSJanus flipping for RTL, affecting .background-image-svg() and others - 10https://bugzilla.wikimedia.org/66091#c6 (10Bartosz Dziewoński) (Restoring previous bug summary for searchability. I also want to kill embed() (bug 673... [21:23:03] so, first question, where are you at with VE OT since last we talked / you presented [21:23:08] my @wikimedia.org google account just forwards to a @cscott.net, so apparently nothing but my phone pays attentions to chats directed there. [21:23:44] TrevorParscal: I had a priority interrupt w/ the PDF stuff, so that's all i can breathe, eat, or sleep until the tampa datacenter is decommissioned. [21:23:55] at least that's my understanding [21:24:07] right [21:24:32] but basically I rewrote the VE OT stuff -- for the third or fourth time, i think -- using higher-level intentions, plus refactoring the new* methods to use a smaller set of intentions. [21:24:38] so the intentions are basically a middle layer. [21:25:01] are those patches in gerrit? [21:25:05] let me push that patch to git for you to look at. i was working on updating the test suite when i got task switched, so jenkins won't like it. [21:25:16] ah [21:25:25] is ve ot work something that you would normally have some % of your time to work on? [21:25:41] i guess? ;) [21:25:42] realizing that the PDF stuff is making now abnormal [21:26:01] I just wasn't sure if this was something you were doing for fun, 20%, or as an assigned task [21:26:24] let's say it's a 20% task. also fun. :) [21:26:40] right [21:26:52] and, how TogetherJS-specific are things? [21:26:59] not at all, really. [21:27:06] it just relays data between clients? [21:27:11] i mean, the transaction transpose operation is fundamental, regardless. [21:27:41] I know you are doing distributed OT, so the server doesn't have a model, the clients just negotiate between each other to eventually end up in the same state [21:28:21] maintaining the OT history is done with ~100 lines of general-purpose code in togetherjs, but that could easily be ported or rewritten/etc. it's all client-side. the hub is just a broadcaster and timestamper [21:28:34] which i think is actually a really good model to use in general [21:29:16] agreed [21:29:22] right now, togetherjs is a convenient way to prototype and test this code without having to write a bunch of new UI [21:29:40] i like erik's ui proposals for collaboration a lot, but i don't know that anyone is actually implementing them [21:29:48] you could always have a "client" running on the server which never makes changes of its own, but can persist the current state from time to time [21:29:55] (and they also seem to be based on winter, so it's not clear they *can* be implemented at this point in time) [21:30:20] I think that's all smoke and mirrors anyway [21:30:47] TrevorParscal: sure. that's a reasonable way to persist state. you could also use client-local storage. it depends to some degree on what user model of collaboration you have. [21:30:53] Winter is more of a static HTML napkin they can draw on with crayons [21:31:21] i guess the "fake client to persist" is more like the etherpad model, where the etherpad doesn't go away just because no one's working on it. but in theory you might also be storing these revisions in mediawiki as unpublished revisions of some sort. [21:31:42] there's this underlying conceptual issue w/ collaborative sessions and how you record that work. [21:32:07] in any case, like i said, i don't have to answer that issue yet, still plenty of work to do making basic transactions work and transpose. [21:32:42] yeah, i'm not as concerned about those issues [21:32:45] and the next big task would be restructuring the undo stack to handle having "foreign" operations from other people in it. which i guess should be skipped when you undo? [21:32:50] more just with getting VE into a state where OT works [21:32:53] (i am totally stealing that napkin analogy next time someons asks me wtf winter is) [21:32:53] (03CR) 10Catrope: [C: 032] Relabel the cancel button in the save dialog to "Resume editing" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159806 (https://bugzilla.wikimedia.org/69116) (owner: 10Jforrester) [21:33:12] MatmaRex: :) [21:33:14] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Cancel" button in the Save dialog is confusing. How about "Resume editing"? - 10https://bugzilla.wikimedia.org/69116 (10Roan Kattouw) 5PATC>3RESO/FIX [21:33:15] hey, i've got my own little UI playground, i call it "Nell's Wikipedia". [21:33:29] ok, give me a second to see what state my tree is in [21:33:48] (03PS2) 10Catrope: Bind ve.ce.Surface#onDocumentMouseUp to the entire document on mousedown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159807 (https://bugzilla.wikimedia.org/59822) (owner: 10Esanders) [21:34:26] (03Merged) 10jenkins-bot: Relabel the cancel button in the save dialog to "Resume editing" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159806 (https://bugzilla.wikimedia.org/69116) (owner: 10Jforrester) [21:35:20] (03PS9) 10Cscott: WIP: Record intention in ve.dm.Transaction object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 [21:35:36] TrevorParscal: looks like I reused the change id from the previous versions of this patch ;) [21:36:00] (03CR) 10Catrope: [C: 032] Bind ve.ce.Surface#onDocumentMouseUp to the entire document on mousedown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159807 (https://bugzilla.wikimedia.org/59822) (owner: 10Esanders) [21:36:02] TrevorParscal: but PS9 should probably be compared against base, not previous versions, since it's a rewrite of that part. [21:36:12] (03CR) 10Catrope: [C: 032] Convert all instances of assert.equal to assert.strictEqual [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159781 (owner: 10Esanders) [21:36:27] TrevorParscal: and again, jenkins won't like it because there were some tests that needed to be updated [21:36:31] (03CR) 10jenkins-bot: [V: 04-1] WIP: Record intention in ve.dm.Transaction object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 (owner: 10Cscott) [21:36:37] awesome [21:36:42] TrevorParscal: see, told you! ;) [21:36:47] lol [21:37:03] anyway, my intention is to take a quantum to finish this up just as soon as the PDF fires are out. [21:37:16] so, that's your latest work - and you are going to be unable to work on it more until sometime in the future when the thing with the PDF stuff is sorted [21:37:47] (03Merged) 10jenkins-bot: Convert all instances of assert.equal to assert.strictEqual [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159781 (owner: 10Esanders) [21:37:51] any visibility on the containment of those fires? [21:37:53] TrevorParscal: well, i can go back to working on it just as soon as we hire someone whose actual job includes the PDF backend. ;) [21:37:56] (03Merged) 10jenkins-bot: Bind ve.ce.Surface#onDocumentMouseUp to the entire document on mousedown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159807 (https://bugzilla.wikimedia.org/59822) (owner: 10Esanders) [21:38:36] TrevorParscal: I think I made good progress this week better instrumenting the backend and reconstructing/documenting all the bits which mwalker let me. [21:38:59] TrevorParscal: let me wave my hands wildly and say i expect to still be working on PDF stuff next week, but hopefully not too long after that. [21:39:37] TrevorParscal: that gerrit patch is probably worth reviewing to see if we're on the same page about the general structure of the 'intention' stuff. [21:40:43] TrevorParscal: I'm a bit of two minds. The first version of the patches only operated on the low level operation array. That was nice because there aren't that many different low level operations, and I can do the transpose blindly without having to clone/look at a complete copy of the document. [21:41:10] but it made me nervous because i also couldn't guarantee anything about what invariants i may or may not be breaking in the document structure [21:42:05] the second major version was the version i had at wikimania, and worked on the high-level new* operations. So now we can rely on the new* constructors to ensure that the actual operations preserve document invariants, although it's harder to ensure that the actual transpose is correct. I think that's probably the right tradeoff to make though. [21:42:36] But there were too many different new* operations, and they didn't form a complete set -- some operations were missing or non-orthogonal, etc. [21:42:39] i think we agree about moving forward with intention preservation, transforming the higher level information at the transaction builder level seems like it provides more abstraction and keeps OT in the problem domain, rather than scattering it around in the data processing and tree synchronization domain [21:43:22] So now major version 3 introduces intentions as a sort of middle layer which is simpler/more orthogonal than the high-level new* operations, but preserves more of the user's "intention" than looking at the low-level operations. And that's where we are now. [21:43:43] awesome [21:43:44] But if you have version 3, I could be convinced to go back to version 1, which had a bit of elegance to it. [21:43:51] And danger. [21:43:55] Elegant danger. ;) [21:44:12] elegant danger does sound like fun [21:44:15] lol [21:47:06] (03CR) 10Cscott: WIP: Record intention in ve.dm.Transaction object (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 (owner: 10Cscott) [21:47:41] TrevorParscal: https://gerrit.wikimedia.org/r/159815 [21:48:57] TrevorParscal: and fwiw, currently i try to wipe out the entire undo stack whenever we get a transaction from another user, which is a temporary Big Stick approach. but i think that code rotted somewhat since I wrote it. [21:49:07] ok, i should get back to the pdf mines [21:50:47] thanks for getting me up to speed man [21:50:56] I look forward to you being able to return to VE OT work [21:51:57] (03CR) 10Trevor Parscal: [C: 032] Make popups position themselves correctly when dimensions change [oojs/ui] - 10https://gerrit.wikimedia.org/r/159815 (owner: 10Catrope) [21:52:52] (03Merged) 10jenkins-bot: Make popups position themselves correctly when dimensions change [oojs/ui] - 10https://gerrit.wikimedia.org/r/159815 (owner: 10Catrope) [21:56:08] s/but if you have/if you hate/ [21:56:20] i should really try to read what i type as i write it [21:56:22] i assumed [21:56:31] it was obvious from the context [21:56:33] :) [21:56:44] the not/now typo is usually the most pernicious one [21:56:53] i don't think i've done have/hate before ;) [21:58:06] "i have phabricator. we should now give up on gerrit and move to phabricator for everything." ;) [22:08:25] ah yes, phabricator [22:08:37] Written in the only language worse than Java... PHP [22:17:02] (03CR) 10Cscott: "This is the third major revision of this patch. Some history, copied from IRC:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 (owner: 10Cscott) [22:18:15] (03PS1) 10Alex Monk: Try to stop user from tabbing outside of open dialog box [oojs/ui] - 10https://gerrit.wikimedia.org/r/159902 (https://bugzilla.wikimedia.org/67156) [22:43:31] (03PS1) 10Esanders: DomRange / getOffset edge cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159917 [22:43:33] (03PS1) 10Esanders: Cache $documentNode in surface view [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159918 [22:43:35] (03PS1) 10Esanders: Trigger selection update on selectionchange or mousemove events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159919 (https://bugzilla.wikimedia.org/59822) [23:10:37] edsanders: https://gerrit.wikimedia.org/r/159922 [23:41:29] 3VisualEditor / 3ContentEditable: Horizontal lines (----,
) extremely hard to delete - 10https://bugzilla.wikimedia.org/50770#c1 (10WhatamIdoing) I ran across this just now. Not only was I unable to find a way to delete it, I'm not sure that I'd have known that I had successfully selected it.