[00:12:32] (03PS1) 10Jforrester: Remove VisualEditor.i18n.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159928 [00:13:06] (03CR) 10Legoktm: [C: 032] Remove VisualEditor.i18n.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159928 (owner: 10Jforrester) [00:14:38] (03Merged) 10jenkins-bot: Remove VisualEditor.i18n.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159928 (owner: 10Jforrester) [00:34:14] 3VisualEditor / 3Editing Tools: VisualEditor: "Clear styling" is confusing. If it's going to clear links, too, then it should say, "Clear styling and links" - 10https://bugzilla.wikimedia.org/70739#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 51757 *** [00:34:15] 3VisualEditor / 3Editing Tools: VisualEditor: Clear formatting button should not remove links - 10https://bugzilla.wikimedia.org/51757#c7 (10James Forrester) *** Bug 70739 has been marked as a duplicate of this bug. *** [00:41:49] (03PS2) 10Catrope: DomRange / getOffset edge cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159917 (owner: 10Esanders) [00:42:32] (03PS3) 10Catrope: DomRange / getOffset edge cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159917 (owner: 10Esanders) [00:43:05] (03CR) 10Catrope: [C: 032] DomRange / getOffset edge cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159917 (owner: 10Esanders) [00:43:11] (03PS2) 10Catrope: Cache $documentNode in surface view [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159918 (owner: 10Esanders) [00:43:46] (03CR) 10Catrope: [C: 032] Cache $documentNode in surface view [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159918 (owner: 10Esanders) [00:45:45] (03Merged) 10jenkins-bot: DomRange / getOffset edge cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159917 (owner: 10Esanders) [00:46:05] (03Merged) 10jenkins-bot: Cache $documentNode in surface view [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159918 (owner: 10Esanders) [00:52:37] (03PS2) 10Esanders: Trigger selection update on selectionchange or mousemove events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159919 (https://bugzilla.wikimedia.org/59822) [00:52:39] (03PS9) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [00:52:41] (03PS10) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [00:52:44] (03PS12) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [00:52:45] (03PS12) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [00:55:17] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [01:13:02] (03CR) 10Catrope: [C: 032] Trigger selection update on selectionchange or mousemove events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159919 (https://bugzilla.wikimedia.org/59822) (owner: 10Esanders) [01:14:34] (03Merged) 10jenkins-bot: Trigger selection update on selectionchange or mousemove events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159919 (https://bugzilla.wikimedia.org/59822) (owner: 10Esanders) [01:46:42] (03PS1) 10Esanders: Refactor out finding of CE focusedNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159949 [02:00:43] (03PS1) 10Catrope: Fix JS error due to typo in dm.Converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159957 [02:02:10] (03CR) 10Jforrester: [C: 032] "Whoops." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159957 (owner: 10Catrope) [02:03:53] (03Merged) 10jenkins-bot: Fix JS error due to typo in dm.Converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159957 (owner: 10Catrope) [02:07:32] 3VisualEditor / 3Technical Debt: VisualEditor: Write unit tests for dm.Converter's use of dm.Model APIs - 10https://bugzilla.wikimedia.org/70751 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None There are no unit tests exercising features of dm.Converter that are currently unused by our node types, l... [02:11:31] 3VisualEditor / 3ContentEditable: VisualEditor: Mouse up outside the surface doesn't register a selection change. - 10https://bugzilla.wikimedia.org/59822 (10James Forrester) 5PATC>3RESO/FIX a:3Ed Sanders [02:15:02] (03PS1) 10Jforrester: Update VE core submodule to master (028e8cb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159960 [02:15:29] 3VisualEditor / 3Technical Debt: VisualEditor: Write unit tests for dm.Converter's use of dm.Model APIs - 10https://bugzilla.wikimedia.org/70751 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc [02:19:00] 3VisualEditor: VisualEditor: Links to disambiguation pages should be highlighted in a different color - 10https://bugzilla.wikimedia.org/70738#c3 (10James Forrester) 5NEW>3RESO/DUP This is (effectively) a duplicate of bug 7936 (which is only asking for Special:AllPages, but we'd also change it in the cont... [02:42:40] (03PS1) 10Catrope: Improve FieldLayout help popup appearance [oojs/ui] - 10https://gerrit.wikimedia.org/r/159965 [12:49:31] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf21] Editor is displayed with two Toolbars. - 10https://bugzilla.wikimedia.org/70768 (10Ritu Swain) 3UNCO p:3Unprio s:3major a:3None Created attachment 16453 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16453&action=edit double Tool... [12:49:59] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf21] Editor is displayed with two Toolbars. - 10https://bugzilla.wikimedia.org/70768 (10Ritu Swain) [12:52:14] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf21] Editor is displayed with two Toolbars. - 10https://bugzilla.wikimedia.org/70768#c1 (10Ritu Swain) Browsers- FF and Chrome. Couldn't test on Safari. [13:03:19] 3VisualEditor / 3Initialisation: VisualEditor:[Regression wmf 21]“Uncaught TypeError: Cannot read property 'top' of undefined” when Editor is launched. - 10https://bugzilla.wikimedia.org/70770 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Environment- test2, beta 1> open VE, I get JS console erro... [13:03:44] 3VisualEditor / 3Initialisation: VisualEditor:[Regression wmf 21]“Uncaught TypeError: Cannot read property 'top' of undefined” when Editor is launched. - 10https://bugzilla.wikimedia.org/70770 (10Ritu Swain) [15:07:32] 3MediaWiki / 3ResourceLoader: Errors in one module can affect other modules via $.ready - 10https://bugzilla.wikimedia.org/70772 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None This is not really a ResourceLoader bug but serious enough that some workaround is needed and that probably has to be done... [15:21:21] (03PS1) 10Lokal Profil: Correct typo [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160002 [15:26:13] (03PS2) 10Bartosz Dziewoński: Correct typo in visualeditor-dialog-meta-settings-redirect-statichelp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160002 (owner: 10Lokal Profil) [15:26:18] (03CR) 10Bartosz Dziewoński: [C: 032] Correct typo in visualeditor-dialog-meta-settings-redirect-statichelp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160002 (owner: 10Lokal Profil) [15:26:45] (03CR) 10Bartosz Dziewoński: [C: 032] Correct typo in visualeditor-dialog-meta-settings-redirect-statichelp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160002 (owner: 10Lokal Profil) [15:28:16] (03Merged) 10jenkins-bot: Correct typo in visualeditor-dialog-meta-settings-redirect-statichelp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160002 (owner: 10Lokal Profil) [15:29:29] fyi, I'm still experiencing https://bugzilla.wikimedia.org/show_bug.cgi?id=70602 . [15:55:17] (03PS1) 10Cmcmahon: [BrowserTest] add one test to validate new ie11 build [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160006 [15:56:04] (03CR) 10Cmcmahon: [C: 032] "build maintenance, no function change" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160006 (owner: 10Cmcmahon) [15:57:35] (03Merged) 10jenkins-bot: [BrowserTest] add one test to validate new ie11 build [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160006 (owner: 10Cmcmahon) [16:05:59] 3VisualEditor / 3MediaWiki integration: VisualEditor: Save page button is not fully clickable - 10https://bugzilla.wikimedia.org/70602#c4 (10Elitre) It's not gone for me. [16:08:08] in Resources.php: [16:08:11] // WARNING: OOjs-UI is NOT TESTED with older browsers and is likely to break [16:08:11] // if loaded in browsers that don't support ES5 [16:08:22] is that still accurate? [16:08:45] and how big of an issue would that be? (I'm not really familiar with what browsers support es5 and not...) [16:09:15] We're planning to use a simple widget in the request a rename form for SUL finalisation, see https://gerrit.wikimedia.org/r/#/c/156488/12/modules/ext.centralauth.globalrenamerequest.js,cm [16:29:13] legoktm: still accurate, but afaik you can just add a dependency on the 'es5-shim' module and it should work [16:29:26] well, the oojs-ui module has that dependency... [16:29:31] (it used to be horribly broken in IE8 or something even with that, but was fixed) [16:29:56] then it probably works, but i'm afraid it's still not being routinely tested [16:30:24] Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=11849661 [16:30:24] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107359735 [16:30:24] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107372355 [16:30:24] Corruption alert: visualeditor-needcheck on tewiki: https://te.wikipedia.org/?diff=1294396 [16:30:24] Corruption alert: visualeditor-needcheck on tewiki: https://te.wikipedia.org/?diff=1294397 [16:30:25] Corruption alert: visualeditor-needcheck on tewiki: https://te.wikipedia.org/?diff=1294398 [16:31:02] ok, thanks [16:57:15] hey guys, I don't understand if this is known or not: https://it.wikipedia.org/w/index.php?title=BT_Italia&curid=711446&diff=68102565&oldid=68102554 There's a space inside the wikilink, at the very end, and then the nowiki tag. I can't reproduce, and this seems to happen with simpler links too. [17:03:53] Further examples at https://it.wikipedia.org/w/index.php?title=West_Hollywood&curid=2095569&diff=68101635&oldid=66951304 . [17:12:22] at fr.wp as well: https://fr.wikipedia.org/w/index.php?title=L%C3%A9gendaire_(Mafia_K%271_Fry)&curid=4527137&diff=107384110&oldid=107381967 [17:15:41] legoktm: We've not done any formal testing of OOUI's UI with IE < 10, but the /code/ should work fine. [17:17:00] RoanKattouw_away: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-windows_8.1-internet_explorer-11-sauce/lastCompletedBuild/testReport/(root)/VisualEditor%20Bullets,%20Numbering/check_strings_for_bullets_and_numbering__outline_example_____Numbering_______/ – not sure if you can work out from that if that's a real IE11 issue. [17:17:12] ok, sounds good [17:17:57] legoktm: Automatically checking that a UX library works in 40 different browser/OS/version combos is… hard. [17:18:09] : [17:18:11] P* [17:21:15] James_F: hi, and ^^^. Drop me a line if you need me to file that. have a nice weekend, everybody. [17:21:48] MaxSem: need your feedback on https://bugzilla.wikimedia.org/show_bug.cgi?id=70312 [17:22:00] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf20] Edit notice displays at half-width - 10https://bugzilla.wikimedia.org/70565 (10James Forrester) 5RESO/DUP>3RESO/FIX [17:22:00] 3OOjs UI: OOjs UI: [Regression wmf20] Popups sizing broken - 10https://bugzilla.wikimedia.org/70423 (10James Forrester) [17:22:29] 3VisualEditor / 3Editing Tools: VisualEditor:Shrink back the Basic Reference dialog size - 10https://bugzilla.wikimedia.org/70016 (10James Forrester) [17:22:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: After saving a page reference list gets missing (unless it is refreshed again) and the page gets categorized as "Pages with missing reference list" - 10https://bugzilla.wikimedia.org/68182 (10James Forrester) [17:22:53] 3VisualEditor / 3Editing Tools: VisualEditor: In the media insertion dialog, give a tooltip on each item saying what will happen when you click it (i.e., "Click to insert as a thumbnail" or whatever) - 10https://bugzilla.wikimedia.org/52219 (10James Forrester) [17:22:53] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - 10https://bugzilla.wikimedia.org/66604 (10James Forrester) [17:22:53] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] In Safari, Cannot enter any input in any dialog and VE gets unresponsive after trying to do that - 10https://bugzilla.wikimedia.org/70578 (10James Forrester) [17:22:54] 3VisualEditor / 3Editing Tools: VisualEditor: Triggering context on link after defocus throws "TypeError: Cannot read property 'isCollapsed' of null" - 10https://bugzilla.wikimedia.org/68915 (10James Forrester) [17:22:55] 3VisualEditor / 3Editing Tools: VisualEditor: The language dialog will not close - 10https://bugzilla.wikimedia.org/70731 (10James Forrester) [17:22:56] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Clicking in the document where an inspector was opened doesn't close the inspector - 10https://bugzilla.wikimedia.org/68679 (10James Forrester) [17:23:00] 3VisualEditor / 3MediaWiki integration: VisualEditor: Link existence checker in LinkTargetInputWidget doesn't work for interwikis, language links - 10https://bugzilla.wikimedia.org/70504 (10James Forrester) [17:23:06] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10James Forrester) [17:23:06] 3VisualEditor / 3Editing Tools: VisualEditor: Support "substituting" templates in transclusion dialog - 10https://bugzilla.wikimedia.org/49904 (10James Forrester) [17:23:06] 3VisualEditor / 3Editing Tools: VisualEditor: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - 10https://bugzilla.wikimedia.org/68590 (10James Forrester) [17:23:07] 3VisualEditor / 3Editing Tools: VisualEditor: In the media selector show name in a tooltip on mouseover - 10https://bugzilla.wikimedia.org/52459 (10James Forrester) [17:23:08] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf12] The highlight for centered images is taking 100% width - 10https://bugzilla.wikimedia.org/67507 (10James Forrester) [17:23:09] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10James Forrester) [17:23:22] 3VisualEditor / 3Data Model: VisualEditor: Make transaction processing exception-safe - 10https://bugzilla.wikimedia.org/68892 (10James Forrester) [17:23:22] 3VisualEditor / 3Data Model: VisualEditor: tags appear when editing on the Hebrew Wiki - 10https://bugzilla.wikimedia.org/66210 (10James Forrester) [17:23:22] 3VisualEditor / 3MediaWiki integration: VisualEditor: Populate LinkCache from MWLinkTargetInputWidget etc - 10https://bugzilla.wikimedia.org/69886 (10James Forrester) [17:23:22] 3VisualEditor / 3Editing Tools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - 10https://bugzilla.wikimedia.org/68537 (10James Forrester) [17:23:23] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf20] The link target suggestion drop down is appearing cut off to a very small size upon first time opening the link inspector - 10https://bugzilla.wikimedia.org/70683 (10James Forrester) [17:23:24] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195 (10James Forrester) [17:23:25] 3VisualEditor / 3ContentEditable: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - 10https://bugzilla.wikimedia.org/69474 (10James Forrester) [17:23:26] 3VisualEditor / 3ContentEditable: VisualEditor: Out-of-skin templates are taking editors to linked pages, rather than letting them edit the template - 10https://bugzilla.wikimedia.org/70074 (10James Forrester) [17:23:27] 3VisualEditor / 3Editing Tools: VisualEditor: Append references list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906 (10James Forrester) [17:23:37] 3VisualEditor / 3Data Model: VisualEditor: Investigate parsing/rendering/behavior of "{{MW 1.23}}" on mediawiki.org [mini-tracking] - 10https://bugzilla.wikimedia.org/68297 (10James Forrester) [17:23:37] 3VisualEditor / 3Editing Tools: VisualEditor: Insert > References list is very large in Firefox - 10https://bugzilla.wikimedia.org/70545 (10James Forrester) [17:23:38] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog should recommend TemplateData-hinted mandatory parameters - 10https://bugzilla.wikimedia.org/50747 (10James Forrester) [17:23:38] 3VisualEditor / 3Mobile: VisualEditor Mobile: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110 (10James Forrester) [17:23:39] 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580 (10James Forrester) [17:23:40] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10James Forrester) [17:23:41] 3VisualEditor / 3ContentEditable: VisualEditor: Deleting from an empty paragraph to the end of an inline node throws an exception - 10https://bugzilla.wikimedia.org/70375 (10James Forrester) [17:23:42] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843 (10James Forrester) [17:24:30] and https://bugzilla.wikimedia.org/show_bug.cgi?id=70602 doesn't work for me, if that helps. I might have said this before? I dunno, I'm getting old and don't remember things. [17:24:35] bye! [17:33:59] 3VisualEditor / 3Editing Tools: Disable "Re-use" button under Cite tools when there's nothing to re-use - 10https://bugzilla.wikimedia.org/70640 (10James Forrester) [17:39:29] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf21] Editor is displayed with two Toolbars. - 10https://bugzilla.wikimedia.org/70768#c2 (10Roan Kattouw) I can't reproduce this. Does this also happen when you're logged out? [17:39:43] 3VisualEditor / 3Initialisation: VisualEditor:[Regression wmf 21]“Uncaught TypeError: Cannot read property 'top' of undefined” when Editor is launched. - 10https://bugzilla.wikimedia.org/70770#c1 (10Roan Kattouw) I can't reproduce this on test2. Does it happen when logged out as well? [17:40:59] 3VisualEditor / 3MediaWiki integration: VisualEditor: Save page button is not fully clickable - 10https://bugzilla.wikimedia.org/70602#c5 (10Roan Kattouw) (In reply to Elitre from comment #4) > It's not gone for me. It works for me. Does it work for you when you're logged out? [17:44:59] RoanKattouw: Argh. Just inserted a template, and I'm getting infinite snowmen. [17:45:05] Yay [17:45:09] Everything is broken it sounds like [17:45:15] RoanKattouw: Yeah. :-( [17:45:15] Three bugs I can't reproduce [17:45:26] And Elitre talking about things like https://it.wikipedia.org/w/index.php?title=BT_Italia&curid=711446&diff=68102565&oldid=68102554 [17:45:33] which, I wonder if the latter might be IE [17:45:43] or AnnotationInspector refactors [17:47:55] * James_F tries to extract the contents of the edit. [17:48:15] You might be able to stop the flow of snowmen by pressing enter to split the paragraph [17:48:33] No, the snowmen were getting inserted into the document whilst the dialog was still closing. [17:48:49] I clicked "Cancel" and it stopped, but the dialog remained pending. [17:48:52] And uncloseable. [17:48:56] And… other brokeness. [17:48:58] Oh lovely [17:49:25] ve.instances[0].model.documentModel.data.data [17:49:35] Array[262470] [17:49:38] * James_F sighs. [17:49:55] Once you're done rescuing, could you see if this is reproducible by inserting the same template in a similar context? [17:50:00] Sure. [17:50:19] I want getRange() on this, yes? [17:50:28] getRange() on what? [17:50:38] The last 1000 nodes? [17:50:58] .data.data does not return node objects, it returns individual data elements [17:51:03] Yeah, I know. [17:51:22] (03PS2) 10Esanders: Refactor out finding of CE focusedNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159949 [17:51:24] (03PS1) 10Esanders: Emit more position events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160034 [17:51:28] (03CR) 10jenkins-bot: [V: 04-1] Refactor out finding of CE focusedNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159949 (owner: 10Esanders) [17:51:30] (03CR) 10jenkins-bot: [V: 04-1] Emit more position events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160034 (owner: 10Esanders) [17:53:02] James_F: I don't follow what you're trying to do [17:53:15] I'm trying to extract the 3 hours worth of content I wrote here. [17:53:15] 3VisualEditor / 3MediaWiki integration: VisualEditor: Save page button is not fully clickable - 10https://bugzilla.wikimedia.org/70602#c6 (10Elitre) Nope. Just tried again incognito mode on IE, FF and Chrome. [17:54:01] (03PS1) 10Cmcmahon: [BrowserTest] UI text changed s/Cancel/Resume editing/. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160035 [17:55:32] Are the snowmen still accumulating? [17:55:39] Not after I killed JS. [17:55:42] OK [17:55:44] Worry not. [17:55:53] You could probably use the inspector to extract the HTML contents of the CE surface [17:56:01] Pasting that into another VE should work reasonably well [17:56:02] That's what I did. [17:56:09] Well, it inserted the HTML as raw text. [17:56:13] So… "worked". [17:58:28] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160035 (owner: 10Cmcmahon) [18:00:07] (03Merged) 10jenkins-bot: [BrowserTest] UI text changed s/Cancel/Resume editing/. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160035 (owner: 10Cmcmahon) [18:01:54] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (028e8cb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159960 (owner: 10Jforrester) [18:03:31] (03Merged) 10jenkins-bot: Update VE core submodule to master (028e8cb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159960 (owner: 10Jforrester) [18:10:44] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf16] Opening link inspector/comment box in an empty line, opens them at the end of the previous line - 10https://bugzilla.wikimedia.org/69122#c12 (10Rummana Yasmeen) Verified the fix in Betalabs [18:11:15] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf16] Opening link inspector/comment box in an empty line, opens them at the end of the previous line - 10https://bugzilla.wikimedia.org/69122#c13 (10Rummana Yasmeen) 5RESO/?>3VERI *Verified the fix in production* [18:12:30] 3VisualEditor / 3MediaWiki integration: VisualEditor: Toolbar utilities menu items should not be cut off against browser edge - 10https://bugzilla.wikimedia.org/57366#c13 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in Production [18:13:14] 3VisualEditor / 3Editing Tools: VisualEditor: Reference group input should be a "ComboBox" suggesting possible values - 10https://bugzilla.wikimedia.org/61574#c4 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in Production [18:14:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf20] Link target names are not appearing pressing command+K just applying the link text as link target straight off - 10https://bugzilla.wikimedia.org/70356#c6 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in Production [18:16:09] RoanKattouw: I repeated the bug. [18:16:18] RoanKattouw: Not exactly a "minimum" test case, but: [18:16:59] 3VisualEditor / 3Editing Tools: VisualEditor: Open button in link inspector should be disabled when the link target field is empty - 10https://bugzilla.wikimedia.org/70015#c12 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in Production [18:17:09] Go to https://www.mediawiki.org/wiki/VisualEditor/status?veaction=edit. Scroll to the final section, remove the "…", insert template -> key press; set parameter 1 as Ctrl, parameter 2 as Shift, and parameter 3 as V. Insert. Voilà. [18:19:44] 3VisualEditor / 3Editing Tools: VisualEditor: Opening the link inspector and then closing, while selecting an image moves the image to the previous position - 10https://bugzilla.wikimedia.org/68762#c3 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in Production [18:20:01] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] Inserting multi-node template (?) causes endless snowmen - 10https://bugzilla.wikimedia.org/70777 (10James Forrester) 3ASSI p:3Unprio s:3major a:3None Initial case: 1. Go to https://www.mediawiki.org/wiki/VisualEditor/status?veaction=e... [18:20:16] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] Inserting multi-node template (?) causes endless snowmen - 10https://bugzilla.wikimedia.org/70777 (10James Forrester) p:5Unprio>3Highes a:3Roan Kattouw [18:20:57] James_F: I'll try reproducing that in a minute. In the meantime, enjoy https://fr.wikipedia.org/w/index.php?title=%C3%89pinay-sur-Orge&diff=107359735&oldid=107128377 [18:21:01] Wikitext corruption caused by IE11 [18:21:06] Woo. Fun. [18:22:48] James_F: When you come here, could you bring my IE laptop please? [18:23:05] I don't really want to debug this using crossbrowsertesting over Trevor's not-terribly-fast wifi [18:23:08] RoanKattouw: Of course. [18:24:26] The bot mentioned that diff earlier. [18:24:35] Is https://cs.wikipedia.org/?diff=11849661 related? [18:26:22] Yeah the bot is how I found it [18:26:36] Krenair: Maybe. I wasn't able to reproduce with Chrome, will try with IE [18:26:43] Although note that there's a freaking backtick in there [18:28:00] That's a backtick? [18:28:27] {| border´"1" cellpadding="2" cellspacing="0" style="border-collapse;" class="wikitable" [18:28:38] That's brace pipe space border backtick quote one quote space [18:28:47] That's a normal tick. [18:28:50] No wait, backtick is ` [18:28:54] /forwardtick [18:28:58] It's a smart quote? [18:30:07] Yup that's an IE thing too [18:30:17] IE likes corrupting tables apparentyl [18:46:25] RoanKattouw: Fun. [18:49:38] Urgh [18:49:44] So there seem to be two things going on [18:51:16] One is, IE normalizes style="background: #ddffdd;" to style="background: rgb(221, 255, 221);" [18:52:04] The other is, sometimes tables somehow manage to have an empty style="" attribute inbound but not outbound and I don't know why that happens [18:54:04] (03PS3) 10Esanders: Refactor out finding of CE focusedNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159949 [18:54:06] (03PS2) 10Esanders: Emit more position events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160034 [18:54:08] (03CR) 10jenkins-bot: [V: 04-1] Refactor out finding of CE focusedNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159949 (owner: 10Esanders) [18:54:10] (03CR) 10jenkins-bot: [V: 04-1] Emit more position events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160034 (owner: 10Esanders) [18:54:12] Oh, aha [18:54:22] The empty style="" comes from normalizing style="border-collapse;" which is invalid [18:58:21] Oh wow [18:58:25] This is unbelievably bad [18:58:31] div = document.createElement('div'); [18:58:37] div.setAttribute('style', ''); [18:58:49] div.getAttribute('style'); [18:58:57] In real browsers: '' [18:58:59] In IE: null [18:59:49] Seems to have to do with how the style attribute is normalized in IE [19:00:28] Because if you set it to an invalid value, it'll read back as an empty string, and if you set it to something involving a color value like #ffffff it'll read back as rgb(255,255,255) [19:00:57] James_F: This is a browser bug in IE11 that causes wikitext corruption and it appears to be uncircumventable [19:01:03] Fun. [19:01:29] I'm going to write a jsfiddle for this [19:01:38] Then email our contact at Microsoft saying this is a showstopper [19:02:35] :-( [19:03:36] RoanKattouw, we have to put IE11 back on the blacklist? [19:04:05] Well, that's James's call [19:04:21] Also, is VE marking all edits with this issue as needcheck? [19:05:04] No, that's the worst part [19:05:40] The only thing that triggers needcheck is being dirty-diffed to [19:05:53] Because it's read in as and written out as [19:06:14] But for all other normalizations of the style attribute, the normalization happens *in the HTML parser* and so we don't notice, because we compare HTML DOMs [19:06:31] The needcheck code assumes that the browser's HTML parser isn't incompetent [19:06:37] So this edit got caught with needcheck for some other reason? [19:06:43] Yeah I don't know why [19:07:19] But I reproduced it on https://fr.wikipedia.org/wiki/Utilisateur:Roan_Kattouw_(WMF)/Sandbox?veaction=edit without triggering the corruption warning [19:07:44] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf21] Editor is displayed with two Toolbars. - 10https://bugzilla.wikimedia.org/70768#c3 (10Ritu Swain) (In reply to Roan Kattouw from comment #2) > I can't reproduce this. Does this also happen when you're logged out? I can reproduce it(tried with a... [19:07:59] https://cs.wikipedia.org/wiki/Wikipedista:Roan_Kattouw_(WMF)/Sandbox?veaction=edit does trigger it because it triggers a different normalization in each step [19:08:31] IE's style normalization isn't really worthy of the term "normalization" because there's an edge case where it's not idempotent [19:08:58] style="border-collapse;" (or any invalid CSS really) normalizes to style="" which in turn normalizes to not having a style attribute at all [19:10:29] 3VisualEditor / 3Initialisation: VisualEditor:[Regression wmf 21]“Uncaught TypeError: Cannot read property 'top' of undefined” when Editor is launched. - 10https://bugzilla.wikimedia.org/70770#c2 (10Ritu Swain) (In reply to Roan Kattouw from comment #1) > I can't reproduce this on test2. Does it happen when... [19:11:04] (03CR) 10Esanders: WIP: Record intention in ve.dm.Transaction object (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 (owner: 10Cscott) [19:13:12] (03PS1) 10Esanders: Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 [19:13:14] (03CR) 10jenkins-bot: [V: 04-1] Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 (owner: 10Esanders) [19:14:44] 3VisualEditor / 3Initialisation: VisualEditor:[Regression wmf 21]“Uncaught TypeError: Cannot read property 'top' of undefined” when Editor is launched. - 10https://bugzilla.wikimedia.org/70770#c3 (10Roan Kattouw) I can't reproduce this, neither logged in nor logged out, neither on test2 nor on beta labs, usi... [19:20:36] Hi guys. I am struggeling to get VisualEditor and Parsoid to work on my private wiki. Parsoid works when I make it public (readable). [19:21:37] I heard about that you need a reverse proxy in order to make this work. Is this true? [19:25:52] No, that's not true [19:26:02] There are instructions on the documentation page, let me find you a link [19:26:21] See https://www.mediawiki.org/wiki/Extension:VisualEditor#Linking_with_Parsoid_in_private_wikis [19:26:35] Note that you'll need to uncomment the lines that look like //$wgSomething = something [19:27:31] 3VisualEditor / 3Initialisation: VisualEditor:[Regression wmf 21]“Uncaught TypeError: Cannot read property 'top' of undefined” when Editor is launched. - 10https://bugzilla.wikimedia.org/70770#c4 (10Rummana Yasmeen) 5UNCO>3NEW RoanKattouw, Try opening a new page with VE, you will get this error. [19:28:43] ( gute ---^^) [19:29:29] 3VisualEditor / 3Initialisation: VisualEditor:[Regression wmf 21]“Uncaught TypeError: Cannot read property 'top' of undefined” when Editor is launched. - 10https://bugzilla.wikimedia.org/70770#c5 (10Roan Kattouw) (In reply to Rummana Yasmeen from comment #4) > RoanKattouw, Try opening a new page with VE, you... [19:30:16] RoanKattouw: Thank you. But these settings are already in place. Get a "parsoidserver-http-bad-status: 500" -error. [19:31:11] Oh, also [19:31:26] Every time you switch the wiki from being public to being private, you have to restart Parsoid [19:31:40] Maybe that should also be in the documentation [19:31:55] If after restarting Parsoid you still get a 500 error, look at Parsoid's log output [19:32:09] RoanKattouw: why is that necessary? [19:32:21] ok. will give it a go. [19:32:52] gwicke: I don't know if it's currently necessary but it used to be when I was playing with it [19:33:00] nope, same message. [19:33:13] On startup (or on first request), Parsoid seems to make an API call for wiki-wide information and then cache that information [19:33:32] normally it should only cache it if the request was successful [19:33:32] That appears to include private-ness, because it gets very confused when a wiki changes from being public to private under its feet [19:33:36] Well, yes [19:33:45] Suppose you have a public wiki and make a bunch of successful requests to it [19:33:48] Then you make the wiki private [19:33:55] there is nothing in the config about being public / private [19:34:12] Now Parsoid requests will fail because it'll have cached the fact that the wiki wasn't private last time [19:34:13] parsoid just forwards the cookie if supplied [19:34:27] Or at least that's what I observed when private wiki support was first introduced [19:34:31] it may be fixed now [19:34:41] gute: Did Parsoid spit out any information about the error? [19:34:52] no [19:34:59] I routinely get cache misses in prod because my browser sends a cookie for *.wikimedia.org [19:35:03] but it still works just fine [19:35:04] just slower [19:35:13] parsoidConfig.debug = true; [19:35:32] that'd be the public -> private switch [19:43:32] RoanKattouw: my line in localsettings.js for Parsoid --> https://dpaste.de/04QA/raw [19:45:03] (03PS2) 10Esanders: Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 [19:45:05] (03PS4) 10Esanders: Refactor out finding of CE focusedNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159949 [19:45:09] (03PS1) 10Esanders: Allow specification of range when getting selection rectangles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160073 [19:45:13] (03CR) 10jenkins-bot: [V: 04-1] Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 (owner: 10Esanders) [19:45:15] (03CR) 10jenkins-bot: [V: 04-1] Refactor out finding of CE focusedNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159949 (owner: 10Esanders) [19:45:15] gute: make sure you also have the other lines for private wikis [19:45:17] (03CR) 10jenkins-bot: [V: 04-1] Allow specification of range when getting selection rectangles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160073 (owner: 10Esanders) [19:46:38] gwicke: besides https://dpaste.de/04QA/raw ? Which lines are you thinking of? [19:47:07] gute: https://www.mediawiki.org/wiki/Extension:VisualEditor#Linking_with_Parsoid_in_private_wikis [19:47:14] $wgSessionsInObjectCache = true; [19:47:16] Gwicke: sorry, I mean https://dpaste.de/vcFR/raw [19:47:19] $wgVisualEditorParsoidForwardCookies = true; [19:47:49] ah, perhaps disable $wgSecureLogin ? [19:47:51] yes. I got them all. [19:48:15] Tried it. try again with a restart of parsoid... [19:48:16] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf21] Cannot open any inspector, throwing error Uncaught TypeError: Cannot read property 'top' of undefined - 10https://bugzilla.wikimedia.org/70782 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with V... [19:48:52] gute: also, do you require the VE extension before that section? [19:48:59] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf21] Cannot open any inspector, throwing error Uncaught TypeError: Cannot read property 'top' of undefined - 10https://bugzilla.wikimedia.org/70782 (10Rummana Yasmeen) [19:49:10] I don't see the require [19:49:15] 3VisualEditor / 3Initialisation: VisualEditor:[Regression wmf 21]“Uncaught TypeError: Cannot read property 'top' of undefined” when Editor is launched. - 10https://bugzilla.wikimedia.org/70770 (10Rummana Yasmeen) [19:49:46] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf21] Cannot open any inspector, throwing error Uncaught TypeError: Cannot read property 'top' of undefined - 10https://bugzilla.wikimedia.org/70782 (10Rummana Yasmeen) 5NEW>3ASSI p:5Unprio>3High a:3Roan Kattouw [19:50:47] gwicke, gute: If $wgSecureLogin is enabled, make sure the api.php URL you used in Parsoid's localsettings.js is an HTTPS URL [19:51:01] gwicke, no that did'nt do it. I have the require. [19:51:03] Actually from your pastebin it looks like that's the problem [19:51:31] if it's a self-signed cert that wouldn't easily work [19:51:38] so easier to disable it [19:51:59] it's self signed. [19:52:20] gute: do you have the require *before* the settings? [19:52:28] yes [19:52:34] okay [19:52:36] trying out the https thingie. [19:54:26] RoanKattouw, gwicke: nope. changing of the localsettings.js to https didnt do it. [19:56:17] That might be because it's a self-signed cert? [19:56:25] Try setting it back to http:// but also disabling $wgSecureLogin [19:56:40] Or whatever the setting is that aggressively redirects to https [19:57:06] I have tried that as well. no luck. [19:57:36] RoanKattouw, gwicke: some version info: https://dpaste.de/pnWw/raw [19:58:12] (03PS1) 10Esanders: ve.getStartAndEndRects returns null for empty rect lists [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160076 [20:00:43] (03PS2) 10Esanders: ve.getStartAndEndRects returns null for empty rect lists [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160076 (https://bugzilla.wikimedia.org/70770) [20:01:07] RoanKattouw, gwicke: changing parsoid url to api.php5 didnt do it either. [20:02:29] If I only change the wiki to be readable and comment out $wgVisualEditorParsoidForwardCookies = true; and $wgSessionsInObjectCache = true; it works. but not with a private security. [20:05:15] (03PS3) 10Catrope: ve.getStartAndEndRects returns null for empty rect lists [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160076 (https://bugzilla.wikimedia.org/70770) (owner: 10Esanders) [20:05:26] (03CR) 10Catrope: [C: 032] ve.getStartAndEndRects returns null for empty rect lists [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160076 (https://bugzilla.wikimedia.org/70770) (owner: 10Esanders) [20:07:17] RoanKattouw, gwicke: I have even tried to set $wgVisualEditorParsoidHTTPProxy = true; and that didnt work either. [20:08:59] (03Merged) 10jenkins-bot: ve.getStartAndEndRects returns null for empty rect lists [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160076 (https://bugzilla.wikimedia.org/70770) (owner: 10Esanders) [20:12:21] if I set $wgVisualEditorParsoidHTTPProxy = true; and $wgHTTPProxy = "8833"; and then head over to parsoid config to change the url to http://localhost:8833/wikiprivat/api.php, I get a different error message. [20:13:23] the errormessage says (translated from swedish) "Error occurd while reading data from server: parsoidserver-http-curl-error: Failed to connect to 0.0.34.129: Invalid argument." [20:14:47] Is there no one who has a solution for this? I have spent so many hours on this.. [20:20:16] 3VisualEditor / 3Editing Tools: Selecting correct image format isn't possible - 10https://bugzilla.wikimedia.org/70785 (10Eran Roz) 3NEW p:3Unprio s:3normal a:3None Since the full name isn't shown, it isn't possible to select the correct image format if two formats for the same image exist. For exam... [20:20:30] (03PS1) 10Jforrester: ve.getStartAndEndRects returns null for empty rect lists [VisualEditor/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160082 (https://bugzilla.wikimedia.org/70770) [20:26:59] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf21] Editor is displayed with two Toolbars. - 10https://bugzilla.wikimedia.org/70768#c4 (10Rummana Yasmeen) Ritu, can you share the link to the page where you are getting this, I can't reproduce it either. [20:31:29] 3VisualEditor / 3Editing Tools: Disable "Re-use" button under Cite tools when there's nothing to re-use - 10https://bugzilla.wikimedia.org/70640#c3 (10Rummana Yasmeen) Verified the fix in test2 [20:31:59] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf20] Edit notice displays at half-width - 10https://bugzilla.wikimedia.org/70565#c4 (10Rummana Yasmeen) Verified the fix in test2 [20:32:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] Checking "Border" in media settings dialog is not enabling "Apply changes" button - 10https://bugzilla.wikimedia.org/70575#c4 (10Rummana Yasmeen) Verified the fix in test2 [20:32:44] 3VisualEditor / 3Editing Tools: VisualEditor: ”Use an Existing Reference“ button should be inactive if there are no references to add (the internal list is empty) - 10https://bugzilla.wikimedia.org/70611#c7 (10Rummana Yasmeen) Verified the fix in test2 [20:34:45] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf20] Toolbar in mobile got squished in Betalabs and test2 both in desktop and iOS Safari - 10https://bugzilla.wikimedia.org/70430#c3 (10Rummana Yasmeen) Verified the fix in test2 [20:35:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] Adding a text as an image caption duplicates the text in the field with a following pawn - 10https://bugzilla.wikimedia.org/70450#c4 (10Rummana Yasmeen) Verified the fix in test2 [20:37:00] RoanKattouw_away, gwicke: where'd you go? [20:37:59] 3VisualEditor / 3Editing Tools: VisualEditor: Undoing the edit from toolbar does not disable the "Apply Changes" button inside Media Settings dialog - 10https://bugzilla.wikimedia.org/68058#c6 (10Rummana Yasmeen) Verified the fix in test2 [20:39:29] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438#c19 (10Rummana Yasmeen) Verified the fix in test2 [20:54:01] Hi. a few days ago I installed parsoid with visualeditor for mediawiki 1.22. Is that version without support for private wikis? [20:55:31] the parsoid service is on the same server as the wiki. could one just permit a single ip-adress to be able to work fully with the api? [21:13:33] (03PS3) 10Esanders: Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 [21:13:35] (03PS5) 10Esanders: Refactor out finding of CE focusedNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159949 [21:13:37] (03PS3) 10Esanders: Emit more position events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160034 [21:13:39] (03PS2) 10Esanders: Allow specification of range when getting selection rectangles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160073 [21:14:24] (03PS4) 10Esanders: Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 [21:14:26] (03PS6) 10Esanders: Refactor out finding of CE focusedNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159949 [21:14:28] (03PS4) 10Esanders: Emit more position events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160034 [21:14:30] (03PS3) 10Esanders: Allow specification of range when getting selection rectangles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160073 [21:17:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000#c14 (10Rummana Yasmeen) Verified the fix in test2 [21:18:17] (03CR) 10jenkins-bot: [V: 04-1] Allow specification of range when getting selection rectangles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160073 (owner: 10Esanders) [21:18:45] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf21] Editor is displayed with two Toolbars. - 10https://bugzilla.wikimedia.org/70768#c5 (10Ritu Swain) (In reply to Rummana Yasmeen from comment #4) > Ritu, can you share the link to the page where you are getting this, I can't > reproduce it either.... [21:20:39] gute: Sorry, I was away for lunch [21:21:39] I don't remember if we have private wiki support in the VE version for 1.22. You can find out by grepping the code for wgVisualEditorParsoidForwardCookies and see if there's any code referencing it [21:21:44] 3VisualEditor / 3Data Model: VisualEditor: “show one more field” adds nothing to existing Template data, with Templates having at least 4 parameters. - 10https://bugzilla.wikimedia.org/70609 (10Ritu Swain) [21:21:51] Also 1.22 is old enough that I don't think there are VE versions out there that claim to support it [21:22:29] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Cancel" button in the Save dialog is confusing. How about "Resume editing"? - 10https://bugzilla.wikimedia.org/69116#c3 (10Rummana Yasmeen) Verified the fix in Betalabs [21:30:15] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf21] Editor is displayed with two Toolbars. - 10https://bugzilla.wikimedia.org/70768#c6 (10Rummana Yasmeen) Created attachment 16454 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16454&action=edit Screenshot Ok, so I reproduced it on my use... [21:33:15] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf21] Editor is displayed with two Toolbars. - 10https://bugzilla.wikimedia.org/70768 (10Rummana Yasmeen) 5UNCO>3NEW [21:33:56] (03PS1) 10Catrope: (Kind of) fix treatment of strange dir values [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160096 (https://bugzilla.wikimedia.org/70731) [21:36:46] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf21] Editor is displayed with two Toolbars. - 10https://bugzilla.wikimedia.org/70768#c7 (10Roan Kattouw) https://gerrit.wikimedia.org/r/160076 (the fix for bug 70770 fixes this too). [21:38:15] 3VisualEditor / 3Initialisation: VisualEditor: [Regression wmf 21] “Uncaught TypeError: Cannot read property 'top' of undefined” when Editor is launched - 10https://bugzilla.wikimedia.org/70770 (10James Forrester) p:5Unprio>3High s:5normal>3major a:3Ed Sanders [21:39:01] RoanKattouw, there is. but that's as old as it goes. [21:40:19] (03PS1) 10Jforrester: Update VE core submodule to master (badcac5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160097 [21:43:29] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] Cannot open any inspector, throwing error "Uncaught TypeError: Cannot read property 'top' of undefined" - 10https://bugzilla.wikimedia.org/70782 (10James Forrester) [21:43:46] 3VisualEditor / 3Initialisation: VisualEditor: [Regression wmf 21] “Uncaught TypeError: Cannot read property 'top' of undefined” when Editor is launched - 10https://bugzilla.wikimedia.org/70770 (10James Forrester) [21:43:46] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf21] Editor is displayed with two toolbars on second initialisation - 10https://bugzilla.wikimedia.org/70768 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [21:43:46] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] Cannot open any inspector, throwing error "Uncaught TypeError: Cannot read property 'top' of undefined" - 10https://bugzilla.wikimedia.org/70782 (10James Forrester) [21:43:58] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (badcac5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160097 (owner: 10Jforrester) [21:45:29] 3VisualEditor / 3Editing Tools: VisualEditor: The language dialog will not close - 10https://bugzilla.wikimedia.org/70731 (10James Forrester) 5PATC>3RESO/FIX [21:45:57] (03PS1) 10Catrope: Don't return undefined in ve.init.mw.Platform#getLanguageName [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160098 (https://bugzilla.wikimedia.org/70731) [21:45:57] gute: I'm pretty sure I deleted the branch of VisualEditor that claimed to work with MediaWiki 1.22. It didn't. [21:45:57] (03Merged) 10jenkins-bot: Update VE core submodule to master (badcac5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160097 (owner: 10Jforrester) [21:45:57] (03CR) 10Jforrester: [C: 032] Don't return undefined in ve.init.mw.Platform#getLanguageName [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160098 (https://bugzilla.wikimedia.org/70731) (owner: 10Catrope) [21:45:57] gute: Sorry. :-( [21:45:57] (03PS4) 10Esanders: Allow specification of range when getting selection rectangles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160073 [21:46:36] (03Merged) 10jenkins-bot: Don't return undefined in ve.init.mw.Platform#getLanguageName [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160098 (https://bugzilla.wikimedia.org/70731) (owner: 10Catrope) [21:47:11] (03CR) 10Jforrester: [C: 032] (Kind of) fix treatment of strange dir values [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160096 (https://bugzilla.wikimedia.org/70731) (owner: 10Catrope) [21:48:53] James_F, Well I got 1.22.6 actually.. [21:48:54] (03Merged) 10jenkins-bot: (Kind of) fix treatment of strange dir values [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160096 (https://bugzilla.wikimedia.org/70731) (owner: 10Catrope) [21:50:10] James_F, https://www.mediawiki.org/wiki/Special:ExtensionDistributor/VisualEditor [21:50:37] gute: Bah. That really should have been deleted. I'm really sorry about that. [21:50:48] ryasmeen: We /may/ have fixed bugs 70768 / 70770 / 70782 in Beta Labs once the next sync finish (not yet). Could you test? [21:51:16] yes I saw that James_F :) Will surely do! [21:51:23] James_F, but it does work, only just not with private wikis. [21:51:39] gute: Yeah, maybe we should add a note. [21:51:50] gute: I'd recommend upgrading to 1.23 if you can, BTW. [21:54:31] James_F, I feel like a little girl at a cemetary at midnight. I'm fairly new at this wiki-thing, and have never upgraded before. is there a patch or something smooth for v 1.22.6 [21:56:01] (03PS1) 10Catrope: Account for the case where a FocusableNode has an empty outerRects array [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160102 [21:56:48] gute: there should be a patch somewhere, but the usual and recommended upgrade methods is to just overwrite all the existing files with the ones from the tarball for the newer version [21:56:58] There is an upgrade guide on mw.org somewhere [21:57:14] gute: (you generally don't need to delete the old files, the rare cases that you do are documented somewhere) [21:57:28] https://www.mediawiki.org/wiki/Manual:Upgrading#Files_remaining_that_may_cause_errors [21:57:39] this is also probably the guide that RoanKattouw is talking about [21:57:48] (03PS2) 10Catrope: Account for the case where a FocusableNode has an empty outerRects array [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160102 (https://bugzilla.wikimedia.org/70777) [21:58:44] Yes [21:58:50] (03CR) 10Esanders: [C: 032] Account for the case where a FocusableNode has an empty outerRects array [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160102 (https://bugzilla.wikimedia.org/70777) (owner: 10Catrope) [22:00:30] (03Merged) 10jenkins-bot: Account for the case where a FocusableNode has an empty outerRects array [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160102 (https://bugzilla.wikimedia.org/70777) (owner: 10Catrope) [22:01:17] (03PS1) 10Jforrester: Account for the case where a FocusableNode has an empty outerRects array [VisualEditor/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160105 (https://bugzilla.wikimedia.org/70777) [22:01:40] MatmaRex, the StartProfiler.* does not exist in my root. so I just have to download latest stable and copy it over? will there then be a wizard of some sort? Will I still have all my extensions? Do I need to reinstall Parsoid? [22:01:41] (03CR) 10Catrope: [C: 032] Account for the case where a FocusableNode has an empty outerRects array [VisualEditor/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160105 (https://bugzilla.wikimedia.org/70777) (owner: 10Jforrester) [22:01:54] (03CR) 10Catrope: [C: 032] ve.getStartAndEndRects returns null for empty rect lists [VisualEditor/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160082 (https://bugzilla.wikimedia.org/70770) (owner: 10Jforrester) [22:02:07] RoanKattouw, ^^ [22:03:13] gute: You will still have all of your extensions. You do not need to do reinstall Parsoid, but you do need to restart it [22:03:21] (03PS1) 10Jforrester: Update VE core submodule to master (f646507) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160110 [22:03:22] gute: yes. no wizard, it will just work (you might need to run the 'update.php' maintenance script to upgrade database schema, i don't remember if there were any changes). your extensions will stay there (unless you manually delete them from the extensions/ directory) [22:03:24] You probably don't need to mess with the StartProfiler stuff if you don't know what it is [22:04:32] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (f646507) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160110 (owner: 10Jforrester) [22:04:42] gute: note that upgrading mediawiki doesn't upgrade the extensions. the ones you have will likely still be compatible, but they might not. you probably want to upgrade them too anyway. [22:07:21] Yeah the point of this is to upgrade VisualEditor and you'll need to upgrade that separately [22:07:30] (03Merged) 10jenkins-bot: Account for the case where a FocusableNode has an empty outerRects array [VisualEditor/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160105 (https://bugzilla.wikimedia.org/70777) (owner: 10Jforrester) [22:07:33] (03Merged) 10jenkins-bot: ve.getStartAndEndRects returns null for empty rect lists [VisualEditor/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160082 (https://bugzilla.wikimedia.org/70770) (owner: 10Jforrester) [22:08:20] Yeah. ok. so I'll give it a shot then.. (must just find a download link..) [22:08:44] 3VisualEditor / 3Initialisation: VisualEditor: [Regression wmf 21] “Uncaught TypeError: Cannot read property 'top' of undefined” when Editor is launched - 10https://bugzilla.wikimedia.org/70770#c10 (10Rummana Yasmeen) 5PATC>3RESO/FIX Verified the fix in Betalabs [22:09:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] Cannot open any inspector, throwing error "Uncaught TypeError: Cannot read property 'top' of undefined" - 10https://bugzilla.wikimedia.org/70782#c1 (10Rummana Yasmeen) 5ASSI>3RESO/FIX Verified the fix in Betalabs. [22:09:21] (03Merged) 10jenkins-bot: Update VE core submodule to master (f646507) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160110 (owner: 10Jforrester) [22:09:59] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf21] Editor is displayed with two toolbars on second initialisation - 10https://bugzilla.wikimedia.org/70768#c8 (10Rummana Yasmeen) 5ASSI>3RESO/FIX Verified the fix in Betalabs [22:13:06] (03PS1) 10Jforrester: Update VE core submodule to cherry-pick (d9658b2) [extensions/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160114 [22:15:10] (03PS5) 10Esanders: Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 [22:15:12] (03PS7) 10Esanders: Refactor out finding of CE focusedNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159949 [22:15:14] (03PS5) 10Esanders: Emit more position events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160034 [22:15:16] (03PS5) 10Esanders: Allow specification of range when getting selection rectangles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160073 [22:40:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] Cannot open any inspector, throwing error "Uncaught TypeError: Cannot read property 'top' of undefined" - 10https://bugzilla.wikimedia.org/70782 (10James Forrester) [22:40:15] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] Inserting multi-node template (?) causes endless snowmen - 10https://bugzilla.wikimedia.org/70777 (10James Forrester) 5PATC>3RESO/FIX [22:43:17] 3VisualEditor: VisualEditor: Ugly span tags appear on {{infobox book}}, but not in the saved wikitext, if ref tag is present - 10https://bugzilla.wikimedia.org/70796 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Created attachment 16455 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16455&... [22:44:00] 3VisualEditor: VisualEditor: Ugly span tags appear on {{infobox book}}, but not in the saved wikitext, if ref tag is present - 10https://bugzilla.wikimedia.org/70796#c1 (10WhatamIdoing) Created attachment 16456 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16456&action=edit Infobox as seen in Safari.... [23:08:49] (03PS1) 10Alex Monk: Try to handle interwiki links in LinkTargetInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160155 (https://bugzilla.wikimedia.org/70504) [23:08:49] (03CR) 10Alex Monk: [C: 04-2] "not ready yet, obviously." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160155 (https://bugzilla.wikimedia.org/70504) (owner: 10Alex Monk) [23:41:38] MatmaRex, I got as far as to the mw-config. (https://www.mediawiki.org/wiki/Manual:Upgrading#Web_browser) then I got this error: https://dpaste.de/Pj2G/raw [23:42:20] what can I do about that??? [23:46:05] Ugh, SemanticForms [23:46:14] gute: You may need to upgrade SemanticForms [23:48:09] alright