[01:24:48] (03PS1) 10Jforrester: Add contextual help to all remaining meta dialog controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160371 (https://bugzilla.wikimedia.org/51798) [03:50:14] 3VisualEditor / 3Language: VisualEditor: Cannot type in Korean using Mozilla on Windows 7 with dual-script keyboard - 10https://bugzilla.wikimedia.org/70353#c5 (10Revi) When I tried to do test for bug 50631 on [[en:User:Hym411/VETest]] (second line), I got this bug. bug 50631 at least returns some result -... [04:54:17] (03PS8) 10Esanders: Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 [04:54:19] (03PS8) 10Esanders: WIP Allow specification of range when getting selection rectangles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160073 [04:54:21] (03PS2) 10Esanders: Add getNativeRange method with option dm range argument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160303 [04:55:43] (03Abandoned) 10Esanders: getNativeRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160302 (owner: 10Esanders) [04:56:24] (03CR) 10jenkins-bot: [V: 04-1] Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 (owner: 10Esanders) [04:57:26] (03CR) 10jenkins-bot: [V: 04-1] Add getNativeRange method with option dm range argument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160303 (owner: 10Esanders) [05:39:11] (03PS9) 10Esanders: Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 [05:39:13] (03PS9) 10Esanders: WIP Allow specification of range when getting selection rectangles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160073 [05:39:15] (03PS3) 10Esanders: Add getNativeRange method with optional DM range argument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160303 [09:48:10] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160371 (https://bugzilla.wikimedia.org/51798) (owner: 10Jforrester) [11:36:59] 3MediaWiki extensions / 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - 10https://bugzilla.wikimedia.org/35342#c46 (10Andre Klapper) (In reply to paladox2015 from comment #42) > Merge Failed. > This change was unable to be automatically merged with the current state of > the repository.... [11:54:44] 3MediaWiki extensions / 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - 10https://bugzilla.wikimedia.org/35342#c47 (10paladox2015) Hi I have fixed it. [14:49:03] (03CR) 10Jforrester: Add contextual help to all remaining meta dialog controls (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160371 (https://bugzilla.wikimedia.org/51798) (owner: 10Jforrester) [14:49:05] (03PS2) 10Jforrester: Add contextual help to all remaining meta dialog controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160371 (https://bugzilla.wikimedia.org/51798) [14:56:07] (03CR) 10Jforrester: [C: 032] Improve FieldLayout help popup appearance [oojs/ui] - 10https://gerrit.wikimedia.org/r/159965 (owner: 10Catrope) [14:57:05] (03Merged) 10jenkins-bot: Improve FieldLayout help popup appearance [oojs/ui] - 10https://gerrit.wikimedia.org/r/159965 (owner: 10Catrope) [15:02:20] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (073f37e258) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160461 [15:13:02] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf21] : Citations deleted, are still shown in “Use this group” suggestion list. - 10https://bugzilla.wikimedia.org/70847 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16467 --> https://bugzilla.wikimedia.org/attachment.... [15:13:29] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf21] : Citations deleted, are still shown in “Use this group” suggestion list. - 10https://bugzilla.wikimedia.org/70847#c1 (10Ritu Swain) Created attachment 16468 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16468&action=edit Basic Citation [15:13:44] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf21] : Citations deleted, are still shown in “Use this group” suggestion list. - 10https://bugzilla.wikimedia.org/70847 (10Ritu Swain) [15:40:29] 3MediaWiki / 3ResourceLoader: [Regression] Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c28 (10Greg Grossmeier) Bartosz: I'm just seeing this now. No one added it this morning; you should have :) [15:53:31] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf21] :New Section/Add Topic tab when first enabled/disabled, gets added to the toolbar only after clicking on the Edit Source tab. - 10https://bugzilla.wikimedia.org/70848 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Created attachment 164... [15:54:29] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf21] :New Section/Add Topic tab when first enabled/disabled, gets added to the toolbar only after clicking on the Edit Source tab. - 10https://bugzilla.wikimedia.org/70848#c1 (10Ritu Swain) Created attachment 16470 --> https://bugzilla.wikimedia.org... [15:54:59] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf21] :New Section/Add Topic tab when first enabled/disabled, gets added to the toolbar only after clicking on the Edit Source tab. - 10https://bugzilla.wikimedia.org/70848 (10Ritu Swain) [16:12:31] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf21] : In Transclusion,highlight moves to next item (Content/Template), instead of staying at the Citation. - 10https://bugzilla.wikimedia.org/70849 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Environment- Production, Test2, beta 1> open... [16:13:17] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf21] : In Transclusion, highlight moves to next item (Content/Template), instead of staying at the Citation. - 10https://bugzilla.wikimedia.org/70849#c1 (10Ritu Swain) Created attachment 16471 --> https://bugzilla.wikimedia.org/attachment.cgi?id=164... [16:14:32] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf21] : In Transclusion, highlight moves to next item (Content/Template), instead of staying at the Citation. - 10https://bugzilla.wikimedia.org/70849 (10Ritu Swain) [16:14:34] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf21] : In Transclusion, highlight moves to next item (Content/Template), instead of staying at the Citation. - 10https://bugzilla.wikimedia.org/70849#c2 (10Ritu Swain) Created attachment 16472 --> https://bugzilla.wikimedia.org/attachment.cgi?id=164... [16:55:57] (03CR) 10Catrope: [C: 032] Strip Start/EndFragment comments from paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160179 (https://bugzilla.wikimedia.org/70799) (owner: 10Esanders) [16:57:43] (03Merged) 10jenkins-bot: Strip Start/EndFragment comments from paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160179 (https://bugzilla.wikimedia.org/70799) (owner: 10Esanders) [17:19:36] So I still need to get comments from Trevor on https://gerrit.wikimedia.org/r/#/c/156459/ and https://gerrit.wikimedia.org/r/#/c/156559/, and Roan/Ed on https://gerrit.wikimedia.org/r/#/c/159006/ [17:26:51] TrevorP|Away: ----^^ [17:27:14] MatmaRex: so... [17:27:32] (03CR) 10Catrope: [C: 032] ve.ui.AnnotationInspector: Apply existing annotations to inserted content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160216 (https://bugzilla.wikimedia.org/70534) (owner: 10Bartosz Dziewoński) [17:27:40] what's crackin'? [17:27:52] (03CR) 10Catrope: [C: 032] ve.ce.Surface: Insert new paragraphs after empty nodes rather than before [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160215 (https://bugzilla.wikimedia.org/59652) (owner: 10Bartosz Dziewoński) [17:28:40] TrevorParscal: i looked at your WIP and i like it, but it's broken :D [17:28:55] the json format looks kinda verbose, do we need that all? (i.e., do we need the order of icons, and do we need to state available color variants twice?) [17:28:58] (https://gerrit.wikimedia.org/r/#/c/157866/) [17:29:13] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (073f37e258) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160461 (owner: 10Jforrester) [17:29:43] (03Merged) 10jenkins-bot: ve.ui.AnnotationInspector: Apply existing annotations to inserted content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160216 (https://bugzilla.wikimedia.org/70534) (owner: 10Bartosz Dziewoński) [17:29:54] (03Merged) 10jenkins-bot: ve.ce.Surface: Insert new paragraphs after empty nodes rather than before [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160215 (https://bugzilla.wikimedia.org/59652) (owner: 10Bartosz Dziewoński) [17:31:10] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (073f37e258) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160461 (owner: 10Jforrester) [17:31:14] 3VisualEditor / 3Editing Tools: VisualEditor: Inserted link annotations don't take pre-annotations (but inserted language annotations do) - 10https://bugzilla.wikimedia.org/70534 (10James Forrester) 5PATC>3RESO/FIX [17:31:44] 3VisualEditor / 3ContentEditable: VisualEditor: Can't add new paragraphs to the end of the page, if the last line is an empty section heading == == - 10https://bugzilla.wikimedia.org/59652 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal [17:34:28] (03PS1) 10Jforrester: Update VE core submodule to master (8fb94f1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160478 [17:35:52] MatmaRex: good points [17:39:18] MatmaRex: https://gist.github.com/trevorparscal/230df3438ef7d7ca9e63 [17:39:24] thoughts? [17:41:48] TrevorParscal: looks good. still more verbose than what i proposed in https://gerrit.wikimedia.org/r/#/c/158444/3/Gruntfile.js,unified , but looks like the right balance to me [17:42:06] TrevorParscal: no extension on the file name? afaik we'll only have one source file, always [17:42:24] ah, yeah we should do that [17:42:26] adding extensions makes for easier grepping ;) [17:42:40] agreed [17:43:09] and, the files: { ... } portion should be part of the build script still [17:45:43] (03CR) 10Trevor Parscal: "Just don't pass this.$input into the config for PendingElement and it will operate on this.$element (the parent) instead." [oojs/ui] - 10https://gerrit.wikimedia.org/r/156459 (owner: 10Alex Monk) [17:46:44] (03CR) 10Trevor Parscal: [C: 032] Get confirmation when trying to insert/edit template/citation with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk) [17:46:51] (03CR) 10Trevor Parscal: [C: 04-1] Get confirmation when trying to insert/edit template/citation with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk) [17:47:12] arg [17:47:18] almost +2'd the wrong thingy [17:47:26] caught it in time [17:48:49] (03CR) 10Trevor Parscal: "See the language inspector - it opens a "sub" dialog for language selection. It's sort of messy, but it works for now until we clean this " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk) [17:49:10] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (8fb94f1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160478 (owner: 10Jforrester) [17:49:59] TrevorParscal: need me to do anything? [17:50:03] if not i'll go find and fix some fun lil' bug [17:50:04] yes [17:50:11] go ahead for now [17:50:15] I'm getting something ready for you [17:50:59] (03Merged) 10jenkins-bot: Update VE core submodule to master (8fb94f1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160478 (owner: 10Jforrester) [18:00:15] 3VisualEditor / 3Data Model: VisualEditor: Copying and pasting a template causes comment to be inserted in Chrome on Windows due to broken native clipboard behaviour - 10https://bugzilla.wikimedia.org/70799 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal [18:02:44] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf12] The highlight for centered images is taking 100% width - 10https://bugzilla.wikimedia.org/67507#c1 (10Bartosz Dziewoński) 5ASSI>3RESO/WOR Can't reproduce. Must have been fixed in the meantime. [18:04:16] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf12] The highlight for centered images is taking 100% width - 10https://bugzilla.wikimedia.org/67507#c2 (10James Forrester) 5RESO/WOR>3RESO/FIX a:3Ed Sanders Ha. Yes, fixed by Ed as part of his FocusableNode fixes. [18:04:56] MatmaRex: Nice catch. [18:05:06] MatmaRex: Roan had been putting that off for months. :-) [18:05:14] (03PS7) 10Trevor Parscal: [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 [18:05:23] (03PS8) 10Trevor Parscal: [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 [18:05:49] haha [18:06:12] Not that slacking off ever pays. Ahem. :-) [18:06:12] James_F: Please add https://gerrit.wikimedia.org/r/#/c/160488/ to SWAT [18:06:41] It's probably Ed's unwrapping of generated content or something related that fixed it [18:06:51] MatmaRex: ok, so what I'm hoping you can help me with first is to take that patch, and use the images.json files (changing their contents as you may see fit) to generate the icon CSS instead of us using raster.less/vector.less + icons.less/indicators.less/textures.less [18:06:58] (03CR) 10jenkins-bot: [V: 04-1] [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [18:07:04] also, don't worry too much about minerva's background-color crap [18:07:38] it's evil that they included a background color in an icon class and we can just treat it as an invert variant (may need to modify to the SVG file) [18:07:56] MatmaRex: thoughts? [18:08:39] (I'm going to go take a peek at some other upcoming work for you, server-side OOjs UI [18:09:27] TrevorParscal: okay [18:09:40] Oh screw you Internet Explorer [18:10:01] i'm here for the next hour for sure, ask me whatever you need [18:12:29] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf21] : Citations deleted, are still shown in “Use this group” suggestion list. - 10https://bugzilla.wikimedia.org/70847#c2 (10Rummana Yasmeen) 5UNCO>3RESO/WON Hey Ritu, this is intentional, because even if user deletes the citations that belongs... [18:14:59] 3VisualEditor / 3ContentEditable: VisualEditor bugs: wikilinks, tables, nowiki and other - 10https://bugzilla.wikimedia.org/70396#c2 (10WhatamIdoing) 5UNCO>3RESO/FIX Thanks for posting this. The first problem is "working as designed", but the design is seriously being discussed because of exactly this p... [18:17:31] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf21] :New Section/Add Topic tab when first enabled/disabled, gets added to the toolbar only after clicking on the Edit Source tab. - 10https://bugzilla.wikimedia.org/70848#c2 (10Rummana Yasmeen) 5UNCO>3RESO/DUP *** This bug has been marked as a... [18:18:47] 3VisualEditor / 3Initialisation: VisualEditor: Style and bgcolor attributes normalized by Internet Explorer - 10https://bugzilla.wikimedia.org/70856 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None When you edit a page with VE in IE, CSS styles are normalized, causing dirty diffs. This is because In... [18:27:29] 3VisualEditor / 3ContentEditable: VisualEditor: Spaces at the start of a paragraph aren't very obvious - 10https://bugzilla.wikimedia.org/66628#c3 (10WhatamIdoing) No, they actually are not shown. Download the screenshot and pull it into Preview on your Mac. Zoom in six times, scroll way over to the red o... [18:27:59] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Can't use save form checkboxes in Opera - 10https://bugzilla.wikimedia.org/63615#c6 (10Bartosz Dziewoński) 5ASSI>3RESO/WOR Not reproducible and no response from bug reporter :( [18:32:44] 3VisualEditor: VisualEditor: span tags get added to references - 10https://bugzilla.wikimedia.org/61371#c5 (10Elitre) My guess is that https://cs.wikipedia.org/w/index.php?title=%C4%8Cesk%C3%A1_akademie_v%C4%9Bd_a_um%C4%9Bn%C3%AD&diff=11859116&oldid=11475316 is copy/paste issue as well? [18:34:29] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] In Safari, Cannot enter any input in any dialog and VE gets unresponsive after trying to do that - 10https://bugzilla.wikimedia.org/70578#c2 (10Rummana Yasmeen) This issue happens when you scroll down the page a bit and try adding reference/citation/... [18:34:44] 3VisualEditor: VisualEditor: span tags get added to references - 10https://bugzilla.wikimedia.org/61371#c6 (10Roan Kattouw) Yeah, probably... [18:36:20] (03PS10) 10Esanders: Allow specification of range when getting selection rectangles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160073 [18:36:22] (03PS1) 10Esanders: Rename inlineRects to startAndEndRects everywhere [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160495 [18:38:44] 3VisualEditor / 3ContentEditable: VisualEditor: Pasting lists from Microsoft Word (MS Office) injects hidden HTML cruft like - - 10https://bugzilla.wikimedia.org/69821 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low [18:38:59] 3VisualEditor / 3ContentEditable: VisualEditor: Copying from Microsoft Word adds XML cruft like "gte mso" (mso = Microsoft Office) - 10https://bugzilla.wikimedia.org/69513 (10James Forrester) [18:39:29] 3VisualEditor / 3ContentEditable: VisualEditor: Span tags getting added to references when pasting from Microsoft Office - 10https://bugzilla.wikimedia.org/61371 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Low s:5normal>3minor [18:39:45] 3VisualEditor / 3ContentEditable: VisualEditor: Pasting lists from Microsoft Word (MS Office) injects hidden HTML cruft like - - 10https://bugzilla.wikimedia.org/69821 (10James Forrester) [18:39:45] 3VisualEditor / 3ContentEditable: VisualEditor: Copying from Microsoft Word adds XML cruft like "gte mso" (mso = Microsoft Office) - 10https://bugzilla.wikimedia.org/69513 (10James Forrester) [18:40:33] 3VisualEditor: When you copy and paste a table in VisualEditor, the result shouldn't have newlines and nowikis inserted (scope=col) - 10https://bugzilla.wikimedia.org/70857 (10WhatamIdoing) [18:40:34] 3VisualEditor: When you copy and paste a table in VisualEditor, the result shouldn't have newlines and nowikis inserted (scope=col) - 10https://bugzilla.wikimedia.org/70857 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None See https://fr.wikipedia.org/w/index.php?diff=107442976&oldid=107442557 for an e... [18:40:44] 3VisualEditor / 3Editing Tools: VisualEditor: Support tables (tracking) - 10https://bugzilla.wikimedia.org/39596 (10WhatamIdoing) [18:41:30] 3VisualEditor / 3Initialisation: VisualEditor: Style and bgcolor attributes normalized by Internet Explorer - 10https://bugzilla.wikimedia.org/70856 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Highes s:5normal>3major a:3Roan Kattouw [18:46:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] In Transclusion (multi-template) dialog, moving a template past a content block then focuses the content block, not the selected template - 10https://bugzilla.wikimedia.org/70849#c3 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Low Possibly caus... [18:47:29] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf16] Comment box is not opening in Firefox , throwing error:TypeError: ve.ui.WhitespaceTextInputWidget is not a constructor - 10https://bugzilla.wikimedia.org/68960 (10James Forrester) p:5Unprio>3High [18:47:44] 3VisualEditor / 3Editing Tools: VisualEditor: For all templates , "Template:" is getting added as a prefix while searching from Template dialog box - 10https://bugzilla.wikimedia.org/67384 (10James Forrester) p:5Unprio>3High [18:48:29] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf16] Cannot scroll the link suggestions inside link inspector - 10https://bugzilla.wikimedia.org/69038 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [18:48:59] 3VisualEditor / 3Data Model: VisualEditor: [Regression] Categories and DEFAULTSORT meta items getting modified to strip default whitespace? - 10https://bugzilla.wikimedia.org/65647 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [18:51:29] 3VisualEditor / 3Editing Tools: VisualEditor: Dialogs should have a "cancel" button next to "Apply changes" - 10https://bugzilla.wikimedia.org/52462#c9 (10James Forrester) 5REOP>3RESO/FIX (In reply to John Broughton from comment #8) > If in fact the link tool and the Formula window are outside the scope... [19:01:23] MatmaRex: I'm probably going to get some lunch in a min, how's it going? [19:03:10] TrevorParscal: i'm adjusting existing code to the JSON format, and actually i'm pretty confused by it, was just going to ask [19:03:34] ask away [19:03:54] the handoff was very vague, I'm not surprised :) [19:05:45] TrevorParscal: what is the icons/indicators/textures split meant to represent? just maps to the CSS classes that are to be generated for each icon? [19:05:59] (with the classes being defined in build/images.json) [19:06:42] if yes, then i don't see how i can reconcile that with the ".oo-ui-image-" in classes.variants.prefix [19:07:05] the variants prefixing is just a parent selector [19:07:09] it also confuses me that both icons/indicators/textures and variants are toplevel keys in the objects [19:07:26] and the suffix is the variant name [19:07:45] I'm open to you putting icons/indicators/textures under "images": {} or something [19:07:54] really, I'm open to you just doing what you think is good [19:08:04] I trust you will come up with something sensible [19:08:10] use your judgement, etc. [19:08:17] right, i'm just not sure what's sensible here [19:08:18] hmm [19:08:22] I was basically sketching in JSON [19:08:27] consider it a napkin [19:11:16] i'm not concerned with the input being a sketch, i'm concerned with not understanding what the output is supposed to be [19:11:28] okay, so let's see [19:11:47] we have the 'up' "indicator" in mediawiki theme, with a "constructive" variant [19:12:53] so we need styles for .oo-ui-indicator-up, .oo-ui-indicator-up-constructive, .oo-ui-indicator-up.oo-ui-image-invert, and .oo-ui-indicator-up-constructive.oo-ui-image-invert? [19:13:17] along these lines, i guess [19:13:45] 3VisualEditor / 3Editing Tools: VisualEditor: In template dialog, the “show one more field” control appears when there are 4 entries - 10https://bugzilla.wikimedia.org/70609 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal a:3James Forrester [19:16:10] (03PS1) 10Jforrester: Template dialog: Show up to the limit of parameters, not up to the limit + 1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160500 (https://bugzilla.wikimedia.org/70609) [19:17:01] 3VisualEditor / 3Data Model: Cannot copy text when dm.surface.enabled === false - 10https://bugzilla.wikimedia.org/69515 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal a:3Ed Sanders [19:18:44] one sec MatmaRex [19:21:01] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf21]:"Uncaught TypeError: undefined is not a function" , when media Search dialog is searching for the Media. - 10https://bugzilla.wikimedia.org/70860 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Environment- Test2, beta 1> Go to Media Sea... [19:21:14] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf21]:"Uncaught TypeError: undefined is not a function" , when media Search dialog is searching for the Media. - 10https://bugzilla.wikimedia.org/70860 (10Ritu Swain) [19:21:16] MatmaRex: ah [19:21:29] (03PS1) 10Catrope: Work around position: fixed; bug in Safari [oojs/ui] - 10https://gerrit.wikimedia.org/r/160503 (https://bugzilla.wikimedia.org/70578) [19:21:39] TrevorParscal: https://gerrit.wikimedia.org/r/160503 [19:21:40] so, the MediaWiki skin's built output is a good guide there [19:22:10] (03CR) 10Trevor Parscal: [C: 032] Work around position: fixed; bug in Safari [oojs/ui] - 10https://gerrit.wikimedia.org/r/160503 (https://bugzilla.wikimedia.org/70578) (owner: 10Catrope) [19:23:26] (03Merged) 10jenkins-bot: Work around position: fixed; bug in Safari [oojs/ui] - 10https://gerrit.wikimedia.org/r/160503 (https://bugzilla.wikimedia.org/70578) (owner: 10Catrope) [19:24:02] MatmaRex: so like this:https://gist.github.com/trevorparscal/2c8ce9118580af263558 [19:25:33] the idea is that we can modulate which image is used by adding/removing oo-ui-image-{variant} classes [19:26:25] hmm. okay, that starts making sense [19:26:42] thanks. enojy your lunch [19:26:56] :) [19:32:56] MatmaRex: something to consider, how we might be able to allow downstream users to introduce new images and have them be generated in all the correct colors - like maybe having some form of the theme JSON in the dist and the generator stuff as an NPM module [19:33:00] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf16] Opening link inspector/comment box in an empty line, opens them at the end of the previous line - 10https://bugzilla.wikimedia.org/69122#c14 (10Rummana Yasmeen) 5VERI>3REOP This is again happening for comment box in Betalabs [19:33:02] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf21] : “Size values are invalid” message does not show up , when choosing a different image and customizing its size to 0x0px. - 10https://bugzilla.wikimedia.org/70861 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Created attachment 16473... [19:33:39] (03PS5) 10Alex Monk: Split out isPending, pushPending, popPending, etc. into PendingElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/156459 [19:33:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In Safari, Cannot enter any input in any dialog and VE gets unresponsive after trying to do that - 10https://bugzilla.wikimedia.org/70578 (10James Forrester) 5PATC>3RESO/FIX [19:33:45] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf21] : “Size values are invalid” message does not show up , when choosing a different image and customizing its size to 0x0px. - 10https://bugzilla.wikimedia.org/70861#c1 (10Ritu Swain) Created attachment 16474 --> https://bugzilla.wikimedia.org/att... [19:34:14] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf21] : “Size values are invalid” message does not show up , when choosing a different image and customizing its size to 0x0px. - 10https://bugzilla.wikimedia.org/70861 (10Ritu Swain) [19:35:31] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In media dialog, "Size values are invalid" message does not show up, when choosing a different image and then setting its size to 0 x 0 px - 10https://bugzilla.wikimedia.org/70861 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal a:3Mo... [19:37:44] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf21] : Citations deleted, are still shown in “Use this group” suggestion list. - 10https://bugzilla.wikimedia.org/70847#c3 (10Ritu Swain) (In reply to Rummana Yasmeen from comment #2) > Hey Ritu, this is intentional, because even if user deletes the... [19:41:04] (03PS11) 10Alex Monk: Show pending state on action button and keep dialog open when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) [19:42:44] (03CR) 10jenkins-bot: [V: 04-1] Show pending state on action button and keep dialog open when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [19:45:00] (03PS12) 10Alex Monk: Show pending state on action button and keep dialog open when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) [19:54:14] 3VisualEditor / 3ContentEditable: VisualEditor: Mouse up outside the surface doesn't register a selection change. - 10https://bugzilla.wikimedia.org/59822#c7 (10Rummana Yasmeen) Verified the fix in Betalabs [19:55:23] (03CR) 10Trevor Parscal: [C: 032] Split out isPending, pushPending, popPending, etc. into PendingElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/156459 (owner: 10Alex Monk) [19:56:14] (03Merged) 10jenkins-bot: Split out isPending, pushPending, popPending, etc. into PendingElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/156459 (owner: 10Alex Monk) [19:58:24] TrevorParscal: indeed, when colorize-svg.js is somewhat stable, we should make it an npm module [19:59:57] ok, really going to lunch now [19:59:59] talk soon [20:00:34] (03PS4) 10Bartosz Dziewoński: [POC] Colorize SVG icons into defined color variants [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 [20:01:25] ^ (so far just adjusted the colorizing code to the new input format, it's a bit messy :/) [20:01:39] (03CR) 10jenkins-bot: [V: 04-1] [POC] Colorize SVG icons into defined color variants [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 (owner: 10Bartosz Dziewoński) [20:31:34] (03PS2) 10Jforrester: build: Use cssmin after cssjanus rather than before to fix RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 [20:31:36] (03PS2) 10Jforrester: build: Use csscomb to prettify the CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/159076 [20:32:07] (03CR) 10jenkins-bot: [V: 04-1] build: Use cssmin after cssjanus rather than before to fix RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 (owner: 10Jforrester) [20:32:30] (03PS3) 10Jforrester: build: Create minified JS and CSS distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 [20:33:15] (03CR) 10jenkins-bot: [V: 04-1] build: Create minified JS and CSS distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 (owner: 10Jforrester) [20:33:22] (03CR) 10Jforrester: "PS2 is a rebase onto "Use csscomb to prettify the CSS" and clean-up." [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 (owner: 10Jforrester) [20:48:14] (03PS1) 10Cmcmahon: [BrowserTests] Pick up the latest webdriver to run latest Firefox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160514 [20:48:55] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160514 (owner: 10Cmcmahon) [20:49:55] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTests] Pick up the latest webdriver to run latest Firefox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160514 (owner: 10Cmcmahon) [20:50:06] chrismcmahon: Whoops. [20:50:22] James_F: ? [20:50:35] (03Merged) 10jenkins-bot: [BrowserTests] Pick up the latest webdriver to run latest Firefox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160514 (owner: 10Cmcmahon) [20:50:40] chrismcmahon: The V-1 from the qunit job running on the one slave that doesn't work. [20:50:47] heh. [20:50:55] chrismcmahon: It's a sign too many things are flying around for Zuul to despatch correctly. :-) [20:51:17] James_F: I successfully put off the FF upgrade locally until just now, FF snuck it in. Apparently S did the same. [20:51:26] Ha. [20:56:20] James_F: one thing I want to do this quarter is plan out a sane set of hosts for Jenkins/Zuul master-slave stuff. We have the horsepower available now, it's just not yet been done. [20:56:52] it's bubble gum and baling wire right now, and has been [20:57:06] chrismcmahon: Yeah, Krinkle's actually working on that right now (adding some more slaves), but mostly for the Precise -> Trusty switchover. [21:10:10] MatmaRex: how's it going? [21:10:49] (03PS5) 10Bartosz Dziewoński: [POC] Colorize SVG icons into defined color variants [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 [21:10:54] TrevorParscal: like this ^ [21:11:11] gah, is there any way to apply a diff like https://gist.githubusercontent.com/Krenair/ff4b3121e05a7c93b4fc/raw/86f3867038bdd72c942909f88dcdc797e5841957/gistfile1.diff ? [21:11:31] TrevorParscal: i did the mediawiki theme only, and it sorta kinda works, but i don't really understand the build process and some things don't [21:11:36] I lost the branch somewhere [21:11:46] (03CR) 10jenkins-bot: [V: 04-1] [POC] Colorize SVG icons into defined color variants [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 (owner: 10Bartosz Dziewoński) [21:11:54] Krenair: curl … | git apply? [21:12:26] TrevorParscal: the broken parts are mostly commented on in various files [21:12:32] nothing applies cleanly :/ [21:14:17] Krenair: curl .. | patch -p1 --merge [21:14:27] (start with a clean state for sanity) [21:15:33] MatmaRex: looks like you are on your way here [21:15:35] brb [21:17:20] brb also. [21:28:59] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf16] Opening link inspector/comment box in an empty line, opens them at the end of the previous line - 10https://bugzilla.wikimedia.org/69122#c15 (10Rummana Yasmeen) (In reply to Rummana Yasmeen from comment #14) > This is again happening for both... [21:34:17] (03PS11) 10Alex Monk: Get confirmation when trying to insert/edit template/citation with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) [21:35:57] (03CR) 10jenkins-bot: [V: 04-1] Get confirmation when trying to insert/edit template/citation with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk) [21:36:08] (03PS12) 10Alex Monk: Get confirmation when trying to insert/edit template/citation with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) [21:37:16] (03CR) 10Alex Monk: [C: 04-1] "Various issues I forgot about." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk) [21:37:45] (03CR) 10jenkins-bot: [V: 04-1] Get confirmation when trying to insert/edit template/citation with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk) [21:40:14] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf20] The link target suggestion drop down is appearing cut off to a very small size upon first time opening the link inspector - 10https://bugzilla.wikimedia.org/70683#c1 (10Rummana Yasmeen) Created attachment 16475 --> https://bugzilla.wikimedia.... [21:40:59] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf20] The link target suggestion drop down is appearing cut off to a very small size upon first time opening the link inspector - 10https://bugzilla.wikimedia.org/70683#c2 (10Rummana Yasmeen) Created attachment 16476 --> https://bugzilla.wikimedia.... [21:48:51] (03PS1) 10Cmcmahon: [BrowserTest] inadvertent clash of identifiers from earlier update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160525 [21:49:31] (03PS13) 10Alex Monk: Get confirmation when trying to insert/edit template/citation with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) [21:51:42] RoanKattouw, that worked, thanks [22:13:32] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160525 (owner: 10Cmcmahon) [22:15:08] (03Merged) 10jenkins-bot: [BrowserTest] inadvertent clash of identifiers from earlier update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160525 (owner: 10Cmcmahon) [22:19:03] James_F: https://gerrit.wikimedia.org/r/160535 [22:19:14] Also needs a VE core equivalent but I didn't do it yet because my working copy is dirty [22:23:07] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (49b64bdba7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160537 [22:23:09] RoanKattouw: Done. ^^^ [22:23:45] ryasmeen: The Safari fix should be live on beta labs in a few minutes [22:23:50] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (49b64bdba7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160537 (owner: 10Jforrester) [22:25:28] TrevorParscal: so, any thoughts? does that look like it would work? [22:26:08] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (49b64bdba7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160537 (owner: 10Jforrester) [22:27:17] 3VisualEditor / 3Editing Tools: VisualEditor: The Cite and Re-use options remains enabled even if the toolbar gets disabled when user clicks outside - 10https://bugzilla.wikimedia.org/70870 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16477 --> https://bugzilla.wikimedia.... [22:27:42] TrevorParscal: looks like i'll need to replicate the dir structure with raster.less and vector.less, is there no better way to do this? [22:28:17] RoanKattouw: cool! Thanks, and we are going to BP it? since it is a regression [22:40:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] The Cite and Re-use options remains enabled even if the toolbar gets disabled when user clicks outside - 10https://bugzilla.wikimedia.org/70870 (10Rummana Yasmeen) [22:42:57] MatmaRex: um [22:43:21] ok, so, where are you at, sorry I was talking to people near my desk [22:43:37] so, we have no URL remapping right now [22:44:00] which means you are stuck recreating the dir structures the images are in relative to their stylesheets [22:44:02] yeah? [22:46:31] TrevorParscal: well, yeah, but that's not a problem [22:47:16] things that don't work are: [22:47:32] raster vs vector stylesheets, the setup for this looks ugly and i didn't bother until i have to [22:48:03] no place to put the generated less files, since afaict they're not supposed to be part of the distribution [22:48:44] well, we can do one of two things [22:48:53] and the FIXMEs in gruntfile [22:48:58] 1, not use less to generate this particular CSS (very common with such systems) [22:49:21] 2, generate them, and then remove them after processing [22:49:29] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In Safari, Cannot enter any input in any dialog and VE gets unresponsive after trying to do that - 10https://bugzilla.wikimedia.org/70578#c5 (10Rummana Yasmeen) Verified the fix in Betalabs [22:49:43] sure, i can do 2, i was just wondering if there is a right way to do this before i reimplement everything [22:59:01] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] The Cite and Re-use options remains enabled even if the toolbar gets disabled when user clicks outside - 10https://bugzilla.wikimedia.org/70870 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Alex Monk [23:06:27] (03PS1) 10Catrope: Update VE core for cherry-picks of If67fe35b and I80d0632fd [extensions/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160553 [23:06:43] (03CR) 10Catrope: [C: 032 V: 032] Update VE core for cherry-picks of If67fe35b and I80d0632fd [extensions/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160553 (owner: 10Catrope) [23:07:17] 3VisualEditor / 3Editing Tools: VisualEditor: In Safari, Citation dialog opens with a weird animation and placing the cursor inside a parameter field enlarges it - 10https://bugzilla.wikimedia.org/70872 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16478 --> https://bugzil... [23:09:42] (03Abandoned) 10Jforrester: Update VE core submodule to cherry-pick (d9658b2) [extensions/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160114 (owner: 10Jforrester) [23:11:00] 3VisualEditor / 3MediaWiki integration: VisualEditor: Switching to source mode should show a spinner, pending state or similar - 10https://bugzilla.wikimedia.org/65012 (10James Forrester) [23:12:44] 3VisualEditor / 3Editing Tools: VisualEditor: Do not let me tab outside the dialog box in Chrome/Safari - 10https://bugzilla.wikimedia.org/67156 (10James Forrester) [23:12:45] 3VisualEditor / 3Editing Tools: VisualEditor: Reference group input combo box does not populate the Reference group names if created from Reference list dialog - 10https://bugzilla.wikimedia.org/70365 (10James Forrester) [23:18:52] (03CR) 10Esanders: [C: 032] Add keyboard shortcuts for strikethrough and code annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160174 (https://bugzilla.wikimedia.org/52597) (owner: 10Jforrester) [23:19:34] (03PS1) 10Alex Monk: Check whether there is a range selected when enabling/disabling re-use citation tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160556 (https://bugzilla.wikimedia.org/70870) [23:21:18] (03CR) 10Catrope: [C: 032] Check whether there is a range selected when enabling/disabling re-use citation tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160556 (https://bugzilla.wikimedia.org/70870) (owner: 10Alex Monk) [23:21:51] (03Merged) 10jenkins-bot: Add keyboard shortcuts for strikethrough and code annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160174 (https://bugzilla.wikimedia.org/52597) (owner: 10Jforrester) [23:22:02] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] The Cite and Re-use options remains enabled even if the toolbar gets disabled when user clicks outside - 10https://bugzilla.wikimedia.org/70870 (10Alex Monk) 5PATC>3RESO/FIX [23:23:01] (03Merged) 10jenkins-bot: Check whether there is a range selected when enabling/disabling re-use citation tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160556 (https://bugzilla.wikimedia.org/70870) (owner: 10Alex Monk) [23:26:16] (03PS3) 10Jforrester: Add contextual help to all remaining meta dialog controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160371 (https://bugzilla.wikimedia.org/51798) [23:28:02] ryasmeen: Could you verify if bug 70770 and bug 70777 are now fixed in test2? [23:29:30] RoanKattouw: 70770 and all related issues with it is fixed [23:29:35] I am checking the other one [23:30:15] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] Cannot open any inspector, throwing error "Uncaught TypeError: Cannot read property 'top' of undefined" - 10https://bugzilla.wikimedia.org/70782#c2 (10Rummana Yasmeen) Verified the fix in test2 [23:30:29] 3VisualEditor / 3Initialisation: VisualEditor: [Regression wmf 21] “Uncaught TypeError: Cannot read property 'top' of undefined” when Editor is launched - 10https://bugzilla.wikimedia.org/70770#c11 (10Rummana Yasmeen) Verified the fix in test2 [23:32:01] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf21] Editor is displayed with two toolbars on second initialisation - 10https://bugzilla.wikimedia.org/70768#c9 (10Rummana Yasmeen) Verified the fix in test2 [23:40:14] 3VisualEditor / 3Technical Debt: VisualEditor: Nicer removal of Cite.php's class=error - 10https://bugzilla.wikimedia.org/51141#c4 (10Alex Monk) (In reply to James Forrester from comment #3) > Sorry! > > This refers to the hacky fix for bug 50423 which added (eventually): > > /* HACK: Hide Ref errors in... [23:40:59] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In Safari, Cannot enter any input in any dialog and VE gets unresponsive after trying to do that - 10https://bugzilla.wikimedia.org/70578#c6 (10Rummana Yasmeen) Verified the fix in test2 [23:58:17] 3VisualEditor / 3Editing Tools: VisualEditor: Add a shortcut for strikethrough (?which?) - 10https://bugzilla.wikimedia.org/60257 (10James Forrester) 5PATC>3RESO/FIX [23:58:17] 3VisualEditor / 3Editing Tools: VisualEditor: Add keyboard shortcut for code element/style - 10https://bugzilla.wikimedia.org/52597 (10James Forrester) 5PATC>3RESO/FIX [23:58:59] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] Inserting multi-node template (?) causes endless snowmen - 10https://bugzilla.wikimedia.org/70777#c5 (10Rummana Yasmeen) Verified the fix in mediawiki.org with the case mentioned above.