[00:10:19] (03PS3) 10Jforrester: build: Make headers atop dist files suitable for distribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 (owner: 10Krinkle) [00:11:31] 3OOjs UI: OOjs UI: Auto-shortening of dialog titles when there's insufficient space isn't working - 10https://bugzilla.wikimedia.org/68571 (10Bartosz Dziewoński) a:5James Forrester>3Bartosz Dziewoński [00:25:20] (03CR) 10Krinkle: [C: 032] build: Bump miscellaneous devDependencies to latest [oojs/core] - 10https://gerrit.wikimedia.org/r/160261 (owner: 10Jforrester) [00:26:53] (03CR) 10Krinkle: [C: 032] build: Bump miscellaneous devDependencies to latest [oojs/ui] - 10https://gerrit.wikimedia.org/r/160263 (owner: 10Jforrester) [00:28:13] (03Merged) 10jenkins-bot: build: Bump miscellaneous devDependencies to latest [oojs/ui] - 10https://gerrit.wikimedia.org/r/160263 (owner: 10Jforrester) [00:28:27] (03Merged) 10jenkins-bot: build: Bump miscellaneous devDependencies to latest [oojs/core] - 10https://gerrit.wikimedia.org/r/160261 (owner: 10Jforrester) [00:42:21] (03CR) 10Krinkle: [C: 032] build: Bump miscellaneous devDependencies to latest [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160267 (owner: 10Jforrester) [00:44:03] (03Merged) 10jenkins-bot: build: Bump miscellaneous devDependencies to latest [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160267 (owner: 10Jforrester) [00:45:52] (03CR) 10Krinkle: [C: 032] build: Bump miscellaneous devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160265 (owner: 10Jforrester) [00:47:13] (03Merged) 10jenkins-bot: build: Bump miscellaneous devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160265 (owner: 10Jforrester) [00:50:21] (03PS4) 10Jforrester: build: Create minified JS and CSS distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 [00:50:23] (03PS3) 10Jforrester: build: Use csscomb to prettify the CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/159076 [00:50:35] (03CR) 10Jforrester: "PS3 is a rebase." [oojs/ui] - 10https://gerrit.wikimedia.org/r/159076 (owner: 10Jforrester) [00:50:47] (03CR) 10Jforrester: "PS4 is a rebase." [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 (owner: 10Jforrester) [00:55:06] edsanders: There's a leaf comment here, https://gerrit.wikimedia.org/r/#/c/155839/, was that handled / bug filed? [01:02:04] no [01:02:28] I have a local fix that may work, was waiting for iOS devices to test [01:02:37] edsanders: Good news! ;-) [01:17:12] (03PS2) 10Esanders: Rename inlineRects to startAndEndRects everywhere [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160495 [01:17:14] (03PS10) 10Esanders: Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 [01:17:16] (03PS11) 10Esanders: Allow specification of range when getting selection rectangles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160073 [01:17:18] (03PS4) 10Esanders: Add getNativeRange method with optional DM range argument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160303 [01:17:20] (03PS1) 10Esanders: Remove getSelection*Client* methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160579 [01:29:12] edsanders: https://gerrit.wikimedia.org/r/#/c/160371/ [01:29:25] (03CR) 10Esanders: [C: 032] Add contextual help to all remaining meta dialog controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160371 (https://bugzilla.wikimedia.org/51798) (owner: 10Jforrester) [01:30:56] (03CR) 10Esanders: [C: 04-2] "Should be abandoned as a result of I92fdcc24c611, unless a really quick fix is needed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160171 (owner: 10Catrope) [01:31:13] (03Merged) 10jenkins-bot: Add contextual help to all remaining meta dialog controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160371 (https://bugzilla.wikimedia.org/51798) (owner: 10Jforrester) [01:32:44] 3VisualEditor / 3Editing Tools: VisualEditor: There should be help links in every context - dialog boxes, inspectors, etc. - 10https://bugzilla.wikimedia.org/51798#c16 (10James Forrester) 5PATC>3ASSI The page settings ("meta") dialog now has a complete set of contextual help. Will wait for further user f... [01:36:22] (03PS1) 10Catrope: Work around IE's normalization of style attributes by abusing XML parsers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160583 [01:37:30] edsanders: ^^^ [01:41:38] (03PS1) 10Catrope: Use ve.parseXhtml() and ve.serializeXhtml() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160584 [01:41:42] (03PS2) 10Catrope: Work around IE's normalization of style attributes by abusing XML parsers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160583 (https://bugzilla.wikimedia.org/70856) [01:41:54] (03PS2) 10Catrope: Use ve.parseXhtml() and ve.serializeXhtml() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160584 (https://bugzilla.wikimedia.org/70856) [01:42:11] (03CR) 10Esanders: [C: 031] "so far so good" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160583 (https://bugzilla.wikimedia.org/70856) (owner: 10Catrope) [01:45:49] (03PS1) 10Jforrester: Update VE core submodule to master (0facbc0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160586 [01:46:32] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (0facbc0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160586 (owner: 10Jforrester) [01:48:12] (03Merged) 10jenkins-bot: Update VE core submodule to master (0facbc0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160586 (owner: 10Jforrester) [02:17:33] (03PS1) 10Esanders: Provide a method to get all the rectangles for a given selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160591 [02:18:29] Krinkle: https://gerrit.wikimedia.org/r/#/c/159076/ [02:25:32] (03PS3) 10Catrope: Work around IE's normalization of style attributes by abusing XML parsers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160583 [02:25:37] edsanders: Now with unit tests ---^^ [02:31:01] (03CR) 10Esanders: [C: 032] Work around IE's normalization of style attributes by abusing XML parsers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160583 (owner: 10Catrope) [02:32:17] (03Merged) 10jenkins-bot: Work around IE's normalization of style attributes by abusing XML parsers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160583 (owner: 10Catrope) [02:32:21] (03CR) 10Esanders: [C: 031] "Needs core pullthrough" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160584 (https://bugzilla.wikimedia.org/70856) (owner: 10Catrope) [02:35:13] edsanders: ^^^ [02:35:15] Err. [02:35:18] (03PS1) 10Jforrester: Update VE core submodule to master (ebc8569) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160592 [02:35:18] edsanders: vvv [02:35:20] Bah. [02:36:01] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (ebc8569) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160592 (owner: 10Jforrester) [02:36:22] (03PS1) 10Jforrester: Work around IE's normalization of style attributes by abusing XML parsers [VisualEditor/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160593 [02:36:48] (03PS1) 10Jforrester: Work around IE's normalization of style attributes by abusing XML parsers [VisualEditor/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160594 [02:37:43] (03Merged) 10jenkins-bot: Update VE core submodule to master (ebc8569) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160592 (owner: 10Jforrester) [02:38:00] (03CR) 10Jforrester: [C: 032] "Per Ed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160584 (https://bugzilla.wikimedia.org/70856) (owner: 10Catrope) [02:38:15] (03PS1) 10Jforrester: Use ve.parseXhtml() and ve.serializeXhtml() [extensions/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160596 (https://bugzilla.wikimedia.org/70856) [02:38:34] (03PS1) 10Jforrester: Use ve.parseXhtml() and ve.serializeXhtml() [extensions/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160597 (https://bugzilla.wikimedia.org/70856) [02:39:20] (03CR) 10jenkins-bot: [V: 04-1] Use ve.parseXhtml() and ve.serializeXhtml() [extensions/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160596 (https://bugzilla.wikimedia.org/70856) (owner: 10Jforrester) [02:39:28] Ick. [02:39:41] (03Merged) 10jenkins-bot: Use ve.parseXhtml() and ve.serializeXhtml() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160584 (https://bugzilla.wikimedia.org/70856) (owner: 10Catrope) [02:40:06] Oh, yeah, just too many of them at once. [02:43:06] (03CR) 10Catrope: [C: 032 V: 032] Work around IE's normalization of style attributes by abusing XML parsers [VisualEditor/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160594 (owner: 10Jforrester) [02:43:36] (03CR) 10Catrope: [C: 032] Use ve.parseXhtml() and ve.serializeXhtml() [extensions/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160596 (https://bugzilla.wikimedia.org/70856) (owner: 10Jforrester) [02:44:15] (03CR) 10Catrope: [C: 032 V: 032] Work around IE's normalization of style attributes by abusing XML parsers [VisualEditor/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160593 (owner: 10Jforrester) [02:44:35] (03CR) 10jenkins-bot: [V: 04-1] Use ve.parseXhtml() and ve.serializeXhtml() [extensions/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160596 (https://bugzilla.wikimedia.org/70856) (owner: 10Jforrester) [02:44:37] (03CR) 10Jforrester: [C: 031] build: Make headers atop dist files suitable for distribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 (owner: 10Krinkle) [02:45:24] (03PS1) 10Catrope: Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160600 [02:45:32] (03PS4) 10Jforrester: build: Use csscomb to prettify the CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/159076 [02:46:12] edsanders: Please +2 https://gerrit.wikimedia.org/r/#/c/160600/ and https://gerrit.wikimedia.org/r/#/c/160601/ [02:46:18] (03PS1) 10Catrope: Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160601 [02:46:29] (03CR) 10jenkins-bot: [V: 04-1] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160600 (owner: 10Catrope) [02:48:08] (03CR) 10Catrope: "recheck" [extensions/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160600 (owner: 10Catrope) [02:48:40] (03PS3) 10Esanders: Rename inlineRects to startAndEndRects everywhere [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160495 [02:48:42] (03PS11) 10Esanders: Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 [02:48:44] (03PS2) 10Esanders: Remove getSelection*Client* methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160579 [02:48:46] (03PS10) 10Esanders: Refactor out finding of CE focusedNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159949 [02:48:48] (03PS2) 10Esanders: Provide a method to get all the rectangles for a given selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160591 [02:48:50] (03PS12) 10Esanders: Allow specification of range when getting selection rectangles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160073 [02:48:52] (03PS5) 10Esanders: Add getNativeRange method with optional DM range argument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160303 [02:49:35] (03CR) 10Catrope: [C: 032 V: 032] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160600 (owner: 10Catrope) [02:49:47] (03CR) 10Catrope: [C: 032 V: 032] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160601 (owner: 10Catrope) [02:51:23] (03PS2) 10Catrope: Use ve.parseXhtml() and ve.serializeXhtml() [extensions/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160596 (https://bugzilla.wikimedia.org/70856) (owner: 10Jforrester) [02:51:26] (03PS2) 10Catrope: Use ve.parseXhtml() and ve.serializeXhtml() [extensions/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160597 (https://bugzilla.wikimedia.org/70856) (owner: 10Jforrester) [02:51:42] (03CR) 10Catrope: [C: 032 V: 032] Use ve.parseXhtml() and ve.serializeXhtml() [extensions/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160596 (https://bugzilla.wikimedia.org/70856) (owner: 10Jforrester) [02:51:50] (03CR) 10Catrope: [C: 032 V: 032] Use ve.parseXhtml() and ve.serializeXhtml() [extensions/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160597 (https://bugzilla.wikimedia.org/70856) (owner: 10Jforrester) [03:12:40] (03PS5) 10Jforrester: build: Use csscomb to prettify the CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/159076 [03:12:49] (03CR) 10jenkins-bot: [V: 04-1] build: Use csscomb to prettify the CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/159076 (owner: 10Jforrester) [03:17:04] (03PS6) 10Jforrester: build: Use csscomb to prettify the CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/159076 [03:18:14] 3VisualEditor / 3Initialisation: VisualEditor: Style and bgcolor attributes normalized by Internet Explorer - 10https://bugzilla.wikimedia.org/70856#c8 (10James Forrester) 5PATC>3RESO/FIX Deploy scheduled for 08:00 SF time tomorrow. [07:58:16] 3VisualEditor / 3MediaWiki integration: VisualEditor: {{lowercasetitle}} is not reflected in Display title in Advanced page settings - 10https://bugzilla.wikimedia.org/70880 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None The article [[iOS]] in the English Wikipedia has {{lowercasetitle}}, which... [11:49:15] (03PS6) 10Bartosz Dziewoński: [POC] Colorize SVG icons into defined color variants [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 [11:50:11] (03CR) 10jenkins-bot: [V: 04-1] [POC] Colorize SVG icons into defined color variants [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 (owner: 10Bartosz Dziewoński) [11:58:41] (03PS9) 10Bartosz Dziewoński: [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [11:59:14] (03CR) 10Bartosz Dziewoński: "(Fixed the demo not loading because it's been annoying me.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [11:59:28] (03CR) 10jenkins-bot: [V: 04-1] [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [12:04:50] (03PS7) 10Bartosz Dziewoński: [POC] Colorize SVG icons into defined color variants [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 [12:05:48] (03CR) 10jenkins-bot: [V: 04-1] [POC] Colorize SVG icons into defined color variants [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 (owner: 10Bartosz Dziewoński) [12:25:34] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk) [12:49:24] (03PS8) 10Bartosz Dziewoński: Colorize SVG files into defined color variants, output image LESS [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 [12:50:09] (03CR) 10jenkins-bot: [V: 04-1] Colorize SVG files into defined color variants, output image LESS [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 (owner: 10Bartosz Dziewoński) [12:51:10] (03CR) 10Bartosz Dziewoński: "This seems to work as expected now and I mostly like how it has turned out. See commit message for outstanding issues." [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 (owner: 10Bartosz Dziewoński) [13:44:11] (03CR) 10Siebrand: "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [14:54:01] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/36739 (owner: 10Hashar) [14:54:39] (03PS10) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/36739 [14:56:39] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/36739 (owner: 10Hashar) [15:00:47] 3VisualEditor / 3Editing Tools: VisualEditor: Citations appear broken for a few moments, before getting inserted in a Basic Reference dialog . - 10https://bugzilla.wikimedia.org/70884 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Created attachment 16482 --> https://bugzilla.wikimedia.org/attachm... [15:00:59] 3VisualEditor / 3Editing Tools: VisualEditor: Citations appear broken for a few moments, before getting inserted in a Basic Reference dialog . - 10https://bugzilla.wikimedia.org/70884 (10Ritu Swain) [15:11:38] (03CR) 10Hashar: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/36739 (owner: 10Hashar) [16:05:46] (03PS14) 10Alex Monk: Get confirmation when trying to insert/edit template/citation with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) [16:32:48] 3VisualEditor / 3Data Model: VisualEditor: Citations in the Re-use reference list do not get sorted by their numbers on second initialisation . - 10https://bugzilla.wikimedia.org/70886 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16483 --> https://bugzilla.wikimedia.org/atta... [16:33:15] 3VisualEditor / 3Data Model: VisualEditor: Citations in the Re-use reference list do not get sorted by their numbers on second initialisation . - 10https://bugzilla.wikimedia.org/70886#c1 (10Ritu Swain) Created attachment 16484 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16484&action=edit Referen... [16:33:59] 3VisualEditor / 3Data Model: VisualEditor: Citations in the Re-use reference list do not get sorted by their numbers on second initialisation . - 10https://bugzilla.wikimedia.org/70886#c2 (10Ritu Swain) Created attachment 16485 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16485&action=edit Referen... [16:34:29] 3VisualEditor / 3Data Model: VisualEditor: Citations in the Re-use reference list do not get sorted by their numbers on second initialisation . - 10https://bugzilla.wikimedia.org/70886#c3 (10Ritu Swain) Created attachment 16486 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16486&action=edit In Beta... [16:35:16] 3VisualEditor / 3Data Model: VisualEditor: Citations in the Re-use reference list do not get sorted by their numbers on second initialisation . - 10https://bugzilla.wikimedia.org/70886#c4 (10Ritu Swain) Created attachment 16487 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16487&action=edit In Beta... [16:35:44] 3VisualEditor / 3Data Model: VisualEditor: Citations in the Re-use reference list do not get sorted by their numbers on second initialisation . - 10https://bugzilla.wikimedia.org/70886 (10Ritu Swain) [16:48:17] 3VisualEditor / 3Editing Tools: VisualEditor: "Uncaught TypeError: Cannot read property 'getSurface' of null" when selecting a text style with citation highlighted - 10https://bugzilla.wikimedia.org/70888 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Created attachment 16488 --> https://bugzilla.... [16:48:30] 3VisualEditor / 3Editing Tools: VisualEditor: "Uncaught TypeError: Cannot read property 'getSurface' of null" when selecting a text style with citation highlighted - 10https://bugzilla.wikimedia.org/70888 (10Ritu Swain) [17:11:27] Is hangouts completely broken? [17:13:56] Krenair: yes it is, by design; but it happens to work for other people right now :P [17:16:29] I can't use text chat to the group either. [17:16:37] "We're having trouble connecting to Google. We'll keep trying..." [17:16:57] https://bugzilla.wikimedia.org/show_bug.cgi?id=70886 just came up so I'll look at that [17:17:55] I couldn't think of a lessy hacky solution to the Cite.php error suppression bug, left a comment [17:19:15] Need to fix my patch for https://bugzilla.wikimedia.org/show_bug.cgi?id=70504 so it can handle double interwiki links, ugh. [17:22:39] Double interwikis are handled so poorly by pretty much everything [17:23:03] RoanKattouw: Hmm, the servers are now reporting the right version… [17:23:07] RoanKattouw: Yay for scap. [17:23:08] OK good [17:23:17] James_F: Easy test: check if ve.parseXhtml is defined [17:23:34] And ve.isStyleAttributeBroken should be false in non-IE browsers [17:23:57] Yes and yes. [17:30:26] https://code.google.com/p/chromium/issues/detail?id=324437& [17:33:55] What's the coding standard for PHP splitting on ->s? "foo\n->bar()\n->baz()" OK? [17:34:29] yes [17:34:32] OK. [17:35:20] bah, my name is wrong in more places. why is it so hard to copy and paste… [17:36:35] :-( [17:36:42] (03PS1) 10Jforrester: Make message respect plural rules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160699 [17:36:49] Is there a problem with EV ? https://fr.wikipedia.org/w/index.php?title=Coloration%20des%20mati%C3%A8res%20organiques%20dissoutes%20dans%20l%27eau&diff=107509413&oldid=96876645&unhide=1 https://fr.wikipedia.org/w/index.php?title=Exotoxine&diff=prev&oldid=107508831 [17:37:47] Oh dear. Krenair ^^^ any chance that's us? [17:40:45] What the [17:41:10] Frakir: Whoa that's a scary bug. Let me see if I can reproduce that [17:42:26] Yup that's a VE bug [17:43:55] James_F: That's nothing to do with any of Krenair's changes most likely, it seems like it's a DM-related thing [17:45:12] But only in Firefox?! [17:45:13] WTF [17:45:59] RoanKattouw: New? [17:46:10] Probably? [17:46:15] Trying to figure out what is going on [17:46:27] It doesn't get a NeedCheeck; [17:47:19] Krinkle: BTW, you said you were going to +2 https://gerrit.wikimedia.org/r/#/c/159076/ last night and didn't. :_) [17:47:34] (03PS5) 10Jforrester: build: Create minified JS and CSS distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 [17:48:13] James_F: Yeah it's a Parsoid problem [17:48:28] But I don't yet understand what is going on or why it's happening in Firefox but not Chrome [17:48:59] (03CR) 10jenkins-bot: [V: 04-1] build: Create minified JS and CSS distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 (owner: 10Jforrester) [17:49:26] James_F: So, is the .csscomb.json needed still? Or did we try without it? [17:49:33] I guess the reason that didn't work was due to the npm version [17:49:35] so it should work [17:49:40] that'd be all [17:53:22] RoanKattouw: Fun. [17:53:37] Krinkle: Yeah, but we made a custom .csscomb.json file intentionally… [17:53:56] James_F: There is no such thing as a default csscomb file, it's about a custom file name, not a custom file [17:53:59] we dont have a custom file name [17:54:12] I'm fine with hardcoding it if you think the default file name is undocumented. [17:54:46] Krinkle: Oh, you mean, is the config pointing to the .csscomb.json file needed? No. [17:54:53] Exactly [17:55:05] Want me to fix? [17:55:18] Sure [17:55:29] 3VisualEditor / 3Data Model: VisualEditor: Re-use an existing reference shouldn't require a reference list to be or have been on the page to work - 10https://bugzilla.wikimedia.org/68079 (10Rummana Yasmeen) [17:55:44] 3VisualEditor / 3Data Model: VisualEditor: Citations in the Re-use reference list do not get sorted by their numbers on second initialisation . - 10https://bugzilla.wikimedia.org/70886 (10Rummana Yasmeen) [17:55:51] (03PS7) 10Jforrester: build: Use csscomb to prettify the CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/159076 [17:56:47] 3VisualEditor / 3Data Model: VisualEditor: Re-use an existing reference shouldn't require a reference list to be or have been on the page to work - 10https://bugzilla.wikimedia.org/68079 (10Rummana Yasmeen) [17:56:47] 3VisualEditor / 3Data Model: VisualEditor: Citations in the Re-use reference list do not get sorted by their numbers on second initialisation . - 10https://bugzilla.wikimedia.org/70886 (10Rummana Yasmeen) [17:58:14] RoanKattouw, what do you do in firefox to trigger this? Cannot reproduce [17:58:58] Krenair: http://fr.wikipedia.org/w/index.php?title=Exotoxine&veaction=edit , make a change, view idff [17:59:08] Not just review changes? [17:59:14] Yes review changes sory [17:59:30] You'll see the category at the bottom be converted to Badtitletext [17:59:45] (I tested locally, btw) [18:00:18] I think the name of the category has to have é in it [18:00:32] It's because Firefox URL-encodes but Chrome doesn't [18:00:34] Parsoid bug [18:01:19] It begins 2,5h ago https://fr.wikipedia.org/wiki/Sp%C3%A9cial:Journal_du_filtre_antiabus?wpSearchUser=&wpSearchFilter=14&wpSearchTitle= (and spaces are replaced by underscores in [[links]]) [18:01:57] RoanKattouw, in the same diffs, there were aldo some replacings of spaces by underscores in some internal links [18:01:59] 3VisualEditor / 3Editing Tools: VisualEditor: "Uncaught TypeError: Cannot read property 'getSurface' of null" when applying a heading format on citation - 10https://bugzilla.wikimedia.org/70888#c1 (10Rummana Yasmeen) 5UNCO>3NEW I could reproduce it while applying the text style, but the heading styles on... [18:02:08] also [18:02:14] 3VisualEditor / 3Editing Tools: VisualEditor: "Uncaught TypeError: Cannot read property 'getSurface' of null" when applying a heading format on citation - 10https://bugzilla.wikimedia.org/70888#c2 (10Rummana Yasmeen) (In reply to Rummana Yasmeen from comment #1) > I could not reproduce it while applying the... [18:03:25] Hmm... Aren't frwiki deployments supposed to happen on thursdays? [18:04:31] (03PS4) 10Esanders: Rename inlineRects to startAndEndRects everywhere [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160495 [18:04:33] (03PS12) 10Esanders: Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 [18:04:35] (03PS3) 10Esanders: Remove getSelection*Client* methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160579 [18:04:37] (03PS11) 10Esanders: Refactor out finding of CE focusedNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159949 [18:04:39] (03PS7) 10Esanders: Emit more events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160034 [18:04:41] (03PS3) 10Esanders: Provide a method to get all the rectangles for a given selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160591 [18:04:43] (03PS13) 10Esanders: Allow specification of range when getting selection rectangles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160073 [18:04:45] (03PS6) 10Esanders: Add getNativeRange method with optional DM range argument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160303 [18:04:51] Krenair: They do. [18:05:12] Krenair: But RoanKattouw's new code went out ~ 2.5 hours ago and might have broken things (though I can't see why). [18:05:36] Yeah, just went looking at swats [18:05:56] No, it's Parsoid [18:06:00] I think [18:06:40] I mean it's possible that my change /triggered/ Firefox to do something that trips the Parsoid bug [18:06:51] Not https://gerrit.wikimedia.org/r/#/c/160584/2/modules/ve-mw/init/ve.init.mw.Target.js ? [18:07:13] yes, probably [18:07:37] (03PS3) 10Esanders: [BREAKING CHANGE] Create ve.dm.Focusable and store focusable flag there [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159640 [18:11:52] (03CR) 10jenkins-bot: [V: 04-1] Emit more events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160034 (owner: 10Esanders) [18:11:55] (03CR) 10jenkins-bot: [V: 04-1] Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 (owner: 10Esanders) [18:13:44] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf16] Opening link inspector/comment box in an empty line, opens them at the end of the previous line - 10https://bugzilla.wikimedia.org/69122 (10Rummana Yasmeen) 5REOP>3ASSI [18:17:45] hegesippe: Can you link me to a case where spaces were replaced with underscores? [18:18:12] hegesippe, Frakir: Thanks for the report. I found out why categories are being removed and filed https://bugzilla.wikimedia.org/show_bug.cgi?id=70894 . It's a bug in Parsoid that is triggered only in Firefox [18:20:51] But I don't know why the underscore bug happens yet, I'll need a diff for that [18:22:06] Eek https://fr.wikipedia.org/w/index.php?title=Gregor_Strasser&diff=prev&oldid=107510160 looks bad enough [18:22:53] RoanKattouw, for example: https://fr.wikipedia.org/w/index.php?title=Saison_6_de_Koh-Lanta&diff=prev&oldid=107509309 [18:27:02] OK I've isolated a test case at https://fr.wikipedia.org/wiki/Utilisateur:Roan_Kattouw_%28WMF%29/Sandbox?veaction=edit [18:27:34] Broken in Firefox but not Chrome [18:27:40] Yay Firefox. [18:27:46] Broken by your new code? [18:28:17] Probably only when there are special characters in the href [18:29:15] James_F: Recent Parsoid bug apparently, probably triggered by my code [18:29:24] * James_F nods. [18:29:27] Grumble. [18:30:48] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf22] Resizing the window adds an extra padding below the "Choose a different image" button in Media Settings dialog - 10https://bugzilla.wikimedia.org/70895 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16489... [18:49:52] (03PS1) 10Mooeypoo: Validate size widget when activating/deactivating apply button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160789 (https://bugzilla.wikimedia.org/70861) [18:50:38] RoanKattouw: Thoughts on how we can look for and fix all these mis-edits? [18:51:01] (03PS1) 10Mooeypoo: Set size to default on 0 value [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160790 (https://bugzilla.wikimedia.org/70861) [18:51:30] hm. Something happened to initial/default image size. My default images are smaller in VE than in view. [18:51:44] eep [18:52:03] 3VisualEditor: VisualEditor replaces categories with [[MediaWiki:Badtitletext]] - 10https://bugzilla.wikimedia.org/70897 (10Inkowik) 3NEW p:3Unprio s:3normal a:3None http://de.wikipedia.org/w/index.php?diff=134089498 http://de.wikipedia.org/w/index.php?diff=134090414 VisualEditor is replacing categori... [18:52:06] Yeah. Weird bug. [18:52:14] Eloquence: Yeah. :-( [18:52:32] mooeypoo: VE doesn't respect your thumbnail size preferences [18:52:39] maybe it's just that [18:52:40] indeed. But it did before. [18:52:43] can't get no respect from VE [18:52:47] never did for me. [18:53:02] MatmaRex, ... seriously? I fixed that ages ago :\ [18:53:04] * James_F grins. [18:53:07] James_F: frwiki has an abusefilter tagging edits that remove all categories [18:53:09] meh. [18:53:12] heh [18:53:12] mooeypoo: No, personal prefs. [18:53:21] RoanKattouw: But what about the other 160 wikis with VE? ;-) [18:53:22] What personal prefs? [18:53:42] mooeypoo: You can have a personal pref over-riding the wiki pref over-riding the farm pref over-riding the default size. [18:53:47] oh wow... [18:53:48] mooeypoo: Because… MediaWiki. [18:53:57] mooeypoo: It's a semi-WONTFIX. [18:53:58] James_F: Yeah.... it'll only happen where special characters are involved but that's still a lot [18:53:58] but... I never overrided anything in my local wiki, I don't think. [18:54:10] And the corruption checker doesn't catch it because it's a Parsoid bug [18:54:12] https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-rendering, "Thumbnail size" [18:54:13] RoanKattouw: plwiki, ptwiki, … [18:54:15] RoanKattouw: Yeah. :-( [18:54:22] So .. how can I know if this is not respecting my wiki-wide or my preference [18:54:46] mooeypoo: It's working just fine. Worry not. [18:54:52] oh, okay. [18:55:00] James_F, but I do think I found an underlying bug [18:55:21] Since it doesn't respect my sizing, it *thinks* it's size A when it's size B, which means the model is always in "changed" mode (and the apply button is lit) [18:55:25] because why not. [18:56:01] This is actually pretty annoying to fix if I can't read the user preference. The settings for default come from the wiki-wide settings. [18:56:10] Not sure how to fix this without checking local user settings. [18:56:28] I also confirmed that my change from today's SWAT caused Firefox to start URL-encoding where it previously didn't, which is why we are now hitting this Parsoid bug [18:56:43] James_F: As for finding them... maybe introduction of underscores? I don't know [18:57:10] The "good" news is that the first space isn't converted to an underscore, because one of their bugs is that they have .replace( /_/, ' ' ) rather than .replace( /_/g, ' ' ) [18:57:26] RoanKattouw: Well, searching for [[Category:MediaWiki:Badarticle]] is a start. [18:57:48] is there an instant-revert we can do to fix this? [18:58:05] No, it's not [[Category:MediaWiki:Badarticle]], it's [[MediaWiki:Badtitletext]] [18:58:06] we should help with the cleanup [18:58:16] Eloquence: We can trade one kind of corruption for another by reverting my IE workaroudn [18:58:18] RoanKattouw: Ah, even better. :-( [18:58:25] RoanKattouw: Yeah, let's not do that. [18:58:38] That will stop Firefox from doing this underscore and category stuff, but it will make IE normalize style and bgcolor attributes again [18:58:51] which is .. not nearly as bad .. but OK [18:59:12] Except when I say "normalize" I mean "remove everything that isn't valid CSS" [18:59:23] ah [18:59:41] So if you have a typo in your inline style, VE will helpfully clean that up by destroying it so that someone else can't come along later and fix your typo [19:00:15] Almost like pasting in [[MediaWiki:Badtitletext]] [19:00:17] Also it normalizes things like style="color:#ffd" to style="color: rgb(255, 255, 221);" which is more cosmetic in nature I suppose [19:00:24] But not more or less cosmetic than underscores in links [19:00:28] right. well, this is major prod snafu so let's pick the least evil solution we can get out asap - thanks. [19:00:35] Eloquence: Definitely. [19:00:47] Yeah Subbu said he found some things [19:01:03] Should we revert the IE hacks until Subbu gets a fix for Parsoid together? [19:01:13] He's running tests before pushing for review. [19:01:22] Right, so he has fixes ready already, that's good [19:02:49] RoanKattouw: What do you think re. IE vs. Firefox? [19:03:45] I think the IE corruption will be lower impact than the Firefox corruption [19:03:54] * James_F sighs. [19:03:57] Yeah, probably. [19:04:01] Revert then? [19:04:10] Yes [19:17:59] 3VisualEditor: VisualEditor replaces categories with [[MediaWiki:Badtitletext]] - 10https://bugzilla.wikimedia.org/70897#c1 (10Inkowik) some other occurences: [1] http://de.wikipedia.org/w/index.php?diff=134086405 [2] http://de.wikipedia.org/w/index.php?diff=134086148 [3] http://de.wikipedia.org/w/index.php?di... [19:19:55] 3VisualEditor / 3MediaWiki integration: VisualEditor: Saving replaces categories with [[MediaWiki:Badtitletext]] - 10https://bugzilla.wikimedia.org/70897#c2 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Highes s:5normal>3critic a:3Roan Kattouw This is caused by bug 70894; we have made an emerge... [19:24:38] hi TrevorParscal [19:25:38] hi [19:25:44] sorry, was late to get on IRC [19:25:53] Very late. :-) [19:26:01] was working on home computer (left laptop in the car and my wife was out) [19:26:05] back on laptop now [19:26:42] * James_F nods. [19:42:21] Can someone work out what instruction 2 means? https://bugzilla.wikimedia.org/show_bug.cgi?id=70886 [19:42:28] "in the resulting dialog sort the citations by their numbers. They get sorted." [19:42:52] The re-use dialog doesn't let you sort... It's sorted by number already... [19:43:44] 3VisualEditor / 3Editing Tools: VisualEditor: "Uncaught TypeError: Cannot read property 'getSurface' of null" when applying a heading format on citation - 10https://bugzilla.wikimedia.org/70888#c3 (10Ritu Swain) (In reply to Rummana Yasmeen from comment #1) > I could reproduce it while applying the text styl... [19:45:01] 3VisualEditor / 3Data Model: VisualEditor: Citations in the Re-use reference list do not get sorted by their numbers on second initialisation . - 10https://bugzilla.wikimedia.org/70886 (10Alex Monk) [19:45:02] 3VisualEditor / 3Data Model: VisualEditor: Citations in the Re-use reference list do not get sorted by their numbers on second initialisation . - 10https://bugzilla.wikimedia.org/70886#c5 (10Alex Monk) a:3Alex Monk (In reply to Ritu Swain from comment #0) > 2> Cite Re-Use -> in the resulting dialog sort t... [20:03:46] 3VisualEditor / 3Editing Tools: VisualEditor: "Uncaught TypeError: Cannot read property 'getSurface' of null" when applying a heading format on citation - 10https://bugzilla.wikimedia.org/70888#c4 (10Rummana Yasmeen) (In reply to Ritu Swain from comment #3) > (In reply to Rummana Yasmeen from comment #1) > >... [20:07:13] $ git checkout -b come-on-firefox [20:07:15] fatal: A branch named 'come-on-firefox' already exists. [20:08:53] (03PS1) 10Catrope: Followup 80dd016: avoid using XMLSerializer when not absolutely necessary [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160809 [20:09:06] RoanKattouw_away: :-) [20:10:58] (03CR) 10Jforrester: Followup 80dd016: avoid using XMLSerializer when not absolutely necessary (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160809 (owner: 10Catrope) [20:13:29] 3OOjs UI: OOjs UI: Auto-shortening of dialog titles when there's insufficient space isn't working - 10https://bugzilla.wikimedia.org/68571#c5 (10Bartosz Dziewoński) (In reply to Bartosz Dziewoński from comment #4) > It seems the intended behavior is to ellipse the text, but that doesn't > happen because the la... [20:14:18] James_F: I think MatmaRex needs +v :) [20:15:31] i also need +2! :D [20:16:15] * James_F grins. [20:16:18] MatmaRex: You don't have it? [20:17:11] not in all repos [20:17:15] Oy. [20:17:24] oh hey, why am i still mobile. [20:17:41] Indeed. [20:17:52] Poor mobile MatmaRex, we knew thee well. [20:18:41] Bah, I can't edit extension-VisualEditor-staff [20:18:57] RoanKattouw_away: https://gerrit.wikimedia.org/r/#/admin/groups/uuid-c46f4782767ebf11cd4f45582c3f20192cd7216f,members needs +MatmaRex when you get back. [20:21:03] MatmaRex: Have added you to VisualEditor-core, OOjs and OOjs-UI, and UnicodeJS. Otherwise [20:21:05] Bah. [20:21:25] … Otherwise you should have +2 already in the repos you care about? [20:21:51] yep [20:27:22] (03PS1) 10Bartosz Dziewoński: ProcessDialog: Don't center the title label if there's not enough space [oojs/ui] - 10https://gerrit.wikimedia.org/r/160812 (https://bugzilla.wikimedia.org/68571) [20:29:18] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/160812/ [20:30:08] James_F: Added MatmaRex [20:31:42] RoanKattouw_away: Thanks. [20:33:32] (03CR) 10Catrope: Followup 80dd016: avoid using XMLSerializer when not absolutely necessary (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160809 (owner: 10Catrope) [20:39:46] (03PS1) 10Jforrester: README: Add devDependencies badge [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160818 [20:41:28] TrevorParscal: so did you end up looking at the colorize stuff? https://gerrit.wikimedia.org/r/#/c/158444/ i'd really prefer you to look at the five problem points in the commit message before i start solving them blindly [20:42:27] MatmaRex: loookin [20:44:06] TrevorParscal: Also please review https://gerrit.wikimedia.org/r/160812 , that bug is bothering me [20:46:07] hi [20:46:56] hi [20:49:02] (03PS2) 10Bartosz Dziewoński: ProcessDialog: Don't center the title label if there's not enough space [oojs/ui] - 10https://gerrit.wikimedia.org/r/160812 (https://bugzilla.wikimedia.org/68571) [20:50:56] (03CR) 10Trevor Parscal: [C: 04-1] "Two problems here:" [oojs/ui] - 10https://gerrit.wikimedia.org/r/160812 (https://bugzilla.wikimedia.org/68571) (owner: 10Bartosz Dziewoński) [20:51:04] James_F: See https://gerrit.wikimedia.org/r/#/c/160812/ [20:51:13] this is a design change, and I'm not sure about it [20:51:27] I think we need to go and shorten the button labels as much as we can [20:51:30] * James_F nods. [20:51:34] they should be clear, but less verbose [20:51:34] That sounds reasonable. [20:51:49] s// [20:51:56] s//? [20:51:59] Hmm [20:52:41] (03CR) 10Bartosz Dziewoński: "Per screenshots on the bug, even a button label like "Save changes" can be too long when translated. This doesn't affect buttons that are " [oojs/ui] - 10https://gerrit.wikimedia.org/r/160812 (https://bugzilla.wikimedia.org/68571) (owner: 10Bartosz Dziewoński) [20:54:22] MatmaRex: so, your 5 problems [20:54:41] one of them, Minerva looks like $%^& [20:54:55] that's actually how Minerva looks, because they only implemented like 1% [20:55:04] generally, we can ignore [20:55:36] as for passing src to colorizeSvg [21:11:29] 3VisualEditor / 3Data Model: VisualEditor: Citations in the Re-use reference list do not get sorted by their numbers on second initialisation . - 10https://bugzilla.wikimedia.org/70886#c7 (10Alex Monk) I had trouble understanding the second step. The screenshots didn't help me with that. [21:11:42] RoanKattouw: So are you re-doing 160809 ahead of … a follow-up SWAT this afternoon? [21:12:32] Yeah I'll go clean it up [21:12:32] I was eating lunch [21:12:51] Excuses. :-) [21:31:55] MatmaRex: ok, back [21:32:12] MatmaRex: oh, you are eating - good, eat [21:32:52] i'm almost back. ;) [21:35:59] 3VisualEditor / 3Data Model: VisualEditor: Citations in the Re-use reference list do not get sorted by their numbers on second initialisation . - 10https://bugzilla.wikimedia.org/70886#c8 (10Ritu Swain) (In reply to Alex Monk from comment #7) > I had trouble understanding the second step. The screenshots di... [21:37:54] (03PS2) 10Catrope: Followup 80dd016: avoid using XMLSerializer when not absolutely necessary [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160809 [21:38:47] TrevorParscal: right. need anything? [21:39:15] no, I'm just poking at server-side OOjs UI [21:39:33] James_F: Amended https://gerrit.wikimedia.org/r/160809 [21:39:40] OOphp UI?.... "oh-foo-ee" [21:39:49] TrevorParscal: :-) [21:39:51] RoanKattouw: Cool. [21:40:51] TrevorParscal: alright. btw, if you want to squash my colorize stuff with your theme stuff then that's perfectly okay [21:41:21] I may do so [21:41:27] I will talk to you about it first [21:41:30] (03CR) 10Catrope: [C: 032] Make message respect plural rules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160699 (owner: 10Jforrester) [21:43:12] (03Merged) 10jenkins-bot: Make message respect plural rules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160699 (owner: 10Jforrester) [21:48:59] (03CR) 10Jforrester: [C: 031] Followup 80dd016: avoid using XMLSerializer when not absolutely necessary [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160809 (owner: 10Catrope) [21:49:33] (03PS1) 10Esanders: Move sluggability methods to model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160837 [21:49:35] TrevorParscal: OOrubyUI! [21:49:35] (03PS1) 10Esanders: Calculate slug positions in the model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160838 [21:49:37] (03PS1) 10Esanders: Add hasSlugAtOffset to DM document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160839 [21:49:39] (03PS1) 10Esanders: Move getRelativeOffset, getRelativeRange, getNearestFocusableNode to model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160840 [21:50:49] oo-roo-bee-ooy [21:50:59] Kind of Japanese-sounding? [21:50:59] 3VisualEditor / 3Data Model: VisualEditor: Citations in the Re-use reference list do not get sorted by their numbers on second initialisation . - 10https://bugzilla.wikimedia.org/70886#c9 (10Rummana Yasmeen) Ritu,you cannot sort the citations inside Re-use dialog, so the step 2 is kind of confusing.Maybe yo... [21:51:28] (03CR) 10jenkins-bot: [V: 04-1] Calculate slug positions in the model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160838 (owner: 10Esanders) [21:52:19] (03CR) 10jenkins-bot: [V: 04-1] Add hasSlugAtOffset to DM document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160839 (owner: 10Esanders) [21:52:30] (03CR) 10jenkins-bot: [V: 04-1] Move getRelativeOffset, getRelativeRange, getNearestFocusableNode to model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160840 (owner: 10Esanders) [21:59:14] RoanKattouw_away, I just realised - https://en.wikipedia.org/w/api.php?action=query&format=json&meta=siteinfo&siprop=interwikimap :( [21:59:19] no api urls [22:00:55] Krenair: Lovely. [22:01:03] Krenair: Guess your own! Magic. [22:01:08] Haha. [22:01:23] I had code pulling the data and everything, then realised .api was undefined. [22:03:12] Should we modify the API? [22:03:28] And if so, let's do so in the next 2 days so we get it into 1.24? :-) [22:06:11] Actually, this would break even standard interwiki links (when run from that wiki). Not just the double interwiki case I was trying to deal with. [22:27:14] (03PS9) 10Bartosz Dziewoński: Colorize SVG files into defined color variants, output image LESS [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 [22:28:03] (03CR) 10jenkins-bot: [V: 04-1] Colorize SVG files into defined color variants, output image LESS [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 (owner: 10Bartosz Dziewoński) [22:35:43] (03PS2) 10Mooeypoo: Set size to default on 0 value [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160790 (https://bugzilla.wikimedia.org/70861) [22:36:49] (03CR) 10Esanders: [C: 032] Followup 80dd016: avoid using XMLSerializer when not absolutely necessary [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160809 (owner: 10Catrope) [22:38:41] (03Merged) 10jenkins-bot: Followup 80dd016: avoid using XMLSerializer when not absolutely necessary [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160809 (owner: 10Catrope) [22:47:26] (03PS10) 10Bartosz Dziewoński: Colorize SVG files into defined color variants, output image LESS [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 [22:48:20] (03CR) 10jenkins-bot: [V: 04-1] Colorize SVG files into defined color variants, output image LESS [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 (owner: 10Bartosz Dziewoński) [22:49:57] (03PS11) 10Bartosz Dziewoński: Colorize SVG files into defined color variants, output image LESS [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 [22:50:36] (03CR) 10Bartosz Dziewoński: "PS9 fixes the 'src' key. PS10 implements two-step build process. PS11 kills demo artifacts. I think this is ready, for now." [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 (owner: 10Bartosz Dziewoński) [22:50:45] (03CR) 10jenkins-bot: [V: 04-1] Colorize SVG files into defined color variants, output image LESS [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 (owner: 10Bartosz Dziewoński) [22:59:29] 3VisualEditor / 3Data Model: VisualEditor: Citations in the Re-use reference list do not get sorted by their numbers on second initialisation . - 10https://bugzilla.wikimedia.org/70886#c10 (10Ritu Swain) (In reply to Rummana Yasmeen from comment #9) > Ritu,you cannot sort the citations inside Re-use dialog,... [23:07:42] (03PS1) 10Jforrester: Update VE core submodule to master (3e09af1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160862 [23:07:54] RoanKattouw_away: ^^^ [23:08:22] James_F: Sorry I am here, just got back [23:08:27] No worries. [23:08:35] I'm taking it you decided we didn't need to SWAT? [23:08:36] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (3e09af1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160862 (owner: 10Jforrester) [23:09:38] We ... did? [23:09:45] Did I not add the commit to the calendar? [23:09:50] Hmm I guess I didn't [23:10:05] That was Matt's thing [23:10:15] RoanKattouw: Also you didn't do any prep. work and it's a bit late now. [23:10:39] :-( [23:10:43] Max seems to still be SWATting [23:10:58] Sure, but the deadline for new entries is 15:59:59. :-) [23:11:06] I'll ask him, you prep. it. [23:11:12] (03PS1) 10Catrope: Followup 80dd016: avoid using XMLSerializer when not absolutely necessary [VisualEditor/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160863 [23:11:23] (03PS1) 10Catrope: Followup 80dd016: avoid using XMLSerializer when not absolutely necessary [VisualEditor/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160865 [23:11:27] I already asked [23:11:41] (03Merged) 10jenkins-bot: Update VE core submodule to master (3e09af1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160862 (owner: 10Jforrester) [23:11:48] RoanKattouw: He said yes. [23:11:53] OK [23:12:10] (03CR) 10Catrope: [C: 032 V: 032] Followup 80dd016: avoid using XMLSerializer when not absolutely necessary [VisualEditor/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160865 (owner: 10Catrope) [23:12:18] (03CR) 10Jforrester: [C: 032] Followup 80dd016: avoid using XMLSerializer when not absolutely necessary [VisualEditor/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160863 (owner: 10Catrope) [23:12:24] (03CR) 10Catrope: [C: 032 V: 032] Followup 80dd016: avoid using XMLSerializer when not absolutely necessary [VisualEditor/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160863 (owner: 10Catrope) [23:12:54] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/160801/ and https://gerrit.wikimedia.org/r/#/c/160799/ can be re-used for the mw-core re-cherries. [23:13:00] RoanKattouw: Depending on what you want to do. [23:13:45] (03PS1) 10Catrope: Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160867 [23:14:11] Thanks [23:15:00] * James_F waits for the other two mw-core patches to add for Max. [23:15:10] (03CR) 10jenkins-bot: [V: 04-1] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160867 (owner: 10Catrope) [23:17:15] (03PS1) 10Catrope: Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160869 [23:17:50] (03CR) 10Catrope: [C: 032 V: 032] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/160867 (owner: 10Catrope) [23:18:38] (03CR) 10Catrope: [C: 032 V: 032] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/160869 (owner: 10Catrope) [23:26:48] Krinkle: BTW, I'm an idiot, https://david-dm.org/wikimedia/mediawiki-extensions-VisualEditor#info=devDependencies totally works. Did https://gerrit.wikimedia.org/r/#/c/160818/ to go with the rest. [23:27:34] (03PS2) 10Jforrester: README: Add devDependencies badge [oojs/core] - 10https://gerrit.wikimedia.org/r/160262 [23:29:44] RoanKattouw, James_F: in mediawiki core, Interwiki::getAllPrefixes is used to get that list. On wikimedia this uses getAllPrefixesCached, which only pulls out iw_prefix, iw_url and iw_local. [23:30:40] Hmm. [23:31:03] Oh, and on my wiki only wikipedia has iw_api populated anyway. gj past me. [23:31:46] :-D [23:42:39] (03CR) 10Catrope: [C: 032] Show pending state on action button and keep dialog open when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [23:43:11] (03CR) 10Catrope: [C: 032] Template dialog: Show up to the limit of parameters, not up to the limit + 1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160500 (https://bugzilla.wikimedia.org/70609) (owner: 10Jforrester) [23:44:23] (03Merged) 10jenkins-bot: Show pending state on action button and keep dialog open when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [23:44:30] (03CR) 10Catrope: [C: 032] Validate size widget when activating/deactivating apply button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160789 (https://bugzilla.wikimedia.org/70861) (owner: 10Mooeypoo) [23:44:56] (03Merged) 10jenkins-bot: Template dialog: Show up to the limit of parameters, not up to the limit + 1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160500 (https://bugzilla.wikimedia.org/70609) (owner: 10Jforrester) [23:45:27] (03CR) 10jenkins-bot: [V: 04-1] Validate size widget when activating/deactivating apply button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160789 (https://bugzilla.wikimedia.org/70861) (owner: 10Mooeypoo) [23:46:12] O.O [23:46:18] how is this failing now and not before. [23:48:16] RoanKattouw, mw tests pass for me with this fix [23:48:29] 3VisualEditor / 3MediaWiki integration: VisualEditor: Switching to source mode should show a spinner, pending state or similar - 10https://bugzilla.wikimedia.org/65012 (10Alex Monk) 5PATC>3RESO/FIX [23:48:33] and... nothing really should be affectig tests in general, since this is a ui change. Is this something with jenkins? [23:50:06] 23:44:47 Original exception: [092a0b7d] /jenkins-mwext-VisualEditor-qunit-11526/index.php?title=Special:BlankPage Exception from line 721 of /srv/ssd/jenkins-slave/workspace/mwext-VisualEditor-qunit/includes/db/DatabaseSqlite.php: Error in BEGIN query: There is already an active transaction
[23:50:13] That sounds like it's probably not your fault :) [23:52:46] (03CR) 10Catrope: [C: 032] Validate size widget when activating/deactivating apply button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160789 (https://bugzilla.wikimedia.org/70861) (owner: 10Mooeypoo) [23:54:27] (03Merged) 10jenkins-bot: Validate size widget when activating/deactivating apply button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160789 (https://bugzilla.wikimedia.org/70861) (owner: 10Mooeypoo) [23:54:28] That was odd. I don't usually worry about qunit when I only edit ve.ui stuff, too [23:54:31] woot [23:54:39] that size thing is driving me crazy, though. Meh. [23:54:56] I might look into that... [23:55:29] turn that WONTFIX-frown upside down...