[00:04:00] 3MediaWiki / 3Page editing: Require POST for all changes; Never change content on HEAD-request - 10https://bugzilla.wikimedia.org/44602#c7 (10Matthew Flaschen) (In reply to Jesús Martínez Novo (Ciencia Al Poder) from comment #1) > Also, the plugin is bad designed, since it should send HEAD requests, not > GE... [00:07:36] (03PS2) 10Alex Monk: Try to handle interwiki links in LinkTargetInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160155 (https://bugzilla.wikimedia.org/70504) [00:08:31] 3VisualEditor / 3MediaWiki integration: VisualEditor: Link existence checker in LinkTargetInputWidget doesn't work for interwikis, language links - 10https://bugzilla.wikimedia.org/70504#c2 (10Alex Monk) 5PATC>3ASSI a:5Alex Monk>3None So it turns out this patch is basically useless because iw_api is... [00:08:33] (03PS2) 10Esanders: Move getRelativeOffset, getRelativeRange, getNearestFocusableNode to model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160840 [00:08:35] (03PS2) 10Esanders: Add hasSlugAtOffset to DM document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160839 [00:08:37] (03PS2) 10Esanders: Calculate slug positions in the model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160838 [00:09:15] (03Abandoned) 10Alex Monk: Try to handle interwiki links in LinkTargetInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160155 (https://bugzilla.wikimedia.org/70504) (owner: 10Alex Monk) [00:10:30] (03CR) 10jenkins-bot: [V: 04-1] Move getRelativeOffset, getRelativeRange, getNearestFocusableNode to model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160840 (owner: 10Esanders) [00:23:46] (03PS3) 10Esanders: Move getRelativeOffset, getRelativeRange, getNearestFocusableNode to model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160840 [00:25:10] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Create ve.dm.Focusable and store focusable flag there [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159640 (owner: 10Esanders) [00:26:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In media dialog, "Size values are invalid" message does not show up, when choosing a different image and then setting its size to 0 x 0 px - 10https://bugzilla.wikimedia.org/70861 (10James Forrester) 5PATC>3RESO/FIX [00:26:48] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Create ve.dm.Focusable and store focusable flag there [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159640 (owner: 10Esanders) [00:26:58] (03PS1) 10Esanders: Move ce.document tests to dm.document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160885 [00:27:14] 3VisualEditor / 3Editing Tools: VisualEditor: In template dialog, the “show one more field” control appears when there are 4 entries - 10https://bugzilla.wikimedia.org/70609 (10James Forrester) 5PATC>3RESO/FIX [00:28:17] (03CR) 10jenkins-bot: [V: 04-1] Move ce.document tests to dm.document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160885 (owner: 10Esanders) [00:41:41] (03PS1) 10Catrope: Update VE core submodule to master (5f4b740) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160888 [00:41:54] edsanders: I can haz +2? https://gerrit.wikimedia.org/r/#/c/160888/ [00:42:46] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (5f4b740) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160888 (owner: 10Catrope) [00:42:59] nm I need to squash [00:43:27] (03PS3) 10Catrope: Update VE core submodule to master (5f4b740) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159642 (owner: 10Esanders) [00:43:41] (03Abandoned) 10Catrope: Update VE core submodule to master (5f4b740) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160888 (owner: 10Catrope) [00:44:11] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (5f4b740) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159642 (owner: 10Esanders) [00:44:32] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (5f4b740) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159642 (owner: 10Esanders) [00:47:19] (03CR) 10Catrope: [C: 031] Move sluggability methods to model (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160837 (owner: 10Esanders) [01:25:08] (03CR) 10Catrope: [C: 04-1] "Dude, this is awesome. So much less code!" (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159623 (https://bugzilla.wikimedia.org/69886) (owner: 10Alex Monk) [01:25:49] RoanKattouw, yes... see the commit message. [01:26:02] Right [01:26:05] I guess it was already broken anyawy [01:26:09] and no one appeared to care [01:26:11] The code appears to have been broken at some point (And no one noticed). [01:26:30] probably because of https://gerrit.wikimedia.org/r/#/c/135782/ [01:44:10] (03PS1) 10Esanders: Add native range to categories.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160899 [01:45:38] (03PS4) 10Esanders: Update VE core submodule to master (5f4b740) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159642 [01:46:08] (03CR) 10jenkins-bot: [V: 04-1] Add native range to categories.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160899 (owner: 10Esanders) [01:46:10] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (5f4b740) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159642 (owner: 10Esanders) [01:47:47] (03Merged) 10jenkins-bot: Update VE core submodule to master (5f4b740) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159642 (owner: 10Esanders) [01:53:33] (03CR) 10Alex Monk: Refactor a bunch of CategoryInputWidget code, tear out dead/broken redirect handling that should be rewritten (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159623 (https://bugzilla.wikimedia.org/69886) (owner: 10Alex Monk) [02:08:13] (03PS1) 10Catrope: When updating the ideal size while not clipping, set that size [oojs/ui] - 10https://gerrit.wikimedia.org/r/160902 [02:08:43] (03PS1) 10Catrope: Update width of TextInputMenuWidget before fitting labels, not after [oojs/ui] - 10https://gerrit.wikimedia.org/r/160903 [02:09:48] (03CR) 10Catrope: Refactor a bunch of CategoryInputWidget code, tear out dead/broken redirect handling that should be rewritten (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159623 (https://bugzilla.wikimedia.org/69886) (owner: 10Alex Monk) [02:11:21] (03CR) 10Catrope: [C: 04-1] "You should make this change in VE core instead." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160899 (owner: 10Esanders) [02:11:40] (03CR) 10Catrope: [C: 032] Refactor a bunch of CategoryInputWidget code, tear out dead/broken redirect handling that should be rewritten [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159623 (https://bugzilla.wikimedia.org/69886) (owner: 10Alex Monk) [02:13:23] (03Merged) 10jenkins-bot: Refactor a bunch of CategoryInputWidget code, tear out dead/broken redirect handling that should be rewritten [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159623 (https://bugzilla.wikimedia.org/69886) (owner: 10Alex Monk) [02:36:35] (03CR) 10Esanders: "It is in core as well, doesn't it need to be in both?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160899 (owner: 10Esanders) [03:54:17] 3MediaWiki extensions / 3WikiEditor: CharInsert should not show up to JavaScriptless users - 10https://bugzilla.wikimedia.org/70923 (10Gryllida) 3NEW p:3Unprio s:3normal a:3None str: 0) disable javascript 1) open an edit box e.g. https://www.mediawiki.org/wiki/Extension:CharInsert?action=edit... [06:26:59] 3VisualEditor / 3MediaWiki integration: VisualEditor: Populate LinkCache from MWLinkTargetInputWidget etc - 10https://bugzilla.wikimedia.org/69886 (10James Forrester) 5PATC>3RESO/FIX [06:49:50] 3VisualEditor / 3Editing Tools: when browser is narrow tools wraps to 2 rows when 2 would be sufficient - 10https://bugzilla.wikimedia.org/70928 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Created attachment 16498 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16498&action=edit... [06:50:14] 3VisualEditor / 3Editing Tools: when browser is narrow tools wraps to 3 rows when 2 would be sufficient - 10https://bugzilla.wikimedia.org/70928 (10Jared Zimmerman (WMF)) [11:48:07] 3MediaWiki / 3ResourceLoader: CSSMin::encodeImageAsDataURI() should be smarter about SVG images (tracking) - 10https://bugzilla.wikimedia.org/57777 (10Bartosz Dziewoński) [11:48:24] 3MediaWiki / 3ResourceLoader: Embedded SVG files should be optimized in ResourceLoader/CSSMin - 10https://bugzilla.wikimedia.org/63491 (10Bartosz Dziewoński) [11:48:24] 3MediaWiki / 3ResourceLoader: Allow minification of SVG files - 10https://bugzilla.wikimedia.org/34812 (10Bartosz Dziewoński) [11:48:25] 3MediaWiki / 3ResourceLoader: Investigate embedding some data URLs without base 64 - 10https://bugzilla.wikimedia.org/67341 (10Bartosz Dziewoński) [11:48:36] 3MediaWiki / 3ResourceLoader: CSSMin::encodeImageAsDataURI() should be smarter about SVG images (tracking) - 10https://bugzilla.wikimedia.org/57777 (10Bartosz Dziewoński) [11:48:36] 3MediaWiki / 3ResourceLoader: Embedded SVG files should be optimized in ResourceLoader/CSSMin - 10https://bugzilla.wikimedia.org/63491 (10Bartosz Dziewoński) [11:56:52] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843#c10 (10Bartosz Dziewoński) 5ASSI>3RESO/FIX I can't reproduce. Probably fixed by Ed's recent cleanup... [12:04:22] 3VisualEditor / 3Editing Tools: VisualEditor: In the media selector show name in a tooltip on mouseover - 10https://bugzilla.wikimedia.org/52459#c2 (10Bartosz Dziewoński) I think a better place to display the name would be in the "Media settings" dialog. Right now, when inserting an image, you don't even kno... [12:08:51] 3VisualEditor / 3Editing Tools: VisualEditor: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - 10https://bugzilla.wikimedia.org/68590#c5 (10Bartosz Dziewoński) What is the expected behavior? Discardin... [12:14:37] 3VisualEditor / 3ContentEditable: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - 10https://bugzilla.wikimedia.org/69474#c4 (10Bartosz Dziewoński) Any attempt to "parse" the template parameters is going to become very complex or fail to address the needs of w... [13:41:17] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/36739 (owner: 10Hashar) [13:50:36] 3VisualEditor / 3ContentEditable: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - 10https://bugzilla.wikimedia.org/69474#c5 (10Bartosz Dziewoński) I played with it and the following sort of works for all reference node types. There must be a better way to do... [13:53:52] (03PS1) 10Bartosz Dziewoński: ve.ce.CommentNode: Correct comments formatting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160958 [14:05:06] 3VisualEditor / 3Editing Tools: VisualEditor: The MWAlienInspector immediately closes after opening on Opera 12, when opened using the context tooltip - 10https://bugzilla.wikimedia.org/67530#c3 (10Bartosz Dziewoński) Ooh. It only closes itself when opened by clicking the context tooltip. Opening it by doubl... [14:07:37] 3VisualEditor / 3Editing Tools: VisualEditor: ve.ui.FragmentInspector immediately closes after opening on Opera 12, when opened using the context tooltip - 10https://bugzilla.wikimedia.org/67530#c4 (10Bartosz Dziewoński) Also affects the comment inspector in standalone. [16:04:04] Krenair: Do you want to try to take on 46992 and the WMF part of that bug, then? [16:05:59] (03CR) 10Jforrester: [C: 032] ve.ce.CommentNode: Correct comments formatting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160958 (owner: 10Bartosz Dziewoński) [16:06:42] i spent way too much time investigating that opera 12 bug and i still don't know how to fix it. [16:06:46] * MatmaRex grumble grumble [16:07:14] (03Merged) 10jenkins-bot: ve.ce.CommentNode: Correct comments formatting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160958 (owner: 10Bartosz Dziewoński) [16:09:40] MatmaRex: :-( [16:09:48] MatmaRex: IE had something similar. [16:12:56] James_F, the MW bit sounds okay. Actually I edited those files in my second commit to mediawiki/core, heh [16:14:05] Don't know about populating the field on WMF sites though... Might take some changes to things like https://meta.wikimedia.org/wiki/Interwiki_map [16:14:08] Krenair: You mean the installer bit? [16:14:11] yes [16:14:14] And yeah, it seems so. [16:30:30] Corruption alert: visualeditor-needcheck on svwiki: https://sv.wikipedia.org/?diff=27571961 [16:30:30] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13407581 [16:30:30] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32688159 [16:30:30] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32700411 [16:30:30] Corruption alert: visualeditor-needcheck on ukwiki: https://uk.wikipedia.org/?diff=14830990 [16:30:31] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65612255 [16:30:31] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65612328 [16:30:32] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65612594 [16:30:32] Corruption alert: visualeditor-needcheck on nlwiki: https://nl.wikipedia.org/?diff=42101853 [16:30:33] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40078643 [16:30:33] Corruption alert: visualeditor-needcheck on bswiki: https://bs.wikipedia.org/?diff=2465695 [16:33:18] Oh dear. [16:40:33] yikes [16:46:11] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/69542 [16:52:48] Krenair: So it's all RoanKattouw_away's fault? :-) [16:54:30] well [16:55:14] he copied it from iwtransclusion :) [17:50:51] TrevorParscal: unless you have better ideas, my plan for today/tomorrow is to look into making MW not base64-encode SVG images https://bugzilla.wikimedia.org/show_bug.cgi?id=67341 [17:52:28] RoanKattouw, I have a mw:badtitletext diff for you to look at: https://pt.wikipedia.org/w/index.php?title=The_Caves_of_Steel&diff=40076091&oldid=40068950 [17:52:57] whatami: I'll look. Speaking of, frwiki has a very helpful AbuseFilter for "all categories were deleted": https://fr.wikipedia.org/w/index.php?title=Sp%C3%A9cial:Journal_du_filtre_antiabus&wpSearchFilter=14 [17:53:07] ("Suppression de toutes les catégories") [17:53:34] "[[MediaWiki:Badtitletext|Perícope da Adúltera]] [17:53:37] What the... [17:54:09] 3OOjs UI: OOjs UI: The help texts in the tooltips of Page Settings menu looks crunched inside the pop-up - 10https://bugzilla.wikimedia.org/70677#c1 (10James Forrester) 5ASSI>3RESO/FIX p:5Unprio>3Normal Roan fixed this last week. [17:54:10] From context I assume that was just meant to be [[Perícope da Adúltera]] but in general we won't be sure what the intended link target was [17:55:20] That's why I wanted you to know about it. ;-) [17:55:23] MatmaRex: Could you look at https://bugzilla.wikimedia.org/show_bug.cgi?id=54965 at some point? I think it's still an issue (we've hacked around it for VE, but OOUI hasn't…) [17:55:25] Yeah thanks [17:55:31] That's a type I hadn't seen before [17:56:23] It looks like this would be a redlink. [17:56:53] 3OOjs UI: OOjs UI: ClippableElement shouldn't assume the body height is 100% - 10https://bugzilla.wikimedia.org/54965 (10James Forrester) a:3Bartosz Dziewoński [17:56:58] No, a redirect. [17:57:06] edsanders: Hmm, https://pt.wikipedia.org/?diff=40078643 looks like it's cleaning up after a copy-paste bug... [17:57:41] Yeah it redirects from Perícop*e* to Perícop*a* [17:57:42] And followed by a non-breaking space. [17:58:02] James_F: sure [17:58:26] interesting [17:58:26] MatmaRex: go ahead, that sounds excellent [17:58:35] re: different svg encoding [18:00:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: Broken browser plugins cause cruft to be injected into the page (tracker) - 10https://bugzilla.wikimedia.org/52327#c3 (10Roan Kattouw) I wonder if https://ru.wikipedia.org/?diff=65612328 is another instance of this, or if it's a copy-paste bug instead. [18:04:00] (03PS1) 10Trevor Parscal: [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 [18:10:09] TrevorParscal: More OOUI fixes: https://gerrit.wikimedia.org/r/160902 https://gerrit.wikimedia.org/r/160903 [18:11:51] (03CR) 10Trevor Parscal: [C: 032] Update width of TextInputMenuWidget before fitting labels, not after [oojs/ui] - 10https://gerrit.wikimedia.org/r/160903 (owner: 10Catrope) [18:12:32] (03CR) 10Trevor Parscal: [C: 032] When updating the ideal size while not clipping, set that size [oojs/ui] - 10https://gerrit.wikimedia.org/r/160902 (owner: 10Catrope) [18:14:15] (03Merged) 10jenkins-bot: When updating the ideal size while not clipping, set that size [oojs/ui] - 10https://gerrit.wikimedia.org/r/160902 (owner: 10Catrope) [18:14:17] (03Merged) 10jenkins-bot: Update width of TextInputMenuWidget before fitting labels, not after [oojs/ui] - 10https://gerrit.wikimedia.org/r/160903 (owner: 10Catrope) [18:16:51] (03CR) 10Catrope: "Is it already? grunt builds the MW one from the core one, and Jenkins is complaining that they're not the same. Where did you update the c" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160899 (owner: 10Esanders) [18:23:47] MatmaRex: re: https://gerrit.wikimedia.org/r/#/c/158444/ [18:24:35] yeah> [18:24:37] ? [18:24:54] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (24ac83a472) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161008 [18:24:57] i notice that minerva and mediawiki have raster and vector less files still - but apex and blank do not - probably because apex and blank don't introduce images [18:25:16] just wondering where you landed on this - I think you were saying you wanted to rid ourselves of such files [18:26:45] yeah, i didn't do anything about that yet. the basic ooui styles also use the two files, just to set the default file extension variable to svg or png and include other files [18:27:01] right [18:27:04] no worries [18:27:12] and the entire build process seems to be dependent on that [18:27:17] just wondering if you hit a wall there, or if you hadn't yet bothered [18:27:34] I'm going to squash this into my theme commit [18:27:42] you are doing other things right now, right? [18:27:50] yeah, didn't look into it yet. if we have the two-step build process, it should be easy to also generate these files on-the-fly [18:27:53] as in, you have no changes that aren't in gerrit [18:27:56] yep, feel free to squash [18:28:03] cool [18:30:46] (03PS10) 10Trevor Parscal: [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 [18:31:33] (03Abandoned) 10Trevor Parscal: Colorize SVG files into defined color variants, output image LESS [oojs/ui] - 10https://gerrit.wikimedia.org/r/158444 (owner: 10Bartosz Dziewoński) [18:31:41] (03CR) 10jenkins-bot: [V: 04-1] [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [18:37:59] MatmaRex: so, one thing I am thinking about, the MediaWiki theme actually needs a lot of (maybe all) different icons, so I'm going to move a lot of icons from core (maybe all) into MediaWiki [18:38:10] icons are pretty ... connected to a theme [18:38:28] alternatively, we could provide a default in core [18:38:48] and allow overriding (so we only send one "up" icon, not the default and the override) [18:39:19] any thoughts on that? [18:41:27] sounds reasonable? no thoughts on the implementation from me, no idea how to do that :) [18:41:40] no worries [18:42:04] TrevorParscal: Over-riding sounds better [18:42:07] it would probably be easier/neater to only include icons in the themes, not in ooui proper [18:42:21] yeah [18:42:22] * James_F isn't so sure. [18:42:33] Helping people come up with good icons is hard. [18:42:35] the specific icons aren't necessary for anything, are they? [18:42:47] User prompts. [18:42:49] no, it's just a library [18:43:01] well, there are some indicators that are used [18:43:21] like, in the widgets for menus and closing popups (that's an icon actually) [18:43:22] oh hmm. yeah, the required "star" [18:43:25] Menus and… yeah. [18:44:29] but, we could include a few icons/indicators that are actually required in the blank theme [18:44:41] https://github.com/edg2s/range-get-client-rects [18:44:46] which is meant for copy, modify, new theme! woot! [18:45:01] oh, i like that. [18:45:17] especially things like toolbar-shadow [18:45:22] which only Apex is going to use [18:45:29] ok, I'm going to do some... organizing [18:46:52] 3OOjs UI: OOjs UI: ClippableElement shouldn't assume the body height is 100% - 10https://bugzilla.wikimedia.org/54965#c7 (10Bartosz Dziewoński) 5ASSI>3RESO/FIX a:5Bartosz Dziewoński>3Ed Sanders Ed has independently applied my second suggestion from March in 8bd708b9d5260defef664346523a6d78c14c4837 two... [18:46:55] James_F: ^. i keep finding things ed has already fixed! [18:50:53] (03PS1) 10Esanders: Workaround Chrome's Range.getClientRects bug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161017 [18:59:36] 3OOjs UI: OOjs UI: The help texts in the tooltips of Page Settings menu looks crunched inside the pop-up - 10https://bugzilla.wikimedia.org/70677#c2 (10Rummana Yasmeen) Verified the fix in Betalabs [19:08:55] 3OOjs UI: OOjs UI: The help texts in the tooltips of Page Settings menu looks crunched inside the pop-up - 10https://bugzilla.wikimedia.org/70677#c3 (10Rummana Yasmeen) Verified the fix in test2 [19:15:03] MatmaRex: edsanders is too good to tag things as fixing bugs, clearly. :-) [19:15:41] That's your job James [19:15:51] :-P [19:16:18] (03PS1) 10Catrope: Fix documentation lies about dialog labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/161023 [19:17:22] 3OOjs UI: OOjs UI: ClippableElements should clip to the viewport, not the body - 10https://bugzilla.wikimedia.org/68370#c3 (10Ed Sanders) *** Bug 54965 has been marked as a duplicate of this bug. *** [19:17:22] 3OOjs UI: OOjs UI: ClippableElement shouldn't assume the body height is 100% - 10https://bugzilla.wikimedia.org/54965#c8 (10Ed Sanders) 5RESO/FIX>3RESO/DUP *** This bug has been marked as a duplicate of bug 68370 *** [19:20:55] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843#c11 (10Rummana Yasmeen) Verified the fix in Betalabs [19:20:55] 3OOjs UI: OOjs UI: ClippableElement shouldn't assume the body height is 100% - 10https://bugzilla.wikimedia.org/54965 (10James Forrester) 5RESO/DUP>3RESO/FIX [19:20:57] 3OOjs UI: OOjs UI: ClippableElement shouldn't assume the body height is 100% - 10https://bugzilla.wikimedia.org/54965#c9 (10James Forrester) *** Bug 68370 has been marked as a duplicate of this bug. *** [19:20:57] 3OOjs UI: OOjs UI: ClippableElements should clip to the viewport, not the body - 10https://bugzilla.wikimedia.org/68370#c4 (10James Forrester) 5RESO/FIX>3RESO/DUP *** This bug has been marked as a duplicate of bug 54965 *** [19:21:57] (03CR) 10Jforrester: [C: 032] Fix documentation lies about dialog labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/161023 (owner: 10Catrope) [19:22:38] (03Merged) 10jenkins-bot: Fix documentation lies about dialog labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/161023 (owner: 10Catrope) [19:27:40] (03PS15) 10Catrope: Get confirmation when trying to insert/edit template/citation with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk) [19:28:51] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In media dialog, "Size values are invalid" message does not show up, when choosing a different image and then setting its size to 0 x 0 px - 10https://bugzilla.wikimedia.org/70861#c5 (10Rummana Yasmeen) 5RESO/FIX>3REOP I can still reproduce... [19:29:06] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In media dialog, "Size values are invalid" message does not show up, when choosing a different image and then setting its size to 0 x 0 px - 10https://bugzilla.wikimedia.org/70861 (10Rummana Yasmeen) 5REOP>3ASSI [19:31:34] (03PS16) 10Catrope: Get confirmation when trying to insert/edit template/citation with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk) [19:31:54] James_F: http://builds.jenkins.jquery.com/qunit/faf5e97f897e67772e32d5e9f9db56da28710ba9/test/logs.html [19:31:59] new "skipped" feature RoanKattouw ^ [19:32:32] (03CR) 10Catrope: [C: 032] Get confirmation when trying to insert/edit template/citation with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk) [19:33:49] (03Merged) 10jenkins-bot: Get confirmation when trying to insert/edit template/citation with required parameters missing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk) [19:40:09] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog should recommend TemplateData-hinted mandatory parameters - 10https://bugzilla.wikimedia.org/50747#c20 (10James Forrester) 5PATC>3RESO/FIX There are still some remaining improvements (as always), but the thrust of this bug is now done. [19:48:18] mooeypoo: Reopened this one:https://bugzilla.wikimedia.org/show_bug.cgi?id=70861 [19:48:53] Yep, the second change that's required to fix this is still not merged [19:49:11] Should be fixed with this https://gerrit.wikimedia.org/r/#/c/160790/ [19:51:33] (03CR) 10Catrope: [C: 032] Set size to default on 0 value [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160790 (https://bugzilla.wikimedia.org/70861) (owner: 10Mooeypoo) [19:52:47] (03Merged) 10jenkins-bot: Set size to default on 0 value [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160790 (https://bugzilla.wikimedia.org/70861) (owner: 10Mooeypoo) [19:53:43] (03PS1) 10Esanders: Remove hard coded types from canHaveSlugBefore and fix logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161033 [19:55:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: The #contentSub should not be removed during loading phase - 10https://bugzilla.wikimedia.org/70954 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None 1. View https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License 2. Observe whitespace between... [19:57:12] (03CR) 10Krinkle: "fixme: Caused bug 70954. I should've seen that one coming. This was on purpose." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/107133 (https://bugzilla.wikimedia.org/52243) (owner: 10Esanders) [19:58:05] 3VisualEditor / 3MediaWiki integration: [Regression] VisualEditor: The #contentSub should not be removed during loading phase - 10https://bugzilla.wikimedia.org/70954#c1 (10Krinkle) Caused by I2d6157708bd7b4c3a7c647 which fixed bug 52243 and bug 54325. Perhaps we should use "visibility: hidden;" instead of... [19:59:05] 3VisualEditor / 3MediaWiki integration: [Regression] VisualEditor: The #contentSub should not be removed during loading phase - 10https://bugzilla.wikimedia.org/70954#c2 (10Krinkle) (In reply to Krinkle from comment #0) > 1. View https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License > 2. Observe wh... [19:59:36] 3VisualEditor / 3MediaWiki integration: [Regression] VisualEditor: The #contentSub should not be removed during loading phase - 10https://bugzilla.wikimedia.org/70954#c3 (10Krinkle) (In reply to Krinkle from comment #0) > 1. View https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License > 2. Observe wh... [20:06:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: Switching to source mode should show a spinner, pending state or similar - 10https://bugzilla.wikimedia.org/65012#c5 (10Rummana Yasmeen) Verified the fix in Betalabs [20:09:38] you know what's great? autofilling edit summary field. just sayin'. [20:10:25] with section summaries? [20:10:28] Elitre: Thank mooeypoo for putting it on the radar [20:10:53] 3VisualEditor / 3Editing Tools: VisualEditor: Highlight missing parameters in template dialog when complaining about them - 10https://bugzilla.wikimedia.org/70957 (10Roan Kattouw) 3ASSI p:3Unprio s:3normal a:3Alex Monk TODO someone needs to figure out what the visual treatment should look like The i... [20:11:14] Krenair: not necessarily. [20:11:56] RoanKattouw: I'll thank mooeypoo just because it's always right to do so. [20:12:27] section titles*, I guess... [20:12:36] (03CR) 10Catrope: [C: 04-1] Try to stop user from tabbing outside of open dialog box (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/159902 (https://bugzilla.wikimedia.org/67156) (owner: 10Alex Monk) [20:14:14] (03CR) 10Catrope: [C: 04-1] "We don't generally document things this way. The framed config option is defined in ButtonWidget (or ButtonElement? whichever), so it shou" [oojs/ui] - 10https://gerrit.wikimedia.org/r/160198 (owner: 10Rillke) [20:15:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] The Cite and Re-use options remains enabled even if the toolbar gets disabled when user clicks outside - 10https://bugzilla.wikimedia.org/70870#c3 (10Rummana Yasmeen) Verified the fix in Betalabs [20:18:23] 3VisualEditor / 3Editing Tools: VisualEditor: Highlight missing parameters in template dialog when complaining about them - 10https://bugzilla.wikimedia.org/70957#c1 (10James Forrester) p:5Unprio>3Normal s:5normal>3enhanc Possible options: * Put a red(?) ring/border around the field * Put a red(?) r... [20:19:13] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=51013 [20:21:39] RoanKattouw, oh, didn't we need to update wfUseMW for https://gerrit.wikimedia.org/r/#/c/156559/16 ? [20:21:48] Ahm, I guess so? [20:21:51] Oops, yes. [20:21:58] "We'll need to update our wfUseMW when that gets merged." [20:22:10] Sorry, I did notice that this morning, but then I forgot about it [20:22:20] I blame myself. [20:22:39] I put that on the radar? [20:23:02] I have no idea what I did, but you're most welcome. [20:23:37] and thanks for the merge, RoanKattouw :D [20:24:26] (03PS1) 10Alex Monk: Followup I35e55658: Update wfUseMW call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161040 [20:25:06] (03CR) 10Alex Monk: "We didn't update wfUseMW... Done in I7ecb0bbc" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/156559 (https://bugzilla.wikimedia.org/50747) (owner: 10Alex Monk) [20:25:08] (03CR) 10Jforrester: [C: 032] Followup I35e55658: Update wfUseMW call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161040 (owner: 10Alex Monk) [20:26:23] 3VisualEditor / 3Technical Debt: VisualEditor: Don't use OpenSearch for checking page existence - 10https://bugzilla.wikimedia.org/51013#c6 (10James Forrester) *** Bug 54361 has been marked as a duplicate of this bug. *** [20:26:23] 3VisualEditor / 3Editing Tools: VisualEditor: OpenSearch results aren't perfect for searching for pages (some don't come up) - 10https://bugzilla.wikimedia.org/54361#c3 (10James Forrester) 5ASSI>3RESO/DUP Actually, merging this into bug 51013 for actioning. *** This bug has been marked as a duplicate of... [20:26:25] (03Merged) 10jenkins-bot: Followup I35e55658: Update wfUseMW call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161040 (owner: 10Alex Monk) [20:28:03] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=70958 [20:28:12] 3VisualEditor / 3Technical Debt: VisualEditor: Don't use OpenSearch for checking page existence - 10https://bugzilla.wikimedia.org/51013 (10James Forrester) [20:46:57] (03CR) 10Catrope: [C: 031] Calculate slug positions in the model (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160838 (owner: 10Esanders) [20:48:27] (03CR) 10Catrope: [C: 04-1] Add hasSlugAtOffset to DM document (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160839 (owner: 10Esanders) [20:52:24] (03CR) 10Catrope: Add hasSlugAtOffset to DM document (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160839 (owner: 10Esanders) [20:53:15] (03CR) 10Catrope: [C: 031] Move getRelativeOffset, getRelativeRange, getNearestFocusableNode to model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160840 (owner: 10Esanders) [20:54:33] Hi ryasmeen [20:54:43] Hey Krenair [20:55:08] Did you say you were going to look at https://bugzilla.wikimedia.org/show_bug.cgi?id=70886#c10 earlier? [20:55:51] oh yes, Sorry ! I didnt get back to that, re-writing it [20:56:01] (03CR) 10Catrope: [C: 031] "I'm especially amused by the method in ListNode, which was returning false for nested lists and falling back to the parent for top-level l" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161033 (owner: 10Esanders) [20:56:53] no rush, was just wondering whether I should go and figure it out (I thought I remembered you mentioning it, so..) [20:57:59] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (24ac83a472) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161008 (owner: 10Jforrester) [20:59:16] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (24ac83a472) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161008 (owner: 10Jforrester) [20:59:40] Favorite bash hack of the day: (cd ../..; git show; cd -) | patch -p1 [21:00:56] ok Krenair, let me get back from a meeting then I will re-write it and let you know [21:01:29] (03PS1) 10Catrope: Add native range classes to documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161089 [21:02:04] (03Abandoned) 10Catrope: Add native range to categories.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160899 (owner: 10Esanders) [21:02:48] (03CR) 10jenkins-bot: [V: 04-1] Add native range classes to documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161089 (owner: 10Catrope) [21:20:53] 3MediaWiki / 3ResourceLoader: Investigate embedding some data URLs without base 64 - 10https://bugzilla.wikimedia.org/67341 (10Bartosz Dziewoński) a:3Bartosz Dziewoński [21:26:51] Krinkle|detached: James_F: do you want to me to anything to https://gerrit.wikimedia.org/r/#/c/161030/ (Move assets/ to resources/assets/) or should it be merged? [21:27:39] Krinkle|detached: James_F: if assets/ is really going to break prod, it'd be nice to do this before tomorrow… [21:29:36] 3MediaWiki / 3ResourceLoader: Embedded SVG files should be optimized in ResourceLoader/CSSMin - 10https://bugzilla.wikimedia.org/63491#c4 (10Bartosz Dziewoński) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 34812 *** [21:29:52] 3MediaWiki / 3ResourceLoader: Consider safely optimizing embedded SVG icons in MediaWiki core - 10https://bugzilla.wikimedia.org/59744 (10Bartosz Dziewoński) [21:29:52] 3MediaWiki / 3ResourceLoader: Allow minification of SVG files - 10https://bugzilla.wikimedia.org/34812#c3 (10Bartosz Dziewoński) *** Bug 63491 has been marked as a duplicate of this bug. *** [21:30:07] 3MediaWiki / 3ResourceLoader: Allow minification of SVG files - 10https://bugzilla.wikimedia.org/34812 (10Bartosz Dziewoński) [21:30:07] 3MediaWiki / 3ResourceLoader: Consider safely optimizing embedded SVG icons in MediaWiki core - 10https://bugzilla.wikimedia.org/59744 (10Bartosz Dziewoński) [21:36:36] 3MediaWiki / 3Page editing: Require POST for all changes; Never change content on HEAD-request - 10https://bugzilla.wikimedia.org/44602#c8 (10Jesús Martínez Novo (Ciencia Al Poder)) Not able to open rollback links on a new page means there's no way to rollback a lot of edits and also see what has been revert... [21:37:06] Krenair:Comment added in the bug [21:37:06] 3VisualEditor / 3Data Model: VisualEditor: In the Re-use reference list search is not returning correct results on the second initialization for a specific case - 10https://bugzilla.wikimedia.org/70886#c11 (10Rummana Yasmeen) So the issue here is actually about the reference search not working properly insid... [21:41:06] 3VisualEditor / 3Data Model: VisualEditor: In the Re-use reference list search is not returning correct results on the second initialization for a specific case - 10https://bugzilla.wikimedia.org/70886#c12 (10Rummana Yasmeen) (In reply to Rummana Yasmeen from comment #11) > So the issue here is actually abou... [21:43:39] ryasmeen, thanks! [21:44:02] Sure. [21:45:52] 3VisualEditor / 3Data Model: VisualEditor: In the Re-use reference list search is not returning correct results on the second initialization for a specific case - 10https://bugzilla.wikimedia.org/70886 (10Rummana Yasmeen) 5UNCO>3NEW [21:57:08] 3VisualEditor / 3Data Model: VisualEditor: In the Re-use reference dialog, search is not returning correct results on the second initialization for a specific case - 10https://bugzilla.wikimedia.org/70886 (10Rummana Yasmeen) [22:09:06] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog should recommend TemplateData-hinted mandatory parameters - 10https://bugzilla.wikimedia.org/50747#c21 (10Rummana Yasmeen) Verified the fix to show confirmation dialog when trying to insert/edit a template with one or more missing required par... [22:23:52] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In media dialog, "Size values are invalid" message does not show up, when choosing a different image and then setting its size to 0 x 0 px - 10https://bugzilla.wikimedia.org/70861 (10James Forrester) 5ASSI>3RESO/FIX [22:24:25] 3OOjs UI: InlineMenuWidget should behave as a menu widget - 10https://bugzilla.wikimedia.org/70968 (10Tisza Gergő) 3NEW p:3Unprio s:3enhanc a:3None Expected syntax: var menu = new oo.ui.InlineMenuWidget(); menu.addItems( items ); menu.chooseItem( item1 ); menu.on( 'select', doStuff ); Actual... [22:25:44] ryasmeen, can't reproduce this issue on beta.wmflabs.org... [22:28:30] actually... [22:29:47] Krenair: Can you try on this page :http://en.wikipedia.beta.wmflabs.org/wiki/Referencesearch?veaction=edit [22:30:21] and type "1 " inside re-use reference dialog [22:30:45] yep, that doesn't seem right :/ [22:30:56] yeah :) [22:31:24] so it comes up with more weirdness as you add more citations in the page [22:31:35] was just trying that [22:31:35] I just gave you the minimal to reproduce [22:32:40] only happens with Cite book? [22:34:04] nope it happens with any citation [22:34:22] but you need leave the required field empty [22:34:38] I dont know whats with it though :S [22:34:53] so not basic refs? [22:36:04] I've also just run into another ref bug :/ [22:36:12] no not with basic reference [22:36:22] okay...which one is that? [22:37:32] one ref on one line, one on a second line. select from end of second ref to end of first ref. delete. [22:38:02] (seems that selection has to be done with keyboard, not mouse, weirdly) [22:39:48] Ah! yeah..we had a similar kind of bug with selection..but that got fixed I think! [22:40:01] let me see if I find it in BZ [22:44:08] ryasmeen, it seems like searching '1' will show all citations. [22:44:41] you mean that is how it is supposed to work? [22:45:59] no, I don't think this is correct. [22:46:05] But that's what seems to be happening at the moment [22:46:11] yeah. [22:46:15] Also, why is different from the first time then? [22:47:01] when you search for 1 for the first time (before re-using it), it just returns [1] citation [22:52:04] ryasmeen, I can't reproduce that... it always appears to happen for me... [22:54:15] oh which one? that it appears with all citations? [22:54:32] I mean, it happens the first time as well. [22:54:40] Also, just tried to copy 2 references from one VE instance to another, got 3 out :/ [22:55:10] bonus bug ! :D [22:55:34] :D [22:55:46] okay but for me , it works fine on the first attempt [22:56:09] ryasmeen, try http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Referencesearch/2&veaction=edit [22:56:13] anyways, on both cases it has to be same right? Should just return the matched result [22:57:42] ok in this page , you have already re-used one of them [22:58:27] that is why all the citations are appearing after the search [23:00:07] ryasmeen, I edited the page so they should not be re-uses at all [23:00:09] try now? [23:05:20] I don't like the look of that text = [ view.$element.text().toLowerCase(), citation, name ].join( ' ' ); line in the ReferenceSearchWidget [23:05:33] We use that to do the query, but view.$element isn't necessarily loaded at this point IIRC [23:05:36] okay, so i think once you save the page after adding those citations , you will get all citations.So try a new page where there is no citation already [23:08:34] on my local wiki all of the citation templates match '1' because they do {{#invoke:citation/CS1}}, and I don't have Scribunto or that module installed [23:08:53] But on beta... [23:13:57] Oh, ryasmeen [23:14:10] It links to a page with '1' in its name [23:14:20] (the missing or empty error for book citations) [23:14:34] oooh no ! :| [23:14:55] thats why it happens when you only have missing parameters.hmmm [23:15:00] presumably why the issue went away when you set the title [23:15:16] right [23:15:55] hahaha [23:16:02] So what you're saying is this is a feature? :P [23:19:51] well, no it is not :P But I dont know if there is any work around for this special case of missing parameter help page [23:20:27] I'm not sure why this link is included in the text searched... [23:22:01] Krenair: Which link? [23:22:39] Krenair: Do you mean, the text output of the reference? That's by design. [23:22:55] oh, right. [23:22:56] Yeah [23:23:04] // Make URLs searchable. [23:23:09] * James_F nods. [23:23:17] view.$element.find( 'a[href]' ).each( extractAttrs ); [23:23:24] Bingo. [23:24:21] This is the link included in the 'missing or empty |title=' error you get from Cite book if you don't specify title= [23:25:10] it includes '1' (Help:CS1_errors#citation_missing_title), so searching for '1' returns the ref [23:32:58] (03CR) 10Esanders: "Yeah - I had to read that a few times before realising it was completely pointless." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161033 (owner: 10Esanders) [23:33:36] ryasmeen, is https://bugzilla.wikimedia.org/show_bug.cgi?id=70886 still valid? [23:41:17] Krenair, I think we can mark it as Invalid [23:47:05] * hexmode sighs [23:47:14] hi hexmode [23:47:20] hey [23:47:27] Krenair: if you can add your comment in the bug [23:47:34] so, of course, I have a question [23:47:55] I'm seeing "TypeError: mw.log.warning is not a function" [23:48:07] got a clue for a fix? [23:48:27] Are you using a new version of VE with an old version of MW? [23:48:51] I have 1.23wmf20, I think [23:49:00] it was the one it said to use [23:49:46] oh... wasn't that supposed to be 1.24wmf20? [23:50:05] yep :/ [23:50:44] Whoops. [23:50:47] * James_F looks. [23:51:05] https://gerrit.wikimedia.org/r/#/c/161040/1/VisualEditor.hooks.php [23:51:07] No, 1.24wmf20. [23:53:21] yeah [23:53:37] so, anyway, I am going to try to sync everything [23:53:44] should have tried that first [23:53:45] :P [23:54:25] I meant 1.24wmf20 above. sorry [23:58:20] (03PS1) 10Jforrester: Update VE core submodule to master (0d5eff7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161138 [23:58:57] btw RoanKattouw: ty for all the ie work. I owe you your gift of choice. [23:59:04] or a beer [23:59:11] ok, works now. [23:59:17] and IE comes up [23:59:31] just me not syncing branches