[00:11:36] hexmode: Are you testing in IE11 or IE10? [00:11:38] I would love input [00:11:52] We greylisted IE11 in production and found corruption issues, but I don't really know what the user experience is like very well [00:12:04] Other than that there are scrolling bugs, and IE11 renders like crap [00:12:36] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf12] Link Suggestions are now not appearing for Desktop VE - 10https://bugzilla.wikimedia.org/67437#c6 (10Rummana Yasmeen) 5VERI>3REOP This got broken again apparently in last few hours. [00:12:51] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf12] Link Suggestions are now not appearing for Desktop VE - 10https://bugzilla.wikimedia.org/67437 (10Rummana Yasmeen) 5REOP>3ASSI [00:14:12] (03PS1) 10Catrope: Followup cc657c4: make code and strikethrough key commands actually work [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161142 [00:14:27] (03CR) 10Jforrester: [C: 032] Followup cc657c4: make code and strikethrough key commands actually work [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161142 (owner: 10Catrope) [00:16:16] (03Merged) 10jenkins-bot: Followup cc657c4: make code and strikethrough key commands actually work [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161142 (owner: 10Catrope) [00:25:37] (03PS2) 10Jforrester: Update VE core submodule to master (6f1b98e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161138 [00:25:43] RoanKattouw: ^^^ Sorry. [00:25:49] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (6f1b98e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161138 (owner: 10Jforrester) [00:27:05] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (6f1b98e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161138 (owner: 10Jforrester) [00:27:17] (03Merged) 10jenkins-bot: Update VE core submodule to master (6f1b98e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161138 (owner: 10Jforrester) [00:27:28] RoanKattouw: Juts reopened this onehttps://bugzilla.wikimedia.org/show_bug.cgi?id=67437 [00:28:00] We got it broken somehow in last few hrs [00:28:58] (03PS1) 10Catrope: Make the trigger demo kind of work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161145 [00:39:51] (03CR) 10Jforrester: [C: 032] Make the trigger demo kind of work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161145 (owner: 10Catrope) [00:41:05] (03Merged) 10jenkins-bot: Make the trigger demo kind of work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161145 (owner: 10Catrope) [00:43:06] (03Abandoned) 10Jforrester: Use start rect instead of bounding rect in ve.ui.Toolbar#onSurfaceViewKeyUp [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160171 (owner: 10Catrope) [00:59:03] (03PS1) 10Catrope: Followup 6c862e8: position before AND after showing in TextInputMenuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/161150 (https://bugzilla.wikimedia.org/67437) [01:02:01] TrevorParscal: https://gerrit.wikimedia.org/r/161150 [01:04:13] (03CR) 10Trevor Parscal: [C: 032] Followup 6c862e8: position before AND after showing in TextInputMenuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/161150 (https://bugzilla.wikimedia.org/67437) (owner: 10Catrope) [01:04:59] (03Merged) 10jenkins-bot: Followup 6c862e8: position before AND after showing in TextInputMenuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/161150 (https://bugzilla.wikimedia.org/67437) (owner: 10Catrope) [01:09:32] How can I edit a parameter of a template in VisualEditor mode rather than wikitext? [01:09:35] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In media dialog, "Size values are invalid" message does not show up, when choosing a different image and then setting its size to 0 x 0 px - 10https://bugzilla.wikimedia.org/70861#c7 (10Rummana Yasmeen) 5RESO/FIX>3REOP Right now, if you try... [01:09:51] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In media dialog, "Size values are invalid" message does not show up, when choosing a different image and then setting its size to 0 x 0 px - 10https://bugzilla.wikimedia.org/70861 (10Rummana Yasmeen) 5REOP>3ASSI [01:17:58] (03PS4) 10Jforrester: build: Make headers atop dist files suitable for distribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 (owner: 10Krinkle) [01:18:43] (03CR) 10jenkins-bot: [V: 04-1] build: Make headers atop dist files suitable for distribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 (owner: 10Krinkle) [01:18:53] (03CR) 10Jforrester: "PS4 is a rebase, plus application of the new header to files that were missed previously." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 (owner: 10Krinkle) [01:20:07] jimt, a parameter name? [01:20:38] jimt: That's not supported yet but will be in a few months [01:21:09] RoanKattouw: Thanks. It would be very useful. [01:21:45] Krenair: No, the parameter value, where currently "raw" wikitext is shown in the form textarea. [01:22:20] ahh [01:23:15] (03PS5) 10Jforrester: build: Make headers atop dist files suitable for distribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 (owner: 10Krinkle) [01:23:24] (03CR) 10Jforrester: "PS5 fixes a mis-rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 (owner: 10Krinkle) [01:25:41] James_F: https://github.com/Krinkle/dotfiles/blob/master/modules/aliases.sh#L19 [01:25:43] (might be useful) [01:25:51] I use nit all the time [01:25:55] instead of 'grunt' [01:28:26] (03CR) 10Jforrester: [C: 031] build: Make headers atop dist files suitable for distribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 (owner: 10Krinkle) [01:29:30] jimt: Yeah, it would be. Parsoid built experimental support for it but I need to get around to playing with it and integrating it into VisualEditor [02:46:36] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In media dialog, "Size values are invalid" message does not show up, when choosing a different image and then setting its size to 0 x 0 px - 10https://bugzilla.wikimedia.org/70861#c8 (10Moriel Schottlender) We didn't want to force an input on t... [03:54:45] (03PS1) 10Catrope: Fix automatic sizing of windows [oojs/ui] - 10https://gerrit.wikimedia.org/r/161165 (https://bugzilla.wikimedia.org/70016) [04:01:13] (03CR) 10Krinkle: [C: 032] build: Make headers atop dist files suitable for distribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 (owner: 10Krinkle) [04:42:23] 3VisualEditor / 3Editing Tools: VisualEditor:Shrink back the Basic Reference dialog size - 10https://bugzilla.wikimedia.org/70016 (10James Forrester) a:5Trevor Parscal>3Roan Kattouw [04:48:26] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (ec785c2c64) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161171 [04:48:47] (03Abandoned) 10Jforrester: [WIP] Typing tests using jQuery.IME [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121452 (owner: 10Jforrester) [13:12:06] 3MediaWiki extensions / 3WikiEditor: Editing too quickly causes EditWarning not to work - 10https://bugzilla.wikimedia.org/24509 (10Andre Klapper) [13:15:52] 3MediaWiki / 3Page editing: Links to newly created pages become blue only after a too big delay - 10https://bugzilla.wikimedia.org/47199#c18 (10Andre Klapper) VictorPorton: Have you fixed your setup creating the issue in comment 16/17? [14:17:20] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL, affecting .background-image-svg() and others - 10https://bugzilla.wikimedia.org/66091 (10Bartosz Dziewoński) [14:17:35] 3MediaWiki / 3ResourceLoader: External link icon is not flipped in RTL - 10https://bugzilla.wikimedia.org/68326 (10Bartosz Dziewoński) [15:13:06] 3MediaWiki / 3ResourceLoader: CSSMin::encodeImageAsDataURI() should be smarter about SVG images (tracking) - 10https://bugzilla.wikimedia.org/57777 (10Bartosz Dziewoński) [15:13:07] 3MediaWiki / 3ResourceLoader: CSSMin doesn't need to generate double rules for IE<8 when embedding SVG files - 10https://bugzilla.wikimedia.org/71003 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3minor a:3None CSSMin doesn't need to generate double rules for IE<8 when embedding SVG files. IE<8 will not lo... [15:15:22] 3MediaWiki / 3ResourceLoader: ResourceLoader: Remove custom LESS functions - 10https://bugzilla.wikimedia.org/67368 (10Bartosz Dziewoński) a:3Bartosz Dziewoński [15:15:37] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL, affecting .background-image-svg() and others - 10https://bugzilla.wikimedia.org/66091 (10Bartosz Dziewoński) a:3Bartosz Dziewoński [15:16:07] 3MediaWiki / 3ResourceLoader: External link icon is not flipped in RTL - 10https://bugzilla.wikimedia.org/68326#c2 (10Bartosz Dziewoński) p:5Low>3High a:3Bartosz Dziewoński Sorry it took so long. The fix is now available and should be applied within days (or weeks, top). [15:20:51] 3MediaWiki / 3ResourceLoader: LESS compiler should preserve the position of CSSMin / CSSJanus annotations - 10https://bugzilla.wikimedia.org/54673#c12 (10Bartosz Dziewoński) For /* @embed */ annotations, it turns out it is actually possible to use them without lessc mucking about, using the "infix" syntax:... [15:27:50] 3MediaWiki / 3ResourceLoader: background-image-svg does not embed correctly - 10https://bugzilla.wikimedia.org/61941#c10 (10Bartosz Dziewoński) My fix caused bug 66091. I submitted a better fix for it now. [15:34:36] I wonder if I can use LinkCache to store category hidden status in https://gerrit.wikimedia.org/r/#/c/159623/2/modules/ve-mw/ui/widgets/ve.ui.MWCategoryInputWidget.js [16:21:47] (03PS6) 10Krinkle: build: Make headers atop dist files suitable for distribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 [16:23:18] (03CR) 10jenkins-bot: [V: 04-1] build: Make headers atop dist files suitable for distribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 (owner: 10Krinkle) [16:23:30] Krinkle: What did you do?! [16:24:51] (03PS7) 10Krinkle: build: Make headers atop dist files suitable for distribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 [16:26:06] (03CR) 10jenkins-bot: [V: 04-1] build: Make headers atop dist files suitable for distribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 (owner: 10Krinkle) [16:27:40] 3VisualEditor: When adding a citation there should be some button that gives the current day to a chosen field - 10https://bugzilla.wikimedia.org/71005 (10Stryn) 3NEW p:3Unprio s:3normal a:3None I mean, when you click Cite -> Website and go to "URL access date" field, there are just "field description"... [16:30:30] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13409721 [16:30:30] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32712263 [16:30:30] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32712276 [16:30:30] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32712285 [16:30:30] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32712324 [16:34:43] James_F: well, that's fucked. [16:34:50] PhantomJS is killing itself? [16:34:56] Might as well -_- [16:35:01] Works locally on the same version of phantomjs [16:35:07] Linux can be depressing I guess.. [16:35:23] * James_F sighs. [16:47:11] (03CR) 10Krinkle: [C: 032] build: Make headers atop dist files suitable for distribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 (owner: 10Krinkle) [16:48:41] (03Merged) 10jenkins-bot: build: Make headers atop dist files suitable for distribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158883 (owner: 10Krinkle) [16:49:44] Huh. [16:51:07] turtles. [16:52:57] All the way down to Jenkins. [17:22:06] (03PS1) 10Esanders: Move deletion part of handleDelete logic to surface fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161266 [17:25:06] 3MediaWiki / 3ResourceLoader: External link icon is not flipped in RTL - 10https://bugzilla.wikimedia.org/68326#c3 (10Krinkle) 5PATC>3RESO/DUP These aren't really dependant, it's just the same thing for a specific image. Duping instead. *** This bug has been marked as a duplicate of bug 66091 *** [17:25:06] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL, affecting .background-image-svg() and others - 10https://bugzilla.wikimedia.org/66091#c8 (10Krinkle) *** Bug 68326 has been marked as a duplicate of this bug. *** [17:32:46] (03CR) 10Esanders: Add hasSlugAtOffset to DM document (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160839 (owner: 10Esanders) [17:35:41] mooeypoo: lol Krinkle is playing something that sounds like the karaoke version of Let It Go [17:36:06] Are you singing? [17:39:11] No he's just using the Frozen soundtrack as background music it seems [17:41:56] (03CR) 10Krinkle: "There should be a space in between." [oojs/core] - 10https://gerrit.wikimedia.org/r/160262 (owner: 10Jforrester) [17:42:29] mooeypoo: He was humming "Do You Want To Build A Snowman" just now :) [17:45:12] (03PS3) 10Jforrester: README: Add devDependencies badge [oojs/core] - 10https://gerrit.wikimedia.org/r/160262 [17:46:04] (03PS2) 10Jforrester: README: Add devDependencies badge [oojs/ui] - 10https://gerrit.wikimedia.org/r/160264 [17:46:24] RoanKattouw, slowly but surely, I will convert you all. [17:52:45] RoanKattouw: It was in fact the instrumental version of just that [17:57:36] (03PS4) 10Esanders: Move getRelativeOffset, getRelativeRange, getNearestFocusableNode to model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160840 [17:57:38] (03PS2) 10Esanders: Move deletion part of handleDelete logic to surface fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161266 [17:57:40] (03PS3) 10Esanders: Add hasSlugAtOffset to DM document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160839 [17:58:32] (03CR) 10Esanders: Move sluggability methods to model (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160837 (owner: 10Esanders) [18:01:54] (03CR) 10jenkins-bot: [V: 04-1] Move deletion part of handleDelete logic to surface fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161266 (owner: 10Esanders) [18:02:52] RoanKattouw: Assigning this to you https://gerrit.wikimedia.org/r/#/c/161091/3 [18:04:36] 3MediaWiki / 3ResourceLoader: CSSMin: Embed non-binary data URIs using plain text instead of base64 - 10https://bugzilla.wikimedia.org/67341 (10Krinkle) [18:05:19] oh, also. i have nothing to do. if you want me to do something, do tell. [18:05:56] (i'll find something if not) [18:06:28] RoanKattouw, I've got another diff for you to look at, related to the Badtitletext problem in Firefox: https://fy.wikipedia.org/w/index.php?title=Willem_IV_fan_Oranje-Nassau&diff=700856&oldid=645964 [18:07:19] Oh, yup [18:07:39] I hadn't seen that encoding of |link= before but that's what I would expect to have happened [18:08:35] I'll assume that it's fixed by your patch, then. [18:13:42] RoanKattouw, I've found a weird little nest of badtitletexts in edits made back in June at ast.wp. [18:14:06] Weird [18:14:14] Do you think that might be connected at all? It looks very different; it replaces numbers with the link. [18:14:23] Numbers? WTF [18:14:28] Can you show me an example? [18:14:30] https://ast.wikipedia.org/w/index.php?title=Peligru_Mariellu&diff=747158&oldid=747157 [18:14:49] Fixed here: https://ast.wikipedia.org/w/index.php?title=Peligru_Mariellu&diff=747159&oldid=747158 [18:14:52] (Yes the |link= thing is almost certainly caused by my first patch and fixed by my second patch on Tuesday) [18:15:05] But then another is here: https://ast.wikipedia.org/w/index.php?title=Peligru_Mariellu&diff=747160&oldid=747159 [18:15:38] Same article/same editor. S/he pasted wikitext source into VisualEditor and is trying to clean it up. [18:15:57] Weird. Maybe the author tried to link 1922 to something "weird" [18:16:18] "1922" and "sieglu XX" (I think that's 20th century) are being replaced. [18:16:36] Should this be filed as a Parsoid bug? [18:17:41] Maybe [18:17:50] But it's impossible to tell what happened [18:18:01] I suspect that the user tried to make the link target something with interesting characters in it [18:18:11] But we have no way of telling what those interesting characters might have been [18:18:34] Krinkle: Review of https://gerrit.wikimedia.org/r/#/c/159076/ please? [18:18:43] TrevorP|Away: Review of https://gerrit.wikimedia.org/r/#/c/161165/ please? [18:18:55] RoanKattouw: Review of https://gerrit.wikimedia.org/r/#/c/161171/ please? [18:19:17] The page is a mess now. I can't even paste text into it. [18:19:34] (03PS8) 10Krinkle: build: Use csscomb to prettify the CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/159076 (owner: 10Jforrester) [18:20:51] Yaaay browsers https://bugzilla.mozilla.org/show_bug.cgi?id=1069501 [18:21:26] Especially https://i.imgur.com/egy8PSJ.png [18:21:50] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (ec785c2c64) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161281 [18:21:52] (03PS1) 10Jforrester: Follow-up cc657c4: Change strikethrough key command to not clash with Macs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161282 [18:21:59] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (ec785c2c64) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161171 (owner: 10Jforrester) [18:22:51] (03Abandoned) 10Jforrester: Update OOjs UI to v0.1.0-pre (ec785c2c64) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161281 (owner: 10Jforrester) [18:22:53] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (ec785c2c64) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161171 (owner: 10Jforrester) [18:23:01] (03PS2) 10Jforrester: Follow-up cc657c4: Change strikethrough key command to not clash with Macs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161282 [18:26:10] 3VisualEditor / 3Editing Tools: VisualEditor: Add a shortcut for strikethrough (?which?) - 10https://bugzilla.wikimedia.org/60257#c6 (10Rummana Yasmeen) 5RESO/FIX>3REOP We need to change the shortcut key for code annotation on mac from "cmd+shift+3".Because,its a shortcut to take screenshot so it does no... [18:30:16] (03CR) 10Krinkle: [C: 032] build: Use csscomb to prettify the CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/159076 (owner: 10Jforrester) [18:30:22] (03PS6) 10Krinkle: build: Create minified JS and CSS distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 (owner: 10Jforrester) [18:30:29] (03CR) 10Trevor Parscal: [C: 032] Fix automatic sizing of windows [oojs/ui] - 10https://gerrit.wikimedia.org/r/161165 (https://bugzilla.wikimedia.org/70016) (owner: 10Catrope) [18:30:53] James_F: did you see my email about monday or tuesday? [18:31:29] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (ec785c2c64) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161171 (owner: 10Jforrester) [18:31:57] (03Merged) 10jenkins-bot: build: Use csscomb to prettify the CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/159076 (owner: 10Jforrester) [18:32:04] (03Merged) 10jenkins-bot: Fix automatic sizing of windows [oojs/ui] - 10https://gerrit.wikimedia.org/r/161165 (https://bugzilla.wikimedia.org/70016) (owner: 10Catrope) [18:33:46] (03PS3) 10Jforrester: Follow-up cc657c4: Change strikethrough key command to not clash with Macs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161282 [18:36:00] (03CR) 10Krinkle: [C: 032] README: Add devDependencies badge [oojs/ui] - 10https://gerrit.wikimedia.org/r/160264 (owner: 10Jforrester) [18:36:23] (03CR) 10Krinkle: [C: 032] README: Add devDependencies badge [oojs/core] - 10https://gerrit.wikimedia.org/r/160262 (owner: 10Jforrester) [18:36:49] (03Merged) 10jenkins-bot: README: Add devDependencies badge [oojs/ui] - 10https://gerrit.wikimedia.org/r/160264 (owner: 10Jforrester) [18:37:09] legoktm: I did. RoanKattouw, Krinkle: What do you think? [18:37:22] (03CR) 10Krinkle: [C: 04-1] "Per James, let's try to find a better commit message for this." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160034 (owner: 10Esanders) [18:39:11] (03Merged) 10jenkins-bot: README: Add devDependencies badge [oojs/core] - 10https://gerrit.wikimedia.org/r/160262 (owner: 10Jforrester) [18:40:05] (03CR) 10Jforrester: Emit more events (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160034 (owner: 10Esanders) [18:41:07] 3VisualEditor / 3Editing Tools: VisualEditor:Shrink back the Basic Reference dialog size - 10https://bugzilla.wikimedia.org/70016 (10James Forrester) 5PATC>3RESO/FIX [18:41:33] (03CR) 10Krinkle: [C: 032] README: Add devDependencies badge [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160818 (owner: 10Jforrester) [18:42:06] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In media dialog, "Size values are invalid" message does not show up, when choosing a different image and then setting its size to 0 x 0 px - 10https://bugzilla.wikimedia.org/70861#c9 (10Rummana Yasmeen) (In reply to Moriel Schottlender from com... [18:43:16] (03Merged) 10jenkins-bot: README: Add devDependencies badge [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160818 (owner: 10Jforrester) [18:44:27] (03PS5) 10Esanders: Rename inlineRects to startAndEndRects everywhere [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160495 [18:44:29] (03PS13) 10Esanders: Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 [18:44:31] (03PS4) 10Esanders: Remove getSelection*Client* methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160579 [18:44:33] (03PS12) 10Esanders: Refactor out finding of CE focusedNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159949 [18:44:35] (03PS8) 10Esanders: Emit 'position' and 'contextChange' events correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160034 [18:44:37] (03PS4) 10Esanders: Provide a method to get all the rectangles for a given selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160591 [18:44:39] (03PS2) 10Esanders: Workaround Chrome's Range.getClientRects bug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161017 [18:44:41] (03PS14) 10Esanders: Allow specification of range when getting selection rectangles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160073 [18:44:43] (03PS7) 10Esanders: Add getNativeRange method with optional DM range argument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160303 [18:49:47] Krinkle: Can you help with https://gerrit.wikimedia.org/r/161089 ? [18:50:38] Checking [18:51:04] RoanKattouw: Those three classes don't exist, they're not defined anywhere in our code [18:51:11] You can only categories classes you document. [18:51:22] 3MediaWiki / 3ResourceLoader: CSSMin doesn't need to generate double rules for IE<8 when embedding SVG files - 10https://bugzilla.wikimedia.org/71003#c1 (10db) Is that needed for Grade C browsers? Maybe remove support for IE7 there also. [18:51:24] if you want it to ignore those classes and allow them as upstream types, add them to jsduck.conf [18:51:25] RoanKattouw: [18:51:30] Aah OK [18:51:45] RoanKattouw, I wonder if I can use LinkCache to store category hidden status in https://gerrit.wikimedia.org/r/#/c/159623/2/modules/ve-mw/ui/widgets/ve.ui.MWCategoryInputWidget.js [18:51:52] can/should* [18:52:21] 3VisualEditor / 3Editing Tools: VisualEditor: Image should not change size when going from read to edit - 10https://bugzilla.wikimedia.org/67047#c5 (10Jared Zimmerman (WMF)) I'd like to revisit this, the current behavior is actively against the WYSIWYG model established in VE. I'm still not understanding the... [18:52:40] Krenair: We use category hidden status in the interface elsewhere, right? In the popups? [18:52:47] IIRC, yep. [18:52:51] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf12] Link Suggestions are now not appearing for Desktop VE - 10https://bugzilla.wikimedia.org/67437#c9 (10Rummana Yasmeen) 5PATC>3RESO/FIX Verified the fix in Betalabs [18:52:51] Right, then yes [18:53:07] 3MediaWiki / 3ResourceLoader: CSSMin doesn't need to generate double rules for IE<8 when embedding SVG files - 10https://bugzilla.wikimedia.org/71003#c2 (10Bartosz Dziewoński) We only dropped JS for IE 6 and 7, we still support them for basic CSS. [18:53:10] Things like prefix searches should only write to the LinkCache, not read, because there's no point. You're already getting information from the API, might as well ask for some more [18:53:45] RoanKattouw, https://bugzilla.wikimedia.org/show_bug.cgi?id=70957 - highlight on the dialog behind the confirmation dialog? [18:54:05] well, I guess it would stay there if the confirmation dialog is dismissed and they go back to editing the template [18:54:10] But things like status of existing things, like category widgets or links in the page, that's good for reading from LinkCache, because 1) you'd actually be saving a request if you hit the cache, it's not like search where you're already in a position where you have to hit the API anyway and 2) you're likely to have just done a search recently that included that result [18:54:25] until the user typed something, I guess. [18:54:34] Yeah, I don't know [18:54:40] I was hoping TrevorP|Away would have some thoughts [18:58:05] (03CR) 10Catrope: [C: 04-1] Add hasSlugAtOffset to DM document (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160839 (owner: 10Esanders) [18:58:21] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Clicking in the document where an inspector was opened doesn't close the inspector - 10https://bugzilla.wikimedia.org/68679 (10James Forrester) [18:58:21] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In media dialog, "Size values are invalid" message does not show up, when choosing a different image and then setting its size to 0 x 0 px - 10https://bugzilla.wikimedia.org/70861 (10James Forrester) [18:58:41] 3VisualEditor / 3Editing Tools: VisualEditor: In the media insertion dialog, give a tooltip on each item saying what will happen when you click it (i.e., "Click to insert as a thumbnail" or whatever) - 10https://bugzilla.wikimedia.org/52219 (10James Forrester) [18:58:41] 3VisualEditor / 3Editing Tools: VisualEditor: Triggering context on link after defocus throws "TypeError: Cannot read property 'isCollapsed' of null" - 10https://bugzilla.wikimedia.org/68915 (10James Forrester) [18:58:41] 3VisualEditor / 3Editing Tools: VisualEditor: Do not let me tab outside the dialog box in Chrome/Safari - 10https://bugzilla.wikimedia.org/67156 (10James Forrester) [18:58:42] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - 10https://bugzilla.wikimedia.org/66604 (10James Forrester) [18:58:43] 3VisualEditor / 3MediaWiki integration: VisualEditor: After saving a page reference list gets missing (unless it is refreshed again) and the page gets categorized as "Pages with missing reference list" - 10https://bugzilla.wikimedia.org/68182 (10James Forrester) [18:59:02] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10James Forrester) [18:59:02] 3VisualEditor / 3Editing Tools: VisualEditor: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - 10https://bugzilla.wikimedia.org/68590 (10James Forrester) [18:59:02] 3VisualEditor / 3Data Model: VisualEditor: Make transaction processing exception-safe - 10https://bugzilla.wikimedia.org/68892 (10James Forrester) [18:59:03] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10James Forrester) [18:59:04] 3VisualEditor / 3MediaWiki integration: VisualEditor: Link existence checker in LinkTargetInputWidget doesn't work for interwikis, language links - 10https://bugzilla.wikimedia.org/70504 (10James Forrester) [18:59:05] 3VisualEditor / 3Editing Tools: VisualEditor: In the media selector show name in a tooltip on mouseover - 10https://bugzilla.wikimedia.org/52459 (10James Forrester) [18:59:06] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf20] The link target suggestion drop down is appearing cut off to a very small size upon first time opening the link inspector - 10https://bugzilla.wikimedia.org/70683 (10James Forrester) [18:59:07] 3VisualEditor / 3Editing Tools: VisualEditor: Support "substituting" templates in transclusion dialog - 10https://bugzilla.wikimedia.org/49904 (10James Forrester) [18:59:08] 3VisualEditor / 3ContentEditable: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - 10https://bugzilla.wikimedia.org/69474 (10James Forrester) [18:59:09] 3VisualEditor / 3Editing Tools: VisualEditor: Append references list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906 (10James Forrester) [18:59:15] 3VisualEditor / 3ContentEditable: VisualEditor: Out-of-skin templates are taking editors to linked pages, rather than letting them edit the template - 10https://bugzilla.wikimedia.org/70074 (10James Forrester) [18:59:15] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10James Forrester) [18:59:15] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195 (10James Forrester) [18:59:16] 3VisualEditor / 3ContentEditable: VisualEditor: Up/down arrow in Firefox broken after using left/right - 10https://bugzilla.wikimedia.org/70724 (10James Forrester) [18:59:17] 3VisualEditor / 3Editing Tools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - 10https://bugzilla.wikimedia.org/68537 (10James Forrester) [18:59:18] 3VisualEditor / 3Editing Tools: VisualEditor: Reference group input combo box does not populate the Reference group names if created from Reference list dialog - 10https://bugzilla.wikimedia.org/70365 (10James Forrester) [18:59:19] 3VisualEditor / 3Data Model: VisualEditor: tags appear when editing on the Hebrew Wiki - 10https://bugzilla.wikimedia.org/66210 (10James Forrester) [18:59:21] 3VisualEditor / 3Data Model: VisualEditor: Investigate parsing/rendering/behavior of "{{MW 1.23}}" on mediawiki.org [mini-tracking] - 10https://bugzilla.wikimedia.org/68297 (10James Forrester) [18:59:26] 3VisualEditor / 3Editing Tools: VisualEditor: Insert > References list is very large in Firefox - 10https://bugzilla.wikimedia.org/70545 (10James Forrester) [18:59:26] 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580 (10James Forrester) [18:59:26] 3VisualEditor / 3ContentEditable: VisualEditor: Deleting from an empty paragraph to the end of an inline node throws an exception - 10https://bugzilla.wikimedia.org/70375 (10James Forrester) [18:59:27] 3VisualEditor / 3Mobile: VisualEditor Mobile: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110 (10James Forrester) [19:01:25] edsanders: https://gerrit.wikimedia.org/r/#/c/159006/1/modules/ve-mw/ui/widgets/ve.ui.MWReferenceGroupInputWidget.js is what I was talking about [19:02:52] 3VisualEditor / 3Editing Tools: VisualEditor: The language dialog will not close if you paste in content with an auto direction and no language - 10https://bugzilla.wikimedia.org/70731 (10James Forrester) [19:02:58] (03CR) 10Catrope: [C: 031] Move getRelativeOffset, getRelativeRange, getNearestFocusableNode to model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160840 (owner: 10Esanders) [19:03:03] (03PS2) 10Catrope: Remove hard coded types from canHaveSlugBefore and fix logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161033 (owner: 10Esanders) [19:03:22] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In media dialog, "Size values are invalid" message does not show up, when choosing a different image and then setting its size to 0 x 0 px - 10https://bugzilla.wikimedia.org/70861#c10 (10Moriel Schottlender) (In reply to Rummana Yasmeen from co... [19:06:33] (03PS4) 10Catrope: Add hasSlugAtOffset to DM document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160839 (owner: 10Esanders) [19:06:47] (03CR) 10Catrope: [C: 032] Add hasSlugAtOffset to DM document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160839 (owner: 10Esanders) [19:06:52] (03CR) 10Catrope: [C: 032] Calculate slug positions in the model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160838 (owner: 10Esanders) [19:06:58] (03CR) 10Catrope: [C: 032] Move sluggability methods to model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160837 (owner: 10Esanders) [19:07:06] (03PS5) 10Catrope: Move getRelativeOffset, getRelativeRange, getNearestFocusableNode to model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160840 (owner: 10Esanders) [19:07:10] (03CR) 10Catrope: [C: 032] Move getRelativeOffset, getRelativeRange, getNearestFocusableNode to model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160840 (owner: 10Esanders) [19:07:14] (03PS3) 10Catrope: Remove hard coded types from canHaveSlugBefore and fix logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161033 (owner: 10Esanders) [19:07:18] (03CR) 10Catrope: [C: 032] Remove hard coded types from canHaveSlugBefore and fix logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161033 (owner: 10Esanders) [19:07:21] :o [19:07:31] PLUS TWO ALL THE THINGS [19:08:45] (03Merged) 10jenkins-bot: Move sluggability methods to model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160837 (owner: 10Esanders) [19:08:46] I merged one of Ed's stacks yesterday, this is number two, and the third stack I'm reviewing now is as big as the first two combined [19:09:33] (03Merged) 10jenkins-bot: Calculate slug positions in the model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160838 (owner: 10Esanders) [19:09:35] (03Merged) 10jenkins-bot: Add hasSlugAtOffset to DM document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160839 (owner: 10Esanders) [19:09:46] (03Merged) 10jenkins-bot: Move getRelativeOffset, getRelativeRange, getNearestFocusableNode to model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160840 (owner: 10Esanders) [19:09:48] (03Merged) 10jenkins-bot: Remove hard coded types from canHaveSlugBefore and fix logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161033 (owner: 10Esanders) [19:10:53] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161266 (owner: 10Esanders) [19:11:00] (03PS3) 10Esanders: Move deletion part of handleDelete logic to surface fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161266 [19:17:34] Hey guys [19:18:22] We used to override close( data ) in dialogs and check data.cancel to know if the user clicked the X in the top corner of the dialog. [19:18:24] Krinkle: background(-position)?\s*:\s*(?:quantity|keyword)*?(quantity) [19:19:12] Should I do the same thing in getTeardownProcess( data ) before it returns a process step? Or should I bind to click on the X button instead? [19:19:38] 3MediaWiki / 3Page editing: user common.js edit (codeeditor) view page loads in distracting way - 10https://bugzilla.wikimedia.org/71015 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None when you load https://en.wikipedia.org/wiki/Special:MyPage/common.js in edit mode the page refactors, fla... [19:19:56] I couldn't find any examples of getTeardownProcess() doing anything other than returning with .first or .next [19:20:01] RoanKattouw: [19:20:01] BladeBronson: So remember when Trevor was like "I should explain these changes to you in an hour so you don't find out over the course of days"? [19:20:03] RoanKattouw: https://github.com/operasoftware/flipcss/blob/master/lib/flipcss.js#L155 [19:20:12] BladeBronson: I think he meant this process change [19:20:16] heh [19:20:42] well, we've been using getTeardownProcess for a few months since our last upstream sync - so we're not overriding close() anymore. [19:20:56] Krinkle: background(-position)?\s*:\s*(?:\S+\s*)*?(quantity) [19:20:58] But now I've run into the situation where I need to determine what is causing the dialog to close. [19:21:03] OK [19:21:08] Yeah that'll still be in data.action [19:21:23] yep, so i should just track in getTeardownProcess before returning? [19:21:28] But you need to override getTeardownProcess() to inspect it, overriding close() is not cool any more [19:21:32] Well it depends on what you're doing [19:21:48] Just firing some Google Analytics tracking [19:21:50] You have access to data.action both inside of the functions added by first/last and outside of them [19:22:20] really? I threw a debugger statement there and arguments was empty [19:22:26] Generally in get...Process() functions you should be doing everything on the inside, with few exceptions [19:22:47] Was that while you were still overriding close? [19:23:18] nah [19:23:32] I mean we have getTeardownProcess = function ( data ) { all over the place [19:24:18] Oooh but also data = data || {}; [19:24:26] Because I guess when you close using the safe action, data = undefined [19:24:59] BladeBronson: So we now have this concept of closing with a safe action. It's the default for closing when there's no explicit action passed in. So data.action might not be set, or data might be undefined altogether [19:25:17] It looks like we also rigged up the X to that instead of to data.action='close' [19:27:49] okay then our snapshot of code is in between when getTeardownProcess was introduced and when the safe action was introduced [19:27:51] check this out: [19:28:00] ve.ui.WikiaPreferenceDialog.prototype.getTeardownProcess = function ( data ) { [19:28:00] debugger; // data is an object with action = 'cancel'. I could do tracking here before returning [19:28:00] return ve.ui.WikiaPreferenceDialog.super.prototype.getTeardownProcess.call( this, data ) [19:28:01] .first( function () { [19:28:03] debugger; // function has no arguments [19:28:33] I don't have access to data inside of .first [19:28:59] Yes you do [19:29:10] Try console.log(data); inside the .first function [19:30:15] ReferenceError: data is not defined [19:30:40] what the [19:31:17] testing to see if it's chrome dev tools... [19:31:52] I mean what you're showing me here is the JavaScript equivalent of water catching on fire [19:32:01] haha [19:32:07] okay, it's a problem with chrome dev tools only [19:32:15] So forgive me if I'm like "no, you MUST be doing something wrong" [19:32:30] "Are you sure that's not gasoline?" :D [19:32:36] when pausing with debugger; the reference error occurs [19:33:17] (03PS1) 10Esanders: Replace boolean checks of getSlugAtOffset with hasSlugAtOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161328 [19:34:02] (03PS1) 10Catrope: Followup ec785c2: re-evaluate clipping state after positioning [oojs/ui] - 10https://gerrit.wikimedia.org/r/161329 [19:34:47] TrevorParscal: This TextMenuInputWidget thing is a gift that keeps on giving :| please review https://gerrit.wikimedia.org/r/161329 [19:34:56] ryasmeen: That ---^^ fixes the empty link inspector dropdown [19:34:57] okay, so i'm all set until our next update when the X button no longer sets action = 'cancel' [19:35:17] actually by then, we're probably going to redo the UI of dialogs to match whatever else we're doing [19:36:35] Right [19:36:56] Well generally we've moved to a pattern where data.action can be missing, or data can be undefined altogether, and that should behave like data.action='cancel' [19:37:06] That's the whole "safe action" thing [19:53:06] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000#c15 (10Rummana Yasmeen) Verified the fix in production [19:53:36] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000 (10Rummana Yasmeen) 5RESO/?>3VERI [19:55:36] (03PS1) 10Esanders: Remove 'new' keyword where not used [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161337 [19:56:21] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438#c20 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [19:57:29] Krinkle: You missed https://gerrit.wikimedia.org/r/#/c/160266/. [19:58:07] 3VisualEditor / 3Editing Tools: VisualEditor: Undoing the edit from toolbar does not disable the "Apply Changes" button inside Media Settings dialog - 10https://bugzilla.wikimedia.org/68058#c7 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [20:00:59] What's the best place to report strange diffs? [20:01:08] danmichaelo: Here's pretty good. [20:01:13] (03PS1) 10Mooeypoo: [WIP] Transform the search widget into masonry fit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 [20:01:28] Great! Just came across this one: https://no.wikipedia.org/w/index.php?title=Samantha_Skogrand&diff=prev&oldid=13406329&diffonly=1 [20:01:51] 3VisualEditor / 3Editing Tools: VisualEditor [Regression wmf20] Template dialog no longer displays added template fields' names - 10https://bugzilla.wikimedia.org/70406#c10 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [20:02:13] The strange part is that a category was replaced by a MediaWiki-message :) [20:02:32] danmichaelo: Yeah, that's a really bad bug we found with Firefox that we did an emergency fix for yesterday. [20:02:51] danmichaelo: But unfortunately it may have corrupted a few pages. :-( [20:02:54] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Transform the search widget into masonry fit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (owner: 10Mooeypoo) [20:03:00] Krinkle, what do I edit in my experimental fix so that "new Masonry()" will not get grunt upset that "Masonry doesn't exist" ? I've added the library to VisualEditor.php modules, the library itself loads, just grunt complains. [20:03:14] thanks, great to know it has been tracked down! [20:03:21] danmichaelo: Sorry for the disruption. :-( [20:03:36] no worries! [20:04:52] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] Link inspector is taking a long time on opening up on the first attempt of an edit session - 10https://bugzilla.wikimedia.org/70467#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [20:08:35] 3VisualEditor / 3Editing Tools: Disable "Re-use" button under Cite tools when there's nothing to re-use - 10https://bugzilla.wikimedia.org/70640#c4 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [20:11:25] mooeypoo: What complains? jshint? If it's jshint, use /*global Masonry*/ [20:11:44] RoanKattouw, ah! thank you [20:12:21] There's a config file where we add very common globals like ve and OO , but Masonry is probably just used in one file [20:12:36] ok, so Masonry library doesn't work (I'm having some problems figuring out which container to give it, but working on that) -- but the initial work is trying to do some light magic with image resize/representation without cropping http://imgur.com/a/Uethj [20:13:50] I'm resizing the wrappers of smaller images so they're centered. It's a lot easier to see them like that, too, they're not hidden by their titles anymore. But it's not yet ready to be called masonry fit just yet. [20:14:22] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf20] Edit notice displays at half-width - 10https://bugzilla.wikimedia.org/70565#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [20:15:51] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf21] Checking "Border" in media settings dialog is not enabling "Apply changes" button - 10https://bugzilla.wikimedia.org/70575#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [20:16:26] (03PS1) 10Esanders: Remove test for functionality tested in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161346 [20:16:52] 3VisualEditor / 3Editing Tools: VisualEditor: ”Use an Existing Reference“ button should be inactive if there are no references to add (the internal list is empty) - 10https://bugzilla.wikimedia.org/70611#c8 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [20:20:51] (03CR) 10Catrope: [C: 04-1] Emit 'position' and 'contextChange' events correctly (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160034 (owner: 10Esanders) [20:22:40] >> 100 - 2.3 [20:22:41] Krinkle: (number) 97.7 [20:22:46] >> 100 - 97.7 [20:22:46] Krinkle: (number) 2.299999999999997 [20:22:59] >> 100 - 2.3 - 97.7 [20:22:59] James_F: (number) 0 [20:23:08] >> 100 - 97.7 - 2.3 [20:23:08] James_F: (number) -2.6645352591003757e-15 [20:23:15] wut. [20:23:23] 0.1 + 0.2 !== 0.3 [20:23:24] Yay non-deterministic pipelines. [20:23:25] >> 0.1 + 0.2 !== 0.3 [20:23:25] Krinkle: (boolean) true [20:23:28] >> 0.1 + 0.2 [20:23:28] Krinkle: (number) 0.30000000000000004 [20:23:35] >>> 100 - 97.7 [20:23:35] RoanKattouw: (number) 2.299999999999997 [20:23:42] >>> (100 - 97.7).toFixed(1) [20:23:42] RoanKattouw: (string) '2.3' [20:23:48] >> 999999999999999 [20:23:49] Krinkle: (number) 999999999999999 [20:23:49] >> 9999999999999999 [20:23:50] Krinkle: (number) 10000000000000000 [20:23:50] (03PS6) 10Esanders: Rename inlineRects to startAndEndRects everywhere [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160495 [20:23:52] (03PS14) 10Esanders: Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 [20:23:54] (03PS5) 10Esanders: Remove getSelection*Client* methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160579 [20:23:56] (03PS13) 10Esanders: Refactor out finding of CE focusedNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159949 [20:23:58] (03PS9) 10Esanders: Emit 'position' and 'contextChange' events correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160034 [20:24:00] (03PS5) 10Esanders: Provide a method to get all the rectangles for a given selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160591 [20:24:02] (03PS3) 10Esanders: Work around Chrome's Range.getClientRects bug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161017 [20:24:04] (03PS15) 10Esanders: Allow specification of range when getting selection rectangles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160073 [20:24:06] (03PS8) 10Esanders: Add getNativeRange method with optional DM range argument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160303 [20:25:32] >>> s = '97.7'; i = s.indexOf('.'); digits = s.length - i - 1; [20:25:32] RoanKattouw: (number) 1 [20:25:51] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf20] Toolbar in mobile got squished in Betalabs and test2 both in desktop and iOS Safari - 10https://bugzilla.wikimedia.org/70430#c4 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [20:26:11] >> s = '97.123'; s.slice(s.indexOf('.')).length [20:26:11] Krinkle: (number) 4 [20:26:16] >> s = '97.123'; s.slice(s.indexOf('.') + 1).length [20:26:16] Krinkle: (number) 3 [20:39:06] 3MediaWiki extensions / 3Cite: Invalid HTML markup standalone LI element when using references on main page - 10https://bugzilla.wikimedia.org/71023#c1 (10Jon) Actually this appears to be a problem with the Cite extension. The same problem happens on desktop. Output is: