[00:00:44] (03PS2) 10Catrope: Update VE core submodule to master (d6904b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160885 (owner: 10Esanders) [00:00:53] (03Abandoned) 10Catrope: Update VE core submodule to master (d6904b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161391 (owner: 10Catrope) [00:01:46] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (d6904b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160885 (owner: 10Esanders) [00:04:00] (03PS3) 10Catrope: Update VE core submodule to master (d6904b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160885 (owner: 10Esanders) [00:04:22] (03CR) 10Catrope: [C: 032] Provide a method to get all the rectangles for a given selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160591 (owner: 10Esanders) [00:10:20] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (d6904b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160885 (owner: 10Esanders) [00:11:55] (03Merged) 10jenkins-bot: Update VE core submodule to master (d6904b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/160885 (owner: 10Esanders) [00:11:57] (03CR) 10Catrope: [C: 032] Work around Chrome's Range.getClientRects bug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161017 (owner: 10Esanders) [00:14:41] (03CR) 10Catrope: [C: 032] "Merging but please read inline comment" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160303 (owner: 10Esanders) [00:14:52] t0ryzal, hey [00:15:06] can someone help me with a visual editor install? [00:15:11] Maybe I can [00:15:19] (from #mediawiki, in case anyone was wondering) [00:15:40] yes please [00:15:44] thanks [00:15:56] i've been trying to follow the instructions [00:16:06] and am currently checking if parsoid works properly [00:16:09] http://www.mediawiki.org/wiki/Parsoid/Troubleshooting [00:16:21] the "curl https://localhost:8000/localhost/" [00:16:31] doesn't seem to work properly [00:16:37] or im doing something wrong [00:16:43] what is supposed to be replaced with? [00:16:54] is it supposed to be something like "index.php" or "api.php"? [00:16:58] because that's what im trying. [00:17:05] No, something like Main_Page [00:17:10] The name of an existing page on your wiki. [00:17:11] (03Merged) 10jenkins-bot: Add getNativeRange method with optional DM range argument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160303 (owner: 10Esanders) [00:17:13] (03Merged) 10jenkins-bot: Separate computation of highlights from rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160065 (owner: 10Esanders) [00:17:15] (03Merged) 10jenkins-bot: Remove getSelection*Client* methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160579 (owner: 10Esanders) [00:17:17] (03Merged) 10jenkins-bot: Rename inlineRects to startAndEndRects everywhere [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160495 (owner: 10Esanders) [00:17:19] (03Merged) 10jenkins-bot: Allow specification of range when getting selection rectangles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160073 (owner: 10Esanders) [00:17:21] (03Merged) 10jenkins-bot: Provide a method to get all the rectangles for a given selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160591 (owner: 10Esanders) [00:17:23] (03Merged) 10jenkins-bot: Work around Chrome's Range.getClientRects bug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161017 (owner: 10Esanders) [00:17:38] ok [00:17:45] so it's not returning anything [00:17:51] Okay. [00:17:54] Do you have Parsoid running? [00:18:29] i just did a "sudo service parsoid restart" [00:18:31] and ran it again [00:18:35] it seems to be running [00:19:40] if i do a curl http://localhost:8142, it returns some html [00:20:10] with a welcome message [00:30:09] t0ryzal: you might want to check and possibly tweak /etc/mediawiki/parsoid/settings.js [00:30:32] to make sure that you have configured your API end point correctly [00:31:19] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/160266/ [00:31:43] (03CR) 10Catrope: [C: 032] Replace boolean checks of getSlugAtOffset with hasSlugAtOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161328 (owner: 10Esanders) [00:32:03] (03CR) 10Catrope: [C: 032] README: Add devDependencies badge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160266 (owner: 10Jforrester) [00:32:13] gwicke: Is there a way to confirm whether or not my settings are correct? I can access the API endpoint properly from a web browser. [00:32:22] (03PS10) 10Jforrester: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [00:32:27] (03PS11) 10Jforrester: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [00:32:33] (03PS13) 10Jforrester: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [00:33:24] (03Merged) 10jenkins-bot: Replace boolean checks of getSlugAtOffset with hasSlugAtOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161328 (owner: 10Esanders) [00:33:33] (03Merged) 10jenkins-bot: README: Add devDependencies badge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/160266 (owner: 10Jforrester) [00:34:27] t0ryzal: https://www.mediawiki.org/wiki/Parsoid/Troubleshooting [00:34:46] the first heading there [00:36:14] Oh. Yes, that's working. Just checked again [00:36:53] The second curl statement is not returning anything though, when I substitute with Main_Page [00:37:10] and the appropriate port [00:38:35] (03PS1) 10Jforrester: Update VE core submodule to master (90bb24f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161403 [00:39:56] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (90bb24f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161403 (owner: 10Jforrester) [00:40:06] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (90bb24f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161403 (owner: 10Jforrester) [00:49:52] (03PS2) 10Catrope: Update VE core submodule to master (90bb24f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161403 (owner: 10Jforrester) [00:58:05] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (90bb24f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161403 (owner: 10Jforrester) [00:58:20] (03Abandoned) 10Jforrester: Add native range classes to documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161089 (owner: 10Catrope) [00:59:23] 3VisualEditor / 3Editing Tools: VisualEditor: Add a shortcut for strikethrough (?which?) - 10https://bugzilla.wikimedia.org/60257#c7 (10James Forrester) 5REOP>3RESO/FIX Re-fixed. [00:59:38] (03Merged) 10jenkins-bot: Update VE core submodule to master (90bb24f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161403 (owner: 10Jforrester) [01:20:59] (03CR) 10Catrope: [C: 04-1] Data model implementation for tables (039 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [01:21:54] All I can say right now is that VE isn't working. Is there a way I can get more information about what's not working or what's failing? [01:24:29] I think my parsoid service is running and was confirmed with the help of gwicke. Any advice for me? I've read through the wiki quite a few times and checked my steps many times [01:26:49] t0ryzal, isn't working... [01:26:59] Do you get an edit tab on each wiki page? [01:27:06] (a ve one) [01:27:24] So far I'm just checking on the Main Page [01:27:25] and yes [01:27:28] there's an Edit tab [01:27:41] but that leads to a text editor [01:27:54] or text edit field. [01:27:55] right, is there a VE one though? [01:28:18] Well, that's the only Edit tab I see. [01:28:25] Is there supposed to be another one specifically for VE? [01:28:42] yes [01:28:52] you should also be able to trigger VE by adding ?veaction=edit to the URL [01:30:29] Hm, yeah that doesn't seem to be working. [01:59:25] I'll take another crack at this tomorrow. Thanks for all the help. [02:32:44] (03PS11) 10Jforrester: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [02:34:10] (03CR) 10Jforrester: Data model implementation for tables (039 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [09:17:46] (03PS11) 10Bartosz Dziewoński: [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [09:18:11] (03CR) 10Bartosz Dziewoński: "Fixed merge conflict (with csscomb change)." [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [09:18:48] (03CR) 10jenkins-bot: [V: 04-1] [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [10:42:13] (03PS1) 10Bartosz Dziewoński: Improve generating SVG and PNG LESS distribution variants [oojs/ui] - 10https://gerrit.wikimedia.org/r/161443 [10:43:10] (03CR) 10jenkins-bot: [V: 04-1] Improve generating SVG and PNG LESS distribution variants [oojs/ui] - 10https://gerrit.wikimedia.org/r/161443 (owner: 10Bartosz Dziewoński) [10:43:17] (03CR) 10Bartosz Dziewoński: "Trevor, is your theme work nearing completion, or should I rebase on master?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/161443 (owner: 10Bartosz Dziewoński) [11:31:27] (03PS2) 10Bartosz Dziewoński: Improve generating SVG and PNG LESS distribution variants [oojs/ui] - 10https://gerrit.wikimedia.org/r/161443 [11:33:28] (03CR) 10jenkins-bot: [V: 04-1] Improve generating SVG and PNG LESS distribution variants [oojs/ui] - 10https://gerrit.wikimedia.org/r/161443 (owner: 10Bartosz Dziewoński) [15:09:49] Hey, my favourite team [15:09:51] https://www.dropbox.com/s/zjye5z3d9tmhtlj/Screenshot%202014-09-19%2010.58.08.png?dl=0 [15:10:02] Is there a way to force a menu to open a different direction? [15:10:22] I can also just add a z-index to this particular menu, but it would be more better if I didn't have to [15:33:26] hello there [15:33:33] the qunit job for VE is broken :-( [15:33:44] https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/11564/consoleFull [15:33:56] I have updated it to clone mediawiki/vendor and it fails :/ [15:35:38] I did the same tweak to all the other qunit jobs and they pass :-: [15:35:49] so I am assuming it is an issue in VE somewhere [16:20:04] James_F was wondering about my question, so for his benefit and RoanKattouw_away's, I'm wondering if I can configure an InlineMenuWidget to open up instead of down - we have a menu that is currently being partially blocked by our metadata panel. I'd prefer to change the direction instead of add a z-index to the menu div. [16:21:15] marktraceur: Hmm. I can't remember how we did it. [16:21:19] * James_F looks at the documentation. [16:21:45] Neat [16:21:49] Thanks for helping :) [16:23:09] Hmmmmmmm. [16:23:17] So… db1b656 added this code for ClippableElement. [16:23:26] But InlineMenuWidget doesn't mix that in. [16:23:31] * James_F tries to remember why. [16:24:06] Also, I think it was only automatic. [16:24:24] Hm [16:24:31] Trevor was talking about letting you configure the attachment point with a set of 12 options. [16:24:40] But I don't think we did that (yet?). [16:37:00] Well, I'll wait for the people to get in [16:37:11] Maybe a feature request is the push y'all need :) [17:12:36] Hangouts seems to lose connection mid-call every day now :( [17:18:28] hangouts are the worst. [17:30:14] marktraceur: So when you first asked for InlineMenuWidget, Trevor wrote some code to make it adaptively open to the bottom or top, but that code was hilariously broken and he abandoned it [17:30:30] Ha ha ha broken. [17:30:34] Hilarious [17:30:56] RoanKattouw: Maybe we could revive it in a config option? Or if y'all are busy I could just man up and use z-index [17:31:04] Also I guess ClippableElement didn't clip the menu there because the bar at the bottom is absolutely positioned? [17:31:43] If either the menu or one of its ancestors had a higher z-index, it would be above rather than below that bar [17:32:36] Also if the bottom bar has a fixed height, you can set bottom: on the big container above it so they don't overlap, and then ClippableElement should work I think [17:32:58] RoanKattouw: The bar at the bottom is absolutely positioned *and* has a higher z-index [17:33:03] Right [17:34:45] Wait, image-wrapper and post-image are deliberately styled to overlap? [17:35:17] Oh I see what's going on, this is clever [17:36:10] image-wrapper is position: fixed; bottom: 82px; , and post-image is position: absolutely; top: 607px; [17:36:30] and they end up not overlapping, clever [17:36:52] marktraceur: I think ClippableElement may be able to help you out here, let me play with something [17:37:30] Indeed :) [17:37:42] K, thanks [17:38:50] Dammit, actually no it won't [17:39:00] If you scroll down the page, image-wrapper and post-image overlap [17:39:43] which is a really clever effect that I haven't seen before, but it totally destroys my plan [17:39:51] Because now I can't clip the menu against image-wrapper [17:40:22] marktraceur: You realize post-image can in fact overlay almost the entire download popup if you scroll down far enough? [17:40:27] So maybe that popup needs a z-index [17:40:41] It's intentional actually [17:40:55] RoanKattouw: We don't want the popups accessible when the panel is open [17:40:58] ryasmeen, what did we decide about https://bugzilla.wikimedia.org/show_bug.cgi?id=70886 again? [17:41:00] was that invalid? [17:41:00] We're pretty much axing the panel later anyway [17:41:05] OK [17:41:15] Once you've axed it, I probably have better solutions for you [17:41:39] But right now, you have a problem because, while I can't open the popups when the panel is open, I can open a popup first then scroll to open the panel [17:42:12] And if you z-indexed the menu to be visible on top of the panel, what happens if you scroll down very far? The panel is obscured and there's a decapitated menu floating somewhere? [17:43:14] Hmm, although in your screenshot it looks like the menu is being obscured even when the panel is "closed". I can't reproduce that, but I do have a solution for that problem [17:43:30] OK [17:44:02] Wait, in your screenshot the download pane pops out to the left of the icon, but for me it's to the top [17:44:12] That's probably why [17:44:15] RoanKattouw: Yeah, this is after a few patches [17:44:23] Let me give you the patch link [17:44:25] I'm on Ia92545ed1ef7f2e4ba7934c682eef684a22ca17f [17:44:42] ("Make the download pane into its own dialog") [17:45:05] RoanKattouw: https://gerrit.wikimedia.org/r/161348 [17:45:15] Last follow-up patch in the series, I think [17:45:44] OK from the title that's obviously the commit I was missing :D [17:45:49] *nod* :) [17:45:56] Krenair: yes it is.Marking it as such. [17:46:38] The clipping still isn't as strong for me but it's there now [17:46:58] Oh that's because there's a "default" option that I don't have [17:48:05] ...which is because I was being stupid with localhost vs 127.0.0.1 (so the image was a cross-domain request). I see it now [17:50:06] RoanKattouw: We could also probably force-close the menu widget when the user opens the panel, if that solves that usability issue [17:50:16] Or I could bother pginer to see what he thinks would suck the least [17:52:05] RoanKattouw: Krinkle said Monday or Tuesday works for him...do you have a preference? [17:52:30] legoktm: Either is fine [17:54:23] 3VisualEditor / 3Data Model: VisualEditor: In the Re-use reference dialog, search is not returning correct results on the second initialization for a specific case - 10https://bugzilla.wikimedia.org/70886#c13 (10Rummana Yasmeen) 5NEW>3RESO/INV The reason it is showing the other citations awhen you search... [17:56:33] (03PS12) 10Jforrester: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [17:56:35] (03PS12) 10Jforrester: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [17:56:37] (03PS13) 10Jforrester: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [17:56:39] (03PS14) 10Jforrester: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [17:57:09] (03CR) 10Jforrester: "PS12 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [17:57:17] (03CR) 10Jforrester: "PS12 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [17:57:26] (03CR) 10Jforrester: "PS14 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [17:57:37] (03CR) 10Jforrester: "PS13 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [17:58:05] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [17:58:11] marktraceur: Simple quick fix that makes the behavior a bit better: .mw-mmv-image-wrapper { overflow-y: auto; } [17:58:37] This makes image-wrapper scrollable, which in itself doesn't do anything because of the way it and its contents are laid out [17:59:06] But InlineMenuWidget (and most other OOUI widgets, through the ClippableElement mixin) respect the boundaries of the nearest scrollable container [17:59:50] Right now the menu's closest scrollable container is the body, but by setting that CSS rule it will become the image wrapper, and the menu will truncate itself and make itself scrollable to avoid running over the edge [18:02:47] Ah, K [18:03:09] RoanKattouw: You think that will work if the overflow isn't because the menu is too small, but because an overlay makes it not visible? [18:03:23] At least I think that's what happens. [18:03:24] I'll try it [18:07:35] OK, that's pretty neat [18:07:40] Thanks RoanKattouw :) [18:08:37] 3VisualEditor / 3Editing Tools: VisualEditor: Add a shortcut for strikethrough (?which?) - 10https://bugzilla.wikimedia.org/60257#c8 (10Rummana Yasmeen) Verified the fix in Betalabs and test2 [18:10:44] marktraceur: No in that case it won't work. If you pull up the overlay it'll still get clipped [18:11:43] s/clipped/obscured [18:12:07] The menu will clip to the bottom of image-wrapper, and in the initial state image-wrapper ends where the bottom panel begins [18:12:32] Yeah, I see what you mean now [18:12:34] But if you pull up the bottom panel (or scroll down), the bottom panel will obscure image-wrapper including the download pane and the menu and everything [18:12:35] Works like a charm :) [18:12:52] Which is not ideal I think but I think it's probably the most consistent behavior that can be provided [18:16:21] Krinkle: helllo :) [18:16:36] hashar: I sent an e-mail 5 seconds ago [18:16:58] Krinkle: i have migrated qunit jobs to use zuul cloner earlier today [18:17:08] I know, James told me, jobs are broken [18:17:21] lib/ve git submodule is missing. [18:17:23] grrr [18:17:52] that is so obvious [18:18:56] Krinkle: I am reverting the VE job till i find a good way to handle the submodule [18:19:45] |log Jenkins: reverting job mwext-VisualEditor-qunit to previous state (i.e. without Zuul cloner) [18:20:35] ok :) [18:23:05] Krinkle: it is back up https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/11566/console sorry [18:23:15] calling it an end and closing laptop now [18:23:29] on monday I will document what I did this weekend [18:23:34] and expose that suvbmodule issue [18:24:54] See you hashar. :-) [18:25:13] :-] [18:41:45] (03PS12) 10Trevor Parscal: [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 [18:41:48] (03CR) 10jenkins-bot: [V: 04-1] [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [18:45:02] TrevorParscal: btw, you seen https://gerrit.wikimedia.org/r/#/c/161443/ ? it kills vector.less and raster.less [18:45:37] nice [18:45:41] I will look after the meeting today [18:45:46] and fold it in [18:45:53] I'm working on rebasing the theme commit onto master [18:49:09] aye [19:00:10] (03PS13) 10Trevor Parscal: [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 [19:01:17] (03CR) 10jenkins-bot: [V: 04-1] [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [19:37:32] Hey, I'm seeing some odd behavior with a paste from MS Word. Any idea why VE is interpreting some spaces as a ↵ character? [19:44:35] (03PS1) 10Alex Monk: Make InputWidget mixin FlaggedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/161516 (https://bugzilla.wikimedia.org/70957) [19:56:38] 3VisualEditor / 3Editing Tools: VisualEditor: Applying link to the caption of an image does not enable "Apply Changes" button - 10https://bugzilla.wikimedia.org/71065 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Insert an image with caption 3.Reope... [20:02:21] 3MediaWiki extensions / 3TemplateData: TemplateData: add tooltip/quick link to TD help page near new TD editor button - 10https://bugzilla.wikimedia.org/67621#c4 (10Elitre) 5RESO/FIX>3REOP James, if the link can't point to the local help page for each wiki, please redirect it to https://www.mediawiki.org... [20:08:40] 3VisualEditor / 3ContentEditable: Paste into VE from word converting spaces to line breaks. - 10https://bugzilla.wikimedia.org/71067 (10ryan.glasnapp) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16522 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16522&action=edit original Word sour... [20:11:21] James_F, RoanKattouw_away: For https://bugzilla.wikimedia.org/show_bug.cgi?id=70957 I'm wondering if we should always style those textarea:required:invalid elements in some way [20:11:44] instead of only after the user has attempted to submit [20:11:47] (03PS13) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [20:11:49] (03PS14) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [20:11:51] (03PS15) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [20:13:32] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [20:18:59] Krenair: Ooh I didn't know :invalid existed, that's awesome [20:19:38] Krenair: The only thing I'm worried about is that I don't want it to yell at you for it being initially empty. It should only do that if you take some sort of deliberate action to leave it empty [20:24:06] Yeah. [20:24:24] I'm thinking just add a 'blurredOnce' flag or something. [20:26:04] Well I wonder if that isn't how :invalid already behaves in browsers? [20:26:43] it does [20:26:51] http://jsfiddle.net/tbERP/ [20:27:09] but, we don't want to use the HTML stuff without a shim [20:28:30] what we need is to use setFlag( 'invalid' ) [20:30:03] TrevorParscal: That goes invalid immediately when you select it. [20:30:08] TrevorParscal: Which is uncool. [20:30:17] no, it should set the flag when you leave the field [20:30:28] Indeed, I agree that it should. [20:30:41] so, you could abstract the required concept [20:30:48] and in the future we could use HTML5 [20:31:25] and we could solve this in TextInputWidget to the point where we just say { required: true } in construction or toggleRequired( true ) after [20:32:16] and the default implementation would call this.isValid on blur and set an invalid flag if so [20:32:25] and when invliad, remove the flag on change [20:32:48] probably run isValid on change always really [20:33:02] and, then you could override isValid in subclasses to do different things [20:33:28] maybe build in a way to define what is valid with a configurable regex or symbolic name that uses a canned regexp [20:33:35] Shall I spec this out? [20:34:54] Krenair: ^^^ Would that be helpful? [20:36:01] oh my TrevorParscal is on IRC [20:36:03] TrevorParscal, RequiredElement? :) [20:36:15] TrevorParscal: I thought you decided to leave IRC altogether to be able to focus ™ [20:36:23] hm [20:36:42] Krenair: I don't know where else we would use this other than text inputs [20:36:43] ?? [20:37:08] RoanKattouw: https://meta.wikimedia.org/wiki/Community_Engagement_(Product)?veaction=edit [20:37:30] TrevorParscal, probably only inputs. [20:38:41] http://etherpad.wikimedia.org/p/TextInputWidgetValidation [20:39:16] I think you could make other types of inputs, e.g. radio buttons or something, required? [20:39:44] radio I could see [20:39:50] we don't have that yet anyway [20:39:56] yeah [20:40:04] Krenair: And checkboxes. [20:40:04] let's cross that bridge when we come to it yeah? [20:40:13] Krenair: "I agree to the following terms and conditions". [20:40:14] how do you make a checkbox required? [20:40:17] ah [20:40:28] well... is that really "required" in the same sense? [20:40:38] It's a standard Web pattern (anti-pattern?). [20:40:56] I think it would have a significantly different implementation though [20:42:29] for this case, yeah. Let's do it in TextInputWidget [20:43:04] ok, Roan has agreed with the contents of the Etherpad [20:43:16] so, if you go that direction, we will be in good shape [20:53:30] mooeypoo: I was going to say in the standup, but looks like y'all forgot about me :P [20:53:39] mooeypoo: I didn't get to review autofill yesterday, but I'm doing it now [20:54:14] (03PS8) 10Krinkle: Implement new 'autovalue' parameter property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [21:02:27] (03PS2) 10Alex Monk: TextInputWidget: Determine validity on blur and change. [oojs/ui] - 10https://gerrit.wikimedia.org/r/161516 (https://bugzilla.wikimedia.org/70957) [21:02:32] Krinkle, oh, I arrived late to the hangout, I thought you already spoke :p but awesome, let me know if it works. If it does and it gets merged, we can see about doing something in the VE-side [21:03:07] TrevorParscal, RoanKattouw_away: Something like that, but with isValid returning a promise? [21:19:37] 3MediaWiki / 3Page editing: Revert bug 27860 or add configuration variable to restore "Mark all edits minor by default" preference behaviour - 10https://bugzilla.wikimedia.org/42008#c8 (10Bawolff (Brian Wolff)) Do people still strongly care about this issue/Want me to fix it (by fix I mean add a global to co... [21:21:44] (03PS3) 10Bartosz Dziewoński: Improve generating SVG and PNG LESS distribution variants [oojs/ui] - 10https://gerrit.wikimedia.org/r/161443 [21:22:59] (03CR) 10jenkins-bot: [V: 04-1] Improve generating SVG and PNG LESS distribution variants [oojs/ui] - 10https://gerrit.wikimedia.org/r/161443 (owner: 10Bartosz Dziewoński) [21:24:39] 3MediaWiki / 3Page editing: Revert bug 27860 or add configuration variable to restore "Mark all edits minor by default" preference behaviour - 10https://bugzilla.wikimedia.org/42008#c9 (10Nemo) Dunno what qualifies for "strongly care" but I still think this was very wrong and would love to have the checkboxe... [21:39:55] Krenair: yes, a promise [21:40:13] so, you can you know... like validate it with the server [21:40:15] if needed [21:40:17] yep [21:40:28] even if we don't need it today [21:40:30] we will soon [21:42:59] TrevorParscal, there seems to be some problem using this on the template dialog [21:43:20] The flag is set on blur and updated properly on change [21:43:32] yet, it seems to be applying as the dialog opens.. [21:44:17] does it go through and focus each textarea while opening, or something? [21:49:06] 3MediaWiki / 3Page editing: Revert bug 27860 or add configuration variable to restore "Mark all edits minor by default" preference behaviour - 10https://bugzilla.wikimedia.org/42008#c10 (10Laurence 'GreenReaper' Parry) Yes, what Nemo said. I have a patch for this against 1.23 at: http://pool.wikifur.com/Ed... [22:02:51] (03PS14) 10Trevor Parscal: [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 [22:03:10] (03Abandoned) 10Trevor Parscal: Improve generating SVG and PNG LESS distribution variants [oojs/ui] - 10https://gerrit.wikimedia.org/r/161443 (owner: 10Bartosz Dziewoński) [22:09:53] (03PS15) 10Trevor Parscal: [WIP|BREAKING CHANGE] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 [22:10:11] (03PS3) 10Alex Monk: TextInputWidget: Determine validity on blur and change. [oojs/ui] - 10https://gerrit.wikimedia.org/r/161516 (https://bugzilla.wikimedia.org/70957) [22:10:35] (03PS16) 10Trevor Parscal: [WIP|BREAKING CHANGE] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 [22:14:29] (03PS17) 10Trevor Parscal: [BREAKING CHANGE] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 [22:14:53] (03PS1) 10Alex Monk: Style required but currently-invalid parameters on the template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161613 (https://bugzilla.wikimedia.org/70957) [22:16:18] TrevorParscal, and "Can be a symbolic name that references a statically defined RegExp object, such as "integer" for /^\d+$/"... [22:19:35] What are you expecting for that, other than "integer"? is this some standard thing? [22:21:54] (03PS2) 10Alex Monk: Style required but currently-invalid parameters on the template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161613 (https://bugzilla.wikimedia.org/70957) [22:23:17] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [22:25:59] well, we could probably have "non-empty" [22:26:19] which is like /.+/ or something [22:26:26] they should just be things that are useful [22:26:33] doesn't have to be an exhaustive list [22:26:41] RoanKattouw: thoughts? [22:26:50] Hmm [22:26:52] Maybe [22:27:10] I'm not sure that now is the greatest time to speculatively build a library of regexes that we think will be common in the future [22:27:31] i'm thinking non-empty is the one we want [22:27:33] to start with [22:27:37] number could be fine too [22:27:41] but don't add a ton of them [22:27:47] just the ones we think we have a use case for [22:27:55] 3OOjs UI: OOjs UI: [Regression wmf18] In VE, on the first attempt to invoke , the confirmation dialogs for switching to Read mode and Edit Source mode are appearing with a scroll bar and button placements are also not next to each other - 10https://bugzilla.wikimedia.org/70061#c1 (10James Forrester) 5ASSI>3... [22:28:56] Ok. I'll consider that 'integer' and 'non-empty' for now. TrevorParscal, any string which isn't one of those will be interpreted as a regexp? [22:29:07] 3OOjs UI: OOjs UI: [Regression wmf18] In VE, on the first attempt to invoke , the confirmation dialogs for switching to Read mode and Edit Source mode are appearing with a scroll bar and button placements are also not next to each other - 10https://bugzilla.wikimedia.org/70061#c2 (10Roan Kattouw) It may no lon... [22:29:46] you can just do instanceof RegExp [22:30:08] otherwise look for it as a key in this.constructor.static.validationPatterns [22:30:15] otherwise just ignore it [22:30:20] and assume non-empty? [22:30:35] no, the default should be no validation [22:30:59] invalid validation config should mean no validation, or an error, probably the former - Timo? [22:31:03] Krenair: ^^ [22:31:23] So isValid always resolves true if it's a non-special string? [22:32:17] yes [22:41:21] 3OOjs UI: OOjs UI: [Regression wmf18] In VE, on the first attempt to invoke , the confirmation dialogs for switching to Read mode and Edit Source mode are appearing with a scroll bar and button placements are also not next to each other - 10https://bugzilla.wikimedia.org/70061#c3 (10James Forrester) 5RESO/FIX... [22:41:37] 3OOjs UI: OOjs UI: [Regression wmf18] In VE, on the first attempt to invoke , the confirmation dialogs for switching to Read mode and Edit Source mode are appearing with a scroll bar and button placements are also not next to each other - 10https://bugzilla.wikimedia.org/70061 (10James Forrester) 5REOP>3ASSI [22:42:25] (03PS4) 10Alex Monk: TextInputWidget: Determine validity on blur and change. [oojs/ui] - 10https://gerrit.wikimedia.org/r/161516 (https://bugzilla.wikimedia.org/70957) [22:42:27] TrevorParscal, okay, how about that? ^ [22:43:59] (03PS14) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [22:44:01] (03PS15) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [22:44:03] (03PS16) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [22:45:55] (03CR) 10Krinkle: [C: 04-1] ""4 new parameters were imported." should not be an error message but a success message (.successbox)" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [22:46:33] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [22:47:49] (03PS9) 10Krinkle: Implement new 'autovalue' parameter property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [22:49:39] 3VisualEditor / 3Mobile: VisualEditor Mobile: For the first time in each edit session in Nexus 7(Android 4.4.2), Link Inspector gets auto-zoomed in, which looks like partial rendering of the UI - 10https://bugzilla.wikimedia.org/66759 (10James Forrester) a:5Juliusz Gonera>3None [22:49:39] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor appears over the toolbar in iPad Mini and Nexus 7 for Mobile VE - 10https://bugzilla.wikimedia.org/65325 (10James Forrester) a:5Juliusz Gonera>3None [22:49:40] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10James Forrester) a:5Juliusz Gonera>3None [22:53:10] (03CR) 10Krinkle: "Hm.. That's new in this commit. I'll file bugs." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [22:55:24] 3MediaWiki extensions / 3TemplateData: TemplateData: Import parameters message should rendere as "success" not "error" - 10https://bugzilla.wikimedia.org/71077 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Created attachment 16524 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16524&action=edi... [22:55:53] 3MediaWiki extensions / 3TemplateData: TemplateData: Import parameters message should rendere as "success" not "error" - 10https://bugzilla.wikimedia.org/71077 (10Krinkle) [22:55:53] 3MediaWiki extensions / 3TemplateData: TemplateData: GUI editor (tracking) - 10https://bugzilla.wikimedia.org/65544 (10Krinkle) [22:57:37] (03CR) 10Alex Monk: [C: 04-1] "Why does this style them immediately? It should be waiting for the user to manually blur the textarea..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161613 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [22:57:53] 3MediaWiki extensions / 3TemplateData: TemplateData: GUI editor (tracking) - 10https://bugzilla.wikimedia.org/65544 (10Krinkle) [22:57:54] 3MediaWiki extensions / 3TemplateData: TemplateData: "Required" and "Suggested" label should not wrap - 10https://bugzilla.wikimedia.org/71078 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Created attachment 16525 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16525&action=edit Screenshot of b... [23:00:24] (03CR) 10Krinkle: Implement new 'autovalue' parameter property (033 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [23:02:26] MatmaRex: Quick ping. [23:02:38] Ah, never mind, will work around it. [23:02:53] yeah? [23:03:06] Trying to find a way to add you to the dashboard that doesn't break gerrit. :-) [23:03:20] Observe: https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/VisualEditor,dashboards/custom:custom [23:03:50] Now looks like it works, I think? [23:04:24] yeah. it took a while and i was just going to say it's broken, but then it loaded [23:04:45] Lots of people == lots of queries == slow gerrit. [23:04:56] But that's always a good place to look for things to do code review on. :-) [23:05:00] yeah [23:05:02] this is magical. [23:05:09] dude. never seen that before [23:05:12] Really? [23:05:22] i think you showed me some dashboards, but they didn't look this big :D [23:05:29] I swore I sent an e-mail to wikitech-l about how to make your own. [23:05:39] Yeah, well, Editing team is a bit over-heavy with work. :-) [23:05:46] Most teams have a much saner dashboard. [23:09:21] MatmaRex: If there are extensions we should look at, feel free to lob them into the dashboard (or ask me to). [23:11:36] (03Abandoned) 10Bartosz Dziewoński: ProcessDialog: Don't center the title label if there's not enough space [oojs/ui] - 10https://gerrit.wikimedia.org/r/160812 (https://bugzilla.wikimedia.org/68571) (owner: 10Bartosz Dziewoński) [23:12:23] 3OOjs UI: OOjs UI: Auto-shortening of dialog titles when there's insufficient space isn't working - 10https://bugzilla.wikimedia.org/68571#c8 (10Bartosz Dziewoński) 5PATC>3RESO/FIX a:5Bartosz Dziewoński>3None As fixed as it's going to get. [23:12:54] night. [23:17:41] Krenair: lookin [23:23:38] 3MediaWiki extensions / 3TemplateData: TemplateData: "Required" and "Suggested" label should not wrap in the GUI editor - 10https://bugzilla.wikimedia.org/71078 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Moriel Schottlender [23:24:15] Oh right, I can't just use Function.prototype.bind in OOUI can I? [23:24:24] 3MediaWiki extensions / 3TemplateData: TemplateData: Import parameters message should rendere as "success" not "error" in the GUI editor - 10https://bugzilla.wikimedia.org/71077 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3minor a:3Moriel Schottlender [23:25:02] Krenair: No, use OO.ui.bind [23:25:15] We try to support browsers that don't have native bind, kind of, at least in OOUI [23:25:19] In VE we don't give a crap [23:26:18] I should probably move the blur handler into its own function [23:30:29] (03CR) 10Krinkle: [C: 04-1] Implement new 'autovalue' parameter property (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [23:30:39] (03PS10) 10Krinkle: Implement new 'autovalue' parameter property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [23:30:50] (03CR) 10Krinkle: [C: 031] "Please confirm." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [23:31:00] mooeypoo: Let me know what you think. [23:31:15] (03CR) 10Trevor Parscal: [C: 04-1] TextInputWidget: Determine validity on blur and change. (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/161516 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [23:31:34] I am a little confused [23:34:37] (03PS2) 10Trevor Parscal: [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 [23:35:07] Krinkle, okay, I see, you fixed the comments. It looks good, except for the comment you made about the error/success message (which I will fix in a new unrelated commit) [23:35:10] mooeypoo: You changed the default value from "" to null, but the comparison was still against "" [23:35:27] and the unit tests passed even due to it not comparing very well [23:35:29] Yeah, I saw it now. I changed one but not the otherr [23:35:38] I filed a bug for errorbox [23:35:44] oh great [23:35:57] wikibugs: MediaWiki extensions / TemplateData: TemplateData: Import parameters message should rendere as "success" not "error" - https://bugzilla.wikimedia.org/71077 (Krinkle) NEW p:Unprio s:normal a:None Created attachment 16524 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16524&action=edi... [23:35:58] wikibugs: MediaWiki extensions / TemplateData: TemplateData: "Required" and "Suggested" label should not wrap - https://bugzilla.wikimedia.org/71078 (Krinkle) NEW p:Unprio s:normal a:None Created attachment 16525 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16525&action=edit Screenshot of b... [23:36:07] * mooeypoo nods [23:36:08] awesomesauce [23:36:52] (03PS11) 10Krinkle: Implement new 'autovalue' parameter property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [23:36:57] (03CR) 10Krinkle: [C: 032] "Fixed typo becuause -> because" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [23:37:12] (03CR) 10Krinkle: [C: 032] Implement new 'autovalue' parameter property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [23:37:18] woot [23:37:21] and also, whoops. [23:37:40] (03Merged) 10jenkins-bot: Implement new 'autovalue' parameter property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/157820 (https://bugzilla.wikimedia.org/51428) (owner: 10Mooeypoo) [23:37:51] I really need spellcheck in the terminal and in sublime [23:41:42] (03PS18) 10Jforrester: [BREAKING CHANGE] Create a MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [23:41:44] that was my typo actually ;-) [23:41:53] TrevorParscal: ^^^ Please sanity-check my changes. [23:46:17] >>> 'asd'.match( undefined ); [23:46:17] Krenair: (object) [''] [23:46:31] TrevorParscal, ^ [23:46:53] >>> 'asd'.match(null) [23:46:53] RoanKattouw: (object) null [23:47:25] Krenair: ^ [23:47:26] undefined -> 'undefined' -> /undefined/ [23:47:33] LOL [23:47:35] (03CR) 10Trevor Parscal: [C: 031] [BREAKING CHANGE] Create a MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [23:47:44] Thanks JavaScript [23:48:32] RoanKattouw, yep. [23:49:22] And I don't think it matters to my code. validationRegexp should be either an instance of RegExp or undefined... [23:49:33] I am still shocked about yesterday's math revelation. [23:51:25] Oh 44+1+44 = 88 ? [23:51:35] Someone on the Firefox bugzilla actually explained this to me [23:52:27] JavaScript is very philosophical. [23:52:33] it's like the whole 2+2=5 [23:52:48] and then 0.2+0.3 business. [23:53:13] It's pretty terrible for math-based javascript stuff :\ [23:53:29] It actually is like 2+2 = 5 much more than you think [23:54:19] It is..? [23:56:14] So the measurements I'm taking are rounded [23:56:36] The real height of those things is like 43.6 pixels [23:57:12] Actually it's 43.516 :) [23:57:26] So the parent height ends up being 43.516 + 1 + 43.516 = 88.03 [23:57:50] (03CR) 10Trevor Parscal: [C: 032] Documentation: ActionWidget is non-framed by default [oojs/ui] - 10https://gerrit.wikimedia.org/r/160198 (owner: 10Rillke) [23:58:43] (03Merged) 10jenkins-bot: Documentation: ActionWidget is non-framed by default [oojs/ui] - 10https://gerrit.wikimedia.org/r/160198 (owner: 10Rillke)