[01:39:00] <grrrit-wm>	 (03PS1) 10Jforrester: update-oojs-ui.sh: Exclude the minimised distribution files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161885 
[02:31:39] <grrrit-wm>	 (03PS19) 10Krinkle: [BREAKING CHANGE] Create a MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal)
[02:45:22] <grrrit-wm>	 (03PS8) 10Jforrester: build: Create minified JS and CSS distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 
[02:45:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] build: Create minified JS and CSS distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 (owner: 10Jforrester)
[02:46:23] <grrrit-wm>	 (03PS9) 10Jforrester: build: Create minified JS and CSS distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 
[02:46:25] <grrrit-wm>	 (03PS20) 10Jforrester: [BREAKING CHANGE] Create a MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal)
[02:46:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] build: Create minified JS and CSS distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 (owner: 10Jforrester)
[02:47:10] <grrrit-wm>	 (03PS21) 10Jforrester: [BREAKING CHANGE] Create a MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal)
[10:58:37] <wikibugs>	 3MediaWiki / 3ResourceLoader: Errors in one module can affect other modules via $.ready - 10https://bugzilla.wikimedia.org/70772 (10Andre Klapper) p:5Unprio>3High
[11:06:22] <wikibugs>	 3MediaWiki / 3Page editing: Add syntax highlighting to Edit box - 10https://bugzilla.wikimedia.org/11627#c4 (10Pavel (pastakhov)) I am developing the CodeMirror extension [1] that highlights the wiki markup in <textarea>. It is not ready for real usage yet, but you can already see how it work [2] and help me...
[13:18:37] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Edit summary box should be a text input box and not textarea - 10https://bugzilla.wikimedia.org/52133#c10 (10Spinningspark) (In reply to Amir E. Aharoni from comment #9) > Is it possible to meet in the middle: To show it as a textarea, but to allow > savi...
[13:28:09] <wikibugs>	 3VisualEditor: не работает - 10https://bugzilla.wikimedia.org/71119 (10d_iar) 3UNCO p:3Unprio s:3normal a:3None win 8.1  сенсорный .вообще нереально написать нажимая backspace  чтоб стереть  ошибочно написанное страницу подбрасывает вверх. и на этом точка. дальше работать соответ�
[13:34:14] <MatmaRex>	 um… who here knows russian? :P that looks like a serious report, but i don't speak the language well enough to translate
[13:34:33] <MatmaRex>	 i can tell you that the summary means "doesn't work" :D
[13:35:37] <marktraceur>	 MaxSem, I guess.
[13:35:50] <marktraceur>	 Or yurik maybe
[13:45:21] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Edit summary box should be a text input box and not textarea - 10https://bugzilla.wikimedia.org/52133#c11 (10Spinningspark) (In reply to Spinningspark from comment #10)  However, the input box should be large enough to accomodate the maximum permitted len...
[14:20:37] <wikibugs>	 3OOjs UI: OOjs UI: Dialogs resize horizontally but stay at full height when browser window is enlarged - 10https://bugzilla.wikimedia.org/68213 (10Bartosz Dziewoński)
[14:25:54] <wikibugs>	 3OOjs UI: OOjs UI: Dialogs resize horizontally but stay at full height when browser window is enlarged - 10https://bugzilla.wikimedia.org/68213#c1 (10Bartosz Dziewoński) 5ASSI>3RESO/FIX a:5Trevor Parscal>3None I can no longer reproduce this, neither in OOjs UI demo nor in standalone VE demo.
[14:30:07] <wikibugs>	 3VisualEditor: Backspace issue on Windows 8.1 - 10https://bugzilla.wikimedia.org/71119#c1 (10Andre Klapper) Thanks for taking the time to report this!  Am I correct that this is about Windows 8.1 phone? Could you provide exact steps to reproduce (step by step) in English what exactly is broken with backspace,...
[14:36:09] <wikibugs>	 3OOjs UI: OOjs UI: Buttons and button-like things should be keyboard-accessible - 10https://bugzilla.wikimedia.org/62337#c12 (10Bartosz Dziewoński) 5ASSI>3RESO/FIX I think we should close this and open separate bugs for any remaining issues. It seems that the buttons in question (comment 4 and comment 10)...
[14:37:52] <wikibugs>	 3OOjs UI: OOjs UI: Issues with button placement and sizing on first open - 10https://bugzilla.wikimedia.org/70061 (10Bartosz Dziewoński)
[14:45:36] <wikibugs>	 3OOjs UI: OOjs UI: Dialog emits "closing" event 250ms after close() is invoked - 10https://bugzilla.wikimedia.org/64775#c1 (10Bartosz Dziewoński) 5ASSI>3RESO/FIX This seems to have been fixed, perhaps in the great and terrible dialog refactor (3ba36b9a53aa41da07c3b56a063fe0d3c419c2a5). It has definitely be...
[14:46:16] <MatmaRex>	 ha, andre speaks russian. :D
[14:51:01] <wikibugs>	 3OOjs UI: OOjs UI: A 'small' dialog doesn't fit a field label and a input field - 10https://bugzilla.wikimedia.org/67354#c3 (10Bartosz Dziewoński) p:5Normal>3Lowest Ed's comment sounds like a WONTFIX to me.
[15:10:17] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: .topicon icons are taking editors to linked pages, rather than letting them edit the template, in MonoBook on English Wikipedia - 10https://bugzilla.wikimedia.org/70074#c3 (10Bartosz Dziewoński) Caused by "z-index: 10;" in [[w:en:MediaWiki:Monobook.css]].
[15:16:47] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: .topicon icons are taking editors to linked pages, rather than letting them edit the template, in MonoBook on English Wikipedia - 10https://bugzilla.wikimedia.org/70074#c4 (10Bartosz Dziewoński) a:5Ed Sanders>3Bartosz Dziewoński While this could possibly be...
[15:28:39] <edsanders>	 MatmaRex, see my comments on ^^^
[15:29:18] <MatmaRex>	 edsanders: wow, okay
[15:29:24] <MatmaRex>	 but i just fixed the bug in VE
[15:29:30] <edsanders>	 that's ok too
[15:29:48] <edsanders>	 but need a sensible way of editing them
[15:29:57] <MatmaRex>	 of course
[15:29:59] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Prevent page elements from displaying on top of highlights [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161957 (https://bugzilla.wikimedia.org/70074) 
[15:30:05] <MatmaRex>	 i'm sure there's a bug for that filed in 2005, somewhere
[15:30:21] <edsanders>	 well we're the editing team so we can fix that now
[15:30:34] <MatmaRex>	 ha-ha
[15:30:55] <MatmaRex>	 edsanders: https://bugzilla.wikimedia.org/show_bug.cgi?id=23796
[15:30:57] <edsanders>	 I was thinking either gallery syntax <indicators>Image.png|Star \n Foo.svg|Lock</indicators>
[15:31:16] <MatmaRex>	 filed in only 2010, actually.
[15:31:20] <MatmaRex>	 46 commens
[15:31:42] <MatmaRex>	 edsanders: oh, and there's a VE bug too. https://bugzilla.wikimedia.org/show_bug.cgi?id=51420 :)
[15:34:02] <edsanders>	 yeah Trevor was saying he got half way through then it got nuked because he wasn't using pageprops
[15:34:16] <edsanders>	 seem like something you'd like to take on?
[15:34:50] <MatmaRex>	 hmm
[15:34:59] <MatmaRex>	 perhaps
[15:37:49] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: .topicon icons are taking editors to linked pages, rather than letting them edit the template, in MonoBook on English Wikipedia - 10https://bugzilla.wikimedia.org/70074#c7 (10Bartosz Dziewoński) Ed, that's bug 23796, with the related bug 51420 in VE.
[15:37:49] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Issues with shields/highlights/phantoms (tracking) - 10https://bugzilla.wikimedia.org/66083 (10Bartosz Dziewoński)
[15:39:00] <edsanders>	 you could start with https://www.mediawiki.org/wiki/Special:Code/MediaWiki/73498#c9500
[15:42:14] <edsanders>	 what are your reservations?
[15:49:53] <grrrit-wm>	 (03CR) 10Esanders: "1. This probably deserves an inline comment" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161957 (https://bugzilla.wikimedia.org/70074) (owner: 10Bartosz Dziewoński)
[16:26:07] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "1. Done." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161957 (https://bugzilla.wikimedia.org/70074) (owner: 10Bartosz Dziewoński)
[16:26:26] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Prevent page elements from displaying on top of highlights [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161957 (https://bugzilla.wikimedia.org/70074) 
[16:27:57] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Prevent page elements from displaying on top of highlights [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161957 (https://bugzilla.wikimedia.org/70074) 
[16:30:32] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: Prevent page elements from displaying on top of highlights [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161957 (https://bugzilla.wikimedia.org/70074) 
[16:44:05] <grrrit-wm>	 (03CR) 10Alex Monk: Try to stop user from tabbing outside of open dialog box (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/159902 (https://bugzilla.wikimedia.org/67156) (owner: 10Alex Monk)
[16:50:35] <grrrit-wm>	 (03PS1) 10Esanders: Add expand method to ranges, finish unit test coverage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161977 
[16:50:37] <grrrit-wm>	 (03PS1) 10Esanders: Make newFromTranslatedRange a method (translate) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161978 
[16:53:41] <grrrit-wm>	 (03PS13) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[16:53:43] <grrrit-wm>	 (03PS15) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[16:53:45] <grrrit-wm>	 (03PS16) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb)
[16:53:47] <grrrit-wm>	 (03PS17) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[16:53:49] <grrrit-wm>	 (03PS1) 10Esanders: CE fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161979 
[16:54:42] <grrrit-wm>	 (03Abandoned) 10Esanders: CE fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161979 (owner: 10Esanders)
[16:54:47] <grrrit-wm>	 (03PS16) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[16:54:49] <grrrit-wm>	 (03PS17) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb)
[16:54:51] <grrrit-wm>	 (03PS18) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[16:59:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb)
[17:44:22] <grrrit-wm>	 (03Abandoned) 10Catrope: [WIP] Hide resize handles on headings in IE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142842 (owner: 10Catrope)
[17:44:28] <grrrit-wm>	 (03Abandoned) 10Catrope: [WIP] Fix highlights on references in IE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143807 (owner: 10Catrope)
[17:56:54] <wikibugs>	 3MediaWiki / 3Page editing: Provide a way to set page meta-data flags ("featured article", "protected", etc.), configure which ones are available for a wiki,  and display icons indicating these statuses - 10https://bugzilla.wikimedia.org/23796#c50 (10Nemo) (In reply to James Forrester from comment #49) > Tha...
[18:02:23] <wikibugs>	 3MediaWiki / 3Page editing: Provide a way to set page meta-data flags ("featured article", "protected", etc.), configure which ones are available for a wiki,  and display icons indicating these statuses - 10https://bugzilla.wikimedia.org/23796 (10Bartosz Dziewoński)
[18:03:24] <wikibugs>	 3MediaWiki / 3Page editing: Provide a way to set page meta-data flags ("featured article", "protected", etc.), configure which ones are available for a wiki,  and display icons indicating these statuses - 10https://bugzilla.wikimedia.org/23796#c51 (10Bartosz Dziewoński) 5NEW>3ASSI a:3Bartosz Dziewoński...
[18:13:50] <Krenair>	 RoanKattouw, any idea what happened to https://gerrit.wikimedia.org/r/#/c/144171/ ?
[18:14:58] <RoanKattouw>	 What the ...
[18:15:10] <RoanKattouw>	 I canceled Timo's +2 so I could fix the typo in the commit message
[18:15:14] <RoanKattouw>	 I didn't touch it otherwise
[18:15:31] <RoanKattouw>	 Also it succeeded first, then failed on the same code?
[18:16:09] <RoanKattouw>	 17:55:13 1) UIDGeneratorTest::testTimestampedUID with data set #0 ('newTimestampedUID128', 39, 128, 46, 48)
[18:16:10] <RoanKattouw>	 17:55:13 unlink(/var/lib/jenkins-slave/tmpfs/mediawiki-vendor-integration/mw-UIDGenerator-UID-nodeid): No such file or directory
[18:16:12] <RoanKattouw>	 ....
[18:16:52] <RoanKattouw>	 I've re-+2ed it (and legoktm said recheck as well), maybe there's one broken slave in the pool or something
[18:18:53] <wikibugs>	 3VisualEditor: VisualEditor: Some comments are not displayed - 10https://bugzilla.wikimedia.org/71085#c1 (10Roan Kattouw) The reason for this is that we're currently very conservative about which comments we deem to be "safe" to display, because there are some "unsafe" ones, like comments placed between two ta...
[18:19:37] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf21] Editor is displayed with two toolbars on second initialisation - 10https://bugzilla.wikimedia.org/70768#c11 (10Rummana Yasmeen) I cannot reproduce it following your steps.In steps 4, you mentioned to repeat step 2, what change have you...
[18:27:44] <RoanKattouw>	 Krenair: https://gerrit.wikimedia.org/r/#/c/144171/ merged this time
[18:31:04] <Krenair>	 thanks
[18:33:42] <RoanKattouw>	 MatmaRex: Have you looked at the ArticleEmblems extension?
[18:34:27] <RoanKattouw>	 Trevor wrote it in 2010, then Tim critiqued it, Chad deleted it in 2011, and Max revived it in 2012 and addressed Tim's comments
[18:34:46] <RoanKattouw>	 It doesn't seem to have been imported into git though
[18:35:11] <RoanKattouw>	 https://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/ArticleEmblems/?view=log
[18:35:50] <MatmaRex>	 never heard of it
[18:35:59] <RoanKattouw>	 [15:34:02] <edsanders>	 yeah Trevor was saying he got half way through then it got nuked because he wasn't using pageprops
[18:36:09] <RoanKattouw>	 ArticleEmblems is what Ed was referring to there
[18:36:44] <MatmaRex>	 it seems rather limited
[18:37:00] <MatmaRex>	 and not configurable by skins
[18:37:47] <MatmaRex>	 "emblems", huh. i'm going to have a really hard time solving the naming problem.
[18:38:31] <MatmaRex>	 (emblems, indicators, icons, badges)
[18:39:15] <edsanders>	 I wouldn't assume that's the best name
[18:42:29] <James_F>	 I like Emblems.
[18:42:35] <James_F>	 Badges is the term used in Wikidata, though.
[18:42:40] <RoanKattouw>	 Yeah obviously I'm not saying 4-year-old code is the definitive answer to this problem
[18:42:42] <James_F>	 Maybe we should try to be slightly consistent. :-)
[18:42:53] <RoanKattouw>	 Just bringing it to your attention in case some of it turns out to be salvageable
[18:43:33] <MatmaRex>	 yep
[18:43:52] <MatmaRex>	 there's also chad's patch on the bug
[18:44:09] <MatmaRex>	 i'll probably read these and rewrite
[18:44:46] <MatmaRex>	 also. i wonder how many use cases this should try to support. featured article icons, locked article icons, that's obvious; what about coordinates?
[18:45:58] <James_F>	 Yeah, co-ordinates and map-triggers would be good.
[18:46:12] <James_F>	 Also maybe "find this book in a library" as an alternative there
[18:46:20] <MatmaRex>	 we're going to need a… bigger name to support these. ;)
[18:46:33] <James_F>	 (Article subject action vs. article status vs. article meta-status.)
[18:46:39] <MatmaRex>	 ArticleStuffs
[18:47:27] * James_F worries. :-)
[19:00:53] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Comments in "unsafe" content locations are not displayed - 10https://bugzilla.wikimedia.org/71085 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3minor
[19:04:37] <grrrit-wm>	 (03PS1) 10Alex Monk: Use mw.Title#getRelativeText to deal with titles relative to specific namespaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162015 
[19:05:56] <James_F>	 Krenair: https://gerrit.wikimedia.org/r/162016 – let's not make > 1.24 dependencies if we don't have to. :-)
[19:06:32] <James_F>	 Krenair: 1.24wmf22 < 1.24 < 1.25wmf1 so yay.
[19:06:58] <Krenair>	 It looked like there was controversy over the 1.24 release branch stuff, so I left it alone.
[19:07:04] <James_F>	 Meh.
[19:08:02] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "I'd really rather we didn't add a 1.25 dependency this early in the cycle if we can avoid it." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162015 (owner: 10Alex Monk)
[19:11:48] <grrrit-wm>	 (03PS2) 10Alex Monk: Use mw.Title#getRelativeText to deal with titles relative to specific namespaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162015 
[19:15:55] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it - 10https://bugzilla.wikimedia.org/71131 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce:  1.Open a page with VE 2.Go to Insert>...
[19:16:50] <James_F>	 edsanders: ^^^ Did you break formulæ again?
[19:30:37] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Insert > References list is very large in Firefox - 10https://bugzilla.wikimedia.org/70545#c2 (10Bartosz Dziewoński) 5ASSI>3UNCO Can't reproduce using Firefox 32 on Windows 7, nor any other browser. Is this still happening for you? I think it was fixed along...
[19:32:22] <wikibugs>	 3MediaWiki / 3Page editing: Provide a way to set page meta-data flags ("featured article", "protected", etc.), configure which ones are available for a wiki,  and display icons indicating these statuses - 10https://bugzilla.wikimedia.org/23796 (10Bartosz Dziewoński)
[19:44:39] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Insert > References list is very large in Firefox - 10https://bugzilla.wikimedia.org/70545 (10Bartosz Dziewoński)
[19:44:39] <wikibugs>	 3VisualEditor: Switch to source editing dialog too tall - 10https://bugzilla.wikimedia.org/70317#c1 (10Bartosz Dziewoński) This might be the same issue as bug 70545 and looks similarly fixed to be, but I don't have a Mac to test on.
[19:47:06] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580#c1 (10Bartosz Dziewoński) 5ASSI>3RESO/FIX I just tried this on beta.wmflabs and it seems to work correctly there.
[19:47:51] <wikibugs>	 3OOjs UI: OOjs UI: Selecting an item from the dropdown in link annotation inspector does something weird with the focus of the input on an iPad - 10https://bugzilla.wikimedia.org/64575 (10Bartosz Dziewoński)
[19:48:17] <MatmaRex>	 darn, i'd be good at QA.
[20:13:10] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre wmf1] Increasing indentation to a bullet/numbered list is also adding a new bullet every time - 10https://bugzilla.wikimedia.org/71134 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16537   --> https://bugzilla.wiki...
[20:13:55] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre wmf1] Increasing indentation to a bullet/numbered list is also adding a new bullet/numbered point every time - 10https://bugzilla.wikimedia.org/71134 (10Rummana Yasmeen)
[20:20:09] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Insert > References list is very large in Firefox - 10https://bugzilla.wikimedia.org/70545#c3 (10James Forrester) 5UNCO>3RESO/FIX a:3Roan Kattouw Yeah, part of Roan's fixes.
[20:20:28] <James_F>	 MatmaRex: If you do all the QA ryasmeen won't have the time to shout at you for your code… ;-)
[20:21:46] <ryasmeen>	 :D
[20:23:08] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Switch to source editing dialog too tall - 10https://bugzilla.wikimedia.org/70317#c2 (10James Forrester) Yeah, checked on a Mac.
[20:24:23] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it - 10https://bugzilla.wikimedia.org/71131 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major a:3Bartosz Dziewoński
[20:24:24] <James_F>	 MatmaRex: Could you look at ^^^ if you have a moment? Probably "simple" (ha!).
[20:25:38] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: [Regression pre wmf1] Increasing indentation to a bullet/numbered list is also adding a slug with a new bullet/numbered point each time - 10https://bugzilla.wikimedia.org/71134#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Ed Sanders Due to the ch...
[20:28:52] <MatmaRex>	 sure
[20:28:54] <TrevorParscal>	 ok, done with doctors and lunch
[20:29:11] <TrevorParscal>	 how's everyone doing?
[20:31:25] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Switch to source editing dialog too tall - 10https://bugzilla.wikimedia.org/70317 (10Bartosz Dziewoński) 5UNCO>3RESO/FIX
[20:41:59] <RoanKattouw>	 TrevorParscal: Timo, Kunal and I had lunch with Jan Paul
[20:42:08] <RoanKattouw>	 I'm about to bang my head against the wall with puppet again
[20:42:12] <RoanKattouw>	 Maybe do some code review as procrastination
[20:42:22] <James_F>	 RoanKattouw: :-P
[20:46:30] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf 22]Selection does not work while trying to select multiples lines after dragging the selection horizontally over a focusable node - 10https://bugzilla.wikimedia.org/71139 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reprod...
[20:49:01] <James_F>	 ryasmeen: https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/VisualEditor,dashboards/merged:merged
[20:49:52] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Switch to source editing dialog too tall - 10https://bugzilla.wikimedia.org/70317 (10James Forrester) p:5Unprio>3Normal
[20:51:54] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf 22]Selection does not work while trying to select multiples lines after dragging the selection horizontally over a focusable node - 10https://bugzilla.wikimedia.org/71139 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Ed Sanders
[20:52:13] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf 22] Selection does not work while trying to select multiples lines after dragging the selection horizontally over a focusable node - 10https://bugzilla.wikimedia.org/71139 (10James Forrester)
[20:53:37] <grrrit-wm>	 (03PS1) 10Esanders: SurfaceObserver should observe the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162125 
[20:54:33] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] "lol" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162125 (owner: 10Esanders)
[20:55:32] <edsanders>	 RoanKattouw, the range stuff should be pretty trivial to review too
[20:56:20] <RoanKattouw>	 Yeah that stuff is on my review list for today
[20:58:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: SurfaceObserver should observe the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162125 (owner: 10Esanders)
[21:10:52] <James_F>	 RoanKattouw: What is the "gem" branch of VE-MW and is it still needed? https://git.wikimedia.org/log/mediawiki%2Fextensions%2FVisualEditor/refs%2Fheads%2Fgem
[21:11:54] <edsanders>	 RoanKattouw, so in FF it looks like the only way to disable the native drawing of table selections is to use -moz-user-select: none
[21:12:08] <edsanders>	 but that actually disables selection and all events
[21:13:28] <James_F>	 RoanKattouw: Also, can sandbox/catrope/iefixes go?
[21:15:16] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (bab8befc94) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162136 
[21:16:23] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it - 10https://bugzilla.wikimedia.org/71131#c1 (10Bartosz Dziewoński) It only closes when you're inserting a new formula. Editing existing ones doesn't have this p...
[21:21:22] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it - 10https://bugzilla.wikimedia.org/71131#c2 (10James Forrester) Focus issue?
[21:28:24] <RoanKattouw>	 edsanders: Is there not some other magical value of -moz-user-select that we can use? Because user-select has like 6 different valuesd
[21:29:06] <RoanKattouw>	 edsanders: Also can we possibly do trickery with ::selection { background: transparent; }  or something?
[21:31:16] <edsanders>	 ::selection doesn't work
[21:31:23] <edsanders>	 I'm already doing transparent
[21:31:29] <edsanders>	 tried border, outline, color etc
[21:33:02] <RoanKattouw>	 Ugh
[21:33:12] <RoanKattouw>	 Is this the thing where ::selection works for text but not images?
[21:34:19] <edsanders>	 RoanKattouw, none | text | all | element
[21:34:32] <edsanders>	 none is none, text is default, all changes double click behaviour, and element is for IE
[21:34:48] <edsanders>	 ::selection never hides the table cell outlines
[21:34:52] <edsanders>	 probably
[21:35:00] <edsanders>	 it's unhideable
[21:35:13] <RoanKattouw>	 Starting with Firefox 21 none behaves like -moz-none, so selection can be re-enabled on sub-elements using -moz-user-select:text.
[21:35:29] <edsanders>	 hm
[21:35:33] <edsanders>	 so <p>?
[21:35:42] <RoanKattouw>	 I'm hoping that means that doing table { user-select: none; }    td { user-select: text; } will do something reasonable
[21:36:27] <edsanders>	 that might just work
[21:36:39] <edsanders>	 I think it might need to be below td
[21:36:41] <edsanders>	 but will check
[21:36:45] <edsanders>	 works with p
[21:36:47] <RoanKattouw>	 Yeah maybe td * { ... }
[21:36:58] <RoanKattouw>	 Or td > *
[21:37:13] <edsanders>	 yes
[21:37:20] <RoanKattouw>	 Anyway then you could presumably do ::selection { background-color: transparent; } to hide the remainder of the selection
[21:38:00] <edsanders>	 eugh
[21:38:05] <edsanders>	 I am doing
[21:38:08] <edsanders>	 td doesn't work
[21:38:15] <edsanders>	 and td>* is technically not correct
[21:38:17] <edsanders>	 wiat
[21:38:18] <edsanders>	 wait
[21:38:19] <edsanders>	 it is
[21:38:24] <edsanders>	 it just isnt
[21:38:26] <edsanders>	 working
[21:39:38] <edsanders>	 so td > p works, but td > * doesn't
[21:39:58] <RoanKattouw>	 WTF
[21:40:01] <RoanKattouw>	 What about td *
[21:41:13] <edsanders>	 I think that's on nested tables
[21:41:21] <edsanders>	 because td > * then applies to the child table
[21:42:11] <edsanders>	 it needs to be td > canContainContentNode
[21:46:29] <TrevorParscal>	 RoanKattouw: am I going to get review on https://gerrit.wikimedia.org/r/#/c/157866/ today?
[21:46:37] <RoanKattouw>	 Yes
[21:46:38] <TrevorParscal>	 I realize it's the commit from hell
[21:46:49] <TrevorParscal>	 I owe you lunch or something
[21:46:49] <RoanKattouw>	 Sorry I've had random other crap going on until now
[21:46:54] <TrevorParscal>	 no worries man
[21:46:58] <RoanKattouw>	 Dude you fed me nutella ice cream
[21:47:00] <RoanKattouw>	 It's fine
[21:47:05] <TrevorParscal>	 lol
[21:47:13] <TrevorParscal>	 James missed out man!
[21:48:28] <edsanders>	 :(
[21:49:23] <RoanKattouw>	 TrevorParscal: We'll have to figure out a way to dissolve the sugar and try again
[21:49:31] <TrevorParscal>	 oh yeah
[21:49:33] <RoanKattouw>	 Also my mom suggested getting the sugar from strawberries
[21:49:48] <TrevorParscal>	 well, I mean you can make a thick syrup with sugar and water
[21:49:54] <TrevorParscal>	 and heat it up a bit
[21:50:05] <TrevorParscal>	 I stuck to the recipe
[21:50:10] <RoanKattouw>	 Yeah
[21:50:12] <TrevorParscal>	 at my peril
[21:50:15] <RoanKattouw>	 Always stick to the recipe the first time
[21:50:28] <RoanKattouw>	 Then what went wrong is definitely the recipe's fault
[21:50:29] <TrevorParscal>	 I have the recipe in a google doc now and have already made modifications
[21:52:55] <edsanders>	 RoanKattouw, we don't have a class for canContainContentNode
[21:53:29] <RoanKattouw>	 .ve-ce-contentBranchNode ?
[21:53:36] <RoanKattouw>	 Or does ve.ce.ContentBranchNode not set that?
[21:56:44] <edsanders>	 no
[21:57:27] <RoanKattouw>	 Hmm OK
[21:57:28] <RoanKattouw>	 Well let's set that then
[21:57:43] <TrevorParscal>	 I'm going to use honey next time actually
[21:58:03] <James_F>	 TrevorParscal: Not golden syrup?
[21:58:11] <James_F>	 TrevorParscal: Be careful what kind of sugar you want to use.
[21:58:49] <TrevorParscal>	 well, I'm going to try it with honey, it's very thick and I think it will go well
[21:59:06] <TrevorParscal>	 some people actually use honey flavored yogurt instead of plain, they seem to think it's awesome
[21:59:23] <TrevorParscal>	 also, going to put all of it in the blender first
[22:00:47] <RoanKattouw>	 Nice
[22:03:03] <edsanders>	 RoanKattouw, added contentBranchNode and that does the trick
[22:04:02] <edsanders>	 need to sort out FF doing multi range selection
[22:05:01] <Krenair>	 RoanKattouw, I'm not sure what to do about non-isolated windows in https://gerrit.wikimedia.org/r/#/c/159902/1/src/Window.js
[22:08:58] <TrevorParscal>	 what do I do for "Expense type" when expensing lunch against Tomasz's budget...?
[22:09:03] <TrevorParscal>	 I hate paperwork
[22:09:18] <RoanKattouw>	 No idea
[22:09:22] <RoanKattouw>	 Ask Sarah
[22:09:25] <RoanKattouw>	 And when you find out, tell me
[22:09:59] <TrevorParscal>	 i'll be giving you my .ods file
[22:13:36] <TrevorParscal>	 James_F: you've filled out an expense report.. semi-recently?
[22:13:50] <TrevorParscal>	 is the "Expense type" column just mean "Department"?
[22:25:08] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it - 10https://bugzilla.wikimedia.org/71131#c3 (10Bartosz Dziewoński) After dm.Surface emits 'contextChange', ve.ui.Context#afterContextChange thinks that the insp...
[22:25:36] <MatmaRex>	 grumble
[22:25:57] <MatmaRex>	 i hate inspectors that close themselves. it's a second one that's beating me.
[22:47:42] <RoanKattouw>	 MatmaRex: You should talk to edsanders , he's been messing with that recently
[22:48:03] <RoanKattouw>	 He rewrote the way contextChange events get emitted last week, and he's been doing other selection-related and math inspector-related things in the recent past
[22:49:22] <MatmaRex>	 grumble grumble.
[22:51:02] <edsanders>	 we made some changes that causes the math inspector to close, but added a check to see if the node changed onContextChange, so that should stop it from closing
[22:51:26] <MatmaRex>	 it doesn't
[22:51:31] <MatmaRex>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=71131#c3
[22:51:38] <MatmaRex>	 After dm.Surface emits 'contextChange', ve.ui.Context#afterContextChange thinks that the inspector should be closed, because `selectedNode !== this.lastSelectedNode` (this.lastSelectedNode is null).
[22:52:05] <MatmaRex>	 i don't understand what's causing this.lastSelectedNode to be null, though
[23:00:08] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] When the inspector is still open for a selected node, after placing the cursor in a different position, inspector flickers there - 10https://bugzilla.wikimedia.org/71151 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created at...
[23:05:53] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it - 10https://bugzilla.wikimedia.org/71131#c4 (10Bartosz Dziewoński) (The cause is probably 49a239b4b68719dc59bacf79e5186aceca881c58.)
[23:15:39] <grrrit-wm>	 (03CR) 10Jackmcbarn: [C: 04-1] "This is the wrong approach, per the comments on the Parsoid change. Instead, just make the checkbox prepend "safesubst:" (not just "subst:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153934 (https://bugzilla.wikimedia.org/49904) (owner: 10Alex Monk)
[23:23:22] <grrrit-wm>	 (03PS22) 10Catrope: [BREAKING CHANGE] Create a MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal)
[23:26:18] <MatmaRex>	 edsanders: i'm giving up for now, i don't know anywhere near enough about how this stuff interacts. totally feel free to pick up that bug.
[23:26:54] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf 22] Inspector loses it UI after scrolling down the page and clicking somewhere else in the document - 10https://bugzilla.wikimedia.org/71153 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16542   --> https://bugzil...
[23:27:38] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf 22] Inspector loses it UI after scrolling down the page and clicking somewhere else in the document - 10https://bugzilla.wikimedia.org/71153#c1 (10Rummana Yasmeen) Created attachment 16543   --> https://bugzilla.wikimedia.org/attachment.cgi?id=165...
[23:28:03] <grrrit-wm>	 (03CR) 10Subramanya Sastry: "<subbu> jackmcbarn, this proposal doesn't change the problem that is there with the data-mw flag proposal ... the html that we receive can" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153934 (https://bugzilla.wikimedia.org/49904) (owner: 10Alex Monk)
[23:35:55] <Krenair>	 Is RoanKattouw around?
[23:36:45] <RoanKattouw>	 Yes
[23:36:51] <RoanKattouw>	 What's up?
[23:37:16] <RoanKattouw>	 TrevorParscal: I'm reviewing your code now, I'm going to save my comments soon due to the high rate of WTFs per minute from just reviewing Gruntfile.js
[23:38:20] <Krenair>	 RoanKattouw, so for https://gerrit.wikimedia.org/r/#/c/159902/1/src/Window.js - I don't think I've run into non-isolated windows before...?
[23:38:35] <RoanKattouw>	 We don't have them in VE right now, but OOUI supports them
[23:38:51] <RoanKattouw>	 You can see them in the dialogs demo, there's an option to isolate windows or not (off by default)
[23:38:55] <RoanKattouw>	 In a non-isolated window, there is no iframe
[23:39:35] <RoanKattouw>	 So, my real question is, which element were you hoping to get to through this.$iframe.contents()[0] ?
[23:40:09] <RoanKattouw>	 It feels to me like that shouldn't even work
[23:40:42] <Krenair>	 I think it was the document element of the iframe, or something
[23:41:04] <RoanKattouw>	 wtf
[23:41:06] <RoanKattouw>	 Really?
[23:41:07] <RoanKattouw>	 That WORSK?
[23:41:09] <RoanKattouw>	 *WORKS
[23:41:40] <RoanKattouw>	 Holy crap that actually gives you the document
[23:41:44] <RoanKattouw>	 Not even the documentElement but the document
[23:42:08] <RoanKattouw>	 That's some impressive special-casing on jQuery's part
[23:42:55] <RoanKattouw>	 Krenair: So, several things about that code
[23:43:16] <RoanKattouw>	 For the isolated case, I think all you have to check is that e.target isn't equal to the iframe, because the stuff inside the iframe is in a different document
[23:43:42] <RoanKattouw>	 Second of all, I don't think you need to filter on :focusable because non-:focusable elements won't receive focus events
[23:44:10] <Krenair>	 yeah, that bit about :focusable I was going to deal with in the next PS
[23:44:15] <RoanKattouw>	 Third, you need a capturing event handler there, otherwise bubbling will be used and the focus handler on the event itself will run before yours
[23:44:48] <RoanKattouw>	 (Do you know about the capture and bubble phases of DOM event emission?)
[23:45:11] <Krenair>	 No
[23:45:23] <RoanKattouw>	 So, when an event is fired, it propagates as follows
[23:45:41] <RoanKattouw>	 First, in the capture phase, it trickles down from the document via the ancestors to the element
[23:46:10] <RoanKattouw>	 This is called the capture phase because parents can set special event handlers that run in this phase and are able to prevent events from reaching their children (capture them)
[23:46:35] <RoanKattouw>	 Then when the event has trickled down to the element, it enters the bubble phase, and bubbles back up the tree to the root
[23:46:46] <RoanKattouw>	 By default, event handlers you attach will run in the bubble phase
[23:47:26] <RoanKattouw>	 Then when the event finishes bubbling all the way up to the root, the native action is taken by the browser
[23:47:42] <RoanKattouw>	 e.preventDefault() prevents the browser from taking the native action at the end
[23:48:40] <RoanKattouw>	 e.stopPropagation() stops the event from being propagated any further. If you call this from a capturing event handler, it prevents it from trickling down any further, and in a non-capturing handler it prevents it from bubbling up any further
[23:49:28] <RoanKattouw>	 e.stopImmediatePropagation() does what e.stopPropagation() does but also prevents any additional event handlers that may exist at the same level (i.e. attached to the same element with the same capturingness) from being called
[23:49:37] <RoanKattouw>	 </DOM explanation>
[23:50:28] <RoanKattouw>	 Then the way that jQuery's feature that you're using there is implemented is that $(document).on( 'focus', ':focusable' ) attaches an event handler to the document in the bubble phase (I think), then ignores the event if !$(e.target).is(':focusable')
[23:52:10] <RoanKattouw>	 So given that we quite frequently attach event handlers to 'focus', what I think you want to do is attach a capturing event handler to the document which calls both preventDefault and stopPropagation on events whose e.target is not inside of this.$element
[23:52:25] <Krenair>	 That sounds like it, yes.
[23:52:35] <RoanKattouw>	 then only attach that handler on open and detach it on close, as opposed to leaving it attached continuously and checking this.isOpened()
[23:52:59] <RoanKattouw>	 Checking whether something is inside this.$element also nicely covers both the isolated and non-isolated cases
[23:53:02] <RoanKattouw>	 And makes sense in general
[23:53:06] <RoanKattouw>	 In fact
[23:53:12] <RoanKattouw>	 Maybe we should do this in WindowManager instead
[23:53:19] <RoanKattouw>	 Because that's where the modal-ness property is set I think
[23:53:31] <Krenair>	 yes it is.
[23:53:40] <RoanKattouw>	 As is I'm pretty sure your code would break clicking out of the link inspector
[23:54:01] <RoanKattouw>	 Putting it in WindowManager also means we only have one copy of the handler per manager rather than one per window
[23:54:12] <Krenair>	 Actually, I wonder how it handles multiple windows being open.
[23:54:27] <RoanKattouw>	 Right now WM doesn't let you do that but we have ideas about changing that
[23:54:40] <RoanKattouw>	 Specifically to allow a MessageDialog to be open on top of a ProcessDialog
[23:54:51] <RoanKattouw>	 (Maybe we'll accomplish that with multiple WMs though --- I don't know)
[23:54:57] <Krenair>	 well, yeah, I had to use a hack to get around that somewhere else
[23:55:09] <Krenair>	 the thing is, will this now break that hack?
[23:55:16] <RoanKattouw>	 Oh I see
[23:55:33] <RoanKattouw>	 Oh, hmm and what about the language inspector
[23:55:44] <RoanKattouw>	 That creates a window manager that is then attached to the global overlay
[23:55:48] <RoanKattouw>	 And you'll get a focus transition
[23:56:16] <RoanKattouw>	 I already had to hack around IE getting confused by that focus transition; I think it's fine in other browsers but only because the windows are both isolated and focus events don't bubble through the iframe barrier (except in IE)
[23:56:19] <Krenair>	 I still wonder why browsers handle the tabbing differently to each other :/
[23:57:00] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Create a MediaWiki theme (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal)
[23:57:13] <RoanKattouw>	 TrevorP|Away: First set of comments ---^^ because your Gruntfile changes broke my brain
[23:57:27] <RoanKattouw>	 Will continue reviewing other files now
[23:58:05] <Krenair>	 RoanKattouw, of course, I could stick a hidden element at the end of the dialog, and move focus back to the start when its tabbed to