[00:04:46] Right [00:05:01] I mean that sounded hacky in the beginning but I now think it might not be that bad [00:05:09] Considering the problems with the alternative [00:06:46] yep :/ [00:10:37] RoanKattouw, I'm increasingly thinking of doing table selection manually [00:10:44] the user-select thing sort of works [00:11:07] but only if you start your drag on the paragraph, not the table cell padding [00:11:08] Anyway, thank you RoanKattouw. [00:11:14] edsanders: ... of course [00:11:26] which is about 50/50 on a small number table [00:11:34] edsanders: Yeah doing it manually sounds reasonable if the native selection is obtuse [00:12:20] and there's a whole bunch of crap converting the range to table cell nodes then a rectangle [00:12:51] Krenair: Well in any case you now know more than you ever wanted to know about event propagation :) [00:13:01] Haha, yep [00:22:58] (03CR) 10GWicke: [C: 04-1] "So far the assumption was that substitution and other PST features like signatures would happen purely in the client. Are there good reaso" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153934 (https://bugzilla.wikimedia.org/49904) (owner: 10Alex Monk) [00:23:54] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf 22] Inspector loses it UI after scrolling down the page and clicking somewhere else in the document - 10https://bugzilla.wikimedia.org/71153 (10Rummana Yasmeen) 5NEW>3ASSI a:3Roan Kattouw [00:36:55] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre wmf 1]The substitute template for the field Month and year does not return any value - 10https://bugzilla.wikimedia.org/71157 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16545 --> https://bugzilla.wikimedia.org... [00:41:19] (03CR) 10Jforrester: "> So far the assumption was that substitution and other PST features like signatures would happen purely in the client. Are there good rea" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153934 (https://bugzilla.wikimedia.org/49904) (owner: 10Alex Monk) [00:43:58] (03CR) 10Catrope: [BREAKING CHANGE] Create a MediaWiki theme (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [00:48:40] (03CR) 10GWicke: "@James: IMHO 'insert a signature' or 'insert templated content into the page' are very well within the realm of what editors can do. It do" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153934 (https://bugzilla.wikimedia.org/49904) (owner: 10Alex Monk) [00:49:28] How about we move the insert-signature button away from the toolbar and into the personal tools. then you can make up your mind on a page-by-page base [00:49:29] xD [00:53:15] Krinkle: ;) [01:26:32] (03CR) 10Subramanya Sastry: "gwicke: the problem is not so much about clients doing it, but how do they do it? straightforward html subst will not work because of nest" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153934 (https://bugzilla.wikimedia.org/49904) (owner: 10Alex Monk) [01:28:39] (03CR) 10GWicke: "Yes, there will need to be a way to push the encapsulation one level down when retrieving the HTML template expansion from Parsoid. A subs" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153934 (https://bugzilla.wikimedia.org/49904) (owner: 10Alex Monk) [02:55:08] (03CR) 10Catrope: [BREAKING CHANGE] Create a MediaWiki theme (0329 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [03:07:04] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (bab8befc94) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162136 (owner: 10Jforrester) [03:08:39] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (bab8befc94) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162136 (owner: 10Jforrester) [06:40:55] 3MediaWiki / 3Page editing: MediaWiki external link syntax parsing of URI schemes - 10https://bugzilla.wikimedia.org/71166 (10David Condrey) 3UNCO p:3Unprio s:3trivia a:3None MediaWiki external link syntax parsing does not appear to support the view-source [URI schemes][1] potentially others as well.... [11:08:03] Hi ! I am a PhD student working on product comparison matrices (e.g. https://en.wikipedia.org/wiki/Comparison_of_Nikon_DSLR_cameras). Wikipedia is our favorite case study and we would like to create an editor for such matrices. [11:09:01] I would like to know if the mediawiki / wikipedia community is interested in the creation of a dedicated visual editor for such tables. [13:36:10] 3VisualEditor / 3Editing Tools: Template editor does not load - 10https://bugzilla.wikimedia.org/71175 (10Robin Krahl) 3NEW p:3Unprio s:3normal a:3None Intention: I tried to insert a template using VisualEditor when editing or creating pages on dewiki. Steps to Reproduce: 1. Enable Visual Editor in... [13:39:09] 3VisualEditor / 3Editing Tools: Template editor does not load - 10https://bugzilla.wikimedia.org/71175#c1 (10Robin Krahl) Created attachment 16552 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16552&action=edit Screenshot of the stuck template pop-up with Firefox 32.0 on Kubuntu 14.04 [14:06:08] 3VisualEditor / 3Editing Tools: Template editor does not load - 10https://bugzilla.wikimedia.org/71175#c2 (10Elitre) I can't reproduce with the same browser but in Windows 8. Robin, can you please try to add a template in incognito mode to https://de.wikipedia.org/wiki/Benutzer:Elitre_(WMF)/sandbox?veaction=... [14:15:53] 3VisualEditor / 3Editing Tools: Template editor does not load - 10https://bugzilla.wikimedia.org/71175#c3 (10Robin Krahl) 5NEW>3RESO/WOR Hmm, strange. The problem does not occur with a blanked common.js, though the user scripts did not report an error. Anyway, thanks for the assistance; I’ll have anoth... [14:22:37] 3VisualEditor / 3Editing Tools: Template editor does not load - 10https://bugzilla.wikimedia.org/71175#c4 (10Elitre) You're welcome. On de.wp you can find me at https://de.wikipedia.org/wiki/Wikipedia:Technik/Text/Edit/VisualEditor/Beta2013-07 . Please let us know of any further issues, or just leave your th... [15:00:26] (03CR) 10Zfilipin: [C: 04-1] WIP: [Browser Test] Reworked step definition and links file basis input (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [15:35:21] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf21] Editor is displayed with two toolbars on second initialisation - 10https://bugzilla.wikimedia.org/70768#c12 (10Ritu Swain) (In reply to Rummana Yasmeen from comment #11) > I cannot reproduce it following your steps.In steps 4, you menti... [15:36:06] 3VisualEditor / 3Data Model: VisualEditor: In the Re-use reference dialog, search is not returning correct results on the second initialization for a specific case - 10https://bugzilla.wikimedia.org/70886#c15 (10Ritu Swain) http://youtu.be/5RjM22EfZjE [16:02:56] 3OOjs UI: OOjs UI: "Use this Group" menu items, in Reference dialog, have a cut-off display - 10https://bugzilla.wikimedia.org/71178 (10Ritu Swain) 3UNCO p:3Unprio s:3trivia a:3None Created attachment 16554 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16554&action=edit screenshot showing "Use... [16:03:07] 3OOjs UI: OOjs UI: "Use this Group" menu items, in Reference dialog, have a cut-off display - 10https://bugzilla.wikimedia.org/71178 (10Ritu Swain) [16:30:48] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107663972 [16:30:48] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107686670 [16:30:48] Corruption alert: visualeditor-needcheck on viwiki: https://vi.wikipedia.org/?diff=19639547 [16:30:48] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32757363 [16:30:48] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32758524 [16:30:49] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32759903 [16:30:49] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32760992 [16:30:50] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32761035 [16:30:50] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32761691 [16:30:51] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65729393 [16:30:51] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65739592 [16:30:52] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65740962 [16:30:52] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40119277 [16:30:53] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40126934 [16:32:41] :/ [16:33:52] the few i clicked were false positives. [17:17:12] MatmaRex: Still… :-( [17:17:48] :( [17:20:09] Also, we had the stand-up without you today, sorry. [17:21:06] James_F: https://fr.wikipedia.org/?diff=107686670 [17:21:28] VisualEditor: making it easier to mess with population numbers since 2011 :P [17:26:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf21] Editor is displayed with two toolbars on second initialisation - 10https://bugzilla.wikimedia.org/70768#c13 (10Rummana Yasmeen) 5RESO/FIX>3REOP Ok thanks so much Ritu! I can now reproduce it.The following error appears in the consol... [17:26:54] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf21] Editor is displayed with two toolbars on second initialisation - 10https://bugzilla.wikimedia.org/70768 (10Rummana Yasmeen) 5REOP>3ASSI a:3Roan Kattouw [17:36:56] RoanKattouw:http://en.wikipedia.beta.wmflabs.org/wiki/70768 [18:08:42] (03PS1) 10Jforrester: Converter: Allow Nodes to return empty arrays if they want not to be output [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162301 [18:09:51] >>> Array.isArray( undefined ) [18:09:51] RoanKattouw: (boolean) false [18:09:55] James_F: ---^^ [18:10:59] (03PS2) 10Jforrester: Converter: Allow Nodes to return empty arrays if they want not to be output [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162301 [18:11:12] (03PS1) 10Krinkle: Remove ve.isArray and use Array.isArray instead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162302 [18:11:36] >> Array.isArray() [18:11:36] Krinkle: (boolean) false [18:11:39] >> Array.isArray( [] ) [18:11:39] Krinkle: (boolean) true [18:11:45] >> Array.isArray( Object.create(Array) ) [18:11:45] Krinkle: (boolean) false [18:11:49] >> Array.isArray( Object.create(Array.prototype) ) [18:11:49] Krinkle: (boolean) false [18:11:58] (03CR) 10Catrope: [C: 032] Converter: Allow Nodes to return empty arrays if they want not to be output [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162301 (owner: 10Jforrester) [18:12:11] >> var x = []; delete x.__proto__; [ Array.isArray(x), x ]; [18:12:11] Krinkle: (object) [true, []] [18:12:28] >> var x = []; delete x.__proto__; x.push [18:12:28] Krinkle: (function) push [18:12:34] (03CR) 10jenkins-bot: [V: 04-1] Remove ve.isArray and use Array.isArray instead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162302 (owner: 10Krinkle) [18:13:16] >> Array.isArray( Object.create( new Array ) ) [18:13:16] Krenair: (boolean) false [18:13:58] (03PS2) 10Krinkle: Remove ve.isArray and use Array.isArray instead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162302 [18:14:13] (03Merged) 10jenkins-bot: Converter: Allow Nodes to return empty arrays if they want not to be output [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162301 (owner: 10Jforrester) [18:14:55] MatmaRex: how's it going? [18:18:08] James_F: RoanKattouw: http://es5.github.io/#x12.8 [18:19:59] TrevorParscal: how's what going? mostly okay, although i haven't gotten anything done today yet. hard drives are almost as evil as printers. [18:23:40] (03PS2) 10Alex Monk: Try to stop user from tabbing outside of open dialog box [oojs/ui] - 10https://gerrit.wikimedia.org/r/159902 (https://bugzilla.wikimedia.org/67156) [18:28:22] MatmaRex: Roan reviewed "our" code [18:28:33] some of it, mostly the grunt stuff, you might be able to help address [18:28:40] https://gerrit.wikimedia.org/r/#/c/157866/22 [18:28:43] hard drive permitting [18:28:46] do you need a computer? [18:29:26] (03PS1) 10Jforrester: MWHeading: Don't put self in output if contents are blank or whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162310 (https://bugzilla.wikimedia.org/50100) [18:29:29] i saw, will look [18:29:57] nah, the one i have is nice. my hard drive woes were related to a SSD upgrade :) [18:31:55] (03CR) 10jenkins-bot: [V: 04-1] MWHeading: Don't put self in output if contents are blank or whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162310 (https://bugzilla.wikimedia.org/50100) (owner: 10Jforrester) [18:32:14] hi [18:32:20] I see you are using trello [18:32:35] is it just IT seccion, who does? [18:33:28] are we? i don't think we do. some other WMF teams do, though. try #wikimedia-corefeatures? [18:33:29] umm James Forester is probably not an IT guy [18:33:46] (03PS1) 10Jforrester: Update VE core submodule to master (563666a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162315 [18:33:47] MatmaRex: well, I see there VE analitics tab [18:45:26] 3VisualEditor / 3Editing Tools: VisualEditor: When an image is the first item of the document , trying to delete it right after opening VE throws "Error: offset was inside a handlesOwnChildren node" - 10https://bugzilla.wikimedia.org/71187 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created... [18:47:38] 3VisualEditor / 3Editing Tools: VisualEditor: When an image is the first item of the document , trying to delete it right after opening VE throws "Error: offset was inside a handlesOwnChildren node" - 10https://bugzilla.wikimedia.org/71187#c1 (10Rummana Yasmeen) It happens for reflist too.Though thats not so... [19:04:18] (03PS1) 10Catrope: Tolerate null boundingRect in all code paths in DesktopContext#updateDimensions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162359 (https://bugzilla.wikimedia.org/70768) [19:04:24] (03PS1) 10Catrope: Don't drop 1px rects for FocusableNodes if all we have is 1px rects [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162360 (https://bugzilla.wikimedia.org/70768) [19:05:38] RoanKattouw: https://gerrit.wikimedia.org/r/162315 [19:06:06] Juandev: What Trello board? [19:06:21] James_F: ve analytics [19:06:37] Juandev: There's a VE analytics Trello board? [19:07:22] James_F: yup [19:07:28] Juandev: Oh, right, that thing from 2013. Not used in over a year. [19:07:40] James_F: huh ok [19:07:40] Juandev: It took a few weeks for me to explain that Trello is terrible. :-) [19:07:55] James_F: we were just testing it today [19:08:25] and its a major move to something better than Google, but I miss a some functionality [19:09:06] and I am surprised that even Trello Business, doesnt offer that functionality. Why to pay 45 bugs/pers/ yer and get more emoticons in bussiness version? [19:09:28] James_F: so did you switched for a different PMS? [19:09:46] Juandev: We use Bugzilla. [19:09:50] Juandev: We always have. [19:10:04] Soon we'll switch to Phabricator with everyone else, though. [19:10:11] Krinkle: https://gerrit.wikimedia.org/r/#/c/161957/ [19:10:46] James_F: well and what about other not IT WMF guys, do they have any project management sw? [19:11:15] bugzilla sounds to be good enough for IT solutions, but not for social and others, or basic org management [19:11:39] Juandev: Phabricator is a bit better for non-technical people. [19:11:54] ummh, lets see [19:12:16] James_F: well in bugzilla you dont have Khant chart [19:17:22] 3MediaWiki / 3Page editing: Etherpad functionality within MediaWiki editing - 10https://bugzilla.wikimedia.org/28373#c4 (10Sumana Harihareswara) 5NEW>3RESO/FIX https://www.mediawiki.org/wiki/Extension:EtherEditor is an implementation, by Mark Holmquist, of Etherpad editing within a MediaWiki installation... [19:18:54] 3MediaWiki / 3Page editing: Etherpad functionality within MediaWiki editing - 10https://bugzilla.wikimedia.org/28373#c5 (10Mark Holmquist) 5RESO/FIX>3REOP Ehhh, but it's broken. A lot. I think cscott had a few ideas on the burner, so I'll reopen and ping him to add some details. [19:20:31] (03PS5) 10Krinkle: Prevent page elements from displaying on top of highlights [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161957 (https://bugzilla.wikimedia.org/70074) (owner: 10Bartosz Dziewoński) [19:21:42] (03CR) 10Catrope: [C: 032] Add expand method to ranges, finish unit test coverage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161977 (owner: 10Esanders) [19:22:12] Juandev: You mean a Gantt chart? Yeah, those are pointless. [19:22:19] RoanKattouw: https://gerrit.wikimedia.org/r/162315 [19:23:21] (03Merged) 10jenkins-bot: Add expand method to ranges, finish unit test coverage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161977 (owner: 10Esanders) [19:23:32] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (563666a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162315 (owner: 10Jforrester) [19:24:12] RoanKattouw: You seen https://gerrit.wikimedia.org/r/160423 ? [19:26:43] (03Merged) 10jenkins-bot: Update VE core submodule to master (563666a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162315 (owner: 10Jforrester) [19:31:13] (03PS6) 10Krinkle: Prevent page elements from displaying on top of highlights [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161957 (https://bugzilla.wikimedia.org/70074) (owner: 10Bartosz Dziewoński) [19:31:53] (03CR) 10Krinkle: [C: 031] "Added a tooltip to make it easier to determine what's going on with the pointer events." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161957 (https://bugzilla.wikimedia.org/70074) (owner: 10Bartosz Dziewoński) [19:32:28] (03CR) 10Catrope: [C: 032] Make newFromTranslatedRange a method (translate) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161978 (owner: 10Esanders) [19:33:03] ok [19:35:11] (03Merged) 10jenkins-bot: Make newFromTranslatedRange a method (translate) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161978 (owner: 10Esanders) [19:36:03] (03Abandoned) 10Krinkle: [WIP] Demo refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131078 (owner: 10Krinkle) [19:39:09] 3VisualEditor / 3Data Model: VisualEditor: [Regression] When an image is the first item of the document , trying to delete it right after opening VE throws "Error: offset was inside a handlesOwnChildren node" - 10https://bugzilla.wikimedia.org/71187 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5n... [19:48:52] 3MediaWiki / 3Page editing: Etherpad functionality within MediaWiki editing - 10https://bugzilla.wikimedia.org/28373#c6 (10C. Scott Ananian) Try out the TogetherJS collaboration for the text field: https://en.wikipedia.org/wiki/User:Cscott/common.js [20:08:43] (03CR) 10Catrope: [C: 04-1] Use LinkCache instead of an object in MWCategoryWidget to store hidden status (to be shared with the input widget) (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161637 (owner: 10Alex Monk) [20:09:11] (03PS2) 10Jforrester: MWHeading: Don't put self in output if contents are blank or whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162310 (https://bugzilla.wikimedia.org/50100) [20:09:15] (03PS4) 10Catrope: Blur contentEditable node while destroying surface. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144089 (owner: 10Inez) [20:11:00] (03CR) 10jenkins-bot: [V: 04-1] MWHeading: Don't put self in output if contents are blank or whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162310 (https://bugzilla.wikimedia.org/50100) (owner: 10Jforrester) [20:11:28] (03CR) 10Catrope: [C: 04-1] "PS4 addresses my comment on PS3, but I'm still anxious about making this change unless you explain why it's needed" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144089 (owner: 10Inez) [20:16:05] (03CR) 10Catrope: [C: 032] TextInputWidget: Determine validity on blur and change. [oojs/ui] - 10https://gerrit.wikimedia.org/r/161516 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [20:17:29] (03Merged) 10jenkins-bot: TextInputWidget: Determine validity on blur and change. [oojs/ui] - 10https://gerrit.wikimedia.org/r/161516 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [20:22:22] 3VisualEditor / 3Editing Tools: VisualEditor: Highlight missing parameters in template dialog when complaining about them - 10https://bugzilla.wikimedia.org/70957 (10James Forrester) [20:31:49] (03CR) 10Bartosz Dziewoński: [BREAKING CHANGE] Create a MediaWiki theme (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [20:33:03] (03CR) 10Bartosz Dziewoński: "Replied about my parts of the mess. :)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [20:35:17] (03CR) 10Bartosz Dziewoński: [C: 031] Prevent page elements from displaying on top of highlights [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161957 (https://bugzilla.wikimedia.org/70074) (owner: 10Bartosz Dziewoński) [20:36:41] RoanKattouw, what should I do about https://gerrit.wikimedia.org/r/#/c/161613/ ? I was relying on 'blur' only being fired when the user explicitly moves focus away from the box, but it's apparently triggered by something else as well? [20:39:20] Have you managed to get a stack trace of why isn't being focused/blurred on init/open? [20:40:02] RoanKattouw: https://gerrit.wikimedia.org/r/162456 [20:44:42] (03CR) 10Catrope: [BREAKING CHANGE] Create a MediaWiki theme (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [21:13:01] RoanKattouw, TrevorParscal I'm increasingly thinking we need to store multi-range selections in the model [21:13:34] sure you can do one special case for strip-delete, but what about formatting actions [21:14:52] sounds exciting [21:15:13] MatmaRex: how's the computer? [21:15:26] okay [21:18:34] do you need a computer? [21:30:22] (03PS1) 10Bartosz Dziewoński: ve.ui.Context: Prevent context changes during opening/closing inspectors better [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162473 (https://bugzilla.wikimedia.org/71131) [21:31:04] James_F: whoo. that might work. it seems to fix this issue, no idea if it breaks anything else. ^ [21:33:56] TrevorParscal: my dream laptop has a 16:10 or squarer screen, is about 15" on the diagonal, a real keyboard, and a trackpoint. i'm afraid they don't make any like this anymore, and i've got one like that. i'm not going to change it until advancing technology forces me to. :) [21:34:25] or your computer stops working? [21:34:50] it's a thinkpad, i don't expect that within my lifetime ;) [21:35:15] well, if you are losing productivity due to hardware problems, please let us know so we can sort that out [21:35:16] (and in any case, the market of used classic thinkpads is pretty large) [21:35:32] I used to use ThinkPads, I feel your pain [21:35:58] I eventually switched to mac [21:36:19] but, I get how you can get really attached to a form factor/keyboard/pointer, etc [21:36:32] nah, it was mostly my fault. i'm not very good with hardware and it was bluescreening on me because of some stupid bios sata settings [21:36:56] does that mean you are using Windows? [21:37:12] yes. ssssh. [21:37:52] (03PS1) 10Catrope: Re-clip popups after resizing them [oojs/ui] - 10https://gerrit.wikimedia.org/r/162474 (https://bugzilla.wikimedia.org/71153) [21:39:23] Was there a change at some point to how citations (probably among other things) were rendered? [21:39:56] I'm pretty sure a bunch of bugs I fixed to do with reference searching (a while back) were caused by something like that, and now someone has found what appears to be one more [21:39:56] Why? [21:40:42] (03CR) 10Bartosz Dziewoński: "I think this works (or at least I'm unable to break it). This and Ed's context changes might need some careful manual testing. :/" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162473 (https://bugzilla.wikimedia.org/71131) (owner: 10Bartosz Dziewoński) [21:41:15] E.g. https://gerrit.wikimedia.org/r/#/c/150736/ [21:41:28] (03CR) 10Catrope: [C: 04-1] WIP Support new column-width & mode attributes to Cite's (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123093 (https://bugzilla.wikimedia.org/51260) (owner: 10Alex Monk) [21:41:58] (03PS2) 10Bartosz Dziewoński: ve.ui.Context: Prevent context changes during opening/closing inspectors better [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162473 (https://bugzilla.wikimedia.org/71131) [21:50:44] (03CR) 10Catrope: [C: 04-1] [WIP] Show LST
elements and let them be edited (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159182 (https://bugzilla.wikimedia.org/70581) (owner: 10Jforrester) [21:51:36] TrevorParscal: https://gerrit.wikimedia.org/r/162474 [21:52:08] TrevorParscal: Also https://gerrit.wikimedia.org/r/#/c/162360/ plus dependency [21:53:57] (03PS1) 10Bartosz Dziewoński: ve.dm.Surface: Fix documentation typo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162476 [21:54:50] (03PS1) 10Bartosz Dziewoński: ve.ui.MWLiveExtensionInspector: Fix comment typo [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162478 [21:55:28] edsanders: https://gerrit.wikimedia.org/r/162473 needs you. [21:55:43] (03CR) 10Jforrester: [C: 032] ve.dm.Surface: Fix documentation typo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162476 (owner: 10Bartosz Dziewoński) [21:55:55] (03CR) 10Jforrester: [C: 032] ve.ui.MWLiveExtensionInspector: Fix comment typo [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162478 (owner: 10Bartosz Dziewoński) [21:56:45] MatmaRex, I'm trying to find the underlying cause [21:56:58] it does look like .selectedNodes is wrong [21:57:07] yes [21:57:11] i think i found it [21:57:33] (03Merged) 10jenkins-bot: ve.ui.MWLiveExtensionInspector: Fix comment typo [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162478 (owner: 10Bartosz Dziewoński) [21:57:49] #afterContextChange is simply not called for the stuff that happens during inspector setup, because we have an if() for that in onContextChange [21:58:01] (03Merged) 10jenkins-bot: ve.dm.Surface: Fix documentation typo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162476 (owner: 10Bartosz Dziewoński) [21:58:17] i removed that if(0 and moved it to #onContextChange itself, so we don't close inspectors that are currently opening [21:58:45] it makes intuitive sense to me and i couldn't find a way to break it [22:00:53] just realised my copy of parsoid is from april [22:01:00] updated, but now I get this: [22:01:02] this.parser = new HTML5.DOMParser( domino ); [22:01:02] ^ [22:01:02] TypeError: undefined is not a function [22:01:22] Krenair: `rm -rf node_modules && npm install` [22:02:30] (03CR) 10Trevor Parscal: [C: 032] Re-clip popups after resizing them [oojs/ui] - 10https://gerrit.wikimedia.org/r/162474 (https://bugzilla.wikimedia.org/71153) (owner: 10Catrope) [22:03:00] RoanKattouw: ^^^ Cherry-pick? [22:03:19] (03Merged) 10jenkins-bot: Re-clip popups after resizing them [oojs/ui] - 10https://gerrit.wikimedia.org/r/162474 (https://bugzilla.wikimedia.org/71153) (owner: 10Catrope) [22:05:02] Krinkle: https://gerrit.wikimedia.org/r/#/c/161957/ [22:05:20] (03CR) 10Krinkle: [C: 032] Prevent page elements from displaying on top of highlights [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161957 (https://bugzilla.wikimedia.org/70074) (owner: 10Bartosz Dziewoński) [22:05:53] 3VisualEditor / 3ContentEditable: VisualEditor: .topicon icons are taking editors to linked pages, rather than letting them edit the template, in MonoBook on English Wikipedia - 10https://bugzilla.wikimedia.org/70074 (10James Forrester) 5PATC>3RESO/FIX [22:06:34] (03Merged) 10jenkins-bot: Prevent page elements from displaying on top of highlights [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161957 (https://bugzilla.wikimedia.org/70074) (owner: 10Bartosz Dziewoński) [22:07:10] 3VisualEditor / 3ContentEditable: VisualEditor: Issues with shields/highlights/phantoms (tracking) - 10https://bugzilla.wikimedia.org/66083#c1 (10James Forrester) 5ASSI>3RESO/WOR Tracking bug with no outstanding blockers. Closing. [22:07:10] (03CR) 10Catrope: [C: 032] Tweak traverseUpstream documentation and code style [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161668 (owner: 10Esanders) [22:08:33] (03Merged) 10jenkins-bot: Tweak traverseUpstream documentation and code style [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161668 (owner: 10Esanders) [22:10:28] James_F, got it running but it seems to be stuck parsing the page :/ [22:10:39] Krenair: :-( [22:15:51] RoanKattouw, talk to me about getNodeFromOffset [22:16:05] (03CR) 10Trevor Parscal: [C: 032] Tolerate null boundingRect in all code paths in DesktopContext#updateDimensions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162359 (https://bugzilla.wikimedia.org/70768) (owner: 10Catrope) [22:16:32] edsanders: so, multiple ranges aye? [22:16:35] edsanders: What about it [22:16:46] it is defined in ve.BranchNode where it will return any type of node [22:16:54] TrevorParscal: Could you review https://gerrit.wikimedia.org/r/#/c/162360/ too? [22:17:01] Oh that [22:17:10] Whereas in other cases it returns the branch node [22:17:11] then in ve.ce/dm.Document, it returns the parent if !canHaveChildren [22:17:14] Yeah [22:17:19] That is horrible [22:17:39] I would be so happy if that were to die in a hellish fire [22:17:41] so document.getNodeFromOffset !== document.documentNode.getNodeFromOffset [22:17:41] (03Merged) 10jenkins-bot: Tolerate null boundingRect in all code paths in DesktopContext#updateDimensions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162359 (https://bugzilla.wikimedia.org/70768) (owner: 10Catrope) [22:18:04] Unfortunately we rely on one behavior vs the other quite often, so we'd have to migrate all callers [22:18:53] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf 22] Inspector loses it UI after scrolling down the page and clicking somewhere else in the document - 10https://bugzilla.wikimedia.org/71153 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3High s:5normal>3major [22:19:08] James_F, even if its just ''b'' [22:19:14] at least "getBranchNodeFromOffset" [22:19:37] Yeah or that [22:19:39] Good cal [22:19:41] l [22:20:26] (03CR) 10Trevor Parscal: [C: 04-1] Don't drop 1px rects for FocusableNodes if all we have is 1px rects (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162360 (https://bugzilla.wikimedia.org/70768) (owner: 10Catrope) [22:21:36] (03PS2) 10Catrope: Don't drop 1px rects for FocusableNodes if all we have is 1px rects [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162360 (https://bugzilla.wikimedia.org/70768) [22:21:40] TrevorParscal: ---^^ [22:23:04] (03CR) 10Trevor Parscal: [C: 032] Don't drop 1px rects for FocusableNodes if all we have is 1px rects [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162360 (https://bugzilla.wikimedia.org/70768) (owner: 10Catrope) [22:24:24] (03Merged) 10jenkins-bot: Don't drop 1px rects for FocusableNodes if all we have is 1px rects [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162360 (https://bugzilla.wikimedia.org/70768) (owner: 10Catrope) [22:30:02] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (880100c45e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162487 [22:30:14] TrevorParscal, yeah [22:30:20] I think it's unavoidalb [22:30:26] -able [22:31:37] MatmaRex: Could you quickly +2 these two pull-throughs https://gerrit.wikimedia.org/r/#/c/162487/ and https://gerrit.wikimedia.org/r/#/c/162488/ for our sanity? [22:31:38] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (880100c45e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162487 (owner: 10Jforrester) [22:31:46] Or, never mind, Roan will do it. :-) [22:33:28] 3MediaWiki extensions / 3Cite: Supporting directionality for references - 10https://bugzilla.wikimedia.org/13673 (10Sumana Harihareswara) [22:34:02] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (880100c45e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162487 (owner: 10Jforrester) [22:34:49] (03PS8) 10Alex Monk: WIP Support new column-width & mode attributes to Cite's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123093 (https://bugzilla.wikimedia.org/51260) [22:37:15] sorry, was afk for a minute. [22:38:36] Krenair: https://gerrit.wikimedia.org/r/#/c/159902/ [22:38:42] you had questions about this? [22:38:54] I am concerned about it, but I need to test it to be sure [22:42:01] I'm not sure about it. [22:44:49] I'm still not 100% convinced we really want it. It seems browsers are handling this differently. [22:50:19] yeah, the main thing I'm concerned about is they should be able to tab out of the page (into the address bar) [22:52:43] (03PS1) 10Esanders: Calculate selected node on change and emit contextChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162495 (https://bugzilla.wikimedia.org/71131) [22:52:54] RoanKattouw: ^^^ [22:53:03] Krenair: so, I'm seeing we aren't the first people with this problem [22:53:10] some links in google seem relevant [22:53:11] https://drublic.de/blog/accessible-dialogs-modals/ [22:53:28] http://stackoverflow.com/questions/12936954/how-does-jquery-ui-dialog-disable-focus-on-background-inputs [22:53:30] stuff like that [22:53:32] brb [22:56:20] (03CR) 10Esanders: [C: 04-2] "This may fix the bug but I'm not confident it doesn't break other cases. I came across other issues with our current system for not closin" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162473 (https://bugzilla.wikimedia.org/71131) (owner: 10Bartosz Dziewoński) [22:56:38] (03PS5) 10Alex Monk: Use LinkCache instead of an object in MWCategoryWidget to store hidden status (to be shared with the input widget) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161637 [22:58:33] (03CR) 10Bartosz Dziewoński: "In this particular case, the issue was caused by the contextChange emitted during inspector setup being intentionally ignored, which meant" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162473 (https://bugzilla.wikimedia.org/71131) (owner: 10Bartosz Dziewoński) [22:58:36] (03PS2) 10Esanders: Calculate selected node on change and emit contextChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162495 (https://bugzilla.wikimedia.org/71131) [23:00:08] (03Abandoned) 10Bartosz Dziewoński: ve.ui.Context: Prevent context changes during opening/closing inspectors better [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162473 (https://bugzilla.wikimedia.org/71131) (owner: 10Bartosz Dziewoński) [23:00:38] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it - 10https://bugzilla.wikimedia.org/71131 (10Bartosz Dziewoński) a:5Bartosz Dziewoński>3Ed Sanders [23:00:51] (03CR) 10Esanders: "I agree that seems ugly, and if my fix I store lastSelectedNode even if we cancel afterSelectionChange, but before we remove the code bloc" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162473 (https://bugzilla.wikimedia.org/71131) (owner: 10Bartosz Dziewoński) [23:00:53] (03PS1) 10Catrope: Don't drop 1px rects for FocusableNodes if all we have is 1px rects [VisualEditor/VisualEditor] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162497 (https://bugzilla.wikimedia.org/70768) [23:02:01] edsanders: i assigned the bug to you then. thanks for investigating [23:02:10] and good night [23:02:21] night [23:04:11] 3MediaWiki / 3ResourceLoader: Using "/*@noflip*/ /*@embed*/" annotation doesn't work (although other combinations do) - 10https://bugzilla.wikimedia.org/69698 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [23:04:24] 3MediaWiki / 3ResourceLoader: Using "/*@noflip*/ /*@embed*/" annotation doesn't work (although other combinations do) - 10https://bugzilla.wikimedia.org/69698 (10Bartosz Dziewoński) [23:16:58] (03PS1) 10Esanders: Fix documentation in ve.Document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162502 [23:50:18] (03CR) 10Alex Monk: "See I7e3a2a16" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161613 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [23:50:30] (03PS1) 10Alex Monk: TextInputWidget: Determine validity in onEdit rather than in setValue [oojs/ui] - 10https://gerrit.wikimedia.org/r/162511 (https://bugzilla.wikimedia.org/70957)