[00:25:29] (03CR) 10Catrope: "Why is this needed?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/162511 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [00:27:45] (03CR) 10Alex Monk: "To fix the issue I mentioned on Ieaf4c194 - setValue is called as soon as the widget is constructed, but we only want explicit user action" [oojs/ui] - 10https://gerrit.wikimedia.org/r/162511 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [00:30:36] TrevorParscal: Thoughts on https://gerrit.wikimedia.org/r/#/c/162511/ ? [00:45:14] (03PS8) 10Krinkle: Add a clean-up script for use as a pre-commit hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 (owner: 10Jforrester) [00:45:58] (03PS9) 10Krinkle: Add a clean-up script for use as a pre-commit hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 (owner: 10Jforrester) [00:47:11] (03PS10) 10Krinkle: Add a clean-up script for use as a pre-commit hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 (owner: 10Jforrester) [00:50:44] (03PS3) 10Krinkle: Remove ve.isArray and use Array.isArray instead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162302 [00:50:57] James_F: ^ [00:51:17] (03CR) 10Trevor Parscal: [C: 04-1] "We should add a method called setValidation() which is called AFTER setValue in the constructor, which causes the validation to only be pe" [oojs/ui] - 10https://gerrit.wikimedia.org/r/162511 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [00:52:05] (03CR) 10jenkins-bot: [V: 04-1] Remove ve.isArray and use Array.isArray instead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162302 (owner: 10Krinkle) [00:55:00] (03PS4) 10Krinkle: Remove ve.isArray and use Array.isArray instead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162302 [00:57:30] (03PS5) 10Jforrester: [BREAKING CHANGE] Remove ve.isArray and use Array.isArray instead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162302 (owner: 10Krinkle) [00:57:36] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] Remove ve.isArray and use Array.isArray instead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162302 (owner: 10Krinkle) [00:58:27] (03PS1) 10Krinkle: Replace use of ve.isArray with native Array.isArray [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162521 [00:58:56] (03CR) 10Catrope: [C: 032] Move deletion part of handleDelete logic to surface fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161266 (owner: 10Esanders) [00:59:00] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Remove ve.isArray and use Array.isArray instead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162302 (owner: 10Krinkle) [00:59:53] 3MediaWiki / 3ResourceLoader: LESS compiler should preserve the position of CSSMin / CSSJanus annotations - 10https://bugzilla.wikimedia.org/54673#c13 (10Matthew Flaschen) Considering Bartosz's patch (https://gerrit.wikimedia.org/r/#/c/161245/) solved this in a different way, and this is an upstream (lessphp... [01:00:02] TrevorParscal: https://bugzilla.wikimedia.org/show_bug.cgi?id=40622 [01:00:40] (03Merged) 10jenkins-bot: Move deletion part of handleDelete logic to surface fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161266 (owner: 10Esanders) [01:00:54] 3MediaWiki / 3ResourceLoader: LESS compiler should preserve the position of CSSMin / CSSJanus annotations - 10https://bugzilla.wikimedia.org/54673 (10Krinkle) 5NEW>3RESO/WON [01:03:25] (03CR) 10Catrope: [C: 032] Use LinkCache instead of an object in MWCategoryWidget to store hidden status (to be shared with the input widget) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161637 (owner: 10Alex Monk) [01:06:40] (03Merged) 10jenkins-bot: Use LinkCache instead of an object in MWCategoryWidget to store hidden status (to be shared with the input widget) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161637 (owner: 10Alex Monk) [01:09:55] 3VisualEditor: Pasting in image caption with a repeated reference causes VE to crash - 10https://bugzilla.wikimedia.org/71214 (10Spinningspark) 3NEW p:3Unprio s:3major a:3None I found this bug while trying to swap the captions of two images, but it can be duplicated with just one image: 1. Paste this... [01:13:17] (03CR) 10Catrope: [C: 032] Fix documentation in ve.Document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162502 (owner: 10Esanders) [01:14:32] (03Merged) 10jenkins-bot: Fix documentation in ve.Document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162502 (owner: 10Esanders) [01:16:01] (03CR) 10Catrope: [C: 032] Calculate selected node on change and emit contextChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162495 (https://bugzilla.wikimedia.org/71131) (owner: 10Esanders) [01:17:29] (03Merged) 10jenkins-bot: Calculate selected node on change and emit contextChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162495 (https://bugzilla.wikimedia.org/71131) (owner: 10Esanders) [01:41:11] (03PS1) 10Krinkle: mw.LinkCache: Clean up [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162529 [03:04:17] (03CR) 10Jforrester: [C: 032] Replace use of ve.isArray with native Array.isArray [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162521 (owner: 10Krinkle) [03:05:58] (03Merged) 10jenkins-bot: Replace use of ve.isArray with native Array.isArray [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162521 (owner: 10Krinkle) [09:09:09] 3MediaWiki extensions / 3Cite: Add JS popup citation creator - 10https://bugzilla.wikimedia.org/31672#c1 (10Gadget850) These seem redundant or overlapping: Bug 2745 - Have References text edit window on Edit pages Bug 30777 - In-place editing of citations Bug 31672 - Add JS popup citation creator Does Visua... [09:09:10] 3MediaWiki extensions / 3Cite: In-place editing of citations - 10https://bugzilla.wikimedia.org/30777#c4 (10Gadget850) These seem redundant or overlapping: Bug 2745 - Have References text edit window on Edit pages Bug 30777 - In-place editing of citations Bug 31672 - Add JS popup citation creator Does Visua... [09:09:10] 3MediaWiki extensions / 3Cite: Have References text edit window on Edit pages - 10https://bugzilla.wikimedia.org/2745#c8 (10Gadget850) These seem redundant or overlapping: Bug 2745 - Have References text edit window on Edit pages Bug 30777 - In-place editing of citations Bug 31672 - Add JS popup citation cre... [09:20:53] 3MediaWiki extensions / 3Cite: Cite Extension: missing ref name before triggers error messages - 10https://bugzilla.wikimedia.org/29774#c5 (10Gadget850) Looking at the history of Patterns Of Screen Writing/Filmography, it looks like references were being used to create a list of works, which was... [09:33:08] 3MediaWiki extensions / 3Cite: Parser bugs with error message: MediaWiki:Cite error refs without references - 10https://bugzilla.wikimedia.org/17495#c2 (10Gadget850) With the resolution of Bug 16854, I am closing this. [09:33:22] 3MediaWiki extensions / 3Cite: Parser bugs with error message: MediaWiki:Cite error refs without references - 10https://bugzilla.wikimedia.org/17495 (10Gadget850) 5NEW>3RESO/FIX [09:34:52] 3MediaWiki extensions / 3Cite: Cite: when using "group=" attribute within "ref" element the space can cause line-break - 10https://bugzilla.wikimedia.org/19303#c1 (10Gadget850) Is this still an issue? If so, can we get a concrete example? [09:39:39] 3MediaWiki extensions / 3Cite: in ordered list or unordered list - 10https://bugzilla.wikimedia.org/25939#c3 (10Gadget850) With 1.24wmf21 I now see:

Text 1[1] Text 2 3MediaWiki extensions / 3Cite: in ordered list or unordered list - 10https://bugzilla.wikimedia.org/25939#c4 (10Fomafix) No. The outer

    still gets closed. [11:09:05] hm: https://bugzilla.wikimedia.org/show_bug.cgi?id=71222 [13:13:22] 3MediaWiki extensions / 3Cite: in ordered list or unordered list - 10https://bugzilla.wikimedia.org/25939#c5 (10Gadget850) I see the issue. Item 1 and Item 2 list is rendered as separate unordered lists and the The reference list is rendered as an unordered list, not an ordered list. I don't s... [13:21:07] (03PS1) 10Zfilipin: WIP [BrowserTest] reproducing bug 69535 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162576 (https://bugzilla.wikimedia.org/69535) [13:23:08] 3MediaWiki extensions / 3Cite: Citations templates - 10https://bugzilla.wikimedia.org/22134#c16 (10Gadget850) Over the last two years the major citation templates on the English wiki have been converted to Lua which has mostly resolved the performance issues. But, the use of these templates is not mandated... [13:25:37] 3MediaWiki extensions / 3Cite: Footnotes content should appear in a tooltip (add ReferenceTooltips to Cite as default/option) - 10https://bugzilla.wikimedia.org/7908#c24 (10Gadget850) It looks like some experimental tooltip code was added to cite.php but recently removed. We now have the experimental HoverC... [14:29:14] (03PS2) 10Zfilipin: WIP [BrowserTest] reproducing bug 69535 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162576 (https://bugzilla.wikimedia.org/69535) [14:44:30] (03Abandoned) 10Zfilipin: WIP [BrowserTest] reproducing bug 69535 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162576 (https://bugzilla.wikimedia.org/69535) (owner: 10Zfilipin) [15:44:37] (03PS1) 10Esanders: Rename ve.Document.getNodeFromOffset to getBranchNodeFromOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162612 [15:48:24] 3MediaWiki / 3Page editing: Provide a way to set page meta-data flags ("featured article", "protected", etc.), configure which ones are available for a wiki, and display icons indicating these statuses - 10https://bugzilla.wikimedia.org/23796 (10Bartosz Dziewoński) [15:53:22] 3MediaWiki / 3Page editing: Provide a way to set page meta-data flags ("featured article", "protected", etc.), configure which ones are available for a wiki, and display icons indicating these statuses - 10https://bugzilla.wikimedia.org/23796 (10Nemo) [16:03:58] (03PS2) 10Esanders: [BREAKING CHANGE] Rename ve.Document.getNodeFromOffset to getBranchNodeFromOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162612 [16:05:41] (03PS1) 10Esanders: Rename getNodeFromOffset to getBranchNodeFromOffset [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162621 [16:08:10] 3VisualEditor / 3Editing Tools: Regression: Link button does nothing - 10https://bugzilla.wikimedia.org/71237 (10Chris McMahon) 3NEW p:3Unprio s:3major a:3None Edit any page on beta labs e.g. http://en.wikipedia.beta.wmflabs.org/wiki/Media_Interface_VisualEditor_Test?veaction=edit Click the Link but... [16:12:41] Hey. [16:12:57] (03PS2) 10Alex Monk: TextInputWidget: Add setValidation function to change pattern used to validate text [oojs/ui] - 10https://gerrit.wikimedia.org/r/162511 (https://bugzilla.wikimedia.org/70957) [16:13:06] * Krenair waves [16:15:06] (03PS3) 10Alex Monk: Style required but currently-invalid parameters on the template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161613 (https://bugzilla.wikimedia.org/70957) [16:18:15] good morning peoples [16:24:50] (03CR) 10Trevor Parscal: [C: 04-1] TextInputWidget: Add setValidation function to change pattern used to validate text (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/162511 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [16:25:00] Morning TrevorParscal. [16:25:24] what's the craic mate? [16:26:01] I'm looking at code review now, but I will be doing the standup from home and coming in right after that [16:27:04] TrevorParscal, hey [16:27:16] Krenair: howdy man [16:27:30] TrevorParscal, what's the point in setting validate to null if we're about to setValidation( config.validate || null ) ? [16:27:47] so, 2 things [16:28:06] I think internal consistency is one, and consistency is another [16:28:10] we do this all over the place [16:28:25] I'm open to changing the pattern, but we should keep it consistent in the mean time [16:28:35] the internal consistency thing is the other... [16:29:19] so, you initialize it to null, within setValidation you resolve the incoming value to regexp, string -> regexp or falsey -> null [16:29:31] if string doesn't resolve, then use null [16:29:31] etc [16:29:45] so, then in isValid, you know that it's either a RegExp or null [16:30:00] because you've controlled it at initialization and modification points [16:30:06] and you can write your logic more simply [16:30:23] as it is now, it's a bit complex for how many lines it is [16:30:42] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13422401 [16:30:42] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107691101 [16:30:42] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32771256 [16:30:42] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32771295 [16:30:42] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32771330 [16:30:42] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32771331 [16:30:43] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32771406 [16:30:44] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32771414 [16:30:44] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32771549 [16:30:44] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32771679 [16:30:45] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32771996 [16:30:45] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32772038 [16:30:46] and we can avoid do as much legwork on keydown if we've already resolved the regexp [16:30:49] thoughts? [16:31:09] RoanKattouw_away edsanders James_F ^^^ [16:31:40] (03PS3) 10Alex Monk: TextInputWidget: Add setValidation function to change pattern used to validate text [oojs/ui] - 10https://gerrit.wikimedia.org/r/162511 (https://bugzilla.wikimedia.org/70957) [16:33:47] I think the edgiest case is the image dimensions widget [16:37:35] (03CR) 10Trevor Parscal: [C: 04-1] TextInputWidget: Add setValidation function to change pattern used to validate text (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/162511 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [16:37:44] Krenair: more pedantic comments [16:37:47] thanks for your patience [16:38:15] I'm hoping I'm actually helping you with my comments [16:38:43] like, explaining why it should be the way I'm asking it to be, rather than just asking you to change things arbitrarily [16:39:19] edsanders: what is that about image dimensions widget? [16:40:36] TrevorParscal, yeah, good catch with the nulls [16:41:22] As for the pattern of setting this.validate = null; anyway... Eh :p [16:43:39] TrevorParscal, wait, don't we want it to validate successfully if the pattern is left undefined? [16:45:36] I think it has "numbers only" maybe using validation? [16:49:08] ... what? [17:11:55] (03PS1) 10Krinkle: spec: Rewrite, reshape, reform! (Markdown) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/162639 [17:20:14] welp, my connection died, anod now hangouts says the room is empty. you're all done? [17:21:01] MatmaRex: Yeah, sorry. [17:21:13] okay, good :) did i miss anything important? [17:21:22] No, just me. :-) [17:26:19] (03PS1) 10Catrope: Account for isValid() becoming async [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162646 [17:26:31] Krenair: ----^^ [17:27:43] (03CR) 10jenkins-bot: [V: 04-1] Account for isValid() becoming async [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162646 (owner: 10Catrope) [17:28:11] (03PS1) 10Catrope: Make MWLinkTargetInputWidget#isValid asynchronous [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162647 [17:30:29] (03CR) 10Catrope: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162646 (owner: 10Catrope) [17:36:50] (03CR) 10Jforrester: [C: 04-1] "Trailing whitespace on a few lines… Otherwise good to go." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/162639 (owner: 10Krinkle) [17:51:18] (03Abandoned) 10Jforrester: [WIP] Show LST
    elements and let them be edited [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159182 (https://bugzilla.wikimedia.org/70581) (owner: 10Jforrester) [17:51:25] (03CR) 10Jforrester: [WIP] Show LST
    elements and let them be edited (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/159182 (https://bugzilla.wikimedia.org/70581) (owner: 10Jforrester) [18:02:44] Krenair: so, you had more questions about nulls? [18:03:04] TrevorParscal, wait, don't we want it to validate successfully if the pattern is left undefined? [18:04:31] ok, so you mean that match( undefined ) -> [""] actually IS the behavior you want [18:04:44] because it returns a non-falsey result [18:05:50] you could default to /.*/ instead of null [18:06:15] the point I was making is not about null, it's about having a predictable value internally by controlling all points where the value is set [18:07:31] the input of a set is untrusted, don't store it unless you have verified it's what you expect it to be, otherwise fallback to a stable default value [18:07:31] Krenair: Could you review https://gerrit.wikimedia.org/r/162646 and https://gerrit.wikimedia.org/r/162647 ? [18:08:05] that way everywhere the property is read, it's contents are known to be sane [18:11:11] (03PS1) 10Catrope: Update VE core submodule to master (9e69dba) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162658 [18:11:38] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (9e69dba) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162658 (owner: 10Catrope) [18:13:11] (03PS1) 10Jforrester: Follow-up I99acd6c6: More files' header comment fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162659 [18:14:23] MatmaRex: got any outstanding changes to https://gerrit.wikimedia.org/r/#/c/157866/ ? [18:14:29] I'm going to rebase and start fixing things [18:14:30] (03CR) 10jenkins-bot: [V: 04-1] Follow-up I99acd6c6: More files' header comment fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162659 (owner: 10Jforrester) [18:14:34] (looking at your comments now) [18:15:24] (03Merged) 10jenkins-bot: Update VE core submodule to master (9e69dba) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162658 (owner: 10Catrope) [18:16:23] (03CR) 10Catrope: [C: 032] "Looks fine, but hasChildren() is horribly misnamed IMO. A childless node will still return true for hasChildren() if it has the *ability* " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162612 (owner: 10Esanders) [18:16:45] RoanKattouw: canHaveChildren() ? [18:16:52] I think that's what it used to be called [18:17:01] I guess it must have been renamed for whatever reawson [18:17:40] James_F: RoanKattouw.static.canHaveChildren = false; // Nuff said [18:18:06] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Rename ve.Document.getNodeFromOffset to getBranchNodeFromOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162612 (owner: 10Esanders) [18:18:09] TrevorParscal: I was expecting you to use yourself as an example [18:18:15] lol [18:18:22] Trevor.hasChildren() === true Trevor.canHaveChildren() === false [18:18:38] Surely that's Trevor.canHaveMoreChildren() [18:18:48] I suppose so [18:18:58] Fortunately we don't support these kinds of things for nodes :D [18:19:00] As opposed to Trevor.canHaveChildren( 'future' ), which is still true. [18:19:04] * James_F grins. [18:19:13] no, it's really not [18:19:52] MatmaRex: you 'round? [18:20:02] wanted to avoid merge hell [18:20:11] yeah? [18:20:53] TrevorParscal: yeah? [18:21:13] (03PS23) 10Trevor Parscal: [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 [18:21:28] do you have any outstanding changes against ^^^^ [18:21:32] I just rebased it [18:21:42] and I'm about to make some more changes re: Roan's review [18:21:55] TrevorParscal: Trevor.canHaveChildren( 'future' ) === "is Trevor allowed to have children" !== "is Trevor going to have additional children ;-) [18:21:56] nope [18:22:02] ok cool [18:22:41] (03CR) 10jenkins-bot: [V: 04-1] [WIP] MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [18:33:34] (03PS1) 10Catrope: Update VE core submodule to master (8d5ec7a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162664 [18:34:35] (03PS2) 10Catrope: Update VE core submodule to master (8d5ec7a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162621 (owner: 10Esanders) [18:34:46] (03Abandoned) 10Catrope: Update VE core submodule to master (8d5ec7a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162664 (owner: 10Catrope) [18:36:09] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (8d5ec7a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162621 (owner: 10Esanders) [18:38:21] (03Merged) 10jenkins-bot: Update VE core submodule to master (8d5ec7a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162621 (owner: 10Esanders) [18:48:41] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1]Comment box is not opening in Betalabs - 10https://bugzilla.wikimedia.org/71246 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Cannot open comment box in Betalabs. Throwing the following error in the console: Uncaught TypeError:... [18:49:07] (03PS1) 10Catrope: Account for WhitespacePreservingTextInputWidget#getValue being called early [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162671 [18:49:09] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1]Comment box is not opening in Betalabs - 10https://bugzilla.wikimedia.org/71246 (10Rummana Yasmeen) 5NEW>3ASSI a:3Roan Kattouw [18:49:54] (03PS2) 10Catrope: Account for WhitespacePreservingTextInputWidget#getValue being called early [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162671 (https://bugzilla.wikimedia.org/71246) [18:50:12] (03PS2) 10Catrope: Account for isValid() becoming async [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162646 (https://bugzilla.wikimedia.org/71237) [18:50:23] (03PS3) 10Catrope: Account for WhitespacePreservingTextInputWidget#getValue being called early [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162671 (https://bugzilla.wikimedia.org/71246) [18:51:13] (03PS2) 10Catrope: Make MWLinkTargetInputWidget#isValid asynchronous [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162647 (https://bugzilla.wikimedia.org/71237) [19:03:46] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/162646 https://gerrit.wikimedia.org/r/#/c/162647 https://gerrit.wikimedia.org/r/162671 [19:06:40] (03CR) 10Trevor Parscal: [C: 032] Account for isValid() becoming async [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162646 (https://bugzilla.wikimedia.org/71237) (owner: 10Catrope) [19:08:02] (03CR) 10Trevor Parscal: [C: 031] Make MWLinkTargetInputWidget#isValid asynchronous [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162647 (https://bugzilla.wikimedia.org/71237) (owner: 10Catrope) [19:08:47] (03Merged) 10jenkins-bot: Account for isValid() becoming async [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162646 (https://bugzilla.wikimedia.org/71237) (owner: 10Catrope) [19:10:51] (03CR) 10Trevor Parscal: [C: 032] Account for WhitespacePreservingTextInputWidget#getValue being called early [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162671 (https://bugzilla.wikimedia.org/71246) (owner: 10Catrope) [19:13:02] (03Merged) 10jenkins-bot: Account for WhitespacePreservingTextInputWidget#getValue being called early [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162671 (https://bugzilla.wikimedia.org/71246) (owner: 10Catrope) [19:15:06] RoanKattouw, hey. Sorry I missed your message earlier, was having dinner [19:16:24] Krenair: No worries. I got Trevor to do the CRs because the commits needed to land today [19:16:33] ok [19:16:39] Otherwise 1.25wmf1 would have had JS errors when opening inspectors :| [19:17:16] Turns out that isValid() is a relatively popular method name, and some classes using it were now overriding the TextInputWidget version that appeared under their feet with incompatible (synchronous) implementations [19:17:26] Which led to a crashfest :S [19:17:50] do we need to update VE core in ve-mw? [19:18:46] Yeah I'm ddoing that now [19:18:54] ok [19:19:08] (03PS3) 10Catrope: Update VE core submodule to master (6e68242) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162647 (https://bugzilla.wikimedia.org/71237) [19:19:20] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (6e68242) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162647 (https://bugzilla.wikimedia.org/71237) (owner: 10Catrope) [19:20:10] 3VisualEditor / 3Editing Tools: VisualEditor: TitleInputWidget should validate inputs - 10https://bugzilla.wikimedia.org/71249 (10James Forrester) 3ASSI p:3Unprio s:3normal a:3None We have isValid() functions for similar inputs, but not this one, so it's possible to try to create a redirect to "|" (w... [19:20:14] Krinkle, did you want to make a pull request out of this as well: https://github.com/Krinkle/gerrit-sweep/commit/cf71d864a2f9f85064bb3c47d4ced376267f076d [19:20:46] edsanders: I made two branches with different approaches. Either could be useful. [19:20:56] they both work? [19:21:36] Yeah, I believe so [19:21:56] but you don't need both [19:22:20] One is assuming the output format git provides and cuts it, the other uses the lower level API directly (which has reliable output format) [19:23:46] can you submit the second one? [19:24:17] ha, that's interesting [19:24:34] i have a `git forget` alias which kills the current branch and switches to master [19:24:43] (03Merged) 10jenkins-bot: Update VE core submodule to master (6e68242) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162647 (https://bugzilla.wikimedia.org/71237) (owner: 10Catrope) [19:25:13] I've moved the git log master out of the loop so it's many times faster now [19:25:34] MatmaRex: I have "git clear" for that. [19:29:54] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf21] Editor is displayed with two toolbars on second initialisation - 10https://bugzilla.wikimedia.org/70768 (10James Forrester) 5PATC>3RESO/FIX [19:29:54] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it - 10https://bugzilla.wikimedia.org/71131 (10James Forrester) 5PATC>3RESO/FIX [19:30:23] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] Link button does nothing - 10https://bugzilla.wikimedia.org/71237 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Highes a:3Roan Kattouw [19:30:52] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] Comment box is not opening in Betalabs - 10https://bugzilla.wikimedia.org/71246 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Highes [19:32:39] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf22] Resizing the window adds an extra padding below the "Choose a different image" button in Media Settings dialog - 10https://bugzilla.wikimedia.org/70895 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low a:3Moriel Schottlender [19:33:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf22] Resizing the window adds an extra padding below the "Choose a different image" button in Media Settings dialog - 10https://bugzilla.wikimedia.org/70895 (10James Forrester) [19:35:55] (03PS4) 10Alex Monk: TextInputWidget: Add setValidation function to change pattern used to validate text [oojs/ui] - 10https://gerrit.wikimedia.org/r/162511 (https://bugzilla.wikimedia.org/70957) [19:45:42] (03PS1) 10Esanders: Prevent exception throwing in getFilename of MWImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162694 [19:48:15] edsanders: Have you seen https://bugzilla.wikimedia.org/show_bug.cgi?id=71139 ? [19:52:24] 3VisualEditor / 3Editing Tools: VisualEditor: TitleInputWidget should validate inputs - 10https://bugzilla.wikimedia.org/71249 (10Roan Kattouw) a:3Alex Monk [19:56:53] 3VisualEditor: Pasting in image caption with a repeated reference causes VE to crash - 10https://bugzilla.wikimedia.org/71214 (10Roan Kattouw) 5NEW>3ASSI a:3Roan Kattouw [19:58:23] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf22] Resizing the window adds an extra padding below the "Choose a different image" button in Media Settings dialog - 10https://bugzilla.wikimedia.org/70895 (10Roan Kattouw) a:5Moriel Schottlender>3Trevor Parscal [19:59:37] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre wmf 1]The substitute template for the field Month and year does not return any value - 10https://bugzilla.wikimedia.org/71157 (10Roan Kattouw) [20:02:25] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] When the inspector is still open for a selected node, after placing the cursor in a different position, inspector flickers there - 10https://bugzilla.wikimedia.org/71151#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Roan Katt... [20:10:14] James_F, what should we do with invalid values for MWTitleInputWidget, beyond flagging them as invalid? [20:10:48] I guess the template placeholder page can disable the 'Add template' button [20:10:50] Krenair: Well, for the meta dialog we should probably not set the new value if it's invalid. [20:10:55] And on the template… yeah. [20:11:11] So just ignore the invalid value? [20:11:53] Yeah; if it's currently blank don't set a nonsense one, if it's currently set don't over-write it with nonsense. [20:11:54] Make sense? [20:13:23] hm, isValid is async :/ [20:14:33] or at least, can be. in this case we know it will be resolved by the time we get it, but... [20:33:38] RoanKattouw, not yet [20:37:51] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] Link button does nothing - 10https://bugzilla.wikimedia.org/71237#c5 (10Rummana Yasmeen) Verified the fix in Betalabs [20:39:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] Comment box is not opening in Betalabs - 10https://bugzilla.wikimedia.org/71246#c5 (10Rummana Yasmeen) Verified the fix in Betalabs [20:40:38] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it - 10https://bugzilla.wikimedia.org/71131#c9 (10Rummana Yasmeen) Verified the fix in Betalabs [20:42:33] lots of bugs today ryasmeen :-) [20:42:46] or all the same bug [20:43:18] yes chrismcmahon, yeah also lots of them got fixed at one shot :) [20:43:48] yeah , the inspector issues were all almost related [20:47:55] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] When the inspector is still open for a selected node, after placing the cursor in a different position, inspector flickers there - 10https://bugzilla.wikimedia.org/71151#c2 (10Rummana Yasmeen) Nope this is still happening.I guess it has some... [20:54:10] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf21] Editor is displayed with two toolbars on second initialisation - 10https://bugzilla.wikimedia.org/70768#c19 (10Rummana Yasmeen) Verified the fix in Betalabs [20:58:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf 22] Inspector loses it UI after scrolling down the page and clicking somewhere else in the document - 10https://bugzilla.wikimedia.org/71153#c4 (10Rummana Yasmeen) Verified the fix in Betalabs [21:06:48] (03PS2) 10Krinkle: spec: Rewrite, reshape, reform! (Markdown) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/162639 [21:07:23] (03CR) 10Jforrester: [C: 032] spec: Rewrite, reshape, reform! (Markdown) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/162639 (owner: 10Krinkle) [21:09:05] (03Merged) 10jenkins-bot: spec: Rewrite, reshape, reform! (Markdown) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/162639 (owner: 10Krinkle) [21:09:38] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FTemplateData/master/Specification.md [21:09:39] yay [21:12:17] (03PS1) 10Krinkle: spec: Fix Markdown syntax to be compatible with gitblit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/162761 [21:13:16] (03CR) 10Krinkle: "Preview: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FTemplateData/9dd5cb40871ccb8134d5002d72ee71cd865d3a22/Specification.md" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/162761 (owner: 10Krinkle) [21:13:18] Krinkle: http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FTemplateData.git/9dd5cb40871ccb8134d5002d72ee71cd865d3a22/Specification.md [21:13:37] (03CR) 10Jforrester: [C: 032] spec: Fix Markdown syntax to be compatible with gitblit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/162761 (owner: 10Krinkle) [21:15:06] (03Merged) 10jenkins-bot: spec: Fix Markdown syntax to be compatible with gitblit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/162761 (owner: 10Krinkle) [21:20:56] The only bug in VE-* with redlink in it is https://bugzilla.wikimedia.org/show_bug.cgi?id=53441 [21:21:17] ah, red link; https://bugzilla.wikimedia.org/show_bug.cgi?id=65353 [21:21:19] found it [21:21:29] That looks right, yeah. [21:21:54] 3VisualEditor / 3MediaWiki integration: VisualEditor: Blue link / red link logic should descend into links inside generated content nodes (e.g. templates) - 10https://bugzilla.wikimedia.org/65353 (10James Forrester) a:3Alex Monk [21:23:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: Blue link / red link logic should descend into links inside generated content nodes (e.g. templates) - 10https://bugzilla.wikimedia.org/65353#c2 (10Krinkle) We used to parse template content with action=parse from the PHP parser which naturally contained... [21:24:00] James_F: https://bugzilla.wikimedia.org/show_bug.cgi?id=62803 - not sure what that bug is for [21:24:06] still relevant> [21:24:07] ? [21:27:52] 3VisualEditor / 3Technical Debt: VisualEditor: Extract red link API code from VE and put into Parsoid - 10https://bugzilla.wikimedia.org/62803#c1 (10James Forrester) (In Parsoid or whatever; the point is, this code should be re-useable by Flow, OCG and anyone else rather than buried inside VE.) [21:35:54] 3VisualEditor / 3Editing Tools: VisualEditor: Triggering context on link after defocus throws "TypeError: Cannot read property 'isCollapsed' of null" - 10https://bugzilla.wikimedia.org/68915#c1 (10Krinkle) 5ASSI>3RESO/WOR Can't reproduce. [21:41:09] Krinkle: i'm told that you grok gerrit. how do i change the default reviewer for OCG stuff from mwalker to cscott? [21:42:14] cscott: subscribe at https://gerrit.wikimedia.org/r/#/settings/projects [21:42:27] cscott: there is also an alternative, public way at https://www.mediawiki.org/wiki/Git/Reviewers [21:42:45] mwalker seems to use that [21:53:56] cscott: default reviewer doesn't exist in Gerrit. You can subscribe to e-mail notifications for certain projects/branches/file paths/events [21:54:09] and there's a bot (powered by that wiki page) that adds people to Reviewer list [21:57:37] 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580#c2 (10Rummana Yasmeen) 5RESO/FIX>3REOP Bartosz, did you check it in en.m.wikipedia.beta.wmflabs.org? Because it is a mobile bug and I am still seeing it there. [21:59:15] MatmaRex, Krinkle: thanks [22:02:33] (03PS1) 10Alex Monk: Unbreak category widget check for hidden pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162767 [22:02:37] 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580#c3 (10Bartosz Dziewoński) Yup, that's where I checked, and it still works correctly for me using desktop Opera beta 25. I admittedly didn't actually check with a mobi... [22:02:49] RoanKattouw_away, MatmaRex: ^ I have no idea how I managed to **** that up. [22:03:11] I must've tested before making that change and uploading PS1... [22:03:37] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf20] The link target suggestion drop down is appearing cut off to a very small size upon first time opening the link inspector - 10https://bugzilla.wikimedia.org/70683#c3 (10Rummana Yasmeen) 5ASSI>3RESO/FIX Yes, this one got fixed in wmf 22.Mark... [22:05:19] Krenair: huh, what error is that causing? [22:05:52] >> Object.prototype.hasOwnProperty( undefined, 'hiddencat' ) // this doesn't throw or anything [22:05:52] MatmaRex: (boolean) false [22:06:07] unless pageInfo is undefined, but in that case you have problems elsewhere too [22:06:29] >> Object.prototype.hasOwnProperty( {hiddencat: true}, 'hiddencat' ) [22:06:29] Krenair: (boolean) false [22:06:45] Krenair: .call [22:06:46] oh [22:06:48] duh [22:06:49] yes [22:06:51] (03CR) 10Catrope: [C: 032] Unbreak category widget check for hidden pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162767 (owner: 10Alex Monk) [22:07:08] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf20] The link target suggestion drop down is appearing cut off to a very small size upon first time opening the link inspector - 10https://bugzilla.wikimedia.org/70683 (10Rummana Yasmeen) [22:07:10] >> Object.prototype.hasOwnProperty( 'hasOwnProperty' ) [22:07:10] Krinkle: (boolean) true [22:07:13] :P [22:07:24] * MatmaRex slaps self around a bit with a large trout [22:07:40] sorry about that guys. [22:08:34] (03Merged) 10jenkins-bot: Unbreak category widget check for hidden pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162767 (owner: 10Alex Monk) [22:11:37] 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580#c4 (10Rummana Yasmeen) Oh yes.Sorry should have mentioned it, this bug is for iOS Safari only. [22:12:07] 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue in iOS Safari - 10https://bugzilla.wikimedia.org/64580 (10Rummana Yasmeen) [22:14:59] nope, still something broken there I think [22:15:14] sigh [22:19:47] (03PS1) 10Alex Monk: Really fix CategoryWidget checks for redirects to hidden categories this time [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162774 [22:19:56] * James_F coughs. [22:21:28] James_F: ? [22:21:44] No matter. [22:22:10] Just unfortunate I get pinged on every IRC message with "VisualEditor" in it whilst in meetings. [22:22:37] Even in this channel? [22:23:02] even from grrrit-wm? [22:25:53] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696#c8 (10Rummana Yasmeen) This is still happening [22:26:09] Krenair: Yeah, everywhere. I get a bunch of pings. :-) [22:48:52] (03CR) 10Catrope: [C: 032] Really fix CategoryWidget checks for redirects to hidden categories this time [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162774 (owner: 10Alex Monk) [22:50:34] (03Merged) 10jenkins-bot: Really fix CategoryWidget checks for redirects to hidden categories this time [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162774 (owner: 10Alex Monk) [23:00:10] 3VisualEditor / 3Editing Tools: VisualEditor Mobile: After tapping on "Go back"/"Continue Anyway" in the "Required parameter missing" confirmation dialog in iOS Safari, it flickers at the top of the screen - 10https://bugzilla.wikimedia.org/71259 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None S... [23:03:41] (03CR) 10Catrope: [C: 032 V: 032] Don't drop 1px rects for FocusableNodes if all we have is 1px rects [VisualEditor/VisualEditor] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162497 (https://bugzilla.wikimedia.org/70768) (owner: 10Catrope) [23:05:12] (03PS1) 10Catrope: Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162784 [23:05:24] (03CR) 10Catrope: [C: 032 V: 032] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162784 (owner: 10Catrope) [23:50:07] 3VisualEditor / 3Editing Tools: VisualEditor: TitleInputWidget should validate inputs - 10https://bugzilla.wikimedia.org/71249#c1 (10Alex Monk) Currently the redirect section of the page settings dialog and the template placeholder page use MWTitleInputWidget. The template placeholder page can be fixed with...