[01:30:06] 3VisualEditor / 3Technical Debt: VisualEditor: Extract red link API code from VE and put into Parsoid - 10https://bugzilla.wikimedia.org/62803#c2 (10Gabriel Wicke) For static pages we should be able to do this with CSS retrieved from an API. We'll provide this API for normal pages. For dynamic hints during... [01:44:39] 3VisualEditor / 3Editing Tools: VisualEditor Mobile: After tapping on "Go back"/"Continue Anyway" in the "Required parameter missing" confirmation dialog in iOS Safari, it flickers at the top of the screen - 10https://bugzilla.wikimedia.org/71259 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5n... [01:46:07] 3VisualEditor / 3Technical Debt: VisualEditor: Extract red link API code from VE and put into Parsoid - 10https://bugzilla.wikimedia.org/62803#c3 (10James Forrester) (In reply to Gabriel Wicke from comment #2) > For static pages we should be able to do this with CSS retrieved from an > API. We'll provide thi... [01:57:22] 3VisualEditor / 3Editing Tools: VisualEditor: Triggering context on link after defocus throws "TypeError: Cannot read property 'isCollapsed' of null" - 10https://bugzilla.wikimedia.org/68915 (10James Forrester) [01:57:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue in iOS Safari - 10https://bugzilla.wikimedia.org/64580 (10James Forrester) 5REOP>3ASSI s:5normal>3minor [01:58:36] 3VisualEditor / 3Editing Tools: VisualEditor: TitleInputWidget should validate inputs - 10https://bugzilla.wikimedia.org/71249 (10James Forrester) p:5Unprio>3High [02:01:54] 3VisualEditor / 3Editing Tools: VisualEditor: "Use this Group" menu items, in Reference / Reference list dialogs, have a cut-off display - 10https://bugzilla.wikimedia.org/71178#c1 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3High s:5trivia>3minor a:3Alex Monk See MWLinkTargetInputWidget does thi... [02:08:40] 3VisualEditor / 3Editing Tools: VisualEditor: "Use this Group" menu items, in Reference / Reference list dialogs, have a cut-off display - 10https://bugzilla.wikimedia.org/71178#c2 (10Roan Kattouw) (In reply to James Forrester from comment #1) > See MWLinkTargetInputWidget does this – the menu needs to use a... [05:08:48] (03PS1) 10Legoktm: Clean up various PHP hook functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162826 [05:10:38] (03CR) 10jenkins-bot: [V: 04-1] Clean up various PHP hook functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162826 (owner: 10Legoktm) [05:12:03] (03PS2) 10Legoktm: Clean up various PHP hook functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162826 [09:40:06] 3MediaWiki extensions / 3WikiEditor: remove messages for features that aren't going to be developed - 10https://bugzilla.wikimedia.org/71287 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Some features of WikiEditor probably aren't going to be developed much in the future. One such feature that... [13:18:51] (03PS1) 10Zfilipin: [BrowserTest] Disable screenshots for broken scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162879 (https://bugzilla.wikimedia.org/71298) [13:20:42] (03CR) 10Amire80: [C: 032] [BrowserTest] Disable screenshots for broken scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162879 (https://bugzilla.wikimedia.org/71298) (owner: 10Zfilipin) [13:22:32] (03Merged) 10jenkins-bot: [BrowserTest] Disable screenshots for broken scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162879 (https://bugzilla.wikimedia.org/71298) (owner: 10Zfilipin) [13:49:08] (03PS1) 10Esanders: Be more cautious about placing the cursor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162884 (https://bugzilla.wikimedia.org/71187) [13:51:16] (03CR) 10jenkins-bot: [V: 04-1] Be more cautious about placing the cursor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162884 (https://bugzilla.wikimedia.org/71187) (owner: 10Esanders) [15:19:01] (03PS1) 10Esanders: Fix some getSelectionRects edge cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162892 [15:20:51] (03CR) 10jenkins-bot: [V: 04-1] Fix some getSelectionRects edge cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162892 (owner: 10Esanders) [15:51:26] (03PS1) 10Esanders: Don't perform focus node native selection trick while dragging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162904 (https://bugzilla.wikimedia.org/71139) [15:53:19] (03CR) 10jenkins-bot: [V: 04-1] Don't perform focus node native selection trick while dragging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162904 (https://bugzilla.wikimedia.org/71139) (owner: 10Esanders) [15:57:10] 3VisualEditor / 3Data Model: VisualEditor: [Regression pre wmf1] Increasing indentation to a bullet/numbered list is also adding a slug with a new bullet/numbered point each time - 10https://bugzilla.wikimedia.org/71134#c2 (10Ed Sanders) Can you give more detailed instructions. I'm seeing slugs in lists but... [16:19:25] 3OOjs UI: OOjs UI: Allow Scrolling the text in the Insert Comment dialog, with only one scrollbar. - 10https://bugzilla.wikimedia.org/71310 (10Ritu Swain) 3UNCO p:3Unprio s:3enhanc a:3None Created attachment 16585 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16585&action=edit screenshot showi... [16:19:38] 3OOjs UI: OOjs UI: Allow Scrolling the text in the Insert Comment dialog, with only one scrollbar. - 10https://bugzilla.wikimedia.org/71310 (10Ritu Swain) [16:30:52] Corruption alert: visualeditor-needcheck on rowiki: https://ro.wikipedia.org/?diff=8842696 [16:30:52] Corruption alert: visualeditor-needcheck on mediawikiwiki: https://www.mediawiki.org/?diff=1185634 [16:30:52] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107717031 [16:30:52] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32773496 [16:30:52] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32773505 [16:30:52] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32773515 [16:30:53] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40140018 [16:30:53] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40140023 [16:30:53] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40140232 [16:30:54] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40140238 [16:30:54] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40140392 [16:30:55] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40144431 [16:45:29] (03PS2) 10Jforrester: Follow-up I99acd6c6: More files' header comment fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162659 [16:45:52] (03CR) 10Jforrester: "PS2 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162659 (owner: 10Jforrester) [16:46:50] (03CR) 10jenkins-bot: [V: 04-1] Follow-up I99acd6c6: More files' header comment fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162659 (owner: 10Jforrester) [16:47:16] Krinkle|detached: ^^^^ Could you poke jenkins to work out why karma never returns? [16:57:38] MatmaRex: "This is awful. Let's do it anyway."? :-) [16:58:10] well? it is. :P [16:58:30] (03PS40) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [16:58:37] 3VisualEditor / 3MediaWiki integration: VisualEditor: Incompatibility with Special:Preferences#mw-prefsection-editing item, "Edit pages on double click (requires JavaScript)" - 10https://bugzilla.wikimedia.org/53058#c6 (10James Forrester) 5PATC>3ASSI Is this now fixed given the above being merged? [16:58:59] (03Abandoned) 10Jforrester: DO NOT MERGE: Annotation tests proof of concept. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121284 (owner: 10Divec) [16:59:52] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [17:15:23] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In media dialog, "Size values are invalid" message does not show up, when choosing a different image and then setting its size to 0 x 0 px - 10https://bugzilla.wikimedia.org/70861#c11 (10Ritu Swain) When the image size is default, inserting a n... [17:17:18] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162659 (owner: 10Jforrester) [17:20:53] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162884 (https://bugzilla.wikimedia.org/71187) (owner: 10Esanders) [17:20:59] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162892 (owner: 10Esanders) [17:21:03] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162904 (https://bugzilla.wikimedia.org/71139) (owner: 10Esanders) [17:21:10] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [17:26:58] (03CR) 10Catrope: [C: 032] Follow-up I99acd6c6: More files' header comment fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162659 (owner: 10Jforrester) [17:28:30] (03Merged) 10jenkins-bot: Follow-up I99acd6c6: More files' header comment fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162659 (owner: 10Jforrester) [17:32:03] (03CR) 10Catrope: [C: 04-1] "PS23 rebases an old version, unfixing a bunch of stuff others fixed, without addressing any comments. I'll fix it" [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [17:32:57] (03PS24) 10Jforrester: [BREAKING CHANGE] Create a MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [17:33:11] (03CR) 10Jforrester: "PS24 is PS22 rebased onto master." [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [17:36:40] * RoanKattouw wonders wtf happened with https://fr.wikipedia.org/?diff=107717031 [17:36:51] That's IE-style style attribute corruption [17:37:01] RoanKattouw: Cached code? [17:37:59] Maybe? But it seems unlikely after this long [17:41:08] Never underestimate caches. [17:41:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf21] Editor is displayed with two toolbars on second initialisation - 10https://bugzilla.wikimedia.org/70768#c21 (10Rummana Yasmeen) verified the backport in test2 [17:44:11] James_F: I've been thinking (also because Rummana was asking), we should have instrumentation for browser version prevalence (what % of VE edits are IE11?), maybe also abuse that to track how many clients are running outdated code [17:44:53] RoanKattouw: That'd be helpful, though I believe there are PII issues about UA strings (!) so we'd need to check what's allowed. [17:46:22] Right [17:46:48] (03PS1) 10Jforrester: [BrowserTests] Put automatic language screenshots in more specific category [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162929 [17:47:23] So presumably we'd need to do something like process the UA strings into generic browser identifiers (like "Firefox 32") then forget the original UA strings? [17:47:53] * James_F nods. [17:48:23] Or use $.client if it's good enough [17:48:26] It's not. [17:48:41] Also, we've put a huge amount of development time into "the one true UA parser". [17:48:43] We should just use that. [17:51:40] 3MediaWiki extensions / 3Cite: Edit preview doesn't let you preview cite.php footnotes. - 10https://bugzilla.wikimedia.org/5984#c25 (10Gadget850) 5PATC>3NEW Since the patch is abandoned, I am changing the status to NEW. [17:55:59] $.client isn't good enough? [17:57:23] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf 22] Inspector loses it UI after scrolling down the page and clicking somewhere else in the document - 10https://bugzilla.wikimedia.org/71153#c5 (10Rummana Yasmeen) Verified the backport in test2 [17:58:46] MatmaRex_: Apparently not. [17:59:05] how so? [17:59:12] what's missing / broken? [18:02:54] 3MediaWiki / 3ResourceLoader: ResourceLoader: 'languageScripts' in the file module should look for fallback languages - 10https://bugzilla.wikimedia.org/58139 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) [18:03:23] 3MediaWiki extensions / 3TemplateData: TemplateData: add tooltip/quick link to TD help page near new TD editor button - 10https://bugzilla.wikimedia.org/67621#c5 (10James Forrester) Have pointed it to https://www.mediawiki.org/wiki/Help:TemplateData instead – hope that's OK. [18:06:22] MatmaRex_: I don't know, I just trust Analytics. [18:06:41] heh. [18:06:49] i also never heard of "the one true UA parser", what/where's that? [18:06:58] Somewhere in Analytics land. [18:07:11] meh [18:07:42] Probably written in Python. [18:08:16] double meh. [18:08:50] James_F: Yeah we should use Oliver's uaparser [18:08:55] 3VisualEditor / 3ContentEditable: VisualEditor: Inserting a comment before the last word in a Language (RTL direction)Text moves the word to the start of the line. - 10https://bugzilla.wikimedia.org/71320 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Environment-test2, beta 1> Insert Language in R... [18:09:07] 3VisualEditor / 3ContentEditable: VisualEditor: Inserting a comment before the last word in a Language (RTL direction)Text moves the word to the start of the line. - 10https://bugzilla.wikimedia.org/71320 (10Ritu Swain) [18:09:08] RoanKattouw: Good luck porting that to client-side scraping. [18:09:39] Yeah no [18:09:55] Someone asked Oliver and he was like NOPE [18:10:04] You want instead to intercept the EventLogging calls server-side and parse them there? [18:11:36] (03CR) 10Catrope: [C: 04-1] Be more cautious about placing the cursor (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162884 (https://bugzilla.wikimedia.org/71187) (owner: 10Esanders) [18:11:38] 3VisualEditor / 3ContentEditable: VisualEditor: Inserting a comment before the last word in a Language (RTL direction)Text moves the word to the start of the line. - 10https://bugzilla.wikimedia.org/71320#c1 (10Ritu Swain) http://youtu.be/6vtjey9UcCU [18:30:17] (03CR) 10Catrope: [C: 032] Fix some getSelectionRects edge cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162892 (owner: 10Esanders) [18:31:40] (03Merged) 10jenkins-bot: Fix some getSelectionRects edge cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162892 (owner: 10Esanders) [18:37:24] 3MediaWiki extensions / 3TemplateData: TemplateData: add tooltip/quick link to TD help page near new TD editor button - 10https://bugzilla.wikimedia.org/67621#c6 (10Elitre) 5REOP>3RESO/FIX Looks like it is. Thanks! [18:46:47] Krinkle, RoanKattouw, Trevor: http://knockoutjs.com/documentation/component-binding.html [18:47:08] (03CR) 10Esanders: Be more cautious about placing the cursor (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162884 (https://bugzilla.wikimedia.org/71187) (owner: 10Esanders) [18:47:11] haven't looked at what all the other frameworks have done recently [19:00:09] 3VisualEditor / 3Data Model: VisualEditor: [Regression pre wmf1] Increasing indentation to a bullet/numbered list is also adding a slug with a new bullet/numbered point each time - 10https://bugzilla.wikimedia.org/71134#c3 (10Rummana Yasmeen) Created attachment 16592 --> https://bugzilla.wikimedia.org/atta... [19:48:33] ok, another question [19:51:01] watching parsoid's error log and seeing a count down: [warning/api][localhost/PowerCalculator] Failed API request, 7 retries remaining. [19:51:04] James_F, hashar https://commons.wikimedia.org/wiki/Category:VisualEditor-ja :-) [19:51:28] Japanese auto created screenshots [19:51:30] and then the next one seems to be the parse, but VE has already given out :( [19:52:41] any clues on speeding it up? [19:54:35] hexmode: the MW API used by parsoid seems to have issues [19:55:07] gwicke: :( so... anything I can do? [19:55:45] it worked better on REL1_23... [19:56:12] * hexmode doesn't want to roll back... would rather roll forward [20:12:03] hexmode: first I'd check that your wiki / API actually works at all [20:12:21] https://www.mediawiki.org/wiki/Parsoid/Troubleshooting [20:15:55] RoanKattouw, did you read -1 as 1? [20:17:31] Oooh maybe? [20:17:38] Yeah I'm blind [20:20:46] (03PS1) 10Alex Monk: Stop "Edit pages on double click" from affecting VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162968 (https://bugzilla.wikimedia.org/53058) [20:27:20] (03CR) 10Catrope: [C: 032] Be more cautious about placing the cursor (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162884 (https://bugzilla.wikimedia.org/71187) (owner: 10Esanders) [20:28:50] (03Merged) 10jenkins-bot: Be more cautious about placing the cursor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162884 (https://bugzilla.wikimedia.org/71187) (owner: 10Esanders) [20:48:21] 3VisualEditor / 3Data Model: VisualEditor: [Regression pre wmf1] Increasing indentation to a bullet/numbered list is also adding a slug with a new bullet/numbered point each time - 10https://bugzilla.wikimedia.org/71134#c4 (10Ed Sanders) I think it makes sense to have a slug there, as a double indented list... [21:17:56] hmm. have weird editing bugs on en wiki, but I don't have debug = true set and I'm not sure if I can replicate if I refresh. no errors getting logged to console. anything I can do to figure out what's going on? [21:18:09] on adding a link to some text, it duplicated further up the range [21:18:18] I thought maybe I just accidentally hit some keys [21:18:31] but now if I try to highlight and delete the insert text it doesn't work [21:18:38] but it does work if I hit backspace one by one [21:18:42] so thinking range issues. [21:19:19] *duplicated text that was before the thing I was added a link to [21:19:57] argh words. [21:23:24] aaand now it is behaving very strangely. The history hasn't been recorded right. :( [21:27:07] (03PS1) 10Jforrester: Re-label "Manage template documentation" to "Manage TemplateData" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/163028 (https://bugzilla.wikimedia.org/63389) [21:27:13] (03PS1) 10Jforrester: Let help link target be locally over-ridden; default to the MW help page [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/163029 (https://bugzilla.wikimedia.org/67621) [21:28:23] mvolz: I have heard anecdotal reports from people and even seen it a few times on other people's machines [21:28:29] But I haven't yet identified what triggers it [21:28:39] Also, holy crap mvolz is alive :P [21:28:53] mvolz: You'll hopefully be happy to know that I'm working on putting Citoid in production [21:28:54] (03CR) 10Alex Monk: [C: 032] Clean up various PHP hook functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162826 (owner: 10Legoktm) [21:28:58] Are you doing any work on Citoid these days? [21:31:54] (03Merged) 10jenkins-bot: Clean up various PHP hook functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162826 (owner: 10Legoktm) [21:36:55] RoanKattouw: you are??? [21:36:57] awesome! [21:37:13] about a week ago I got my first pull request and merged it [21:37:28] also fixed up an old commit [21:37:56] and added more docs accordingly :P mediawiki.org/wiki/Citoid/API [21:38:03] woo export formats. [21:38:19] pull request? [21:38:22] Is this in github or in Gerrit? [21:38:36] gerrit [21:38:40] but I can't speak gerrit [21:38:55] i can only communicate it github speak. alas. [21:40:08] 3VisualEditor / 3Data Model: VisualEditor: [Regression] When an image is the first item of the document , trying to delete it right after opening VE throws "Error: offset was inside a handlesOwnChildren node" - 10https://bugzilla.wikimedia.org/71187 (10James Forrester) 5PATC>3RESO/FIX [21:40:08] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf21] Editor is displayed with two toolbars on second initialisation - 10https://bugzilla.wikimedia.org/70768#c22 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:40:24] OK that's fine [21:40:26] Just checking :) [21:40:36] I was thinking of writing some patches for Citoid soonish [21:40:53] I need it to have like a welcome page at / because the health checks need it [21:41:09] sweet [21:41:28] Which is why I was asking how much you're working on it, because if you're still active there then maybe you can take some of that work off my hands [21:41:33] haha [21:41:42] well, ask James_F ;) [21:41:53] what does the welcome page need? [21:41:57] just, to exist? [21:42:01] Yeah [21:42:09] okay can do. [21:42:17] I just need a request to http://localhost:12345/ (or whatever the port number is) to not return an error [21:42:26] :1970 sorry [21:42:51] yeah np [21:43:05] As for what you put there, it should probably eventually be somewhat useful but right now I don't care as long as it's an HTTP 200 status code [21:43:41] Our load balancers will be hitting it periodically to check that the service is still alive [21:43:54] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf20] The link target suggestion drop down is appearing cut off to a very small size upon first time opening the link inspector - 10https://bugzilla.wikimedia.org/70683#c4 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production for deskt... [21:47:06] 3VisualEditor / 3MediaWiki integration: VisualEditor: Switch to source editing dialog too tall - 10https://bugzilla.wikimedia.org/70317#c3 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:48:59] (03CR) 10Jforrester: [C: 032] Prevent exception throwing in getFilename of MWImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162694 (owner: 10Esanders) [21:49:08] 3VisualEditor / 3Editing Tools: VisualEditor: Insert > References list is very large in Firefox - 10https://bugzilla.wikimedia.org/70545#c4 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:49:52] 3VisualEditor / 3Editing Tools: VisualEditor: Add a shortcut for strikethrough (?which?) - 10https://bugzilla.wikimedia.org/60257#c9 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:50:44] (03Merged) 10jenkins-bot: Prevent exception throwing in getFilename of MWImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162694 (owner: 10Esanders) [21:51:21] 3VisualEditor / 3Editing Tools: VisualEditor: Shrink back the Basic Reference dialog size - 10https://bugzilla.wikimedia.org/70016#c6 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:51:51] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Cancel" button in the Save dialog is confusing. How about "Resume editing"? - 10https://bugzilla.wikimedia.org/69116#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:52:38] 3VisualEditor / 3ContentEditable: VisualEditor: Mouse up outside the surface doesn't register a selection change. - 10https://bugzilla.wikimedia.org/59822#c9 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:55:33] (03CR) 10Catrope: [C: 032] Don't perform focus node native selection trick while dragging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162904 (https://bugzilla.wikimedia.org/71139) (owner: 10Esanders) [21:56:08] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843#c13 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:57:21] (03Merged) 10jenkins-bot: Don't perform focus node native selection trick while dragging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/162904 (https://bugzilla.wikimedia.org/71139) (owner: 10Esanders) [21:58:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: Switching to source mode should show a spinner, pending state or similar - 10https://bugzilla.wikimedia.org/65012#c7 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [22:01:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] The Cite and Re-use options remains enabled even if the toolbar gets disabled when user clicks outside - 10https://bugzilla.wikimedia.org/70870#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [22:04:37] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog should recommend TemplateData-hinted mandatory parameters - 10https://bugzilla.wikimedia.org/50747#c23 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [22:05:54] 3VisualEditor / 3Editing Tools: VisualEditor: Add keyboard shortcut for code element/style - 10https://bugzilla.wikimedia.org/52597#c6 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [22:16:24] woah, what [22:16:46] RoanKattouw, https://www.mediawiki.org/w/api.php?action=query&generator=allcategories&gacprefix=R&prop=categoryinfo&redirects= [22:17:00] The error I get for this on my wiki is Notice: Undefined offset: 8 in /home/alex/Development/MediaWiki/includes/api/ApiQueryCategoryInfo.php on line 52 [22:17:06] Fatal error: Call to a member function getDBkey() on a non-object in /home/alex/Development/MediaWiki/includes/api/ApiQueryCategoryInfo.php on line 53 [22:17:29] wtf [22:17:41] (this isn't affecting VE in master or production or anything, just something I was working on) [22:18:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In Safari, Cannot enter any input in any dialog and VE gets unresponsive after trying to do that - 10https://bugzilla.wikimedia.org/70578#c7 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [22:18:18] (03PS1) 10Esanders: Fix getUsedStoreValues and allow a range to be passed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163042 [22:20:53] 3VisualEditor / 3Initialisation: VisualEditor: [Regression wmf 21] “Uncaught TypeError: Cannot read property 'top' of undefined” when Editor is launched - 10https://bugzilla.wikimedia.org/70770#c12 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [22:22:53] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] Cannot open any inspector, throwing error "Uncaught TypeError: Cannot read property 'top' of undefined" - 10https://bugzilla.wikimedia.org/70782#c3 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [22:24:22] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf 22] Selection does not work while trying to select multiples lines after dragging the selection horizontally over a focusable node - 10https://bugzilla.wikimedia.org/71139 (10James Forrester) 5PATC>3RESO/FIX [22:28:26] (03PS41) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [22:29:54] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [22:30:52] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it - 10https://bugzilla.wikimedia.org/71131#c10 (10Rummana Yasmeen) Verified the fix in test2 [22:38:22] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] Comment box is not opening in Betalabs - 10https://bugzilla.wikimedia.org/71246#c6 (10Rummana Yasmeen) Verified the fix in test2 [22:39:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] Link button does nothing - 10https://bugzilla.wikimedia.org/71237#c6 (10Rummana Yasmeen) verified the fix in test2 [22:42:47] (03CR) 10Catrope: [C: 032] Stop "Edit pages on double click" from affecting VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162968 (https://bugzilla.wikimedia.org/53058) (owner: 10Alex Monk) [22:44:06] 3VisualEditor / 3MediaWiki integration: VisualEditor: Incompatibility with Special:Preferences#mw-prefsection-editing item, "Edit pages on double click (requires JavaScript)" - 10https://bugzilla.wikimedia.org/53058 (10Alex Monk) 5PATC>3RESO/FIX [22:48:06] (03PS1) 10Jforrester: Update VE core submodule to master (6012dc5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163050 [22:49:22] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (6012dc5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163050 (owner: 10Jforrester) [22:49:57] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Clicking in the document where an inspector was opened doesn't close the inspector - 10https://bugzilla.wikimedia.org/68679 (10James Forrester) [22:49:57] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] When the inspector is still open for a selected node, after placing the cursor in a different position, inspector flickers there - 10https://bugzilla.wikimedia.org/71151 (10James Forrester) [22:49:57] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In media dialog, "Size values are invalid" message does not show up, when choosing a different image and then setting its size to 0 x 0 px - 10https://bugzilla.wikimedia.org/70861 (10James Forrester) [22:49:57] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - 10https://bugzilla.wikimedia.org/66604 (10James Forrester) [22:49:58] 3VisualEditor / 3MediaWiki integration: VisualEditor: After saving a page reference list gets missing (unless it is refreshed again) and the page gets categorized as "Pages with missing reference list" - 10https://bugzilla.wikimedia.org/68182 (10James Forrester) [22:50:07] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10James Forrester) [22:50:19] 3VisualEditor / 3Editing Tools: VisualEditor: Do not let me tab outside the dialog box in Chrome/Safari - 10https://bugzilla.wikimedia.org/67156 (10James Forrester) [22:50:19] 3VisualEditor / 3MediaWiki integration: VisualEditor: Link existence checker in LinkTargetInputWidget doesn't work for interwikis, language links - 10https://bugzilla.wikimedia.org/70504 (10James Forrester) [22:50:19] 3VisualEditor / 3ContentEditable: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - 10https://bugzilla.wikimedia.org/69474 (10James Forrester) [22:50:20] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10James Forrester) [22:50:21] 3VisualEditor / 3Editing Tools: VisualEditor: In the media insertion dialog, give a tooltip on each item saying what will happen when you click it (i.e., "Click to insert as a thumbnail" or whatever) - 10https://bugzilla.wikimedia.org/52219 (10James Forrester) [22:50:22] 3VisualEditor / 3Editing Tools: VisualEditor: In the media selector show name in a tooltip on mouseover - 10https://bugzilla.wikimedia.org/52459 (10James Forrester) [22:50:23] 3VisualEditor / 3Editing Tools: VisualEditor: Support "substituting" templates in transclusion dialog - 10https://bugzilla.wikimedia.org/49904 (10James Forrester) [22:50:24] 3VisualEditor / 3Editing Tools: VisualEditor: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - 10https://bugzilla.wikimedia.org/68590 (10James Forrester) [22:50:25] 3VisualEditor / 3Editing Tools: VisualEditor: There should be help links in every context - dialog boxes, inspectors, etc. - 10https://bugzilla.wikimedia.org/51798 (10James Forrester) [22:50:34] 3VisualEditor / 3Data Model: VisualEditor: tags appear when editing on the Hebrew Wiki - 10https://bugzilla.wikimedia.org/66210 (10James Forrester) [22:50:34] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195 (10James Forrester) [22:50:34] 3VisualEditor / 3ContentEditable: VisualEditor: Up/down arrow in Firefox broken after using left/right - 10https://bugzilla.wikimedia.org/70724 (10James Forrester) [22:50:34] 3VisualEditor / 3Data Model: VisualEditor: Make transaction processing exception-safe - 10https://bugzilla.wikimedia.org/68892 (10James Forrester) [22:50:35] 3VisualEditor / 3Editing Tools: VisualEditor: Reference group input combo box does not populate the Reference group names if created from Reference list dialog - 10https://bugzilla.wikimedia.org/70365 (10James Forrester) [22:50:36] 3VisualEditor / 3Data Model: VisualEditor: [Regression pre wmf1] Increasing indentation to a bullet/numbered list is also adding a slug with a new bullet/numbered point each time - 10https://bugzilla.wikimedia.org/71134 (10James Forrester) [22:50:37] 3VisualEditor / 3Editing Tools: VisualEditor: Highlight missing parameters in template dialog when complaining about them - 10https://bugzilla.wikimedia.org/70957 (10James Forrester) [22:50:38] 3VisualEditor / 3Editing Tools: VisualEditor: Append references list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906 (10James Forrester) [22:50:39] 3VisualEditor / 3Editing Tools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - 10https://bugzilla.wikimedia.org/68537 (10James Forrester) [22:50:43] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10James Forrester) [22:50:43] 3VisualEditor / 3Data Model: VisualEditor: Investigate parsing/rendering/behavior of "{{MW 1.23}}" on mediawiki.org [mini-tracking] - 10https://bugzilla.wikimedia.org/68297 (10James Forrester) [22:50:44] 3VisualEditor / 3ContentEditable: VisualEditor: Deleting from an empty paragraph to the end of an inline node throws an exception - 10https://bugzilla.wikimedia.org/70375 (10James Forrester) [22:50:44] 3VisualEditor / 3Mobile: VisualEditor Mobile: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110 (10James Forrester) [22:52:22] (03Merged) 10jenkins-bot: Stop "Edit pages on double click" from affecting VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162968 (https://bugzilla.wikimedia.org/53058) (owner: 10Alex Monk) [22:52:25] (03Merged) 10jenkins-bot: Update VE core submodule to master (6012dc5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163050 (owner: 10Jforrester) [22:59:37] 3VisualEditor / 3Data Model: VisualEditor: [Regression pre wmf1] Increasing indentation to a bullet/numbered list is also adding a slug with a new bullet/numbered point each time - 10https://bugzilla.wikimedia.org/71134#c5 (10James Forrester) (In reply to Ed Sanders from comment #4) > I think it makes sense... [23:02:24] 3VisualEditor / 3Editing Tools: VisualEditor: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - 10https://bugzilla.wikimedia.org/68590#c6 (10Bartosz Dziewoński) To be clear, I suggest WONTFIX. The orig... [23:07:06] (03PS42) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [23:08:58] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [23:33:17] (03PS43) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [23:34:43] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [23:43:52] 3VisualEditor / 3Data Model: VisualEditor: [Regression] When an image is the first item of the document , trying to delete it right after opening VE throws "Error: offset was inside a handlesOwnChildren node" - 10https://bugzilla.wikimedia.org/71187#c4 (10Rummana Yasmeen) Verified the fix in Betalabs [23:55:16] RoanKattouw, I'm confused about your comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=71178 [23:55:53] Do you mean that the widget needs to mixin LookupInputWidget for config.$overlay to work? [23:56:06] Oh, a ComboBoxWidget doesn't? [23:56:23] Oh it has a this.menu instead [23:56:25] Sorry [23:56:26] OK let me see here [23:56:41] you can pass $overlay through to the menu or input widgets [23:57:01] But where do I get the surface's localOverlay from? [23:57:11] No that doesn't work, MenuWidget doesn't take one [23:57:23] $overlay is used by LookupInputWidget to decide what to append the MenuWidget to [23:57:46] So, it looks like you need to do some additional rigging [23:58:26] I think ComboBox needs to take a $overlay parameter just like LookupInputWidget. I don't know why the menu is being appended to this.$element right now, it feels like that shouldn't happen [23:59:31] Although, wait, no... [23:59:35] Trevor why did you build this this way