[00:00:00] $overlay is a concept specific to TextInputMenuWidget? Ugh [00:00:27] Though I guess for a ComboBoxWidget that would actually not be a problem because theres' a text input there [00:00:50] Krenair: OK so I think I understand now [00:01:00] ComboBoxWidget needs to be refactored to use TextInputMenuWidget instead of MenuWiidget [00:01:26] (this is probably partly my fault) [00:01:38] TIMW takes a reference to a TextInputWidget (this.input) and automatically renders itself below that input, no matter where in the DOM you put it [00:02:10] So then ComboBoxWidget can take a $overlay which defaults to body or something, and it appends the TIMW to $overlay. This is what LookupInputWidget does [00:02:25] Then ReferenceListDialog can override $overlay to be surface.getLocalOverlay().$element or whatever [00:03:47] "which defaults to body or something" = this.$overlay = config.$overlay || this.$( 'body,.oo-ui-window-overlay' ).last(); [00:03:56] from LookupInputWidget [00:04:00] Krenair: Does this sound sensible? [00:05:25] I think so. [00:44:17] (03PS44) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [00:45:24] 3VisualEditor / 3Data Model: VisualEditor: In the Re-use reference dialog, search is not returning correct results on the second initialization for a specific case - 10https://bugzilla.wikimedia.org/70886#c16 (10Alex Monk) 5RESO/INV>3REOP It does look like this is valid then, I think. [02:44:40] (03CR) 10Catrope: [C: 04-1] "Looks fine, but has a typo" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162529 (owner: 10Krinkle) [02:45:54] (03CR) 10Catrope: [C: 032] Fix getUsedStoreValues and allow a range to be passed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163042 (owner: 10Esanders) [02:47:00] (03CR) 10Catrope: [C: 032] Remove test for functionality tested in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161346 (owner: 10Esanders) [02:47:18] (03PS3) 10Catrope: Use mw.Title#getRelativeText to deal with titles relative to specific namespaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162015 (owner: 10Alex Monk) [02:47:37] (03Merged) 10jenkins-bot: Fix getUsedStoreValues and allow a range to be passed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163042 (owner: 10Esanders) [02:47:43] (03CR) 10Catrope: [C: 032] Use mw.Title#getRelativeText to deal with titles relative to specific namespaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162015 (owner: 10Alex Monk) [02:48:57] (03CR) 10jenkins-bot: [V: 04-1] Remove test for functionality tested in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161346 (owner: 10Esanders) [02:49:53] (03CR) 10Catrope: [C: 032] Remove test for functionality tested in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161346 (owner: 10Esanders) [02:50:44] (03Merged) 10jenkins-bot: Use mw.Title#getRelativeText to deal with titles relative to specific namespaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162015 (owner: 10Alex Monk) [02:51:34] (03Merged) 10jenkins-bot: Remove test for functionality tested in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161346 (owner: 10Esanders) [08:06:52] (03CR) 10Zfilipin: [C: 031] [BrowserTests] Put automatic language screenshots in more specific category [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162929 (owner: 10Jforrester) [12:30:59] Hi ! I am a PhD student working on an editor for comparison tables (e.g. https://en.wikipedia.org/wiki/Comparison_of_Nikon_DSLR_cameras). Wikipedia is my favorite playground and I would like to see if I can contribute directly to the Visual editor. [13:00:06] gbecan: sure you can. do you have any questions in particular? [13:00:37] gbecan: most of the instructions from https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker apply to VisualEditor too, if you're looking for a guide [13:01:03] (although VE can run independently of MW, too) [13:01:16] Well, I dont know if what we are planning to do with our editor will match the requirements of the development of VisualEditor [13:02:00] our code is managed in git, like MediaWiki, and our bugs are in Bugzilla, like MediaWiki [13:02:44] Thanks for all the information. [13:03:05] Do you think that VisualEditor would benefit from a specialized table editor? [13:03:40] it probably would, and i think someone is already working on one [13:04:08] Ok nice. [13:04:22] gbecan: you can look at https://gerrit.wikimedia.org/r/#/c/159317/ and previos patches for a proof-of-concept / demo [13:04:34] i'm not sure what the current status is, but it mostly worked when i tried it :) [13:05:20] :) thanks it saves me a lot of search ! [13:06:18] I will read and analyze everything you gave me to see if contributing to the editor is a good thing for our research and the community [13:08:49] I hope we can help! Thanks again [15:00:25] 3VisualEditor / 3Editing Tools: VisualEditor: In the media selector show name in a tooltip on mouseover - 10https://bugzilla.wikimedia.org/52459#c3 (10Bartosz Dziewoński) a:5Moriel Schottlender>3Bartosz Dziewoński Since no one disagrees, I'm going to make that happen. [15:03:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf22] Resizing the window adds an extra padding below the "Choose a different image" button in Media Settings dialog - 10https://bugzilla.wikimedia.org/70895#c1 (10Bartosz Dziewoński) This happens when the window is small enough that the dialog has t... [15:44:47] MatmaRex: Umm. Don't fiddle with the media dialog. It's being completely re-written by Moriel. [15:45:37] oh? [15:45:56] grumble. fiddling with it has been going rather well. [15:47:14] Well, talk to her first, at least. :-) [15:47:54] 3VisualEditor / 3Editing Tools: VisualEditor: In the media selector show name in a tooltip on mouseover - 10https://bugzilla.wikimedia.org/52459#c4 (10Bartosz Dziewoński) a:5Bartosz Dziewoński>3Moriel Schottlender Or not. [16:11:06] (03PS1) 10Vikassy: [BrowserTest] Fixed failing language screenshot scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163185 [16:30:51] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107753327 [16:30:51] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32783045 [16:30:51] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32783397 [16:30:51] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32785498 [16:30:51] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32785538 [16:30:52] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32789017 [16:30:52] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32789247 [16:30:53] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=68336820 [16:30:53] Corruption alert: visualeditor-needcheck on enwiki: https://en.wikipedia.org/?diff=627076106 [16:33:28] So, I think I borked my parsoid. When it tries to parse widgets this is what it tells me: Parser function implementation for pf_#widget missing in Parsoid. [16:44:11] Now it shows ENCODED_CONTENT and a bunch of gibberish. Poo. [16:56:53] RoanKattouw_away: you're all set: https://gerrit.wikimedia.org/r/#/c/163192/. lmk if you need anything else, feel free to pm [17:08:31] (03PS2) 10Zfilipin: [BrowserTest] Fixed failing language screenshot scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163185 (https://bugzilla.wikimedia.org/71298) (owner: 10Vikassy) [17:11:00] (03CR) 10Zfilipin: [C: 031] [BrowserTest] Fixed failing language screenshot scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163185 (https://bugzilla.wikimedia.org/71298) (owner: 10Vikassy) [17:11:31] (03CR) 10Zfilipin: "Not sure why, but I do not have +2 on this repository. :(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163185 (https://bugzilla.wikimedia.org/71298) (owner: 10Vikassy) [17:35:57] mvolz: Thanks [17:47:59] http://gruntjs.com/using-the-cli [17:49:17] (03CR) 10Jforrester: [C: 032] "@Zfilipin: LDAP's having issues, sadly." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163185 (https://bugzilla.wikimedia.org/71298) (owner: 10Vikassy) [17:49:26] (03PS3) 10Jforrester: [BrowserTest] Fixed failing language screenshot scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163185 (https://bugzilla.wikimedia.org/71298) (owner: 10Vikassy) [17:58:51] (03CR) 10Jforrester: [C: 032] "(Try again.)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163185 (https://bugzilla.wikimedia.org/71298) (owner: 10Vikassy) [18:00:40] (03Merged) 10jenkins-bot: [BrowserTest] Fixed failing language screenshot scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163185 (https://bugzilla.wikimedia.org/71298) (owner: 10Vikassy) [18:22:10] 3MediaWiki extensions / 3TemplateData: WikEd is not compatible with the TemplateData editor: TemplateData is not saved - 10https://bugzilla.wikimedia.org/71363 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None There's a report here: https://en.wikipedia.org/w/index.php?diff=627177867&oldid=627175358... [18:27:21] 3MediaWiki extensions / 3TemplateData: WikEd is not compatible with the TemplateData editor: TemplateData is not saved - 10https://bugzilla.wikimedia.org/71363#c1 (10James Forrester) Gadget bugs aren't tracked in Bugzilla per community request (though it's going to be worth reviewing that in the light of Ph... [18:33:25] hmph [18:33:28] why is PopupWidget clippable? [18:33:44] is was made so fairly recently (https://gerrit.wikimedia.org/r/#/c/120616/) with no explanation nor bug [18:39:25] 3VisualEditor: VisualEditor: Typing more words into a ==Section heading== adds them into the next line - 10https://bugzilla.wikimedia.org/71364 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None See https://office.wikimedia.org/w/index.php?diff=118520&oldid=118519 This was all supposed to be on one li... [18:39:51] MatmaRex: Why would it not be Clippable? [18:40:21] Clipping for all the things. [18:40:28] The reason I made it clippable is because of frwiki's new page creation edit notice [18:40:35] It's gigantic [18:40:43] and it was making the edit notice popup bigger than the screen [18:40:49] RoanKattouw: oh [18:40:52] Well, taller [18:40:57] RoanKattouw: i'm trying to make it scroll-into-view-able, for inspectors [18:41:01] and it's acting funny [18:41:08] https://bugzilla.wikimedia.org/show_bug.cgi?id=52526 [18:41:44] http://i.imgur.com/tMBO8h8.png [18:45:58] Right [18:46:51] Well yeah since it's clippable you can't scroll down to see the whole thing [18:47:45] But I guess you could call .setClipping( false ) on it? [18:47:59] .toggleClipping( false ) sorry [18:49:49] hm. [18:56:35] (03PS1) 10Jforrester: Move IE10 to the greylist too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163223 [18:58:25] (03CR) 10jenkins-bot: [V: 04-1] Move IE10 to the greylist too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163223 (owner: 10Jforrester) [19:00:30] by the way, PopupWidget#scrollElementIntoView doesn't actually work because the element with the content is not .$element, but .$popup. bleh. [19:00:54] (03PS25) 10Trevor Parscal: [BREAKING CHANGE] Create a MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 [19:02:02] Ugh [19:02:38] 3VisualEditor / 3Data Model: VisualEditor: Undoing a change of group on a reference throws "Uncaught TypeError: Cannot read property 'length' of undefined" - 10https://bugzilla.wikimedia.org/69119 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Low [19:04:11] i'm not sure if that's intentional / should be changed? [19:05:20] Yeah that should probably be overridden in PopupWidget [19:05:53] RoanKattouw: you mean scrollElementIntoView() overridden to use $popup, or the internals rejiggered? [19:07:06] hmm [19:08:31] The latter I think [19:09:38] actually it needs like it could be solved neatly with CSS [19:09:55] right now $element (.oo-ui-popupWidget) is always 0x0, because all of its children are positioned [19:11:06] You know if only Trevor was on IRC... [19:11:25] we could position $element itself instead, maybe? [19:13:00] sup TrevorParscal [19:13:11] howdy man [19:13:19] I'm just finishing up this theme patch [19:13:20] TrevorParscal: why is PopupWidget's $element not absolutely positioned, but its $popup is instead? (child of $element) [19:13:46] $element is always 0x0 because of that, which is annoying [19:13:55] ok [19:13:58] can i change this or would the world explode? [19:14:03] so, this is something I'm totally open to changing [19:14:29] the reason it works this way is that PopupElement is "an element with a popup in it" [19:14:49] so, you have a PopupWidget that mixes in PopupElement (and doesn't do much else) [19:14:52] (my actual problem is that i can't scroll the popup into view without reaching inside it for the $popup) [19:15:12] hold on... i got this backwards [19:15:53] ok... right... PopupElement actually embeds a PopupWidget (because that makes sense...?) [19:16:03] there are reasons for it, but yeah.. look away.. [19:16:06] um.. [19:16:49] ah [19:16:53] ok, it's because of the anchor [19:17:10] we wanted the anchor and the popup box to share a parent [19:17:17] for positioning purposes [19:17:43] I think it's possible we could do it differently, but be aware of CSS selectors targeting these different elements [19:17:56] yeah [19:18:20] but, right now, it seems that the popup body is being positioned in relation to the anchor manually anyway, in JS [19:18:29] couldn't we just position the anchor in relation to the popup? [19:18:46] i think yes [19:18:57] and I encourage you to see if it's possible [19:19:20] it should be… it'll just take some poking [19:22:03] (03PS1) 10Bartosz Dziewoński: [WIP] DesktopContext: Ensure that inspectors/menus are fully visible when created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163228 (https://bugzilla.wikimedia.org/52526) [19:25:14] (03PS1) 10Bartosz Dziewoński: ve.ui.DesktopContext: Fix comment typo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163229 [19:25:46] (03CR) 10jenkins-bot: [V: 04-1] [WIP] DesktopContext: Ensure that inspectors/menus are fully visible when created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163228 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński) [19:26:26] MatmaRex, indicator patch looks good. While we don't need to have VE support out of the box, we will need to move or hide the indicators on VE load [19:26:37] look at the code handling 'firstHeading' in ve.init.mw.ViewPageTarget.js [19:26:49] currently the indicators are pushing the edit bar down [19:26:57] edsanders: yep, but that'll be easy, no? [19:27:21] Yes, I'm glad you agree :) [19:27:41] edsanders: then they can probably be handled as meta items or something… i'll probably need to leave this part to someone else ;) [19:28:00] yes- we'll need some Parsoid handling [19:29:25] but the hiding/moving we can prepare a patch for now [19:37:22] (03CR) 10Jforrester: [C: 032] ve.ui.DesktopContext: Fix comment typo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163229 (owner: 10Bartosz Dziewoński) [19:38:50] (03CR) 10jenkins-bot: [V: 04-1] ve.ui.DesktopContext: Fix comment typo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163229 (owner: 10Bartosz Dziewoński) [19:56:24] (03PS2) 10Catrope: Move IE10 to the greylist too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163223 (owner: 10Jforrester) [20:01:19] (03CR) 10Jforrester: [C: 031] Move IE10 to the greylist too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163223 (owner: 10Jforrester) [20:33:05] Hey guys [20:33:15] do you know how to crash your browser using VE? [20:33:18] I can tell you :) [20:42:27] 3MediaWiki extensions / 3Cite: Cite: Markup before automatic reference list displays list style as unordered - 10https://bugzilla.wikimedia.org/68293#c2 (10Erwin Dokter) Any list type that occupies the last line will cause this. Definitely something funky... It changes the
    to simply <... [20:58:39] (03PS1) 10Inez: Fix for endless loop in SelectWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/163273 [21:18:47] (03CR) 10Catrope: [C: 032] Fix for endless loop in SelectWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/163273 (owner: 10Inez) [21:19:03] InezK: Whoooops [21:19:06] Thanks for that fix [21:19:32] RoanKattouw_away, where am I supposed to get a reference to Surface in ReferenceListDialog? [21:19:39] absolutely [21:19:50] (03Merged) 10jenkins-bot: Fix for endless loop in SelectWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/163273 (owner: 10Inez) [21:26:25] Krenair: Ahm, good question [21:27:43] Krenair: I think what you'd have to do is use this.manager.getOverlay() , and then make sure DesktopSurface#createDialogWindowManager passes in the local overlay [21:28:05] DesktopContext#createInspectorWindowManager already does this [21:28:44] (03PS2) 10Bartosz Dziewoński: DesktopContext: Ensure that inspectors/menus are fully visible when created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163228 (https://bugzilla.wikimedia.org/52526) [21:28:47] (03PS1) 10Bartosz Dziewoński: PopupWidget: Make $element not be a 0x0 box [oojs/ui] - 10https://gerrit.wikimedia.org/r/163280 (https://bugzilla.wikimedia.org/52526) [21:29:18] ugh [21:29:29] this took me way longer than it should. but i think it works [21:29:58] MatmaRex: Do you instead make it a 1x1 px box? :-) [21:30:45] (03CR) 10jenkins-bot: [V: 04-1] DesktopContext: Ensure that inspectors/menus are fully visible when created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163228 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński) [21:31:04] grrrrrh [21:31:42] is PhantomJS broken now? [21:32:20] RoanKattouw: PopupWidget calls toggleClipping(true) every time it's shown :( which makes sense for a clippable element i guess, but it's somewhat annoying here [21:32:44] RoanKattouw, okay, I guess it would help if DesktopSurface#createDialogWindowManager used ve.ui.WindowManager rather than the OO.ui parent class :) [21:33:09] 3OOjs UI: OOjs UI: Dialogs should not display below visible page area - 10https://bugzilla.wikimedia.org/52526 (10Bartosz Dziewoński) a:5Trevor Parscal>3Bartosz Dziewoński [21:56:38] 3MediaWiki extensions / 3TemplateData: WikEd is not compatible with the TemplateData editor: TemplateData is not saved - 10https://bugzilla.wikimedia.org/71363#c2 (10Andre Klapper) 5NEW>3RESO/INV WikEd is not an extension hence this is unfortunately out of scope for Bugzilla. Closing as INVALID as this... [22:05:10] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector UI gets broken if the link target suggestion dropdown overlaps with the border of the page - 10https://bugzilla.wikimedia.org/71371 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16609 --> https://bugzilla.wikimed... [22:16:49] (03PS3) 10Catrope: DesktopContext: Ensure that inspectors/menus are fully visible when created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163228 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński) [22:18:24] (03CR) 10jenkins-bot: [V: 04-1] DesktopContext: Ensure that inspectors/menus are fully visible when created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163228 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński) [22:26:12] 3VisualEditor / 3Editing Tools: [Regression wmf1] Link inspector does not close when clicking out into non-linked text - 10https://bugzilla.wikimedia.org/71373 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None 1. Open VisualEditor 2. Find or create a paragraph with a link followed by some non-linked... [22:35:53] 3MediaWiki / 3ResourceLoader: Using "/*@noflip*/ /*@embed*/" annotation doesn't work (although other combinations do) - 10https://bugzilla.wikimedia.org/69698#c7 (10Bartosz Dziewoński) 5PATC>3RESO/FIX Backported to 1.24 after all. [22:50:09] 3VisualEditor / 3Editing Tools: [Regression wmf1] Link inspector does not close when clicking out into non-linked text - 10https://bugzilla.wikimedia.org/71373#c1 (10Roan Kattouw) p:5Unprio>3High s:5normal>3major a:3Ed Sanders This broke in https://gerrit.wikimedia.org/r/#/c/162495/ , which made it... [22:51:28] (03CR) 10Catrope: [C: 032] PopupWidget: Make $element not be a 0x0 box [oojs/ui] - 10https://gerrit.wikimedia.org/r/163280 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński) [22:52:27] RoanKattouw, so I appear to have it working... Now I just need to upload the three parts :) [22:52:28] (03Merged) 10jenkins-bot: PopupWidget: Make $element not be a 0x0 box [oojs/ui] - 10https://gerrit.wikimedia.org/r/163280 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński) [22:52:49] Krenair: Yay :) [22:53:02] I'm just merging Bartosz's two-part commit here [22:53:15] * MatmaRex braces for regressions [22:56:30] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (98e770ce46) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163296 [22:57:50] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (98e770ce46) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163296 (owner: 10Catrope) [22:59:37] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (98e770ce46) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163296 (owner: 10Catrope) [23:01:00] (03PS1) 10Alex Monk: Don't cut off "Use this group" dropdown menu in reference dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163299 (https://bugzilla.wikimedia.org/71178) [23:01:07] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (98e770ce46) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163296 (owner: 10Catrope) [23:01:52] (03PS1) 10Alex Monk: ComboBoxWidget: Append menu to $overlay option [oojs/ui] - 10https://gerrit.wikimedia.org/r/163300 (https://bugzilla.wikimedia.org/71178) [23:02:05] (03PS1) 10Alex Monk: DesktopSurface#createDialogWindowManage: Send overlay object to WindowManager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163301 (https://bugzilla.wikimedia.org/71178) [23:02:43] 3VisualEditor / 3Editing Tools: VisualEditor:The "Use this group" drop down box is getting cut off in Basic Reference dialog - 10https://bugzilla.wikimedia.org/71374 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16610 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16... [23:03:48] (03CR) 10jenkins-bot: [V: 04-1] DesktopSurface#createDialogWindowManage: Send overlay object to WindowManager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163301 (https://bugzilla.wikimedia.org/71178) (owner: 10Alex Monk) [23:05:45] RoanKattouw, sigh, jenkins... [23:08:09] 3VisualEditor / 3Editing Tools: VisualEditor:The "Use this group" drop down box is getting cut off in Basic Reference dialog - 10https://bugzilla.wikimedia.org/71374#c1 (10Rummana Yasmeen) 5NEW>3RESO/DUP Sorry ,it is a duplicate, I could not find this bug in BZ, so reported it. *** This bug has been mar... [23:08:20] Krenair: Yeah it did that to me too. Comment "recheck" [23:08:22] 3VisualEditor / 3Editing Tools: VisualEditor: "Use this Group" menu items, in Reference / Reference list dialogs, have a cut-off display - 10https://bugzilla.wikimedia.org/71178#c6 (10Rummana Yasmeen) *** Bug 71374 has been marked as a duplicate of this bug. *** [23:08:25] 3VisualEditor / 3Editing Tools: VisualEditor:The "Use this group" drop down box is getting cut off in Basic Reference dialog - 10https://bugzilla.wikimedia.org/71374#c2 (10Rummana Yasmeen) Sorry ,it is a duplicate, I could not find this bug in BZ, so reported it. [23:08:40] I was going to just hit the rebase button, but that should work too. [23:09:15] (03CR) 10Alex Monk: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163301 (https://bugzilla.wikimedia.org/71178) (owner: 10Alex Monk) [23:10:23] Yeah either is fine [23:10:50] (03CR) 10Catrope: [C: 032] "Per James" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163296 (owner: 10Catrope) [23:11:01] IIRC, recheck doesn't rerun the privileged tests or something? [23:11:11] Something like that [23:11:23] right, which makes it useless in most repositories :p [23:12:21] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (98e770ce46) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163296 (owner: 10Catrope) [23:19:36] Krinkle: https://gerrit.wikimedia.org/r/163296 [23:21:40] (03PS4) 10Catrope: DesktopContext: Ensure that inspectors/menus are fully visible when created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163228 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński) [23:21:50] (03CR) 10Catrope: [C: 032] Move IE10 to the greylist too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163223 (owner: 10Jforrester) [23:21:56] RoanKattouw, hm :/ [23:22:12] it failed again [23:22:27] Yeah my OOUI pull-through also keeps failing [23:22:29] I've asked Krinkle to look at it [23:22:46] Krenair: He says not to trigger any Jenkins runs in VE core for now while he's in there [23:22:52] Okay. [23:23:44] (03Merged) 10jenkins-bot: Move IE10 to the greylist too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163223 (owner: 10Jforrester) [23:24:08] (03CR) 10jenkins-bot: [V: 04-1] DesktopContext: Ensure that inspectors/menus are fully visible when created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163228 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński) [23:29:12] (03CR) 10Krinkle: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163296 (owner: 10Catrope) [23:29:39] (03CR) 10Krinkle: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163296 (owner: 10Catrope) [23:29:56] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (98e770ce46) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163296 (owner: 10Catrope) [23:32:32] (03CR) 10Krinkle: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163296 (owner: 10Catrope) [23:33:51] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (98e770ce46) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163296 (owner: 10Catrope) [23:34:09] 3VisualEditor / 3Editing Tools: VisualEditor: In Firefox "TypeError: this.$documentNode is undefined" appears while selecting a citation note for a second time but not consecutively - 10https://bugzilla.wikimedia.org/71375 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16611... [23:44:06] RoanKattouw: http://jsfiddle.net/119eccdx/ [23:44:44] >>> [ [ 1, 2, 3 ], [ 4, 5, 6 ] ].join('$') [23:44:45] RoanKattouw: (string) '1,2,3$4,5,6' [23:44:53] >> [ 1, 2, 3 ].toString() [23:44:53] RoanKattouw: (string) '1,2,3' [23:45:04] TrevorParscal: Looks reasonable to me [23:45:24] >> [ { foo: 'bar'}, { bar: 'quux' } ].join('$') [23:45:25] RoanKattouw: (string) '[object Object]$[object Object]' [23:46:21] >> x = [ 1,2]; x.toString=undefined; ''+x [23:46:21] Krinkle: TypeError: Cannot convert object to primitive value [23:46:54] >> x = [ 1,2]; x.toString=Object.prototype.toString/*cut out Array#toString*/; ''+x [23:46:54] Krinkle: (string) '[object Array]' [23:47:30] >> function MyClass() {} x = new MyClass(); x.toString(); [23:47:30] RoanKattouw: (string) '[object Object]' [23:48:01] >> ''+new Boolean() [23:48:01] Krinkle: (string) 'false' [23:48:08] >> ''+Object.toString.call(new Boolean()) [23:48:08] Krinkle: TypeError: Function.prototype.toString is not generic [23:48:17] >> Object.prototype.toString.call(new Boolean()) [23:48:17] Krinkle: (string) '[object Boolean]' [23:53:18] >> Object.prototype.toString.call( '' ) [23:53:18] Krenair: (string) '[object String]'