[00:13:00] 3VisualEditor: VisualEditor: Ugly span tags appear on {{infobox book}}, but not in the saved wikitext, if ref tag is present - 10https://bugzilla.wikimedia.org/70796#c2 (10WhatamIdoing) Also reported here: https://www.mediawiki.org/wiki/Thread:VisualEditor/Feedback/Infobox_on_en.wikipedia%27s_The_Little_Prince [09:07:47] 3VisualEditor: VisualEditor: Letters getting added and duplicated on pages featuring chess templates - 10https://bugzilla.wikimedia.org/71404 (10Elitre) 3NEW p:3Unprio s:3normal a:3None See https://de.wikipedia.org/wiki/Benutzer:Elitre_(WMF)/sandbox?veaction=edit . Place your cursor after the last peri... [09:08:00] 3VisualEditor: VisualEditor: Letters getting added and duplicated on pages featuring chess templates - 10https://bugzilla.wikimedia.org/71404 (10Elitre) [09:08:00] 3VisualEditor / 3ContentEditable: VisualEditor: CSS munging causing absolutely-positioned chess diagrams(?) to break - 10https://bugzilla.wikimedia.org/51932 (10Elitre) [11:45:19] (03PS1) 10Bartosz Dziewoński: Add rudimentary support for page status indicators [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163563 (https://bugzilla.wikimedia.org/23796) [11:50:00] 3MediaWiki / 3Page editing: Provide a way to set page meta-data flags ("featured article", "protected", etc.), configure which ones are available for a wiki, and display icons indicating these statuses - 10https://bugzilla.wikimedia.org/23796#c58 (10Bartosz Dziewoński) Patches: * MediaWiki: https://gerrit.... [13:58:32] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/163028 (https://bugzilla.wikimedia.org/63389) (owner: 10Jforrester) [14:00:53] (03CR) 10Jackmcbarn: "Note that on enwiki, the current message was confusing, since "documentation" is something other than what this is there (and the same is " [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/163028 (https://bugzilla.wikimedia.org/63389) (owner: 10Jforrester) [14:38:45] 3OOjs UI: OOjs UI: PopupToolGroup shows horizontal scrollbar, tools are not wide enough to contain labels - 10https://bugzilla.wikimedia.org/65059#c1 (10Bartosz Dziewoński) This only happens when the vertical scrollbar is needed to display all items. [15:18:47] 3OOjs UI: OOjs UI: PopupToolGroup shows horizontal scrollbar, tools are not wide enough to contain labels - 10https://bugzilla.wikimedia.org/65059#c2 (10Bartosz Dziewoński) a:3Bartosz Dziewoński It also doesn't happen on IE 11. Opera latest, Firefox latest and Opera 12 all exhibit the issue. I can't tell if... [15:19:18] 3OOjs UI: OOjs UI: PopupToolGroup shows horizontal scrollbar, tools are not wide enough to contain labels - 10https://bugzilla.wikimedia.org/65059#c3 (10Bartosz Dziewoński) Created attachment 16621 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16621&action=edit IE11 screenshots [15:32:26] (03PS1) 10Bartosz Dziewoński: ClippableElement: Use 'overflow-[xy]: scroll' rather than 'auto' [oojs/ui] - 10https://gerrit.wikimedia.org/r/163586 (https://bugzilla.wikimedia.org/65059) [15:40:00] 3OOjs UI: OOjs UI: PopupToolGroup shows horizontal scrollbar, tools are not wide enough to contain labels - 10https://bugzilla.wikimedia.org/65059#c5 (10Bartosz Dziewoński) JSFiddle: http://jsfiddle.net/hxyxvqy0/ [15:44:15] 3OOjs UI: OOjs UI: PopupToolGroup shows horizontal scrollbar, tools are not wide enough to contain labels - 10https://bugzilla.wikimedia.org/65059#c6 (10Bartosz Dziewoński) (As a curiosity, Opera 12 only exhibits the issue only if the dropdown contains block elements that contain inline-block elements. Not tha... [15:47:55] https://www.mediawiki.org/w/index.php?title=Parsoid/Deployments doesn't seem to be opening in VE ... it seems to be loading forever. [15:48:01] i can open title=Parsoid however. [16:09:47] 3VisualEditor / 3Editing Tools: VisualEditor: Add a Template dialog does not open, when adding a new Basic reference. - 10https://bugzilla.wikimedia.org/71417 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Environment- test2 1> In VE, open Basic citation dialog and enter any citation(book,news,Web... [16:10:44] 3OOjs UI: OOjs UI: ClippableElement does not work in certain cases - 10https://bugzilla.wikimedia.org/67444#c2 (10Bartosz Dziewoński) Either this doesn't happen anymore, or the reproduction instructions are insufficient. :) [16:14:45] 3VisualEditor / 3Editing Tools: VisualEditor: Add a Template dialog does not open, when adding a new Basic reference. - 10https://bugzilla.wikimedia.org/71417#c1 (10Ritu Swain) http://youtu.be/sy91ReXk_f4 [16:16:19] 3OOjs UI: OOjs UI: Allow Scrolling the text in the Insert Comment dialog, with only one scrollbar - 10https://bugzilla.wikimedia.org/71310#c1 (10Bartosz Dziewoński) This is two issues: * The comment inspector isn't autosized correctly (after closing it and viewing the newly created comment, the inspector wi... [16:22:17] 3VisualEditor / 3ContentEditable: VisualEditor: "Uncaught NotFoundError: Failed to execute 'insertBefore' on 'Node': .." while inserting a comment. - 10https://bugzilla.wikimedia.org/71418 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Created attachment 16623 --> https://bugzilla.wikimedia.org/at... [16:22:29] 3VisualEditor / 3ContentEditable: VisualEditor: "Uncaught NotFoundError: Failed to execute 'insertBefore' on 'Node': .." while inserting a comment. - 10https://bugzilla.wikimedia.org/71418 (10Ritu Swain) [16:30:48] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32813333 [16:30:48] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65850196 [16:30:48] Corruption alert: visualeditor-needcheck on cawiki: https://ca.wikipedia.org/?diff=14088878 [16:30:48] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40169356 [16:30:48] Corruption alert: visualeditor-needcheck on skwiki: https://sk.wikipedia.org/?diff=5864711 [16:47:23] James_F: Are you watching the changes to https://www.mediawiki.org/wiki/Help:VisualEditor/User_guide ? :) [16:47:35] I made a few in the last couple of days. Hopefully nothing silly. [16:47:53] aharoni: Haven't yet got to that page in my e-mail, but will check it out. :-) [16:47:57] There are also some questions on the talk page. [16:48:00] Nothing urgent. [16:50:31] Thanks for the heads-up. [17:17:29] (03PS3) 10Alex Monk: DesktopSurface#createDialogWindowManage: Send overlay object to WindowManager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163301 (https://bugzilla.wikimedia.org/71178) [17:23:38] Krinkle|detached, ah, looks like you(?) fixed the jenkins issue behind https://gerrit.wikimedia.org/r/#/c/163301/ [17:23:43] what was going wrong with that? [17:34:43] (03PS1) 10Bartosz Dziewoński: ve.ui.CommentInspector.css: Fix documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163616 [17:35:44] (03CR) 10Jforrester: [C: 032] ve.ui.CommentInspector.css: Fix documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163616 (owner: 10Bartosz Dziewoński) [17:38:21] (03Merged) 10jenkins-bot: ve.ui.CommentInspector.css: Fix documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163616 (owner: 10Bartosz Dziewoński) [17:40:44] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (3aafc81) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163455 (owner: 10Jforrester) [17:42:45] (03Merged) 10jenkins-bot: Update VE core submodule to master (3aafc81) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163455 (owner: 10Jforrester) [17:42:49] MatmaRex: Wow that is stupid [17:43:13] MatmaRex: Have you seen https://code.google.com/p/chromium/issues/detail?id=387290 BTW? It's kind of the reverse of that bug [17:43:44] RoanKattouw: yeah, i looked at the one linked from the comment and that, related but seem different [17:54:24] (03CR) 10Catrope: [C: 032] Add rudimentary support for page status indicators [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163563 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [17:56:32] (03Merged) 10jenkins-bot: Add rudimentary support for page status indicators [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163563 (https://bugzilla.wikimedia.org/23796) (owner: 10Bartosz Dziewoński) [17:59:42] RoanKattouw: want to know another scrollbar-related fun fact? our height measurements in TextInputWidget are off by one, but only in Blink :( [17:59:55] RoanKattouw: they are also off by one in IE, but only when the textarea is two lines high [18:00:13] also, standalone demo doesn't work in IE :( [18:03:23] (the two lines thing is our fault, though) [18:03:30] 3OOjs UI: OOjs UI: Allow Scrolling the text in the Insert Comment dialog, with only one scrollbar - 10https://bugzilla.wikimedia.org/71310#c2 (10Bartosz Dziewoński) (In reply to Bartosz Dziewoński from comment #1) > * The textarea inside has a silly vertical scrollbar that scrolls only by > one pixel up or d... [18:07:15] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf21]:"Uncaught TypeError: undefined is not a function" , when media Search dialog is searching for the Media. - 10https://bugzilla.wikimedia.org/70860#c1 (10Ritu Swain) Created attachment 16625 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16... [18:07:51] (03PS1) 10Bartosz Dziewoński: TextInputWidget: Don't mix inner and outer heights in calculations [oojs/ui] - 10https://gerrit.wikimedia.org/r/163632 (https://bugzilla.wikimedia.org/71310) [18:11:59] 3VisualEditor / 3ContentEditable: VisualEditor: "Uncaught NotFoundError: Failed to execute 'insertBefore' on 'Node': .." while inserting a comment. - 10https://bugzilla.wikimedia.org/71418#c1 (10Roan Kattouw) This bug also causes VE to throw errors when loading on pages like http://www.mediawiki.org/wiki/Par... [18:12:15] 3VisualEditor / 3ContentEditable: VisualEditor: "Uncaught NotFoundError: Failed to execute 'insertBefore' on 'Node': .." while inserting a comment. - 10https://bugzilla.wikimedia.org/71418 (10Roan Kattouw) p:5Unprio>3Highes s:5minor>3critic [18:17:53] 3VisualEditor: VisualEditor: Fail more graciously (please don't add too many nowiki tags) - 10https://bugzilla.wikimedia.org/71422 (10Elitre) 3NEW p:3Unprio s:3normal a:3None The author of this revision https://fr.wikipedia.org/w/index.php?title=La_Grange_au_Lac&diff=107837547&oldid=107804115 realizes... [18:20:45] 3VisualEditor: VisualEditor: Give the user a chance to understand if he made a mistake and to fix it - 10https://bugzilla.wikimedia.org/71422 (10Elitre) [18:21:30] 3VisualEditor: VisualEditor: Give the user a chance to understand if he made a mistake and to fix it - 10https://bugzilla.wikimedia.org/71422#c1 (10Roan Kattouw) There is already a warning that appears in the top right corner. Maybe that warning could be made better? The number of nowiki tags there is a bit e... [18:22:00] 3VisualEditor: VisualEditor: Give the user a chance to understand if he made a mistake and to fix it - 10https://bugzilla.wikimedia.org/71422#c2 (10Roan Kattouw) Maybe we could have an additional warning on save, like we do for suspected page corruption? [18:28:00] (03PS1) 10Catrope: Followup a618491: fix JS errors when slugging near annotated inline nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163636 (https://bugzilla.wikimedia.org/71418) [18:29:15] 3VisualEditor: VisualEditor: Give the user a chance to understand if he made a mistake and to fix it - 10https://bugzilla.wikimedia.org/71422#c3 (10Elitre) I'll file a bug against Parsoid, thanks. Could we expose the specific issue, like, telling at which line it is and highlighting it? I realize pointing at c... [18:29:29] (03CR) 10jenkins-bot: [V: 04-1] Followup a618491: fix JS errors when slugging near annotated inline nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163636 (https://bugzilla.wikimedia.org/71418) (owner: 10Catrope) [18:55:35] MatmaRex: Yeah I noticed autosizing textareas are funky in IE [18:55:43] But I didn't know standalone was broken :( [18:56:11] RoanKattouw: i think the autosizing is hopeless, i'm rewriting it to just count rows and set the 'rows' attribute [18:56:32] Wait it wasn't doing that before? [18:56:36] RoanKattouw: did you know firefox, unlike all other browsers, will display the textarea with space for one more row than the value of the attribute? [18:56:41] wtf [18:56:46] no, it was measuring various heights and applying guesses [18:57:22] i hope trevor didn't have a very good reason to do that, like doing what i'm trying to do being somehow hopelessly broken [18:58:27] Well I think he was trying to avoid using the rows attribute [18:58:39] because that requires guessing / computing how tall a row is [18:59:08] I do remember we rewrote it at some point [18:59:19] James thinks it might have something to do with Firefox drawing that extra row [19:00:04] Or something. [19:00:10] Very vague memory. [19:00:45] MatmaRex: https://gerrit.wikimedia.org/r/#/c/116665/ has some info in the commit message I suppose [19:03:26] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/114522/ also says "Uses scrollHeight technique, which has its ups and downs but seems to work more consistently than other approaches." [19:03:49] no idea what "consistently" means, perhaps the firefox thing? [19:04:20] Maybe? I don't remember [19:05:25] do we need to care about that? James_F? [19:06:08] https://bugzilla.mozilla.org/show_bug.cgi?id=33654 [19:06:35] 14 years old. nice [19:07:55] But with several patches, the most recent of which was written in 2011 [19:13:41] (03PS1) 10Divec: Record and show observation times in ve.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163644 [19:14:27] eh, rows also acts very funny in IE [19:14:51] Of course they do. :-) [19:16:22] so, the appraiser came by [19:16:29] we survived that [19:16:34] with minimal distraction [19:17:11] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/157866/ gtg? [19:17:51] will need to fixup MobileFrontend before we pull it through [19:17:59] I think there are some minor changes to be made [19:18:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3High s:5normal>3major [19:20:21] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - 10https://bugzilla.wikimedia.org/66604 (10James Forrester) [19:20:22] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In media dialog, "Size values are invalid" message does not show up, when choosing a different image and then setting its size to 0 x 0 px - 10https://bugzilla.wikimedia.org/70861 (10James Forrester) [19:20:30] 3VisualEditor / 3Data Model: VisualEditor: Make transaction processing exception-safe - 10https://bugzilla.wikimedia.org/68892 (10James Forrester) [19:20:46] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10James Forrester) [19:20:46] 3VisualEditor / 3Editing Tools: VisualEditor: In the media selector show name in a tooltip on mouseover - 10https://bugzilla.wikimedia.org/52459 (10James Forrester) [19:20:47] 3VisualEditor / 3ContentEditable: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - 10https://bugzilla.wikimedia.org/69474 (10James Forrester) [19:20:47] 3VisualEditor / 3MediaWiki integration: VisualEditor: Link existence checker in LinkTargetInputWidget doesn't work for interwikis, language links - 10https://bugzilla.wikimedia.org/70504 (10James Forrester) [19:20:48] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195 (10James Forrester) [19:20:49] 3VisualEditor / 3Editing Tools: VisualEditor: In the media insertion dialog, give a tooltip on each item saying what will happen when you click it (i.e., "Click to insert as a thumbnail" or whatever) - 10https://bugzilla.wikimedia.org/52219 (10James Forrester) [19:20:50] 3VisualEditor / 3Editing Tools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - 10https://bugzilla.wikimedia.org/68537 (10James Forrester) [19:20:51] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10James Forrester) [19:20:54] 3VisualEditor / 3Editing Tools: VisualEditor: There should be help links in every context - dialog boxes, inspectors, etc. - 10https://bugzilla.wikimedia.org/51798 (10James Forrester) [19:20:54] 3VisualEditor / 3Editing Tools: VisualEditor: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - 10https://bugzilla.wikimedia.org/68590 (10James Forrester) [19:20:54] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10James Forrester) [19:21:19] TrevorParscal: There were some issues RoanKattouw and I spotted. E.g. the popup hook/whatever it's called (arrow) doesn't appear in the right place in the demos page. [19:21:27] TrevorParscal: But otherwise it looks good to me. [19:21:31] I don't know if that's a regression though [19:21:34] Yeah. [19:21:47] I just need to go through all the comments now, I'll do that now [19:21:52] Anchor [19:22:04] and, just leave comments [19:22:05] thanks man [19:22:05] well, after I finish this fix for this crash on slugging an annotated inline node thing [19:22:10] yup [19:22:15] 3VisualEditor / 3Mobile: VisualEditor: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110 (10James Forrester) a:5Ed Sanders>3James Forrester [19:22:42] Could someone review https://gerrit.wikimedia.org/r/163644/ for me real quick? (It's a few lines and they don't run in production) [19:23:14] (03CR) 10Jforrester: [C: 031] Record and show observation times in ve.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163644 (owner: 10Divec) [19:23:21] divec_: Use ve.now(). Looks good otherwise [19:23:44] James_F, did you see https://gerrit.wikimedia.org/r/#/c/120962/ ? [19:24:59] Krenair: Yes. It's fine. [19:27:30] (03PS2) 10Divec: Record and show observation times in ve.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163644 [19:28:34] (03PS2) 10Catrope: Followup a618491: fix JS errors when slugging near annotated inline nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163636 (https://bugzilla.wikimedia.org/71418) [19:28:53] divec_: You changed it to no longer subtract startTime? [19:29:10] I have a chromium stack trace, triggered with 'debugger'. Halfway down the stack, a few lines *above* the current execution point, I have a red box saying "Uncaught Error". [19:29:17] startTime is unused now [19:29:43] divec_: Yeah, I think that can happen if you have error catching turned off [19:29:48] I have the octagonal blue "pause on exceptions" button activated. So any ideas why the uncaught exception wouldn't have triggered anything? [19:30:12] Hah that should have been caught then [19:30:31] (03PS3) 10Divec: Record and show observation times in ve.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163644 [19:30:44] James_F, so... you want to reply? [19:31:00] RoanKattow: duh, thanks, yeah, need to subtract startTime (unless I just wait for 1970-01-01 00:00:00 to come round again) [19:31:05] Krenair: Not particularly. We've had this discussion four times before. Gerrit isn't the place for bug discussion. [19:31:09] (03CR) 10Catrope: [C: 032] Record and show observation times in ve.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163644 (owner: 10Divec) [19:33:15] (03Merged) 10jenkins-bot: Record and show observation times in ve.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163644 (owner: 10Divec) [19:37:06] (03PS2) 10Bartosz Dziewoński: TextInputWidget: Don't mix inner and outer heights in calculations [oojs/ui] - 10https://gerrit.wikimedia.org/r/163632 (https://bugzilla.wikimedia.org/71310) [19:40:20] TrevorParscal: So your theme change looks good to merge except that you have regressed popup anchor placement [19:40:32] ok [19:40:38] i will look at that [19:40:40] Look at the info icon in the widgets demo for example [19:40:48] In master, the popup icon is centered wrt the icon [19:40:59] In your change, it's right-aligned in both themes [19:47:06] (03PS1) 10Jforrester: Let tools be flagged [oojs/ui] - 10https://gerrit.wikimedia.org/r/163653 [19:47:17] James_F: https://gerrit.wikimedia.org/r/#/c/163636/ fixes the crash near slugs BTW [19:47:54] (03CR) 10jenkins-bot: [V: 04-1] Let tools be flagged [oojs/ui] - 10https://gerrit.wikimedia.org/r/163653 (owner: 10Jforrester) [19:48:45] (03PS2) 10Jforrester: Let tools be flagged [oojs/ui] - 10https://gerrit.wikimedia.org/r/163653 [19:48:54] (03CR) 10Jforrester: [C: 032] Followup a618491: fix JS errors when slugging near annotated inline nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163636 (https://bugzilla.wikimedia.org/71418) (owner: 10Catrope) [19:50:21] (03Merged) 10jenkins-bot: Followup a618491: fix JS errors when slugging near annotated inline nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163636 (https://bugzilla.wikimedia.org/71418) (owner: 10Catrope) [19:50:57] (03PS1) 10Jforrester: Followup a618491: fix JS errors when slugging near annotated inline nodes [VisualEditor/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163656 (https://bugzilla.wikimedia.org/71418) [19:51:03] RoanKattouw: ^^^ [19:54:42] (03PS1) 10Bartosz Dziewoński: TextInputWidget: Work around Blink height miscalculation [oojs/ui] - 10https://gerrit.wikimedia.org/r/163659 (https://bugzilla.wikimedia.org/71310) [19:54:52] (03PS1) 10Catrope: Fix JS error in mostly-dead Opera compat code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163660 [19:56:14] i can't remember when i last needed to do this much cross-browser testing. [19:57:07] (03PS1) 10Jforrester: Add a "Remove" context button to all Focussable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163662 (https://bugzilla.wikimedia.org/60110) [19:57:33] (03CR) 10Catrope: [C: 04-1] Try to stop user from tabbing outside of open dialog box (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/159902 (https://bugzilla.wikimedia.org/67156) (owner: 10Alex Monk) [19:59:36] MatmaRex: welcome to the team :D [20:00:35] i'll get myself transferred to parsoid, wikitext is saner than that :P [20:01:20] don't let him go! [20:01:33] * gwicke listens up ;) [20:01:54] damn... [20:03:22] * gwicke wasted a few months of his life on IE5.0, IE5.5{win,mac} and IE6.0 and decided to not wade into that swamp again [20:05:33] * gwicke has high respect for those that are still in battle though [20:07:40] (03PS1) 10Bartosz Dziewoński: ve.ui.FragmentInspector: Remove #setDimensions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163663 [20:07:53] ^ finally a change i like [20:15:02] 3VisualEditor / 3Editing Tools: VisualEditor: CommentInspector doesn't update its size when the textarea gets resized - 10https://bugzilla.wikimedia.org/71427 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None CommentInspector doesn't update its size when the textarea gets resized, only if it's... [20:15:50] 3OOjs UI: OOjs UI: TextInputWidget's textarea gets silly scrollbars when it shouldn't - 10https://bugzilla.wikimedia.org/71310 (10Bartosz Dziewoński) a:3Bartosz Dziewoński [20:15:50] 3OOjs UI: OOjs UI: TextInputWidget's textarea gets silly scrollbars when it shouldn't - 10https://bugzilla.wikimedia.org/71310#c5 (10Bartosz Dziewoński) (In reply to Bartosz Dziewoński from comment #1) > * The comment inspector isn't autosized correctly (after closing it and > viewing the newly created comme... [20:15:51] 3VisualEditor / 3Editing Tools: VisualEditor: CommentInspector doesn't update its size when the textarea gets resized - 10https://bugzilla.wikimedia.org/71427 (10Bartosz Dziewoński) a:3Bartosz Dziewoński [20:20:02] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163662 (https://bugzilla.wikimedia.org/60110) (owner: 10Jforrester) [20:21:11] (03CR) 10Catrope: [C: 032] "It had outdated documentation too :S" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163663 (owner: 10Bartosz Dziewoński) [20:22:49] (03Merged) 10jenkins-bot: ve.ui.FragmentInspector: Remove #setDimensions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163663 (owner: 10Bartosz Dziewoński) [20:24:32] (03CR) 10Bartosz Dziewoński: "It had outdated documentation ever since it was created, too." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163663 (owner: 10Bartosz Dziewoński) [20:25:09] (03CR) 10Jforrester: [C: 04-1] "Depends on being able to over-ride the label for context items." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163662 (https://bugzilla.wikimedia.org/60110) (owner: 10Jforrester) [20:28:26] gwicke: few months, during Monobook? [20:38:50] Krinkle: yup [20:45:38] (03PS1) 10Bartosz Dziewoński: ve.ui.CommentInspector.js: Fix documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163673 [20:45:40] (03PS1) 10Bartosz Dziewoński: [WIP] ve.ui.CommentInspector: Update size when the textarea gets resized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) [20:46:47] i need inspectors (or at least CommentInspector) to emit some kind of resize events, and i need DesktopContext to listen to them. does this make sense? see ^ [20:47:02] TrevorParscal: you're probably a good person to ask. ^ [20:47:37] what is causing the resize? [20:47:48] like, the contents of the inspector are resizing? [20:52:51] yes [20:52:59] autosized multiline textInputWidget [20:53:08] TextInputWidget* [20:53:19] TrevorParscal: sorry, i was asynchronous ;) [20:54:50] so, of course this isn't something the dom gives us [20:54:58] we would need to poll [20:55:22] the good thing is, polling for the body height only requires the browser to re-render the contents of the iframe (not the whole dang document) [20:55:39] so, even an aggressive polling interval would work ok [20:56:35] and, HTML5 has this new thing coming where iframes can be seamless - which will probably never work... ever... anywhere http://caniuse.com/#feat=iframe-seamless [20:56:59] But we could also just rig up events for this [20:57:10] TrevorParscal: eh, that seems like overkill [20:57:14] Because the thing that makes the inspector grow is an OOUI widget (autosizing TextInputWidget) [20:57:16] we know when the height changes [20:57:26] you mean, on textarea change? [20:57:27] we just need to share this information with the PopupWidget [20:57:31] yes [20:57:42] we resize it ourselves [20:57:50] well, that's a one-off fix for a particular use case [20:57:59] but, it could work similarly, sure [20:58:28] what are we resizing for, updating the iframe size to encompass the iframe contents? [20:58:39] yep [20:58:56] TrevorParscal: see https://gerrit.wikimedia.org/r/163674 [20:58:58] i think using the onchange event - at least initially, is a good idea [20:59:50] if we find there are other cases where this is needed, perhaps less predictable ones, we could explore polling [21:01:30] i don't see when would that be necessary, to be honest [21:01:47] okay, i'll go ahead with the resize event for oo.ui.Window, then? [21:01:49] WindowManager, rather [21:02:16] actually [21:02:19] ugh [21:02:58] Window has a resize event already, but it doesn't seem to ever emit it. [21:03:33] lookin [21:03:34] wut [21:04:44] so, you could setSize( this.size ) [21:05:37] ignore that [21:05:39] digging [21:05:59] lol @ never emitting resize [21:06:05] TrevorParscal: IMO, OO.ui.Window.prototype.setDimensions should emit 'resize'. [21:06:13] I think you are right [21:06:31] or OO.ui.WindowManager.prototype.updateWindowSize should emit something [21:06:36] please add that, but verify the dimensions have changed to avoid triggering lots of useless updates for non-changes [21:06:55] yep [21:06:57] well, the popup is more interested in the manager yeah? [21:07:07] so, probably do it there since the manager is in control anyway [21:07:37] alright [21:07:42] manager.emit( 'resize', win ) [21:07:57] and just remove the doc for the event that never occurs [21:08:08] sounds good [21:08:27] then your handler will look a lot nicer [21:09:15] I notice you are using a getWindow within the inspector [21:09:54] hm? [21:09:58] we don't have a convention exactly, but we usually consider it to be OK to access owned properties directly - but there are exceptions where it's needed to use a getter [21:10:15] and I've sort of wondered if Krinkle has an opinion about this [21:10:21] ah, you mean this.getManager [21:10:28] yeah [21:10:56] I mean, this.manager would work as well [21:11:15] but, if the getManager method were to do something clever... [21:11:19] right, not sure why i did it this way [21:11:32] TrevorParscal: MatmaRex: Only access properties within the file that defines it and only if there's no logic in the getter method. [21:11:33] so, usually when I see this.get{something} I think, logic in a getter? [21:11:39] i'm subliminally aware of the convention ;) [21:11:46] otherewise use the method and, if needed repeatedly, store in a local var [21:11:53] Krinkle: in other words "what we are doing so far is fine" [21:12:02] this bit of code looked different first [21:12:04] Krinkle: I agree with you btw [21:12:09] I can't speak for the entire code base, but I'll take your word for it :P [21:12:29] MatmaRex: no worries, I just wanted to help clarify how we usually do things [21:12:54] Krinkle: I think there are still violations here and there, but the majority case is exactly as you stated [21:13:48] MatmaRex: what Krinkle said though, actually is a little different than what we are usually doing - but I think it's better [21:14:04] he said, if it's introduced in the same file [21:14:19] which, in your case it is not, and using the getter is correct because it's a subclass [21:14:25] right Krinkle? [21:14:58] this makes it possible to limit the changes needed to introduce logic to a getter to a single file [21:15:00] TrevorParscal: I was just saying, I'm sure it's our pratice, but there's probably areas where we're not doing it (but shouldD) [21:15:22] and also implies that all properties are private, and getters are potentially "protected" or more usually public [21:15:49] TrevorParscal: And I was also make a subtle suggestion that we stop using properties in classes where the method has logic (even if it's just fallback or lazy-init logic), so that you don't depend on accessing a property "at the right time" but instead have the method be more atomical [21:15:55] Krinkle: I agree with you, but yeah we have more tech debt here than I originally estimated [21:16:47] right, basically apply the logic at the time of setting? [21:16:54] rather than getting? [21:16:59] is that what you mean? [21:29:54] Krinkle: sorry, i just reread- and you are saying anytime there's logic used to populate a property we should move the logic to a getter and populate it on demand [21:33:32] TrevorParscal: No, I wasn't recommending a strategy on that regard in either direction [21:33:42] i guess I'm confused [21:34:00] I'm just saying, given a class with a property that has a getter method with logic in it, and you're trying to decide how to access that property, use getter method. [21:34:47] right [21:34:56] that is clear [21:35:06] we do that - if not everywhere, nearly [21:35:07] E.g. getTooltip ->() this.title || this.label [21:35:15] use getTooltip even if you think title is set in your context. [21:35:49] TrevorParscal: Processing logic should imho generally be in the setter method (and fail if it's invalid) [21:36:06] that way event listeners don't have to defend against garbage [21:42:26] seems sensible [21:43:57] (03PS2) 10Bartosz Dziewoński: TextInputWidget: Work around Blink height miscalculation [oojs/ui] - 10https://gerrit.wikimedia.org/r/163659 (https://bugzilla.wikimedia.org/71310) [21:43:59] (03PS1) 10Bartosz Dziewoński: WindowManager: Emit 'resize' event when a window is resized [oojs/ui] - 10https://gerrit.wikimedia.org/r/163738 (https://bugzilla.wikimedia.org/71427) [21:45:22] (03PS2) 10Bartosz Dziewoński: ve.ui.CommentInspector: Update size when the textarea gets resized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) [21:45:24] (03CR) 10jenkins-bot: [V: 04-1] ve.ui.CommentInspector: Update size when the textarea gets resized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) (owner: 10Bartosz Dziewoński) [21:52:15] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to set an item's size in upright terms in the media edit dialog - 10https://bugzilla.wikimedia.org/62671#c8 (10Spinningspark) One point about the upright parameter is that it does something sensible with a portrait image by default without the user having... [21:57:48] (03PS3) 10Bartosz Dziewoński: ve.ui.CommentInspector: Update size when the textarea gets resized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) [21:58:43] (03CR) 10jenkins-bot: [V: 04-1] ve.ui.CommentInspector: Update size when the textarea gets resized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) (owner: 10Bartosz Dziewoński) [21:59:02] (03CR) 10Bartosz Dziewoński: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) (owner: 10Bartosz Dziewoński) [22:00:41] (03PS4) 10Bartosz Dziewoński: ve.ui.CommentInspector: Update size when the textarea gets resized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) [22:05:11] (03CR) 10Catrope: [C: 032 V: 032] Followup a618491: fix JS errors when slugging near annotated inline nodes [VisualEditor/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163656 (https://bugzilla.wikimedia.org/71418) (owner: 10Jforrester) [22:07:47] (03PS1) 10Catrope: Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163749 [22:08:36] (03CR) 10Catrope: [C: 032] ve.ui.CommentInspector.js: Fix documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163673 (owner: 10Bartosz Dziewoński) [22:09:16] TrevorParscal: How's that popup anchor coming? [22:09:26] arg [22:09:30] keep getting distracted [22:09:56] (03Merged) 10jenkins-bot: ve.ui.CommentInspector.js: Fix documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163673 (owner: 10Bartosz Dziewoński) [22:16:59] Krinkle: I just looked at you, and merged "Timo" and "Krinkle" in my head to what could only be described as sounding like "Kreeeenkle" [22:17:38] Deskana: Pronouncing the nickname of our half-Dutch half-German engineer with a French accent is not allowed [22:18:07] Also wow there is a different interpretation of that sentence that's not accurate but more hilarious [22:19:15] Right, the merge process makes noise [22:19:16] :) [22:19:43] or rather the product of the merge does [22:24:12] (03CR) 10Catrope: [C: 032 V: 032] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163749 (owner: 10Catrope) [22:40:23] James_F, VE doesn't open on https://www.mediawiki.org/wiki/Parsoid/Deployments in case it is not a known issue (I am on FF) [22:40:51] subbu: Yeah, RoanKattouw's fixing in the SWAT. [22:43:11] k [22:47:08] (03CR) 10Catrope: [C: 032] TextInputWidget: Add setValidation function to change pattern used to validate text [oojs/ui] - 10https://gerrit.wikimedia.org/r/162511 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [22:47:47] RoanKattouw: ok [22:47:49] so... [22:47:52] about the anchor thing [22:47:56] what is broken about it? [22:48:07] (03Merged) 10jenkins-bot: TextInputWidget: Add setValidation function to change pattern used to validate text [oojs/ui] - 10https://gerrit.wikimedia.org/r/162511 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [22:48:11] how do I reproduce the issue? [22:50:56] Really dude? [22:51:04] What have you been working on all day? :| [22:51:09] Anyway [22:51:28] TrevorParscal: In the widgets demo, search for "PopupButtonWidget (frameless, with popup head)‎" , it's a button with the information (lowercase i) icon [22:51:33] Click the icon, a popup appears [22:51:48] The popup anchor points to the right edge of the icon, whereas in master it points to the center [22:51:51] ok, i see that [22:51:56] cool, thanks [22:52:05] This is more obvious in the MW theme because the icon and the anchor are both bigger there, but Apex has the same bug [22:52:12] yup [22:55:01] (03CR) 10Catrope: [C: 04-1] Style required but currently-invalid parameters on the template dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161613 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [22:57:18] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/bs3NIiqnc8Q ? [22:58:51] https://developer.mozilla.org/en-US/docs/Web/Guide/Events/Mutation_events - "Deprecated This feature has been removed from the Web. Though some browsers may still support it, it is in the process of being dropped. Do not use it in old or new projects. Pages or Web apps using it may break at any time." [22:58:52] damn [22:59:04] Yeah mutation events were dropped in favor of mutation observers [22:59:31] But of course mutation observers don't have a "notify me when this element is attached to the document" feature because that's the only damn thing we want out of it [23:01:10] (03PS28) 10Trevor Parscal: [BREAKING CHANGE] Create a MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 [23:02:24] RoanKattouw: that should do it [23:02:41] was clearly an oversight, you will agree I'm sure when you see the diff [23:03:24] https://gerrit.wikimedia.org/r/#/c/157866/27..28/src/styles/widgets/PopupButtonWidget.less [23:03:37] Yeah that doesn't belong there [23:03:38] (see other files in that same change of course) [23:03:59] added custom positioning for framed and frameless, for each theme [23:04:21] Also left: 1em; really should not have been in the core style :) [23:04:24] TrevorParscal: I'm having fun butchering OOUI's Tool, BTW. [23:04:32] cool [23:04:55] yeah, there are some things we need to clean up, maybe you could file some tech-debt bugs? [23:05:03] No he's just ripping it up [23:05:06] I'm just changing the code. :-) [23:05:12] I could make bugs and then self-assign… [23:05:24] Tools have titles and labels without using LabeledElement and TitledElement, that kind of stuff [23:05:55] TrevorParscal: We can talk later. :-) [23:06:09] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Create a MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [23:07:16] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Create a MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal) [23:09:15] (03PS3) 10Jforrester: Tool: Use FlaggedElement mixin to let tools be flagged [oojs/ui] - 10https://gerrit.wikimedia.org/r/163653 [23:09:22] (03PS10) 10Catrope: build: Create minified JS and CSS distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 (owner: 10Jforrester) [23:12:16] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (a6d3197df2) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163759 [23:13:30] James_F: even better [23:13:31] TrevorParscal: So now the question is, what kind of ResourceLoader rigging do we need? [23:13:43] for the theme stuff? [23:14:50] Yeah [23:14:56] I mean there's like new files and crap [23:15:10] Shall I generate a commit in MW core that you can then amend with the necessary RL stuff? [23:15:27] yeah, it's basically just dropping the "core" styles and updating the name of the theme stylesheet [23:15:46] and, maybe changing the theme, but not until Prateek has a go at it [23:16:02] Right [23:16:05] RoanKattouw: yeah, that would be fine [23:16:08] great even [23:16:09] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (a6d3197df2) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163759 (owner: 10Catrope) [23:16:09] But even for Apex we have new files, right? [23:16:14] So even without changing the theme to mw... [23:16:18] yes [23:16:26] we can stick with apex for the time being [23:16:39] Yes [23:16:42] we used to have a core and theme style [23:16:46] now we only have theme styles [23:17:04] but we have rtl/ltr and svg/png versions (4 versions for each theme) [23:17:15] and the naming may be different [23:17:23] I forget in which cases [23:18:23] and there was something about minerva and MobileFrontend, wasn't there? [23:20:31] TrevorParscal: https://gerrit.wikimedia.org/r/163763 [23:22:37] you are starting with MW core? [23:23:38] No I have a VE core commit too [23:23:45] But the way this is hooked up in VE core is a bit weird [23:23:58] So I was going to suggest you make the changes in MW core and I'll port them to VE core [23:24:26] RoanKattouw: yeah, well I think minerva's output is almost the same, but I need to add some CSS classes where they are using their giant check icon [23:24:38] Actually the way it's hooked up in VE-MW is weird, the way it's hooked up in VE core is different still [23:26:07] but let's do MW core first because that one is the easiest to understand [23:26:15] um... so what about skinScripts? [23:27:36] ok, so there's no problem just yet - because it happens that both apex and minerva both use the same exact code for their themes (they just instantiate the default OO.ui.Theme implementation) [23:27:51] but, to roll out the MediaWiki theme, we need skinScripts [23:28:02] MatmaRex: I heard you were working on skinScripts [23:28:06] where did that land? [23:28:30] TrevorParscal: ain't never heard of that myself [23:29:04] TrevorParscal: i only worked on https://www.mediawiki.org/wiki/Manual:$wgResourceModuleSkinStyles [23:29:33] ok, well.. we need skinScripts [23:29:38] :D [23:29:46] any takers? [23:30:04] MatmaRex: maybe you could take a stab at that soon? [23:30:06] it will probably be easy to implement [23:30:11] agreed [23:30:12] we already have languageScripts and skinStyles [23:31:10] and i probably could, sure [23:31:33] RoanKattouw, when you add an entry to the linkCache, you can't overwrite it later? :/ [23:32:08] Krenair: Ugh, you can't? :( [23:32:11] That's a bug [23:32:25] I mean, at the very least you should be able to extend entries, right? [23:32:31] yes [23:32:34] OK, so hold on [23:32:39] Let me merge Timo's cleanup of LinkCache [23:32:40] Presumably because you're just trying to resolve the deferred that already exists [23:32:46] Yeah probably [23:33:05] His cleanup probably doesn't fix this bug, but if you're gonna mess with LinkCache then you should base your work on it [23:33:23] that was already resolved* [23:33:46] yeah, I just ran into this issue when trying to debug something I wrote :( [23:33:53]