[00:00:21] <TrevorParscal>	 I'll be interested to see how much was actually in it
[00:00:27] <TrevorParscal>	 heading to the store in a bit
[00:00:58] <TrevorParscal>	 I'll check back when I return
[00:36:12] <grrrit-wm>	 (03PS1) 10Catrope: Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163783 (https://bugzilla.wikimedia.org/71373) 
[00:37:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163783 (https://bugzilla.wikimedia.org/71373) (owner: 10Catrope)
[00:42:33] <grrrit-wm>	 (03PS2) 10Catrope: Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163783 (https://bugzilla.wikimedia.org/71373) 
[00:43:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163783 (https://bugzilla.wikimedia.org/71373) (owner: 10Catrope)
[00:45:18] <grrrit-wm>	 (03PS1) 10Jforrester: [BREAKING CHANGE] Tool: Use the LabelElement and TitledElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/163785 
[00:45:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Tool: Use the LabelElement and TitledElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/163785 (owner: 10Jforrester)
[00:53:27] <grrrit-wm>	 (03PS4) 10Jforrester: Tool: Use FlaggedElement mixin to let tools be flagged [oojs/ui] - 10https://gerrit.wikimedia.org/r/163653 
[00:54:24] <grrrit-wm>	 (03CR) 10Catrope: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163783 (https://bugzilla.wikimedia.org/71373) (owner: 10Catrope)
[00:58:35] <grrrit-wm>	 (03PS2) 10Jforrester: [BREAKING CHANGE] Tool: Use the LabelElement and TitledElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/163785 
[01:06:03] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Declared missing var, fixed php doc & spelling, spacing [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/161896 (owner: 10Yurik)
[01:06:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Declared missing var, fixed php doc & spelling, spacing [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/161896 (owner: 10Yurik)
[01:13:20] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Be able to set an item's size in upright terms in the media edit dialog - 10https://bugzilla.wikimedia.org/62671#c9 (10James Forrester) (In reply to Spinningspark from comment #8) > One point about the upright parameter is that it does something sensible > with a...
[01:15:32] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf1] "Uncaught NotFoundError: Failed to execute 'insertBefore' on 'Node': .." while inserting a comment - 10https://bugzilla.wikimedia.org/71418 (10James Forrester) 5PATC>3RESO/FIX a:3Roan Kattouw
[01:19:20] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf1] Increasing indentation to a bullet/numbered list is also adding a slug with a new bullet/numbered point each time - 10https://bugzilla.wikimedia.org/71134 (10James Forrester)
[01:25:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417#c2 (10James Forrester) a:3Roan Kattouw I believe this has now been fixed and backported as part of the fix for bug 71418.
[01:26:00] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417 (10James Forrester) 5ASSI>3RESO/FIX
[02:07:15] <grrrit-wm>	 (03PS1) 10Catrope: Add localsettings.js file [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163792 
[02:07:16] <grrrit-wm>	 (03PS1) 10Catrope: Add localsettings.js file [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163792 
[02:08:32] <RoanKattouw>	 WTF why did grrrit-wm report that twice
[02:08:46] <RoanKattouw>	 James_F: What have you wrought? -----^^
[02:09:35] <grrrit-wm>	 (03PS1) 10Catrope: Add --config to override path to localsettings.js [services/citoid] - 10https://gerrit.wikimedia.org/r/163793 
[02:21:56] <James_F>	 RoanKattouw: Hmm…
[02:21:58] <James_F>	 RoanKattouw: Ooooooooh.
[02:22:01] <James_F>	 Whoops.
[02:22:42] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/163795 fixes.
[02:32:31] <Afif>	 Hi. Can i get help in visualeditor setup? Currently on mw 1.25, parsoid is running. 
[02:33:21] <Afif>	 The visualeditor is not loading.. I can't seeit when i tried to edit my pages
[02:34:20] <Afif>	 Special:version shows it load
[02:37:20] <grrrit-wm>	 (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (a6d3197df2) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163759 (owner: 10Catrope)
[02:40:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (a6d3197df2) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163759 (owner: 10Catrope)
[02:43:45] <grrrit-wm>	 (03PS3) 10Jforrester: Update OOjs UI to v0.1.0-pre (a6d3197df2) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163759 (owner: 10Catrope)
[02:45:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (a6d3197df2) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163759 (owner: 10Catrope)
[06:57:37] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Table with attribute border=0 is displayed as if border=1 - 10https://bugzilla.wikimedia.org/57295#c3 (10Raimond Spekking) 5RESO/FIX>3REOP Maybe a regression: the VE renders the table in https://de.wikipedia.org/w/index.php?title=Landschaftsversammlung_Rhei...
[11:08:48] <wikibugs>	 3VisualEditor: ISBN ending in X is not shown as a link - 10https://bugzilla.wikimedia.org/71462 (10Spinningspark) 3NEW p:3Unprio s:3normal a:3None Intention: ISBN ending in X is not shown as a link     Reproducible: Didn't try
[13:00:03] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Fix JS error in mostly-dead Opera compat code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163660 (owner: 10Catrope)
[13:01:36] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix JS error in mostly-dead Opera compat code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163660 (owner: 10Catrope)
[14:15:24] <grrrit-wm>	 (03PS1) 10Jforrester: Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's [VisualEditor/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163852 (https://bugzilla.wikimedia.org/71373) 
[14:15:48] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's [VisualEditor/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163852 (https://bugzilla.wikimedia.org/71373) (owner: 10Jforrester)
[14:17:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's [VisualEditor/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163852 (https://bugzilla.wikimedia.org/71373) (owner: 10Jforrester)
[14:52:10] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core sub-module to wmf/1.25wmf1 for cherry-pick (560f89e) [extensions/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163859 
[14:52:30] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf1] "Uncaught NotFoundError: Failed to execute 'insertBefore' on 'Node': .." while inserting a comment - 10https://bugzilla.wikimedia.org/71418#c6 (10Ritu Swain) Issue resolved in test2, but can be reproduced in beta.
[14:58:35] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (0677c3b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163861 
[14:58:49] <James_F>	 MatmaRex: Feel like +2ing that?
[14:59:08] <MatmaRex>	 sure
[14:59:19] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (0677c3b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163861 (owner: 10Jforrester)
[14:59:42] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Update VE core sub-module to wmf/1.25wmf1 for cherry-pick (560f89e) [extensions/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163859 (owner: 10Jforrester)
[15:00:21] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Fix JS error in mostly-dead Opera compat code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163660 (owner: 10Catrope)
[15:00:27] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Fix JS error in mostly-dead Opera compat code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163660 (owner: 10Catrope)
[15:00:40] <James_F>	 Thanks. :-)
[15:00:49] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417#c3 (10Ritu Swain) (In reply to James Forrester from comment #2) > I believe this has now been fixed and backported as part of the fix...
[15:01:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (0677c3b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163861 (owner: 10Jforrester)
[15:01:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core sub-module to wmf/1.25wmf1 for cherry-pick (560f89e) [extensions/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163859 (owner: 10Jforrester)
[15:02:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix JS error in mostly-dead Opera compat code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163660 (owner: 10Catrope)
[15:21:00] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Link inspector does not close when clicking out into non-linked text - 10https://bugzilla.wikimedia.org/71373 (10James Forrester) 5PATC>3RESO/FIX
[15:21:35] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Link inspector does not close when clicking out into non-linked text - 10https://bugzilla.wikimedia.org/71373#c8 (10James Forrester) a:5Ed Sanders>3Roan Kattouw Merged into master and deployed to wmf1.
[15:45:02] <wikibugs>	 3VisualEditor: style issue: Cite/Basic/General references text misaligned in Chrome especially - 10https://bugzilla.wikimedia.org/71470 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 16632   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16632&action=edit Truncated text Chr...
[15:46:17] <wikibugs>	 3VisualEditor: style issue: Cite/Basic/General references text misaligned in Chrome especially - 10https://bugzilla.wikimedia.org/71470#c1 (10James Forrester) 5NEW>3RESO/DUP   *** This bug has been marked as a duplicate of bug 71178 ***
[15:46:17] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: "Use this Group" menu items, in Reference / Reference list dialogs, have a cut-off display - 10https://bugzilla.wikimedia.org/71178#c7 (10James Forrester) *** Bug 71470 has been marked as a duplicate of this bug. ***
[15:49:47] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf1]: “Uncaught TypeError: Cannot read property 'disconnect' of undefined”  on closing the Options dialog, after inserting and deleting categories. - 10https://bugzilla.wikimedia.org/71471 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Create...
[15:50:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf1]: “Uncaught TypeError: Cannot read property 'disconnect' of undefined”  on closing the Options dialog, after inserting and deleting categories. - 10https://bugzilla.wikimedia.org/71471#c1 (10Ritu Swain) Created attachment 16634   --> https://bugzil...
[15:50:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf1]: “Uncaught TypeError: Cannot read property 'disconnect' of undefined”  on closing the Options dialog, after inserting and deleting categories. - 10https://bugzilla.wikimedia.org/71471 (10Ritu Swain)
[16:16:52] <edsanders>	 MatmaRex, is the fact my stylesheet isn't outputting mw-wiki-logo to do with your Vector refactoring?
[16:17:57] <MatmaRex>	 edsanders: nope
[16:18:07] <edsanders>	 hm
[16:18:10] <MatmaRex>	 edsanders: if you're sure you're running latest core and skin, blame krinkle
[16:18:20] <edsanders>	 I'll do some updates
[16:18:59] <edsanders>	 that's better
[16:30:48] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on svwiki: https://sv.wikipedia.org/?diff=27732757
[16:30:48] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107837420
[16:30:48] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107843916
[16:30:48] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107850370
[16:30:48] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107852604
[16:30:49] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107856011
[16:30:49] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107856797
[16:30:49] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107856919
[16:30:49] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107856976
[16:30:50] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32823756
[16:30:51] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32823809
[16:30:51] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32824743
[16:31:05] <James_F>	 Ick.
[16:35:23] <grrrit-wm>	 (03PS1) 10Esanders: Update to use new selection/range API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163873 
[16:35:25] <grrrit-wm>	 (03PS2) 10Esanders: [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 
[16:36:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update to use new selection/range API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163873 (owner: 10Esanders)
[16:37:45] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417#c4 (10James Forrester) I can't; have you refreshed?  The citation template now opens as expected.
[16:38:00] <grrrit-wm>	 (03PS45) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 
[16:40:11] <grrrit-wm>	 (03PS3) 10Esanders: [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 
[16:40:13] <grrrit-wm>	 (03PS2) 10Esanders: Handle triple click with surface fragments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163849 
[16:40:51] <grrrit-wm>	 (03PS46) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 
[16:43:01] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Adding categories, removing them, then cancelling the dialog throws “Uncaught TypeError: Cannot read property 'disconnect' of undefined”. - 10https://bugzilla.wikimedia.org/71471 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal s:5norm...
[16:47:38] <grrrit-wm>	 (03CR) 10Esanders: "FIXME: this causes horizontal scrolling in the main document" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163228 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński)
[16:53:45] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417#c5 (10Ritu Swain) (In reply to James Forrester from comment #4) > >  >   I checked with a clear history.It still does not open the "A...
[16:54:17] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Table with attribute border=0 is displayed as if border=1 - 10https://bugzilla.wikimedia.org/57295#c4 (10James Forrester) 5REOP>3RESO/FIX (In reply to Raimond Spekking from comment #3) > Maybe a regression: the VE renders the table in > https://de.wikipedia...
[16:54:28] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Ugh, indeed, but that's not this, that's the OOjs UI dependency. :/" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163228 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński)
[16:55:55] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I'll fix it later today (or at least patch it up), I know what's causing it." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163228 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński)
[16:56:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417#c6 (10James Forrester) (In reply to Ritu Swain from comment #5) > I checked with a clear history.It still does not open the "Add a Te...
[17:01:30] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Table with attribute border=0 is displayed as if border=1 - 10https://bugzilla.wikimedia.org/57295#c5 (10Raimond Spekking) 5RESO/FIX>3REOP Sorry, but border=1 is very different from border=0. Your "some light default styling" shows a border. This means, thi...
[17:06:20] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Put in hacks to scrub plugin garbage (e.g. myEventWatcherDiv) - 10https://bugzilla.wikimedia.org/68900#c1 (10Roan Kattouw) Here's a novel one: https://sv.wikipedia.org/?diff=27732757
[17:12:30] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417#c7 (10Ritu Swain) (In reply to James Forrester from comment #6) > (In reply to Ritu Swain from comment #5) > > I checked with a clear...
[17:22:06] <grrrit-wm>	 (03PS4) 10Esanders: [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 
[17:34:59] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: PopupWidget: Position body/anchor using 'margin-left' instead of 'left' [oojs/ui] - 10https://gerrit.wikimedia.org/r/163883 
[17:35:11] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Follow-up: https://gerrit.wikimedia.org/r/163883" [oojs/ui] - 10https://gerrit.wikimedia.org/r/163280 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński)
[17:35:21] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Fixed in https://gerrit.wikimedia.org/r/163883 (I hope)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163228 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński)
[17:35:29] <MatmaRex>	 edsanders: https://gerrit.wikimedia.org/r/163883
[17:36:11] <MatmaRex>	 why is PopupWidget so weird :(
[17:38:00] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "This ought to be reviewed and pulled into VE before next branch cut. I really hope I'm not breaking any other things with this patch, eh." [oojs/ui] - 10https://gerrit.wikimedia.org/r/163883 (owner: 10Bartosz Dziewoński)
[17:39:46] <RoanKattouw>	 TrevorParscal: Please review https://gerrit.wikimedia.org/r/#/c/163883, it's black magic to me
[17:41:32] <MatmaRex>	 it just *is* black magic.
[17:42:13] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] PopupWidget: Position body/anchor using 'margin-left' instead of 'left' [oojs/ui] - 10https://gerrit.wikimedia.org/r/163883 (owner: 10Bartosz Dziewoński)
[17:43:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: PopupWidget: Position body/anchor using 'margin-left' instead of 'left' [oojs/ui] - 10https://gerrit.wikimedia.org/r/163883 (owner: 10Bartosz Dziewoński)
[17:43:45] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417#c8 (10James Forrester) (In reply to Ritu Swain from comment #7) > (In reply to James Forrester from comment #6) > > (In reply to Ritu...
[17:43:55] <James_F>	 RoanKattouw: Note that pull-through is blocked on fixing up the MediaWiki theme pull-through.
[17:44:04] <RoanKattouw>	 Right
[17:44:10] <James_F>	 (/cc TrevorParscal – are you close on that?)
[17:44:15] <RoanKattouw>	 I'll see if the MW core one is mergeable
[17:44:23] <James_F>	 RoanKattouw: Not without breaking VE.
[17:44:34] <James_F>	 RoanKattouw: Trevor said there needed to be local changes in VE-core and VE-MW.
[17:44:45] <TrevorParscal>	 can I get links to those really quickly so I can inspect them
[17:44:46] <TrevorParscal>	 ?
[17:44:51] <James_F>	 Sure.
[17:44:53] <TrevorParscal>	 I just know they need to be done carefully
[17:45:04] <James_F>	 TrevorParscal: The VE-core pull-through is https://gerrit.wikimedia.org/r/#/c/163759/
[17:45:07] <RoanKattouw>	 I think VE-MW may well keep working with Trevor's MW core pull-through
[17:45:08] <RoanKattouw>	 So I'll test that
[17:45:37] <James_F>	 TrevorParscal: https://gerrit.wikimedia.org/r/#/c/163763/ is the MW-core one; that needs skin-scripts line added. Want me to fix up?
[17:45:46] <TrevorParscal>	 yeah, sure
[17:45:51] <James_F>	 OK, one second.
[17:45:54] <TrevorParscal>	 thanks
[17:46:50] <RoanKattouw>	 Uhm
[17:47:01] <RoanKattouw>	 Context anchoring is broken in VE with that change
[17:48:08] <RoanKattouw>	 http://i.imgur.com/vVeevFI.png
[17:48:37] <James_F>	 RoanKattouw: With which change? MediaWiki theme or "Position body/anchor using 'margin-left' instead of 'left'"
[17:48:38] <James_F>	 ?
[17:48:49] <RoanKattouw>	 163763
[17:48:59] <RoanKattouw>	 (MW core pull-through of Trevor's theme commit)
[17:48:59] <James_F>	 RoanKattouw: Ah, OK. Yeah, sounds like we need local changes in VE.
[17:49:08] <James_F>	 (163763 now updated.)
[17:51:12] <RoanKattouw>	 GET http://127.0.0.1/w/resources/lib/oojs-ui/images/textures/pending.gif 404 (Not Found) 
[17:51:37] <James_F>	 That sounds odd. Shouldn't it be using a theme-dependent URL?
[17:51:59] <RoanKattouw>	 Yeah....
[17:52:11] <RoanKattouw>	 that's what grep tells me too
[17:52:21] <RoanKattouw>	 Except, no
[17:52:28] <RoanKattouw>	 resources/lib/oojs-ui/oojs-ui-apex.svg.css
[17:52:30] <RoanKattouw>	 1085:  background-image: /* @embed */ url(images/textures/pending.gif);
[17:52:31] <RoanKattouw>	 1210:  background-image: /* @embed */ url(images/textures/pending.gif);
[17:52:33] <RoanKattouw>	 1613:  background-image: /* @embed */ url(images/textures/pending.gif);
[17:52:34] <James_F>	 Oh dear.
[17:52:34] <RoanKattouw>	 2065:  background-image: /* @embed */ url(themes/apex/images/textures/pending.gif);
[17:52:42] <James_F>	 Want me to fix?
[17:53:04] <RoanKattouw>	 I found the culprits in OOUI
[17:53:17] <RoanKattouw>	 TextInputWidget.less , ActionWidget.less and Dialog.less
[17:53:19] <James_F>	 "'@{oo-ui-default-image-path}/textures/pending.gif"
[17:53:21] <James_F>	 Yeah.
[17:53:22] <RoanKattouw>	 Look at how they use pending.gif
[17:53:23] <RoanKattouw>	 Exactly
[17:53:29] * James_F tsks TrevorParscal.
[17:53:55] <James_F>	 Also, this is why it doesn't work in MediaWiki theme either, presumably?
[17:53:55] <InezK>	 Are you guys in the office today?
[17:54:06] <RoanKattouw>	 Speaking of the office, I should head in
[17:54:07] <TrevorParscal>	 I'm not
[17:54:11] <James_F>	 InezK: Krinkle and I am; RoanKattouw will be; TrevorParscal isn't.
[17:54:15] <InezK>	 I will be passing by around 1pm, was thinking about stopping by to say hi
[17:54:19] <James_F>	 InezK: Do so!
[17:54:38] <TrevorParscal>	 RoanKattouw: you don't like the many pending images of doom?
[17:54:55] <InezK>	 Ok, see you after 1pm
[17:55:28] <RoanKattouw>	 TrevorParscal: I like them, they're just hiding very well
[17:55:41] <RoanKattouw>	 TrevorParscal: Also have you seen http://i.imgur.com/vVeevFI.png ?
[17:56:01] <TrevorParscal>	 i just noticed that in the ve pull through
[17:56:16] <TrevorParscal>	 have you identified the culprit yet?
[17:57:02] <TrevorParscal>	 I think it's to do with using the wrong css prop post 163883
[17:57:21] <James_F>	 TrevorParscal: How do you actually /use/ images in CSS now?
[17:57:43] <RoanKattouw>	 TrevorParscal: I haven't debugged it, was hoping you could
[17:58:05] <TrevorParscal>	 James_F: what do you mean?
[17:58:23] <TrevorParscal>	 like the new icon stuff?
[17:58:36] <RoanKattouw>	 The pending texture in particular
[17:58:39] <James_F>	 TrevorParscal: 'Cos ".oo-ui-background-image('@{oo-ui-default-image-path}/textures/pending.gif');" looks right.
[17:58:56] <James_F>	 TrevorParscal: But it generates images/textures/pending.gif rather than themes/apex/images/textures/pending.gif in some cases.
[17:59:03] <RoanKattouw>	 No, in all cases
[17:59:13] <James_F>	 RoanKattouw: "2065:  background-image: /* @embed */ url(themes/apex/images/textures/pending.gif); "
[17:59:15] <RoanKattouw>	 default-image-path doesn't have any images in it any more, all images are theme-specific now AFAIK
[17:59:24] <TrevorParscal>	 why do we have to use a variable?
[17:59:29] <James_F>	 RoanKattouw: No, "@oo-ui-default-image-path: 'themes/apex/images'; "
[17:59:35] <James_F>	 RoanKattouw: See images.less in Apex.
[17:59:36] <TrevorParscal>	 even aside from that
[17:59:45] <James_F>	 TrevorParscal: I don't know, you wrote it. :-)
[17:59:50] <TrevorParscal>	 there are no images in the core styles anymore
[18:00:08] <RoanKattouw>	 There are
[18:00:12] <RoanKattouw>	 Three uses of pending.gif
[18:00:14] <James_F>	 TrevorParscal: So Dialog.less etc. shouldn't have this, it should be moved into each theme?
[18:00:28] <TrevorParscal>	 yeah
[18:00:43] <TrevorParscal>	 i thought I already made that change...
[18:00:44] <TrevorParscal>	 ugh
[18:00:54] <James_F>	 TrevorParscal: Grep for @{oo-ui-default-image-path}
[18:00:58] <James_F>	 TrevorParscal: Three hits.
[18:02:28] <RoanKattouw>	 Also what's up with .icon();
[18:02:39] <RoanKattouw>	 Minerva's elements.less calls it but it doesn't seem to be defined anywhere
[18:02:51] <TrevorParscal>	 that's just a whole other messy thing they did
[18:04:02] <TrevorParscal>	 so, the popup anchor needs shifting..
[18:05:24] <TrevorParscal>	 -1.125em on Apex and -1.5em on MediaWiki
[18:07:46] <TrevorParscal>	 and https://gerrit.wikimedia.org/r/#/c/163883 seems to have no effect on this
[18:08:01] <RoanKattouw>	 No but it's needed separately
[18:08:07] <RoanKattouw>	 I can see why in my local VE now
[18:08:20] <RoanKattouw>	 The popups for the edit notice and stuff cause a horizontal scrollbar
[18:08:40] <RoanKattouw>	 Because their parent is positioned where they would be if the anchor was left-aligned, then the popup is relatively positioned from there
[18:09:01] <RoanKattouw>	 So it renders correctly (except for that adjustment) but it takes up space as if it was left-anchored
[18:09:34] <TrevorParscal>	 yeah, I'm trying to figure out how to not need to special case the styling for each theme, that seems crap
[18:10:57] <TrevorParscal>	 i think it's due to the way I ended up doing the triangle stuff
[18:11:06] <TrevorParscal>	 working on an alternate approach
[18:12:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417#c9 (10Ritu Swain) Thank you once again :), will keep that in mind.
[18:14:50] <grrrit-wm>	 (03PS1) 10Catrope: Account for categories being removed twice in MWCategoryWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163887 (https://bugzilla.wikimedia.org/71471) 
[18:15:46] <James_F>	 RoanKattouw: I thought Krenair was going to work on that, and you were going to come in? :-P
[18:15:56] <James_F>	 (Sorry Krenair.)
[18:16:17] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Adding categories, removing them,  then cancelling the dialog throws “Uncaught TypeError: Cannot read property 'disconnect' of undefined”. - 10https://bugzilla.wikimedia.org/71471 (10James Forrester) a:5Alex Monk>3Roan Kattouw
[18:16:53] <RoanKattouw>	 Yeah I'll head in now
[18:18:05] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Handle triple click with surface fragments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163849 (owner: 10Esanders)
[18:18:48] <RoanKattouw>	 Sorry I didn't realize that bug had been assigned to Krenair 
[18:19:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Handle triple click with surface fragments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163849 (owner: 10Esanders)
[18:36:45] <kaity>	 hey James_F
[18:36:51] <James_F>	 Hey.
[18:37:06] <kaity>	 should we send that survey soon or wait until after quarterly review?
[18:37:29] <James_F>	 Maybe wait?
[18:38:35] <kaity>	 James_F: ok cool
[18:42:01] <Krenair>	 James_F, RoanKattouw: I had been planning to, but okay.
[18:42:11] <Krenair>	 (I hadn't started work on it. Just finished dinner.)
[18:43:11] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Correct the left positioning of a popup wrapper [oojs/ui] - 10https://gerrit.wikimedia.org/r/163893 
[18:43:22] <TrevorParscal>	 ok, that should do it
[18:43:31] <TrevorParscal>	 a detail that got lost in the theme changes
[18:49:57] <TrevorParscal>	 RoanKattouw_away: https://gerrit.wikimedia.org/r/#/c/163893/ needs to be merged and included in the ve core pull through
[18:51:53] <grrrit-wm>	 (03PS2) 10Catrope: Correct the left positioning of a popup wrapper [oojs/ui] - 10https://gerrit.wikimedia.org/r/163893 (owner: 10Trevor Parscal)
[18:52:04] <RoanKattouw>	 OK
[18:52:36] <RoanKattouw>	 TrevorParscal: So your commit message says something about "a theme-independent way"
[18:52:42] <RoanKattouw>	 but your commit only touches theme-specific files
[18:53:05] <RoanKattouw>	 Is the body of the commit message describing something you would like to happen rather than what you actually did?
[18:56:29] <TrevorParscal>	 well, maybe it reads a little odd
[18:56:49] <TrevorParscal>	 the point is that themes should not move the wrapper, just align things relative to it
[18:57:07] <TrevorParscal>	 so the wrapper can always be set in software to the right place, and all themes will work correctly
[18:57:44] <RoanKattouw>	 Oh OK
[18:57:49] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Correct the left positioning of a popup wrapper [oojs/ui] - 10https://gerrit.wikimedia.org/r/163893 (owner: 10Trevor Parscal)
[18:58:38] <RoanKattouw>	 I will rebuild the pull-throughs to include that commit once it merges
[18:59:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Correct the left positioning of a popup wrapper [oojs/ui] - 10https://gerrit.wikimedia.org/r/163893 (owner: 10Trevor Parscal)
[18:59:56] <TrevorParscal>	 thanks man
[19:00:02] <RoanKattouw>	 TrevorParscal: What about pending.gif?
[19:00:50] <TrevorParscal>	 i can put another commit together that moves that to themes
[19:01:05] <James_F>	 That'd be good.
[19:05:44] <RoanKattouw>	 OK there you go
[19:05:50] <RoanKattouw>	 https://gerrit.wikimedia.org/r/163763
[19:06:01] <RoanKattouw>	 I gotta go to lunch now
[19:10:08] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Move references to pending.gif to the themes that provide it [oojs/ui] - 10https://gerrit.wikimedia.org/r/163900 
[19:16:46] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Move references to pending.gif to the themes that provide it [oojs/ui] - 10https://gerrit.wikimedia.org/r/163900 (owner: 10Trevor Parscal)
[19:16:49] <James_F>	 TrevorParscal: Nice. Thanks.
[19:17:20] <TrevorParscal>	 been eating while I work... going to go get some fresh air - be back soon
[19:17:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move references to pending.gif to the themes that provide it [oojs/ui] - 10https://gerrit.wikimedia.org/r/163900 (owner: 10Trevor Parscal)
[19:18:05] <James_F>	 TrevorParscal: Kk.
[19:24:24] <grrrit-wm>	 (03PS5) 10Esanders: [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 
[19:25:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 (owner: 10Esanders)
[19:46:00] <edsanders>	 RoanKattouw_away, TrevorParscal I have a question for you slackers
[19:54:10] <grrrit-wm>	 (03PS6) 10Esanders: [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 
[20:15:13] <TrevorParscal>	 edsanders: sup?
[20:20:29] <edsanders>	 table selections
[20:20:47] <edsanders>	 and how to describe them
[20:21:21] <edsanders>	 my current draft is [tableNode, (row, col)From, (row, col)To ]
[20:22:06] <edsanders>	 which leaves two questions
[20:22:12] <edsanders>	 1. How do you serialize that
[20:22:37] <edsanders>	 2. How do you preserve it through transactions (cf. tx.translateRange)
[20:26:45] <edsanders>	 maybe replace tableNode with tableNode.getOuterRange().start ?
[20:28:20] <mooeypoo>	 is there a special jsDoc way to denote a method that's being overriden ?
[20:28:29] <mooeypoo>	 Other than saying it in the method description, of course. 
[20:29:28] <mooeypoo>	 as in, purposefully overriding behavior
[20:40:44] <edsanders>	 ping TrevorParscal 
[20:40:45] <James_F>	 mooeypoo: No.
[20:41:35] <TrevorParscal>	 hi
[20:43:54] <RoanKattouw>	 mooeypoo: Can you explain what you want to document exactly?
[20:44:02] <mooeypoo>	 I feel like I'm abusing OOUI with this code.
[20:44:25] <mooeypoo>	 RoanKattouw, I'm just overriding a base behavior of the select widget and an event along with it
[20:44:46] <RoanKattouw>	 edsanders: Yeah you'd probably need to store tableNode's start offset anyway, because nodes are ephemeral so onTransact you might have to update / invalidate the node refernce
[20:45:01] <edsanders>	 yes
[20:45:18] <mooeypoo>	 so, instead of it emitting select (and doing nothing else) on clicking an item, I'm building an info window when it's selected, and I'm not emiting the 'select' until the user actually approves the selection.
[20:45:19] <edsanders>	 but also a transaction might delete your table
[20:45:41] <RoanKattouw>	 Rigtht
[20:46:07] <RoanKattouw>	 mooeypoo: I think you just redefine the documentation in that case. You can use @inheritdoc to inherit the things you don't redefine
[20:46:38] <RoanKattouw>	 edsanders: Yeah, hmm, how do you translate across that, or a row in the middle of your selection getting removed, or split/merge operations
[20:46:40] <mooeypoo>	 Yeah, I rewrote the documentation, but it's a relatively big behavior change, I thought there might be a way to emphasize it
[20:46:43] <mooeypoo>	 thanks
[20:48:03] <RoanKattouw>	 re @inheritdoc I'm not sure but Krinkle can correct me if I'm wrong
[20:48:19] <TrevorParscal>	 mooeypoo: what is the use case where you need this?
[20:49:39] <mooeypoo>	 TrevorParscal, the media search dialog. The images appear in the box -- when the user clicks one, it shouldn't be picked, but rather expand an info box (like Google images, more or less) and then the image can be selected only after the user approves the selection
[20:49:44] <mooeypoo>	 this is for the new dialog redesign
[20:49:49] <RoanKattouw>	 edsanders: I'm thinking maybe we can store the start offset of the selection, I feel like that might be more stable than row/col coordinates
[20:49:56] <RoanKattouw>	 Because those coords get weird with merged cells
[20:50:05] <mooeypoo>	 So, it means that the selection is "broken" into 2 parts -- displaying info about the object and only afterwards actually performing "select"
[20:50:23] <mooeypoo>	 hence overriding the parent 
[20:51:10] <edsanders>	 RoanKattouw, we only let the user create bounding rectangles
[20:51:10] <TrevorParscal>	 mooeypoo: are you familiar with the difference between select and choose?
[20:51:36] <RoanKattouw>	 edsanders: Hmm, so here's an idea. A table selection from (r1,c1) to (r2,c2) could theoretically be represented as a selection from (linmod offset of r1c1, linmod offset of r2c2) with gaps that are relatively predictable, is that right?
[20:51:40] <mooeypoo>	 TrevorParscal, oh. ah! Now that you say it, yes, I remember you have it in the other widgets.
[20:51:42] <TrevorParscal>	 select is a by-product of choose, choose is performed when the user takes action (clicking)
[20:51:52] <mooeypoo>	 But the user clicks in this case
[20:52:02] <TrevorParscal>	 you really only need to override the choose behavior though
[20:52:36] <TrevorParscal>	 chooseItem selects and then emits choose
[20:52:53] <mooeypoo>	 TrevorParscal, OO.ui.SearchWidget.prototype.onResultsSelect = function ( item ) 
[20:53:00] <mooeypoo>	 there is no "choose" in that widget? am I missing something?
[20:53:07] <TrevorParscal>	 well... hold up
[20:53:13] <mooeypoo>	 there's only select, because the user actively clicks the widget result.
[20:53:20] <TrevorParscal>	 so, you really need to just stop closing the dialog on choose
[20:53:23] <TrevorParscal>	 that's more my point
[20:53:35] <mooeypoo>	 I want to perform another action, too
[20:53:54] <TrevorParscal>	 right, so on choose you can show the infobox thing
[20:54:05] <RoanKattouw>	 edsanders: So only bounding rectangles, what simplifications does that allow?
[20:54:09] <TrevorParscal>	 and then there is another button somewhere (i presume) you want to use for ACTUAL choosing?
[20:54:21] <TrevorParscal>	 this also makes it work correctly with keyboard
[20:54:22] <mooeypoo>	 yeah
[20:54:35] <TrevorParscal>	 so, don't change the selection model of the widget
[20:54:41] <edsanders>	 well you said the coords get weird with merged cells
[20:54:46] <TrevorParscal>	 just respond to different events
[20:54:47] <TrevorParscal>	 yeah?
[20:55:12] <mooeypoo>	 hm, but the event of the user clicking the result is "select" event.
[20:55:18] <Krinkle>	 mooeypoo: RoanKattouw: @inheritdoc all or nothing.
[20:55:30] <RoanKattouw>	 edsanders: I guess maybe not
[20:55:35] <TrevorParscal>	 mooeypoo: the user clicking will emit both select and choose
[20:55:41] <TrevorParscal>	 you want to behave on choose
[20:55:45] <mooeypoo>	 TrevorParscal, so, either I emit select but I ignore it in the dialog and then emit "choose" and work on *that*
[20:56:01] <mooeypoo>	 TrevorParscal, it ... doesn't seem to emit choose though? I'm missing something I think.
[20:56:01] <RoanKattouw>	 Oooh because our coord system double-counts (or triple-counts or whatever) merged cells, so it's fine?
[20:56:21] <mooeypoo>	 TrevorParscal, in ooui:
[20:56:22] <mooeypoo>	 OO.ui.SearchWidget.prototype.onResultsSelect = function ( item ) {
[20:56:22] <mooeypoo>	 	this.emit( 'select', item ? item.getData() : null );
[20:56:22] <mooeypoo>	 };
[20:56:22] <TrevorParscal>	 it happens where there's deliberate action taken on an item, unlike highlight or select which are used for hovering/keying through or setting the state programatically
[20:56:23] <edsanders>	 the table model breaks it down into a full grid
[20:56:31] <RoanKattouw>	 Right, yeah
[20:56:38] <edsanders>	 then for a given start/end works out a rectangle that doesn't cut up merged cells
[20:56:39] <TrevorParscal>	 see OO.ui.SelectWidget.prototype.chooseItem
[20:56:50] <edsanders>	 I think it's odd to use a range to define the start/end
[20:57:03] <RoanKattouw>	 OK, yeah, so then maybe we don't need that
[20:57:07] <RoanKattouw>	 So let's see what can happen
[20:57:08] <mooeypoo>	 ahha
[20:57:14] <edsanders>	 it feels fragile
[20:57:16] <RoanKattouw>	 Rows or columns can be inserted
[20:57:31] <RoanKattouw>	 Then we would potentially have to translate the selection's coords for that
[20:57:34] <edsanders>	 like if with some translations the end offset ends up inside a nested table
[20:58:00] <edsanders>	 I'm thinking to begin with the only translation we do is clipping
[20:58:18] <RoanKattouw>	 Clipping?
[20:58:18] <edsanders>	 and converting to null when the table is deleted
[20:58:24] <TrevorParscal>	 mooeypoo: the trick is that choose is an event only emitted when the user makes a choice
[20:58:28] <edsanders>	 you select all and the table gets smaller
[20:58:35] <RoanKattouw>	 Oh I see
[20:58:35] <TrevorParscal>	 select is emitted when the control is changed (by the user or the software)
[20:59:07] <RoanKattouw>	 So clipping in the graphics processing sense: you fix out-of-bound coords by setting them to the new boundary value
[20:59:29] <edsanders>	 right
[20:59:32] <RoanKattouw>	 That's sensible
[20:59:55] <mooeypoo>	 TrevorParscal, hmmm. Okay, this makes sense
[21:00:05] <RoanKattouw>	 I think using a (r1,c1),(r2,c2) representation and translating that is sensible
[21:00:15] <RoanKattouw>	 I just hope that translating for column insertions won't be too hard
[21:00:22] <edsanders>	 I don't think it matters so much if you destroy a table selection, mostly because insert/delete row/col is pretty uncommon
[21:00:57] <RoanKattouw>	 We'd also have to define what happens when a cell at the boundary gets split/merged, in theory, but in practice that probably can't arise except in collaboration cases
[21:01:24] <RoanKattouw>	 Right and if we select the inserted row/col after inserting it or just clear the selection, that would be fine too
[21:01:31] <edsanders>	 right
[21:01:41] <RoanKattouw>	 For removing rows/cols, you could assume that the thing being removed was previously selected, so you clear the selection
[21:03:10] <edsanders>	 I think in translateTableSelection we will have to check if any transactions happened inside the tableNode @ tableNodeOffset (fetched from DM tree)
[21:03:14] <mooeypoo>	 TrevorParscal, \o/ it works! thanks!
[21:03:20] <TrevorParscal>	 RoanKattouw: are you gonna regenerate this? 163759
[21:03:28] <TrevorParscal>	 mooeypoo: n/p
[21:04:23] <RoanKattouw>	 TrevorParscal: Oh yes I should do that
[21:05:15] <edsanders>	 RoanKattouw, will probably go with tableNodeRange, because we already have translateRange methods, and it may be useful to have the end offset
[21:05:31] <RoanKattouw>	 edsanders: Right. Which is just foreach ( tx ) { intersect( tx.getAffectedRange(), table.getOuterRange() ) not empty }
[21:05:41] <RoanKattouw>	 Yeah tha's sensible
[21:08:45] <edsanders>	 RoanKattouw, https://docs.google.com/document/d/1yBE_086jqPDoG9YMYykSJwurxPifGhRsOCZl7cf6b2o/edit
[21:08:55] <edsanders>	 what happens if you insert a col into the middle of the bottom table
[21:08:59] <edsanders>	 I have a row selected
[21:09:31] <edsanders>	 ah, I did it with a private window
[21:09:39] <edsanders>	 they expand the table selection
[21:10:27] <RoanKattouw>	 Can you merge/split cells in gdocs?
[21:10:57] <RoanKattouw>	 Because, if so, what happens if I split the cell your selection starts in?
[21:11:03] <RoanKattouw>	 I mean I think I know what should happen but still
[21:11:10] <edsanders>	 it appears to have a left bias too
[21:11:28] <edsanders>	 insert left expands the range, but not right
[21:12:09] <edsanders>	 can't see any merge/split tools
[21:13:42] <edsanders>	 you can't even paste one in
[21:23:04] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Put in hacks to scrub plugin garbage (e.g. myEventWatcherDiv) - 10https://bugzilla.wikimedia.org/68900#c2 (10Alex Monk) I wonder if we can just do something like this  $( newDoc )     .remove( '[id=myEventWatcherDiv]' ) // Bug 51423     .remove( 'object[t...
[21:23:04] <wikibugs>	 3OOjs UI: OOjs UI: Issues with button placement and sizing on first open - 10https://bugzilla.wikimedia.org/70061#c4 (10Bartosz Dziewoński) Are there are particular issues known? Or reproduction instructions? This is "high priority" and completely not actionable :(
[21:26:00] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Put in hacks to scrub plugin garbage (e.g. myEventWatcherDiv) - 10https://bugzilla.wikimedia.org/68900#c3 (10Roan Kattouw) (In reply to Alex Monk from comment #2) > I wonder if we can just do something like this >  > $( newDoc ) >  .remove( '[id=myEventWa...
[21:26:06] <RoanKattouw>	 Krenair: Yes let's do that
[21:27:01] <Krenair>	 I guess I'll upload a patch then
[21:27:26] <RoanKattouw>	 Cool
[21:29:38] <Krenair>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=67006 and https://bugzilla.wikimedia.org/show_bug.cgi?id=69513 look harder to deal with, leaving those for now
[21:30:14] <Krenair>	 (first one: eh, we could div[id^=kloutify], but that wouldn't be complete)
[21:34:30] <RoanKattouw>	 Yeah <!--[if gte mso 0]> is harder to find, but we should probably be filtering that in our paste handler instead
[21:36:41] <grrrit-wm>	 (03PS4) 10Catrope: Update OOjs UI to v0.1.0-pre (afa3241e8e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163759 
[21:38:20] <grrrit-wm>	 (03PS1) 10Alex Monk: Remove certain blacklisted elements when getting HTML from document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163961 (https://bugzilla.wikimedia.org/68900) 
[21:39:05] <Krenair>	 Hm. Don't think I've linked so many bugs from a single patch before.
[21:40:41] <James_F>	 :-)
[21:40:55] <Krenair>	 (sorry about your inboxes.)
[21:41:16] <James_F>	 Krenair: Only 9.
[21:42:17] <Krenair>	 I get the impression that some people think that's a lot
[21:42:28] * James_F grins.
[21:42:38] <Krenair>	 Also, 18 for any client not doing threading
[21:43:06] <Krenair>	 because, IIRC bugzilla api forces it to post the comment and change status in two separate actions
[21:43:25] <James_F>	 Yeah. Boo Bugzilla.
[21:43:34] <James_F>	 If only we were about to switch to a different system…
[21:43:36] <James_F>	 ;-)
[21:43:40] <Krenair>	 haha
[21:43:42] <Krenair>	 Anyway I guess if this gets merged, we can mark 68900 as fixed
[21:44:22] <Krenair>	 As for the rest of them... I guess I'll start recording any new occurrences of those on wikis with the patch
[21:44:33] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (afa3241e8e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163759 (owner: 10Catrope)
[21:44:42] * James_F nods.
[21:46:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (afa3241e8e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163759 (owner: 10Catrope)
[21:47:12] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Remove certain blacklisted elements when getting HTML from document (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163961 (https://bugzilla.wikimedia.org/68900) (owner: 10Alex Monk)
[21:49:22] <mooeypoo>	 what in the name of all that is imagey--- the API has 0-length thumbnails
[21:49:31] <mooeypoo>	 0-width / 0-height
[21:49:49] <RoanKattouw>	 WTF
[21:49:57] <James_F>	 mooeypoo: That's for audio files, right?
[21:50:09] <mooeypoo>	 Yes
[21:50:11] <Krenair>	 RoanKattouw, I'd prefer to keep the spaces... :p
[21:50:17] <mooeypoo>	 But there is a thumbnail
[21:50:22] <Krenair>	 will use quotes instead of escaping though
[21:50:23] <mooeypoo>	 and it does have width and height.
[21:50:25] <mooeypoo>	 hm
[21:50:29] <RoanKattouw>	 Krenair: Fine with me, you're apparently allowed spaces there which I didn't know
[21:50:46] <mooeypoo>	 http://bits.wikimedia.org/static-1.25wmf1/resources/assets/file-type-icons/fileicon-ogg.png <-- thumb from the API
[21:50:47] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] "Uncaught TypeError: undefined is not a function", when using media search dialog - 10https://bugzilla.wikimedia.org/70860 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal a:3Moriel Schottlender
[21:51:01] <mooeypoo>	 so, it's ogg files, but the *image* is an image. Anyways. Yes. Confusing.
[21:51:11] <grrrit-wm>	 (03PS2) 10Alex Monk: Remove certain blacklisted elements when getting HTML from document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163961 (https://bugzilla.wikimedia.org/68900) 
[21:51:33] <James_F>	 mooeypoo: Yeah.
[21:51:44] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Remove certain blacklisted elements when getting HTML from document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163961 (https://bugzilla.wikimedia.org/68900) (owner: 10Alex Monk)
[21:52:13] <James_F>	 mooeypoo: We need to invent a treatment for audio and video files, and multi-page files, BTW.
[21:52:31] <mooeypoo>	 Yeah
[21:52:38] <mooeypoo>	 Right now I'm trying to just "deal" with them.
[21:52:52] <mooeypoo>	 They're fighting back, but I am holding on.
[21:53:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove certain blacklisted elements when getting HTML from document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163961 (https://bugzilla.wikimedia.org/68900) (owner: 10Alex Monk)
[21:53:20] <James_F>	 :-)
[21:54:31] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Put in hacks to scrub plugin garbage (e.g. myEventWatcherDiv) - 10https://bugzilla.wikimedia.org/68900#c6 (10Alex Monk) 5PATC>3RESO/FIX Marking this as fixed, will keep an eye on the others in the next couple of weeks or so to see if those are resolve...
[21:54:45] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Put in hacks to scrub plugin garbage (e.g. myEventWatcherDiv) - 10https://bugzilla.wikimedia.org/68900 (10Alex Monk)
[21:56:18] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Try to stop user from tabbing outside of open dialog box [oojs/ui] - 10https://gerrit.wikimedia.org/r/159902 (https://bugzilla.wikimedia.org/67156) (owner: 10Alex Monk)
[21:57:00] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Table with attribute border=0 is displayed as if border=1 - 10https://bugzilla.wikimedia.org/57295#c6 (10James Forrester) 5REOP>3RESO/WON (In reply to Raimond Spekking from comment #5) > Sorry, but border=1 is very different from border=0. Your "some light...
[21:57:18] <RoanKattouw>	 TrevorParscal: So the OOUI pull-throughs have landed now :)
[21:57:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Try to stop user from tabbing outside of open dialog box [oojs/ui] - 10https://gerrit.wikimedia.org/r/159902 (https://bugzilla.wikimedia.org/67156) (owner: 10Alex Monk)
[21:57:27] <RoanKattouw>	 TrevorParscal: What are you up to? Wanna do some OOUI code review for me?
[21:57:35] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Broken OpenODBC browser plugin causes "application/iodbc" to be injected into the page - 10https://bugzilla.wikimedia.org/51521 (10James Forrester) 5PATC>3RESO/FIX a:3Alex Monk
[21:57:49] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Broken DivX browser plugin causes "myEventWatcherDiv" to be injected into the page - 10https://bugzilla.wikimedia.org/51423 (10James Forrester) 5PATC>3RESO/FIX a:3Alex Monk
[21:58:03] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Yet Another Broken Browser Plugin Injecting Garbage in Pages (Norton?) - 10https://bugzilla.wikimedia.org/63229 (10James Forrester) 5PATC>3RESO/FIX a:3Alex Monk
[21:58:33] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor:  Instapaper plug-in injects div tags into pages - 10https://bugzilla.wikimedia.org/61776 (10James Forrester) 5PATC>3RESO/FIX a:3Alex Monk
[21:58:46] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor:  Web Thunder Helper Plugin (download) leaves garbage in pages - 10https://bugzilla.wikimedia.org/63121 (10James Forrester) 5PATC>3RESO/FIX a:3Alex Monk
[21:59:04] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Broken DataVault browser plugin causes "application/x-datavault" to be injected into the page - 10https://bugzilla.wikimedia.org/52791 (10James Forrester) 5PATC>3RESO/FIX a:3Alex Monk
[21:59:04] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Do not let me tab outside the dialog box in Chrome/Safari - 10https://bugzilla.wikimedia.org/67156#c8 (10Alex Monk) 5PATC>3RESO/FIX Merged. Hopefully this doesn't break anything else.
[21:59:16] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Broken Foxlingo Firefox extension injects javascript into page - 10https://bugzilla.wikimedia.org/52884 (10James Forrester) 5PATC>3RESO/FIX a:3Alex Monk
[21:59:31] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Evernote Web Clipper inserts _clearly_component__css - 10https://bugzilla.wikimedia.org/53252 (10James Forrester) 5PATC>3RESO/FIX a:3Alex Monk
[21:59:50] <James_F>	 Krenair: Did you miss https://bugzilla.wikimedia.org/show_bug.cgi?id=67006 accidentally or is it not blockable?
[22:00:17] <Krenair>	 I misread it earlier.
[22:00:21] <Krenair>	 Should be blockable easily.
[22:00:24] <James_F>	 Kk.
[22:00:25] <James_F>	 Assigned.
[22:00:46] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Broken Kloutify browser extension injects garbage into the page - 10https://bugzilla.wikimedia.org/67006 (10James Forrester) a:3Alex Monk
[22:00:57] <grrrit-wm>	 (03CR) 10Jforrester: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 (owner: 10Esanders)
[22:03:03] <grrrit-wm>	 (03PS1) 10Alex Monk: Blacklist div[id = kloutify] as well [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163968 (https://bugzilla.wikimedia.org/67006) 
[22:03:27] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Blacklist div[id = kloutify] as well [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163968 (https://bugzilla.wikimedia.org/67006) (owner: 10Alex Monk)
[22:03:41] <James_F>	 GJ. :-)
[22:03:47] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Broken Kloutify browser extension injects garbage into the page - 10https://bugzilla.wikimedia.org/67006 (10James Forrester) 5PATC>3RESO/FIX
[22:05:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Blacklist div[id = kloutify] as well [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163968 (https://bugzilla.wikimedia.org/67006) (owner: 10Alex Monk)
[22:05:04] <Krenair>	 Somehow I thought it said <div id="kloutify"></div><div></div><div id="kloutify-score">10</div> (the last </div> moved immediately after the first <div>)
[22:05:30] * James_F nods.
[22:05:31] <Krenair>	 reading is hard.
[22:05:38] <James_F>	 Krenair: Review on https://gerrit.wikimedia.org/r/#/c/163887/ appreciated, on the topic of reading. :-)
[22:06:01] <James_F>	 MatmaRex: Review on https://gerrit.wikimedia.org/r/#/c/163333/ and https://gerrit.wikimedia.org/r/#/c/163300/ would be good if you're around.
[22:06:15] <grrrit-wm>	 (03PS11) 10Jforrester: build: Create minified JS and CSS distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 
[22:06:36] <James_F>	 Krinkle: https://gerrit.wikimedia.org/r/#/c/157315/ and https://gerrit.wikimedia.org/r/#/c/163653/ would be nice.
[22:07:08] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/163632/ and https://gerrit.wikimedia.org/r/#/c/163659/ similarly.
[22:08:06] <RoanKattouw>	 James_F: I was trying to dump those on Trevor
[22:08:11] <James_F>	 RoanKattouw: Which ones?
[22:08:53] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Account for categories being removed twice in MWCategoryWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163887 (https://bugzilla.wikimedia.org/71471) (owner: 10Catrope)
[22:09:45] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Adding categories, removing them,  then cancelling the dialog throws “Uncaught TypeError: Cannot read property 'disconnect' of undefined”. - 10https://bugzilla.wikimedia.org/71471 (10Alex Monk) 5PATC>3RESO/FIX
[22:09:46] <RoanKattouw>	 Thanks
[22:10:12] <Krenair>	 (back soon)
[22:10:13] <MatmaRex>	 James_F: can do
[22:10:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Account for categories being removed twice in MWCategoryWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163887 (https://bugzilla.wikimedia.org/71471) (owner: 10Catrope)
[22:10:46] <MatmaRex>	 i've been poking at https://bugzilla.wikimedia.org/show_bug.cgi?id=70724 and probably will file a firefox bug after i make a small test case
[22:11:16] <MatmaRex>	 since it clearly looks like firefox gets confused about its native selections
[22:12:22] <James_F>	 MatmaRex: Thanks.
[22:13:06] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032 V: 032] Add --config to override path to localsettings.js [services/citoid] - 10https://gerrit.wikimedia.org/r/163793 (owner: 10Catrope)
[22:13:21] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032 V: 032] Add localsettings.js file [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163792 (owner: 10Catrope)
[22:13:22] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032 V: 032] Add localsettings.js file [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163792 (owner: 10Catrope)
[22:13:36] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032 V: 032] Add node_modules directory [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163320 (owner: 10Catrope)
[22:13:37] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032 V: 032] Add node_modules directory [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163320 (owner: 10Catrope)
[22:14:11] <grrrit-wm>	 (03PS2) 10Jforrester: Add build of Zotero translation server [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163321 (owner: 10Catrope)
[22:14:12] <grrrit-wm>	 (03PS2) 10Jforrester: Add build of Zotero translation server [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163321 (owner: 10Catrope)
[22:14:14] <grrrit-wm>	 (03PS3) 10Jforrester: Add build of Zotero translation server [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163321 (owner: 10Catrope)
[22:14:15] <grrrit-wm>	 (03PS3) 10Jforrester: Add build of Zotero translation server [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163321 (owner: 10Catrope)
[22:14:33] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/163795/
[22:17:15] <TrevorParscal>	 RoanKattouw: here 
[22:17:57] <RoanKattouw>	 TrevorParscal: https://gerrit.wikimedia.org/r/163632 is a stack of 4 changes fixing various things
[22:18:08] <TrevorParscal>	 nice
[22:18:09] <TrevorParscal>	 lookin
[22:18:13] <RoanKattouw>	 Or 3 really
[22:18:43] <RoanKattouw>	 The fourth one isn't actually in the stack, it's https://gerrit.wikimedia.org/r/#/c/163586/
[22:19:19] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] TextInputWidget: Don't mix inner and outer heights in calculations [oojs/ui] - 10https://gerrit.wikimedia.org/r/163632 (https://bugzilla.wikimedia.org/71310) (owner: 10Bartosz Dziewoński)
[22:19:35] <RoanKattouw>	 There's also https://gerrit.wikimedia.org/r/163333 (small fix by me), and https://gerrit.wikimedia.org/r/163653 and https://gerrit.wikimedia.org/r/163785 is James tearing up OO.ui.Tool
[22:19:40] <RoanKattouw>	 As you may have noticed the rest is all Bartosz :)
[22:20:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: TextInputWidget: Don't mix inner and outer heights in calculations [oojs/ui] - 10https://gerrit.wikimedia.org/r/163632 (https://bugzilla.wikimedia.org/71310) (owner: 10Bartosz Dziewoński)
[22:20:20] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] "We filing a bug for this upstream?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/163659 (https://bugzilla.wikimedia.org/71310) (owner: 10Bartosz Dziewoński)
[22:20:48] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] WindowManager: Emit 'resize' event when a window is resized [oojs/ui] - 10https://gerrit.wikimedia.org/r/163738 (https://bugzilla.wikimedia.org/71427) (owner: 10Bartosz Dziewoński)
[22:21:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: TextInputWidget: Work around Blink height miscalculation [oojs/ui] - 10https://gerrit.wikimedia.org/r/163659 (https://bugzilla.wikimedia.org/71310) (owner: 10Bartosz Dziewoński)
[22:22:31] <wikibugs>	 3OOjs UI: OOjs UI: TextInputWidget's textarea gets silly scrollbars when it shouldn't - 10https://bugzilla.wikimedia.org/71310 (10James Forrester) 5PATC>3RESO/FIX
[22:22:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: WindowManager: Emit 'resize' event when a window is resized [oojs/ui] - 10https://gerrit.wikimedia.org/r/163738 (https://bugzilla.wikimedia.org/71427) (owner: 10Bartosz Dziewoński)
[22:22:47] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: CommentInspector doesn't update its size when the textarea gets resized - 10https://bugzilla.wikimedia.org/71427 (10James Forrester) p:5Unprio>3Low s:5normal>3minor
[22:23:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: CommentInspector doesn't update its size when the textarea gets resized - 10https://bugzilla.wikimedia.org/71427 (10James Forrester) 5PATC>3RESO/FIX
[22:24:03] <grrrit-wm>	 (03Abandoned) 10Jforrester: build: Implement 'phantomcheck' task [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 (owner: 10Krinkle)
[22:24:21] <RoanKattouw>	 TrevorParscal: Then with that 'resize' change, that opens the door for https://gerrit.wikimedia.org/r/#/c/163674
[22:25:19] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Not convinced this is ready yet." [oojs/ui] - 10https://gerrit.wikimedia.org/r/163785 (owner: 10Jforrester)
[22:25:25] <RoanKattouw>	 TrevorParscal: So please look at that one, and also https://gerrit.wikimedia.org/r/#/c/163586/ https://gerrit.wikimedia.org/r/163333 https://gerrit.wikimedia.org/r/163653 . Then look at whether https://gerrit.wikimedia.org/r/163785 is going in the right direction (but don't merge it quite yet)
[22:25:34] <RoanKattouw>	 TrevorParscal: Then after all that, I'd like to pick your brain about something else OOUI-related
[22:25:57] <TrevorParscal>	 ok, i will let you know when I'm done
[22:26:02] <RoanKattouw>	 Cool
[22:26:03] <RoanKattouw>	 Thanks man
[22:26:14] <RoanKattouw>	 Sorry to dump this on you all at once :|
[22:28:45] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: CommentInspector doesn't update its size when the textarea gets resized - 10https://bugzilla.wikimedia.org/71427#c4 (10James Forrester) 5RESO/FIX>3REOP Spoke too soon.
[22:29:00] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: CommentInspector doesn't update its size when the textarea gets resized - 10https://bugzilla.wikimedia.org/71427 (10James Forrester) 5REOP>3PATC
[22:31:13] <TrevorParscal>	 I'm really confused about https://gerrit.wikimedia.org/r/#/c/163674/4/src/ui/inspectors/ve.ui.CommentInspector.js,unified
[22:31:21] <TrevorParscal>	 textareas wrap text
[22:31:26] <TrevorParscal>	 why are we counting rows?
[22:31:34] <TrevorParscal>	 as defined by split( '
[22:31:38] <TrevorParscal>	 arg...
[22:31:44] <TrevorParscal>	 split( '\n' )
[22:31:52] <TrevorParscal>	 RoanKattouw: ?
[22:32:00] <TrevorParscal>	 MatmaRex: ?
[22:32:04] <RoanKattouw>	 I don't know
[22:32:27] <RoanKattouw>	 The way you say that it sounds like a bad idea
[22:38:04] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] ve.ui.CommentInspector: Update size when the textarea gets resized (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) (owner: 10Bartosz Dziewoński)
[22:41:26] <Krinkle>	 RoanKattouw: https://github.com/karma-runner/karma-qunit/blob/master/Gruntfile.coffee#L69-L75
[22:41:39] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] ClippableElement: Use 'overflow-[xy]: scroll' rather than 'auto' [oojs/ui] - 10https://gerrit.wikimedia.org/r/163586 (https://bugzilla.wikimedia.org/65059) (owner: 10Bartosz Dziewoński)
[22:42:35] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Make this.$.$iframe actually point to an iframe again [oojs/ui] - 10https://gerrit.wikimedia.org/r/163333 (owner: 10Catrope)
[22:42:56] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Tool: Use FlaggedElement mixin to let tools be flagged [oojs/ui] - 10https://gerrit.wikimedia.org/r/163653 (owner: 10Jforrester)
[22:43:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: ClippableElement: Use 'overflow-[xy]: scroll' rather than 'auto' [oojs/ui] - 10https://gerrit.wikimedia.org/r/163586 (https://bugzilla.wikimedia.org/65059) (owner: 10Bartosz Dziewoński)
[22:44:19] <TrevorParscal>	 I do think this is headed in the right direction: https://gerrit.wikimedia.org/r/#/c/163785
[22:44:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make this.$.$iframe actually point to an iframe again [oojs/ui] - 10https://gerrit.wikimedia.org/r/163333 (owner: 10Catrope)
[22:44:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tool: Use FlaggedElement mixin to let tools be flagged [oojs/ui] - 10https://gerrit.wikimedia.org/r/163653 (owner: 10Jforrester)
[22:44:38] <RoanKattouw>	 TrevorParscal: Good to hear
[22:44:56] <RoanKattouw>	 Ultimately what he's working on is making descriptions their own thing so they can be configured separately from titles
[22:45:17] <RoanKattouw>	 (so we can have tools that have a description that isn't the same as the node's description, like "move this image to the left")
[22:45:30] <RoanKattouw>	 As part of that he was splitting up title and label, and then a wild herd of mixins appeared
[22:54:20] <MatmaRex>	 TrevorParscal: oh hmm. yeah, that's silly
[22:55:03] <TrevorParscal>	 The tricky thing here is that depending on the way it's displayed, the title or label may need to contain different things
[22:55:14] <RoanKattouw>	 Yes
[22:55:21] <TrevorParscal>	 as in, which kind of toolgroup
[22:55:32] <RoanKattouw>	 He's also having to work around assumptions like "at construction time I will now what the label needs to be and it won't then change"
[22:55:37] <RoanKattouw>	 Yup
[22:55:41] <RoanKattouw>	 Yeah that's why he's not done yet
[22:55:45] <RoanKattouw>	 There's a fair amount of complexity there
[22:56:03] <TrevorParscal>	 but it sort of suggests we are doing something wrong, like the tool objects are sort of model, view and controller right now, and we need a toolbar model that is separate
[22:56:26] <TrevorParscal>	 I just was... trying not to do MVC( MVC( MVC( MVC( MVC...) ) ) )
[22:56:41] <TrevorParscal>	 which usually is a bad instinct, I should just go for it
[23:03:00] <wikibugs>	 3OOjs UI: OOjs UI: PopupToolGroup shows horizontal scrollbar, tools are not wide enough to contain labels - 10https://bugzilla.wikimedia.org/65059 (10James Forrester) 5PATC>3RESO/FIX
[23:05:20] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (30b0407428) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163982 
[23:06:51] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Looks reasonable, but wow, indirection." (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/163300 (https://bugzilla.wikimedia.org/71178) (owner: 10Alex Monk)
[23:08:47] <grrrit-wm>	 (03CR) 10Catrope: ComboBoxWidget: Append menu to $overlay option (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/163300 (https://bugzilla.wikimedia.org/71178) (owner: 10Alex Monk)
[23:08:51] <James_F>	 RoanKattouw: +2 https://gerrit.wikimedia.org/r/163982 and https://gerrit.wikimedia.org/r/163983 please.
[23:09:10] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (30b0407428) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163982 (owner: 10Jforrester)
[23:10:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (30b0407428) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163982 (owner: 10Jforrester)
[23:15:24] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: ComboBoxWidget: Append menu to $overlay option [oojs/ui] - 10https://gerrit.wikimedia.org/r/163300 (https://bugzilla.wikimedia.org/71178) (owner: 10Alex Monk)
[23:15:42] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: ComboBoxWidget: Append menu to $overlay option [oojs/ui] - 10https://gerrit.wikimedia.org/r/163300 (https://bugzilla.wikimedia.org/71178) (owner: 10Alex Monk)
[23:16:37] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: LookupInputWidget: Fix whitespace and documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/163988 
[23:16:51] <RoanKattouw>	 TrevorParscal: So, can we talk about overlays?
[23:16:56] <TrevorParscal>	 sure
[23:16:58] <TrevorParscal>	 shoot
[23:17:01] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Fixed whitespace." (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/163300 (https://bugzilla.wikimedia.org/71178) (owner: 10Alex Monk)
[23:17:09] <RoanKattouw>	 OK so let me tell you what our problem is
[23:17:19] <RoanKattouw>	 We have a trio of patches that addresses it, but suboptimally
[23:17:34] <RoanKattouw>	 So in the reference and reference list dialogs, we have a ComboBoxWidget
[23:17:50] <RoanKattouw>	 The menu attached to this ComboBoxWidget is likely to be taller than the remaining space in the dialog
[23:18:03] <RoanKattouw>	 which by default causes it to clip because menus are ClippableElements
[23:18:32] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Up/down arrow in Firefox broken after using left/right - 10https://bugzilla.wikimedia.org/70724#c1 (10Bartosz Dziewoński) a:3Bartosz Dziewoński Looks like a browser bug with Firefox's native selection having inconsistent state. I'm going to try poking some mo...
[23:18:42] <RoanKattouw>	 So to address this problem, I told Alex to have ComboBoxWidget support $overlay the same way TextInputMenuWidget does
[23:18:45] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] LookupInputWidget: Fix whitespace and documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/163988 (owner: 10Bartosz Dziewoński)
[23:18:49] <RoanKattouw>	 Which is fine, except then we need to set $overlay to something
[23:19:04] <James_F>	 MatmaRex: Nice.
[23:19:11] <James_F>	 MatmaRex: (re. bug 70724)
[23:19:15] <RoanKattouw>	 My initial instinct was the surface's localOverlay, which doesn't work because the dialog is above it, so most of the menu is obscured and not visible
[23:19:20] <MatmaRex>	 James_F: not nice at all. :>
[23:19:30] <James_F>	 MatmaRex: Nice that you're taking it on. :-)
[23:19:35] <RoanKattouw>	 My second instinct was the global overlay, which results in code that mostly works but has two problems
[23:19:46] <MatmaRex>	 if roan's onto the overlay thingy, then i'm off for today
[23:19:54] <MatmaRex>	 oh also
[23:20:08] <RoanKattouw>	 1) The font size is wrong. localOverlay is inside the surface so it gets its font size corrections, but globalOverlay relies on the things inside it (individual windows) to do font size corrections
[23:20:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: LookupInputWidget: Fix whitespace and documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/163988 (owner: 10Bartosz Dziewoński)
[23:20:20] <MatmaRex>	 James_F: is there a sane way i can share my calendar with the team so y'all know when i won't be available?
[23:20:21] <RoanKattouw>	 2) When you close the dialog, the menu is still visible
[23:20:32] <James_F>	 MatmaRex: Personal or work?
[23:20:39] <RoanKattouw>	 MatmaRex: Thanks for reminding me that I need to stalk your work calendar
[23:20:43] <MatmaRex>	 either?
[23:20:48] <TrevorParscal>	 RoanKattouw: still reading..
[23:21:32] <RoanKattouw>	 MatmaRex: All @wikimedia.org calendars automatically share with each other, so anyone can view anyone else's calednar
[23:21:38] <RoanKattouw>	 My default view has all team members' calendars
[23:21:44] <James_F>	 MatmaRex: Go to https://www.google.com/calendar > Settings > Calendars > Bartosz Dziewonski.
[23:21:45] <RoanKattouw>	 And you can import anyone else's calendar into your view if you like
[23:21:58] <MatmaRex>	 okay
[23:22:08] <RoanKattouw>	 TrevorParscal: OK, so continuing. I have a suggestion for fixing parts of both #1 and #2
[23:22:16] <James_F>	 MatmaRex: And allow me and others to "Make changes to events", please. Makes things easier. :-)
[23:22:23] <MatmaRex>	 then you should probably already see it? i have a calendar on my personal account shared with my work account
[23:22:36] <RoanKattouw>	 I was hoping we could have some sort of overlay for modal Windows that doesn't clip to the iframe boundary but does inherit the font size fixes
[23:22:43] <RoanKattouw>	 Like a second child of div.oo-ui-window maybe
[23:23:00] <RoanKattouw>	 Then what would also take care of hiding the menu when closing
[23:23:00] <James_F>	 MatmaRex: Not unless you're explicitly sharing it, I don't think.
[23:23:15] <RoanKattouw>	 Sharing of calendars is not transitive
[23:23:17] <RoanKattouw>	 Fortunately
[23:23:27] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (859654b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163990 
[23:23:46] <RoanKattouw>	 My personal calendar is shared read/write with my work account, so I can my personal account at work, but my coworkers cannot see my personal calendar
[23:23:54] <RoanKattouw>	 *so I can see my personal calendar at work
[23:23:56] <James_F>	 Ditto.
[23:24:47] <TrevorParscal>	 RoanKattouw: it needs to be bundled with the window on a per-window basis
[23:25:00] <TrevorParscal>	 otherwise you will end up showing the menu with a different dialog
[23:25:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (859654b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163990 (owner: 10Jforrester)
[23:25:13] <RoanKattouw>	 TrevorParscal: Yeah exactly
[23:25:18] <MatmaRex>	 oookay. i think i've got this
[23:25:21] <RoanKattouw>	 Also different windows could in theory have different font sizes I guess
[23:25:35] <MatmaRex>	 can someone verify you can see it?
[23:25:37] <RoanKattouw>	 MatmaRex: If you need a personal event to be visible to us, invite your work account to it
[23:25:53] <RoanKattouw>	 MatmaRex: What am I supposed to see?
[23:25:56] <MatmaRex>	 RoanKattouw: i "re-shared" a shared calendar
[23:25:57] <TrevorParscal>	 so, right now window has an overlay
[23:26:22] <TrevorParscal>	 and we are using it, but it doesn't help much because it's the smaller size
[23:26:39] <TrevorParscal>	 you want to the menu to render on top of the window, escaping it when needed
[23:26:43] <RoanKattouw>	 Yes
[23:26:49] <MatmaRex>	 personal calendar shared with work account, where i shared it with the organization
[23:26:50] <MatmaRex>	 okay
[23:26:57] <MatmaRex>	 i'll solve this conundrum tomorrow
[23:26:58] <RoanKattouw>	 I am aware of oo-ui-window-overlay, and in fact that (or body) is the default value for $overlay
[23:27:09] <RoanKattouw>	 But it's useless for this purpose because it clips to the window boundary
[23:27:12] <MatmaRex>	 night
[23:27:15] <TrevorParscal>	 so, I guess you are suggesting a window would wrap windows in another div?
[23:27:15] <grrrit-wm>	 (03PS2) 10Jforrester: Update VE core submodule to master (859654b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163990 
[23:27:32] <RoanKattouw>	 Well we could do a few things
[23:27:34] <TrevorParscal>	 and have a sibling to the current window wrapper (that will no longer be this.$element
[23:27:40] <TrevorParscal>	 which is an overlay
[23:27:41] <RoanKattouw>	 No, hold on
[23:27:43] <TrevorParscal>	 ok
[23:27:48] <RoanKattouw>	 For isolated modal windows, the DOM is like this:
[23:28:21] <RoanKattouw>	 <div windowManager><div window><div window-frame><iframe>....
[23:28:43] <RoanKattouw>	 window-frame is centered and sized
[23:28:52] <RoanKattouw>	 But window occupies the entire screen
[23:29:21] <RoanKattouw>	 So we could have an overlay that's a child of window and a sibling of window-frame
[23:29:51] <TrevorParscal>	 yeah, so since the frame is where we apply the smaller sizing, we can just add the overlay to the window's .$element
[23:29:54] <RoanKattouw>	 (For non-modal windows div.window doesn't occupy the entire screen but I'm ignoring that case for nwo)
[23:30:00] <RoanKattouw>	 Yeah exactly
[23:30:31] <TrevorParscal>	 seems sensible to me, and also I expect if it's not already the case it will be easy to apply the correct font sizing to the window div
[23:30:42] <TrevorParscal>	 without it bleeding elsewhere or causing other problems
[23:31:02] <RoanKattouw>	 Yeah it might be applied to window-frame right now, but that could be moved
[23:33:13] <Krenair>	 RoanKattouw, did you see my messages yesterday about linkCache .get vs. .getCached?
[23:33:37] <RoanKattouw>	 Krenair: If I did I forgot, sorry
[23:33:51] <Krenair>	 if you .set on a title twice, .get shows only the first value, .getCached shows the correct one
[23:33:58] <RoanKattouw>	 Oh right that
[23:34:32] <Krenair>	 That's fine for what I'm doing right now, but seems like a bug
[23:34:55] <RoanKattouw>	 Yeah it is a bug
[23:35:01] <RoanKattouw>	 get and getCached shouldn't return different things
[23:36:34] <grrrit-wm>	 (03PS1) 10Catrope: Update Citoid submodule to master [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163995 
[23:37:22] <mooeypoo>	 haaaaaaaaaaa code. Why must you be so tricksy.
[23:39:01] <wikibugs>	 3OOjs UI: "Back" button support for dialogs - 10https://bugzilla.wikimedia.org/71488 (10Yuri Astrakhan) 3NEW p:3Unprio s:3minor a:3None We might be able to work around this, but the current framework (with routing) allows an easy support for hitting the "back" button in the browser to close the dialog...
[23:39:53] <RoanKattouw>	 James_F: https://gerrit.wikimedia.org/r/163995
[23:40:04] <grrrit-wm>	 (03PS1) 10Alex Monk: Follow redirects in the category input widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163996 
[23:40:23] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032 V: 032] Update Citoid submodule to master [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163995 (owner: 10Catrope)
[23:41:10] <James_F>	 TrevorParscal: ContextItemWidget is evil and horrible.
[23:41:26] <mooeypoo>	 I have reached a conclusion. It is profound: CSS is evil.
[23:41:28] <mooeypoo>	 That is all.
[23:41:33] * James_F grins.
[23:41:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Follow redirects in the category input widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163996 (owner: 10Alex Monk)
[23:41:58] <TrevorParscal>	 James_F: why come you no like?
[23:42:01] <mooeypoo>	 James_F, so, "masonry view" with images the size of 2px each doesn't quite count, does it?
[23:42:03] <mooeypoo>	 Had to ask.
[23:42:18] <James_F>	 TrevorParscal: Because you take a tool, shuck half its settings, and shiv it.
[23:42:32] <RoanKattouw>	 mooeypoo: Please tell me there's a 1px border either side that counts towards the 2px width
[23:42:44] <James_F>	 TrevorParscal: "	this.setIcon( this.tool.static.icon ); "
[23:42:58] <James_F>	 TrevorParscal: This was brought to you by the words "eww" and "argh".
[23:43:19] <RoanKattouw>	 Now that tools are real IconElements etc this is annoying
[23:43:25] <RoanKattouw>	 Also, this.tool isn't a tool, it's a class
[23:43:57] <mooeypoo>	 RoanKattouw, ooh! I am adding one now.
[23:44:18] <James_F>	 TrevorParscal: So… adding FlaggedElement to OO.ui.Widget. Good idea or great idea?
[23:44:39] <James_F>	 TrevorParscal: (Or even Element, perhaps; a destructive dialog of fun!)
[23:44:55] <TrevorParscal>	 James_F: it's not a tool
[23:44:55] <James_F>	 mooeypoo: Also, no. :-)
[23:45:10] <mooeypoo>	 Darn. My evil plans have been thwarted. Back to the drawing board.
[23:45:12] <mooeypoo>	 With a thicker pen.
[23:45:14] <TrevorParscal>	 and if you've been minding the design direction, it's diverging
[23:45:27] <James_F>	 TrevorParscal: And yet it takes its logic from one.
[23:45:38] <TrevorParscal>	 that's because I'm lazy!
[23:45:40] <TrevorParscal>	 shhhhh
[23:45:43] <James_F>	 TrevorParscal: :-)
[23:45:52] <TrevorParscal>	 simmer down, somebody will hear you
[23:46:06] <James_F>	 No-one will ever hear me kvetch in this logged IRC channel…
[23:46:18] <TrevorParscal>	 making all elements flaggable...
[23:46:32] <TrevorParscal>	 seems "harmless"
[23:46:39] <James_F>	 Yeah.
[23:46:43] <James_F>	 OK.
[23:47:33] <TrevorParscal>	 We could switch to using oo-ui-flag-{flag} as the class scheme
[23:47:44] <TrevorParscal>	 nicer than oo-ui-flaggableElement-{flag}
[23:48:00] <Krenair>	 Hmm. My code worked better when it was broken. :/
[23:48:05] <TrevorParscal>	 and goes along with other things such as images, a la the new oo-ui-image-invert
[23:52:45] <mooeypoo>	 ok, when I do $element.css( { foo: 0 } ); and then later $element.css( { bar: 1 } ); <-- does the second .css() call override the first, or *adds* to the first?
[23:53:05] <mooeypoo>	 this code is driving me mad.
[23:53:16] <RoanKattouw>	 mooeypoo: Adds to
[23:53:18] <TrevorParscal>	 adds
[23:53:19] <grrrit-wm>	 (03PS1) 10Catrope: Update node_modules [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163998 
[23:53:35] <mooeypoo>	 it should add right?!
[23:53:43] <mooeypoo>	 what is going on. I'm overriding it elsewhere, then. Meh.
[23:53:44] <RoanKattouw>	 mooeypoo: .css( {foo: 'bar'} ) is shorthand for .css( 'foo', 'bar' ) but lets you do multiple calls in one, that's all
[23:53:50] <TrevorParscal>	 attr( 'style', 'foo:0' ) vs attr( 'style', 'bar:1' )
[23:53:52] <TrevorParscal>	 arg!
[23:53:52] <RoanKattouw>	 James_F: https://gerrit.wikimedia.org/r/163998
[23:53:54] <TrevorParscal>	 stop roan
[23:53:56] <mooeypoo>	 hehe
[23:53:58] <TrevorParscal>	 you type to fast
[23:54:00] <TrevorParscal>	 lol
[23:54:00] <mooeypoo>	 yeah it makes sense that it does
[23:54:09] <mooeypoo>	 but at some point my width/height CSS call is being eaten up
[23:54:19] <mooeypoo>	 probably something totally silly that I'm doing wrong
[23:54:23] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032 V: 032] Update node_modules [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163998 (owner: 10Catrope)
[23:54:28] <mooeypoo>	 but I had to verify it wasn't that, at least.
[23:55:44] <mooeypoo>	 A mooey sanity check.
[23:56:58] <grrrit-wm>	 (03PS2) 10Alex Monk: Follow redirects in the category input widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163996 
[23:58:16] <RoanKattouw>	 TrevorParscal: Would you approve of me moving .oo-ui-overlay out from where it is now to where we discussed? Cause I see no reason to have two separate overlays
[23:59:24] <mooeypoo>	 IT WORKS.
[23:59:38] <mooeypoo>	 oh, for the love of all image and css, it *works*. Geesh.