[00:03:47] <TrevorParscal>	 RoanKattouw: wyou mena oo-ui-window-overlay?
[00:03:56] <RoanKattouw>	 Sorry yes
[00:04:01] <TrevorParscal>	 left hand off by one error
[00:04:10] <TrevorParscal>	 yes, sounds good
[00:04:48] <RoanKattouw>	 OK I'll go do that then
[00:05:04] <RoanKattouw>	 That'll actually allow us to eliminate 2 of those 3 commits, because it'll be the default value for $overlay and we won't have to pass it through
[00:23:48] <James_F>	 TrevorParscal: So…
[00:23:54] <TrevorParscal>	 so...
[00:23:59] <James_F>	 TrevorParscal: OO.ui.Element now has to mixin EventEmitter.
[00:24:06] <James_F>	 TrevorParscal: (Cool undeclared dependency, bro.)
[00:24:18] <TrevorParscal>	 I've talked to Roan about this
[00:24:24] <James_F>	 This is OK?
[00:24:33] <TrevorParscal>	 it's sort of a mess
[00:24:41] <TrevorParscal>	 we use OO.ui.Element for ce nodes
[00:25:08] <TrevorParscal>	 so even though we really should mixin event emitter at the OO.ui.Element level, we haven't done so because it will need multi-repo cleanup
[00:26:48] <James_F>	 :-(
[00:28:05] <James_F>	 What clean-up?
[00:32:09] <RoanKattouw>	 Well it would cause the mixin to come in from two sides too, wouldn't it?
[00:32:20] <RoanKattouw>	 From both Element and Node
[00:33:59] <James_F>	 Ah.
[00:36:35] <grrrit-wm>	 (03PS1) 10Catrope: Followup 54b09fd: remove unneeded IIFE [oojs/ui] - 10https://gerrit.wikimedia.org/r/164006 
[00:41:52] <TrevorParscal>	 Krinkle: what was that replacement for grunt you were talking about?
[00:41:59] <Krinkle>	 TrevorParscal: Gulp
[00:42:23] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Followup 54b09fd: remove unneeded IIFE [oojs/ui] - 10https://gerrit.wikimedia.org/r/164006 (owner: 10Catrope)
[00:42:25] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Followup 54b09fd: remove unneeded IIFE [oojs/ui] - 10https://gerrit.wikimedia.org/r/164006 (owner: 10Catrope)
[00:42:46] <grrrit-wm>	 (03PS2) 10Krinkle: Element: Remove unneeded IIFE [oojs/ui] - 10https://gerrit.wikimedia.org/r/164006 (owner: 10Catrope)
[00:42:52] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Element: Remove unneeded IIFE [oojs/ui] - 10https://gerrit.wikimedia.org/r/164006 (owner: 10Catrope)
[00:43:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Element: Remove unneeded IIFE [oojs/ui] - 10https://gerrit.wikimedia.org/r/164006 (owner: 10Catrope)
[00:46:24] <grrrit-wm>	 (03PS1) 10Jforrester: [BREAKING CHANGE] Make all Elements flaggable, and scrap the FlaggedElement mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/164007 
[00:46:34] <RoanKattouw>	 So it turns out ce.Node isn't actually a problem
[00:46:51] <RoanKattouw>	 Because ce.View inherits Element and mixes in EventEmitter
[00:46:57] <RoanKattouw>	 And ve.Node is mixed in later and doesn't have events
[00:47:43] <James_F>	 TrevorParscal: ^^^ For your delectation.
[00:48:04] <TrevorParscal>	 RoanKattouw: i didn't say it was a problem
[00:48:30] <RoanKattouw>	 No but I did
[00:48:33] <RoanKattouw>	 And I'm correcting myself
[00:48:34] <TrevorParscal>	 I said we knew we should do it, and just needed to write the patch, but didn't do it immediately because it involved 2 repos and... we were lazy
[00:48:49] <RoanKattouw>	 Righ
[00:48:53] <TrevorParscal>	 I recall you correcting yourself the same way like 6 months ago
[00:48:57] <RoanKattouw>	 haha
[00:51:23] <James_F>	 TrevorParscal: Consider it written. :-)
[00:51:28] * James_F coughs meaningfully.
[00:53:42] <RoanKattouw>	 James_F: https://gerrit.wikimedia.org/r/#/c/163321/
[00:53:59] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032 V: 032] Add build of Zotero translation server [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163321 (owner: 10Catrope)
[01:21:18] <wikibugs>	 3OOjs UI: OOjs UI: "Back" button support for dialogs - 10https://bugzilla.wikimedia.org/71488 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5minor>3enhanc
[01:29:59] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Adding categories, removing them, then cancelling the dialog throws “Uncaught TypeError: Cannot read property 'disconnect' of undefined” - 10https://bugzilla.wikimedia.org/71471 (10James Forrester)
[01:30:01] <grrrit-wm>	 (03PS1) 10Jforrester: Account for categories being removed twice in MWCategoryWidget [extensions/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164018 (https://bugzilla.wikimedia.org/71471) 
[01:48:10] <grrrit-wm>	 (03PS1) 10Catrope: Allow urlencoded requests as well as JSON requests [services/citoid] - 10https://gerrit.wikimedia.org/r/164021 
[01:48:12] <grrrit-wm>	 (03PS1) 10Catrope: Add a test form to the welcome page [services/citoid] - 10https://gerrit.wikimedia.org/r/164022 
[01:48:46] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032 V: 032] Add a test form to the welcome page [services/citoid] - 10https://gerrit.wikimedia.org/r/164022 (owner: 10Catrope)
[01:49:06] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032 V: 032] Allow urlencoded requests as well as JSON requests [services/citoid] - 10https://gerrit.wikimedia.org/r/164021 (owner: 10Catrope)
[01:49:59] <grrrit-wm>	 (03PS1) 10Catrope: Update Citoid submodule [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/164023 
[01:50:07] <grrrit-wm>	 (03CR) 10Catrope: [C: 032 V: 032] Update Citoid submodule [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/164023 (owner: 10Catrope)
[02:36:29] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (859654b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163990 (owner: 10Jforrester)
[02:38:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (859654b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163990 (owner: 10Jforrester)
[02:53:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Indent buttons should be used for in-/out-denting paragraphs as well as lists. - 10https://bugzilla.wikimedia.org/48010#c6 (10Spinningspark) I don't know if this is related, or whether it should be a new bug.  In this edit:  https://en.wikipedia.org/w/index.php?t...
[02:56:16] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Indent buttons should be used for in-/out-denting paragraphs as well as lists. - 10https://bugzilla.wikimedia.org/48010#c7 (10Spinningspark) (In reply to Spinningspark from comment #6)  Sorry, posted this in wrong place.  It was intended for bug 59849
[02:56:44] <wikibugs>	 3VisualEditor: VisualEditor:  Cutting (removing) last sections on page,  and then pasting them back in, results in increased indentation in Chrome - 10https://bugzilla.wikimedia.org/59849#c1 (10Spinningspark) I don't know if this is related, or whether it should be a new bug.  In this edit:  https://en.wikiped...
[07:09:43] <RoanKattouw>	 mvolz: http://citoid-beta.wmflabs.org/
[07:09:57] <RoanKattouw>	 Running from my puppet manifest https://gerrit.wikimedia.org/r/#/c/163068 :)
[07:10:21] <RoanKattouw>	 Now I "just" have to get ops to deploy it
[09:49:14] <grrrit-wm>	 (03CR) 10Catrope: "So I talked to Trevor about this problem today. The menu can't use the surface's local overlay because it's below the dialog. Using the gl" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163299 (https://bugzilla.wikimedia.org/71178) (owner: 10Alex Monk)
[10:24:01] <grrrit-wm>	 (03PS14) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[10:24:03] <grrrit-wm>	 (03PS17) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[10:24:05] <grrrit-wm>	 (03PS18) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb)
[10:24:07] <grrrit-wm>	 (03PS19) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[10:27:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[10:27:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb)
[10:29:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[12:50:47] <wikibugs>	 3MediaWiki / 3ResourceLoader: Mediawiki no longer accepts unicode object property name without quotes - 10https://bugzilla.wikimedia.org/51539 (10Andre Klapper) p:5High>3Normal
[14:26:31] <grrrit-wm>	 (03PS1) 10Amire80: iEarly return for readability [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164074 
[14:28:47] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] iEarly return for readability [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164074 (owner: 10Amire80)
[14:28:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: iEarly return for readability [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164074 (owner: 10Amire80)
[14:44:37] <grrrit-wm>	 (03PS1) 10Amire80: Replace srting comparison with boolean condition [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164078 
[14:46:47] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "No-op" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164078 (owner: 10Amire80)
[14:46:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace srting comparison with boolean condition [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164078 (owner: 10Amire80)
[14:58:38] <grrrit-wm>	 (03PS1) 10Amire80: Change == to === according to coding conventions [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164081 
[14:58:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Change == to === according to coding conventions [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164081 (owner: 10Amire80)
[15:27:11] <grrrit-wm>	 (03PS1) 10Amire80: Replace == with isset [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164085 
[15:32:04] <grrrit-wm>	 (03PS1) 10Amire80: Replace == with isset [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164086 
[15:37:31] <grrrit-wm>	 (03PS2) 10Amire80: Change == to === according to coding conventions [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164081 
[15:38:52] <grrrit-wm>	 (03PS3) 10Amire80: Change == to === according to coding conventions [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164081 
[16:30:36] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32830068
[16:30:36] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32832320
[16:30:36] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65901950
[16:30:36] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65901992
[16:30:36] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65902006
[16:30:37] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=68431058
[17:24:17] <wikibugs>	 3MediaWiki / 3ResourceLoader: CSSMin: Don't generate double rules for IE < 8 when embedding SVG files - 10https://bugzilla.wikimedia.org/71003 (10Bartosz Dziewoński) 5PATC>3RESO/FIX a:3Bartosz Dziewoński
[17:24:46] <wikibugs>	 3MediaWiki / 3ResourceLoader: CSSMin: Embed non-binary data URIs using plain text instead of base64 - 10https://bugzilla.wikimedia.org/67341 (10Bartosz Dziewoński) 5PATC>3RESO/FIX p:5Low>3Normal
[17:43:08] <grrrit-wm>	 (03PS3) 10Jforrester: [BREAKING CHANGE] Tool: Use the LabelElement and TitledElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/163785 
[17:43:43] <grrrit-wm>	 (03CR) 10Jforrester: "PS3 is a rebase onto Ia1fa027." [oojs/ui] - 10https://gerrit.wikimedia.org/r/163785 (owner: 10Jforrester)
[17:58:29] <InezK>	 Hey.. quick question: why all template are always inserted as inline? - https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js#L53-L64
[18:01:24] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Uncaught Error: Syntax error, unrecognized expression: div[id ^= mittoHidden appears while trying to save a page in Betalabs - 10https://bugzilla.wikimedia.org/71521 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Uncaught Error: Syntax error, unreco...
[18:02:18] <RoanKattouw>	 InezK: I don't remember if we had a good reason for that. Probably not.
[18:02:31] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: "Uncaught Error: Syntax error, unrecognized expression: div[id ^= mittoHidden" appears while trying to save a page in Betalabs - 10https://bugzilla.wikimedia.org/71521 (10Rummana Yasmeen) a:3Roan Kattouw
[18:02:45] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: "Uncaught Error: Syntax error, unrecognized expression: div[id ^= mittoHidden" appears while trying to save a page in Betalabs - 10https://bugzilla.wikimedia.org/71521 (10Rummana Yasmeen) 5NEW>3ASSI
[18:04:51] <grrrit-wm>	 (03PS1) 10Catrope: Fix syntax error in mittoHidden selector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164122 (https://bugzilla.wikimedia.org/71521) 
[18:06:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix syntax error in mittoHidden selector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164122 (https://bugzilla.wikimedia.org/71521) (owner: 10Catrope)
[18:07:42] <InezK>	 RoanKattouw: it seems that using ve.dm.Node.static.isHybridInline could be helpful here
[18:09:44] <grrrit-wm>	 (03CR) 10Catrope: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164122 (https://bugzilla.wikimedia.org/71521) (owner: 10Catrope)
[18:09:51] <RoanKattouw>	 InezK: What would "isHybridInline" mean exactly?
[18:10:54] <InezK>	 I saw it used here ve.dm.MWTransclusionNode.static.toDataElement to determine if it's block or inline template
[18:11:18] <InezK>	 so I thought something similar could be used when inserting new template as well
[18:11:28] <InezK>	 of course we don't have converter there, so it would have to be changed
[18:12:22] <wikibugs>	 3MediaWiki / 3ResourceLoader: Disabling javascript on olderbrowsers should turn on the <noscript> handling - 10https://bugzilla.wikimedia.org/71522 (10Yuri Astrakhan) 3NEW p:3Unprio s:3normal a:3None If we abort javascript loading whenever the browser is "too old to support", we ought to honor the <n...
[18:12:47] <RoanKattouw>	 Oh THAT function
[18:13:00] <RoanKattouw>	 Well, the problem is, we get the preview from Parsoid asynchronously
[18:13:22] <RoanKattouw>	 So I guess we'd have to wait until we get that before inserting, or something
[18:19:56] <grrrit-wm>	 (03PS7) 10Catrope: [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 (owner: 10Esanders)
[18:21:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 (owner: 10Esanders)
[18:26:50] <InezK>	 RoanKattouw: Maybe we coudl have call similar to this: ve.ce.MWTransclusionNode.prototype.generateContents 
[18:27:02] <InezK>	 in ve.dm.MWTransclusionModel.prototype.insertTransclusionNode?
[18:27:50] <InezK>	 and then run logic similar to ve.dm.Node.static.isHybridInline, and finally run surfaceFragment.insertContent - and we would have to make sure that 'parsefragment' is not called twice for the same wikitext (maybe we could fill generated content cache after the first call)
[18:28:47] <RoanKattouw>	 Probably
[18:28:55] <RoanKattouw>	 But it would make the whole insertion operation async
[18:29:00] <RoanKattouw>	 which the caller would have to have support for
[18:29:58] <InezK>	 yes, some wait indicator, etc.. which I like better than what is currently happening - content popping up "randomly"
[18:30:05] <RoanKattouw>	 Yeah
[18:30:52] <grrrit-wm>	 (03CR) 10Krinkle: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164122 (https://bugzilla.wikimedia.org/71521) (owner: 10Catrope)
[18:35:53] <InezK>	 btw. the original code - that forces transclusion to always be inserted as "inline" was introduced here by Trevor: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/commit/be199c0bf2dda8086e4f3a2f46decb17ccf19935#diff-9423b71644b2585ea5d7448c1462007a
[18:36:09] <InezK>	 and Christian is making a good point that back then he (Trevor) was working on citetions - which are usually (if not always) inline nodes
[18:53:50] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix syntax error in mittoHidden selector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164122 (https://bugzilla.wikimedia.org/71521) (owner: 10Catrope)
[18:55:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix syntax error in mittoHidden selector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164122 (https://bugzilla.wikimedia.org/71521) (owner: 10Catrope)
[18:59:19] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Up/down arrow in Firefox broken after using left/right - 10https://bugzilla.wikimedia.org/70724#c2 (10Bartosz Dziewoński) Minimal test case: http://jsfiddle.net/ybawstce/1/  (This will throw errors in some edge cases, but that's not the point; try arrowing arou...
[19:09:47] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Up/down arrow in Firefox broken after using left/right - 10https://bugzilla.wikimedia.org/70724#c3 (10Bartosz Dziewoński) Calling nativeSelection.collapseToStart() seems to magically fix the erroneous behavior (http://jsfiddle.net/ybawstce/3/), we can probably...
[19:09:47] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf2] "Uncaught Error: Syntax error, unrecognized expression: div[id ^= mittoHidden" appears while trying to save a page - 10https://bugzilla.wikimedia.org/71521 (10James Forrester) p:5Unprio>3High s:5normal>3blocke
[19:15:26] <MatmaRex>	 James_F: do we want to apply a workaround in VE for broken firefox cursoring? https://bugzilla.wikimedia.org/show_bug.cgi?id=70724#c3
[19:15:52] <MatmaRex>	 (it's one line, assuming it works as well in practice as it does in the jsfiddle)
[19:25:15] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Up/down arrow in Firefox broken after using left/right - 10https://bugzilla.wikimedia.org/70724#c4 (10Bartosz Dziewoński) Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1075901
[19:29:07] <grrrit-wm>	 (03PS1) 10Alex Monk: Unbreak saving: Fix selector syntax error in I8af9f7ba [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164151 
[19:29:18] <Krenair>	 edsanders, MatmaRex, mooeypoo: ^
[19:30:36] <Krenair>	 (I have no idea we didn't pick this up in the original commit)
[19:31:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Unbreak saving: Fix selector syntax error in I8af9f7ba [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164151 (owner: 10Alex Monk)
[19:32:02] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Unbreak saving: Fix selector syntax error in I8af9f7ba [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164151 (owner: 10Alex Monk)
[19:32:03] <Krenair>	 Now is a really bad time to break jenkins
[19:32:07] <MatmaRex>	 welp
[19:32:20] <Krenair>	 19:29:12 stderr: /usr/lib/git-core/git-submodule: 552: /usr/lib/git-core/git-submodule: git reset: not found
[19:32:37] <MatmaRex>	 ci is pooped
[19:32:39] <MatmaRex>	 again
[19:32:42] <MatmaRex>	 or still
[19:32:48] <MatmaRex>	 sometimes i don't even know
[19:32:52] <Krenair>	 verified & submit?
[19:32:59] <MatmaRex>	 i wonder if i can
[19:33:08] <MatmaRex>	 i can't.
[19:33:09] <Krenair>	 I can't.
[19:33:22] <MatmaRex>	 Code Review - Error
[19:33:22] <MatmaRex>	 Applying label "Verified": 2 is restricted
[19:33:28] <Krenair>	 Someone, at some point in time, thought restricting that was a good idea.
[19:33:33] <MatmaRex>	 that's helpful. who had the idea of restricting this? :(
[19:34:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Unbreak saving: Fix selector syntax error in I8af9f7ba [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164151 (owner: 10Alex Monk)
[19:37:32] <wikibugs>	 3MediaWiki / 3Page editing: Allow cascade semi-protection on fully protected pages - 10https://bugzilla.wikimedia.org/71529 (10Bohdan) 3NEW p:3Unprio s:3normal a:3None In bug 8796 cascade semi-protection has been disabled. Several other bugs were WONTFIXed 'cause in all of them there still was a brea...
[19:54:07] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: ve.ce.Surface: Magic workaround for broken Firefox cursoring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164162 (https://bugzilla.wikimedia.org/70724) 
[19:55:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ve.ce.Surface: Magic workaround for broken Firefox cursoring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164162 (https://bugzilla.wikimedia.org/70724) (owner: 10Bartosz Dziewoński)
[20:08:17] <cscott>	 hm, ve seems to be turned off on wikitech?
[20:08:36] <grrrit-wm>	 (03CR) 10GWicke: [C: 04-1] "I think Thiemo makes a good point. Handling column count automatically by number of citations seems to have advantages in both convenience" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (https://bugzilla.wikimedia.org/51260) (owner: 10Alex Monk)
[20:36:08] <MatmaRex>	 Krinkle: hey, you actually there? if you're bored: saving in VE master is broken, there's a patch pending to fix it, but we can't merge it because the npm job is broken again and no one has permissions to do V+2 other than jenkins
[20:36:42] <MatmaRex>	 https://gerrit.wikimedia.org/r/164151
[20:36:52] <Krinkle>	 I know
[20:36:58] <MatmaRex>	 okay
[20:37:09] <Krinkle>	 I'm working on the CI breakage. Jenkins GIT layer is completely unresponsive.
[20:37:16] <Krinkle>	 Unknown cause, sort of out of ideas.
[20:37:17] <MatmaRex>	 i just wanted to be sure that someone who can remedy this knows, and will fix it before tomorrow :)
[20:37:26] <Krinkle>	 I;m in the VE quarterly review meeting atm
[20:37:31] <MatmaRex>	 i know
[20:37:34] <Krinkle>	 I know you know
[20:37:35] <MatmaRex>	 me too
[20:37:47] <Krinkle>	 I know you know that I know you know that I know
[20:37:59] * MatmaRex concedes the fight
[20:38:07] <Krinkle>	 :)
[20:56:00] <grrrit-wm>	 (03CR) 10Krinkle: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164122 (https://bugzilla.wikimedia.org/71521) (owner: 10Catrope)
[20:57:14] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Fix syntax error in mittoHidden selector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164122 (https://bugzilla.wikimedia.org/71521) (owner: 10Catrope)
[20:57:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix syntax error in mittoHidden selector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164122 (https://bugzilla.wikimedia.org/71521) (owner: 10Catrope)
[20:58:25] <Krenair>	 That selector was added last, after my test, because it was just a comment made a few hours prior on the main bug about adding a hack. :/
[20:58:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix syntax error in mittoHidden selector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164122 (https://bugzilla.wikimedia.org/71521) (owner: 10Catrope)
[21:00:03] <Krinkle>	 Krenair: RoanKattouw_away: TrevorParscal: We should look into how this bug could've ocurred. It's a fatal exception at the global uncaught level. Something that, if triggered, is caught by QUnit
[21:00:09] <Krinkle>	 We should trigger this code path in our tests.
[21:00:12] <Krinkle>	 (ideally)
[21:00:33] <Krinkle>	 we have a couple of basic surface tests, right? We use Target in some tests.
[21:00:42] <Krinkle>	 nothing elaborate, but at least asserting it doesnt' crash
[21:01:34] <Krenair>	 (I am slightly surprised that it wasn't picked up in review, but I'm still responsible. sorry.)
[21:02:50] <grrrit-wm>	 (03PS2) 10Amire80: WIP: Add localized <ref> and <references> tags [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163467 (https://bugzilla.wikimedia.org/28980) 
[21:10:58] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Duplicate of https://gerrit.wikimedia.org/r/#/c/164122/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164151 (owner: 10Alex Monk)
[21:11:03] <grrrit-wm>	 (03Abandoned) 10Bartosz Dziewoński: Unbreak saving: Fix selector syntax error in I8af9f7ba [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164151 (owner: 10Alex Monk)
[21:11:52] <grrrit-wm>	 (03CR) 10Cscott: [C: 04-1] "You'd definitely need some way of exporting the localized tag names via the siteinfo API or similar so that tools like Parsoid can obtain " (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163467 (https://bugzilla.wikimedia.org/28980) (owner: 10Amire80)
[21:14:46] <MatmaRex>	 James_F: bored? our docs on mw.org are teh suck. https://www.mediawiki.org/wiki/OOjs_UI#Showing_a_dialog has code that throws errors
[21:15:12] <MatmaRex>	 James_F: this works for me instead: http://pastebin.com/3kZBAkQc but i'm not sure if that's how it's supposed to be done these days
[21:15:24] <MatmaRex>	 do you know, or can grab a trevor/roan to confirm? :D
[21:34:34] <MatmaRex>	 i'll be leaving for tonight. see you
[22:06:51] <grrrit-wm>	 (03CR) 10Jforrester: "We've had this conversation four times now. It's getting tiring to have to rebut the same points each time." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (https://bugzilla.wikimedia.org/51260) (owner: 10Alex Monk)
[22:08:12] <James_F>	 MatmaRex: Sounds reasonable…
[22:09:00] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf2] "Uncaught Error: Syntax error, unrecognized expression: div[id ^= mittoHidden" appears while trying to save a page - 10https://bugzilla.wikimedia.org/71521 (10James Forrester) 5PATC>3RESO/FIX
[22:18:06] <MatmaRex>	 CR, anyone? https://www.mediawiki.org/w/index.php?title=OOjs_UI&diff=1202510&oldid=1132389
[22:18:36] <MatmaRex>	 night
[22:25:22] <InezK>	 RoanKattouw_away: https://github.com/Wikia/app/pull/4932/files
[22:26:31] <RoanKattouw>	 InezK: That looks mostly reasonable
[22:26:45] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf2] "Uncaught Error: Syntax error, unrecognized expression: div[id ^= mittoHidden" appears while trying to save a page - 10https://bugzilla.wikimedia.org/71521#c3 (10Rummana Yasmeen) Verified the fix in Betalabs
[22:26:50] <RoanKattouw>	 I'll file a bug about this, with a link to that commit, and assign it to Ed
[22:27:21] <RoanKattouw>	 Then once he's done with table editing stuff (which will take a while) hopefully he can look at this 
[22:34:47] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Check locally for the user preference to prompt an edit summary, rather than waiting for the API to round-trip - 10https://bugzilla.wikimedia.org/71535 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3Alex Monk Right now we rely on the API moaning...
[22:35:44] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Transclusion nodes should re-evaluate their block/inline status on every update - 10https://bugzilla.wikimedia.org/49784#c8 (10Roan Kattouw) Inez talked to me about this long-standing problem today. He worked on a solution that involves waiting for the preview t...
[22:35:50] <James_F>	 RoanKattouw: Seen https://gerrit.wikimedia.org/r/#/c/164238/1 ?
[22:36:05] <RoanKattouw>	 Ooh no I hadn't, nice
[22:37:35] <Krenair>	 Have been looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=69119
[22:37:54] <RoanKattouw>	 Ugh oh that one
[22:37:57] <Krenair>	 When you undo a ref group change, refGroup gets updated
[22:38:06] <Krenair>	 listGroup is not
[22:38:09] <RoanKattouw>	 I looked at it but had no immediate idea of what the hell was going on
[22:38:31] <Krenair>	 listGroup is used to remove the ref from the internal list
[22:42:20] <grrrit-wm>	 (03CR) 10Catrope: [C: 032 V: 032] Account for categories being removed twice in MWCategoryWidget [extensions/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164018 (https://bugzilla.wikimedia.org/71471) (owner: 10Jforrester)
[22:44:34] <RoanKattouw>	 Krenair: What I wonder though, is why does this only happen with refs inside of a caption?
[22:44:49] <RoanKattouw>	 Is there some sort of interaction with newFromDocumentInsertion's internalList transplantation stuff going on?
[22:45:07] <RoanKattouw>	 Also I noticed that after cutting the reference and pasting it back in, it appeared to get a new internal list entry
[22:45:33] <Krenair>	 I found that weird as well, see comment 3
[22:45:42] <RoanKattouw>	 I feel like the bug involves so many complex things (pasting refs, ref reuse, refs inside captions) that I wonder how many of them are actually necessary to reproduce it
[22:46:30] <RoanKattouw>	 Krenair: Aha!
[22:46:32] <RoanKattouw>	 Well spotted
[22:46:46] <RoanKattouw>	 So there's a problem with undoing group changes
[22:47:05] <RoanKattouw>	 Which may or may not be related to ... oh wait no I'm thinking of a different bug
[22:47:21] <RoanKattouw>	 OK so for the bug you're actually looking at, I think you've nailed down the minimal case
[22:47:28] <Krenair>	 from filibuster: VeDmTransactionProcessor.executeOperation( {"type":"attribute","key":"refGroup","from":"a","to":""} )
[22:47:40] <RoanKattouw>	 For the bug I *thought* you were looking at but you weren't, there's more going on there
[22:47:49] <Krenair>	 Oh okay, so then the next call handles listGroup.
[22:48:10] <Krenair>	 And the result looks sane
[22:48:23] <RoanKattouw>	 That one is like, have document with a ref reuse inside of a caption, edit caption, cut reused ref, save caption, edit caption, paste reused ref back in, save caption, JS error
[22:48:52] <RoanKattouw>	 Found it: https://bugzilla.wikimedia.org/show_bug.cgi?id=71214
[22:49:06] <RoanKattouw>	 But I'm distracting you from debugging the first bug, sorry
[22:57:16] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Adding categories, removing them,  then cancelling the dialog throws “Uncaught TypeError: Cannot read property 'disconnect' of undefined” - 10https://bugzilla.wikimedia.org/71471 (10Alex Monk) 5PATC>3RESO/FIX
[22:59:24] <Krenair>	 It seems that when it undoes the group change, the internal list is not updated properly
[23:00:01] <Krenair>	 the element is still under the pre-undo group in internalList.nodes
[23:01:01] <Krenair>	 rn.doc.internalList.nodes['mwReference/s'].keyedNodes['auto/0'][0].element.attributes.listGroup
[23:01:01] <Krenair>	 "mwReference/"
[23:01:01] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Applying link to the caption of an image does not enable "Apply Changes" button - 10https://bugzilla.wikimedia.org/71065 (10Rummana Yasmeen) 5NEW>3ASSI a:3Moriel Schottlender
[23:01:30] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Applying link to the caption of an image does not enable "Apply Changes" button - 10https://bugzilla.wikimedia.org/71065 (10James Forrester) p:5Unprio>3Normal
[23:01:39] <Krenair>	 (rn is the ve.dm.MWReferenceNode object, started with empty group, changed to 's' then tried to undo back to '')
[23:03:40] <grrrit-wm>	 (03PS2) 10Jforrester: ve.ce.Surface: Magic workaround for broken Firefox cursoring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164162 (https://bugzilla.wikimedia.org/70724) (owner: 10Bartosz Dziewoński)
[23:06:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ve.ce.Surface: Magic workaround for broken Firefox cursoring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164162 (https://bugzilla.wikimedia.org/70724) (owner: 10Bartosz Dziewoński)
[23:11:15] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Check locally for the user preference to prompt an edit summary, rather than waiting for the API to round-trip - 10https://bugzilla.wikimedia.org/71535 (10James Forrester) p:5Unprio>3Normal
[23:12:37] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] ve.ce.Surface: Magic workaround for broken Firefox cursoring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164162 (https://bugzilla.wikimedia.org/70724) (owner: 10Bartosz Dziewoński)
[23:12:52] <grrrit-wm>	 (03CR) 10Catrope: [V: 032] ve.ce.Surface: Magic workaround for broken Firefox cursoring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164162 (https://bugzilla.wikimedia.org/70724) (owner: 10Bartosz Dziewoński)
[23:13:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ve.ce.Surface: Magic workaround for broken Firefox cursoring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164162 (https://bugzilla.wikimedia.org/70724) (owner: 10Bartosz Dziewoński)
[23:15:08] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] ve.ce.Surface: Magic workaround for broken Firefox cursoring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164162 (https://bugzilla.wikimedia.org/70724) (owner: 10Bartosz Dziewoński)
[23:16:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ve.ce.Surface: Magic workaround for broken Firefox cursoring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164162 (https://bugzilla.wikimedia.org/70724) (owner: 10Bartosz Dziewoński)
[23:20:37] <grrrit-wm>	 (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 (owner: 10Esanders)
[23:25:59] <BladeBronson>	 TrevorParscal, RoanKattouw: Haaaaave you met Matt?
[23:26:30] <RoanKattouw>	 GOD FINALLY
[23:26:42] <RoanKattouw>	 Someone who makes How I Met Your Mother references at work
[23:26:51] <RoanKattouw>	 BladeBronson: Which Matt
[23:26:59] <RoanKattouw>	 Also you forgot to tell Matt to go "Hi, I'm Matt"
[23:27:10] <BladeBronson>	 Wikia Matt. He's been developing on VE for months and can't wait to meet you at dinner tonight.
[23:27:58] <RoanKattouw>	 Oh I can't make it, sorry
[23:28:07] <RoanKattouw>	 I have to do a bunch of stuff before I get up at 6am tomorrow to fly to Europe
[23:29:18] <BladeBronson>	 Europe is old and dinner with Matt is new. You know my one rule, right? New is always better.
[23:29:22] <RoanKattouw>	 haha
[23:33:24] <BladeBronson>	 you're just going to get lost in code and stay at the office until 8:00 anyway
[23:40:37] <James_F>	 BladeBronson: Dinner tonight?
[23:42:04] <James_F>	 Oh.
[23:42:15] * James_F is going to miss it. :-)
[23:42:20] <James_F>	 Umm, :-(
[23:52:35] <wikibugs>	 3MediaWiki / 3Page editing: Allow cascade semi-protection on fully protected pages - 10https://bugzilla.wikimedia.org/71529#c1 (10Jackmcbarn) 5NEW>3RESO/WON This has the same issue as all of the other requests. If [[Foo]] gets this form of protection set on it, and [[Foo]] transcludes [[Template:Bar]], t...