[00:00:17] (03PS12) 10Krinkle: build: Create minified JS and CSS distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 (owner: 10Jforrester) [00:15:08] (03CR) 10Krinkle: [C: 04-1] "The .min.css files duplicate the same stylesheet 4 times." [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 (owner: 10Jforrester) [01:14:55] (03PS13) 10Krinkle: build: Create minified JS and CSS distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 (owner: 10Jforrester) [01:16:25] (03CR) 10Krinkle: [C: 032] build: Create minified JS and CSS distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 (owner: 10Jforrester) [01:16:35] (03PS2) 10Krinkle: update-oojs-ui.sh: Exclude the minimised distribution files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161885 (owner: 10Jforrester) [01:16:50] (03CR) 10Krinkle: [C: 032] update-oojs-ui.sh: Exclude the minimised distribution files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161885 (owner: 10Jforrester) [01:17:41] (03Merged) 10jenkins-bot: build: Create minified JS and CSS distribution files [oojs/ui] - 10https://gerrit.wikimedia.org/r/157315 (owner: 10Jforrester) [01:18:15] (03CR) 10jenkins-bot: [V: 04-1] update-oojs-ui.sh: Exclude the minimised distribution files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161885 (owner: 10Jforrester) [01:49:13] (03CR) 10Jforrester: [C: 032] "Go go Jenkins." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161885 (owner: 10Jforrester) [01:50:30] (03Merged) 10jenkins-bot: update-oojs-ui.sh: Exclude the minimised distribution files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/161885 (owner: 10Jforrester) [01:53:27] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (48980881f3) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164715 [07:44:31] 3VisualEditor / 3MediaWiki integration: VisualEditor: The show/hide text a collapsed navbox disappear afted have edited - 10https://bugzilla.wikimedia.org/68279#c8 (10Gabrasca) the issue appens only after it is saved from VE, if I reload the page the show/hide text returns. [11:17:47] (03CR) 10Esanders: Add a "Remove" context button to all Focussable nodes (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163662 (https://bugzilla.wikimedia.org/60110) (owner: 10Jforrester) [11:25:24] (03CR) 10Amire80: WIP: Add localized and tags (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/163467 (https://bugzilla.wikimedia.org/28980) (owner: 10Amire80) [15:42:30] 3VisualEditor / 3Mobile: VisualEditor: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110#c11 (10Ed Sanders) Of course this behaves completely differently in iOS 8 (the keyboard stays up). *sigh* [16:34:45] 3VisualEditor / 3MediaWiki integration: VisualEditor: If VisualEditor is the primary editor, type=create and type=fulltext buttons should point to VE, not WT editor - 10https://bugzilla.wikimedia.org/52162#c5 (10Tar Lócesilion) I don't want to make inputbox suddenly magically different. It's about ordinary u... [17:16:16] 3VisualEditor: VisualEditor: Cutting (removing) last sections on page, and then pasting them back in, results in increased indentation in Chrome - 10https://bugzilla.wikimedia.org/59849#c5 (10Spinningspark) > TLDR: The colon does *not* actually mean "indent". Ok, the colon does not mean indent. However, I... [17:59:15] 3VisualEditor / 3ContentEditable: nowiki in references - 10https://bugzilla.wikimedia.org/53183#c2 (10Amir E. Aharoni) I cannot reproduce this with the current version of the article, which has similar content. When trying to edit the old version of the article I get a strange result: I don't see the extern... [17:59:46] 3VisualEditor / 3ContentEditable: VisualEditor: nowiki when trying to edit an external link in references - 10https://bugzilla.wikimedia.org/53183 (10Amir E. Aharoni) [18:20:12] (03PS2) 10Bartosz Dziewoński: ListToolGroup: Implement collapsible/expandable tools [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) [19:05:17] 3OOjs UI / 3Technical Debt: OOjs UI: PopupWidget needs to have its body positioned absolutely and anchor relatively to it, and not vice versa - 10https://bugzilla.wikimedia.org/71644 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None PopupWidget needs to have its body positioned absolutely and a... [19:05:29] 3VisualEditor / 3ContentEditable: VisualEditor: Left-aligning a large image causes horizontal scrolling past the context menu on Chrome - 10https://bugzilla.wikimedia.org/71540 (10Bartosz Dziewoński) [19:06:30] 3OOjs UI / 3Technical Debt: OOjs UI: PopupWidget needs to have its body positioned absolutely and anchor relatively to it, and not vice versa - 10https://bugzilla.wikimedia.org/71644 (10Bartosz Dziewoński) p:5Unprio>3Low [19:28:30] 3MediaWiki / 3ResourceLoader: Add configuration option to enable loading modules based on url parameter - 10https://bugzilla.wikimedia.org/27766 (10Helder) [20:08:35] (03PS1) 10Bartosz Dziewoński: InlineMenuWidget: Fix documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/164740 [20:14:26] (03PS1) 10Bartosz Dziewoński: SelectWidget: Fix typos in documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/164741 [20:26:25] (03PS1) 10Bartosz Dziewoński: TextInputMenuWidget: Fix typo in documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/164742 [20:28:12] (03PS2) 10Bartosz Dziewoński: TextInputMenuWidget: Fix typo in documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/164742 [20:31:45] 3OOjs UI: OOjs UI: InlineMenuWidget should behave as a menu widget - 10https://bugzilla.wikimedia.org/70968#c1 (10Bartosz Dziewoński) InlineMenuWidget is just one of the wrappers for MenuWidget (the other is ComboBoxWidget) and not a MenuWidget itself, so it kind of makes sense for it to have a different inter... [21:20:33] (03PS1) 10Bartosz Dziewoński: Toolbar: Correctly display "More" label on catch-all groups [oojs/ui] - 10https://gerrit.wikimedia.org/r/164744 [21:21:40] (03PS3) 10Bartosz Dziewoński: ListToolGroup: Implement collapsible/expandable tools [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) [21:22:09] (03CR) 10Jforrester: [C: 032] SelectWidget: Fix typos in documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/164741 (owner: 10Bartosz Dziewoński) [21:22:25] (03CR) 10Jforrester: [C: 032] TextInputMenuWidget: Fix typo in documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/164742 (owner: 10Bartosz Dziewoński) [21:22:44] i should probably stash all my typo fixes and just commit everything every day or so… [21:22:45] (03CR) 10Jforrester: [C: 04-1] "Add an entry to the demo to show we don't regress?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/164744 (owner: 10Bartosz Dziewoński) [21:22:58] MatmaRex: :-) [21:23:01] (Hey.) [21:23:21] James_F: there's one more typo/doc fix you missed. :) [21:23:22] (03Merged) 10jenkins-bot: SelectWidget: Fix typos in documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/164741 (owner: 10Bartosz Dziewoński) [21:23:42] (03Merged) 10jenkins-bot: TextInputMenuWidget: Fix typo in documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/164742 (owner: 10Bartosz Dziewoński) [21:24:06] (03CR) 10Jforrester: [C: 032] InlineMenuWidget: Fix documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/164740 (owner: 10Bartosz Dziewoński) [21:24:10] Yeah yeah. [21:25:17] (03Merged) 10jenkins-bot: InlineMenuWidget: Fix documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/164740 (owner: 10Bartosz Dziewoński) [21:25:56] MatmaRex: Feel like merging https://gerrit.wikimedia.org/r/#/q/Iaea30c2429401be4061f30d98a8edc7cce5567b1,n,z for me? :-) [21:27:57] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.1.0-pre (48980881f3) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164715 (owner: 10Jforrester) [21:28:39] Thanks! [21:29:45] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (48980881f3) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164715 (owner: 10Jforrester) [22:04:02] (03PS29) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [22:04:10] (03PS36) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [22:13:36] MatmaRex: Hmm. [22:13:47] MatmaRex: BTW, https://gerrit.wikimedia.org/r/#/c/164746/ is where your FIXME gets fixed. Soon! [22:13:54] James_F: mhm? [22:14:29] MatmaRex: In https://gerrit.wikimedia.org/r/#/c/164590 I think the expandCollapseTool should be display:inline-block not display:inline to stop it looking ugly. [22:14:32] James_F: ha, neat. [22:14:44] James_F: yes, i know. that's broken becayse jquery is too clever [22:15:08] i'm currently figuring out a way to fix this that doesn't cause me to hate myself [22:15:11] * James_F is trying to work out how to… yeah. [22:15:26] and yes, i've spent over half an hour on it already [22:15:55] i might just hardcode 'inline-block' in the JS in a few places [22:16:02] How about in the… yeah. [22:16:20] Also, I think a slight animation would help. [22:16:53] MatmaRex: Could you not just give it a unique class that gets display:inline-block? [22:18:10] hmm, maybe [22:18:44] You'll need that for animations anywawy. [22:18:44] James_F: actually, i think the problem affects the actual tools, too, it's just not visible because of implementation details of the demo [22:18:58] Hmm. Doesn't affect VE's use of them, though? [22:19:15] i haven't checked [22:19:26] it's the hiding and showing them that's a problem, current code is perfectly fine [22:21:25] Ah [22:27:34] James_F, it's been a while since I did that and I am gettng a bit confused now -- I have a question from the woman who wants to join us as a volunteer regarding gerrit signup. The 'register' button goes to the wikitech site -- so, the credentials later to sign into gerrit site is going to be the same, right? I have all my passes go automatically, I forgot, and I can't find the page for it in the docs [22:27:52] mooeypoo: There are three things. [22:27:53] I think it's the same signup, but I can't remember. [22:28:13] mooeypoo: There is your wiki account name, your git/shell name, and your display name. [22:28:51] Okay. The wiki accont name is User:Mooeypoo (or wahtever) on the unified login system for the wikis, right? [22:29:13] mooeypoo: No, wikitech.wikimedia.org isn't a unified login wiki. [22:29:51] right, right, oh, I thought you included it in the list. Okay. [22:29:52] mooeypoo: I made it simple and have the same username and shell name. [22:30:07] mooeypoo: Your shell name is wikigit IIRC. :-) [22:30:13] yes... :( [22:30:20] i misunderstood what it was [22:31:28] And now can't really change it.. bah. Anyways, yeah. So my username is 'mooeypoo', shell is 'wikigit' and display name is my name. The username is what I login with, and the shell name is what comes in the clone/whatever git repo requests like http://username@blahblah [22:31:42] sorry, http://shellname@blahblah [22:31:56] so she just needs to sign up in *one* place (wikitech) to get access to the gerrit site, too. [22:32:32] (if you want to use https to push to gerrit rather than ssh, the login username will be the shell name) [22:33:50] yes [22:34:54] yeah, I gave an https example .,but the same goes with ssh [22:34:59] ssh://shellname... [22:35:24] ok, I just wanted to make sure I follow up with her properly. It's confusing a bit, since she needs to sign up to only ONE place, but submit the SSH passwords to 2 places [22:35:35] ssh keys, I mean [22:35:40] ssh passwords? [22:35:41] ssh keys [22:35:42] yes [22:35:45] The keys, sorry, yeah [22:36:09] She needs to submit the public key to both wikitech *and* gerrit separately, but sign up only to wikitech [22:36:23] Wanted to make sure I got it right, it was a tad confusing and I didn't quite remember how I did it [22:36:40] yes [22:36:55] iirc there's a gerrit bug somewhere about pulling ssh keys from ldap [22:37:39] (which is where wikitech is putting them) [22:37:40] yeah I remembered something [22:37:49] thanks :) [22:38:04] If this goes well, she wants to check VE development out, so we might get a volunteer [22:39:25] there are a few pages on mediawikiwiki about this [22:39:54] Krenair, yeah too many :\ I wrote a guide exactly for that reason [22:40:31] it's really confusing for someone who's never dealt with any of this before. I remember I had to ask Amir and James a whole lot of questions. One page leads to another and another and back to the same page, and then you have VE install and then Parsoid and then git/gerrit explanations [22:40:34] it was really very messy. [22:41:01] so we can have a few + 1? [22:41:02] :p [22:41:16] I made a single "TODO" process for newbies, but I seem to have a couple of things I should emphasize and correct, and if it works well with newbies, we can have that instead [22:41:30] well, the other pages do have their uses -- for advance usage or to remind myself sometimes of whether to do X or Y i go there [22:41:40] but for a complete newbie to install all their thing its' really confusing [22:41:59] so yeah, if it works, sure. a few advanced + 1 newbie tutorial. I don't see a problem with that. [22:42:27] no, a few advanced and a few + 1 newbie ones [22:42:37] I don't think I've seen a good newbie one? [22:42:47] not necessarily good [22:42:53] I mademy guide mainly for myself and for specifically VE newbies [22:43:07] but if this works, I'd be happy to replace whatever newbie process is now with that [22:43:09] or adjust [22:43:40] Krenair, https://www.mediawiki.org/wiki/User:Mooeypoo/VisualEditor_Development [22:43:53] it's a step by step "here's how you install everything" guide, except for LAMP server. [22:44:37] But it's mainly for VE development, so it's not really generalized enough to replace the general newbie guides. Then again, I could adjust it [22:47:00] Krenair, not good? [22:47:47] Well you need to fix "Request a developer account" obviously [23:01:45] Krenair, aye :p that, yes. [23:02:06] Krenair, part of the reason I have it on my personal page instead of putting it up for general public is to test it out first [23:26:32] hmmm [23:26:51] James_F: i wonder if i should file a jquery bug for this :P [23:27:05] MatmaRex: Krinkle|detached will probably argue with you. :-) [23:28:38] James_F: reduced test case: http://jsfiddle.net/gtj4hu3h/ ;) [23:28:50] "AAA" should be displayed 100px from top; it is displayed at the top [23:29:00] removing ".hide().show()" fixes it [23:29:52] i'm pretty damn sure this isn't the expected behavior, and it shouldn't be hard to fix in jquery [23:34:51] (03PS4) 10Bartosz Dziewoński: ListToolGroup: Implement collapsible/expandable tools [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) [23:34:57] jquery is evil. [23:41:28] does the example on https://www.mediawiki.org/wiki/OOjs_UI#Showing_a_dialog still work? I just tried it on that page itself, and it didn't really... [23:42:20] legoktm: WFM [23:42:26] hm. [23:42:59] legoktm: what happens when it doesn't work? [23:43:29] http://cl.ly/image/3A25281m1F3X [23:44:07] heh [23:44:10] monobook [23:44:15] that probably explains it [23:44:30] i bet it renders under page body for some reason [23:44:39] should I try vector? [23:44:46] you can see that the overlay is displayed above sidebar [23:44:54] yep, and file a bug? :D [23:48:02] works-ish in vector, but the underlines are above the options? [23:48:57] http://cl.ly/image/1Y300R3D461v when my cursor is hovering over "Good" [23:49:57] lol [23:50:05] 3OOjs UI: OOjs UI: Showing a dialog example doesn't work in MonoBook skin - 10https://bugzilla.wikimedia.org/71650 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Created attachment 16670 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16670&action=edit screenshot I tried the example... [23:50:08] also I'm going to try using this on a non-mediawiki site, so this'll be fun :) [23:51:38] legoktm: what browser? [23:52:13] legoktm: Monobook really needs to die in a fire. [23:52:20] ff32 on OSX, but I might be using a modified UA [23:54:03] legoktm: WFM on Opera 12 and Opera latest, looks like Firefox bug [23:54:50] man, everyone's raving about html5 these days, and browsers can't get text underlining right [23:55:49] html6 [23:57:10] legoktm: if you report that as oojs ui bug, i'll probably do the legwork on smaller test case and report it upstream [23:57:17] or, you could skip the middleman… ;) [23:58:07] heh [23:58:22] I was actually going to try and develop something today! [23:58:27] I'll file the oojs ui bug [23:58:49] ooui should probably try to suppress the underlines anyway [23:58:56] they come from MW [23:59:37] OOUI shouldn't know anything about its environment. It's MW-independent. Instead, MW should be less bad. :-)