[01:49:46] <legoktm[NE]>	 https://en.wikipedia.org/wiki/MediaWiki:Visualeditor-cite-tool-definition.json :((((((((
[01:56:24] <jackmcbarn>	 legoktm[NE]: what's  wrong with that?
[01:59:50] <legoktm[NE]>	 it's putting configuration in the mediawiki namespace
[02:00:11] <jackmcbarn>	 where would you like it to put it?
[02:00:40] <legoktm[NE]>	 well, not there!
[02:00:54] <legoktm[NE]>	 probably a config variable
[02:01:04] <jackmcbarn>	 then you couldn't edit it on-wiki
[02:02:22] <legoktm[NE]>	 well, yes.
[02:03:56] <legoktm[NE]>	 we'll have that in the long-term future, but I still don't see that as a strong enough argument for putting it in the MW namespace.
[07:40:17] <grrrit-wm>	 (03PS1) 10Krinkle: build: Clean up Grunt config and add missing csscomb run [oojs/ui] - 10https://gerrit.wikimedia.org/r/164904 
[07:41:31] <grrrit-wm>	 (03CR) 10Krinkle: build: Use csscomb to prettify the CSS (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/159076 (owner: 10Jforrester)
[07:42:27] <grrrit-wm>	 (03CR) 10Krinkle: "csscomb config is missing entries. As a result the new {theme}.svg.css and mediawiki*.css files are not being combed. Fixed in Iadc1d2bb5c" [oojs/ui] - 10https://gerrit.wikimedia.org/r/157866 (owner: 10Trevor Parscal)
[07:56:20] <grrrit-wm>	 (03CR) 10Hashar: "check experimental" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 (owner: 10Hashar)
[08:25:48] <grrrit-wm>	 (03CR) 10Hashar: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 (owner: 10Hashar)
[08:45:40] <grrrit-wm>	 (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 
[09:28:49] <grrrit-wm>	 (03PS1) 10Krinkle: build: Update to karma-qunit v0.1.4 and qunitjs v1.15 [oojs/core] - 10https://gerrit.wikimedia.org/r/164920 
[09:28:51] <grrrit-wm>	 (03PS1) 10Krinkle: [WIP] build: Use Chrome instead of PhantomJS [oojs/core] - 10https://gerrit.wikimedia.org/r/164921 
[09:30:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] build: Use Chrome instead of PhantomJS [oojs/core] - 10https://gerrit.wikimedia.org/r/164921 (owner: 10Krinkle)
[09:31:13] <grrrit-wm>	 (03CR) 10Krinkle: "Jenkins config WIP: https://gerrit.wikimedia.org/r/#/c/164906/" [oojs/core] - 10https://gerrit.wikimedia.org/r/164921 (owner: 10Krinkle)
[09:45:45] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: For formulae (and some other nodes?), inspection trigger region is a single line, not the whole block - 10https://bugzilla.wikimedia.org/64625#c1 (10Roan Kattouw) 5ASSI>3RESO/FIX The bug as reported (formula click areas)  is fixed now. It was probably fixed...
[09:49:17] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: setResizableHandlesSizeAndPosition() shouldn't measure things on every keypress - 10https://bugzilla.wikimedia.org/62812#c1 (10Roan Kattouw) 5ASSI>3RESO/FIX This was fixed at some point. setResizableHandlesSizeAndPosition() is now attached to the 'position'...
[09:59:45] <wikibugs>	 3MediaWiki / 3ResourceLoader: ResourceLoader cache is broken after moving MediaWiki - 10https://bugzilla.wikimedia.org/35472 (10Krinkle)
[10:06:32] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: For formulae (and some other nodes?), inspection trigger region is a single line, not the whole block - 10https://bugzilla.wikimedia.org/64625#c2 (10Roan Kattouw) *** Bug 50776 has been marked as a duplicate of this bug. ***
[10:06:32] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Alien shield is mis-sized for inline content (assumes it's just one line of text high) - 10https://bugzilla.wikimedia.org/50776#c1 (10Roan Kattouw) 5ASSI>3RESO/DUP   *** This bug has been marked as a duplicate of bug 64625 ***
[10:09:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Template dialog doesn't display very long template names gracefully - 10https://bugzilla.wikimedia.org/67267#c1 (10Roan Kattouw) 5ASSI>3RESO/FIX This is wrapped correctly now
[10:11:30] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Make the media dialog one dialog again - 10https://bugzilla.wikimedia.org/58245#c1 (10Roan Kattouw) 5ASSI>3RESO/DUP   *** This bug has been marked as a duplicate of bug 67170 ***
[10:11:32] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Merge the inserting and editing media dialogs - 10https://bugzilla.wikimedia.org/67170#c4 (10Roan Kattouw) *** Bug 58245 has been marked as a duplicate of this bug. ***
[10:14:16] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Clean up constructor params to dm.Node subclasses - 10https://bugzilla.wikimedia.org/55871#c2 (10Roan Kattouw) 5ASSI>3RESO/FIX https://gerrit.wikimedia.org/r/#/c/135878/
[10:17:15] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: ve.ui.Context#toolbar is null in MediaWiki - 10https://bugzilla.wikimedia.org/52011#c1 (10Roan Kattouw) 5ASSI>3RESO/FIX There used to be a .toolbar property because the context had its own (local) toolbar to show the contextual tools in. This has been replac...
[10:20:00] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Provide clean way to clone a linmod slice - 10https://bugzilla.wikimedia.org/48651#c1 (10Roan Kattouw) 5ASSI>3RESO/FIX ve.dm.Document#cloneSliceFromRange addresses this
[10:26:07] <Krinkle>	 RoanKattouw: https://integration.wikimedia.org/ci/job/oojs-core-npm/300/console
[10:26:16] <Krinkle>	 Chromium 37.0.2062 (Ubuntu)
[10:27:28] <RoanKattouw>	 Sweet!
[10:31:45] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Chrome 36 and higher throws "Discontiguous selection is not supported" on opening the editor - 10https://bugzilla.wikimedia.org/68493#c3 (10Roan Kattouw) 5ASSI>3RESO/FIX Fixed now because we don't use Rangy any more.
[10:44:57] <grrrit-wm>	 (03CR) 10Krinkle: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/164921 (owner: 10Krinkle)
[10:48:42] <grrrit-wm>	 (03PS2) 10Krinkle: [WIP] build: Use Chrome instead of PhantomJS [oojs/core] - 10https://gerrit.wikimedia.org/r/164921 
[10:48:54] <grrrit-wm>	 (03PS3) 10Krinkle: [WIP] build: Use Chrome/Firefox instead of PhantomJS [oojs/core] - 10https://gerrit.wikimedia.org/r/164921 
[10:50:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] build: Use Chrome/Firefox instead of PhantomJS [oojs/core] - 10https://gerrit.wikimedia.org/r/164921 (owner: 10Krinkle)
[10:51:13] <grrrit-wm>	 (03PS4) 10Krinkle: [WIP] build: Use Chrome instead of PhantomJS [oojs/core] - 10https://gerrit.wikimedia.org/r/164921 
[11:07:56] <grrrit-wm>	 (03PS5) 10Krinkle: build: Use local Chrome and Firefox in ci task [oojs/core] - 10https://gerrit.wikimedia.org/r/164921 
[11:23:17] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Found a breaking change, see comment." (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/164081 (owner: 10Amire80)
[11:27:03] <wikibugs>	 3VisualEditor: Cannot save deletion of {{clarify span}} template - 10https://bugzilla.wikimedia.org/71701 (10Spinningspark) 3NEW p:3Unprio s:3normal a:3None Intention: Remove a template on en.wikipedia.  The template in question is {{clarify span}}  Steps to Reproduce: 1. Click on span to open the temp...
[11:39:16] <wikibugs>	 3VisualEditor: Cannot save deletion of {{clarify span}} template - 10https://bugzilla.wikimedia.org/71701#c1 (10Elitre) To remove a template, you simply click on it and press Canc or Backspace.
[11:56:01] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "PS48 unfixes a bug that we fixed painstakingly: https://bugzilla.wikimedia.org/show_bug.cgi?id=68597 . It's reasonable to propose that thi" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec)
[12:08:07] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Move window overlay up to be a sibling of the frame [oojs/ui] - 10https://gerrit.wikimedia.org/r/164361 (https://bugzilla.wikimedia.org/71178) (owner: 10Alex Monk)
[12:08:15] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] ComboBoxWidget: Append menu to $overlay option [oojs/ui] - 10https://gerrit.wikimedia.org/r/163300 (https://bugzilla.wikimedia.org/71178) (owner: 10Alex Monk)
[12:10:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move window overlay up to be a sibling of the frame [oojs/ui] - 10https://gerrit.wikimedia.org/r/164361 (https://bugzilla.wikimedia.org/71178) (owner: 10Alex Monk)
[12:10:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: ComboBoxWidget: Append menu to $overlay option [oojs/ui] - 10https://gerrit.wikimedia.org/r/163300 (https://bugzilla.wikimedia.org/71178) (owner: 10Alex Monk)
[12:11:36] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] mw.Platform: Use 'mediawiki.language' for language fallback chain [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164783 (owner: 10Bartosz Dziewoński)
[12:13:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: mw.Platform: Use 'mediawiki.language' for language fallback chain [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164783 (owner: 10Bartosz Dziewoński)
[12:15:02] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "You removed $1 from the message, so you should also update the caller in MWBetaWelcomeDialog to not pass this parameter, and update the qq" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164503 (owner: 10Mattflaschen)
[12:16:35] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "This causes the 'change' event to be emitted twice for the same change in some cases, because setCurrentDimensions() also emits it." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164784 (https://bugzilla.wikimedia.org/70861) (owner: 10Mooeypoo)
[12:20:02] <wikibugs>	 3VisualEditor: Cannot save deletion of {{clarify span}} template - 10https://bugzilla.wikimedia.org/71701#c2 (10Spinningspark) (In reply to Elitre from comment #1) > To remove a template, you simply click on it and press Canc or Backspace.  Yes, but that also removes the text the template was bracketing.  The...
[12:56:46] <grrrit-wm>	 (03PS6) 10Catrope: [WIP] Use a single unicorn <img> instead of &#xFEFF; in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 
[12:58:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use a single unicorn <img> instead of &#xFEFF; in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope)
[13:01:00] <grrrit-wm>	 (03PS49) 10Catrope: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec)
[13:01:16] <grrrit-wm>	 (03CR) 10Catrope: "PS49 is a rebase onto the "stage slugs" stack" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec)
[13:02:46] <grrrit-wm>	 (03PS7) 10Catrope: [WIP] Use a single unicorn <img> instead of &#xFEFF; in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 
[13:02:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec)
[13:03:05] <grrrit-wm>	 (03CR) 10Catrope: "PS7 is a rebase onto the "Stage slugs" branch" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope)
[13:04:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use a single unicorn <img> instead of &#xFEFF; in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope)
[13:25:00] <wikibugs>	 3VisualEditor: Cannot save deletion of {{clarify span}} template - 10https://bugzilla.wikimedia.org/71701#c3 (10Elitre) I believe that ATM the fastest way to do so is simply copying the text, removing the template, pasting the text? A better support of templates incapsulating text has already been requested el...
[13:50:35] <grrrit-wm>	 (03PS8) 10Catrope: [WIP] Use a single unicorn <img> instead of &#xFEFF; in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 
[13:50:37] <grrrit-wm>	 (03PS1) 10Catrope: Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 
[13:51:25] <grrrit-wm>	 (03PS9) 10Catrope: [WIP] Use a single unicorn <img> instead of &#xFEFF; in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 
[13:51:59] <grrrit-wm>	 (03CR) 10Catrope: "PS8: Break out DocumentSynchronizer portion into its own change" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope)
[13:52:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 (owner: 10Catrope)
[13:53:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use a single unicorn <img> instead of &#xFEFF; in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope)
[14:17:21] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164503 (owner: 10Mattflaschen)
[14:26:37] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163662 (https://bugzilla.wikimedia.org/60110) (owner: 10Jforrester)
[14:54:47] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf2]:”Uncaught Error: Cannot set attributes on closing element” on decreasing indentation, when the edit comment box is still open - 10https://bugzilla.wikimedia.org/71706 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Created attachment 16677...
[15:06:28] <James_F>	 Morning.
[15:06:41] <James_F>	 RoanKattouw_away: Thanks for doing some sterling work on noting old bugs have been fixed.
[15:06:47] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: For formulae (and some other nodes?), inspection trigger region is a single line, not the whole block - 10https://bugzilla.wikimedia.org/64625 (10James Forrester) a:3Ed Sanders
[15:07:31] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Alien shield is mis-sized for inline content (assumes it's just one line of text high) - 10https://bugzilla.wikimedia.org/50776#c2 (10James Forrester) 5RESO/DUP>3RESO/FIX a:3Ed Sanders This was actually a different issue (slightly), so separating it. Stil...
[15:08:20] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] build: Update to karma-qunit v0.1.4 and qunitjs v1.15 (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/164920 (owner: 10Krinkle)
[15:10:36] <RoanKattouw>	 James_F: You're welcome :) I was looking for unfixed ones and the fixed ones were getting in the way :D
[15:10:44] * James_F grins.
[15:11:59] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Edit  comment dialog turns blank, when applying a text style, Uncaught TypeError:Cannot Read Property 'getSurface of null'. - 10https://bugzilla.wikimedia.org/69262#c2 (10Ritu Swain) Created attachment 16678   --> https://bugzilla.wikimedia.org/attachment.cgi?id=...
[15:13:24] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Edit  comment dialog turns blank, when applying a text style, Uncaught TypeError:Cannot Read Property 'getSurface of null'. - 10https://bugzilla.wikimedia.org/69262#c3 (10Ritu Swain) Issue is reproducible and is related to Bug 70888.Please ses "Screenshot 1.25wmf...
[15:13:33] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Chrome 36 and higher throws "Discontiguous selection is not supported" on opening the editor - 10https://bugzilla.wikimedia.org/68493 (10James Forrester) a:3Ed Sanders
[15:14:17] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Clean up constructor params to dm.Node subclasses - 10https://bugzilla.wikimedia.org/55871 (10James Forrester) a:3Ed Sanders
[15:16:36] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Provide clean way to clone a linmod slice - 10https://bugzilla.wikimedia.org/48651 (10James Forrester) a:3Ed Sanders
[15:19:46] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Provide clean way to clone a linmod slice - 10https://bugzilla.wikimedia.org/48651#c2 (10James Forrester) Provided by gerrit I38d63e31.
[15:22:00] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] build: Use local Chrome and Firefox in ci task [oojs/core] - 10https://gerrit.wikimedia.org/r/164921 (owner: 10Krinkle)
[15:22:47] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: In template dialog,  the “show one more field” control appears when there are 4 entries - 10https://bugzilla.wikimedia.org/70609#c4 (10Ritu Swain) Issue fixed in test2, beta, production.
[15:23:28] <grrrit-wm>	 (03PS2) 10Jforrester: build: Update to karma-qunit v0.1.4 and qunitjs v1.15 [oojs/core] - 10https://gerrit.wikimedia.org/r/164920 (owner: 10Krinkle)
[15:23:34] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] build: Update to karma-qunit v0.1.4 and qunitjs v1.15 [oojs/core] - 10https://gerrit.wikimedia.org/r/164920 (owner: 10Krinkle)
[15:27:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Update to karma-qunit v0.1.4 and qunitjs v1.15 [oojs/core] - 10https://gerrit.wikimedia.org/r/164920 (owner: 10Krinkle)
[15:32:32] <wikibugs>	 3OOjs UI: OOjs UI: TextInputWidget's textarea gets silly scrollbars when it shouldn't - 10https://bugzilla.wikimedia.org/71310#c8 (10Ritu Swain) (In reply to Bartosz Dziewoński from comment #1) >  > * The textarea inside has a silly vertical scrollbar that scrolls only by >   one pixel up or down when a scroll...
[15:37:16] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Adding categories, removing them,  then cancelling the dialog throws “Uncaught TypeError: Cannot read property 'disconnect' of undefined” - 10https://bugzilla.wikimedia.org/71471#c7 (10Ritu Swain) Issue is now fixed in beta too.
[15:38:33] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] build: Clean up Grunt config and add missing csscomb run [oojs/ui] - 10https://gerrit.wikimedia.org/r/164904 (owner: 10Krinkle)
[15:40:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Clean up Grunt config and add missing csscomb run [oojs/ui] - 10https://gerrit.wikimedia.org/r/164904 (owner: 10Krinkle)
[15:52:46] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: setResizableHandlesSizeAndPosition() shouldn't measure things on every keypress - 10https://bugzilla.wikimedia.org/62812#c2 (10James Forrester) a:3Ed Sanders Fixed in gerrit Ia6cf8de0da0.
[15:58:16] <wikibugs>	 3OOjs UI: OOUI: ComboBoxWidget cut off near bottom of window - 10https://bugzilla.wikimedia.org/71178#c13 (10Alex Monk) 5PATC>3RESO/FIX Should be fixed.
[15:58:53] <James_F>	 RoanKattouw_away: You planning to land https://gerrit.wikimedia.org/r/#/c/163850/ and https://gerrit.wikimedia.org/r/#/c/164516/ down to https://gerrit.wikimedia.org/r/#/c/164514/ today?
[15:59:31] <wikibugs>	 3OOjs UI: OOjs UI: ComboBoxWidget cut off near bottom of window - 10https://bugzilla.wikimedia.org/71178 (10Alex Monk)
[16:04:10] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (26dadbc60f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165002 
[16:05:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Template dialog doesn't display very long template names gracefully - 10https://bugzilla.wikimedia.org/67267 (10James Forrester)
[16:06:23] <James_F>	 Krenair: Want to +2 https://gerrit.wikimedia.org/r/165001 and https://gerrit.wikimedia.org/r/165002 so we can marvel at your fix to the ComboBox widget? :-)
[16:11:08] <Krenair>	 ok
[16:15:21] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf2]: Bold/Italic/Underline/Strikethrough, when set on formulas are not reflected. - 10https://bugzilla.wikimedia.org/71707 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16679   --> https://bugzilla.wikimedia.org/attachmen...
[16:15:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf2]: Bold/Italic/Underline/Strikethrough, when set on formulas are not reflected. - 10https://bugzilla.wikimedia.org/71707 (10Ritu Swain)
[16:17:35] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Update OOjs UI to v0.1.0-pre (26dadbc60f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165002 (owner: 10Jforrester)
[16:18:19] <James_F>	 Thanks
[16:19:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (26dadbc60f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165002 (owner: 10Jforrester)
[16:23:05] <James_F>	 Hmm.
[16:23:28] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Try again, Jenkins." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165002 (owner: 10Jforrester)
[16:23:34] <Krenair>	 16:19:13 PhantomJS 1.9.7 (Linux): Executed 155 of 0 DISCONNECTED (12.874 secs / 3.422 secs)
[16:23:46] <James_F>	 Yeah, that happens from time to time.
[16:24:02] <James_F>	 It's why Krinkle|detached has been putting so much work into replacing phantomjs with Chromium.
[16:24:22] <RoanKattouw>	 James_F: I've only reviewed like 10% of the big selection rewrite so not quite yet :(
[16:24:24] <RoanKattouw>	 I need to make time to go through all that stuff
[16:24:46] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (26dadbc60f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165002 (owner: 10Jforrester)
[16:24:59] <grrrit-wm>	 (03PS6) 10Jforrester: build: Use local Chrome and Firefox in ci task [oojs/core] - 10https://gerrit.wikimedia.org/r/164921 (owner: 10Krinkle)
[16:25:14] <James_F>	 RoanKattouw: Understood.
[16:25:32] * James_F sighs at Jenkins.
[16:25:35] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders)
[16:25:51] <James_F>	 Doesn't that need your stuff to be +2'ed first?
[16:25:54] <RoanKattouw>	 James_F: Re slugging stack, apart from the one that I just +2ed (which is in the middle), it's all my code
[16:26:00] <James_F>	 Or is this your way of encouraging Ed to… yeah.
[16:26:02] <James_F>	 :-)
[16:26:06] <RoanKattouw>	 Legitimately, not just splits
[16:26:11] <RoanKattouw>	 So yeah Ed needs to look at that
[16:26:14] * James_F nods.
[16:26:25] <RoanKattouw>	 But knowing him he'll just point in the direction of the great selection rewrite ;)
[16:26:32] <RoanKattouw>	 which is an entirely fair point
[16:26:52] <James_F>	 Don't review that until he's merged your stuff? ;-)
[16:27:08] <James_F>	 RoanKattouw: Can you confirm that 165002 passes locally (VE-core) for you?
[16:28:32] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "…" [oojs/core] - 10https://gerrit.wikimedia.org/r/164921 (owner: 10Krinkle)
[16:29:16] <RoanKattouw>	 Also I split off https://gerrit.wikimedia.org/r/#/c/164963/ as a nice reviewable chunk
[16:29:24] * James_F saw.
[16:29:49] <James_F>	 But I thought https://gerrit.wikimedia.org/r/#/c/151046/ was going to get merged into the Unicorning patch?
[16:29:58] <James_F>	 And also not be WIP. :-)
[16:30:15] <RoanKattouw>	 No it won't be merged in
[16:30:29] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108004343
[16:30:29] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108004686
[16:30:29] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on hewiki: https://he.wikipedia.org/?diff=16047237
[16:30:29] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on hewiki: https://he.wikipedia.org/?diff=16047243
[16:30:29] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on huwiki: https://hu.wikipedia.org/?diff=15188877
[16:30:30] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on huwiki: https://hu.wikipedia.org/?diff=15188926
[16:30:30] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on huwiki: https://hu.wikipedia.org/?diff=15188967
[16:30:31] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on huwiki: https://hu.wikipedia.org/?diff=15189015
[16:30:34] <RoanKattouw>	 The unicorn patch is already big. I'm resisting the temptation to split it up, but I also don't want it to grow
[16:30:37] <RoanKattouw>	 And they technically don't need each other
[16:30:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Use local Chrome and Firefox in ci task [oojs/core] - 10https://gerrit.wikimedia.org/r/164921 (owner: 10Krinkle)
[16:30:50] <RoanKattouw>	 (I know I inspire lots of confidence when I use the word "technically" :P )
[16:31:00] * James_F grins.
[16:31:02] <RoanKattouw>	 James_F: Yes that OOUI pull-through (165002) passes npm test for me locally
[16:31:19] <James_F>	 RoanKattouw: Yeah, for me too, and the MW-core one merged fine.
[16:31:22] * James_F grumbles.
[16:33:02] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Annotation tools should be visibly disabled when selection is a formula node (which doesn't take annotations) - 10https://bugzilla.wikimedia.org/71707 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal s:5normal>3enhanc
[16:40:18] <wikibugs>	 3OOjs UI: OOjs UI: ComboBoxWidget cut off near bottom of window - 10https://bugzilla.wikimedia.org/71178#c14 (10Ritu Swain) I can still reproduce it on both beta and test2.
[16:40:30] <wikibugs>	 3VisualEditor: Cannot save deletion of {{clarify span}} template - 10https://bugzilla.wikimedia.org/71701#c4 (10Spinningspark) It's quite difficult to select the text without opening the template.  Having opened it, it is not five clicks to get to delete.  Having selected delete, it makes no sense not to allow...
[16:47:49] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: redirect option works badly if pointing to category pages - 10https://bugzilla.wikimedia.org/71708 (10Trevor (Wikia)) 3NEW p:3Unprio s:3minor a:3None The VE's Page Settings dialog redirect options work badly for category destinations.  For example, if you...
[16:53:00] <wikibugs>	 3VisualEditor: Cannot save deletion of {{clarify span}} template - 10https://bugzilla.wikimedia.org/71701#c5 (10Bartosz Dziewoński) Right, there are actually two issues here:  * It's not possible to "Apply changes" from the transclusion dialog after it   has been emptied. This is obviously a bug and should be...
[17:06:15] <Krenair>	 James_F, what's going on?
[17:17:00] <wikibugs>	 3VisualEditor: Cannot save deletion of {{clarify span}} template - 10https://bugzilla.wikimedia.org/71701#c6 (10Spinningspark) Agreed there are two issues here, and I'm happy for this to be split into two bugs if necessary.  It must also be easy to add a "save as plain text" button or something similar.  If th...
[17:30:31] <Krinkle>	 MatmaRex: http://jsfiddle.net/u09hpjzo/
[17:32:11] <MatmaRex>	 Krinkle: right, so it's a bug?
[17:32:23] <Krinkle>	 MatmaRex: well, I don't think jQuery will consider it a bug
[17:32:29] <MatmaRex>	 obviously
[17:32:33] <MatmaRex>	 but it still is one? :>
[17:32:44] <Krinkle>	 MatmaRex: No, I'd agree it isn't a bug
[17:33:44] <Krinkle>	 MatmaRex: The display operations are done while the element is detached, so it can't know which styles apply
[17:34:00] <wikibugs>	 3OOjs UI: OOjs UI: ComboBoxWidget cut off near bottom of window - 10https://bugzilla.wikimedia.org/71178#c15 (10Alex Monk) What about now? beta won't show OOjs UI fixes until it actually has the latest copy of OOjs UI.
[17:34:03] <Krinkle>	 so at that point it's just a regular span inline or div block
[17:34:16] <Krinkle>	 and toggling the display value hardcodes it in an inline-style.
[17:34:19] <MatmaRex>	 indeed, which is why i'd wager that it shouldn't be hard-coding the default ones
[17:34:29] <Krinkle>	 MatmaRex: define default ones
[17:34:39] <Krinkle>	 There is no such thing
[17:34:47] <RoanKattouw>	 .css( 'display' ,'' ) ?
[17:35:01] <MatmaRex>	 Krinkle: the ones that come from the defaultDisplay() function in jquery
[17:35:07] <Krinkle>	 elements are just elements, everything is done using css. The browser hiding <script> and rendering <span> as display:inline is just another stylesheet applying before anything else.
[17:35:11] <MatmaRex>	 indeed, it'd expect what RoanKattouw said
[17:35:22] <MatmaRex>	 i'd*
[17:35:54] <Krinkle>	 so there's no difference between a css rule of our own that does "span { display: inline-block; }" or the browser doing it. Either way it's a "custom" value that requires getting computed values
[17:36:07] <MatmaRex>	 i know
[17:36:31] <Krinkle>	 MatmaRex: http://jsfiddle.net/t4o3jwou/
[17:36:34] <MatmaRex>	 what i'm suggesting is not to hard-code them, just toggle adding/removing display:none if the element is detached without the rest of the magic
[17:36:35] <MatmaRex>	 anyway
[17:36:36] <Krinkle>	 when attached it works fine
[17:36:48] <MatmaRex>	 i know
[17:36:49] <Krinkle>	 MatmaRex: What if the value was already inlined?
[17:36:57] <Krinkle>	 <span style="display:table;">
[17:36:58] <MatmaRex>	 it breaks when detached
[17:37:23] <RoanKattouw>	 Does it not store the old value somewhere? Otherwise how does this not break when attached?
[17:37:31] <Krinkle>	 Exactly
[17:37:37] <MatmaRex>	 Krinkle: presumably that should be kept, but meh
[17:37:41] <Krinkle>	 And it restores it afterwards.
[17:37:45] <MatmaRex>	 there's a workaround for this very stupiud feature at https://gerrit.wikimedia.org/r/#/c/164590/5/src/toolgroups/ListToolGroup.js
[17:37:51] <RoanKattouw>	 So change how you get the old value
[17:38:04] <RoanKattouw>	 Use domElement.style.display instead of computed style?
[17:38:08] <Krinkle>	 IN that case don't work around it, just use css(display directly. Don't use hide() or show() at all.
[17:38:15] <Krinkle>	 It's a convenience method for a common case.
[17:38:21] <MatmaRex>	 Krinkle: i can't because i'm not calling .hide() or show() either
[17:38:22] <Krinkle>	 It doesn't have to cover the whole universe :)
[17:38:33] <MatmaRex>	 unless you want me to bypass ooui's .toggle()
[17:38:38] <MatmaRex>	 but that seems evil
[17:39:23] <Krinkle>	 Fix oojs ui's toggle maybe?
[17:39:42] <MatmaRex>	 fix how? detect detached elements and handle them separately? that's exactly the thing jquery should be doing
[17:40:10] <Krinkle>	 MatmaRex: I mean, maybe simplify oojs ui toggle to display:none ->display:''
[17:40:17] <Krinkle>	 do our elements use inline styles?
[17:40:24] <MatmaRex>	 hopefully not
[17:40:41] <RoanKattouw>	 No but there can be CSS targeting them with display: inline-block;
[17:40:41] <MatmaRex>	 but we might rely on .show() working for elements hidden via global css
[17:40:45] <RoanKattouw>	 Like in his jsfiddle
[17:40:48] <Krinkle>	 Exactly, and we can say: we don't support that ("don't touch oojs-ui elements manually")
[17:41:21] <Krinkle>	 right, if the default display is 'none' you want show() to show it
[17:41:47] <Krinkle>	 RoanKattouw: which means you still need the computer value
[17:41:48] <MatmaRex>	 (and then you don't know what display value to use, again, and you're pooped again)
[17:42:11] <MatmaRex>	 it's hopeless, i'm going to file the jquery bug anyway
[17:42:26] <Krinkle>	 I defer to #jquery-dev if you think there's a way to make it work for everyone. Otherwise we'll have to make our own compromise.
[17:42:30] <MatmaRex>	 so far i suggest just keeping the workaround in ListToolGroup i added, or some less silly form of it
[17:42:46] <Krinkle>	 MatmaRex: Be sure to use the new issue tracker on github for jquery core, trac has been abandoned. It opened up just a few days ago
[17:42:49] <MatmaRex>	 (like, can we clear the jquery-stored display value?
[17:42:55] <MatmaRex>	 )
[17:43:19] <MatmaRex>	 (that seems less silly than what i do right now, but there's no public api for that and i don't want to poke too much with .data())
[17:43:19] <Krinkle>	 MatmaRex: You could, it's in data()
[17:43:25] <Krinkle>	 but please don't :)
[17:44:12] <MatmaRex>	 i have a bit of a backlog of various bugs to file, heh. i might as well add this one to the list
[17:46:17] <wikibugs>	 3VisualEditor: Cannot save deletion of {{clarify span}} template - 10https://bugzilla.wikimedia.org/71701#c7 (10Bartosz Dziewoński) (In reply to Spinningspark from comment #6) > Ooooh, just noticed the template form doesn't have a tick box for "subst", > that's going to be needed one day.  Bug 49904.
[17:47:17] <grrrit-wm>	 (03CR) 10Krinkle: ListToolGroup: Implement collapsible/expandable tools (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) (owner: 10Bartosz Dziewoński)
[17:48:01] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: ListToolGroup: Implement collapsible/expandable tools (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) (owner: 10Bartosz Dziewoński)
[17:49:44] <wikibugs>	 3OOjs UI: OOjs UI: ComboBoxWidget cut off near bottom of window - 10https://bugzilla.wikimedia.org/71178#c16 (10Ritu Swain) (In reply to Alex Monk from comment #15) > What about now? beta won't show OOjs UI fixes until it actually has the > latest copy of OOjs UI.  I checked with a clear cache in test2 and sti...
[17:50:29] <grrrit-wm>	 (03CR) 10Krinkle: ListToolGroup: Implement collapsible/expandable tools (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) (owner: 10Bartosz Dziewoński)
[18:27:37] <grrrit-wm>	 (03PS2) 10Mooeypoo: Emit change event when dimensions change in MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164784 (https://bugzilla.wikimedia.org/70861) 
[18:27:45] <mooeypoo>	 hm. This wasn't as complicated than I thought it would be, thanks to ooui.
[18:41:10] <James_F>	 mooeypoo: Always good to hear. :-)
[18:45:17] <James_F>	 legoktm: MediaWiki:Visualeditor-specialcharinspector-characterlist-insert
[18:46:13] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Per Alex." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165002 (owner: 10Jforrester)
[18:47:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (26dadbc60f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165002 (owner: 10Jforrester)
[18:49:37] <grrrit-wm>	 (03PS5) 10Trevor Parscal: [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 
[18:49:58] * James_F sighs.
[18:50:16] <James_F>	 Krinkle: Could you look at https://gerrit.wikimedia.org/r/165002 please?
[18:50:26] <James_F>	 Krinkle: (And why Jenkins is failing to merge it.)
[18:50:37] <Krinkle>	 checking
[18:50:44] <James_F>	 Thanks.
[18:50:55] <Krinkle>	 James_F: Antoine replaced the implementation of the VisualEditor-qunit job earlier
[18:50:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal)
[18:51:02] <Krinkle>	 ah, this is -npm t hough
[18:51:10] <James_F>	 Krinkle: That won't affect … yeah.
[18:51:20] <Krinkle>	 James_F: It's the same old same old. PhantomJS randomly disconnecting for unknown reasons.
[18:51:29] <James_F>	 Yeah, but this is happening on every try.
[18:52:07] <Krinkle>	 Yep. But I've investigated this several times over the past few weeks. Got absolutely nowhere. Eventually it works..
[18:52:34] <Krinkle>	 Or switch to Chromium. Seem appropiate for modern-only repos like UI and VE.
[18:53:01] <Krinkle>	 https://integration.wikimedia.org/ci/job/VisualEditor-npm/
[18:53:15] <Krinkle>	 the one before it passed
[18:53:22] <Krinkle>	 somehow PhantomJS never fails for oojs-core btw
[18:53:42] <Krinkle>	 so it could be something we're triggering inside oojs-ui (and subsequently in VE, and ve-mw)
[18:54:46] <Krenair>	 I guess I should put https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 (use Function#bind) back on my list if we're going to switch away from PhantomJS
[18:55:38] <Krinkle>	 Krenair: Right
[18:55:52] <Krinkle>	 Krenair: unless OOjs UI is going to support non-es5 browsers, in which case we should just use es5-shim
[18:55:59] <Krinkle>	 beause if oojs-ui does, so will VisualEditor
[19:00:10] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Update OOjs UI to v0.1.0-pre (26dadbc60f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165002 (owner: 10Jforrester)
[19:01:05] <mooeypoo>	 TrevorP|Away / James_F are we having a meeting?
[19:01:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (26dadbc60f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165002 (owner: 10Jforrester)
[19:03:15] <grrrit-wm>	 (03PS1) 10Legoktm: Display JSON configuration options in NS_MEDIAWIKI as JSON [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165037 
[19:11:47] <Krinkle>	 James_F: converting oojs-ui to karma w/ chromium now
[19:12:34] <James_F>	 Krinkle: Awesome, thanks.
[19:19:11] <Krenair>	 Krinkle, so is OOjs UI going to support non-es5 browsers?
[19:19:41] <Krinkle>	 Krenair: I expect so, yes. At least for CSS.
[19:19:58] <James_F>	 Krenair: IE8+ is our aim, I believe.
[19:19:59] <Krinkle>	 Krenair: And it seems simple enough for the JS to work in ES3 as well (with Es5-shim). 
[19:20:07] <Krinkle>	 But js != dom
[19:20:14] <James_F>	 Krenair: But we've not done proper testing at all yet.
[19:20:21] <Krinkle>	 so we may not actually support the average es3 browser.
[19:20:31] <Krinkle>	 we'll see.
[19:20:44] <grrrit-wm>	 (03PS1) 10Krinkle: build: Update grunt-contrib-uglify to v0.6.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/165043 
[19:20:58] <James_F>	 Also, OOUI|php needs to support non-JS IE8.
[19:21:00] <James_F>	 At least.
[19:21:27] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] build: Update grunt-contrib-uglify to v0.6.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/165043 (owner: 10Krinkle)
[19:21:44] <Krinkle>	 Ar, spoiled my epic topic name in that commit.
[19:25:12] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Nice improvement, no-op to distribution output." [oojs/ui] - 10https://gerrit.wikimedia.org/r/165043 (owner: 10Krinkle)
[19:25:44] <Krinkle>	 James_F: Hm.. oojs-ui tets are failing for me locally
[19:25:57] <James_F>	 Krinkle: Not for me.
[19:26:04] <Krinkle>	 OO.ui.theme.updateElementClasses is undefined after loading oojs-ui.js. Makes sense since it needs a theme js file as well
[19:26:11] <James_F>	 Krinkle: Something from your local settings?
[19:26:15] <Krinkle>	 Can you run locahost/oojs/ui/tests/ ?
[19:26:21] <James_F>	 One moment.
[19:26:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Update grunt-contrib-uglify to v0.6.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/165043 (owner: 10Krinkle)
[19:26:47] <wikibugs>	 3OOjs UI: OOjs UI: ComboBoxWidget cut off near bottom of window - 10https://bugzilla.wikimedia.org/71178#c17 (10Alex Monk) It's working for me on deployment-prep. test2 won't be updated until Thursday.
[19:29:24] <James_F>	 Krinkle: OK, that was unexpected.
[19:29:26] <James_F>	 Krinkle: My login failed and I ended up on the login screen with all my processes killed.
[19:29:28] <James_F>	 Krinkle: Anyway, to repeat, it works fine here.
[19:29:46] <Krinkle>	 In Chrome?
[19:29:55] <Krinkle>	 latest oojs-ui master, after grunt build?
[19:29:56] <James_F>	 Yes, and Firefox.
[19:29:58] <James_F>	 Yes.
[19:30:09] <James_F>	 Do you have a local change on your demo index.html?
[19:35:32] <Krinkle>	 James_F: No
[19:35:36] <Krinkle>	 doesn't make any sense
[19:35:39] <Krinkle>	 doesn't make any sense/
[19:35:45] <Krinkle>	 how can it be passing?
[19:41:06] <James_F>	 Krinkle: How can it not?
[19:41:30] <Krinkle>	 James_F: OO.ui.Element.prototype.debouncedUpdateThemeClasses
[19:41:35] <Krinkle>	 calls OO.ui.theme.updateElementClasses( this );
[19:41:48] <Krinkle>	 OO.ui.theme is not assigned anywhere in oojs-ui.js
[19:41:52] <Krinkle>	 that's instantiated in a theme js file
[19:42:00] <James_F>	 Which is loaded.
[19:42:10] <Krinkle>	 No, it isn;t
[19:42:14] <James_F>	 Yeah, it is.
[19:42:23] <James_F>	 I added the load of it myself to demo/index.html 
[19:42:28] <James_F>	 Previously it wasn't.
[19:42:31] <Krinkle>	 No, it isn't
[19:42:32] <Krinkle>	 https://github.com/wikimedia/oojs-ui/blob/master/tests/index.html#L15
[19:42:44] <James_F>	 Err. Huh.
[19:42:49] <James_F>	 That's… interesting
[19:43:01] <Krinkle>	 It's passing for me in phantomjs
[19:43:08] <James_F>	 Yeah.
[19:43:09] <Krinkle>	 but that's because the error is asynchronous (setTImeout is used)
[19:43:11] <James_F>	 How did it get lost?
[19:43:15] * James_F sighs.
[19:43:38] <Krinkle>	 It doesn't affect the logic being asserted, it's just a stray exception in this case.
[19:44:08] <Krinkle>	 Which is another reason why I want to kill theme.js with fire, but for another time.
[19:44:40] <Krinkle>	 James_F: Can you run git checkout master; git pull; grunt build and then run oojs/ui/tests/index.html in a browser?
[19:44:48] <Krinkle>	 Tell me you get failures
[19:45:17] <Krinkle>	 http://i.imgur.com/gSIgc2R.png
[19:45:19] <Krinkle>	 brb after dinner
[19:48:55] <TrevorParscal>	 Krinkle|detached: looks like the demo didn't get updated to include the new theme scripts
[19:51:07] <grrrit-wm>	 (03PS30) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) 
[19:54:02] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor:  Cutting and pasting formatted text causes space to be removed after the formatting - 10https://bugzilla.wikimedia.org/71718 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None See https://office.wikimedia.org/w/index.php?diff=118847&oldid=118846  Steps t...
[19:54:17] <wikibugs>	 3MediaWiki extensions / 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - 10https://bugzilla.wikimedia.org/35342#c48 (10paladox2015) Hi I have now fix it.
[20:15:25] <whatami>	 edsanders, ado you happen to be around at this hour?
[20:15:37] <edsanders>	 hi
[20:15:56] <whatami>	 Would you please look at the formatting mess in https://office.wikimedia.org/w/index.php?oldid=118849#Looking_ahead ?
[20:16:32] <whatami>	 It did not look like that when I saved the page.
[20:17:40] <Krenair>	 RoanKattouw_away, James_F: Should https://bugzilla.wikimedia.org/show_bug.cgi?id=71652 be assigned to TrevorP|Away then?
[20:19:53] <whatami>	 edsanders, I filed https://bugzilla.wikimedia.org/show_bug.cgi?id=71718 a few minutes ago, which is also a copy-paste problem, but I don't know whether this is the same thing.
[20:20:12] <edsanders>	 sure
[20:20:20] <whatami>	 Both involve formatted text, but the one I filed just removes spaces, without screwing up the formatting.
[20:21:58] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: The show/hide text a collapsed navbox disappear afted have edited - 10https://bugzilla.wikimedia.org/68279#c9 (10Alex Monk) (Quoting Alex Monk from comment #6) > Gabrasca, could you link to the page showing this issue?
[20:22:35] <edsanders>	 whatami, what is broken?
[20:23:41] <whatami>	 The part that is rendered as "Support for '<i>Internet Explorer 10 <b>may appear very soon. " is supposed to be "Support for <b>Internet Explorer 10</b> may appear very soon."
[20:25:16] <whatami>	 There should be no italics, and there should be no visible single quotation mark, and the wikitext should not later say  ..."[[mediawikiwiki:Cite-from-id|plans to add '''auto-fill features''']]''' ''''''for citations '''soon."
[20:25:31] <whatami>	 Nothing should be bold and italics.
[20:33:00] <wikibugs>	 3OOjs UI: OOjs UI: Menus appearing behind page content in Safari 6.1.3 and 7.0.5 when zoomed in - 10https://bugzilla.wikimedia.org/64388#c30 (10WhatamIdoing) Assuming that the steps to reproduce are:  1.  Read Wikipedia article in Safari.  Zoom in at least twice (Command-+).  2.  Open page in VisualEditor.  3....
[20:41:45] <Krinkle>	 James_F|Away: Did you end up making an overview of david-md badges?
[21:29:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: MWLink nodes inside sub-editor dialogs appear as zero-width - 10https://bugzilla.wikimedia.org/71652 (10Roan Kattouw) a:5Alex Monk>3Trevor Parscal
[21:29:42] <RoanKattouw>	 Krenair: Yes. I've reassigned it
[21:30:04] <Krenair>	 (to be clear, I wasn't saying "I don't want this, please re-assign" but "If you think it should be, then go ahead" :))
[21:30:36] <James_F>	 Krinkle: No, looked around but didn't find things.
[21:30:40] <James_F>	 Hey Roan.
[21:41:48] <grrrit-wm>	 (03PS1) 10Jforrester: test: Load a theme for the test HTML file so the tests don't fail [oojs/ui] - 10https://gerrit.wikimedia.org/r/165112 
[21:45:16] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] "This looks ugly but for the reason you outline in the commit summary it does work: every change ultimately leads to a change in the widget" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164784 (https://bugzilla.wikimedia.org/70861) (owner: 10Mooeypoo)
[21:45:38] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] test: Load a theme for the test HTML file so the tests don't fail [oojs/ui] - 10https://gerrit.wikimedia.org/r/165112 (owner: 10Jforrester)
[21:46:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Emit change event when dimensions change in MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164784 (https://bugzilla.wikimedia.org/70861) (owner: 10Mooeypoo)
[21:46:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: test: Load a theme for the test HTML file so the tests don't fail [oojs/ui] - 10https://gerrit.wikimedia.org/r/165112 (owner: 10Jforrester)
[21:47:39] <grrrit-wm>	 (03CR) 10Mooeypoo: "I think part of the problem is the name of the "setCurrentDimensions" method. It's not *quite* setting current dimensions of the widget, i" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164784 (https://bugzilla.wikimedia.org/70861) (owner: 10Mooeypoo)
[22:03:39] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (cfd855e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165115 
[22:05:26] <grrrit-wm>	 (03PS1) 10Christian: christian test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165116 
[22:05:52] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (cfd855e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165115 (owner: 10Jforrester)
[22:06:31] <BladeBronson>	 Oooh look, Christian is committing some junk
[22:06:58] <grrrit-wm>	 (03Abandoned) 10Christian: christian test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165116 (owner: 10Christian)
[22:07:08] * James_F grins at BladeBronson.
[22:07:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (cfd855e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165115 (owner: 10Jforrester)
[22:10:56] <Krenair>	 RoanKattouw, so for https://bugzilla.wikimedia.org/show_bug.cgi?id=65353 I have a patch that takes the styling code out of MWInternalLinkAnnotation and makes it into a call to ve.init.platform.linkCache.styleElement( annotation.$element, model.getAttribute( 'lookupTitle' ) ); which basically just runs this.get( title ) and the styling code when it completes
[22:11:31] <RoanKattouw>	 Ooh nice
[22:11:47] <Krenair>	 Then overrides getRenderedDomElements in MWTransclusionNode to call the parent function, find all link elements, and apply that function to them
[22:11:58] <RoanKattouw>	 Excellent design
[22:12:01] <legoktm>	 TrevorParscal: I'm not busy whenever you come back
[22:12:10] <RoanKattouw>	 I was looking at that bug earlier today unsure how to do it but that sounds great
[22:12:11] <Krenair>	 Except it needs to be for all generated content nodes
[22:12:14] <TrevorParscal>	 ok, i may have some questions for you
[22:12:18] <Krenair>	 which is in VE core
[22:12:23] <TrevorParscal>	 RoanKattouw: how's europe?
[22:12:27] <RoanKattouw>	 Urgh right
[22:12:29] <RoanKattouw>	 TrevorParscal: It's good.
[22:12:30] <Krenair>	 So I need to make a MWGeneratedContentNode ?
[22:12:40] <RoanKattouw>	 TrevorParscal: Chocolate for you and yours was purchased, see gchat
[22:12:51] <Krenair>	 Oh, the other thing I don't like about my transclusionnode override is this line: var href = JSON.parse( $( this ).attr( 'data-parsoid' ) )['sa']['href'];
[22:13:11] <RoanKattouw>	 Also the Americans grudgingly granted me another visa, so I'm allowed to come back for 3 more years
[22:13:23] <RoanKattouw>	 Krenair: NOOOO
[22:13:38] <RoanKattouw>	 I've been gloating about how we stopped looking at data-parsoid.sa.href over a year ago
[22:14:09] <RoanKattouw>	 What is it needed for? MWLinkAnnotation extracts the link title from the href
[22:14:10] <TrevorParscal>	 3 more years, 3 More Years, 3 MORE YEARS, 3! MORE! YEARS!
[22:14:26] <RoanKattouw>	 There's a separate tech debt bug about factoring out that ./ stripping code
[22:14:33] <Krenair>	 RoanKattouw, ... can we pull that out in getRenderedDomElements?
[22:14:43] <ragesoss>	 I'm trying to edit my userpage with VE, and it seems to get confused by the existing content that includes a the semicolon syntax at the beginning of a line.
[22:14:44] <RoanKattouw>	 TrevorParscal: Yeah if they did 4-year visas I could do a parody of Obama's tweet
[22:14:48] * TrevorParscal feels like chanting is especially difficult to get started on IRC
[22:15:51] <RoanKattouw>	 Krenair: We have href-to-title stuff going on in many places (something like /(\.\.?\/)+/g ), there's a bug about factoring it out
[22:16:16] <RoanKattouw>	 So we could do that
[22:16:55] <RoanKattouw>	 ragesoss: Is this a situation where we believe it's a definition list because of the semicolon, but the PHP parser somehow believes it isn't. Could you link to this page?
[22:17:11] <ragesoss>	 RoanKattouw: https://en.wikipedia.org/wiki/User:Sage_(Wiki_Ed)
[22:17:36] <Krenair>	 RoanKattouw, so what about MWGeneratedContentNode?
[22:18:18] <RoanKattouw>	 ragesoss: What lines does it get confused by?
[22:18:28] <wikibugs>	 3OOjs UI: OOjs UI: Menus appearing behind page content in Safari 6.1.3 and 7.0.5 when zoomed in - 10https://bugzilla.wikimedia.org/64388#c31 (10Bryce Glover) @WhatamIdoing:  Methinks that the problem is highly exacerbated by the use of Safari Extensions (see comment 2 for the full list of stuff I had on my com...
[22:18:48] <ragesoss>	 RoanKattouw: I just saved an edit, which helped me see more about what it is getting confused by.
[22:18:55] <RoanKattouw>	 Krenair: Maaaybe. Except the only reason that works right now is we don't have core nodes extending GCN. If we ever do then we're screwed
[22:19:20] <RoanKattouw>	 ragesoss: Oh, yes, I see
[22:19:28] <RoanKattouw>	 Yeah we don't have good support for definition lists yet
[22:19:37] <RoanKattouw>	 unfortunately
[22:19:40] <ragesoss>	 RoanKattouw: If I start from the semicolon, and then try to add some newlines above it to add content, I can't *not* make the new lines start with semicolons.
[22:19:50] <RoanKattouw>	 Yeah
[22:19:55] <RoanKattouw>	 That's an unfortunate bug
[22:20:19] <Krenair>	 RoanKattouw, well the bug is about doing this for all GCNs, not just templates
[22:20:20] <RoanKattouw>	 However if you create the new line from the other side (you pressed enter before the date, then up arrow, but you could also press enter at the end of the heading) it should work
[22:20:26] <RoanKattouw>	 Krenair: Yeah exactly
[22:20:27] <Krenair>	 I could upload the patch for templates for now
[22:20:37] <Krenair>	 (once I fix data-parsoid.sa.href)
[22:20:42] <RoanKattouw>	 So creating MWGCN would work but only by accident because all GCNs are MW nodes
[22:21:12] <RoanKattouw>	 So we need something better 
[22:21:19] <ragesoss>	 RoanKattouw: I did press enter before the date.
[22:21:24] <RoanKattouw>	 Possibly redefining one of GCN's methods in MW or something, although that's also kinda ugly
[22:21:26] <ragesoss>	 Cursor at the start of the date line, before any text.
[22:21:33] <RoanKattouw>	 ragesoss: Yes exactly, I can tell you did
[22:21:47] <RoanKattouw>	 If, instead, you put the cursor at the end of the thing before the date, then press enter, you should not encounter this bug
[22:22:06] <RoanKattouw>	 I realize that's not an actual answer and we do have a bug here, but you should be able to work around it that way
[22:22:33] <ragesoss>	 RoanKattouw: correct. Also, "clear formatting" is not an option when I highlight the text.
[22:23:01] <RoanKattouw>	 Yeah, because technically it's not formatting but structure :|
[22:23:07] <RoanKattouw>	 Definition lists are an annoying edge case
[22:24:21] <ragesoss>	 Thanks much for talking me through it. Just wanted to make sure it was a known issue.
[22:27:46] <RoanKattouw>	 It wasn't to me as such, but sadly I wasn't surprised
[22:34:00] <wikibugs>	 3VisualEditor: VisualEditor: Cannot enable or disable formatting of lines starting with semicolon markup - 10https://bugzilla.wikimedia.org/71721 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None If there is a line on a page that includes the semicolon syntax, VisualEditor does not handle this well. For e...
[23:05:48] <Krenair>	 James_F, has Roan gone?
[23:09:31] <Krenair>	 oh, of course he has, I forgot where he was now.
[23:22:26] <Krinkle>	 James_F|Away: https://krinkle.github.io/?193 (nicely inspired by twitter.github.io and jquery.github.io)
[23:22:37] <Krinkle>	 give it a while to load
[23:36:20] <legoktm>	 Krinkle: how does it pick which repos to use?
[23:36:45] <Krinkle>	 legoktm: Any repo that doesn't have the default "Mirror from Gerrit" or other "mirror"-related description.
[23:36:58] <legoktm>	 ah
[23:37:01] <Krinkle>	 i.e. things generally in use on github
[23:37:48] <Krinkle>	 If needed, I'll add a manual filter for mediawiki-extensions-* since I don't like those there.
[23:37:55] <Krinkle>	 but so far it seems to work