[00:06:08] (03PS1) 10Christian: Make MWTransclusionModel and MWTemplateDialog extensible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165139 [00:07:27] James_F|Away: https://krinkle.github.io/dm/ [00:07:56] (03PS2) 10Christian: Make MWTransclusionModel and MWTemplateDialog extensible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165139 [00:08:22] James_F|Away: Hm.. This is not really useful. It only serves as a way of asserting we are pinning our versions (as is our convention) [00:08:32] since we always pin them, it'll never tell you about available updates [00:08:49] at least convenient urls though [00:17:29] Krinkle: Hmm. What's it meant to show? [00:17:31] Krinkle: Oh, didn't see https://krinkle.github.io/dm/ and was looking at https://krinkle.github.io/?193 [00:17:42] James_F: the latter shows repos [00:17:46] (once it loads) [00:17:51] Yes, but not status. [00:18:04] indeed [00:18:24] Knowing that we have a bunch of repos isn't great. :-) [00:18:40] Well, it sure as hell is a lot better than the garbage listing Gerrit and gitblit provide [00:19:16] though not meant to be complete at this point. I suspect someone will write up a tool labs dashboard for repos similar to this [00:19:24] the sorting can be useful too (popular repos atop) [00:19:24] * James_F nods. [00:19:31] Ah, is that the sort order. [00:19:35] It was entierly not-clear. [00:19:47] well, it's "relevance" [00:20:08] stars + forks + watchers, for now [00:20:28] but someone writing a dashboard for this on labs is sad, it shows other apps fail [00:20:31] GitHub activity is pretty meaningless. [00:20:36] It is [00:20:43] But so is a-z when there's 800 repos [00:20:55] you'll be guranteed to not show what the user is looking for [00:21:02] this is a best efforts approach [00:21:09] E.g. jQuery.IME is going to "win" whereas MediaWiki-core is going to "lose" because of how they're used. [00:21:09] suggestions welcome :) [00:21:16] Latest patch? [00:21:29] (Latest landed patch to master.) [00:21:38] metric doesn't exist [00:21:45] last pushed exists however [00:21:52] I'm filtering out anything from before 2013 [00:22:09] * James_F nods. [00:22:18] I'd not worry too much. [00:32:21] (03CR) 10Alex Monk: Make MWTransclusionModel and MWTemplateDialog extensible (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165139 (owner: 10Christian) [00:38:53] (03CR) 10Krinkle: "fixme: tabs instead of spaces." [oojs/ui] - 10https://gerrit.wikimedia.org/r/165112 (owner: 10Jforrester) [00:39:15] James_F: 8 spaces? wowy [00:39:22] That must be nano instead of Atom [00:39:23] Krinkle: What did that? [00:39:24] :-) [00:39:36] You tell me [00:39:48] Actually, that's probably cat foo > grep … > … [00:39:54] * James_F sighs at being clever. [00:40:06] (or vim, or some other bash-based s\tabber) [00:40:11] Yeah. [00:40:39] don't worry though, I'll fix it up in the karma fixup [00:40:56] or go ahead and I'll rebase [00:42:19] Done. [00:42:20] (03PS1) 10Jforrester: Follow-up I730e3d: Tab not spaces [oojs/ui] - 10https://gerrit.wikimedia.org/r/165149 [00:53:52] (03CR) 10Jforrester: "Maybe put an
before each control so it's clear that it's not a button itself?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) (owner: 10Bartosz Dziewoński) [00:56:36] (03PS1) 10Krinkle: Element: Remove test for deprecated onDOMEvent() [oojs/ui] - 10https://gerrit.wikimedia.org/r/165152 [00:57:07] (03PS2) 10Krinkle: Follow-up I730e3d7d: Tab not spaces [oojs/ui] - 10https://gerrit.wikimedia.org/r/165149 (owner: 10Jforrester) [00:57:35] (03CR) 10Krinkle: [C: 032] "(need at least 7 hash characters to make a link, GitHub and git-cli follow the same convention of using no less than 7 for uniqueness)." [oojs/ui] - 10https://gerrit.wikimedia.org/r/165149 (owner: 10Jforrester) [00:57:53] Krinkle: Aha, thanks. [00:59:15] (03Merged) 10jenkins-bot: Follow-up I730e3d7d: Tab not spaces [oojs/ui] - 10https://gerrit.wikimedia.org/r/165149 (owner: 10Jforrester) [01:01:55] (03PS1) 10Krinkle: [WIP] build: Use Karma instead of grunt-contrib-qunit [oojs/ui] - 10https://gerrit.wikimedia.org/r/165154 [01:03:13] (03CR) 10Jforrester: [C: 032] "Also fails in Chrome in some cases…" [oojs/ui] - 10https://gerrit.wikimedia.org/r/165152 (owner: 10Krinkle) [01:04:57] (03Merged) 10jenkins-bot: Element: Remove test for deprecated onDOMEvent() [oojs/ui] - 10https://gerrit.wikimedia.org/r/165152 (owner: 10Krinkle) [01:10:07] (03PS2) 10Krinkle: [WIP] build: Use Karma instead of grunt-contrib-qunit [oojs/ui] - 10https://gerrit.wikimedia.org/r/165154 [01:10:09] (03PS1) 10Krinkle: PhantomJS: So long, and thanks for all the … [oojs/ui] - 10https://gerrit.wikimedia.org/r/165157 [01:12:45] (03PS2) 10Krinkle: PhantomJS: So long, and thanks for all the … [oojs/ui] - 10https://gerrit.wikimedia.org/r/165157 [01:16:56] (03CR) 10Jforrester: [C: 031] "What's WIP?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/165154 (owner: 10Krinkle) [01:17:47] (03PS3) 10Jforrester: test: Replace phantomjs with Chromium as the testing target [oojs/ui] - 10https://gerrit.wikimedia.org/r/165157 (owner: 10Krinkle) [01:17:54] (03CR) 10Jforrester: [C: 031] test: Replace phantomjs with Chromium as the testing target [oojs/ui] - 10https://gerrit.wikimedia.org/r/165157 (owner: 10Krinkle) [01:20:03] (03PS4) 10Krinkle: build: Use Chrome and Firefox for tests instead of PhantomJS [oojs/ui] - 10https://gerrit.wikimedia.org/r/165157 [01:25:33] (03PS1) 10Krinkle: build: Simplify Karma configuration [oojs/core] - 10https://gerrit.wikimedia.org/r/165158 [01:26:11] (03PS3) 10Krinkle: build: Use Karma instead of grunt-contrib-qunit [oojs/ui] - 10https://gerrit.wikimedia.org/r/165154 [01:26:15] (03PS5) 10Krinkle: build: Use Chrome and Firefox for tests instead of PhantomJS [oojs/ui] - 10https://gerrit.wikimedia.org/r/165157 [01:28:43] (03PS2) 10Krinkle: build: Simplify Karma configuration [oojs/core] - 10https://gerrit.wikimedia.org/r/165158 [01:29:26] (03PS4) 10Krinkle: build: Use Karma instead of grunt-contrib-qunit [oojs/ui] - 10https://gerrit.wikimedia.org/r/165154 [01:29:30] (03PS6) 10Krinkle: build: Use Chrome and Firefox for tests instead of PhantomJS [oojs/ui] - 10https://gerrit.wikimedia.org/r/165157 [01:30:06] (03CR) 10Krinkle: "Never mind, the default 'progress' reporter is even buggier and more uselessly verbose on Jenkins: https://integration.wikimedia.org/ci/jo" [oojs/core] - 10https://gerrit.wikimedia.org/r/165158 (owner: 10Krinkle) [01:37:30] (03CR) 10Jforrester: [C: 032] build: Use Karma instead of grunt-contrib-qunit [oojs/ui] - 10https://gerrit.wikimedia.org/r/165154 (owner: 10Krinkle) [01:38:08] (03CR) 10Jforrester: [C: 04-1] "We should suppress the coverage report from one of these; getting it twice is silly." [oojs/core] - 10https://gerrit.wikimedia.org/r/165158 (owner: 10Krinkle) [01:38:35] (03CR) 10Jforrester: [C: 04-1] "We should suppress the coverage report from one of these; getting it twice is silly." [oojs/ui] - 10https://gerrit.wikimedia.org/r/165157 (owner: 10Krinkle) [01:39:34] (03Merged) 10jenkins-bot: build: Use Karma instead of grunt-contrib-qunit [oojs/ui] - 10https://gerrit.wikimedia.org/r/165154 (owner: 10Krinkle) [01:39:50] (03CR) 10Jforrester: "(Err… thrice.)" [oojs/core] - 10https://gerrit.wikimedia.org/r/165158 (owner: 10Krinkle) [01:45:33] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] In media dialog, "Size values are invalid" message does not show up, when choosing a different image and then setting its size to 0 x 0 px - 10https://bugzilla.wikimedia.org/70861#c14 (10James Forrester) 5PATC>3RESO/FIX Not pulled through y... [02:24:58] (03PS3) 10Jforrester: In first-time dialog, explain how to switch to source without losing work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164503 (owner: 10Mattflaschen) [02:25:11] (03CR) 10Jforrester: [C: 032] "Thanks." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164503 (owner: 10Mattflaschen) [02:29:10] (03Merged) 10jenkins-bot: In first-time dialog, explain how to switch to source without losing work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164503 (owner: 10Mattflaschen) [03:02:46] 3VisualEditor / 3ContentEditable: VisualEditor: Copying text causes Safari to scroll to the top of the page and move the cursor to the top - 10https://bugzilla.wikimedia.org/71728 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None Steps to reproduce: 1. Open a long page in Safari 6.2 (maybe others?)... [03:46:59] 3VisualEditor / 3Editing Tools: VisualEditor: Content in translate templates do not render in friendly ways - 10https://bugzilla.wikimedia.org/71730#c1 (10Jared Zimmerman (WMF)) see https://www.mediawiki.org/wiki/Communication?veaction=edit [03:47:02] 3VisualEditor / 3Editing Tools: VisualEditor: Content in translate templates do not render in friendly ways - 10https://bugzilla.wikimedia.org/71730 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Created attachment 16686 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16686&action=... [04:15:30] 3VisualEditor: [Regression] VisualEditor: Save button stays disabled after inserting a character - 10https://bugzilla.wikimedia.org/71732 (10Krinkle) 3NEW p:3Unprio s:3critic a:3None 1. Open https://www.mediawiki.org/wiki/QA/Selenium_Workshop in latest stable Chrome. 2. Click "Edit" 3. Put cursor in th... [04:16:58] 3VisualEditor: [Regression] VisualEditor: Save button stays disabled after inserting a character - 10https://bugzilla.wikimedia.org/71732#c1 (10Krinkle) It seems the model is consistently one character behind. When I worked-round the bug in comment #0 by backspacing over my new character and typing it again, a... [06:16:45] 3VisualEditor: VisualEditor: Welcome dialog fills entire screen (Cancel button hard to find) - 10https://bugzilla.wikimedia.org/71736 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Created attachment 16689 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16689&action=edit Screenshot of bug. Open h... [06:56:35] (03CR) 10Bartosz Dziewoński: "James, eh, I'm not sure if that's going to look well... I'm planning to do list "separator" support soon anyway." [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) (owner: 10Bartosz Dziewoński) [07:00:45] (03PS6) 10Bartosz Dziewoński: ListToolGroup: Implement collapsible/expandable tools [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) [07:02:13] (03CR) 10Bartosz Dziewoński: ListToolGroup: Implement collapsible/expandable tools (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) (owner: 10Bartosz Dziewoński) [07:42:13] 3VisualEditor: [Regression] VisualEditor: Save button stays disabled after inserting a character - 10https://bugzilla.wikimedia.org/71732#c2 (10Roan Kattouw) Could this be fixed by https://gerrit.wikimedia.org/r/164514 ? [07:43:39] (03CR) 10Catrope: [C: 032] Display JSON configuration options in NS_MEDIAWIKI as JSON [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165037 (owner: 10Legoktm) [07:45:16] (03Merged) 10jenkins-bot: Display JSON configuration options in NS_MEDIAWIKI as JSON [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165037 (owner: 10Legoktm) [07:54:48] Oh? Yay [07:55:01] Every time you join you'll automatically be +v-ed by ChanServ [07:55:56] I see. [07:56:02] Smart [07:56:25] +v doesn't really give us any special rights here, but it groups us at the top of the nick list in most clients, so people can see we're the cool kids and all the others are lurkers :P [07:57:14] I see. [07:57:16] Mean [07:58:24] This channel is publicly logged at http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki-visualeditor/ , [07:59:11] So, I should not have called it mean? Hmm. [07:59:22] haha [08:21:12] (03PS7) 10Krinkle: ListToolGroup: Implement collapsible/expandable tools [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) (owner: 10Bartosz Dziewoński) [08:29:42] RoanKattouw: https://gerrit.wikimedia.org/r/165037 doesn't seem to do anything for me locally [08:29:48] how do I check that it's doing something? [08:30:00] I don't see 
 rendering, and I was able to save it with a syntax error
[08:30:13] 	 if it does neither of that, what does it do?
[08:32:24] 	 Hmm that's weird
[08:32:31] 	 I think that's what it's supposed to do
[08:33:02] 	 Did it work for you?
[08:33:14] 	 Well I didn't test it (sorry)
[08:33:23] 	 I just read it and went "well OF COURSE this'll work"
[08:33:25] 	 (famous last words)
[08:34:06] 	 Hmm you're right, it doesn't work for me either
[08:36:29] 	 The hook doesn't seem to be run at all?
[08:36:31] * RoanKattouw updates MW core
[08:38:54] 	 Hmm no the code is running, at least when I save
[08:39:00] 	 But it doesn't seem to care that I saved invalid JSON
[08:40:30] 	 Oooh hold on
[08:40:33] 	 I think I know
[08:49:40] 	 Krinkle: I don't know what's going on. I tried putting return false; in but that doesn't change anything. The code is being run though. I'll ask legoktm when he's awake
[08:50:03] 	 k
[08:51:04] 	 (03CR) 10Krinkle: "fixme: This change doesn't seem to do anything. The MediaWiki page stil renders as text instead of 
 (whether it exists locally or dis" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165037 (owner: 10Legoktm)
[08:51:12] 	 RoanKattouw: ^
[08:51:23] 	 Oh hah I was writing that too
[08:51:45] 	 I'm off to sleep for a few more hours. Hunger woke me up as my eating schedule is off, my sleep schedule was adjusted (I just stay up longer the first day), but now its off again.
[08:51:54] 	 (03CR) 10Catrope: "I tried adding return false; after $model = CONTENT_MODEL_JSON; but that didn't seem to help." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165037 (owner: 10Legoktm)
[08:52:05] 	 Krinkle: Yeah I had the same thing, kept waking up around 6
[08:55:14] 	 RoanKattouw: interesting. This is the first time, with all my flying in the past 3 yrs, that I have a food jetlag
[08:58:42] 	 I had it coming back from Zurich
[08:58:54] 	 Kept waking up at 5 or 6 and having to wait for the bagel place downstairs to open (at 7)
[08:59:26] 	 It's usually just a few days, and I can avoid it if I make an effort to
[08:59:59] 	 But this time I had to go to the consulate in Amsterdam right off the plane, and that took forever, and then I had meetings in the evening so I didn't really have a good opportunity to adjust properly
[09:09:07] 	 (03CR) 10Krinkle: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) (owner: 10Bartosz Dziewoński)
[09:09:32] 	 RoanKattouw: Yes, exactly. There's no decent food in this country until 7 or 8.
[09:10:03] 	 I have the same at night sometimes when I'm working late. After 2am, it's nomansland down town
[09:10:07] 	 Even in Enschede
[09:27:27] 	 Krinkle: Dude I'm in Friesland
[11:05:43] 	 3MediaWiki extensions / 3TemplateData: TemplateData:  If TemplateData is added to a template page (not a /doc subpage), then it needs to be wrapped in  tags - 10https://bugzilla.wikimedia.org/69149#c6 (10Richard Morris) This has caused a few problems on the en wiki. As I discuss at https://en.wiki...
[11:08:28] 	 3OOjs UI: OOjs UI: TextInputWidget's textarea gets silly scrollbars when it shouldn't - 10https://bugzilla.wikimedia.org/71310#c9 (10Bartosz Dziewoński) I think that's the part tracked as bug 71427.
[11:09:47] 	 (03PS8) 10Bartosz Dziewoński: ve.ui.CommentInspector: Update size when the textarea gets resized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) 
[12:00:44] 	 3OOjs UI: OOjs UI: Toolbar menus should use sub-groups with a separator (
?) between them for splitting up longer lists - 10https://bugzilla.wikimedia.org/71616#c1 (10Bartosz Dziewoński) This looks like it'd require us to implement either subgroups of some kind, or a way to explicitly order the groups (to b...
[12:19:13] 	 (03CR) 10Bartosz Dziewoński: "I am actually not sure if this is the right way to go per https://bugzilla.wikimedia.org/show_bug.cgi?id=71616#c1 . We might instead want " [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) (owner: 10Bartosz Dziewoński)
[12:34:24] 	 (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] The Great Selection Rewrite of 2014 (038 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 (owner: 10Esanders)
[14:28:11] 	 edsanders: Did you get anywhere with those iOS 8 bugs?
[14:32:17] 	 grumble, ooui build takes really long.
[14:32:21] 	 also hi.
[14:33:39] 	 MatmaRex: It's because some guy added this slow PNG rasterization thing ;)
[14:34:10] 	 i blame trevor ;) but that takes less than half of the run time
[14:35:42] 	 is there a reason not to create a 'quickbuild' task that would skip svg2png, uglify, csscomb, etc.?
[14:36:38] 	 'time-grunt' is a really neat npm module for measuring the times and it tells me that csscomb is the second slower after svg2png :( with the build tasking ~40s
[14:36:59] 	 RoanKattouw, hey
[14:37:20] 	 Holy crap
[14:37:21] 	 So I wanted to deal with the data-parsoid.sa.href thing
[14:37:32] 	 MatmaRex: Yeah quickbuild would be cool. We could hook that up to grunt watch too
[14:37:49] 	 Did you say we could access annotations etc. for things under the transclusion CE node?
[14:37:52] 	 (actually test is 40s, build is 30s)
[14:41:38] 	 Krenair: Ahm no, so what I meant was
[14:42:05] 	 MWInternalLinkAnnotation has relatively simple logic for taking an href and converting it to a title
[14:43:27] 	 It's basically about stripping ./ and ../ prefixes, plus some more complications to deal with absolute URLs that I don't quite recall why they're there
[14:44:09] 	 Oh the absolute handling is for copy-paste so we probably don't need that part
[14:44:24] 	 It looks like that's currently part of toDataElement
[14:44:31] 	 But there's a tech debt bug somewhere that I filed like a year ago that complains about how this ./ ../ stripping stuff is duplicated in a bunch of places and needs to be centralized
[14:45:17] 	 So I figured if you factor that out into a function that turns an href into a title and make it static, then you can use it instead of sa.href
[14:45:23] 	 It looks like the href attributes I'm getting are absolute.
[14:45:31] 	 ( https://bugzilla.wikimedia.org/show_bug.cgi?id=61572 )
[14:45:48] 	 Krenair: Are you using element.href or element.getAttribute( 'href' ) ?
[14:45:59] 	 $link.attr( 'href' )
[14:46:14] 	 Hmm
[14:46:38] 	 Can you put a breakpoint in there and check what each of those things I said say? I don't trust jQuery to not be excessively clever
[14:47:04] 	 So I was using $link = $( this )
[14:47:17] 	 I stuck console.log in there, this.href is also absolute
[14:47:23] 	 yeah it would be
[14:47:30] 	 But what about this.getAttribute( 'href' )?
[14:47:58] 	 absolute
[14:48:06] 	 grr alright fine
[14:48:17] 	 Then I suppose you'll have to factor that stuff out too
[15:44:58] 	 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of ve.splitClusters - 10https://bugzilla.wikimedia.org/57628#c1 (10Sucheta Ghoshal) Well, if we are going beyond BMP, we need to take surrogate pairs into account, too. JavaScript does not do that natively, AFAIK. Would code points be enough in that case?
[15:45:22] 	 ^ RoanKattouw  : There, I added it as a comment 
[15:46:30] 	 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of ve.splitClusters - 10https://bugzilla.wikimedia.org/57628#c2 (10Roan Kattouw) a:3Sucheta Ghoshal (In reply to Sucheta Ghoshal from comment #1) > Well, if we are going beyond BMP, we need to take surrogate pairs into > account, too. JavaScript does n...
[15:47:42] 	 divec: Could you refresh my memory here? ----^^
[15:48:40] 	 I can't think of David's name without those cute Erin pictures flashing in front of my eyes. :P 
[15:48:56] 	 haha
[15:49:07] 	 I think David might be a bit slow to respond for that very reaso
[15:49:16] 	 The ones that are ruling the internet presently 
[15:49:34] 	 He's totally forgiven, in that case 
[15:49:44] 	 Heya.
[15:49:48] 	 MatmaRex: I wouldn't waste time making a "quick build" grunt task, given that Krinkle|detached wants us to switch away from grunt to gullp.
[15:49:50] * James_F grins.
[15:49:56] 	 In private chat with me he's already apologized with "Erinterruption" a few times
[15:50:39] 	 That's a clever term; going to be used throughout her life 
[15:51:47] 	 James_F: Good morning. You'll be pleased to hear that I reviewed Ed's selection change, and less pleased to hear that it contains calls to .getDocuemnt()
[15:51:55] 	 Eww.
[15:51:58] 	 Other than that my comments were minor though
[15:55:07] * James_F punts 71732 to you.
[15:55:16] 	 3VisualEditor / 3Data Model: VisualEditor: [Regression?] Save button stays disabled after inserting a character in some cases. - 10https://bugzilla.wikimedia.org/71732#c3 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Roan Kattouw This works fine if the first cursor position is in the Header, or...
[15:57:09] 	 RoanKattouw, so I'm thinking move the link logic out of ve.dm.MWInternalLinkAnnotation.static.toDataElement into its own static function, getTargetDataFromHref or something
[15:57:18] 	 It does seem to work fine apart from crashing the link inspector in insertion mode, and adding classes like ve-ce-dir-null
[15:57:26] 	 returning { title: matches[2], hrefPrefix: matches[1] };
[15:57:28] 	 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of ve.splitClusters - 10https://bugzilla.wikimedia.org/57628#c3 (10David Chan) Hi, yes, we wrote ve.splitClusters because we wanted to make the document model be a list of grapheme clusters, instead of a list of raw Javascript characters (i.e. Unicode co...
[15:57:54] 	 just taking the href and document
[15:57:58] 	 3MediaWiki extensions / 3TemplateData: TemplateData: GUI editor (tracking) - 10https://bugzilla.wikimedia.org/65544 (10James Forrester)
[15:58:01] 	 3MediaWiki extensions / 3TemplateData: TemplateData GUI: Port interface to OOjs UI. - 10https://bugzilla.wikimedia.org/71746 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3Moriel Schottlender This is pretty high priority (and yet probably rather a pain).
[15:58:13] 	 3VisualEditor / 3Data Model: VisualEditor: [Regression?] Save button stays disabled after inserting a character in some cases. - 10https://bugzilla.wikimedia.org/71732#c4 (10Ed Sanders) Works for me in latest Chrome
[15:58:48] 	 mooey|away: https://bugzilla.wikimedia.org/show_bug.cgi?id=71078 is pretty high-priority, but https://bugzilla.wikimedia.org/71746 might mean you want to focus on that first.
[15:58:55] 	 edsanders: Then you've not tried hard enough. :-)
[15:59:09] 	 I did as instructed
[15:59:17] 	 edsanders: Where did you click, exactly?
[15:59:23] 	 the first paragraph
[15:59:26] 	 Where?
[15:59:49] 	 hmm
[15:59:51] 	 maybe caching
[15:59:53] 	 E.g. drop the cursor between the 'e' and the 'n' of Selenium.
[15:59:55] 	 broken now
[16:00:11] 	 Also, not this only happens on the very first click; if you get it to work at first, I couldn't get it to break later.
[16:03:00] 	 I also realized today that I'll have to rebase the slug and unicorn changes onto the selection rewrite, that'll be fun
[16:03:27] 	 Krenair: Yeah sounds good
[16:03:41] 	 Krenair: Right, I totally forgot that the hrefPrefix needs to be extracted as well, good call
[16:04:00] 	 3VisualEditor / 3Data Model: VisualEditor: [Regression?] Save button stays disabled after inserting a character in some cases. - 10https://bugzilla.wikimedia.org/71732#c5 (10Ed Sanders) Only happens on first click.
[16:04:20] 	 RoanKattouw: Indeed.
[16:04:25] 	 RoanKattouw: Unless you merge them first! ;-)
[16:04:29] 	 ha
[16:04:43] 	 Maybe not while I have easy reproduction steps for a crash
[16:06:24] 	 OK, dinner time, back later
[16:06:47] 	 See you.
[16:08:49] 	 now it won't reproduce in debug mode...
[16:08:52] 	 hey James_F, seen https://bugzilla.wikimedia.org/show_bug.cgi?id=71616#c1 or the last comment on https://gerrit.wikimedia.org/r/#/c/164590/ ?
[16:09:08] 	 MatmaRex: … bah.
[16:09:17] 	 MatmaRex: Apparently it helps if I press "Save Changes".
[16:10:18] 	 3MediaWiki extensions / 3TemplateData: TemplateData GUI: Port interface to OOjs UI - 10https://bugzilla.wikimedia.org/71746 (10James Forrester) p:5Unprio>3High
[16:10:20] 	 cursor positions look correct, must be the insertion observation
[16:10:43] 	 3OOjs UI: OOjs UI: Toolbar menus should use sub-groups with a separator (
?) between them for splitting up longer lists - 10https://bugzilla.wikimedia.org/71616#c2 (10James Forrester) (In reply to Bartosz Dziewoński from comment #1) > This looks like it'd require us to implement either subgroups of some kin...
[16:11:02] 	 MatmaRex: The mock-up doesn't show headings of sub-groups, just of the overall group.
[16:12:08] 	 hm, okay. sounds like rewrite-time then
[16:13:22] 	 MatmaRex: Wait.
[16:13:42] 	 (03CR) 10Jforrester: "I think the collapsibility model would happen on the tools not the tool groups, probably." [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) (owner: 10Bartosz Dziewoński)
[16:13:46] 	 ^^^ There.
[16:14:12] 	 (03PS3) 10Divec: Make slug animations work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164516 (owner: 10Catrope)
[16:14:14] 	 (03PS50) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 
[16:14:16] 	 (03PS4) 10Divec: Get rid of trigger-happy slugChange event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164515 (owner: 10Catrope)
[16:14:18] 	 (03PS3) 10Divec: Followup 2fcc4c0: fix bugs with selection-only polling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164514 (owner: 10Catrope)
[16:14:20] 	 (03PS18) 10Divec: Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders)
[16:16:01] 	 (03CR) 10jenkins-bot: [V: 04-1] Followup 2fcc4c0: fix bugs with selection-only polling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164514 (owner: 10Catrope)
[16:16:29] 	 (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec)
[16:17:50] 	 (03PS1) 10Divec: POC: Match native content start annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165233 
[16:19:22] 	 (03CR) 10jenkins-bot: [V: 04-1] POC: Match native content start annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165233 (owner: 10Divec)
[16:30:01] 	 (03PS1) 10Alex Monk: Apply link styling logic to transclusion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165240 (https://bugzilla.wikimedia.org/653539) 
[16:31:36] 	 (03CR) 10jenkins-bot: [V: 04-1] Apply link styling logic to transclusion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165240 (https://bugzilla.wikimedia.org/653539) (owner: 10Alex Monk)
[16:33:19] 	 mooeypooooo
[16:34:41] 	 (03PS2) 10Alex Monk: Apply link styling logic to transclusion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165240 (https://bugzilla.wikimedia.org/653539) 
[16:39:00] 	 (03PS3) 10Alex Monk: Apply link styling logic to transclusion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165240 (https://bugzilla.wikimedia.org/653539) 
[17:23:20] 	 James_F: Hmm you seem to have created https://gerrit.wikimedia.org/r/#/c/164593/ as part of a backport but do you remember how far through you went with that?
[17:26:10] 	 RoanKattouw: I thought it was deployed?
[17:26:15] 	 It might be?
[17:26:16] 	 RoanKattouw: Is it not?
[17:26:31] 	 If not it really should be…
[17:26:32] 	 Well instead of finding out (which takes time) I figured I'd ask you if you recalled
[17:26:42] 	 ryasmeen said this one needed to be backported, so...
[17:26:45] 	 I don't, sorry.
[17:26:48] 	 I don't know how recently she checked
[17:26:58] 	 OK well then I'll just dig into it and find out
[17:27:14] 	 Ta.
[17:27:28] 	 RoanKattouw: ad2a4ef58be6dcbc0c2ed2da49d50d288721de5f
[17:27:35] 	 RoanKattouw: In VE-MW pulls it in for wmf2.
[17:27:58] 	 I see
[17:28:31] 	 Oh, created on Oct 3
[17:28:36] 	 But not deployed yet?
[17:28:40] * James_F sighs at himself.
[17:28:43] 	 Oct 3 was a Friday
[17:28:55] 	 So the first available SWAT window for it was like 2 hours ago
[17:29:32] 	 Also that explains why I didn't know about it, because I was barely working that day
[17:29:54] 	 I attended the Parsoid QR and went back to sleep
[17:30:47] 	 James_F: Anyway OK I'll create a core pull-through commit for this and list it for the SWAT
[17:30:56] * James_F nods.
[17:30:58] 	 RoanKattouw: Thanks.
[17:31:13] 	 Would you like it to be listed for 4pm today (when I'm asleep) or 8am tomorrow (when I'll be awake but probably eating or helping siblings with homework or whatever)
[17:34:24] 	 RoanKattouw: Or 04:00 tomorrow?
[17:34:32] 	 Oh right, that exists now
[17:34:42] 	 greg-g: Are the 04:00 SWATs extant yet?
[17:34:50] 	 no
[17:34:58] 	 Thanks. :-)
[17:34:59] 	 I've been mentally blocking on that...
[17:35:03] 	 :/
[17:35:06] 	 They're not in the calendar
[17:35:06] 	 RoanKattouw: 08:00 SF is fine.
[17:35:07] 	 sick week then camping
[17:35:12] 	 greg-g: No worries.
[17:35:14] 	 OK
[17:35:23] 	 greg-g: We can add them next week. :-)
[17:35:38] 	 yeah, I'm just worried about brad's comment
[17:35:54] 	 Which one?
[17:40:59] 	 James_F: that moving the time for the "morning SF" slot will mean he won't really participate anymore
[17:41:04] 	 or was that to just me?
[17:41:30] 	 ah yeah, just to me
[17:42:00] 	 10am SF == 13:00 his time, which is prime work time
[17:46:14] 	 Oh, boo.
[17:46:45] 	 James_F: https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=130234&oldid=130110
[17:47:20] 	 greg-g: Have enough people come forward to make up for that? Brad's been a complete trooper on morning SWATs.
[17:47:26] 	 I'm gonna hang out with my family for a bit, will be back later at some point
[17:47:27] 	 RoanKattouw: Thanks.
[17:47:35] 	 Also because Wednesday is meeting-o-rama
[17:47:42] 	 James_F: yeah, that's the solution there
[17:48:07] * James_F nods.
[17:54:23] 	 so, I've recently learned I love sardines
[17:54:47] 	 not that it's shocking when i love a food I've never had before, given i love all food
[17:54:53] 	 but, they are really good
[17:57:11] 	 TrevorParscal: I doubt RoanKattouw_away will agree with you on that, given, well, fish.
[17:57:57] 	 always hatin' on the fish!
[18:01:13] * James_F grins.
[18:01:29] 	 TrevorParscal: Maybe when moo|food moves here you'll have a fellow fish-lover?
[18:01:30] 	 … that sounds wrong.
[18:02:09] 	 (03PS3) 10Christian: Make MWTransclusionModel and MWTemplateDialog extensible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165139 
[18:02:35] 	 My race's tradition demands me to be fish lover. 
[18:02:49] 	 But, hmm, I don't know. 
[18:03:24] 	 I like shrimps, which are not technically considered as fish. 
[18:04:05] 	 (03PS4) 10Christian: Make MWTransclusionModel and MWTemplateDialog extensible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165139 
[18:04:17] 	 sucheta: :-)
[18:06:34] 	 There are a few other genres of fish that Bengal is famous for, Ilish (http://en.wikipedia.org/wiki/Ilish) being one of them 
[18:07:33] 	 People go absolutely nuts over this one. 
[18:08:17] 	 Maybe ryasmeen would know? 
[18:09:00] 	 sucheta, yeah thats the only fish that I like though :)
[18:09:38] 	 moo|food: You have e-mail.
[18:09:46] 	 Me too. I wish they came boneless. 
[18:33:08] 	 sucheta: The fish I poked bones out of, was that Ilish?
[18:34:16] 	 Because if so, I agree they should be boneless
[18:34:39] 	 RoanKattouw, No, that was a rather simpler one 
[18:34:59] 	 Wait ilish has more bones?
[18:35:04] 	 Ilish is much more complicated bone-wise. 
[18:41:46] 	 sucheta: You got RoanKattouw to eat fish?!
[18:42:04] 	 James_F: You do realize, I do eat some fish
[18:42:12] 	 RoanKattouw: Uh-huh.
[18:42:15] 	 Although yes she got me to eat a kind of fish I ordinarily wouldn't eat
[18:42:25] 	 It wasn't too fishy, and there was curry involved
[18:42:31] 	 Aha.
[18:42:44] 	 If you want to applaud someone, look no further than Cadence
[18:42:45] 	 Q: How do you get someone to eat fish if they dislike fish? A: Cover it in curry.
[18:42:48] 	 She got me to eat salmon
[18:42:54] 	 Smoked?
[18:43:01] 	 No, salmon fukikake (sp?)
[18:43:08] 	 Gosh.
[18:43:24] 	 So laced with Japanese herbs and mayonnaise
[18:43:35] 	 There you go, my other weakness: mayonnaise
[18:44:10] 	 Heh. 
[18:44:36] 	 :-)
[18:46:01] 	 This is when I'd just done a positioning ride to put my bike in Trevor's garage ahead of our bicycling extravaganza the weekend before last
[18:46:11] 	 So I ate dinner with Trevor (salmon) and then again with Melissa (grilled cheese)
[18:46:31] * James_F grins.
[18:46:34] 	 Two-dinner Roan.
[18:50:04] 	 (03CR) 10Jforrester: [C: 032] Fix styles not showing up, and use addModuleStyles since it's only CSS [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/161983 (owner: 10Legoktm)
[18:51:41] 	 (03PS9) 10Esanders: [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 
[18:51:43] 	 (03PS16) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[18:51:45] 	 (03PS19) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[18:51:47] 	 (03PS2) 10Esanders: WIP non-native table handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164616 
[18:51:49] 	 (03PS20) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb)
[18:51:51] 	 (03PS21) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[18:53:26] 	 (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb)
[18:53:47] 	 (03CR) 10jenkins-bot: [V: 04-1] WIP non-native table handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164616 (owner: 10Esanders)
[19:00:18] 	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf 2] Deleting any focusable node throws "error:NS_ERROR_FAILURE:" in Firefox and wrong context menu starts appearing for other nodes - 10https://bugzilla.wikimedia.org/71580#c7 (10Rummana Yasmeen) Verified the fix in Betalabs
[19:00:58] 	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf2] Deleting any focusable node throws "error:NS_ERROR_FAILURE:" in Firefox and wrong context menu starts appearing for other nodes - 10https://bugzilla.wikimedia.org/71580 (10James Forrester)
[19:01:21] 	 Krenair: Want to take a break and quickly merge https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/CiteThisPage,dashboards/default this stack? :-)
[19:23:56] 	 James_F, sure, looking
[19:24:12] 	 Thanks.
[19:27:28] 	 (03PS10) 10Catrope: [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 (owner: 10Esanders)
[19:27:35] 	 (03CR) 10Alex Monk: [C: 032] Remove CiteThisPageForm, fold into SpecialCiteThisPage [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/161980 (owner: 10Legoktm)
[19:27:38] 	 (03Merged) 10jenkins-bot: Remove CiteThisPageForm, fold into SpecialCiteThisPage [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/161980 (owner: 10Legoktm)
[19:28:02] 	 (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 (owner: 10Esanders)
[19:28:09] 	 Eek.
[19:28:15] 	 There we go
[19:28:20] 	 edsanders: Here goes nothing. :-)
[19:28:20] 	 Rebase hell for me, and a heart attack for ryasmeen 
[19:28:30] 	 David and I have more heart attacks planned for her on Thursday
[19:28:31] 	 Poor ryasmeen. :-)
[19:29:08] 	 :)
[19:29:11] 	 RoanKattouw: Is there a pull-through?
[19:29:32] 	 its okay! I can live through it ;)
[19:29:32] 	 Yeah there's a "fix the breaking changes" commit if that's what you mean
[19:29:32] 	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 (owner: 10Esanders)
[19:29:38] 	 Aha, https://gerrit.wikimedia.org/r/#/c/163873/
[19:29:41] 	 Yeah
[19:29:45] * James_F preps.
[19:29:48] 	 I'm now building a pull-throught to squash into that
[19:29:55] 	 Oh, I can do that if you want.
[19:29:59] * James_F shrugs.
[19:30:06] 	 I'm already on it
[19:30:10] 	 Kk.
[19:31:34] 	 (03PS2) 10Alex Monk: Set visiblity for functions on SpecialCiteThisPage [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/161981 (owner: 10Legoktm)
[19:31:52] 	 (03CR) 10Alex Monk: [C: 032] Set visiblity for functions on SpecialCiteThisPage [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/161981 (owner: 10Legoktm)
[19:31:55] 	 (03Merged) 10jenkins-bot: Set visiblity for functions on SpecialCiteThisPage [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/161981 (owner: 10Legoktm)
[19:32:14] 	 (03CR) 10Alex Monk: "(In PS2 I removed an extra space and an extra line)" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/161981 (owner: 10Legoktm)
[19:32:31] 	 (03PS2) 10Alex Monk: Fix styles not showing up, and use addModuleStyles since it's only CSS [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/161983 (owner: 10Legoktm)
[19:33:08] 	 (03CR) 10Alex Monk: [C: 032] Fix styles not showing up, and use addModuleStyles since it's only CSS [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/161983 (owner: 10Legoktm)
[19:33:15] 	 (03Merged) 10jenkins-bot: Fix styles not showing up, and use addModuleStyles since it's only CSS [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/161983 (owner: 10Legoktm)
[19:33:24] 	 woot, thanks Krenair 
[19:33:41] 	 yw :)
[19:37:44] 	 (03PS2) 10Catrope: Update VE core submodule to master (984b57a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163873 (owner: 10Esanders)
[19:38:09] 	 legoktm: Hey did you see Krinkle|detached's comment on your JSON content model change in VE?
[19:38:37] 	 I merged it because it looked obviously correct, but then neither of us managed to actually get it to do anything (like change behavior anywhere)
[19:39:21] 	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (984b57a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163873 (owner: 10Esanders)
[19:39:39] 	 (03PS3) 10Catrope: Update VE core submodule to master (984b57a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163873 (owner: 10Esanders)
[19:39:42] 	 RoanKattouw: It changes the appearance of the message in the read mode.
[19:39:52] 	 RoanKattouw: Observe: http://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Visualeditor-cite-tool-definition.json
[19:40:11] 	 RoanKattouw: But hmm, not the edit hook to the JSON editor: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=MediaWiki:Visualeditor-cite-tool-definition.json&action=edit
[19:40:18] 	 It looked like that before too
[19:40:27] 	 And I was able to save invalid JSON locally as well
[19:42:35] 	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (984b57a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163873 (owner: 10Esanders)
[19:42:59] 	 RoanKattouw: Yes, but this change was meant to fix that.
[19:43:09] 	 I know
[19:43:11] 	 And it didn't
[19:43:16] 	 RoanKattouw: And no it didn't, compare with http://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Visualeditor-cite-tool-definition.json
[19:43:17] 	 Which is why Timo and I were confused
[19:43:27] 	 It fixes the display part, though.
[19:43:39] 	 But that was this morning, so I shelved it waiting for legoktm to wake up
[19:43:44] * James_F nods.
[19:43:48] 	 But the display part looked like that before for me
[19:43:59] 	 Are you sure? It never has in production.
[19:44:01] 	 (03Merged) 10jenkins-bot: Update VE core submodule to master (984b57a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163873 (owner: 10Esanders)
[19:44:02] 	 Well, good news, he's awake and now he's ignoring you. :-)
[19:44:04] 	 Gosh.
[19:44:55] 	 I'm not 100% sure. Also I might have some weird extensions installed
[19:47:07] 	 edsanders: And this, good sir, is where you review my stage slugs stack :)
[19:48:59] 	 RoanKattouw: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=MediaWiki:Visualeditor-cite-tool-definition.json&action=info says "json"
[19:49:00] 	 OHHH
[19:49:01] 	 I know why.
[19:49:02] 	 RoanKattouw: now look at http://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Visualeditor-cite-tool-definition.json
[19:49:03] 	 RoanKattouw: just needed a null edit
[19:49:15] 	 Aha
[19:49:57] 	 http://en.wikipedia.beta.wmflabs.org/w/index.php?title=MediaWiki%3AVisualeditor-cite-tool-definition.json&diff=138759&oldid=85623 also got "prettified" by PST
[19:52:16] 	 RoanKattouw: as for locally, you probably have $wgContentHandlerUseDB=true;
[19:52:43] 	 which is what you want, but it means you have to manually change the content model.. iirc
[19:55:08] 	 (03CR) 10Alex Monk: Apply link styling logic to transclusion nodes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165240 (https://bugzilla.wikimedia.org/653539) (owner: 10Alex Monk)
[19:55:57] 	 (03CR) 10Alex Monk: [C: 04-1] Apply link styling logic to transclusion nodes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165240 (https://bugzilla.wikimedia.org/653539) (owner: 10Alex Monk)
[19:56:19] 	 RoanKattouw: i'm tweaking the algorithm I used to calculate baseboards for my house remodel and am going to give it to mooey for image fitting
[19:56:37] 	 images on rows instead of runs on boards
[19:56:38] 	 same crap
[19:56:41] 	 optimal fit
[19:57:28] 	 tweaking it a bit to evenly distribute outliers (esp. narrow or wide images) and calculate multiple random solutions and choose the one with the smallest gaps
[19:57:41] 	 I'll have to show it to you so you can rewrite it to be smarter
[19:57:41] 	 RoanKattouw, James_F: Also https://gerrit.wikimedia.org/r/#/c/165325/
[19:57:46] 	 it's sort of brute force
[20:02:30] 	 (03PS4) 10Alex Monk: Apply link styling logic to transclusion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165240 (https://bugzilla.wikimedia.org/65353) 
[20:03:56] 	 (03CR) 10jenkins-bot: [V: 04-1] Apply link styling logic to transclusion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165240 (https://bugzilla.wikimedia.org/65353) (owner: 10Alex Monk)
[20:04:38] 	 (03PS5) 10Alex Monk: Apply link styling logic to transclusion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165240 (https://bugzilla.wikimedia.org/65353) 
[20:09:35] 	 ... how was I not here
[20:09:41] * mooeypoo beats xchat
[20:09:50] 	 mooeypoo: :-)
[20:09:52] 	 Well we also have a TrevorP|Away  and a TrevorParscal 
[20:09:54] 	 so...
[20:10:38] 	 Oh, I thought he just cloned himself for extra programming power.
[20:11:34] 	 TrevorParscal: Are you connecting directly rather than through the bouncer for a reason?
[20:12:27] 	 on my imac
[20:12:39] 	 other computer is charging, and I'm enjoying the 27" screen
[20:12:45] 	 haven't setup the bouncer on this comp
[20:20:45] 	 I'm back on my laptop
[20:20:48] 	 the confusion can end
[20:30:55] 	 James_F: That rendering of the json with the green/grey boxes ; does not happen locally
[20:31:00] 	 I guess that's extension at work
[20:31:16] 	 didn't that come from EventLogging at some point?
[20:35:36] 	 Krinkle: it got moved out of EventLogging and into core.
[20:35:46] 	 Krinkle: what does ?action=info say the content model is?
[20:36:50] 	 json :)
[20:36:56] 	 legoktm: but not for the /en subpage
[20:37:01] 	 which makes sense I guess
[20:37:19] 	 ok, so that's how I can test it. thx
[20:39:31] 	 should we also change the contentmodel of subpages? I didn't really think of that
[20:39:35] 	 it's just patching the exact page name
[20:41:29] 	 it's fine this way
[20:46:52] 	 edsanders, https://bugzilla.wikimedia.org/show_bug.cgi?id=69119
[20:47:16] 	 I looked at it a bit, I think something weird is going on with the internal list in MWReferenceModel#updateInternalItem
[20:56:47] 	 (03CR) 10Esanders: [C: 032] Get rid of trigger-happy slugChange event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164515 (owner: 10Catrope)
[21:03:43] 	 (03CR) 10Catrope: [C: 04-1] Apply link styling logic to transclusion nodes (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165240 (https://bugzilla.wikimedia.org/65353) (owner: 10Alex Monk)
[21:04:18] 	 (03PS4) 10Catrope: Followup 2fcc4c0: fix bugs with selection-only polling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164514 
[21:07:54] 	 edsanders: You about to merge https://gerrit.wikimedia.org/r/#/c/164514/ ?
[21:14:16] 	 (03PS4) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 
[21:16:31] 	 meh. I should've made TemplateDataGenerator with 2 separate singletons, one for the data and one for ui. Live and learn.
[21:17:34] * James_F nods.
[21:19:29] 	 (03PS6) 10Alex Monk: Apply link styling logic to transclusion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165240 (https://bugzilla.wikimedia.org/65353) 
[21:19:45] 	 3VisualEditor / 3Editing Tools: VisualEditor: Content in translate templates do not render in friendly ways - 10https://bugzilla.wikimedia.org/71730#c2 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3minor Yeah, the Translate extension fundamentally doesn't work with VisualEditor in its...
[21:24:13] 	 uh oh.
[21:24:40] 	 "ReferenceError: OO is not defined" <-- uh, isn't OO loaded in MW core?
[21:24:45] 	 or do I need to add it as a module?
[21:26:31] 	 It exists in MW core as a module called 'oojs'
[21:26:38] 	 hmm
[21:26:39] 	 But you may have to make it a dependency of your module
[21:26:50] 	 oh a dependency..
[21:26:54] 	 And OOUI.
[21:26:56] 	 ha. Yes.. That was silly
[21:26:59] 	 Which in any remotely VE-related context shouldn't be necessary because VE stuff already depends on oojs
[21:27:06] 	 oh, yes, oojs and ooui
[21:27:06] 	 But is in TemplateData.
[21:27:08] 	 Oh yeah if you use OOUI, then just depend on oojs-ui instead
[21:27:11] 	 Oh I see
[21:27:20] 	 Yeah just depend on oojs-ui then. It in turn depends on oojs
[21:27:25] 	 and my hopes are being slowly crushed
[21:27:31] 	 I may have to do a lot more rewriting with this
[21:27:32] 	 And es5-shim for fun.
[21:27:47] 	 I am in denial about this.
[21:28:01] 	 I insist it's just a simple switch until I run into a wall.
[21:28:10] 	 I see nothing wrong with this strategy.
[21:28:57] 	 uhm... if I mix ooui with *some* elements of jquery ui
[21:29:03] 	 will the internet implode?
[21:29:09] 	 haha
[21:29:15] 	 I wouldn't try.
[21:29:19] 	 Probably not at this precise moment
[21:29:29] 	 Eh, I need the drag/drop reorder
[21:29:36] 	 jquery.ui.sortable
[21:29:43] 	 Oh, fun.
[21:30:14] 	 I could do it old-fashioned way like Joomla 1.0 -- have a textbox with the order *number* in each row, and then make the user manually change the numbers
[21:30:20] 	 If it worked for 1995...
[21:30:27] 	 Eww.
[21:30:31] 	 Eww.
[21:30:32] 	 Eww.
[21:30:33] 	 Eww.
[21:30:39] 	 Just in case my views weren't clear. :-)
[21:30:43] 	 Haha
[21:30:52] 	 Damn. Well, back to the drawing board.
[21:31:20] 	 James_F, seriously, though -- switching to ooui would mean some features would have to go away, then. I think probably only the sortable (that's the one thing that jumps to mind)
[21:31:43] 	 is that okay until we add that to ooui, or do you want me to first wait for ooui and *then* transition?
[21:32:20] 	 Using jui sortable is probably fine for now
[21:32:28] 	 3MediaWiki / 3ResourceLoader: Disabling javascript on olderbrowsers should turn on the