[01:03:05] mooeypoo: http://miromannino.com/projects/justified-gallery/ [01:03:15] that one is something I found (and it's open source) [01:03:19] might have some good code in it [01:03:44] seemed like a lot of the code was for the interactions and lightboxing and stuff [01:53:58] TrevorP|Away, oooh aewsome, i'll take a look [03:15:34] (03CR) 10GOIII: [C: 031] WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [03:28:43] 3VisualEditor / 3ContentEditable: VisualEditor: Typing fast in reference dialog box shifts the first character of the text to the next line in Firefox - 10https://bugzilla.wikimedia.org/64399#c10 (10Rummana Yasmeen) 5VERI>3REOP This is again happening on Betalabs [03:28:58] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression pre-wmf3]Typing fast in reference dialog box shifts the first character of the text to the next line in Firefox - 10https://bugzilla.wikimedia.org/64399 (10Rummana Yasmeen) [03:29:15] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression pre-wmf3]Typing fast in reference dialog box shifts the first character of the text to the next line in Firefox - 10https://bugzilla.wikimedia.org/64399 (10Rummana Yasmeen) 5REOP>3ASSI [03:29:43] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression pre-wmf3]Typing fast in CE or reference dialog box shifts the first character of the text to the next line in Firefox - 10https://bugzilla.wikimedia.org/64399 (10Rummana Yasmeen) [04:55:27] (03PS1) 10SuchetaG: Getting rid of ve.splitClusters in ve-mw [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165430 [04:59:29] (03CR) 10Legoktm: "On enwp beta labs I had to null edit one of the messages for it to show up fancily. But ?action=info should display the proper contentmode" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165037 (owner: 10Legoktm) [05:41:22] (03PS1) 10SuchetaG: Getting rid of ve.splitClusters in VE core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165433 [05:55:14] (03PS2) 10SuchetaG: Getting rid of ve.splitClusters in VE core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165433 [06:42:13] 3VisualEditor / 3Editing Tools: VisualEditor: Content in translate tags does not render in friendly ways - 10https://bugzilla.wikimedia.org/71730#c3 (10Nemo) I assume you mean translate tags as shown in the screenshot, because "translate templates" don't exist. [07:01:39] (03CR) 10Catrope: [C: 04-1] Getting rid of ve.splitClusters in VE core (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165433 (owner: 10SuchetaG) [07:03:15] (03CR) 10Catrope: [C: 04-1] Getting rid of ve.splitClusters in ve-mw (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165430 (owner: 10SuchetaG) [07:05:44] (03CR) 10Catrope: "jscs should have warned about the whitespace thing, but you're not in the trusted user group for some reason. I'll fix that." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165430 (owner: 10SuchetaG) [07:07:49] Krinkle|detached: Why did https://gerrit.wikimedia.org/r/#/c/165430/ not run the full tests? It was committed with a @wikimedia.org address [07:07:58] (03CR) 10Catrope: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165430 (owner: 10SuchetaG) [07:08:14] (03CR) 10Catrope: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165433 (owner: 10SuchetaG) [07:09:39] (03CR) 10jenkins-bot: [V: 04-1] Getting rid of ve.splitClusters in VE core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165433 (owner: 10SuchetaG) [07:20:03] Krinkle|detached: Also when I rechecked https://gerrit.wikimedia.org/r/#/c/165430/ jscs didn't warn about how foo.split(''); should be foo.split( '' ); , shouldn't it warn about that? [07:24:43] Alright, let the rebase fun begin [07:42:19] (03PS19) 10Catrope: Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [07:55:08] (03PS5) 10Catrope: Get rid of trigger-happy slugChange event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164515 [07:57:11] (03PS4) 10Catrope: Make slug animations work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164516 [08:00:24] (03PS2) 10SuchetaG: Getting rid of ve.splitClusters in ve-mw [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165430 [08:01:14] sucheta: It needs to be Bug: 57628 (with a colon, not a space) and there can't be a blank line between it and the Change-Id line [08:01:18] The bot is picky :| [08:01:51] Oh wait the latter you did do. The diff was just playing tricks on my eyes [08:02:22] So it should be Bug:57628? [08:02:53] Or Bug: 57628 [08:03:21] The latter [08:03:28] So a colon AND a space, you're right [08:05:20] You'll know when you've done it right because the bot notifications will include a link to the bug [08:05:26] Like for "Stage slugs" above [08:08:08] (03PS3) 10SuchetaG: Getting rid of ve.splitClusters in VE core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165433 (https://bugzilla.wikimedia.org/57628) [08:09:20] (03PS3) 10SuchetaG: Getting rid of ve.splitClusters in ve-mw [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165430 (https://bugzilla.wikimedia.org/57628) [08:09:57] I still can't see most of the things in Gerrit [08:10:22] So. Annoying. [08:11:38] OK there you go, that worked [08:12:06] Oh, aha and now I see why you aren't trusted, I'll fix that [08:12:18] (03CR) 10Catrope: [C: 032] Getting rid of ve.splitClusters in ve-mw [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165430 (https://bugzilla.wikimedia.org/57628) (owner: 10SuchetaG) [08:12:41] (03CR) 10Catrope: [C: 032] Getting rid of ve.splitClusters in VE core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165433 (https://bugzilla.wikimedia.org/57628) (owner: 10SuchetaG) [08:13:01] Wait. What. I can see everything on Chromium! [08:13:47] (03Merged) 10jenkins-bot: Getting rid of ve.splitClusters in ve-mw [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165430 (https://bugzilla.wikimedia.org/57628) (owner: 10SuchetaG) [08:14:16] Thanks :) [08:14:29] (03Merged) 10jenkins-bot: Getting rid of ve.splitClusters in VE core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165433 (https://bugzilla.wikimedia.org/57628) (owner: 10SuchetaG) [08:15:31] https://gerrit.wikimedia.org/r/#/c/165443/ [08:17:16] Hee. There's a patchset about me. [08:18:29] * RoanKattouw spots a wild hashar [08:18:43] * RoanKattouw ambushes hashar with https://gerrit.wikimedia.org/r/#/c/165443/ [08:20:01] busy at coworking place, speaking with a french wikipedia [08:20:08] hashar: No worries, take your time [08:20:29] sucheta: That reminds me, I need to write some more patchsets about you [08:20:31] (and get you to +2 them) [08:22:02] (03PS1) 10Catrope: Add Sucheta to authors list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165444 [08:23:02] If only the universe was this simple, and everything could be solved with ambushing patchsets at one another. [08:23:43] haha [08:24:07] Well I have a long list of bugs if you want more work [08:24:26] But right now, your mission, should you choose to accept it, is to merge https://gerrit.wikimedia.org/r/165444 [08:24:34] Because I want to make sure you can actually +2 things in both repos [08:25:24] (03PS1) 10Catrope: Move Bartosz to principal authors section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165445 [08:25:42] I can't..+2 it but [08:26:34] (03CR) 10jenkins-bot: [V: 04-1] Move Bartosz to principal authors section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165445 (owner: 10Catrope) [08:26:34] meh [08:26:35] RoanKattouw: deploying it [08:26:39] hashar: Thanks [08:27:07] (03PS2) 10Catrope: Move Bartosz to principal authors section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165445 [08:28:06] (03PS1) 10Catrope: Add Sucheta to AUTHORS.txt [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165446 [08:28:11] sucheta: RoanKattouw: Zuul config change has been deployed. `sucheta should now have jobs triggered [08:28:19] Awesome, thanks man [08:28:19] and have access to 'recheck' :D [08:28:27] how you did all the work [08:28:30] I am just pressing buttons [08:28:37] hashar, thank you :D [08:28:49] sucheta: You should be able to +2 https://gerrit.wikimedia.org/r/#/c/165446/ though [08:28:49] during the weekly RelEng checkin yesterday, we talked about having zuul conf to self deploy when folks +2 a change [08:28:58] this way no shell access would be needed anymore [08:28:59] Because it's in VE-core and James beat me to giving you access apparently [08:29:49] (03PS1) 10Catrope: Move Bartosz to principal authors section [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165447 [08:30:18] As for VE-MW, I'll have to dig into LDAP for that [09:06:45] sucheta: I messed with LDAP and I think I've added you to the wmf group correctly, so hopefully you can now +2 in VE-MW as well [09:21:43] 3MediaWiki extensions / 3Cite: Cite: Support multi-column and alternative list-style for tag (like enwiki {{reflist}}) - 10https://bugzilla.wikimedia.org/51260#c39 (10Thiemo Mättig) Just to make this clear (since I was told to say this here rather than in Gerrit): 100% agree to what Krinkle an... [10:27:26] (03PS51) 10Catrope: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [10:27:54] (03PS2) 10Catrope: Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 [10:29:21] (03CR) 10jenkins-bot: [V: 04-1] Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 (owner: 10Catrope) [10:29:35] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [10:30:28] (03PS10) 10Catrope: [WIP] Use a single unicorn instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [10:32:40] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use a single unicorn instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [11:09:16] 3MediaWiki extensions / 3TemplateData: Autovalue doesn't substitute - 10https://bugzilla.wikimedia.org/71789 (10Tar Lócesilion) 3UNCO p:3Unprio s:3normal a:3None 'When users add the template to a page, this value will be added automatically.' ([[mw:Help:TemplateData#Auto value]]). Cool. But when use... [12:33:09] RoanKattouw, I still cannot +2 https://gerrit.wikimedia.org/r/#/c/165444/ though [12:34:57] (03CR) 10SuchetaG: [C: 032] Add Sucheta to AUTHORS.txt [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165446 (owner: 10Catrope) [12:35:59] Boo [12:36:08] sucheta: Ahm, could you try logging out of Gerrit and back in, maybe? [12:36:17] I also may have added you to the group wrong. LDAP is a mystery to me [12:37:03] (03Merged) 10jenkins-bot: Add Sucheta to AUTHORS.txt [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165446 (owner: 10Catrope) [12:42:53] RoanKattouw, Logged out, and logged back in to Gerrit -- can't +2 still [12:43:09] sucheta: OK that's weird. Well I need to add you to the VE group anyway, that should do it [12:43:18] But you won't be able to +2 in MW core until this gets fixed :S [12:43:38] OK you should be able to +2 in VE-MW now [12:44:47] I just +2'd in VE core? [12:49:53] MW core not VE core [12:50:11] I added you to the +2 list for VE core earlier, and just now I manually added you to VE-MW and OOjs /OOUI [12:50:39] But for MediaWiki core and other random extensions, you need to be in the 'wmf' group in LDAP, which I tried adding you to but that doesn't seem to have worked [12:50:49] So now I'm talking to ops about it and they're grumbling that I shouldn't have been touching LDAP :| [12:51:23] Not just the plain 'mediawiki' group? [12:51:42] I guess I could add her to that group, yeah [12:51:54] But it incorporates ldap/wmf and she's supposed to be in there [12:52:16] I even followed the steps in the documentation on wikitech to add her, but it doesn't seem to have worked [12:52:21] Ops told me to file an RT ticket so I did [12:57:40] sucheta: In any case, you should now be able to +2 https://gerrit.wikimedia.org/r/#/c/165444/ [12:59:18] sucheta: And I have another bug for you, whenever you're ready [13:05:28] RoanKattouw, Please to shoot the bug. And +2ing. [13:05:57] I'm apparently very uncreative or predictable, because it's the next on the list :) https://bugzilla.wikimedia.org/show_bug.cgi?id=56647 [13:06:41] For this bug you won't need to touch any OOUI code, but you may find it useful to have a clone of OOUI lying around so you can look at documentation and code [13:10:36] Also, RoanKattouw , i still cannot +2 [13:10:57] * sucheta clicks on the bug [13:11:05] Boo [13:46:31] 3VisualEditor / 3Editing Tools: VisualEditor: Annotations pull-down closes before scrolling it. - 10https://bugzilla.wikimedia.org/71794 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Environment- test2, beta In the Reference dialog and Media Settings Caption dialog, before even I could scroll dow... [13:46:43] 3VisualEditor / 3Editing Tools: VisualEditor: Annotations pull-down closes before scrolling it. - 10https://bugzilla.wikimedia.org/71794 (10Ritu Swain) [13:55:00] 3VisualEditor / 3Editing Tools: VisualEditor: The external links should be validated. - 10https://bugzilla.wikimedia.org/71795 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Open the link inspector and just type in double slash(forward), click done.It gets inserted in the CE as an external link. Th... [13:55:13] 3VisualEditor / 3Editing Tools: VisualEditor: The external links should be validated. - 10https://bugzilla.wikimedia.org/71795 (10Ritu Swain) [13:57:49] sucheta: Ugh right these groups don't work the way I thought they did [13:58:19] sucheta: *Now* you should be able to +2 things [13:58:45] dun dun dun [14:00:07] (03CR) 10Catrope: [C: 04-1] "Minor style thing, good to merge otherwise" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165240 (https://bugzilla.wikimedia.org/65353) (owner: 10Alex Monk) [14:04:24] (03PS7) 10Alex Monk: Apply link styling logic to transclusion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165240 (https://bugzilla.wikimedia.org/65353) [14:11:55] is there a way to hide elements if VE is disabled, other than by javascript? (like a css class or something?) [14:12:10] (disabled in a user's preferences i mean) [14:12:15] jackmcbarn: The class will have .ve-not-available I believe [14:12:31] Yeah [14:12:59] Sorry [14:13:08] The *node* will have the ve-not-available *class* [14:28:36] (03CR) 10Catrope: [C: 032] Apply link styling logic to transclusion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165240 (https://bugzilla.wikimedia.org/65353) (owner: 10Alex Monk) [14:30:03] (03Merged) 10jenkins-bot: Apply link styling logic to transclusion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165240 (https://bugzilla.wikimedia.org/65353) (owner: 10Alex Monk) [14:30:55] RoanKattouw, okay, so I'm wondering what we can do to make this apply to other GCNs [14:31:23] Yeah, that's a good question [14:40:31] As I said earlier, creating something like MWGeneratedContentNode would work at this point in time because all of our GCN subclasses are in VE-MW [14:42:19] But if we ever create GCN subclasses in VE core that will fall flat [14:42:52] I'm not sure how else to do it though. Maybe we need some sort of hook mechanism [14:43:06] We should pick edsanders and TrevorP|Away 's brains about that [14:43:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: Blue link / red link logic should descend into links inside generated content nodes (e.g. templates) - 10https://bugzilla.wikimedia.org/65353 (10James Forrester) 5PATC>3RESO/FIX [14:45:12] (03CR) 10Jforrester: [C: 032] Move Bartosz to principal authors section [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165447 (owner: 10Catrope) [14:45:20] (03CR) 10Jforrester: [C: 032] Move Bartosz to principal authors section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165445 (owner: 10Catrope) [14:45:26] Um. James_F just closed the bug anyway... [14:45:40] (03CR) 10Jforrester: [C: 032] Add Sucheta to authors list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165444 (owner: 10Catrope) [14:46:32] (03PS52) 10Catrope: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [14:46:38] (03Merged) 10jenkins-bot: Move Bartosz to principal authors section [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165447 (owner: 10Catrope) [14:46:49] (03Merged) 10jenkins-bot: Move Bartosz to principal authors section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165445 (owner: 10Catrope) [14:47:00] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of ve.splitClusters - 10https://bugzilla.wikimedia.org/57628 (10James Forrester) 5PATC>3RESO/FIX [14:47:44] 3VisualEditor / 3Technical Debt: VisualEditor: Make byte counter in save dialog use widget accessors rather than $textarea - 10https://bugzilla.wikimedia.org/56647 (10Roan Kattouw) a:3Sucheta Ghoshal [14:47:51] James_F, https://bugzilla.wikimedia.org/65353 is for all GCNs [14:47:59] the patch Roan just merged only did transclusion nodes [14:48:11] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [14:49:57] (03Merged) 10jenkins-bot: Add Sucheta to authors list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165444 (owner: 10Catrope) [14:51:01] (03PS3) 10Catrope: Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 [14:51:08] (03PS11) 10Catrope: [WIP] Use a single unicorn instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [14:51:55] (03PS12) 10Catrope: Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [14:52:41] (03CR) 10jenkins-bot: [V: 04-1] Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 (owner: 10Catrope) [14:54:01] (03CR) 10jenkins-bot: [V: 04-1] Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [14:56:06] (03PS2) 10Catrope: POC: Match native content start annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165233 (owner: 10Divec) [14:57:38] (03CR) 10jenkins-bot: [V: 04-1] POC: Match native content start annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165233 (owner: 10Divec) [15:16:47] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (https://bugzilla.wikimedia.org/51260) (owner: 10Alex Monk) [15:33:07] (03PS31) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [15:53:16] 3VisualEditor / 3MediaWiki integration: VisualEditor:"404 file Not Found Error" when logging into betalabs - 10https://bugzilla.wikimedia.org/71806 (10Ritu Swain) 3UNCO p:3Unprio s:3major a:3None While trying to login to betalabs i get "404 file Not Found Error" after clicking the Log In button. [15:53:28] 3VisualEditor / 3MediaWiki integration: VisualEditor:"404 file Not Found Error" when logging into betalabs - 10https://bugzilla.wikimedia.org/71806 (10Ritu Swain) [16:04:24] * James_F waves. [16:04:52] RoanKattouw: What kind of GCN would we create in VE-core? It feels out of scope for VE; each implementation is responsible for its own funkiness, surely? [16:28:55] GCN? GameCube Nintendo? [16:29:05] out of scope, but awesome... [16:29:23] :) [16:29:41] haha [16:30:34] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108052093 [16:30:34] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66014741 [16:30:34] Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=40645857 [16:30:34] Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=40645895 [16:30:34] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=68542736 [16:31:06] TrevorParscal, I'm looking at the code you sent me and at a few papers about organizing the images in rows, but I am getting stuck on one tiny detail -- maybe you have an idea? It seems most of the methods already assume in advance how many images there are in a row, which only makes sense if you have images that are *relatively* similar in aspect-ratio (like in Flickr) but makes no sense for our images too much [16:31:09] but I think i'm missing something [16:31:27] it can be that they already choose in advance the number of images per row, the entire point is to do that dynamically. [16:31:58] 3VisualEditor / 3Editing Tools: VisualEditor: The external links should be validated. - 10https://bugzilla.wikimedia.org/71795#c1 (10Andre Klapper) s:5normal>3enhanc [Problem is unrelated to specific browsers hence removing 'Web browser' field entry. "should be" -> new feature, hence setting 'Severity' t... [16:32:18] TrevorParscal, example, this one seems to calculate row by the buffer length (so, the number of images in each row!) https://github.com/miromannino/Justified-Gallery/blob/master/src/js/justifiedGallery.js#L215 [16:32:41] And this one is laying out the method Flickr is layed out -- but again, the number of images per row is a constant http://l.yimg.com/j/assets/ipt/breaking-row-boundaries.pdf [16:32:48] I must be missing something. [16:33:23] I found this: http://sevengoslings.net/~fangel/packgrid/ [16:33:36] TrevorParscal, I have an idea of how to do it recursively brute-force, but I have a feeling that's not going to be very optimized; do you think I should try that out and then we can see how to optimize it, or should I spend more time trying to figure out what they mean in those existing ones? [16:33:46] and I started trying to cleanup the code and get it to work in a more generic way but didn't really finish [16:33:54] also, I don't know the license of the code [16:34:00] oooo [16:34:09] but the author was linking to it on Reddit [16:34:19] and offering it up to help someone [16:34:30] so, probably something we could hunt down [16:34:49] it also has a research paper [16:34:53] and some math behind it [16:35:01] might be a better approach for our purposes [16:35:03] TrevorParscal, all we really need is the idea of the algorithm itself; if we have that, we can implement it ourselves. There's also this, from HP which seems to be highly recommended -- file:///home/morielschottlender/Documents/Algorithms/06266273.pdf [16:35:10] * mooeypoo nods [16:35:14] aye, just loaded the research paper [16:36:42] file:///, mooeypoo [16:36:46] oops [16:36:47] haha [16:36:51] * mooeypoo downloaded [16:36:55] let me fetch that from the net [16:37:25] http://dl.acm.org/citation.cfm?id=1459359.1459496 [16:37:27] BRIC [16:37:40] That's HP's paper. I have access to ACM if anyone wants the paper [16:53:01] TrevorParscal: I take it you're not making it into the office for the stand-up? :-) [16:55:21] James_F: correct, but when I do come in (shortly after) the party may start [16:55:37] btw, did some code review for Wikidata this morning [16:55:42] they are using OOjs UI [16:55:45] woot! [16:55:51] TrevorParscal: Nice! [16:58:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: Blue link / red link logic should descend into links inside generated content nodes (e.g. templates) - 10https://bugzilla.wikimedia.org/65353#c5 (10Alex Monk) 5RESO/FIX>3REOP Transclusion nodes are not the only generated content nodes [17:21:18] Yeah, of course [17:21:25] (0,0) selection strikes back [17:21:29] And I bet it's the Great Selection Rewrite [17:23:00] Yup [17:24:28] 3MediaWiki extensions / 3TemplateData: TemplateData: Add an "autofill" attribute for parameters which clients would automatically insert if none specified - 10https://bugzilla.wikimedia.org/51428 (10Bartosz Dziewoński) [17:27:28] (03PS6) 10Alex Monk: If there isn't one already, append reference list to page when creating a reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149117 (https://bugzilla.wikimedia.org/54906) [17:28:58] (03CR) 10jenkins-bot: [V: 04-1] If there isn't one already, append reference list to page when creating a reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149117 (https://bugzilla.wikimedia.org/54906) (owner: 10Alex Monk) [17:30:28] 3VisualEditor / 3ContentEditable: VisualEditor: Trying to insert anything in the slug inside a media dialog box throws Uncaught Error: Offset could not be translated to a DOM element and offset: 63 - 10https://bugzilla.wikimedia.org/63025#c4 (10Ritu Swain) This issue has resurfaced with error as "Uncaught Er... [17:54:46] (03PS7) 10Alex Monk: If there isn't one already, append reference list to page when creating a reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149117 (https://bugzilla.wikimedia.org/54906) [18:00:59] 3VisualEditor / 3MediaWiki integration: VisualEditor: Blue link / red link logic should descend into links inside generated content nodes (e.g. templates) - 10https://bugzilla.wikimedia.org/65353#c6 (10James Forrester) (In reply to Alex Monk from comment #5) > Transclusion nodes are not the only generated co... [18:02:59] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression pre-wmf3]Typing fast in CE or reference dialog box shifts the first character of the text to the next line in Firefox - 10https://bugzilla.wikimedia.org/64399 (10Rummana Yasmeen) a:5Ed Sanders>3Roan Kattouw [18:04:04] RoanKattouw: Did you manage to reproduce the cursor issue on Betalabs later? [18:04:23] Because I am getting it in every attempt to save a page [18:04:52] I have not yet [18:06:13] 3VisualEditor / 3MediaWiki integration: VisualEditor: Blue link / red link logic should descend into links inside generated content nodes (e.g. templates) - 10https://bugzilla.wikimedia.org/65353#c7 (10Alex Monk) Well, it was you who changed this bug from being about just templates to being about "generated... [18:06:16] Are you trying on Firefox? [18:06:48] edsanders: sorry the meeting got pushed back [18:06:53] it was my fault for coming in later [18:07:11] RoanKattouw: it happens if you type something on CE and then switch back to readmode discarding your edit as well [18:09:35] But I'm still trying to look at the double typing bug [18:09:57] ryasmeen: Hmm I tried that too in Firefox, and I didn't see it [18:10:09] But I can totally reproduce the double typing thing and that's also really bad [18:10:21] And definitely caused by Ed's Great Selection Rewrite of 2014 [18:12:23] Bad Ed. :-) [18:14:02] (03PS1) 10Jforrester: Update VE core submodule to master (8280da5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165526 [18:14:17] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (8280da5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165526 (owner: 10Jforrester) [18:15:48] (03Merged) 10jenkins-bot: Update VE core submodule to master (8280da5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165526 (owner: 10Jforrester) [18:20:51] edsanders: you good to meet in 10 min instead of 40? [18:23:58] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/163674/ ping. [18:25:46] (03CR) 10Jforrester: [C: 032] Get rid of trigger-happy slugChange event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164515 (owner: 10Catrope) [18:26:14] (03CR) 10Jforrester: [C: 031] "Ed's call." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164516 (owner: 10Catrope) [18:27:38] (03CR) 10Trevor Parscal: [C: 032] ve.ui.CommentInspector: Update size when the textarea gets resized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) (owner: 10Bartosz Dziewoński) [18:28:02] James_F: yup [18:28:17] edsanders: James_F: Kaity is ready 30min early for the meeting, so... in 2 min if you guys are game [18:28:23] MatmaRex: HEY! [18:28:26] You feeling better? [18:28:32] Sorry to hear you were ill [18:28:40] TrevorParscal: Meeting with RoanKattouw and ryasmeen won't end that early. [18:28:59] TrevorParscal: Scrum of Scrums over-ran. [18:29:14] (03CR) 10jenkins-bot: [V: 04-1] ve.ui.CommentInspector: Update size when the textarea gets resized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) (owner: 10Bartosz Dziewoński) [18:29:51] hi TrevorParscal [18:30:15] 3VisualEditor / 3Editing Tools: VisualEditor: The external links should be validated. - 10https://bugzilla.wikimedia.org/71795#c2 (10Ritu Swain) (In reply to Andre Klapper from comment #1) > [Problem is unrelated to specific browsers hence removing 'Web browser' > field entry. "should be" -> new feature, hen... [18:30:50] James_F: it's scheduled to... :( [18:34:14] 3VisualEditor / 3MediaWiki integration: VisualEditor:"404 file Not Found Error" when logging into betalabs - 10https://bugzilla.wikimedia.org/71806#c1 (10Andre Klapper) How is that problem related to VisualEditor (which you set as a product here)? I don't see VisualEditor mentioned in your steps to reproduc... [18:37:28] 3VisualEditor / 3Data Model: VisualEditor: [Regression?] Save button stays disabled after inserting a character in some cases. - 10https://bugzilla.wikimedia.org/71732 (10James Forrester) s:5critic>3major [18:39:31] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Double-typing issues inside media/reference dialogs again in Firefox - 10https://bugzilla.wikimedia.org/71823 (10James Forrester) 3ASSI p:3Unprio s:3major a:3Roan Kattouw But not only when typing fast. [18:39:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Double-typing issues inside media/reference dialogs again in Firefox - 10https://bugzilla.wikimedia.org/71823 (10James Forrester) p:5Unprio>3High [18:41:24] TrevorParscal: Where did you go? [18:41:30] r34 [18:41:34] where shall I go? [18:41:41] kaity: ? [18:41:49] TrevorParscal: OK. I don't know. Did you, Ed and kaity agree to meet early? [18:42:06] not yet [18:42:13] (03CR) 10Jforrester: [C: 032] "Go go Jenkins." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) (owner: 10Bartosz Dziewoński) [18:42:14] Kaity and I were trying to see if that was possible [18:42:15] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Double-typing issues inside CE/media/reference dialogs again in Firefox - 10https://bugzilla.wikimedia.org/71823 (10Rummana Yasmeen) [18:42:20] Ping edsanders. [18:42:27] yea can everyone attend? [18:42:36] edsanders: are you around? we were trying to meet a little early as to not drag your evening out [18:43:05] Coming. [18:43:38] (03CR) 10jenkins-bot: [V: 04-1] ve.ui.CommentInspector: Update size when the textarea gets resized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) (owner: 10Bartosz Dziewoński) [18:43:58] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Double-typing issues inside CE/media/reference dialogs again in Firefox - 10https://bugzilla.wikimedia.org/71823#c1 (10Rummana Yasmeen) Also, after saving a page or discarding an edit, the cursor appears on the Read Mode which could be a rel... [18:45:00] edsanders: ping ping ping :) [18:45:05] hey [18:45:08] ok [18:45:14] i need a good punchline to a joke that starts with "How many software engineers do you need to merge a change?". :> [18:46:15] MatmaRex, I am not sure, but I know the answer for Windows Engineers and lightbulbs. [18:55:28] * RoanKattouw slow claps [18:55:33] I found where Ed broke everything [18:55:43] if ( !this.getModel().getSelection() ) [18:56:20] MatmaRex: Well if you're interested in epic changes, look at https://gerrit.wikimedia.org/r/125937 :) [19:00:09] :o [19:01:08] RoanKattouw: Whoops. [19:08:21] (03PS1) 10Catrope: Followup b8d8a5b: fix stray check for !selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165537 (https://bugzilla.wikimedia.org/71823) [19:08:31] James_F: Trivial change ---^^ [19:11:30] 3VisualEditor: JS error on loading mobile VE: Discontiguous selection is not supported. - 10https://bugzilla.wikimedia.org/69616#c4 (10Jon) a:3None Not sure if this is still a relevant bug. Guessing VE folks will know. [19:16:02] (03CR) 10Jforrester: [C: 032] Followup b8d8a5b: fix stray check for !selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165537 (https://bugzilla.wikimedia.org/71823) (owner: 10Catrope) [19:16:29] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Double-typing issues inside CE/media/reference dialogs again in Firefox - 10https://bugzilla.wikimedia.org/71823 (10James Forrester) 5PATC>3RESO/FIX [19:16:32] RoanKattouw: Is that also the cursor-still-visible-after-exit-VE bug? [19:16:41] James_F: I haven't been able to reproduce that one [19:16:53] I did during our meeting, if you didn't notice. [19:17:00] I didn't actually [19:17:08] Is that Firefox only, or also in Chrome [19:17:10] Cursor blinking in read mode after demoing the first-character issues. [19:17:14] This was Chrome. [19:17:22] Didn't test in Firefox yet. [19:17:44] 3VisualEditor / 3MediaWiki integration: VisualEditor:"404 file Not Found Error" when logging into betalabs - 10https://bugzilla.wikimedia.org/71806#c2 (10Ritu Swain) > Also, URLs to reproduce the problem are welcome. http://login.wikimedia.beta.wmflabs.org/wiki/Special:CentralLogin/start?token=bbdd420df13bbf... [19:17:51] (03Merged) 10jenkins-bot: Followup b8d8a5b: fix stray check for !selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165537 (https://bugzilla.wikimedia.org/71823) (owner: 10Catrope) [19:19:29] (03PS1) 10Jforrester: Update VE core submodule to master (4b3da84) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165538 [19:19:39] RoanKattouw: ^^^ [19:19:45] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] All Citation notes are appearing as Basic Reference - 10https://bugzilla.wikimedia.org/71825 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Insert Cite>Website/News/Journal etc Obs... [19:19:58] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] All Citation notes are appearing as Basic Reference - 10https://bugzilla.wikimedia.org/71825 (10Rummana Yasmeen) p:5Unprio>3High s:5normal>3major [19:20:21] Oh dear. [19:20:27] (03PS1) 10Catrope: Followup b8d8a5b: fix getNativeRange() in null selection case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165539 [19:20:49] What the ... [19:20:52] Maybe that's Alex's change? [19:20:59] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (4b3da84) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165538 (owner: 10Jforrester) [19:21:51] (03CR) 10Jforrester: Followup b8d8a5b: fix getNativeRange() in null selection case (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165539 (owner: 10Catrope) [19:22:28] (03Merged) 10jenkins-bot: Update VE core submodule to master (4b3da84) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165538 (owner: 10Jforrester) [19:23:15] 3VisualEditor / 3Editing Tools: VE citation form bugginess on iOS - 10https://bugzilla.wikimedia.org/66562 (10Jon) a:3None [19:23:16] 3VisualEditor / 3Editing Tools: VisualEditor: Extra characters being inserted when typing in bulleted lists - 10https://bugzilla.wikimedia.org/71827 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Created attachment 16718 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16718&action=... [19:23:54] RoanKattouw, which change? [19:24:03] The one that touches template nodes [19:24:11] I don't know if it causes that bug, it's just speculation [19:26:02] (03CR) 10Catrope: [C: 04-1] Followup b8d8a5b: fix getNativeRange() in null selection case (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165539 (owner: 10Catrope) [19:26:09] (03CR) 10Catrope: Followup b8d8a5b: fix getNativeRange() in null selection case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165539 (owner: 10Catrope) [19:26:50] hmmm.. I doubt it [19:30:04] RoanKattouw, appears to be selection rewrite? [19:30:11] Nooo I think I know [19:30:20] Kunal's ContentHandler change [19:30:26] Checking on beta labs now [19:30:30] I broke something? o.O [19:30:36] hah well also I can't reproduce [19:30:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] All Citation notes are appearing as Basic Reference - 10https://bugzilla.wikimedia.org/71825#c1 (10Rummana Yasmeen) Created attachment 16719 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16719&action=edit Screenshot [19:31:04] Wait, WTF [19:31:14] It's different from what the summary makes it sound like [19:31:15] I only tested that patch in that, a) it displayed prettily, and b) the output of wfMessage( $key )->plain() was the same with or without the patch [19:31:20] All citation insertions insert an empty reference [19:31:29] legoktm: Yeah no yours isn't to blame, sorry [19:31:41] ok :P [19:31:42] The blame wheel is spinning rapidly here [19:32:28] I blame TrevorParscal. [19:32:33] 'Cos he merged no code. [19:32:39] So clearly he's at fault. [19:32:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Citation dialog inserts empty reference - 10https://bugzilla.wikimedia.org/71825#c2 (10Roan Kattouw) This is happening because the references inserted by the citation dialog are empty, they don't have a template in them like they should. [19:32:59] It may well be the selection rewrite, let's see [19:35:02] Yeah it's the selection rewrite alright [19:37:21] Boo. [19:45:46] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf3] For every Math expression, it is not appearing on CE when its gets evaluated for the first time - 10https://bugzilla.wikimedia.org/71829 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16720 --> https://bugzi... [19:47:12] OK found it [19:49:15] Also affects media dialog and comment inspector [19:49:23] RoanKattouw: How severe is that Selection Re-write ? :( [19:49:41] ryasmeen: There's just some loose ends that Ed forgot about :| [19:49:50] Ah okay [19:49:59] He basically needed to touch every single piece of code that interacts with selections in any way [19:50:03] and he missed a couple [19:50:21] OK I have a fix for the citation thing [19:50:44] hmm, there is a new one related with math inspector not rendering the function for the first time [19:50:58] 3VisualEditor / 3MediaWiki integration: VisualEditor:"404 file Not Found Error" when logging into betalabs - 10https://bugzilla.wikimedia.org/71806#c3 (10Ritu Swain) (In reply to Ritu Swain from comment #2) > > Also, URLs to reproduce the problem are welcome. I followed this link http://en.wikipedia.beta.wm... [19:51:37] which also regressed today after that got merged i guess [19:51:52] In addition to what you found, I'm fixing the remove button in the comment inspector, and changing the image in the media dialog [19:52:04] I don't know exactly how they're broken right now but I can tell you that they're broken [19:52:19] The media dialog will probably just insert another image if you try to change the image [19:52:29] oh! [19:54:30] * mooeypoo 's ears are burning [19:54:37] what? someone said images, and media dialog [19:54:51] in close proximity to the word "broken". [19:54:59] lol [19:55:26] Well RoanKattouw: at my end it gets stuck inside Media Dialog when you attempt to change an image [19:56:00] I have no problems with the dialog [19:56:11] oh, wait, I'm working off of my patchset, so it's probably not updated [19:56:19] (03PS1) 10Catrope: Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165592 (https://bugzilla.wikimedia.org/71825) [19:57:09] (03PS1) 10Catrope: Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165593 (https://bugzilla.wikimedia.org/71825) [19:57:18] edsanders: ----^^ [19:57:57] (03CR) 10jenkins-bot: [V: 04-1] Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165592 (https://bugzilla.wikimedia.org/71825) (owner: 10Catrope) [19:59:38] RoanKattouw, looks fine but tests are failing [19:59:52] ugh [20:00:22] (03PS2) 10Catrope: Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165592 (https://bugzilla.wikimedia.org/71825) [20:00:31] Oh that's just mw.cookie, that's an intermittent failure [20:02:10] edsanders: OK tests pass now [20:02:47] (03CR) 10Esanders: [C: 032] Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165592 (https://bugzilla.wikimedia.org/71825) (owner: 10Catrope) [20:03:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3]Getting stuck inside Media Settings dialog while attempting to change an image - 10https://bugzilla.wikimedia.org/71832 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16721 --> https://bugzilla.wikimedia.org... [20:04:14] (03Merged) 10jenkins-bot: Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165592 (https://bugzilla.wikimedia.org/71825) (owner: 10Catrope) [20:04:42] (03CR) 10Esanders: [C: 032] Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165593 (https://bugzilla.wikimedia.org/71825) (owner: 10Catrope) [20:04:47] Thanks [20:06:12] (03Merged) 10jenkins-bot: Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165593 (https://bugzilla.wikimedia.org/71825) (owner: 10Catrope) [20:09:57] (03PS1) 10Jforrester: Update VE core submodule to master (07b791e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165595 [20:10:28] 3VisualEditor / 3ContentEditable: VisualEditor: Trying to insert anything in the slug inside a media dialog box throws Uncaught Error: Offset could not be translated to a DOM element and offset: 63 - 10https://bugzilla.wikimedia.org/63025 (10Rummana Yasmeen) 5RESO/FIX>3REOP [20:10:43] 3VisualEditor / 3ContentEditable: VisualEditor: Trying to insert anything in the slug inside a media dialog box throws Uncaught Error: Offset could not be translated to a DOM element and offset: 63 - 10https://bugzilla.wikimedia.org/63025 (10Rummana Yasmeen) 5REOP>3ASSI [20:15:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Citation dialog inserts empty reference - 10https://bugzilla.wikimedia.org/71825#c7 (10James Forrester) 5PATC>3RESO/FIX a:3Roan Kattouw (Core pull-through not yet merged but otherwise fixed.) [20:15:46] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (07b791e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165595 (owner: 10Jforrester) [20:15:49] Ta. [20:16:10] (03PS1) 10SuchetaG: Replacing $input in save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165597 (https://bugzilla.wikimedia.org/56647) [20:17:29] 3VisualEditor / 3ContentEditable: VisualEditor: Trying to insert anything in the slug inside a media dialog box throws Uncaught Error: Offset could not be translated to a DOM element and offset: 63 - 10https://bugzilla.wikimedia.org/63025#c5 (10James Forrester) 5ASSI>3RESO/FIX That was bug 71825, now fix... [20:17:46] (03CR) 10Catrope: [C: 04-1] Replacing $input in save dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165597 (https://bugzilla.wikimedia.org/56647) (owner: 10SuchetaG) [20:20:22] RoanKattouw: Did https://bugzilla.wikimedia.org/show_bug.cgi?id=71829 get fixed too? [20:20:30] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf3] For every Math expression, it is not appearing on CE when its gets evaluated for the first time - 10https://bugzilla.wikimedia.org/71829 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Roan Kattouw [20:20:50] (03Merged) 10jenkins-bot: Update VE core submodule to master (07b791e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165595 (owner: 10Jforrester) [20:20:56] James_F: Haven't tested. Did read the MathInspector code, didn't see anything obvious, then had a meeting (that I'm now in) [20:21:22] RoanKattouw: Probably code in LiveInpsector as Ed would typo it. :-) [20:21:49] I read that too [20:21:59] (03PS2) 10SuchetaG: Replacing $input in save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165597 (https://bugzilla.wikimedia.org/56647) [20:22:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Getting stuck inside Media Settings dialog while attempting to change an image - 10https://bugzilla.wikimedia.org/71832#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3High a:3Roan Kattouw Fall-out from selection rewrite; fixed by... [20:23:10] [20:23:10] What's up with jenkins? [20:23:52] How did I do that? :O [20:24:18] Holy crap you caused a horizontal scrollbar in my client [20:24:39] (03CR) 10Catrope: [C: 032] Replacing $input in save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165597 (https://bugzilla.wikimedia.org/56647) (owner: 10SuchetaG) [20:25:38] It looks like the question of the moment. [20:25:44] Although it was not [20:26:24] (03Merged) 10jenkins-bot: Replacing $input in save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165597 (https://bugzilla.wikimedia.org/56647) (owner: 10SuchetaG) [20:29:01] 3VisualEditor / 3Editing Tools: VisualEditor: Bring back the edit summary byte counter in the save dialog - 10https://bugzilla.wikimedia.org/71837 (10Roan Kattouw) 3ASSI p:3Unprio s:3normal a:3Sucheta Ghoshal It's ve-ui-mwSaveDialog-editSummary-count in MWSaveDialog, but there are several issues with... [20:29:23] sucheta: That one ---^^ is in basically the same code [20:29:49] Maybe for tomorrow? :) It's pretty late for you already [20:35:13] 3VisualEditor / 3Technical Debt: VisualEditor: Make byte counter in save dialog use widget accessors rather than $textarea - 10https://bugzilla.wikimedia.org/56647#c3 (10James Forrester) 5PATC>3RESO/FIX Masked by bug 71837. [20:43:28] 3VisualEditor / 3Editing Tools: VisualEditor: Bring back the edit summary byte counter in the save dialog - 10https://bugzilla.wikimedia.org/71837 (10James Forrester) p:5Unprio>3High [20:51:14] um [20:51:17] var $textarea = dialog.editSummaryInput.getValue(); ? [20:51:54] Crap, did I miss something? [20:52:04] getvalue doesn't return a jquery object [20:52:07] ? [20:52:09] Yeah, crap [20:52:11] No it does not [20:52:12] It returns a string [20:52:14] well that's the only line of the change :) [20:52:21] :D [20:52:49] No, there is another line which is correct [20:52:53] .val() -> .setValue() [20:54:09] Maybe we should add a resetValue() method to TextInputWidget . We're using setValue( '' ) in several places. [20:54:49] (03PS1) 10Catrope: Followup 78e3a91: can't assign getValue() to $textarea, oops [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165606 [20:54:52] mooeypoo: We need more than that too [20:54:56] but that's besides the point. Yeah, the getValue() one returns a string, so the .focus() shouldn't work, theoretically. [20:55:10] That code I'm touching there is doing all sorts of things to $textarea [20:55:12] focus, selectEnd [20:55:18] That needs to all be in TextInputWidget [20:55:18] * mooeypoo nods [20:55:24] aye. [20:55:37] It should be in InputWidget generalized, probably [20:55:42] (03PS2) 10Catrope: Followup 78e3a91: can't assign getValue() to $textarea, oops [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165606 [20:55:50] focus yes, selectEnd no [20:56:00] True, yes, indeed [20:57:06] isEmpty() could be helpful too. I thought it already existed? Not sure. I might be mixing widgets. $textarea.val() !== '' [20:57:11] ^^ instead of that [20:58:42] Maybe [21:03:07] I think TextInputWidget has a focus method too [21:03:43] (03CR) 10Esanders: "FIXME" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165597 (https://bugzilla.wikimedia.org/56647) (owner: 10SuchetaG) [21:07:29] edsanders: See https://gerrit.wikimedia.org/r/165606 for the fix. [21:07:50] Ooooh. [21:08:21] fixes, but doesn't use getValue... [21:08:29] Fair [21:08:35] (03CR) 10Esanders: [C: 032] Followup 78e3a91: can't assign getValue() to $textarea, oops [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165606 (owner: 10Catrope) [21:08:46] Also, TextInputWidget probably has .focus() [21:08:57] But it doesn't have an equivalent of ve.selectEnd() [21:09:03] If we implemented that we could get rid of $textarea there [21:10:00] (03Merged) 10jenkins-bot: Followup 78e3a91: can't assign getValue() to $textarea, oops [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165606 (owner: 10Catrope) [21:11:07] Damn this edit counter code is a mess [21:11:21] And poor sucheta gets to clean it up as her introduction to VE :| [21:11:33] Yeah. [21:12:54] That's probably fine, except this confusion was not great for my sleepy eyes. :P [21:14:01] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression pre-wmf3] Typing fast in CE or reference dialog box shifts the first character of the text to the next line in Firefox - 10https://bugzilla.wikimedia.org/64399#c11 (10James Forrester) 5ASSI>3RESO/FIX a:5Roan Kattouw>3Ed Sanders Moved to a di... [21:14:07] sucheta: Go! Work on things tomorrow. :-) [21:14:41] RoanKattouw: BTW, I'd point out that it's actually plausible for you to get fixes into tomorrow's cut after you sleep tonight. :-) [21:14:51] James_F: Yes, but RFC meeting [21:15:12] RoanKattouw: Yes yes, but in 45 minutes' time. [21:15:24] I had meetings today 19:00-19:30 , 19:30-20:00 (really 20:10), 20:00-20:30 (really 20:40), 22:00-23:00 and now 23:00-00:00 [21:15:45] Fun. [21:15:56] Plus hangouts with David in the late afternoon, plus trying to get actual work done [21:16:04] Yay Wednesdays [21:16:17] So I might slack off a bit tomorrow [21:16:34] You slack off /every/ day. :-) [21:18:54] See you all tomorrow. It's almost 3AM. As Ted Moseby said, no good code was written after 2 AM [21:19:19] I was actually thinking of saying "nothing good happens after 2am" to you earlier :D [21:19:41] It's always 2am somewhere. [21:19:50] G'night sucheta ;) [21:20:37] Good things rarely happen, thus ;) Blame it all on 2 am [21:20:52] sucheta: See you. :-) [21:21:21] :D Bye! [21:22:45] 3VisualEditor / 3Mobile: VisualEditor Mobile: Can't select an image node if the cursor is active? - 10https://bugzilla.wikimedia.org/71841 (10James Forrester) 3NEW p:3Unprio s:3normal a:3None If you open the editor and click on an image it works fine (albeit alienated), but once you've dropped the cu... [21:23:14] 3VisualEditor / 3Mobile: VisualEditor Mobile: Can't select an image node if the cursor is active? - 10https://bugzilla.wikimedia.org/71841 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [21:25:45] 3VisualEditor: JS error on loading mobile VE: Discontiguous selection is not supported. - 10https://bugzilla.wikimedia.org/69616#c5 (10James Forrester) 5NEW>3RESO/DUP Duplicate of bug 68493 which is now fixed. *** This bug has been marked as a duplicate of bug 68493 *** [21:25:58] 3VisualEditor / 3ContentEditable: VisualEditor: Chrome 36 and higher throws "Discontiguous selection is not supported" on opening the editor - 10https://bugzilla.wikimedia.org/68493#c4 (10James Forrester) *** Bug 69616 has been marked as a duplicate of this bug. *** [21:27:58] 3VisualEditor / 3Editing Tools: VisualEditor: TitleInputWidget should validate inputs - 10https://bugzilla.wikimedia.org/71249#c3 (10James Forrester) (In reply to Alex Monk from comment #1) > Currently the redirect section of the page settings dialog and the template > placeholder page use MWTitleInputWidget... [21:28:44] 3VisualEditor / 3Editing Tools: VisualEditor: TitleInputWidget should validate inputs - 10https://bugzilla.wikimedia.org/71249 (10James Forrester) [21:29:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] When the inspector is still open for a selected node, after placing the cursor in a different position, inspector flickers there - 10https://bugzilla.wikimedia.org/71151 (10James Forrester) [21:29:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Clicking in the document where an inspector was opened doesn't close the inspector - 10https://bugzilla.wikimedia.org/68679 (10James Forrester) [21:29:00] 3VisualEditor / 3Data Model: VisualEditor: Pasting in image caption with a repeated reference causes VE to crash - 10https://bugzilla.wikimedia.org/71214 (10James Forrester) [21:29:00] 3VisualEditor / 3MediaWiki integration: VisualEditor: After saving a page reference list gets missing (unless it is refreshed again) and the page gets categorized as "Pages with missing reference list" - 10https://bugzilla.wikimedia.org/68182 (10James Forrester) [21:29:01] 3VisualEditor / 3Editing Tools: VisualEditor: Applying link to the caption of an image does not enable "Apply Changes" button - 10https://bugzilla.wikimedia.org/71065 (10James Forrester) [21:29:02] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - 10https://bugzilla.wikimedia.org/66604 (10James Forrester) [21:29:13] 3VisualEditor / 3Editing Tools: VisualEditor: In the media insertion dialog, give a tooltip on each item saying what will happen when you click it (i.e., "Click to insert as a thumbnail" or whatever) - 10https://bugzilla.wikimedia.org/52219 (10James Forrester) [21:29:13] 3VisualEditor / 3Data Model: VisualEditor: Undoing a change of group on a reference throws "Uncaught TypeError: Cannot read property 'length' of undefined" - 10https://bugzilla.wikimedia.org/69119 (10James Forrester) [21:31:55] TrevorParscal: https://phabricator.wikimedia.org/M4/ [21:35:01] hmmmmmmm [21:42:35] mooeypoo: you in SF yet? [21:42:53] "Do not dwell in the past, do not dream of the future, concentrate the mind on the present moment." –Phab 404 [21:43:19] Krinkle: Do you even read your email? [21:43:23] Krinkle, not yet [21:43:24] Hm.. I think the copyright notice at the bottom there is unfortunately phrased legal wise [21:43:27] Text is available under the Creative Commons Attribution-ShareAlike License; code is available under the GNU General Public License or other appropriate open source licenses. By using this site, you agree to the Terms of Use and Privacy Policy. · Copyright 2014 · Wikimedia Foundation [21:43:44] That means phab interface text has now been illegaly relicenced :P [21:43:51] (maybe, INAL) [21:44:16] I did read editing-l, mooeypoo is full-time now [21:44:23] Krinkle: Oh wait, I was wrong, the email doesn't say [21:45:16] ah, the mail does say, she's not yet moved but still in *** [21:45:25] (wmfall) [21:45:38] Aye, I plan to move towards December [21:45:38] mooeypoo: you moving this month? [21:45:41] cool [21:45:57] I did start packing... my mom's here now, she extended her layover for a week [21:46:28] we're getting a head start on packing and figuring out how to sell half my apartment... and... how much it will cost to send a bunch of stuff across the country. [21:46:30] And I assume sucheta is in India based on her saying it's 3AM. [21:46:37] cool cool. Team growing :) [21:46:40] :) [21:47:01] mooeypoo: or go for a road trip and DIY. [21:47:25] Krinkle, I actually thought about doing that [21:47:35] Yeah .. that means renting a U-Haul and finding a second driver and taking a week off work [21:47:39] Indeed [21:47:48] my dad wanted to come over and make a 2-3 week trip thing [21:47:50] Because NYC - SF is 4500km or so [21:47:56] but yeah, it doesn't work out. [21:48:19] RoanKattouw, it's worse than that, because it seems that it won't really be any fun if we do NYC -> SF [21:48:32] there's not a whole lot to see on that line. I was told to go at it through like... florida [21:48:38] which will make things a whole lot longer [21:48:39] Yeah I can't think of fun places on the way, other than Mt Rushmore [21:49:03] We might do it at some point, it sounds like a fun trip, but probaby not in this move [21:49:21] Can you go to the top of Mount Rushmore? [21:49:23] There are fun things up north, like Niagara Falls and Jasper/Banff [21:49:31] Or is that preventing the mouths to open up for Team America? [21:49:51] But Niagara - Jasper is, what, 3000km? 3000km of boring [21:50:05] Well, yeah, but that means going further north, maybe even crossing to Canada, and also freezing. [21:50:07] December... [21:50:16] haha yeah maybe not in December [21:50:20] RoanKattouw, I can't believe you missed my Mt. Rushmore reference. [21:50:26] Did oyu not see Team America? [21:50:28] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10James Forrester) [21:50:47] I don't know about the rest of Canada but I know what the weather is in Saskatchewan that time of year and it's not good for you or your car or anything really (-40) [21:50:53] mooeypoo: Ooooooooh yeah [21:50:54] Of course [21:50:57] Well done [21:50:58] 3VisualEditor / 3Editing Tools: VisualEditor: Append references list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906 (10James Forrester) [21:51:01] :D [21:51:21] I was thinking it could be quite epic to write VE code at the top of Mt. Rushmore [21:51:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf22] Resizing the window adds an extra padding below the "Choose a different image" button in Media Settings dialog - 10https://bugzilla.wikimedia.org/70895 (10James Forrester) [21:51:29] and then i was wondering if you can even get there. [21:51:44] 3VisualEditor / 3Editing Tools: VisualEditor: CommentInspector doesn't update its size when the textarea gets resized - 10https://bugzilla.wikimedia.org/71427 (10James Forrester) [21:52:00] And yes... -40 is not advisable. I know I'm pretty used to cold weather in NYC, but that's just crazy. [21:52:49] Dude the mall parking lots have a power socket at each space [21:53:01] So you can plug in your car and keep the oil heated and moving lest it freeze over [21:53:01] 3VisualEditor / 3Mobile: VisualEditor: Selecting templates on iOS < 8 causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110 (10James Forrester) [21:53:12] mooeypoo: depends, if you find 2 other drivers, you don't have to go yourself. [21:53:15] It looks really silly in summer when it's closer to +40 than -40 [21:53:21] You'd just sponsor two people to have a 2-week vacation. [21:53:30] while driving your stuff across the country [21:53:41] Krinkle, indeed. [21:53:48] Are you volunteering? [21:53:50] (not fully paid, just enough to justify the driving/costs, it's their vacation) [21:53:57] There are places I'd like to drive to but they're not reasonably connected in any way [21:54:13] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10James Forrester) [21:54:16] mooeypoo: Maybe greglist :P, though it's a risk, they might drive to Mexico instead and sell your stuff. :P [21:54:24] Niagara Falls, Jasper/Banff national parks, Grand Canyon; they're all thousands of kilometers apart [21:54:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] The subst: autovalue for a template field does not return any value (Parsoid issue?) - 10https://bugzilla.wikimedia.org/71157 (10James Forrester) [21:54:42] Krinkle, oh, mexico is fine -- my parents live there [21:54:42] :P [21:54:43] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195 (10James Forrester) [21:54:58] 3VisualEditor / 3Editing Tools: VisualEditor: Support "substituting" templates in transclusion dialog - 10https://bugzilla.wikimedia.org/49904 (10James Forrester) [21:55:14] 3VisualEditor / 3ContentEditable: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - 10https://bugzilla.wikimedia.org/69474 (10James Forrester) [21:55:29] 3VisualEditor / 3Editing Tools: VisualEditor: MWLink nodes inside sub-editor dialogs appear as zero-width - 10https://bugzilla.wikimedia.org/71652 (10James Forrester) [21:55:43] 3VisualEditor / 3Data Model: VisualEditor: Make transaction processing exception-safe - 10https://bugzilla.wikimedia.org/68892 (10James Forrester) [21:55:59] 3VisualEditor / 3Editing Tools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - 10https://bugzilla.wikimedia.org/68537 (10James Forrester) [21:59:14] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10James Forrester) [21:59:28] 3VisualEditor / 3ContentEditable: VisualEditor: Deleting from an empty paragraph to the end of an inline node throws an exception - 10https://bugzilla.wikimedia.org/70375 (10James Forrester) [21:59:43] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf1] Increasing indentation to a bullet/numbered list is also adding a slug with a new bullet/numbered point each time - 10https://bugzilla.wikimedia.org/71134 (10James Forrester) [21:59:58] 3VisualEditor / 3Editing Tools: VisualEditor: In the media selector show name in a tooltip on mouseover - 10https://bugzilla.wikimedia.org/52459 (10James Forrester) [22:01:14] 3VisualEditor / 3Editing Tools: VisualEditor: There should be help links in every context - dialog boxes, inspectors, etc. - 10https://bugzilla.wikimedia.org/51798 (10James Forrester) [22:01:28] 3VisualEditor / 3Editing Tools: VisualEditor: Reference group input combo box does not populate the Reference group names if created from Reference list dialog - 10https://bugzilla.wikimedia.org/70365 (10James Forrester) [22:01:28] 3VisualEditor / 3ContentEditable: VisualEditor: Safari scrolls one line for every character typed - 10https://bugzilla.wikimedia.org/71561 (10James Forrester) [22:01:45] 3VisualEditor / 3Editing Tools: VisualEditor: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - 10https://bugzilla.wikimedia.org/68590 (10James Forrester) [22:01:45] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf3] For every Math expression, it is not appearing on CE when its gets evaluated for the first time - 10https://bugzilla.wikimedia.org/71829 (10James Forrester) [22:03:00] 3VisualEditor / 3MediaWiki integration: VisualEditor: Link existence checker in LinkTargetInputWidget doesn't work for interwikis, language links - 10https://bugzilla.wikimedia.org/70504 (10James Forrester) [22:15:10] (03CR) 10Esanders: [C: 031] "Holding off +2 as Roan mentioned potentially not releasing this yet." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [22:18:02] edsanders: Thanks. Yeah I wanted to unleash that stack after the cut tomorrow [22:18:37] edsanders: Also ideally https://gerrit.wikimedia.org/r/#/c/164516/ would be part of that unleashing, but I wasn't sure what you'd think of it, because I don't like it much myself either [22:18:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf2] Deleting any focusable node throws "error:NS_ERROR_FAILURE:" in Firefox and wrong context menu starts appearing for other nodes - 10https://bugzilla.wikimedia.org/71580#c8 (10Rummana Yasmeen) Verified the backport in test2 [22:25:19] Hopefully I'll also figure out why the hell unicorns break the paste tests and then the unicorn changes can go too [22:26:17] OMG RoanKattouw [22:26:35] I just came back from the supermarket, GUESS what they brought over to my local store *just as I am moving* [22:26:45] ....stroopwafels? [22:26:53] YES! [22:27:15] Nice [22:27:17] They call it "Eat Dutch Waffles" [22:27:30] Which seems like a really weird name, honestly, but very practical. [22:27:38] Yeah [22:27:55] oh, and it's NYC so they emphasize it's "ALL NATURAL" [22:28:06] The SF buzzword for that is "organic" [22:28:27] Yeah the supply of European things isn't as good on the west coast as on the east coast [22:28:37] But we have Mexican food instead so I'll take that [22:30:00] I wonder how chemists deal with everything having "Organic" label [22:30:14] I imagine most chemists in California are hairless now. [22:30:49] That's OK we have prop 65 warnings instead [22:31:01] I'm afraid to ask what that is [22:31:30] " WARNING: This product contains chemicals known to the State of California to cause cancer and birth defects or other reproductive harm." [22:31:50] I saw a sign similar to this (but not this exact sign) at the Disneyland entrance: https://en.wikipedia.org/wiki/California_Proposition_65_%281986%29#mediaviewer/File:Disneyland_Prop_65_Warning_crop.jpg [22:32:12] (Caption in the article: "A vague Prop 65 warning sign at Disneyland Resort") [22:32:17] Just another excuse for someone to say "Sorry honey, it's the stroopwafels. Blame the Dutch." [22:32:59] Obligatory: https://xkcd.com/796/ [22:34:55] I think social and organic structures did that already, they call it facebook exposure and facebook stalking :P It's pull though not push like that xkcd [22:36:21] Krinkle: I brought that up because of the "known to the State of California" part, which is a reference to prop 65 warnings [22:44:59] RoanKattouw, are these signs backed up by actual science, or are they just due to political pressure over labeling stuff? [22:47:01] mooeypoo: Well https://en.wikipedia.org/wiki/California_Proposition_65_%281986%29#Abuse is a section, so ... [22:47:11] Ha [22:47:19] Also that article says (not in that section but right before it) that there is no penalty for posting an unnecessary warning sign [22:47:44] Oh, scientists everywhere rejoice. [22:54:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Getting stuck inside Media Settings dialog while attempting to change an image - 10https://bugzilla.wikimedia.org/71832#c2 (10Rummana Yasmeen) Verified the fix in Betalabs [22:55:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Citation dialog inserts empty reference - 10https://bugzilla.wikimedia.org/71825#c8 (10Rummana Yasmeen) Verified the fix in Betalabs [22:57:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Double-typing issues inside CE/media/reference dialogs again in Firefox - 10https://bugzilla.wikimedia.org/71823#c4 (10Rummana Yasmeen) The issue of double-typing of characters is resolved but the cursor is still appearing on readmode after... [23:14:57] TrevorParscal, around? [23:15:01] yeah [23:15:07] writing OOjs UI documentation [23:15:09] what's up? [23:18:05] a few months ago I fixed a few bugs related to the ref search widget [23:18:24] one bug has come up more recently that I think is related [23:25:29] ryasmeen: https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/index.html#widgets-mediawiki-vector-ltr [23:32:39] ryasmeen: https://bugzilla.wikimedia.org/show_bug.cgi?id=71827 sounds bad – can you investigate? [23:39:17] a few months ago I fixed a few bugs related to the ref search widget [23:39:17] one bug has come up more recently that I think is related [23:39:26] 31<Krenair>30 because the ref content is loaded late: https://gerrit.wikimedia.org/r/#/c/150736/ [23:39:26] 31<Krenair>30 as you can see from this commit, just a few lines before this change we try to make existing urls searchable, and record current text to be searched [23:39:26] 31<Krenair>30 this is still done, so I think this change was incomplete [23:39:36] because the ref content is loaded late: https://gerrit.wikimedia.org/r/#/c/150736/ [23:40:10] alex_____: Network issues? [23:40:17] yes [23:40:21] Fun. :-( [23:40:23] TrevorParscal: ^^^ [23:41:27] The bug it fixed though... Has got to have been a regression. But I don't know what caused it [23:42:02] Krenair: lookin