[00:01:45] (03CR) 10Trevor Parscal: [C: 04-1] Style required but currently-invalid parameters on the template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161613 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [00:05:00] Krenair: ok, so I think you are right, if the node isn't ready to be cloned because it doesn't have the content yet, it certainly won't contain the links we are looking for [00:05:44] the question is, when will the node be ready? [00:05:58] and if we can answer that, then we need to wait until then to build the list [00:06:18] because this latent grabbing of info is suspect [00:06:27] likely to cause many unforseen issues [00:27:11] James_F: this is the issue that I was mentioning in our pre-deployment meeting, it only happens in office wiki/mediawiki.org [00:27:27] I could not reproduce it on test2 or Betalabs under same scenario [00:28:28] TrevorP|Away, do you have a comment for https://gerrit.wikimedia.org/r/161613 ? [00:33:31] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression]In Firefox, Cursor is appearing in Read mode at the end of the document after saving a page and after discarding the current edit - 10https://bugzilla.wikimedia.org/71852 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment... [00:33:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression]In Firefox, Cursor is appearing in Read mode at the end of the document after saving a page and after discarding the current edit - 10https://bugzilla.wikimedia.org/71852 (10Rummana Yasmeen) 5NEW>3ASSI a:3Roan Kattouw [00:34:30] 3MediaWiki / 3ResourceLoader: CSSJanus fails to flip with !important - 10https://bugzilla.wikimedia.org/61440 (10Matthew Flaschen) a:3Matthew Flaschen [00:34:43] 3VisualEditor / 3ContentEditable: VisualEditor: Trying to insert anything in the slug inside a media dialog box throws Uncaught Error: Offset could not be translated to a DOM element and offset: 63 - 10https://bugzilla.wikimedia.org/63025 (10Rummana Yasmeen) 5REOP>3ASSI [00:34:43] 3VisualEditor / 3ContentEditable: VisualEditor: Trying to insert anything in the slug inside a media dialog box throws Uncaught Error: Offset could not be translated to a DOM element and offset: 63 - 10https://bugzilla.wikimedia.org/63025#c6 (10Rummana Yasmeen) 5RESO/FIX>3REOP Nope, this bug must have a... [01:03:44] ryasmeen|Away: Maybe fixed in wmf1 then? [01:06:53] (03PS9) 10Jforrester: ve.ui.CommentInspector: Update size when the textarea gets resized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) (owner: 10Bartosz Dziewoński) [01:07:33] (03CR) 10Jforrester: [C: 032] Followup b8d8a5b: fix getNativeRange() in null selection case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165539 (owner: 10Catrope) [01:08:03] (03CR) 10Jforrester: [C: 032] ve.ui.CommentInspector: Update size when the textarea gets resized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) (owner: 10Bartosz Dziewoński) [01:08:34] (03CR) 10GOIII: [C: 031] WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [01:09:22] (03Merged) 10jenkins-bot: Followup b8d8a5b: fix getNativeRange() in null selection case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165539 (owner: 10Catrope) [01:10:27] (03PS17) 10Jforrester: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [01:11:33] (03Merged) 10jenkins-bot: ve.ui.CommentInspector: Update size when the textarea gets resized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) (owner: 10Bartosz Dziewoński) [01:12:06] (03PS1) 10Jforrester: Update VE core submodule to master (8b78c2b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165675 [01:13:11] Please someone merge that. :-) [01:55:13] (03CR) 10Mooeypoo: [C: 032] Update VE core submodule to master (8b78c2b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165675 (owner: 10Jforrester) [01:56:40] (03Merged) 10jenkins-bot: Update VE core submodule to master (8b78c2b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165675 (owner: 10Jforrester) [02:12:29] 3VisualEditor / 3ContentEditable: VisualEditor: Trying to insert anything in the slug inside a media dialog box throws Uncaught Error: Offset could not be translated to a DOM element and offset: 63 - 10https://bugzilla.wikimedia.org/63025#c7 (10James Forrester) Huh. Darn. [02:40:15] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] In Firefox, Cursor is appearing in Read mode at the end of the document after saving a page and after discarding the current edit in Firefox - 10https://bugzilla.wikimedia.org/71852 (10James Forrester) p:5Unprio>3Highes [02:57:58] 3VisualEditor / 3ContentEditable: VisualEditor: Trying to insert anything in the slug inside a media dialog box throws Uncaught Error: Offset could not be translated to a DOM element and offset: 63 - 10https://bugzilla.wikimedia.org/63025 (10James Forrester) [02:57:59] 3VisualEditor / 3Editing Tools: VisualEditor: The external links should be validated. - 10https://bugzilla.wikimedia.org/71795#c3 (10Andre Klapper) (In reply to Ritu Swain from comment #2) > it could follow the HTTP URL syntax. What is that syntax? What about other protocols? How to define what's "valid" wi... [03:07:43] James_F|Away: But mediawiki.org and test2 both are running wmf2 right now [03:08:33] and its broken in wmf2 not on wmf3 i guess [03:13:15] 3OOjs UI: OOjs UI: Toolbar menus should let you show keyboard shortcuts in a right gutter - 10https://bugzilla.wikimedia.org/71855 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3Bartosz Dziewoński Something like: * https://a248.e.akamai.net/f/1737/7533/6/res2.windows.microsoft.com/resbox/en/windows%... [03:13:43] 3OOjs UI: OOjs UI: Toolbar menus should let you show keyboard shortcuts in a right gutter - 10https://bugzilla.wikimedia.org/71855 (10James Forrester) p:5Unprio>3High [03:23:15] 3VisualEditor / 3ContentEditable: VisualEditor: Extra characters being inserted when typing in bulleted lists - 10https://bugzilla.wikimedia.org/71827#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major a:3Roan Kattouw This sounds bad. [03:26:02] James_F, I complied. https://gerrit.wikimedia.org/r/#/c/165675/ <-- merged [03:31:14] 3MediaWiki / 3ResourceLoader: CSSJanus fails to flip with !important - 10https://bugzilla.wikimedia.org/61440#c4 (10Matthew Flaschen) Thanks, Bartosz. I submitted a fix (https://github.com/cssjanus/php-cssjanus/pull/3) upstream using your regex change. I also added a few tests. [03:31:28] 3MediaWiki / 3ResourceLoader: CSSJanus fails to flip with !important - 10https://bugzilla.wikimedia.org/61440 (10Matthew Flaschen) [03:31:58] 3VisualEditor / 3ContentEditable: VisualEditor: Extra characters being inserted when typing in bulleted lists - 10https://bugzilla.wikimedia.org/71827#c2 (10Jared Zimmerman (WMF)) I certainly didn't get a warm feeling while it was happening. [03:32:28] 3VisualEditor / 3ContentEditable: VisualEditor: Extra characters being inserted when typing in bulleted lists - 10https://bugzilla.wikimedia.org/71827#c3 (10Jared Zimmerman (WMF)) I didn't test on multiple platforms but I'm on Chrome 38.0.2125.101 beta / OS X 10.9 [03:38:28] 3VisualEditor / 3Editing Tools: VisualEditor: Content inside templates for translation of templates does not render in friendly ways - 10https://bugzilla.wikimedia.org/71730#c4 (10James Forrester) No, it means the ghastly mess that is {{TNTNTNTNTTNT}} :-) [04:13:43] 3VisualEditor / 3ContentEditable: VisualEditor: Extra characters being inserted when typing in bulleted lists - 10https://bugzilla.wikimedia.org/71827#c4 (10Rummana Yasmeen) yes just reproduced on mediawiki.org too on this page:https://www.mediawiki.org/wiki/User:RYasmeen_(WMF)?veaction=edit However, it doe... [04:41:28] 3VisualEditor / 3Editing Tools: VisualEditor: Highlight missing parameters in template dialog when complaining about them - 10https://bugzilla.wikimedia.org/70957 (10James Forrester) [04:49:58] 3VisualEditor / 3Editing Tools: VisualEditor: CommentInspector doesn't update its size when the textarea gets resized - 10https://bugzilla.wikimedia.org/71427 (10James Forrester) 5PATC>3RESO/FIX [05:14:15] 3MediaWiki / 3ResourceLoader: CSSJanus fails to flip with !important - 10https://bugzilla.wikimedia.org/61440#c5 (10Krinkle) Note that !important must never be used. It is a valid bug for upstream CSSJanus (since it's valid CSS), but should not bare any relevance to code in Wikimedia environments. There is... [05:32:00] 3MediaWiki / 3ResourceLoader: CSSJanus fails to flip with !important - 10https://bugzilla.wikimedia.org/61440#c6 (10Krinkle) Thanks Siebrand. I've put it here: https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS#.21important [07:36:28] 3MediaWiki / 3ResourceLoader: CSSJanus fails to flip with !important - 10https://bugzilla.wikimedia.org/61440#c7 (10Matthew Flaschen) (In reply to Krinkle from comment #5) > To override a style, always use the same selector as the original style and > you'll be fine. That isn't appropriate in all cases. Sa... [08:26:01] (03CR) 10Fomafix: [C: 04-1] "Some lines are too long. Use line breaks." (039 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [08:44:58] 3VisualEditor / 3ContentEditable: VisualEditor: Extra characters being inserted when typing in bulleted lists - 10https://bugzilla.wikimedia.org/71827#c5 (10Roan Kattouw) This is the exact bug that https://gerrit.wikimedia.org/r/#/c/164514/ was designed to fix; Rachel F showed me the exact same thing the day... [09:09:24] (03PS18) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [09:09:26] (03PS20) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [09:09:28] (03PS3) 10Esanders: WIP non-native table handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164616 [09:09:30] (03PS21) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [09:09:32] (03PS22) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [09:09:34] (03PS1) 10Esanders: Fix documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165703 [09:11:19] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [09:11:38] (03CR) 10jenkins-bot: [V: 04-1] WIP non-native table handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164616 (owner: 10Esanders) [09:25:04] (03CR) 10Catrope: [C: 032] Fix documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165703 (owner: 10Esanders) [09:26:32] (03Merged) 10jenkins-bot: Fix documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165703 (owner: 10Esanders) [10:15:28] 3MediaWiki / 3ResourceLoader: CSSJanus fails to flip with !important - 10https://bugzilla.wikimedia.org/61440#c8 (10Krinkle) (In reply to Matthew Flaschen from comment #7) > (In reply to Krinkle from comment #5) > > To override a style, always use the same selector as the original style and > > you'll be fin... [13:27:01] RoanKattouw, so I finally managed to debug my iOS8 device [13:27:28] only had to install 4GB of OS updates, 1GB of sys updates for safari 7, then 60mb for safari 7.1 [13:28:42] lovely [13:33:05] realise it's overlay-content height [13:33:08] now I find this: and now I f [13:33:12] https://gerrit.wikimedia.org/r/#/c/165637/ [13:34:32] Ahm [13:34:45] That /sounds/ like the iOS 7 keyboard sizing bug that Juliusz had worked around [13:35:15] Hmm or maybe he's saying that Juliusz's hack works in 7 but not 8 [13:37:02] well - it fixes the height = 0 bug [13:37:45] but the toolbar doesn't float correctly [13:38:03] because the overlay it too tall [13:38:51] also I can scroll very well with a cursor placed [13:39:08] not sure if that is a new issue though [14:04:46] (03PS1) 10Amire80: Handle a off-bounds image condition in language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165721 [14:28:51] (03PS2) 10Zfilipin: [BrowserTest] Handle a off-bounds image condition in language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165721 (owner: 10Amire80) [14:30:06] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Handle a off-bounds image condition in language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165721 (owner: 10Amire80) [14:31:32] (03Merged) 10jenkins-bot: [BrowserTest] Handle a off-bounds image condition in language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165721 (owner: 10Amire80) [14:56:28] (03PS1) 10Catrope: Followup 2fcc4c0: fix bugs with selection-only polling [VisualEditor/VisualEditor] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/165734 [14:56:36] (03CR) 10Catrope: [C: 032 V: 032] Followup 2fcc4c0: fix bugs with selection-only polling [VisualEditor/VisualEditor] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/165734 (owner: 10Catrope) [14:57:42] (03PS1) 10Catrope: Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/165735 [14:57:57] (03CR) 10Catrope: [C: 032 V: 032] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/165735 (owner: 10Catrope) [14:58:22] (03PS1) 10Esanders: MobileContext fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165736 [15:04:48] (03PS13) 10Divec: Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [15:06:15] (03CR) 10jenkins-bot: [V: 04-1] Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [15:09:40] (03PS6) 10Catrope: Get rid of trigger-happy slugChange event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164515 [15:10:40] (03PS5) 10Catrope: Make slug animations work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164516 [15:10:52] (03PS53) 10Catrope: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [15:11:00] (03PS4) 10Catrope: Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 [15:11:06] (03PS14) 10Catrope: Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [15:11:18] (03PS3) 10Catrope: POC: Match native content start annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165233 (owner: 10Divec) [15:12:38] (03CR) 10jenkins-bot: [V: 04-1] Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 (owner: 10Catrope) [15:13:02] bah [15:13:19] Oh that's fakeImes failing in Phantom [15:13:40] (03CR) 10jenkins-bot: [V: 04-1] Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [15:14:10] And that one has some serious failures [15:14:33] (03PS1) 10Esanders: Add missing images to Minerva theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/165741 [15:16:30] we really need better ways to test VE's cursor behavior and such -- still too many cases where weird stuff happens :( [15:47:01] (03PS7) 10Catrope: Get rid of trigger-happy slugChange event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164515 [15:48:32] (03PS6) 10Catrope: Make slug animations work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164516 [15:48:42] (03PS54) 10Catrope: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [15:48:56] (03PS4) 10Catrope: POC: Match native content start annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165233 (owner: 10Divec) [15:49:07] (03PS5) 10Catrope: Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 [15:50:00] (03PS15) 10Catrope: Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [15:51:32] (03CR) 10jenkins-bot: [V: 04-1] Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 (owner: 10Catrope) [15:53:44] 3MediaWiki / 3ResourceLoader: CSSMin url() value remapping not working in certain obscure cases (braces in comments inside declarations: background: /*{test}*/ url(image.png) ) - 10https://bugzilla.wikimedia.org/60077#c19 (10Mark A. Hershberger) If you want to backport this, that would be appreciated. Cherr... [15:54:57] OK the unicorn commit is V+2 now, and I fixed my botched rebase commit resolution in "trigger-happy slugChange" so the whole stack up to unicorn is now ready to merge [15:55:22] I think that's quite an accomplishment already :) gonna go eat, will be back around standup time, then I'll look into the V-1s on the last two commits [15:55:26] (03CR) 10jenkins-bot: [V: 04-1] Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [15:59:20] * James_F waves. [15:59:22] RoanKattouw_away: Is Unicorning going to get a proper commit title? :-) [16:21:55] (03CR) 10Jforrester: [C: 04-1] "We're about to delete the theme…" [oojs/ui] - 10https://gerrit.wikimedia.org/r/165741 (owner: 10Esanders) [16:26:02] (03PS6) 10Bartosz Dziewoński: [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [16:28:14] (03CR) 10jenkins-bot: [V: 04-1] [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [16:30:29] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108065437 [16:30:29] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108084398 [16:30:29] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32921664 [16:30:29] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32921680 [16:30:29] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32921684 [16:30:30] Corruption alert: visualeditor-needcheck on huwiki: https://hu.wikipedia.org/?diff=15196741 [16:30:30] Corruption alert: visualeditor-needcheck on huwiki: https://hu.wikipedia.org/?diff=15196777 [16:30:31] Corruption alert: visualeditor-needcheck on huwiki: https://hu.wikipedia.org/?diff=15196780 [16:30:31] Corruption alert: visualeditor-needcheck on huwiki: https://hu.wikipedia.org/?diff=15198456 [16:30:32] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66030665 [16:30:32] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40245751 [16:30:33] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40247136 [16:30:33] Corruption alert: visualeditor-needcheck on elwiki: https://el.wikipedia.org/?diff=4877159 [16:30:34] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=68557503 [16:32:07] (03PS7) 10Bartosz Dziewoński: [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [16:34:04] (03CR) 10jenkins-bot: [V: 04-1] [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [16:38:42] interesting [16:45:46] 3MediaWiki extensions / 3TemplateData: TemplateData: If TemplateData is added to a template page (not a /doc subpage), then it needs to be wrapped in tags - 10https://bugzilla.wikimedia.org/69149#c7 (10James Forrester) p:5Low>3High (In reply to Alex Monk from comment #2) > Well how would we... [16:45:48] 3MediaWiki extensions / 3TemplateData: TemplateData: If TemplateData is added to a template page (not a /doc subpage), then it needs to be wrapped in tags - 10https://bugzilla.wikimedia.org/69149 (10James Forrester) a:3Moriel Schottlender [16:48:43] (03PS8) 10Bartosz Dziewoński: [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [16:50:48] (03CR) 10Esanders: "When? What about VE standalone?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/165741 (owner: 10Esanders) [16:51:28] 3VisualEditor: When adding a citation there should be some button that gives the current day to a chosen field - 10https://bugzilla.wikimedia.org/71005 (10Stryn) s:5normal>3enhanc [16:51:41] (03CR) 10Jforrester: "About a minute after https://gerrit.wikimedia.org/r/#/c/164745/ lands. VE stand-alone can use MW or Apex skins as normal." [oojs/ui] - 10https://gerrit.wikimedia.org/r/165741 (owner: 10Esanders) [16:57:13] (03PS1) 10Esanders: Switch mobile demo from deprecated Minerva to MediaWiki [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165757 [16:57:49] (03CR) 10Jforrester: [C: 032] Switch mobile demo from deprecated Minerva to MediaWiki [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165757 (owner: 10Esanders) [16:58:12] James_F: Yeah, it needs a new commit summary [17:01:31] 3OOjs UI: OOjs UI: search results widget bottom aligns and doesn't scroll in MediaWiki theme - 10https://bugzilla.wikimedia.org/71889 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3None For example in the language search dialog in VE. [17:35:45] RoanKattouw: +2 https://gerrit.wikimedia.org/r/#/c/164745/ for me? [17:36:57] RoanKattouw: Thanks! [17:40:02] And there. [17:40:03] (03PS1) 10Jforrester: [BREAKING CHANGE] Remove deprecated Minerva theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/165761 [17:48:28] (03PS6) 10Catrope: Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 [17:50:22] (03CR) 10jenkins-bot: [V: 04-1] Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 (owner: 10Catrope) [17:57:49] (03PS16) 10Catrope: Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [17:58:20] (03PS1) 10Esanders: Fix styling of search dialog in MW [oojs/ui] - 10https://gerrit.wikimedia.org/r/165763 (https://bugzilla.wikimedia.org/71889) [17:59:32] (03PS1) 10Esanders: Fix grunt watch [oojs/ui] - 10https://gerrit.wikimedia.org/r/165764 [18:00:22] (03CR) 10jenkins-bot: [V: 04-1] Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [18:06:33] (03PS17) 10Catrope: Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [18:08:07] (03CR) 10jenkins-bot: [V: 04-1] Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [18:12:10] so TrevorParscal [18:12:23] "// Prevent any key events that might cause scrolling" [18:13:12] that's only supposed to apply to the parent document? [18:13:42] except when you have a non-isolated window there is no difference between the document and the parent document [18:13:50] so you've just killed all those keystrokes in the dialog [18:13:55] edsanders: Whoops. [18:18:07] edsanders: Maybe the dialog demo should include a dialog with a TextInputWidget or soemthing [18:18:25] To verify that you can click in the dialog (we had the exact same bug with mousedown IIRC) and type [18:18:37] Good https://gerrit.wikimedia.org/r/#/c/165763/ idea [18:18:59] nice [18:19:04] so my quick fix is to disable global events for isolated windows [18:19:48] wondering if it's possible to catch the events after they've bubbled up to the window container and then stop them going any further [18:20:05] Why not $.contains( e.target, ... ) [18:22:32] edsanders: ?? [18:23:10] you found an issue with non-isolated dialogs or something? [18:23:11] Good question [18:23:16] yes [18:23:22] the global events [18:23:27] where are we at with that? [18:23:45] so the idea in isolated dialogs is to prevent interaction with the parent [18:24:01] except with non-isolated dialogs it prevents interaction with the dialog [18:24:40] for example, breaks scroll keys (left/right/pgup) in textboxes, and scrolling of overflow content [18:25:20] I suggested e.target-based filtering [18:26:09] edsanders: Speaking of something entirely different, can I get CR of https://gerrit.wikimedia.org/r/#/c/164516/ soonish? [18:26:46] RoanKattouw: I'm going to re-+2 https://gerrit.wikimedia.org/r/#/c/135131/ OK? [18:26:57] James_F: No [18:27:00] No? [18:27:05] Unless you are OK with non-animated slugs from a product perspective [18:27:08] What changed from the stand-up? [18:27:09] Which I think you had said you were not [18:27:18] I forgot that Ed hadn't yet reviewed the animation change [18:27:24] Ah, OK. *glares at Ed*. [18:27:27] I am personally OK with landing staged non-animated slugs [18:27:47] It's not actually as bad as it sounds, it's janky-looking but most of the visual cues are still there [18:28:05] It looked a bit too janky for me. [18:28:21] edsanders: that does seem like a problem [18:28:31] how did you find this? where are you using a non-isolated dialog? [18:31:10] RoanKattouw, do you have a second to help me and the new volunteer with an Ubuntu issue? [18:31:30] well, a php-in-ubuntu issue. I think. MW won't install, it says there are "modules missing". I'm not entirely sure what to do [18:31:30] I was just about to take a break actually [18:31:42] Which modules does it say are missing? [18:31:47] RoanKattouw, not urgent, she's about to go to sleep anyways. Can I send you the errors she's getting? [18:31:52] An obvious candidate is mysql, you have to install the php5-mysql package anyway [18:31:53] Sure [18:31:55] indeed [18:31:56] mysql [18:31:59] but also a couple of others [18:32:14] It might say "I need one of: mysql, sqlite, ..." [18:32:22] mysql is the breaking one, clearly. She has mysql installed (She installed LAMP... you'd think that would make php *connected* with a mysql module...) [18:32:24] yep [18:32:33] but also Warning: Could not find APC, XCache or WinCache. [18:32:40] Could not find GD library or ImageMagick. [18:32:51] and PECL [18:32:53] Those are fine [18:33:09] GD/ImageMagick means thumbnails won't work [18:33:12] or at least won't be scaled [18:33:23] APC means worse performance but is also easy to install (php-apc or php5-apc, I forget) [18:33:36] * mooeypoo nods [18:33:46] i sent you the email she sent me with all the notices. I think it fails mostly because of the mysql [18:33:53] Probably yes [18:34:10] OK I'm going to be social for a few hours now, since I'm with family I don't see often [18:34:21] I'll be back later, probably around the time of Damon's office hour thing [18:34:37] awesome, I can figure out installing the php5-mysql module if that's the only real problem [18:38:20] mooeypoo, I can also probably maybe be able help you with Ubuntu related installation horrors. Have just done it myself. Although there is no end of new threats there [18:38:56] sucheta, yeah she's a bit new to Ubuntu as it is. Mostly it goes well, but then MW wouldn't install because of missing php stuff apparently [18:39:24] Uhm, which one is she running? 14.04? [18:39:29] I'm really annoyed at the LAMP installation though. Most good LAMP tutorials do the connection between php and mysql automatically for you, since it's... I dunno... *obvious* [18:39:34] I think so? Not sure. [18:39:56] Because a lot of the things are different for 14.04 [18:40:19] I had to change quite a lot of things here and there [18:40:23] yeah :\ [18:40:37] The new apache is also changed [18:43:07] TrevorParscal, there's a non-isolated dialog in the VE demo [18:43:14] for picking your UI language [18:43:35] not a 'real world' problem for VE yet [18:46:49] (03PS2) 10Jforrester: Follow-up If2da01a2: Fix grunt watch [oojs/ui] - 10https://gerrit.wikimedia.org/r/165764 (owner: 10Esanders) [18:46:53] (03CR) 10Jforrester: [C: 032] Follow-up If2da01a2: Fix grunt watch [oojs/ui] - 10https://gerrit.wikimedia.org/r/165764 (owner: 10Esanders) [18:47:53] bah, why can't i 'npm install' in oojs/ui on Ubuntu 14. [18:48:04] MatmaRex: What error does it give you/ [18:48:20] a bullshit one :D i'm trying to upgrade npm, that supposedly helps [18:48:32] MatmaRex: `rm -rf node_modules` helps often IME. [18:48:35] (Yay Node). [18:52:15] (03Merged) 10jenkins-bot: Follow-up If2da01a2: Fix grunt watch [oojs/ui] - 10https://gerrit.wikimedia.org/r/165764 (owner: 10Esanders) [18:52:56] bah. turns out that actually installing grunt helps. but why do we run `grunt` from `npm install`, somehow? [18:53:41] RoanKattouw_away, do we need to use e.target filtering or can we just choose where we listen? [18:55:04] MatmaRex: Read the README. :-0 [18:56:23] yeah… i installed 'grunt' globally instead of 'grunt-cli' [19:23:13] Yeah grunt runs from npm install which is very annoying [19:23:39] And exposes bugs every now and then where it can't install something because grunt breaks because you haven't installed that thing yet [19:25:32] RoanKattouw: I'm sure we'll have different entertaining bugs with gulp. [19:53:30] RoanKattouw, If I got from a slug to a focusable node it doesn't collapse [19:53:40] (in your stack) [19:54:23] Also Firefox has problems [19:54:31] if 0,0 is a slug it takes focus on load [19:55:13] and the staging doesn't work at all [19:55:25] (clicking does nothing) [19:57:41] James_F, why is this stuck https://gerrit.wikimedia.org/r/#/c/165757/ ? [19:58:32] edsanders: … 'cos it depends on 165736 which is unreviewed. [19:59:00] edsanders: Do you think I should just blindly merge that? It looked a bit beyond a simple one. [20:12:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Adding categories, removing them, then cancelling the dialog throws “Uncaught TypeError: Cannot read property 'disconnect' of undefined” - 10https://bugzilla.wikimedia.org/71471#c8 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in produ... [20:12:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Adding categories, removing them, then cancelling the dialog throws “Uncaught TypeError: Cannot read property 'disconnect' of undefined” - 10https://bugzilla.wikimedia.org/71471#c9 (10Rummana Yasmeen) Verified the fix in production [20:15:14] 3VisualEditor / 3Data Model: VisualEditor: [Regression] When an image is the only item of the document , trying to delete it right after opening VE throws "Error: offset was inside a handlesOwnChildren node" - 10https://bugzilla.wikimedia.org/71187#c6 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in... [20:15:59] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector UI gets broken if the link target suggestion dropdown overlaps with the border of the page - 10https://bugzilla.wikimedia.org/71371#c3 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [20:16:26] Uhm, how was the edit summary byte count supposed to appear? 'The number of bytes remaining' - this was the text? [20:16:47] sucheta: That was the tooltip. [20:17:05] sucheta: It just appeared as a number in the bottom right of the text box before. [20:19:17] Oh, so it's supposed to be a number in the span ve-ui-mwSaveDialog-editSummary-count? [20:20:39] James_F, yeah - it can't be any more broken than it is currently with an incomplete skin [20:21:04] sucheta: That sounds about right, yes. [20:21:11] edsanders: Eh. OK. [20:21:14] oh wait [20:21:21] (03CR) 10Jforrester: [C: 032] MobileContext fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165736 (owner: 10Esanders) [20:21:31] Wait? [20:21:42] oh well, never mind [20:21:51] …OK. [20:22:15] "oh wait" +@ [20:22:17] *+2 [20:22:19] classic [20:22:42] Gerrit was 503ing [20:23:17] (03Merged) 10jenkins-bot: MobileContext fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165736 (owner: 10Esanders) [20:23:18] RoanKattouw, you may want to post-review it [20:23:19] (03Merged) 10jenkins-bot: Switch mobile demo from deprecated Minerva to MediaWiki [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165757 (owner: 10Esanders) [20:24:02] edsanders: Hmm, OK... did you check if this was a problem with your change, or my refactor of it, or my animation change? [20:24:15] (I'm happy to figure that out for myself, just checking in case you already knew) [20:24:23] no - I was just testing from the animation change [20:25:20] Oh, the "Oh wait" was about the +2? [20:25:26] Clarity. It's a thing. :-) [20:54:31] (03PS1) 10SuchetaG: Bringing back the edit summary byte counter in the save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165871 (https://bugzilla.wikimedia.org/71837) [20:55:48] edsanders: Did you have any comments to make on https://gerrit.wikimedia.org/r/#/c/164516/ ? We'd like to merge this stack now if possible… [20:56:30] Other than it* being broken in FF [20:57:18] Oh, did you say that here/ [20:57:23] * James_F didn't see. Sorry. [20:58:17] String( this.editSummaryByteLimit - $.byteLength( this.editSummaryInput.getV [20:58:18] alue() ) ) [20:58:34] Should have been broken in two lines maybe? [20:59:52] Why did it break here though :| [21:00:01] We aim for a line length of 100 chars [21:00:15] Ya, that [21:00:22] But that's not a hard and fast rule [21:00:27] If it comes out to 103, nobody cares [21:00:35] OK, review! [21:00:40] There's a hard-and-fast rule at 120, I think? [21:00:59] We generally just use our judgment. I have a ruler configured for 100 but I take that as a suggestion [21:01:16] sucheta: Ooh, totally missed the Gerrit notification. Reviewing now :) [21:05:14] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf 22] Selection does not work while trying to select multiples lines after dragging the selection horizontally over a focusable node - 10https://bugzilla.wikimedia.org/71139#c4 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:06:58] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf2] "Uncaught Error: Syntax error, unrecognized expression: div[id ^= mittoHidden" appears while trying to save a page - 10https://bugzilla.wikimedia.org/71521#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:10:58] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf1] "Uncaught NotFoundError: Failed to execute 'insertBefore' on 'Node': .." while inserting a comment - 10https://bugzilla.wikimedia.org/71418#c8 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [21:11:19] (03CR) 10Catrope: [C: 04-1] Bringing back the edit summary byte counter in the save dialog (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165871 (https://bugzilla.wikimedia.org/71837) (owner: 10SuchetaG) [21:11:30] sucheta: Looks good, two minor things ---^^ [21:19:59] 3VisualEditor / 3ContentEditable: VisualEditor: Extra characters being inserted when typing in bulleted lists - 10https://bugzilla.wikimedia.org/71827 (10James Forrester) 5ASSI>3RESO/FIX [21:23:28] 3VisualEditor / 3Data Model: VisualEditor: Investigate parsing/rendering/behavior of "{{MW 1.23}}" on mediawiki.org [mini-tracking] - 10https://bugzilla.wikimedia.org/68297#c5 (10James Forrester) 5ASSI>3RESO/FIX All VE items appear fixed as of a while ago. Marking as such. [21:26:13] (03PS2) 10SuchetaG: Bringing back the edit summary byte counter in the save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165871 (https://bugzilla.wikimedia.org/71837) [21:27:35] RoanKattouw, there ^^ [21:27:46] (03CR) 10jenkins-bot: [V: 04-1] Bringing back the edit summary byte counter in the save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165871 (https://bugzilla.wikimedia.org/71837) (owner: 10SuchetaG) [21:28:22] (03CR) 10Catrope: [C: 032] Bringing back the edit summary byte counter in the save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165871 (https://bugzilla.wikimedia.org/71837) (owner: 10SuchetaG) [21:28:37] (The V-1 is the mw.cookie thing which happens intermittently, it wasn't a real failure) [21:29:47] (03Merged) 10jenkins-bot: Bringing back the edit summary byte counter in the save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165871 (https://bugzilla.wikimedia.org/71837) (owner: 10SuchetaG) [21:32:29] 3VisualEditor / 3Editing Tools: VisualEditor: Bring back the edit summary byte counter in the save dialog - 10https://bugzilla.wikimedia.org/71837 (10James Forrester) 5PATC>3RESO/FIX [21:32:35] Though a follow-up to make it a TitleElement appreciated. :-) [21:33:02] * RoanKattouw high-fives sucheta for fixing a user-visible bug on her fourth day [21:33:22] RoanKattouw: MatmaRex: https://github.com/trevorparscal/colorize [21:33:24] (third if you discount the Ubuntu upgrade mess) [21:33:40] this is what i came up with as a proof of concept for on-demand svg colorizing [21:34:01] TrevorParscal: OK I'll look in a minute, in bugfixing mode right now [21:34:07] RoanKattouw: no worries [21:34:07] RoanKattouw, Haha, High-five! :D [21:34:21] TrevorParscal: Also I assume Melissa sent you the same picture of Blaise she sent me? :D [21:34:28] TrevorParscal: is it faster than the phantomjs rasterizer? if yes, i approve :D [21:34:56] MatmaRex: It's ~4s for the set instead of 5. So… ish. [21:35:13] MatmaRex: I don't know, it takes like 3.2 secs on my machine to do all the OOjs UI icons (not indicators) in normal, invert and 3 of them in a variant (same as the mediawiki theme config) [21:35:16] Your son is getting too clever [21:35:24] MatmaRex: I'm skipping indicators atm [21:35:56] I'm using 16x supersampling and an unsharp mask to make up for the horrific rendering quality of imagemagick [21:36:08] maybe we could get better performance out of RSVG [21:37:07] i got the PNGs to look pretty good though [21:37:15] if you reduce the sampling variable to 1 [21:37:19] prepare to be shocked [21:37:21] lol [21:37:53] heh [21:37:58] MatmaRex: so, I'm thinking we will need to create a new kind of RL module [21:38:09] a ResourceLoaderIconModule [21:39:49] we /could/ add the support for this in ResourceLoaderFileModule [21:39:57] since... they are files [21:40:35] :o [21:40:44] what are these files going to be used for? [21:40:52] (03PS8) 10Catrope: Get rid of trigger-happy slugChange event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164515 [21:41:14] edsanders: --^^ fixes the focusablenode thing [21:41:17] 'images' => array( 'images/add.svg' => array( 'constructive' ), 'apple.svg', 'arrow.svg' ) [21:41:20] legoktm: Icons [21:41:22] legoktm: Clue's in the name. ;-) [21:41:23] yeah [21:41:42] rather... 'images' => array( 'icons' => array( 'images/add.svg' => array( 'constructive' ), 'apple.svg', 'arrow.svg' ) ) [21:41:45] something like that [21:41:48] updateSlug() was only called when the observer did something, which I copied from your code, but focusing a node doesn't cause observer events so I just moved it to onModelSelect, seemed appropriate [21:42:16] TrevorParscal: I don't think it should be a file module [21:42:24] Fundamentally what it is outputting is not a file or a concatenation of files [21:42:30] It's heavy on generated code (CSS) [21:42:37] fair enough [21:42:59] but the file mtime stuff is the same for invalidation [21:43:50] the source of the information is still a file [21:43:56] I would suggest you create a base class for things that are file based, and then use it in the FileModule and IconModule. [21:44:03] unlike other modules which are generated from the database or something [21:44:40] legoktm: but copy and paste is so much easier!! :P [21:45:01] xP [21:45:16] Yeah... [21:45:55] Maybe some of this FileModule stuff needs to be factored out and then it can be used by TemplateModule, IconModule, and RegularFileHelpImBadAtNamingThingsModule [21:46:20] RoanKattouw: Or maybe StagedFileModule for things that do things to files in tmp and then do something to them? [21:46:42] James_F: would prefer that class be called /dev/null [21:46:48] Or alternatively RoansWrathModule [21:46:55] RoanKattouw: You're no fun. [21:47:19] i'm not planning on using a tmp dir [21:47:46] just piping through imagemagick and stashing the rendered icon in cache or something [21:48:15] 3VisualEditor / 3MediaWiki integration: VisualEditor: Blue link / red link logic should descend into links inside non-transclusion generated content nodes - 10https://bugzilla.wikimedia.org/71900 (10James Forrester) p:5Unprio>3Lowest [21:48:17] 3VisualEditor / 3MediaWiki integration: VisualEditor: Blue link / red link logic should descend into links inside non-transclusion generated content nodes - 10https://bugzilla.wikimedia.org/71900 (10James Forrester) 3ASSI p:3Unprio s:3trivia a:3None For the very few GCNs that generate wiki-link links... [21:48:28] 3VisualEditor / 3MediaWiki integration: VisualEditor: Blue link / red link logic should descend into links inside transclusions - 10https://bugzilla.wikimedia.org/65353#c8 (10James Forrester) 5REOP>3RESO/FIX (In reply to Alex Monk from comment #7) > Well, it was you who changed this bug from being about... [21:51:51] RoanKattouw: also the whole local path, remote path stuff for images [21:52:07] i guess we are going to stop serving icons off disk [21:53:25] Well if you have colored icons you can't serve them off disk directly [21:53:32] The originals you could, but the colored versions you couldn't [21:53:52] So yeah I suppose you wouldn't need remote path [21:54:17] i'm basing this off ResourceLoaderUserCSSPrefsModule atm [21:54:25] as a starting point [21:55:32] OK that's good [21:55:35] Because that one is pure generation [21:55:56] edsanders: You happy with Roan's change? [21:56:00] So I realized that perhaps it's too late for me to jump into building OOUI chaos and then fixing the TitleElement part. James_F, OK, if I do it tomorrow morning? [21:56:08] sucheta: Of course. :-) [21:57:37] James_F: I haven't fixed Firefox yet, about to test my fix for that now [21:58:47] RoanKattouw: Oh, OK. [21:59:29] It's a bug in Ed's own commit though :P [21:59:45] RoanKattouw: :-) [21:59:58] (03PS20) 10Catrope: Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [22:00:06] OK that makes clicking in slugs work [22:00:16] If there is a slug at (0,0) then like Ed said it doesn't expand [22:00:26] even though it's initially focused [22:01:00] which... we should be doing selectFirstContentOffset() anyway, somehow that's happening on Chrome [22:01:08] RoanKattouw: the file mtime stuff is growing [22:01:10] AGH! [22:01:17] I'm too lazy to fix that now, I'm just gonna rebase this through because I amended stuff all over the stack [22:01:21] RoanKattouw, James_F|Away Yes but FF is still completely broken [22:01:25] TrevorParscal: Factor it out man. Bite the bullet :) [22:01:32] lol [22:01:38] edsanders: Let me rebase this through and then you can look at it again [22:01:50] (03PS9) 10Catrope: Get rid of trigger-happy slugChange event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164515 [22:01:58] php makes me sad [22:02:02] (03PS7) 10Catrope: Make slug animations work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164516 [22:02:53] edsanders: Firefox WFM in that ---^^ version of 164516 [22:03:11] The (0,0) issue is still there but IMO that's a larger problem, and not that bad, because when you type it fixes itself [22:10:51] (03PS55) 10Catrope: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [22:11:40] (03PS56) 10Catrope: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [22:13:43] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [22:16:02] hah [22:16:11] It's getting V-1ed because some IME tests are no longer failing [22:17:36] (03PS1) 10SuchetaG: Adding OO.ui.TitledElement as mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/165907 [22:18:58] (03PS1) 10Mooeypoo: Add tags to new strings [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/165908 (https://bugzilla.wikimedia.org/69149) [22:19:01] (03CR) 10Catrope: [C: 04-1] Adding OO.ui.TitledElement as mixin (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/165907 (owner: 10SuchetaG) [22:19:07] RoanKattouw, initial focus is still 0,0 [22:19:22] edsanders: I know, but I'm pretty sure that was the case before too [22:19:36] Also that's a bug with selectFirstContentOffset() not being called, it is being called in Chrome [22:19:49] [00:03] RoanKattouw The (0,0) issue is still there but IMO that's a larger problem, and not that bad, because when you type it fixes itself [22:20:00] slug->focusable doesn't work in FF [22:21:11] also animations are now broken in Chrome :) [22:21:13] huh that was working for me before [22:21:27] And I compared the animations side by side [22:21:31] Maybe my rebases broke things [22:22:12] also in master, FF doesn't select 0,0 [22:23:20] hm [22:25:48] (03PS2) 10SuchetaG: Adding OO.ui.TitledElement as mixin to label widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/165907 [22:25:56] WTF I have a cursor in a slug but slugFragment is null, what is going on [22:26:29] (03PS2) 10Esanders: Fix styling of search dialog in MW [oojs/ui] - 10https://gerrit.wikimedia.org/r/165763 (https://bugzilla.wikimedia.org/71889) [22:26:32] Oh, I think I see [22:27:02] updateSlug() gets called from onModelSelect which is triggered by the slug being staged in the first place [22:27:10] updateSlug() shouldn't unslug unless the cursor actually moved away [22:27:21] ...but that logic is ther [22:28:30] 3OOjs UI: OOjs UI: search results widget bottom aligns and doesn't scroll in MediaWiki theme - 10https://bugzilla.wikimedia.org/71889 (10Ed Sanders) a:3Ed Sanders [22:30:03] Oh ffs [22:30:59] ha it's another !getSelection() thing [22:32:13] rebase almost all the things? [22:32:42] yeah exactly [22:36:05] RoanKattouw, this requires no action, but I must get something off my chest: Mathematics without Physical implications is weird, and should die in a fire. [22:36:08] That is all. [22:36:20] Now in order to fix my botched rebase conflict resolution I'm going to deliberately cause a rebase conflict with myself [22:36:55] Oh, cool I don't have to [22:36:59] Because it's the other conflict [22:38:35] (03PS10) 10Catrope: Get rid of trigger-happy slugChange event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164515 [22:39:24] (03CR) 10Catrope: [C: 032] Adding OO.ui.TitledElement as mixin to label widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/165907 (owner: 10SuchetaG) [22:39:54] (03PS8) 10Catrope: Make slug animations work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164516 [22:39:55] RoanKattouw: so, I'm thinking we could actually build a check for SVG support into ResourceLoaderStartupModule's startup.js [22:40:07] Yeah that would be a good place to put it [22:40:13] and then all image modules will be loaded in the right flavor from then on out [22:40:18] I have been wanting to do SVG/PNG fallbacking properly for over a year now [22:40:32] and you just cracked that case [22:42:12] edsanders: OK that's working better now, now with less stupid code [22:42:21] I guess the animation still only goes one way though, I totally missed that [22:42:39] I'll take a look tomorrow [22:42:43] I animated entering a slug but I forgot to animate leaving [22:42:50] Yeah let's push this back a bit, it's getting crazy [22:43:15] I also discovered the unicorn change breaks the toolbar for God knows what reason [22:43:25] (03PS1) 10SuchetaG: Replacing the title attribute with the mixin TitledElement from OOUI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165912 [22:45:46] (03Merged) 10jenkins-bot: Adding OO.ui.TitledElement as mixin to label widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/165907 (owner: 10SuchetaG) [22:45:57] (03PS57) 10Catrope: Replace pawns with unicorns for pre-annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [22:46:08] (03PS58) 10Catrope: Replace pawns with unicorns for pre-annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [22:47:33] (03CR) 10Catrope: [C: 04-1] Replacing the title attribute with the mixin TitledElement from OOUI (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165912 (owner: 10SuchetaG) [22:47:43] sucheta: [22:47:59] sucheta: I feel bad for commit-message-minus-one-ing you at 4:17am your time :( [22:48:48] (03CR) 10jenkins-bot: [V: 04-1] Replace pawns with unicorns for pre-annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [22:49:29] I am totally high on Beatles right now, so Let It Be [22:49:44] Fixing :P [22:50:20] *The Beatles [22:53:35] OK fixed the toolbar, that was another rebase mistake [22:53:43] 3VisualEditor / 3Data Model: VisualEditor: In the Re-use reference dialog, search is not returning correct results on the second initialization for a specific case - 10https://bugzilla.wikimedia.org/70886#c17 (10Alex Monk) So I'm guessing this is related to bug 67342 [22:53:48] (03PS59) 10Catrope: Replace pawns with unicorns for pre-annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [22:54:12] mooeypoo: In case you thought your language inspector stuff back in the day had high patchset numbers... ---^^ [22:54:38] oooh! [22:54:45] ... how many did I have? I think around 45 [22:55:27] (03CR) 10jenkins-bot: [V: 04-1] Replace pawns with unicorns for pre-annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [22:57:05] (03PS2) 10SuchetaG: Replacing title attribute with mixin TitledElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165912 [23:00:09] (03CR) 10Catrope: [C: 032] Replacing title attribute with mixin TitledElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165912 (owner: 10SuchetaG) [23:01:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Double-typing issues inside CE/media/reference dialogs again in Firefox - 10https://bugzilla.wikimedia.org/71823#c5 (10Rummana Yasmeen) Verified the fix for double-typing issue in test2 [23:01:57] OK, thanks, RoanKattouw . James_F|Away , there you go. [23:02:13] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Citation dialog inserts empty reference - 10https://bugzilla.wikimedia.org/71825#c9 (10Rummana Yasmeen) Verified the fix in test2 [23:03:12] See you all tomorrow! [23:03:56] (03Merged) 10jenkins-bot: Replacing title attribute with mixin TitledElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165912 (owner: 10SuchetaG) [23:03:58] Good night [23:04:12] night sucheta [23:04:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Getting stuck inside Media Settings dialog while attempting to change an image - 10https://bugzilla.wikimedia.org/71832#c3 (10Rummana Yasmeen) Verified the fix in test2 [23:04:42] Well, "night". I guess it's October now so the sun doesn't rise that early any more, but in June it would have been light already [23:06:44] (03PS60) 10Catrope: Replace pawns with unicorns for pre-annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [23:10:57] (03PS9) 10Catrope: Make slug animations work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164516 [23:11:35] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/165922/ [23:11:38] it's a start [23:12:07] Nice [23:12:25] hoping I can get Matmarex to run with it [23:19:03] TrevorParscal, RoanKattouw: will you guys have itme to review this anytime soon? https://gerrit.wikimedia.org/r/#/c/165139/ [23:19:13] lookin [23:20:16] could you please describe the intention of the changes in the commit message, rather than just saying "we made changes" lol :) [23:20:45] but, yeah looks like the refactoring of the initialization method (which i helped you with) and a spec cache (which seems nice) [23:21:42] (03CR) 10Trevor Parscal: [C: 031] "Please write a more complete commit message." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165139 (owner: 10Christian) [23:28:14] (03CR) 10Trevor Parscal: Style required but currently-invalid parameters on the template dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161613 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [23:33:42] TrevorParscal: thanks, ok, will fix/improve [23:34:07] (03CR) 10Trevor Parscal: [C: 032] Make slug animations work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164516 (owner: 10Catrope) [23:35:33] (03CR) 10Jforrester: [C: 032] "Per Ed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164515 (owner: 10Catrope) [23:35:53] (03CR) 10Jforrester: [C: 032] "Per Roan, Ed, Trevor." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [23:36:07] Holy crap what is happening [23:36:34] As discussed here, slug animations only does entering animations, not leaving animations, I'm still working on those [23:36:39] But I guess it can go without [23:36:47] (03CR) 10Catrope: [C: 032] "Per Trevor" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164516 (owner: 10Catrope) [23:36:54] RoanKattouw: Improvements welcome, but let's just land this. [23:37:34] (03Merged) 10jenkins-bot: Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [23:37:40] (03Merged) 10jenkins-bot: Get rid of trigger-happy slugChange event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164515 (owner: 10Catrope) [23:37:44] (03Merged) 10jenkins-bot: Make slug animations work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164516 (owner: 10Catrope) [23:38:46] (03PS1) 10Catrope: Also make transitions when leaving slugs work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165936 [23:38:58] James_F: Improvements ---^^ [23:39:03] * James_F saw. [23:39:11] Eventually this whole things needs to be cleaned up though [23:39:17] I've made a mess of the slug animations this way [23:39:33] Quoth TrevorParscal: "It's ve.ce.Surface. It's a nightmare anyway. How much worse could it get?". [23:39:41] I retrofitted it on the original animation technique, but now that technique is unused [23:39:42] That's praise for your coding right there, RoanKattouw. :-) [23:39:52] Yeah. [23:40:13] So all the weird shapes I twisted things into as part of bolting onto existing CSS can be untangled [23:40:15] haha yeah thanks TrevorParscal [23:40:27] (03CR) 10Jforrester: [C: 031] Also make transitions when leaving slugs work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165936 (owner: 10Catrope) [23:41:03] Well, I'll show you how much worse it can get! [23:41:08] (03CR) 10Catrope: [C: 032] Replace pawns with unicorns for pre-annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [23:41:14] There! [23:41:32] Wow. [23:41:34] :-D [23:41:45] 3VisualEditor / 3Technical Debt: VisualEditor: Put block slugs in the DM rather than fake them in CE - 10https://bugzilla.wikimedia.org/65052 (10James Forrester) 5PATC>3RESO/FIX a:3Ed Sanders [23:41:51] (03PS7) 10Jforrester: Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 (owner: 10Catrope) [23:42:02] October 10, 2014 at 1:41am ladies and gentlemen. The +2 heard round the world [23:42:10] (03CR) 10Jforrester: [C: 031] Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 (owner: 10Catrope) [23:42:19] (03PS18) 10Jforrester: Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [23:42:29] Coming in just under the six-month mark there I think? And at exactly 60 patchsets [23:42:34] Ha. [23:42:37] (03Merged) 10jenkins-bot: Replace pawns with unicorns for pre-annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [23:42:43] So, ten patchsets a month? [23:43:26] RoanKattouw: is https://gerrit.wikimedia.org/r/#/c/151046/ good to go too? [23:43:29] (03PS2) 10Catrope: Also make transitions when leaving slugs work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165936 [23:43:48] TODO: [23:43:48] * Arrow keying from inline slug onto focusable node into another inline slug [23:43:48] throws exception [23:43:50] * Aggressively clean up behind inline slugs, like we do for unicorns [23:43:52] * Redo render lock checking in a more carefully considered way” [23:43:54] (03CR) 10jenkins-bot: [V: 04-1] Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 (owner: 10Catrope) [23:43:54] So… no. [23:43:56] Nope [23:43:59] Also V-1 [23:44:03] True. [23:44:38] Has David put in his fixes for arrow key stuff in that yet? [23:44:44] I think he had some idea for how to fix it [23:45:08] But also, some of those bugs won't be fixed until we clean up behind unused chimeras pretty aggressively, which we need to do anyway [23:45:20] (03CR) 10jenkins-bot: [V: 04-1] Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [23:45:31] * James_F nods. [23:45:58] 23:43:42 Expected: ε [23:46:00] 23:43:42 Actual: ♙ [23:46:07] It's just taunting me there [23:46:23] My theory though is that the two commits aren't actually separable [23:46:35] This code should work. This code is logical, and follows the implemented methods of existing, working, publications. This code should be epic. [23:46:42] Naturally, it doesn't. [23:46:51] RoanKattouw: Hmm. [23:46:58] The V-1 on the chimera commit is about expected failures, so that's it nagging us to update the failure registry [23:47:01] Which I will go ahead and do [23:47:07] RoanKattouw: Good. [23:47:13] mooeypoo: :-) [23:48:21] James_F, I am going to take a break from crop/resizing thumbnails and concentrate for a while on the ooui shift for templatedata. When you get a moment, though, I hope my quickfix for the templatedata is what was meant? There was a bunch of "if subpage not in namepsace but is default key" stuff in there that I wasn't sure we should go by. [23:48:48] mooeypoo: Yeah, that looks good. [23:48:56] mooeypoo: Was about to merge it. [23:49:23] oh cool, ok. There aren't a lot of tests in there. Basically only for top pages, and only for new strings. [23:49:30] hope the bug reporters will be happy with that for now. [23:50:28] (03CR) 10Jforrester: [C: 032] Add tags to new strings [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/165908 (https://bugzilla.wikimedia.org/69149) (owner: 10Mooeypoo) [23:50:43] 3MediaWiki extensions / 3TemplateData: TemplateData: If TemplateData is added to a template page (not a /doc subpage), then it needs to be wrapped in tags - 10https://bugzilla.wikimedia.org/69149 (10James Forrester) 5PATC>3RESO/FIX [23:50:56] woot [23:51:01] (03PS5) 10Jforrester: Style required but currently-invalid parameters on the template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161613 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [23:51:15] (03CR) 10Jforrester: "PS5 is a rebase of PS3." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161613 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [23:51:45] (03PS19) 10Catrope: Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [23:56:45] (03CR) 10Jforrester: [C: 031] Style required but currently-invalid parameters on the template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161613 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk)