[00:01:42] (03Merged) 10jenkins-bot: Add tags to new strings [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/165908 (https://bugzilla.wikimedia.org/69149) (owner: 10Mooeypoo) [00:09:03] (03PS2) 10Jforrester: WIP Failing test case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158662 (https://bugzilla.wikimedia.org/70375) (owner: 10Esanders) [00:10:42] (03CR) 10jenkins-bot: [V: 04-1] WIP Failing test case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158662 (https://bugzilla.wikimedia.org/70375) (owner: 10Esanders) [00:16:52] (03CR) 10Jforrester: "What needs to happen here to fix this? I vaguely guesstimated that this would be fixed by the staging of slugs, but clearly I was wrong. :" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158662 (https://bugzilla.wikimedia.org/70375) (owner: 10Esanders) [00:24:46] 3VisualEditor / 3Mobile: VisualEditor Mobile: Link icon is missing in production (en.wiki) for mobile web - 10https://bugzilla.wikimedia.org/71903 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16739 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16739&action=edit Scr... [00:36:12] (03CR) 10Jforrester: WIP failing converter tests (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114355 (owner: 10Esanders) [00:50:17] 3VisualEditor: VisualEditor: Unlabeled, auto-numbered URLs can't be opened - 10https://bugzilla.wikimedia.org/71904 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None I'm editing, and I see a plain, unlabeled, auto-numbered link to an external website. It says "[2]". I can't open that link without ex... [03:58:58] 3VisualEditor / 3Editing Tools: VisualEditor: Add an "open" button for link nodes too - 10https://bugzilla.wikimedia.org/71904 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3enhanc [04:26:13] 3MediaWiki extensions / 3Cite: Templates transcluded list missing or incomplete during section edit - 10https://bugzilla.wikimedia.org/71866#c1 (10Quiddity) This problem only exists if the templates are within tags. Confirmed in a sandbox. (Thanks go to legoktm for suggesting that possibility). Movin... [06:10:57] (03PS8) 10Divec: Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 (owner: 10Catrope) [06:10:59] (03PS20) 10Divec: Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [06:11:56] (03CR) 10Divec: "Rebase" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [06:12:25] (03PS21) 10Divec: Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [06:12:51] (03CR) 10jenkins-bot: [V: 04-1] Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 (owner: 10Catrope) [06:14:06] (03CR) 10jenkins-bot: [V: 04-1] Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [06:17:23] (03PS1) 10Divec: Don't calculate DOM hash in SurfaceObserver (was unused) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165975 [08:21:41] Hello [08:21:46] 3VisualEditor / 3MediaWiki integration: VisualEditor: If more than one section was changed, no section title should be shown in the edit summary - 10https://bugzilla.wikimedia.org/58488 (10Elitre) [08:24:34] How can I activate VisualEditor on our Mediawiki pages? I see only "edit" but it is code editing. May I ask somebody for help please ? thank you [08:25:37] I am using IE 10 or CHROME v.38 [08:25:59] 3VisualEditor / 3MediaWiki integration: VisualEditor: If the user only has edited in one section (??), insert the name of that section into the edit summary as if they were section-editing - 10https://bugzilla.wikimedia.org/51903#c8 (10Elitre) Isn't this the current behavior (for various meanings of "section... [08:31:40] thank you but I am trying to edit whole page not one section I mean tabs "Read" "Edit" "View History" [08:43:47] Do I need to install and configure Parsoid node.js service ? [08:43:58] www.mediawiki.org/wiki/Extension:VisualEditor#Setting_VisualEditor_up [08:44:24] or how can I enable it please ? [08:58:20] no Idea or suggestion please ? [09:20:57] (03PS1) 10Esanders: Update method name in test description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165990 [09:40:55] (03PS1) 10Esanders: Bring in MobileContext hack from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165992 [09:41:08] (03PS1) 10Esanders: Remove MW-specific mobile hack from core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165993 [09:41:56] (03CR) 10jenkins-bot: [V: 04-1] Bring in MobileContext hack from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165992 (owner: 10Esanders) [09:45:19] (03PS1) 10Esanders: Add white background to toolbar in MediaWiki theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/165994 [09:51:21] (03CR) 10Esanders: "No, the empty paragraph in this case is not a slug. This is a low level bug in the transaction builder." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158662 (https://bugzilla.wikimedia.org/70375) (owner: 10Esanders) [10:56:06] (03CR) 10Esanders: "FIXME: This throws and exception in jQuery when you try to use it 'unsupported pseudo: focusable'." [oojs/ui] - 10https://gerrit.wikimedia.org/r/159902 (https://bugzilla.wikimedia.org/67156) (owner: 10Alex Monk) [10:57:59] 3VisualEditor / 3Editing Tools: VisualEditor: Do not let me tab outside the dialog box in Chrome/Safari - 10https://bugzilla.wikimedia.org/67156#c9 (10Ed Sanders) 5RESO/FIX>3REOP The applied patch throws an exception, see gerrit. [13:06:14] (03PS3) 10Esanders: Fix styling of search dialog in MW [oojs/ui] - 10https://gerrit.wikimedia.org/r/165763 (https://bugzilla.wikimedia.org/71889) [13:06:16] (03PS1) 10Esanders: Refine global event handling in non-isolated window managers [oojs/ui] - 10https://gerrit.wikimedia.org/r/166019 [15:53:13] (03PS9) 10Bartosz Dziewoński: [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [16:00:29] 3MediaWiki / 3Page editing: First line in edit window is sometimes hidden in Safari - 10https://bugzilla.wikimedia.org/71909 (10Andre Klapper) [16:01:26] (03PS32) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [16:15:37] (03PS4) 10Esanders: WIP non-native table handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164616 [16:15:43] (03CR) 10jenkins-bot: [V: 04-1] WIP non-native table handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164616 (owner: 10Esanders) [16:18:52] (03PS33) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [16:19:10] (03PS34) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [16:19:26] (03PS35) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [16:19:34] (03CR) 10Paladox: [C: 031] WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [16:23:57] (03PS1) 10Jforrester: Update VE core submodule to master (cf894c4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166057 [16:25:46] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (cf894c4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166057 (owner: 10Jforrester) [16:26:29] (03CR) 10Jforrester: [C: 032] Update method name in test description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165990 (owner: 10Esanders) [16:28:10] (03Merged) 10jenkins-bot: Update method name in test description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165990 (owner: 10Esanders) [16:30:42] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108087835 [16:30:42] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108103168 [16:30:42] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32921954 [16:30:42] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32922018 [16:30:42] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32922097 [16:30:43] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66056072 [16:30:43] Corruption alert: visualeditor-needcheck on skwiki: https://sk.wikipedia.org/?diff=5870938 [16:39:51] (03CR) 10Fomafix: "Use tabs instead of spaces for indenting." (039 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [16:40:18] (03CR) 10Fomafix: [C: 04-1] WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [16:53:45] 3VisualEditor / 3MediaWiki integration: VisualEditor:Editing and saving a page , then pressing back browser button takes to previously saved page. - 10https://bugzilla.wikimedia.org/71917 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Environment- test2 1> In VE enter external link e.g- http://low... [16:53:58] 3VisualEditor / 3MediaWiki integration: VisualEditor:Editing and saving a page , then pressing back browser button takes to previously saved page. - 10https://bugzilla.wikimedia.org/71917 (10Ritu Swain) [17:00:58] 3VisualEditor / 3Editing Tools: VisualEditor: The external links should be validated. - 10https://bugzilla.wikimedia.org/71795#c4 (10Ritu Swain) I raised this ticket, because i thought there should be some sort of client-side validation for external link entries.What I mean is, when i type in a "//" or "//f... [17:01:28] (03PS36) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [17:01:45] (03PS37) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [17:02:05] (03PS38) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [17:02:15] (03CR) 10Paladox: [C: 031] WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [17:03:43] 3MediaWiki extensions / 3Cite: Templates transcluded list missing or incomplete during section edit - 10https://bugzilla.wikimedia.org/71866 (10Andre Klapper) p:5Unprio>3Normal [17:10:44] 3OOjs UI: OOjs UI: ComboBoxWidget cut off near bottom of window - 10https://bugzilla.wikimedia.org/71178#c18 (10Ritu Swain) hi Alex, when i click on the combo box arrow it just puts the cursor in it.Earlier doing the same action, used to show the "General References" in a drop-down list with a check beside it. [17:10:58] 3OOjs UI: OOjs UI: ComboBoxWidget cut off near bottom of window - 10https://bugzilla.wikimedia.org/71178#c19 (10Ritu Swain) (In reply to Ritu Swain from comment #18) > hi Alex, when i click on the combo box arrow it just puts the cursor in > it.Earlier doing the same action, used to show the "General Reference... [17:26:00] (03CR) 10Florianschmidtwelzow: "@Paladox: There is no need to review your own change :)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [17:29:12] (03CR) 10Paladox: "Oh ok." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [18:00:48] (03PS10) 10Bartosz Dziewoński: [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [18:14:50] James_F: Could you point me to the roadmap for VE? [18:15:06] Deskana: mediawiki.org/wiki/VisualEditor/Roadmap [18:15:19] James_F: ta duck [18:15:35] Deskana: No probs dahhhhhhrling. [18:24:28] (03CR) 10Bartosz Dziewoński: "Do we want to merge this now and add more stuff later, or do we want one massive patch with everything in it?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [18:25:10] MatmaRex: Partial progress is still progress. [18:25:28] MatmaRex: And merged in OOUI master !== available in MediaWiki core, of course. [18:26:10] indeed and indeed, but i don't see how that answers the question. the sooner we merge it, the less time there is for the JS implementation to drift away as we forget to update the PHP patch. :) [18:27:17] It was a "yes". :-) [18:27:57] :D [18:35:32] MatmaRex: does it really have to have a magic __call thing? [18:35:58] legoktm: Was that the bit that we're doing so we don't use traits? [18:36:13] I don't know yet, still reading through the patch. [18:39:18] I know there's some magic there. [19:07:23] (03CR) 10Legoktm: [WIP] PHP Implementation of OOjs UI (035 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [19:09:18] legoktm: example usage of what? where __call is used? [19:09:22] yes [19:09:29] or, how it's intended to be used [19:09:49] OoUiButtonWidget has several mixins [19:10:21] the mixins there are apparently basically traits [19:11:32] oh I see, hm. [19:11:52] so if you have e.g. OoUiButtonWidget that mixins a OoUiFlaggedElement, you can call setFlag() directly on the button [19:12:44] gotcha, I missed the difference between Widgets and elements. [19:13:07] but, traits wouldn't solve this problem either afais [19:13:10] i have a patch written that actually uses that for something (on top of trevor's), perhaps i should upload that [19:13:39] oh, it would [19:13:41] gr [19:13:46] yes please [19:14:32] I am going to find food and think about this a bit more [19:15:12] I also don't like the OoUiTheme::$current thing. [19:16:17] (03PS1) 10Bartosz Dziewoński: [WIP] OoUiTitledElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/166081 [19:16:19] (03PS1) 10Bartosz Dziewoński: [WIP] OoUiGroupElement, OoUiButtonGroupWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/166082 [19:16:49] legoktm: look at OoUiButtonGroupWidget and how it uses OoUiGroupElement's method(s) directly. that's how it's supposed to work i guess [19:17:07] (this is direct translation from JS) [19:17:28] by the way, you might also want to look at OoUiTitledElement and how i'm (ab)using a static property [19:17:44] because that's very neat but also sort of ew [19:19:49] (03CR) 10jenkins-bot: [V: 04-1] [WIP] OoUiGroupElement, OoUiButtonGroupWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/166082 (owner: 10Bartosz Dziewoński) [19:21:11] (03PS2) 10Jforrester: MediaWiki theme: Add filled white background to toolbars [oojs/ui] - 10https://gerrit.wikimedia.org/r/165994 (owner: 10Esanders) [19:21:18] (03CR) 10Jforrester: [C: 032] MediaWiki theme: Add filled white background to toolbars [oojs/ui] - 10https://gerrit.wikimedia.org/r/165994 (owner: 10Esanders) [19:24:03] (03Merged) 10jenkins-bot: MediaWiki theme: Add filled white background to toolbars [oojs/ui] - 10https://gerrit.wikimedia.org/r/165994 (owner: 10Esanders) [19:46:30] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340#c4 (10James Forrester) a:5Krinkle>3Bartosz Dziewoński Bumping over to Bartosz; this is an awkward three-w... [20:04:24] is it OOUI, or OOjs-UI? [20:04:32] legoktm: Indeed. [20:05:49] we're really bad at naming things. [20:06:31] legoktm: It was OOjs UI, but given we're having non-JS versions maybe we'll call it OOUI with OOUI|js, …|PHP and other builds. [20:06:34] legoktm: Or whatever. [20:08:14] 3VisualEditor / 3MediaWiki integration: VisualEditor: The handler MWCategoryWidget#onLookupInputKeyDown is not actually bound to anything - 10https://bugzilla.wikimedia.org/56700#c2 (10Krinkle) Created attachment 16743 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16743&action=edit Screenshot of bug... [20:26:28] 3VisualEditor / 3MediaWiki integration: VisualEditor: The handler MWCategoryWidget#onLookupInputKeyDown is not actually bound to anything - 10https://bugzilla.wikimedia.org/56700#c3 (10Krinkle) The handler from MWCategoryWidget is working fine. However, here is the code I used for comment #2 In ve/ui/MWCate... [20:33:28] 3OOjs UI: OOjs UI: ComboBoxWidget cut off near bottom of window - 10https://bugzilla.wikimedia.org/71178#c20 (10Alex Monk) I don't see how that's related to this bug. [20:34:13] 3VisualEditor / 3MediaWiki integration: VisualEditor: The handler MWCategoryWidget#onLookupInputKeyDown is not actually bound to anything - 10https://bugzilla.wikimedia.org/56700#c4 (10Krinkle) 5ASSI>3RESO/WOR Nevermind. They all work fine now. There is still a tech debt here though, we should use OOjs U... [20:34:21] (03PS5) 10Christian: Make MWTransclusionModel and MWTemplateDialog extensible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165139 [20:38:19] (03PS6) 10Jforrester: Make MWTransclusionModel and MWTemplateDialog extensible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165139 (owner: 10Christian) [20:38:42] (03CR) 10Jforrester: [C: 032] Make MWTransclusionModel and MWTemplateDialog extensible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165139 (owner: 10Christian) [20:38:45] (03PS1) 10Krinkle: MWCategoryWidget: Use TextInputWidget#event-enter instead of keypress [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166135 [20:39:28] 3VisualEditor / 3MediaWiki integration: VisualEditor: The handler MWCategoryWidget#onLookupInputKeyDown is not actually bound to anything - 10https://bugzilla.wikimedia.org/56700#c5 (10Krinkle) (In reply to Krinkle from comment #4) > There is still a tech debt here though, we should use OOjs UI's "enter" eve... [20:40:20] (03Merged) 10jenkins-bot: Make MWTransclusionModel and MWTemplateDialog extensible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165139 (owner: 10Christian) [20:43:52] (03CR) 10Jforrester: [C: 031] MWCategoryWidget: Use TextInputWidget#event-enter instead of keypress [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166135 (owner: 10Krinkle) [20:45:32] 3VisualEditor / 3Editing Tools: VisualEditor: "Categories" dialog behaves differently for existing values and entered values - 10https://bugzilla.wikimedia.org/71921 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Created attachment 16745 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16745&acti... [20:45:43] 3VisualEditor / 3Editing Tools: VisualEditor: "Categories" dialog behaves differently for existing values and entered values - 10https://bugzilla.wikimedia.org/71921#c1 (10Krinkle) Created attachment 16746 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16746&action=edit Screenshot of later rendering... [20:49:15] 3VisualEditor / 3Editing Tools: VisualEditor: "Categories" dialog behaves differently for existing values and entered values - 10https://bugzilla.wikimedia.org/71921 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3minor a:3Krinkle [21:09:13] (03PS1) 10Jforrester: build: Test with Chrom{e|ium}, not PhantomJS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166140 [21:11:13] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of $.proxy, use native .bind() - 10https://bugzilla.wikimedia.org/62762#c16 (10James Forrester) (In reply to Alex Monk from comment #15) > (In reply to Krinkle from comment #14) > > VisualEditor core, and OOjs UI. > > Me and Krinkle spoke about this and... [21:23:44] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to add or remove tables, table rows and table columns - 10https://bugzilla.wikimedia.org/52181 (10James Forrester) a:3Ed Sanders [21:42:29] 3VisualEditor / 3Technical Debt: VisualEditor: OpenSearch results aren't perfect for checking for page existence - 10https://bugzilla.wikimedia.org/51013#c7 (10James Forrester) 5ASSI>3RESO/FIX a:3Krinkle FIXED by dint of bug 70958 being fixed. Thanks, Timo! [21:46:30] Krinkle or Gruntmeisters, I want grunt-jscs to run on modules/**/*.js except for modules/new/vendor. grunt-jshint has an ignores option, but I don't see an equivalent for grunt-jscs [21:48:20] hmm, maybe jscs's excludeFiles: [ 'modules/new/vendor/**' ] works for grunt-jscs [21:49:07] spagewmf: that could work, but it's better to not run on grunt on it in the first place [21:49:28] spagewmf: remember that, contrary to running jshint from the command line standalone, inside grunt it is whitelist based. You pass it what files to run on [21:49:42] so modules/** is interpreted and expanded recursively [21:50:12] spagewmf: http://gruntjs.com/configuring-tasks#files [21:50:15] spagewmf: Clearly I should get my client to ping me on 'gruntmeisters'. :-) [21:50:38] see minimatch for how exclude patterns, it's similar to bash globstar's use of ! [21:51:04] Krinkle: well, modules/new/vendor passes jshint, but I guess I could get the list of files right for jshint and then jscs's "src: '<%= jshint.all %>'," will pick up the same set. Thanks [21:51:42] spagewmf: Yep, and then you can tack on a [ ..., '!modules/new/vendor/**' ] for things that should pass jshint, but not jscs [21:51:48] or something like that [21:52:07] James_F: I mentioned oojs on a Romanian credit card darknet, where the heck were you :) [21:52:16] spagewmf: :-D [21:52:28] spagewmf: I don't frequent darknet sites much, sorry old bean. [22:04:51] (03CR) 10Krinkle: "'Executed 192 of 0'. Maybe update karma-qunit/qunitjs/karma-launcher-* first to a later version just to be safe and consistent." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166140 (owner: 10Jforrester) [22:15:28] more network issues :( [22:15:39] sigh, edsanders is gone now [22:16:38] (03PS1) 10Alex Monk: Revert "Try to stop user from tabbing outside of open dialog box" [oojs/ui] - 10https://gerrit.wikimedia.org/r/166146 [22:16:42] (03CR) 10jenkins-bot: [V: 04-1] Revert "Try to stop user from tabbing outside of open dialog box" [oojs/ui] - 10https://gerrit.wikimedia.org/r/166146 (owner: 10Alex Monk) [22:19:28] (03PS2) 10Alex Monk: Revert "Try to stop user from tabbing outside of open dialog box" [oojs/ui] - 10https://gerrit.wikimedia.org/r/166146 [22:28:05] Krinkle: thanks, that worked. Do gruntmesiters just leave `grunt watch` running in a terminal window, or is there a slicker way to see its results? [22:28:42] spagewmf: I personally rarely use grunt watch. Every now and again I'll be in a close iteration session where I do use it. [22:29:09] Usually I just work (test first or not), and run grunt test in the command line whenever I get closer to a commit or when something is up. [22:29:27] I only need it for unit testsing, not for coding style like jshint because I have that inside hte editor before I even press save [22:30:30] spagewmf: http://i.imgur.com/JqqFyF7.png [22:30:32] Krinkle: thanks. One other question is should I put grunt test into Flow's pre-commit hook, which currently shells out to run jshint, etc. [22:30:44] spagewmf: Yep, that makes sense. [22:31:07] spagewmf: How do you currently ensure jshint exists in the precommit hook? Are people expected to run npm install first? Do you run it from global or from ./node_modules ? [22:33:23] Krinkle: IIRC jdlrobson set us up with `make installhooks` and `make nodecheck`, https://github.com/wikimedia/mediawiki-extensions-Flow/blob/master/Makefile . I'll share my Gruntfile with him [22:47:18] eh what is up here [23:16:59] Krenair: Hmm re https://gerrit.wikimedia.org/r/166146 :-( [23:29:40] (03PS1) 10Jforrester: build: Update qunitjs from 1.14.0 to 1.15.0 and related changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166154 [23:31:07] (03CR) 10jenkins-bot: [V: 04-1] build: Update qunitjs from 1.14.0 to 1.15.0 and related changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166154 (owner: 10Jforrester) [23:31:16] Whut? [23:31:38] Oh, just the usual. [23:32:01] (03CR) 10Jforrester: "Done in Ia0ec7b8." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166140 (owner: 10Jforrester) [23:36:07] (03PS1) 10Alex Monk: Replace calls to OO.ui.bind( fn, ... ) with fn.bind( ... ) [oojs/ui] - 10https://gerrit.wikimedia.org/r/166155 (https://bugzilla.wikimedia.org/62762) [23:43:10] (03CR) 10Alex Monk: [C: 032] MWCategoryWidget: Use TextInputWidget#event-enter instead of keypress [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166135 (owner: 10Krinkle) [23:44:25] (03PS2) 10Jforrester: build: Test with Chrom{e|ium}, not PhantomJS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166140 [23:44:39] (03Merged) 10jenkins-bot: MWCategoryWidget: Use TextInputWidget#event-enter instead of keypress [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166135 (owner: 10Krinkle) [23:45:14] (03PS3) 10Jforrester: build: Test with Chrom{e|ium}, not PhantomJS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166140 [23:46:37] (03CR) 10Jforrester: "PS2 is a rebase onto Ia0ec7b8." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166140 (owner: 10Jforrester) [23:53:39] (03CR) 10Krinkle: [C: 032] build: Test with Chrom{e|ium}, not PhantomJS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166140 (owner: 10Jforrester) [23:53:44] (03CR) 10Krinkle: [C: 032] build: Update qunitjs from 1.14.0 to 1.15.0 and related changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166154 (owner: 10Jforrester) [23:55:21] (03CR) 10jenkins-bot: [V: 04-1] build: Update qunitjs from 1.14.0 to 1.15.0 and related changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166154 (owner: 10Jforrester) [23:55:23] (03CR) 10jenkins-bot: [V: 04-1] build: Test with Chrom{e|ium}, not PhantomJS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166140 (owner: 10Jforrester) [23:56:04] (03CR) 10Krinkle: [C: 032] build: Update qunitjs from 1.14.0 to 1.15.0 and related changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166154 (owner: 10Jforrester) [23:57:15] (03CR) 10Jforrester: [C: 032] Revert "Try to stop user from tabbing outside of open dialog box" [oojs/ui] - 10https://gerrit.wikimedia.org/r/166146 (owner: 10Alex Monk) [23:57:41] (03CR) 10jenkins-bot: [V: 04-1] build: Update qunitjs from 1.14.0 to 1.15.0 and related changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166154 (owner: 10Jforrester) [23:57:43] (03CR) 10jenkins-bot: [V: 04-1] build: Test with Chrom{e|ium}, not PhantomJS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166140 (owner: 10Jforrester) [23:58:33] (03CR) 10Krinkle: [C: 032] "If at first you don't succeed,: Try, try, try again" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166154 (owner: 10Jforrester) [23:58:44] Krinkle: :-)