[00:00:36] (03CR) 10jenkins-bot: [V: 04-1] build: Update qunitjs from 1.14.0 to 1.15.0 and related changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166154 (owner: 10Jforrester) [00:00:38] (03CR) 10jenkins-bot: [V: 04-1] build: Test with Chrom{e|ium}, not PhantomJS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166140 (owner: 10Jforrester) [00:00:51] (03CR) 10Krinkle: [C: 032] "Insanity is doing the same thing, over and over again, but expecting different results." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166154 (owner: 10Jforrester) [00:00:59] :) [00:01:09] (03Merged) 10jenkins-bot: Revert "Try to stop user from tabbing outside of open dialog box" [oojs/ui] - 10https://gerrit.wikimedia.org/r/166146 (owner: 10Alex Monk) [00:02:26] (03CR) 10jenkins-bot: [V: 04-1] build: Update qunitjs from 1.14.0 to 1.15.0 and related changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166154 (owner: 10Jforrester) [00:02:28] (03CR) 10jenkins-bot: [V: 04-1] build: Test with Chrom{e|ium}, not PhantomJS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166140 (owner: 10Jforrester) [00:02:43] Krinkle: Want to manually clear the cache on the server and run it? [00:02:52] This isn't that bug [00:02:57] that was a git submodule bug [00:03:10] Oh. [00:03:22] Unless you found in the past that helps, I'll believe anything. [00:03:36] I don't have integration access, so I haven't found anything. [00:03:46] I'm just the Timo-cargo-cultist at this point. :-) [00:03:50] Should I squash the changes together so it can work? [00:03:51] (03CR) 10Krinkle: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166154 (owner: 10Jforrester) [00:04:08] (03CR) 10Krinkle: [C: 032] "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166140 (owner: 10Jforrester) [00:04:14] (03CR) 10Krinkle: [C: 032] build: Update qunitjs from 1.14.0 to 1.15.0 and related changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166154 (owner: 10Jforrester) [00:04:27] it should go into a differnet build directory now. [00:04:35] which is equiv of clearing the cache, but without ssh :P [00:04:39] Ha. [00:04:55] paralel forces it to create workspace@2 [00:05:01] Ah, interesting. [00:05:45] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (d6e7af8010) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166159 [00:05:54] (03CR) 10jenkins-bot: [V: 04-1] build: Update qunitjs from 1.14.0 to 1.15.0 and related changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166154 (owner: 10Jforrester) [00:06:01] (03CR) 10jenkins-bot: [V: 04-1] build: Test with Chrom{e|ium}, not PhantomJS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166140 (owner: 10Jforrester) [00:06:23] Krenair: Merge on the two of https://gerrit.wikimedia.org/r/#/q/I63d51311f73d1295a2a35ebadf7d9ac835dec5c7,n,z you can merge? [00:15:12] (03PS2) 10Krinkle: build: Update karma and switch from PhantomJS to Chrome [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166154 (owner: 10Jforrester) [00:15:28] (03CR) 10Krinkle: [C: 032] "Cheating." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166154 (owner: 10Jforrester) [00:15:40] (03Abandoned) 10Krinkle: build: Test with Chrom{e|ium}, not PhantomJS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166140 (owner: 10Jforrester) [00:17:33] (03Merged) 10jenkins-bot: build: Update karma and switch from PhantomJS to Chrome [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166154 (owner: 10Jforrester) [00:19:20] (03PS3) 10Krinkle: WIP failing converter tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114355 (owner: 10Esanders) [00:19:36] (03PS2) 10Krinkle: Update OOjs UI to v0.1.0-pre (d6e7af8010) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166159 (owner: 10Jforrester) [00:21:31] (03CR) 10jenkins-bot: [V: 04-1] WIP failing converter tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114355 (owner: 10Esanders) [00:54:52] (03PS1) 10Krinkle: build: Remove 'repository' and 'licenses' key from package.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166161 [00:55:13] (03CR) 10Krinkle: "Similar to the package.json in mediawiki-core." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166161 (owner: 10Krinkle) [00:59:37] (03PS2) 10Krinkle: build: Remove 'repository' and 'licenses' key from package.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166161 [01:00:11] (03CR) 10Jforrester: [C: 032] build: Remove 'repository' and 'licenses' key from package.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166161 (owner: 10Krinkle) [01:01:08] Krinkle: Could you +2 https://gerrit.wikimedia.org/r/#/q/I63d51311f73d1295a2a35ebadf7d9ac835dec5c7,n,z whilst you're at it? [01:01:25] Krinkle: Only substantive change is a revert we're going to put out in the SWAT. [01:01:42] (03Merged) 10jenkins-bot: build: Remove 'repository' and 'licenses' key from package.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166161 (owner: 10Krinkle) [01:02:18] James_F: only code change is https://gerrit.wikimedia.org/r/#/c/165907/ [01:02:25] which is interesting. It doesn't say why it's added. [01:02:48] it doens't do anything by default [01:02:55] was it arleady used and broken and this fixes it? [01:02:59] Hmm. [01:03:03] No, sorry, that's odd. [01:03:05] or is it just a new feature for users to start using [01:03:26] That's just a new feature. [01:03:35] The revert didn't make it to the pull-through somehow. [01:04:07] * James_F tries again. [01:07:10] (03PS3) 10Jforrester: Update OOjs UI to v0.1.0-pre (837b2f733e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166159 [01:08:08] Krinkle: Better now? [01:08:27] Krinkle: Only real code change is https://gerrit.wikimedia.org/r/#/q/837b2f7,n,z [01:11:44] (03CR) 10Krinkle: [C: 032] Update OOjs UI to v0.1.0-pre (837b2f733e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166159 (owner: 10Jforrester) [01:11:47] (03CR) 10Krinkle: Try to stop user from tabbing outside of open dialog box (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/159902 (https://bugzilla.wikimedia.org/67156) (owner: 10Alex Monk) [01:12:12] Krinkle: Thanks. :-) [01:12:28] James_F: not merging wmf/ right now [01:12:42] Krinkle: Yeah, please don't. It's in the SWAT for Tuesday morning. [01:12:47] :) [01:13:14] Undeployed merges to MW-core wmf* considered harmful. :-) [01:13:31] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (837b2f733e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166159 (owner: 10Jforrester) [01:22:53] (03PS1) 10Krinkle: build: Remove stray '*' before '/**' in csslint file pattern [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166165 [01:24:08] (03CR) 10Jforrester: [C: 032] build: Remove stray '*' before '/**' in csslint file pattern [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166165 (owner: 10Krinkle) [01:25:38] (03Merged) 10jenkins-bot: build: Remove stray '*' before '/**' in csslint file pattern [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166165 (owner: 10Krinkle) [01:33:45] (03PS2) 10Jforrester: Update VE core submodule to master (d172dcc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166057 [01:35:25] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (d172dcc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166057 (owner: 10Jforrester) [10:57:03] (03PS39) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [13:28:45] (03PS1) 10Divec: WIP: Refactor SurfaceObserver pollOnceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 [13:30:31] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor SurfaceObserver pollOnceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 (owner: 10Divec) [14:06:41] (03PS2) 10Divec: WIP: Refactor SurfaceObserver pollOnceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 [14:08:26] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor SurfaceObserver pollOnceInternal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166188 (owner: 10Divec) [14:24:29] (03PS2) 10Bartosz Dziewoński: [WIP] OoUiGroupElement, OoUiButtonGroupWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/166082 [14:24:31] (03PS2) 10Bartosz Dziewoński: [WIP] OoUiTitledElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/166081 [14:24:33] (03PS11) 10Bartosz Dziewoński: [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [14:24:35] (03PS1) 10Bartosz Dziewoński: [WIP] OoUiFieldLayout, OoUiFieldsetLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/166191 [14:32:02] (03CR) 10Bartosz Dziewoński: [WIP] PHP Implementation of OOjs UI (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [14:33:20] (03PS12) 10Bartosz Dziewoński: [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [16:40:21] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108130633 [16:40:21] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108131785 [16:40:21] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108132338 [16:40:21] Corruption alert: visualeditor-needcheck on huwiki: https://hu.wikipedia.org/?diff=15204056 [16:51:05] (03PS1) 10Bartosz Dziewoński: Element: Correct method name reference [oojs/ui] - 10https://gerrit.wikimedia.org/r/166199 [17:09:07] Oh no :( [17:09:38] The second and third frwiki entries show myEventWatcherDiv [18:32:51] (03PS2) 10Bartosz Dziewoński: [WIP] Layouts: Field, Fieldset, Form, Panel, Grid [oojs/ui] - 10https://gerrit.wikimedia.org/r/166191 [18:32:53] (03PS3) 10Bartosz Dziewoński: [WIP] OoUiGroupElement, OoUiButtonGroupWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/166082 [18:32:55] (03PS3) 10Bartosz Dziewoński: [WIP] OoUiTitledElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/166081 [18:32:57] (03PS13) 10Bartosz Dziewoński: [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [18:39:16] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Layouts: Field, Fieldset, Form, Panel, Grid [oojs/ui] - 10https://gerrit.wikimedia.org/r/166191 (owner: 10Bartosz Dziewoński) [18:52:07] (03PS5) 10Esanders: WIP non-native table handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164616 [18:52:10] (03CR) 10jenkins-bot: [V: 04-1] WIP non-native table handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164616 (owner: 10Esanders) [19:02:44] (03PS6) 10Esanders: WIP non-native table handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164616 [19:02:45] (03CR) 10jenkins-bot: [V: 04-1] WIP non-native table handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164616 (owner: 10Esanders) [19:14:48] (03PS19) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [19:14:50] (03PS21) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [19:14:52] (03PS7) 10Esanders: WIP non-native table handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164616 [19:14:54] (03PS22) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [19:14:56] (03PS23) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [19:16:08] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [19:18:14] (03CR) 10jenkins-bot: [V: 04-1] WIP non-native table handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164616 (owner: 10Esanders) [19:32:32] (03PS1) 10Bartosz Dziewoński: ButtonWidget: Fix titled button [oojs/ui] - 10https://gerrit.wikimedia.org/r/166214 [19:41:37] (03PS1) 10Esanders: Remove unicorn debug styling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166215 [19:50:07] (03CR) 10Legoktm: [WIP] PHP Implementation of OOjs UI (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [23:34:15] 3VisualEditor: file permissions cause lintian warnings - 10https://bugzilla.wikimedia.org/71933#c1 (10Byfserag) https://bugzilla.wikimedia.org/show_bug.cgi?id=71928 https://bugzilla.wikimedia.org/show_bug.cgi?id=71930 https://bugzilla.wikimedia.org/show_bug.cgi?id=71931 https://bugzilla.wikimedia.org/show_b... [23:34:32] (03PS40) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [23:44:32] 3VisualEditor / 3Editing Tools: copying formatted text from one VE edit session to another removes spaced before linked text - 10https://bugzilla.wikimedia.org/71968 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None copying text from https://en.wikipedia.org/wiki/Treaty_of_Fort_Laramie_(1868... [23:48:17] 3VisualEditor: Editing parameters of a multiref template within a reference is not recognised as a change to the reference - 10https://bugzilla.wikimedia.org/71969 (10Spinningspark) 3NEW p:3Unprio s:3normal a:3None Intention: I was trying to amend the contents of a {{multiref}} template in en.wp Steps...