[02:01:59] <grrrit-wm>	 (03PS1) 10Alex Monk: Sort out some odd file permissions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166275 (https://bugzilla.wikimedia.org/71933) 
[02:03:02] <wikibugs>	 3VisualEditor: file permissions cause lintian warnings - 10https://bugzilla.wikimedia.org/71933 (10Alex Monk) a:3Alex Monk
[02:23:20] <grrrit-wm>	 (03PS5) 10Mooeypoo: [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 
[02:24:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (owner: 10Mooeypoo)
[02:29:16] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Sort out some odd file permissions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166275 (https://bugzilla.wikimedia.org/71933) (owner: 10Alex Monk)
[02:30:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Sort out some odd file permissions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166275 (https://bugzilla.wikimedia.org/71933) (owner: 10Alex Monk)
[02:37:45] <wikibugs>	 3VisualEditor: file permissions cause lintian warnings - 10https://bugzilla.wikimedia.org/71933 (10Alex Monk) 5PATC>3RESO/FIX
[02:37:52] <mooey|away>	 Krenair, are you awake/around by any chance?
[02:38:23] <Krenair>	 yeah, still :/
[02:38:47] <mooey|away>	 heh
[02:39:14] <mooey|away>	 go to sleep! :P but if you're not, I could use a verify on a bug if you have a second
[02:39:26] <Krenair>	 ok
[02:39:37] <mooey|away>	 Can you quickly open the categories dialog and click on the main category arrow down?
[02:39:45] <mooey|away>	 the popup appears waaaaay to the left for me
[02:39:56] <mooey|away>	 want to verify it's not some local fluke, I've had a bit of an issue updating ve today
[02:40:16] <mooey|away>	 I also switched rtl/ltr a bunch of times, so I just want sanity check 
[02:40:37] <mooey|away>	 heya James_F 
[02:42:11] <James_F>	 Hey mooey|away.
[02:42:15] <James_F>	 mooey|away: Krinkle|detached reported that bug (categories being off to the left) on Friday.
[02:42:44] <mooey|away>	 oh okay, so I'm not crazy
[02:42:55] <Krenair>	 mooey|away, yeah, I see the issue
[02:43:04] <mooey|away>	 I changed my setup from rtl to rtl so many times (ui and core and ui again) i wanted to verify it wasn't some fluke error
[02:43:07] * mooey|away is trying to fix
[02:43:16] * James_F nods.
[02:43:23] <mooey|away>	 it seems we've changed the context popups to be outside the scope of the iframe 
[02:43:32] <mooey|away>	 we're not taking into account the position of the window, I think.
[02:43:56] <Krenair>	 I wonder if this is related to the overlay change.
[02:44:02] <mooey|away>	 hehe and I keep automatically opening the media dialog instead of the category dialog on each refresh
[02:44:02] <James_F>	 Probably.
[02:44:14] * mooey|away curses muscle memory
[02:44:27] * James_F grins.
[02:44:59] <mooey|away>	 also, James_F, templatedata dialog is ooui'ed.
[02:45:09] <mooey|away>	 Not working yet, but the dialog is *opening*. 
[02:45:10] <James_F>	 Oooh.
[02:45:13] <James_F>	 Nice.
[02:45:16] * mooey|away will post the WIP soon
[02:45:21] * James_F nods.
[02:45:32] <mooey|away>	 I'm using it to unwind after uber-packing sessions with my mom
[02:46:11] <mooey|away>	 So now it opens and says hello, which is a great way to test all dialogs.
[02:46:13] <mooey|away>	 :D
[02:46:21] <James_F>	 :-)
[02:46:44] <mooey|away>	 actually, i wanted to ask you. Don't we already have *something* working with drag/drop or am I misremembering?
[02:46:56] <mooey|away>	 I could have sworn we had some widget that could move. Not sure, though. 
[02:47:13] <James_F>	 Well, selections.
[02:47:17] <James_F>	 But they aren't widgets.
[02:47:29] <James_F>	 FocussableNodes.
[02:48:39] <mooey|away>	 hmmm.
[02:48:56] <Krenair>	 yeah, confirmed the category popup issue you found is caused by https://gerrit.wikimedia.org/r/#/c/164361/
[02:49:15] <mooey|away>	 Krenair, yea that makes sense
[02:49:24] <mooey|away>	 the position is relative to the main window rather than the frame, it seems
[03:04:07] <mooey|away>	 hm, this is a bit of a mess, actually. The sizing/positioning code is run from inside the iframe, which doesn't seem to recognize the fact that it's in the scope of a larger window.
[03:04:31] <mooey|away>	 We might need to send some iframe details to that popup if it's an iframe sibling now.
[03:06:26] <mooey|away>	 okay. Forget everything I just said.
[03:06:28] * mooey|away solved for LTR
[03:06:32] * mooey|away is testing for RTL now
[03:12:40] <mooey|away>	 oh my.
[03:12:52] <mooey|away>	 James_F, did we change the way we detect RTL lately?
[03:13:15] <James_F>	 mooey|away: Yeah. legoktm[SJS] I think did something and RoanKattouw_away merged it.
[03:13:21] <mooey|away>	 That method didn't even detect rtl properly. Fixing that too now, but that seems odd to be the product of the same fix
[03:13:21] <mooey|away>	 ah.
[03:13:38] <mooey|away>	 Okay, I'm fixing it now, but with a solution ed didn't like in the past
[03:13:50] <legoktm[SJS]>	 oh, what did I change?
[03:14:07] <mooey|away>	 this.$container.attr( 'dir' ) is what it was, and that was 'undefined' so it was always positioning for ltr even when it was RTL
[03:14:12] <mooey|away>	 I'm changing that check to this.$container.css( 'direction' )
[03:14:17] <legoktm[SJS]>	 I didn't do anything RTL related recently...
[03:14:17] <mooey|away>	 which is inherited
[03:14:33] <James_F>	 legoktm[SJS]: Maybe it wasn't you.
[03:15:28] <James_F>	 Someone changed something.
[03:15:44] <mooey|away>	 either way, ed will have to deal with this change, or find a better way to call for the frame attributes properly. I used to have this.frame.getDir() which I can't manage to call from the widget
[03:15:56] <mooey|away>	 But this should work
[03:16:13] <mooey|away>	 if I can manage to get the *math* right. Mirroring, pfft.
[03:16:58] <James_F>	 Ah, yes, it was Bartosz, sorry lego. Remember that someone other than mooey|away had done it: https://gerrit.wikimedia.org/r/#/c/164783/
[03:17:06] <legoktm[SJS]>	 :P
[03:17:09] <James_F>	 Not sure if that caused a breakage?
[03:17:24] <James_F>	 legoktm[SJS]: Sorry.
[03:17:37] <mooey|away>	 hmm.
[03:17:45] <mooey|away>	 something's weird in general with the .attr( 'dir' ) test
[03:18:03] <mooey|away>	 I wonder if we had RTL errors in the past with this too, before the change that caused the LTR error.
[03:18:13] <mooey|away>	 that shouldn't have worked; there is no attribute for that element.
[03:19:14] * James_F nods.
[03:26:14] <mooey|away>	 James_F, okay, I'm about to send this to gerrit, I can't find krinkle's bug
[03:26:18] <mooey|away>	 do you have the bug number handy?
[03:26:26] <James_F>	 mooey|away: Not here, sorry.
[03:26:30] * mooey|away nods
[03:26:35] <James_F>	 mooey|away: I can tag it tomorrow, don't worry.
[03:26:50] <mooey|away>	 awesomesauce. Yeah, I looked through the bug reports and I can't immediately spot it
[03:44:35] <grrrit-wm>	 (03PS1) 10Mooeypoo: Correctly place CategoryPopupWidget in LTR and RTL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166279 
[03:45:10] <mooey|away>	 this also looks iffy, btw this.$.$iframe
[03:45:14] <mooey|away>	 didn't we get rid of this.$
[16:30:32] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13454113
[16:30:32] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13454117
[16:30:32] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108161519
[16:30:32] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108162640
[16:30:32] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on cawiki: https://ca.wikipedia.org/?diff=14132464
[16:30:33] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40267021
[17:27:31] <grrrit-wm>	 (03PS1) 10Esanders: Fix icon opacity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166292 
[17:27:54] <grrrit-wm>	 (03PS1) 10Esanders: Fix icon opacity [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166293