[00:01:00] <RoanKattouw>	 Maybe I'll put the inner overlay stuff in as a quick fix
[00:01:07] <RoanKattouw>	 And then take more time to do it properly
[00:02:50] <grrrit-wm>	 (03PS1) 10Catrope: Introduce oo-ui-window-inner-overlay [oojs/ui] - 10https://gerrit.wikimedia.org/r/166700 
[00:04:48] <grrrit-wm>	 (03PS1) 10Catrope: Put category popups in the inner overlay for now [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166701 (https://bugzilla.wikimedia.org/72052) 
[00:08:55] <grrrit-wm>	 (03PS22) 10Jforrester: Use a single unicorn-like <img> instead of &#xFEFF; in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope)
[00:09:11] <grrrit-wm>	 (03Abandoned) 10Jforrester: Don't rebuild entire paragraph when inserting text in slug location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164963 (owner: 10Catrope)
[00:13:08] <RoanKattouw>	 TrevorParscal: https://gerrit.wikimedia.org/r/166700 https://gerrit.wikimedia.org/r/166701
[00:15:47] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Introduce oo-ui-window-inner-overlay [oojs/ui] - 10https://gerrit.wikimedia.org/r/166700 (owner: 10Catrope)
[00:15:52] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Put category popups in the inner overlay for now [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166701 (https://bugzilla.wikimedia.org/72052) (owner: 10Catrope)
[00:17:14] <RoanKattouw>	 Thanks Trevor
[00:17:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Put category popups in the inner overlay for now [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166701 (https://bugzilla.wikimedia.org/72052) (owner: 10Catrope)
[00:18:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Introduce oo-ui-window-inner-overlay [oojs/ui] - 10https://gerrit.wikimedia.org/r/166700 (owner: 10Catrope)
[00:38:26] <grrrit-wm>	 (03PS5) 10Krinkle: Link dialog: do basic URI validation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/141367 (https://bugzilla.wikimedia.org/28789) (owner: 10TheDJ)
[00:40:15] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (d74a46ca6a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166706 
[00:41:06] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (d74a46ca6a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166706 (owner: 10Jforrester)
[00:42:40] <grrrit-wm>	 (03PS1) 10Jforrester: Put category popups in the inner overlay for now [extensions/VisualEditor] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/166709 (https://bugzilla.wikimedia.org/72052) 
[00:42:59] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Put category popups in the inner overlay for now [extensions/VisualEditor] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/166709 (https://bugzilla.wikimedia.org/72052) (owner: 10Jforrester)
[00:43:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (d74a46ca6a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166706 (owner: 10Jforrester)
[00:44:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Put category popups in the inner overlay for now [extensions/VisualEditor] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/166709 (https://bugzilla.wikimedia.org/72052) (owner: 10Jforrester)
[00:44:38] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] The context menus for Categories are appearing in an incorrect position and also not closing - 10https://bugzilla.wikimedia.org/72052#c5 (10James Forrester) 5PATC>3RESO/FIX a:5Moriel Schottlender>3Roan Kattouw SWATting in the morning.
[00:48:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Put category popups in the inner overlay for now [extensions/VisualEditor] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/166709 (https://bugzilla.wikimedia.org/72052) (owner: 10Jforrester)
[01:04:40] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Suggest case insensitive results when searching for categories to add - 10https://bugzilla.wikimedia.org/57302 (10James Forrester) a:3Alex Monk
[12:27:48] <grrrit-wm1>	 (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166539 (owner: 10Esanders)
[12:29:14] <grrrit-wm1>	 (03PS25) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[12:29:16] <grrrit-wm1>	 (03PS27) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[12:29:18] <grrrit-wm1>	 (03PS30) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[12:29:28] <grrrit-wm1>	 (03PS2) 10Esanders: Bring in MobileContext hack from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165992 
[12:37:05] <grrrit-wm1>	 (03PS3) 10Esanders: Bring in MobileContext hack from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165992 
[12:38:06] <grrrit-wm1>	 (03PS2) 10Esanders: Fix paste by never polling while pasting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166539 
[12:45:33] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Bring in MobileContext hack from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165992 (owner: 10Esanders)
[12:45:46] <grrrit-wm1>	 (03PS2) 10Esanders: Delete Minerva theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/165741 
[12:48:03] <grrrit-wm1>	 (03Abandoned) 10Esanders: WIP non-native table handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164616 (owner: 10Esanders)
[12:51:20] <grrrit-wm1>	 (03PS1) 10Esanders: Fix theme on mobile-dist [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166737 
[15:16:52] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] "Uncaught TypeError: undefined is not a function", when using media search dialog - 10https://bugzilla.wikimedia.org/70860#c2 (10Moriel Schottlender) This is a problem with the API in general, and while it is throwing an error, it shouldn't act...
[15:17:30] <mooeypoo>	 James_F, this is waht Krenair said was not an error-error but a notice-error. Do we close this? As far as I can tell, this is doing nothing other than throwing an annoying error in the console. Everything system/code-wise is still usable.
[15:17:58] <Krenair>	 Was this that uselang-related thing?
[15:18:00] <mooeypoo>	 And I don't know how to suppress that warning, it's coming from api.php response
[15:18:01] <mooeypoo>	 aye
[15:18:04] <James_F>	 Krenair: Yes.
[15:18:05] <Krenair>	 Core shouldn't complain about that anymore.
[15:18:08] <Krenair>	 Pull the latest version.
[15:18:10] <mooeypoo>	 oh
[15:18:12] <James_F>	 Which is fixed as of wmf4.
[15:18:14] <mooeypoo>	 ha
[15:18:20] <James_F>	 So will mark as fixed. :-)
[15:18:21] * mooeypoo updates core
[15:19:07] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] "Uncaught TypeError: undefined is not a function", when using media search dialog - 10https://bugzilla.wikimedia.org/70860#c3 (10James Forrester) 5ASSI>3RESO/FIX This was fixed in MediaWiki core as of wmf4 (to be released tomorrow to MediaW...
[15:19:09] <wikibugs>	 3VisualEditor: Stop putting categories in the middle of the page - 10https://bugzilla.wikimedia.org/72048#c4 (10ssastry) a:5Parsoid Team>3None On irc, Roan thinks this is a VE/data-corruption bug. Re-assigning.
[15:19:34] <grrrit-wm1>	 (03PS1) 10Divec: Polyfill Set for PhantomJS (for debug only) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166753 
[15:19:52] <James_F>	 Hmmmmmmm.
[15:19:54] <mooeypoo>	 hm. I'm still getting it
[15:19:57] <James_F>	 Nasty bug.
[15:20:15] <James_F>	 Categories not showing up.
[15:20:15] <James_F>	 Trying to work out why
[15:20:30] <Krenair>	 mooeypoo, still getting the warning? or the error from VE code?
[15:20:44] <mooeypoo>	 Krenair, I just pulled core and refreshed and i'm still getting "Uncaught TypeError: undefined is not a function" with api.php
[15:21:05] <mooeypoo>	 "Unrecognized parameter": "uselang"
[15:21:08] <James_F>	 Krenair: Edit https://www.mediawiki.org/w/index.php?title=VisualEditor&veaction=edit and go to categories – none of the categories show up. Any ideas?
[15:21:20] <RoanKattouw>	 mooeypoo: What makes you think the two are related?
[15:21:27] <RoanKattouw>	 undefined is not a function can occur for canceled JSONP requests
[15:21:35] <RoanKattouw>	 Unrecognized param uselang is a harmless warning
[15:21:51] <Krenair>	 James_F, Uncaught TypeError: Cannot read property 'hidden' of undefined
[15:21:59] <Krenair>	 uh oh.
[15:22:29] <mooeypoo>	 RoanKattouw, when i go into the api.php error it says "Unrecognized parameter: uselang"
[15:22:37] <RoanKattouw>	 OK, yeah
[15:22:43] <mooeypoo>	 :\
[15:22:46] <RoanKattouw>	 But all of our API responses say that, including the successful ones
[15:23:03] <mooeypoo>	 I mean, it's not really affecting anything, it seems, it's just annoying. But it's still popping up
[15:24:01] <mooeypoo>	 hm. RoanKattouw I'm not sure how to debug this, then? It happens all the time when you search for images
[15:24:09] <RoanKattouw>	 It's a known jQuery problem
[15:24:12] <RoanKattouw>	 I'm responding on the bug
[15:24:21] <mooeypoo>	 oh , awesome
[15:24:23] <mooeypoo>	 thanks!
[15:25:08] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf21] "Uncaught TypeError: undefined is not a function", when using media search dialog - 10https://bugzilla.wikimedia.org/70860#c4 (10Roan Kattouw) 5RESO/FIX>3RESO/WON (In reply to James Forrester from comment #3) > This was fixed in MediaWiki c...
[15:25:26] <RoanKattouw>	 mooeypoo: I don't know if I've explained this to you before, but basically the media dialog uses JSONP requests and canceling those is an interesting problem
[15:25:42] <RoanKattouw>	 I remember Trevor first explaining this to me when we were randomly having dinner in Portland last summer
[15:26:24] <mooeypoo>	 oh, we are canceling them a lot, actually. We're sending a new request on every keystroke, basically, and cancelling the previous one
[15:26:32] <mooeypoo>	 but then, why would this only appear once and not a bazillion times?
[15:26:35] <RoanKattouw>	 JSONP requests work by injecting <script src="api.php?callback=foo&....."> into the DOM, and then having api.php cooperate by outpiutting foo({data: 'goes here'});
[15:26:58] <RoanKattouw>	 So then you just need to define a global function called foo() and it'll be called once the data arrives
[15:27:27] <RoanKattouw>	 In practice, 'foo' would instead be jQuery234643523423524354
[15:27:27] <RoanKattouw>	 with a different number for every request, because you can have more than one of them going on at once
[15:27:43] <RoanKattouw>	 The problem is, this isn't really cancelable
[15:27:44] <mooeypoo>	 and they're mostly anonymous functions, right?
[15:27:54] <RoanKattouw>	 Once you've added the <script> tag, the URL will be loaded and the code calling foo() will execute no matter what you do
[15:28:05] <RoanKattouw>	 No they have to be global functions because they have to be visible from that script tag
[15:28:14] <mooeypoo>	 oh
[15:28:32] <mooeypoo>	 wait, but we go somethign like $.getJSON( ... ).done( function () { ... } );
[15:28:37] <RoanKattouw>	 So jQuery will do something like window.jQuery123 = function ( data ) { do stuff with data }; insertScriptTag('api.php?callback=jQuery123&...' );
[15:28:41] <Krenair>	 James_F, weird. I'm not getting the same thing on my wiki
[15:28:53] <James_F>	 Krenair: Using wmf3 or master?
[15:28:56] <Krenair>	 master
[15:28:59] <RoanKattouw>	 Yeah so the window.jQuery123 function will then resolve the promise and call your anonymous function
[15:29:00] <James_F>	 Krenair: Try with wmf3?
[15:29:03] * mooeypoo nods
[15:29:05] <James_F>	 Krenair: Did we fix it?
[15:29:08] <RoanKattouw>	 In any case, as I said, this isn't cancelable, once you fire it off you're committed
[15:29:22] <mooeypoo>	 RoanKattouw, interesting, so wait, jquery does let you cancel the request, though. (Apparently not?)
[15:29:23] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression ?wmf3] Hidden categories cause "Uncaught TypeError: Cannot read property 'hidden' of undefined" to be thrown - 10https://bugzilla.wikimedia.org/72080 (10James Forrester) p:5Unprio>3Normal
[15:29:24] <RoanKattouw>	 So what jQuery does when you .abort() the request, is it does window.jQuery123 = undefined;
[15:29:28] <mooeypoo>	 oh
[15:29:37] <RoanKattouw>	 (or delete window.jQuery123; or what have you)
[15:29:52] <RoanKattouw>	 So you see how this is simultaneously very effective and very horrible)
[15:29:58] <mooeypoo>	 ha
[15:30:27] <mooeypoo>	 wouldn't it have been easier to replace the above with an empty returning function?
[15:30:34] <RoanKattouw>	 That's what I think they should do
[15:30:47] <mooeypoo>	 window.jQuery123123 = function ( ) { return null; }
[15:30:48] <Krenair>	 James_F, doesn't seem to occur on wmf3 either... hmm
[15:30:49] <mooeypoo>	 or something
[15:30:52] <RoanKattouw>	 Or replace it with a function that deletes itself
[15:30:55] <mooeypoo>	 then it should be invisible
[15:31:00] <mooeypoo>	 or -- yeah. that
[15:31:10] <RoanKattouw>	 (these functions, if you don't abort, also delete themselves after they run)
[15:31:31] <mooeypoo>	 oh, so then returning null or false or something will also probably solve this
[15:31:31] <James_F>	 Krenair: Odd.
[15:32:05] <RoanKattouw>	 I think there was some reason that they didn't want to do it, maybe to do with how there is some sort of risk that the function will stick around forever and never get cleaned up, but I forget the details
[15:32:34] <mooeypoo>	 yeah i was about to ask 
[15:32:51] <mooeypoo>	 you wrote that it won't be resolved upstream.. if the solution seems so relatively simple, i wonder why they don't fix it
[15:33:05] <mooeypoo>	 but yeah
[15:33:11] <mooeypoo>	 interesting. Thanks !
[15:36:02] <mooeypoo>	 RoanKattouw, btw, if I'm already bugging you about bugs in such an early hour -- this is waiting for sub-surfaces, as far as I understand? https://bugzilla.wikimedia.org/show_bug.cgi?id=60919
[15:36:16] <RoanKattouw>	 Subdocuments
[15:36:18] <RoanKattouw>	 Probably
[15:36:19] * RoanKattouw reads bug
[15:36:22] <mooeypoo>	 sub documents, yes, sorry
[15:36:58] <mooeypoo>	 we're not copying the internalList properly?
[15:37:36] <RoanKattouw>	 Yeah that looks like a subdocument problem
[15:37:38] <mooeypoo>	 I was looking at it, and I've ran into a bit of a wall. I can continue researching but if htis is best dealt-with and is going to be resolved with sub documents, I might as well leave it be 'till then, rather than mess things up
[15:37:48] <mooeypoo>	 and make things more complicated for later
[15:37:51] <RoanKattouw>	 I'm hoping I can convince edsanders to work on that next
[15:37:59] <RoanKattouw>	 It looks like tables are getting close
[15:38:21] <mooeypoo>	 Okay, I'll wait with it, then.
[15:39:08] <RoanKattouw>	 I'm entangled in some OOUI stuff right now to do with popup placement
[15:39:23] <RoanKattouw>	 I did the overlay overlay overlay thing but I'm now trying to do it properly
[15:39:38] <RoanKattouw>	 After that, perhaps I'll do subdocuments, depending on where Ed is at
[15:40:51] <mooeypoo>	 overlayoverlay is a nice title, but that logically makes at least one of them an underlay
[15:41:11] <mooeypoo>	 so, you should overlay the aunderlay overlay fix on top of the current code.
[15:41:14] <mooeypoo>	 Or... something.
[15:41:17] <mooeypoo>	 :D
[15:41:46] <RoanKattouw>	 Yeah I called the branch underlay
[15:41:53] <RoanKattouw>	 The actual thing is called oo-ui-window-inner-overlay
[15:42:46] <mooeypoo>	 is there an outer-overlay
[15:42:58] <RoanKattouw>	 Yes but it's just called the overlay
[15:43:02] <James_F>	 RoanKattouw: Tsk, "innerlay".
[15:43:45] <mooeypoo>	 That is so confusing. I ran into a similar confusing thing with the media search dialog; the thumbnails are created with 2 layers and done in jquery, so it's something like $thumb = $back.add( $front );
[15:44:01] <mooeypoo>	 and then the code has references all over the place to this.$thumb.first() and .last()
[15:44:10] <RoanKattouw>	 That sounds horrible
[15:44:11] <mooeypoo>	 which is extremely confusing
[15:44:24] * mooeypoo got rid of that in the new fix
[15:44:28] <RoanKattouw>	 Is this our code or Masonry code?
[15:44:33] <mooeypoo>	 our code
[15:44:45] <RoanKattouw>	 Oh but you fixed it, good
[15:44:55] <mooeypoo>	 i'm not using the masonry library. We'll be able to attach it later if we want, but for now I'll create something at least somewhat fallbacky
[15:45:13] <mooeypoo>	 i have to use images directly, though, no more background-image, because I have to resize them
[15:45:30] <mooeypoo>	 (not that my resizing *works* right now, mind you, but let's not quibble over details) :P
[15:47:36] <mooeypoo>	 You know, the biggest problem with masonry is that most people/code CALL it masonry, but actually cheat their way out of really doing actual masonry by cropping
[15:47:52] <mooeypoo>	 Which is entirely against the point.
[15:49:11] <Krenair>	 'Category:WMF Projects 2011q3' -> true, 'Category:WMF Projects 2011q3‎' -> false
[15:49:12] <Krenair>	 hm
[15:49:26] <grrrit-wm1>	 (03Abandoned) 10Jforrester: Delete Minerva theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/165741 (owner: 10Esanders)
[15:50:28] <James_F>	 Krenair: Odd.
[15:51:22] <Krenair>	 they are different strings
[15:54:35] <Krenair>	 second one has an extra character on the end
[15:54:37] <Krenair>	 e2 80 8e
[15:55:03] <James_F>	 Returned from the API?
[15:55:16] <Krenair>	 This is in the wikitext of the page.
[15:55:22] <James_F>	 Huh.
[15:55:34] <James_F>	 Should I just fix the wikitext?
[15:55:42] <Krenair>	 Well...
[15:55:48] <Krenair>	 VE should be able to handle this. MW can.
[15:55:54] <James_F>	 Or should we trim() the string?
[15:55:56] <Krenair>	 I just wonder WTF MW is doing.
[15:55:59] <James_F>	 Or something odd.
[15:57:32] <Krenair>	 trim() doesn't do it.
[15:59:48] <Krenair>	 Since MW picks up only the visible part of the string
[16:04:13] <mooeypoo>	 RoanKattouw, I've been having a couple of ideas on improving ooui's usage
[16:07:08] <mooeypoo>	 RoanKattouw, TrevorParscal I'm thinking that all "containers" should behave something like Panel/Stack layouts; Instead of having to instantiate an OO.ui.FieldsetLayout object and then do fieldsetLayout.$element.append( fieldlayout.$element, fieldlayout2.$element ) wouldn't it be better having them be something like fieldsetLayout.addFields( fieldLayout1, fieldLayout2 ) hich does the $element appending for the user?
[16:07:18] <mooeypoo>	 the use of .$element.append and such can be confusing
[16:07:49] <RoanKattouw>	 Ideally all containers would be GroupElements
[16:07:53] * mooeypoo nods
[16:08:01] <RoanKattouw>	 FieldsetLayout is one
[16:08:13] <mooeypoo>	 There are a few, but field layout is the most notable one
[16:08:16] <RoanKattouw>	 So you can do fieldsetLayout.addItems( fieldLayout1, fieldLayout2 );
[16:08:26] <RoanKattouw>	 Ahm, maybe wrapped in [ ... ]
[16:08:34] <mooeypoo>	 it is used fairly often, and can be really confusing, especially when you deal with many
[16:09:17] <mooeypoo>	 I think we might want to reduce having to use $element as much as possible outside ooui. Things that are often done should be encapsulated, I think? 
[16:09:28] <mooeypoo>	 for instance, adding a class to the object -- that can be a config option
[16:09:40] <RoanKattouw>	 It already is
[16:09:44] <RoanKattouw>	 But yes you're right
[16:09:52] <mooeypoo>	 we're doing that a lot, and so is the user. Users who aren't used to thinking about .$element can get confused
[16:09:54] <RoanKattouw>	 Reaching into foo.$element where foo !== this is bad
[16:10:08] <mooeypoo>	 oh, are we? I'm seeing this.whateverInput.$element.addClass( ... ) a lot
[16:10:23] <RoanKattouw>	 with the exception of doing $someContainer.append( topLevelWidget.$element );
[16:10:25] <RoanKattouw>	 mooeypoo: Oh yes
[16:10:32] <RoanKattouw>	 Because we didn't have the 'classes' config option before
[16:10:53] <RoanKattouw>	 We've been eliminating excuses to use .$element, but we haven't ported all of the old code yet
[16:10:53] <mooeypoo>	 sure, if you have custom jquery stuff then yes, but whatever uses native ooui stuff should have its own append/addClass/jquery stuff internally, as much as possible
[16:10:59] <mooeypoo>	 oh okay
[16:11:04] <mooeypoo>	 I'll do that in the code I'm touching, then
[16:11:38] <mooeypoo>	 I'm now spinning my wheels on empty over fieldsetlayout that has labels in it (and for some annoying reason doesn't display them right)
[16:11:57] <mooeypoo>	 it's probably me not appending/instantiating right, but the use of $element is making thing smore confusing to debug and follow
[16:15:13] <mooeypoo>	 hmm, FieldsetLayout is already a group element, it's just not appending the group, it seems
[16:16:18] <RoanKattouw>	 No it is
[16:16:21] <RoanKattouw>	 line 32
[16:16:25] <RoanKattouw>	 .prepend( this.$icon, this.$label, this.$group );
[16:16:45] <RoanKattouw>	 Also note the 'items' config option
[16:18:37] <mooeypoo>	 that prepends the icon and label
[16:18:42] <mooeypoo>	 not the items
[16:18:51] <mooeypoo>	 I'm extending the addItems method now
[16:18:58] <mooeypoo>	 though I'll have to see how to do it properly for removeItems
[16:19:13] <RoanKattouw>	 Wait, why
[16:19:19] <RoanKattouw>	 The default implementation should be adding to this.$group
[16:19:32] <mooeypoo>	 oh, hm
[16:19:35] <mooeypoo>	 it should.
[16:19:39] <mooeypoo>	 .... ha
[16:19:40] <RoanKattouw>	 You really should not need to be fixing FieldsetLayout's usage of GroupElement, it looks fine
[16:19:55] * mooeypoo needs to fix the docs instead, then
[16:20:09] <mooeypoo>	 We are completely *not* using this in ve
[16:20:21] <mooeypoo>	 and I just went with what I'm used to, ha. Let me see if that works
[16:20:24] <RoanKattouw>	 Oh I'm sure
[16:20:28] <RoanKattouw>	 I think the OOUI demo uses it correctly
[16:20:29] <Krenair>	 James_F, ahh... MW is sending us normalisation information, which we're ignoring.
[16:20:38] <RoanKattouw>	 mooeypoo: Also did you see config.items in the FieldsetLayout constructor?
[16:21:16] <mooeypoo>	 RoanKattouw, aye
[16:21:34] <RoanKattouw>	 You might find that useful
[16:21:50] <RoanKattouw>	 OK I should really head into the office now
[16:22:21] <mooeypoo>	 oh my  god I feel like an idiot now
[16:22:30] <mooeypoo>	 well. That works.
[16:22:33] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] Fix theme on mobile-dist [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166737 (owner: 10Esanders)
[16:23:19] <James_F>	 Krenair: Maybe we shouldn't. :-)
[16:24:34] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Fix theme on mobile-dist [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166737 (owner: 10Esanders)
[16:24:44] <mooeypoo>	 hm, we really should start fixing up the code to fit this awesome ooui capability, then. I'll do that with the new media search fix
[16:30:49] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13459666
[16:30:49] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13459669
[16:30:50] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13459686
[16:30:50] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13459689
[16:30:50] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66164632
[16:30:50] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66181717
[16:30:50] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40290914
[16:30:50] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40293768
[16:30:51] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40294821
[16:31:24] <grrrit-wm1>	 (03PS26) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[16:31:26] <grrrit-wm1>	 (03PS28) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[16:31:28] <grrrit-wm1>	 (03PS31) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[16:31:30] <grrrit-wm1>	 (03PS1) 10Esanders: Allow tools to specify which selection types they support [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166768 
[16:34:22] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Yet Another Broken Browser Plugin Injecting Garbage in Pages (Norton?) - 10https://bugzilla.wikimedia.org/63229#c4 (10Alex Monk) 5RESO/FIX>3REOP https://no.wikipedia.org/w/index.php?title=Bruker:Bredekg%C3%A5rd&diff=13459686&oldid=13459676
[16:34:39] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Yet Another Broken Browser Plugin Injecting Garbage in Pages (Norton?) - 10https://bugzilla.wikimedia.org/63229 (10Alex Monk) a:5Alex Monk>3None
[16:45:25] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Yet Another Broken Browser Plugin Injecting Garbage in Pages (Norton?) - 10https://bugzilla.wikimedia.org/63229 (10James Forrester) 5REOP>3ASSI
[16:49:11] <grrrit-wm1>	 (03PS27) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[16:49:13] <grrrit-wm1>	 (03PS29) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[16:49:14] <grrrit-wm1>	 (03PS32) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[16:49:16] <grrrit-wm1>	 (03PS1) 10Esanders: Fix getAnnotationsFromRange when starting with an element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166773 
[16:49:18] <grrrit-wm1>	 (03PS1) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 
[16:51:12] <edsanders>	 RoanKattouw_away, https://gerrit.wikimedia.org/r/166768 & https://gerrit.wikimedia.org/r/166773 are fixes for tables
[16:51:16] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 (owner: 10Esanders)
[16:51:20] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[16:51:31] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[16:51:33] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[16:52:26] <grrrit-wm1>	 (03PS28) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[16:52:28] <grrrit-wm1>	 (03PS30) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[16:52:30] <grrrit-wm1>	 (03PS2) 10Esanders: [BREAKING CHANGE] Allow tools to specify which selection types they support [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166768 
[16:52:32] <grrrit-wm1>	 (03PS2) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 
[16:52:34] <grrrit-wm1>	 (03PS33) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[16:52:36] <grrrit-wm1>	 (03PS2) 10Esanders: Fix getAnnotationsFromRange when starting with an element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166773 
[16:53:49] <grrrit-wm1>	 (03PS1) 10Esanders: New requiresSelection api for tools [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166776 
[16:54:36] <RoanKattouw>	 edsanders: Cool. I'll look after the standup
[16:54:43] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Fix getAnnotationsFromRange when starting with an element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166773 (owner: 10Esanders)
[16:54:44] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 (owner: 10Esanders)
[16:54:46] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[16:55:02] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[16:55:13] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[16:55:23] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] The context menus for Categories are appearing in an incorrect position and also not closing - 10https://bugzilla.wikimedia.org/72052#c7 (10Rummana Yasmeen) Verified the fix in Betalabs and test2
[16:56:09] <grrrit-wm1>	 (03CR) 10Catrope: [C: 04-1] "I would much rather this be driven from the other side, with the Surface disabling and re-enabling the SurfaceObserver. We already have me" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166539 (owner: 10Esanders)
[16:58:24] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] “Uncaught TypeError: undefined is not a function” when Citation dialog opens - 10https://bugzilla.wikimedia.org/71997#c3 (10Rummana Yasmeen) Verified the fix in Betalabs
[17:27:34] <mooeypoo>	 Can I steal VE's styling for TemplateData dialog?
[17:28:29] <mooeypoo>	 I'll just do that and blame someone else if I get caught. Roan. I'll blame RoanKattouw_away.
[17:29:50] <TrevorParscal>	 divec: do you know if Asher's sister is coming with you guys?
[17:29:53] <mooeypoo>	 Seriously, though, TrevorParscal just an idea (but I encountered this twice now) -- Is there a proper way to do 3-element grid layout in ooui? Fieldlayout is 2 and FieldsetLayout takes fieldLayouts and/or appends elements one after the other (so most often on different lines)
[17:29:58] <TrevorParscal>	 and, will be at thanksgiving?
[17:31:29] <TrevorParscal>	 you mean like 2 outlines?
[17:31:38] <TrevorParscal>	 tierd
[17:32:04] <mooeypoo>	 TrevorParscal, well, I'm trying to build a list of parameters, so I need paramName + paramAliases (with different styling like in the template dialog) and a button (delete)
[17:32:08] <mooeypoo>	 all in the same line
[17:32:25] <mooeypoo>	 I thought of using field layout twice, so field layout inside a field layout, but that fails
[17:32:33] <mooeypoo>	 because field layout is looking for an actual field
[17:33:01] <TrevorParscal>	 napkin drawing?
[17:33:16] <mooeypoo>	 well, look at the template dialog (add template) and the way the param appears there
[17:33:55] <mooeypoo>	 So in the list of params there, there are only 2 items -- name and in the other end of the line the alias. I want a "delete" button to be there too.
[17:34:34] <mooeypoo>	 i can build that manually, but a widget could be nice
[17:35:01] <mooeypoo>	 TrevorParscal, another example for using something like this would have been the dimensions widget, where you have [input] [label x] [input] [label]
[17:35:05] <mooeypoo>	 so there it's 4 items
[17:35:13] <mooeypoo>	 [input] x [input]px
[17:36:06] <TrevorParscal>	 the list is a search widget
[17:36:07] <TrevorParscal>	 right?
[17:36:16] <TrevorParscal>	 it only shows the first 5
[17:36:20] <TrevorParscal>	 and has a filter
[17:36:22] <mooeypoo>	 The list in VE, yes, but not in TemplateData
[17:36:22] <TrevorParscal>	 inpu
[17:36:23] <mooeypoo>	 yes
[17:36:32] <mooeypoo>	 but look at the list items as an example of what I mean
[17:36:44] <mooeypoo>	 I want to go as close to that as possible to preserve the styles between VE and templatedata dialog
[17:37:22] <mooeypoo>	 but i also have to have a "Delete" button. I could, I guess, make the delete part of the parameter details (so, to delete, you'll have to edit the param and only then delete)
[17:37:58] <TrevorParscal>	 well, those are just template param option widgets
[17:38:11] <TrevorParscal>	 are you also showing template params?
[17:38:15] <TrevorParscal>	 just use the same widgets
[17:38:17] <mooeypoo>	 Yep
[17:38:26] <TrevorParscal>	 and, I am unsure about adding a remove button
[17:38:31] <mooeypoo>	 oh, I can use the option widget outside of a bigger scoped select widget?
[17:39:07] <TrevorParscal>	 the thing you need to be careful with is adding a button inside an already clickable region
[17:39:25] <mooeypoo>	 I can put the delete inside the data. We can always move it somewhere else. In any case I'm only semi-designing this... we'll need to see a proper design after I port the entire thing to ooui
[17:39:43] <mooeypoo>	 I just wanted to try and be loyal to VE's existing design as much as possible, so use as many elements from that dialog as possible
[17:39:56] <mooeypoo>	 TrevorParscal, that's a good point
[17:48:56] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualdEditor:  If I click on "show all fields" and add a parameter, then leave the list of all fields open so I can add another (and another and another) - 10https://bugzilla.wikimedia.org/72083 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None This is from Salix alba...
[17:49:37] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualdEditor:  If I click on "show all fields" and add a parameter, then leave the list of all fields open so I can add another (and another and another) - 10https://bugzilla.wikimedia.org/72083 (10WhatamIdoing) s:5normal>3enhanc
[18:06:38] <Krinkle>	 TrevorParscal: RoanKattouw: James_F|Away: https://cssjanus.github.io/
[18:06:47] <Krinkle>	 We were still linking to the google code demo. 
[18:07:05] <Krinkle>	 Made a js one. And because it's js, no need for ajax to a python script
[18:21:23] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] For every Math expression, it is not appearing on CE when its gets evaluated for the first time - 10https://bugzilla.wikimedia.org/71829 (10James Forrester)
[18:47:41] <grrrit-wm1>	 (03PS1) 10SuchetaG: Replacing push.apply with newly created ve.batchPush in VE core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166790 (https://bugzilla.wikimedia.org/66206) 
[18:48:56] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Replacing push.apply with newly created ve.batchPush in VE core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166790 (https://bugzilla.wikimedia.org/66206) (owner: 10SuchetaG)
[19:16:12] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Replacing push.apply with newly created ve.batchPush in VE core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166790 (https://bugzilla.wikimedia.org/66206) (owner: 10SuchetaG)
[19:17:35] <grrrit-wm1>	 (03PS1) 10SuchetaG: Replacing push.apply in VE-MW with ve.batchPush from VE core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166799 (https://bugzilla.wikimedia.org/66206) 
[19:17:58] <grrrit-wm1>	 (03CR) 10Esanders: "This is the least likely to break fix that gets paste working again. Anything more significant with the surface observer I'd like to get D" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166539 (owner: 10Esanders)
[19:18:19] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Replacing push.apply with newly created ve.batchPush in VE core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166790 (https://bugzilla.wikimedia.org/66206) (owner: 10SuchetaG)
[19:18:46] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] "Yeah James points out this is kind of urgent, so I'll merge it. Let's plan to do it properly later then; that's what I've been doing with " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166539 (owner: 10Esanders)
[19:20:54] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Fix paste by never polling while pasting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166539 (owner: 10Esanders)
[19:20:56] <Krinkle>	 Interesting, looks like whatwg is abandoning ship on XMLHttpRequest, finally.
[19:21:12] <Krinkle>	 New standard: Fetch (promise based)
[19:24:36] <grrrit-wm1>	 (03PS15) 10Trevor Parscal: [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 
[19:24:40] <TrevorParscal>	 MatmaRex: 
[19:24:42] <TrevorParscal>	 see ^^^
[19:24:54] <TrevorParscal>	 I made the change for the __get
[19:25:17] <TrevorParscal>	 to generate $this->icon and $this->button instead of having to define them ahead of time
[19:25:28] <MatmaRex>	 woot
[19:25:28] <TrevorParscal>	 as per you noticing the APIs could be closer together
[19:25:35] <TrevorParscal>	 could you rebase your stuff on that?
[19:25:39] <TrevorParscal>	 then we can merge merge merge
[19:26:35] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal)
[19:26:40] <MatmaRex>	 yep, will do
[19:26:47] <Krinkle>	 nummi: oojs.jquery.js is an optimised build of oojs.js for when you have jquery, so you need jquery + oojs.jquery + oojs.ui
[19:26:50] <MatmaRex>	 early tomorrow, probably
[19:27:11] <nummi>	 Thanks Krinkle, we are using jquery.
[19:27:43] <Krinkle>	 nummi: look at the demo/ example for a page that works.
[19:28:07] <MatmaRex>	 TrevorParscal: do we have a good idea on how we want to solve the RTL thing? there isn't really a way to detect directionality when you're PHP code
[19:28:27] <MatmaRex>	 TrevorParscal: i don't think we can avoid the user specifying direction, one way or the other
[19:28:44] <Krinkle>	 nummi: https://github.com/wikimedia/VisualEditor/blob/master/demos/ve/desktop-dist.html#L37
[19:29:02] <Krinkle>	 it's a bit messy since the demo tries to show off everything at once, yours should be simpler.
[19:30:35] <nummi>	 Krinkle, thanks. For now I modified build/modules.json. For “visualEditor.standalone.build” I added “baselibs” as a dependency. (we’re trying to make it simple to upgrade VE necessary)
[19:30:49] <nummi>	 (when necessary)
[19:33:27] <MatmaRex>	 TrevorParscal: also – next steps? it seems that we need to bring together the JS and PHP demos, tests for JS and PHP output parity and rebinding support
[19:33:46] <MatmaRex>	 ("we need"… to consider OOUI PHP done :) )
[19:35:16] <MatmaRex>	 i say let's do these in that order. the demo should be easy, just boring – slap the data (class names and configs) in some JSON files, mark some "JS only", write ten lines of code to render the widgets demo
[19:37:01] <grrrit-wm1>	 (03PS3) 10Alex Monk: Follow redirects in the category input widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163996 
[19:37:06] <MatmaRex>	 for tests, i was thinking of making it a QUnit test – PHP code to pass the result of running OOUI PHP classes to JS, JS code to create the same elements from scratch and compare DOMs – but i'm not sure if that entirely makes sense. is it possible to hook that up to our CI?
[19:38:04] <grrrit-wm1>	 (03CR) 10Alex Monk: Follow redirects in the category input widget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163996 (owner: 10Alex Monk)
[19:39:32] <MatmaRex>	 as for rebinding i'd like to hear what you think, you probably thought about this a lot more than i did. i have some vague ideas, i wonder if they match yours
[19:39:46] <MatmaRex>	 TrevorParscal: ^
[19:39:48] <MatmaRex>	 brb
[19:41:07] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression ?wmf3] Non-normalised category names cause "Uncaught TypeError: Cannot read property 'hidden' of undefined" to be thrown - 10https://bugzilla.wikimedia.org/72080#c1 (10Alex Monk) E.g. on https://www.mediawiki.org/wiki/VisualEditor - extra invi...
[19:41:40] <TrevorParscal>	 MatmaRex: going to lunch with roan for a bit, will discuss RTL issue with him
[19:42:52] <TrevorParscal>	 as for demo alignment, we need to come up with a new concept for the "demos" because what we really need is a style guide (lots of description of what you are looking at and how to use it and generate it) and a sanity check (tons of widgets in a small space to be able to ensure quickly that they are all working properly)
[19:42:58] <TrevorParscal>	 the current demo does both very poorly
[19:43:14] <TrevorParscal>	 I will talk to a few people and come up with a plan, and then write it up in the etherpad
[19:43:16] <TrevorParscal>	 brb
[20:15:05] <grrrit-wm1>	 (03PS1) 10Alex Monk: Follow normalisation response from category status query [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166863 (https://bugzilla.wikimedia.org/72080) 
[20:25:57] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  If I click on "show all fields" and add a parameter, then leave the list of all fields open so I can add another (and another and another) - 10https://bugzilla.wikimedia.org/72083 (10Andre Klapper)
[20:38:01] <grrrit-wm1>	 (03PS29) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[20:38:03] <grrrit-wm1>	 (03PS31) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[20:38:05] <grrrit-wm1>	 (03PS3) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 
[20:38:07] <grrrit-wm1>	 (03PS34) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[20:38:09] <grrrit-wm1>	 (03PS3) 10Esanders: Fix getAnnotationsFromRange when starting with an element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166773 
[20:47:54] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Placing cursor on a slug created from indenting a list throws "TypeError: Cannot read property 'getSelection' of null" - 10https://bugzilla.wikimedia.org/72095 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16774   --> https://bug...
[20:48:09] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Placing cursor on a slug created from indenting a list throws "TypeError: Cannot read property 'getSelection' of null" - 10https://bugzilla.wikimedia.org/72095 (10Rummana Yasmeen) 5NEW>3ASSI a:3Roan Kattouw
[20:53:50] <TrevorParscal>	 MatmaRex: you still 'round?
[20:54:09] <MatmaRex>	 yeah, doing uni busywork
[20:54:14] <TrevorParscal>	 no worries
[20:54:18] <TrevorParscal>	 go ahead and do so
[20:54:23] <MatmaRex>	 what's up?
[20:54:24] <TrevorParscal>	 I don't have a plan for RTL yet
[20:54:30] <TrevorParscal>	 forgot to talk to roan about it
[20:54:33] <TrevorParscal>	 and he's in a meeting
[20:54:39] <TrevorParscal>	 will poke when I have something
[20:54:56] <TrevorParscal>	 but, wanted to make sure you had things to work on tomorrow
[20:55:13] <ryasmeen>	 RoanKattouw: this is a new issue around slugs:https://bugzilla.wikimedia.org/show_bug.cgi?id=72095
[20:55:37] <RoanKattouw>	 TrevorParscal: I'm coming down in a minute
[20:55:54] <MatmaRex>	 TrevorParscal: so far i have rebasing and the issues in the etherpad, and if i run out of that then i have a few small bugs elsehwere waiting for me
[20:56:05] <TrevorParscal>	 ok
[20:56:21] <TrevorParscal>	 cool
[20:56:31] <MatmaRex>	 (i probably won't have too much time for that, sadly, my wednesdays and thursdays are busy :/)
[20:57:47] <TrevorParscal>	 also, fyi, https://gerrit.wikimedia.org/r/#/c/164007/
[20:57:54] <TrevorParscal>	 this will affect the PHP implementation
[21:04:24] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  After placing the cursor on a slug, placing it anywhere in the page which follows that particular slug throws "TypeError: Cannot read property 'getSelection' of null"the - 10https://bugzilla.wikimedia.org/72095#c1 (10Rummana Yasmeen) Rephrasing the bug its not o...
[21:04:24] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] After placing the cursor on a slug, placing it anywhere in the page which follows that particular slug throws "TypeError: Cannot read property 'getSelection' of null"the - 10https://bugzilla.wikimedia.org/72095 (10Rummana Yasmeen)
[21:12:04] <RoanKattouw>	 ryasmeen: Ouch
[21:13:42] <RoanKattouw>	 Ugh that's from my change to make exit transitions work
[21:18:01] <ryasmeen>	 RoanKattouw: you mean transitions of arrow keys?
[21:18:24] <RoanKattouw>	 No, sorry, I meant the animation when you exit a slug
[21:18:33] <ryasmeen>	 ah okay!
[21:19:35] <RoanKattouw>	 Sorry, "transition" is the technical term for a specific kind of animation; I now see that was confusing
[21:19:59] <ryasmeen>	 no worries ! :)
[21:22:56] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] A Red border is appearing around the Title field inside the Books and Journal citation dialog - 10https://bugzilla.wikimedia.org/72096 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16775   --> https://bugzil...
[21:23:23] <grrrit-wm1>	 (03PS1) 10Catrope: Followup 2432cbf: add recursion guard to updateSlug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166884 (https://bugzilla.wikimedia.org/72095) 
[21:23:34] <RoanKattouw>	 edsanders: Could you review https://gerrit.wikimedia.org/r/166884 please?
[21:23:48] <ryasmeen>	 RoanKattouw: What broke this one :(?  https://bugzilla.wikimedia.org/show_bug.cgi?id=72096
[21:23:59] <RoanKattouw>	 Yeah I noticed that earlier today
[21:24:02] <ryasmeen>	 this was fine yesterday
[21:24:05] <RoanKattouw>	 It's Alex's validation thing
[21:24:14] <RoanKattouw>	 Those fields aren't allowed to be empty, and for some reason it starts complaining about that too early
[21:25:09] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] A Red border is appearing around the Title field inside the Books and Journal citation dialog - 10https://bugzilla.wikimedia.org/72096#c1 (10Roan Kattouw) 5NEW>3ASSI a:3Alex Monk Looks like a regression from the "highlight invalid text...
[21:25:10] <ryasmeen>	 hmm and not for all citations?
[21:26:06] <RoanKattouw>	 Yeah it was used in the citation and template dialogs where we say inputs aren't allowed to be empty
[21:26:27] <RoanKattouw>	 So if you edit an existing citation/template, and one of the fields has already been filled out, then going to that field shouldn't give you the red border
[21:26:32] <RoanKattouw>	 If it does, we have worse problems
[21:27:28] <Krenair>	 It should only go red if you focus a required field, then move to another focus leaving it invalid
[21:28:41] <RoanKattouw>	 I think it goes red on focus
[21:29:05] <ryasmeen>	 Krenair: yeah, but right now its happening on the first time it gets focused
[21:37:29] <mooeypoo>	 TrevorParscal, oops, I forgot to login, but I made 2 tiny changes to the code in the docs http://www.mediawiki.org/w/index.php?title=OOjs_UI&diff=1225629&oldid=1224642
[21:38:25] <grrrit-wm1>	 (03CR) 10Catrope: [C: 04-1] Follow normalisation response from category status query (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166863 (https://bugzilla.wikimedia.org/72080) (owner: 10Alex Monk)
[21:39:54] <mooeypoo>	 ah, one more tiny change
[21:40:17] <RoanKattouw>	 mooeypoo: WTF is going on with that new OO.ui.Process() example
[21:40:24] <mooeypoo>	 yeah
[21:40:24] <RoanKattouw>	  return new OO.ui.Process( window.open.call( window, this.url ), this ); ?!?
[21:40:33] <RoanKattouw>	 I mean the previous version was even more wrong, it didn't even parse
[21:40:35] <mooeypoo>	 I'm trying to fix that too, hang on
[21:40:52] <mooeypoo>	 I first added 'this' there since that doesn't work at all without it
[21:40:59] <mooeypoo>	 but it needs function () {} call too
[21:42:13] <mooeypoo>	 RoanKattouw, I'm not sure about  "window.open.call( window, this.url );"
[21:42:30] <mooeypoo>	 I've never used this like that
[21:42:33] <RoanKattouw>	 Yeah I have no idea WTF is going on there
[21:42:40] <RoanKattouw>	 TrevorParscal: What were you smoking when you wrote that? ---^^
[21:42:44] <mooeypoo>	 hehe
[21:42:58] <mooeypoo>	 well I see the idea behind it, but I'm not sure that's the right command? never used that
[21:43:13] <mooeypoo>	 can I change it to console.log() or even alert just for the example?
[21:43:17] <mooeypoo>	 alert is so noobie
[21:43:27] <mooeypoo>	 But effective for a demo
[21:44:08] <TrevorParscal>	 supposed to be .bind not .call
[21:44:09] <TrevorParscal>	 sorry
[21:44:09] <legoktm>	 TrevorParscal, MatmaRex: how far along is the ooui-php patch so far? it's still marked as WIP so I'm not sure how much I should be reviewing it
[21:44:14] <TrevorParscal>	 you can pass a function
[21:44:20] <TrevorParscal>	 not the result of window.open
[21:44:21] <TrevorParscal>	 lol
[21:44:33] <TrevorParscal>	 legoktm: it's close
[21:44:39] <TrevorParscal>	 http://etherpad.wikimedia.org/p/OOUIPHP
[21:44:47] <mooeypoo>	 ok I'll fix that to bind
[21:44:52] <mooeypoo>	 looking at htis https://developer.mozilla.org/en-US/docs/Web/API/Window.open and wasn't entirely sure
[21:44:55] <TrevorParscal>	 dude, sorry those examples aren't very good
[21:45:01] <TrevorParscal>	 lol
[21:45:28] <TrevorParscal>	 you can't do new OO.ui.Process( windowObjectReference ); either
[21:45:40] <mooeypoo>	 yeah
[21:45:44] <mooeypoo>	 I'm adding a function call there
[21:45:52] <TrevorParscal>	 what we need is an OOjs UI examples dir
[21:46:03] <TrevorParscal>	 with the example code that the docs use
[21:46:04] <mooeypoo>	 not sure about the bind either, all the exampls I see use bind afterwards. Let me fix this and see if that's what was supposed to be there
[21:46:04] <James_F>	 Maybe we could call it a demo!
[21:46:07] <TrevorParscal>	 only, actually working
[21:46:09] <TrevorParscal>	 with a link to it
[21:46:45] * mooeypoo nods
[21:46:59] <mooeypoo>	 TrevorParscal, I think I messed up that example more
[21:47:09] <mooeypoo>	 the .bind should be a separate call, no? '
[21:48:11] <RoanKattouw>	 mooeypoo: new OO.ui.Process( window.open.bind( window, this.url ) );
[21:48:33] <mooeypoo>	 eh, so no anonymous function needed?
[21:48:35] <RoanKattouw>	 Or, alternatively, new OO.ui.Process( function () { window.open( this.url ); }, this );    those two are equivalent
[21:48:37] <mooeypoo>	 also, ", this)
[21:48:57] <mooeypoo>	 https://www.mediawiki.org/wiki/OOjs_UI#Windows
[21:49:15] <RoanKattouw>	 Yeah no anonymous function needed, and no ,this either because you've already bound it
[21:49:17] <mooeypoo>	 the bind is unneded now with the function, i think
[21:49:23] <RoanKattouw>	 No it's not
[21:49:30] <RoanKattouw>	 Because you're using 'this' inside for this.url
[21:49:30] <mooeypoo>	 I am a bit confused, sorry
[21:49:34] <RoanKattouw>	 It is confusing
[21:49:54] <mooeypoo>	 I had a lot of troubles activating mos tthings because of the missing ", this );"
[21:50:05] <mooeypoo>	 for the context; but with the bind, that's not needed...?
[21:50:07] <RoanKattouw>	 Yeah, but you've found the one case where you don't need it
[21:50:10] <mooeypoo>	 we're binding "window" though
[21:50:11] <RoanKattouw>	 Yeah with bind it isn't
[21:50:22] <mooeypoo>	 we're not putting in the context 'this'
[21:50:22] <RoanKattouw>	 bind returns a function that ignores its context, and calls another function with a specific context
[21:50:26] <mooeypoo>	 oh
[21:50:45] <mooeypoo>	 what's the 'window' variable there for, then?
[21:51:01] <RoanKattouw>	 So window.open.bind( window, this.url ); returns something like function () { window.open.call( window, url ); }
[21:51:08] <RoanKattouw>	 The context to run window.open in
[21:51:15] <mooeypoo>	 this is so confusing
[21:51:17] <RoanKattouw>	 The signature is func.bind( context, arg1, arg2, ... )
[21:51:21] <RoanKattouw>	 Yes it is
[21:51:31] <RoanKattouw>	 It's confusing if you're not very familiar with function binding
[21:51:34] <mooeypoo>	 how does it now the context to find "this.url" in?
[21:51:42] <RoanKattouw>	 Because this.url is passed in by value
[21:51:44] <mooeypoo>	 the binding is supposed to be for that, no? that context
[21:51:46] <RoanKattouw>	 It's resolved the moment you call bind
[21:51:49] <mooeypoo>	 oh
[21:51:52] <mooeypoo>	 yeesh
[21:52:16] <RoanKattouw>	 If you want to make the example simpler and easier to understand
[21:52:26] <RoanKattouw>	 Make it new OO.ui.Process( function () { window.open( this.url ); }, this );
[21:52:38] <mooeypoo>	 ok, so         return new OO.ui.Process( window.open.bind( window, this.url ) );
[21:52:40] <mooeypoo>	 oh
[21:52:43] <RoanKattouw>	 It's probably obvious to you what that does
[21:52:44] <mooeypoo>	 no bind at all
[21:52:50] <mooeypoo>	 ok I'm copying yours
[21:52:51] <RoanKattouw>	 And yes what you said works too, that's what Trevor was trying to do
[21:52:56] * mooeypoo is still confused
[21:53:14] <mooeypoo>	 For the purpose of the example, we may as well keep it consistent with the binding, i think
[21:53:16] <RoanKattouw>	 The two are equivalent, but mine (which is really a slight modification of one of your versions) is probably easier to understand
[21:53:19] <RoanKattouw>	 yeah
[21:53:45] <mooeypoo>	 There.
[21:53:46] <mooeypoo>	 I think.
[21:53:48] <RoanKattouw>	 Actually I guess there is a functional difference, to do with when this.url is evaluated
[21:54:08] <RoanKattouw>	 In the one without bind, it's evaluated late, and in the one with bind, it's evaluated early
[21:54:24] <RoanKattouw>	 Yeah what you have on the wiki page now looks good
[21:54:39] <mooeypoo>	 I should also add somethng about this.actions.setMode()
[21:54:43] <mooeypoo>	 and flags for actions
[21:55:59] <grrrit-wm1>	 (03PS5) 10Trevor Parscal: [WIP] Layouts: Field, Fieldset, Form, Panel, Grid [oojs/ui] - 10https://gerrit.wikimedia.org/r/166191 (owner: 10Bartosz Dziewoński)
[21:57:19] <grrrit-wm1>	 (03CR) 10Esanders: [C: 032] Followup 2432cbf: add recursion guard to updateSlug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166884 (https://bugzilla.wikimedia.org/72095) (owner: 10Catrope)
[21:57:33] <James_F>	 Thanks Ed.
[21:58:07] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] After placing the cursor on a slug, placing it anywhere in the page which follows that particular slug throws "TypeError: Cannot read property 'getSelection' of null" - 10https://bugzilla.wikimedia.org/72095 (10James Forrester) 5PATC>3RES...
[21:59:38] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Followup 2432cbf: add recursion guard to updateSlug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166884 (https://bugzilla.wikimedia.org/72095) (owner: 10Catrope)
[22:04:11] <grrrit-wm1>	 (03PS1) 10Jforrester: Update VE core submodule to master (660ac11) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166895 
[22:05:50] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (660ac11) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166895 (owner: 10Jforrester)
[22:06:34] <RoanKattouw>	 sucheta: Once https://gerrit.wikimedia.org/r/#/c/166895/ ---^^ merges, ve.batchPush() will exist in VE-MW and you'll be able to clean up those two push.apply calls in VE-MW
[22:07:26] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (660ac11) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166895 (owner: 10Jforrester)
[22:13:55] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Replace uses of push.apply with something safe - 10https://bugzilla.wikimedia.org/66206#c4 (10James Forrester) a:3Sucheta Ghoshal VE-MW patch coming or not needed?
[22:14:11] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf3] The dropdown box for "Use this group" field inside Reference dialog is not closing  upon de-focusing - 10https://bugzilla.wikimedia.org/72099 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16777   --> https://bugz...
[22:15:39] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] The dropdown box for "Use this group" field inside Reference dialog is not closing upon de-focusing - 10https://bugzilla.wikimedia.org/72099 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal
[22:16:37] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] The dropdown box for "Use this group" field inside Reference dialog is not closing upon de-focusing - 10https://bugzilla.wikimedia.org/72099#c1 (10Roan Kattouw) Ugh yeah this is because it's in the outer overlay :(
[22:17:22] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Replace uses of push.apply with something safe - 10https://bugzilla.wikimedia.org/66206#c5 (10Roan Kattouw) (In reply to James Forrester from comment #4) > VE-MW patch coming or not needed?  There are two usages in VE-MW that do need to be cleaned up. Now that 1...
[22:17:52] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: If I click on "show all fields" and add a parameter, then leave the list of all fields open so I can add another (and another and another) - 10https://bugzilla.wikimedia.org/72083 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal
[22:22:03] <grrrit-wm1>	 (03PS30) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb)
[22:22:05] <grrrit-wm1>	 (03PS32) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb)
[22:22:07] <grrrit-wm1>	 (03PS3) 10Esanders: [BREAKING CHANGE] Allow tools to specify which selection types they support [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166768 
[22:22:09] <grrrit-wm1>	 (03PS4) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 
[22:22:11] <grrrit-wm1>	 (03PS35) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb)
[22:22:13] <grrrit-wm1>	 (03PS4) 10Esanders: Fix getAnnotationsFromRange when starting with an element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166773 
[22:23:28] <RoanKattouw>	 ryasmeen: You are a genius
[22:23:45] <RoanKattouw>	 ryasmeen: By finding that bug, you have led me to read and modify the code that is going to save my butt with refactoring the popup stuff
[22:24:03] <Krinkle>	 RoanKattouw: Hm.. is a template going from inline to block a regression?
[22:24:14] <RoanKattouw>	 Krinkle: Define "going from inline to block"
[22:24:20] <James_F>	 :-)
[22:24:26] <Krinkle>	 I'm editing parameters of an inline template and closing the dialog to apply it i rendering makes it block level now
[22:24:29] <ryasmeen>	 RoanKattouw: :)
[22:24:36] <James_F>	 Krinkle: No, that's bug 49… something.
[22:24:36] <Krinkle>	 so it no longer matches what it looks like after saving
[22:24:38] <James_F>	 Krinkle: Very old.
[22:24:44] <Krinkle>	 Still very annoying
[22:24:44] <James_F>	 Krinkle: Never worked.
[22:24:52] <James_F>	 Yes. Feel free to bully edsanders into fixing it. :-)
[22:25:00] <James_F>	 'Cos he's totally not busy on that work with tables.
[22:30:17] <grrrit-wm1>	 (03PS1) 10Catrope: Support MenuWidget's config.widget being in a different document [oojs/ui] - 10https://gerrit.wikimedia.org/r/166898 (https://bugzilla.wikimedia.org/72099) 
[22:32:38] <RoanKattouw>	 TrevorParscal: ---^^
[22:34:10] <grrrit-wm1>	 (03CR) 10Trevor Parscal: [C: 032] Support MenuWidget's config.widget being in a different document [oojs/ui] - 10https://gerrit.wikimedia.org/r/166898 (https://bugzilla.wikimedia.org/72099) (owner: 10Catrope)
[22:34:21] <RoanKattouw>	 Thansk
[22:36:03] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Support MenuWidget's config.widget being in a different document [oojs/ui] - 10https://gerrit.wikimedia.org/r/166898 (https://bugzilla.wikimedia.org/72099) (owner: 10Catrope)
[22:40:56] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4]Cannot open the dropdown box  for "Use this group" field inside References List dialog box - 10https://bugzilla.wikimedia.org/72100 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16778   --> https://bugzilla.w...
[22:41:16] <grrrit-wm1>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (98cecf304d) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166904 
[22:41:21] <James_F>	 RoanKattouw: ^^^
[22:41:34] <ryasmeen>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/166898/ is this going to fix https://bugzilla.wikimedia.org/show_bug.cgi?id=72100 too?
[22:41:36] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (98cecf304d) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166904 (owner: 10Jforrester)
[22:41:54] <RoanKattouw>	 ryasmeen: No that's not fixed :O
[22:41:58] <RoanKattouw>	 WTF is going on there
[22:42:05] <ryasmeen>	 yeah thats a pre-wmf4 though
[22:42:08] <grrrit-wm1>	 (03PS2) 10Alex Monk: TextInputMenuWidget: Handle undefined value properly when toggling visibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/166512 (https://bugzilla.wikimedia.org/72100) 
[22:42:39] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4]Cannot open the dropdown box for "Use this group" field inside References List dialog box - 10https://bugzilla.wikimedia.org/72100 (10Alex Monk) a:3Alex Monk
[22:43:00] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] TextInputMenuWidget: Handle undefined value properly when toggling visibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/166512 (https://bugzilla.wikimedia.org/72100) (owner: 10Alex Monk)
[22:43:04] <Krenair>	 :)
[22:43:05] <RoanKattouw>	 ryasmeen: No but that ---^^ does
[22:43:09] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] The dropdown box for "Use this group" field inside Reference dialog is not closing upon de-focusing - 10https://bugzilla.wikimedia.org/72099 (10James Forrester) 5PATC>3ASSI a:3Roan Kattouw
[22:43:11] <James_F>	 Ha.
[22:43:21] <Krenair>	 I uploaded that fix two days ago.
[22:43:24] <ryasmeen>	 Ah great ! :)
[22:43:30] <RoanKattouw>	 Krenair happened to be adding the Bug: thing to it at exactly the right moment :)
[22:43:43] <Krenair>	 I saw the chat and added it
[22:43:52] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] Cannot open the dropdown box  for "Use this group" field inside References List dialog box - 10https://bugzilla.wikimedia.org/72100 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal
[22:44:57] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (98cecf304d) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166904 (owner: 10Jforrester)
[22:45:23] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] The dropdown box for "Use this group" field inside Reference dialog is not closing upon de-focusing - 10https://bugzilla.wikimedia.org/72099#c4 (10James Forrester) 5ASSI>3RESO/FIX Now fixed?
[22:45:23] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Replace uses of push.apply with something safe - 10https://bugzilla.wikimedia.org/66206#c6 (10Roan Kattouw) (In reply to Roan Kattouw from comment #5) > (In reply to James Forrester from comment #4) > > VE-MW patch coming or not needed? >  > There are two usages...
[22:45:34] <grrrit-wm1>	 (03CR) 10Catrope: [C: 04-1] "You missed one in MWTemplateModel" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166799 (https://bugzilla.wikimedia.org/66206) (owner: 10SuchetaG)
[22:46:12] <grrrit-wm1>	 (03Merged) 10jenkins-bot: TextInputMenuWidget: Handle undefined value properly when toggling visibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/166512 (https://bugzilla.wikimedia.org/72100) (owner: 10Alex Monk)
[22:46:52] <Krenair>	 (While trying to deal with maths work.)
[22:49:26] <grrrit-wm1>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (1829141230) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166905 
[22:50:32] <RoanKattouw>	 MatmaRex: Hey, do you have a minute for me to pick your brain about PopupWidget positioning?
[22:58:41] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/166906 and https://gerrit.wikimedia.org/r/166901.
[22:58:56] <James_F>	 Krenair: Having fun? :-)
[22:59:17] <MatmaRex>	 RoanKattouw: sure
[22:59:31] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (1829141230) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166905 (owner: 10Jforrester)
[22:59:48] <RoanKattouw>	 MatmaRex: OK so it looks to me like it works like this, correct me if I'm wrong
[23:00:09] <RoanKattouw>	 PopupWidget expects its caller to position it, using position: absolute; top: NNNpx; left: MMMpx;
[23:00:18] <RoanKattouw>	 And then PopupWidget itself aligns itself using margin-left
[23:00:52] <RoanKattouw>	 Is that right?
[23:01:04] <RoanKattouw>	 Because I'm thinking that I want to build a positioning feature into PopupWidget
[23:01:07] <MatmaRex>	 indeed, but it allows the caller to use anything. position:relative; is used in some places in ooui, i think
[23:01:12] <RoanKattouw>	 Ooooh OK
[23:01:22] <RoanKattouw>	 Yeah that sounds sensible
[23:01:25] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (1829141230) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166905 (owner: 10Jforrester)
[23:01:51] <RoanKattouw>	 i was thinking of building in automatic absolute positioning, but I think I know where this relative positioning thing is used
[23:01:53] <RoanKattouw>	 (help popups)
[23:02:03] <MatmaRex>	 yeah, popupbuttonwidget iirc
[23:02:37] <Krenair>	 James_F, haha :(
[23:04:45] <MatmaRex>	 RoanKattouw: i was wondering if we could kill that entire thing and replace it with a position(x,y) method, that would place the arrow at x,y page coordinates and align the body magically. dunno if that's feasible
[23:05:32] <MatmaRex>	 (it would also of course mean that popup's position will not automatically adjust itself, like it could with position:relative)
[23:05:33] <RoanKattouw>	 Well that's what I want to do
[23:05:40] <RoanKattouw>	 Except instead of passing in (x,y), passing in an element
[23:06:11] <RoanKattouw>	 This is already essentially how MWCategoryWidgetPopup is positioned, although maybe we should make that use relative positioning instead
[23:06:18] <MatmaRex>	 oh. that sounds neat
[23:06:20] <TrevorParscal>	 James_F: https://etherpad.wikimedia.org/p/OOUIDEMOS
[23:06:37] <RoanKattouw>	 I was also thinking about factoring out this positioning relative to another element logic because TextInputMenuWidget uses it too
[23:06:50] <RoanKattouw>	 I even got part of the way through writing a PositionedElement mixin
[23:07:06] <RoanKattouw>	 But now I've decided that I'm just going to beef up OO.ui.Element.getRelativePosition() with iframe-awareness
[23:08:09] <RoanKattouw>	 because that's where almost all of the complexity is
[23:08:29] <MatmaRex>	 eww, iframes
[23:08:33] <RoanKattouw>	 Yeeeaah
[23:08:46] <RoanKattouw>	 Because suggestion dropdowns can protrude out
[23:09:08] <RoanKattouw>	 Like they do with the link inspector (which is why that code was first written), and as of recently with the reference group widget
[23:09:46] <RoanKattouw>	 Right now I've got the category popups sitting in a special overlay that I created especially for them so they're inside the iframe instead of the main document, otherwise positioning and mousedown capturing was too hard
[23:10:10] <RoanKattouw>	 I was thinking of moving them to the main document so they could also protrude
[23:10:16] <RoanKattouw>	 But I also like the position: relative; idea
[23:15:03] <MatmaRex>	 i dunno. sorry, i need to hit the bed. talk to you tomorrow
[23:19:59] <RoanKattouw>	 Thanks man
[23:20:52] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Trying to insert anything in the slug inside a media dialog box throws Uncaught Error: Offset could not be translated to a DOM element and offset: 63 - 10https://bugzilla.wikimedia.org/63025#c8 (10Rummana Yasmeen) 5ASSI>3RESO/FIX This is now fixed with late...
[23:21:22] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Trying to insert anything in the slug inside a media dialog box throws Uncaught Error: Offset could not be translated to a DOM element and offset: 63 - 10https://bugzilla.wikimedia.org/63025 (10Rummana Yasmeen)
[23:23:00] <RoanKattouw>	 ryasmeen: Awesome. I like bugs that close themselves :)
[23:23:44] <ryasmeen>	 hahaha yeah! I know, its a relieve for me too :)
[23:35:30] <RoanKattouw>	 mooeypoo: DUUUDE I've just made a major breakthrough in fighting RTL positioning bugs
[23:35:53] <RoanKattouw>	 All that flip me I'm a mirror code, the reason that was even necessary appears to be that we had .oo-ui-window-overlay{ top: 0; left: 0; }
[23:36:28] <RoanKattouw>	 Which, in RTL, is flipped to top: 0; right: 0; , and now your coordinate system's origin is in the wrong place and measured coordinates can't be translated into it easily
[23:36:32] <RoanKattouw>	 Solution: @noflip
[23:36:35] <RoanKattouw>	 (I think; testing this theory now)
[23:38:05] <grrrit-wm1>	 (03PS2) 10Jforrester: Element: Correct method name reference in documentation. [oojs/ui] - 10https://gerrit.wikimedia.org/r/166199 (owner: 10Bartosz Dziewoński)
[23:38:11] <mooeypoo>	 well, the flip was needed because a lot of the coordinates are calculated dynamically
[23:38:13] <grrrit-wm1>	 (03PS3) 10Jforrester: Element: Correct method name reference in documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/166199 (owner: 10Bartosz Dziewoński)
[23:38:18] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] Element: Correct method name reference in documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/166199 (owner: 10Bartosz Dziewoński)
[23:38:39] <mooeypoo>	 RoanKattouw, but th efact everything was nested in 2 left/right positioned divs made things really hard to calculate.
[23:38:43] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] ButtonWidget: Fix titled button [oojs/ui] - 10https://gerrit.wikimedia.org/r/166214 (owner: 10Bartosz Dziewoński)
[23:39:16] <RoanKattouw>	 Yeah that's the thing, nothing should be positioned righjt
[23:39:17] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 031] WindowManager: Wait for window to open before trying to close it [oojs/ui] - 10https://gerrit.wikimedia.org/r/166613 (https://bugzilla.wikimedia.org/69918) (owner: 10Bartosz Dziewoński)
[23:39:20] <RoanKattouw>	 But it was due to a missing noflip
[23:39:25] <mooeypoo>	 hmmm
[23:39:28] <mooeypoo>	 Are you sure?
[23:39:39] <mooeypoo>	 The problem I remember is that not everything flipped
[23:39:45] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] Replace calls to OO.ui.bind( fn, ... ) with fn.bind( ... ) [oojs/ui] - 10https://gerrit.wikimedia.org/r/166155 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk)
[23:40:03] <mooeypoo>	 so, some flipped and some didn't, which meant we have to flip for RTL (and plus do some mental gymnastics to calculate exactly how to flip sometimes)
[23:40:05] <RoanKattouw>	 OK well I'm crusading against positioning problems now
[23:40:15] * mooeypoo nods
[23:40:17] <RoanKattouw>	 There's a lot that's broken in RTL related to popups and the context
[23:40:40] <RoanKattouw>	 Yeah I think what you're talking about is actually caused by us accidentally flipping too much
[23:40:43] <mooeypoo>	 yeah the positioning was crazy. The noflip sounds right, but i remember something about some of the containers not being flipped
[23:40:55] <mooeypoo>	 oh, wait, some of the problem was inside frames -- but you fixed janus to work there I think
[23:40:57] <grrrit-wm1>	 (03PS4) 10Jforrester: MediaWiki theme: Fix styling of SearchWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/165763 (https://bugzilla.wikimedia.org/71889) (owner: 10Esanders)
[23:41:04] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] MediaWiki theme: Fix styling of SearchWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/165763 (https://bugzilla.wikimedia.org/71889) (owner: 10Esanders)
[23:41:22] <mooeypoo>	 and yeah, that might be.
[23:42:15] <RoanKattouw>	 Oh, right, so back then this wouldn't have been a problem
[23:42:22] <RoanKattouw>	 The thing that was being over-flipped was originally inside a frame
[23:42:28] <mooeypoo>	 yeah
[23:42:49] <mooeypoo>	 over-flipped and hard-coded left: vs flipped left, stuff like that.
[23:42:53] <mooeypoo>	 it was really confusing
[23:42:59] <James_F>	 TrevorParscal: Quick sanity-check on https://gerrit.wikimedia.org/r/#/c/166613/ maybe?
[23:43:13] <grrrit-wm1>	 (03PS2) 10Jforrester: Refine global event handling in non-isolated window managers [oojs/ui] - 10https://gerrit.wikimedia.org/r/166019 (owner: 10Esanders)
[23:43:27] <James_F>	 TrevorParscal: Any maybe https://gerrit.wikimedia.org/r/#/c/166019/ if you're in the mood
[23:45:04] <grrrit-wm1>	 (03CR) 10Trevor Parscal: [C: 032] Refine global event handling in non-isolated window managers [oojs/ui] - 10https://gerrit.wikimedia.org/r/166019 (owner: 10Esanders)
[23:45:08] <grrrit-wm1>	 (03CR) 10Trevor Parscal: [C: 032] WindowManager: Wait for window to open before trying to close it [oojs/ui] - 10https://gerrit.wikimedia.org/r/166613 (https://bugzilla.wikimedia.org/69918) (owner: 10Bartosz Dziewoński)
[23:45:20] <James_F>	 TrevorParscal: Nice
[23:50:25] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] Previous Link is getting applied to the first letter on newly added text while selecting the previous link and replacing it with new text - 10https://bugzilla.wikimedia.org/72108 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None C...
[23:52:12] <ryasmeen>	 RoanKattouw: https://bugzilla.wikimedia.org/show_bug.cgi?id=72108 :Unicorn change affect?
[23:52:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] Previous Link is getting applied to the first letter on newly added text while selecting the previous link and replacing it with new text - 10https://bugzilla.wikimedia.org/72108 (10Roan Kattouw) 5NEW>3ASSI a:3David Chan
[23:52:29] <RoanKattouw>	 ryasmeen: Yeah probably
[23:56:59] <grrrit-wm1>	 (03PS1) 10Trevor Parscal: Apply mw-body-content styles to SurfaceWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166918 (https://bugzilla.wikimedia.org/71652) 
[23:58:47] <grrrit-wm1>	 (03PS2) 10Catrope: Apply mw-body-content styles to SurfaceWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166918 (https://bugzilla.wikimedia.org/71652) (owner: 10Trevor Parscal)
[23:59:51] <grrrit-wm1>	 (03CR) 10Catrope: [C: 032] Apply mw-body-content styles to SurfaceWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166918 (https://bugzilla.wikimedia.org/71652) (owner: 10Trevor Parscal)