[00:02:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] After placing the cursor on a slug, placing it anywhere in the page which follows that particular slug throws "TypeError: Cannot read property 'getSelection' of null" - 10https://bugzilla.wikimedia.org/72095#c5 (10Rummana Yasmeen) Verified t... [00:03:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] The dropdown box for "Use this group" field inside Reference dialog is not closing upon de-focusing - 10https://bugzilla.wikimedia.org/72099#c6 (10Rummana Yasmeen) Verified the fix in test2 [00:05:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] Cannot open the dropdown box for "Use this group" field inside References List dialog box - 10https://bugzilla.wikimedia.org/72100#c4 (10Rummana Yasmeen) Verified the fix in test2 [00:05:34] (03PS2) 10Divec: WIP: Show entire expandable call tree in ve.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167021 [00:05:55] 3VisualEditor: VisualEditor: Can't cut or (somestimes) paste in Firefox - 10https://bugzilla.wikimedia.org/72164 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1. Open a page in Firefox (my version is 32). 2. Select some text. 3. Press Ctrl-X or Command-X. 4. Notice that... [00:06:53] 3VisualEditor / 3ContentEditable: VisualEditor: Trying to insert anything in the slug inside a media dialog box throws Uncaught Error: Offset could not be translated to a DOM element and offset: 63 - 10https://bugzilla.wikimedia.org/63025#c9 (10Rummana Yasmeen) Verified the fix in test2 [00:11:09] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] The context menus for Categories are appearing in an incorrect position and also not closing - 10https://bugzilla.wikimedia.org/72052#c8 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [00:19:24] (03CR) 10Divec: "No PhantomJS, so abandon?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166753 (owner: 10Divec) [00:21:06] (03PS3) 10Divec: WIP: Show entire expandable call tree in ve.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167021 [00:24:10] (03PS23) 10Divec: Use a single unicorn-like instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [00:43:25] 3VisualEditor / 3Editing Tools: VisualEditor: Category sort keys cannot be added - 10https://bugzilla.wikimedia.org/72168 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1. Open a page and go to Page options > Categories. 2. (Add a category if none exist.) Edit a category... [02:28:28] (03Abandoned) 10Jforrester: Polyfill Set for PhantomJS (for debug only) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166753 (owner: 10Divec) [02:50:47] lol https://github.com/jquery/standards/issues/20 [02:51:29] Krinkle, maybe he thought this should be standard.. [07:12:11] (03CR) 10Esanders: Get rid of toHashObject from ranges/selection (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167052 (owner: 10Esanders) [10:40:53] 3VisualEditor: VisualEditor: Can't cut or (sometimes) paste in Firefox - 10https://bugzilla.wikimedia.org/72164 (10Elitre) [10:44:25] (03PS1) 10Esanders: Fix shift-click select on links in Chrome [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167188 [11:01:18] (03PS32) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [11:01:20] (03PS34) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [11:01:22] (03PS2) 10Esanders: Get rid of toHashObject from ranges/selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167052 [11:01:24] (03PS5) 10Esanders: [BREAKING CHANGE] Allow tools to specify which selection types they support [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166768 [11:01:26] (03PS6) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [11:01:28] (03PS37) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [11:01:30] (03PS6) 10Esanders: Fix getAnnotationsFromRange when starting with an element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166773 [11:03:21] (03CR) 10jenkins-bot: [V: 04-1] Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 (owner: 10Esanders) [11:03:31] (03CR) 10jenkins-bot: [V: 04-1] Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [11:14:01] (03PS1) 10Esanders: Files and message for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 [11:14:36] (03PS1) 10Esanders: Fix class name is browser test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167190 [11:15:19] (03CR) 10jenkins-bot: [V: 04-1] Files and message for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders) [11:16:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: Allow seeing all template parameters at once - 10https://bugzilla.wikimedia.org/69734 (10Elitre) [11:16:38] 3VisualEditor / 3Editing Tools: VisualEditor: If I click on "show all fields" and add a parameter, then leave the list of all fields open so I can add another (and another and another) - 10https://bugzilla.wikimedia.org/72083 (10Elitre) [11:17:41] (03PS1) 10Esanders: Restore basic styling to toolbar in core target (only) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167191 [15:19:24] 3VisualEditor / 3Data Model: VisualEditor: Selection starting on a tooled item (e.g. link) always shows the context menu - 10https://bugzilla.wikimedia.org/72152 (10Ed Sanders) a:3Ed Sanders [15:20:02] (03PS1) 10Esanders: Fix contextChange events from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167217 (https://bugzilla.wikimedia.org/72152) [15:22:07] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a way to label auto-numbered external links - 10https://bugzilla.wikimedia.org/72150#c6 (10WhatamIdoing) Steps to reproduce: 1. 1. Open a page that already contains an external link without a label: [http://example.com], such as https://en.wikipedia... [15:28:07] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a way to label auto-numbered external links - 10https://bugzilla.wikimedia.org/72150#c7 (10Elitre) I tried this earlier and works for me in Chrome/Win8 and Safari on my Air. (6.2 isn't the most recent Safari version, but I don't think that matters). Can... [15:29:52] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a way to label auto-numbered external links - 10https://bugzilla.wikimedia.org/72150#c8 (10Elitre) (Also, works fine in both skins.) [15:45:25] 3VisualEditor / 3MediaWiki integration: VisualEditor: Advanced media dialog shown with scrollbars in Polish because translated button labels don't fit horizontally - 10https://bugzilla.wikimedia.org/72187 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Created attachment 16796 --> https://b... [16:07:05] (03PS2) 10Jforrester: Fix contextChange events from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167217 (https://bugzilla.wikimedia.org/72152) (owner: 10Esanders) [16:07:53] 3VisualEditor / 3Data Model: VisualEditor: Selection starting on a tooled item (e.g. link) always shows the context menu - 10https://bugzilla.wikimedia.org/72152 (10James Forrester) p:5Unprio>3High [16:09:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: Advanced media dialog shown with scrollbars in Polish because translated button labels don't fit horizontally - 10https://bugzilla.wikimedia.org/72187#c1 (10James Forrester) Can we improve the translations? [16:13:47] (03CR) 10Jforrester: "I was waiting for sub-groups in OOUI toolbars to be a thing before doing this; indeed, I just created support for that as bug 72159." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167191 (owner: 10Esanders) [16:25:22] 3VisualEditor / 3MediaWiki integration: VisualEditor: Advanced media dialog shown with scrollbars in Polish because translated button labels don't fit horizontally - 10https://bugzilla.wikimedia.org/72187#c2 (10Bartosz Dziewoński) Not really. [16:30:43] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13463030 [16:30:43] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108290697 [16:30:43] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108290749 [16:30:43] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108290778 [16:30:43] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108290817 [16:30:44] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32994546 [16:30:44] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66223763 [16:30:45] Corruption alert: visualeditor-needcheck on bgwiki: https://bg.wikipedia.org/?diff=6313119 [16:31:01] Ick. [16:32:08] 3VisualEditor / 3Editing Tools: VisualEditor: Advanced media dialog shown with scrollbars in Polish because translated button labels don't fit horizontally - 10https://bugzilla.wikimedia.org/72187#c3 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3minor Well, given that we're replacing t... [16:33:49] Is it just me or is that one showing up on nowiki more common now? [16:39:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] Red border is appearing around required parameters before focus moves away - 10https://bugzilla.wikimedia.org/72096 (10Alex Monk) [16:39:23] Krenair: https://no.wikipedia.org/w/index.php?namespace=&tagfilter=visualeditor-needcheck&title=Spesial%3ASiste+endringer [16:39:29] Krenair: It might be the same user. [16:55:39] 3VisualEditor / 3Editing Tools: flipping through images in Media Viewer produces error: could not load thumbnail data - 10https://bugzilla.wikimedia.org/72190 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3None Created attachment 16798 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16798&action... [16:55:55] (03PS1) 10Alex Monk: Only validate required template params after blur [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167226 (https://bugzilla.wikimedia.org/72096) [16:59:42] (03PS2) 10Alex Monk: Only validate required template params after blur [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167226 (https://bugzilla.wikimedia.org/72096) [17:02:12] (03PS1) 10Esanders: Fix broken node change detection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167228 [17:02:14] (03PS1) 10Esanders: Close inspector on model select [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167229 [17:21:38] 3VisualEditor: Cannot save deletion of {{clarify span}} template - 10https://bugzilla.wikimedia.org/71701 (10Bartosz Dziewoński) [17:21:40] 3VisualEditor / 3MediaWiki integration: VisualEditor: It's not possible to "Apply changes" from the transclusion dialog after it has been emptied - 10https://bugzilla.wikimedia.org/72191 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None It's not possible to "Apply changes" from the transclusion... [17:28:34] (03PS3) 10Esanders: Fix contextChange events from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167217 (https://bugzilla.wikimedia.org/72152) [17:28:36] (03PS2) 10Esanders: Close inspector on model select [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167229 [17:28:38] (03PS2) 10Esanders: Fix broken node change detection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167228 [17:28:53] 3VisualEditor / 3MediaWiki integration: VisualEditor: Blue link / red link logic should descend into links inside non-transclusion generated content nodes - 10https://bugzilla.wikimedia.org/71900#c1 (10Elitre) In the top template at https://it.wikipedia.org/wiki/Korova_Milk_Bar?veaction=edit "migliorare ques... [17:29:51] RoanKattouw: Can we talk a little bit about handling galleries in VE - in regard to: https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec/Gallery_RDFa [17:30:00] MatmaRex, are page status indicators ready to go? [17:30:46] edsanders: probably, they were when i last looked at them, i think [17:43:42] InezK: Sure [17:44:47] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/167217/ stack; https://gerrit.wikimedia.org/r/167226 [17:46:20] (03CR) 10Catrope: [C: 04-1] "But now you're not emitting contextChange when the insertionAnnotations change." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167217 (https://bugzilla.wikimedia.org/72152) (owner: 10Esanders) [17:46:43] (03CR) 10Catrope: Fix contextChange events from annotations (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167217 (https://bugzilla.wikimedia.org/72152) (owner: 10Esanders) [17:48:46] James_F, you may want to watchlist https://www.mediawiki.org/wiki/Requests_for_comment/Allow_styling_in_templates if you aren't already [17:49:15] Eloquence: Eurgh. Is that really going to go anywhere? [17:49:38] Eloquence: It blew up pretty significantly in January as effectively a WONTFIX. [17:49:54] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/167188/ [17:50:04] Eloquence: (I am watching, yes.) [17:52:08] 3VisualEditor / 3MediaWiki integration: VisualEditor: It's not possible to "Apply changes" from the transclusion dialog after it has been emptied - 10https://bugzilla.wikimedia.org/72191#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Sucheta Ghoshal Yeah; this should be available when there... [17:52:11] James_F, brion wants to take a crack at it [17:52:25] Eloquence: Huh. In that case, I'm more interested. :-) [17:52:29] Eloquence: Thanks for the heads-up. [17:52:30] mwahahaha [17:52:31] RoanKattouw: so we are thinking about having gallery node as a branch node, and that gallery node would have gallery item as a child, or placeholder (for invalid gallery item), or from Parsoid it would just get "\n" for new lines, I'm not sure how those will be recognized in DM [17:53:07] James_F: the main trick is to make sure the styles are scoped to just the template [17:53:39] since official HTML5 scoped styles are like not consistently supported yet, that means we have to parse the CSS and modify selectors [17:53:48] Right, so you'd have a GalleryNode whose children are GalleryItemNodes [17:53:49] tim’s gonna poke at a css parser to go for that part :) [17:54:22] (this also means a template-with-style will have a wrapper element) [17:54:35] which should be nice [17:54:44] RoanKattouw: yes [17:55:03] Let's not have a placeholder for invalid/empty in the DM, I'd prefer that be dealt with in ce.GalleryNode [17:55:07] RoanKattouw: GalleryItemNode (for figure) and GalleryItemPlaceholderNode (for placeholder) (perhaps some better naming) [17:55:20] brion: We should chat a bit about it at some point. :-) [17:55:28] *nod* [17:55:28] As for newlines, that's dealt with automatically by DM, that's already working for
    /
  • lists too [17:55:49] James_F: either grab me some time next week when i’m in the office or schedule something on my calendar so i don’t forget :D [17:55:58] RoanKattouw: so, if that's my htmldom: https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec/Gallery_RDFa, what should happen with that meta placeholder? [17:56:14] brion: Will do. :-) [17:56:19] it shouldn't go to DM as well? I want to preserve it (on the way out) but give no ability to edit in VE (for now) [17:56:23] (03CR) 10Catrope: [C: 04-1] Fix broken node change detection (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167228 (owner: 10Esanders) [17:56:34] Wait, *Parsoid* puts in a meta placeholder? [17:56:37] * RoanKattouw reads spec page [17:56:48] Oooh [17:56:54] For invalid entries, gotcha [17:57:00] yup [17:57:10] and newlines are just output as "\n" [17:57:19] Yeah newlines are fine, DM will deal with that [17:57:42] The tag, for now let's just leave that be, it'll be treated as an alienMeta automatically [17:58:24] ok, so it seem I just have GalleryNode (Branch that does NOT handle own children), GalleryItemNode (similar to ImageNode, and also handles own children, for purpose of caption) [17:58:31] If we want any sort of editing capability for it, then we'll need to do more to it, but if you just do nothing then it'll automatically be preserved for you [17:58:42] sweeet [17:58:45] Yeah exactly [17:58:59] Also, here's one annoying thing though [17:59:11] This is the first time that we have to use parent context to distinguish nodes from each other [17:59:27] yes, so we are using matching function [17:59:39] in Parsoid, I can as well give different typeof to that thing - not a problem [17:59:43] Both a GalleryItemNode and a BlockImageNode are figure[typeof="mw:Image/Thumb"], and they are distinguished only by parentage [18:00:18] Yeah a matchFunction for that would work. A different type from Parsoid might be nice, or maybe we just need to bite the bullet and support context-sensitive node matching in ve.dm.ModelRegistry [18:01:31] btw. a little bit about CE [18:02:03] or maybe later, let me quickly confirm what we talked about [18:06:35] (03CR) 10Catrope: [C: 031] Close inspector on model select [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167229 (owner: 10Esanders) [18:12:41] hm, is TrevorP|Away around? I got a behavior/UX question for him [18:15:18] TrevorParscal, I've split the templatedata dialog to two panels; parameter list (similar to how template dialog looks) and then when you choose a param, it goes to a details panel where you can change its properties. The question is this: Do I save changes with "save" button (so, allowing the user to go back without saving with 'back') or do I do what the other dialogs in VE do, which is *immediately* change the templa [18:15:18] tedata model when the user changes any of the inputs, no need for 'save'. If that makes sense? [18:15:24] (03CR) 10Catrope: [C: 04-1] Fix shift-click select on links in Chrome (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167188 (owner: 10Esanders) [18:15:39] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression] "Make full size" is not enabling "Apply Changes" button when the image has been set to a custom size - 10https://bugzilla.wikimedia.org/72155 (10Rummana Yasmeen) 5NEW>3ASSI a:3Moriel Schottlender [18:16:21] TrevorParscal, in any case, the new templatedata won't be applied until the user clicks "APPLY" -- but should I change properties 'on the fly' when user changes, or defer the change until the user clicks "save properties" [18:17:52] 3VisualEditor: In VE, while adding any image using Firefox getting the error "Image corrupt or truncated" in Betalabs - 10https://bugzilla.wikimedia.org/72115#c5 (10James Forrester) I also can't reproduce this problem (MediaViewer issue?) in Chrome, Safari or Firefox? The error as state would be from the MW me... [18:17:56] mooeypoo: catching up [18:18:00] one sec (reading) [18:18:37] modal experiences should stage changes [18:19:10] it's a modal dialog, so you should be operating on a stand-alone model, and upon save you should apply those changes [18:19:16] just clarification: The templatedata model is internal, so the user can still cancel at any time, but the question is more should the user click 'save' or not in intermediate steps. [18:19:37] Aye, yes, of course -- this is similar to the image model. IT is separate from the image in the actual surface, but the changes *to* the model are done immediately [18:19:40] if by intermediate steps you mean individual pages in the dialog, no [18:19:53] i think that should all be done immediately [18:20:04] RoanKattouw: where that information about \n is preserved? I don't see it in documentModel.data.data [18:20:16] because those pages are not modal experiences - as in you can navigate to a different page without clicking save [18:20:31] oh, it's internal.whitespace [18:20:37] so if you click "framed" the model changes immediately; if you go to 'change image' it changes immediately, etc -- at the "APPLY" part, the dialog just applies the current edited model to the actual page. Does that make sense? [18:20:39] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] "Make full size" is not enabling "Apply Changes" button when the image has been set to a custom size - 10https://bugzilla.wikimedia.org/72155 (10James Forrester) p:5Unprio>3Normal s:5normal>3minor [18:20:47] TrevorParscal, okay, that makes sense. So no "save" intermediate steps [18:20:52] it "saves" automatically [18:20:59] (The model, I mean, not the actual result in the page) [18:21:27] mooeypoo: right, as the template editor also does, you should bind the change events of the inputs directly to model modification code [18:21:34] as you type, the model is being updated [18:21:34] * mooeypoo nods [18:21:37] like, very immediate [18:21:38] instant [18:21:40] :) [18:21:51] awesome. So I'll remove the 'save properties' button I shoved in there [18:21:52] :) [18:21:55] Thanks! [18:26:54] 3VisualEditor / 3MediaWiki integration: VisualEditor: Blue link / red link logic should descend into links inside non-transclusion generated content nodes - 10https://bugzilla.wikimedia.org/71900#c2 (10Alex Monk) Yeah. More with bug 65353 really [18:40:21] yo mooeypoo how's life [18:40:33] see https://he.wikipedia.org/wiki/%D7%A9%D7%99%D7%97%D7%AA_%D7%9E%D7%A9%D7%AA%D7%9E%D7%A9:Amire80#.D7.94.D7.A2.D7.95.D7.A8.D7.9A_.D7.94.D7.97.D7.96.D7.95.D7.AA.D7.99_-_.D7.93.D7.95.D7.92.D7.9E.D7.94_.D7.9C.D7.91.D7.A2.D7.99.D7.94 [18:40:45] [18:40:54] am I understanding this correctly? [18:41:00] James_F RoanKattouw TrevorParscal how do we push forward page status indicators? [18:41:07] did somebody actually try to use the Insert key in VisualEditor? [18:41:18] INSERT?! [18:41:36] edsanders: merge all the things? [18:41:41] DEPLOY DEPLOY DEPLOY! [18:41:45] I'm on board [18:42:11] i thought you were "off" and not to be trusted [18:42:19] aharoni, what's the problem [18:42:22] it's the week-end afterall [18:42:32] I've only had one glass of wine [18:42:54] (and some Tequila) [18:43:05] RoanKattouw: https://www.mediawiki.org/wiki/Wikimedia_Engineering/2014-15_Goals#Editing [18:43:25] edsanders: Is wine and tequila a good mix? [18:43:45] nothing and tequila is a good mix [18:44:05] HA. [18:44:19] but we've have a Californian guest and I don't want to point out how uncivilised she is [18:44:41] lol [18:44:55] who is this person? [18:45:10] And which part of California, that we might judge them? [18:45:12] is this person from L.A.? [18:45:43] medical student, somewhere outside of SF, wine country [18:45:44] if they claim to be from "SoCal" you should see them out quickly [18:45:50] nice [18:46:03] via New York though [18:48:58] aharoni, heya, uh, I'm looking at the previous version, and trying to see if I can replicate, but this is really not making sense [18:49:37] aharoni, I can also see Danny did another change to a work [18:49:46] aharoni, word, rather.. see https://he.wikipedia.org/w/index.php?title=%D7%92%27%D7%95%D7%9F_%D7%93%D7%90%D7%93%D7%9C%D7%99%2C_%D7%93%D7%95%D7%9B%D7%A1_%D7%A0%D7%95%D7%A8%D7%AA%27%D7%9E%D7%91%D7%A8%D7%9C%D7%A0%D7%93&diff=16066636&oldid=15937545 [18:49:53] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Can't cut or (sometimes) paste in Firefox - 10https://bugzilla.wikimedia.org/72164 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major a:3Ed Sanders [18:50:01] edsanders: somebody had trouble fixing a typo in Hebrew in VE, and mentioned that he was using Insert. [18:50:20] I really don't understand what's the problem, because fixing that typo is totally possible in VE. [18:50:26] aharoni, was he, though? He said he tried and it *acted* like he had the 'insert' button on, but it wasn't on [18:50:42] He also managed to fix another typo as you can see from the above diff. Hmm. [18:50:56] Oh. [18:51:10] (03PS1) 10Alex Monk: Don't try to check page existence of external links in transclusion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167249 [18:51:24] You know... What do you call the default behavior for Insert - on or off? :) [18:51:57] (03CR) 10Jforrester: [C: 032] Don't try to check page existence of external links in transclusion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167249 (owner: 10Alex Monk) [18:52:00] ha, I don't even have an insert key in this keyboard. Hmm [18:52:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: Blue link / red link logic should descend into links inside non-transclusion generated content nodes - 10https://bugzilla.wikimedia.org/71900#c3 (10Alex Monk) (Uploaded Gerrit change 167249 for that) [18:52:10] James_F, before tests have even completed? :p [18:52:18] When I first used an IBM-PC compatible computer in 1991, the default in MS-DOS and GW-BASIC was the opposite from the default today. [18:52:29] Krenair: I have faith. :-) [18:52:30] Dark ages. [18:52:44] aharoni: Overwrite for ever! [18:52:47] The tests run in response to +2 anyway :) [18:53:02] Krenair: Also, whoops. :-) [18:53:13] Apparently it's common enough to +2 new patchsets immediately (due to rebases / commit message changes I imagine) that Timo went through the trouble of deduplicating those jobs [18:53:24] (03Merged) 10jenkins-bot: Don't try to check page existence of external links in transclusion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167249 (owner: 10Alex Monk) [18:53:48] aharoni, ok I just tested in my other laptop where I do have insert -- i can fix, change with and without insert. The second I click "insert" the cursor turns into a selection of the next character so you can see you're overriding things. Turn 'insert' off, and it comes back to being a cursor. [18:53:58] I can't see what the problem was, especially since he *managed* to change a word [18:57:24] yeah, it's weird. [18:57:46] aharoni, what's HotCat ? [18:59:14] RoanKattouw, TrevorParscal can we review it then, I don't want it to go stale and end up on the scrap heap https://gerrit.wikimedia.org/r/#/c/162609/ [18:59:39] agreed [19:03:51] I just wanted to update https://www.mediawiki.org/w/index.php?title=Help:Preferences&veaction=edit but the combination of visual editor and the new translation features make it almost impossible to understand what's goin on there without to look at the source [19:04:17] i.e. Honestly, I don't understand that syntax in the wikitext editor... [19:05:10] physikerwelt__, yeah we're no where near tranlsate extensions support unfortunately [19:06:15] There's a problem with wikitext?? [19:07:34] physikerwelt__: I can understand that from a developer point of view... but from a user point of view I guess it would be better to disable one or the other extension... Especially since there are some information that sould be stored an updated by normal users [19:07:57] (03CR) 10Esanders: Fix contextChange events from annotations (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167217 (https://bugzilla.wikimedia.org/72152) (owner: 10Esanders) [19:08:12] We're not about to disable VisualEditor on mediawiki.org if that's what you're asking for. [19:08:40] nor the Translate extension [19:08:51] Hmm, I thought we were going to disable visual editing of translated pages? [19:08:57] Or do we just show a warning instead? [19:09:16] edsanders: So what you're saying is we shouldn't be hiding the context while the user is dragging? [19:09:22] cause that's what that code was doing AIUI [19:09:30] Just a warning. [19:09:42] RoanKattouw, it wasn't actually working I think [19:09:49] "You are editing a translatable page. Editing these in VisualEditor is not yet officially supported." edit notice [19:09:53] OK, cool [19:10:05] I did not request that... but I think it scares away people from editing mediawiki.org [19:10:16] Translate or VisualEditor? :) [19:10:16] * edsanders verifies in master [19:10:23] edsanders: Also did you see the other, non-inline comment? [19:10:30] RoanKattouw, you could do that, but there's not much point [19:10:31] "But now you're not emitting contextChange when the insertionAnnotations change." [19:10:54] it's an unlikely situation (making a selection inside a link) and either behaviour is acceptable [19:11:02] Ahm [19:11:08] What about starting a pre-annotation by pressing Ctrl+B? [19:11:16] Surely we need to emit contextChange when that happens to update toolbar state? [19:11:58] it appears to work [19:12:23] not sure how... [19:12:29] Yeah now I wonder why [19:12:43] (03PS2) 10Jforrester: [BrowserTest] Fix class name for ve-ui-contextMenuWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167190 (owner: 10Esanders) [19:13:26] RoanKattouw_away, ctrl+b wouldn't trigger setSelection anyway [19:13:43] so whatever makes it work is not via this function [19:14:11] setInsertionAnnotations always emits a contextChange [19:15:18] Aaah of course [19:17:36] (03PS3) 10Esanders: Close inspector on model select [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167229 [19:17:38] (03PS3) 10Esanders: Fix broken node change detection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167228 [19:18:26] (03CR) 10Esanders: Fix broken node change detection (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167228 (owner: 10Esanders) [19:18:39] RoanKattouw: Also https://www.mediawiki.org/wiki/VisualEditor/Adding_instrumentation_how-to [19:19:04] Yeah I saw [19:19:12] I need to do some server-side instrumentation though [19:19:25] (03CR) 10Esanders: "setInsertionAnnotations emits its own contextChange" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167217 (https://bugzilla.wikimedia.org/72152) (owner: 10Esanders) [19:19:38] 3OOjs UI: OOjs UI: search results widget bottom aligns and doesn't scroll in MediaWiki theme - 10https://bugzilla.wikimedia.org/71889 (10James Forrester) 5PATC>3RESO/FIX [19:19:41] Also that doesn't really discuss the EventLogging side of things, only the VE side of things. Which I know how that works because I wrote it [19:20:17] (03CR) 10Catrope: [C: 032] Fix contextChange events from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167217 (https://bugzilla.wikimedia.org/72152) (owner: 10Esanders) [19:20:23] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/164590/ [19:21:06] (03CR) 10Esanders: Fix shift-click select on links in Chrome (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167188 (owner: 10Esanders) [19:21:13] (03PS2) 10Esanders: Fix shift-click select on links in Chrome [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167188 [19:21:46] RoanKattouw, new ve.Range( selectionBefore.getRange().from, newSelection.getRange().to ) [19:21:49] note the different selections [19:21:51] (03CR) 10jenkins-bot: [V: 04-1] Close inspector on model select [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167229 (owner: 10Esanders) [19:21:54] edsanders: Ooooh [19:21:58] I'm blind [19:22:06] (03CR) 10Catrope: [C: 032] Fix broken node change detection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167228 (owner: 10Esanders) [19:22:39] I swear Karma times out 50% of the time [19:22:53] (03CR) 10Catrope: [C: 032] Fix shift-click select on links in Chrome [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167188 (owner: 10Esanders) [19:22:58] edsanders: Locally? [19:23:20] https://integration.wikimedia.org/ci/job/VisualEditor-npm/3659/console [19:23:21] (03CR) 10Catrope: [C: 032] Close inspector on model select [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167229 (owner: 10Esanders) [19:23:38] "Disconnected (1 times), because no message in 10000 ms." [19:24:03] (03Merged) 10jenkins-bot: Fix contextChange events from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167217 (https://bugzilla.wikimedia.org/72152) (owner: 10Esanders) [19:24:27] (03Merged) 10jenkins-bot: Fix broken node change detection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167228 (owner: 10Esanders) [19:25:08] (03Merged) 10jenkins-bot: Fix shift-click select on links in Chrome [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167188 (owner: 10Esanders) [19:25:17] (03Merged) 10jenkins-bot: Close inspector on model select [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167229 (owner: 10Esanders) [19:30:00] RoanKattouw, Did you see the difference between toJSON and stringify? [19:30:21] Doesn't stringify call toJSON if it exists? [19:30:58] it returns a string though [19:31:04] which makes for horrible diffs [19:31:13] Oooooh [19:31:16] toJSON returns a plain object [19:31:21] That's ... understandable but horrible [19:31:23] then magic happens [19:32:25] (03CR) 10Catrope: Get rid of toHashObject from ranges/selection (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167052 (owner: 10Esanders) [19:32:32] (03CR) 10Catrope: [C: 032] Get rid of toHashObject from ranges/selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167052 (owner: 10Esanders) [19:33:23] 3VisualEditor / 3Data Model: VisualEditor: Selection starting on a tooled item (e.g. link) always shows the context menu - 10https://bugzilla.wikimedia.org/72152 (10James Forrester) 5PATC>3RESO/FIX [19:34:15] (03Merged) 10jenkins-bot: Get rid of toHashObject from ranges/selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167052 (owner: 10Esanders) [19:35:24] TrevorParscal: https://gerrit.wikimedia.org/r/166952 [19:36:50] (03CR) 10Cmcmahon: [C: 032] "Thanks!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167190 (owner: 10Esanders) [19:38:20] (03Merged) 10jenkins-bot: [BrowserTest] Fix class name for ve-ui-contextMenuWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167190 (owner: 10Esanders) [19:42:26] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (99ec31d9b9) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167035 (owner: 10Jforrester) [19:43:11] (03PS1) 10Catrope: Update VE core submodule to master (0190744) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167298 [19:44:33] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (0190744) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167298 (owner: 10Catrope) [19:44:38] (03PS7) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [19:44:54] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (99ec31d9b9) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167035 (owner: 10Jforrester) [19:45:54] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Clicking the link tool or Ctrl+K keyboard command on an auto-numbered external link triggers the wrong (annotation) link inspector - 10https://bugzilla.wikimedia.org/72150#c9 (10James Forrester) 5REOP>3ASSI p:5Unprio>3Normal a:3Alex Monk Ah... [19:49:12] (03Merged) 10jenkins-bot: Update VE core submodule to master (0190744) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167298 (owner: 10Catrope) [19:58:23] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] “Uncaught TypeError: undefined is not a function” when Citation dialog opens - 10https://bugzilla.wikimedia.org/71997#c4 (10etonkovidova) Verified the fix on test2 [20:00:07] Just been looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=72150#c9 [20:00:42] I notice that if you select one of these unlabelled external links, the link tool in the toolbar is not selected [20:01:05] Hmm [20:01:13] Krenair: Is that because the tool is just the annotation tool, and when we split it we didn't cope? Or is it a new regression? [20:01:14] Krenair: Does that link tool have external link nodes in its .static.modelClasses? [20:01:14] Does VE core know they're links? [20:01:35] ve.ui.MWLinkNodeInspector.static.modelClasses = [ ve.dm.MWNumberedExternalLinkNode ]; [20:01:41] yes [20:01:42] Right [20:01:48] But that's the inspector [20:01:49] What about the tool [20:02:16] ve.ui.MWLinkNodeInspectorTool.static.modelClasses = [ ve.dm.MWNumberedExternalLinkNode ]; [20:02:25] Ooooh [20:02:30] But that's LinkNodeInspector tool [20:02:38] So that's the issue, I guess. [20:02:40] And there's a different LinkAnnotationInspectorTool, because Bartosz split them? [20:02:42] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (0d358b167a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167304 [20:02:56] did i? [20:03:01] Months ago. [20:03:12] TrevorParscal: BTW, https://gist.github.com/catrope/70117fa069eb7cec314a is what we were talking about yesterday [20:03:12] i messed with these a bit, but i don't think either is my brainchild [20:03:20] Throwing it in a gist so I can delete it locally [20:03:38] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (0d358b167a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167304 (owner: 10Jforrester) [20:03:39] thanks [20:03:53] TrevorParscal: around? question: we do plan to switch OOUI PHP to use PHP traits instead of our own mixins when we move WMF to PHP 5.4+? [20:04:14] MatmaRex: Yes. [20:04:33] good. then i can add two "HACK"-s with clear conscience :) [20:05:32] (i'm cooking ButtonInputWidget) [20:06:11] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (0d358b167a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167304 (owner: 10Jforrester) [20:08:25] MatmaRex: yes, ideally [20:08:43] but the mixin system I've used so far has actually worked out better than I expected [20:08:55] and it's kept the APIs strikingly similar [20:09:46] RoanKattouw, why are numbered/unlabelled external links separate like this? [20:11:49] Krenair: Because their DOM representation is [20:11:54] So, empty link [20:12:01] That can't be an annotation because an annotation applies to text [20:19:05] TrevorParscal: yeah, i also feel it's better than i expected [20:19:23] 3VisualEditor / 3Editing Tools: VisualEditor: MWLink nodes inside sub-editor dialogs appear as zero-width - 10https://bugzilla.wikimedia.org/71652#c4 (10etonkovidova) Verified the fix on test2. [20:19:41] php is surprisingly flexible, heh. my only gripe is the isset()s everywhere, gotta wait for php 7 to fix that ;) [20:20:48] TrevorParscal: also i just noticed, PHP OoUiButtonWidget is missing like, almost all of ButtonWidget's functionality :D i'm going to fix that now too [20:21:42] (03PS1) 10Bartosz Dziewoński: Introduce ButtonInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/167306 [20:21:59] TrevorParscal: i changed my mind, we probably want support in that. ^ [20:22:48] (03PS1) 10Bartosz Dziewoński: FormLayout: Accept HTML form attributes as config options [oojs/ui] - 10https://gerrit.wikimedia.org/r/167307 [20:23:29] (03CR) 10jenkins-bot: [V: 04-1] Introduce ButtonInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/167306 (owner: 10Bartosz Dziewoński) [20:25:09] (03CR) 10jenkins-bot: [V: 04-1] FormLayout: Accept HTML form attributes as config options [oojs/ui] - 10https://gerrit.wikimedia.org/r/167307 (owner: 10Bartosz Dziewoński) [20:31:39] (03PS2) 10Bartosz Dziewoński: FormLayout: Accept HTML form attributes as config options [oojs/ui] - 10https://gerrit.wikimedia.org/r/167307 [20:31:41] (03PS2) 10Bartosz Dziewoński: Introduce ButtonInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/167306 [20:37:16] MatmaRex: https://gerrit.wikimedia.org/r/#/c/167306/ is looking good! [20:37:21] excellent work man [20:37:40] ugh, I have like a million lines of code to review - why must you be so productive!!!? [20:38:03] heh [20:38:28] this is what happened when we added ed to the team... code review backlog! [20:54:20] James_F, bullet point indentation is broken :( [20:54:54] Eloquence: Eurgh. ryasmeen – could you investigate and file a bug? edsanders|away is probably best to deal. [20:55:05] ryasmeen: Possibly more than one bug. [20:55:17] Eloquence: MW.org or elsewhere? [20:55:18] (03PS3) 10Bartosz Dziewoński: FormLayout: Accept HTML form attributes as config options [oojs/ui] - 10https://gerrit.wikimedia.org/r/167307 [20:55:20] (03PS1) 10Bartosz Dziewoński: TextInputWidget: Allow changing 'type' attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/167311 [20:56:18] James_F: we already have one:https://bugzilla.wikimedia.org/show_bug.cgi?id=71134 [20:57:00] That's not saying indentation is broken, just that it works differently [20:57:49] (03PS1) 10Bartosz Dziewoński: FlaggedElement: Fix PHP notice [oojs/ui] - 10https://gerrit.wikimedia.org/r/167312 [20:57:49] Eloquence: How is bullet indentation broken? bug 71134 is related to indentation but if that's what you saw I'm not sure you would have said "broken", maybe "works strangely" [20:58:09] (03PS2) 10Bartosz Dziewoński: FlaggedElement: Fix PHP notice [oojs/ui] - 10https://gerrit.wikimedia.org/r/167312 [20:59:45] RoanKattouw: Yeah, i dont see it broken anywhere as in "not working at all" , but yes we do have that working differently bug [21:00:21] OK [21:00:31] James said he was able to reproduce something by pasting a list and then trying to indent it or something [21:00:35] But he's running away to a meeting [21:00:48] okay [21:15:59] ryassmen: 71997 - after is verified in Betalabs and test2 - should we change the bug status? [21:16:53] etonkovidova: No keep it as Resolved-Fixed , we change the status to Verified-Fixed once it is verified in the production environment [21:17:11] right - thx! [21:17:15] sure [21:26:42] (03CR) 10Catrope: [C: 032] Only validate required template params after blur [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167226 (https://bugzilla.wikimedia.org/72096) (owner: 10Alex Monk) [21:28:21] (03Merged) 10jenkins-bot: Only validate required template params after blur [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167226 (https://bugzilla.wikimedia.org/72096) (owner: 10Alex Monk) [21:36:43] RoanKattouw: i'm trying to find instances in your VE code where you're emitting the events to understand how it's broken a little better [21:37:00] and reading the history and any changes that happened to mw track, EL, and your own code [21:37:09] purpose: maybe save you a patch [21:37:13] Cool [21:37:20] OK well so I'll explain the flow to you, in the present [21:37:22] I don't know about the past [21:37:46] Things call ve.track(), for instance ve.init.mw.ViewPageTarget.init.js line 345 calls it when the user clicks the edit link [21:38:08] right, that's what i was going to ask [21:38:13] ve.track (in ve.track.js) is similar to mw.track (it's actually what Ori copied to write mw.track) in that it buffers events and allows after-the-fact subscription [21:38:14] i was also looking at line 36 there [21:38:16] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FVisualEditor/d0cc8074c22239fbe769ac939ea824ddfd68686e/modules%2Fve-mw%2Finit%2Ftargets%2Fve.init.mw.ViewPageTarget.init.js#L37 [21:38:27] Then yeah, line 36 is the subscriber to ve.track [21:38:31] It forwards to mw.track [21:38:34] gotcha [21:38:43] That's stupid, it should probably just use EL directly at that point [21:38:46] so when it does that call, the event coming in would be on the "ve" namespace right? [21:38:57] well - not if that subscriber really does gain you performance [21:39:03] Yeah so it calls mw.track( 've.' + topic, data ) [21:39:17] so wouldn't the fix just be to change 've.' to 'event.'? [21:39:25] assuming "topic" is a proper schema name? [21:39:26] Then after some buffering and what not on the mw.track side, the event logging subscriber gets its hands on it and does God knows what to the topic [21:39:37] no - it's not that bad :) [21:39:44] The topic may be a proper schema name, let me check [21:39:45] it only manipulates the whole name [21:39:52] Edit appears to be [21:39:53] to strip out the "namespace" which is what comes before the first . [21:40:05] ok, cool [21:40:25] However we do have this.track() calls in ve.init.mw.TargetEvents.js as well [21:40:26] yeah, this doesn't look too horrible: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FEventLogging/77afd299e01986eb21c1b30b1ee5b2cc3d880bb8/modules%2Fext.eventLogging.subscriber.js#L34 [21:40:33] i saw that [21:40:38] And it calls things like this.track( 'behavior.saveDialogClose', { duration: ve.now() - this.timings.saveWorkflowBegin } ); [21:40:39] so what's this.track vs. ve.track? [21:40:52] this.track is just a wrapper around ve.track [21:41:00] that adds a magic property [21:41:03] data.targetName [21:41:14] to the data passed in the second arg? [21:41:23] But the point is, this results in calls like mw.track( 've.behavior.saveDialogClose', { ... } ) [21:41:25] Yes [21:41:31] right [21:41:45] Which looks like a sane enough topic until you realize it's going to go looking for a schema called Behavior.saveDialogClose [21:41:45] but is this trying to do anything else other than call event logging? [21:41:51] like, are you relying on these events internally? [21:41:55] No, we're not [21:42:07] It's supposed to be a generic thing that you can hook any event logging thing into, EL or otherwise [21:42:29] So we could either change our topic names to be EL-compliant, or have our subscriber map the topics [21:42:35] I would be equally happy to do either [21:42:51] gotcha, ok, so obviously it's up to you guys how you fix it, but it seems to me that calling mw.track with an event name of the form 'event.<>' should work fine [21:43:05] Provided the EL subscriber is fixed, ytes [21:43:08] yes [21:43:13] and that we should do anyway [21:43:16] Yup [21:43:36] Once that's fixed I *believe* the two events in ve.init.mw.ViewPageTarget.init.js should start working again immediately [21:43:59] Because Schema:Edit actually exists; I'll test locally, though, to see if there are any other weird things happening there [21:44:07] there is indeed a schema called Edit [21:44:11] Also "Edit" is a horrible name for a schema and we should really come up with a better one [21:44:15] :D [21:44:49] As for the others, there are various VisualEditor* schemas which seem to correspond to things we track, but that just aren't hooked up correctly, so I'll work on that too [21:46:53] Oh cool, Schema:Edit actually contains a bunch of nice stuff [21:46:58] yes, i'm assuming you're looking at the (amazing) cirrus search results: https://meta.wikimedia.org/w/index.php?title=Special%3ASearch&profile=advanced&search=VisualEditor&fulltext=Search&ns470=1&profile=advanced [21:47:10] Yeah [21:47:31] kcool, well, i'll lurk in here in case you want to bounce ideas off. but this has been a nice trip into VE and EL code :) [21:47:38] Yeah, thanks man [21:47:53] Now I just need to get this stuff running locally and then get like 15 different events working [21:48:16] Also, re fixing the subscriber, was Matt going to do that? [21:48:28] It looks like it'll be simple [21:48:28] i'll catch up with him [21:48:31] OK cool [21:56:43] milimetric: OOOOH the subscriber only subscribes to 'event' [21:56:54] So the topic has to start with 'event' or the subscriber doesn't even get it [21:57:16] yes [21:57:27] as far as i can tell [21:57:29] And yes now I see the .. bug [21:57:40] but - i've been looking at this for like 2 minutes :) [22:05:21] RoanKattouw: now the other thing is I see you passing things like { action: 'section-edit-link-click' } to the event [22:05:25] etonkovidova: You can file a bug under Wikimedia Labs about Betalabs [22:05:30] but the other properties in the Edit schema, how do those get filled [22:05:30] milimetric: Yeah [22:05:36] Excellent question :P [22:05:44] That's one of my next things, is actually using those [22:05:52] Because I'm pretty sure none of that stuff is populated [22:05:53] But good news! [22:06:08] :) /me loves good news [22:06:13] It doesn't matter that we're not populating the wikitext vs visualeditor property, because we're not tracking this AT ALL for the wikitext editor anyway! [22:06:14] :( [22:06:28] oh that was totally a Futurama good news [22:07:43] i wonder if other teams have best practices for how to populate various schemas [22:07:44] ryasmeen: it could be just temporary [22:07:55] like maybe a set of defaults by schema Id [22:19:38] milimetric: What's REALLY weird though, is that there is data that looks exactly like my events, with my namespacing and everything (like ve.behavior.saveDialogClose) in Graphite [22:19:43] And I have NO IDEA how it gets there [22:19:59] Is there a subscriber somewhere that subscribes to all and dumps it all into Graphite somehow? [22:20:07] that could very well be [22:20:15] like - something that just dumps all stuff from mw.track [22:20:19] brb - gotta pick up wife [22:20:50] Yeah but I haven't been able to find it yet [22:22:51] (03CR) 10Trevor Parscal: [C: 032] Use relative positioning for category popups, move out of overlay [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166952 (owner: 10Catrope) [22:24:42] (03CR) 10jenkins-bot: [V: 04-1] Use relative positioning for category popups, move out of overlay [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166952 (owner: 10Catrope) [22:24:56] (03CR) 10Trevor Parscal: [C: 032] FlaggedElement: Fix PHP notice [oojs/ui] - 10https://gerrit.wikimedia.org/r/167312 (owner: 10Bartosz Dziewoński) [22:25:03] AHA [22:25:11] ext.wikimediaEvents.ve.js [22:25:57] hello etonkovidova, nice to see you here! [22:26:19] It goes into the TimingData schema [22:26:22] ( milimetric ---^^ ) [22:26:27] But ... not on all wikis? [22:26:41] That's also how the other mw.track() calls end up being collected [22:27:34] For deprecated stuff and what not [22:27:36] (03Merged) 10jenkins-bot: FlaggedElement: Fix PHP notice [oojs/ui] - 10https://gerrit.wikimedia.org/r/167312 (owner: 10Bartosz Dziewoński) [22:27:53] chrismcmahon and everybody else: thanks! [22:28:56] etonkovidova: I think ryasmeen|Away mentioned it, but if you are free Wednesday evening, this talk at WMF should be interesting: http://www.meetup.com/wikimedia-tech/events/207856222/ [22:29:52] OK I need to figure out who's using what and write it all up [22:30:06] James_F, the bug I saw was different -- tabbing inserted a new bullet, but at the same level. can't repro now so may be an edge condition. will keep an eye out [22:30:20] It'll be an entertaining overview of how everything works differently and it's all insane and/or broken in one way or another [22:30:28] Eloquence: I think I can. [22:30:33] (03CR) 10Trevor Parscal: "Don't feel bad about using inline-table. Table display is actually awesome, and people feel like they are doing something wrong only becau" [oojs/ui] - 10https://gerrit.wikimedia.org/r/166627 (https://bugzilla.wikimedia.org/71855) (owner: 10Bartosz Dziewoński) [22:30:42] chrismcmahon: yes, I know about it and I am going to attend [22:31:10] etonkovidova: great! I'll be in SF Tue/Wed/Thu next week also [22:31:42] (03CR) 10Trevor Parscal: [C: 032] ListToolGroup: Implement collapsible/expandable tools [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) (owner: 10Bartosz Dziewoński) [22:31:46] chrismcmahon: that's great! [22:31:54] (03CR) 10Trevor Parscal: [C: 032] Introduce ButtonInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/167306 (owner: 10Bartosz Dziewoński) [22:34:07] (03Merged) 10jenkins-bot: ListToolGroup: Implement collapsible/expandable tools [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) (owner: 10Bartosz Dziewoński) [22:34:10] (03Merged) 10jenkins-bot: Introduce ButtonInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/167306 (owner: 10Bartosz Dziewoński) [22:36:37] (03CR) 10Bartosz Dziewoński: "That's true and I agree wholeheartedly, but the CSS here is still a pretty complicated solution that will probably become tech debt in the" [oojs/ui] - 10https://gerrit.wikimedia.org/r/166627 (https://bugzilla.wikimedia.org/71855) (owner: 10Bartosz Dziewoński) [22:37:09] MatmaRex: Un-WIP it? :-) [22:37:27] It's not too late. [22:38:00] * James_F grins. [22:38:04] James_F: the padding nastiness i did there also means that all menu lists will now be 2.5em wider than they need to be [22:38:07] 3OOjs UI: OOjs UI: Toolbar menus should be collapsible - 10https://bugzilla.wikimedia.org/70568 (10James Forrester) 5PATC>3RESO/FIX [22:38:44] it's all just ugh [22:38:55] MatmaRex: Eh. Yeah, that's a little janky. Toolbar menu lists only, though? [22:39:34] i'm not even entirely sure, popup menus probably too [22:40:27] if we need the feature now, then we can go ahead with it (it still needs the VE fixes for font size) [22:41:14] if it can wait, then i'd like to think about it some more [22:41:42] (03PS1) 10Jforrester: Only validate required template params after blur [extensions/VisualEditor] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167334 (https://bugzilla.wikimedia.org/72096) [22:42:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] Red border is appearing around required parameters before focus moves away - 10https://bugzilla.wikimedia.org/72096 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3High [22:42:21] MatmaRex: It's not hugely urgent, don't rush. [22:42:30] MatmaRex: But in the next couple of weeks would be good. [22:42:38] James_F: by the way, our VE code is the only known user of OOUI toolbars? [22:42:43] MatmaRex: Yes. [22:42:50] (i wonder how bold i can be if i need to rejigger some stuff) [22:43:05] MatmaRex: But we still should mark it as [BREAKING CHANGE] even if we already know the fix and have made it. [22:43:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf4] Red border is appearing around required parameters before focus moves away - 10https://bugzilla.wikimedia.org/72096 (10James Forrester) [22:43:23] aye [22:44:08] 3VisualEditor / 3Editing Tools: VisualEditor: The icons for Media and Comment are appearing a bit darker in Insert menu - 10https://bugzilla.wikimedia.org/71541#c5 (10etonkovidova) checked in BetaLabs and test2. [22:45:02] (03CR) 10Bartosz Dziewoński: "(The padding nastiness I did here also means that all menu lists will now be 2.5em wider than they need to be. This really could use more " [oojs/ui] - 10https://gerrit.wikimedia.org/r/166627 (https://bugzilla.wikimedia.org/71855) (owner: 10Bartosz Dziewoński) [22:45:17] TrevorParscal: [22:45:21] * MediaWiki: https://gerrit.wikimedia.org/r/162609 [22:45:21] * VisualEditor extension: https://gerrit.wikimedia.org/r/163563 [22:45:21] * Vector skin: https://gerrit.wikimedia.org/r/162610 [22:45:23] * MonoBook skin: https://gerrit.wikimedia.org/r/163558 [22:45:25] * Modern skin: https://gerrit.wikimedia.org/r/163559 [22:45:27] * Cologne Blue skin: https://gerrit.wikimedia.org/r/163560 [22:52:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: Create a meta dialog panel for setting page status indicators - 10https://bugzilla.wikimedia.org/72199 (10James Forrester) p:5Unprio>3Low [22:52:23] 3MediaWiki / 3Page editing: Provide a way to set page meta-data flags ("featured article", "protected", etc.), configure which ones are available for a wiki, and display icons indicating these statuses - 10https://bugzilla.wikimedia.org/23796 (10James Forrester) [22:52:24] 3VisualEditor / 3MediaWiki integration: VisualEditor: Create a meta dialog panel for setting page status indicators - 10https://bugzilla.wikimedia.org/72199 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3None Not quite sure how this will work (and how it will know which ones are available), but thi... [22:53:29] (03CR) 10Catrope: [C: 032] "Go go Jenkins" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166952 (owner: 10Catrope) [22:54:53] (03PS1) 10Jforrester: Apply mw-body-content styles to SurfaceWidget [extensions/VisualEditor] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167335 (https://bugzilla.wikimedia.org/71652) [22:57:36] (03Merged) 10jenkins-bot: Use relative positioning for category popups, move out of overlay [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166952 (owner: 10Catrope) [22:58:20] (03PS1) 10Jforrester: Fix broken node change detection [VisualEditor/VisualEditor] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167336 [23:00:51] (03PS1) 10Jforrester: Fix clipboardData API path on copy [VisualEditor/VisualEditor] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167338 [23:01:24] (03PS1) 10Jforrester: Fix clipboardData API path on copy [VisualEditor/VisualEditor] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167339 [23:02:18] (03CR) 10jenkins-bot: [V: 04-1] Fix clipboardData API path on copy [VisualEditor/VisualEditor] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167338 (owner: 10Jforrester) [23:07:27] RoanKattouw: http://he.wikipedia.beta.wmflabs.org/wiki/%D7%9C%D7%95%D7%90%D7%99_%D7%93%D7%94_%D7%A1%D7%9F-%D7%96%27%D7%95%D7%A1%D7%98?uselang=he&veaction=edit [23:07:27] RoanKattouw: Change-Id: I9ae783576699836c6c209179e4474356090abc7b [23:09:29] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167338 (owner: 10Jforrester) [23:13:14] RoanKattouw: Ic872eff6e00c8a5c5d6cc397a87454d42898a476 to wmf3 [23:13:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] Cannot open the dropdown box for "Use this group" field inside References List dialog box - 10https://bugzilla.wikimedia.org/72100 (10James Forrester) [23:13:55] RoanKattouw: I9ae783576699836c6c209179e4474356090abc7b also to wmf3 [23:16:54] TrevorP|Away: ? [23:17:02] legoktm: He left for the day, what's up? [23:17:16] RoanKattouw: https://gerrit.wikimedia.org/r/#/q/status:open+-branch:master+owner:%22Jforrester+%253Cjforrester%2540wikimedia.org%253E%22,n,z [23:17:26] (03CR) 10Catrope: [C: 032] Apply mw-body-content styles to SurfaceWidget [extensions/VisualEditor] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167335 (https://bugzilla.wikimedia.org/71652) (owner: 10Jforrester) [23:17:30] (03CR) 10Catrope: [C: 032] Only validate required template params after blur [extensions/VisualEditor] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167334 (https://bugzilla.wikimedia.org/72096) (owner: 10Jforrester) [23:17:34] RoanKattouw: he merged https://gerrit.wikimedia.org/r/165952, but I don't think it was ready for merging [23:17:36] (03CR) 10Catrope: [C: 032] Fix clipboardData API path on copy [VisualEditor/VisualEditor] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167338 (owner: 10Jforrester) [23:17:41] (03CR) 10Catrope: [C: 032] Fix clipboardData API path on copy [VisualEditor/VisualEditor] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167339 (owner: 10Jforrester) [23:17:48] (03CR) 10Catrope: [C: 032] Fix broken node change detection [VisualEditor/VisualEditor] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167336 (owner: 10Jforrester) [23:17:48] and he left a comment indicating that there was an issue with it, so I'm a bit confused. [23:18:05] legoktm: His comment was about exposing it in skins. [23:18:17] legoktm: Oh, sorry, different patch. [23:18:30] No I don't think he meant to merge that at all [23:18:35] I sat next to him while he wrote this [23:18:41] It was meant to be a -1 [23:18:56] Ah, whoops. [23:19:00] Revert time? [23:19:02] legoktm: Would you mind cleaning this mess up? [23:19:07] sure [23:19:08] (03Merged) 10jenkins-bot: Apply mw-body-content styles to SurfaceWidget [extensions/VisualEditor] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167335 (https://bugzilla.wikimedia.org/71652) (owner: 10Jforrester) [23:19:12] (03Merged) 10jenkins-bot: Only validate required template params after blur [extensions/VisualEditor] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167334 (https://bugzilla.wikimedia.org/72096) (owner: 10Jforrester) [23:19:18] (03CR) 10jenkins-bot: [V: 04-1] Fix clipboardData API path on copy [VisualEditor/VisualEditor] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167338 (owner: 10Jforrester) [23:19:20] (I am in the middle of cleaning up a different mess right now, otherwise I would do it [23:20:22] (03CR) 10Catrope: [V: 032] Fix clipboardData API path on copy [VisualEditor/VisualEditor] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167338 (owner: 10Jforrester) [23:21:13] (03Merged) 10jenkins-bot: Fix clipboardData API path on copy [VisualEditor/VisualEditor] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167339 (owner: 10Jforrester) [23:21:17] :) [23:22:08] (03Merged) 10jenkins-bot: Fix broken node change detection [VisualEditor/VisualEditor] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167336 (owner: 10Jforrester) [23:30:25] (03PS1) 10Jforrester: Update VE core submodule to 1.25wmf3 cherry-pick (227d7df) [extensions/VisualEditor] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167343 [23:34:33] James_F: https://gerrit.wikimedia.org/r/167344 [23:34:49] James_F: Amend that to include VE submodule change once I merge your core pull-through? [23:34:51] (03PS1) 10Jforrester: Update VE core submodule to 1.25wmf4 cherry-pick (7b70172) [extensions/VisualEditor] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167345 [23:34:59] (03CR) 10Catrope: [C: 032] Update VE core submodule to 1.25wmf3 cherry-pick (227d7df) [extensions/VisualEditor] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167343 (owner: 10Jforrester) [23:36:41] (03Merged) 10jenkins-bot: Update VE core submodule to 1.25wmf3 cherry-pick (227d7df) [extensions/VisualEditor] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167343 (owner: 10Jforrester) [23:49:22] (03PS1) 10Bartosz Dziewoński: OOUI PHP: Unbreak ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/167348 [23:49:52] RoanKattouw: https://gerrit.wikimedia.org/r/167347 is the re-build. [23:52:17] (03CR) 10GOIII: [C: 031] WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox)