[03:26:10] 3VisualEditor:
added when creating a level 2 heading - 10https://bugzilla.wikimedia.org/72246 (10Stöger Florian D. M.) 3NEW p:3Unprio s:3normal a:3None See [[w:Special:Diff/630280487]]: I tried exchanging the "References" and "See also" sections. Therefore, I had to delete the References section a... [04:01:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] In Firefox, Cursor is appearing in Read mode at the end of the document after saving a page and after discarding the current edit in Firefox - 10https://bugzilla.wikimedia.org/71852 (10James Forrester) [09:38:52] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf4] Math/Formula inspector is not working again - 10https://bugzilla.wikimedia.org/72136#c5 (10Ed Sanders) Parsoid is now returning a full HTML document for parsefragment, instead of just a body tag. This affects all generated content and although t... [09:52:40] (03PS1) 10Esanders: Make padding between popup and container configurable [oojs/ui] - 10https://gerrit.wikimedia.org/r/167541 [10:20:25] 3VisualEditor: [Regression] External links are rendered as red links now - 10https://bugzilla.wikimedia.org/72251 (10Raimond Spekking) 3NEW p:3Unprio s:3normal a:3None Since a few days all externl links, incl. coordinates in the upper right edge, are rendered as red links on dewiki. I guess this is a r... [10:47:17] (03PS1) 10Esanders: Fix anchor positioning on popups [oojs/ui] - 10https://gerrit.wikimedia.org/r/167543 [12:11:22] (03PS33) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [12:11:24] (03PS35) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [12:11:26] (03PS6) 10Esanders: [BREAKING CHANGE] Allow tools to specify which selection types they support [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166768 [12:11:28] (03PS8) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [12:11:30] (03PS38) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [12:11:32] (03PS7) 10Esanders: Fix getAnnotationsFromRange when starting with an element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166773 [12:11:34] (03PS1) 10Esanders: Handle paste events on the paste target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167557 [12:11:36] (03PS1) 10Esanders: Fix scroll jumping in Firefox when pasting at end of line [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167558 [12:11:38] (03PS1) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 [12:14:23] (03CR) 10jenkins-bot: [V: 04-1] Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [12:15:25] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Allow tools to specify which selection types they support [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166768 (owner: 10Esanders) [12:42:37] (03PS2) 10Mvolz: maps added as allowed value in TD JSON root [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 [13:46:04] (03PS1) 10QChris: DO NOT MERGE. Test for commit bug\n\nThis is a test for bug 53662.\n [extensions/Cite] (sandbox/qchris/master) - 10https://gerrit.wikimedia.org/r/167573 [13:48:02] (03Abandoned) 10QChris: DO NOT MERGE. Test for commit bug\n\nThis is a test for bug 53662.\n [extensions/Cite] (sandbox/qchris/master) - 10https://gerrit.wikimedia.org/r/167573 (owner: 10QChris) [14:09:54] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf4]: Applying link to an image gives "Uncaught TypeError: Cannot read property 'from' of null ", inspector stays open. - 10https://bugzilla.wikimedia.org/72258 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16818 --> htt... [14:10:07] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf4]: Applying link to an image gives "Uncaught TypeError: Cannot read property 'from' of null ", inspector stays open. - 10https://bugzilla.wikimedia.org/72258 (10Ritu Swain) [14:20:37] Hello [14:21:18] Is there a technical overview of how the editor is built and what parts it is made of? Or some introduction to development [14:24:37] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf4]- "Uncaught TypeError: Cannot read property 'resolve' of null" when applying language annotation to an image, the inspector remains open. - 10https://bugzilla.wikimedia.org/72259 (10Ritu Swain) [14:24:39] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf4]- "Uncaught TypeError: Cannot read property 'resolve' of null" when applying language annotation to an image, the inspector remains open. - 10https://bugzilla.wikimedia.org/72259 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created atta... [14:33:08] * James_F waves. [14:51:27] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (db065e5a9f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167579 [14:54:39] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf3] External links are rendered as red links now - 10https://bugzilla.wikimedia.org/72251#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal s:5normal>3minor a:3Alex Monk This was fixed in gerrit I35c9bea4. [14:58:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] Previous Link is getting applied to the first letter on newly added text while selecting the previous link and replacing it with new text - 10https://bugzilla.wikimedia.org/72108 (10James Forrester) p:5Unprio>3High s:5normal>3major [14:59:22] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf3] Extra wide space appearing between the search box and the list of existing references inside Re-Use dialog in mobile VE - 10https://bugzilla.wikimedia.org/72110 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low [15:00:09] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf3] A small arrow is appearing in an incorrect position next to Citation icon in Mobile VE - 10https://bugzilla.wikimedia.org/72111#c1 (10James Forrester) What's wrong about the position? [15:00:38] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf3] The fields inside Citations dialog are appearing at a fixed rather than whole-screen width in mobile VE - 10https://bugzilla.wikimedia.org/72112#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low This is almost certainly because of the Med... [15:01:38] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf4] Applying link to an image gives "Uncaught TypeError: Cannot read property 'from' of null ", inspector stays open - 10https://bugzilla.wikimedia.org/72258 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal [15:02:37] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf4] "Uncaught TypeError: Cannot read property 'resolve' of null" when applying language annotation to an image, the inspector remains open - 10https://bugzilla.wikimedia.org/72259#c1 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal Almost cert... [15:03:52] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] The context menus for Categories are appearing in an incorrect position and also not closing - 10https://bugzilla.wikimedia.org/72052#c9 (10James Forrester) *** Bug 71999 has been marked as a duplicate of this bug. *** [15:03:53] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf3]:Category context menu appears out of position. - 10https://bugzilla.wikimedia.org/71999#c1 (10James Forrester) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 72052 *** [15:04:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf2] ”Uncaught Error: Cannot set attributes on closing element” on decreasing indentation, when the edit comment box is still open - 10https://bugzilla.wikimedia.org/71706 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal [15:05:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] The #contentSub should not be removed during loading phase - 10https://bugzilla.wikimedia.org/70954 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3trivia [15:34:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf4] Math/Formula inspector is not displaying any updated formulæ - 10https://bugzilla.wikimedia.org/72136 (10James Forrester) [15:34:09] edsanders: https://bugzilla.wikimedia.org/show_bug.cgi?id=72136 <-- can we fix this quickly? [15:35:04] yes, but depends what Parsoid team say [15:35:34] :-( [15:38:07] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression pre-wmf4] Selecting and replacing a link by typing clears all annotations from DM, but CE thinks it's still a link for the first character - 10https://bugzilla.wikimedia.org/72108#c1 (10James Forrester) Unicorning-related? [15:41:11] looks like a Parsoid bug from my end, as we give them a body=1 param [15:41:23] 3VisualEditor / 3ContentEditable: VisualEditor:[Regression wmf4] Red color for internal link and background color for Language annotation is not applied to text following an internal link - 10https://bugzilla.wikimedia.org/72261 (10Ritu Swain) [15:41:25] 3VisualEditor / 3ContentEditable: VisualEditor:[Regression wmf4] Red color for internal link and background color for Language annotation is not applied to text following an internal link - 10https://bugzilla.wikimedia.org/72261 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 168... [15:41:40] It's a pretty disruptive bug. [15:41:54] Did you file an upstream with Parsoid? [15:43:17] re-assigned to them, subbu is looking [15:43:52] 3VisualEditor / 3Data Model: VisualEditor: [Regression?] Save button stays disabled after inserting a character in some cases - 10https://bugzilla.wikimedia.org/71732#c6 (10James Forrester) 5ASSI>3RESO/FIX This appears to now be fixed in wmf3. [15:43:53] OK. [15:45:09] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] In Firefox, Cursor is appearing in Read mode at the end of the document after saving a page and after discarding the current edit in Firefox - 10https://bugzilla.wikimedia.org/71852#c1 (10James Forrester) 5ASSI>3RESO/FIX This now seems fixed... [15:46:09] James_F, edsanders, how serious is this? can it wait for later in the day? [15:47:30] subbu: It's painful, but it only affects formula editing AFAICT. It can wait for lataer. [15:48:03] we have a deploy today .. should be able to squeeze this in then. [15:48:38] Thanks. [15:49:22] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] When the inspector is still open for a selected node, after placing the cursor in a different position, inspector flickers there - 10https://bugzilla.wikimedia.org/71151#c4 (10James Forrester) This appears to now be fixed (testing on enwiki); ca... [15:50:53] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] For every Math expression, it is not appearing on CE when its gets evaluated for the first time - 10https://bugzilla.wikimedia.org/71829#c1 (10James Forrester) Probably the same cause as bug 71852. [15:50:53] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] In Firefox, Cursor is appearing in Read mode at the end of the document after saving a page and after discarding the current edit in Firefox - 10https://bugzilla.wikimedia.org/71852 (10James Forrester) [16:08:54] 3VisualEditor / 3ContentEditable: VisualEditor:[Regression wmf4] Red color for internal link and background color for Language annotation is not applied to text following an internal link - 10https://bugzilla.wikimedia.org/72261#c1 (10Ritu Swain) (In reply to Ritu Swain from comment #0) > Created attachment... [16:30:29] James_F, subbu it also affects templates, inserting and <meta> tags into the document [16:30:44] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13467242 [16:30:44] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13467253 [16:30:44] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13467388 [16:30:44] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13467428 [16:30:44] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13467430 [16:30:45] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13467448 [16:30:45] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66323123 [16:30:46] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40328240 [16:30:46] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40328309 [16:30:46] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40328470 [16:30:47] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40328489 [16:30:47] <wm-ve-needcheck> Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40328815 [16:34:06] <James_F> edsanders: Argh. [16:34:34] <edsanders> I don't think they make it through to the wikitext [16:37:26] <edsanders> In other news, table cell merge/un-merge works [16:37:48] <edsanders> was easier than I thought [16:38:17] <edsanders> Maybe we should have a table toolbar for cell actions [16:38:34] <edsanders> merge, header [16:38:39] <edsanders> maybe tableDelete [16:42:08] <edsanders> also http://i.imgur.com/UePEGlW.png , left or right? James_F [16:42:21] <James_F> edsanders: Right. [16:42:24] <edsanders> (Google or OpenOffice) [16:42:38] <James_F> edsanders: And the reverse for split. [16:43:05] <James_F> edsanders: And we said we'd have a context menu for table selections, didn't we? [16:43:41] <edsanders> we did - but reconsidering [16:43:51] <James_F> I don't want a second toolbar. [16:43:55] <James_F> In Mobile it'd be a third one. [16:44:00] <James_F> Way too busy. [16:44:05] <edsanders> it would be inline [16:44:14] <edsanders> and we could make it autohide [16:44:21] <edsanders> instead of just auto-disable [16:44:38] <edsanders> just a dropdown menu, like insert [16:45:03] <wikibugs> 3VisualEditor / 3Initialisation: VisualEditor: From a cold start using debug=true, there's no indication VE is loading for a few seconds; move some init stuff further up? - 10https://bugzilla.wikimedia.org/65453#c2 (10Sucheta Ghoshal) The change in the URL with veaction=edit happens late, too. Spinner appear... [16:45:21] <James_F> Inline toolbar? [16:45:49] <edsanders> (neither Google nor OO have a separate icon for split, the just have the merge icon selected - I'm inclined to agree, we don't have a stateful icons anywhere else) [16:46:18] <edsanders> (e.g. we don't have an un-strikethrough icon) [16:46:34] <edsanders> not a whole toolbar [16:46:37] <edsanders> just a toolgroup [16:46:43] <edsanders> in the main toolbar [16:46:50] <edsanders> like the bullet list group, or insert [16:46:58] <grrrit-wm1> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167389 (owner: 10Mvolz) [16:47:19] <James_F> OK, yeah, stateful merge makes sense. [16:47:24] <edsanders> for extra de-clutter it could be auto-hidden [16:48:12] <grrrit-wm1> (03CR) 10Siebrand: [C: 04-1] "de.json has one entry too many added." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [16:56:04] <edsanders> James_F, the other benefit of using the toolbar is we get all the updateState stuff for free [16:56:16] <edsanders> instead of having to do a bunch of work to OOUI [16:56:44] <edsanders> the toolbar listens to contextChange and changes tool state accordingly (selected / disabled) [16:56:57] <edsanders> we have no mechanism for doing that in context menus at the moment [16:57:35] <edsanders> in fact the whole way we create "tools" inside context menus is a bit hacky [16:57:45] <edsanders> maybe TrevorP|Away has thoughts on that [17:06:20] <maurodec> Hello! Can anyone help me get started developing VisualEditor? What is some must read documentation on how to get started? [17:13:38] <MatmaRex> um, hi. sorry i'm late. :) [17:21:16] <edsanders> maurodec, hi [17:22:27] <maurodec> edsanders hello [17:23:05] <edsanders> have you done any MediaWiki development? [17:23:52] <maurodec> Nope [17:23:59] <maurodec> I need to start form the very very basics [17:24:15] <maurodec> I tried following http://www.mediawiki.org/wiki/VisualEditor_gadgets but it wasn't helpful at all. [17:25:09] <wikibugs> 3VisualEditor / 3Editing Tools: ZH IME input sometimes inserts latin characters - 10https://bugzilla.wikimedia.org/72268 (10Trevor (Wikia)) 3NEW p:3Unprio s:3normal a:3None From a Wikia staff member working on ZH communities: Basically we need to type Pinyin (English words) first to select Chinese c... [17:36:14] <James_F> maurodec: https://www.mediawiki.org/wiki/VisualEditor/Software is a reasonable start, but it's not hugely friendly. [17:36:41] <maurodec> Thanks, I will definitely check it out. Anything else I should know? [17:40:14] <James_F> maurodec: Ask questions here. ;-) We're friendly. [17:40:21] <maurodec> Thanks! [17:46:49] <grrrit-wm1> (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (db065e5a9f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167579 (owner: 10Jforrester) [17:49:07] <grrrit-wm1> (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (db065e5a9f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167579 (owner: 10Jforrester) [18:00:53] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor:[Regression wmf4] Language context menu appears outside the Content Editor - 10https://bugzilla.wikimedia.org/72273 (10Ritu Swain) [18:00:54] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor:[Regression wmf4] Language context menu appears outside the Content Editor - 10https://bugzilla.wikimedia.org/72273 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16821 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16821&act... [18:04:09] <edsanders> maurodec, I'm told vagrant is a good way to get up and running with MediaWiki [18:04:19] <edsanders> someone else here may know more about it [18:04:30] <edsanders> it claims to have a role for VisualEditor too [18:04:44] <edsanders> https://www.mediawiki.org/wiki/MediaWiki-Vagrant [18:08:44] <James_F> Oh, yeah, Vagrant is great. [18:09:34] <grrrit-wm1> (03PS2) 10Catrope: Fix scroll jumping in Firefox when pasting at end of line [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167558 (owner: 10Esanders) [18:12:05] <grrrit-wm1> (03CR) 10Catrope: [C: 032] Fix scroll jumping in Firefox when pasting at end of line [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167558 (owner: 10Esanders) [18:17:41] <grrrit-wm1> (03PS34) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [18:17:43] <grrrit-wm1> (03PS36) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [18:17:45] <grrrit-wm1> (03PS2) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 [18:17:47] <grrrit-wm1> (03PS3) 10Esanders: Fix scroll jumping in Firefox when pasting at end of line [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167558 [18:17:49] <grrrit-wm1> (03PS2) 10Esanders: Handle paste events on the paste target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167557 [18:17:51] <grrrit-wm1> (03PS7) 10Esanders: [BREAKING CHANGE] Allow tools to specify which selection types they support [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166768 [18:17:53] <grrrit-wm1> (03PS9) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [18:17:55] <grrrit-wm1> (03PS39) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [18:17:57] <grrrit-wm1> (03PS8) 10Esanders: Fix getAnnotationsFromRange when starting with an element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166773 [18:17:59] <grrrit-wm1> (03PS1) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [18:18:09] <grrrit-wm1> (03CR) 10Esanders: [C: 032] "Per Catrope, PS3 is a rebase" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167558 (owner: 10Esanders) [18:19:30] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [18:23:33] <grrrit-wm1> (03Merged) 10jenkins-bot: Fix scroll jumping in Firefox when pasting at end of line [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167558 (owner: 10Esanders) [18:23:41] <grrrit-wm1> (03CR) 10Catrope: [C: 032] Stage an empty comment node when inserting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167387 (owner: 10Esanders) [18:25:14] <grrrit-wm1> (03CR) 10Catrope: [C: 032] Fix height calculation in fragment inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167446 (owner: 10Esanders) [18:26:19] <grrrit-wm1> (03Merged) 10jenkins-bot: Stage an empty comment node when inserting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167387 (owner: 10Esanders) [18:27:14] <grrrit-wm1> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders) [18:27:34] <grrrit-wm1> (03Merged) 10jenkins-bot: Fix height calculation in fragment inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167446 (owner: 10Esanders) [18:27:51] <grrrit-wm1> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Per PS38 comment." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [18:30:16] <grrrit-wm1> (03CR) 10Catrope: [C: 032] Stage a space when inserting a special character [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167388 (owner: 10Esanders) [18:32:08] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] In Firefox, Cursor is appearing in Read mode at the end of the document after saving a page and after discarding the current edit in Firefox - 10https://bugzilla.wikimedia.org/71852#c3 (10James Forrester) 5REOP>3RESO/FIX Gah. [18:32:08] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] In Firefox, Cursor is appearing in Read mode at the end of the document after saving a page and after discarding the current edit in Firefox - 10https://bugzilla.wikimedia.org/71852#c2 (10James Forrester) 5RESO/FIX>3REOP Different issue. [18:32:12] <grrrit-wm1> (03Merged) 10jenkins-bot: Stage a space when inserting a special character [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167388 (owner: 10Esanders) [18:33:20] <grrrit-wm1> (03CR) 10Catrope: [C: 04-1] Remove insertion insepctor class (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167443 (owner: 10Esanders) [18:34:11] <grrrit-wm1> (03CR) 10Catrope: Remove insertion insepctor class (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167443 (owner: 10Esanders) [18:35:16] <grrrit-wm1> (03CR) 10Catrope: [C: 032] Handle paste events on the paste target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167557 (owner: 10Esanders) [18:37:01] <grrrit-wm1> (03Merged) 10jenkins-bot: Handle paste events on the paste target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167557 (owner: 10Esanders) [18:37:08] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it - 10https://bugzilla.wikimedia.org/71131#c16 (10Rummana Yasmeen) Verified the fix in test2 and Betalabs [18:42:54] <wikibugs> 3VisualEditor / 3Mobile: VisualEditor Mobile: The down-arrow is not appearing in against the cite menu's icon in Mobile VE - 10https://bugzilla.wikimedia.org/72111#c2 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal a:3Trevor Parscal The icon was actually missing before; reversing the logic of... [18:43:07] <wikibugs> 3VisualEditor / 3Mobile: VisualEditor Mobile: The down-arrow is not appearing in against the cite menu's icon in Mobile VE - 10https://bugzilla.wikimedia.org/72111 (10James Forrester) [18:46:42] <grrrit-wm1> (03PS1) 10Catrope: Update VE core submodule to master (51a919d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167636 [18:49:37] <grrrit-wm1> (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (51a919d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167636 (owner: 10Catrope) [18:50:43] <RoanKattouw> Krenair: What is that issue that you mentioned in the standup that I said Trevor should work on? [18:51:10] <grrrit-wm1> (03Merged) 10jenkins-bot: Update VE core submodule to master (51a919d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167636 (owner: 10Catrope) [18:51:10] <RoanKattouw> Krenair: nm I remember [18:51:12] <RoanKattouw> Link node inspector [18:51:38] <Krenair> https://bugzilla.wikimedia.org/show_bug.cgi?id=72150 [19:05:57] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] In Firefox, Cursor is appearing in Read mode at the end of the document after saving a page and after discarding the current edit in Firefox - 10https://bugzilla.wikimedia.org/71852#c4 (10Rummana Yasmeen) 5RESO/FIX>3REOP This issue is not fi... [19:09:38] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] When the inspector is still open for a selected node, after placing the cursor in a different position, inspector flickers there - 10https://bugzilla.wikimedia.org/71151#c6 (10Rummana Yasmeen) Nope, still happening in en.wiki,test2 and Betalabs [19:09:38] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] When the inspector is still open for a selected node, after placing the cursor in a different position, inspector flickers there - 10https://bugzilla.wikimedia.org/71151#c5 (10Rummana Yasmeen) Nope, still happening in en.wiki,test2 and Betalabs [19:10:04] <grrrit-wm1> (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Allow tools to specify which selection types they support [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166768 (owner: 10Esanders) [19:11:45] <kaity> hey James_F [19:11:54] <grrrit-wm1> (03Merged) 10jenkins-bot: [BREAKING CHANGE] Allow tools to specify which selection types they support [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166768 (owner: 10Esanders) [19:13:07] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Chrome lets you place the cursor either side of a Table (eww) and VE doesn't correct this - 10https://bugzilla.wikimedia.org/71560 (10James Forrester) [19:13:23] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: Make it easier to see that there is an option to paste as plain text - 10https://bugzilla.wikimedia.org/71612 (10James Forrester) [19:16:38] <grrrit-wm1> (03PS2) 10Jforrester: Update VE core submodule to master (f8a563a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166776 (owner: 10Esanders) [19:17:27] <grrrit-wm1> (03PS3) 10Esanders: Remove insertion inspector class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167443 [19:17:41] <grrrit-wm1> (03CR) 10Catrope: [C: 032] Update VE core submodule to master (f8a563a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166776 (owner: 10Esanders) [19:18:15] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (f8a563a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166776 (owner: 10Esanders) [19:18:29] <James_F> Bah. [19:18:52] <James_F> edsanders: ^^^ qunit failures from your breaking change. [19:19:18] <grrrit-wm1> (03Merged) 10jenkins-bot: Update VE core submodule to master (f8a563a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166776 (owner: 10Esanders) [19:19:32] <James_F> Oh. But it passed the second time? [19:19:34] * James_F sighs. [19:21:04] <grrrit-wm1> (03PS2) 10Esanders: Add button to debug bar to enable input debugging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167366 [19:21:23] <edsanders> lots of timeouts, like I said [19:21:32] <Krenair> The easy way to fix https://bugzilla.wikimedia.org/show_bug.cgi?id=53774 is to introduce a wgRelevantArticleId JS global [19:21:39] <Krenair> Except then, we have a new JS global. Sigh. [19:25:25] <grrrit-wm1> (03PS2) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [19:25:28] <grrrit-wm1> (03PS3) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 [19:25:30] <grrrit-wm1> (03PS10) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [19:25:32] <grrrit-wm1> (03PS40) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [19:27:18] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [19:28:10] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders) [19:29:16] <grrrit-wm1> (03PS3) 10Esanders: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 [19:29:18] <grrrit-wm1> (03PS4) 10Esanders: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 [19:29:20] <grrrit-wm1> (03PS11) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [19:29:22] <grrrit-wm1> (03PS41) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [19:30:39] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [19:30:54] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [19:31:12] <grrrit-wm1> (03PS1) 10Jforrester: doc: Use wildcards for Desktop/Mobile …Context and …Surface for simplicity of extension [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167643 [19:31:17] <James_F> edsanders: Could you +2 ^^^^ so that I can merge your MW-mobile change? [19:31:56] <grrrit-wm1> (03CR) 10Esanders: [C: 032] doc: Use wildcards for Desktop/Mobile …Context and …Surface for simplicity of extension [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167643 (owner: 10Jforrester) [19:32:13] <James_F> Thanks! [19:32:30] <edsanders> didn't I already have that change in 165992? [19:32:40] <James_F> You did it in MW. [19:32:47] <James_F> But MW's one is built from VE-core. [19:32:50] <James_F> So it was V-1'ing. [19:32:57] <James_F> This way it'll Just Work™. [19:32:59] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123093 (https://bugzilla.wikimedia.org/51260) (owner: 10Alex Monk) [19:33:16] <James_F> (You can't touch .docs/categories.json in VE-MW manually.) [19:33:55] <grrrit-wm1> (03Merged) 10jenkins-bot: doc: Use wildcards for Desktop/Mobile …Context and …Surface for simplicity of extension [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167643 (owner: 10Jforrester) [19:37:46] <grrrit-wm1> (03PS4) 10Jforrester: Update VE core submodule to master (e556440) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165992 (owner: 10Esanders) [19:39:54] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf4] Red border is appearing around required parameters before focus moves away - 10https://bugzilla.wikimedia.org/72096#c6 (10Rummana Yasmeen) Verified the fix in Betalabs [19:40:17] <grrrit-wm1> (03CR) 10Jforrester: [C: 032] Remove MW-specific mobile hack from core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165993 (owner: 10Esanders) [19:40:31] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [19:41:49] <grrrit-wm1> (03Merged) 10jenkins-bot: Remove MW-specific mobile hack from core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165993 (owner: 10Esanders) [19:44:47] <grrrit-wm1> (03PS5) 10Jforrester: Update VE core submodule to master (db78bdd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165992 (owner: 10Esanders) [19:46:45] <grrrit-wm1> (03CR) 10Jforrester: [C: 031] Update VE core submodule to master (db78bdd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165992 (owner: 10Esanders) [19:55:38] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Inserting a comment before the last word in a Language (RTL direction)Text moves the word to the start of the line. - 10https://bugzilla.wikimedia.org/71320#c2 (10etonkovidova) 5UNCO>3NEW Confirmed in test2 and Betalabs in Chrome. [19:57:03] <mooeypoo> eh, verifying -- if I have MyObj.static.someFunc = function () {...} and I refer to it from within the same class; do I use MyObj.static.someFunc or this.constructor.static.someFunc ? the second is preferable I think? [19:58:23] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor:[Regression wmf4] Language context menu appears outside the Content Editor - 10https://bugzilla.wikimedia.org/72273#c1 (10etonkovidova) 5UNCO>3NEW Confirmed test2 and Betalabs on Chrome. [20:04:03] <edsanders> mooeypoo, this. [20:04:17] <edsanders> then inheritence works [20:05:16] <mooeypoo> Inheritence even in static methods? [20:05:41] <mooeypoo> Static methods always confuse me somewhat when it comes to inheritance [20:05:56] <James_F> Welcome to JS. :-) [20:06:37] <mooeypoo> haha yeah, hence verifying. [20:10:12] <Daniel_01> Hi, there. Hi mooeypoo :) [20:10:23] <PolK> Hi all [20:11:06] <mooeypoo> heya Daniel_01 [20:11:12] <mooeypoo> how are you today? [20:11:56] <Daniel_01> Great! Polk is one of my techfriends I mentioned yesterday. [20:12:30] <Daniel_01> It is him who installed and set our Wikimedia package. [20:12:30] <Krenair> Hey [20:12:35] <Krenair> MediaWiki [20:12:40] <PolK> Hi, mooeypoo [20:12:42] <Daniel_01> Ha ha ha, sorry [20:13:05] <Daniel_01> I always have to think before writing it [20:13:27] <mooeypoo> Heya PolK [20:13:32] <PolK> mooeypoo: we have a little wiki and we need a server to run VE. Do you know how much visitors are good for a 256 MB RAM server, please? [20:13:56] <PolK> the maximum it holds, i mean [20:14:29] <Daniel_01> We need to know the minimum we will need to start with it. [20:14:40] <mooeypoo> That would probably be a Parsoid question, and I have to admit I'm not sure. I think gwicke said that it should be okay for a small wiki yesterday, though. [20:15:20] <Daniel_01> I think he mentioned it. [20:16:01] <RoanKattouw> mooeypoo: Re static inheritance: it's common for something like Tool to have a function that accesses .static.requiresRange but for subclasses to override .static.requiresRange, so accessing Tool.static.requiresRange won't "work" [20:16:26] <Krenair> http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki-visualeditor/20141019.txt [20:16:35] <RoanKattouw> But this.constructor is "look at the current *object* and determine which class it's an instance of", which will be LinkTool or something, so you can use this.constructor.static for working static inheritance [20:18:01] <mooeypoo> oh, that makes sense [20:18:15] <mooeypoo> well, my classes will likely not be inherited, but I might as well do this right. [20:18:51] <RoanKattouw> Yeah that's what we prefer to do [20:20:13] <mooeypoo> gwicke, RoanKattouw, Krenair any way to estimate how many visitors per x time a 256MB RAM server could handle with Parsoid? I know gwicke mentioned it should be okay for small wikis, but PolK and Daniel_01 are looking to see which option fits their wiki the best, and i'm not sure about this answer. [20:20:15] <James_F> ryasmeen: https://bugzilla.wikimedia.org/show_bug.cgi?id=72136 and https://bugzilla.wikimedia.org/show_bug.cgi?id=71829 fixed I think. [20:21:03] <ryasmeen> ok James_F:Verifying them [20:21:07] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] For every Math expression, it is not appearing on CE when its gets evaluated for the first time - 10https://bugzilla.wikimedia.org/71829#c2 (10James Forrester) 5ASSI>3RESO/FIX Now appears to work in production. Success. [20:21:11] <James_F> ryasmeen: Thanks. [20:21:49] <grrrit-wm1> (03CR) 10Catrope: [C: 032] Update VE core submodule to master (db78bdd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165992 (owner: 10Esanders) [20:23:26] <grrrit-wm1> (03Merged) 10jenkins-bot: Update VE core submodule to master (db78bdd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/165992 (owner: 10Esanders) [20:23:29] <Daniel_01> Tks, mooeypoo, we are following [20:25:37] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] For every Math expression, it is not appearing on CE when its gets evaluated for the first time - 10https://bugzilla.wikimedia.org/71829#c3 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in Betalabs, test2 and en.wiki [20:27:30] <James_F> mooeypoo: Are you/they putting a cache in front on Parsoid? [20:27:47] <James_F> mooeypoo: If so you can be quite mean with memory, but then you need memory for the cache. :-) [20:31:12] <Daniel_01> Hi James_F, tks. [20:31:43] <Daniel_01> But would you recommend more than that? [20:32:10] <Daniel_01> We expect the wiki to grow, slowly, but steadily [20:34:08] <mooeypoo> You can always upgrade later, of course. [20:34:20] <mooeypoo> If the wiki gets big, I imagine you will have to, but the question is how fast and how big. [20:34:22] <Daniel_01> But, so far, we are small and I think that the better way to do it is to start moving to the new server in its basic configuration [20:34:41] <Daniel_01> Yeap, that is the answer for now [20:35:05] <James_F> Daniel_01: For the whole of the Wikimedia world (~50000 edits a day) we only have 24 Parsoid boxes with (?)2GB of RAM and 2 Varnish boxes in front of them with (?)4GB of RAM. [20:35:15] <James_F> (The box counts are right; the RAM might be off.) [20:36:17] <PolK> Oh, that's such a parameter! Then 256 MB Ram should be enough by now [20:36:23] <James_F> Probabl. [20:36:25] <James_F> +y [20:36:43] <Daniel_01> Good news. The smaller, the cheaper. [20:36:44] <cscott> edsanders is the oojs-gui guru, right? [20:36:49] <PolK> Great, Daniel_01 [20:36:57] <James_F> cscott: MatmaRex more so. [20:37:03] <cscott> does anyone want to help me migrate Extension:Collection to oojs ? [20:37:05] <James_F> cscott: But edsanders is awesome too. :-) [20:37:11] <James_F> cscott: Unlikely. ;-) [20:37:28] <cscott> in particular i'd like to replace the wonky NN% status text with a proper progress bar; I'm hoping that oojs has such a widget. [20:37:50] <RoanKattouw> There is not currently a progress bar widget in OOUI I think [20:37:51] <cscott> i figure i might as well replace the button styles & etc at the same time, if oojs-gui is the new hotness [20:37:54] <RoanKattouw> But there should probably be one [20:38:00] <James_F> Yeah. [20:38:08] <cscott> why do i end up creating work for myself? [20:38:28] <cscott> now i have to learn how to write new widgets for ooui [20:38:54] <Daniel_01> Thank you guys, that will keep us busy for a while now. Time to go back to work. I'm really happy to have arrived here. [20:38:59] <cscott> is there a mailing list, or a good starting point for ooui stuff? [20:39:09] <James_F> cscott: Not really. Wikitech-l is where it's at right now. [20:39:15] <edsanders> cscott, we don't have a progress bar [20:39:17] <James_F> cscott: Maybe we should create a front-end mailing list. [20:39:20] <PolK> Thanks a lot, guys [20:39:31] <James_F> Daniel_01, PolK: Good luck! Ask if you have any questions. [20:39:41] * cscott is a little sad [20:39:47] <Daniel_01> :) [20:39:49] <PolK> Sure! thanks James_F [20:40:12] <edsanders> most of our widgets at this point are interactive [20:40:49] <cscott> edsanders: oh, i can make it interactive. if you keep clicking on it the thermometer goes up faster. [20:40:55] <RoanKattouw> haha [20:40:58] <cscott> isn't that how all thermometers work [20:41:02] <James_F> :-) [20:41:05] <cscott> you haven't tried clicking on them, have you [20:41:05] <edsanders> technically [20:41:14] <edsanders> you'd generate heat [20:41:22] <James_F> cscott: Also think about how to make it work in PHP. [20:42:12] <cscott> <? exit(1337); ?> [20:42:50] <cscott> which is actually a meta-error, as exit codes can only go up to 255.... [20:43:18] <James_F> Fine. <? exit("1337"); ?> [20:43:22] <James_F> String => true => 1. [20:43:25] <cscott> man sez: "The exit() function causes normal process termination and the value of status & 0377 is returned to the parent (see wait(2))." which has to be one of the most gratuitous uses of octal i've seen recently. [20:43:39] <James_F> Gosh. [20:43:45] <RoanKattouw> haha [20:44:11] <cscott> exitcode>>8 is used for the process id of the child exiting. [20:44:14] <cscott> fun fact [20:44:22] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf4] Language context menu appears outside the Content Editor - 10https://bugzilla.wikimedia.org/72273 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low [20:44:52] <cscott> oh wait, yeah, there is some signal information jammed in there as well. it's a struct masquerading as an int. [20:46:04] <cscott> anyway, Extension:Collection currently uses jquery to auto-update the page and re-fetch the current progress percentage, which is renders as text. [20:47:17] <cscott> presumably that's the PHP fallback patch, more or less. but we can still render it as a progress bar instead of as text. [20:47:22] <RoanKattouw> cscott: Oh man, I know you've already met David but you have no idea how well you guys would get along [20:47:29] <RoanKattouw> I have faith in this language variant project :) [20:47:46] <edsanders> cscott, well a progress bar element/widget would be straightforward [20:48:26] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders) [20:48:32] <cscott> RoanKattouw: wait, which david are you talking about? and which variant project? [20:48:53] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf4] Annotation continuation is working but the browser styles it wrongly (i.e., not at all) - 10https://bugzilla.wikimedia.org/72261 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal s:5normal>3major a:3Roan Kattouw [20:49:33] <edsanders> cscott, the problem with coming here for answers is that the longer we stay the more work we dump on you [20:49:53] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: [Regression pre-wmf4] Selecting and replacing a link by typing clears all annotations from DM, but CE thinks it's still a link for the first character - 10https://bugzilla.wikimedia.org/72108 (10James Forrester) [20:49:53] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf4] Annotation continuation is working but the browser styles it wrongly (i.e., not at all) - 10https://bugzilla.wikimedia.org/72261 (10James Forrester) [20:50:04] <edsanders> chan - and the VE language variant support, I assume? [20:50:07] <cscott> James_F: http://php.net/manual/en/function.exit.php says exit("1337") actually prints the string and then exits. [20:50:24] <James_F> cscott: Eurgh. exit((int)"1337")? [20:50:30] <edsanders> cscott, I can make you a progress bar widget if that's what you need [20:51:17] <cscott> James_F: yeah, that does what you want. oddly, the php manual doesn't say what actual exit code is used if you exit("1337"). Is that a successful exit, or not successful? [20:51:25] <cscott> edsanders: i would appreciate that a lot. [20:51:26] * James_F grins. [20:52:21] <cscott> if you type `exit("1337") ;` at `php --interactive` it prints "1337" and then *does not exit*. [20:52:25] <cscott> i guess that's a feature? [20:53:13] <cscott> `php -r 'exit("1337");'` exits with exitcode 0. just in case you were wondering. success! [20:54:20] <cscott> and `php -r 'exit((int)"1337");'` exits silently with exitcode 57. naturally. [20:54:36] * James_F grins. [20:54:41] <James_F> Isn't PHP great? [20:55:09] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf5] The "Show Options" inside Transclusion dialog box is not bringing up the other options to add parameter/template/content - 10https://bugzilla.wikimedia.org/72278 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment... [20:55:10] <cscott> this is one of those wonderful combinations of obscure php corner cases *and* obscure unix corner cases [20:57:03] <cscott> so i learned about the obscure unix corner case the hard one once when i was too lazy to implement a proper RPC mechanism and thought I could just use the process exit code to return integer data from a child process to a parent. [20:57:50] <cscott> s/hard one/hard way/ [20:59:04] <cscott> as one does [21:00:38] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf5] The "Show Options" inside Transclusion dialog box is not bringing up the other options to add parameter/template/content - 10https://bugzilla.wikimedia.org/72278 (10James Forrester) p:5Unprio>3High s:5normal>3major [21:18:39] <wikibugs> 3VisualEditor / 3MediaWiki integration: VisualEditor: Suggest case insensitive results when searching for categories to add - 10https://bugzilla.wikimedia.org/57302#c2 (10Alex Monk) This would require a change to the MW core API module... [21:21:44] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/141367 (https://bugzilla.wikimedia.org/28789) (owner: 10TheDJ) [21:27:57] <grrrit-wm1> (03CR) 10Catrope: [C: 032] Fix getAnnotationsFromRange when starting with an element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166773 (owner: 10Esanders) [21:28:47] <mooeypoo> hm i'm running into issues with my tests now. [21:28:56] <mooeypoo> oh... I know why. Ha. [21:29:04] <mooeypoo> Might help if I get oojs as a dependency. [21:29:31] <James_F> mooeypoo: You mean oojs-ui? [21:29:37] <wikibugs> 3VisualEditor / 3MediaWiki integration: VisualEditor: Suggest case insensitive results when searching for categories to add - 10https://bugzilla.wikimedia.org/57302#c3 (10James Forrester) (In reply to Alex Monk from comment #2) > This would require a change to the MW core API module... Hence "low". :-) [21:29:43] <mooeypoo> James_F, no, the data module only needs oojs [21:29:47] <mooeypoo> the dialog requires oojs-ui [21:29:49] <grrrit-wm1> (03Merged) 10jenkins-bot: Fix getAnnotationsFromRange when starting with an element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166773 (owner: 10Esanders) [21:29:52] <mooeypoo> and the tests are on the data module only [21:30:25] <mooeypoo> Which raises another question actually... when I load both in the actual extension, I assume that resourceManager knows not to load oojs twice? [21:30:26] <James_F> mooeypoo: oojs-ui pulls in oojs though. [21:30:31] <James_F> mooeypoo: Yeah. [21:30:35] <RoanKattouw> Yeah RL knows [21:30:41] <mooeypoo> James_F, yeah, but saying that TemplateDataModel has dependency for UI makes no sense [21:30:48] <mooeypoo> it depends on OOJS because it's a class [21:30:51] <mooeypoo> no ui in it [21:30:56] * James_F nods. [21:31:02] <mooeypoo> you could, theoretically and practically, use it with some other ui [21:31:14] <RoanKattouw> You will have data --> oojs, and interface --> oojs-ui --> oojs but that'll be deduplicated [21:31:21] * mooeypoo nods [21:31:26] <RoanKattouw> Also, presumably you have interface --> data ( -->oojs) [21:31:32] <mooeypoo> the tests load the data module only [21:31:33] <RoanKattouw> So that's a third oojs dependency :D [21:32:14] <mooeypoo> the interface wasn't dependent on the data at first when I made them completely independent, but since we're not going to allow for jQueryUI at all anymore there's no need for that [21:32:20] <mooeypoo> so I'm making both a dependency of one another [21:32:27] <mooeypoo> well, data a dependency of interface [21:32:32] <RoanKattouw> yeah [21:35:55] <grrrit-wm1> (03PS1) 10Esanders: Progress bar widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/167706 [21:36:16] <RoanKattouw> cscott: ---^^ [21:37:59] <mooeypoo> RoanKattouw, okay, we discussed using this.constructor.static.myStaticFunc in the same class, but can I also use it from *within* the *static* function? There's an issue with 'this' context in it, no? [21:38:10] <mooeypoo> that would explain the issues I'm getting, too, in the unit tests [21:38:22] <RoanKattouw> So, the weirdest thing about static functions in oojs [21:38:24] <mooeypoo> My static function is recursive [21:38:31] <RoanKattouw> is that they have a 'this' object, and it refers to .statc [21:38:38] <mooeypoo> oh [21:38:39] <RoanKattouw> So .static.foo can call .static.bar by doing this.bar() [21:38:45] <mooeypoo> ha [21:38:57] <RoanKattouw> This is weird because traditionally, in other languages, static functions do not have a 'this' at all [21:39:09] <mooeypoo> \o/ tests pass [21:39:24] <mooeypoo> Yeah, that's what was odd. But it makes sense, I guess. It works now. [21:39:29] <RoanKattouw> But in JS, if you call foo.bar.baz() then its 'this' will be foo.bar unless you're doing something fancy [21:40:00] <mooeypoo> So this isn't a specific oojs thing, it's a javascript feature? [21:40:14] <mooeypoo> "it's not a bug it's a feature" ? [21:40:50] <RoanKattouw> Krinkle|detached: So in the oojs-ui demo, the little console thingies say "(predefined: widget)" but when I try to use that it says "widget is undefined" [21:40:54] <RoanKattouw> mooeypoo: Yeah it's a JS feature [21:42:41] <RoanKattouw> Oh, classic [21:43:12] <RoanKattouw> Krinkle|detached: So that might be because 1) it's not widget but $widget, but also 2) the code falls victim to a classic scope problem [21:43:29] <RoanKattouw> hmmm, or not? [21:43:31] * RoanKattouw looks deeper [21:45:14] <edsanders> RoanKattouw, I was just trying to use that to test my new widget [21:45:21] <RoanKattouw> I think I have a fix [21:45:33] <RoanKattouw> It's broken in two different ways [21:45:53] <RoanKattouw> Yup, got it working [21:46:51] <grrrit-wm1> (03PS1) 10Catrope: Fix consoles in widgets demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/167709 [21:46:53] <grrrit-wm1> (03CR) 10Catrope: [C: 032] Progress bar widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/167706 (owner: 10Esanders) [21:49:05] <grrrit-wm1> (03CR) 10Esanders: [C: 032] Fix consoles in widgets demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/167709 (owner: 10Catrope) [21:49:39] <grrrit-wm1> (03Merged) 10jenkins-bot: Progress bar widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/167706 (owner: 10Esanders) [21:51:28] <grrrit-wm1> (03Merged) 10jenkins-bot: Fix consoles in widgets demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/167709 (owner: 10Catrope) [21:53:34] <grrrit-wm1> (03PS1) 10Legoktm: OoUiPHP: Improve theme singleton handling [oojs/ui] - 10https://gerrit.wikimedia.org/r/167711 [21:53:39] <legoktm> TrevorP|Away, MatmaRex ^ [21:54:22] <MatmaRex> legoktm: OoUiPHP? i haven't seen this capitalization variant yet. :D [21:54:32] <legoktm> I just made something up :P [21:55:10] <wikibugs> 3VisualEditor / 3Mobile: VisualEditor:[Regression pre-wmf5] Cannot open Mobile VE in Betalabs , in the console "TypeError: Cannot set property 'MWMobileContext' of undefined" appears - 10https://bugzilla.wikimedia.org/72282 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16826... [21:55:23] <grrrit-wm1> (03CR) 10Bartosz Dziewoński: [C: 031] "Not tested, looks sane." [oojs/ui] - 10https://gerrit.wikimedia.org/r/167711 (owner: 10Legoktm) [21:59:04] <grrrit-wm1> (03PS1) 10Legoktm: Add basic composer.json [oojs/ui] - 10https://gerrit.wikimedia.org/r/167712 [21:59:37] <grrrit-wm1> (03CR) 10Legoktm: "TODO: bikeshed over name, and implement autoloading" [oojs/ui] - 10https://gerrit.wikimedia.org/r/167712 (owner: 10Legoktm) [22:05:57] <grrrit-wm1> (03PS1) 10Catrope: Followup e20b47f: make .mediawiki.mobile depend on .core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167715 (https://bugzilla.wikimedia.org/72282) [22:08:08] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor:“ Uncaught Error: Unable to parse title” when entering space as a template. - 10https://bugzilla.wikimedia.org/71998#c1 (10etonkovidova) 5UNCO>3NEW Confirmed - test2, Betalabs, produciton(Chrome, FF) The following error is dispayed: Uncaught Error: Unable to... [22:24:32] <grrrit-wm1> (03PS2) 10Legoktm: Add composer.json, use it for autoloading [oojs/ui] - 10https://gerrit.wikimedia.org/r/167712 [22:33:55] <grrrit-wm1> (03CR) 10Jforrester: [C: 032] Followup e20b47f: make .mediawiki.mobile depend on .core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167715 (https://bugzilla.wikimedia.org/72282) (owner: 10Catrope) [22:34:39] <wikibugs> 3VisualEditor / 3Mobile: VisualEditor: [Regression pre-wmf5] Cannot open Mobile VE in Betalabs , in the console "TypeError: Cannot set property 'MWMobileContext' of undefined" appears - 10https://bugzilla.wikimedia.org/72282 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal a:3Roan Kattouw [22:35:52] <grrrit-wm1> (03Merged) 10jenkins-bot: Followup e20b47f: make .mediawiki.mobile depend on .core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167715 (https://bugzilla.wikimedia.org/72282) (owner: 10Catrope) [22:36:37] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: “Uncaught Error: Unable to parse title” when entering space as a template - 10https://bugzilla.wikimedia.org/71998 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [22:41:09] <wikibugs> 3OOjs UI: OOjs UI: Do not let me tab outside a dialog box in Chrome/Safari - 10https://bugzilla.wikimedia.org/67156 (10Alex Monk) a:5Alex Monk>3None [22:45:55] <Krenair> James_F, I think it was Roan(?) suggesting earlier that Trevor should look at https://bugzilla.wikimedia.org/show_bug.cgi?id=72150 [22:46:11] <James_F> Krenair: Yes? [22:48:39] <Krenair> (I'm just going through my list of assigned bugs trying to find something that isn't blocked by someone/something else) [22:50:11] <Krenair> (that doesn't involve categorywidget etc.) [22:53:23] <grrrit-wm1> (03CR) 10Alex Monk: [C: 04-1] "(there's various other things wrong here as well. I think I have a newer patch laying around somewhere, but IIRC it is not pretty)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166863 (https://bugzilla.wikimedia.org/72080) (owner: 10Alex Monk) [22:53:53] <mooey|food> TrevorParscal, is there a way to programmatically close/teardown a dialog from within the dialog? [22:53:58] <mooey|food> can't find the proper method [22:56:48] <RoanKattouw> mooeypoo: this.close( { optional data to close with } ); [22:57:19] <RoanKattouw> Krenair: Yeah I've been trying to get him to, and he's said he wants to do VE work today, but instead he's been working on preparing for a meeting and that meeting is now running long [22:57:44] <mooeypoo> oh [22:57:47] <mooeypoo> that's... simple. [22:57:48] <mooeypoo> thanks RoanKattouw [22:58:38] <TrevorParscal> mooeypoo: what Roan said [22:59:04] <TrevorParscal> we need to fix the dialog.open() issue btw [22:59:07] <RoanKattouw> Oh did you get back? [22:59:21] <TrevorParscal> Yeah, sorry was in a meeting with the new VPE [22:59:45] <RoanKattouw> Krenair: We talked and came up with an approach to fix it, and I asked Trevor to execute that plan, but then we was consumed by that meeting [22:59:51] <RoanKattouw> And now I am being consumed by meetings instead [23:00:36] <Krenair> Fun. [23:01:14] <Krenair> RoanKattouw, is the approach you discussed anything I could do? It is assigned to me... [23:06:42] <grrrit-wm1> (03CR) 10Trevor Parscal: [C: 032] OoUiPHP: Improve theme singleton handling [oojs/ui] - 10https://gerrit.wikimedia.org/r/167711 (owner: 10Legoktm) [23:07:18] <grrrit-wm1> (03CR) 10Trevor Parscal: [C: 032] Add composer.json, use it for autoloading [oojs/ui] - 10https://gerrit.wikimedia.org/r/167712 (owner: 10Legoktm) [23:07:31] <legoktm> TrevorParscal: you didn't want to bikeshed over the name? :D [23:07:57] <legoktm> if it's fine, I'll add it to packagist.org [23:08:28] <grrrit-wm1> (03Merged) 10jenkins-bot: OoUiPHP: Improve theme singleton handling [oojs/ui] - 10https://gerrit.wikimedia.org/r/167711 (owner: 10Legoktm) [23:09:31] <grrrit-wm1> (03Merged) 10jenkins-bot: Add composer.json, use it for autoloading [oojs/ui] - 10https://gerrit.wikimedia.org/r/167712 (owner: 10Legoktm) [23:14:40] <legoktm> TrevorParscal: https://packagist.org/packages/oojs/ui [23:17:23] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Clicking the link tool or Ctrl+K keyboard command on an auto-numbered external link triggers the wrong (annotation) link inspector - 10https://bugzilla.wikimedia.org/72150#c10 (10WhatamIdoing) Phatom87 says he's been using "the tab that shows up afte... [23:30:43] <mooeypoo> hm. When I go this.close(); in the dialog, I am getting an error "Uncaught TypeError: Cannot read property 'resolve' of null" referencing oojs-ui.js line #2907 [23:31:11] <mooeypoo> TrevorParscal, ^^ any idea? [23:31:13] <RoanKattouw> Oh didn't MatmaRex fix that bug eralier? [23:31:17] <mooeypoo> oh [23:31:19] <mooeypoo> maybe? [23:31:30] <mooeypoo> I didn't update my mw core in a while [23:31:59] <MatmaRex> i probably did. but that only happened if you were closing a dialog while it was still opening [23:32:06] <MatmaRex> so if you're doing that, you have a bug somewhere else anyway :D [23:32:25] <mooeypoo> I'm closing it in 'getSetupProcess' done [23:32:29] <mooeypoo> should already be open at that point [23:32:53] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: Edit comment dialog turns blank, when applying a text style, Uncaught TypeError:Cannot Read Property 'getSurface of null'. - 10https://bugzilla.wikimedia.org/69262#c4 (10etonkovidova) 5UNCO>3NEW Confirmed test2, Betalabs, production (FF, Chrome). The error i... [23:32:56] <MatmaRex> oh yeah. it isn't really open [23:33:06] <MatmaRex> try updating ooui and it should work [23:33:08] <mooeypoo> in the getSetupProcess I'm loading my data model, and that's async. in the "fail" section of it, it should close the dialog [23:33:41] <mooeypoo> MatmaRex, is it updated in mw core already? [23:33:48] <mooeypoo> 'cause that's what I'm drawing from in templatedata extension [23:33:52] <RoanKattouw> mooeypoo: Why would you do that ?! [23:34:03] <MatmaRex> no idea. [23:34:08] <RoanKattouw> Open the dialog and immediately close it again without explaination to the user? [23:34:16] <RoanKattouw> that seems like a bad idea [23:34:20] <mooeypoo> There is an explanation to the user [23:34:22] <mooeypoo> it's on the main page [23:34:32] <mooeypoo> oh, I guess I could put it in th edialog itself. Of course. [23:34:34] <TrevorParscal> mooeypoo: you figure that out, or should I still look? [23:34:56] <mooeypoo> TrevorParscal, I think we're good. It's either a bug that was solved, or I should actually make the dialog tell the user about the problem. [23:34:58] <TrevorParscal> mooeypoo: you still need to return a process that closes the dialog [23:35:18] <mooeypoo> which... I don't know why the hell I didn't thnk about that. I was going with "migrate that jquery ui" bit a bit too far [23:35:21] <TrevorParscal> basically, in a get*Process method, don't actually do anything, just return processes that do things [23:35:26] <mooeypoo> Oh [23:35:37] <TrevorParscal> or you can get into hot water [23:36:37] <mooeypoo> I see [23:37:33] <grrrit-wm1> (03CR) 10Legoktm: "woot: https://packagist.org/packages/oojs/ui" [oojs/ui] - 10https://gerrit.wikimedia.org/r/167712 (owner: 10Legoktm) [23:37:54] <mooeypoo> TrevorParscal, okay, that makes sense. I think RoanKattouw's point, however, makes this irrelevant :\ I should really display the error message in the dialog, not exit the dialog and display it in the main screen. [23:40:39] <TrevorParscal> yeah [23:40:58] <TrevorParscal> and if you are using getActionProcess, there is error handling (see the demo) [23:43:14] <mooeypoo> gotcha [23:43:54] <TrevorParscal> and pay attention to the difference between recoverable and non-recoverable errors [23:44:04] <TrevorParscal> when constructing your OO.ui.Error object [23:48:31] * mooeypoo nods